[KYUUBI #5877][FOLLOWUP] Add spark output mode to better support PySpark notebook

:mag: Description
Issue References 🔗

This pull request fixes #
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklists
📝 Author Self Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] This patch was not authored or co-authored using Generative Tooling

📝 Committer Pre-Merge Checklist

[ ] Pull request title is okay.
[ ] No license issues.
[ ] Milestone correctly set?
[ ] Test coverage is ok
[ ] Assignees are selected.
[ ] Minimum number of approvals
[ ] No changes are requested

Be nice. Be informative.

Codecov Report
Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4be20e1) 61.54% compared to head (12aac55) 61.53%.
 Consider uploading reports for the commit de1669c to get more accurate results

Files
Patch %
Lines

.../kyuubi/engine/spark/operation/ExecutePython.scala
0.00%
2 Missing :warning:

...kyuubi/engine/spark/operation/SparkOperation.scala
0.00%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5898      +/-   ##
============================================
- Coverage     61.54%   61.53%   -0.02%
  Complexity       23       23
============================================
  Files           615      615
  Lines         36325    36332       +7
  Branches       4970     4971       +1
============================================
  Hits          22357    22357
- Misses        11554    11566      +12
+ Partials       2414     2409       -5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thanks, merged to 1.9


pingfederate_oauth_access_token_manager plugin_descriptor_ref for JWT Bearer Token

Hi
I'm trying to provision an OAuth Access Token Manager in PingFederate. The Plugin descriptor ref. id is set as: "com.pingidentity.pf.access.token.management.plugins.JwtBearerAccessTokenManagementPlugin".

However, this value is not accepted due to string length limits;

│ Error: unable to create OauthAccessTokenManagers: Validation error(s) occurred. Please review the error(s) and address accordingly.
│ The plugin ID must be less than 33 characters, contain no spaces, and be alphanumeric.
│
│   with pingfederate_oauth_access_token_manager.oauth_access_token_mgr,
│   on main.tf line 49, in resource "pingfederate_oauth_access_token_manager" "oauth_access_token_mgr":
│   49: resource "pingfederate_oauth_access_token_manager" "oauth_access_token_mgr" {

Can you please suggest a way to proceed with this.

its the _ in the name, its not alphanumeric

its the _ in the name, its not alphanumeric

it worked. Thank you..


Question: how to set IPP printer attributes for multiple page-ranges

Hello,
This IPP control file prints a multipage PDF correctly using ipptool.exe per command line in Windows.
My question is how to format or restructure the control file to apply different print attributes to page ranges of the PDF ?
The testfile is 100 pages.
{
NAME "PDFM Print-Job [testprint]"
OPERATION Print-Job
GROUP operation-attributes-tag
ATTR charset attributes-charset utf-8
ATTR language attributes-natural-language en
ATTR uri printer-uri ipp://<IP_ADDRESS>/ipp/print
ATTR mimeMediaType document-format application/pdf
ATTR boolean ipp-attribute-fidelity true
ATTR name requesting-user-name "myusername"
ATTR name job-name "testprint"
GROUP job-attributes-tag
ATTR integer copies 1
ATTR enum print-quality draft
ATTR keyword print-color-mode color
ATTR enum finishings none
ATTR keyword print-content-optimize auto
ATTR keyword output-bin stacker-2
ATTR keyword multiple-document-handling separate-documents-collated-copies
ATTR keyword sides one-sided
ATTR collection media-col {
   MEMBER name    media-source roll-1
}
File "C:\Apps\EPD\Cache\testprint.pdf"
STATUS successful-ok
STATUS successful-ok-ignored-or-substituted-attributes
DISPLAY job-id
DISPLAY job-uri
}

specifically I want to set these attributes for certain page ranges,
ATTR enum print-quality draft
ATTR keyword print-color-mode color
ATTR enum finishings none
ATTR keyword print-content-optimize auto
ATTR keyword output-bin stacker-2

for example sake page 1 to 10 must be
ATTR enum print-quality draft
ATTR keyword print-color-mode monochrome
ATTR keyword print-content-optimize text

page 11 to 80 must be
ATTR enum print-quality normal
ATTR keyword print-color-mode color
ATTR keyword print-content-optimize auto

page 81 to 100 must be
ATTR enum print-quality high
ATTR keyword print-color-mode color
ATTR keyword print-content-optimize photo

I have queried the printer capabilites with the help of the ipptools OPERATION Get-Printer-Attributes
the response is fairly detailed and I know the printer supports the keywords that I need here the complete response
    Get-Printer-Attributes:
        attributes-charset (charset) = utf-8
        attributes-natural-language (naturalLanguage) = en
        printer-uri (uri) = ipp://<IP_ADDRESS>:631/ipp/print
    Get printer attributes using Get-Printer-Attributes                  [PASS]
        RECEIVED: 9474 bytes in response
        status-code = successful-ok (successful-ok)
        attributes-charset (charset) = utf-8
        attributes-natural-language (naturalLanguage) = en
        printer-uri-supported (uri) = ipp://<IP_ADDRESS>/ipp/print
        uri-security-supported (keyword) = none
        uri-authentication-supported (keyword) = requesting-user-name
        printer-name (nameWithoutLanguage) = NPIC58434
        printer-location (textWithoutLanguage) =
        printer-more-info (uri) = http://<IP_ADDRESS>/airprint_mob_status.htm
        printer-device-id (textWithoutLanguage) = MFG:HP;CMD:PJL,DW-PCL,POSTSCRIPT,HP-GL/2,RTL,JPEG,TIFF,PDF,CALSRASTER,ASCII,RASTERSTREAM;MDL:HP PageWide XL 8000PS;CLS:PRINTER;LEDMDIS:USB#FF#CC#00;MCT:PR;MCL:DJA;MCV:1.0;DES:HP PageWide XL 8000PS;SN:MY59Q5Q00Q;FW:NGRGA_14_01_03.1;CID:HPDJPST;
        printer-dns-sd-name (nameWithoutLanguage) = HP PageWide XL 8000PS \[C58434]
        printer-info (textWithoutLanguage) = HP PageWide XL 8000PS \[C58434]
        printer-make-and-model (textWithoutLanguage) = HP PageWide XL 8000PS
        printer-state (enum) = idle
        printer-state-reasons (1setOf keyword) = marker-supply-low-report,marker-waste-almost-full-warning,media-low-warning
        printer-supply-info-uri (uri) = http://<IP_ADDRESS>/hp/device/webAccess/supplies.htm
        ipp-versions-supported (1setOf keyword) = 1.0,1.1,2.0
        operations-supported (1setOf enum) = Print-Job,Print-URI,Validate-Job,Create-Job,Send-URI,Cancel-Job,Get-Job-Attributes,Get-Jobs,Get-Printer-Attributes,Send-Document
        multiple-document-jobs-supported (boolean) = false
        multiple-operation-time-out (integer) = 1
        charset-configured (charset) = utf-8
        charset-supported (charset) = utf-8
        natural-language-configured (naturalLanguage) = en-us
        generated-natural-language-supported (naturalLanguage) = en-us
        document-format-default (mimeMediaType) = application/octet-stream
        document-format-preferred (mimeMediaType) = application/pdf
        document-format-supported (1setOf mimeMediaType) = image/jpeg,application/vnd.hp-PCL,application/octet-stream,image/urf,image/tiff,application/zip,application/pdf
        printer-geo-location (unknown) = unknown
        printer-is-accepting-jobs (boolean) = true
        queued-job-count (integer) = 105
        pdl-override-supported (keyword) = attempted
        printer-up-time (integer) = 489235
        compression-supported (keyword) = none
        color-supported (boolean) = true
        reference-uri-schemes-supported (1setOf uriScheme) = http,https
        page-ranges-supported (boolean) = true
        job-creation-attributes-supported (1setOf keyword) = copies,finishings,ipp-attribute-fidelity,job-name,media,media-col,orientation-requested,output-bin,print-color-mode,print-quality,printer-resolution,sides,page-ranges,multiple-document-handling
        media-supported (1setOf keyword) = na_letter_8.5x11in,na_legal_8.5x14in,na_ledger_11x17in,na_c_17x22in,na_d_22x34in,na_e_34x44in,asme_f_28x40in,na_super-b_13x19in,na_arch-a_9x12in,na_arch-b_12x18in,na_arch-c_18x24in,na_arch-d_24x36in,iso_a4_210x297mm,iso_a3_297x420mm,iso_a2_420x594mm,iso_a1_594x841mm,iso_a0_841x1189mm,iso_b4_250x353mm,iso_b3_353x500mm,iso_b2_500x707mm,iso_b1_707x1000mm,iso_c4_229x324mm,iso_c3_324x458mm,iso_c2_458x648mm,iso_c1_648x917mm,jis_b4_257x364mm,jis_b3_364x515mm,jis_b2_515x728mm,jis_b1_728x1030mm,custom_min_210x279.40mm,custom_max_914x92000mm,roll_min_210x279.40mm,roll_max_914x92000mm
        media-default (keyword) = roll_roll-1_914x92000mm
        media-ready (1setOf keyword) = roll_current_762x0mm,roll_current_914x0mm,roll_current_863x0mm,roll_current_914x0mm,roll_current_558x0mm,roll_current_609x0mm
        media-col-ready (1setOf collection) = {media-size={x-dimension=76200 y-dimension=27940-9200000} media-top-margin=500 media-bottom-margin=500 media-left-margin=500 media-right-margin=500 media-source=roll-1 media-type=stationery},{media-size={x-dimension=91400 y-dimension=27940-9200000} media-top-margin=500 media-bottom-margin=500 media-left-margin=500 media-right-margin=500 media-source=roll-2 media-type=stationery},{media-size={x-dimension=86300 y-dimension=27940-9200000} media-top-margin=500 media-bottom-margin=500 media-left-margin=500 media-right-margin=500 media-source=roll-3 media-type=stationery},{media-size={x-dimension=101600 y-dimension=27940-9200000} media-top-margin=500 media-bottom-margin=500 media-left-margin=500 media-right-margin=500 media-source=roll-4 media-type=stationery-heavyweight-coated},{media-size={x-dimension=55800 y-dimension=27940-9200000} media-top-margin=500 media-bottom-margin=500 media-left-margin=500 media-right-margin=500 media-source=roll-5 media-type=stationery},{media-size={x-dimension=60900 y-dimension=27940-9200000} media-top-margin=500 media-bottom-margin=500 media-left-margin=500 media-right-margin=500 media-source=roll-6 media-type=stationery}
        media-col-supported (1setOf keyword) = media-size-name,media-size,media-top-margin,media-bottom-margin,media-left-margin,media-right-margin,media-source,media-type
        media-col-default (collection) = {media-size-name=na_letter_8.5x11in media-size={x-dimension=21590 y-dimension=27940} media-top-margin=500 media-bottom-margin=500 media-left-margin=500 media-right-margin=500 media-source=roll-1 media-type=stationery}
        media-left-margin-supported (integer) = 500
        media-right-margin-supported (integer) = 500
        media-top-margin-supported (integer) = 500
        media-bottom-margin-supported (integer) = 500
        media-source-supported (1setOf keyword) = auto,main,roll-1,roll-2,roll-3,roll-4,roll-5,roll-6
        media-size-supported (1setOf collection) = {x-dimension=21590 y-dimension=27940},{x-dimension=21590 y-dimension=35560},{x-dimension=27940 y-dimension=43180},{x-dimension=43180 y-dimension=55880},{x-dimension=55880 y-dimension=86360},{x-dimension=86360 y-dimension=111760},{x-dimension=71120 y-dimension=101600},{x-dimension=33020 y-dimension=48260},{x-dimension=22860 y-dimension=30480},{x-dimension=30480 y-dimension=45720},{x-dimension=45720 y-dimension=60960},{x-dimension=60960 y-dimension=91440},{x-dimension=21000 y-dimension=29700},{x-dimension=29700 y-dimension=42000},{x-dimension=42000 y-dimension=59400},{x-dimension=59400 y-dimension=84100},{x-dimension=84100 y-dimension=118900},{x-dimension=25000 y-dimension=35300},{x-dimension=35300 y-dimension=50000},{x-dimension=50000 y-dimension=70700},{x-dimension=70700 y-dimension=100000},{x-dimension=22900 y-dimension=32400},{x-dimension=32400 y-dimension=45800},{x-dimension=45800 y-dimension=64800},{x-dimension=64800 y-dimension=91700},{x-dimension=25700 y-dimension=36400},{x-dimension=36400 y-dimension=51500},{x-dimension=51500 y-dimension=72800},{x-dimension=72800 y-dimension=103000},{x-dimension=21000-91400 y-dimension=27940-9200000}
        media-type-supported (1setOf nameWithoutLanguage) = stationery,stationery-coated,stationery-heavyweight-coated,stationery-tracing,stationery-bond-translucent,stationery-fine,photographic-glossy,photographic-satin & photographic-semi-gloss,photographic-matte,back-print-film,film-matte,self-adhesive,self-adhesive-film
        pages-per-minute (integer) = 16
        pages-per-minute-color (integer) = 16
        jpeg-k-octets-supported (rangeOfInteger) = 0-12582912
        jpeg-x-dimension-supported (rangeOfInteger) = 1-65535
        jpeg-y-dimension-supported (rangeOfInteger) = 1-65535
        pdf-k-octets-supported (rangeOfInteger) = 0-20971520
        pdf-versions-supported (keyword) = iso-32000-1_2008
        printer-uuid (uri) = urn:uuid:01fea3db-e30c-5fb5-a1f8-cf0294fea8a8
        marker-names (1setOf nameWithoutLanguage) = cyan ink,cyan ink
        marker-colors (1setOf nameWithoutLanguage) = #FF00FF,#FF00FF
        marker-types (1setOf keyword) = inkCartridge,inkCartridge
        marker-low-levels (1setOf integer) = 1,1
        marker-high-levels (1setOf integer) = 100,100
        marker-levels (1setOf integer) = 38,100
        copies-default (integer) = 1
        multiple-document-handling-default (keyword) = separate-documents-collated-copies
        finishings-default (enum) = none
        orientation-requested-default (enum) = portrait
        print-quality-default (enum) = draft
        printer-resolution-default (resolution) = 300dpi
        sides-default (keyword) = one-sided
        output-bin-default (keyword) = stacker-1
        output-mode-default (keyword) = auto
        copies-supported (rangeOfInteger) = 1-999
        multiple-document-handling-supported (1setOf keyword) = separate-documents-uncollated-copies,separate-documents-collated-copies
        finishings-supported (1setOf enum) = none,trim
        orientation-requested-supported (1setOf enum) = portrait,landscape,reverse-portrait,reverse-landscape,none
        print-quality-supported (1setOf enum) = draft,normal,high
        printer-resolution-supported (1setOf resolution) = 300dpi,600dpi,1200dpi
        sides-supported (keyword) = one-sided
        output-bin-supported (1setOf keyword) = stacker-2,rear,tray-1,tray-6,stacker-1
        output-mode-supported (1setOf keyword) = auto,color,monochrome
        printer-icons (1setOf uri) = http://<IP_ADDRESS>/hp/device/webAccess/images/wake/printer2.png,http://<IP_ADDRESS>/hp/device/webAccess/images/wake/printer2-large.png
        landscape-orientation-requested-preferred (enum) = 5
        printer-kind (keyword) = roll
        print-color-mode-default (keyword) = auto
        print-color-mode-supported (1setOf keyword) = auto,color,monochrome
        print-content-optimize-supported (1setOf keyword) = auto,graphics,photo,text,text-and-graphics

I see a page-ranges attribute, under job-creation-attributes-supported section but I could not figure out how to use and apply that.
Can someone kindly supply an example how IPP attributes need to be applied to page ranges ?
thank you

also, I have read https://tools.ietf.org/html/rfc8011#section-5.2.7 - but I still did not understand how to use multiple page-ranges properly.

@CanadianHusky What you want to use the "overrides" Job Template attribute (a 1setOf collection), however this printer does not seem to support it.
What you'll need to do instead is send multiple Print-Job requests, each with a different value of "page-ranges" and the corresponding Job Template attributes/values for that range of pages.

Understood, thank you. I was hoping that
pdl-override-supported (keyword) = attempted
could be utilized somehow, but if you say that based on the attribute list 'overrides" is not supported, sending multiple Print-Job requests is the only way.
What makes it a bit more complicated is the fact that for production I use the "Print-URI" Operation and not the "Print-Job" operation.
When I transfer files directly to the controller of the device with Print-Job and ipptool.exe the amount of time taken for the first sheet to come out is for examples sake 5 units. I call this "IPP-Push" because I push data to the controller. To maintain sequential print order, the next batch cannot start until the previous is finished.
When I do the identical job file and identical IPP command, with the only difference "Print-URI" the print file is copied to an http accessible network path, a tiny http server acts as a file server. The controller receives a tiny control file with your ipptool.exe and 'pulls' the file itself. This time the first sheet out is 1 unit....5 times faster!
In production numbers it is the difference between waiting 10 minutes or 50 minutes when Data is a few hundret MB or more.
Is it possible that the ipptool.exe buffering/network method could be tweaked to improve throuput by a factor of 5?
My tests are based on this version ipp-20151110.msi
If there has been improvement to ipptool.exe over the years in this topic I would be interested in testing that again.
Thank you for the great work on this Printing protocol. Its a shame that manufacturers are still dragging their feet with implementation. Even the latest Hewlett-Packard Pagewide Firmwave has no IPP options to control the hardware folder options.

@CanadianHusky The current IPP Everywhere self-certification tools installer (here) is far more up-to-date. That said, the "pull" print mode might be optimized in some way that the "push" print request might not be for this printer (and you might be dealing with a slow storage subsystem vs. HTTP with range requests into memory with PDF), so if you can take advantage of Print-URI you should!
"pdl-override-supported" is a different attribute and has a different meaning - basically it tells the client whether Job Template attributes will override embedded instructions for media size, print quality, etc. The 'attempted' value is pretty common and just means that they should (which is expected for PDF at least).
As for printer manufacturers, my experience is that they "get" it but still have to support their existing customers and solutions. This makes some areas of change slower/harder than they need to be, but they are moving in the right direction. Heck, a few years ago you might not have had any IPP support in this class of printer yet!


Steps are unclear

Steps are unclear, which of these nodes are roots / siblings / child ? Please add screenshots if possible.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5a7c3841-58f6-35eb-c7eb-a95fb3e40a63
Version Independent ID: b32ff3b6-a7e5-baba-795e-44f21236ad5a
Content: ER Use financial dimensions as a data source (Part 1 - Design data model) - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/dev-itpro/analytics/tasks/er-financial-dimensions-data-source-1.md
Service: dynamics-ax-applications
Product: ****
Technology: ****
GitHub Login: @NickSelin
Microsoft Alias: nselin

@manishmoothedath, thank you for the feedback.
@NickSelin, please review and consider updating the content.

@manishmoothedath - Thanks for your feedback. This topic, as well as the other three in this procedure set, are automatically generated from the task guide that can be uploaded from the LCS BPM library and played in Task recorder. When these guides are played, you can see all of the screens/pages that are referred to. However, the topics have been updated with some screenshots. Changes will be published today.


Don't allow construction of types returned by admin type methods by users

There is not really any need to allow users to create classes returned by admin type methods on Producer and Consumer such as PartitionMetadata, GroupInfo etc. We can probably mark  their constructors as internal.

The downside on this is that it make tests more difficult if anyone wants to mock some returns in unit tests (for example, automatic operations on metadata requests). I would happily let public constructor for all public classes so that it's not a nightmare to test, as it doesn't have any downside on perf / use.

i'd agree with that.


Retention.size seems to be ignored

What did you do?
We run a prometheus process that collects relatively small number of metrics (number of series: 30076) with retention.size param set to 1024MB:
bin/prometheus --config.file prometheus.yml --web.enable-admin-api --web.enable-lifecycle --storage.tsdb.retention.size 1024MB --storage.tsdb.retention.time 365d --web.listen-address <IP_ADDRESS>:9123 --storage.tsdb.max-block-duration 25h --storage.tsdb.path /stats_data --log.level debug --query.max-samples 200000 --storage.tsdb.no-lockfile --query.lookback-delta 600s

What did you expect to see?
We expect the disk space taken by prometheus to be limited by approximately 1GB.
What did you see instead? Under which circumstances?
The total size of the data dir has grown higher than 2GB for 3 weeks, and  it doesn't seem to have plans to stop. No blocks deleted so far by retention policy.
I added a debug metric that reports the size of each file in the prometheus data dir, and here is what it shows currently:

It can be seen clearly that the space is taken not by wal (green), but blocks (which is why I'm creating new issue, because it previous ones the problem was caused by the wal).
Prometheus metrics confirms the problem. prometheus_tsdb_storage_blocks_bytes shows 2.305727921e+09, prometheus_tsdb_size_retentions_total is 0:
# HELP prometheus_tsdb_retention_limit_bytes Max number of bytes to be retained in the tsdb blocks, configured 0 means disabled
# TYPE prometheus_tsdb_retention_limit_bytes gauge
prometheus_tsdb_retention_limit_bytes 1.073741824e+09
# HELP prometheus_tsdb_size_retentions_total The number of times that blocks were deleted because the maximum number of bytes was exceeded.
# TYPE prometheus_tsdb_size_retentions_total counter
prometheus_tsdb_size_retentions_total 0
# HELP prometheus_tsdb_storage_blocks_bytes The number of bytes that are currently used for local storage by all blocks.
# TYPE prometheus_tsdb_storage_blocks_bytes gauge
prometheus_tsdb_storage_blocks_bytes 2.305727921e+09

Environment

System information:

uname -srm
Linux 3.10.0-1127.18.2.el7.x86_64 x86_64

Prometheus version:

 ./prometheus --version
prometheus, version 2.22.0 (branch: HEAD, revision: a6239a377d49104ac7253a99aef8feb8dee0a7c2)
  build user:       couchbase@a18d7aab001f
  build date:       20210701-11:04:06
  go version:       go1.14.2
  platform:         linux/amd64

Prometheus configuration file:

global:
  scrape_interval: 10s
  scrape_timeout: 10s
  evaluation_interval: 1m
rule_files:
- /opt/couchbase/var/lib/couchbase/config/prometheus_rules.yml
scrape_configs:
- job_name: general
  honor_timestamps: true
  scrape_interval: 10s
  scrape_timeout: 10s
  metrics_path: /_prometheusMetrics
  scheme: http
  basic_auth:
    username: '<user>'
    password_file: <file_path>>
  relabel_configs:
  - source_labels: [__address__]
    separator: ;
    regex: 127\.0\.0\.1:8091
    target_label: instance
    replacement: ns_server
    action: replace
  - source_labels: [__address__]
    separator: ;
    regex: 127\.0\.0\.1:9998
    target_label: instance
    replacement: xdcr
    action: replace
  - source_labels: [__address__]
    separator: ;
    regex: 127\.0\.0\.1:8097
    target_label: instance
    replacement: backup
    action: replace
  - source_labels: [__address__]
    separator: ;
    regex: 127\.0\.0\.1:8095
    target_label: instance
    replacement: cbas
    action: replace
  - source_labels: [__address__]
    separator: ;
    regex: 127\.0\.0\.1:8096
    target_label: instance
    replacement: eventing
    action: replace
  - source_labels: [__address__]
    separator: ;
    regex: 127\.0\.0\.1:8094
    target_label: instance
    replacement: fts
    action: replace
  - source_labels: [__address__]
    separator: ;
    regex: 127\.0\.0\.1:9102
    target_label: instance
    replacement: index
    action: replace
  - source_labels: [__address__]
    separator: ;
    regex: 127\.0\.0\.1:11280
    target_label: instance
    replacement: kv
    action: replace
  - source_labels: [__address__]
    separator: ;
    regex: 127\.0\.0\.1:8093
    target_label: instance
    replacement: n1ql
    action: replace
  static_configs:
  - targets:
    - <IP_ADDRESS>:8091
    - <IP_ADDRESS>:9998
    - <IP_ADDRESS>:8097
    - <IP_ADDRESS>:8095
    - <IP_ADDRESS>:8096
    - <IP_ADDRESS>:8094
    - <IP_ADDRESS>:9102
    - <IP_ADDRESS>:11280
    - <IP_ADDRESS>:8093
- job_name: ns_server_high_cardinality
  honor_timestamps: true
  scrape_interval: 10s
  scrape_timeout: 10s
  metrics_path: /_prometheusMetricsHigh
  scheme: http
  basic_auth:
    username: '<user>'
    password_file: <file_path>>
  relabel_configs:
  - source_labels: [__address__]
    separator: ;
    regex: 127\.0\.0\.1:8091
    target_label: instance
    replacement: ns_server
    action: replace
  static_configs:
  - targets:
    - <IP_ADDRESS>:8091
- job_name: index_high_cardinality
  honor_timestamps: true
  scrape_interval: 3m
  scrape_timeout: 10s
  metrics_path: /_prometheusMetricsHigh
  scheme: http
  basic_auth:
    username: '<user>'
    password_file: <file_path>>
  relabel_configs:
  - source_labels: [__address__]
    separator: ;
    regex: 127\.0\.0\.1:9102
    target_label: instance
    replacement: index
    action: replace
  static_configs:
  - targets:
    - <IP_ADDRESS>:9102
- job_name: fts_high_cardinality
  honor_timestamps: true
  scrape_interval: 3m
  scrape_timeout: 10s
  metrics_path: /_prometheusMetricsHigh
  scheme: http
  basic_auth:
    username: '<user>'
    password_file: <file_path>>
  relabel_configs:
  - source_labels: [__address__]
    separator: ;
    regex: 127\.0\.0\.1:8094
    target_label: instance
    replacement: fts
    action: replace
  static_configs:
  - targets:
    - <IP_ADDRESS>:8094
- job_name: kv_high_cardinality
  honor_timestamps: true
  scrape_interval: 30s
  scrape_timeout: 10s
  metrics_path: /_prometheusMetricsHigh
  scheme: http
  basic_auth:
    username: '<user>'
    password_file: <file_path>>
  relabel_configs:
  - source_labels: [__address__]
    separator: ;
    regex: 127\.0\.0\.1:11280
    target_label: instance
    replacement: kv
    action: replace
  static_configs:
  - targets:
    - <IP_ADDRESS>:11280
- job_name: cbas_high_cardinality
  honor_timestamps: true
  scrape_interval: 3m
  scrape_timeout: 10s
  metrics_path: /_prometheusMetricsHigh
  scheme: http
  basic_auth:
    username: '<user>'
    password_file: <file_path>>
  relabel_configs:
  - source_labels: [__address__]
    separator: ;
    regex: 127\.0\.0\.1:8095
    target_label: instance
    replacement: cbas
    action: replace
  static_configs:
  - targets:
    - <IP_ADDRESS>:8095
- job_name: eventing_high_cardinality
  honor_timestamps: true
  scrape_interval: 3m
  scrape_timeout: 10s
  metrics_path: /_prometheusMetricsHigh
  scheme: http
  basic_auth:
    username: '<user>'
    password_file: <file_path>>
  relabel_configs:
  - source_labels: [__address__]
    separator: ;
    regex: 127\.0\.0\.1:8096
    target_label: instance
    replacement: eventing
    action: replace
  static_configs:
  - targets:
    - <IP_ADDRESS>:8096
- job_name: prometheus
  honor_timestamps: true
  scrape_interval: 1m
  scrape_timeout: 1m
  metrics_path: /metrics
  scheme: http
  basic_auth:
    username: '<user>'
    password_file: <file_path>>
  relabel_configs:
  - separator: ;
    regex: (.*)
    target_label: instance
    replacement: prometheus
    action: replace
  metric_relabel_configs:
  - source_labels: [__name__]
    separator: ;
    regex: prometheus_target_interval_length_seconds_sum|prometheus_target_interval_length_seconds|prometheus_target_interval_length_seconds_count
    replacement: $1
    action: drop
  static_configs:
  - targets:
    - <IP_ADDRESS>:9123

`

Logs:
Compaction logs look ok to me:

level=info ts=2021-11-15T11:00:01.524Z caller=compact.go:494 component=tsdb msg="write block" mint=1636963200000 maxt=1636970400000 ulid=01FMHM1YGSTJ034XP1EJY8KDJX duration=859.002235ms
level=info ts=2021-11-15T11:00:01.588Z caller=head.go:809 component=tsdb msg="Head GC completed" duration=21.097557ms
level=info ts=2021-11-15T11:00:01.605Z caller=checkpoint.go:96 component=tsdb msg="Creating checkpoint" from_segment=300 to_segment=301 mint=1636970400000
level=info ts=2021-11-15T11:00:02.792Z caller=head.go:889 component=tsdb msg="WAL checkpoint complete" first=300 last=301 duration=1.18719712s

Sometimes it takes longer though. It even removes something, but it is not retention related as I see all the metrics data is there and extractable.
level=info ts=2021-11-15T15:00:01.420Z caller=compact.go:494 component=tsdb msg="write block" mint=1636977600000 maxt=1636984800000 ulid=01FMJ1SD0T73Y99SJYAXP0QT56 duration=754.197257ms
level=info ts=2021-11-15T15:00:01.485Z caller=head.go:809 component=tsdb msg="Head GC completed" duration=22.259144ms
level=info ts=2021-11-15T15:00:01.502Z caller=checkpoint.go:96 component=tsdb msg="Creating checkpoint" from_segment=302 to_segment=303 mint=1636984800000
level=info ts=2021-11-15T15:00:02.658Z caller=head.go:889 component=tsdb msg="WAL checkpoint complete" first=302 last=303 duration=1.155751244s
level=info ts=2021-11-15T15:00:04.062Z caller=compact.go:440 component=tsdb msg="compact blocks" count=3 mint=1636956000000 maxt=1636977600000 ulid=01FMJ1SF0NVA1Z4QG91CNEZH2Y sources="[01FMHD678TC75EFFYE77VY9V46 01FMHM1YGSTJ034XP1EJY8KDJX 01FMHTXNRSTTW2TYXSJKAGSH8K]" duration=1.353403267s
level=info ts=2021-11-15T15:00:04.125Z caller=db.go:1152 component=tsdb msg="Deleting obsolete block" block=01FMHD678TC75EFFYE77VY9V46
level=info ts=2021-11-15T15:00:04.129Z caller=db.go:1152 component=tsdb msg="Deleting obsolete block" block=01FMHTXNRSTTW2TYXSJKAGSH8K
level=info ts=2021-11-15T15:00:04.133Z caller=db.go:1152 component=tsdb msg="Deleting obsolete block" block=01FMHM1YGSTJ034XP1EJY8KDJX
level=info ts=2021-11-15T15:00:05.812Z caller=compact.go:440 component=tsdb msg="compact blocks" count=3 mint=1636912800000 maxt=1636977600000 ulid=01FMJ1SGEBBETEPNDMTQGNMM3J sources="[01FMGRK5Y79ZQ71GDGFGGW8P24 01FMHD68C916T7RVG5Q6AG8K6P 01FMJ1SF0NVA1Z4QG91CNEZH2Y]" duration=1.641333967s
level=info ts=2021-11-15T15:00:05.858Z caller=db.go:1152 component=tsdb msg="Deleting obsolete block" block=01FMJ1SF0NVA1Z4QG91CNEZH2Y
level=info ts=2021-11-15T15:00:05.867Z caller=db.go:1152 component=tsdb msg="Deleting obsolete block" block=01FMGRK5Y79ZQ71GDGFGGW8P24
level=info ts=2021-11-15T15:00:05.875Z caller=db.go:1152 component=tsdb msg="Deleting obsolete block" block=01FMHD68C916T7RVG5Q6AG8K6P

Thanks for your report.
Please update your Prometheus release. There is a bug in Prometheus 2.22.0 which has been fixed in 2.22.1 that prevents size based retention.


[5.5] Allow Schema::drop and Schema::dropIfExists arrays of table names

It is better to provide a description

Oops. forgot. Thanks for pointingthat out :P

When would you realistically use this function?

When you have a migration that has to drop two tables on a rollback.
It surprised me when it didnt work for me actually.

So, why not call Schema::drop twice where it's highly obvious in what order you're removing the tables?

But okay, if you really want this ...
Why limit yourself to arrays? Why not Arrayable? iterable? You know, anything that can be foreach-able? And where are the tests?

Holding off for now.


update others_application mappings

Description
update others_application mappings
Issues Resolved
update others_application mappings
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #277 (e136ca4) into main (7bdb8e8) will increase coverage by 0.24%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #277      +/-   ##
============================================
+ Coverage     36.82%   37.07%   +0.24%
- Complexity      881      886       +5
============================================
  Files           179      179
  Lines          6957     6981      +24
  Branches        849      853       +4
============================================
+ Hits           2562     2588      +26
+ Misses         4158     4155       -3
- Partials        237      238       +1

Impacted Files
Coverage Δ

.../opensearch/securityanalytics/util/IndexUtils.java
37.68% <0.00%> (-0.90%)
:arrow_down:

...ch/securityanalytics/mapper/MappingsTraverser.java
82.35% <0.00%> (-0.70%)
:arrow_down:

...g/opensearch/securityanalytics/model/Detector.java
69.89% <0.00%> (-0.35%)
:arrow_down:

...ics/transport/TransportGetIndexMappingsAction.java
0.00% <0.00%> (ø)

...search/securityanalytics/mapper/MapperService.java
4.54% <0.00%> (+0.08%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Get "soft" score of SVC instead of binary classification?

Hi, thank you for making this library!
Is there a way to obtain a "soft" score for SVC? Similar to how scikit learn exposes SVC.decision_function (see also: decision_function).
I'd be happy to try and implement this if it does not exist already.

Hi @ferrouille, I do not plan to add decision_function to SVC, but I would be happy to review your code if you'd like to work on it!


Fixes #654: Upload count

This PR fixed the upload count shown in the header.
It also introduces some infrastructure for handling concurrency in the app. I will add some documentation on its usage.
Feel free to go through the PR and see the usage of

background thread using ThreadPoolExecutorService
the usage of ListenableFuture in the UploadCountClient

Codecov Report

Merging #691 into master will decrease coverage by 0.13%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #691      +/-   ##
=========================================
- Coverage     6.1%   5.96%   -0.14%
=========================================
  Files          88      95       +7
  Lines        4885    4992     +107
  Branches      439     443       +4
=========================================
  Hits          298     298
- Misses       4562    4669     +107
  Partials       25      25

Impacted Files
Coverage Δ

...ree/nrw/commons/contributions/UploadCountTask.java
0% <0%> (ø)

...w/commons/contributions/ContributionsActivity.java
0% <0%> (ø)
:arrow_up:

.../java/fr/free/nrw/commons/utils/ExecutorUtils.java
0% <0%> (ø)

.../concurrency/ExceptionAwareThreadPoolExecutor.java
0% <0%> (ø)

...commons/concurrency/ThreadPoolExecutorService.java
0% <0%> (ø)

...ee/nrw/commons/concurrency/ThreadFactoryMaker.java
0% <0%> (ø)

...ns/concurrency/BackgroundPoolExceptionHandler.java
0% <0%> (ø)

...e/nrw/commons/contributions/UploadCountClient.java
0% <0%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b400cd...82c0d24. Read the comment docs.


[ko] Update outdated in dev-1.21-ko.8 (M51-M55)

Ref #29253
Task: M51-M55
M51. content/en/docs/tutorials/kubernetes-basics/scale/scale-interactive.html | 2(+XS) 2(-)
M52. content/en/docs/tutorials/kubernetes-basics/update/update-interactive.html | 1(+XS) 1(-)
M53. content/en/docs/tutorials/stateful-application/cassandra.md | 2(+XS) 2(-)
M54. content/en/docs/tutorials/stateful-application/zookeeper.md | 4(+XS) 4(-)
M55. content/en/docs/tutorials/stateless-application/guestbook.md | 1(+XS) 1(-)

/assign

/lgtm

/approve


Use MSTest meta package

This add MSTest.Analyzers for test code. Coverlet is an unused dependency.

/azp run


Allow testing of Webhooks using ENV

After seeing the pull request #190 I wanted to contribute with what looks to me a better solution.
As @taylorotwell said using environment variables looked like a better choice.
To keep it simple I added a isInTestingMode method that return a boolean according to the CASHIER_TESTING env variable.
Then in the handleWebhook method we can verify that we are not in testing mode.

Well, I don't really understand what is the problem with StyleCI.
So I am going to start over.

You had trailing whitespace. You could have just downloaded the diff it gave you and applied it instead of manually trying to fix it though...

I am not used to github stuff yet.
I'll try that then.

Please squash to one commit.

(and force push)

I might have done something wrong..
Sorry for my poor git knowledge

I will close this and start over.


Make README.md readable

Nothing too much to explain except that I made code and text look nicer.

I cant merge

I import it externaly and give you promo


Draft: [FEATURE] Support typo3-contentblock packages

content blocks works out of the box. it was a mistake on my end. thanks for taking a look


build: add missing configuration options to build.ps1

Bring build.ps1 in line with the CI builds which specify the additional parameters to the llvm configuration.  Thanks to @fischman-bcny for pointing out this divergence!

@compnerd maybe I am missing something. Aren't tools not using Python at all? I am getting
  Manually-specified variables were not used by the project:
    LLDB_PYTHON_EXE_RELATIVE_PATH
    LLDB_PYTHON_EXT_SUFFIX
    LLDB_PYTHON_RELATIVE_PATH

from build tools configuration with this changes. On the other hand, the Compilers step is actually missing LLDB_PYTHON_EXE_RELATIVE_PATH and LLDB_PYTHON_RELATIVE_PATH variables.

@lxbndr ugh, yes, those were meant for the toolchain build, not the build tools.


🔌 Plugin: Policies via csv does not work

🔖 Summary

I am following the instructions mentioned  here https://github.com/janus-idp/backstage-plugins/blob/main/plugins/rbac-backend/README.md.
I created rbac-policy.csv as shown below:

Assigning users to roles
g, user:default/test, role:default/catalog-admin
g, user:default/test, role:default/admin-rbac
g, user:default/test, role:default/scaffolder-admin
Defining permissions for admin role
catalog-entity
p, role:default/catalog-admin, catalog-entity, read, allow
p, role:default/catalog-admin, catalog-entity, create, allow
p, role:default/catalog-admin, catalog-entity, update, allow
p, role:default/catalog-admin, catalog-entity, delete, allow
p, role:default/catalog-admin, catalog.location.read, read, allow
p, role:default/catalog-admin, catalog.location.create, create, allow
p, role:default/catalog-admin, catalog.location.delete, delete, allow
rbac
p, role:default/admin-rbac, policy-entity, create, allow
p, role:default/admin-rbac, policy-entity, read, allow
p, role:default/admin-rbac, policy-entity, update, allow
p, role:default/admin-rbac, policy-entity, delete, allow
scaffolder
p, role:default/scaffolder-admin, scaffolder-action, execute, allow
p, role:default/scaffolder-admin, scaffolder-template, read, allow
p, role:default/scaffolder-admin, scaffolder.template.parameter.read, read, allow
p, role:default/scaffolder-admin, scaffolder.template.step.read, read, allow
In app.config.yaml
permission:
enabled: true
rbac:
policies-csv-file: ../../packages/backend/org/rbac-policy.csv
policyFileReload: true

Once logged into Backstage successfully using user:default/test, I can see components and templates, but there is no 'Create' button for components or 'Choose' button for templates to create a component.

🌐 Project website (if applicable)
No response
✌ Context
No response
👀 Have you spent some time to check if this plugin request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Contributing Guidelines

Are you willing to submit PR?
None

Hi @PatAKnight ,
Thank you very much for your excellent support. Everything is working now.


/examples/inline/inline.py not working

When I click on inline button InlineHandler does not react, that is not called on_inline_query and on_chosen_inline_result.

I just tried inline.py and it works as expected. You type @WhateverYourBotIs querystring, it echoes back your query string (meaning on_inline_query() is invoked). If you select the option, the chosen inline result is printed on the console (meaning on_chosen_inline_result() is invoked).


Remove wp-admin redirect

I dunno if there's a specific reason for this in the first place, but for me it looks useless. If you're using a Ghost app, you shouldn't be trying to access wp-admin (I'd argue people using Wordpress blogs also don't, they just go to /admin or /login and get redirected). The only use I can see for this would be migrating from a Wordpress blog (which can now use the redirects feature) or bots trying to hack Wordpress websites from google search.
If you still wanna keep this redirect, please consider adding it to the default redirects file instead of hardcoding it into the core, so people who don't need it can disable it.
This change was also requested in the forum.

This is not a bug and we're not interested in changing this functionality at the moment. You're more than welcome to vote on the forum issue, which you've already linked to :)


Long running process (PHP-FPM)?

Hi!
Could this module be used to run PHP-FPM in the background?
Can time-limit be set to 0 or -1 for example?

@Richard87
Yes, setting timeout to 0 leaves it running indefinitely. Although it is undocumented at the moment.
Something like this should run indefinitely.
exec ping google.com {
    startup
    timeout 0
}


Removing Code Contracts from a project when upgrading to VS2017

My C# project developed in VS2015 used Code Contracts. Since this tool has gone stale after being open sourced by Microsoft, I don't plan to use it in VS2017. That said, when I attempt to run my project's unit tests in VS2017 it complains about the assembly needing to be rewritten using CCRewrite because it contains preconditions. When I create a new VS2017 project (as a test) with preconditions I do not receive this error.
What do I need to do to get rid of the error message in my legacy project? I can't seem to find any references to it.

I finally found another post stating that Contract.Requires<TException>(...) requires a rewriter whereas Contract.Requires(...) does not. After making this change in my project it is now executing without errors in VS2017.


feat(core): allow the use of a requests session

Hey :waffle: !
I'm not sure if this is a common pain point, but it would be quite useful to be able to pass a requests.session to the API classes. One possible use case is to pass a Retry parameter to retry in case of 500. This is quite nice as one instability can break a script, when most of the time we could just retry.
api = sdk.AccountV2API(client, session=requests.Session(retries=Retry(total=10)))
project = api.create_project(name="toto")

Since this PR introduces some weird changes in the API, you could also just create an empty session as an attribute so it could be modified by modifying the attribute.
api = sdk.AccountV2API(client)
api._session = requests.Session(retries=Retry())

Cheers!
Have a lovely day!

Hey! That may be better to have this option when creating a Client instead, what do you think?

Hey! That may be better to have this option when creating a Client instead, what do you think?

Oh yeah, I like your idea a lot better as it will be more convenient when working with multiple APIs. Awesome :pray: I will update my PR next week.


Support overlaying environment values onto existing values.

Use Case
Our common application configuration requires each application to define a small set of descriptive information about the service in order to make the application deployable, discoverable, etc.
envconfig.Process along with default struct tag definitions allow for both global default value configuration as well as environment-specific configuration.  However, they do not support defining application-specific defaults for common configuration concerns (application name, e.g.) while preserving global default values and required field behaviors.  It's not possible to use default value and setting the same information in each environment is redundant and prone to errors when not setting it correctly in each environment.
envconfig.Overlay enables per-application defaults by replacing only values defined in a configuration struct instance with environment variables and not the default values (if they are defined).
Configuration values will adhere to following order of precedence with these changes:

(Highest) Environment Variable
Struct values
(Lowest) Struct tag values

Configuring a simple web server
Assume we have the provided configuration struct:
type ServerInfo struct {
    http             string `default:":8080"`
    appName          string `required:"true"`
    env              string `default:"local"`
    messageBrokerURL string `default:"localhost:8081"`
}

with the following environment variables defined:
SERVER_INFO_ENV=STAGE
SERVER_INFO_MESSAGE_BROKER_URL=http://message-broker-stage.bigbankcorp.internal/messages/recent

We can define the server info before overlaying values from the environment as follows:
base := ServerInfo{
  appName: "MessageDigester",
}

info := envconfig.Overlay("SERVER_INFO", &base)

Then, we run envconfig.Overlay() and expect info to be represented in json as:
{
  "http": ":8080",
  "appName": "MessageDigester",
  "env": "STAGE",
  "messageBrokerURL": "http://message-broker-stage.bigbankcorp.internal"
}

👍  Need this


Remove hardcoded paths

In multiple places asset paths are hardcoded (e.g. fonts, images) this cause them not to work properly (e.g. in staging).
Production works by "accident" since the required files have been deployed to root at some point before the sub directory change.
See https://github.com/gnosis/dex-docs/commit/8f8b04d24ca6d91350be85559dfaf7160faffc2c

https://github.com/gnosis/conditional-tokens-docs/commit/3e74890604697dee6c1d0b31c200fba06173df10
https://github.com/gnosis/conditional-tokens-docs/commit/0c265f951b72cdac2ba2309bfc84f47000cd9b55


[1.11.2] Add support of TechReborn energy

The controller does not accept techReborn energy. It would be nice to add support.

RS 1.11.2 supports Forge Energy. I imagine their could be a problem with TR. Can you try with Actually additions for example and see if that works?

Yes that work with Actually Additions. It's just for TechReborn. Cables do not connect.

Yep, then this is a TR issue.
TechReborn should emit Forge Energy, so this is an issue on their side. Please report it on their bug tracker.

TR doesn't push FE atm, this is an issue on our end.

Definitely not my area of expertise, but aren't RF, Tesla, and Forge Energy push-based systems?

Yes, I just didn't get around to doing it for FE because I'm lazy :P

Oh.  Sorry, I saw you were a contributor to RS and thought were saying it was on this end.  I didn't realize you were from Tech Reborn.

How is the status of this? Just made a modpack with buildcraft + tech reborn + refined storage and while testing it I noticed I can't connect my TR battery with the RS controller.

It will be done when it's done.


Yuv to rgb changes

Updating Foxy to include function to convert YUV format images into RGB inside rviz.
Fixes #682

@asobhy-qnx

Linux
Linux-aarch64
macOS
Windows

CI warnings on MacOS and Windows are unrelated. Merging!


Use log instead of resolve ref

Hello jbwatenbergscality,
My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.
Status report is not available.

Waiting for approval
The following approvals are needed before I can proceed with the merge:

the author

one peer

/approve

Waiting for approval
The following approvals are needed before I can proceed with the merge:

the author

one peer

The following options are set: approve

In the queue
The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.
The changeset will be merged in:

:heavy_check_mark: development/3.1

The following branches will NOT be impacted:

development/1.0
development/2.0
development/3.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.
IMPORTANT
Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.
The following options are set: approve


New Graphics Backend

The version of the project that was handed in was made with a DirectX9 graphics backend which has proved to be challenging for creating and rendering textures from a byte stream.
This issue aims to address this as an issue that can be fixed by swapping out the backend with OpenGL or possibly rewriting the entire frontend on the OpenGL backend.

This can't be achieved within the time constraints before the exam.


Added modifier spinner in nutrients editing. Fixes API.

Will fix #2605
Also fix the API problem found by @teolemon.

I added closes #2605 @VaiTon assuming it's a full fix

3 little conflicts to solve @VaiTon

Just tried from trunk:


Realm crashes when using with AsyncDisplayKit

I am not sure where to ask so I put this question in AsyncDisplayKit issue and here as well.
I recently integrated Realm to my existing project and encountered a lot of crashes. All of them are  libc++abi.dylib: terminating with uncaught exception of type realm::IncorrectThreadException: Realm accessed from incorrect thread..
I make sure that all of Realm objects' creation, access happen in main thread. And it looks like the crashes happen only when the attributed string contains emojis or special characters. Any idea what could be wrong?

I am also looking for the same issue. Please can anyone help, Can we use Realm With AsyncDisplayKit or not ?

@tungvoduc - To avoid this, you can use ThreadSafeReference https://realm.io/news/obj-c-swift-2-2-thread-safe-reference-sort-properties-relationships/ it can be passed across the threads. Follow this I was also facing the same issue, got the answer on Realm Slack Channel.

Thread-safe references are definitely the answer to this. Closing.


refactor: set karma as default

Set Karma as default
Run Jest spec files in test/unit, rather than test/unit/specs
https://github.com/vuejs-templates/webpack/issues/1062

See #1074 - I think we get Jest running on windows after all :)

FYI: Jest is the only thing that I can get to actually run my tests on windows.

It seems the new setup will work, I'll close this for now. We can still revert if we come across other problems.


build: fix update license workflow

Coverage remained the same at 100.0% when pulling 908a2eb7d15b7a51fd7547c256bd6c1296f6a1b3 on fix-update-license into 29e080c24ec9a5897ea4fe783369bea7327d1a4c on main.

Coverage remained the same at 100.0% when pulling 908a2eb7d15b7a51fd7547c256bd6c1296f6a1b3 on fix-update-license into 29e080c24ec9a5897ea4fe783369bea7327d1a4c on main.

:tada: This PR is included in version 1.2.11 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


is this mod still being developed?

is this mod still being developed?

i hope it is id love to see a 1.21.1 version
ive yet to find a alternative to fix the many translation based crashes ive encounterd


"Math domain error" problem

Hi! I am trying to run the metk.py in my computer using the file as an example, however I am getting an error after I type this:
python metk.py --in /Users/Danniel/metk/fep_kcal.csv --prefix test_pw
As you can see, I am omitting the [--units uM] and [--example], as I want to leave the default values, and the error I am getting is the following:
Traceback (most recent call last):
  File "metk.py", line 28, in <module>
    df = ki_to_kcal_df(df)
  File "/Users/Danniel/metk/modelevaltoolkit/metk_util.py", line 126, in ki_to_kcal_df
    new_df['Pred'] = [ki_to_kcal(x, units) for x in df['Pred']]
  File "/Users/Danniel/metk/modelevaltoolkit/metk_util.py", line 55, in ki_to_kcal
    return math.log(ic50 * multiplier) * 0.5961
ValueError: math domain error

Thanks in advance!

I believed it's because you have negative values in the document, and it looks like the values you have belong to delta G, is that correct?

  The metk.py script expects the input to be in kcal/mol.  The call to ki_to_kcal should have been commented out.  This has been fixed.  My apologies for any hassles.

Thank you! That is very helpful! So, just to make sure... The code only takes files which input is kcal/mol? So, whenever I call the program in the terminal, should I avoid the [--units uM]? if I do so, will it consider kcal/mol by default?
Thanks again!

Input is always in kcal/mol.   The --units flag only affects the second plot in the pdf output.   You can change whether that plot is displayed with uM or nM as the units.  I'll make this more clear in the README file.

I see, thank you for the clarification!


Update react-scripts to 5.0.0

Related Issue or Background Info

Part of #2908
We are actually already on the latest stable version of react, 17.0.2. However, React 18 is in rc and release is imminent. I will be keeping an eye out to see if it releases in the next few days.
In the meantime, this PR updates react-scripts, along with a slew of other packages that need updating along with it, including uswds
Resolves #2909

Changes Proposed

Update react-scripts to 5.0.0
Removed craco. We only use it to allow sass mixins in component sass files, which we only did in one file. See #1676 and #1681. I decided to remove since it reduces our build complexity, and we don't really have any sass/uswds experts on the team anymore, so it seems unlikely that we will use mixins anyways.
Update testing library packages since react-scripts upgraded jest
Fix three tests that broke after the upgrades, luckily nothing too crazy needed to change
Since react-scripts also updated eslint to 8.x, needed to update some eslint plugins and change some eslint configuration, including adding a typescript parser for it, see more here
Because of the update to webpack 5, needed to update uswds to 2.13.0 as well. Along with this I had to change the way we import some uswds icons
Update sass to 1.47.0. Along with the uswds upgrade this seems to have finally cleared out all the useless deprecation warnings and changelog notes we get when running the frontend!! :tada:
Updated typescript to 4.5.4, and fixed a whole bunch of ts errors in our tests
Update various storybook packages so that storybook can use webpack 5

Additional Information

The updates seemed to change our CSS output in a few places, so I'm working through making sure there are no UI changes (thanks Chromatic!)

Screenshots / Demos
Checklist for Author and Reviewer
Infrastructure

[ ] Consult the results of the terraform-plan job inside the "Terraform Checks" workflow run for this PR. Confirm that there are no unexpected changes!

Design

[ ] Any UI/UX changes have a designer as a reviewer, and changes have been approved
[ ] Any large-scale changes have been deployed to test, dev, or pentest and smoke-tested by both the engineering and design teams

Content

[ ] Any content changes (including new error messages) have been approved by content team

Support

[ ] Any changes that might generate new support requests have been flagged to the support team
[ ] Any changes to support infrastructure have been demo'd to support team

Testing

[ ] Includes a summary of what a code reviewer should verify

Changes are Backwards Compatible

[ ] Database changes are submitted as a separate PR

[ ] Any new tables that do not contain PII are accompanied by a GRANT SELECT to the no-PHI user
[ ] Any changes to tables that have custom no-PHI views are accompanied by changes to those views
(including re-granting permission to the no-PHI user if need be)
[ ] Liquibase rollback has been tested locally using ./gradlew liquibaseRollbackSQL or liquibaseRollback
[ ] Each new changeset has a corresponding tag

[ ] GraphQL schema changes are backward compatible with older version of the front-end

Security

[ ] Changes with security implications have been approved by a security engineer (changes to  authentication, encryption, handling of PII, etc.)
[ ] Any dependencies introduced have been vetted and discussed

Cloud

[ ] DevOps team has been notified if PR requires ops support
[ ] If there are changes that cannot be tested locally, this has been deployed to our Azure test, dev, or pentest environment for verification

This should be ready for review now! There were 8 UI changes in Chromatic, but I honestly couldn't tell the difference by visual inspection, so I just went ahead and accepted them.


⚠ GTru has degraded performance

In 661b0fc, GTru ($GTRU) experienced degraded performance:

HTTP code: 200
Response time: 5528 ms

Resolved: GTru performance has improved in c1b20cb after 7 minutes.


Introduce WasmInputStream for reading WASM files

Parse all sections streamwise
Do not keep any portion of the file in memory during parsing other than what is needed to parse the current element
Ensure that all sections are parsed safely even if there is extraneous data

If there are no further comments, I'd like to move ahead with this.

https://github.com/dylibso/chicory/blob/main/CONTRIBUTING.md#code-reviews

I'm aware, thanks. Are you saying you are not interested in having this change, or my subsequent changes which depend on it, and that your citing of this policy is indicative of your decision to block this change? If so, it would probably be better to say so directly, because then I can get on with developing what I need under my own fork without having to be delayed by upstreaming. If not, then let's continue the discussion properly.

@andreaTP, I'll add a third option: non-response. If you are no longer interested in reviewing this change, I will dismiss your review and allow someone else to have a look instead.

Sorry I'm just getting around to looking at this PR. I'm supportive of where this is going, but I think we should hold off on it. There are a lot more changes than I thought would be necessary. I'm having trouble understanding it and keeping up. I'd like to keep work focused on the milestones: Improving our test posture and specification coverage. I worry all these changes are making it harder to understand what is happening in the codebase. I understand some of the arguments for how these are improvements, but the cost of not understanding them is too high this early in the project.

If you look at WasmInputStream as an encapsulated interface, it should be very straightforward: methods to read each exact value type without casting, smart handling of sections, lookahead (peek) is handled for you. The interface itself is simple and as spec-correct as possible, and that is the most important idea.
To help understand how this simplifies things, start by looking at the code where sections are parsed. In each case, the code is simplified or at worst made more readable by eliminating casts (or replacing them with explicit transformations in a few select places), and reading things by their WASM type as given in the spec. Having a spec-direct and simple API also serves to make things more correct (for example, using limited-range *LEB decoding to detect errors on invalid input which previously were allowed, and correcting our still-incorrect UTF-8 validation behind a simple API).
In terms of encapsulation, this PR moves code complexity from a central hub class (Parser) to a leaf class which encapsulates the idea of reading WASM data, and removes direct reliance on ByteBuffer, which has already been labeled as user-unfriendly in this PR comment section. Its symmetrical counterpart, WasmOutputStream which is already written, will do the same for output.
The immediate next step after this patch is to move each section's individual parsing code to that section's class, further reducing the conceptual complexity of Parser (which today does many distinct jobs related to parsing). This patch is also ready to go.
An additional and critical benefit of this code is of course that currently, the entire WASM program must be held in memory, even if it is quite large, especially in the case where you start with an InputStream (where the entire stream must be copied). By encapsulating input behind a stream, we can still support in-memory buffers (including memory-mapped files), and also plain InputStream. Since there is a layer of encapsulation, we can also support reading from a MemorySegment in Java 22+ by adding one implementation class. Retaining ByteBuffer as an input type is not tenable, and it is definitely not tenable as an output type (since buffers must be pre-sized).


[HOLD, RC1] Blazor catch-all parameters

Fixes #19632
Based on:

https://github.com/dotnet/aspnetcore/issues/25199#issuecomment-679321134
https://github.com/dotnet/aspnetcore/pull/24038#issuecomment-660154330

So initially when implementing this I was confused by looking at MVC routing and thought that ** should be implemented as part of this feature.  Turns out the ** was specifically talking about URL building rather than actual routing.
In the end, the current Blazor router only allows * -- we will throw for more than one * (see TemplateSegment.cs:25) to protect for potentially using ** in the future.
So in other words, we don't need to mention ** or anything to do with encoding/decoding, as whatever is captured in the catch-all parameter should come through as-is.

@zbecknell ... Sorry that I didn't read the whole convo over there. It was a TL;DR to me at like 4am! :smile: lol

should come through as-is

... but I thought you said that you do decode at ...
https://github.com/dotnet/aspnetcore/pull/24038#discussion_r456513976

No worries!  And now I'm adding to the confusion!  I shouldn't have said "as-is" -- a catch-all won't be decoded any differently than other params.  So  for /blog/{*parameter}, /blog/value1/foo%20bar -> parameter == "value1/foo bar"

Is a slash included? For /blog/value1/foo%20bar, which would be captured into the var ...

value1/foo bar
/value1/foo bar

Negative, the first slash is part of the template, so it's not included.

Yes ... I see what you mean. /blog/{*parameter} ... "/blog/" ... gotcha. Thanks.

kk ... I think we're good here. We'll just wait and see when Artak wants these RC1 PRs merged ... now or at RC1 release.

We're going to temporarily surface it this way (see the diff). I'll update this when RC1 releases and then again at .NET 5 GA.


NotImplementedError in soft_actor_critic

Hi :)
I got NotImplementedError at "next_state, reward, done, _ = env.step(action)" and when I set  "env = gym.make("Pendulum-v0")", it'd be solved.
thanks for your support

but the algorithm still not have a good performance.
so how to solve it ...

Hi, I also have same problem "NotImplementedError at "next_state, reward, done, _ = env.step(action)", can you please help to fix it? thanks a lot!

Hi, I also have same problem "NotImplementedError at "next_state, reward, done, _ = env.step(action)", can you please help to fix it? thanks a lot!

you should change the function name: ''_action'' to ''action''
before:
def _action(self, action):
        low  = self.action_space.low
        high = self.action_space.high

        action = low + (action + 1.0) * 0.5 * (high - low)
        action = np.clip(action, low, high)

        return action

after:
def action(self, action):
        low  = self.action_space.low
        high = self.action_space.high

        action = low + (action + 1.0) * 0.5 * (high - low)
        action = np.clip(action, low, high)

        return action

Thank you so much!
On Wednesday, 28 October 2020, 01:20:52 am GMT-7, baimengwei<EMAIL_ADDRESS>wrote:
Hi, I also have same problem "NotImplementedError at "next_state, reward, done, _ = env.step(action)", can you please help to fix it? thanks a lot!
you should change the function name: ''_action'' to ''action''
before:
def _action(self, action):        low  = self.action_space.low        high = self.action_space.high                action = low + (action + 1.0) * 0.5 * (high - low)        action = np.clip(action, low, high)                return action
after:
def action(self, action):        low  = self.action_space.low        high = self.action_space.high                action = low + (action + 1.0) * 0.5 * (high - low)        action = np.clip(action, low, high)                return action
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi, I have the same error with NotImplementedError at "next_state, reward, done, _ = env.step(action)", when I delete _ in the action and reverse_action it still doesn't work? Does anyone meet this issue before? btw, I am running ddpg example.


Remarks and doc updates for objectId escaping on aad set and remove

Remarks and doc updates for objectId escaping on aad set and aad remove.  In rare situations, escaping an objectId may be required if the objectId contains a minus sign (-) prefix.

@waldekmastykarz this PR looks a little better. :-)   Thanks for your patience!

Excellent! Thank you once again @pkskelly! I'll process it shortly.

Merged manually. Thank you!


Add Route53 health checks to all domains

Not really sure what this entails, but it sounds like something we should have for a public site... 😬

So on further investigation, I don't think this is something we really need at all. I thought a health check was something to check the health of a DNS record itself, like to make sure those records were still reachable or something. Really, the health check on a record set is for checking other endpoints, and Route53 decides whether or not to return the record set in DNS queries based on the health of that other endpoint. Apparently it's used for DNS failover, and cases involving more complex multi-host routing setups, none of which we need here. See these Route53 health check docs for more info.


feat: Wide info card subtitle + redesign. #967

API changes
Added subtitle optional prop.
Closes #967
Closes #1029

Looks good:

API changes
Implementation with image

Needs design changes:

When an icon is used, the ratio of icon:text needs to be higher. See Slide 3 in the design feedback Keynote.

The intent of this card (and tall_info_card) is to "lead-in" into other content (e.g. summary-to-detail, call-to-action, etc.), so it needs to be clickable (either the card itself or via a button).
This would mean that the card needs a mandatory name, with behavior matching button.name, and an optional label. If label is specified, render a button; if not, make the entire card clickable.
I'm assuming that the wide_info_card in this PR covers both the "WideInfoCard" and "centered_wide_info_card / Complex_wide_left_img_text" in XD. If so, the "centered_wide_info_card" already has design variations for card-with-button and card-without-button.

Added label and align props.
https://user-images.githubusercontent.com/64769322/136018578-10d8d1dc-e6df-46c7-910b-fbeb02dc8e39.mov
align='right':

waiting for design team to address comment above

Hi @mturoci it's tricky to provide a solid deterministic approach for color selections as we don't know in advance what colors a user will choose.
What we can provide as a solution is to:

identify UI elements that are contrasting/ less visible etc.
introduce new color variables to these UI elements eg: icon color and icon foreground.

Using Fluent UI Theme Designer to generate colors would cover some parts of the UI with accessibility issues but not all aspects, so I don't think it's a solid approach.

It seems foreground color is taking too much attention in light and yellow theme. can we use neutralLight for foreground?

The contrast in neon theme is not enough:

it's tricky to provide a solid deterministic approach for color selections as we don't know in advance what colors a user will choose

Right, not easy, but doable.

introduce new color variables to these UI elements eg: icon color and icon foreground.

Sounds good, just make sure they are based off the current theme, not hardcoded values.

@mturoci idea is to have attention to foreground like in neon theme. So NeutralLight would good to use as foreground color. We only need to highlight icon and that is contrast enough in every theme

@mturoci It is to make it a consistence UI element because icons width and height changes from icon to icon. Because of this circle it always take same space and consistence on each card

width and height changes from icon to icon

These are minimal, maybe less than 1px differences as we use font-icons, but if the only issue is space, the wrapper can be transparent. Right now, it looks odd since it is there, but barely visible.
If you want to make the wrapper less prominent, what about going with very light text color (text1)? Would look like this:

@shihan007 is it good as it is?

@lo5 wdyt about background prop? I vote to remove it since it can break contrast with text easily.

No, I thought this is how you wanted based on designs - align with the bottom edge of the image. Should I put it right after the textual content?

A card can be of any height / width user wishes. That means having hardcoded dimensions (like in the example above) or let the content dictate the dimensions (flex layout).

For tallinfo card with an icon the spacing should be 16px between content and button. Also, the height of the card should depend on the content.

This is implemented already, just the example uses hardcoded values.

For tallinfo card with an image, you can align the button to the image at the very bottom. As we don't have control over the image height.

We don't honor image height, we fit the image to the card height.
The goal of all the cards in Wave is to provide a good experience experience for both fixed dimensions and content (flex) dimensions.
So both of the comments are already addressed.


Update?

When is 1.13 support expected?
Unfortunately, it prevents switching to server version 1.13, and the development is not working yet.

Use ProtocolSupport as an alternative for the time being.

Thanks, but I still use this one but it uses a lot of memory. So I asked when a complete update of ViaBackwards is expected?

There is no expected date.


feat: add BitVec.(msb, getMsbD)_(rotateLeft, rotateRight)

This PR adds theorems BitVec.(getMsbD, msb)_(rotateLeft, rotateRight).
We follow the same strategy taken for getLsbD, constructing the necessary auxilliary theorems first (relying on different hypotheses) and then generalizing.

got it @kim-em! And thanks for reviewing this :)


Add configure flags to conditionally build grpc plugins

Add configure flags to conditionally build grpc plugins.
We want to be able to make install only grpc_cpp_plugin (or others, conditionally), as others just bloat our docker images and increase compilation time.

Sorry, found these
        -DgRPC_BUILD_GRPC_CSHARP_PLUGIN=OFF \
        -DgRPC_BUILD_GRPC_NODE_PLUGIN=OFF \
        -DgRPC_BUILD_GRPC_OBJECTIVE_C_PLUGIN=OFF \
        -DgRPC_BUILD_GRPC_PHP_PLUGIN=OFF \
        -DgRPC_BUILD_GRPC_PYTHON_PLUGIN=OFF \
        -DgRPC_BUILD_GRPC_RUBY_PLUGIN=OFF \
        -DgRPC_BUILD_GRPC_CPP_PLUGIN=ON \


Add YAML file to tell CI which distros to build

New CI jobs move (more of) the configuration from the jenkins repo to the individual project repos. So now this needs to be configured here instead of in the 'Jenkins' repo.

ci build please


When following tutorial for "Create a custom task with MSBuild" project give warning NU5128

When following the linked tutorial, I get this warning from running nuget pack.
Warning	NU5128	Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below:
- Add lib or ref assemblies for the netstandard2.0 target framework

I can work around the issue by doing "Scenario 2" from the reference NuGet warning: https://learn.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu5128#scenario-2
Is it possible to:

At a minimum (assuming it's correct) add the _._ workaround to the tutorial so users following the tutorial don't get warnings?
Is it possible to package these steps up as their own set of .props and .targets files so that each MSBuild assembly doesn't need to repeat all of these steps?

If there are any questions / concerns, please let me know. Thanks!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6cf3ed7e-8425-d255-938b-7319e865fd9a
Version Independent ID: 6cf3ed7e-8425-d255-938b-7319e865fd9a
Content: Create a custom task with MSBuild - MSBuild
Content Source: docs/msbuild/tutorial-custom-task-code-generation.md
Product: visual-studio-windows
Technology: msbuild
GitHub Login: @ghogen
Microsoft Alias: ghogen

@MattKotsenas -- Matt, thank you for your feedback and question.  Please consider these resources:

Ask a question or find an answer on the Microsoft Q&A page for Visual Studio.
Check the Visual Studio MSDN Forum.
Stack Overflow
Reddit

@ghogen -- Gordon, please look into this issue.

I think this is because the nuspec by default contains an empty dependencies section, which leads to this warning. We can avoid that by adding SuppressDependenciesWhenPacking (set to true) in the project file.
See https://github.com/NuGet/Home/issues/5132


See plots of the results of trials over time

US 01.06.01
As an owner or experimenter, I want to see histograms of the results of trials.
more elaborate:
US 01.07.01
As an owner or experimenter, I want to see plots of the results of trials over time.
Rationale:
to analyze the data of the experiment over time
to observe the trend of experiment
Story points: 11
Risk level: low

US 01.09.01
As an owner or experimenter, I want to observe statistics (quartiles, median, mean, stdev) about a current trials.

Give me summary statistics of a trial.

US 01.06.01
As an owner or experimenter, I want to see histograms of the results of trials.

Show me the proportions of answers, not meaningful for count, but meaningful for binomial and non-negative and measurement.

US 01.07.01
As an owner or experimenter, I want to see plots of the results of trials over time.

Binomial: show the proportion of success over time
Count: show count increase over time
Non-negative: show mean over time? Quantiles over time?
Measurement: show mean over time? Quantiles over time?


Support dependencies autoupdate

Support a way of automatic dependency updates (add some bot?).

The following should enable Dependabot:
# To get started with Dependabot version updates, you'll need to specify which
# package ecosystems to update and where the package manifests are located.
# Please see the documentation for all configuration options:
# https://docs.github.com/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file

version: 2
updates:
  - package-ecosystem: "" # See documentation for possible values
    directory: "/" # Location of package manifests
    schedule:
      interval: "weekly"

You'll need to find the right value for package-ecosystem and make sure the directory points to where your package manifest sits.

Configuration options for the dependabot.yml file

@jigga - drop a comment on this issue and we can assign to you 👍

Reopening this issue as we don't currently have Dependabot PRs spinning up for some reason 🤔

@JamieSlome  please see https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuring-dependabot-version-updates#enabling-dependabot-version-updates.
I have no access to settings , thefore assigning to you.

Thanks @jigga for your valuable contribution!

@magner669 - it is already enabled. Something is failing here.

Yup , looks like it cant open  a pull request.
https://github.com/Citi/gradle-helm-plugin/network/updates/814223866

@magner669 @jigga - I think adding the following to the workflow file will work:
permissions:
  pull-requests: write

How do you explain the file without this chagnge working as is on @jigga 's clone?

@magner669 - figured it out 🎉 Dependabot is unable to create new branches as we have configuration settings which lock down who can create new branches 👍
I will adjust to support this new requirement.

Can we close this ?

@magner669 - yep! 👍

@imanushin @magner669 - please see https://blog.gradle.org/gradle-github-partnership-supply-chain-security


Proposals

So I was planning on creating a PR for gdExtension, but before I get started, I would like to propose a couple of things for consideration.
Integrate build system more tightly:
Currently it is expected that wasmer be downloaded and extracted manually before compilation. This is fine, but it is also possible to semi intergrade it into the scons build system so that its built from source via a git submodule. This wont be as simple as just having scons compile it, as its written in rust. But for an example you can see what I have done for luaJIT here which has similar issues. I think this approach could work here.
Potentially support engine module builds:
gdExtension is still in a very early stage. But one of the upsides is that code written for it is 98% the same as module code. So if support is to come for gdExtension I think there should be a compile time option as well to build as a engine module.
Would like to hear any input you have on regarding this.

Integrate build system more tightly

Good suggestion. Although I'd push back on compiling from source and instead opt for downloading the binaries (and universalizing in the case of macOS) in the Scons workflow. Might be wise to download if either A) wasmer directory does not exist implying we're building for the first time, or B) a download-wasmer (or similar) option is set e.g. scons platform=... download-wasmer=yes. The Wasmer folks seem to be pretty good with builds and releases. Wasmer version could even be a Scons option. Do you see any advantage to building Wasmer from source?

Potentially support engine module builds

If this is easy to do, I'm all for it. That said, it's not going to be my priority as the addon approach will suffice for anyone looking to play around with Godot Wasm and there's lots more to do before a 1.x is reasonable.

Do you see any advantage to building Wasmer from source?

Looking into it more, there would not be much of an advantage other then convince. I think a scons option to download and unpack could achieve the same thing. I saw the download page did not include static libraries and had hoped if we compiled from source, static would be an option. But looking at the docs it seems it may only build as a shared library.

If this is easy to do, I'm all for it. That said, it's not going to be my priority as the addon approach will suffice for anyone looking to play around with Godot Wasm and there's lots more to do before a 1.x is reasonable.

I think at least for a potential godot 4 version this would be a good idea, as I have ran into lots of random bugs and stability issues with gdextension, and assuming the changes are made for gdextension the extra support would take minimal effort.

Can a godot 4 branch be made to target PRs at?

@Trey2k Thanks for opening this issue and kicking off discussion. Keep the fantastic suggestions coming! Update re: some of the points raised above:

Created a branch for Godot 4 PRs.
Using static libs as of https://github.com/ashtonmeuser/godot-wasm/commit/d0ff4313734a1b22448d118ec9c45cecfb77b1fb.
Wasmer is now downloaded in the SConstruct build process if directory is missing or download-wasmer=yes option provided.
Created and labelled a bunch of new issues for improvements mentioned above.

I did minor patching for janked version of downloading the wasm libraries here https://github.com/V-Sekai/godot/tree/wasm

@fire Can you expand on the janked Wasmer download? It seems to work for Linux, macOS, and Windows in CI build but if there's an issue, I'll address it.

I'll see if find some time tomorrow night to reply.

No rush. I think I see the issue you're describing and tried to capture it in #22.

godot-wasm engine module builds are completed. There's a bug with msvc, but that's a bug.

Yep gonna close. New proposals can come in as their own issues. Provided we get MSVC builds working, I'd be happy with the the existing functionality as a v1.0.


Give a more complete example of how sum and avg functions could be used

This is not an issue but I can't get sum or avg working.
I have one table data with a column temp (which is a i16 or temp -> Nullable<Int2> in schema.rs).
I tried:
        let source = data::dsl::data
            .select(dsl::avg(data::dsl::temp));
        let avg_data = source.get_result(&con).unwrap();

but when compiling, I got this:
54 |         let avg_data = source.get_result(&con).unwrap();
   |             ^^^^^^^^ consider giving `avg_data` a type

So I changed to:
        let avg_data: sql_types::Numeric = source.get_result(&con).unwrap();

But then I got:
54 |         let avg_data: sql_types::Numeric = source.get_result(&con).unwrap();
   |                                                   ^^^^^^^^^^ the trait `Queryable<diesel::sql_types::Nullable<diesel::sql_types::Numeric>, Pg>` is not implemented for `diesel::sql_types::Numeric`

I can't find a solution to solve this...
Help is welcome.

As mentioned in several places in the documentation: Types from diesel::sql_types are not designed to hold any value on rust site. See the documentation of those sql typea for compatible rust types.
Also: Pleaseask further questions in our gitter channel or in our forum, not in the issue tracker.

Thanks for your answer.
Yes, I know and sorry for that, but I could not find the forum and still can't find it...
I will try gitter in the worst case.

The forum can be found here.
Closed as this is nothing that is actionable for anyone of the contributors.

Hi @sideralis
This is required nullable, so:
let avg_data: Option<i64> = source.get_result::<Option<i64>>(&con).unwrap();


Minor error in docs

This Issue is about (delete as applicable)

An error in the documentation

Right here:
https://github.com/photonstorm/phaser/blob/dev/docs/Phaser.GameObjectFactory.html#L3335
I think it is supposed to say Creature instead of Sprite?

Link does not work anymore. Is it fixed or what is the status?

Alternative links that may be useful/helpful:
http://phaser.io/docs/2.6.2/Phaser.GameObjectFactory.html#creature
https://github.com/photonstorm/phaser/blob/v2.6.2/src/gameobjects/GameObjectFactory.js#L144
https://github.com/photonstorm/phaser/blob/master/v2/src/gameobjects/GameObjectFactory.js#L144
I see in v3 on master it's been refactored heavily so this may not be an issue.


crazyflie_py: fix flake8 and pep256 issues

Hi @knmcguire, this is one of 3 PRs that essentially enable Python code linting for crazyswarm2 (using mostly flake8). Since the tests where failing before, quite many (whitespaces) changes were needed. Thanks for double checking!

These tests are the default ones that get created when you create a new package (I deleted one check, that checks that every file has some "copyright information", because I believe that having a LICENSE per repo is sufficient). We just had those tests disabled, because well - they failed:-)


Remove duplicate check for label validity

While looking through the code, I noticed a redundant check to see if the supplied label name was valid. This PR removed that redundant check.

@jberzy Please fill in the optional (not for us) extended description -

@jrgemignani I can't seem to find that extended description form anywhere.

@jrgemignani I can't seem to find that extended description form anywhere.

When you create a commit, it is the message for the commit. It isn't to be confused with the PR.

@jrgemignani  Thanks. The commit should contain the extended description now.

@jberzy If you would be so kind as to create PRs off of this one for the PG16, PG15, PG14, & PG13 branches?


Problems when using with title and jquery.phoenix

Using jquery.phoenix  (https://github.com/kugaevsky/jquery-phoenix) for the bootstrap-select:
If we use without a title:
            <select class="selectpicker">
                <option value="A">A</option>
                <option value="B">B</option>
                <option value="C">C</option>
            </select>
            <script>$('select').phoenix();</script>

It is totally OK.
If we use with a title:
            <select class="selectpicker" title="Please select">
                <option value="A">A</option>
                <option value="B">B</option>
                <option value="C">C</option>
            </select>
            <script>$('select').phoenix();</script>

It is not OK. Everytime when refreshing, it only shows the title, not the last used option

Closing as non reproducible and too old anyway.


Added ObsoleteAttribute to unused ViewEngine property

What it says on the tin...
Closes #5066
Closes #4916

:shipit:

:shipit: , though this does not close https://github.com/aspnet/Mvc/issues/4916. https://github.com/aspnet/Mvc/issues/4916 is for 2.0.0 where we'll actually remove the property.

@pranavkm please merge when ready. Please make sure GitHub doesn't close the wrong issue (it auto-closes based on commit text).


Implement Markdown Changelog Message Feature in Inbox System

Implement a changelog message feature to our inbox system before the public launch of the dimension. The content format should be in Markdown to facilitate the inclusion of release notes with images. The changelog message should include a short title and description for preview purposes. Additional details such as the author's name and the date of publication should also be displayed. Coordinate with our designer for the visual layout of this feature. The steps to complete this task are as follows:

Design the structure of the changelog message feature, ensuring it supports Markdown format.
Implement the feature into the inbox system.
Include fields for a short title and description.
Add fields to display the author's name and date of publication.
Test the feature thoroughly to ensure it works as expected.
Coordinate with the design team for the visual layout.
Conduct a final review and make necessary adjustments before the public launch.

lgtm!


Access bits of a Logic by Logic index

Motivation
Sometimes it's desirable to access a bit of a Logic signal by another Logic.  This is achievable with >> n and & Const(1), but it would be nice to just use [n] directly to generate that code for ease of use and readability.
Desired solution
Modify the overloaded operator[] on Logic so that it can accept either an int or another Logic, and appropriately generates hardware if necessary (if it's a Logic).

Hi, can I take this one next?

It might be a good idea to make a new custom module so that the generated output SystemVerilog has [] instead of << &1


Sort Options on Posts Page

A minimal bar above posts that allows for filter & sort
Options:

Sort by date
Filter by tag(s)

Also add Sort by Popularity and Likes


List more bindable actions in help keybindings

The list in help keybindings was missing a few useful bindable actions such as ForceQuit.

But it still doesn't really fit to the content of bufpane.go#L686 or am I overlooking something (108 vs 112 entries)? Additionally it would be easier to maintain when we stick to the same order in both lists, then it can simply being diffed.


Is it enabled rtdm, if I run configure  --disable-8139too --enable-rtdm?

@rise0chen Hello, did you get RTDM working with this crate?

This crate used ioctrl


Problems with leafref

Hi,
I am trying to use leafrefs but it seems that they don't work in Netopeer2.  Here is a snippet of the yang file:
    rpc restart {
            input {
                    leaf package {
                            type leafref {
                                 path "../../packages/name";
                            }
                    }
            }
    }

    leaf refaa {
            type leafref {
                 path "../packages/name";
            }
    }

list packages {
	key "name";
	leaf "name" {
		type "string";
	}
	description "Packages list";
}

When I try to set the leaf "refaa" with an edit-config operation, netopeer2-server crashes and the log says:
netopeer2-server[4655]: EDIT_CONFIG: ds 4754840, defop 1, testopt 0, config:
<refaa xmlns="http://www.tiesse.com/ns/tiesse-cli/1.0">ethernet</refaa>

netopeer2-server[4655]: (cl_request_process:420) Sending session-refresh request.
netopeer2-server[4655]: (cl_request_process:442) session-refresh request sent, waiting for response.
netopeer2-server[4655]: (cl_request_process:464) session-refresh response received, processing.
netopeer2-server[4655]: EDIT_CONFIG: leaf /tiesse:refaa, operation 1
netopeer2-server[4655]: Memory allocation failed (/home/stefano/Progetti/nos/branches/X.4.5-6.netconf/sources/tiesse/src/netopeer2/Netopeer2/server/operations.c:221)

Also sending the rpc "restart" is not working, netopeer2-server does not crash but it gives the following error:
netopeer2-server[4863]: Session 2: received message:
<?xml version="1.0" encoding="UTF-8"?>
<rpc xmlns="urn:ietf:params:xml:ns:netconf:base:1.0" message-id="c5499470-d97a-11e6-9a4b-e91c7bb5fdf6">
  <cli:restart xmlns:cli="http://www.tiesse.com/ns/tiesse-cli/1.0">
    <cli:package>ethernet</cli:package>
  </cli:restart>
</rpc>

netopeer2-server[4863]: DICT: inserting "rpc" with collision
netopeer2-server[4863]: DICT: inserting (refcount) "urn:ietf:params:xml:ns:netconf:base:1.0"
netopeer2-server[4863]: DICT: inserting "message-id" with collision
netopeer2-server[4863]: DICT: inserting "c5499470-d97a-11e6-9a4b-e91c7bb5fdf6" with collision
netopeer2-server[4863]: DICT: inserting (refcount) "restart"
netopeer2-server[4863]: DICT: inserting (refcount) "cli"
netopeer2-server[4863]: DICT: inserting (refcount) "http://www.tiesse.com/ns/tiesse-cli/1.0"
netopeer2-server[4863]: DICT: inserting (refcount) "package"
netopeer2-server[4863]: DICT: inserting (refcount) "ethernet"
netopeer2-server[4863]: DICT: inserting "" with collision
netopeer2-server[4863]: DICT: inserting (refcount) ""
netopeer2-server[4863]: DICT: inserting (refcount) "ethernet"
netopeer2-server[4863]: Resolving unresolved data nodes and their constraints...
netopeer2-server[4863]: Leafref "../../packages/name" of value "ethernet" points to a non-existing leaf. (/tiesse:restart/package)
netopeer2-server[4863]: DICT: inserting "Request could not be completed because the relevant data model content does not exist."
netopeer2-server[4863]: DICT: inserting "en" with collision
netopeer2-server[4863]: DICT: inserting "instance-required" with collision
netopeer2-server[4863]: DICT: inserting "/tiesse:restart/package" with collision
netopeer2-server[4863]: DICT: inserting "Leafref "../../packages/name" of value "ethernet" points to a non-existing leaf." with collision
netopeer2-server[4863]: DICT: inserting "en" with collision
netopeer2-server[4863]: Session 2: sending message:

#474

[2016/05/30 13:16:25.849639, 3] ssh_socket_unbuffered_write:  Enabling POLLOUT for socket
[2016/05/30 13:16:25.855271, 3] packet_send2:  packet: wrote [len=28,padding=12,comp=15,payload=15]
[2016/05/30 13:16:25.855588, 3] channel_write_common:  channel_write wrote 6 bytes
netopeer2-server[4863]: Session 2: sending message:
<rpc-reply xmlns="urn:ietf:params:xml:ns:netconf:base:1.0" message-id="c5499470-d97a-11e6-9a4b-e91c7bb5fdf6"><rpc-error><error-type>application</error-type><error-tag>data-missing</error-tag><error-severity>error</error-severity><error-app-tag>instance-required</error-app-tag><error-path>/tiesse:restart/package</error-path><error-message xml:lang="en">Leafref "../../packages/name" of value "ethernet" points to a non-existing leaf.</error-message></rpc-error></rpc-reply>

[2016/05/30 13:16:25.856761, 3] packet_send2:  packet: wrote [len=492,padding=8,comp=483,payload=483]
[2016/05/30 13:16:25.857058, 3] channel_write_common:  channel_write wrote 474 bytes
[2016/05/30 13:16:25.857345, 3] ssh_socket_unbuffered_write:  Enabling POLLOUT for socket
netopeer2-server[4863]: Session 2: sending message:

##

[2016/05/30 13:16:25.858086, 3] packet_send2:  packet: wrote [len=28,padding=14,comp=13,payload=13]
[2016/05/30 13:16:25.858371, 3] channel_write_common:  channel_write wrote 4 bytes
[2016/05/30 13:16:25.858624, 3] ssh_socket_unbuffered_write:  Enabling POLLOUT for socket

In the "packages" list there is the "ethernet" instance and both operations work in sysrepo, respectively with the sr_set_item and the sr_rpc_send function, using the value "ethernet" as above.
Thanks

Hi,
this is a bug that required a rather extensive modifications, so we included it only in the devel branch of libyang. I tried your examples with the devel branch and it required further changes and bugfixing, but should now work. So, if you can, use libyang from the devel branch (this will require to also use libnetconf2, netopeer2-server, and sysrepo from their devel branches) or you must wait until it will be merged into master (rough estimate is the end of February).
Reagrds,
Michal


DEBUG:root:made sure table exists

$ pycardsyncer -c pycard.conf -a private --debug
DEBUG:root:Using configuration from pycard.conf
DEBUG:root:Ignoring query:where in configuration file
DEBUG:root:Ignoring default:debug in configuration file
DEBUG:root:Using configuration:
DEBUG:root:	accounts:
DEBUG:root:		auth: basic
DEBUG:root:		name: work
DEBUG:root:		resource: https://carddav.server.tld:443/davical/caldav.php/username/addresses/
DEBUG:root:		user: username
DEBUG:root:		verify: True
DEBUG:root:		write_support: False
DEBUG:root:	accounts:
DEBUG:root:		auth: digest
DEBUG:root:		name: private
DEBUG:root:		resource: https://contacts.icloud.com/
DEBUG:root:		user: myname
DEBUG:root:		verify: True
DEBUG:root:		write_support: False
DEBUG:root:	debug: True
DEBUG:root:	filename: pycard.conf
DEBUG:root:	sqlite:
DEBUG:root:		path: ./abook.db
DEBUG:root:	sync:
DEBUG:root:		accounts: set(['private'])
DEBUG:root:start syncing account private
DEBUG:root:made sure version table exists
DEBUG:root:made sure accounts table exists
DEBUG:root:made sure private table exists
DEBUG:root:looking for locally changed vcards...
And nothing else...

+1


Legacy League

In an effort to either
a) Be ready ahead of time for legacy league support
or
b) Be ready very quickly after legacy league starts.
I'd like to make a list of the things that need to be implemented in procurement that I can see from the league release announcement: https://www.pathofexile.com/forum/view-thread/1834597

[ ] Leaguestones - Probably something similar to what was done with the essences
[x] Relic identification - This would need to check that we can just add in "Relic" in the Rarity enum and handle it appropriately in the ItemToColorBrushConverter. See PR #668
[ ] Update the settings to search for Legacy Leage Settings line 84, 85
This league will go live on the 3rd of March.

Leaguestones should be easy to implement, support for this could almost be done in preparation with the assumption that they will act as other league items have in the past
Relic, will hopefully be as simple as updating the enum and brush converter as you saw.
League settings, it's worth noting that this doesn't have to be updated, by default settings if you chose to login to all leagues, new leagues are automatically picked up, periodically updating the settings file is just something I've always done with each update.

Explanation of League Stones by ZiggyD
https://www.youtube.com/watch?v=xp_a226eg_U