Option to eliminate randomness

It would be great if there was an option to eliminate randomness when drawing shapes. So basically that the first time it would be random, and then the same shape would be drawn again.
For example drawing lines on canvas and then redrawing the entire canvas causes the lines to flicker due to randomness.

I would be willing to work on this as a PR, if you think it's a good idea.

This would be useful.
How about a generate function that returns an instance. Something like the below.
// returns instance of rectangle
const rec = rc.generate.rectangle(120, 15, 80, 80, { roughness: 2.8, fill: 'blue' })
// draws rectangle using above instance, will always be same no randomness
rc.draw(rec)

Yep, something like that would be great 👍

This is great. In fact underneath the main API, there are already methods to do this; and my version 1 of this lib already supported this - it was more object oriented and a lot of people preferred the current simpler api.
Having said that that I'm planning an update that creates a raw SVG renderer along with the current Canvas render. So, any API change has to be forward compatible, and this is right along the lines with where I'm going.
I'll add this in in the next couple of days.

@pshihn Would definitely appreciate having this feature. I made a snake game using roughjs, and it looks great. However, it currently updates the drawings too fast, and having control over the randomness would help me fix it.

Thanks a lot for making the library!

@AriaFallah This is really cool! I think I should create a gallery page where people submit creations using Rough.js

Not sure this warrants a new issue, so I'm adding here.
I suggest using a seedable RNG to support 'squigglevision' allowing the coder to limit the change in randomness to just a few iterations. For example: setting to seed A, drawing a square; setting to seed B, redrawing the same square; now back to seed A, etc.
I suppose the same functionality can be gained with the generator function - I'd just need to generate two or more instances of an object with the same settings, then alternate which is placed on-screen.

@ShonFrazier That's exactly what I had in mind :)

Here you go: https://github.com/pshihn/rough/wiki/RoughGenerator
It's available in the latest build: 2.0.1
This should handle your use cases. Let me know what you think @novoselrok, @AriaFallah, @BrianDGLS
Regarding the 'squigglevision', @ShonFrazier, I suppose it could be written on top of roughjs/generators easily.
I'm a bit reluctant to add animation related effects in the core draw platform.
Perhaps an animation helper lib that used roughjs would be nice later on.

I meant "support others' efforts to use roughjs when animating" - I wouldn't expect any kind of animation helpers to be provided by this lib. Just giving more control to the consumer of your API is all that's required. I think generators gives me exactly the control I'd expect. thanks!

@pshihn with this new API is there any way to have
roughCanvas.rectangle(0, 0, 25, 25);
roughCanvas.rectangle(10, 10, 25, 25);

the two above calls, draw the same exact shape? Basically, have the library draw the same thing even when the x and y coordinates change.
Right now I'm not sure how to use the generators for a moving object like the snake.

@AriaFallah It does not directly solve your scenario, but you can use generator in combination with context.translate/setTransform
Here's an example: https://jsfiddle.net/woubwqv0/3/

@AriaFallah I ran into this yesterday too. The best solution I've found is to generate the shapes anchored around 0,0 and then translate each shape into place using your x and y coordinates as @pshihn recommended. The context.save() and context.restore() helpers may come in handy if you're animating a lot of objects.
Still not sure what to do for curves (such as an edge between two nodes that are allowed to move independently).

When RoughSVG renderer is in place, you can get a SVG node with the shape - would be much easier to animate without re-rendering using CSS/Style transform
(Re-rendering has its own cool effect though)

Generators were added in https://github.com/pshihn/rough/pull/36 Closing issue

In my project, I needed the ability to have a custom seed in order to have a stable rendering across serialization boundaries. Since it's not going to be supported directly by roughjs, I had to workaround by overriding Math.random with a pseudo random number generator that supports a seed before calling roughjs.
Here's the code if you want to replicate it on your use case.
// Before
const shape = generator.rectangle(10, 10, 50, 50);

// After
const shape = withCustomMathRandom(123456 /* seed */, () =>
  generator.rectangle(10, 10, 50, 50)
);

// https://stackoverflow.com/questions/521295/seeding-the-random-number-generator-in-javascript/47593316#47593316
const LCG = (seed: number) => () =>
  ((2 ** 31 - 1) & (seed = Math.imul(48271, seed))) / 2 ** 31;

// Unfortunately, roughjs doesn't support a seed attribute (https://github.com/pshihn/rough/issues/27).
// We can achieve the same result by overriding the Math.random function with a
// pseudo random generator that supports a random seed and swapping it back after.
function withCustomMathRandom<T>(seed: number, cb: () => T): T {
  const random = Math.random;
  Math.random = LCG(seed);
  const result = cb();
  Math.random = random;
  return result;
}

@pshihn, I would encourage to make it part of the official API. I don't believe that generators are solving this use case of serializing and deserializing the shapes.

@vjeux do you imagine seeding each shape or a global seed or both?

My use case us each generate command would have an individual seed managed by the caller.
I don’t have a use case for a global seed

Resolved by https://github.com/pshihn/rough/pull/121


ProjectBuilder tests failing when exercising Kotlin multiplatform plugin

Expected Behavior

I can use ProjectBuilder while applying "kotlin-multiplatform" plugin.
Current Behavior

Failure:
Cannot create service of type KotlinScriptEvaluator using method BuildServices.createKotlinScriptEvaluator() as required service of type KotlinScriptBasePluginsApplicator for parameter #7 is not available.
Context

Trying to efficiently test a Gradle plugin that integrates with the Kotlin Gradle plugin.
Steps to Reproduce

Will do if required, but this issue is almost identical to https://github.com/gradle/gradle/issues/16774 which was acknowledged and for a while had a release target for a fix. The difference with this issue is that I'm not aware of a workaround https://github.com/gradle/gradle/issues/16774#issuecomment-1109284132
Your Environment

Build scan URL:

Sorry that you're having trouble with Gradle!
Your issue lacks information about how to reproduce the problem you're having. A reproducer project can really help us track down and fix your problem quicker.  We may also be able to suggest workarounds or ways to avoid the problem if we can reproduce it.
This issue will be closed after 7 days, unless you can provide more information.

The issue may be indeed similar to #16774, however a reproducer is required in order to pinpoint the source of the problem.
The issue could also depend on the specific version of the kotiln multiplatform plugin being used and various other factors.

Reproducer: https://github.com/3flex/gradle-21074-demo
I've used Kotlin Gradle Plugin 1.6.10 because it looks like a workaround or fix was added in Kotlin Gradle Plugin 1.6.20.
I've tested KGP 1.6.10 on 7.4.2 (fails), 7.5-20220703235851+0000 (fails) and 7.6-20220704221532+0000 (works), so it seems https://github.com/gradle/gradle/commit/dd5ea83f66bc3a7892704d036509060a9e01d0b0 has fixed this.

Thank you for providing the reproducer!
I have manually validated that the issue is not present anymore with KGP 1.6.10 or 1.7.0 when running with latest 7.6 nightly.
To clarify, the root cause of the problem described in this issue matches the one described in the #16774. For future reference, here is the error from the reproducer using ProjectBuilder (KGP 1.6.10, Gradle 7.4.2):
ProjectBuilderTest > test() FAILED
    org.gradle.api.internal.plugins.PluginApplicationException: Failed to apply plugin 'org.jetbrains.kotlin.multiplatform'.
        at org.gradle.api.internal.plugins.DefaultPluginManager.doApply(DefaultPluginManager.java:173)
...

 Caused by:
        org.gradle.api.reflect.ObjectInstantiationException: Could not create an instance of type org.jetbrains.kotlin.gradle.plugin.BuildEventsListenerRegistryHolder.
            at org.gradle.internal.instantiation.generator.DependencyInjectingInstantiator.doCreate(DependencyInjectingInstantiator.java:69)
...

            Caused by:
            org.gradle.internal.service.ServiceCreationException: Cannot create service of type DefaultBuildEventsListenerRegistry using DefaultBuildEventsListenerRegistry constructor as required service of type BuildEventListenerFactory for parameter #1 is not available.
                at org.gradle.internal.service.DefaultServiceRegistry$FactoryService.bind(DefaultServiceRegistry.java:807)

So it seem to have indeed been fixed in #21135.


"prefix" no longer looks at a trailing slash

After recently upgrading to Grape 1.0.x, it seems that
prefix 'api'
gets a bit too greedy in which routes it intercepts.
When using something like
mount ApiClass::Base => '/'
get '/*params/'`

where, the "prefix" is defined within the ApiClass::Base, a route such as domain/apiary previously used the Rails router. Instead, that route is now intercepted with Grape.

This seems to stem from a change introduced in https://github.com/ruby-grape/grape/pull/1517/files#diff-1a2141f1143a454a12c8400e0dea79d4, which alters the default behavior of anchoring.
This differs from the documentation at https://github.com/ruby-grape/grape#anchoring

This looks legit, care to write some failing specs first?


[dev-1.30] Remove useless line wrap

Follow-up of #45125

/cc @divya-mohan0209  @drewhagen

/approve

Thanks @HirazawaUi
/lgtm


DE43639 Cert 21.06: Check for null in focus-trap focus() method

Cert for #1351

Closed in favor of #1355


GPTMD needs option for turning OFF deconvolution

PTMs missed due to incorrect charge state assignment.

done in #1319


Update to work in 1.20.1

Describe the your request
Hey!
Me and my friend are using 1.20.1 to play and would love to use the disenchanter to store our XP, however the latest version is 1.19.2, could you guys check and see if it works in 1.20.1, and if so update the version number too so CurseForge can add it to our modpack?

would be rly nice

It will be updated to 1.20.1 once I have time to do so.
Sorry for inconvenience. I'm super busy now.

No worries, it can wait so I don't mind. Thanks!


Add Ingress with Traefik for application deployment and Argo/Tekton dashboards (incl. Tekton Trigger EventListener)

Fixes #34 #43


Kitchen View

It'd be great to have a "i'm in the kitchen cooking" view of a recipe (or menu?), separate from the normal detail view. In particular:

allow checking off ingredients (cross them out, and maybe reduce opacity?)
allow checking off directions (if they're in a multi-item format of some sort)
less "manage stuff" UI bits
ability to easily add ingredient deltas and/or notes while cooking

Note that this would display the ephemeral version of the recipe, not the canonical one. This needs to be the specific version from the planner.

I'm gonna close this as complete. Cooking from the plan is available, with a dedicated low-noise view. It's unclear if/how the other bells and whistles ought to work, so left open-ended for the future (or not).


template: jinja2 is missing a simple test for lists

As long as this is lacking from the official jinja2 tests, we should add one to our own filters and tests.

Closing as per https://github.com/inveniosoftware/invenio/pull/3228#issuecomment-125352743


[Subtask] Document UnparsedType data type which handles an unresolvable type from the catalog

Describe the subtask
The introduced UnparsedType data type which handles an unresolvable type from the catalog should be documented.
Parent issue
#2117

@mchades, could you assign this ticket to me?


'openURL' is only available in iOS 14.0 or newer

The package indicates .iOS(.v13) platform support, but doesn't compile for iOS 14 just because its package description is erroneous.

@RemiBardon How should it be configured?
https://github.com/jaywcjlove/swiftui-markdown/blob/65ec741eed76dd3c71c44b6e8c41ae7b50fe4f53/Package.swift#L9

As the compiler says, "'openURL' is only available in iOS 14.0 or newer". You can either add an @available tag to your function using openURL, but then you'll probably need it everywhere else (as it's the main component of the library). Or you can change .iOS(.v13) to .iOS(.v14) and the compiler will be happy 🙂
Either way, it breaks backwards compatibility, but you already broke it when introducing openURL anyway 💁🏻♂.

@RemiBardon thx


Delete phase does not ask for confirmation

Please complete the following fields as applicable:
Expected behaviour:
When clicking in delete phase within a template editing, a confirmation message should be displayed.
Actual behaviour:
Clicking in delete action destroys the phase for a template
Steps to reproduce:
Explained above

Where is the delete phase button @jollopre I've only been able to edit not delete

You can see the delete action on the template details page where an overview of phases for that template is displayed. Note, the action is only visible if that phase has been marked as modifiable.

Great, I see it now! Had actually been planning to raise a ticket to add a 'delete phase' button as I couldn't find a way to do it ;-)
You're right that this action needs a confirmation

confirmation message working as expected now. closing issue.


Delete GCP001105

Please delete submission id '673d26bee6802e0001af1206' and all associated data from the sumstats FTPs.
The user will resubmit under a new GCP to be linked to a future PMID.

@earlEBI done


A terrible showcase

A terrible showcase, a mishmash of rxjava and binding. Make an illustrative example please.

Hey there, the SciChart Showcase is deprecated, the examples have been moved into the main examples suite here:
https://github.com/ABTSoftware/SciChart.Android.Examples/tree/SciChart_v3_Release/Examples
Have you tried it out?

Has it helped? Check out the Audio Analyzer, ECG and Lidar demo here:
https://github.com/ABTSoftware/SciChart.Android.Examples/tree/SciChart_v3_Release/Examples/app/src/main/java/com/scichart/examples/fragments/showcase
There is also a trading demo in there 'Multi Pane Stock Charts'
Best regards,
Andrew


[5.1] Change the exception the gate throws

I've updated this file in order to throw the correct Exception which is UnauthorizedException on createGateUnauthorizedException method. Also this is useful in order to render a different response here: app/Exceptions/Handler.php

This is updated in 5.2.

To give more more info, it would be a breaking change to make this change on 5.1.

@geodeveloper See here: AuthorizesRequests.php#L16

Ok, great. It's good to know it has been fixed. Thank you.


cr: hold references to temp cache nodes to avoid GC

Otherwise these nodes can get deleted during the SearchForNodes call.
Is there a better way to get Go to hold a reference to an object besides printing it?
Issue: KBFS-1096

just one question, but lgtm

Closing in favor of #20.


Unable to auto-deploy from GitHub using custom script that uses SQLCMD

I've setup my Azure website to watch GitHub repository branch and auto-deploy on commits. I'm also executing a custom post deployment script inside of which I'm using sqlcmd.
I've been using my script for a few months and it was working as expected, but when I committed something to GitHub today, deployment failed.
After investigating it seems that sqlcmd is unable to connect to database.
sqlcmd -S tcp:xxxxxx.database.window.net,1433 -d DBName -U user@xxxxxx -P pwd -b -i "Deploy.sql"

I've tried change these switches and seen that I'm able to connect if I omit the tcp: part in my server parameter:
sqlcmd -S xxxxxx.database.window.net,1433 -d DBName -U user@xxxxxx -P pwd -b -i "Deploy.sql"

I suspect this must me some kind of a bug, as MSDN also encourages to explicitly specify TCP connection. But even though if I change my parameters in my custom deployment script, deployment still doesn't work.
My custom deployment script
:::::::::::::::::::::::::::::::::::::::::::::::::
:: KUDU Deployment script for database upgrade
:: ----------

setlocal

IF NOT DEFINED DEPLOYMENT_DB (
	echo Missing Application setting "DEPLOYMENT_DB" in Azure Web app configuration.
	goto :error
)

:: Deploy database upgrade

echo Starting database deployment to %DEPLOYMENT_DB%.

cd "%DEPLOYMENT_SOURCE%\Database"

sqlcmd -S tcp:xxxxxx.database.windows.net,1433 -d %DEPLOYMENT_DB% -U User@xxxxxx -P Pwd -b -i "00 Backup.sql","01 Drop.sql","02 Create.sql","03 Types.sql","04 Functions.sql","05 Procedures.sql","08 Restore.sql"

IF !ERRORLEVEL! NEQ 0 goto error

goto :end

:::::::::::::::::::::::::::::::::::::::::::::::::
:: ERROR

:error
echo An error has occurred during database deployment to %DEPLOYMENT_DB%.
exit /b 1

:::::::::::::::::::::::::::::::::::::::::::::::::
:: Everything's fine

:end
echo Post deployment completed.

The last line I see in the log is the Starting database deployment to DBName. That's just before execution the sqlcmd. What follows in the log is this:

Command 'starter.cmd "D:\home\site\d ...' was aborted due to no output nor CPU activity for 121 seconds. You can increase the SCM_COMMAND_IDLE_TIMEOUT app setting (or WEBJOBS_IDLE_TIMEOUT if this is a WebJob) if needed.\r\nstarter.cmd "D:\home\site\deployments\tools\deploy.cmd"
One or more errors occurred.
Command 'starter.cmd "D:\home\site\d ...' was aborted due to no output nor CPU activity for 121 seconds. You can increase the SCM_COMMAND_IDLE_TIMEOUT app setting (or WEBJOBS_IDLE_TIMEOUT if this is a WebJob) if needed.\r\nstarter.cmd "D:\home\site\deployments\tools\deploy.cmd"

As you can see I've already increased my timeout from the default of 60 seconds to 120. But that should not be the problematic part, as my script does nothing particularly time consuming for this to take this long.
So what should I do?

I've actually had a large table that was executing SQL script for longer than 2 minutes...


podmanv2 events

add the ability to monitor events
Signed-off-by: Brent Baude<EMAIL_ADDRESS>

LGTM

I am getting the following error on all invocations:
libpod (v2events) $ sudo ./cmd/podmanV2/podmanV2 events
ERRO[0000] failed to read message field: bad message

V1 does not throw it. I try to have a look but today is filled with meetings until late :/

/lgtm
/hold

/hold cancel


Live Streaming not working on mobile iOS - connection closing without error

What is the current behavior?
I am using the deepgram sdk for live streaming. It works fine on all browsers but on iPhone (Safari and Chrome) the connection just closes after a few seconds.
There are not errors, it's closing with Code 1000 and no reason.
For a few seconds I also get the interim results so I assume there is everything correct with the mime type, encoding and connection.
I also had trouble to recover from this closed connection. It would be nice to have a small example in the docs or as a demo.
Steps to reproduce
It's easily reproducable using live stream with any mobile iOS device.
It is also happening in your own example repo: https://github.com/deepgram-starters/live-nextjs-starter
Expected behavior
The connection should not stop automatically or there should at least be a reason why it stopped.
Please tell us about your environment

We want to make sure the problem isn't specific to your operating system or programming language.

Language: Next.js 14 + latest Deepgram SDK
Browser: mobile iOS (all browsers) - it's working fine on desktop Mac/Windows

Can you share some code for this reproducable?

Yes, you can check your own repository where it also happens:
https://github.com/deepgram-starters/live-nextjs-starter

I am also getting this issue on my own project. Please let me know if there are any updates @lukeocodes @christophmeise
Environment
Language: react 18.2 + typescript 4.9.5 + latest Deepgram SDK
Browser: mobile iOS (all browsers) - it's working fine on desktop Mac

It works for me in iOS. I used it for transcription on https://github.com/deepgram-devs/deepgram-conversational-demo which is fine on iOS, verified on iPhone 14, 15, and in the iOS simulator.
The issue that @christophmeise was speaking of was to do with iOS and Safari sending an empty blob chunk at the start of streaming. This would cause the websocket to close, as it's invalid audio data.
I have a PR in the works that includes a work-around for this anyway, but you can implement that fix yourself.
blob.size for blob size. Must be > 0
arrayBuffer.bytelength for array buffer size. Must be > 0
Closing as this is not an SDK bug, but a browser issue. It just so happens 3.4.x will include a work-around.

I am having the same issue. @lukeocodes I'll take a look at your PR to see if I can implement the same workaround for now but any idea when you'll be releasing 3.4.x?

Just incase anyone needs it,  here's how I fixed the issue.
const recorder = new MediaRecorder(event.streams[0])
recorder.start(500)
recorder.ondataavailable = (e) => {
  const data = e.data
  if (data.size > 0) {
    console.log('client: sent data to websocket')
    if (this.dgSocket !== null) {
      this.dgSocket.send(data)
    }
  }
}


DemoApp dont react to images

Hi!
Thanks for the demo app.
Having some issues to get the app to work correctly. None of the demos work.
Followed all of your steps and no luck...
I have installed my trail license inside WikitudePlugin.js
Running on my iPhone.
Any suggestions?

Hi !
What do you mean by "none of the demos work" ? Do you have any error message in any of the console ? Can you launch the demos but nothing happens when they're launched ?
Also, on which iOS version your phone is running ?

No error message in the console.
Yes, the demos is running and the trail message is showing in front of the camera live preview.
But the AR is not showing.
Using iOS 9.3.3

What demo(s) did you launch ?
Because most of them requires you to scan a specific picture to actually see AR on the screen (that's the case for at least the first 15 demos).
Normally, these required pictures should be shown in a small header bar in the demo, and you can find most of them in a pdf here.
None of them shows some AR right when it starts (except maybe the solar system demo at the bottom of the list, or the geo-based demos).

I have tried to scan the pictures in the pdf.
The solar system demo does not work correctly either.
This is my console log in Xcode:
2016-08-11 11:29:37.987 Ionicitude Demo[9542:3250410] ----------------- Wikitude SDK REQUIREMENT NOT FULFILLED ----------------- 2016-08-11 11:29:37.987 Ionicitude Demo[9542:3250410] CoreLocation Authorization Status is not determined - All ARchitect World load requests are on hold! 2016-08-11 11:29:37.987 Ionicitude Demo[9542:3250410] This problem occurs because you've called the method 'loadArchitecteWorldFromURL:withRequiredFeatures:' with a feature that contains Geo Requirements. 2016-08-11 11:29:37.987 Ionicitude Demo[9542:3250410] To resolve this problem, either accept the iOS location access prompt or make sure that the 'NSLocationWhenInUseUsageDescription' key is defined in your applications Info.plist. 2016-08-11 11:29:37.987 Ionicitude Demo[9542:3250410] Set the key's value to e.g. 'Access to GPS information is needed to display POIs around your current location'. 2016-08-11 11:29:37.989 Ionicitude Demo[9542:3250410] Affected URL's:  2016-08-11 11:29:37.993 Ionicitude Demo[9542:3250410] 	URL: file:///var/containers/Bundle/Application/9DDC0DF3-CC4E-4729-B89A-026A3D149B3E/Ionicitude%20Demo.app/www/wikitude-worlds/1_ClientRecognition_1_ImageOnTarget/index.html 2016-08-11 11:29:37.993 Ionicitude Demo[9542:3250410] -------------------------------------------------------------------------- 2016-08-11 11:29:37.994 Ionicitude Demo[9542:3250410]

OK. Yeah, I've run into this problem also.
It's not related to Ionicitude, but rather to how Cordova asks for the geolocation permissions in iOS9 (and 8, if I'm not mistaken).
As you can see, the message explains that the demo asks for the permission to access the geolocation, but where never given the right to do so. The message also talks about an 'NSLocationWhenInUseUsageDescription' key in your Info.plist.
When confronted with this issue, I followed this thread with one of my test devices and that worked, althought I can't seem to remember if it was an iOS9 or iOS8 device.
(Note that after manually adding the keys in your Info.plist, subsequent build of the app will keep these keys, so you won't have to do this all over again.)
Hope that will help !

Whohoo! Thank you!!
Now it works perfekt. <3


Code coverage limit

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   86.95%   86.95%
=======================================
  Files           8        8
  Lines         138      138
=======================================
  Hits          120      120
  Misses         18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1315f65...fdfa361. Read the comment docs.


uninstall apps keeps app instance available

remove app from app manager and app instance is still listed
http://try.cartoview.net/apps/appinstances/?limit=20&offset=0

Cartoview Version : (1.8.1)
Geonode Version : (2.8)

fixed


Update garbage-collection.md

change "higher" to "larger"

This change is

update branch already

update branch again


This line in your styles.css somehow worked its way into the reading mode of code display, and makes the text bold

Reading mode with Obsifetch On:

with Obsifetch Off:

This line is the culprit:
pre {
    margin: 0;
    white-space: pre;
    color: var(--text-accent);
    /*font-weight: bold;*/
    line-height: 1.1;
}

The commented out line in particular. Not sure how it it started affecting my actual files, as it wasn't bolded after I first installed.  I also haven't taken a look at your TypeScript, so maybe its a weird me thing

Oh, it's because pre generally stylizes the codeblocks, ASCII art is in the codeblocks, but I didn't specified which pre so it applies style to every code block. You can change pre { to .logo-section pre {, reload the plugin, close, and reopen the app. This should resolve the issue. I will correct it in the next release along with other updates. Let me know if this works for you.


Add dmsview colors

Added different chain colors for the ACE2 and RBD chains in the dms-view links. Also updated paper links to be the accepted publication version

I double checked all the url's when opening up the .md file on this GitHub branch, I can also confirm on the 'landing pad' page itself once merged


Click event on Treemap

Is there a way to get the value of a selected rectangle in the treemap on click ?

Hi @DeathDoctor ,
Please take the update of amexio (5.9.2), You will find onClick event on treeMap.


Add port to p5.js of Coding Challenge 102: 2D Water Ripple

This is a straight port - the only real differences (beyond syntax and coding style) are the use of the pixels array (index times 4, setting density), and the current/previous array initialization (which is a bit tricky, not sure if it needs further explanation).

I noticed there's a PR underway to update the version of p5.js being used. This port currently uses the previous version (0.10.2), but I can update it to the new version (1.0.0) if you want - a quick test showed it works fine with that version too.

Looks great thanks for working on this! Would be great to update to 1.0.0 so we don't have to go back and do that later.


Update aws-java-sdk to 1.12.110

Updates com.amazonaws:aws-java-sdk from 1.12.105 to 1.12.110.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk" } ]

labels: test-library-update, semver-patch

Superseded by #317.


Avast gives 'infection blocked' when doing npm i for ember-cli-template-lint

Each time I npm install ember-cli-template-lint, my anti-virus Avast gives a notification of an infection being blocked. This is on Mac osx. the infection is JS:Downloader-EKT [Tool].
Are there more people who have this issue?

I don't really think there is anything I can do about this.  There certainly are no viruses published in the tarball on npm.
closing for now...


Logger

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- src/ReCaptchaLogger.php  9

See the complete overview on Codacy


Bugfix/home page typo

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: sodede sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Declare 'react' as a depdency in embla-carousel package

Feature request is related to

[x] The React version

Is your feature request related to an issue?
We can't use the package in a yarn pnp enabled project.
The resolver throws the following error:
embla-carousel tried to access react, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Describe the solution you'd like
Updating the embla-carousel/package.json to move "react" from devDependencies into dependencies

Hi Vicente (@chitchu),
Thank you for creating this issue. I don't think the react package should be a dependency of the embla-carousel package?  It should ideally be a peerDependency, because embla-carousel requires you to install react on your own. Embla shouldn't include a duplicate react in the consumer project because this is known to cause a lot of problems. The reason why it's not a peerDependency today has been discussed in the following issue #92.
In the future, I'm hoping to separate the react version to a separate package called embla-carousel-react, but I haven't had the time to do so. Doing that will make it possible to move react to peerDependencies.
Best,
David

Ok thanks for clarifying. Looking forward to the dedicated react version.

Hi Vicente (@chitchu),
Until then, if you find a solution to the yarn error, please post it here. It might help other.
Cheers,
David

@chitchu the dedicated react version is on its way here: #220.

Hi @chitchu,
I've just released v5.0.0 and the React version is now a dedicated React package. I hope that this will solve the issues you were experiencing.
Cheers,
David


Input custom page number dev/nightly page

While it is nice to have 328 pages as of writing for the development/nightly builds, it's not really useful if you want something more in-between like 100 or 200.

Maybe at this location to make it have multi-usage?

I'd rather just add a search feature soon.  They are ordered by version number so I don't think there's a huge value to letting people page quickly.  If they know the number they are looking for -- they can just search for it.
Searching also lets people search by the description

That is fine for me.


Test Falco

Build failed; the context from the latest run is:
Expand to view
[2019-11-15T16:06:55.399Z] Pull request #63 opened
[2019-11-15T16:06:55.431Z] Connecting to https://api.github.com using jenkinsadmin/****** (GitHub access token for jenkinsadmin)
[2019-11-15T16:06:55.930Z] Connecting to https://api.github.com to check permissions of obtain list of olblak for jenkins-infra/charts
[2019-11-15T16:06:56.627Z] Obtained Jenkinsfile from a0080bcad5a11433ebc3789cac916a3a795e8d92+3f5f43f2a1da8bf8f3713663df3bb8da14d8c931 (1c3d13f5c9ed32cea6fa6523a035387c9db1f50f)
[2019-11-15T16:06:56.627Z] Running in Durability level: MAX_SURVIVABILITY
[2019-11-15T16:06:56.654Z] Loading library pipeline-library@master
[2019-11-15T16:06:56.654Z] Attempting to resolve master from remote references...
[2019-11-15T16:06:56.709Z] Found match: refs/heads/master revision 01483fac87fd7367d39ff00836c8dec453efaa91
[2019-11-15T16:06:56.709Z] No credentials specified
[2019-11-15T16:06:56.710Z] Cloning the remote Git repository
[2019-11-15T16:06:56.710Z] Cloning with configured refspecs honoured and without tags
[2019-11-15T16:06:56.859Z] remote: Enumerating objects
[2019-11-15T16:06:56.860Z] Receiving objects
[2019-11-15T16:06:56.898Z] Resolving deltas
[2019-11-15T16:06:57.007Z] Updating references
[2019-11-15T16:06:57.017Z] Fetching without tags
[2019-11-15T16:06:57.071Z] Checking out Revision 01483fac87fd7367d39ff00836c8dec453efaa91 (master)
[2019-11-15T16:06:57.090Z] Commit message: "Merge pull request #115 from jglick/patch-2"
[2019-11-15T16:06:57.092Z] First time build. Skipping changelog.
[2019-11-15T16:06:59.196Z]
[2019-11-15T16:06:59.196Z] GitHub has been notified of this commit’s build result
[2019-11-15T16:06:59.196Z]
[2019-11-15T16:06:59.197Z] org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
[2019-11-15T16:06:59.197Z] WorkflowScript: 3: Invalid agent type "kubernetes" specified. Must be one of [any, docker, dockerfile, label, none] @ line 3, column 5.
[2019-11-15T16:06:59.197Z]        kubernetes {
[2019-11-15T16:06:59.197Z]        ^
[2019-11-15T16:06:59.197Z]
[2019-11-15T16:06:59.197Z] 1 error
[2019-11-15T16:06:59.197Z]
[2019-11-15T16:06:59.197Z] 	at org.codehaus.groovy.control.ErrorCollector.failIfErrors(ErrorCollector.java:310)
[2019-11-15T16:06:59.197Z] 	at org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1085)
[2019-11-15T16:06:59.197Z] 	at org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:603)
[2019-11-15T16:06:59.197Z] 	at org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:581)
[2019-11-15T16:06:59.197Z] 	at org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:558)
[2019-11-15T16:06:59.197Z] 	at groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader.java:298)
[2019-11-15T16:06:59.197Z] 	at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:268)
[2019-11-15T16:06:59.197Z] 	at groovy.lang.GroovyShell.parseClass(GroovyShell.java:688)
[2019-11-15T16:06:59.197Z] 	at groovy.lang.GroovyShell.parse(GroovyShell.java:700)
[2019-11-15T16:06:59.197Z] 	at org.jenkinsci.plugins.workflow.cps.CpsGroovyShell.doParse(CpsGroovyShell.java:142)
[2019-11-15T16:06:59.197Z] 	at org.jenkinsci.plugins.workflow.cps.CpsGroovyShell.reparse(CpsGroovyShell.java:127)
[2019-11-15T16:06:59.197Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.parseScript(CpsFlowExecution.java:561)
[2019-11-15T16:06:59.197Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.start(CpsFlowExecution.java:522)
[2019-11-15T16:06:59.197Z] 	at org.jenkinsci.plugins.workflow.job.WorkflowRun.run(WorkflowRun.java:327)
[2019-11-15T16:06:59.197Z] 	at hudson.model.ResourceController.execute(ResourceController.java:97)
[2019-11-15T16:06:59.197Z] 	at hudson.model.Executor.run(Executor.java:429)
[2019-11-15T16:06:59.197Z] Finished: FAILURE

Powered by the Comment Logger


Feature for auto commenting on a new issue creation

I would like an automated feature that posts a predefined comment on an issue as soon as it is created. This feature aims to address the problem of delayed and inconsistent communication following the creation of issues. By automatically commenting on issues as soon as they are created, it ensures that contributors receive immediate feedback and acknowledgment for their efforts. This fosters a positive and supportive environment for collaboration, encouraging continued participation and engagement from contributors.
Could you please assign me this issue under GSSOC'24.

can you assign this task to me I would also like add a feature that will self assign the issue to a particular user if he or she wants to contribute to the issue given he or she has opened the issue


Build.ArtifactStagingDirectory incorrect explanation about contents

In the documents above, for Build.ArtifactStagingDirectory it states that the contents of the directory are purged before each new build and that you do not have to clean it yourself. However, as I was developing a YAML file to use for our one project in-house, where we were using this folder to compile the output files that would eventually get pushed into an artifact, a 2nd build attempt immediately failed during the "Initialize Job" step of the pipeline because "The directory is not empty."
Thus, is seems like it is not necessarily true that the directory is purged, and you do in fact have to clean it yourself or a second pipeline build will fail.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9ffebdc8-521c-44b5-cde4-4abdc1bd6f18
Version Independent ID: dc0effda-6d93-62aa-64c5-4e6f283b0826
Content: Predefined variables - Azure Pipelines
Content Source: docs/pipelines/build/variables.md
Product: devops
Technology: devops-cicd
GitHub Login: @juliakm
Microsoft Alias: jukullam

@Londovir  Thank you for the feedback, assigning this to the author for review.

I'm working on getting clarification from the product team on how this should work.

Actually more clarification is needed. I'm having difficulty understanding where artifacts are being downloaded to. I see that by default a job I have is downloading pipeline artifacts that were published in a previous stage. But no matter which path variables I use it seems to say it can't find the files. At a loss, and I see lots of questions on the web where people are having similar issues.

@Londovir I just emailed you. We have a developer that wants to look into your issue in more detail. We're wondering if the initialization error you're seeing is part of the problem. Under normal circumstances, $(Build.ArtifactStagingDirectory) should be where your artifacts go before they are published and should be purged.
I'm closing this issue for now since it's looking like it is not a docs problem.
@AndrewCraswell What type of artifact are you trying to publish? If it is .Net, you might find this section of the .Net article helpful. A lot of people have also found this Learn module useful for understanding artifacts better.

@juliakm it is not fully clear yet. The question here is, is the $(Build.ArtifactStagingDirectory) getting cleaned when a specific run has finished? If that is the case we could safely assume that a next run will work with an empty/clean $(Build.ArtifactStagingDirectory)


Add Multi-core debugging with OpenOCD

I think it would be useful to link to the openocd docs that explain it: https://openocd.org/doc/html/GDB-and-OpenOCD.html

Added the source information


Remove the need to declare source files in the BUILD of activations

I used the feedback of the SIG meeting concerning moving the tests to another directory. I believe I found a nice middle ground, which is actually used by scikit-learn and numpy:
https://github.com/scikit-learn/scikit-learn/tree/master/sklearn
https://github.com/numpy/numpy/tree/master/numpy
The tests of activations can be found now in tensorflow_addons/activations/tests.
This makes a clear distinction between source files and tests files which allows us in turn to use the glob feature of bazel to avoid declaring every python file that we use.
It also makes it easier for users who want to look at implementations to navigate the source code since they don't care about the tests.

Awesome. Looks perfect!


Nested data classes are not parsed back correctly

These are my models
data class IChapter<T>(
  var _id: String,
  var title: String,
  var picture: T,
  var createdAt: Long,
  var updatedAt: Long
)

data class IMedia(
  var _id: String,
  var name: String,
  var extension: String,
  var path: String,
  var size: Long,
  var createdAt: Long,
  var updatedAt: Long
)

I want to save this in prefrences.
object prefs : PreferenceHolder() {
  var chapters: List<IChapter<IMedia>> by bindToPreferenceField(listOf())
}

After i populate it with objects coming from this
    fun getRemoteChapters(): List<IChapter<IMedia>> = listOf(
      IChapter("1", "در تنهایی و ...", IMedia("1", "f1", "jpg", "https://images.all-free-download.com/images/wallpapers_large/small_island_wallpaper_beaches_nature_wallpaper_1388.jpg", 0, 0, 0), 0, 0),
      IChapter("2", "پیش از جکومت", IMedia("2", "f2", "jpg", "https://besthqwallpapers.com/Uploads/22-11-2017/29941/thumb2-sea-landscape-waves-beach-sand-clouds.jpg", 0, 0, 0), 0, 0),
      IChapter("3", "تا رهایی", IMedia("3", "f3", "jpg", "https://earthporm.com/wp-content/uploads/2014/08/small-man-grand-nature-landscape-photography-62.jpg", 0, 0, 0), 0, 0)
    )

If i close and open my app i get class cast error as below
    java.lang.ClassCastException: com.google.gson.internal.LinkedTreeMap cannot be cast to ir.yooneskh.alisotries.database.models.IMedia

Am i doing anything wrong?

Not sure. This is GSON working on here. Try to use fromJson and toJson and look at how does this works.


Add FreeMonitoring diff tests

Refs FerretDB/FerretDB#1323.

Do we plan to test undecided state? E.g. I had this PR - https://github.com/FerretDB/dance/pull/226/files which is currently assigned on you. What are your plans for it?

@rumyantseva Yeah we can do this on this PR or would you rather want to make it in #226?

@noisersup up to you! I'm ok with either option.

There is no effective difference between MongoDB and FerretDB. That should not be a diff test.

@AlekSi: Should we remove this PR then?

I think so, unless we do have a reason to keep it. But I don’t see it


Change form background color

Is there a possible way to do that? I change it in the backcolor property but doesn´t work.

Done, i've changed the color of one theme in the backcolor class in MetroPaint.cs file.


Rewrite DL/FL/LT to count pulse+gap

On Xanthos's prototype, DL2 trades are fixed, but battles and DL1 trades are failing part way through. Seems like the sensor is saturating. Tried putting a barrier between sensor and LED, but that didn't help much.

D-Breaker's unit is pretty much fixed.


Insert Relationship Items into Graph

On the backend, in the graph controller:
[1] Using the Pagination Module, gather all of the project's Relationship Types into an array
[3] Traverse the array of Relationships. For each Relationship:
[3.1] Join the Relationship's type with its corresponding Relationship Type
[3.2] Create a new relationship object adhering to the Relationship spec in the Relationship Graph JSON Specification
[3.3] Push the new relationship object into the graph's edges array
Verify that the generated JSON from the Graph object meets the Relationship Graph JSON Specification.
Possible Errors:
Malformed Data : Reform Data and resend to D3
refer to #57 for better error explanations

error handling


HELP I CANT INSTALL CFFI

in readme it said we should upgrade pip version if we face error installing the packages. I have done that but still cant install.
Looking forward for your help

UPDATE!! I was using python 3.10 . i tried to downgrade the python version and now it works


fix nightly clippy issues

I don't mind making these PRs, but I think we should start pinning our nightlies, and using a script to update the pin every week (or day, or whatever). When our CI breaks due to tooling changes, it means that our release branches will have permanently broken CI jobs, which I'd like to avoid in the future.
If the automatic pin update failed, we'd close it and manually create one that fixed the nw issues.

I'd like to update Cargo-recent.lock in the same manner, running the pin commands in contrib/test.sh after cargo update. This would allow me to locally test the latest versions of all our deps and also let us detect new necessary pins without needing to run cargo unconstrained in CI.

Yep, all sounds reasonable. Shall we get #2328 in and then tackle this?

Yep, good call re doing #2328 first.

Gonna merge this via the CI one-ack carveout.


Dependency check fail at end

Hello, I would like to know if it is possible to configure the plugin in a way that the build fails if we find any vulnerability but only at the end of the process, meaning that the report will complete and all the dependencies are scanned before the fail.
What we want to accomplish is have a step in our CI/CD that fails on vulnerabilities but we want to have a full report of all the dependencies. At the moment the build fails if we find a vulnerability (as expected) but this means that the build stop at this point. Is there a way to allow the scan to finish and only fail at the end?

Yes - that is how ODC works. Just set failBuildOnCVSS=0. See the documentation.

Hi @jeremylong thanks for your reply. And if we were to have multiple java modules (one module failing will cause the other modules to skip the execution), how could we accomplish what I mentioned above and run the full scan of multiple modules and fail at the end?

In the parent pom (assuming maven) use the aggregate goal with <inherited>false</inherited> per https://maven.apache.org/guides/mini/guide-configuring-plugins.html#Using_the_inherited_Tag_In_Build_Plugins

Ok thank you very much, closing!


Plan for glyph rendering

This issue is branched from a question raised https://github.com/linebender/xilem/pull/1 about our plan for glyph rendering, as that is the responsibility of piet-gpu rather than other layers in the stack.
For the first cut, all glyph rendering will happen as dynamic vector graphics rendering, getting the outlines from the font (currently through swash but possibly migrating to Oxidize) and assembling them into scene fragments. At first we will also not support hinting at all, nor stem darkening, nor RGB subpixel rendering. Results will be pretty good on high-dpi screens, but definitely suboptimal on low-dpi. Performance may be a problem on very low-spec GPUs as well.
The roadmap has a number of improvements. One is to support a glyph cache, which by itself doesn't change rendering quality, but will improve performance greatly (especially on low-spec GPUs, in which pulling textures from the glyph atlas will outperform rendering vectors). The infrastructure for glyph (which involves tracking the transform at which a glyph will be displayed) also enables hinting (which is fairly well implemented by swash already).
When hinting is enabled, it will be a configurable option. It is desirable for UI text (and you'd want it for displaying the text in a text editor), but it is not desirable when the scene is more dynamic. Cases where hinting would cause "shimmering" effects include pinch-to-zoom (or any other transform than scrolling) and animation of variable font parameters.
An important quality improvement (especially on macOS) is stem darkening. The best way to implement this is to make coarse path rasterization capable of offset as well as flattening (the same logic will support both stroke rendering and stem darkening). I've figured out the math for this and have a prototype (in JS) but haven't yet implemented it as a compute shader; there are some tricky aspects, especially dealing with joins at corners. This improvement is orthogonal to glyph caching.
Lastly, to support low-dpi screens (especially Windows) we would want to implement RGB subpixel rendering, which is mostly a change in fine rasterization.
With a glyph cache in place, we have a choice. Either this cache is filled by doing path rendering in piet-gpu, or by calling into platform glyph rendering (particularly DirectWrite on Windows). The latter would allow pixel-perfect matching to platform text, but at a performance cost and with other tradeoffs (having two pipelines rather than one always causes problems). My current inclination is to render all the glyphs ourselves, but this is something we can revisit. Note that one option for platform glyph rendering is to take a dependency on font-kit.

I'd just like to cross-pollinate slimsag's work here in the Zig language on curve primitives:
https://www.youtube.com/watch?v=QTybQ-5MlrE
It's still early days, so it may not be the right path in Vello (no pun intended), but maybe it will lead to more ideas.


[SEDONA-251] Add raster type to Sedona

Did you read the Contributor Guide?

Yes, I have read Contributor Rules and Contributor Development Guide

Is this PR related to a JIRA ticket?

Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-251. The PR name follows the format [SEDONA-XXX] my subject.

What changes were proposed in this PR?
This PR adds a raster type to Sedona and some basic functions using the raster type.
How was this patch tested?
Unit tests added
Did this PR include necessary documentation updates?

Yes, I am adding a new API. I am using the [current SNAPSHOT version number]

@umartin
Martin, thanks for this great contribution! Your insights are always helpful to this community! I am Ok with this major change to Sedona Raster module. I think this will make everything easier in Sedona raster. A few more questions:

With this new raster implementation, is it possible that we can easily create similar PostGIS raster functions in Sedona? (https://postgis.net/docs/RT_reference.html)
Is it possible that we can write GeoTiff DataFrame back to disk, e.g., RS_AsTiff(https://postgis.net/docs/RT_ST_AsTIFF.html)? The current Sedona Raster implementation can write raster back to GeoTiff: https://sedona.apache.org/latest-snapshot/api/sql/Raster-loader/#geotiff-dataframe-writer
Is it possible that in the future PRs, we move the existing RS function implementation to this new Raster UDT? Or do you think we should just leave them as is?

@kanchanchy Kanchan, downstream projects such as GeoTorchAI (https://github.com/DataSystemsLab/GeoTorchAI) heavily depends on Sedona raster funcs. What are the most important RS functions that are used by GeoTorchAI?

Thank you @jiayuasu !

Yes! Now we should be able to implement all the raster functions in Postgis.
I think we can adapt the GeoTiff writer to work with rasters as well as the current double arrays. We just need to figure out exactly how that would work from a user perspective. I'll start a discussion on the mailing list about that.
I think that the raster functions in this PR and the current ones, that operate on bands, are complementary. We just need to implement a few function bridging the two. If we can extract bands from rasters and also create rasters from bands the old and new functions will work well together. There are many examples in Postgis we could use as inspiration: https://postgis.net/docs/RT_ST_AsRaster.html https://postgis.net/docs/RT_ST_AddBand.html https://postgis.net/docs/RT_ST_DumpValues.html https://postgis.net/docs/RT_ST_DumpValues.html

Hi @jiayuasu, some of the important functions used by GeoTorchAI are listed below:
RS_GetBand
RS_Normalize
RS_NormalizedDifference
RS_Append
Although the above-mentioned functions are the most important, GeoTorchAI also uses all other RS_ functions supported by Apache Sedona currently.

Thanks for the feedback @kanchanchy!
I  don’t see a need to break any of the existing api:s. Where it makes sense, some of the current RS functions could be extended to support both raster and arrays of double. Just like ST_GeomFromWKB supports both binary and string input.
The way I see it is that the new raster type would only add new functionality, not remove or break any existing api.

@umartin Thanks, Martin. I will merge this PR and let's start the discussion in the mailing list :-)
BTW, maybe I should add the new geotools dependency to https://github.com/jiayuasu/geotools-wrapper?

Yes, you're right, geotools-wrapper should be updated too. I also noticed that Sedona and geotools-wrapper are on different geotools versions. I ran tests locally with geotools 28.2 and they all passed. Maybe should upgrade both Sedona and geotools-wrapper to 28.2?


Informix: Schema does not refresh between databases

System information:

Windows 10 Pro 2004 19041.508
7.2.2

Connection specification:

ifxjdbc 1.0.0

Describe the problem you're observing:
When you configure a new connection the field "Database/Schema" is mandatory.
The Database navigator get the schemas of the default database selected.
If you open a new database from the navigator the schemas does not refresh. So you see the same schemas of the default database although the schemas does not exists.
Steps to reproduce, if exist:

Create a database with some schemas
Create a database with a differents schemas
Setted a default database try to expand another database from the "Database Navigator"
You could see schemas of the default database thant not exists in the other

duplicates #8987
Thanks for the bug report


There are problems with this document's schema impacting one or more items in the document

There are other errors in the document, not recognizing Microsoft.Insights/diagnosticSettings and some versioning. Intellisense does not work.
I am getting Deployment template parse failed: 'Required property 'type' not found in JSON when I deploy the template to Azure.
I am on:
AZ CLI: 2.43.0
Bicep: 0.13.1
VS Arm Tools: 0.15,8

@jrspinella Could you please post a minimal template that reproduces this problem?  The following shows no problems for me:
{
    "$schema": "https://schema.management.azure.com/schemas/2018-05-01/subscriptionDeploymentTemplate.json#",
    "contentVersion": "<IP_ADDRESS>",
    "parameters": {},
    "functions": [],
    "variables": {},
    "resources": [
        {
            "type": "microsoft.insights/diagnosticSettings",
            "apiVersion": "2016-09-01",
            "name": "service",
            "location": "westus",
            "properties": {

            }
        }
    ],
    "outputs": {}
}

Hi,
I am using Azure NoOps Accelerator. You can use the repo that I am using http://aka.ms/azurenoops. Follow the instructions for the quickstart on the readme.

This has been fixed. https://github.com/Azure/NoOpsAccelerator/issues/226


feat: add signal to func

Fixes: https://github.com/mcollina/hwp/issues/6

Would it make sense to also support the abort controller as an input?

Not sure I follow?

Never mind! Could you add it this to the README?

done


Solve testfailure when network is unable

Fix #1733
As a software engineer, I want to use Jsoup library offline for some file parsing so that it is necessary for Jsoup to pass the test when offline.

Thanks. Feel it would be better just to move that specific test to the internal hosted tests. Not inclined to merge.


Lake now selects a different executable when there are multiple with the same name.

Std and Mathlib have both previously had a lean_exe called runLinter.
Prior to v4.1.0-rc1, in Mathlib, running runLinter would run the Mathlib one. After v4.1.0-rc1, it instead runs the Std one.
This had the unfortunate effect of allowing us to merge the first attempted bump to v4.1.0-rc1 while linting was actually failing, because this change had effectively disabled linting in CI!
As a workaround for now, I have renamed runLinter to Mathlib to runMathlibLinter.
Proposed change:

restore the original behaviour, so the "furthest downstream" executable wins.
possibly give a warning?
whatever is different from previously, document in RELEASES.md

This issue may be sufficient to cut a new release candidate, depending on how strongly people feel about the naming of the linter executable.

@semorrison Ah, the problem here is packages and executable now have a strict order and the current package is at the end of that order (because it is a topological ordering of dependencies). Previously, they had no defined order and it was just pure luck that Mathlib won (likely because it is alphabetically before Std and Lake uses an RBMap). I think the solution here is to check the workspace root first before checking the packages.

@semorrison Also note the correct one can also be run disambiguated via mathlib/runLinter (which the CI should maybe use?)

@semorrison Oh, and the name of the executable can be changed independently of the target via the exeName setting.
Finally, did this turn out to be a blocker? Or can a fix wait for later?

No, no blocker. I just renamed the Mathlib runLinter to runMathlibLinter. It's good to know mathlib/runLinter would have worked.
In the longer term we've realised that Std's and Mathlib's runLinter are essentially duplicated code, and probably should be combined (it's a trivial generalization of the Std linter script).
So I think the low-urgency resolution to this issue should be:

prefer executables from the current project


Publishing 1.3.0

Hi @feross,
Would you mind adding me on npm as well, or publish the v1.3.0 tag for me?
Thanks 🍻

Just published, sorry just catching up on github notifications after taking a long open source break. Currently have 900+ notifications to go... 😅


Unrecognized env variable

Hello, I attempted to run this container with a few of the specified environment variables:
        environment:
            - MONGODB_SSL_ALLOW_CONNECTIONS_WITHOUT_CERTIFICATES=true
            - MONGODB_SSL_ALLOW_INVALID_CERTIFICATES=true
            - MONGODB_SSL_ALLOW_INVALID_HOSTNAMES=true

It resulted in these errors:
> starting mongodb service

Error parsing command line: unrecognised option '--sslAllowConnectionsWithoutCertificates'

try 'mongod --help' for more information

If I comment out - MONGODB_SSL_ALLOW_CONNECTIONS_WITHOUT_CERTIFICATES=true then the container is able to start.
Are the environment variables correct?

I will come up with a new image, part of that will also be multiple tags for each minor and major version starting by 4.0

After merging https://github.com/dockhippie/mongodb/pull/21 all valid environment variables should be listed on the readme.


SwiftyDrawView(frame: X.frame)

Hi sir. Im sorry if I disturb you. But this what problem I encountered and I don't know if this relates to your pod.
This view with grey background is my sketch view (a view inside view controller)

The problem here is that when I draw it overlaps to my sketchview, and i can't draw in the upper portion of the sketchview (please just look at the screenshot)

Tried to run on Ipad simulator and this is the result

Problem Solve.
Thankyou bro! Godbless


KAFKA-10001: Should trigger store specific callback if it is also a listener

The store's registered callback could also be a restore listener, in which case it should be triggered along with the user specified global listener as well.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@mjsax @abbccdda thanks for the review, I'm adding unit tests now. Once done I will merge it.


fix bug window.URL.createObjectURL is not a function

fix bug window.URL.createObjectURL is not a function on Chrome

Thank you @guoqchen1001 for this awesome PR. Just published a new version.


Is there a way to make the compiler more performant?

Hey there! Thanks for all your hard work on this great library. I read in a previous issue that currently development is focused more on compatibility than performance. Which sounds great, but I also wanted to know if were any plans or ideas around how to make the performance of this library better?
I'm currently using scssphp to compile Bootstrap with custom variables on a server and the compilation process is taking about 1.5 - 2 seconds which does seem kind of slow.
Just wanted to know if there is a game plan out there yet and if there is somewhere I can jump in to help.
Thanks

Are you letting it compile every load?

Not per page load - but every time a custom variable is changed. For example, changing the background color, font color, button color, etc. and seeing a real-time update. I'm passing my variables via JavaScript and updating the stylesheet when the ajax function is complete. Since this process is synchronous I'm having to wait about a couple seconds before the next change can be made.

If you need performance, I would suggest using a php extension that uses libsass. When scssphp was first released, libsass hadn't been released yet.
Here are a couple of optimization ideas:

cacheable/serializable parse tree; for starters, the sourceParser in each block would need to change from being a reference to the current Parser to an index into a list of parsed files
eliminate the separate adjustAllChildren() pass in the Nested formatter

Thanks, I've looked at the libsass php extension but was hoping to find a solution that could easily be used without having to install anything. The goal is to add a scss compiler to a self-hosted solution that runs out of the box and scssphp seemed to have fit that use case better.
Thanks for sharing those ideas on optimization.

We are using leafo SCSS compiler in Gantry 5 framework and its serving us fine, but I agree that compilation times and high memory usage are a bit issue in some hosts. But those put aside, I think they work great and there are indeed some ways to optimize, which I have been playing with.
One of the most obvious ways to improve the speed is to only recompile when user saves the changes. For the others, I'm still looking ways to save both memory and CPU time.

I'm currently using scssphp to compile Bootstrap with custom variables on a server and the compilation process is taking about 1.5 - 2 seconds which does seem kind of slow.

I'm compiling bootstrap and it takes over 60 seconds... has something changed since then or am I doing something wrong?


Add Python 3.7 to testing suite, maybe remove 3.5?

A further suggestion for the CI: we could also create a few actual environment files (similarly as I did for geopandas: https://github.com/geopandas/geopandas/tree/master/ci/travis, but then not that many).
That way, we can also test different versions of dependencies (to ensure everything works with the minimal versions we say to support), as opposed to only the latest versions now.

BTW, happy to do a PR for this, if that is desired.

Nice! I thought we were already testing on Python 2 and 3 already. Just to get my head around it, this would expand that approach to a few more setups? I think that'd be good in principle. How hard to maintain would it be?

How hard to maintain would it be?

In itself, it's not much harder to maintain. It would just create a few environment yml files next to the requirements.txt.
But of course, properly testing "oldest supported" versions will give more maintenance work than only testing the latest versions. But we can be quite aggressive in bumping minimum versions (currently we don't really specify that, so that would be a first thing to do)

I like that idea. Maybe we should rather than commit to support many versions, say that they might work but be explicit about which ones we do support and what's our philosophy (ie. support the latest ones best until they fail for lack of support upstream)?

Thinking on this. I'd drop 3.5 for now so all tests are back to green and, if we find bandwidth, we can add a more comprehensive testing framework later on. I'm not too worried about supporting older versions as contextily is probably used most at the end of the pipeline in an interactive way, so users would access it on the standard version, which I'd imagine aligns pretty well with whatever Anaconda is distributing (and conda-forge supporting) at the moment. What do you think on dropping 3.5 for now @jorisvandenbossche? On the more comprehensive approach, of course, PRs most welcome! :-)

Fixed with #81


VSCode users documentation improvements and pre-build steps for local .NET Aspire development

We need to add an instructions for non-experienced developers to add intermediate steps in-between of a building instructions to prevent issue with self signed certificates on some systems or browsers with enhanced security options (Mozilla Firefox, Google Chrome)
Error is:
The remote certificate is invalid because of errors in the certificate chain: UntrustedRoot", DebugException="System.Net.Http.HttpRequestException: The SSL connection could not be established, see inner exception.")
The proposal:
We need to add to the documentation explaining local .NET  Aspire project dotnet tools prerequisites including generation and installing steps for a self-signed certificates
Files affected:
CONTRIBUTING.md
Proposal Test:
Execute commands:
Using dotnet dev-certs (for Local Development Only)
The dotnet dev-certs command is specifically for managing HTTPS development certificates for ASP.NET Core applications running on localhost. It does not add certificates to the system's trusted root certificate store for external servers or databases.
Generate a new HTTPS development certificate:
dotnet dev-certs https --trust

Export the HTTPS development certificate:
dotnet dev-certs https -ep path/to/certificate.pfx -p yourpassword

Verify the HTTPS development certificate:
dotnet dev-certs https --check --trust

@csharpfritz Can I just add a PR to that file to simplify starting a .NET Aspire AppHost project to run SharpSite project for non-experienced users and lower prerequisites to VSCode only and .NET SDK 9? Do we need to mention .NET SDK 9 site link for download and install VSCode as an optional IDE?

I like the idea of updating the CONTRIBUTING doc so that the mention of the .NET 9 SDK links to the download page for version 9 of the SDK.

I sometimes forget those steps to get ASP.NET Core development working locally.  This is a good note to add to CONTRIBUTING

@csharpfritz i forgot about this link as well:
https://dotnet.microsoft.com/en-us/download/dotnet/9.0
we need to put it somewhere will make a commit right now

Finally I picked this error message on metal on another PC, and solution worked again:
@csharpfritz I will close this issue with documentation as it fixed with version 0.4


Statement jumps back on repeated dragging events

The first time dragging a statement, it follows the cursor nicely, and stays in place on the new position when let go.
However, when clicking that previously moved statement, it snaps back to its original position once the cursor is moved. It then follows the cursor with the fixed offset between the mouse and where it was in its original position.
This makes it impossible to make fine adjustments or move a statement over 'long distances' when moving different parts of the canvas into view.

fixed in #28


Add css property touch-action: none; to document body.

Description
In the website demo ( https://modelviewer.dev/ ) scrolling around to view the model (astronaut) isn't smooth on mobile plus I can accidentally reload the page when scrolling downwards. The touch-action: none css property added to the body of the document prevents accidental page reloads from scrolling and provides smoother scrolling.
Live Demo
https://drive.google.com/file/d/10VJWJNCc3g8uRA0iPaJ1-jIz4taabP5t/view?usp=drivesdk
Version

model-viewer: v1.5.0

Browser Affected

[ * ] Chrome, version: 89.0.4389.72
[ ] Edge
[ ] Firefox
[ ] IE
[ ] Safari

OS

[ * ] Android
[ ] iOS
[ ] Linux
[ ] MacOS
[ ] Windows

We have this as an attribute (because the CSS version of touch-action seems to be quite buggy on iOS): https://modelviewer.dev/docs/#entrydocs-stagingandcameras-attributes-touch-action
Have you tested to find that the behavior is smoother with CSS touch-action: none? That would surprise me, since it looks like you're seeing low frame rate due to GPU rendering performance.

It usually seems as if its GPU performance but touch-action: none enhances speed greatly.

Can you post side-by-side links so we can see the speed difference you're talking about?

We have this as an attribute (because the CSS version of touch-action seems to be quite buggy on iOS): https://modelviewer.dev/docs/#entrydocs-stagingandcameras-attributes-touch-action
Have you tested to find that the behavior is smoother with CSS touch-action: none? That would surprise me, since it looks like you're seeing low frame rate due to GPU rendering performance.

It seems it is actually just GPU rendering performance since touch-action: pan-y has been added already. However, I noticed that with the touch-action property set to anything other than 'none' even though giving a smoother experience lags only when scrolling the page and model simultaneously but apart from that everything is fine.


sec:access incorrectly allowing access

Grails version: 3.3.0
Spring security plugin version: 3.2.0.M1
I have a call to the sec:access taglib that looks like this:
<sec:access controller='user' action='list'>

<g:link class="list" action="list" controller="user">List Users</g:link>

</sec:access>

And all the controllers live behind /admin (from UrlMappings)
"/admin/$controller/$action?/$id?(.$format)?" {constraints {}}

And I have a rule in application groovy:
grails.plugin.springsecurity.controllerAnnotations.staticRules = [
	[pattern: '/user/**', access: ['ROLE_ADMINISTRATOR']]
]

The line here creates an incorrect url to check against.
Expected Behavior
The link generated should be /admin/user/list which should fail for any other role but 'ROLE_ADMINISTRATOR'
Actual Behavior
The link generated is //admin/user/list (Note the double slash) which webInvocationPrivilegeEvaluator.isAllowed permits. Without the base: '/' it works correctly.

Hi James!  Thank-you for submitting this bug and including expected vs actual behavior  :)
I've verified this bug has been fixed by PR https://github.com/grails-plugins/grails-spring-security-core/pull/487 and will be in the next release of the plugin. ✨


ljungbox

Hello,
There a problem with ljungbox function. your calcul begin with a lag 0, but in this doc : https://en.wikipedia.org/wiki/Ljung–Box_test the calcul begin with a lag 1!
I compare your result with amazon dataset :
from verticapy.stats import ljungbox
vpy_jun = ljungbox(amazon_unique_copy,
         column = "random",
         ts = "date",
         p = 10,
         alpha = 0.05,
         box_pierce = False)

the result is :

In python :
statsmodels.stats.diagnostic.acorr_ljungbox(amazon_unique_copy.to_pandas().sort_values("date")["random"], lags = 10, auto_lag = False)
the result is :

The big difference is the lag 0 which is not present is python.
Event if you remove the lag 0, there will be an other small difference, but it will be an other issue.
Regards,
Alexandre

This issue is corrected. Thanks again for reporting it.


Callback in RegisterModuleInit isn't called

I have
revel.RegisterModuleInit(func(m *revel.Module) {
    ...
})

in my modules. But ... is never called.
I found out, that in revel/revel/module.go function RegisterModuleInit doesn't get the package path key in line 40.
key := fmt.Sprintf("%+k", stack.Caller(1))

So all modules are mapped to "" in appModule.initializedModules. Following the docs "%+k " should get the package path. But it doesn't seem to work.
go version go1.13.6 windows/amd64

Replacing imports does the trick

Merged to develop branch


Timestamp verification for Mailgun fails with large volumes for

We use laravel-mailbox receive lots of emails each day. Since a few weeks, we see more and more messages failing with a temporary error in Mailgun and eventually some mail will fail definitely.
I've done some investigation and the problem is caused by the timestamp verification in the MailgunRequest. I've manually changed the time to ten minutes and all the messages are now arriving successfully.
There are two possible solutions to this issue:

Increase the time to when a message is considered to old
Drop the check for the freshness of a message

The documentation of Mailgun doesn't mention a check on the timestamp, so I would propose to remove the check of the freshness of the message.

Making it secure
There’s nothing to stop someone who knows our webhook URL from crafting false event data and sending it to the URL. Luckily, Mailgun signs each request sent and posts the following parameters as well:

timestamp (number of seconds passed since January 1, 1970)
token (randomly generated string with length 50)
signature (hexadecimal string generated by HMAC algorithm)

To verify the token, you need to:

Concatenate the values of timestamp and token.
Encode the resulting string with HMAC, using your Mailgun API key as the key and Sha256 as the algorithm.

I'd be happy to create a PR for either solution.

Adding my 2 cents - I would be in favor of removing the isFresh check on the MailgunRequest. Seems like it introduces a failure point that is already covered by the signature provided by Mailgun.


Load instrumentation key on target environments

What does this pull request do?
Load instrumentation key on target environments
APPINSIGHTS_INSTRUMENTATIONKEY was always unset on all environments -- this is now read from the same secret that the service uses
Switched to the longer name as the service uses APPLICATIONINSIGHTS_CONNECTION_STRING and I thought usig the same prefix helps
What is the intent behind these changes?
This will enable tracing across all interventions apps

why not use the same variable - "connection string" - instead of instrumentation key in this deploy?

that's much better 👍 let me do that

@tomsmyers done in 5cb9d6f8e5eb7d26ea9a2142a902430a88d3f0e8

(forgot the secrets example -- no other changes)


gRPC payload size too big

Describe the bug
When the function result payload size is too large it fails to send it through gRPC.
direktiv-source pod logs
2023-02-05T10:58:30.142307679Z {"level":"error","ts":"2023-02-05T10:58:30.142Z","caller":"direktiv-knative-source/main.go:144","msg":"failed to receive message: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (6752641 vs. 4194304)","stacktrace":"main.main\n\tgithub.com/vorteil/direktiv-knative-source/cmd/direktiv-knative-source/main.go:144\nruntime.main\n\truntime/proc.go:255"}

This is caused by the payload size being greater than the limit of 4194304 bytes. Would be great if there's a way to increase this limit.

This is the default GRPC limit. Can you please provide a bit more context of what container you use? It looks like a knative source one? Within Direktiv the limit is 128MB at the moment and we can increase it to that in that container as well to keep them the same but I would need to know where and what that is.

you mean the image for direktiv source ?
Image ID:      docker.io/vorteil/direktiv-knative-source@sha256:14bf5b329c0a061afc98f6abbaea645bc8959a15cee7a49b08030a2c5d39efdd

Cool, thanks.

Reminder: The payload size has to be modified on port 3333 in the event receiver in flow.

where and how do i change the size limit? Does that mean I have to create a custom built container image ?


[joss][docs] Performance limits?

Part of: https://github.com/openjournals/joss-reviews/issues/6336
one more thing - I assume there are some images that would be so big they would crash the browser/etc. have y'all done any sort of performance benchmarking to give people interested in this tool some idea of "this tool is for you if your images are <1TB big"
It's a documentation question rather than a capability one - it works great with the sample images i threw at it, and i wouldn't expect to use it for those humongous bazillion Tesla scans that need a whole room of hard drives to store, so mostly a "would be nice" section in the docs to pre-empt the inevitable issue of someone asking if it's for them!

Very impressive :)


Several change to Reuters Bridge.

Each edition of Reuters now splited up into each context.
Rewrite some code logic, now using their type in API to checking.
Add some new feeds specific to U.K edition.

Thank for all comments in the bridge. It's really nice 👍
P/s: You need to pull the latest commits from https://github.com/rss-bridge/rss-bridge/ before checking this.

Close #1


Fix various javadoc issues

Motivation:
In order to release this project we need a successful javadoc build.
Modifications:
Fix various javadoc issues
Result:
Javadoc can be generated successfully

@chrisvest @normanmaurer PTAL
The CI build fails because it builds the most recent Netty sources.
https://github.com/netty/netty/pull/12593, which is post Alpha3 release, changes the API and this causes the CI failure.
I think we can stop building Netty from sources on the CI and we can start using the SNAPSHOT builds on sonatype.

Yeah, I'll look into this.

Cool, build passed when merged into the updated workflows.


README: trim faq and point to the main site

Fixes #246
Signed-off-by: Vincent Batts<EMAIL_ADDRESS>

lgtm thanks bud

LGTM


Exception message thrown by WinRT object is not preserved by C#/WinRT

Click the button in these two repro apps to see the issue:
ColorPickerExceptionMessageUWP.zip
ColorPickerExceptionMessageDesktop.zip
In the UWP application, which does not use C#/WinRT projections, setting ColorPicker.MaxHue to an invalid value causes an ArgumentException to be thrown that gives the specific information that the value must be between 0 and 359.  In the desktop application, which does use C#/WinRT projections, the ArgumentException is still thrown, but the specific error message is lost - all we get is the default ArgumentException error message.

Issue looks to be we store the restricted error info message in the data dictionary and not actually use it for the message.  Looking for a way to set it.

fixed by #1228
App.UnhandledException fix will be available in Windows App SDK 1.2 Preview 2


feature: resolve parameters in Page.url

This allows to build URLs for pages dynamically based on the options.urlParams that are handed over to the page.
Uses the same node-module that express uses, so the very same syntax applies. For example use “http://httpbin.org/get?test=:test” with options = {urlParams: {test: true}} to get “http://httpbin.org/get?test=true”.

@0ff This feature is very handy, much appreciate your contributions here 👍  However due to the fact that there is an open issue #17 regarding removal of the unwanted dependency, I'd not want to add path-to-regexp library as one of the dependency. Do you mind if I port this into an enhancement issue and then implement stripped down version without using the library. Or if you feel, you can create the issue and implement in the Milestone-Enhancements branch. I usually do something like below to achieve what you wanted to do.
function toQueryString(obj) {
    return (
        _.map(obj, (v, k) => {
            if (_.isArray(v)) {
                return (_.map(v, (av) => `${k}[]=${av}`)).join('&');
            } else {
                return `${encodeURIComponent(k)}=${encodeURIComponent(v)}`;
            }
        })
    ).join('&');
}

function toUrl(url = '', params = {}) {
    let q = this.toQueryString(params);
    let urlBuffer = [url];
    if (q) {
        urlBuffer.push(/\?.+$/.test(url) ? `&${q}` : `?${q}`);
    }
    return urlBuffer.join('');
}

@0ff This feature is very handy, much appreciate your contributions here 👍  However due to the fact that there is an open issue #17 regarding removal of the unwanted dependency, I'd not want to add path-to-regexp library as one of the dependency. Do you mind if I port this into an enhancement issue and then implement stripped down version without using the library. Or if you feel, you can create the issue and implement in the Milestone-Enhancements branch. I usually do something like below to achieve what you wanted to do.
function toQueryString(obj) {
    return (
        _.map(obj, (v, k) => {
            if (_.isArray(v)) {
                return (_.map(v, (av) => `${k}[]=${av}`)).join('&');
            } else {
                return `${encodeURIComponent(k)}=${encodeURIComponent(v)}`;
            }
        })
    ).join('&');
}

function toUrl(url = '', params = {}) {
    let q = this.toQueryString(params);
    let urlBuffer = [url];
    if (q) {
        urlBuffer.push(/\?.+$/.test(url) ? `&${q}` : `?${q}`);
    }
    return urlBuffer.join('');
}


how i can use ethers by python?

how i can use ethers by python?

Ethers is a JavaScript library, so there is no way to directly use it in Python. Their may be JavaScript VM libraries, but that is out of scope for ethers…


[TS migration] Migrate 'App.js' file to TypeScript

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/25230
PROPOSAL: https://github.com/Expensify/App/issues/25230#issuecomment-1911929456
Tests
Same as QA step

[ ] Verify that no errors appear in the JS console

Offline tests
Same as QA step
QA Steps
Verify that app is launched successfully without any console error

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/97676131/4fae23a8-b587-40a6-95bf-996edae9f71d

Android: mWeb Chrome
https://github.com/Expensify/App/assets/97676131/0c0b130d-aff7-4476-b27e-c8e352bf07bb

iOS: Native
https://github.com/Expensify/App/assets/97676131/201777c3-93ef-4166-8a4b-e9a925c68f2c

iOS: mWeb Safari
https://github.com/Expensify/App/assets/97676131/35dcc0c3-aeb4-4a90-930d-2a5166e22d61

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/97676131/481d0af3-9477-4e85-8f93-bc145345218b

MacOS: Desktop
https://github.com/Expensify/App/assets/97676131/6ed631aa-23a3-44ef-bbd8-8e8d84ecd730

@deetergp all yours

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/deetergp in version: 1.4.40-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
failure ❌

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.40-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
failure ❌


RUMM-2796 RequestFactory can throw exceptions

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #1212 (a896748) into develop (640dc96) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1212      +/-   ##
===========================================
- Coverage    82.30%   82.29%   -0.01%
===========================================
  Files          353      353
  Lines        11799    11798       -1
  Branches      2009     2007       -2
===========================================
- Hits          9710     9708       -2
- Misses        1474     1476       +2
+ Partials       615      614       -1

Impacted Files
Coverage Δ

...otlin/com/datadog/android/v2/api/RequestFactory.kt
0.00% <ø> (ø)

...android/v2/core/internal/net/DataOkHttpUploader.kt
94.81% <100.00%> (+0.28%)
:arrow_up:

...n/com/datadog/android/v2/core/SdkInternalLogger.kt
80.77% <0.00%> (-3.85%)
:arrow_down:

...droid/rum/tracking/FragmentViewTrackingStrategy.kt
75.00% <0.00%> (-3.85%)
:arrow_down:

...android/rum/internal/ndk/DatadogNdkCrashHandler.kt
86.21% <0.00%> (-0.99%)
:arrow_down:

.../kotlin/com/datadog/android/v2/core/DatadogCore.kt
88.94% <0.00%> (-0.92%)
:arrow_down:

...ndroid/telemetry/internal/TelemetryEventHandler.kt
72.27% <0.00%> (-0.84%)
:arrow_down:

...android/log/internal/domain/DatadogLogGenerator.kt
95.97% <0.00%> (-0.67%)
:arrow_down:

.../android/rum/internal/domain/scope/RumViewScope.kt
95.24% <0.00%> (ø)

...android/v2/core/internal/DatadogContextProvider.kt
81.54% <0.00%> (ø)

... and 5 more


⚠ Bofrost.nl has degraded performance

In 70eff18, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 3378 ms

Resolved: Bofrost.nl performance has improved in 247c415 after 15 minutes.


On Debian 7 is wrong package version?

Cookbook version
8.0.1
Chef-client version
12.13.37
Platform Details
bentoo/debian-7.9 on VirtualBox
Scenario:
Trying to install simple webapp
During install mysql client service:
STDERR: E: Version '5.5.49-0+deb7u1' for 'mysql-client-5.5' was not found
---- End output of apt-get -q -y install mysql-client-5.5=5.5.49-0+deb7u1 ----
Ran apt-get -q -y install mysql-client-5.5=5.5.49-0+deb7u1 returned 100
According to https://packages.qa.debian.org/m/mysql-5.5.html 5.5.49 is only available for deb8u1. Adding   package_version '5.5.50-0+deb7u2' to service definition solves problem. It looks like this version should be returned by helper: https://github.com/chef-cookbooks/mysql/blob/master/libraries/helpers.rb#L177

Fixed up in 8.0.2


frameit (Landscape detection not working as expected)

Problem:
Landscape screenshots of iPhone and iPad frames are not framed correctly, see attached.
It seems the landscape detection part doesn't seem to understand the offset/widths correctly?
Specs:

Running frameit directly from the console
Version: frameit 3.0.0;
Screenshot sizes are correct (iPhone 750x1334px, iPad 2048x1536px)
I'm using the latest frames version

Can anyone reproduce this?

@psamhaber I think I've seen another report elsewhere so we are going to test on our end. Thanks!

Yes, I can reproduce this when no background is set.

@TKBurner any update on this? I would fix it myself but my ruby skills are basic at best.
Looking at editor.rb (line 23ff) I guess the problem lies in width = offset['width']. If you check the resulting screens I attached above, it looks like the width value is taken from before the frame is flipped...

Thanks for the report! I've reproduced this locally, and will look into it. 👍

Hi folks - I've merged a change in #7759 that seems to fix this problem. If possible, could you give it a try before we ship it in the next release?
Thanks! 🙌

Hi Michael, it's working again, awesome! Thanks a bunch!

Great - glad to hear it! 🙌
This has shipped as part of fastlane 2.6.0 :rocket:


Detect Test Failures

To catch failures in the test suite, the exit code of each test is checked.
Description

An additional option, --python-exit-code 1 is added to the subprocess.call command. With some additional code in each test script, this allows the main script to detect when the test has failed.

I had to fix a few errors that are specific to the commandline version of blender.
Furthermore, the error propagation was not easy, but with your code I got a head start, thanks!
Next up I will fix the failing tests. Have a great week!


feat: add rsbuild-plugin-monaco-editor-nls example

I wrote a plugin, rsbuild-plugin-monaco-editor-nls, for the Monaco Editor in rsbuild to simplify localization.

ok，I will.

LGTM 👍 Can you resolve the conflicts?

ok，i will.

Thank you!