added roc1 + roc2 for compare.md

Describe your changes
added roc1 + roc2 for compare.md
Issue ticket number and link
Closes #227
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have added thorough tests (when necessary).
[x] I have added the right documentation (when needed). Product update? If yes, write one line about this update.

:books: Documentation preview :books:: https://sklearn-evaluation--234.org.readthedocs.build/en/234/

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.1%) to 94.333%

Files with Coverage Reduction
New Missed Lines
%

src/sklearn_evaluation/telemetry.py
2
96.92%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
2730

Relevant Lines:
2894

💛  - Coveralls

@WSShawn make sure the docs are visible once you're done

the header levels are incorrect:

let's create a new ROC section and put the ROC-related subsections under it

ok

I was able to add a new ROC section but on the menu bar, it does not show the subsections.

they show up once you scroll. looks good, if the CI passes, I'll merge!

great work!


Override assert_eq and assert_ne macros

Description of changes:
For assert_eq and assert_ne macros, Kani currently displays a confusing message:
a panicking function core::panicking::assert_failed is invoked: SUCCESS

and generates many checks (see #13 for an example).
With the changes in this PR, a more intuitive message is displayed. For example:
$ cat test.rs
fn main() {
    let x = 1;
    let y = 2;
    assert_eq!(x + 1, y);
    assert_eq!(x, y); //Expected failure
    assert_ne!(x, y);
}
$ kani test.rs
<snip>
** Results:
[assertion.1] Code generation sanity check: Correct CBMC vtable size for StructTag("tag-_4317141983261250885") (MIR type Closure(DefId(2:9147 ~ std[2f3c]::rt::lang_start::{closure#0}), [(), i8, extern "rust-call" fn(()) -> i32, (fn(),)])). Please report failures:
https://github.com/model-checking/kani/issues/new?template=bug_report.md: SUCCESS
[pointer_primitives.1] dead object in OBJECT_SIZE(&temp_0): SUCCESS
/home/ubuntu/git/kani/tests/expected/assert-eq/test.rs function main
[main.assertion.1] line 4 assertion failed: x + 1 == y: SUCCESS
[main.assertion.2] line 5 assertion failed: x == y: FAILURE
[main.assertion.3] line 6 assertion failed: x != y: SUCCESS

** 1 of 5 failed (2 iterations)
VERIFICATION FAILED

Resolved issues:
Resolves #13
Call-outs:

Testing:

How is this change tested? Existing test (tests/expected/assert-eq)

Is this a refactor change? No

Checklist

[X] Each commit message has a non-empty body, explaining why the change was made
[X] Methods or procedures are documented
[X] Regression or unit tests are included, or existing tests cover the modified code
[X] My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

It would be nice if the message was closer to the std one, but not a blocker since this is so much better than what we have today.

I'm not sure how to make the message closer to the std one since the std one is multiline. For this program:
fn eq(x: i32, y: i32) {
    assert_eq!(x, y);
}

fn main() {
    eq(5, 7);
}

The std message is:
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `5`,
 right: `7`', eq.rs:2:5

whereas the kani one is:
assertion failed: x == y

If you have ideas, I can do that in a follow-up PR.

Another nice to have is a little blob explaining why we are overriding these.

Added a detailed explanation.


Template issues in Laravel 11

I'm migrating my app to Laravel 11 and have issue with templates. I use the minimal template where I only display the message ie. {{ formatted }}, but for some reason the app name with the log type is also sent as a message to Telegram. Any ideas what could be the issue? Seems like the published template is not being used.

OK for some reason it just started working when I added random text to the template and then removed it.


python311Packages.cf-xarray: 0.9.0 -> 0.9.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.cf-xarray is: An accessor for xarray objects that interprets CF attributes
meta.homepage for python311Packages.cf-xarray is: https://github.com/xarray-contrib/cf-xarray
meta.changelog for python311Packages.cf-xarray is: https://github.com/xarray-contrib/cf-xarray/releases/tag/v0.9.1
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.9.1 with grep in /nix/store/9mvqv6qar5a3228v2mgck2lr8hjvl2nr-python3.11-cf-xarray-0.9.1
found 0.9.1 in filename of file in /nix/store/9mvqv6qar5a3228v2mgck2lr8hjvl2nr-python3.11-cf-xarray-0.9.1

Rebuild report (if merged into master) (click to expand)

7 total rebuild path(s)

7 package rebuild(s)

First fifty rebuilds by attrpath

python311Packages.cf-xarray
python311Packages.qcodes
python311Packages.qcodes-contrib-drivers
python312Packages.cf-xarray
python312Packages.qcodes
python312Packages.qcodes-contrib-drivers

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/9mvqv6qar5a3228v2mgck2lr8hjvl2nr-python3.11-cf-xarray-0.9.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.cf-xarray https://github.com/r-ryantm/nixpkgs/archive/56c873c0e4a7529325213a15cee004c442b74c94.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/56c873c0e4a7529325213a15cee004c442b74c94#python311Packages.cf-xarray

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/9mvqv6qar5a3228v2mgck2lr8hjvl2nr-python3.11-cf-xarray-0.9.1
ls -la /nix/store/9mvqv6qar5a3228v2mgck2lr8hjvl2nr-python3.11-cf-xarray-0.9.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

12 packages built:

python311Packages.cf-xarray
python311Packages.cf-xarray.dist
python311Packages.qcodes
python311Packages.qcodes-contrib-drivers
python311Packages.qcodes-contrib-drivers.dist
python311Packages.qcodes.dist
python312Packages.cf-xarray
python312Packages.cf-xarray.dist
python312Packages.qcodes
python312Packages.qcodes-contrib-drivers
python312Packages.qcodes-contrib-drivers.dist
python312Packages.qcodes.dist

Maintainer pings
cc @fabaff for testing.

Result of nixpkgs-review pr 314684 at 56c873c0 run on aarch64-darwin 1

6 packages built successfully:

python311Packages.cf-xarray
python311Packages.qcodes
python311Packages.qcodes-contrib-drivers
python312Packages.cf-xarray
python312Packages.qcodes
python312Packages.qcodes-contrib-drivers


New version: JDF v0.2.1

Registering package: JDF
Repository: https://github.com/xiaodaigh/JDF.jl
Created by: @xiaodaigh
Version: v0.2.1
Commit: 51b663043a48066c0a65515f0c2217dbd401dcc3
Reviewed by: @xiaodaigh
Reference: https://github.com/xiaodaigh/JDF.jl/commit/51b663043a48066c0a65515f0c2217dbd401dcc3#commitcomment-35629749

Your new version pull request met all of the guidelines for automatic merging.
I will automatically merge this pull request during the next cron job.
If you want to prevent this pull request from being auto-merged, simply leave a comment.
(If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.)

On a separate note, I see that you are registering a release with a version number of the form v0.X.Y.
Does your package have a stable public API? If so, then it's time for you to register version v1.0.0 of your package. (This is not a requirement. It's just a recommendation.)
If your package does not yet have a stable public API, then of course you are not yet ready to release version v1.0.0.

[noblock]


zebrapack should fall back to not a full load, just parse standalone like msgp

otherwise the load can fail when a file isn't complete by itself:
~/go/src/github.com/glycerine/tmframe2 (master) $ go generate
======== ZebraPack Code Generator  =======
>>> Input: "date.go"
date.go:59:2: undeclared name: panicOn

here panicon.go has the function pancOn, but we aren't doing codegen for it.

I think this issue is still present in the current version (v4.1.0) — unless I'm doing something wrong? Here's an example:
foo.go
package p

type Foo struct{}

bar.go
package p

//go:generate zebrapack

type Bar struct {
	N int `zid:"0"`
}

func Do(f Foo) Bar {
	return Bar{}
}

$ go generate .
bar.go:9:11: undeclared name: Foo
error in getast.go: loader.Load() error: 'couldn't load packages due to errors: p'
bar.go:3: running "zebrapack": exit status 1

See the fix that closed this issue.  Its nice being able to resolve constants from imported packages. The loader gives us that. But then parsing files that don't compile/can't yet have their imports resolved/or have multi-file dependencies like this situation, it becomes finicky. For greenpack I changed disabled the loader as an option, it is back to -no-load always. I may well do so yet with zebrapack too, if the load feature proves to cumbersome to use/doesn't offer sufficient benefit.


Max length option

Is it possible to have a max length option?

Max length doesn't work with this.

@alexandredavi and @vinodbirajdar. The maxlength html input attribute worked as expected in my tests.

Minimum and maximum values validation are now available in version 5.3.0.

I am looking forward for max character length masking. ( not max validation)
Would be nice to add it as option parameter.


brew unable to update after installation on macOS Mojave

What you were trying to do (and why)

macOS Mojave
Install brew with /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
brew update

What happened (include command output)

Command output

Updating Homebrew...
error: waitpid for config failed: No child processes
error: waitpid for gc failed: No child processes

What you expected to happen
brew updated
Output of brew config and brew doctor commands

16:02:37 ~
§ brew config
HOMEBREW_VERSION: 2.2.0
ORIGIN: https://github.com/Homebrew/brew
HEAD: 7d7de295dfbc5e581106e2b1f674496b5e25a773
Last commit: 8 days ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 70ee7daeb9b6c8c82eee6edb2204a88f9b174820
Core tap last commit: 6 hours ago
HOMEBREW_PREFIX: /usr/local
CPU: dodeca-core 64-bit kabylake
Homebrew Ruby: 2.6.3 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3/bin/ruby
Clang: 10.0 build 1001
Git: 2.20.1 => /Library/Developer/CommandLineTools/usr/bin/git
Curl: 7.54.0 => /usr/bin/curl
macOS: 10.14.6-x86_64
CLT: <IP_ADDRESS>.1.1562985497
Xcode: 11.2.1
CLT headers: <IP_ADDRESS>.1.1562985497

16:09:08 ~
§ brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Comments
This issue seems related to https://github.com/Homebrew/brew/issues/3228
Looks like either something should be done to installer to automatically perform sudo chown -R $(whoami) $(brew --prefix)/* after installation, or this manual step should be added to installation steps.
Because otherwise brew seems unable to update until it is done.
After I performed it, it was fine:
16:02:05 ~
§ sudo chown -R $(whoami) $(brew --prefix)/*
Password:

16:02:32 ~
§ brew update
Already up-to-date.

This is an issue specific to you you'll need to figure out yourself. Please report similar issues to Discourse in future.

@MikeMcQuaid sorry you mean it's not a generic Mojave issue? Because I would expect it is.

you mean it's not a generic Mojave issue?

It's not.

Have you even read before closing?

Yes.


cross-compile issues

OS and version used:
openwrt 10.03

Python runtime used:
2.7.12

SDK version used:
azure-iot-sdk-python

Description of the issue:
Enconter errs while cross-compile，
make[2]: *** [python/test/CMakeFiles/iothub_client_mock.dir//src/iothub_client_python.cpp.o] Error 1
make[1]: *** [python/test/CMakeFiles/iothub_client_mock.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make[2]: *** [python_service_client/tests/CMakeFiles/iothub_service_client_mock.dir//src/iothub_service_client_python.cpp.o] Error 1
make[1]: *** [python_service_client/tests/CMakeFiles/iothub_service_client_mock.dir/all] Error 2
make: *** [all] Error 2
Code sample exhibiting the issue:
./build.sh --toolchain-file toolchain-openwrt.cmake -cl -ldl
Console log of the issue:
[ 40%] Building C object iothub_client/CMakeFiles/iothub_client.dir/src/iothubtransport.c.o
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:734:72: sorry, unimplemented: non-static data member initializers
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:734:72: error: 'constexpr' needed for in-class initialization of static data member '_iothubServiceClientAuthHandle' of non-integral type
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In constructor 'IoTHubServiceClientAuth::IoTHubServiceClientAuth(std::string)':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:742:9: error: '_iothubServiceClientAuthHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'void IoTHubServiceClientAuth::Destroy()':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:759:13: error: '_iothubServiceClientAuthHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'IOTHUB_SERVICE_CLIENT_AUTH_TAG* IoTHubServiceClientAuth::GetHandle()':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:768:16: error: '_iothubServiceClientAuthHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: At global scope:
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:832:72: sorry, unimplemented: non-static data member initializers
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:832:72: error: 'constexpr' needed for in-class initialization of static data member '_iothubServiceClientAuthHandle' of non-integral type
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:833:66: sorry, unimplemented: non-static data member initializers
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:833:66: error: 'constexpr' needed for in-class initialization of static data member '_iothubRegistryManagerHandle' of non-integral type
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In constructor 'IoTHubRegistryManager::IoTHubRegistryManager(std::string)':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:843:9: error: '_iothubServiceClientAuthHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:849:9: error: '_iothubRegistryManagerHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In constructor 'IoTHubRegistryManager::IoTHubRegistryManager(IoTHubServiceClientAuth)':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:863:9: error: '_iothubServiceClientAuthHandle' was not declared in this scope[ 41%] Building C object uamqp/CMakeFiles/uamqp.dir/src/header_detect_io.c.o
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:869:9: error: '_iothubRegistryManagerHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'void IoTHubRegistryManager::Destroy()':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:886:13: error: '_iothubRegistryManagerHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:892:13: error: '_iothubServiceClientAuthHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'IOTHUB_DEVICE IoTHubRegistryManager::CreateDevice(std::string, std::string, std::string, IOTHUB_REGISTRYMANAGER_AUTH_METHOD)':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:918:53: error: '_iothubRegistryManagerHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'IOTHUB_DEVICE IoTHubRegistryManager::GetDevice(std::string)':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:935:50: error: '_iothubRegistryManagerHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'void IoTHubRegistryManager::UpdateDevice(std::string, std::string, std::string, IOTHUB_DEVICE_STATUS, IOTHUB_REGISTRYMANAGER_AUTH_METHOD)':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:962:53: error: '_iothubRegistryManagerHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'void IoTHubRegistryManager::DeleteDevice(std::string)':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:977:53: error: '_iothubRegistryManagerHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'boost::python::list IoTHubRegistryManager::GetDeviceList(size_t)':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:994:54: error: '_iothubRegistryManagerHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'IOTHUB_REGISTRY_STATISTICS IoTHubRegistryManager::GetStatistics()':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1022:54: error: '_iothubRegistryManagerHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: At global scope:
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1220:72: sorry, unimplemented: non-static data member initializers
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1220:72: error: 'constexpr' needed for in-class initialization of static data member '_iothubServiceClientAuthHandle' of non-integral type
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1221:61: sorry, unimplemented: non-static data member initializers
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1221:61: error: 'constexpr' needed for in-class initialization of static data member '_iothubMessagingHandle' of non-integral type
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1222:48: sorry, unimplemented: non-static data member initializers
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1222:48: error: 'constexpr' needed for in-class initialization of static data member 'openCompleteContext' of non-integral type
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1223:48: sorry, unimplemented: non-static data member initializers
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1223:48: error: 'constexpr' needed for in-class initialization of static data member 'sendCompleteContext' of non-integral type
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1224:62: sorry, unimplemented: non-static data member initializers
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1224:62: error: 'constexpr' needed for in-class initialization of static data member 'feedbackMessageContext' of non-integral type
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'void IoTHubMessaging::CreateContexts()':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1228:13: error: 'openCompleteContext' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1230:13: error: 'sendCompleteContext' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1232:13: error: 'feedbackMessageContext' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'void IoTHubMessaging::DestroyContexts()':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1238:13: error: 'openCompleteContext' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1240:39: error: type '' argument given to 'delete', expected pointer
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1242:13: error: 'sendCompleteContext' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1244:39: error: type '' argument given to 'delete', expected pointer
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1246:13: error: 'feedbackMessageContext' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1248:42: error: type '' argument given to 'delete', expected pointer
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In constructor 'IoTHubMessaging::IoTHubMessaging(std::string)':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1259:9: error: '_iothubServiceClientAuthHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1265:9: error: '_iothubMessagingHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In constructor 'IoTHubMessaging::IoTHubMessaging(IoTHubServiceClientAuth)':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1280:9: error: '_iothubServiceClientAuthHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1286:9: error: '_iothubMessagingHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'void IoTHubMessaging::Destroy()':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1304:13: error: '_iothubMessagingHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1310:13: error: '_iothubServiceClientAuthHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'void IoTHubMessaging::Open(boost::python::api::object&, boost::python::api::object&)':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1324:13: error: 'openCompleteContext' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1331:39: error: '_iothubMessagingHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1331:85: error: 'openCompleteContext' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'void IoTHubMessaging::Close()':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1343:31: error: '_iothubMessagingHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'void IoTHubMessaging::SendAsync(std::string, IoTHubMessage&, boost::python::api::object&, boost::python::api::object&)':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1354:13: error: 'sendCompleteContext' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1361:44: error: '_iothubMessagingHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1361:126: error: 'sendCompleteContext' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'void IoTHubMessaging::SetFeedbackMessageCallback(boost::python::api::object&, boost::python::api::object&)':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1375:13: error: 'feedbackMessageContext' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1382:61: error: '_iothubMessagingHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1382:118: error: 'feedbackMessageContext' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: At global scope:
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1445:72: sorry, unimplemented: non-static data member initializers
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1445:72: error: 'constexpr' needed for in-class initialization of static data member '_iothubServiceClientAuthHandle' of non-integral type
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1446:76: sorry, unimplemented: non-static data member initializers
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1446:76: error: 'constexpr' needed for in-class initialization of static data member '_iothubDeviceMethodHandle' of non-integral type
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In constructor 'IoTHubDeviceMethod::IoTHubDeviceMethod(std::string)':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1455:9: error: '_iothubServiceClientAuthHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1461:9: error: '_iothubDeviceMethodHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In constructor 'IoTHubDeviceMethod::IoTHubDeviceMethod(IoTHubServiceClientAuth)':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1475:9: error: '_iothubServiceClientAuthHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1481:9: error: '_iothubDeviceMethodHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'void IoTHubDeviceMethod::Destroy()':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1498:13: error: '_iothubDeviceMethodHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1504:13: error: '_iothubServiceClientAuthHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'IoTHubDeviceMethodResponse IoTHubDeviceMethod::Invoke(std::string, std::string, std::string, unsigned int)':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1525:44: error: '_iothubDeviceMethodHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: At global scope:
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1590:72: sorry, unimplemented: non-static data member initializers
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1590:72: error: 'constexpr' needed for in-class initialization of static data member '_iothubServiceClientAuthHandle' of non-integral type
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1591:72: sorry, unimplemented: non-static data member initializers
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1591:72: error: 'constexpr' needed for in-class initialization of static data member '_iothubDeviceTwinHandle' of non-integral type
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In constructor 'IoTHubDeviceTwin::IoTHubDeviceTwin(std::string)':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1600:9: error: '_iothubServiceClientAuthHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1606:9: error: '_iothubDeviceTwinHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In constructor 'IoTHubDeviceTwin::IoTHubDeviceTwin(IoTHubServiceClientAuth)':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1620:9: error: '_iothubServiceClientAuthHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1626:9: error: '_iothubDeviceTwinHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'void IoTHubDeviceTwin::Destroy()':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1643:13: error: '_iothubDeviceTwinHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1649:13: error: '_iothubServiceClientAuthHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'std::string IoTHubDeviceTwin::GetTwin(std::string)':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1664:45: error: '_iothubDeviceTwinHandle' was not declared in this scope
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: In member function 'std::string IoTHubDeviceTwin::UpdateTwin(std::string, std::string)':
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1687:48: error: '_iothubDeviceTwinHandle' was not declared in this scope

@wushichuan - Thanks for filing this issue. We'll investigate it.

Hi @wushichuan,
I'm not sure why you are seeing a cross compile error for OpenWrt. However, before we try and debug this I will need you to test something for me.
I successfully cross compiled the Azure IoT Hub Python library for OpenWrt but when I attempted to run it I found that the Python "Light" that is typically installed on OpenWrt devices does not support binary Python libraries. I would like you to cross compile a simple Python binary library. There are many samples on the Internet. Try and run that on your device. If it fails then you will need to consider cross compiling Python for your platform before we even address this issue. You may not have enough resources to run the complete Python package on your device which means you will need to use the C SDK instead.
Let me know what you find.
Mark Radbourne MSFT

Hi @markrad ,
Thanks for your reply, Accroding to you advices, I had cross compiled some python binary libs, just like psutils, apscheduler, multiprocessing, pymodbus and some other related libs,  and they work well. I should use the interfaces of libs in the python2.7 evironment, maybe the resources is enough. I had cross-compiled then C SDK version sucessfully, but failed with python SDK version.

Hi @wushichuan,
Do you know what versions of gcc and g++ you are running? The error messages are caused by a coding construct that is not supported by your compiler. It does not allow initialization of non-static member variables in a class. For example:
Error message:
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp: At global scope:
/home/wusc/R200/package/azure-iot/py2.7.12_x86/azure-iot-sdk-python/service/src/iothub_service_client_python.cpp:1590:72: sorry, unimplemented: non-static data member initializers

Failing code:
class IoTHubDeviceTwin
{
    IOTHUB_SERVICE_CLIENT_AUTH_HANDLE _iothubServiceClientAuthHandle = NULL;
    IOTHUB_SERVICE_CLIENT_DEVICE_TWIN_HANDLE _iothubDeviceTwinHandle = NULL;
public:
'''
}

Your compiler is complaining about the assignment of NULL to these variables. It wants you to initialize them in the constructor. This would not be a difficult change for you to make to get you unblocked. I can discuss with the product team a more permanent solution.
Mark Radbourne MSFT

Hi @wushichuan,
The product group have merged a fix to address this issue. All non-static class member variables are now initialized in the constructors. You should no longer see this issue.
Mark Radbourne MSFT


PRCA: report processor and tests

The report processor is responsible for reading the report json file generated by SonarQube. It reads the ProjectInfo.xml to work out the relative paths to the files associated with the issues. Note that most of the code already existed, I just reworked it a bit and added an E2E unit test.
I also introduced an orchestrator object that now handles all the work and moved some code there.

LGTM

Other than the comments I've raised it looks good


(POCO X3 PRO) FGA will not replenish bronze apples in JP

Preparation

[X] I tested the latest release
[X] I looked at other issues (even the closed ones)
[X] I read the Troubleshooting Guide

FGO server
JP
FGA build number
1951
Describe the bug
My FGA experience always worked flawlessly, until for some reason the app won't press the replenish button during retry. I restarted the app and did the same node again but this time I observed the entire process. I have observed that FGA will replenish using bronze apples on the FIRST retry, but fails to do so on the SECOND retry.
Now I haven't done this on any other apples if they also experience the same issue, but I'd rather save em for some lotto event or a raid at least (though just say the word and I'll do it and record it if its required). I posted a video link below for a more detailed view of the issue.
Video
https://mega.nz/file/2pYXyKIQ#yR1vOkEOQZ11NBrbVsEz6R0poUBNZnVUISHiTzW2dFA
Device model
POCO X3 PRO
Android version
12
Screen size
1080x2400
RAM
8GB

Update: Turned off Game Turbo UI and switched from Fullscreen Gesture mode to Button mode in Settings. FGA is currently replaying the node for 4 times and more at this time of commenting.


Massive difference in VRAM usage between 8-bit paged and unpaged optimizer (measurements included)

Some weird memory usage (VRAM) is reported (by torch and by NVML) when using 8-bit AdamW, paged or unpaged.
Here we train llama 2 on 4096-token sequences, using either --optim adamw_8bit or --optim paged_adamw_8bit.
We do a full finetune using qlora.py --full-finetune, with our qlora.py fork, stepwise branch, commit 9a1045d.
We print the memory usage using HF transformers trainer's on_step_end callback. This is after optimizer.step(); model.zero_grad().
One would expect the memory usage at the end of step 1 to be the same as the end of step 2.
Yet for unpaged optimizer: memory usage leaps by 13.2GiB. End of step 1=70.4GiB, end of step 2=81.6GiB.
This appears to be a 11.3GiB leap in PyTorch reserved memory only (32.6GiB -> 43.9GiB).
One would expect the memory usage of the paged optimizer to be equal to or lower than that of the unpaged optimizer.
Yet unpaged optimizer uses (NVML overall) 70.4GiB, 81.6GiB (steps 1, 2), whereas paged optimizer uses 91.2GiB.
Oh, actually… paged optimizer has lower torch overall memory, but higher NVML overall memory? Maybe that's some kind of NVML virtual memory? And maybe the torch memory is lower because paging has occurred? What's your understanding?
By the end of step 2: both optimizers moreorless agree on the amount of Torch reserved memory (unpaged=43.9GiB, paged=45.2GiB).
But throughout: the unpaged optimizer uses far more Torch allocated memory (37.7GiB) than the paged optimizer (25.2GiB).
Hm, paged optimizer's torch overall usage is identical to unpaged's step 1 torch overall usage, but distributed differently (paged allocates less and reserves more).
The step 1,2 thing is probably not related to gradient accumulation. We are using gradient accumulation, but gradients are accumulated during microsteps; on_step_end is called after the microsteps.
I have tried modifying my MemoryUsageCallback to use torch.cuda.synchronize(). This does not alter the result.
I ran the program like so (device_map='auto' over 2xA40 on Linux, CUDA 12.1, compute capability 8.6):
ACCELERATE_MIXED_PRECISION=bf16 python -m qlora \
--device_map_auto \
--disable_tqdm True \
--use_auth_token True \
--model_name_or_path meta-llama/Llama-2-7b-chat-hf \
--use_flash_llama \
--trust_remote_code \
--dataset prm800k-solutions \
--dataset_format prm800k-solutions \
--max_memory_MB 48000 --simulate_worst_case_seq_len \
--truncate_toward_center \
--source_max_len 2048 \
--target_max_len 2048 \
--gradient_accumulation_steps 2 \
--per_device_train_batch_size 1 \
--per_device_eval_batch_size 1 \
--optim adamw_8bit \
--learning_rate 0.0002 \
--save_steps 196 \
--save_total_limit 1 \
--max_steps 256 \
--evaluation_strategy steps \
--eval_steps 196 \
--measure_memory \
--terminate_after_step 8 \
--bits 32 \
--full_finetune

The memory readings I get (from Torch and from NVML) are as follows.
adamw_8bit: (notice the big leap in reserved memory from step 1 to 2):
step 1
  NVML memory stats (used+reserved, all processes):
    Device 0: Used 36314MiB / 49140MiB
    Device 1: Used 37746MiB / 49140MiB
    Overall: Used 74061MiB / 98280MiB
  Torch memory stats (allocated, reserved):
    Device 0: Used 35304MiB (Allocated: 19323MiB, Reserved 15980MiB)
    Device 1: Used 36736MiB (Allocated: 19323MiB, Reserved 17412MiB)
    Overall: Used 72040MiB (Allocated: 38647MiB, Reserved 33392MiB)
step 2
  NVML memory stats (used+reserved, all processes):
    Device 0: Used 42086MiB / 49140MiB
    Device 1: Used 43520MiB / 49140MiB
    Overall: Used 85607MiB / 98280MiB
  Torch memory stats (allocated, reserved):
    Device 0: Used 41076MiB (Allocated: 19323MiB, Reserved 21752MiB)
    Device 1: Used 42510MiB (Allocated: 19323MiB, Reserved 23186MiB)
    Overall: Used 83586MiB (Allocated: 38647MiB, Reserved 44938MiB)
step 3
  NVML memory stats (used+reserved, all processes):
    Device 0: Used 42086MiB / 49140MiB
    Device 1: Used 43520MiB / 49140MiB
    Overall: Used 85607MiB / 98280MiB
  Torch memory stats (allocated, reserved):
    Device 0: Used 41076MiB (Allocated: 19323MiB, Reserved 21752MiB)
    Device 1: Used 42510MiB (Allocated: 19323MiB, Reserved 23186MiB)
    Overall: Used 83586MiB (Allocated: 38647MiB, Reserved 44938MiB)

paged_adamw_8bit: (notice the lower torch allocated memory but far higher NVML overall memory):
step 1
  NVML memory stats (used+reserved, all processes):
    Device 0: Used 49138MiB / 49140MiB
    Device 1: Used 44274MiB / 49140MiB
    Overall: Used 93413MiB / 98280MiB
  Torch memory stats (allocated, reserved):
    Device 0: Used 35304MiB (Allocated: 12897MiB, Reserved 22406MiB)
    Device 1: Used 36736MiB (Allocated: 12897MiB, Reserved 23838MiB)
    Overall: Used 72040MiB (Allocated: 25795MiB, Reserved 46244MiB)
step 2
  NVML memory stats (used+reserved, all processes):
    Device 0: Used 49138MiB / 49140MiB
    Device 1: Used 44276MiB / 49140MiB
    Overall: Used 93415MiB / 98280MiB
  Torch memory stats (allocated, reserved):
    Device 0: Used 35306MiB (Allocated: 12897MiB, Reserved 22408MiB)
    Device 1: Used 36738MiB (Allocated: 12897MiB, Reserved 23840MiB)
    Overall: Used 72044MiB (Allocated: 25795MiB, Reserved 46248MiB)
step 3
  NVML memory stats (used+reserved, all processes):
    Device 0: Used 49138MiB / 49140MiB
    Device 1: Used 44276MiB / 49140MiB
    Overall: Used 93415MiB / 98280MiB
  Torch memory stats (allocated, reserved):
    Device 0: Used 35306MiB (Allocated: 12897MiB, Reserved 22408MiB)
    Device 1: Used 36738MiB (Allocated: 12897MiB, Reserved 23840MiB)
    Overall: Used 72044MiB (Allocated: 25795MiB, Reserved 46248MiB)

Versions:

bitsandbytes 0.41.1
transformers 4.32.1
accelerate 0.22.0
torch 2.1.0.dev20230802+cu121

first hypothesis:

paged optimizer's higher NVML usage might just be how NVML accounts for NVIDIA unified memory? maybe it appears that we're about to run out of VRAM but we actually wouldn't?
since paged and unpaged agree on overall torch memory usage until step 2…

the biggest problem here is the unpaged optimizer's giant leap in reserved memory on step 2
the difference in how torch allocated/reserved is distributed between the optimizers may just be… paging being invoked, to page some allocated memory out? I'm not sure why it would kick into action when we still have VRAM to spare though? maybe we had a spike before the step completed, so ended up paging something out, and it remains paged out?


getting iframe.contentWindow.location

How would you access this.contentWindow.location with this directive from a called function or inside ng-onload=""?

This is actually resolved through named parameters now to the callback.
If you take a look at the (usage)[https://github.com/mikaturunen/ng-onload#usage] you can see how it's used. Basically the callback in your controller now receives the iframe.contentWindow.location as parameter so you can use it as you wish. But the location only.
If you need to do more work with the actual html element instead of just tinkering the location, I would suggest some other solution :) Hope this helps. I'm considering this issue closed with this and if you have any other bonderings, do drop a line. Happy to help if I can. Thanks!


Gitlab User/Organization Support

Much like --github-user and --github-org I would like to support gitlab and even bitbucket.

HI, I can work on GitLab support

That would be great! Let me know if you wanna bounce any ideas off me

Hey @denwwer I recently added github PR support. Gitleaks was getting pretty github heavy so i split it out into github.go https://github.com/zricethezav/gitleaks/blob/master/github.go. We should have all the gitlab specific code in gitlab.go

Would love to see support for Bitbucket server


[Idea] Stack-Safe variant of ContT (not 100% sure)

One obvious problem with JavaScript is the lack of tail call elimination. Continuations are tail-recursive, it would be nice if we could have a stack-safe implementation for JavaScript.
One trick under our belt is the Trampoline monad.
a -> b happens to be isomorphic to a -> Trampoline b
so we can actually go newtype ContT r m a = ContT ((a -> Trampoline (m r)) -> Trampoline (m r))
here is an attempt: http://pastebin.com/VHet6yA4
and the test.
> runIdentity $ runContT (tailRecM (\(Tuple a n) -> if n<=100000 then return $ Left (Tuple (a+n) (n+1)) else return $ Right a) (Tuple 0 0)) pure
705082704

Which has avoided stack overflow in ContT.
However I am unsure if this methods. Because the MonadRec instance for ContT r m was not defined in terms of any MonadRec instance for m. So this implementation can not be quite right, but I think its close. Maybe a MonadSuspend class will work around that issue?

Sounds useful. We should try to construct a sequence of left and right-associated binds, like in the tests in free.

Thinking about free, Co is built on FreeT
Maybe something like the following will work.
data Suspend a =
  | Suspend (Unit -> a)
  | Done a

type Suspender = Co Suspend

newtype ContT r m a = ContT ((a -> Suspender m r) -> Suspender m r)

using a Coroutine to add the ability to suspend to any base monad.
I haven't had time to test this one. But it may have a more sane MonadRec instance.

After having a bit of a play with the code. A Suspender coroutine seems more tidy than a MonadSuspend class. With the MonadSuspend class you would need to design another variant of Eff to mix Eff with ContT, but with Suspender you can have a simple forever loop on the outside of runContT breaking free of the loop when Suspender is done (with of course means a different type-signature for this version of runContT).
The problem now is that purescript-transformers would end up with a cyclic dependency with purescript-free, I've put my hands into fire again. :p
So I guess it should be another library like purescript-stacksafe, purescript-stacksafe-contt or something like that.

Isn't type Suspender = FreeT Identity enough?

Using FreeT Identity. ContT Unit (Eff eff) a with a large number of binds would execute fine producing Eff eff a.  So the code way up top is effectively only safe for Cont r a, not ContT r m a. Thats why I'm hunting type Suspender = FreeT, to put the actual work of suspension into the base monad.

Either way, I think this would be best solved outside transformers, in another library. That way, circular dependencies are not an issue.

agreed

I'm going to reopen this because I've had great success. The stack-safe ContT no longer depends on FreeT. I've looped 1000000 times with a base monad of Eff (console :: CONSOLE) with no stack overflow. Plus it uses MonadRec to avoid stack overflow.
See: https://github.com/clinuxrulz/purescript-cont-stack-safe/blob/master/src/Control/Monad/Cont/Trans/StackSafe.purs
and the test case: https://github.com/clinuxrulz/purescript-cont-stack-safe/blob/master/test/Main.purs
I tried my best to use FreeT but evaluation kept leading to stack overflow.
Also ContT now has the exact same type signature as the proper ContT apart from the extra constraint.
You may want to consider this as a part of transformers

Interesting, thanks.
Does this work for both left and right associated binds?
Is there a simple (informal) proof of its safety?

I believe ContT re-associates binds from left associative to right associative. But I would need some benchmarks / profiling to confirm this.
This is an new invention, and there is no proof yet. I lack the skills to create a vigorous proof.
But I can say that it is exciting if this does work, for it is stack-less. Imagine stack-less Aff, stack-less green threads etc. And the fact that every monad in existence can be implemented in terms of callCC, means that every monad in existence can be implemented in a stack-less way (ContT is the mother of all monads, all monads can be implemented with ContT). That said I would not implement every monad that way, for it does have additional overhead and would hurt performance a little.

This is definitely exciting if it can be shown to work, but I think the best way forward for now would be to develop a proof of concept in a separate repo, along with a test suite to demonstrate the safety of various nested binds and measure performance.
When I said "proof", I just meant something informal, not necessarily rigorous. Like for FreeT, we can see that binds get thunked, and only evaluated one-by-one in the tail recursive runFreeT function.

ok, i'll keep it a separate repo... where I ran into trouble with FreeT was, when I had SuspendT implemented with FreeT, the use of SuspendT did not have a single bind in it, and the stack overflow was caused in the SuspendF's (the F-algrebra of suspend?) map function.. It avoided all bind thunks.
I'll see if I can understand how Free's benchmarks work and try to make the same sort of thing.

some results are in. My computer ran out of heap space on the larger tests (probably because of playing youtube for my daughter).
See: https://github.com/clinuxrulz/purescript-cont-stack-safe/blob/master/README.md

Just to mention, for running larger tests it might help to add the node option --max_old_space_size when running the tests. For my machine with 8GB of ram I used --max_old_space_size=8000 in the past to get iterations into the millions.

@ethul thanks for the suggestion. It did help me get passed 1 million, but then I crashed on 1.5 million. I'll have to wait until I can hop on a better computer.

Glad it helped a bit!

I'm going to close this issue now. So I'm not spamming this project. Further discussions can be made by making Issues on the stack-less project repositories.
The project is renamed and split into two parts.
The stack-safe ContT is now: https://github.com/clinuxrulz/purescript-stackless-cont
The stack-less monad transformer is now: https://github.com/clinuxrulz/purescript-stackless
The stackless monad transformer StacklessT is code-wise is Identical to stack-safe ContT. Just that it is built around a Codensity rather than a Continuation. Due to the code being identical, the performance is also identical (roughly 3 times the speed of Free for both left and right associative binds).
Codensity is just a smaller fish than a Continuation. And it just so happens that CodensityT m a is isomorphic to m a. This is what makes StacklessT a general stack-less monad transformer for any given base monad that is an instance of MonadRec.
A side node: A quick and easy stackless Aff can be made by StacklessT Aff, this allows heavy use of purescript-foldable-traversable without blowing the stack. It still decends 100 levels into the stack, then swaps stack-space for heap space as tailRecM does, but it allows you to use other methods like those in purescript-folable-traversable that do not use tailRecM and still avoid stack overflow.


Failed to load nodelet [/camera/driver] of type [astra_camera/AstraDriverNodelet]

I cloned the package directly from the github repository, as suggested in the closed topic for the same issue. When I launch using roslaunch astra_camera astra.launch, there's the following outcome:
[ERROR] [1583252306.847184447]: Failed to load nodelet [/camera/driver] of type [astra_camera/AstraDriverNodelet] even after refreshing the cache: Could not find library corresponding to plugin astra_camera/AstraDriverNodelet. Make sure the plugin description XML file has the correct name of the library and that the library actually exists. [ERROR] [1583252306.847381341]: The error before refreshing the cache was: Could not find library corresponding to plugin astra_camera/AstraDriverNodelet. Make sure the plugin description XML file has the correct name of the library and that the library actually exists. [FATAL] [1583252306.848218031]: Failed to load nodelet '/camera/driver of type astra_camera/AstraDriverNodelet to manager camera_nodelet_manager' [camera/driver-2] process has died [pid 15459, exit code 255, cmd /opt/ros/indigo/lib/nodelet/nodelet load astra_camera/AstraDriverNodelet camera_nodelet_manager ir:=ir rgb:=rgb depth:=depth depth_registered:=depth_registered rgb/image:=rgb/image_raw depth/image:=depth_registered/image_raw __name:=driver __log:=/home/soph/.ros/log/cc8353b4-5d5e-11ea-9275-00e06710abeb/camera-driver-2.log]. log file: /home/soph/.ros/log/cc8353b4-5d5e-11ea-9275-00e06710abeb/camera-driver-2*.log
I do not really know how to fix this, as I haven't found much infromation about this.
I am using ROS indigo in Ubuntu 14.04.
Also, catkin_make fails when making this package.

2 years late but this is caused by missing dependencies. You need to install astra_camera and follow the instructions to download https://wiki.ros.org/astra_camera


[SPARK-40771][CORE]: Fix overflow in broadcast estimatedTotalSize log message

What changes were proposed in this pull request?
This avoids a int overflow in calculating estimated total size for a broadcast. The wrong value is only used in a log message but the wrong size being logged can be confusing.

Why are the changes needed?
The current log message will be incorrect for broadcast exceeding 2GiB.

Does this PR introduce any user-facing change?
I fixes the log message for broadcast > 2GiB in size.

How was this patch tested?
Existing unit tests. Does spark have some way to test logging?

Can one of the admins verify this patch?

Can you try re-running the tests? it looks unrelated

Can you try re-running the tests? it looks unrelated

Looks like the rerun worked.

Merged to master


Can't add new access_token to HttpClient

Hi @sounj142 , The first to thank you for your project. It very helpful for me.
I've got an issue when I use signin silent to auto get new access_token, in my component use an service to make request to an api, but I see that httpClient can't add new access_token, it still use old access_token when component initialize in the first time.
This is my code in my service
await _stateProvider.SetAuthorizationHeader(_httpClient);
var lst = await _httpClient.GetJsonAsync<(string, decimal)[]>("/api/Manage/api1");

Hi huanbd,
Sorry for my late reply. I'm so lazy two recent weeks :D
I just fixed this issue, please try the newest nuget ( ver. 0.7.2 Preview 4)


Update com.gradle.plugin-publish and remove workaround

Remove workaround for https://github.com/gradle/gradle/issues/23928
https://plugins.gradle.org/plugin/com.gradle.plugin-publish has a new version 1.2.0
cc @vlsi

Plugin is released, contents are confirmed clean with new version without the workaround.


Async RFC

This RFC proposes adding several async features to StableHLO, mainly async_start, async_done, and the async<...> value type.
The end goal of this RFC is to allow JAX users to define their own collective matmul schedules, and allow more control to potentially better utilize their hardware.

Closing this as we move to extending jax.compute_on instead


Develop

Codecov Report

Merging #9 (7030f01) into main (890390d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   82.85%   82.85%
=======================================
  Files           3        3
  Lines         105      105
=======================================
  Hits           87       87
  Misses         16       16
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890390d...7030f01. Read the comment docs.


Issue 17661: isInputRange should accept .front that returns reference to range

Note: this PR targets master, rather than stable, because the regression is only in git HEAD, it hasn't gone out in a stable release yet.

Also, the referenced bug only shows up with -dip1000.  So the unittest is somewhat non-diagnostic right now, because Phobos isn't compiled with -dip1000 just yet.  But I put it in there anyway for the future.


No animations in page changes in gallery app

When I open the gallery app and tap on Material, there is no animation to get to the the next page (the list of different widgets). This doesn't look great. It isn't a priority but it's something to be added at one point since this is kinda the demo app for flutter.

We definitely have animations - Do you have animations disabled on your phone (via accessibility settings, battery saver, or animation duration)?

I don't think so. I see the animation when tapping on the hamburger and the drop down settings menu shows up. I don't see animations when tapping on one of the 5 main categories.

Actually when I open I turn on the slow motion I see a simple cross fade animation. I guess that's enough. Maybe it's just lagging for me because it's in debug mode.


Louisville master

I added (Under Development) to the title since CJ shared out the Heroku link and the Kids Count folks wanted to add some language letting people know it wasn't done

Pat, it looks like you selected the wrong branches. The PR is trying to merge louisville-master into gh-pages.
You need to open a PR that merges louisville-pat into louisville-master.


Report a bug

You can report bugs here !

Please use a screenshot !

Motion me if is important !

Exemple :
@MinecraftJulMan (if is important)
Description of the bug (and/or a image).
Thanks !


e2e: fix FPGA tests

Cherry-pick fix from the master branch
Fixes: #419

@bart0sh I have this in my v18 PR. Close?

sure


Update copyright year to 2021

https://github.com/nimblehq/git-template/issues/??
What happened 👀
Update copyright year to  2021.
Insight 📝
N/A
Proof Of Work 📹
N/A

How about following this suggestion @byhbt https://github.com/nimblehq/rails-templates/pull/266#discussion_r555477919

How about following this suggestion @byhbt nimblehq/rails-templates#266 (comment)

Good suggestion, I updated the content.
Thank you!


Instructions wrong and Cursor does not move at all

Hi I tried to remake the Project I tried a genereic ESP32 NodeMCU.
While doing this I stumbled upon following issues:

A button Press is needed in order to start (BUTTON_PIN) -> this has not been mentioned in the instructions
An LED seems to be optional (i guess?!) -> this has not been mentioned in the instructions
I flashed, connected via Bluetooth but no movement/click is done at all.

This is the log while using it:
Button pressed - activating! Update interval: 5000 ms
-----------------------
Moving mouse: x=-4, y=-4, dist=833, speed=4, cycle=0
Executing right click
Moving mouse: x=2, y=0, dist=487, speed=2, cycle=1
Moving mouse: x=-3, y=3, dist=134, speed=3, cycle=2

I followed the installation instruction:
Downloaded .zip, extracted it completely
Opened VSCode, opened extracted folder "esp32-ble-mouse-jiggler-main"
Build -> Upload
Success
Everything is successfull except one "warning" in my Install Log.
This is the Install log:
*  Executing task: C:\Users\xxxxxx\.platformio\penv\Scripts\platformio.exe run

Processing dfrobot_firebeetle2_esp32e (platform: espressif32; board: dfrobot_firebeetle2_esp32e; framework: arduino)
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------Verbose mode can be enabled via `-v, --verbose` option
CONFIGURATION: https://docs.platformio.org/page/boards/espressif32/dfrobot_firebeetle2_esp32e.html
PLATFORM: Espressif 32 (6.5.0) > DFRobot Firebeetle 2 ESP32-E
HARDWARE: ESP32 240MHz, 320KB RAM, 4MB Flash
DEBUG: Current (cmsis-dap) External (cmsis-dap, esp-bridge, esp-prog, iot-bus-jtag, jlink, minimodule, olimex-arm-usb-ocd, olimex-arm-usb-ocd-h, olimex-arm-usb-tiny-h, olimex-jtag-tiny, tumpa)
PACKAGES:
 - framework-arduinoespressif32 @ 3.20014.231204 (2.0.14)
 - tool-esptoolpy @ 1.40501.0 (4.5.1)
 - toolchain-xtensa-esp32 @ 8.4.0+2021r2-patch5
LDF: Library Dependency Finder -> https://bit.ly/configure-pio-ldf
LDF Modes: Finder ~ chain, Compatibility ~ soft
Found 37 compatible libraries
Scanning dependencies...
Dependency Graph
|-- ESP32 BLE Mouse @ 0.3.1
|-- JC_Button @ 2.1.3
|-- TimerEvent @ 0.5.0
|-- FastLED @ 3.6.0
Building in release mode
Compiling .pio\build\dfrobot_firebeetle2_esp32e\src\main.cpp.o
In file included from .pio/libdeps/dfrobot_firebeetle2_esp32e/FastLED/src/FastLED.h:75,
                 from src/main.cpp:5:
.pio/libdeps/dfrobot_firebeetle2_esp32e/FastLED/src/fastspi.h:157:23: note: #pragma message: No hardware SPI pins defined.  All SPI access will default to bitbanged output
 #      pragma message "No hardware SPI pins defined.  All SPI access will default to bitbanged output"
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Linking .pio\build\dfrobot_firebeetle2_esp32e\firmware.elf
Retrieving maximum program size .pio\build\dfrobot_firebeetle2_esp32e\firmware.elf
Checking size .pio\build\dfrobot_firebeetle2_esp32e\firmware.elf
Advanced Memory Usage is available via "PlatformIO Home > Project Inspect"
RAM:   [=         ]  11.8% (used 38740 bytes from 327680 bytes)
Flash: [========  ]  84.8% (used 1111469 bytes from 1310720 bytes)
Building .pio\build\dfrobot_firebeetle2_esp32e\firmware.bin
esptool.py v4.5.1
Creating esp32 image...
Merged 26 ELF sections
Successfully created esp32 image.
========================================================================================= [SUCCESS] Took 8.13 seconds =========================================================================================
 *  Terminal will be reused by tasks, press any key to close it.

Edit: this has been tried on 2 different PCs - one with onboard BT and one with USB BT, both no success.

Hi, thanks for your feedback.
You are right, the "documentation" might need some love ;-) I will try to improve the descriptions.
For the not working part:
The log seems to tell it should be working, at the moment I'm not sure what could be the problem.
Could you maybe tell me which exact model of a NodeMCU you are using? Maybe even with a link to the device?


Add missing includes

Without the gpio header you get these errors outside of the Arduino environment:
 error: 'GPIO_PIN_MUX_REG' undeclared (first use in this function)

Because std::vector is used I also needed to add the vector include to get this to compile with ESP-IDF.

Hi @jurriaan just for the interest, what is your build environment? although it build pretty fine with/without includes you proposed under platformio/linux toolchain I was thinking if some guards are required for sanity with other environments.

Hi @jurriaan just for the interest, what is your build environment? although it build pretty fine with/without includes you proposed under platformio/linux toolchain I was thinking if some guards are required for sanity with other environments.

I'm using the ESP-IDF v4.2 environment with arduino component (see https://github.com/espressif/arduino-esp32/blob/master/docs/esp-idf_component.md)

I'm using the ESP-IDF v4.2 environment with arduino component (see https://github.com/espressif/arduino-esp32/blob/master/docs/esp-idf_component.md)

I have the same issue as @jurriaan. also using eclipse and arduino as component

I have the same issue as @jurriaan. also using eclipse and arduino as component

also fixed build under platformio idf+arduino

also fixed build under platformio idf+arduino


~/.aws/config no longer managed by this tool

Describe the bug
~/.aws/config file is no longer managed by okta-aws-cli AND there was no announcement (or even place to announce) this breaking change.
Additional context
Removing the generation of ~/.aws/config should have, at minimum, been a minor release, not a patch release. Our tooling depended on ~/.aws/config being managed by okta-aws-cli. There is no CHANGELOG or release notes to read that stated this file is no longer managed by this tool.
In addition, since this file is no longer managed by okta-aws-cli, it would be helpful if the format of the credentials names written to ~/.aws/credentials was published so that tooling could be written to work with it. If I have to manage ~/.aws/config now, I want to be certain what I'm doing will work with okta-aws-cli.

I regret that it was a breaking change released as a patch release. That was not intended or anticipated. Sorry about that.
Here's the fix for your immediate issue:

remove source_profile and role_arn from each named profile section in ~/.aws/config (it's an text-based INI file)

Here's some context that may explain how this happened and why:
Removing the writing of ~/.aws/config was not anticipated to be a breaking change. I have since retested by creating a profile in v1.0.3 and using it in v1.0.4 and can see that it breaks. Fixing this automatically is a challenging line to cross as it could break future intentional use of source_profile and role_arn in ~/.aws/config outside this tool.
Modifying ~/.aws/config introduced a lot of undesirable behavior like the AWS CLI re-assuming the role, the inability to properly trace user activity in CloudTrail, and corrupting existing user configuration. Here is a sample of issues modifying this file triggered:

#205, #199, #198, #197, #194, #157

AWS CLI and other downstream tools load credentials from ~/.aws/credentials. The format is documented here, but you shouldn't need to interact with it directly:
https://docs.aws.amazon.com/cli/latest/userguide/cli-config-files.html
AWS CLI uses ~/.aws/config for additional configuration like S3 signature version, request configuration, and default regions. It is optional. The way this tool used to set source_profile and role_arn in there was a bug from misunderstanding how AWS CLI works.

Could you add a CHANGELOG.md or a release notes or something that collects the changes so that consumers can understand what's happening before upgrading? That's probably the biggest win that could come from this ticket.
Also, removing something you used to do should probably be, at the least, a minor version bump, not a patch release.

Would the just-added release notes on this page work?
https://github.com/oktadeveloper/okta-aws-cli-assume-role/releases/tag/v1.0.4
I agree. I'll try to keep that in mind. This is best effort as I'm not paid to work on this.

Yes, that would have helped dramatically.
I understand about the best-effort - I maintain several OSS projects in multiple languages.


REQUEST: New membership for yanfeng1992

GitHub Username
@yanfeng1992
Requirements

[X] I have reviewed the community membership guidelines
[X] I have enabled 2FA on my GitHub account
[X] I have subscribed to the Karmada mailing list
[X] I am actively contributing to 1 or more Karmada subprojects
[X] I have two sponsors that meet the sponsor requirements listed in the community membership guidelines
[X] I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application
[X] I have verified that my sponsors are from different member companies
[X] I have verified that my sponsors are a reviewer or an approver in at least one OWNERS file within one of the Karmada GitHub organizations

Sponsor 1
@XiShanYongYe-Chang
Sponsor 2
@lonelyCZ
List of contributions to the Karmada project
PRs authored:

https://github.com/karmada-io/karmada/pull/3221
https://github.com/karmada-io/karmada/pull/3010
https://github.com/karmada-io/karmada/pull/2911
https://github.com/karmada-io/karmada/pull/2949
https://github.com/karmada-io/karmada/pull/3019
https://github.com/karmada-io/karmada/pull/3018
https://github.com/karmada-io/karmada/pull/3016
https://github.com/karmada-io/karmada/pull/3044
Issues responsed:
https://github.com/karmada-io/karmada/issues/3113

/assign @XiShanYongYe-Chang @lonelyCZ

+1
Welcome! Thanks for your contributes.

+1
Welcome! Thanks @yanfeng1992  for all your contributions.
/assign @kevin-wangzefeng

cc @kevin-wangzefeng

Invitation sent, please visit https://github.com/karmada-io to confirm and join.

Thank you all, the invitation has been confirmed

Welcome @yanfeng1992.
/close


fix R/B channel switch in skin tone calculation

Blue and Red channels were switched, img_rgba is in rgb order but blue is being pulled from channel 0, red from channel 2. This PR swaps them to the correct channels.

Thanks @rbitr for catching this!
@teetone could you take a look?

Ping @teetone

Since @teetone hasn't responded, I'll merge this as it looks like a correct fix. Thanks @rbitr!


Mic 635 csip record prior to review

Codecov Report
Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.80%. Comparing base (2deac88) to head (5b00ede).

Files with missing lines
Patch %
Lines

server/routes/csip-records/controller.ts
90.90%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
+ Coverage   91.76%   91.80%   +0.03%
==========================================
  Files         270      270
  Lines        4055     4062       +7
  Branches      630      632       +2
==========================================
+ Hits         3721     3729       +8
+ Misses        333      332       -1
  Partials        1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Easy to start a 1.0.0-rc4 version of the first to give us debugging interface?

Easy to start a 1.0.0-rc4 version of the first to give us debugging interface?
Because the change is still a bit more

Can you explain more?

I would like to be able to install the project through npm install, and then adjust my nuxt.config.js and modify the ~/assets directory, while modifying the error layout page, next.css config and more

\ @alexchopin


Fix bug

fix a bug. When a TilemapDual is created for the first time, tileset is always null, so display_tilemap can never be set.
bool type can not == with int

Oh, this is my bad. I changed this because the editor warned me that bool types cannot be == with int types. That's another issue, so I'll change it back for now.


Labels do not show for many transit route segments

There is a bug where many route segment labels do not render (for geographic edges). There is a pre-existing TODO for this on the method Edge#coordAlongEdge:
https://github.com/conveyal/transitive.js/blob/50d9e7973a4fd82cc6b765d45e790240c07593a0/lib/graph/edge.js#L623-L632

:tada: This issue has been resolved in version 0.13.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


How to create a RemoteDocker object?

I am using IntelliJ and created a simple mvn Java app.  I have the following code.  However, it is giving me an error that RemoteDocker is not public and I can't use it.  Any thoughts on how to make this work?  I am just testing right now.
import com.amihaiemil.docker.Container;
import com.amihaiemil.docker.Containers;
import com.amihaiemil.docker.RemoteDocker;
import com.amihaiemil.docker.Docker;

public class dockertest {
    public static void main (String args[]) {

        final Docker docker = new RemoteDocker(
                "tcp://<IP_ADDRESS>:2375");
        final Containers containers = docker.containers();
        for(final Container container : containers) {
            //Containers is the entry point of the Containers API
            //and also implements Iterable<Container>
        }
    }
}

@amihaiemil/z please, pay attention to this issue

@rwmajor2/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@rwmajor2 Hello, thanks for the ticket.
RemoteDocker is not yet public because it hasn't been properly tested yet (I still have to figure out how to do this on Travis). It should work just as fine as LocalDocker since they use the same classes, it's just a matter of (secure) connection.
As you can see the ctor has changed a bit, in the wiki there was just an initial idea.
The idea with RemoteDocker now is that you have to provision a remote Docker host and when you do so, you should get 3 .pem files: ca.pem, cert.pem and key.pem.
You need to add these 3 files to 2 Java KeyStores (.jks): the first 2 in a truststore.jks and the key to a keystore.jks. After you have these stores, you need to provide their Path to RemoteDocker constructor, as well as password of the keystore and the passphrase of the key (which is within that keystore).
Sounds a bit complex, but the reasoning is that those certs are already most likely inside Java keystores if they are supposed to be used by a Java application. Besides, reading the .pem files ourselves would have meant using a 3rd party lib for reading .pem, thus making this library heavier.
Nevertheless, don't struggle with that, it might not even work. First, try to use LocalDocker on localhost and see if you can do what you need with the current version. It is still young, not implementing everything (only Images and Containers are partially implemented).

@rwmajor2 I forgot to mention: in order to try to use RemoteDocker you have to fork the repo and make the build yourself. Just mvn clean install should do the trick with no problems.

@rwmajor2 FYI, I just released version 0.0.3. RemoteDocker is now public and can be instantiated if you pass it your own HttpClient.
I figured, in the early stages, we should let the users configure their own clients and not assume Docker's place in the network and things such as authentication mechanisms.

Job gh:amihaiemil/docker-java-api#147 is not assigned, can't get performer

The job is not in WBS, won't close the order


Replace strcharpart() with substitute() for backward compatibility

Pull request #833 has supplied a fix to workaround the backward compatibility problem in #830.  But the multi-byte path problem will appear again in the older version of vim before the function strcharpart was introduced.  We can use substitute to achieve the same result as when strcharpart is used.

I have commit this change to the branch used in #830, but the branch didn't sync to the master branch, so I did't mention the removal of if exists("*strcharpart").  Now I have resolved the conflicts and used the regex you advised.


Save videos downloading (bulk downloading) state in CourseOutlineFragment

Description
LEARNER-6700
Single/Bulk videos downloading states were not saving in the Course Outline fragment.
We are saving and loading it appropriately now using Bridge library to fix all the problematic cases.
Please refer to story for the changes implemented in this PR.

The same issue exists on the Bulk Download feature, let's pair program and fix that tomorrow.


Possible to modify fore wireguard support?

Hi would it be feasible to add wireguard support as i believe it is much less heavy on the cpu. I am using this on the OpenWRT Router, and the speed is largely limited by cpu power.

Hi, I just pushed a new version that implements support for wireguard to the dev branch. Please check it out and test it if you will. Check the updated README on the dev branch for how to use it.

Hi. I've just found your vpn-profile-switcher script and have been testing it on my OpenWRT / NordVPN setup.
I've tested on both OpenVPN connections and Wireguard connections and both are working well, so thank you for creating the script.
I have found a couple of bugs however. Firstly the -c (Country) switch does not appear to be working. In my case I am based in the UK and the script always returns a recommended UK server even if I specify a different country e.g US (United States). I have tried using the github countries.csv file and also a local countries.csv file and both show the same behaviour.
The second bug relates to Wireguard peers. As I understand it the script should keep just the current peer and the last peer used. I have found the previous selected peers are not deleted. They are however set to "Disabled.
Unfortunately my knowledge of scripting is not good enough for me to be able to locate the bugs, but I'm happy to help you test the script for debugging purposes and to test any code fixes that you can provide.
Thank you.


Styles using reinvoke

Codecov Report

Merging #68 into master will increase coverage by 0.27%.
The diff coverage is 98.65%.

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   98.82%   99.10%   +0.27%
==========================================
  Files          62       64       +2
  Lines        8276     8341      +65
==========================================
+ Hits         8179     8266      +87
+ Misses         97       75      -22

Impacted Files
Coverage Δ

iommi/style_django_admin.py
100.00% <ø> (ø)

iommi/table__tests.py
100.00% <ø> (ø)

iommi/traversable__tests.py
100.00% <ø> (+12.50%)
:arrow_up:

iommi/style__tests.py
97.82% <91.42%> (-2.18%)
:arrow_down:

iommi/action.py
100.00% <100.00%> (ø)

iommi/admin.py
98.47% <100.00%> (ø)

iommi/error.py
100.00% <100.00%> (ø)

iommi/form.py
99.05% <100.00%> (-0.14%)
:arrow_down:

iommi/form__tests.py
100.00% <100.00%> (ø)

iommi/fragment.py
100.00% <100.00%> (ø)

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f90ac86...909b557. Read the comment docs.


L10n: Add Swedish translation

^_^

I think everything has been corrected! Thanks for the feedback!


if no Origin header passed, don't set CORS headers

Non-browser clients may or may not set an Origin header when making a
request, but browsers always should.  Don't set ANY CORS headers if
Origin isn't set.  Non-browser clients don't pay attention to CORS, and
a browser that doesn't set Origin should reject the response.

Tests and Mixin both greatly improved. Also does what it says it will do. LGTM.


Items should not disappear when player has a full inventory

User Story
As a player, I'd like to keep all items I encounter, so that I may have full control over what I do with said items.
Acceptance Criteria

Items are not lost when found in a chest but the player has a full inventory

Notes

Why is this feature needed? Please describe the problem your requested feature wants to solve
I'm always frustrated when I find an item in a chest but my inventory is full and that item is lost forever.
Describe the solution you'd like
I'd like to be able to come collect an item later if I can't fit it in my inventory at the time I find it.

Currently the way this is implemented is that the chest is only populated when the player opens it (which makes the most sense). What this means is that the items are not actually stored inside any chest object, and are merely temporary unless put into the players inventory (where they are then stored indefinitely).
So, this probably requires a little larger change than originally thought because it would require making the chests effectively have their own inventory. Though I'm wondering if implementing them similar to how shops are done may work better, so I'll be looking into them next.

Closing this, as it should've been closed with #55, but I forgot to put a closing tag...


Sort By Group

Hello first of all , thanks for the amazing package.
Can we group by looking at the column information?
For example, there are 4 Columns
A Column | B Column | C Column | D Column

Pending | Test 2 | Column Text C | D Text
Pending | Test 2 | Column Tex 1 | D Text
Complated
if i say group by ColumnA it should create 2 tables which is the grouped by ColumnA
A Column (Pending)
Pending | Test 2 | Column Text C | D Text
Pending | Test 2 | Column Tex 1 | D Text
A Column
Complated

Default Table Apple, 1 Apple, 2 Banana, 1 Banana, 2
TableA Apple, 1 Apple, 2
TableB Banana, 1 Banana, 2
Is it a condition that Default Table should be created as TableA, TableB? This is not provided functionally.

I am not sure have you used before airtable ? If you select group any column it will show you grouped rows.
Please look attached images ( grouped by priority)
https://ibb.co/zRp1Kqm

Are you referring to the presentation of a UI like the image below?
There is currently a groupby column feature, but it is not an image-like UI.

Yes, that's exactly it, can you share me the code for guidance?

Demo link
https://weblaze.dev/pluto_grid/build/web/#feature/row-group
Documentation link
https://pluto.weblaze.dev/row-grouping

Can we do that programmatically ? Or it should be initially grouped ?

Documentation has been added to the link below.
See section Groupby columns dynamically.
https://pluto.weblaze.dev/row-grouping#heading-groupby-columns-dynamically


Fix/deployment gas issue

This fixes #161

add WeightV2 type construct to deploy command
make maxGas flag optional
some small changes to the test template. (doesn't change how it works, just locks the mocharc file to the one in the root directory, and prevents it from looking into parent dir)

Will be promoted from draft after #165 is merged and this rebased to master

I'm still getting OutOfGas error.

I'm still getting OutOfGas error.

Hm, I just tested both with and without -g flag:

Are you sure you rebuilt the project when you checked out this PR?
(I rebased now, so the yarn dev command also works)

I'm still getting OutOfGas error.

Hm, I just tested both with and without -g flag:
Are you sure you rebuilt the project when you checked out this PR? (I rebased now, so the yarn dev command also works)

Sorry it was my mistake. deploy works as expected.


Fix gmp error

Fix gmp BigInteger error (TypeError: Argument 1 passed to Jose/Component/Core/Util/Ecc/Point::create() must be an instance of Brick/Math/BigInteger, instance of GMP given)

This won’t work.
Please see #289

This won’t work.
Please see #289

Hi,
install this lib -> https://github.com/brick/math

@MaxDomo,
This won’t resolve the issue, this library will still continue to use gmp and this will break all applications that are still using web-token/* v2.0 or v2.1


Caliper work with hurley

Hello,
I am using hurley:
https://github.com/worldsibu/hurley
And convector:
https://github.com/hyperledger-labs/convector
After solving the problem of version in #812
To build a test network with a smart contract, my fabric config is here:
fabric.yaml.zip
I have an error with the default channel of hurley: ch1
2020.05.09-13:04:58.187 info  [caliper] [adapters/fabric] 	Channel 'ch1' is configured as created, skipping creation
error: [client-utils.js]: sendPeersProposal - Promise is rejected: Error: 2 UNKNOWN: access denied: channel [] creator org [org1MSP]
at new createStatusError (/hyperledger/caliper/node_modules/grpc/src/client.js:64:15)
at /hyperledger/caliper/node_modules/grpc/src/client.js:583:15
error: [Client.js]: Failed Channels Query. Error: Error: 2 UNKNOWN: access denied: channel [] creator org [org1MSP]
at new createStatusError (/hyperledger/caliper/node_modules/grpc/src/client.js:64:15)
at /hyperledger/caliper/node_modules/grpc/src/client.js:583:15
2020.05.09-13:04:58.215 error [caliper] [adapters/fabric] 	The following errors occurred while querying ch1 information from org1MSP's peers:
- Couldn't query ch1 information from peer0.org1.hurley.lab: 2 UNKNOWN: access denied: channel [] creator org [org1MSP]
2020.05.09-13:04:58.215 error [caliper] [caliper-flow] 	Error: Error: Couldn't query ch1 information from org1MSP's peers
at Fabric._joinChannels (/hyperledger/caliper/node_modules/@hyperledger/caliper-fabric/lib/fabric.js:1495:27)
at

Never used the convector/Hurley framework, it may require a new adaptor. If it "just" creates a standard Fabric network, then it would appear that the wrong certificates are being used and so access is rightfully being denied. As mentioned, Hurley itself is an unknown framework to us, so we cannot advise which certificates that it creates you should be providing - best suggestion would be to inspect the fabric container logs to help guide you on the errors, and iterate over what is available to you as provided by Hurley

I believe Hurley and Convector are end of life. Hurley is used to stand up a fabric network (like so many other tools, eg minifabric) it should be possible to configure a network config to work with that fabric network.

Closing as no further action necessary


[ Timeline ] Possibility for segfault when attempting to write a timeline event at shutdown

Access to Timeline::recorder_ isn't guarded by any locks, which makes it possible for one thread to try and allocate a new event from the recorder after it's been deleted. We should add a lock or some atomic counters to make sure we don't delete the recorder while timeline events are being written.
See logs for an example.
Related to https://github.com/flutter/flutter/issues/98421.

marking as P1 based on the priority assigned to the Flutter issue.


Placeholder Text Issues

In Firefox, there is a bug with placeholder text. When you click to focus the textarea, then click again the cursor will jump to the far right and you can't enter text.
In Internet Explorer, when focusing the textarea it will put the cursor at the end of the placeholder text rather that the beginning. This is less annoying that the Firefox issue because you can still input the text.
I attached a modification of your examples/index.html file to recreate the issues.
placeholder.zip
Firefox 47.0.1
Internet Explorer 11
Windows 8.1

I've tested it. It's not linked to the placeholder but I can reproduce the bug, so I try to fix it. :(

Fix : https://github.com/Alex-D/Trumbowyg/pull/357

This is a Firefox bug
https://bugzilla.mozilla.org/show_bug.cgi?id=904846
JSFiddle :
1 : http://jsfiddle.net/xdht9o0s/
2 : http://jsfiddle.net/m5zDU/
You can edit the trumbowyg CSS to fix this, but the placeholder disappear on focus... its a choice :)
.trumbowyg-editor[contenteditable=true]:empty::before
to :
.trumbowyg-editor[contenteditable=true]:empty:not(:focus):before
Exemple : http://jsfiddle.net/mfjntwu6/


I am unable to reach your PSNR.

Hi,
I follow your provided code and keep your setting. However, I am unable to reach your PSNR. Could you please provide me with the training code and pre-train model that can reach this number? Thank you very much !

Thanks for your interest. Our released pre-trained model can reach the reported results in the paper. As we mentioned in the experiment part, following previous works, our evaluation includes two settings, i.e., evaluated in 256*256 and the original resolution. If you want to reach the results of 256 *256, you should resize the results first and then calculate the PSNR and SSIM.


MultipleHandTracking Android app not responding

I seem to be having an issue with the multiple hand tracking application, it doesnt seem to work, it just gets stuck
can you see what the issue is?
The phone i am using has 4GB Ram and is P20Lite

Can you share some logs please? Any idea about how many frames it processes before getting stuck? How about the state of the app when it is getting stuck - are there any number of hands detected in the frame? Is this issue reproducible repeatedly?

it processed one frame
and it just got stuck without any detection
can it be because of slow processing power of the device?
The single hand tracking app worked with lag on the same phone

Multi-hand tracking uses the same underlying graphs as single-hand tracking. If single hand tracking is slow, multi-hands will be slow too.
Were you able to get any logs or figure out what is causing the delay?

Found out the issue, it’s very fast and gives real-time results on stock android’s. Not very much on other android’s who have their own OS layer on top of that.
Thanks for your assist!


Update link for "tags extension"

Issue in ./help/edge/home.md
The first link on this page is about the "tags extension". The link takes you to a page in the tags documentation, which basically just has a link back to the web sdk documentation. Perhaps the link on this page should just go directly to: https://experienceleague.adobe.com/docs/experience-platform/edge/extension/web-sdk-extension-configuration.html?lang=en

Thanks for logging this issue. We will review the documentation and update accordingly.
Tracking internally: https://jira.corp.adobe.com/browse/PLAT-111397

Documentation has been updated: https://experienceleague.adobe.com/docs/experience-platform/edge/home.html


After opening Pa.py, nothing was happen. Where is my trouble?

@Skyere I already told you check #6
And don't create new issues, it's just you are facing some errors while running this PA.py file there is no need to create such issues
Only comment below these issues..

I have fixed #6, but PA.py still stopped after start without any errors

Okay, I fixed it. But now I have another issue: The assistent hasn't hear me. Could you help me?

@Skyere which IDE you are using??

have you installed all the libraries required??

Yes, I installed all libraries. I'm using vs code

Is there any error while running the program or any highlighted text??

Without any errors or warning

Only "Listening..."

can you send me a screenshot??

I tried launc on console too. But recieved the same

@Skyere try this !!
write these lines after engine = pyttsx3.init()
voices = engine.getProperty('voices')
engine.setProperty('voice', voices[1])

still the same error

is that voice assistant speaking??

Yes, I hear this text

then try to speak something in a slient environment, maybe it will recognize...
use headphones (with microphone) if possible...

sometimes due to noisy environment it stuck at listening and doesn't go to recognize the voice...

I'm tried use this to check my microphone

And this one recognize my voice

Hello @Skyere
I am not getting what error you are facing !!
what should can I do??

It's working for me, I have tried to run the same code...
Just there was the only error for underscores before and after both name and main in this line
if __name__ == '__main__':


Add DebugUtilsMessenger to vkcubepp

Note that this PR depends on the #615 PR so it can't be merged before that one is merged.

CI Vulkan-Tools build queued with queue ID 9277.

CI Vulkan-Tools build # 642 running.

CI Vulkan-Tools build queued with queue ID 9294.

CI Vulkan-Tools build # 643 running.

CI Vulkan-Tools build queued with queue ID 9310.

CI Vulkan-Tools build # 644 running.

CI Vulkan-Tools build # 644 failed.

CI Vulkan-Tools build queued with queue ID 9354.

CI Vulkan-Tools build # 645 running.

CI Vulkan-Tools build # 645 passed.

CI Vulkan-Tools build queued with queue ID 4932.

CI Vulkan-Tools build # 675 running.

CI Vulkan-Tools build # 675 passed.