Some dependencies using the sys_platform marker can not be resolved since version "2023.8.19"

Issue description
(Some) dependencies that use the sys_platform marker, could not be resolved during an install.
This issue exists in all versions after version "2023.7.23" and appears on systems other than the system that is mentioned in the marker (note, the output is from 2023.9.8, but as said, the issue exists since [v2023.8.19](https://github.com/pypa/pipenv/releases/tag/v2023.8.19) onwards)
Expected result
Expected would be that the install would resolve itself, without issues. That is, to not stop/fail on dependencies with a system marker other than the current system.
Actual result
pipenv install now results in:
ERROR: No matching distribution found for python-magic-bin==0.4.14

Steps to replicate
Provide the steps to replicate (which usually at least includes the commands and the Pipfile).
1) Minimal Pipfile to reproduce:
[[source]]
url = "https://pypi.org/simple"
verify_ssl = true
name = "pypi"

[packages]
python-magic-bin    = {version = "==0.4.14", sys_platform = "== 'win32'"}

[requires]
python_version = "3.11.0"

2) run pipenv install
pipenv install  --verbose

 3) output of pipenv install  --verbose
Output:
Pipfile.lock (8da0f5) out of date, updating to (499099)...
Locking [packages] dependencies...
Building requirements...
Resolving dependencies...
INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.starting()
INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.adding_requirement(SpecifierRequirement('python-magic-bin==0.4.14'),
None)
CRITICAL:pipenv.patched.pip._internal.resolution.resolvelib.factory:Could not find a version that satisfies the requirement
python-magic-bin==0.4.14 (from versions: none)
Traceback (most recent call last):
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/patched/pip/_vendor/resolvelib/resolvers.py", line 397,
in resolve
    self._add_to_criteria(self.state.criteria, r, parent=None)
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/patched/pip/_vendor/resolvelib/resolvers.py", line 174,
in _add_to_criteria
    raise RequirementsConflicted(criterion)
pipenv.patched.pip._vendor.resolvelib.resolvers.RequirementsConflicted: Requirements conflict: SpecifierRequirement('python-magic-bin==0.4.14')
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/patched/pip/_internal/resolution/resolvelib/resolver.py",
line 92, in resolve
    result = self._result = resolver.resolve(
                            ^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/patched/pip/_vendor/resolvelib/resolvers.py", line 546,
in resolve
    state = resolution.resolve(requirements, max_rounds=max_rounds)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/patched/pip/_vendor/resolvelib/resolvers.py", line 399,
in resolve
    raise ResolutionImpossible(e.criterion.information)
pipenv.patched.pip._vendor.resolvelib.resolvers.ResolutionImpossible:
[RequirementInformation(requirement=SpecifierRequirement('python-magic-bin==0.4.14'), parent=None)]
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/utils/resolver.py", line 445, in resolve
    results = resolver.resolve(constraints, check_supported_wheels=False)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/patched/pip/_internal/resolution/resolvelib/resolver.py",
line 101, in resolve
    raise error from e
pipenv.patched.pip._internal.exceptions.DistributionNotFound: No matching distribution found for python-magic-bin==0.4.14
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/resolver.py", line 675, in <module>
    main()
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/resolver.py", line 661, in main
    _main(
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/resolver.py", line 645, in _main
    resolve_packages(
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/resolver.py", line 612, in resolve_packages
    results, resolver = resolve(
                        ^^^^^^^^
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/resolver.py", line 592, in resolve
    return resolve_deps(
           ^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/utils/resolver.py", line 897, in resolve_deps
    results, hashes, internal_resolver = actually_resolve_deps(
                                         ^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/utils/resolver.py", line 670, in actually_resolve_deps
    resolver.resolve()
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/utils/resolver.py", line 447, in resolve
    raise ResolutionFailure(message=str(e))
pipenv.exceptions.ResolutionFailure: [31m[1mERROR[0m: [33mNo matching distribution found for python-magic-bin==0.4.14[0m
✘ Locking Failed!
⠧ Locking...
Traceback (most recent call last):
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/bin/pipenv", line 8, in <module>
    sys.exit(cli())
             ^^^^^
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/vendor/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/cli/options.py", line 58, in main
    return super().main(*args, **kwargs, windows_expand_args=False)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/vendor/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/vendor/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/vendor/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/vendor/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/vendor/click/decorators.py", line 84, in new_func
    return ctx.invoke(f, obj, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/vendor/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/cli/command.py", line 209, in install
    do_install(
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/routines/install.py", line 164, in do_install
    do_init(
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/routines/install.py", line 648, in do_init
    do_lock(
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/routines/lock.py", line 65, in do_lock
    venv_resolve_deps(
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/utils/resolver.py", line 838, in venv_resolve_deps
    c = resolve(cmd, st, project=project)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/pipenv/2023.9.8/libexec/lib/python3.11/site-packages/pipenv/utils/resolver.py", line 707, in resolve
    raise RuntimeError("Failed to lock Pipfile.lock!")
RuntimeError: Failed to lock Pipfile.lock!

Note: looking at the other issues, I found some overlap in this issue: https://github.com/pypa/pipenv/issues/5884 . I also (successfully) tried the 'strange' solution that was given there. That is: specifying the marker, as actual marker instead of as sys_platform attribute. This however probably isn't the desired solution, so I'm happy to hear any other options!

Well its a bit of a pickle, the short of it is:  dropping requirementslib had some side effects and broke how sys_platform was working; I then made a different patch of it which is truly a behavior change to fold those sys_platform and os_name markers.
The way its working in the latest versions is if you want to skip resolving that dependency on a specific platform, it would need to be added as markers as the sys_platform will try to resolve it and sub dependencies, but will then fold those sys_platform and os_name specs into the sub-dependencies.   This works well for published wheels and things that don't need to build and sdist, but it is problematic for things that do need to build an sdist but cannot on a deferent system where they were simply skipped entirely before.

Thanks for the clarification. We'll move sys_platform to markers then, as also shown in the example Pipfile


Refactor the compose ps command flagging process

What is the problem you're trying to solve
According to #1680, I want to refactor the compose ps command flagging process. Since #1702 is marked invalid, I open this issue for tracking purposes.
Describe the solution you'd like

Create a file in pkg/api/types/${cmd}_types.go, and define the CommandOption for this command
Create some file in pkg/api/cmd/${cmd}, and move the command entry point in real into this package
Create new docs in docs/reference/api/${cmd}_types.md, and describe the field in CommandOption

Additional context
No response

Please go ahead.

Let me close one and track all commands in #1680


Tautulli Popular error when Plex has music

I noticed an error when creating the Plex Popular collection using tautulli, I  think it is due to having music in my library.
I only have movie in my config.yml so I'm not sure why tautulli picks up music as well.
Config.yml
libraries:
  Movies:
    library_type: movie

Movies.yml
templates:
  Chart Alpha:
    sort_title: ++++_<<num>><<collection_name>>
    sync_mode: sync
    collection_order: alpha

  Plex Popular:
    template: {name: Chart Alpha, num: 1}
    tautulli_popular:
      list_days: 30
      list_size: 20
      list_buffer: 20
    tautulli_watched:
      list_days: 30
      list_size: 20
      list_buffer: 20
    summary: Movies Popular on Plex

Error logs:
[2021-02-24 00:30:12,534] [util.py:637]               [INFO]     |====================================================================================================|
[2021-02-24 00:30:12,534] [util.py:639]               [INFO]     |                                      Plex Popular Collection                                       |
[2021-02-24 00:30:12,534] [util.py:640]               [INFO]     |====================================================================================================|
[2021-02-24 00:30:12,534] [config.py:370]             [INFO]     |                                                                                |
[2021-02-24 00:30:12,534] [builder.py:167]            [INFO]     | Scanning Plex Popular Collection                                                                   |
[2021-02-24 00:30:12,534] [builder.py:199]            [DEBUG]    |                                                                                |
[2021-02-24 00:30:12,534] [builder.py:200]            [DEBUG]    | Method: template                                                                                |
[2021-02-24 00:30:12,534] [builder.py:201]            [DEBUG]    | Value: ordereddict([('name', 'Chart Alpha'), ('num', 1)])                                          |
[2021-02-24 00:30:12,535] [builder.py:199]            [DEBUG]    |                                                                                |
[2021-02-24 00:30:12,535] [builder.py:200]            [DEBUG]    | Method: tautulli_popular                                                                           |
[2021-02-24 00:30:12,535] [builder.py:201]            [DEBUG]    | Value: ordereddict([('list_days', 30), ('list_size', 20), ('list_buffer', 20)])                    |
[2021-02-24 00:30:12,535] [builder.py:199]            [DEBUG]    |                                                                                |
[2021-02-24 00:30:12,535] [builder.py:200]            [DEBUG]    | Method: tautulli_watched                                                                           |
[2021-02-24 00:30:12,535] [builder.py:201]            [DEBUG]    | Value: ordereddict([('list_days', 30), ('list_size', 20), ('list_buffer', 20)])                    |
[2021-02-24 00:30:12,535] [builder.py:199]            [DEBUG]    |                                                                                |
[2021-02-24 00:30:12,535] [builder.py:200]            [DEBUG]    | Method: summary                                                                                |
[2021-02-24 00:30:12,536] [builder.py:201]            [DEBUG]    | Value: Movies Popular on Plex                                                                      |
[2021-02-24 00:30:12,536] [builder.py:199]            [DEBUG]    |                                                                                |
[2021-02-24 00:30:12,536] [builder.py:200]            [DEBUG]    | Method: sort_title                                                                                |
[2021-02-24 00:30:12,536] [builder.py:201]            [DEBUG]    | Value: ++++_1Plex Popular                                                                          |
[2021-02-24 00:30:12,536] [builder.py:199]            [DEBUG]    |                                                                                |
[2021-02-24 00:30:12,536] [builder.py:200]            [DEBUG]    | Method: sync_mode                                                                                |
[2021-02-24 00:30:12,536] [builder.py:201]            [DEBUG]    | Value: sync                                                                                |
[2021-02-24 00:30:12,536] [builder.py:199]            [DEBUG]    |                                                                                |
[2021-02-24 00:30:12,537] [builder.py:200]            [DEBUG]    | Method: collection_order                                                                           |
[2021-02-24 00:30:12,537] [builder.py:201]            [DEBUG]    | Value: alpha                                                                                |
[2021-02-24 00:30:12,542] [config.py:390]             [INFO]     |                                                                                |
[2021-02-24 00:30:12,543] [config.py:392]             [INFO]     | Sync Mode: sync                                                                                |
[2021-02-24 00:30:12,685] [builder.py:529]            [DEBUG]    |                                                                                |
[2021-02-24 00:30:12,685] [builder.py:530]            [DEBUG]    | Method: tautulli_popular                                                                           |
[2021-02-24 00:30:12,685] [builder.py:531]            [DEBUG]    | Values: [{'list_type': 'popular', 'list_days': 30, 'list_size': 20, 'list_buffer': 20}]            |
[2021-02-24 00:30:12,686] [builder.py:551]            [INFO]     |                                                                                |
[2021-02-24 00:30:12,686] [builder.py:552]            [DEBUG]    | Value: {'list_type': 'popular', 'list_days': 30, 'list_size': 20, 'list_buffer': 20}               |
[2021-02-24 00:30:12,686] [tautulli.py:28]            [INFO]     | Processing Tautulli Most Popular: 20 Movies                                                        |
[2021-02-24 00:30:12,686] [tautulli.py:61]            [DEBUG]    | Tautulli URL: http://<IP_ADDRESS>:8181/api/v2?apikey=################################&cmd=get_home_stats&time_range=30&stats_count=40 |
[2021-02-24 00:30:12,984] [tautulli.py:61]            [DEBUG]    | Tautulli URL: http://<IP_ADDRESS>:8181/api/v2?apikey=################################&cmd=get_library_names |
[2021-02-24 00:30:13,131] [util.py:649]               [INFO]     | Plex Popular Collection | = | The White Tiger                                                      |
[2021-02-24 00:30:13,155] [util.py:649]               [INFO]     | Plex Popular Collection | = | Wrong Turn                                                           |
[2021-02-24 00:30:13,199] [util.py:649]               [INFO]     | Plex Popular Collection | = | Space Sweepers                                                       |
[2021-02-24 00:30:13,225] [util.py:649]               [INFO]     | Plex Popular Collection | = | SOMM                                                                 |
[2021-02-24 00:30:13,250] [util.py:649]               [INFO]     | Plex Popular Collection | = | Saint Maud                                                           |
[2021-02-24 00:30:13,274] [util.py:649]               [INFO]     | Plex Popular Collection | + | SOMM: Into the Bottle                                                |
[2021-02-24 00:30:13,398] [util.py:649]               [INFO]     | Plex Popular Collection | = | Betting on Zero                                                      |
[2021-02-24 00:30:13,403] [util.py:649]               [INFO]     | Plex Popular Collection | + | 機會 (기희)                                                              |
[2021-02-24 00:30:13,404] [util.py:594]               [DEBUG]    | Traceback (most recent call last):                                                                 |
                                                                 |   File "/modules/config.py", line 404, in update_libraries
                                                                 |     builder.run_methods(collection_obj, collection_name, map, movie_map, show_map)
                                                                 |   File "/modules/builder.py", line 614, in run_methods
                                                                 |     if len(items) > 0:                                  map = self.library.add_to_collection(collection_obj if collection_obj else collection_name, items, self.filters, self.details["show_filtered"], map, movie_map, show_map)
                                                                 |   File "/modules/plex.py", line 193, in add_to_collection
                                                                 |     else:                                       current.addCollection(name)
                                                                 |   File "/usr/local/lib/python3.9/site-packages/plexapi/base.py", line 477, in addCollection
                                                                 |     self._edit_tags('collection', collections)
                                                                 |   File "/usr/local/lib/python3.9/site-packages/plexapi/base.py", line 465, in _edit_tags
                                                                 |     value = getattr(self, tag + 's')
                                                                 |   File "/usr/local/lib/python3.9/site-packages/plexapi/base.py", line 384, in __getattribute__
                                                                 |     value = super(PlexPartialObject, self).__getattribute__(attr)
                                                                 | AttributeError: 'Track' object has no attribute 'collections'
                                                                 |
[2021-02-24 00:30:13,406] [config.py:416]             [ERROR]    | Unknown Error: 'Track' object has no attribute 'collections'

this is really odd I've been looking at this one and can't seem to figure out exactly what's going wrong I feel like the issue might be with the plex API wrapper but ill have top do some more digging but I'm looking into it

ok i think I've got a fix in if your still receiving this problem. Can you test with the develop branch and let me know?

Thanks! I've tested in develop and it works! I am seeing one error however I'm not sure if it's related or not.
Plex Error: Item 75213 not found  I'm not sure if this item is the one from the music library.
today at 5:50 PM  |====================================================================================================|
today at 5:50 PM  |                                      Plex Popular Collection                                       |
today at 5:50 PM  |====================================================================================================|
today at 5:50 PM  |                                                                                |
today at 5:50 PM  | Scanning Plex Popular Collection                                                                   |
today at 5:50 PM  |                                                                                |
today at 5:50 PM  | Sync Mode: sync                                                                                |
today at 5:50 PM  |                                                                                |
today at 5:50 PM  | Processing Tautulli Most Popular: 20 Movies                                                        |
today at 5:50 PM  | Plex Popular Collection | = | Raya and the Last Dragon                                             |
today at 5:50 PM  | Plex Popular Collection | = | Minari                                                               |
today at 5:50 PM  | Plex Popular Collection | = | Wrong Turn                                                           |
today at 5:50 PM  | Plex Popular Collection | = | Space Sweepers                                                       |
today at 5:50 PM  | Plex Popular Collection | = | SOMM                                                                 |
today at 5:50 PM  | Plex Popular Collection | = | 21 Bridges                                                           |
today at 5:50 PM  | Plex Popular Collection | = | Somm: Into the Bottle                                                |
today at 5:50 PM  | Plex Popular Collection | = | Betting on Zero                                                      |
today at 5:50 PM  | Plex Error: Item 75213 not found                                                                   |
today at 5:50 PM  | Plex Popular Collection | + | Skylines                                                             |
today at 5:50 PM  | Plex Popular Collection | + | The Mauritanian                                                      |
today at 5:50 PM  | Plex Popular Collection | + | Cherry                                                               |
today at 5:50 PM  | Plex Popular Collection | + | Boss Level                                                           |
today at 5:50 PM  | Plex Popular Collection | + | Bambi                                                                |
today at 5:50 PM  | Plex Popular Collection | + | How to Train Your Dragon 2                                           |
today at 5:50 PM  | Plex Popular Collection | + | The Curse of La Llorona                                              |
today at 5:50 PM  | Plex Popular Collection | + | The Trial of the Chicago 7                                           |
today at 5:50 PM  | Plex Popular Collection | + | The Nun                                                              |
today at 5:50 PM  | Plex Popular Collection | + | Judas and the Black Messiah                                          |
today at 5:50 PM  | Plex Popular Collection | + | I Care a Lot                                                         |
today at 5:50 PM  | 20 Movies Processed                                                                                |
today at 5:50 PM  |                                                                                |
today at 5:50 PM  | Processing Tautulli Most Watched: 20 Movies                                                        |
today at 5:50 PM  | Plex Popular Collection | = | Raya and the Last Dragon                                             |
today at 5:50 PM  | Plex Popular Collection | = | Wrong Turn                                                           |
today at 5:50 PM  | Plex Popular Collection | = | Minari                                                               |
today at 5:50 PM  | Plex Popular Collection | = | Space Sweepers                                                       |
today at 5:50 PM  | Plex Popular Collection | = | SOMM                                                                 |
today at 5:50 PM  | Plex Popular Collection | = | 21 Bridges                                                           |
today at 5:50 PM  | Plex Popular Collection | = | Somm: Into the Bottle                                                |
today at 5:50 PM  | Plex Popular Collection | = | Betting on Zero                                                      |
today at 5:50 PM  | Plex Error: Item 75213 not found                                                                   |
today at 5:50 PM  | Plex Popular Collection | = | Skylines                                                             |
today at 5:50 PM  | Plex Popular Collection | = | The Mauritanian                                                      |
today at 5:50 PM  | Plex Popular Collection | = | Cherry                                                               |
today at 5:50 PM  | Plex Popular Collection | = | Boss Level                                                           |
today at 5:50 PM  | Plex Popular Collection | = | Bambi                                                                |
today at 5:50 PM  | Plex Popular Collection | = | How to Train Your Dragon 2                                           |
today at 5:50 PM  | Plex Popular Collection | = | The Curse of La Llorona                                              |
today at 5:50 PM  | Plex Popular Collection | = | The Trial of the Chicago 7                                           |
today at 5:50 PM  | Plex Popular Collection | = | The Nun                                                              |
today at 5:50 PM  | Plex Popular Collection | = | Judas and the Black Messiah                                          |
today at 5:50 PM  | Plex Popular Collection | = | I Care a Lot                                                         |
today at 5:50 PM  | 20 Movies Processed                                                                                |
today at 5:50 PM  |                                                                                |
today at 5:50 PM  | Plex Popular Collection | - | Saint Maud                                                           |
today at 5:50 PM  | Plex Popular Collection | - | The White Tiger                                                      |
today at 5:50 PM  | 2 Movie Removed                                                                                |
today at 5:50 PM  |                                                                                |
today at 5:50 PM  | Detail: summary updated Collection Summary                                                         |
today at 5:50 PM  | Detail: sort_title updated Collection Sort Title to ++++_1Plex Popular                             |
today at 5:50 PM  | Detail: collection_order updated Collection Order to alpha                                         |
today at 5:50 PM  | Details: have been updated                                                                         |
today at 5:50 PM  | Detail: asset_directory updated collection poster to [File] /config/assets/Plex Popular/poster.png |
today at 5:50 PM  |                                                                                |
today at 5:50 PM  | No background to update                                                                            |

All i did was handle the error better so the script doesn't stop working plex doesn't like that rating key for some reason. You can check more about what that key is by going to the URL below replacing http://<IP_ADDRESS>:32400 with the URL to your server and <REPLACE-WITH-YOUR-TOKEN> with your token.
view-source:http://<IP_ADDRESS>:32400/library/metadata/75213?X-Plex-Token=<REPLACE-WITH-YOUR-TOKEN>

Thanks, I can confirm that error is because it's coming from the music library. At least it doesn't fail like before. I would say this is good enough as a solution
<MediaContainer size="1" allowSync="1" identifier="com.plexapp.plugins.library" librarySectionID="9" librarySectionTitle="Music"


{path}.html is no longer the HTML report output path

https://github.com/iterative/dvc/pull/6431/files#r698317884

From https://github.com/iterative/dvc/pull/6431/files#r700894470 :

I kind of like dvclive/tsv & dvclive/html.
Honestly, the word plots for referring to the HTML sounds kind of confusing to me because the .tsv files are also dvc plots in a sense.
Moving the outputs to subdirectories would require some changes in DVC core but it feels like a good direction. I might consider also moving the summary .json to dvclive/summary.json.

Added a branch with those changes (tsv, html, summary.json) in dvc core:
https://github.com/iterative/dvc/compare/dvclive-output-subdirs
No strong preference on the alternatives but I don't really like _dvc_logs, looks weird even in docs: https://github.com/iterative/dvc.org/pull/2783/files


Event Grid abbrevations

There missing abbreviations for:

Event Grid Domain
Event Grid Topic

I know this is not an important issue, but it would be nice for them to be there.
For now, I will go with:

evgd for Event Grid Domain
evgt for Event Grid Topic

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8c22eb33-2fde-55b4-021d-e229c857e51b
Version Independent ID: 1f767675-7d50-6ea5-b798-1323cd4a63a1
Content: Recommended abbreviations for Azure resource types - Cloud Adoption Framework
Content Source: docs/ready/azure-best-practices/resource-abbreviations.md
Service: cloud-adoption-framework
Sub-service: ready
GitHub Login: @BrianBlanchard
Microsoft Alias: brblanch

Thanks for reporting - this issue is under review. This is a Microsoft Internal DevOps Bug ID # 358797

Thanks for reporting - this issue is under review. This is a Microsoft Internal DevOps Bug ID # 358797


Ugly html code syntax

The issue
Ugly html code syntax and colors are different from the homepage
To Reproduce

Open Docusaurus Playground

Copy paste this snippet from https://github.com/facebook/docusaurus/blob/master/website/docusaurus.config.js
prism: {
  theme: require("prism-react-renderer/themes/github"),
  darkTheme: require("prism-react-renderer/themes/dracula")
},

Add some html code in docs

Expected behavior
To have the same colors as here - https://docusaurus.io/docs/markdown-features/tabs
Reproducible Demo
https://codesandbox.io/s/loving-heyrovsky-f76no?file=/docs/intro.md - open docs -> intro for sample html - it is ugly!!!

This is not just an HTML snippet issue, but a general problem for the prism github theme. The same thing happens for languages like bash—the attr-name highlight color doesn't look right.

Thanks for the report, this caused by new version of prism-react-renderer (see https://github.com/FormidableLabs/prism-react-renderer/pull/100 for more details), so we locked its version to 1.1.1.


CM-563 Add register endpoint

Input validation for full_name, email, and password
Detailed errors for each negative circumstance
Working security endpoints for registration and login
Modified local and cloud DB
Rewrote Users table slightly

Thanks for reviewing!
The errors are just what Nick had requested. Nick do you not want something
more nuanced?
I'll fix the typos. Full name is probably being replace with separate first
name/last name so I didn't make a check for it as of now.
On Thu, May 6, 2021, 14:34 y-himanen @.***> wrote:

@.**** approved this pull request.
I pulled and tested and everything works great! A few things that I think
could be addressed:

I would like to see a different error message for when the
registration failure is related to the email or the password. I don't like
either or messages that leave you guessing which one went wrong. Also,
@NickCallaghan https://github.com/NickCallaghan - I hope that
frontend will provide the user with some explanation of the password
requirements? I hate when a website makes me guess why my password is
failing!!
there's no check that a full name is actually included - is this
important? checking for 2-50 characters will allow a name like "dou" to be
registered. We also might want to consider some including some whitespace
stripping.
there's a couple of typos/missing words in the error messages, e.g.
auth/routes.py line 40

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ClimateMind/climatemind-backend/pull/208#pullrequestreview-652972228,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABCZ6OUOKVKUBVGMWPUS6VTTMIS6TANCNFSM44BUEIEQ
.

Also there are a couple of places we don't want to do nuanced errors for
security reasons. We don't want to confirm whether or not it's a bad email
or password for login for example to provide minimal feedback for bad
actors.
On Thu, May 6, 2021, 14:36 Sean Payne @.***> wrote:

Thanks for reviewing!
The errors are just what Nick had requested. Nick do you not want
something more nuanced?
I'll fix the typos. Full name is probably being replace with separate
first name/last name so I didn't make a check for it as of now.
On Thu, May 6, 2021, 14:34 y-himanen @.***> wrote:

@.**** approved this pull request.
I pulled and tested and everything works great! A few things that I think
could be addressed:

I would like to see a different error message for when the
registration failure is related to the email or the password. I don't like
either or messages that leave you guessing which one went wrong. Also,
@NickCallaghan https://github.com/NickCallaghan - I hope that
frontend will provide the user with some explanation of the password
requirements? I hate when a website makes me guess why my password is
failing!!
there's no check that a full name is actually included - is this
important? checking for 2-50 characters will allow a name like "dou" to be
registered. We also might want to consider some including some whitespace
stripping.
there's a couple of typos/missing words in the error messages, e.g.
auth/routes.py line 40

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ClimateMind/climatemind-backend/pull/208#pullrequestreview-652972228,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABCZ6OUOKVKUBVGMWPUS6VTTMIS6TANCNFSM44BUEIEQ
.


Getting a 404 for links to ngraph-tensorflow in http://ngraph.nervanasys.com/docs/latest/framework-integration-guides.html

The doc points to this tensorflow repo: https://github.com/NervanaSystems/ngraph-tensorflow which is not accessible.

Thanks @Ajay191191!
Currently, the doc in http://ngraph.nervanasys.com/docs/latest/framework-integration-guides.html#tensorflow represents our efforts integrating with TF1.3. The repository with TF1.3 integration has been moved to https://github.com/NervanaSystems/ngraph-tensorflow-1.3. We'll update this doc accordingly.
We're also actively working on a "dynamic-plugin" approach for newer versions of TF.  Please stay tuned.

Yes - we are fixing this typo in the documentation.


TagFirstLast is not optimal in memory

TagFirstLast use CountDown and therefor use a Queue of all the elements.
Store the full sequence could and should be avoided.

use a Queue of all the elements

How's that? It uses a queue that's a count of 1 in the absolute worst case:
https://github.com/morelinq/MoreLINQ/blob/5205ea241d72b079436060d330cd5c2eae7cdcdf/MoreLinq/TagFirstLast.cs#L64
In turn CountDown is optimised for collections and lists:
https://github.com/morelinq/MoreLINQ/blob/5205ea241d72b079436060d330cd5c2eae7cdcdf/MoreLinq/CountDown.cs#L60-L64
A queue (of 1 in case of TagFirstLast) is only used for a pure sequence.
TagFirstLast used to be implemented in terms of a composition of many other operations but then got simplified into Index + CountDown.

Sorry about that, I misunderstood CountDown, that why I commented about SkipLast and TagFirstLast. Anyway my comments on SkipLast about many object creation and manipulation work here too and I will do perf test before continue along this way.

What would help here is to optimise CountDown for 1 so it doesn't even have to allocate a queue in that case and would eventually help TagFirstLast as a result. I did something like that for MinBy/MaxBy where I used different storage strategies based on count. Optimisation of CountDown is a separate issue so I am going to close this one.


Accessing node data from Vue?

Hello, I added a node with following line
editor.addNode('name', 1, 1, pos_x, pos_y, '', { test: 1 }, 'v-component', 'vue');
How can I access test: 1 in Vue v-component?

Hello  @nodegin
Pass as prop or get Info of node.
View: https://github.com/jerosoler/Drawflow/issues/37 and https://github.com/jerosoler/Drawflow/issues/40
Maybe it will also work for you: https://github.com/jerosoler/Drawflow/issues/39
Jero
Jero

@jerosoler  Shouldn't the props passed in addNode ? it looks odd passed in registerNode so we cannot really passing node instance's data to vue

OK I found that we can use this.$el.parentElement.parentElement.id


enhance Control whether writing into file cache for query and load

Proposed changes
Issue Number: close #xxx
The former implementation would never try to read from cache even though the data might already lie inside local storage. This pr makes it only read the data which does not exist on local cache.

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

LGTM

run buildall


Improve/update listing in https://ethereum.org/en/wallets/find-wallet/#results

I have sent an enquiry, will update you once I have news on it.


change boot version to 2.5.1

Motivation:
change boot version to 2.5.1
fix rpc version 5.4.7
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.

We should document those dependency changes in the ReleaseNote @leizhiyuan @QilongZhang

We should document those dependency changes in the ReleaseNote @leizhiyuan @QilongZhang

ok, just note it in v5.4.7 release note.


CircleCI build failed because of the omitEventHandlers.ts

Duplicates

[ ] I have searched the existing issues

Latest version

[ ] I have tested the latest version

Current behavior 😯

I got this error in CircleCI when building, I never upgraded MUI packages/dependencies these days.
Expected behavior 🤔

The codes can be built without error

Steps to reproduce 🕹

yarn build or yarn start

Context 🔦
https://github.com/mui/material-ui/blob/81608baf0a992543126252ef2e0b858501095140/packages/mui-base/src/utils/omitEventHandlers.ts#L9
Your environment 🌎

CI:

NodeJS: 14.18.2

Dependencies:

"@material-ui/core": "4.11.4",
"@material-ui/icons": "^4.11.2",
"@material-ui/lab": "^4.0.0-alpha.60",
"@material-ui/pickers": "^3.3.10",
"@material-ui/types": "5.1.0"
ps: I have another dependency that uses<EMAIL_ADDRESS>

same issue on local:

remove yarn.lock and node_modules
run yarn
run yarn start
throw error

I locked my version under v5.4.x, but its dependencies will install the latest version of v5, I think it would cause some unexpected issues.

nvm, it works since I upgraded my typescript to v4, sorry my fault.

Is there another solution for this problem? This error also happens on local builds outside of CircleCI when typescript version 3.9.10 is used. Based on the documentation, this typescript version should work (Minimum 3.5).

correct, it happens locally as well. And definitely the documentation recommends v3.5+ but Key Remapping in Mapped Types only works after v4.1.

Thank you for the response! A adoption of the documentation to the minimum version 4.1 would be nice then.

Thanks for pointing it out. I admit I haven't checked this on Typescript 3. I'm going to revert this change so we run on >3.5 and think about increasing the required version in the next major.

Thanks for pointing it out. I admit I haven't checked this on Typescript 3. I'm going to revert this change so we run on >3.5 and think about increasing the required version in the next major.

Sweet. Thank you!

I am also facing this issue.Although my typescript version is 4.7.4.


add support for ACM

Feature request
Support for ACM (AWS Certificate Manager)
Feature description
I would like to add support for the following quotas

[x] ACM certificates

Testing Assistance
Indicate whether or not you will be able to assist in testing pre-release
code for the feature.

solved with https://github.com/sebasrp/awslimitchecker/commit/d54747e633abe02c9e15ad5d4f6ba03e46a27a2d


Undulator Spectrum doesn't show Spectral Power

flux = 1.3e15 # example of flux in photons/s/0.1%bw

import scipy.constants as codata

spectral_power = flux * codata.e * 1e3  # spectral power in W/eV


fix: fixes undefined error coming from datasource rest api form values

This PR fixes undefined data coming from getting datasource rest api form values from redux form, which is causing silent errors when dispatching update replay entity actions.
Fixes #9808.

Bug fix (non-breaking change which fixes an issue)

Manual tests employed.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

/ok-to-test sha=84e62f2


房价预测

房价预测与知识点问答

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


add confirmation to model:prune command

Hi,
Lets add confirmation to model:prune command since it is a destructive command.
Users need to add --force flag to command in production.
thanks

This would be a breaking change and would have to go into 9.x?

@JamesFreeman this is targeting master already.

@ankurk91 please fix the tests here first. Thanks

@JamesFreeman this is targeting master already.

Doh! My bad.

looks like that too much work,  i can live without this feature so closing


Informational fixes

I also saw finding #14 wasn't fixed (gas saving by changing the logic of _isValidInitialization). I think it's ok to leave it unchanged because we wouldn't want users initializing with a start = 0 or period = 0 anyways, so it's nice to have that check in there

I also saw finding 14 wasn't fixed (gas saving by changing the logic of _isValidInitialization). I think it's ok to leave it unchanged because we wouldn't want users initializing with a start = 0 or period = 0 anyways, so it's nice to have that check in there

Hey @darian-chan-cb finding 14 does not say that the logic inside _isValidInitialization be changed, what I meant was this => At the particular spot in code only one check is sufficient ( _isValidInitialization actually checks two things), so you can replace if(! _isValidInitialization) with if(! savedRecurringAllowance.start > 0)


feat: adds organization API

Description
closes #100
Type of change:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Required Checklist:

[x] I have signed the MongoDB CLA
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added any necessary documentation (if appropriate)
[x] I have run make fmt and formatted my code

@robcarlan-mlab RFAL

@themantissa ready for you


Product name doesn't display on catalog page, when framework is installed through GUI Installer

Framework Version: 0.1.5

Framework Version: 0.1.5
Fixed


Updated Parameter "-DeferRegistrationWhenPackagesAreInUse"

Included documentation on the -DeferRegistrationWhenPackagesAreInUse parameter.

Docs Build status updates of commit 7620f93:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/appx/Add-AppxPackage.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Upgraded stylus and stylus-loader versions

This solves the issue https://github.com/AngularClass/NG6-starter/issues/151

Thanks!


Question: how to figure out why tx_cap converges to 0 and does not recover.

Hi.
I have an application where an mobile robot moves between different wireless access point and  using your quic implementation for transport.
during my testing I have experience that both the tx_cap and cwnd in some cases converge to 0. I would expect adjustsments now and then depending on the conditions e.g. handover, interference etc. However what I observe is that sometime it slowly decreases to 0 without recovering and thereby giving and Error 11
I have tried both stream and dgram based transmission and it is the case for both types.
There is ofcourse also the possibility of error in my implementation however I do not observe the same behavior when the robot is static, i.e. not moving.
I have looked at both qlogs and debug output cause but I do not really know what I should be looking for, or if it is even possible to extract from those.
Therefore I was hoping that somebody could point me in the direction on where to look next.
Regards.

Thanks for the report. Sounds like its something to do with the handover period between access points. Are you using quiche for cllient and server? Are these your own applications that are driving the event timers and socket? It would be useful to see some debug or qlogs to see what is happening.

When I use multiple streams on a quic channel to send data for a long time, sometimes cap=0 occurs and will not be recovered

I successfully reproduced this problem. The reason is that the client stream channel is closed, but the server stream channel is not manually closed and the server stream channel keeps writing data. After the write buffer is full, iswritable return false

When I use multiple streams on a quic channel to send data for a long time, sometimes cap=0 occurs and will not be recovered(version is [0.14.0])

I successfully reproduced this problem. The reason is that the client stream channel is closed, but the server stream channel is not manually closed and the server stream channel keeps writing data. After the write buffer is full, iswritable return false


Improvement: rename helpView etc to fiftyFifty

There a few occurences of helpElement, getHelpElement and helpView.
At this point it would make more sense to call them fifityFiftyElement , getFiftyFiftyElement etc.

Target acquired!

Its done


4 feature allow user to get the rate limiter information

Side track:
Force the BasicStorage to convert all keys to type string to align with the constraint of SQLite3_Storage.


Permissions changes

This is mostly permissions changes.

Prevent user from attempting to remove their own permissions on narratives they own. (fixes #29)
Prevent user from trying to link a narrative they don't own to an organization.
Prevent user from trying to change the name of a narrative they don't have admin access to.
Prevent user from trying to change permissions for other people on narratives they don't have admin access to.
Prevent user from trying to delete a narrative they don't have have rights to delete.

Note that the popups still appear, but they just don't let users interact with them.


Implemented streaming and stream preprocessing

https://github.com/alexrudall/anthropic/issues/7
All Submissions:

[X] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[X] Have you added an explanation of what your changes do and why you'd like us to include them?

@alexrudall ready to merge? 👀

Thanks so much @swombat !! A little different to the ruby-openai implementation, that may not be a bad thing, let's see how users find it :)

Released in v0.3.0


Fix incompatibility between augmentations and skorch.NeuralNet.set_params

Really sorry to open yet another PR @robintibor 😅
We've realized with @lapaill that braindecode would crash if we instatiate a class inheriting from skorch.NeuralNet with an argument based on Transform objects and then try to set any other unrelated parameter with the method set_params. Indeed, the latter will inspect each attribute of the NeuralNet object (even if it was previously defined) and call their get_params method when the latter is implemented. The problem is the Transform implements such a method (for an unrelated reason) and outputs a tuple instead of a dict, which would make skorch raise an error.
Hence, this PR solves this incompatibility by replacing the tuples by dictionaries for every Transform. It is also cleaner this way I think.

E               ValueError: This channel name (EOG horizontal) doesn't exist in info.

Strange do you know what happened there @cedricrommel ? Or is it unrelated to this PR, something changed somewhere else?

I might have a clue 🙃 : https://twitter.com/mne_news/status/1456240588421046279?s=20

I'll set the mne version to previous one for now, and we can open a new PR to ensure compatibility with new mne when we want to. What do you think?

oki good to know then we need to ensure compatibility for sure, as you said in separate PR

Ok, now the doc is clean @agramfort :)

doc looks good to me, would be great if you can add the comment I mentioned above @cedricrommel than we could merge from my side

amazing stuff, great, good to merge this before release, thanks @cedricrommel

🙌

🙌


Mapping an optional field

Within a mapper, I'm trying to add some additional data derived from my contentful content. However, the field is not required and I get an error:  "'empty_field_error': The field 'restrictions' is empty and unavailable in the response'."
In the mapper I tried something like: unless.entry.restrictions.nil? or if.entry.restrictions.present? but I still get the error above.
How can you deal with optional fields in the mapper?

Hey @neetso,
I am looking into it. I will get back to you if I need more details.
Cheers


When the framework isn't called in an app does it still take up memory usage?

Hi, I wanted to know if I add this framework does it take up memory when it isn't in use?

Hey,
No. It will only increase memory usage when it is actually in use. It will increase your binary size very slightly though as you obviously have extra code in your app.
Let me know if you have any more questions.


🎨  Use svg icons in default templates

refs #8107
Replace icon fonts in server side rendered default templates with svgs.

In Ghost-Admin we use ember-inline-svg, can't we use something similar here?
e.g. https://www.npmjs.com/package/handlebars-helper-svg

Yes, we could. But is it worth it to add an additional dependency for two svgs?

Hmm depends a little how big the dependency is. But in general, your question is correct.
Is the svg code for both the same here? This has definitely no priority.

Two different svgs only (yet the same as in Ghost Admin) and I would also need to add them to the server/public folder and serve them like we do with the other images here: https://github.com/TryGhost/Ghost/blob/master/core/server/blog/app.js#L58-L60

Are the svg's here the same as in Ghost-Admin?
If yes, i would definitely re-use them via a shared access?

If yes, i would definitely re-use them via a shared access?

Bear in mind there's no longer any "shared access" between Ghost and Ghost-Admin, the files would need to be duplicated to exist in each project.
In my mind the current implementation seems best at this time. The inlined SVGs are not used anywhere else in Ghost and anyone copying the default templates will immediately have access to the images without needing to use another helper to pull in files dynamically.

anyone copying the default templates will immediately have access to the images without needing to use another helper to pull in files dynamically.

Good argument!

Bear in mind there's no longer any "shared access" between Ghost and Ghost-Admin, the files would need to be duplicated and exist in each project.

Why is that again? Sorry, I have forgotten the reason why we have to duplicate the asset files.

Why is that again? Sorry, I have forgotten the reason why we have to duplicate the asset files.

Asset files that live in Ghost-Admin will have their file names changed during building as part of the cache-busting, the SVGs may also end up not being part of the build as they are not referenced anywhere but only in-lined.
If files live in Ghost, Ghost-Admin doesn't have access to them for use in the build process so it can't inline them and it would need to fetch files dynamically across the network at runtime.


Double Jumping immediately after jumping causes the character to flip (???) a bit after the animation starts

I'm not sure if that's the right way to put it, but it's very simple to reproduce; keep repeatedly double jumping before your character reaches the freefalling state (while their state is still jumping).
Here's a video showing the issue; the first double jump is the expected result, and the second double jump is what happens if you double jump while you're in the Jumping state.
https://github.com/user-attachments/assets/f024bdad-cd28-4efd-9066-761b0afefd5f

the double-jump aux state can be activated on the condition that Humanoid.FloorMaterial == Enum.Material.Air
if preferred, you could add special conditions in the init.lua file, such as distance from the floor or time elapsed since the humanoid entered the .Jumping or .Freefall state


Sql_alchemy_helper Engine fix

Describe your changes :

Added connect_args and options for the creation of engine

Type of change :

[x] Bug fix
[x] Improvement

Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have performed a self-review of my own.
[x] I have tagged my reviewers below.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

@harshach @pmbrull

Added a fix for isinstance error under database_common.py
Fix for connect_args missing in database_common.py
Fix for connect_args and options missing in sql_alchemy_helper.py


Sanitizers are broken

https://github.com/private-attribution/ipa/actions/runs/6768037077/job/18391702753
Looks like new nightly compiler needs help asserting that things are Send

works on rustc 1.75.0-nightly (1c05d50c8 2023-10-21)
does not work on rustc 1.75.0-nightly (fee5518cd 2023-11-05)

Looks like it is related to https://github.com/rust-lang/rust/issues/117602 and will be fixed in https://github.com/rust-lang/rust/pull/117542
GIven that, I am going to temporarily disable sanitizer actions and enable them again after this issue is fixed on the rustc side


[release-0.20] Set auto offset reset to earliest

Part of https://github.com/knative-sandbox/eventing-kafka-broker/issues/556

Proposed Changes

Consume topic from the earliest offset

Release Note

:bug: Consume topic from the earliest offset

Maven
/test pull-knative-sandbox-eventing-kafka-broker-unit-tests

/test pull-knative-sandbox-eventing-kafka-broker-unit-tests

/test pull-knative-sandbox-eventing-kafka-broker-integration-tests

/test pull-knative-sandbox-eventing-kafka-broker-unit-tests

/lgtm
/approve


easy to give up mistakenly

currently it's just Z. a player can easily hit the button unintentionally.

maybe make it a bit more complex, like Z+up?


Make generative shortcuts on KodaDot more user-freindly

Originally discussed in https://github.com/kodadot/nft-gallery/issues/9296
Initial problem
Generative artists are almost always implementing shortcuts to interact with the art (download art/part of the art, restart animation... etc.) to their code.
Example:
SailWings:

save art by "s" and
save frame by "v"

Currently, it still doesn't work to press the shortcut on the gallery detail page or when we open art on fullscreen. Its possible only if you click the link on "Animated Media" in details, it will open the art in the new tab. Then, you can press the shortcut. This is not user-friendly at all.
Here:

Solution:
Have the option to open "Animated Media" directly in the gallery item preview.
Either add button for it (open) or implement it to fullscreen preview?
Suggest other ideas.
Fxhash example:
They have this button OPEN which when you open it you can use shortcuts. Check it here.

From fxhash:
https://www.fxhash.xyz/generative/24777


Add deprecated as a dependency at package.json

deprecated should not be a devDependency, but a dependency.

@peleteiro Thanks. Nice catch. Please update to v0.10.1.

Thank you very much! gulp-webpack-build is great!


fix nil pointer panic for monitor

Signed-off-by: Ye Sijun<EMAIL_ADDRESS>build main and run containerd failed.
INFO[2022-04-20T05:35:40.153277386Z] loading plugin "io.containerd.grpc.v1.sandbox-controllers"...  type=io.containerd.grpc.v1
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x98 pc=0x55d06830b312]

goroutine 45 [running]:
github.com/containerd/containerd/runtime/restart/monitor.(*monitor).monitor(0xc00011a050, {0x55d0693c0a40, 0xc00003a0c0})
        /home/jun/Documents/workspace/containerd/runtime/restart/monitor/monitor.go:226 +0x272
github.com/containerd/containerd/runtime/restart/monitor.(*monitor).reconcile.func1()
        /home/jun/Documents/workspace/containerd/runtime/restart/monitor/monitor.go:187 +0xab
created by github.com/containerd/containerd/runtime/restart/monitor.(*monitor).reconcile
        /home/jun/Documents/workspace/containerd/runtime/restart/monitor/monitor.go:184 +0x191

Seems still broken
        Apr 20 08:50:22 4e20dff0b6af containerd[42938]: time="2022-04-20T08:50:22.180313832Z" level=info msg="Start streaming server"
        Apr 20 08:50:22 4e20dff0b6af containerd[42938]: time="2022-04-20T08:50:22.180140133Z" level=error msg=monitor error="no running task found: task db0d630812d37a9985ff327be5f41f7d78075147bc3e085a3ddf44d79b388021 not found: not found"
        Apr 20 08:50:22 4e20dff0b6af systemd[1]: Started containerd container runtime.
        Apr 20 08:50:32 4e20dff0b6af containerd[42938]: time="2022-04-20T08:50:32.181733644Z" level=error msg=monitor error="no running task found: task db0d630812d37a9985ff327be5f41f7d78075147bc3e085a3ddf44d79b388021 not found: not found"
        Apr 20 08:50:42 4e20dff0b6af containerd[42938]: time="2022-04-20T08:50:42.182933645Z" level=error msg=monitor error="no running task found: task db0d630812d37a9985ff327be5f41f7d78075147bc3e085a3ddf44d79b388021 not found: not found"
        Apr 20 08:50:52 4e20dff0b6af containerd[42938]: time="2022-04-20T08:50:52.183684441Z" level=error msg=monitor error="no running task found: task db0d630812d37a9985ff327be5f41f7d78075147bc3e085a3ddf44d79b388021 not found: not found"
        Apr 20 08:51:02 4e20dff0b6af containerd[42938]: time="2022-04-20T08:51:02.184665351Z" level=error msg=monitor error="no running task found: task db0d630812d37a9985ff327be5f41f7d78075147bc3e085a3ddf44d79b388021 not found: not found"
        Apr 20 08:51:12 4e20dff0b6af containerd[42938]: time="2022-04-20T08:51:12.185633691Z" level=error msg=monitor error="no running task found: task db0d630812d37a9985ff327be5f41f7d78075147bc3e085a3ddf44d79b388021 not found: not found"
        Apr 20 08:51:22 4e20dff0b6af containerd[42938]: time="2022-04-20T08:51:22.186395414Z" level=error msg=monitor error="no running task found: task db0d630812d37a9985ff327be5f41f7d78075147bc3e085a3ddf44d79b388021 not found: not found"
        Apr 20 08:51:32 4e20dff0b6af containerd[42938]: time="2022-04-20T08:51:32.187320246Z" level=error msg=monitor error="no running task found: task db0d630812d37a9985ff327be5f41f7d78075147bc3e085a3ddf44d79b388021 not found: not found"
        Apr 20 08:51:42 4e20dff0b6af containerd[42938]: time="2022-04-20T08:51:42.187712793Z" level=error msg=monitor error="no running task found: task db0d630812d37a9985ff327be5f41f7d78075147bc3e085a3ddf44d79b388021 not found: not found"
        Apr 20 08:51:52 4e20dff0b6af containerd[42938]: time="2022-04-20T08:51:52.188632092Z" level=error msg=monitor error="no running task found: task db0d630812d37a9985ff327be5f41f7d78075147bc3e085a3ddf44d79b388021 not found: not found"

    run_restart_linux_test.go:87: ==========
    run_restart_linux_test.go:88: the container does not seem to be restarted
--- FAIL: TestRunRestart (100.13s)

https://github.com/containerd/nerdctl/runs/6091620240?check_suite_focus=true


rerun <file> does not work if there's already an open Rerun instance

In repository repro:
pixi run py-build
pixi run -e py python ./examples/python/dna/dna.py
pixi run rerun some_image_file_I_had_around.png

It says it streams to an existing viewer, but nothing ever shows.
On 0.19 the image opens in new rerun instance, also not what I expected to happen, but not as broken.

I think I remember this working properly back when we merged https://github.com/rerun-io/rerun/pull/6951, hmm... :thinking:
Lemme try this

Yup, it sure is broken now. Digging.

Welp, after a long dig into the git history, the only explanation I can come to is that I severely hallucinated when I merged this PR: the code cannot work because... well the code just isn't there. Literally, there is no code:
https://github.com/rerun-io/rerun/pull/6951/files#diff-2a04e2af4408b757cb5b308ac05290c50f5f04128f6d8072025f746849ebccf0R788-R790
} else if is_another_viewer_running {
    re_log::info!("Another viewer is already running, streaming data to it.");
    Ok(())
}

There's a print saying we're forwarding the data, but... we don't.
There's no such code anywhere in the history history so that doesn't look like a botched rebase..?! I have no idea what on earth is going on.
Well, whatever I guess, I'll just implement for forwarding logic.


Update doc for heroku-20

Update doc for heroku-20
Apparently this is also working well for heroku-20 stack except i didnt need libssl1.0.0 in my Aptfile anymore ( it was not found anyway ).
Maybe we can add this to the docs ?
Regards

Hi - thanks! I just updated the docs.
(sorry for the looong delay)


Story.update() disallowed-keys

Hey 👋
I've found a bug when using Story.update() /2, I'm receiving status 400 because some invalid parameters in the body.
The api documentation doesn't allow some keys that are defined on Input.Story{} as:

external_tickets
story_links
tasks

https://clubhouse.io/api/rest/v3/#URL-Parameters-45270

🏆


Logical Flows: Display of 'via' flows

Scenario:
Let's say we have three applications:
Producer, Consumer and Distributor
Producer sends Trades data to Consumer via Distributor
The requirement is to display this flow on each app's data flows section like this:
Producer:

Distributor:

Consumer:

Currently, we are only creating flows from Producer to Consumer, which means when you view the Distributor app, there are no flows displayed, which is not desirable.
One option to do this is add a via_entity on logical_flow table, and handle this when displaying flows.
Second option is to use the decorator table to add a new decorator type: DISTRIBUTOR (or something similar), and display these flows on the Distributor entity, and also potentially show the decoration on Producer and Consumer.
Third option is to add something like a  DISPLAY_ON field on the logical_flow table with values like SOURCE_ONLY, TARGET_ONLY, BOTH

@davidwatkins73 thoughts? The third options seems to be easiest to do, but we also need to decide which flows should be displayed on the boingy graphs, potentially only the ones with BOTH as the DISPLAY_ON value?
We may add toggles to display hidden flows on all these diagrams potentially.

Linking this to #4788 , since using a combination of tags and default tag behaviour (via logical_flow_decorator, eg: hide_on_target etc) could potentially solve this in a better way.

We've been having some discussions on similar topics.
In one camp we have the logical flows are close to physicals in that their source
and targets should be 'accurate'.  In the other camp we have a desire to skip distributors.
There was quite a lot of opposition to a via field when it was proposed here by the first camp and also the second camp didn't think only one level of indirect hop would be enough.
Everything get's even muddier when we have distributors which sometime do some slight enrichment/combining of data.  Would they be excluded ?...
That said, there are some other options which we could consider:

skipping intermediaries but using transport to encompass distributors (this is routed in the physical so may be tricky)
keeping intermediaries but adding  "ultimate destination/s" decorators on logicals (this allows the existing direct mappings to be progressively enhanced, rather than needing to be re-declared with a 'via' field).

Let's set up a short call later in the week to discuss the options with Mark and I'll do a bit more asking around here first to see what other use-cases people have

Another aspect being actively considered here is at the physical, by allowing physical flows to link to measurables.  One of the measurables we have is the tech-product taxonomy which lists all the hosted middleware options (manage databases, middleware, ETL, scheduling systems etc).  This relationship would be a 'depends on' relationship.  This approach also falls into the skipping intermediaries approach.
The first option I outlined above (using transport) and this are both rooted in the physical, which is arguably where this needs to be as the logical with a 'via' may not be accurate for all instances of communication between two parties (i.e. App A and B communicate via several different intermediaries).

Yep, let's discuss in a call.
I lean towards the first camp, that the 'source' and 'targets' for logical flows should be accurate and match physical flows, so I think we should create logical flows for distributors.
As you said there could be distributors who store/enrich data, and they shouldn't (can't?) be excluded if we want to draw an accurate lineage diagram I suppose (regulators?).
On the distributor app, these flows should be visible, otherwise it gives an inaccurate picture, unless we also create a physical source & target graph similar to logical, but even then, we would need to link distributors to physical flows somehow.
On the producer and consumer apps, ideally they should be hidden by default, but there should be an option to unhide and view these on the logical flow graph. If we just hide them magically as if they didn't exist, it might confuse users.
The logical flow source and target graph, and the boingy graph work well, and users understand the concept of drilling down to physical flows if needed (most just want to look at the diagrams).
So, I think there needs to be a way to enrich these logical diagrams with additional (ideally filterable) information.
I had also raised: https://github.com/finos/waltz/issues/4788 (please let me know your thoughts on that one if you get time), to add tags to logical flows and filter flows based on tags, which is a nice feature in itself, but it will potentially solve this issue.
Eg. tags in this case:
Producer1 -> DistributorA: To DistributorA
DistributorA -> Consumer1: From DistributorA
Producer1 -> Consumer1: via DistributorA
If we allow users to filter the app source/target graph and the group level boingy graph based on these filters, then this potentially resolves the problem (of cluttered flow diagrams), while still maintaining accurate flow information.
Second stage of this could be to mark tags as hidden by default (on logical flow source/target), may be by using the decorator table? This should then complete the solution to this issue imo.

Another approach could be this:
We create logical flows as normal, so in the example above we'll create the following logical flows:

id
source
target

1
Producer1
DistributorA

2
Producer2
DistributorA

3
DistributorA
Consumer1

Now, if we are able to define Upstream(s) for a a logical_flow, we could set logical flow id 1 (Producer1 -> DistributorA) as the  Upstream source for logical flow id 3 (DistributorA -> Consumer1).
This can be done using decorators potentially.
Advantages:

Logical flows are created normally, so each app owner needs to define only one level of upstreams/downstreams as normal
Then, logical flows can be linked progressively, one hop at a time, effectively formalising lineage
Chaining flows this way will enable us to know via apps at any hop of the chain
Impact analysis can be done across multiple hops, as opposed to just one hop

This is a feature that we would also be interested in.


Error when downloading the data?

Hello, thank you for your wonderful work and making this data open-source!
I'm having an issue when trying to download the data, getting the following error:
<EMAIL_ADDRESS>Permission denied (publickey).
install(error): data/ds003020 (dataset)
[Failed to clone from all attempted sources: ['git@github.com:OpenNeuroDatasets/ds003020.git']

Any idea what the issue could be?
Thanks,
Chandan

Is this happening for all files that are trying to be downloaded or just one? If its all of them I would guess that it is because there is some other AWS public key in your environment. If there is some other AWS keys for other buckets that you use that can cause datalad to fail to download because it gets confused with keys.

Gotcha thank you for the very quick response! It was happening for all of them, but was fixed when I just changed the datalad clone argument to this:
datalad clone https://github.com/OpenNeuroDatasets/ds003020

Oh thanks for letting me know! I just switched it to this to make it easier for others in the future. I will close this issue. But feel free to reopen if you keep having issues.


document ideas behind the springboard reboot

random thoughts from IM:
ideally, there's no logic in the actual pages themselves
you just include things if you want it
(or don't, if you don't care about it)
and I was thinking of having a convention of either having includes be community_foo.html or community/foo.html where community (or whatever) is the site name
so ovirt_foo.html or ovirt/foo.html under `_includes/` for site-specific ones, for example
not a hard rule, but one to make it clear when there's something SPECIFIC to the site
and doing similar stuff for CSS/JS
also, look into the possibility of having optional CSS, like fonts.scss, so we don't need to include it in the starter repo, but it checks for the presence of it and uses it
like how I have /img/logo.svg — it's optional to have a logo
and you can change the name (like to PNG even) in the _config.yml
logo: "/img/foobar.png"
if you don't have a logo (and the forkable site won't), then it will fall back to not having the HTML for it, but having just a plain link in the H1
planning on having some page header stuff, like if you want to include special CSS/JS for just that page
like style: and script: in the frontmatter
so it can put those in the HEAD
and special class/classes too
all optional
but would be useful
and all this should be documented
I guess I should write this up and then add it
also, I should write up some rules I try to abide by
like no gem deps
and include only what's necessary
and try to keep content purely separated from logic and such
and explain the dirs a bit (although Jekyll explains them already)
anyway, I have ideas about it in my head... I just hope I don't forget them before implementing them (:
simplify is the #1 constraint and goal behind this, and everything falls into line from that
and to be able to understand everything that's going on
not hide behind layers of dependencies and libraries doing magic things (bootstrap is included in this)
it's POSSIBLE, but not a good idea
(to do things in a wacky way)

Anyway, this needs to be written up properly.

...and included in README.md


[ADAM-1891] Reimplement FASTA sequence and slice converters for performance

Fixes #1891, fixes #2174

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/3022/Build result: FAILURE[...truncated 3 lines...]Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prbWiping out workspace first.Cloning the remote Git repositoryCloning repository https://github.com/bigdatagenomics/adam.git > git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > git rev-parse origin/pr/2175/merge^{commit} # timeout=10 > git branch -a -v --no-abbrev --contains c5a37a382d918d3605352dc60077a3325ebdb729 # timeout=10Checking out Revision c5a37a382d918d3605352dc60077a3325ebdb729 (origin/pr/2175/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f c5a37a382d918d3605352dc60077a3325ebdb729First time build. Skipping changelog.Triggering ADAM-prb ? 2.7.5,2.12,2.4.3,ubuntuTriggering ADAM-prb ? 2.7.5,2.11,2.4.3,ubuntuADAM-prb ? 2.7.5,2.12,2.4.3,ubuntu completed with result FAILUREADAM-prb ? 2.7.5,2.11,2.4.3,ubuntu completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/3023/Build result: FAILURE[...truncated 3 lines...]Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prbWiping out workspace first.Cloning the remote Git repositoryCloning repository https://github.com/bigdatagenomics/adam.git > git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > git rev-parse origin/pr/2175/merge^{commit} # timeout=10 > git branch -a -v --no-abbrev --contains 644d3e28d4da54230b406db7f2288869426358c1 # timeout=10Checking out Revision 644d3e28d4da54230b406db7f2288869426358c1 (origin/pr/2175/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 644d3e28d4da54230b406db7f2288869426358c1First time build. Skipping changelog.Triggering ADAM-prb ? 2.7.5,2.12,2.4.3,ubuntuTriggering ADAM-prb ? 2.7.5,2.11,2.4.3,ubuntuADAM-prb ? 2.7.5,2.12,2.4.3,ubuntu completed with result FAILUREADAM-prb ? 2.7.5,2.11,2.4.3,ubuntu completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Coverage remained the same at ?% when pulling 0d44fc85c6e02312730eb36e95655d647c408fe6 on heuermh:slice-perf into 05d474a9a96f5dddeac7a03a59cf2ffe13c4641a on bigdatagenomics:master.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/3024/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/3025/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/3026/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/3027/
Test PASSed.


Slight change to TLPhotoPicker CustomPhotoPickerViewController example (photoPickerDidCancel)

Hi,
Your photo picker works great.  I had one change regarding the CustomPhotoPickerViewController.
    @objc func customAction() {
        self.dismiss(animated: true, completion: nil)
    }

should be:
@objc func customAction() {
        self.dismiss(animated: true) {
            self.delegate?.photoPickerDidCancel()
        }
    }

to ensure photoPickerDidCancel() is called.
Thanks!

You right. I've pushed a fix for this.


[WIP] Server side rendering for scrolled entries

Still contains commits from #1551. Needs to be rebased once that's merged.
REDMINE-17566

Coverage decreased (-0.002%) to 99.191% when pulling 00231fe5f08bcc1effa403bd5462d88956f2b589 on tf:ssr into 28ac825101a07fd6742ea2d938712b048fd94326 on codevise:master.


[pwrmgr] Various clean-up and updates

fixed missing pre-sync flops
various typo fixes
comments from #1924

Signed-off-by: Timothy Chen<EMAIL_ADDRESS>

@vogelpi
this PR is in response to your comments. Please take a look.
Also I feel like I did not completely understand your points regarding req/ack, please let me know.

@vogelpi i updated per your suggestions.
Please let me know on the req / ack, I've made some updates that i think addresses what you were referring to. If not, let me know, I can update it more.

Hi @tjaychen,
my approach would be to completely separate the clock domain crossing from the two FSMs: The FSMs would not need to care about clearing req/ack, but just deal with combinatorial signals (i.e. setting req, waiting for ack). For handling the clock domain crossing, I would use a separate module that just does that and gives both domains the view of a req/ack that is valid for exactly one cycle, i.e., if both would synchronize with something in the same domain.
The FSM states would then become as simple as (just as an arbitrary example I took StReqPwrUp and StWaitAckPwrUp in the slow FSM):
      StPwrUp: begin
        pwrup_req_o = 1'b1;
        if (pwrup_ack_i) begin
          state_d = StIdle;
        end
      end

I think by doing this quite some complexity associated with the CDC can be moved out of the FSMs into the separate module. But obviously, this module needs to be carefully designed and I guess there are some pitfalls there as well. On the plus side, if its done right once, the module can be used also in other places. I have attached a first draft of such a module. I could not yet test it but it should give you an idea of how it would look like and you can maybe decide if you want to follow this route. If yes, I would of course support you in the process of integrating and debugging it.
I am not saying that this is the only true solution to the problem. Others might not like it for various reasons. But to me it looks like a clean way of handling this. If you decide to stick with the current implementation, that would also be totally fine. No hard feelings.
Best regards,
Pirmin
Please see the attached documents:

A draft of a prim_reqack_sync SystemVerilog module. This module synchronizes a req/ack handshake over a clock domain crossing. The main idea is that both source and destination clock domain see the handshake for exactly one clock cycle, and thus don't need to know that they are syncing with another domain.
prim_reqack_sync.txt
I am not sure this module covers all corner cases properly and could not test it, but it shows the idea.

A hand drawing on the different corner cases that the prim_reqack_sync needs to handle:
reqack_sync.pdf

hmm... this feels really heavy handed in this case.. .but i do see where
you're coming from.
You're basically trying to build in the mechanism on the when the requests
/ acks return to 0.  That's fine, I can switch to this if you like.
I'll probably first revert back to the state without the wait states,
then follow on with another PR to change this, since I want to get the
pwr/rst stuff merged for now.
Do you want to make a PR with your file into ip/prim? Just fyi it looks
like there's a combo direct path to the synchronizers, so you probably want
to add another level of flopping there.
I think I would also change the names the clk_src_i and clk_dest_i (or
something to that effect), so that we can then prefix the domains with
src_req_i, dest_req_o etc.  It might make it easier to read than domain 1 /
2.
.
On Wed, Apr 22, 2020 at 6:03 AM Pirmin Vogel<EMAIL_ADDRESS>wrote:

Hi @tjaychen https://github.com/tjaychen,
my approach would be to completely separate the clock domain crossing from
the two FSMs: The FSMs would not need to care about clearing req/ack, but
just deal with combinatorial signals (i.e. setting req, waiting for ack).
For handling the clock domain crossing, I would use a separate module that
just does that and gives both domains the view of a req/ack that is valid
for exactly one cycle, i.e., if both would synchronize with something in
the same domain.
The FSM states would then become as simple as (just as an arbitrary
example I took StReqPwrUp and StWaitAckPwrUp in the slow FSM):
  StPwrUp: begin
    pwrup_req_o = 1'b1;
    if (pwrup_ack_i) begin
      state_d = StIdle;
    end
  end

I think by doing this quite some complexity associated with the CDC can be
moved out of the FSMs into the separate module. But obviously, this module
needs to be carefully designed and I guess there are some pitfalls there as
well. On the plus side, if its done right once, the module can be used also
in other places. I have attached a first draft of such a module. I could
not yet test it but it should give you an idea of how it would look like
and you can maybe decide if you want to follow this route. If yes, I would
of course support you in the process of integrating and debugging it.
I am not saying that this is the only true solution to the problem. Others
might not like it for various reasons. But to me it looks like a clean way
of handling this. If you decide to stick with the current implementation,
that would also be totally fine. No hard feelings.
Best regards,
Pirmin
Please see the attached documents:

A draft of a prim_reqack_sync SystemVerilog module. This module
synchronizes a req/ack handshake over a clock domain crossing. The main
idea is that both source and destination clock domain see the handshake for
exactly one clock cycle, and thus don't need to know that they are syncing
with another domain.
prim_reqack_sync.txt
https://github.com/lowRISC/opentitan/files/4516182/prim_reqack_sync.txt
I am not sure this module covers all corner cases properly and could
not test it, but it shows the idea.
A hand drawing on the different corner cases that the prim_reqack_sync
needs to handle:
reqack_sync.pdf
https://github.com/lowRISC/opentitan/files/4516056/reqack_sync.pdf
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/2011#issuecomment-617766046,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSQL5SH34FUCJSYCWPDRN3TL3ANCNFSM4MM43V6Q
.

hmm... this feels really heavy handed in this case.. .but i do see where you're coming from. You're basically trying to build in the mechanism on the when the requests / acks return to 0. That's fine, I can switch to this if you like. I'll probably first revert back to the state without the wait states, then follow on with another PR to change this, since I want to get the pwr/rst stuff merged for now. Do you want to make a PR with your file into ip/prim? Just fyi it looks like there's a combo direct path to the synchronizers, so you probably want to add another level of flopping there. I think I would also change the names the clk_src_i and clk_dest_i (or something to that effect), so that we can then prefix the domains with src_req_i, dest_req_o etc. It might make it easier to read than domain 1 / 2. .
…
On Wed, Apr 22, 2020 at 6:03 AM Pirmin Vogel @.***> wrote: Hi @tjaychen https://github.com/tjaychen, my approach would be to completely separate the clock domain crossing from the two FSMs: The FSMs would not need to care about clearing req/ack, but just deal with combinatorial signals (i.e. setting req, waiting for ack). For handling the clock domain crossing, I would use a separate module that just does that and gives both domains the view of a req/ack that is valid for exactly one cycle, i.e., if both would synchronize with something in the same domain. The FSM states would then become as simple as (just as an arbitrary example I took StReqPwrUp and StWaitAckPwrUp in the slow FSM): StPwrUp: begin pwrup_req_o = 1'b1; if (pwrup_ack_i) begin state_d = StIdle; end end I think by doing this quite some complexity associated with the CDC can be moved out of the FSMs into the separate module. But obviously, this module needs to be carefully designed and I guess there are some pitfalls there as well. On the plus side, if its done right once, the module can be used also in other places. I have attached a first draft of such a module. I could not yet test it but it should give you an idea of how it would look like and you can maybe decide if you want to follow this route. If yes, I would of course support you in the process of integrating and debugging it. I am not saying that this is the only true solution to the problem. Others might not like it for various reasons. But to me it looks like a clean way of handling this. If you decide to stick with the current implementation, that would also be totally fine. No hard feelings. Best regards, Pirmin Please see the attached documents: - A draft of a prim_reqack_sync SystemVerilog module. This module synchronizes a req/ack handshake over a clock domain crossing. The main idea is that both source and destination clock domain see the handshake for exactly one clock cycle, and thus don't need to know that they are syncing with another domain. prim_reqack_sync.txt https://github.com/lowRISC/opentitan/files/4516182/prim_reqack_sync.txt I am not sure this module covers all corner cases properly and could not test it, but it shows the idea. - A hand drawing on the different corner cases that the prim_reqack_sync needs to handle: reqack_sync.pdf https://github.com/lowRISC/opentitan/files/4516056/reqack_sync.pdf — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2011 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH2RSQL5SH34FUCJSYCWPDRN3TL3ANCNFSM4MM43V6Q .

btw @vogelpi , thank you for your diligent and detailed review! i'm going to merge it for now, but i expect follow-on PRs to happen. If you don't mind making a PR with your prim_req_ack, i can absorb the behavior into pwrmgr.

merging for now. More PRs to follow to address req/ack.

Hey @tjaychen ,
you are welcome, thanks for all the effort you are putting into this. It is really a lot of work and I think you're doing a great job!
The plan to move forward sounds good to me. I will work out a PR for the prim_req_ack into ip/prim and then we can go from there. Thanks for having a look at the draft and providing initial feedback.


refactor: adjust configuration validation in config flow

Proposed change

Adjust configuration validation in config flow
Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality)
[ ] Breaking change (fix/feature causing existing functionality to break)
[x] Code quality improvements to existing code or addition of tests
[ ] Documentation update
[ ] Adds a new shipper
[ ] Update existing shipper

Additional information

This PR is related to issue: #879

Codecov Report
Attention: Patch coverage is 75.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 95.07%. Comparing base (6a684ae) to head (7d8c500).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #880      +/-   ##
==========================================
- Coverage   95.41%   95.07%   -0.34%
==========================================
  Files           8        8
  Lines        1482     1482
==========================================
- Hits         1414     1409       -5
- Misses         68       73       +5

Files
Coverage Δ

custom_components/mail_and_packages/config_flow.py
100.00% <100.00%> (ø)

custom_components/mail_and_packages/const.py
100.00% <100.00%> (ø)

custom_components/mail_and_packages/helpers.py
94.72% <100.00%> (+<0.01%)
:arrow_up:

custom_components/mail_and_packages/__init__.py
91.30% <64.28%> (-4.39%)
:arrow_down:


chore(master): release 1.1.68

:robot: I have created a release beep boop
1.1.68 (2023-09-04)
Miscellaneous

deps: update dependency wayofdev/cs-fixer-config to v1.2.54 (71b8ec8)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/laravel-stripe-webhooks/releases/tag/v1.1.68 :sunflower:


Fix vairous issues found in bt uart shim driver

Summary
bt_uart_shim: Correct the prototype of bt_uart_shim_getdevice
bt_uart_shim: Support the multiple instances
bt_uart_shim: Don't hardcode the thread stack size
bt_uart_shim: Remove g_lowerstatic static variable
bt_uart_shim: Make CONFIG_SERIAL_TERMIOS optional
bt_uart_shim: Setup pollfd with file* correctly
Impact
Testing
Please ignore nxstyle warning which is fixed by: #2607

@xiaoxiang781216
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/include/nuttx/wireless/bluetooth/bt_uart_shim.h:9:78: error: Long line found
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/include/nuttx/wireless/bluetooth/bt_uart_shim.h:14:79: error: Long line found
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/include/nuttx/wireless/bluetooth/bt_uart_shim.h:15:79: error: Long line found
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/include/nuttx/wireless/bluetooth/bt_uart_shim.h:19:79: error: Long line found
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/include/nuttx/wireless/bluetooth/bt_uart_shim.h:22:78: error: Long line found

@jerpelea fixed here: https://github.com/apache/incubator-nuttx/pull/2607

@jerpelea thanks, PR pass CI now.


Setup.cfg has a duplicate section for flake8

I used the cookiecutter template to start a plugin, running python setup.py develop to install the plugin locally fails with the following error
configparser.DuplicateSectionError: While reading from 'setup.cfg' [line 48]: section 'flake8' already exists
Removing the duplicate entry for flake8 resolves the issue.

Awesome! Thank you for reporting this - was still in beta so great to get these issues reported.

@arthanson I used this to build https://github.com/jasonyates/netbox-circuitmaintenance over the weekend. It worked great. I have a few other issues I can open if you are looking for additional feedback.


Usb assertion "hw_data_offset(next_buffer_ptr) <= USB_DPRAM_MAX"

This is a duplicate of the issue I created at please see the issue there for sull documentation:
hathach/tinyusb/issues/628
In the issue I created in the tinyusb repo I mention that I am using the new code coming directly from that repo, but the code at that is at issue is in the SDK tiny USB repo as well.

Sounds like something @liamfraser needs to look at?

This issue is fixed by hathach/tinyusb#642 @liamfraser it is one real line of code so it should be easy for you to take a look at.

Looks like a plausible fix to me. I think the audio example may be the first one that repeatedly opens and closes an ep which is why we didn't see this?

(I don't own the upstream tinyusb repo so I can't merge the PR)

@liamfraser please accept my contributor invitation, and feel free to review, approval and merge any PRs that make sense to you. I still haven't got into the usb specs of rp2040 yet. Worse I am on vacation just now :wink:

@ndinsmore I have merged this into tinyusb upstream

Will keep this open until either a) our sdk tracks upstream or b) we pick this commit into our fork. We need to review what changes have been made in tinyusb upstream before switching the SDK to it.

closing in favor of #161

changed my mind, will get closed with #321

actually closed by #462

released


fix a regression caused by #1412

A fixup for the incorrect tuple returned from unwrap_cover in qry_compiler. The regression is caused by e34fc1a07.
Suggesting @macintux for a reviewer.

:+1: 54905b8

@borshop merge


Feature/antenna selection v2

Adding Victoria's webinar code into the demos repo.
Minor change to her code:

how the plot is displayed (see commit f06ddaf)

Additions to her code:

added a first-pass readme
added a requirements file

Todos:

will add a smoke test for her code (i.e. allow CircleCI to verify for us in the future)
add node index numbers to the plot

I am having trouble displaying the README image plots using relative paths. I will just merge this into master and hardcode the master branch's image paths for now.

README:

"A graph representing antenna coverage. " --> This is not a sentence
"Each of the seven nodes below represent seven"--> represents
"![example_original](" --> did you mean for the link to look like this? This is not the standard format for including an image in RST format