Fix form default behavior

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/36363
$ https://github.com/Expensify/App/issues/36439
$ https://github.com/Expensify/App/issues/31433
Tests

Go to App
Go to FAB > Request money > Distance.
Click Start.
Hit Enter on keyboard.

[x] Verify that no errors appear in the JS console

Offline tests

Same as Tests
QA Steps

Same as Tests
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Shouldn't we add https://github.com/Expensify/App/pull/36401 to "Fixed issues"?
Conflicts

Again, would you please add some context in the "Details" section? PRs and issue graphs are being navigated by humans after being merged, for various reasons.

Conflicts ⚔

Conflicts, TypeScript Checks, threads

Should I review this?
cc: @cubuspl42 @shubham1206agra

Linter!

First, merge main; major changes are ongoing, and we're 600 commits behind.
You link https://github.com/Expensify/App/issues/36439 as fixed, but you don't include its testing steps in the "Tests" section.
Once you do that, ensure that they pass.
I repeated them and they don't pass for me.

Depending on how difficult it is to fix that, we could consider merging this PR and create a follow-up. Also, it's possible that the "Actions performed" in https://github.com/Expensify/App/issues/36439 are not precise or I misunderstood them.

We're not fixing https://github.com/Expensify/App/issues/36439 as described, as we haven't achieved the expected behavior. You can challenge the expected behavior on the issue. If this isn't a regression from the original PR, you could try using this as a trading card. If this is a regression from the original PR, I would assume a follow-up PR is necessary.

@shubham1206agra Thank you for clarifying!

I just noticed you still need to provide testing videos. Please fix this.

Go to App
Go to FAB > Request money > Distance.
Click Start.
Hit Enter on keyboard.

What's the actual expected behavior? Shouldn't the empty waypoint be accepted, taking us back to the Request Money page / Distance tab?
Also, if I input a waypoint manually and hit Enter, nothing happens. Wasn't that supposed to work? I'm testing on macOS/Web.

Yeah, I remember now. There were some issues on Android Web, and I made a call to remove that support.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@shubham1206agra just passing disablePressOnEnter={false} to FormProvider fixes the refresh issue 🤔

No refresh issue is fixed by other files 😄

just applied it on main could you check?

@shubham1206agra seems like

just passing disablePressOnEnter={false} to FormProvider fixes the refresh issue

without the changes in this PR

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.46-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.46-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


New option that can disable modsecurity logging into nginx error log

Modsecurity module for nginx by default log the whole message in case request is blocked into nginx error log. But the same information is also logged into modsecurity audit logs, so logs can grow pretty fast in case of DDoS or scanning attacks.
This patch adds new option modsecurity_error_log that accepts on or off option. on is default that logs the whole message to error log, but it can be turned off.
It also adds new variable $modsecurity_status that contains status code from modsecurity.

Hi @JakubOnderka,
thanks for this PR!
I'm sure this patch can be useful for many users, but please consider the following:

log the whole message in case request is blocked into nginx error log. But the same information is also logged into modsecurity audit logs

this depends on some circumstances. Eg. by default audit log contains the transaction related information only if the status code is 4XX or 5XX except 404 (see SecAuditLogRelevantStatus).
If someone uses Core Rule Set in anomaly scoring mode, and the transaction's score value does not reach the threshold, then those information will be lost (I mean the triggered rules).
Moreover consider if someone uses some IPS/IDS (eg. fail2ban) which uses only the error.log (as I know there is no any plugin for fail2ban which can use audit.log) - then this configuration could be unusable.
I support any new feature, but we must notice users what do they do.

so logs can grow pretty fast in case of DDoS or scanning attacks.

If the log level is lower than info in Nginx's configuration (eg. no level), then the result is almost the same (like this PR's result).

This patch adds new option modsecurity_error_log that accepts on or off option. on is default that logs the whole message to error log, but it can be turned off.

A side note, but hope others will be check this PR too and write their opinions: modsecurity_error_log refers to me that where is the log, I mean the path. May be some more informative name would be better - eg. modsecurity_use_error_log, or similar.

It also adds new variable $modsecurity_status that contains status code from modsecurity.

It would be nice to see a real example of its use. While you want to add a new configuration keyword and a new variable, please add their documentation into README.md, below the Usage section (you can do that within this PR - not a separated one). If you make the documentation for modsecurity_error_log (or the other name - we will see it), then please add the side effects too what I explained above.
And thanks again!


Check unnecessary usage of msg.Clone()

We need to check unnecessary usage of msg.Clone().
Here an example which make no sense with the new clone handling from v0.5.x:
source producer/scribe.go:203:
// Convert messages to scribe log format
	for idx, msg := range messages {
		currentMsg := msg.Clone()

		category, exists := prod.category[currentMsg.GetStreamID()]
		if !exists {
			if category, exists = prod.category[core.WildcardStreamID]; !exists {
				category = core.StreamRegistry.GetStreamName(currentMsg.GetStreamID())
			}
			metricName := scribeMetricMessages + category
			tgo.Metric.New(metricName)
			tgo.Metric.NewRate(metricName, scribeMetricMessagesSec+category, time.Second, 10, 3, true)
			prod.category[currentMsg.GetStreamID()] = category
		}

		logBuffer[idx] = &scribe.LogEntry{
			Category: category,
			Message:  string(currentMsg.GetPayload()),
		}

		tgo.Metric.Inc(scribeMetricMessages + category)
	}

The file producer had the same issue which i'll fix in #173 by providing a new message method GetOrigStreamID. The main reason for message cloning was often to get the original stream id, which is not necessary anymore and only need resources.
// GetOrigStreamID returns the original/first streamID
func (msg *Message) GetOrigStreamID() MessageStreamID {
	return msg.orig.streamID
}

Added method by https://github.com/trivago/gollum/commit/0f71ba3de1ad9d1e5ad50864722e57f7f74cf0c5


Move health route out of ARPA Reporter folder

Fixes #362
Note this doesn't change any functionality because this route already exists (and I've already added Render config in both staging and prod to check it); it just moves the file out of the ARPA Reporter folder so it doesn't get accidentally removed in the future if we end up retiring ARPA Reporter code.
It looks like Render hits the health check route frequently, so I'm excluding it from logging to keep logs useful (otherwise interesting things may get truncated by thousands of health checks...)
ARPA's test for this route is removed entirely and re-added in #419 in order to avoid merge conflicts between these two concurrently open PRs, since that PR changes how route tests in GOST work.

wdyt of migrating that health-check test over to gost repo as well? It may be useful just to have as a test-template for how to test routes.

Confirmed that the other open PR #419 has the test so no changes required here 👍


OG data is not fully parsed

Tried with version 0.15.3 (we need ios8)
Here are the results of library for url https://www.imdb.com/title/tt5095030/:
createdAt = Wed Jul 18 13:25:53 2018
imageUrl = (null)
pageDescription = Directed by Peyton Reed.  With Paul Rudd, Evangeline Lilly, Michael Peña, Walton Goggins. As Scott Lang balances being both a Super Hero and a father, Hope van Dyne and Dr. Hank Pym present an urgent new mission that finds the Ant-Man fighting alongside The Wasp to uncover secrets from their past.
pageTitle = (null)
pageType = (null)
siteName = (null)
sourceUrl = https://www.imdb.com/title/tt5095030/
updatedAt = Wed Jul 18 13:25:57 2018
url = http://www.imdb.com/title/tt5095030/

While there are not null tags (can be seen in source html, or by tools like https://opengraphcheck.com/result.php?url=https%3A%2F%2Fwww.imdb.com%2Ftitle%2Ftt5095030%2F#.W07dRdgzZTY)
og:url | http://www.imdb.com/title/tt5095030/
og:image | https://m.media-amazon.com/images/M/MV5BYjcyYTk0N2YtMzc4ZC00Y2E0LWFkNDgtNjE1MzZmMGE1YjY1XkEyXkFqcGdeQXVyMTMxODk2OTU@._V1_UY1200_CR90,0,630,1200_AL_.jpg
og:type | video.movie
og:title | Ant-Man and the Wasp (2018)
og:site_name | IMDb
og:description | Directed by Peyton Reed. With Paul Rudd, Evangeline Lilly, Michael Peña, Walton Goggins. As Scott Lang balances being both a Super Hero and a father, Hope van Dyne and Dr. Hank Pym present an urgent new mission that finds the Ant-Man fighting alongside The Wasp to uncover secrets from their past.

Same results with 0.16.1 version

@Luten
I've fixed and support iOS8 again.
Please try 0.16.2

Thanks for fast reaction!
But this fix didn't help =(
Using URLEmbeddedView (0.16.2)
imageUrl = (null)
pageDescription = Directed by Peyton Reed.  With Paul Rudd, Evangeline Lilly, Michael Peña, Walton Goggins. As Scott Lang balances being both a Super Hero and a father, Hope van Dyne and Dr. Hank Pym present an urgent new mission that finds the Ant-Man fighting alongside The Wasp to uncover secrets from their past.
pageTitle = (null)
pageType = (null)
siteName = (null)
sourceUrl = https://www.imdb.com/title/tt5095030/
url = http://www.imdb.com/title/tt5095030/

I've tries https://www.imdb.com/title/tt5095030/  with 0.16.2.
It works fine like below image.

That's strange..
It worked for https://www.imdb.com/title/tt4701182/, but still didn't work for https://www.imdb.com/title/tt5095030/
Looks like it is a cache issue, I'll clear it all and will get back here

Yeah, that did it.
Cleared cache - and now it all works fine.
@marty-suzuki Huge thanks again for your time, efforts and very fast reaction!


Refactor Session class and add independent get_analytics method

📥 Pull Request
Background
I need to access analytics directly, not only through the logs.
I created a workaround for myself to get the analytics stats, but I figured that others could benefit from it as well.
So, I added a function that can return the session analytics back to the user.
📘 Description
Refactored the Session class to improve code modularity and maintainability. Specifically:
•	Introduced a get_analytics method to allow independent retrieval of session analytics (e.g., token cost, LLM calls, tool usage, etc.).
•	Moved token cost and duration formatting into separate methods for better code reuse.
•	Ensured that the analytics function can be used independently of the session lifecycle.
🧪 Testing
•	Tested the get_analytics method by running sessions and validating the returned statistics, including correct duration formatting and token cost calculation.
•	Verified that the session behaves as expected when ending, ensuring no regression in the current end_session logic.
•	Ensured thread management and queue flushing still work as intended in the refactored code.

Another option is to have a function like this:
import json
from decimal import ROUND_HALF_UP, Decimal

from agentops import logger
from agentops.exceptions import ApiServerException
from agentops.helpers import get_ISO_time, filter_unjsonable
from agentops.http_client import HttpClient
from typing import Union
from datetime import datetime

def get_analytics(session) -> dict[str, Union[Decimal, str]]:
    if not session.end_timestamp:
        session.end_timestamp = get_ISO_time()

    formatted_duration = _format_duration(
        session.init_timestamp, session.end_timestamp
    )
    token_cost = _get_token_cost(session)
    if token_cost == "unknown" or token_cost is None:
        token_cost_d = Decimal(0)
    else:
        token_cost_d = Decimal(token_cost)
    formatted_cost = _format_token_cost(token_cost_d)

    return {
        "llm_calls": session.event_counts["llms"],
        "tool_calls": session.event_counts["tools"],
        "actions": session.event_counts["actions"],
        "errors": session.event_counts["errors"],
        "duration": formatted_duration,
        "cost": formatted_cost,
    }

def _format_duration(start_time, end_time):
    start = datetime.fromisoformat(start_time.replace("Z", "+00:00"))
    end = datetime.fromisoformat(end_time.replace("Z", "+00:00"))
    duration = end - start

    hours, remainder = divmod(duration.total_seconds(), 3600)
    minutes, seconds = divmod(remainder, 60)

    parts = []
    if hours > 0:
        parts.append(f"{int(hours)}h")
    if minutes > 0:
        parts.append(f"{int(minutes)}m")
    parts.append(f"{seconds:.1f}s")

    return " ".join(parts)

def _get_token_cost(session):
    with session.lock:
        payload = {"session": session.__dict__}
        try:
            res = HttpClient.post(
                f"{session.config.endpoint}/v2/update_session",
                json.dumps(filter_unjsonable(payload)).encode("utf-8"),
                jwt=session.jwt,
            )
        except ApiServerException as e:
            return logger.error(f"Could not end session - {e}")

    logger.debug(res.body)
    return res.body.get("token_cost", "unknown")

def _format_token_cost(token_cost_d):
    return (
        "{:.2f}".format(token_cost_d)
        if token_cost_d == 0
        else "{:.6f}".format(
            token_cost_d.quantize(Decimal("0.000001"), rounding=ROUND_HALF_UP)
        )
    )

    ```

Awesome-- I like this idea a lot. Will test out your PR today

Closed in favor of #522


Add linux-headers package to installation

Add linux-headers package, which is helpful to get tools like drawing tablets to work.
(ref: https://archlinux.org/packages/core/x86_64/linux-headers/)

perhaps it'd be better to use $kernel-headers since that would cover stuff like linux-lts-headers (unlike only linux-headers).

Alright, fixing.


Release signing and key ?

Could you add code signing for the hash file, so that we can verify the download with a trust anchor  ?
Thanks in advance

Hello
I was looking for something akin to gpg signing (or anything similar, tuf,
cosign) to build an actual trust (in the cryptographic sense) instead of
just data integrity (i.e. hashes).
The difference being, that with integrity only, anyone with access could
swap/modify both the binary and the hash, without anyone seing anything
(aka provider-in-the-middle attack, or insider attack, etc). With signing,
it makes sure that only the ones who have a secret have "stamp" the content
: access alone to the files then becomes "not enough" to plant
bogus-but-hash-correct content. Except it they get acess to your private
key too, of course...
Exemple of other products providing trust : any debian repository requises
a key ring the end user trusts, rclone provides a public key and sign their
sha256sums, or others provide a detached signature for each of the
binary/packaged.
Thanks for your time
Nicolas
Le mar. 17 sept. 2024, 22:02, Yousif Akbar @.***> a
écrit :

Could you include more detail here, @nipil https://github.com/nipil ?
What exactly are you asking for?
If you're looking to verify the integrity of the assets downloaded, you
can verify the SHA256 checksum.
$ wget https://github.com/gruntwork-io/terragrunt/releases/download/v0.67.7/terragrunt_linux_amd64
$ wget https://github.com/gruntwork-io/terragrunt/releases/download/v0.67.7/SHA256SUMS
$ grep "$(sha256sum terragrunt_linux_amd64 | awk '{print $1}')" SHA256SUMS
—
Reply to this email directly, view it on GitHub
https://github.com/gruntwork-io/terragrunt/issues/3408#issuecomment-2356796138,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABODGW4SADZIQFURVVCNK3TZXCDFPAVCNFSM6AAAAABOHSRIUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJWG44TMMJTHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

I think we need to re-use the same approach as for engine releases - including GPG signature file for checksums

Hey folks,
No update on when we'll be doing this, but I wanted to let you know that we're committed to doing it.
We just need to find the bandwidth to get this setup.

Use a PGP key to sign the release commit.
AFAIK : this helps with trusting the release process, but does not really help with trusting the downloaded build artifacts.


Add ARM arch support in order to run on RPi 4

On newly released RPi4, ARM64 support is out of official roadmap. Ubuntu ARM64 for RPi4 is not release yet. Thus we hope to build a binary for ARM32 which could be run on Raspbian system which is officially supported by Raspberry Pi (2, 3 and 4)

Thank you for sending PR.
The arm32 binary for Linux is included from v1.0.8 👍
https://github.com/c-bata/kube-prompt/releases/tag/v1.0.8


Use cookie to remember editor settings

It would be nice if editor settings were remembered from session to session.

This is a duplicate of #22.


Use webpack instead of tsc to output extension-api.ts

The original script compile:extension-types (introduced in https://github.com/lensapp/lens/pull/1387) which uses tsc to output .d.ts didn't (completely) resolve issue https://github.com/lensapp/lens/issues/1262, because tsc only transpile .ts/tsx to .js
The require('module')/import in ts/tsx are the same after transpilation. Keeping require/import causes https://github.com/lensapp/generator-lens-ext/pull/13 (see comments) for extension developers, when they try to import modules from @k8slens/extensions
The PR aims to use WebPack to solve the problem. I added a new webpack.extensions.ts, and used webpack + ts-loader to pack @k8slens/extensions as one file extension-api.js and output .d.ts just the same original tsc.
I tried to keep webpack.extensions.ts as simple as possible, so remove unnecessary settings which are in other more complicated settings such as webpack.renderer.ts or webpack.main.ts
Closes https://github.com/lensapp/lens/issues/1262
Signed-off-by: Hung-Han (Henry) Chen<EMAIL_ADDRESS>

Can't get what this PR fixing / improves?

Can't get what this PR fixing / improves?

See: https://github.com/lensapp/generator-lens-ext/pull/13

Can't get what this PR fixing / improves?

See: lensapp/generator-lens-ext#13

Ok, @chenhunghan please put next time relevant links in PR/issue description.

Can't get what this PR fixing / improves?

See: lensapp/generator-lens-ext#13

Ok, @chenhunghan please put next time relevant links in PR/issue description.

sure, it's a WIP draft so I didn't put too much attention on the description.

@jakolehm checks are passed, please take a look


Numpad keys do not work

I wanted to use the numpad numbers 4, 5, 6 for previous tab, close tab and next tab respectively.
This has been fixed in mousetrap https://github.com/ccampbell/mousetrap/commit/35c73fddf78380f69e21493674754a2663a36ea9 bump the version and re-test.

fixed while merging upstream changes here: https://github.com/pmalecka/chrome-shortkeys/commit/e77ec6c66b340c52a858345a95d60815e67d3178


docs(Contributing): Add a mention to bower install

@jeffersonrpn Hey, thx for the contribution. I'll merge it in.
Although I'm planning to slowly move away from bower as it's quite obsolete these days and rather only move to NPM. But for now, thx :blush:


Structure: Add a way to start both Node server and React app at the same time

This pull request add:

A way to start at the time the node server and React app just using npm start.
A way to start only the node server using npm run server.
A way to start only the React app using npm run client.
Concurrently module

This pull request remove:

Unused modules

Note: I recommend using the latest stable release of node.js (16.10.0) and npm (7.24.0).

I have a question @jesseruu , if I run npm run dev this execute server and react app? or only npm start executes both of them?

I have a question @jesseruu , if I run npm run dev this execute server and react app? or only npm start executes both of them?

Using dev it runs both but only the server uses nodemon.

Ok, remember make pull, becasue I push a new database model, for User, is a new attr that is called 'usr_auth'


Command system: Eliminate the double powershell code parts

#265 Child of Eliminate the double powershell code parts...
Functionality: k2s system ... k2s system command
Eliminate double code parts in high level scripts used
Move those functionalities under the PowerShell modules and scripts -> lib
Steps:

use a branch, keep the branches for the issue as short living as possible (often merges to main)
keep for start the high level scripts which are called from k2s cli directly
in each high level script sync first the functionality within separate modules from lib
delete afterwards the functionality from the high level scripts, eliminate with this the double code
remove the common global variables and global functions parts from the high level scripts
use at the end high level scripts from scripts which are using exclusively lib modules

k2s system upgrade already migrated with https://github.com/Siemens-Healthineers/K2s/commit/b2c30905da876481691584acdcfdd2f3ec39d0c4.


Change PIN

Its not a real critical feature, but it would be nice if future versions provide the possibility to change the USER-PIN of a token. Thank you!

Hi,
Changing User and SO PINs is great. In this regard, there are #110 , #161. Is it not possible to increase its priority?
thanks.
@mathiasertl , @kislyuk


Remove/replace right-click menu

We should either do this last (if there is such a thing) or use conditional compilation to do this in prod but not dev (the inspect element is far too useful to remove in dev).

Yeah, this is just for release builds

Rui has asked if we can keep it for now, as he's still making use of the dev tools.

You can disable the Dev Tools context Menu by setting it to false in the app.json configuration file.
e.g.
{
"startup_app": {
"contextMenu": false,
"name": "OpenfinPOC",
"description": "OpenFin POC",
"url": "http://openfin.co",
"uuid": "OpenfinPOC",
"autoShow": true
},
"runtime": {
"arguments": "",
"version": "beta"
}
}

Yeah, but we wont do it until we share our app on the website I guess.

Let's not forget to do this before submitting the demo to OF.

It would be nice to have this feature toggled between dev and release, too.

Possibly having different versions on each branch? It'll be one line difference true/false, so merges shouldn't conflict

I've pushed up a branch that, as far as I can see, should work. However, locally it doesn't work correctly. When I diff the files generated with the string-replace, and the files where the allow contect menu bool is hardcoded to false they're identical. So why it doesn't run identically is beyond me.

I had a quick pull, and I've got the same issues. Thankfully it's not just you with them


didReceiveNotificationResponse not getting called in iOS

[REQUIRED] Please fill in the following fields:
Unity editor version: 2020.3.46f1
Firebase Unity SDK version: 16.0.0
Source you installed the SDK: Unity Package Manager
Problematic Firebase Component: Messaging
Other Firebase Components in use: Analytics, Crashlytics
Additional SDKs you are using: N / A
Platform you are using the Unity editor on: iOS
Platform you are targeting: iOS, Android
Scripting Runtime: IL2CPP
[REQUIRED] Please describe the issue here:
I am trying to support custom action in iOS with firebase messaging integrated, with the folowing notification categories in the code
-(NSSet*)getNotificationCategories{

    UNNotificationAction *acceptAction = [UNNotificationAction actionWithIdentifier:@"ACCEPT_IDENTIFIER" title:@"Accept" options:UNNotificationActionOptionForeground];
    UNNotificationAction *declineAction = [UNNotificationAction actionWithIdentifier:@"DECLINE_IDENTIFIER" title:@"Decline" options:(UNNotificationActionOptionDestructive)];

    UNNotificationCategory* inviteCategory = [UNNotificationCategory categoryWithIdentifier:@"INVITE_CATEGORY" actions:@[acceptAction,declineAction] intentIdentifiers:@[] options:UNNotificationCategoryOptionNone];

    NSSet *categories = [NSSet setWithObjects:inviteCategory,nil];

    return categories;
}

- (void) application:(UIApplication  *)app didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken {
    [super application:app didRegisterForRemoteNotificationsWithDeviceToken:deviceToken];

    UNUserNotificationCenter *center = [UNUserNotificationCenter currentNotificationCenter];
    NSSet *notificationCategories = [self getNotificationCategories];
    [center setNotificationCategories:notificationCategories];
}

with these now the action button shows up in the push notification but on clicking the action button
- (void)userNotificationCenter:(UNUserNotificationCenter *)center didReceiveNotificationResponse:(UNNotificationResponse *)response withCompletionHandler:(void (^)(void))completionHandler
is not getting called. I have tried with Unity mobile notifictaion plugin there it works fine, with integrated firebase I am facing this issue.
How we are supposed to handle the custom actions with firebase messaging integrated?

Hi @devauk,
It appears that your issue is related to the Apple platform based on the code snippets you provided, and I'd love to point you to the right direction. That said, you may file an issue in the Firebase iOS SDK repository where the team could identify what's causing this to happen. If possible, please include a minimal, reproducible example as this could be used as a basis for troubleshooting.


Support building putty for windows

Motivation for this change
Uses the mingw makefile in putty to build for Windows targets.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

Success on x86_64-linux (full log)
Attempted: putty
Partial log (click to expand)
shrinking /nix/store/c4bcx591az0aplf1m81ij2d2y9c16pk7-putty-0.70/bin/putty
shrinking /nix/store/c4bcx591az0aplf1m81ij2d2y9c16pk7-putty-0.70/bin/plink
shrinking /nix/store/c4bcx591az0aplf1m81ij2d2y9c16pk7-putty-0.70/bin/pterm
shrinking /nix/store/c4bcx591az0aplf1m81ij2d2y9c16pk7-putty-0.70/bin/puttygen
gzipping man pages under /nix/store/c4bcx591az0aplf1m81ij2d2y9c16pk7-putty-0.70/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c4bcx591az0aplf1m81ij2d2y9c16pk7-putty-0.70/bin
patching script interpreter paths in /nix/store/c4bcx591az0aplf1m81ij2d2y9c16pk7-putty-0.70
checking for references to /build in /nix/store/c4bcx591az0aplf1m81ij2d2y9c16pk7-putty-0.70...
/nix/store/c4bcx591az0aplf1m81ij2d2y9c16pk7-putty-0.70

Success on aarch64-linux (full log)
Attempted: putty
Partial log (click to expand)
shrinking /nix/store/767rqz9lqcriyl53k6j5q4gi6amqnc1y-putty-0.70/bin/puttygen
shrinking /nix/store/767rqz9lqcriyl53k6j5q4gi6amqnc1y-putty-0.70/bin/psftp
shrinking /nix/store/767rqz9lqcriyl53k6j5q4gi6amqnc1y-putty-0.70/bin/pscp
shrinking /nix/store/767rqz9lqcriyl53k6j5q4gi6amqnc1y-putty-0.70/bin/plink
gzipping man pages under /nix/store/767rqz9lqcriyl53k6j5q4gi6amqnc1y-putty-0.70/share/man/
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/767rqz9lqcriyl53k6j5q4gi6amqnc1y-putty-0.70/bin
patching script interpreter paths in /nix/store/767rqz9lqcriyl53k6j5q4gi6amqnc1y-putty-0.70
checking for references to /build in /nix/store/767rqz9lqcriyl53k6j5q4gi6amqnc1y-putty-0.70...
/nix/store/767rqz9lqcriyl53k6j5q4gi6amqnc1y-putty-0.70

Success on aarch64-linux (full log)
Attempted: pkgsCross.mingw32.putty
Partial log (click to expand)
        -lshell32 -luser32
installing
post-installation fixup
DLLPATH='/nix/store/15lkdn4wc30yp0qi7p9zakr5cfcr2i5c-putty-0.70-i686-pc-mingw32/bin:/nix/store/bz5izin8r8h72r3p1vbrgfq90pw9dh67-autoconf-2.69/bin:/nix/store/m6idwq9ysc3fv0y1chrcniwz71ygi5b4-automake-1.16.1/bin:/nix/store/knsignig3d67ylsfy617bnjq36dshhri-halibut-1.2/bin:/nix/store/jri0qzh5f41my6sda8vpj2brn37pjnza-libtool-2.4.6/bin:/nix/store/3175j1w4q33kqkf9x0scg9ixndcgfrcb-gnum4-1.4.18/bin:/nix/store/k15ac8wk8h7r30y6g6z5j6rahc28aanm-perl-5.24.4/bin:/nix/store/9nb3k75y84q4lgjzw52k1sh1i34i7q8j-pkg-config-0.29.2/bin:/nix/store/0gahyl2dnjja8648z17jxf47wlb7vsky-patchelf-0.9/bin:/nix/store/a05f8621chsd3h860v8vfyy0g0wgzy7p-paxctl-0.9/bin:/nix/store/jhs9y3f0gkb11afjpza6a5ppd2h6f06w-i686-pc-mingw32-stage-final-gcc-debug-wrapper-7.3.0/bin:/nix/store/pv9zjzci2jafw36cdb0qml8wsi5hnr2i-i686-pc-mingw32-stage-final-gcc-debug-7.3.0/bin:/nix/store/ssr9dhrp11h4lnr35p05bbqc1ln5004d-coreutils-8.29/bin:/nix/store/ws9x9zlnc52y5qr32rxj6lg7wsywyngf-i686-pc-mingw32-binutils-wrapper-2.30/bin:/nix/store/b3fyjpwhqgpjphcn8dw4v2mzh918glxk-i686-pc-mingw32-binutils-2.30/bin:/nix/store/ssr9dhrp11h4lnr35p05bbqc1ln5004d-coreutils-8.29/bin:/nix/store/ssr9dhrp11h4lnr35p05bbqc1ln5004d-coreutils-8.29/bin:/nix/store/7dvq2phf5520wgn2xqq0hbpq2d5iq82d-findutils-4.6.0/bin:/nix/store/i3vi6bipksggp3y11jf8chv99ac174r5-diffutils-3.6/bin:/nix/store/ms0hpa5af9pgjvkjlac5j07xbs09ssb3-gnused-4.5/bin:/nix/store/hnrdvnnzhrppcxqg14bifnnyy4qy94bf-gnugrep-3.1/bin:/nix/store/khp93ad2sbls28z397kx2k4k7lb786ph-gawk-4.2.1/bin:/nix/store/gncd1vwkz1l16qnvdr09cdvphr5agcz8-gnutar-1.30/bin:/nix/store/m90kmkphajn8pns6a7ypgj284jn6nlwg-gzip-1.9/bin:/nix/store/nm3avgd0n7ipk2xc5s0x5352nylsbhjb-bzip2-<IP_ADDRESS>.1-bin/bin:/nix/store/34x9zwhm2c4s1n8rklsgxc878czxnf26-gnumake-4.2.1/bin:/nix/store/6vqgi9d49smsbr2qxra52yhipg0yxf9f-bash-4.4-p23/bin:/nix/store/zr5252g93sb8yjhc7l67x9ggsarx4cma-patch-2.7.6/bin:/nix/store/p4n73z8l1hyyyybsycwbrdry55xlhxvd-xz-5.2.4-bin/bin'
Created 0 DLL link(s) in /nix/store/15lkdn4wc30yp0qi7p9zakr5cfcr2i5c-putty-0.70-i686-pc-mingw32/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/15lkdn4wc30yp0qi7p9zakr5cfcr2i5c-putty-0.70-i686-pc-mingw32
i686-pc-mingw32-strip is /nix/store/b3fyjpwhqgpjphcn8dw4v2mzh918glxk-i686-pc-mingw32-binutils-2.30/bin/i686-pc-mingw32-strip
stripping (with command i686-pc-mingw32-strip and flags -S) in /nix/store/15lkdn4wc30yp0qi7p9zakr5cfcr2i5c-putty-0.70-i686-pc-mingw32/bin
patching script interpreter paths in /nix/store/15lkdn4wc30yp0qi7p9zakr5cfcr2i5c-putty-0.70-i686-pc-mingw32
/nix/store/15lkdn4wc30yp0qi7p9zakr5cfcr2i5c-putty-0.70-i686-pc-mingw32

Failure on x86_64-darwin (full log)
Attempted: putty
Partial log (click to expand)
mv -f $depbase.Tpo $depbase.Po
./../unix/gtkcomm.c:41:10: fatal error: 'gdk/gdkx.h' file not found
#include <gdk/gdkx.h>
         ^~~~~~~~~~~~
1 error generated.
make[1]: *** [Makefile:1517: unix/gtkcomm.o] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-putty-0.70.drv-0/putty-0.70/unix'
make: *** [Makefile:1095: all] Error 2
builder for '/nix/store/iicjqpk0ls3jic3112zf6vspia0phk6m-putty-0.70.drv' failed with exit code 2
error: build of '/nix/store/iicjqpk0ls3jic3112zf6vspia0phk6m-putty-0.70.drv' failed

At which point Microsoft will hire Nix people?

Haha... well putty is still free software! I want to get to the point where all of the Windows apps I use can be built from Nix expressions

CC @angerman is the bootstrapping still OK (until we can do the C++ stuff at least?)

@zimbatm I’ve got a nsis.nix as well that even builds the crosscompiling version (to run makensis on Linux)

Success on x86_64-linux (full log)
Attempted: putty
Partial log (click to expand)
shrinking /nix/store/8c9j6vvbp35qhav77zgdy5sp7111pp60-putty-0.70/bin/putty
shrinking /nix/store/8c9j6vvbp35qhav77zgdy5sp7111pp60-putty-0.70/bin/plink
shrinking /nix/store/8c9j6vvbp35qhav77zgdy5sp7111pp60-putty-0.70/bin/pterm
shrinking /nix/store/8c9j6vvbp35qhav77zgdy5sp7111pp60-putty-0.70/bin/puttygen
gzipping man pages under /nix/store/8c9j6vvbp35qhav77zgdy5sp7111pp60-putty-0.70/share/man/
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8c9j6vvbp35qhav77zgdy5sp7111pp60-putty-0.70/bin
patching script interpreter paths in /nix/store/8c9j6vvbp35qhav77zgdy5sp7111pp60-putty-0.70
checking for references to /build in /nix/store/8c9j6vvbp35qhav77zgdy5sp7111pp60-putty-0.70...
/nix/store/8c9j6vvbp35qhav77zgdy5sp7111pp60-putty-0.70

Failure on x86_64-darwin (full log)
Attempted: putty
Partial log (click to expand)
mv -f $depbase.Tpo $depbase.Po
./../unix/gtkcomm.c:41:10: fatal error: 'gdk/gdkx.h' file not found
#include <gdk/gdkx.h>
         ^~~~~~~~~~~~
1 error generated.
make[1]: *** [Makefile:1517: unix/gtkcomm.o] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-putty-0.70.drv-0/putty-0.70/unix'
make: *** [Makefile:1095: all] Error 2
builder for '/nix/store/yadkjq4qhgagiivjm0g89dc9x0pxhpxm-putty-0.70.drv' failed with exit code 2
error: build of '/nix/store/yadkjq4qhgagiivjm0g89dc9x0pxhpxm-putty-0.70.drv' failed

@angerman: Based on this comment, would you mind sharing/upstreaming makensis?


Report imperial metrics

obviously, the metric system is better but as someone living in the US it would be nice if there was a config to swap to reporting in Miles and Fahrenheit.
I have started doing this by simply converting units in the queries on my Grafana dashboards but this is a bit of a hassle.

Yeah, that's definitely on the roadmap. I guess most users of this logger would now prefer imperial metrics 😃
My approach would've also been to do the conversion in Grafana itself. We could add a dashboard variable that toggles between both systems.

👍 I will keep slowly adding in conversions then, I'll try to PR some of those dashboards when/if they are more complete.

Okay, cool!

I've had some time to add support for imperial metrics. Please upgrade to the newest version and re-import the dashboards afterwards.


Jobs split followup: create pull request jobs

Followup for #18923.  Create corresponding jobs for pull requests.

Known failures:
https://github.com/grpc/grpc/issues/18637
https://github.com/grpc/grpc/issues/18840
https://github.com/grpc/grpc/issues/18967


Feature: Implement back/forward touch gestures

Would be nice to have horizontal overscroll touchpad gestures for going back and forward, like in Chrome and Edge.
Requirements

Swiping left/right navigates backwards or forwards.
Works with touchpad gestures
Works with touch screen gestures

Also, do you know if the Windows API allows custom touchpad gestures? That is, can you intercept raw finger location data and process it in your own app instead of passing it to the OS?

If you mean the UWP, then I would have to check.

I have spent some time looking into this and it is definitely possible, I already got a touch screen gesture to navigate back and forward. I to get touchpad gestures working as well in the future.

Are we talking like a touchpad Geusture...? Or a button like Win 10 File explorer?

touchpad/touch screen. It say in the requirements of the issue.

Ok. I ask because: 1) I'm new to this place. 2) I know a little HTML to where I could do something to make a back button.
BUT, does anyone know any Javascript commands to encode in an HTML website (for testing) that would involve taking commands from the touch pad/touchscreen?

Files isn't a web site.  Sorry bout that! I thought we were talking similar-to-google-drive type stuff. But Ok. Am I allowed to contribute in HTML files? If so, I might, maybe, be able to do something. I think I'll try to do some C# coding to help. I'd really like to use a new kind of file explorer!

Files doesn't have any HTML content as far as I know.

Alright. I'll leave you alone now. Thanks for the info, though!

Can I be assigned to this?

@quantumfrost thank you for your feedback, we're currently working on implementing this feature.


Is possible call something like: git-plus:pull:current ?

Is possible call something like: git-plus:pull:current ?
thx

Check out #270

Thx, but how to set up in the keymap?

Right now setting up a keymapping isn't possible

You can set up a keymapping for the pull command but you'll still have to select "== Current ==" in the dropdown if you have more than one remote repo.
The command to map to is git-plus:pull or git-plus:pull-rebase


Pin drf requirement to make tests pass

attn: @kavdev

Current coverage is 100% (diff: 100%)

Merging #366 into 1.0.0 will not change coverage

@@           1.0.0   #366   diff @@
===================================
  Files         23     23
  Lines       1536   1536
  Methods        0      0
  Messages       0      0
  Branches     183    183
===================================
  Hits        1536   1536
  Misses         0      0
  Partials       0      0

Powered by Codecov. Last update 0deb3fd...fb4967b

Once this is in I will rebase all of the other pull requests.


[sum-of-multiples] update tests to match common test data

FIX #107
REF exercism/x-common#198

LGTM. Thanks!


Add long_description to setup.py

This PR adds metadata content to rended the README.md for the stratify package on PyPI.
This also involved creating the new repo https://github.com/SciTools-incubator/SciTools-incubator.github.io to host content for the README.md i.e., summary.png, which can be referenced from PyPI.
Closed https://github.com/SciTools-incubator/python-stratify/issues/35

the new repo https://github.com/SciTools-incubator/SciTools-incubator.github.io to host content ..

It does raise the question of whether we should be moving this out of scitools_incubator and to scitools

Looks sensible! Thanks @bjlittle !

@lbdreyer I'd agree with that... in fact we've even got at card on the ESMValTool Project in the TODO column for this :+1:

Coverage remained the same at 96.707% when pulling 1de93f9e3ef774c775f68797fd785e78ee72695c on bjlittle:add-long-description into e75b4eb4ba445c3ea0203469567157062ed24779 on SciTools-incubator:master.


Guildstats.eu format error + Purge error

Re-write branch of course.
I'm not sure what the issue is, just see this in the  log, popping up a lot today:

2018-03-06 13:17:48,848:ERROR: get_guild_online: -IMPORTANT- guildstats.eu seems to have changed their websites format.

Then on the /purge command it initiates the purge, then hits an error:

2018-03-06 13:25:03,246:INFO: Command by Chris (Sinsae) in PM: /purge
2018-03-06 13:25:05,149:ERROR: Exception in command: purge
Traceback (most recent call last):
File "C:\Users\Extat\AppData\Local\Programs\Python\Python36-32\discord\ext\com
mands\core.py", line 62, in wrapped
ret = yield from coro(*args, **kwargs)
File "C:\Users\Extat\AppData\Local\Programs\Python\Python36-32\cogs\owner.py",
line 289, in purge
if char['name'] != row["name"]:
TypeError: 'Character' object is not subscriptable

Help and Thanks!

About the first issue, what command was called exactly? Can you show me some lines before and after that?
About, purge is a function I haven't mantained in a long time, I'm going to rewrite/delete it soon

There are no commands being given to it. It just shows that message in the CMD window approximately every 3 minutes or so. I'm not sure what triggers it.

I also redownloaded the whole rewrite.zip and replaced all files and replaced them, except the data folder. Im receiving the same message.

I have found the issue. It was probably how many people I had it track. on the watchedguild list, I literally added every guild in Amera that it could find. Maybe it was because how many requests it was getting from me?

Fixed the error thrown by /purge, I still wouldn't recommend using this command as it hasn't been mantained in a while. If used, create a backup of the database before use.


Support File-Based SDS at the Ingress Gateway

Just how egress gateway supports file based sds to manage tls certs during ClientTLSSettings config, we should do the same at the Ingress Gateway during ServerTLSSettings creation. This will help us maintain consistency and file based SDS is strictly better than file mounted approach currently in place

cc: @myidpt  @JimmyCYJ  @howardjohn @costinm


⚠ Jenkins Plugins Artifactory has degraded performance

In c1a15e2, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 2497 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 8793fe1 after 25 minutes.


Dawa Edina Hillary - missing region, skills, qualifications, at least one contact option

https://lead.asknet.community/profiles/16-Dawa/

[ ] Update/name Region
[ ] Update Skills & Qualifications
[ ] Provide a public contact info if possible or name another contact/expert

wrote him a message maybe you can follow up @maliarich


changes in landing page

Try making Terms of Use smaller font, less space between lines, Privacy too
(in the phone size)

tested successfully


Improve security on nginx

This PR solves #205
Changes based on https://gist.github.com/plentz/6737338

Hi @guilhermebr — we already have a PR opened for #205. It's the PR #207 we're just holding back because testing thing is production/staging is not feasible until we finish #245. So, once #245 I'll go back to #207 and your PR.
Meanwhile any comments on what #207 missed that you're covering here?

@cuducos Sorry, actually I missed this opened PR.
I saw that last issue message was on Jul 21 and thought that it's an abandoned issue. My fault.
I will close the PR and comment in the opened PR.
By the way, if you need any help in #245 let me know.
Thanks

By the way, if you need any help in #245 let me know.

That'd be awesome. The PR is kind of ready for code review I guess and @anaschwendler and @lipemorais are testing it. The opening post suggest some simple tests to make sure development and production environments. @lipemorais also raised some interesting questions on having two or three config files… if that is your field of expertise we'd really appreciate having your opinion there ; )


Styles are missng for web component

Version
3.2.2
Reproduction link
https://github.com/sherlock1982/hello-world-custom
Steps to reproduce
Just launch yarn serve and open http://localhost:8080/
What is expected?
Both app instances to have same styles. Styles for custom app should be defined in shadowRoot
What is actually happening?
Styles are missing for custom-app component

I created a hello-world app and turned main app component into a web component. Now I expect custom-app web component to be styled exactly how normal app.

I noticed similar problem myself - you can change App.vue to App.ce.vue, then vue-loader should get styles from main component's

I will close it as it's already in the docs and a duplicate.


Question about colors.

Description
I've started work on a pretty cool ASCII design, but before I put the time into finalizing it and assigning colors, I wanted to ask something about colors. The wiki says that you can use ${c1} to ${c6} to color the ascii, and I wanted to know if there was a way to use more than 6 colors in a design? This design is probably going to use around 14, if there is a limit.

[ ] Does this issue still occur in the master branch? (Required if issue)

Neofetch version
Neofetch 7.1.0

https://github.com/dylanaraps/neofetch/issues/1523


Change color of active tab and bar's background by click on tab

Hello!
I have three tabs in BottomBar and I want to change bar color and color of active tab, when I click on third tab, my xml/bottombar_tabs.xml:
<?xml version="1.0" encoding="utf-8"?>
<tabs>
    <tab
        id="@+id/tab_cards"
        icon="@drawable/ic_cards_outline"
        title="@string/cards"
        barColorWhenSelected="@color/white"/>
    <tab
        id="@+id/tab_favorites"
        icon="@drawable/ic_favorite_border_24dp"
        title="@string/favorites"
        barColorWhenSelected="@color/white"/>
    <tab
        id="@+id/tab_tabs"
        icon="@drawable/ic_view_carousel_24dp"
        title="@string/tabs"
        barColorWhenSelected="@color/bar_grey"/>
</tabs>

In layout:
<com.roughike.bottombar.BottomBar
                android:id="@+id/bottom_bar"
                android:layout_width="match_parent"
                android:layout_height="56dp"
                android:layout_alignParentBottom="true"
                android:background="@color/white"
                app:bb_activeTabColor="@color/active_grey"
                app:bb_behavior="shifting"
                app:bb_inActiveTabColor="@color/inactive_grey"
                app:bb_tabXmlResource="@xml/bottombar_tabs"/>

I try to change in onTabSelected color of active tab:
bottomBar.setActiveTabColor(ContextCompat.getColor(this, R.color.yellow)
but it's changed only then I click on next tab and "barColorWhenSelected" doesn't work.
When I comment above line, bar color starts changing.
Can you help me please?

Hi @shmakova !
The readme has some instructions how to customize each tab separatedly.
If I understood correctly, you want to have different active colors for active tabs?
This is how you would do it:
<?xml version="1.0" encoding="utf-8"?>
<tabs>
    <tab
        id="@+id/tab_cards"
        icon="@drawable/ic_cards_outline"
        title="@string/cards"
        barColorWhenSelected="@color/white"
        activeColor="#FF0000"/>
    <tab
        id="@+id/tab_favorites"
        icon="@drawable/ic_favorite_border_24dp"
        title="@string/favorites"
        barColorWhenSelected="@color/white"
        activeColor="#00FF00"/>
    <tab
        id="@+id/tab_tabs"
        icon="@drawable/ic_view_carousel_24dp"
        title="@string/tabs"
        barColorWhenSelected="@color/bar_grey"
        activeColor="#0000FF"/>
</tabs>

In that example, the first tab's active icon and title color is red, the second tab's green and third tab's blue.

Thank you very much!


docs: added software stack document

Signed-off-by: Miquel Sabaté Solà<EMAIL_ADDRESS>

LGTM :+1:


Update for spark 2.2.2 release

Release process for Spark 2.2.2 say to update the test.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/646/
Test PASSed.

Test build #92576 has started for PR 21707 at commit cd9bdca.

Test build #92576 has finished for PR 21707 at commit cd9bdca.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92576/
Test FAILed.

Merged build finished. Test FAILed.

test this please

Test build #92593 has started for PR 21707 at commit cd9bdca.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/658/
Test PASSed.

Merged build finished. Test PASSed.

Test build #92593 has finished for PR 21707 at commit cd9bdca.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92593/
Test PASSed.

@vanzin @gatorsmile

Test build #92759 has started for PR 21707 at commit c0c2613.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/779/
Test PASSed.

Test build #92759 has finished for PR 21707 at commit c0c2613.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92759/
Test PASSed.

retest this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/976/
Test PASSed.

Merged build finished. Test PASSed.

Test build #93040 has started for PR 21707 at commit c0c2613.

Test build #93040 has finished for PR 21707 at commit c0c2613.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93040/
Test FAILed.

oops, branch-2.2 doesn't have the fix yet https://github.com/apache/spark/pull/21779.

retest this please

Test build #93081 has started for PR 21707 at commit c0c2613.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/993/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93081/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1000/
Test PASSed.

Test build #93090 has started for PR 21707 at commit c0c2613.

Test build #93090 has finished for PR 21707 at commit c0c2613.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93090/
Test PASSed.

merged to branch-2.2


Upgrade standard plugins to use org.embulk.spi.json.JsonValue, instead of org.msgpack.value.Value

It upgrades embulk-util-json in embulk-deps along with standard plugins.

Thanks!


[Bug] Bladebit Cuda Command Buffer Full

What happened?
Not sure what causes this error or if it qualifies as a bug, but I don't see any resource constraints, so I'm curious as to what causes the "command buffer" to fill.
Machine Specs:
2x 2690v2
576GB RAM
Nvidia A4000 (16GB)
Final Directory 6TB - (5x SAS 1.2TB in RAID 0)
Command Syntax:
./bladebit_cuda -c  -f  -n 6 cudaplot /mnt/sas/complete
Output example:
Step 2 completed step in 7.18 seconds.
[PlotWriter] Waited 9.900000 seconds for a Command to be available.
[PlotWriter] Command buffer full. Waiting for commands.
[PlotWriter] Waited 11.045000 seconds for a Command to be available.
[PlotWriter] Command buffer full. Waiting for commands.
[PlotWriter] Waited 11.099000 seconds for a Command to be available.
Step 3 completed step in 37.70 seconds.
Version
bladebit-cuda-v3.0.0-alpha1-ubuntu-x86-64.tar.gz
What platform are you using?
Linux
What ui mode are you using?
CLI
Relevant log output
Generating plot 6 / 6: 8809c67a5a54b23507e2adcf04e85e1d907125c0aef1082be2679c611be6f9a6
Plot temporary file: /mnt/sas/complete/plot-k32-2023-02-16-10-51-8809c67a5a54b23507e2adcf04e85e1d907125c0aef1082be2679c611be6f9a6.plot.tmp

Generating F1
Finished F1 in 3.17 seconds.
Table 2 completed in 26.50 seconds with<PHONE_NUMBER> entries.
Table 3 completed in 14.20 seconds with<PHONE_NUMBER> entries.
Table 4 completed in 14.25 seconds with<PHONE_NUMBER> entries.
Table 5 completed in 13.85 seconds with<PHONE_NUMBER> entries.
Table 6 completed in 11.26 seconds with<PHONE_NUMBER> entries.
Table 7 completed in 8.48 seconds with<PHONE_NUMBER> entries.
Finalizing Table 7
Finalized Table 7 in 4.99 seconds.
Completed Phase 1 in 96.71 seconds
Marked Table 6 in 2.64 seconds.
Marked Table 5 in 2.30 seconds.
Marked Table 4 in 2.25 seconds.
Marked Table 3 in 2.24 seconds.
Marked Table 2 in 2.24 seconds.
Completed Phase 2 in 11.66 seconds
Compressing Table 1 and 2...
 Step 1 completed step in 5.35 seconds.
 Step 2 completed step in 5.79 seconds.
Completed table 1 in 11.14 seconds with<PHONE_NUMBER> /<PHONE_NUMBER> entries ( 79.85% ).
Compressing tables 2 and 3...
 Step 1 completed step in 5.22 seconds.
 Step 2 completed step in 7.13 seconds.
 Step 3 completed step in 5.73 seconds.
Completed table 2 in 18.09 seconds with<PHONE_NUMBER> /<PHONE_NUMBER> entries ( 80.09% ).
Compressing tables 3 and 4...
 Step 1 completed step in 5.29 seconds.
 Step 2 completed step in 7.24 seconds.
[PlotWriter] Command buffer full. Waiting for commands.
[PlotWriter] Waited 0.000000 seconds for a Command to be available.
[PlotWriter] Command buffer full. Waiting for commands.
[PlotWriter] Waited 3.732000 seconds for a Command to be available.
 Step 3 completed step in 9.39 seconds.
Completed table 3 in 21.92 seconds with<PHONE_NUMBER> /<PHONE_NUMBER> entries ( 80.70% ).
Compressing tables 4 and 5...
 Step 1 completed step in 5.23 seconds.
 Step 2 completed step in 7.18 seconds.
[PlotWriter] Command buffer full. Waiting for commands.
[PlotWriter] Waited 0.000000 seconds for a Command to be available.
[PlotWriter] Command buffer full. Waiting for commands.
[PlotWriter] Waited 9.900000 seconds for a Command to be available.
[PlotWriter] Command buffer full. Waiting for commands.
[PlotWriter] Waited 11.045000 seconds for a Command to be available.
[PlotWriter] Command buffer full. Waiting for commands.
[PlotWriter] Waited 11.099000 seconds for a Command to be available.
 Step 3 completed step in 37.70 seconds.
Completed table 4 in 50.11 seconds with<PHONE_NUMBER> /<PHONE_NUMBER> entries ( 82.26% ).
Compressing tables 5 and 6...
 Step 1 completed step in 5.18 seconds.
 Step 2 completed step in 7.41 seconds.
[PlotWriter] Command buffer full. Waiting for commands.
[PlotWriter] Waited 0.000000 seconds for a Command to be available.
[PlotWriter] Command buffer full. Waiting for commands.
[PlotWriter] Waited 8.999000 seconds for a Command to be available.
[PlotWriter] Command buffer full. Waiting for commands.
[PlotWriter] Waited 11.190000 seconds for a Command to be available.
[PlotWriter] Command buffer full. Waiting for commands.
[PlotWriter] Waited 11.282000 seconds for a Command to be available.
 Step 3 completed step in 37.39 seconds.
Completed table 5 in 49.98 seconds with<PHONE_NUMBER> /<PHONE_NUMBER> entries ( 86.46% ).
Compressing tables 6 and 7...
 Step 1 completed step in 5.22 seconds.
 Step 2 completed step in 8.19 seconds.
[PlotWriter] Command buffer full. Waiting for commands.
[PlotWriter] Waited 0.000000 seconds for a Command to be available.
[PlotWriter] Command buffer full. Waiting for commands.
[PlotWriter] Waited 8.867000 seconds for a Command to be available.
[PlotWriter] Command buffer full. Waiting for commands.
[PlotWriter] Waited 11.047000 seconds for a Command to be available.
[PlotWriter] Command buffer full. Waiting for commands.
[PlotWriter] Waited 11.247000 seconds for a Command to be available.
 Step 3 completed step in 37.76 seconds.
Completed table 6 in 51.16 seconds with<PHONE_NUMBER> /<PHONE_NUMBER> entries ( 100.00% ).
Serializing P7 entries
[PlotWriter] Command buffer full. Waiting for commands.
[PlotWriter] Waited 10.643000 seconds for a Command to be available.
[PlotWriter] Command buffer full. Waiting for commands.
[PlotWriter] Waited 9.673000 seconds for a Command to be available.
Completed serializing P7 entries in 23.44 seconds.
Completed Phase 3 in 225.85 seconds
Completed Plot 1 in 334.23 seconds ( 5.57 minutes )

/mnt/sas/complete/plot-k32-2023-02-16-10-51-8809c67a5a54b23507e2adcf04e85e1d907125c0aef1082be2679c611be6f9a6.plot.tmp -> /mnt/sas/complete/plot-k32-2023-02-16-10-51-8809c67a5a54b23507e2adcf04e85e1d907125c0aef1082be2679c611be6f9a6.plot
Completed writing plot in 156.39 seconds
Final plot table pointers:
 Table 1:<PHONE_NUMBER> ( 0x000000004ce51efc )
 Table 2:<PHONE_NUMBER>4 ( 0x00000003c1683380 )
 Table 3:<PHONE_NUMBER>9 ( 0x0000000702dd4aaf )
 Table 4:<PHONE_NUMBER>9 ( 0x0000000a4aa86bc3 )
 Table 5:<PHONE_NUMBER>9 ( 0x0000000da2a23bcb )
 Table 6:<PHONE_NUMBER>9 ( 0x00000011265bf9db )
 Table 7:<PHONE_NUMBER>9 ( 0x0000001536e14cc1 )
 C 1    :             4096 ( 0x0000000000001000 )
 C 2    :          1721916 ( 0x00000000001a463c )
 C 3    :          1722092 ( 0x00000000001a46ec )

Final plot table sizes:
 Table 1: 14152.19 MiB
 Table 2: 13335.32 MiB
 Table 3: 13436.70 MiB
 Table 4: 13695.61 MiB
 Table 5: 14395.61 MiB
 Table 6: 16648.33 MiB
 Table 7: 16894.31 MiB
 C 1    : 1.64 MiB
 C 2    : 0.00 MiB
 C 3    : 1228.68 MiB

@bobbyt2012 As far as I know, the command buffer filling is simply indicative of the destination not keeping up with the plotter. In other words, it is waiting to write to the destination. I believe that the [PlotWriter] Waited x.x seconds for a Command to be available. is an indication of IO wait time.

Indeed it is as @Jsewill mentioned.
The buffer is currently of fixed size. It will likely be swapped out and be configurable with a dynamic one during beta, however, you will still hit a wall at the end of a plot even with an increased buffer count if the destination is still slow as you will have to wait for the plot to complete writing. It will also use more RAM as you increase the buffer count for the plot writer.

Are there any new updates on configuration parameters related to the buffer counts? I'm seeing the 'Command Buffer Full' on some of my plotting even to a local NVME drive.


[WebPack 2] URL based WebPack

While thinking about what features would be great for WebPack 2, I just found this:
normalize.io
It has some very cool features like not needing an "asset building" step, being CDN friendly (perfect for sharing between projects), package manager agnostic, flat dependency tree (no de-duping needed), normalized entry points, etc.
Also I just found something released this week, OpenRoss, which is a on-demand URL based image resizer.
I'm inclined to think that on-demand, url based transformation, caching asset building can be one of the big WebPack 2 features.
What is your thought on the matter?

normalize.io seems to be defunct. Perhaps the functionality is better handled in user space?

If you are still interested, could you open a RFC issue describing exact details of how this would work out?


Update akka-stream, akka-testkit to 2.6.10

Updates

com.typesafe.akka:akka-stream
com.typesafe.akka:akka-testkit

from 2.6.8 to 2.6.10.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.akka" } ]

labels: library-update, semver-patch

Codecov Report

Merging #808 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #808   +/-   ##
=======================================
  Coverage   82.80%   82.80%
=======================================
  Files          73       73
  Lines        5404     5404
  Branches      146      146
=======================================
  Hits         4475     4475
  Misses        929      929

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800f5be...10c0796. Read the comment docs.


Unable to download American Dad! on ITV

Using latest version available available on Homebrew and trying to run it from the UK, so should be no geo-fencing:
$ brew info youtube-dl
youtube-dl: stable 2021.3.14 (bottled)

$ youtube-dl --verbose "https://www.itv.com/hub/american-dad/2a4263a0279"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', 'https://www.itv.com/hub/american-dad/2a4263a0279']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.03.14
[debug] Git HEAD: d9d591a
[debug] Python version 3.9.2 (CPython) - macOS-11.2.3-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.3.2, ffprobe 4.3.2, rtmpdump 2.4
[debug] Proxy map: {}
[debug] Using fake IP <IP_ADDRESS> (GB) as X-Forwarded-For.
[ITV] 2a4263a0279: Downloading webpage
[ITV] 2a4263a0279: Downloading JSON metadata
ERROR: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "/usr/local/Cellar/youtube-dl/2021.3.14/libexec/lib/python3.9/site-packages/youtube_dl/extractor/common.py", line 634, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "/usr/local/Cellar/youtube-dl/2021.3.14/libexec/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 2279, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File<EMAIL_ADDRESS>line 523, in open
    response = meth(req, response)
  File<EMAIL_ADDRESS>line 632, in http_response
    response = self.parent.error(
  File<EMAIL_ADDRESS>line 561, in error
    return self._call_chain(*args)
  File<EMAIL_ADDRESS>line 494, in _call_chain
    result = func(*args)
  File<EMAIL_ADDRESS>line 641, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)

You are not using the latest version. If Homebrew doesn't provide the latest version, uninstall now from Homebrew and install the latest version in other ways, curl or pip.
And you should not ignore the issue template.

Issue template - where is that?

Issue template - where is that please?

It seems that you had to be signed in to GitHub first. Then if you click New issue button, the list of categories is shown. Click Get started button and the text form comes with the issue template.
If you click New issue button then sign in via the dialog box, only the blank form is presented.
I guess GitHub mistake.

Been having same problem on Vista & Windows 7.
Suddenly, all bar one episode have now downloaded.
C:\Users\mc\Desktop\youtube-dl_2021.04.26>youtube-dl -f mp4 --no-check-certificate --ignore-errors --restrict-filenames --download-archive youtube-dl-history.txt --add-metadata "https://www.itv.com/hub/american-dad/2a4263a0280" --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-f', 'mp4', '--no-check-certificate', '--ignore-errors', '--restrict-filenames', '--download-archive', 'youtube-dl-history.txt', '--add-metadata', 'https://www.itv.com/hub/american-dad/2a4263a0280', '--verbose']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2021.04.26
[debug] Python version 3.4.4 (CPython) - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg 2021-02-28-git-85ab9deb98-full_build-www.gyan.dev,ffprobe 2021-02-28-git-85ab9deb98-full_build-www.gyan.dev, rtmpdump 2.4
[debug] Proxy map: {}
[debug] Using fake IP <IP_ADDRESS> (GB) as X-Forwarded-For.
[ITV] 2a4263a0280: Downloading webpage
[ITV] 2a4263a0280: Downloading JSON metadata
ERROR: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpeav8wi2f\build\youtube_dl\extractor\common.py", line 634, in _request_webpage
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpeav8wi2f\build\youtube_dl\YoutubeDL.py", line 2279, in urlopen
File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
File "C:\Python\Python34\lib\urllib\request.py", line 508, in error
File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
File "C:\Python\Python34\lib\urllib\request.py", line 588, in http_error_default

https://www.itv.com/hub/american-dad/2a4263a0280: no longer available.


Dead infested larva able to burst

Description
Larvae killed via grenades next to their host are still able to develop, and are able to burst out, but are considered DEAD, resulting in a net loss of 1 for both sides
Reproduction
grenade an infested corpse
Additional context
Witnessed a squad leader's corpse be recovered via grenading the body out of the nest, the larva developed, I was able to take control and burst despite being dead inside the host

CMBaseSpeciesOrganic needs explosion resistance for contents inside of it, like bags and such. In CM throwing a grenade with a larva in a host does no damage to the larva

Cannot reproduce

This should be fixed by #4595 hopefully, since there should now be no way for larva to die within a host when already spawned...hopefully


Update README.md to fix a typo

Fixed a typo

Another straightforward one.
/assign @random-liu

/lgtm
/approve

/cc @vteratipally
Can we get an /lgtm on this?

/ok-to-test
/lgtm
/approve

/test pull-npd-e2e-node


"Confirmation messages are not displayed for 'Add, edit, or update' actions in the application."

Conformation messages gives better User Experience  (UX) and feel

Would that be a big change? If not I'm happy to look at a pull request.

i have created pull request for the issue #1352


[Fix](Row store) support decimal256 type

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Adds proof harness for aws_byte_buf_advance function

Description of changes:

Updates implementation of aws_byte_buf_advance function with pre- and post-conditions;
Adds a proof harness for aws_byte_buf_advance function;

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This PR depends on the #359

@justinboswell @JonathanHenson @ColdenCullen @graebm could you review the changes in byte_buf.h and byte_buf_test.c?

@tautschnig @karkhaz @angelhof @danielsn @markrtuttle could you review the proof harnesses?


New version: goreleaser.goreleaser 1.25.1

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Automated with GoReleaser
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Packages\goreleaser.goreleaser__DefaultSource\goreleaser.exe returned exit code: 1
Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\goreleaser.exe returned exit code: 1
Executable C:\Users\Validator\AppData\Local\Microsoft\WinGet\Packages\goreleaser.goreleaser__DefaultSource\goreleaser.exe returned exit code: 1
Executable C:\Users\Validator\AppData\Local\Microsoft\WinGet\Links\goreleaser.exe returned exit code: 1

(Automated response - build 876.)

@wingetbot waivers Add Validation-Executable-Error

@wingetbot waivers Add Validation-Executable-Error


502 Bad Gateway File Save Error in Cape Town prod, dev sandboxes

Issue
When attempting to save changes to .ipynb files in the Cape Town dev or prod sandboxes, the browser says "Saving started" then produces the error "File Save Error for  Invalid response: 502 Bad Gateway". The browser will then say "Saving failed". The file will not be saved. Any changes since the last save are not captured, and right click>Download only downloads the last saved version of the file.

This issue is localised to the Cape Town sandboxes, Oregon does not display this issue.
Frequency
Most files - intermittent. Error occurs on a daily basis, perhaps for about half an hour at a time, sometimes it will resolve itself temporarily
Some files - consistently refuse to save. See Frequently_used_code/Imagery_on_web_map.ipynb. This is sometimes solved by downloading and reuploading the file (that solution worked for Burnt_area_mapping.ipynb, but does not exclude the file from the intermittent error
The error occurs at different times of day and has no discernible pattern for file name or size. It so far has only affected .ipynb notebooks.
Severity
High, it is not possible to reliably save work, especially problematic at the end of the work day. Not all files will experience the error at the same time.
Steps to recreate (consistent error)

Log into a Cape Town sandbox.
Open Frequently_used_code/Imagery_on_web_map.ipynb.
Make a change (markdown or code, anything).
Press Ctrl+S or the 'Save' button.

Steps to recreate (intermittent error)

Log into a Cape Town sandbox.
Create or open any .ipynb notebook and make a change.
Save the notebook.
Repeat 2,3 until error occurs.

I have a request for the next time this happens, @eefaye and others.
Please open the developer console for your browser, here for Chrome:

And have a look at what is logged there and see if any might be useful.

@cbur24  @eloise-b  @NMoghaddam  @fangfy

Both yesterday afternoon and this morning getting 502 error and autosaving failure in production sandbox.

That one is great, @NMoghaddam. Ping @whatnick and @NikitaGandhi it looks to me like the "cancelled due to load timeout" is an indicator of latency being an issue.
Although, checking in the code at those functions could be interesting. Can you ping me when you have these messages alive in a browser window, @NMoghaddam? We can explore the javascript and see if anything is obvious.

@alexgleith more 502 gateways errors trying to save notebooks.

Anecdotally this issue is happening less on the big instances

Not sure if this is useful but it seems a notebook without output is saved automatically. Once the notebook if evaluated, I get a 502, probably because it's much bigger with images.


chore: use monocart-coverage-reports

Let’s use monocart-coverage-reports to process V8 coverage data.

It is worth to wait for https://github.com/codacy/codacy-coverage-reporter/issues/506


NTR: c-di-GMP-mediated signaling and related others

Hello:
I recently submitted two NTRs for "response to c-di-GMP" and "cellular response to c-di-GMP". On looking into this further, I now think we need additional GO terms to more fully describe this process. c-di-mediated signaling is a significant signaling pathway in bacteria and has been recently identified in Dictyostelium, and I'm now starting to encounter papers fleshing out some of the actors involved. So I would like to request 4 new GO terms:
c-di-GMP-mediated signaling
regulation of c-di-GMP-mediated signaling
positive regulation of c-di-GMP-mediated signaling
negative regulation of c-di-GMP-mediated signaling
I am including here only the definition and information for the first term, c-di-GMP-mediated signaling, as I assume it is straightforward for you to create the remaining 3 as children of this term as found in numerous other signal transduction terms. But of course let me know if you would like me to provide further information.
Thanks,
Bob Dodson
Name: c-di-GMP-mediated signaling
Ontology: biological_process
Synonyms: cyclic diguanylate-mediated signaling; 3',5'-cyclic di-GMP-mediated signaling; cyclic di-(3':5')-guanosine monophosphate-mediated signaling; cyclic di-GMP-mediated signaling
Alternate IDs: None
Child of:  GO:0019935: cyclic-nucleotide-mediated signaling
Definition: Any intracellular signal transduction in which the signal is passed on within the cell via cyclic di-GMP (c-di-GMP). Includes production of c-di-GMP, and downstream effectors that further transmit the signal within the cell.
References:
PMID: 23471616	Cyclic di-GMP: the first 25 years of a universal bacterial second messenger.
PMID: 22864416	The prokaryote messenger c-di-GMP triggers stalk cell differentiation in Dictyostelium.
PMID:28057864   Adenylate cyclase A acting on PKA mediates induction of stalk formation by cyclic diguanylate at the Dictyostelium organizer.

Hi Bob,
I think we do need this term. Looking over the paper, I'm not sure that it fits as a child of cyclic-nucleotide signaling because that process is necessarily intracellular. From the paper, it seems that the c-di-GMP signaling is a a true signaling cascade where the c-di-GMP is the signal that acts on some type of receptor. The c-di-GMP signaling then activates cAMP-mediated signaling (on already existing adenylate cyclase) and in turn activates PKA signaling.

I was planning to curate the genes: dgcA, ACA, and PKA, shown in Fig. 7 with "c-di-GMP-mediated signaling" as I interpret these as being the genes actively involved in signaling. Fig. 7 also includes "stalk genes" and these are the genes mentioned in the previous paragraph (staC, etc.) which I interpret as being a downstream effect of the signaling process.

I'm not sure about this. dgcA is the enzyme that generates the c-di-GMP, so it is upstream of the signaling. Then depending on where you slice the signaling pathway (where it ends), ACA and PKA could either be a part of the signaling or downstream of it. I'm pinging @pgaudet here because she is working on the GPCR signaling pathways as part of the signaling project and I'm not sure how the cAMP stuff fits in with her current thoughts. But whatever we decide to do, it should be parallel. Do you have any idea whether the c-di-GMP activates a GPCR?

Hi David:
Thanks for your response. Agreed that dgcA should not be included, that is, should not be annotated with c-di-GMP-mediated signaling, as it generates the signaling molecule.
And I was also wrong about the nature of this signaling and the correct parent for this term. dgcA is found in the cytosol, so I was assuming that this was an intracellular signaling cascade, but on checking again it is clearly noted that c-di-GMP is a secreted signal. As for a receptor, there are only two relevant papers (that I'm aware of at least): this one, PMID:28057864 and PMID: 22864416, and neither has results or even speculation on a possible receptor, and no mention of a GPCR.
Hope we can get Pascale's input as well, both for the dicty biology and her recent work on signaling.
Thanks,
Bob

OK. My model is getting really complicated, so we might want to go over it together at some point. I'm bringing in the specification, determination, commitment and development aspects of cell differentiation. It might be fun to discuss this with @vanaukenk when she gets back. She and I have had looooong discussions about the nature of the cell fate commitment terms. This might be a nice example. The terms are based on classical experiments in developmental biology and we have discussed how those translate into molecular mechanisms.

OK, I see the model. And yes, it is getting complicated...this would have taken me days or longer to flesh out! It's getting late here (Madrid), so I'm not prepared to wade into this right now, but I'll have a look in the next few days and see if I can offer any constructive feedback.
Petra is coming here after the London GO meeting and it might be good to discuss this along with her as well, as her knowledge of dicty Biology is more extensive than mine. Problem is I'll be out a bit in late October, so our overlap time won't be so extensive. How about if we pencil in early October, right after the meeting and try to schedule a time to discuss? Or even during the meeting. I won't be there, but could Skype with you, Kimberly and Petra then if that works.

Hi Bob,
Yes. I'm sorry that the model is so complicated. Maybe we should make a simpler one, but I went down the path of thinking about how all of this relates to the big picture of developmental biology in GO. I tend to do that a lot in GO-CAM models. Maybe we should make a more basic model to try to get out the core annotations that you would have made conventionally. Do you want to try to do that?
I'd love to discuss this because it is something that I have been thinking about for years.
In the meantime, I will create the signaling term and the regulation terms. Since there has been no receptor identified, perhaps I should go a level up for the parent? Then we can move it as the pathway is further elucidated.
-D

Hi David:
I took a look at your model today and have just a couple of comments, one specific and one general.
Specifically, the adenylate cyclase activity in this paper is enabled by dicty gene acaA, which is UniProt:Q03100. I tried to add it, but it didn't show up as a selection choice. Not sure why not.
More generally, we typically don't use the three GO process terms: GO:0045165 cell fate commitment, GO:0001708 cell fate specification or GO:0001709 cell fate determination in curating dicty genes at dictyBase, although your use of them here certainly seems intuitively correct. There are a just a handful of dicty genes curated with these GO terms, but w/o having checked into them I suspect they are wrong-or at least contrary to our practice.
We typically use the GO process terms: GO:0031149 sorocarp stalk cell differentiation and GO:0031150 sorocarp stalk development. And when I select the graph or inferred tree views of these two terms, neither of the 3 above GO terms show up in the displayed results. Note that the GO term GO:0030154 cell differentiation does, and is a parent of these two.
So if these 3 terms are not related to our sorocarp stalk terms, then maybe they should not be used in the model? Or maybe that doesn't matter at all, and you did after all specifically want to bring them in here. Anyway, this is all just a suggestion for what it's worth, at this point I'm not sure what's best. I guess input from Kimberly, Pascale and Petra would help.
Thanks,
Bob

Hi David:
Sorry, we crossed messages here. I was looking at the model and had this page open, and responded w/o refreshing the page, so I didn't see your latest response.
In that case, then yes, I'll try to make a more basic model based on your template, and using some of the suggestions that I just made. I'll start from scratch so as not to mess up your model. Won't be quick-I'm new at this and it takes me longer to think it through and just deal with the mechanics of LEGO. But I'll let you know when I've "finished" or am at least ready for you to review it.
Thanks,
Bob

OK. I made this term and the regulation ones to help you in making the GO-CAM model.
+id: GO:0061939
+name: c-di-GMP-signaling
+namespace: biological_process
+def: "Any process that mediates the transfer of information from one cell to another using c-d-GMP as the signal." [PMID:22864416, PMID:28057864]
+synonym: "3',5'-cyclic di-GMP signaling" EXACT []
+synonym: "cyclic di-(3':5')-guanosine monophosphate signaling" EXACT []
+synonym: "cyclic di-GMP signaling" EXACT []
+synonym: "cyclic diguanylate signaling" EXACT []
+is_a: GO:0007267 ! cell-cell signaling
+created_by: dph
+creation_date: 2017-09-14T18:59:04Z
I am very tempted to make is a child of 'cell cell signaling involved in cell fate commitment', but if we add the commitment term in the model it should be generated automatically. Let me know if what I have done isn't isn't ok with you

Also see #14175

Hi David:
I've worked a bit on a simpler c-di-GMP signaling model over the last few days and am probably ready for feedback from you. It's here:
http://noctua.berkeleybop.org/editor/graph/gomodel:59bee34700000000?barista_token=4ma3kza1t1if3mpows5g#
I have a number of questions, but a couple of quick things to note here:
-this is one of my first models, so I'm pretty new at this; this model is probably how I'd do it, but that doesn't really count for much-especially given the potential breadth and complexity of this model
-many of my questions are about the proper relationships (including correct directionality) between annotons, so any suggestions there, or more documentation in the Curation Documentation would be welcome.
-I've now dropped my previous objection to the use of cell fate commitment, cell fate determination, etc. GO terms, and now agree that these are what ties this in with broader developmental biology. That said, I'm not so familiar with these terms and which are best to use here.
Anyway, let's start there and we can discuss further on this ticket, or on a call if you'd prefer.
Thanks,
Bob

Hi Bob,
Two quick questions/comments.

Why didn't you use the new signaling term?
The cell differentiation part_of stalk cell differentiation is puzzling to me.

I think we should try to have a look at this together on a call. Hopefully with @vanaukenk
It might not happen until after the meeting.

Hi David:

I didn't use the new term because I didn't see it as available through the tool. And I still don't. I tried searching both for text and the GO term id, but not seeing it. Am I missing something?

I guess this reveals my ignorance. How would you suggest to relate these two? Or would you simply not use these two BPs in this way at all? As noted previously, when curating dicty in protein2GO I typically just use GO:0030587 sorocarp development and it's children so my experience is limited with these broader terms.

I'm happy to discuss with you and Kimberly whenever convenient. As noted, if after the meeting Petra will be here so might be better to do then anyway as her knowledge of dicty biology is much more extensive than mine.
Thanks,
Bob

@ukemi  did you get our email to discuss the larger issues here?
We suggest early next week either
Monday 10/16 before and/or ending at 11 AM EDT or
Tuesday 10/17 before and /or ending at 10 AM EDT
Thanks!

Hi David:
Just requesting a simple revision to the definition here.
+def: "Any process that mediates the transfer of information from one cell to another using c-d-GMP as the signal."
Should be: "c-di-GMP" instead of "c-d-GMP"
Thanks,
Bob

@ukemi
I discussed the extracellular presence and action of c-di-GMP with the person who is working on this and published.
She said the strongest evidence that c-di-GMP acts extracellularly currently comes from the fact that the dgca- phenotype is non cell autonomous and can be rescued by mixing with wild-type and by adding c-di-GMP. They are still hunting for receptor and we also discussed that Dicty has a ton of ABC reporters to export from the cell.
That said, I sent her the term (GO:0061939) you added and she approved of the term and definition.
Bob and I updated our CAM model quite a bit and used some different relationships consulting the RO. Maybe you can look at that at your convenience
http://noctua.berkeleybop.org/editor/graph/gomodel:59bee34700000000?barista_token=atdltkzmcjdzpgn1byyr
Also, since there seems no real evidence for c-di-GMP signaling in higher organism, and the expert who is also an evolutionary biologist said (and published) that from phylogenetic evidence it seems obvious that DgcA entered Dictyostelia by horizontal gene transfer from bacteria (but then no other bacterial components are present in Dictyostelia).
So for now at least, maybe we cannot tie this into a larger, general pathway. Let's wait for more publications down the road and revisit.
Unless we made big mistakes in our model, we don't need to discuss this further at this point.
Thanks!
cc
@rjdodson

Thanks all. Sorry it took so long to get back to you. I was swamped all last week. I fixed the typo and am closing this issue. We might want to discuss this model on a call at some point.


Only show Escalate button if Slack is ready

Integrate the new field isSlackReady from the Platform API, so the Escalate button only shows up if the Slack's organization is already set up.

Unassigned myself from this PR. Once merged, I'll handle the review/release for Stateful (as opposed to Runme).


Impose requirements on descriptors from spirv image types

Fixes #762, and lays a lot of groundwork for other image usage validation that @tobine has wanted for a while.

+1

Updated and pushed to master.


[INTERNAL] stringReplacer: Replace using string instead of stream

This allows the processor to only modify a resource if necessary (as in,
a replacement has been applied). Currently, in a standard library build,
this processor is for example the only one to modify JSON files.
However, they often do not contain any of the searched placeholders.
https://github.com/SAP/ui5-fs/pull/472 will enable optimizations for
unmodified resources. So we strive for reducing unnecessary resource
modification across the whole tooling.

Coverage: 94.609% (+0.002%) from 94.607% when pulling 488814a24b95ff7748b0160575ca59f5c586d85e on unstream-stringReplacer into 6eda9f69f2de77a9d16bc84390634335483abe90 on main.


Resume video on setup screen wakeup

Purpose

Resume video on setup screen wakeup

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Steps to test:

Click "Start new call"
Turn on Video by clicking video toggle button
Go to Mobile home screen "let application to go in background mode"
Reopen application
Expected behaviour: Video should be displayed on Setup screen

Code tested

Code tested