Failed at install time with 'editions are unstable'

I get a:
 cargo install wireguard-vanity-address
    Updating registry `https://github.com/rust-lang/crates.io-index`
 Downloading wireguard-vanity-address v0.4.0
error: failed to parse manifest at `/home/stratos/.cargo/registry/src/github.com-1ecc6299db9ec823/wireguard-vanity-address-0.4.0/Cargo.toml`

Caused by:
  editions are unstable

Caused by:
  feature `edition` is required

this Cargo does not support nightly features, but if you
switch to nightly channel you can add
`cargo-features = ["edition"]` to enable this feature

Not being very familiar with Rust, and failing to find a google solution, how would I proceed fixing this?
Thanks!

hm, what version of rust/cargo are you running? (cargo --version). I'm guessing it's fairly old, and doesn't understand the "edition" keyword (which was added in 1.31, released in december 2018).
I'm not exactly sure what our "MSRP" (Minimum Supported Rust Version) is. We're running CI against rust-1.41, and the current release is rust-1.42, so it at least works on those. I just ran tests locally against rust-1.37 and that seemed to work too. From what I've seen, a lot of people are always using the most recent stable release of rust (there's a new one every six weeks), so it takes a bit of deliberate effort to establish and maintain an MSRP, and it's easy to get kind of careless and accidentally require newer features.
I'm using rustup to keep my rust up-to-date, and I think rustup is also the recommended way to install rust in the first place. If you're using rustup then maybe you just need to ask it to upgrade your installation: rustup update. If not, maybe the easiest path is to install it.. the instructions are at https://www.rust-lang.org/learn/get-started .
Let me know how it goes!

I had rust/cargo installed with pacman (in arch) and I though that it will be always kept updated to latest version (I regularly update with pacman).
Nonetheless, running rustup update seems to have updated to something more recent and now I can install fine.
Thanks...

great!


Version 2.8.0 doesn't include all changes

Version 2.8.0 claims to include pull request #1115. Although the code was merged to master on Sep 23, it is not part of the release.
Pls recreate the release

@cpeer you're corretct. Seems like I forgot to downmerge that PR to 2.8. I just did it so It'll be available in 2.8.1

@marcosnils lovely, thx. When will 2.8.1 be available?

@cpeer most likely sometime this week.


Access to body request

Hi.
I use hot chocolate with .net core 3.1
I haven't problem is a classic web api to access to body request:
Here code:
 context.Request.EnableBuffering();
 await _next(context);

 var bodyStream = new StreamReader(HttpContext.Request.Body);
 bodyStream.BaseStream.Seek(0, SeekOrigin.Begin);
 string  bodyText = bodyStream.BaseStream.Length == 0 ? null : bodyStream.ReadToEnd();

But in a graphql hot chocolate query method I've body to null.
How can I solve?

I've solved but I can have access to body only in specific middleware and not in graphql queries.
I've solved storing bodystring into context item
    public async Task Invoke(HttpContext context, IConfiguration configuration)
    {

        //enable request body access
        context.Request.EnableBuffering();

        var stream = context.Request.Body;

        using (var reader = new StreamReader(stream))
        {
            var requestBodyAsString = await reader.ReadToEndAsync();

            context.Items["Body"] = requestBodyAsString;

            if (stream.CanSeek)
                stream.Seek(0, SeekOrigin.Begin);

            await _next(context);

        }

    }


Comment in CSS breaks production build / TypeError: foo.js: Property value expected type of string but got null

With my current Babel 7 / TypeScript 3 instance of NextJS (latest canary), I ended up with this production build error while dev worked fine:
TypeError: foo.js: Property value expected type of string but got null
The culprit was a commented line of CSS:
// top: -${slope - 1}px;
Once I removed the comment, the build went through just fine. I'm not even sure this is a bug or a peculiar "feature" of Babel or one of its components. But I thought I add it here so others can find it.

Hmmm, the issue isn't really clear to me personally. What version of styled-components and babel are you using? Can you provide an example git repo so we can take a look?

This is a known issue AFAIK.
Multiline comments will work since stylis understands them. Single line comments however only work when they don't contain interpolations currently

Not sure if it is a known issue, but it's easily reproduceable: add a single line comment to an interpolated css attribute, e.g.
  // max-width: ${theme.breakpoints[1]};
and you'll get
TypeError: Property value expected type of string but got null
when building for prod with Babel 7.0.0 and styled-components@latest using a .babelrc config like this:
     "plugins": [         [           "babel-plugin-styled-components",           {             "ssr": true,             "displayName": false,             "preprocess": false,             "minify": true           }         ]       ]

Single line comments cause issues with interpolations yes. I recommend
using /* style */ comments for the time being
On Tue, Aug 28, 2018 at 2:41 PM Oliver Studer<EMAIL_ADDRESS>wrote:

Not sure if it is a known issue, but it's easily reproduceable: add a
single line comment to an interpolated css attribute, e.g.
// max-width: ${theme.breakpoints[1]};
and you'll get
TypeError: Property value expected type of string but got null
when building for prod with Babel 7.0.0 and styled-components@latest
using a .babelrc config like this:
"plugins": [ [ "babel-plugin-styled-components", { "ssr": true,
"displayName": false, "preprocess": false, "minify": true } ] ]
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/issues/1949#issuecomment-416715030,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiy1jwZP7L5AOOO_o2AGVbVuN9kCakXks5uVZzagaJpZM4WMlrn
.

@genox Should be fixed if you upgrade babel-plugin-styled-components to 1.6.0


App crash while rotating device screen

Hii, first of all I love this app so much. For me, its the best screen mirroring app that I have ever tried.
But, I want to report my problem, maybe someone can help. If i start scrcpy with my device rotation is horizontal, then the app will crash if i rotate it to vertical, and it happens the otherwise.
I have tried different pc, cable, devices, and the result are same.

Do you have any logs in the console?
In the output of adb logcat when it crashes?
Does the device still appears as connected in the output of adb devices after the crash?

Hi thanks for your help, i found the problem sir. This problem occurs when i use the scrcpy as game capture for live streaming app. And it runs like normal if the scrcpy runs itself without being game captured by the live streaming app.
After crash, i must restart the cmd to run scrcpy again. And the device is still connected "adb devices".

Yeah, same here.

Fault Module Name: graphics-hook64.dll

It seems this library is related to OBS.

So how can i fix it sir

I guess you should report the problem on OBS forums, maybe they know a solution/workaround.
(FYI, I tested on Linux, it works fine, even when I rotate the device.)


Release v3.0.0

Demo
Docs
TODO

merge https://github.com/vitessce/vitessce/pull/1522 and pull in to include in this release

Checklist

[ ] Ensure PR works with all demos on the dev.vitessce.io homepage
[ ] Open (draft) PR's into vitessce-python and vitessce-r if this is a release PR
[ ] Documentation added or updated

docs: http://vitessce-data.s3-website-us-east-1.amazonaws.com/docs/2023-05-26/6b5d759f/
demo: https://s3.amazonaws.com/vitessce-data/demos/2023-05-26/6b5d759f/index.html

Demo: https://s3.amazonaws.com/vitessce-data/demos/2023-05-26/1f030acf/index.html
Docs: http://vitessce-data.s3-website-us-east-1.amazonaws.com/docs/2023-05-26/1f030acf/

Discovered https://github.com/vitessce/vitessce/issues/1566 while testing but i do not think it should necessarily block the release

Demo: https://s3.amazonaws.com/vitessce-data/demos/2023-05-31/8e1d7445/index.html
Docs: http://vitessce-data.s3-website-us-east-1.amazonaws.com/docs/2023-05-31/8e1d7445/

Seems like the initial position in Safari is not working in demo but does seem to work in the docs.  This seems like a regression compared to dev.vitessce.io

Thanks, thats a strange one, seems to do with the timing of the react-grid-layout initial animation https://github.com/vitessce/vitessce/pull/1571

Demo: https://s3.amazonaws.com/vitessce-data/demos/2023-06-02/d5d3a3ea/index.html
Docs: http://vitessce-data.s3-website-us-east-1.amazonaws.com/docs/2023-06-02/d5d3a3ea/


YAML changelog includeAll does not respect errorIfMissingorEmpty default false value

Environment
Liquibase Version: 4.3.5
Liquibase Integration & Version: CLI
Liquibase Extension(s) & Version:
Database Vendor & Version: Oracle
Operating System Type & Version: Windows and Linux
Description
If YAML master changelog an includeAll tag references a path that does not exist the error is thrown despite default for errorIfMissingorEmpty is false. Setting it explicitly to false also does not solve the problem.
Steps To Reproduce

Create a master-changelog.yaml file which references a directory that does not exist. For example:

databaseChangeLog:
  - includeAll:
      path: 075/

Run an update
liquibase --changelogFile=master-changelog.yaml update

Actual Behavior
An error is thrown
Unexpected error running Liquibase: Could not find directory or directory was empty for includeAll '075/'
For more information, please use the --logLevel flag

Expected/Desired Behavior
Update should be executed successfully
I've also noticed that putting
errorIfMissingorEmpty attribute in XML is not recognized anymore resulting in
Attribute 'errorIfMissingorEmpty' is not allowed to appear in element 'includeAll' error but this might be another issue.

Hi @nadarian Thanks for providing a very simple and elegant recreation scenario.  I was able to copy and paste your changelog and recreate the issue.
As a simple workaround you can use set the errorIfMissingorEmpty value like this until we are able to fix this.
databaseChangeLog:
  - includeAll:
      path: 075/
      errorIfMissingOrEmpty: false

We will add this to the issues we are processing.

The problem is that yaml/json/parser-code default to "true" for errorIfMissingOrEmpty in DatabaseChangeLog line 413, but xml has "false" as the default in the XSD, so that overrides the underlying default.
I can easily make that default change for yaml/json/custom, but that is going to be a change in behavior for anyone who is expecting includeAll to fail if the directory doesn't exist since that is how it has always worked.
So I think that at least needs the MajorRelease label with a "breaking change" notice in the release notes.
ALTERNATELY: I could take the default=false setting out of the 4.5.xsd which would bring XML in line with what yaml/json does, starting with anyone using the 4.5.xsd. This makes it more of a "when they are making a new file" type change, but would still be a behavior change for XML users.
I tend to think that from a usability standpoint, it should fail if the requested path doesn't exist rather than silently continue. People get confused when they ask for something and think it should work but they just have a typo or something. In that case, the bug is really in xml.
Thoughts?

NOTE: the errorIfMissingOrEmpty attribute was working for me in yaml, so this issue is purely about matching the defaults in yaml/json vs. xml.

After discussing the issue, we decided that it is better to fix XML to default to errorIfMissingOrEmpty="true".
I created #1960 to track that change.


[SPARK-41180][SQL] Assign an error class to "Cannot parse the data type"

What changes were proposed in this pull request?
This pr aims rename _LEGACY_ERROR_TEMP_1227 to INVALID_DATA_TYPE_SCHEMA
Why are the changes needed?
Proper names of error classes to improve user experience with Spark SQL.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions

@LuciferYang Could you resolve conflicts, please.

two test case failed, will fix later

+1, LGTM. Merging to master.
Thank you, @LuciferYang.

Thanks @MaxGekk


Code First: Per-entity configuration via structural static method

Consider allowing a method like:
public static void Configure(ModelBuilder modelBuilder) {}
to be defined on model types so that:

Model config can be encapsulated
Internal members can be addressed symbolically.

Closing this as we already have other patterns for doing this and there doesn't seem enough value to add a new one.


Fix a bug on adding to a list

This commit adds a empty string substitution when adding
items to the end of a list to fix a bug observed while adding
a new policy version with an empty string.

Coverage remained the same at 53.405% when pulling b11156969697d2a72ef48c20a8a3552b5486ed7b on fix-bug-in-add-list into 91d1dc10dbbb07b3235bede64a5c694f2ef6d08f on master.


Add Chisel to start-herb.sh

@mklingen confirmed in #23 that Chisel currently runs in the background and needs modification, to add enable/disable service calls, before we should run it by default.

It has a "TogglePause" service. The only change needed would be a ros param in the chisel server that tells it whether to start paused or not. The other option is to start pasued, never unpause, and instead write some kind of service call to generate a mesh instead.


Workaround for QUARKUS-3315 Productise quarkus-jms-spi-deployment artifact

Suppressed by https://github.com/jboss-fuse/camel-quarkus/pull/243


bad CPU type in executable: /usr/local/bin/CoreLocationCLI

Did a brew upgrade CoreLocationCLI and received the error.  I removed and did a brew install cask corelocationcli with same results.
MacBook Pro (13-inch, 2018, Four Thunderbolt 3 Ports)
2.3 GHz Quad-Core Intel Core i5
Thanks

I have the same issue. This did work on my M1 MacBook Pro, but it failed on my Intel-based Mac
MacBook Pro (16-inch, 2019)
2.4 GHz 8-Core Intel Core i9

~ > brew ls corelocationcli
==> Binary
/usr/local/bin/CoreLocationCLI -> /usr/local/Caskroom/corelocationcli/4.0.0/CoreLocationCLI (98.9KB)

~ > file /usr/local/bin/CoreLocationCLI
/usr/local/bin/CoreLocationCLI: Mach-O 64-bit executable arm64

~ > uname -rsm
Darwin 21.5.0 x86_64

Easiest workaround: compile it for your current machine. Download the repo, unzip, and then run swift build -c release from the root folder. The binary will be available in the hidden folder ./.build/<arch>/release. You can optionally move the binary to a location in your PATH. It requires XCode, obviously.

Wondering why the official package is not build as a universal binary for both architectures. I ran into the same issue and setup as a workaround my own homebrew tap and compiled it with swift build -c release --arch arm64 --arch x86_64. Hope the upstream homebrew cask will be universal at one point. Intel Macs are not going away anytime soon.

CoreLocationCLI.zip
I just ran this and got this executable. Any good?

Also I can't find any documentation for these --arch flags. But it seems straightforward enough. Happy to support universal builds if this works.

Looks like still a arm64 binary only.
marco@loop ~/Downloads> ./CoreLocationCLI
exec: Failed to execute process '/Users/marco/Downloads/CoreLocationCLI': Bad CPU type in executable.

marco@loop ~/Downloads> lipo -info CoreLocationCLI
Non-fat file: CoreLocationCLI is architecture: arm64

When I run it on the one I compiled.
◆ corelocationcli git:(main) ❯❯❯ lipo -info .build/apple/Products/Release/CoreLocationCLI
Architectures in the fat file: .build/apple/Products/Release/CoreLocationCLI are: x86_64 arm64

I don't know where the options are in the official documentation. I found it here.
https://developer.apple.com/forums/thread/667440
https://liamnichols.eu/2020/08/01/building-swift-packages-as-a-universal-binary.html
Also read somewhere that you can change something in Xcode, but could not figure out what to do in Xcode that it spits out a universal binary.

Trying a new approach. Please see
https://github.com/fulldecent/corelocationcli/releases/tag/4.0.2
https://github.com/Homebrew/homebrew-cask/pull/136269

@fulldecent, version 4.0.2 works perfect. :-)
@mayurankv, not sure what you exactly mean. My repo is here and it has some description. Does that answer your question? https://github.com/mschirrmeister/homebrew-corelocationcli

I was just wondering how to replicate the same self-maintained tap but 4.0.2 works great for me (up to the location privacy issues mentioned in another issue) so no need anymore. Thanks so much for the speedy responses!

On that note, this thread can be closed no?

Thank you, the new released versions have all been multi-arch since 4.0.2


Combine crn

Merge of #307 and #313
NB: changed base to main since now more closely related to that than #307

Closed by #392


Glob without resolving

Hi, I have a question about "resolve". I just want globbed files. I thought, this will work:
require('./includes/*.js', {mode: 'expand'});
but internally it will use default resolve functions ["path-reduce", "strip-ext"]. If I dont want to use any resolving function I need to write my own resolve function, i.e: resolve:(base,files)=>files, or simply use empty array [].
require('./includes/*.js', {mode: 'expand', resolve:[]});
require('./includes/*.js', {mode: 'expand', resolve:(base,files)=>files});
My questions:

is empty array a hack? I think it should return defaults.
what is the correct approach to omit any resolving functions

Thanks in advance

I think both options are valid. I decided on the current default because I thought that would be the most-wanted behaviour. Your solutions to circumvent that both seem valid to me. Personally I'd prefer the empty array in your case, because it more accurately fits what you want (no resolvers)


Delete the parameter "--google-json-key string"

Delete the parameter "--google-json-key string"

This change is

@chenhuan12 Can you elaborate on why that flag option is being removed? Is it no longer supported? If so, can you point to a Kubernetes issue # or pull request # where that is mentioned? Thx

“# kube-prxoy -help”can not find --google-json-key option
# kubectl version
Client Version: version.Info{Major:"1", Minor:"5", GitVersion:"v1.5.1+82450d0", GitCommit:"f5ef9802914a47c848fd84c287333f8b4d28bbc1", GitTreeState:"dirty", BuildDate:"2017-01-23T00:04:39Z", GoVersion:"go1.7", Compiler:"gc", Platform:"linux/amd64", USEEVersion:"V1.02.01_alpha", USEEPublishDate:"2017-1-10 00:00:00"}
Server Version: version.Info{Major:"1", Minor:"5", GitVersion:"v1.5.1+82450d0", GitCommit:"f5ef9802914a47c848fd84c287333f8b4d28bbc1", GitTreeState:"dirty", BuildDate:"2017-01-22T23:56:57Z", GoVersion:"go1.7", Compiler:"gc", Platform:"linux/amd64", USEEVersion:"V1.02.01_alpha", USEEPublishDate:"2017-1-10 00:00:00"}

@pwittrock Do you know what the deal is w/ --google-json-key for kube-proxy? Is that flag just hidden from kube-proxy -help? Who should I ask?

@yujuhong is this something you know about?

/cc @kubernetes/sig-network-misc

I have no idea what this flag was or why it was documented :)

It looks to be defined in pkg/credentialprovider/gcp/jwt.go, not sure why it would be in kube-proxy...

@thockin So it's definitely okay to remove then, right?

I think so - it's not part of the current help text


[Docs]: Editing the Licenses section of readme and adding MIT Licenses badge

what's wrong in the documentation?
The Licenses section of readme should not be this way. It looks unprofessional. I can edit it and add some more text and the MIT License badge to make it look more professional. "This Community is Licensed under MIT license." -> communities are not licensed, software are!
Add screenshots

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I am a GSSoC'23 contributor

Please assign me this issue under GSSoC'23


deploy with passenger + ngnix

Can anyone help with this problem http://stackoverflow.com/questions/34810587/faye-rails-ngnix-passenger-slow-responce-from-faye ?

Me too have the same issue.

Me too

Me too. Anyone ever get passenger + nginx to work?


FIX use variant return type for org.freedesktop.DBus.Properties.Get

I could never get any properties through the org.freedesktop.DBus.Properties.Get method, because the property needs to be wrapped in a variant according to spec. I assume this is a bug.

Thanks @miniME89 !
Maybe if you can look at org.freedesktop.DBus.Properties.Set as well that would be great :) It the moment don't have very much focus on this libraray, hope to start paying more attention after finish som other things

yea, saw that unfinished setter, but luckily i dont need that :)
But i needed a proper handling of emitting the PropertiesChanged event which your code doesn't include yet. I therefore implemented in my project a setter for the properties which emits this signal (see here. I could maybe provide you with some code for that missing part.

you should be able to do serviceImple.emit('signalName', signalData) to emit dbus signals - see https://github.com/sidorares/node-dbus/blob/dc4593f6a967001049d8e887fb720bcf1bdab36c/lib/bus.js#L205-L233

it reads signature from iface description, maybe we need to merge all standard interfaces by default so that 'PropertiesChanged' is known and 'sa{sv}as' signature is used automatically


Feature request

Amazing work. Thank you!
Could you make option for the side bar to be on one of the sides (right or left) ?

Hi, thanks! Yes, as soon as I have time I will definitely do that!

Awesome!

Hi, thanks! Yes, as soon as I have time I will definitely do that!

Could you add a shortcut to turn on/off the sidebar, thx？

Done!


datePickerPopup datepicker-options two way binding problem with start Mode

Hi!
I have a problem with datepickerPopup and datepicker-options.
In my page there are n datepickers generated by ng-repeat:
<div class="datepicker datepicker-popup">
	<input class="form-control" readonly="" type="text"
	name="date[$index]"
	show-button-bar="false"
	ng-change="scope.datePickerChange($index)"
	uib-datepicker-popup="{{scope.datePicker.format}}"
	ng-click="scope.openDatePicker($index)"
	ng-model="scope.bs.pax[$index].birthday"
	is-open="scope.datePicker.open[$index]"
	datepicker-options="scope.datePicker.dateOptions"
</div>

this is my datepickerOptions:
    //Init date picker
    scope.datePicker = {
      format : 'dd/MM/yyyy',
      dateOptions : {
        startingDay : 1,
        showWeeks : false,
        yearRows : 4,
        yearColumns : 5,
	maxDate : new Date(),
        initDate : new Date('67,12,07'),
	datepickerMode : 'year'
      },
      open : []
    };

When  i select from first "date picker" it start in YEAR mode and all works fine.
After if i click on another one "datepicker" in page, bound to same datepickerOption
it start from the last mode of datepicker used previously
I have checked code and i have seen that datepickerOptions is two way binding:
 scope: {
            datepickerOptions: "=?",
            isOpen: "=?",
            currentText: "@",
            clearText: "@",
            closeText: "@"
        },

so everytime that the mode is changed inside the datepicker it propagates to datepickerOption in scope.
you can test this bug in (http://angular-ui.github.io/bootstrap/#/datepickerPopup)  official page.
Select in first datepicker a Year  and open the other datepicker. It get same "datepickerMode"
Angular: 1.4.5
UIBS: 1.3.2
Bootstrap: 3.3.5

I would argue that this is not a bug and is intended behavior.  @wesleycho, thoughts?  I'm inclined to reject this.

This is not a bug - if one does not desire it doing that, one can simply watch the is-open property and reset the state.
But the question does remain, is this desired? If we were to reset this on the datepicker side, how do we know what the default should be? I posit there isn't a good way to do so on the library side that isn't restrictive, and thus should not be supported in the library itself as the default.
Going to close as per determination.


Automate pipeline application building lambda and api gateway deployment

Describe use in Automated Build Documentation

@mcduffie how is this task coming along?

@edwinsarkissian Making progress. Remaining work is to add authentication check and triggers to Lambda deployment.

@mcduffie ping for status.

@edwinsarkissian Added Lambda and api-gateway deployment. Remaining is adding authentication Terraform.
Running into this error in requests lib causing problems with testing:

@mcduffie ping for status.

The issue related to Python "requests" and "docker" packages have been resolved.  I go beyond the first failing point; however, there is a new problem with no obvious reason, which has prevented moving forward with full automation.  The full automation is 95% done, but I cannot test it due to the second problem. Now, apparently the docker image does not get registered in the local (In the EC2 Instance) docker server. This had been working for me for months, and it stopped working without any update on my side.

Because this is a "shared" service, we can proceed with the near fully automated solution into test/prod.

The issue related to Python "requests" and "docker" packages have been resolved. I go beyond the first failing point; however, there is a new problem with no obvious reason, which has prevented moving forward with full automation. The full automation is 95% done, but I cannot test it due to the second problem. Now, apparently the docker image does not get registered in the local (In the EC2 Instance) docker server. This had been working for me for months, and it stopped working without any update on my side.

This is the docker container that is built by app-pack-gen? And it's not being registered within the 'local' docker upon build? and so that prevents pushing? i'm just trying to understand the issue. Is tehre an error? is it silent? My first assumption would be disk space if this has been running for a long while...

i ssh'ed into the machine, and tried running the build_ogc_app as the gitlab-runner user. Ended up not getting very far in the build:
step 27/50 : RUN TIMEFORMAT='time: %3R' bash -c 'time /tmp/install-base-env.bash' && rm -rf /tmp/install-base-env.bash /tmp/env
 ---> Running in 5ce55d452dfb
+ dirname /tmp/install-base-env.bash
+ cd /tmp
+ export MAMBA_VERSION=1.5.7
+ MAMBA_VERSION=1.5.7
+ export CONDA_VERSION=24.3.0
+ CONDA_VERSION=24.3.0
+ URL=https://anaconda.org/conda-forge/micromamba/1.5.7/download/linux-64/micromamba-1.5.7-0.tar.bz2
+ unset HOME
+ mkdir -p /srv/conda
+ export MICROMAMBA_EXE=/usr/local/bin/micromamba
+ MICROMAMBA_EXE=/usr/local/bin/micromamba
+ tar -xvj bin/micromamba
+ wget -qO- https://anaconda.org/conda-forge/micromamba/1.5.7/download/linux-64/micromamba-1.5.7-0.tar.bz2
bin/micromamba
time: 2.560
+ mv bin/micromamba /usr/local/bin/micromamba
+ chmod 0755 /usr/local/bin/micromamba
++ /usr/local/bin/micromamba shell hook -p /srv/conda -s posix
+ eval '
# Copyright (C) 2012 Anaconda, Inc
# SPDX-License-Identifier: BSD-3-Clause

__mamba_exe() (
    "/usr/local/bin/micromamba" "${@}"
)

__mamba_hashr() {
    if [ -n "${ZSH_VERSION:+x}" ]; then
        \rehash
    elif [ -n "${POSH_VERSION:+x}" ]; then
        :  # pass
    else
        \hash -r
    fi
}

__mamba_xctivate() {
    \local ask_conda
    ask_conda="$(PS1="${PS1:-}" __mamba_exe shell "${@}" --shell bash)" || \return
    \eval "${ask_conda}"
    __mamba_hashr
}

micromamba() {
    \local cmd="${1-__missing__}"
    case "${cmd}" in
        activate|reactivate|deactivate)
            __mamba_xctivate "${@}"
            ;;
        install|update|upgrade|remove|uninstall)
            __mamba_exe "${@}" || \return
            __mamba_xctivate reactivate
            ;;
        self-update)
            __mamba_exe "${@}" || \return

            # remove leftover backup file on Windows
            if [ -f "/usr/local/bin/micromamba.bkup" ]; then
                rm -f "/usr/local/bin/micromamba.bkup"
            fi
            ;;
        *)
            __mamba_exe "${@}"
            ;;
    esac
}

if [ -z "${CONDA_SHLVL+x}" ]; then
    \export CONDA_SHLVL=0
    # In dev-mode MAMBA_EXE is python.exe and on Windows
    # it is in a different relative location to condabin.
    if [ -n "${_CE_CONDA+x}" ] && [ -n "${WINDIR+x}" ]; then
        PATH="${MAMBA_ROOT_PREFIX}/condabin:${PATH}"
    else
        PATH="${MAMBA_ROOT_PREFIX}/condabin:${PATH}"
    fi
    \export PATH

    # We'\''re not allowing PS1 to be unbound. It must at least be set.
    # However, we'\''re not exporting it, which can cause problems when starting a second shell
    # via a first shell (i.e. starting zsh from bash).
    if [ -z "${PS1+x}" ]; then
        PS1=
    fi
fi'
++ '[' -z '' ']'
++ export CONDA_SHLVL=0
++ CONDA_SHLVL=0
++ '[' -n '' ']'
++ PATH=/srv/conda/condabin:/srv/conda/envs/notebook/bin:/srv/conda/bin:/srv/npm/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
++ export PATH
++ '[' -z '' ']'
++ PS1=
+ micromamba activate
+ local cmd=activate
+ case "${cmd}" in
+ __mamba_xctivate activate
+ local ask_conda
++ PS1=
++ __mamba_exe shell activate --shell bash
++ /usr/local/bin/micromamba shell activate --shell bash
+ ask_conda='PS1='\''(base) '\''
export PATH='\''/srv/conda/bin:/srv/conda/condabin:/srv/conda/envs/notebook/bin:/srv/conda/bin:/srv/npm/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'\''
export CONDA_PREFIX='\''/srv/conda'\''
export CONDA_SHLVL='\''1'\''
export CONDA_DEFAULT_ENV='\''base'\''
export CONDA_PROMPT_MODIFIER='\''(base) '\'''
+ eval 'PS1='\''(base) '\''
export PATH='\''/srv/conda/bin:/srv/conda/condabin:/srv/conda/envs/notebook/bin:/srv/conda/bin:/srv/npm/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'\''
export CONDA_PREFIX='\''/srv/conda'\''
export CONDA_SHLVL='\''1'\''
export CONDA_DEFAULT_ENV='\''base'\''
export CONDA_PROMPT_MODIFIER='\''(base) '\'''
++ PS1='(base) '
++ export PATH=/srv/conda/bin:/srv/conda/condabin:/srv/conda/envs/notebook/bin:/srv/conda/bin:/srv/npm/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
++ PATH=/srv/conda/bin:/srv/conda/condabin:/srv/conda/envs/notebook/bin:/srv/conda/bin:/srv/npm/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
++ export CONDA_PREFIX=/srv/conda
++ CONDA_PREFIX=/srv/conda
++ export CONDA_SHLVL=1
++ CONDA_SHLVL=1
++ export CONDA_DEFAULT_ENV=base
++ CONDA_DEFAULT_ENV=base
++ export 'CONDA_PROMPT_MODIFIER=(base) '
++ CONDA_PROMPT_MODIFIER='(base) '
+ __mamba_hashr
+ '[' -n '' ']'
+ '[' -n '' ']'
+ hash -r
+ export PATH=/tmp/bin:/srv/conda/bin:/srv/conda/condabin:/srv/conda/envs/notebook/bin:/srv/conda/bin:/srv/npm/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
+ PATH=/tmp/bin:/srv/conda/bin:/srv/conda/condabin:/srv/conda/envs/notebook/bin:/srv/conda/bin:/srv/npm/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
+ cat
+ micromamba install conda=24.3.0 mamba=1.5.7 -y
+ local cmd=install
+ case "${cmd}" in
+ __mamba_exe install conda=24.3.0 mamba=1.5.7 -y
+ /usr/local/bin/micromamba install conda=24.3.0 mamba=1.5.7 -y

and it ends there. no real useful warning or error.

I think we saw this end up being a memory error. So we decided to increase the instance size of these for now. We will really, really need to figure out what we do with concurrent builds and many users requesting builds a single instance is not going to work, and i'm not sure if gitlab runners do all the queueing work or not (i think they do...)

Currently encountering an error where push_docker fails despite docker login succeeding.

Remaining part is to connect Lambda authorizer to API-Gateway path

Fully automated, needs to finish pushing in changes after testing changes.


SkASSERT(!rr.isComplex()) crash in Flutter Gallery

MacOS, Debug build, happens when hovering the "Back" button of the new Reply email demo.
Stacktrace:
sk_abort_no_print()
SkRRectPriv::GetSimpleRadii(SkRRect const&)::'lambda'()::operator()()
SkRRectPriv::GetSimpleRadii(SkRRect const&)
GrRenderTargetContext::drawFastShadow(GrClip const*, SkMatrix const&, SkPath const&, SkDrawShadowRec const&)
SkGpuDevice::drawShadow(SkPath const&, SkDrawShadowRec const&)
SkCanvas::onDrawShadowRec(SkPath const&, SkDrawShadowRec const&)
SkCanvas::private_draw_shadow_rec(SkPath const&, SkDrawShadowRec const&)
SkShadowUtils::DrawShadow(SkCanvas*, SkPath const&, SkPoint3 const&, SkPoint3 const&, float, unsigned int, unsigned int, unsigned int)
flutter::PhysicalShapeLayer::DrawShadow(SkCanvas*, SkPath const&, unsigned int, float, bool, float)
flutter::PhysicalShapeLayer::Paint(flutter::Layer::PaintContext&) const

spotShadowRRect looks like this:
[0]:{fX:24.2452583, fY:24.2452545}
[1]:{fX:24.2452583, fY:24.2452583}
[2]:{fX:24.2452583, fY:24.2452545}
[3]:{fX:24.2452583, fY:24.2452583}

For whatever reason [1].fY is slightly different than the others, which triggers SkASSERT(!rr.isComplex());.
[✓] Flutter (Channel master, 1.23.0-8.0.pre.56, on macOS 11.0 20A5384c x86_64, locale en-US)
    • Flutter version 1.23.0-8.0.pre.56 at /Users/Matej/Projects/flutter/flutter
    • Framework revision d48300e8a4 (2 days ago), 2020-09-29 15:52:03 -0400
    • Engine revision a6a6fd163b
    • Dart version 2.11.0 (build 2.11.0-177.0.dev)

The problem seems to be bool SkRRect::scaleRadii(), the scale coefficient is 0.99999996066553287, which seems to cause subtle differences for first and third corner in SkScaleToSides::AdjustRadii.

Way to reproduce this:
  SkRRect r =
      SkRRect::MakeRectXY(SkRect::MakeLTRB(421.5, 16, 526.5, 64), 24, 24);
  assert(!r.isComplex());
  SkMatrix matrix;
  matrix.setScaleTranslate(1.0102191, 1.0102191, -2.4219234, 2.98397303);
  SkRRect transformed;
  r.transform(matrix, &transformed);
  assert(!transformed.isComplex());

The second assertion will fail.

Adding label based on the flutter doctor provided in the OP.

Sorry, is this engine related issue?

I think technically it is skia issue, but I'm unable to create issues in skia tracker.

xref fxb/48693

Filed https://bugs.chromium.org/p/skia/issues/detail?id=10967 to track progress within skia.

@lhkbob, I think there already exists skia issue for this: https://bugs.chromium.org/p/skia/issues/detail?id=10815

Ah, yep, someone had mentioned in our chat that they weren't able to file a skia bug so I assumed it hadn't been done yet.

Will bring this up again with Skia in our sync later today.

https://bugs.chromium.org/p/skia/issues/detail?id=10815 has been filed with the Skia team.

We'll keep track of this issue in the Skia sync and a mirror issue has been filed. Cannot commit to a timeline for a fix yet.

Updates on the mirrored Skia issue.

Updates on the mirrored Skia issue.

Sounds (based on the update in the Skia issue) like the solution on our side should be to just remove the assert.

Sounds (based on the update in the Skia issue) like the solution on our side should be to just remove the assert.

I'm reducing the priority since this is a debug-binary-only issue. If you are running into this, submit a PR to remove the assert. :-)

I'm reducing the priority since this is a debug-binary-only issue. If you are running into this, submit a PR to remove the assert. :-)

Which assert are you referring to @Hixie? The SkASSERT(!rr.isComplex()) is on Skia's side, I'm not seeing anything in flutter that could avoid this in debug mode?

Which assert are you referring to @Hixie? The SkASSERT(!rr.isComplex()) is on Skia's side, I'm not seeing anything in flutter that could avoid this in debug mode?

Right, I did not mean to imply the assert was in our repo, just that the next step is to remove the assert, if I understood the Skia bug correctly.

Right, I did not mean to imply the assert was in our repo, just that the next step is to remove the assert, if I understood the Skia bug correctly.

I cannot reproduce this issue, but the Skia bug (https://bugs.chromium.org/p/skia/issues/detail?id=10815) is still open. Therefore, I am updating the labels to this issue

Not sure a fix in this way for skia is correct, but it solves our problem.
--- a/src/core/SkRRect.cpp
--
  | 3930 | +++ b/src/core/SkRRect.cpp
  | 3931 | @@ -254,8 +254,8 @@ bool SkRRect::scaleRadii() {
  | 3932 | double scale = 1.0;
  | 3933 |
  | 3934 | // The sides of the rectangle may be larger than a float.
  | 3935 | -    double width = (double)fRect.fRight - (double)fRect.fLeft;
  | 3936 | -    double height = (double)fRect.fBottom - (double)fRect.fTop;
  | 3937 | +    double width = (double)(fRect.fRight - fRect.fLeft);
  | 3938 | +    double height = (double)(fRect.fBottom - fRect.fTop);
  | 3939 | scale = compute_min_scale(fRadii[0].fX, fRadii[1].fX, width,  scale);
  | 3940 | scale = compute_min_scale(fRadii[1].fY, fRadii[2].fY, height, scale);
  | 3941 | scale = compute_min_scale(fRadii[2].fX, fRadii[3].fX, width,  scale);


git history not maintained

Synx moves and organized files outside to a temporary folder, deletes source files, and then moves the temporary structure back in place.
This breaks git/svn history for projects that use source control. For git, ideally Synx should perform a series of git mv operations, which maintains the history.

I'm experimenting with git support on https://github.com/weibel/synx/commit/4c9ad3b5eaaee5132caa797d6c344c2544425e63

Alternatively git log --follow will work
http://stackoverflow.com/questions/5646174/github-follow-history-by-default

Related conversation on #3


bugfix for the mseed gaps

This is the bugfix for issue #261
Basically, we use the obspy built-in merge function to fix this.

Codecov Report

Merging #267 (c3fb78c) into master (d292827) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
- Coverage   47.89%   47.88%   -0.01%
==========================================
  Files         118      118
  Lines       15359    15359
==========================================
- Hits         7356     7355       -1
- Misses       8003     8004       +1

Impacted Files
Coverage Δ

python/mspasspy/db/database.py
82.62% <100.00%> (-0.07%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d292827...c3fb78c. Read the comment docs.

hmmm.... why did it failed? Could you please look into it @haruming ? Thank you!


Breaks apart macros.html

Breaks apart macros.html into macros in /macros/ and /macros/util/.
Additions

Adds notification.html, subscribe.html, youtube.html, util/format.html, util/is-mobile.html, util/share.html.

Removals

Removes macros.html.

Testing

Site should function the same.

Review

@KimberlyMunoz
@jimmynotjim
@sebworks

Notes

Part of https://github.com/cfpb/cfgov-refresh/issues/597

Looks good to me. None of this touches the macro tests, but it would probably make sense to add some there in a future PR.


flutter --version should do something useful

Maybe it should print out the current git revision?

Thanks!


fix owner field

I am not a 100% sure but I think the field  to set here is called owner and not changed_by

That's correct. Thank you @PeterW-LWL


Three Instances of the bot seem to be running

Not really an issue with the bot, but I've got multiple instances running, so all of the help commands prompt three posts instead of the expected one. Might have to restart the EC2 instance to fix it.

Fixed for now, but I need to figure out a good way to keep things running without being connected to the instance


bzr (no such package)

On running fn -v build-server -t rijulsudhir/fn-api-ext
it is showing
Building image rijulsudhir/fn-api-ext
FN_REGISTRY:  <IP_ADDRESS>:5000
Current Context:  distributed-fn
Sending build context to Docker daemon  3.072kB
Step 1/11 : FROM golang:1-alpine AS build-env
 ---> 3a38ce03c951
Step 2/11 : RUN apk --no-cache add build-base git bzr mercurial gcc
 ---> Running in 7815735ce714
fetch https://dl-cdn.alpinelinux.org/alpine/v3.14/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.14/community/x86_64/APKINDEX.tar.gz
ERROR: unable to select packages:
  bzr (no such package):
    required by: world[bzr]
The command '/bin/sh -c apk --no-cache add build-base git bzr mercurial gcc' returned a non-zero code: 1

build can be completed by changing FROM golang:1-alpine AS build-env to FROM golang:1-alpine3.11 AS build-env in the generated dockerfile in the temp folder and building with docker build.
As per https://gitlab.alpinelinux.org/alpine/abuild/-/issues/10000 it seems like bzr package has been removed in the latest version.

If anyone else face the same issue install cli using below command
curl -LSs https://raw.githubusercontent.com/rijulsudhir/fn-1-cli/master/install | sh
This is just a temporary solution until the actual fix is released.
(In this installation golang:1-alpine3.11 is used instead of golang:1-alpine latest)


Parallelise s3 cache probing

Just gave #79 a try.
Disclaimer: I don't have a Carthage dev environment, so this it completely untested (but it typechecks :wink: ).
Please try if it works as intended before merging!
Commit 1 just parallelises the requests with minimal changes to existing code using async-lifted.
async in itself is a really nice library, but it wants the parallelised actions to be IO actions and since we have a ReaderT s IO here, we can't use it. async-lifted provides a more general interface using MonadBaseControl which we can use.
Commit 2 makes the code more concise, removing one top level function. I find this version to be more understandable (less passing around of long arguments), but that might be different for other people.
Commit 3 avoids MonadBaseControl and uses plain async, but needs to do some additional gymnastics to run the ReaderT.
By deciding which commits to pick, you can choose the version you want ;)
Minimal changes, more concise, avoiding async-lifted...

          2 Warnings

:warning:
src/Lib.hs#L534 - Found Reduce duplication

1frameworkNameWithFrameworkExtension = appendFrameworkExtensionTo f
2platformBuildDirectory = carthageBuildDirectoryForPlatform platform
3frameworkDirectory
4  = platformBuildDirectory </> frameworkNameWithFrameworkExtension
5

Why Not

1Combine with src/Lib.hs:959:5

:warning:
src/Lib.hs#L534 - Found Reduce duplication

 1frameworkNameWithFrameworkExtension = appendFrameworkExtensionTo f
 2platformBuildDirectory = carthageBuildDirectoryForPlatform platform
 3frameworkDirectory
 4  = platformBuildDirectory </> frameworkNameWithFrameworkExtension
 5dSYMNameWithDSYMExtension
 6  = frameworkNameWithFrameworkExtension ++ ".dSYM"
 7dSYMdirectory
 8  = platformBuildDirectory </> dSYMNameWithDSYMExtension
 9

Why Not

1Combine with src/Lib.hs:582:5

  Generated by :no_entry_sign: Danger

@mheinzel Great work! Thanks a lot!
I think I like commit 00978566c199f541fc12bfe28508621f1ea1d5c0 the most.
I'm very tempted by f1978ca5d96a7d5c8351fcb9af76fc48a61cfcc2 as well because it deletes some code. However the pattern so far has been:

write a function to do 1 thing
write a wrapper to do it many times

and this commit would break the pattern.
It's debatable if this philosophy was a good approach to begin with, the intention was to remove the cognitive load of the maps and flatMaps and leave the code more readable. It certainly helped me when I started. I'm not sure it's making the code easier to read now. What do you think?
Commit 4040f436b100c62543662546557f8d198636ad7c imho is less readable, introduces do, and runs the reader. I have no problem with async-lifted, should I have a problem with that? :D

I tried it out and seems to work to me.
The speed up is pretty impressive. It's almost instant.

I don't think the pattern is bad, but in this situation it seems a bit too fine-grained.
Also, what makes it so verbose here is that there are so many arguments you just need to pass through, but have to mention again and again (and the type signatures get pretty long).
To reduce this, you could bundle some of this information into some kind Env data type and put it all into the Reader. Bucket name, inverted repo map, AWS env, verbosity settings and cache prefix string (once obtained in the beginning) should not change during execution of the program, right?
Regarding async-lifted:
It has some additional complexity with MonadBaseControl, but you don't really have to deal with this concept to understand and work with the code.
One disadvantage might be that once we convert the code to mtl, we would need a MonadBaseControl constraint in the type signature, which would bubble up into functions using it :thinking:
But no problem for now, we can still decide to explicitly run the Reader then...

By the way, should upload and download of artifacst be parallelised as well?

I suggest to proceed with the following in this PR:

Merge 00978566c199f541fc12bfe28508621f1ea1d5c0

leave the rest out (for now).
I think the Env Data structure going forward would be a nice solution for the verbosity of the arg passing. Some of the arguments are already hidden in the reader.
Probably as you suggested time ago since there is a lot of ReaderT combinations this approach can be used: https://hackernoon.com/the-has-type-class-pattern-ca12adab70ae
Also, don't know if relevant but there is this: https://www.fpcomplete.com/blog/2017/07/the-rio-monad
Once the Env is there then probably it makes sense to take a look again and maybe crush the wrappers that just map over stuff.
About uploading/downloading of artifacts:
It would be nice to parallelise those as well but I wonder:

Is there any benefit in splitting the bandwidth in N? what do you think?
There are print statements all over the place and I fear those might overlap in the output on console. This does not happen when listing because the outcome is collected in a data structure (clever move by @r-peck )

If you want to take a stab at this it would be great. Obviously that would be a different PR.

Sure, let's just merge the first commit.
Downloading multiple files concurrently could be faster in some situations, but not as much as in this case. The perfect number of concurrent downloads depends on a lot of factors...
We could just try it at some point, but it's not urgent.

@mheinzel  will you push force just the first commit or should we do this?

merged! 🎉


fix(batcher): check that the received retrospective_block_hash value is not none.

This change is

#2199  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Basenames frames tutorial

What changed? Why?
A tutorial on how to add a Frame to a Basename profile
Notes to reviewers
How has it been tested?

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1

Review Error for JFrankfurt @ 2024-09-20 16:55:59 UTC
User failed mfa authentication, see go/mfa-help


Please Fix MySql Errors

Ever since I got your plugin my SERVER constantly crashes with a mysql exception of your plugin
This Error evry day evry Night  https://hastebin.com/vobabupoku.vbs
Please Fix

Not a LuckPerms issue.
Please see here for guidance:
https://github.com/lucko/LuckPerms/wiki/Storage-system-errors
https://github.com/lucko/LuckPerms/wiki/Storage-system-errors#mysql-exceeded-max-connections

The last packet successfully received from the server was 1,511,941 milliseconds ago.  The last packet sent successfully to the server was 1 milliseconds ago.)
[00:17:41] [Craft Scheduler Thread - 6855/WARN]: luckperms - Failed to validate connection com.mysql.jdbc.JDBC4Connection@ed438ab (Communications link failure

So let me get this right, you are too lazy/cbf'ed/ignorant to read your own log, do a little research and determine to "pass the buck" without checking your own setup thus placing the blame on everyone except yourself?

It explains exactly what the issue is and what you need to do to fix it. (specifically the second link)

what is your problem you just fix this mistake one

It's not a LuckPerms issue.

Please actually read what I've linked above.

Even Pex is better please fix this mistake
my database goes with each plugin only yours does not want to create it not even ne table

The issue is caused by your MySQL server, not LuckPerms. It tells you that in the error. :)

Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: User 'ni883803_6sql7' has exceeded the 'max_user_connections' resource (current value: 30)

The wiki page I linked explains what you can do to resolve this.

I now have a mysql on a VServer and get the following error please help me I like your plugin I'm mega angry because it is not working please

https://hastebin.com/iribosixed.vbs

here is my config with login and password you are welcome to log in to the database but please help me please
https://hastebin.com/qalububemo.coffeescript

Still not caused by LP. It's a driver error and totally separate.
Again, there are some things you can try on this page: https://github.com/lucko/LuckPerms/wiki/Storage-system-errors
For the last time, it is NOT a LuckPerms bug.


Fix pixel page

Thank you for the update and the support of the project.

Thank you for the update and the support of the project.


[tsp-client] Add gh action for tests

Add a GH action for tsp-client tests

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

I believe this is blocked, until we change how workflows are synced across repos, since this workflow only applies to the tools repo:
https://github.com/Azure/azure-sdk-tools/blob/main/eng/pipelines/eng-workflows-sync.yml

/azp run

/azp run azure-sdk-tools - sync - eng-workflows


Add From Snow to Flow

Insert URLs to the project here: https://github.com/DOI-USGS/snow-to-flow

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

All issues labeled as Good First Issue of the project listed on OpenSustain.tech will be visible on ClimateTriage.com. This is a great way to welcome new community members to your project.
All new projects listed will be posted on our Mastodon channel.

@ellenbechtel @mwernimont


As a system I can store registration information for users (back-end)

Description
The system is able to store additional information. The account data is kept track of in some form of storage (discuss with others). Account data can be stored in a database. The system can be used to check account existence. The front-end can call a function with an email address to check email existing within an account.
Acceptance Criteria

[x] Email addresses can be added to the database.
[x] Optional account information can be stored. (for now username as an example suffices)
[x] The system can check from the front end whether there exists a stored account with a certain email address

Progress can be seen here: https://github.com/SEP-TU-e-2024/website/pull/36


Import error . The following line is showing error when run locally

This line is showing error when torchgan is run locally . Should I change it to
from .models import Discriminator, Generator
as in other files like acgan.py

@namanbiyani yes please do it


workaround fidati pkg bug on consecutive commands

When issuing USB control commands to the api.U2FHID_ARMORY_INF mapping right before issuing one to the api.U2FHID_ARMORY_CFG mapping the following happens.
panic: runtime error: index out of range [2] with length 1

goroutine 33 [running]:
github.com/gsora/fidati/u2fhid.(*Handler).Tx(0x82818650, {0x0, 0x0, 0x0}, {0x0, 0x0})
        github.com/gsora/fidati@v0.0.0-20220824075547-eeb0a5f7d6c3/u2fhid/handler.go:38 +0x690
github.com/usbarmory/tamago/soc/nxp/usb.(*endpoint).tx(0x82830660)
        github.com/usbarmory/tamago@v0.0.0-20230724190245-6f2dec2f8412/soc/nxp/usb/endpoint_handler.go:44 +0x48

As a workaround while this issue is solved this PR avoids issuing status (which is done solely for the reason of printing out the target serial number) before CFG or OTA commands.

Is it worth popping in a TODO to remind us to put it back once the upstream issue is resolved?

Is it worth popping in a TODO to remind us to put it back once the upstream issue is resolved?

Done.


When ruby 2.6 is retired, allow active support 7+ in gemspec

Ruby 2.6 is EOL the 31/03/2022 (https://endoflife.software/programming-languages/server-side-scripting/ruby)

Hey ! Ruby 2.6 is EOL !


Sequenced Packer plugins missing URLs

It seems that Packer plugins sequenced with after = xxx are missing URLs when scraped. Can't really do much until packer.nvim resolves these related issues:

https://github.com/wbthomason/packer.nvim/issues/868
https://github.com/wbthomason/packer.nvim/issues/765

TODO: remove hacky fix in urlview.search.packer when packer.nvim fixes the issues above.

Finally resolved in https://github.com/wbthomason/packer.nvim/pull/917


[TC-FCONC-1.1] SDK has to be implemented for Fluoride Concentration Measurement Cluster

Reproduction steps
All-clusters-app has to be enabled with below mentioned commands :

[ ]  generated-command-list
[ ]  accepted-command-list
[ ]  event-list
[ ]  attribute-list
[ ]  feature-map
[ ]  cluster-revision

Bug prevalence
Whenever I try to read all these Global attributes
GitHub hash of the SDK that was being used
7ae5919a046a18c7e60537aff814977ee424b9cf - Master
Platform
raspi
Platform Version(s)
RPI - 4, 8GB RAM
Anything else?
No response

Will be fixed by https://github.com/project-chip/connectedhomeip/issues/27662


Add missing import of CoreGraphics framework

Some projects, for example those which doesn't have a .pch file importing either UIKit or CoreGraphics, won't compile without this. Sorry my fault on the previous PR guys 😬

This works for me 👍

Shipped as 3.1.1


fix check for parameter existence in EXTINF

Due strange github behaviour request was not closed automatically though patch was applied ok. I close request.


miette integration for all errors

Category
User level API changes
Describe the feature you'd like to request
In #148, we refactored some of our errors to use miette.  We should do this for all errors in Core and Validator.
Describe the solution you'd like
As above.
Describe alternatives you've considered
N/A
Additional context
No response
Is this something that you'd be interested in working on?

[ ] 👋 I may be able to implement this feature request
[X] ⚠ This feature might incur a breaking change

To be explicit: This involves threading source location through many more places.  That could be tracked as a separate issue or as part of this one.


fix(util): ensure unique cache keys in LazyVim.memoize

What is this PR for?
This PR fixes a bug in the LazyVim.memoize function that was causing unexpected behavior in my configuration. The issue was discovered when setting vim.g.lazyvim_prettier_needs_config = true in my lua/config/options.lua, which did not work as expected.
The root cause was an issue with LazyVim.memoize cache key generation, which led to M.has_config(ctx) always returning the same result as M.has_parser(ctx). This happened because LazyVim.memoize generates cache keys based on the function parameters, and both functions were being called with identical parameters:
https://github.com/LazyVim/LazyVim/blob/7d30360df29e0d02dd946521ff7fbfeea201b142/lua/lazyvim/plugins/extras/formatting/prettier.lua#L77-L81
By improving the cache key generation to include function information, we can ensure unique keys for different functions even if their parameters are identical, thereby fixing the issue.
Does this PR fix an existing issue?
N/A
Checklist

[x] I've read the CONTRIBUTING guidelines.

Thanks!


Add e2e tests for virtletctl

This change is

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

tests/e2e/framework/localcmd_interface.go, line 36 at r1 (raw file):

			}
		}
		return 0, err

Ok. That change is quite silly. If it has to match the Executor interface in same way as in docker_interface.go or ssh_interface.go it should wait for cmd result, so it could simply call cmd.Run instead of cmd.Start/cmd.Wait.
Still changing this interface means breaking some tests (for sure port forwarding) which depends on not waiting for cmd finish.

Comments from Reviewable

Review status: 0 of 17 files reviewed at latest revision, 9 unresolved discussions.

tests/e2e/virtletctl_test.go, line 34 at r2 (raw file):

)

var _ = Describe("virtletctl tests", func() {

"virtletctl"

tests/e2e/virtletctl_test.go, line 35 at r2 (raw file):

var _ = Describe("virtletctl tests", func() {
	It("Should how usage", func(done Done) {

"Should display usage info on help subcommand"

tests/e2e/virtletctl_test.go, line 47 at r2 (raw file):

	})

	It("Should not fail during dump-metadata", func(done Done) {

Perhaps this test should check for some simple strings in metadata dump output? Maybe after starting a pod? "Should dump Virtlet metadata on dump-metadata subcommand"

tests/e2e/virtletctl_test.go, line 59 at r2 (raw file):

	})

	It("Should not fail during gendoc", func(done Done) {

perhaps this test should check for a substring in the generated files and should be named "Should generate documentation on gendoc subcommand"

tests/e2e/virtletctl_test.go, line 72 at r2 (raw file):

	Context("Install subcommand", func() {
		It("Should not fail during install", func(done Done) {

"Should install itself as a kubectl plugin on install subcommand" This test is too disruptive, as in, it can damage user's environment if e2e runner is invoked directly. Probably we should mark it as such and take some measures so this test is only executed inside build container or if explicitly asked for? For example, it should maybe skip itself upon some env var like VIRTLET_UNSAFE_E2E (set it in docker run for the build container in build/cmd.sh)

tests/e2e/virtletctl_test.go, line 123 at r2 (raw file):

			Expect(err).NotTo(HaveOccurred())
			Expect(os.Chmod(tempfileName, 0600)).NotTo(HaveOccurred())
		})

I guess several commands like vnc, ssh and dump-metadata can be grouped under one Describe("pod commands", ... with this BeforeAll/AfterAll and make use of this pod setup for their testing.

tests/e2e/virtletctl_test.go, line 131 at r2 (raw file):

		})

		It("Should can call remote command with virtletctl ssh", func(done Done) {

"Should be able to access the pod via ssh using ssh subcommand"

tests/e2e/virtletctl_test.go, line 145 at r2 (raw file):

	})

	It("Should not fail during virsh list", func(done Done) {

Again "Should list libvirt domains on list subcommand" and check for the presence of the pod in the list (there's some code to get domain id from pod name/id in tests/e2e)

Comments from Reviewable

Review status: 0 of 17 files reviewed at latest revision, 8 unresolved discussions.

tests/e2e/virtletctl_test.go, line 47 at r2 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
The one thing is to ensure that there was not error during whole procedure (copying file content from container, using it as boltdb, unmarshalling the data), and another would be validation of generated output. Perhaps this later could be added as conformance test?

Done.

tests/e2e/virtletctl_test.go, line 59 at r2 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
Same as above, that would require to add there a logic aware about which commands should have docs and maybe verification of generated doc format. Good candidate for conformance test.

Added tests for substrings in main virtletctl.md file.

tests/e2e/virtletctl_test.go, line 72 at r2 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
Does anybody run our e2e against  user's environment? That would leave tons of unfinished pods hidden in per run created namespaces (i was in this situation, that's why i wanted to have vm pods created in default namespace, to have them better noticeable).
Anyway - good idea with this possibility to skip, added that in the way as cloud init tests are skipped.

Added in a way how cloud init tests are handled.

tests/e2e/virtletctl_test.go, line 145 at r2 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
Message updated. That part - Done.
As commented above - IMO validation of virsh command output for some added for this test pod is out of scope there and would only increase unnecessarily the test by 20-30sec.
It only verifies if virsh can be accessed and do anything on libvirt. If it could not do that - it would fail, what should be caught by this test. Maybe instead of calling virsh list i should use there virsh help for this purpose, maybe this purpose would be more clear?
But... As commented above - if single pod would be precreated for this test during BeforeSuite - overall cost of such validation would be minimal and so such conformance test could be also added.
Can do that, but hopefully in a followup.

Instead of relying on virsh list I changed verification of virsh command to use version subcommand and it's expected substrings.

Comments from Reviewable

Review status: 0 of 17 files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.

.circleci/config.yml, line 182 at r3 (raw file):

        build/portforward.sh 8080&
        mkdir -p ~/junit
        _output/virtlet-e2e-tests -test.v -ginkgo.skip="\[Heavy\]" -junitOutput ~/junit/junit.xml -include-non-safe-tests=true

Please also add this option in build/cmd.sh, build/cmd.sh uses the build container so it's safe to run these tests there.

tests/e2e/common.go, line 37 at r3 (raw file):

	sshUser               = flag.String("sshuser", defaultSSHUser, "default SSH user for VMs")
	includeCloudInitTests = flag.Bool("include-cloud-init-tests", false, "include Cloud-Init tests")
	includeNonSafeTests   = flag.Bool("include-non-safe-tests", false, "include tests which can modify environment")

includeUnsafeTests
include-unsafe-tests
include tests that can be unsafe if they're run outside the build container

tests/e2e/common.go, line 151 at r3 (raw file):

}

func includeNonSafe() {

includeUnsafe

tests/e2e/common.go, line 153 at r3 (raw file):

func includeNonSafe() {
	if !*includeNonSafeTests {
		Skip("Tests modifying cluster environment are not enabled")

Tests that are unsafe outside the build container are disabled

tests/e2e/virtletctl_test.go, line 47 at r2 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
The one thing is to ensure that there was not error during whole procedure (copying file content from container, using it as boltdb, unmarshalling the data), and another would be validation of generated output. Perhaps this later could be added as conformance test?

well, I was speaking not about validation, but rather about at least some identifying strings present in the output, so as to make sure it doesn't just produce an empty file and does gather some info about pods.

tests/e2e/virtletctl_test.go, line 59 at r2 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
Same as above, that would require to add there a logic aware about which commands should have docs and maybe verification of generated doc format. Good candidate for conformance test.

Well, just the same as above, I meant a simple func to check for e.g. just one word in the output, not any serious correctness checks.

tests/e2e/virtletctl_test.go, line 72 at r2 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
Does anybody run our e2e against  user's environment? That would leave tons of unfinished pods hidden in per run created namespaces (i was in this situation, that's why i wanted to have vm pods created in default namespace, to have them better noticeable).
Anyway - good idea with this possibility to skip, added that in the way as cloud init tests are skipped.

I sometimes build & execute e2e runner on MAC. This test being skipped by default would be highly welcome ...

tests/e2e/virtletctl_test.go, line 123 at r2 (raw file):

Clearly vnc and ssh need them and could be grouped as you proposed, and even could reuse the same vm pod (so that could use BeforeSuite/AfterSuite instead of BeforeAll/AfterAll which are simply adding multiple BeforeEach afair). So when i'll be adding vnc test - will add this Describe.

Well my idea was using the same pod for all the checks incl. virsh / dump-metadata so you could look for pod-specific substrings in the output, but ok, let's keep it this way for now.

tests/e2e/virtletctl_test.go, line 117 at r3 (raw file):

			_, err = tempfile.Write([]byte(strippedKey))
			Expect(err).NotTo(HaveOccurred())
			Expect(os.Chmod(tempfileName, 0600)).NotTo(HaveOccurred())

Expect(os.Chmod(tempfileName, 0600)).To(Succeed())

tests/e2e/virtletctl_test.go, line 154 at r3 (raw file):

	}, 60)
})

Pls use Context("[unsafe]", ...) inside Describe("virtletctl", ...).  Or just do the check inside It(...)

tests/e2e/virtletctl_test.go, line 160 at r3 (raw file):

	})

	Context("Should install itself as a kubectl plugin on install subcommand", func() {

Perhaps just It("Should install itself as a kubectl plugin on install subcommand", ...) You may then also check plugin yaml for a substring and make sure _output/virtletctl is copied to the proper location.

Comments from Reviewable

Review status: 0 of 19 files reviewed at latest revision, 8 unresolved discussions.

.circleci/config.yml, line 182 at r3 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
Please also add this option in build/cmd.sh, build/cmd.sh uses the build container so it's safe to run these tests there.

Done.

tests/e2e/common.go, line 37 at r3 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
includeUnsafeTests
include-unsafe-tests
include tests that can be unsafe if they're run outside the build container

Done.

tests/e2e/common.go, line 151 at r3 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
includeUnsafe

Done.

tests/e2e/common.go, line 153 at r3 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
Tests that are unsafe outside the build container are disabled

Done.

tests/e2e/virtletctl_test.go, line 47 at r2 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
well, I was speaking not about validation, but rather about at least some identifying strings present in the output, so as to make sure it doesn't just produce an empty file and does gather some info about pods.

Added that.

tests/e2e/virtletctl_test.go, line 72 at r2 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
I sometimes build & execute e2e runner on MAC. This test being skipped by default would be highly welcome ...

Ok. Removed this test and we can rethink how to do it properly in a followup.

tests/e2e/virtletctl_test.go, line 117 at r3 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
Expect(os.Chmod(tempfileName, 0600)).To(Succeed())

Good catch. Found also other place where this will improve readability.

tests/e2e/virtletctl_test.go, line 154 at r3 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
Pls use Context("[unsafe]", ...) inside Describe("virtletctl", ...).  Or just do the check inside It(...)

Done.

tests/e2e/virtletctl_test.go, line 160 at r3 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
Perhaps just It("Should install itself as a kubectl plugin on install subcommand", ...) You may then also check plugin yaml for a substring and make sure _output/virtletctl is copied to the proper location.

I see no point in validation of yaml content while kubectl will do that in the end of test. Similar with binary - if there would be copied any garbage - command kubectl plugin virt help will end with failure.

Comments from Reviewable

Review status: 0 of 19 files reviewed at latest revision, 2 unresolved discussions.

tests/e2e/virtletctl_test.go, line 160 at r3 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
I see no point in validation of yaml content while kubectl will do that in the end of test. Similar with binary - if there would be copied any garbage - command kubectl plugin virt help will end with failure.

ok, didn't notice it was running the plugin. then it's ok. sorry.

Comments from Reviewable

Review status: 0 of 19 files reviewed at latest revision, 2 unresolved discussions.

tests/e2e/virtletctl_test.go, line 154 at r3 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
Done.

Done. This time in requested way :)

tests/e2e/virtletctl_test.go, line 160 at r3 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
ok, didn't notice it was running the plugin. then it's ok. sorry.

Done.

Comments from Reviewable

Reviewed 14 of 17 files at r2, 4 of 5 files at r4, 1 of 1 files at r5.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Kotlin examples are written in Java

The client libraries page for Kotlin is the same as for Java. Also all examples are written in Java and not in Kotlin. Hence, I would suggest to either remove it or convert the examples into Kotlin
URL for relevant page?
http://<IP_ADDRESS>/client_libraries/libraries/kotlin/

@fezu54, thank you! We'll take a look.
Transferring this issue over to our new repository.


Problem with form_validation after latest merge

Hi @philsturgeon ,
you have merged the set_data() pull request for the form_validation library. But now I am running into a problem that my current validation configs are not working anymore (they did before).
The problem is (I think) in this line: https://github.com/EllisLab/CodeIgniter/blob/develop/system/libraries/Form_validation.php#L328
If I comment out that line, the validation works....
I think the problem is that _reset_validation() clears the _config_rules array (Line 335).

@IT-Can Can you try commenting out line 1324:
$this->_config_rules = array();
It should work fine then.

@JonoB can you fix this?

Yep, will get this fixed asap

Nice thanks!

@IT-Can @philsturgeon https://github.com/EllisLab/CodeIgniter/pull/1126


attempt to delete row 1 from section 0 which only contains 1 rows before the update

My code crashes with that error message here:

    func tableView(_ tableView: UITableView, editActionsForRowAt indexPath: IndexPath, for orientation: SwipeActionsOrientation) -> [SwipeAction]? {
        guard orientation == .right else { return nil }

        let deleteAction = SwipeAction(style: .destructive, title: "Delete") { action, indexPath in

            self.fileURLs.remove(at: indexPath.row)

            self.tableView.deleteRows(at: [indexPath], with: UITableView.RowAnimation.fade)

        }

        // customize the action appearance
        deleteAction.image = UIImage(named: "delete")

        return [deleteAction]
    }

Anyone able to help me?

Update: If I added more then one SwipeACtion, the second one works not the first one... the first one causes the crash.

The crash is not related to SwipeCellKit, but rather related to the number of rows or sections you are returning back to the UITableViewDelegate methods.


TinyMCE no upload images in blocks

I'm using laravel 7.28.x and all the latest voyager packages.
TinyMCE upload works just fine in bread rich text boxes, but it does not in blocks.
something is not triggering or loading the same.
there are no errors in console etc.

The Voyager upload form was missing from the edit-add.blade.php view. This has been fixed as of version 0.10.1.

The Voyager upload form was missing from the edit-add.blade.php view. This has been fixed as of version 0.10.1.


Localized License Files are not supported

Describe the bug
On DSpace 5 and 6 under JSPUI it was possible to use language dependent repository licenses (for instance default_de.license or default_en.license), which was described here: https://wiki.lyrasis.org/display/DSDOC6x/Localization+L10n#LocalizationL10n-Localizationoflicense.default. There is a default.license https://github.com/DSpace/DSpace/blob/main/dspace/config/default.license in the configuration, which can be replaced with a custom one and it can be overridden collection specificly in the collection metadata. But DSpace 7 does not provide the option to use default_.license files at the moment.
To Reproduce
Steps to reproduce the behavior:

Create a file default_de.license
Switch to german language on the frontend
Start a new submission in a collection using the default license
The default license file will be displayed, and not the existing language specific variant

Expected behavior
The license displayed in the LicenseStep of the submission should use the appropriate Licensefile

Maybe we should treat the default deposit license bundle just like the collection license bundles:  as a metadata field, in this case belonging to the Site object.  That might simplify the code which fetches the license for display, since it would follow exactly the same process first on the Collection and then (if not found) on the Site, rather than having one bit of code for metadata fields and another, nearly identical, for files.
This would also make it easy to let members of the admin. group update a default deposit license remotely, if a bit of UI were built in front of it.

One other thing to consider:  should there be a "fallback" license in case the desired language is not available?  How to select the fallback value?  Perhaps the value with no language specified?  Then sites can determine for themselves which language will be the "default default".

Another idea that I toyed with was using something like PropertyResourceBundle, which already has language+variant selection behavior, but it seems cumbersome for long documents like deposit licenses, especially if you need to serve many languages.  It might be possible to create a FileResourceBundle, but I decided that keeping the design choice of putting each license in a file in config/ was not worth the effort, even though coding it might be fun.

Thank you for sharing your ideas about this, @mwoodiupui!
I like the idea to have the localized licenses in the database rather than in the file system, as the current approach has a nasty limit: you can only translate the default language. For collections with a different license it is not possible to localize them, unless the option to translate the license is in the database.
So I second the approach to move the default license into the database and would like to propose to build localization options on that metadata level (for instance by using the language attribute for the license field?).

If there is a quick way to simply support the old JSPUI approach, then this might be considered a bug fix which could be added to a future 7.6.x bug-fix only release.
However, any larger redesigns or rethinking of this older approach would likely require waiting on 8.0 (or later).
For now, I'll pull this over to the 7.6 maintenance board in the hopes that someone will find a quick/easy way to bug fix this.  But, if that analysis finds it's not easily possible, we may have to move this to 8.0.

@damian-joz : You are welcome to link your solution into this ticket or create a draft PR.  The final decision is not mine alone, but I can bring it to the developer team meetings as necessary for more feedback.

@tdonohue You can assign me to this issue.

@tdonohue Here is my PR https://github.com/DSpace/DSpace/pull/8966
I'd like to discuss one thing. There was a simple cache of license text I had to remove. But now we read file from disk every time we start new submission (or editing). I am thinking to create a simple cache, can be hash map with locales as keys. Any thoughts?

IIRC our general direction now is "don't hold configuration data locally; get them when you need them."
If the license files are being accessed rarely, then the cost of reading them again is negligible and I doubt that a user would notice the delay for I/O.
If the files are being accessed frequently then there is a good chance that entire files are still cached by the OS and there will be no I/O cost at all.
I would say that we should consider the proposed cache un-necessary until we discover otherwise.

@damian-joz : I agree with @mwoodiupui .  I'm OK with the existing cache being removed here & I don't see a need to create a new cache.  We try not to cache configurations or files anymore unless absolutely necessary.  I don't believe caching this license file should be necessary, as I believe the license file is only loaded on the Submission form.  If we find reading this file on demand every time results in a slower submission form, then we could consider other options.  But, I doubt we will see any significant impact in this area of the code (I could always be wrong though).

Hi @tdonohue. Task is ready to assign reviewers.

Hi @damian-joz : Your PR has already been assigned to reviewers.  Code review is on a volunteer basis though at this time, so sometimes it can take some time to get to your code.  But, your PR is on our board to review for 7.6.1, so I can guarantee it will get a review.  (The summer months of July-Aug also are usually very slow for DSpace as many of our volunteers are taking holidays during that time)
If you would like to get immediate attention to your PR, we also do offer all developers the ability to do "PR Trading" (where you offer to review or test someone else's PR in exchange for them reviewing yours).  If that's of interest, see the details at https://wiki.lyrasis.org/display/DSPACE/Trading+reviews+on+Pull+Requests
Either way, I promise your work will be reviewed.  It's on my todo list as well, but I just haven't gotten to it yet.


Relies on a personally manged docker image.

This shows that an important input to the image is managed by a personal dockerhub account: https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/blob/d9b14d2613bf2515a125a3070d2eff7902a4a1e3/infra/build/developer-tools-light/Dockerfile#L16

Thanks for the report @tmc
Yeah we could move away from this and download the correct TF version inline.


URL patterns

How can I use this api? Can you show me an URL pattern what can I use for query information?

Hi @MBalazs90
as specified here https://github.com/RemotePixel/aws-sat-api/blob/c3f3280be69373b0a0dcc14fed50a60743cb2ab4/serverless.yml#L37
request must be in the form of
<your-api-gateway-endpoint>/landsat?path=000&row=000& full=true
FYI, this library is not actively maintained and has been replaced by https://github.com/RemotePixel/aws-sat-api-py (no direct serverless implementation)
hope it helps.


[release-1.7] Add filter configuration override to telemetry v2

Add filter configuration override to telemetry v2

fix

manual cherry-pick #26286. This will greatly simplify telemetry v2 metric customization task: https://istio.io/latest/docs/tasks/observability/metrics/customize-metrics/
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@kyessenov @mandarjog fyi, I will update istio.io doc later.

@bianpengyuan: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio_release-1.7
60c742cf9e514511a783f1250b97c6ac08f21fc7
link
/test release-notes_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Inquiry some questions about RRDN

You mentioned on the page that you referenced the structure of ESRGAN, so I want to know whether RRDN is based on the ESRGAN?
The parameter you referred in the page is the 'C':4, 'D':3, 'G':64, 'G0':64, 'T':10, is original ESRGAN also use the same parameter and same value?
And do you have tested other value of parameter? or this value C':4, 'D':3, 'G':64, 'G0':64, 'T':10, is the best?
which epochs you get the best val_generator_PSNR_Y result?

Hi

Yes
I used these parameters to have a fair comparison with RDN a comparable prediction times
Yes; it depends on what evaluation metric you use (want fast prediction? using MSE? VGG? etc.)
As above, and this varies highly, especially when using an adversarial net. Without gans around 40-60 epochs are enough to get something decent. I would recommend to train at least 120 epochs with the default settings


Type not inferred to &T for .borrow() on an impl Borrow<T>

rust-analyzer version: 17afa2e77 2022-01-24 stable
rustc version: rustc 1.58.1 (db9d1b20b 2022-01-20)
Bug: if s implements Borrow<T>, then RA does not infer that the type of s.borrow() is &T.

This might be a duplicate of https://github.com/rust-analyzer/rust-analyzer/issues/5514


Notifications for events

It would be cool an option that have a windows notification pop up (even with a selectable alarm sound) when the time of a new event comes
EDIT: It would be cool to also have an option (like in google calendar) to select which calendars give you the notifications, for example to have notifications only on the "work" calendar

Would like to see this feature on mobile as well, to notify X amount of time before event


Solitaire payload renders incorrectly in Timeline visualizer

http://adaptivecards.io/samples/Solitaire.html

Closing as no further complaints and the card payload itself is potentially incorrect


Why do you use global variables?

I am just wondering why do you need to use global variables. For dependencies you could use Michael Long's approach with @Injected property wrappers.
The new version of your store with the binding to action extension is amazing btw!
Great work!

never mind I just watch that How to Control the World talk... makes sense...
However in the other repo ... what not use Current.store?

@mycroftcanner Hi, I updated the file to add the link for the talk about this DI method.
I use World only for side effects like URL session, analytics, etc.


Cleanup logs in tests

🐛 Bug Report
There many extraneous logs in the test suite that can get removed.

i8next logs on many tests

To Reproduce
Run test suite
yarn test

Expected behavior
Logs statements should be reduced
Your Environment

node version: 10,12,13
os: Mac, Windows, Linux
any other relevant information

I'm working on tests now so I can take a look at this.


WIP: Add option to change neighbour distance in buffer view

There's probably some terminology I'm missing here, but these changes make it possible to set the "degree" of connectedness for including nodes in the buffer view. Here's an example at degree 2 (including neighbours of neighbours), the root node being "Network Accountability for the Domestic Intelligence Apparatus":

This is WIP because there's some cosmetic work that isn't done yet, I want to nail down the language, and, most importantly, I want to ask: Is this a feature you'd like to add?

Hey, this looks awesome! Other than the cosmetics (as you've mentioned) I think everything is good to go.

It seems useful for the edges to have arrowheads. If you're looking just one generation out, that's not necessary, but with more than one generation and it becomes possible for a child to link to one of its siblings.

https://github.com/org-roam/org-roam-server/blob/d418c632e34951d844a408ed703bb2029fdd73f2/org-roam-server.el#L206-L214
@JeffreyBenjaminBrown
You can arrowheads if you want

So far I do everything in text, but if I ever need it, I'll remember your invitation, thanks :)

OK, looks like "distance" is the graph theory way to say this, so that's what I'm going with. Here's the current state of the UI in dark mode (the colours are untouched in light mode):

Good enough for my purposes, but I'm happy to change it if there are any strong opinions.

Actually, I've spotted a bug in this:

I think the easy way to fix this is also fairly sweeping - I'd like to get rid of the size calculations in JS and do that layout in CSS instead. Is there complexity I'm missing that makes that impossible, or another reason that you'd prefer I didn't do that? I can make it work with the existing approach too, so no worries, I'd just have to work my lazy brain a bit harder.

I haven’t tested your code yet but I was suspecting this would happen. I didn’t know JavaScript, HTML, CSS before this project and I think I still don’t :D I had to make locations and sizes dynamically change depending on the window size and first thing came up to my mind was this. You can put distance input directly in to the middle if you want, would save you from a lot of trouble.
Can you also rename darkmode in the css to darkmode-distance

It's no trouble at all, that's what I mean - this way is actually easier for me. It was easier just to write the code than to explain my thinking more, so here's a couple of commits for discussion. The first one moves the dropdown sizing code into CSS, which should be a lot less vulnerable to careless coders like myself. The second shows why I called it darkmode rather than darkmode-distance: it's intended to apply to the entire page, not just the distance controls. I used it here to control the colours of the select2 dropdowns too, for example. How does this look to you?

To be honest it looks more cleaner this way. I tried to make it with CSS but CSS was hard to wield :D I will test everything when I got time. Do you still working on the PR or is it finished?

If it looks good to you, it's good by me.

Sorry for the late review, I didn't have time.

No worries! Thanks!


Outdated links

The links in the upper left corner of at https://alemangui.github.io/pizzicato/ point to version 0.3.2, which is missing some effects. Looks like 0.6.1 is the current version according to Github.

Thanks for raising this 👍  I also changed the source of the scripts to use CDN.


Documentation for adding a new language needs update

I'm interested in adding JuliaLang to sourcegraph but unfortunately the readme seems to be quite out of date:

(optional, to enable jump to definition) Ensure the language is present in the command line arguments to universal-ctags > https://github.com/sourcegraph/sourcegraph/blob/21efc6844838e773b9a8f4a7ba1d5628e8076984/cmd/symbols/internal/pkg/ctags> /parser.go#L71
-> This link doesn't exist for main

Make sure there is a mapping entry for the languageID in
https://github.com/sourcegraph/sourcegraph/blob/master/shared/src/languages.ts#L40
The url fails as the language.ts file doesn't seem to exist there

I tried adding a juliaSpec but it seems to need some more like telling sourcegraph about a new language. Changing a different spec works for me. Any suggestions?

@tjkandala I think you fixed this in https://github.com/sourcegraph/code-intel-extensions/pull/592? Can we close this?

Thanks for the update. It's still a bit unclear whether I need to run the generate and publish scripts. Julia is present in the language.ts file so it looks like it should work after adding the comment spec for it.
It doesn't though and it's a bit unclear why. I tried it out with different comment specs and changed my Julia file after checking the actual Julia comment spec.
For either of them it shows an empty hover for a few milliseconds and then disappears. Without giving feedback in the console. Is there a command line way of testing and debugging?

Thanks for the update. It's still a bit unclear whether I need to run the generate and publish scripts. Julia is present in the language.ts file so it looks like it should work after adding the comment spec for it.
It doesn't though and it's a bit unclear why. I tried it out with different comment specs and changed my Julia file after checking the actual Julia comment spec.
For either of them it shows an empty hover for a few milliseconds and then disappears. Without giving feedback in the console. Is there a command line way of testing and debugging?

It looks like this section could use a bit of an update: https://docs.sourcegraph.com/dev/how-to/add_support_for_a_language#syntax-highlighting-support
Could we add some deeper explanation or any missing steps here? cc @sourcegraph/frontend-platform and @slimsag


Mark campaign as sent after it is sent

We need two updates:

mark timestamp in the campaign entity after it is sent
after the job completes, we should mark campaign as sent

Current status:

We should have three timestamps there:

timestamp_created - after calling /push/campaign/create endpoint.
timestamp_sent - after calling /push/campaign/live/send/{id} endpoint.
timestamp_completed - after job is completed.


⚠ Bofrost.es has degraded performance

In b2a122f, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1683 ms

Resolved: Bofrost.es performance has improved in e4fbc33 after 6 minutes.


Add Dashboard Grid URLs

Situation
The operation team is currently setting dashboard grid stacks in different geolocations. It could be documented in the manual.
Todo

Add links to other dashboard URLs
List: dashboard.grid.tf, dashboard.be.grid.tf, dashboard.fin.grid.tf, dashboard.us.grid.tf, dashboard.02.grid.tf

@coesensbert any links I am missing? Thanks.

current list of mainnet backend stacks

dashboard.grid.tf (DE)
dashboard.be.grid.tf
dashboard.fin.grid.tf
dashboard.sg.grid.tf
dashboard.us.grid.tf

We can close this issue when #624 is merged.
@coesensbert I kept 02 as it still works with all nets (qa,test,dev,main). LMK if it's ok.

no please remove the 02.grid.tf as we want to remove it over time. It's the same server as the be.grid.tf one, it just exposes over two wildcard records.
02 is still there because it's hard coded in zos, but will also be changed soon. Once updated we will remove the 02.grid.tf record

Gotcha! Done (removed in the PR branch)
Do we plan on having other networks? For now they are all mainnet as I understand and no .dev, .test subdomains are available.

Gotcha! Done (removed in the PR branch)
Do we plan on having other networks? For now they are all mainnet as I understand and no .dev, .test subdomains are available.

It only reached me to expand the mainnet grid backends, not for other nets. So no for now, unless that's required.
There are two more hub's and bootstraps on the planning. We have one now in BE, so one extra in DE (the current spare one) and one in the US for now.

Good! I think if we have lots of mainnet grid backends and some hub + bootstrap as planned, we're all good. Other networks are for testing and development purposes anyway.
Thanks for the info!

Will add this link: https://github.com/threefoldtech/tf_operations/blob/master/docs/all-grid-v3-links.md
as suggested by @coesensbert


fPIC troubles? relocation R_X86_64_PC32 against symbol

Edit: a quicker/easier way to test is to paste this into libfringe/cargo.toml:
[lib]
name = "libfringe"
path = "src/lib.rs"
crate-type = ["dylib"]
Hello,
I'm unable to use libfringe with my DSO. Small test case pasted below.
= note: /usr/bin/ld: /home/maswanso/src/external/rust/libfringefpic/target/debug/deps/libfringefpic.0.o: relocation R_X86_64_PC32 against symbol `_ZN6fringe4arch3imp4swap10trampoline17h9a2ce236cc1b16f6E' can not be used when making a shared object; recompile with -fPIC
I maintain that my little test is compiled as PIC. Evidence: libfringefpic.0.o (pic) and also:
$ file libfringefpic.0.o
/home/maswanso/src/external/rust/libfringefpic/target/debug/deps/libfringefpic.0.o: ELF 64-bit LSB  relocatable, x86-64, version 1 (SYSV), not stripped
I'm quite fascinated with libfringe. I hope it's possible to use with DSOs.
Any suggestions / help would be appreciated!

Cargo.toml
[package]
name = "libfringefpic"
version = "1.0.0"
authors = ["Mark Swanson<EMAIL_ADDRESS>
[dependencies.fringe]
no-default-features = true
git = "https://github.com/nathan7/libfringe.git"
[lib]
name = "libfringefpic"
path = "src/lib.rs"
crate-type = ["dylib"]

.cargo/config

[build]
#rustflags = ["-C", "prefer-dynamic", "-Z", "incremental=/tmp/rustc_incremental", "-Z", "incremental-info"]
rustflags = ["-C", "prefer-dynamic", "-C", "link-args=-fPIC"]
rustflags = ["-C", "relocation-model=pic", "-C", "link-args=-fPIC"]
:-)

src/lib.rs

extern crate fringe;
use fringe::{OsStack, Generator};
pub fn x() {
let stack = OsStack::new(1 << 16).unwrap();
let mut gen = Generator::new(stack, move |yielder, mut index| {
let values = [1, 2, 3];
loop { index = yielder.suspend(values[index]) }
});
println!("{:?}", gen.resume(5));
}
 Running `rustc src/lib.rs --crate-name libfringefpic --crate-type dylib -g -C metadata=63492654b52cf958 --out-dir /home/maswanso/src/external/rust/libfringefpic/target/debug/deps --emit=dep-info,link -L dependency=/home/maswanso/src/external/rust/libfringefpic/target/debug/deps --extern fringe=/home/maswanso/src/external/rust/libfringefpic/target/debug/deps/libfringe-88227e5bfb249863.rlib -C prefer-dynamic -C link-args=-fPIC`

error: linking with cc failed: exit code: 1
|
= note: "cc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-m64" "-L" "/home/maswanso/.multirust/toolchains/nightly-2016-09-09-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/home/maswanso/src/external/rust/libfringefpic/target/debug/deps/libfringefpic.0.o" "-o" "/home/maswanso/src/external/rust/libfringefpic/target/debug/deps/liblibfringefpic.so" "/home/maswanso/src/external/rust/libfringefpic/target/debug/deps/libfringefpic.metadata.o" "-nodefaultlibs" "-L" "/home/maswanso/src/external/rust/libfringefpic/target/debug/deps" "-L" "/home/maswanso/.multirust/toolchains/nightly-2016-09-09-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,-Bstatic" "-Wl,-Bdynamic" "-Wl,--whole-archive" "/tmp/rustc.5dtQdVsxlbYQ/libfringe-88227e5bfb249863.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.5dtQdVsxlbYQ/libvalgrind_request-c9df0ba26d15ec95.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.5dtQdVsxlbYQ/liblibc-ad32fde1bd850538.rlib" "-Wl,--no-whole-archive" "-L" "/home/maswanso/.multirust/toolchains/nightly-2016-09-09-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "std-411f48d3" "-l" "util" "-l" "dl" "-l" "pthread" "-l" "gcc_s" "-l" "pthread" "-l" "c" "-l" "m" "-l" "rt" "-l" "util" "-shared" "-fPIC" "-l" "compiler-rt"
= note: /usr/bin/ld: /home/maswanso/src/external/rust/libfringefpic/target/debug/deps/libfringefpic.0.o: relocation R_X86_64_PC32 against symbol `_ZN6fringe4arch3imp4swap10trampoline17h9a2ce236cc1b16f6E' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value

Ok, I see that when creating a shared library the linker is smart enough to know that you can't use 32-bit relative offsets in a 64-bit system.
I tried to force R_X86_64_64 by using -C code-model=large. That didn't quite work.
rustflags = ["-C", "prefer-dynamic", "-C", "relocation-model=pic", "-C", "code-model=large", "-C", "link-args=-fPIC", "-C", "save-temps"]
I seem to be completely blocked.
Any suggestions / thoughts would be appreciated.
Thanks!

Ok, I simply upgraded to a newer nightly and the problem was resolved.

Ok, while the newer Rust compiler got me further when I circled back to my project it failed again.
I've created a github repo that contains a tiny example on how to reproduce.
Please help.

I submitted a pull request that works around the problem (with inline).
The benchmarks seem to be exactly the same, so I don't think we've lost any performance.

You should probably file a bug with rustc, seeing that something seems to have broken on its end.

https://github.com/rust-lang/rust/issues/37457

This can be fixed by appending @plt after the call instruction operand:
callq ${2:c}@plt

Amanieu - thank you. It seems you also are suggesting a change from "call" to "callq"?
Fyi I used callq ${2:c}@plt and put the #[inline(always)] back and:

the libfringe benchmarks had no difference (great)
I was able to include my patched libfringe git repo into my DSO project and it linked just fine (excellent!)

I'll submit a new pull request shortly.
Amanieu - do you have any words of wisdom that I could add to the pull request to convince Nathan that your change doesn't have any bad side effects? Thanks!

Actually that change is superseded by #62 which inlines the trampoline and eliminates the call entirely. I believe that approach is superior since it also improves performance.
Regarding the change to callq, that was unintentional. It actually does not make any difference since call and callq are identical in this case.


undertow agent test

self test result

Case description
Status
Cases

Undertow
1 passed. 0 failed
click me

Wonderful works. @ascrutae please help on this pr.

@cloudgc consider add more versions supported tests?

I am on it

From cloudgc
发件人: 吴晟 Wu Sheng
发送时间: 2018年8月13日 18:39
收件人: SkywalkingTest/skywalking-agent-testcases
抄送: cloudgc; Mention
主题: Re: [SkywalkingTest/skywalking-agent-testcases] undertow agent test(#23)
@cloudgc consider add more versions supported tests?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Add 'name' stub to String patches. Update .gitignore

Hi, I made a small fix to String patches adding 'name' method because I found an issue with another gem (bunny) that I'm using and that was throwing an exception because of the missing method.
Hope this helps.

Thanks!


Add recent songs (UI and API)

Description
We want to allows users to view their recently search AND played songs. Essentially, if you search and then play a song from the search list, that song is considered "recent".
Acceptance Criteria

We have API endpoints to:

add songs to recents
fetch recents songs,
check if a song is recent
clear all recent songs

From the search view, if no text is typed in, users should be seeing their recent searches

Closed by PR #57