chore(master): release git-jira-branch 2.0.4

:robot: I have created a release beep boop
2.0.4 (2024-05-23)
Bug Fixes

deps: bump the production-dependencies group with 7 updates (#338) (0b2038c)
deps: bump the production-dependencies group with 7 updates (#341) (9ea6d16)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ccntrq/git-jira-branch/releases/tag/git-jira-branch-v2.0.4 :sunflower:


ArraySwitch: don't render inactive inputs, resolves #332

set node dyn_input slots to inactive unless selected, resulting in skipping of rendering of those paths
Node.js: cascade UI flow state upward
early out in update_recursive if already rendered

apart from the one comment, lgtm


Document Socket client

Ref php-http/socket-client#4

:+1:
i think we might want a partial to include on all client docs to mention the plugin system. with a minimal client like this one, its particularly important. the client does not follow redirects for example.

we could add the note on plugins in the footer that talks about async and message factory (the one we said in #67 that we will separate it out later). does this client support async at all? if not, we maybe want a little table with the feature overview for each client...

IMO all clients which support async should be implemented as async in the adapter as well, but async emulation should not be done by default.

Updating according to feedback.

looks good. we could tweak the further reading, if you want. and it would be good to have input from joel on the remote_socket option. but both are imho not blockers for merging.

:+1:

:+1: except for the example :), huge thanks for taking time to do the documentation @ddeboer !

Tweaked further reading by giving some plugin examples.

:+1:


Class method argument type hints considered unused?

Support question
If I have a class method with type hints and I add "use" statements for those type hints, php-cs-fixer will remove them due to no_unused_imports. However, these seem like they're being used to me. What am I missing?
(Note: I'm using Symfony and Doctrine, so there are all sorts of autoload things going on. Is this coming into play somehow?)

Hi and thanks for your question!
With SF and Doctrine there can sure be a lot of magic going on :)
However, since a lot of people here know these stacks I wouldn't expect issues with these. Could you share a bit of sample code that is being changed incorrectly? (maybe together with the PHP version and PHP-CS-Fixer version and configuration you are using). Thanks!

The import of BarTransformer is not removed because it is considered unused but because it is superfluous: BarTransformer is declared in the same namespace as the one it is imported in, so the import statement isn't actually needed.
This topic is already discussed in #4159 so I'm closing here.


Update doc: keyvault-flexvol addon default flag

What this PR does / why we need it: Update doc to reflect keyvault-flexvolume addon is enabled by default.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #4071
Special notes for your reviewer:
If applicable:

[ ] documentation
[ ] unit tests
[ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

/lgtm


[No review]: Session consistency improvement with bloom filter approach

Background
For multi-write accounts, it is possible for clients to route write requests to any region (hub region or satellite region(s)) based on the preferred regions list. At a high-level, this can cause a backlog of changes for the hub region to “consolidate” and conflict resolve. The hub region also forwards conflict resolved changes to satellite region, hence any cross-regional replication latency coupled with regional failover can make it seem as though either the hub region or one or more satellite regions are “lagging”.
The SDK, on the other hand, ensures session guarantees through a session container which stores a single session token mapped to each physical partition. This sort of mapping leads to a “global” representation of progress a physical partition has made.  The issue here is, if this “global” representation of progress is routed to a replica in a “lagging” region, the replica responds with a 404 Read/Write Session Not Available and the SDK then needs to retry on a different replica in the same or a different region until session guarantees are met.
The pain point is excessive retries to guarantee session consistency incur additional latency through possible cross-regional calls and heightened CPU utilization on client-side application pods.
PR details
Overview
This PR moves away from maintaining a single "global" representation of the session token to maintaining a region-scoped progress for each physical partition of a container. This way, when a session token has to be resolved for a request, if the request happens to be targeted to a logical partition, then the session information can be representative of only the regions the logical partition saw requests being routed for. This way the replication target for a replica for whichever region receives the request is reduced and therefore increasing the chances of session guarantees being met without needing retries both locally and cross-regionally.
Major classes introduced
PartitionScopedRegionLevelProgress
This class maintains a double level ConcurrentHashMap which maintains mappings between partitionKeyRangeId and region-level progress. Region-level progress is another ConcurrentHashMap which maps the progress scope / region with the respective localLsn / globalLsn / session token. This class has the main logic for resolving the session token for a given request.
RegionScopedSessionContainer
This class maintains an instance of PartitionKeyBasedBloomFilter and mappings between the collectionRid and PartitionScopedRegionLevelProgress. RegionScopedSessionContainer performs checks to validate whether a request is targeted to a logical partition (thus determining whether the bloom filter is needed or not) and maintains mappings at the collection level. It also fronts invocations from upstream classes wishing to set a session token or resolve the session token for a request.
PartitionKeyBasedBloomFilter
This class encapsulates a bloom filter which stores hashed tuples where the tuples represent the effective partition key string (hashed representation of the logical partition), collection resource id and the region. This class is responsible for enumerating which regions a particular logical partition saw requests in.
Setting the session token in the RegionScopedSessionContainer
Sequence diagram
sequenceDiagram
    autonumber
    participant RXDL as RxDocumentClientImpl
    participant RXGSM as RxGatewayStoreModel
    participant SCL as StoreClient
    participant RSSC as RegionScopedSessionContainer
    participant PKBF as PartitionKeyBasedBloomFilter
    participant PSRP as PartitionScopedRegionLevelProgress

    RXDL-->>RSSC: setSessionToken()
    RXGSM-->>RSSC: setSessionToken()
    SCL-->>RSSC: setSessionToken()
    RSSC->>PSRP: tryRecordSessionToken()
    RSSC-->>PKBF: tryRecordPartitionKey()

Flow of setting a session token / progress withing PartitionScopedRegionLevelProgress
flowchart TD
    A[tryRecordSessionToken - invoked after the collectionRid and physical partiton is determined from the response] -->B[Store the mapping - global: merged session token]
    B --> C[Capture the region the request got a response from]
    C --> D[Obtain the regionId for the region]
    D --> E{Is regionId to region mapping known to the SDK}
    E --> |Yes|F{Does regionId map to a satellite region or specifically if regionId is present is session token?}
    F --> G[Store the mapping - region: localLsn and globalLsn]
    E --> |Yes|H{Does regionId map to a hub region or specifically if regionId is not present is session token?}
    H --> I[Store the mapping - region: globalLsn]
    G --> J{Is region is the first preferred readable region?}
    J --> |Yes|K[Store the mapping - region: session token from the response]
    I --> J

NOTES:

The motivation behind storing the "global" representation of the session token is to resolve the session token as is for requests which don't have logical partition scoping.
The motivation behind storing the session token as is from the first preferred read region is so it is available as is to be merged with any region-scoped session token. A region-scoped session token will mainly have localLsn of a subset of regionIds where a logical partition was resolved to.

Resolving the session token for a request in the RegionScopedSessionContainer
Sequence diagram
sequenceDiagram
    participant RXGSM as RxGatewayStoreModel
    participant STH as SessionTokenHelper
    participant RSSC as RegionScopedSessionContainer
    participant PKBF as PartitionKeyBasedBloomFilter
    participant PSRP as PartitionScopedRegionLevelProgress
    participant SR as StoreReader
    participant CW as ConsistencyWriter

    RXGSM-->>STH: 1. setPartitionLocalSessionToken()
    SR-->>STH: 1. setPartitionLocalSessionToken()
    CW-->>STH: 1. setPartitionLocalSessionToken()
    STH-->>RSSC: 2. resolvePartitionLocalSessionToken()
    RSSC-->>STH: 3. resolvePartitionLocalSessionToken()
    STH-->>PKBF: 4. tryGetPossibleRegionsLogicalPartitionResolvedTo()
    STH-->>PSRP: 5. tryResolveSessionToken()

Flow of resolving a session token within PartitionScopedRegionLevelProgress
flowchart TD
    A[tryResolveSessionToken - kicks in when the session token for the request is to be resolved] --> B{Can region scoped session token be used?}
    B --> |No| C[Return global session token]
    B --> |Yes|D[Obtain session token for first preferred read region aka base session token]
    D --> E[Iterate through regionIds in the global session token for construction of region scoped session token string]
    subgraph Loop to construct a region scoped session token string
    E --> EStart[Start iteration]
    EStart --> F{If regionId has corresponding region known to the SDK}
    F --> |No|G[Return global session token]
    F --> |Yes|H{If region has been resolved for logical partition}
    H --> |Yes|I[Append regionId=localLsn to a session token string and store max globalLsn seen so far]
    H --> |No|J[Append regionId=-1 to a session token string]
    I --> EEnd[End iteration]
    J --> EEnd
    end
    EEnd --> K[Prepend version obtained from global session token to session token string]
    K --> L[Preprend max globalLsn seen so far to session token string]
    L --> M{If merge of base session token and session token string succeeds}
    M --> |Yes|N[Return merge of base session token and session token string]
    M --> |No|O[Return global session token]

Benchmarking results
Open questions

The preferred region could be made dynamic, and this would imply the base session token changes.
The hub region could change.
When availability strategy is configured for the client, this could potentially lead to requests also being routed to other preferred regions leading to the bloom filter being filled up.

/azp run java - cosmos - tests

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure:azure-cosmos

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

Hey @jeet1995, 2 questions wrt Bloom Filters:

What was the actual error rate, in the experiment where 800 million insertions were made in Bloom Filter with expected error rate: 0.001. (code https://github.com/Azure/azure-sdk-for-java/pull/38003/files#diff-3ebb7622a9d10ed5f6e06103b7eda616c0c9ce4e1b72e88708ddf069cb5fcff8R120), how many occurrences of EPK the Bloom Filter deduced it has, but were a false positive? Does this error rate increase as the initial capacity of Bloom Filter is lowered(to conserve memory) keeping the expected error rate same, with same no of insertions: 800million? What is the impact of these false positives?
Is it possible to keep Bloom Filter in Guava Cache for a TTL amount of time i.e. 1 day/week. eg Bloom Filter 1 in Guava: Key=20240513 Value: Actual Bloom Filter1, TTL: 1 day. Bloom Filter 2 Key=20240514 and Value=Actual Bloom Filter2, TTL=1 day. In this case the old Bloom Filter can get TTL'd out and new one gets created each week/day. Would this help in reducing false positives and/or help reduce the memory footprint by lowering the capacity of Bloom Filter, as we are refreshing Bloom Filter periodically?

/azp run java - cosmos - tests

Hey @jeet1995, 2 questions wrt Bloom Filters:

What was the actual error rate, in the experiment where 800 million insertions were made in Bloom Filter with expected error rate: 0.001. (code https://github.com/Azure/azure-sdk-for-java/pull/38003/files#diff-3ebb7622a9d10ed5f6e06103b7eda616c0c9ce4e1b72e88708ddf069cb5fcff8R120), how many occurrences of EPK the Bloom Filter deduced it has, but were a false positive? Does this error rate increase as the initial capacity of Bloom Filter is lowered(to conserve memory) keeping the expected error rate same, with same no of insertions: 800million? What is the impact of these false positives?
We have a unit test SessionConsistencyWithRegionScopingTests#testFppRate - the idea is to use a shadow Set and BloomFilter and insert numbers at random into both these structures and cross-reference - when expected insertions is 10 million, as long as the actual insertion count is below 10 million, the false positive rate hovers around 0.001 - there could be 9.8K false positives or 10.1K false positives are some of the values I have seen. If 10 million more insertions are made, then all bets are off - in the unit test the false positive count increased to 110K - so a false positive rate of ~0.05. The impact of false positives is that the bloom filter will conclude that an EPK has been seen in more regions than actually is the case, so the constructed session token for session consistency guarantees will include progress information from the extra regions. The more the progress scoped into a session token, the more additional retries for the SDK to hit a replica which has caught up to this session token. (The SDK behavior as of today is to use progress from all regions so this is an optimization as 1 / 1000 requests will hit the old behavior). I can double check the 800 million scenario - it is hard to fit the shadow Set into memory for such an insertion count but let me think how to test this.
Is it possible to keep Bloom Filter in Guava Cache for a TTL amount of time i.e. 1 day/week. eg Bloom Filter 1 in Guava: Key=20240513 Value: Actual Bloom Filter1, TTL: 1 day. Bloom Filter 2 Key=20240514 and Value=Actual Bloom Filter2, TTL=1 day. In this case the old Bloom Filter can get TTL'd out and new one gets created each week/day. Would this help in reducing false positives and/or help reduce the memory footprint by lowering the capacity of Bloom Filter, as we are refreshing Bloom Filter periodically?

Clearing out the bloom filter is not a use case for this feature - without knowing what regions an EPK was seen in it is impossible to guarantee read your create / read your read behavior for this EPK. If we clear out the bloom filter it is effectively eventual consistency when reading the document associated with a given EPK.

Failures in live test pipeline w.r.t partition-split tests timing out which pass locally. Same behavior for this PR as well - https://github.com/Azure/azure-sdk-for-java/pull/38740

Merging PR as is.


Database - Add a friendly ID column for tblChallenge

Currently the tblChallenge.ID column is the only column exposed to users.  This column should be more friendly, ie: not skip around by 1000 like SQL Server likes to do from time to time.  Consider either making this column not an identity and incrementing it manually, or adding a new column that is an ID for the public to use.

Got it working, but I need to remember to modify tblChallenge to remove the identity from ChallengeId, update the column with correct challenge IDs, and update the channel names with the correct challenge IDs.


Make dark mode persist while changes pages

Feature request-
Make dark mode persist on different pages for logged in users.
Current Behavior-
Dark mode doesn't stay on changing the page like going to about page or contact etc.
Expected Behavior after this issue-
Dark mode persists between the pages for logged in users, until switched back to light mode.

Hey! I would like to work on this issue!

Hey! I would like to work on this issue!

Please mention under which program would you like to work on this..
If you are a part of GSSoC, points won't be given on issues/ PRs before 1 March.

Hey! I would like to work on this issue!

Please mention under which program would you like to work on this..
If you are a part of GSSoC, points won't be given on issues/ PRs before 1 March.
under mexili


Add known_publish_date_tags to goose configuration

Summary

Loosely enforce PEP 8
Use a class instead of a dict for the article context and publish date patterns
Move the static KNOWN_PUBLISH_DATE_TAGS list to the Configuration class
with a property and setter function allowing users to configure custom
tags for lesser used publish_date tags.

Example
import warnings
from goose3 import Goose, Configuration, PublishDatePattern

warnings.simplefilter('always', DeprecationWarning)

config = Configuration()

config.known_publish_date_tags = {'attribute': 'name', 'value': 'pubdate', 'content': 'content',
                                  'domain': 'sputniknews.com'}
# or
config.known_publish_date_tags = PublishDatePattern(attr='name', value='pubdate', content='content',
                                                    domain='sputniknews.com')

g = Goose(config)
article = g.extract(url="https://sputniknews.com/middleeast/201807281066762466-syrian-kurds-government-agreement/")

print(article.publish_date)

Follow-up from https://github.com/goose3/goose3/pull/55#issuecomment-407404766

@barrust @lababidi any thoughts on this? I expanded the initial scope of this PR a bit.

I am concerned about changing the behavior of how we allow new context managers.

That is definitely valid.

Not sure if you throw the deprecation warning on that or not, but it is something to think about.

Yeah, I handle the case that the old method is used. The implementation here should be backwards compatible. I'll add tests for this.
On second thought perhaps there should be no deprecation warning and we should explicitly allow users to either add a dict or the new class for the pattern.

On second thought perhaps there should be no deprecation warning and we should explicitly allow users to either add a dict or the new class for the pattern.

I think that would be best, allow for both methods: dict or class. Thanks!

If it makes it easier to review/merge I can remove the feature that allows for filtering a pattern for a domain.

No, it is more just a time thing. I will get to it by the end of the weekend. I have done a cursory glance at the code and didn't see anything out of the ordinary.
I am not sure there is a need for the tox.ini file as we already have a setup.cfg file that can hold the flake8 configuration information!

No, it is more just a time thing. I will get to it by the end of the weekend.

Np. I totally understand!

I am not sure there is a need for the tox.ini file as we already have a setup.cfg file that can hold the flake8 configuration information!

Moved the [flake8] section to setup.cfg.


Refactor of Spectator View (Preview)

Overview
This review refactors some previously existing code, spectator view (preview), and adds it to the newer version of the MRTK.
Changes

A new MixedRealityToolkit.Extensions directory is added for components that exist outside the main MRTK functionality
A few basic interfaces are defined to abstract out shared experience components. These will likely change long term but there are hopes that having cleaner definitions than the previous spectator view (preview) will make for a better refactoring experience
3.1) IMatchMakingService
3.2) IPlayerService
3.3) INetworkingService
3.4) ISpatialCoordinateService
Interface definitions are defined for needed spectator view functionality
4.1) IMarkerDetector
4.2) IMarkerVisual
4.3) IPlaybackService
4.4) IRecordingService
An aruco marker detector and aruco marker visual have been defined. Marker detection is conducted using a plugin built out of HoloLensForCV. TBD whether or not the licensing for this repo will suffice. (https://github.com/Microsoft/HoloLensForCV/pull/78 )
A platform switcher is added to the editor for toggling between HoloLens, android and iOS builds.
A new component, UDPBroadcastNetworkingService, acts as a simple implementation of IMatchMakingService, IPlayerService and INetworkingService. It enables devices to discover one another and send byte payloads back in forth containing information around shared spatial coordinate states
A new component, MarkerSpatialCoordinateService, allows devices to coordinate a shared application origin based on showing and detecting ArUco markers

NOTE: This change adds dependencies on Unity's AR Foundation, AR Core and AR Kit.

@chrisfromwork I'm looking at your first pass at defining a networking interface. I'll raise one of the points brought up in #3313
Based on our experiences the networking interface must provide a way to specify:

who will receive a message - all targets, subset of targets, specific target, etc.
how the message will be sent - directly to target, via central authority (if order received matters), etc.
the importance of the message - critical messages will be re-sent until target confirmation is received while other messages may be dropped, etc.

Because this config will vary message-to-message it can't be left to the implementation. But we recognize that not every app will care about how / to whom messages are sent, and that spectator view in particular doesn't and shouldn't care about these future capabilities.
We can kick this can down the road by including an optional config object in the SendData method. It can be ignored by SpectatorView's implementation, but as implementations become more sophisticated we can start packing it with config data:
    public interface INetworkingService
    {
        bool SendData(byte[] data, SendArgs args = null);
        event DataHandler DataReceived;
    }

That's just one future-proofing approach. I'm sure there are others. Let's discuss further in #3313

@Railboy this seems like valuable feedback that we should try and capture in our sharing architecture onenote.
Given this is a review for a feature branch, do you think not declaring this SendArgs type/interface function argument is enough to warrant waiting on completing this pull request? In one sense, my main motivation for this SpectatorView refactor is to call out the exchanges between networking and other components, and I think the interface stub accomplishes that even if it is subjected to change/causes breaking changes before getting the payload into the main development branch.
I also feel like this UDPBroadcast networking component may be too simple to ever be able to distinguish between different payload priorities. Are there any concerns with networking components ignoring parameters in a SendData argument? Would we want networking components to declare what arguments they actually support/use?

@Railboy I will likely check this in tomorrow to get content into this feature branch if there is no update. That going said, I am on board with refactoring any of this content before moving it into the main development to better align with our long term plans.

@chrisfromwork Nope not at all we can hammer out these details later on. Just want to make sure they're getting brought up and discussed.

Are there any concerns with networking components ignoring parameters in a SendData argument?

No, I would expect some simpler implementations to ignore them. An exception or warning would be sufficient IMO. Again, we can work out those details later.

I know this is a merged PR, but I just noticed some discussions on the INetworkingService and thought it might be useful to add some notion of connect / disconnect, along with a connection object.
In my experience, it makes more sense to think in terms of a IConnection rather than an INetworkService.
This makes it easier to differentiate clients, and add extensibility in terms of host/client specific features.

@provencher this is valuable feedback. Could you provide more context on what you would consider an IConnection? Would there be n IConnections for n clients? Would we expect there to be different networking configurations that then are surfaced as different connections?

@chrisfromwork I've been modeling my design philosphy after my experience with Hazel networking.
Here is their connection class. They don't have an interface, and simply use an abstract class, though that isn't a hard req by any means.
https://github.com/DarkRiftNetworking/Hazel-Networking/blob/master/Hazel/Connection.cs
When a user connects, a new connection object is made, and it can be stored in a list.
There is an event dispatcher for Connect, Disconnect, etc, which allow easy management of each connection state.
With the hazel model you can use udp, reliably and unreliably, as well as tcp.
For my own uses, I've found it practical to use combinations of transport protocols.
For instance, you can use multicast to broadcast your initial message to many locally connected clients, and then safely send missing packets over individual tcp connections. (Note multicasting is not a hazel feature, but easy enough to implement with dot net).
Another practical part of SendBytes, is a flag determining the send mode, especially in the case of UDP.
Hazel has Unreliable, Reliable, and Reliable Fragmented, where large messages are broken into smaller ones and reliably transmitted.


Remove invalid gym xcpretty options verify blocks

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[ ] I've updated the documentation if necessary.

Motivation and Context

Currently to use the gym xcpretty report features an empty file must be created to satisfy the verify block. This is not needed since xcpretty will take care of creating both needed directories and the resulting file as can be seen in xcpretty reporter.rb.
Description

xcpretty report creates output, don't verify that path exists before

I signed it!

hey @Dahlgren 🤚  many thx for your contribution ❤


🚀 Job Board: Add the sidebar search form

Created a basic sidebar
Use a FormView for the job_board's URL that includes the search form.
Screenshot of the webpage:

Close #119
Future tasks:

#120
#121
#126
#127

@DeanBiton Why are you testing only form/views and client tests? There is a difference here in the coverage, Is there any test in code that cover the PR? in case yes please add reference to main branch test

@Yarboa I added a new form and a view that uses this form. I have tests for the form and added new tests for the view.

@DeanBiton Why are you testing only form/views and client tests? There is a difference here in the coverage, Is there any test in code that cover the PR? in case yes please add reference to main branch test

@Yarboa I added a new form and a view that uses this form. I have tests for the form and I added more tests for the view.

There are no client tests at all for the relevant template and views


cargo-deny: 0.8.7 -> 0.8.8

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/EmbarkStudios/cargo-deny/releases.
meta.description for cargo-deny is: "Cargo plugin to generate list of all licenses for a crate"
meta.homepage for cargo-deny is: "https://github.com/EmbarkStudios/cargo-deny"
meta.changelog for cargo-deny is: ""
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.8.8 with grep in /nix/store/13ksfjnnkwk8a2b3angq9v6bbw3m2vnv-cargo-deny-0.8.8

directory tree listing: https://gist.github.com/3b46dc17f7a7fed89e15698550929154

du listing: https://gist.github.com/83ae42f7ef343809914797349b0c4c5e

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
cargo-deny

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/13ksfjnnkwk8a2b3angq9v6bbw3m2vnv-cargo-deny-0.8.8 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cargo-deny https://github.com/r-ryantm/nixpkgs/archive/01e87f9e3c2b08e2cc6b766c52c21977d8078d6b.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/13ksfjnnkwk8a2b3angq9v6bbw3m2vnv-cargo-deny-0.8.8
ls -la /nix/store/13ksfjnnkwk8a2b3angq9v6bbw3m2vnv-cargo-deny-0.8.8/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

cargo-deny

Maintainer pings
cc @matthiasbeyer for testing.

On 28-02-2021 01:16:45, R. RyanTM wrote:

https://github.com/NixOS/nixpkgs/pull/114630.patch

Diff LGTM


Figure out how to run a code action without first setting the selection

The command extract that currently first sets the selection because VSCode action execution not on cursor is finicky.  We'd like to figure out how to get this to work

We now have a solution for this which is used for comment and indents. But extract is a little bit special since you have to wait for the name popup.

Not sure this is worth the effort


[Bug]: inconsistent number handling in Candy Guard config

Issue description

initialize config with a tokenGuard with of amount X whereas X has 4 decimals
run deploy, token guard add, token guard update, token guard show ...
it will show X0000
change amount to Y
run token guard update token guard show ...
it will show Y

Relevant log output
No response
Priority this issue should have
Medium (should be fixed soon)

should be easy to fix, having a look at it


add AirPoPo to showcase

as title, thank you very much.

By analyzing the blame information on this pull request, we identified @brentvatne and @manonthemat to be potential reviewers.

@yutin1987 Can you keep the alphabetic order please.

@janicduplessis Thanks for your friendly reminder, I have done it.

@yutin1987 updated the pull request.

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.


⚠ Samsung has degraded performance

In 29d785f, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2227 ms

Resolved: Samsung performance has improved in 8547522.


copyq: 6.1.0 -> 6.2.0

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/CopyQ/versions.
meta.description for copyq is: "Clipboard Manager with Advanced Features"
meta.homepage for copyq is: "https://hluk.github.io/CopyQ"
meta.changelog for copyq is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 6.2.0 with grep in /nix/store/cxgj6chi0a2gwnfr39dzjvzgnpqvzjn7-CopyQ-6.2.0
found 6.2.0 in filename of file in /nix/store/cxgj6chi0a2gwnfr39dzjvzgnpqvzjn7-CopyQ-6.2.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
copyq

Instructions to test this update (click to expand)

Build yourself:
nix-build -A copyq https://github.com/r-ryantm/nixpkgs/archive/4f3c261a1ab0c4701a2ace822cc59af33f2ba75c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/cxgj6chi0a2gwnfr39dzjvzgnpqvzjn7-CopyQ-6.2.0
ls -la /nix/store/cxgj6chi0a2gwnfr39dzjvzgnpqvzjn7-CopyQ-6.2.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

copyq

Maintainer pings
cc @Artturin for testing.

Already up to date


Blue cursor

if you ssh and press enter until the first line gets removed, your cursor becomes blue

its a "feature", now you know that your in an remote shell


Fix issue "Parent is null"

I've got error parent is null when update information with scope.$scan() after changing array with array splice.
The commit fixes this.

Hello!
I think the commit will not give you an expected result, it doesn't generate DOM tree, it just hides a error.
Can you give me the example? I think, maybe providing a warning or a temporary parent element is better...?
Thank you.

I know that it's just hides error, but with exception it not generate anything at all. With this commit all nodes generates as expected.
I will make an example bit later

Here is an example:
http://jsfiddle.net/caee43nn/1/

http://jsfiddle.net/lega911/818h9d04/
Problem is here:

al-ifnot="threads.length == 0" doesn't make sense, because if length==0, then no row is there.
so, it equals to

al-repeat has bigger priority, so it creates rows, then al-ifnot tries to check it, al-ifnot works for every new row.
More important, al-repeat and al-ifnot both rebuild DOM, so it's usually bad idea to use them for the same element, because they try to cut the same element, and you will have that error, it's some limitation, you can't use al-repeat/al-if/al-include on the same element, you can place al-repeat/al-if on child/parent element, it's ok.

I will think how to improve it

ok, thank you so much!
Removing al-ifnot fixed issue with switching pages, but issue "parent is null" is still present for me.
I guess it's because of tablesorter, because when I remove it - i see no error.

issue seems was because of bugs in old tablesorter, new tablesorter version fix this. Anyway, thank you!

now alight displays error on conflict cases (al-repeat + al-if, al-if + al-include, etc)


Problem installing guess-language-spirit

Hi @miguelgrinberg,
First, I would like to say thanks to you for your work. I'm reading and typing your project.
Now, I'm on chapter 14, and I can't install guess_language-spirit (with pipenv or pip)
(flask_mega_tutorial-x-oOu59U) ➜  flask_mega_tutorial git:(master) pipenv install guess_language-spirit
Installing guess_language-spirit…
Collecting guess_language-spirit

Error:  An error occurred while installing guess_language-spirit!
  Could not find a version that satisfies the requirement guess_language-spirit (from versions: )
No matching distribution found for guess_language-spirit

(flask_mega_tutorial-x-oOu59U) ➜  flask_mega_tutorial git:(master) pip install guess_language-spirit
Collecting guess_language-spirit
  Could not find a version that satisfies the requirement guess_language-spirit (from versions: )
No matching distribution found for guess_language-spirit

My python version is 3.6.4. My solution has been downloading the package (tar.gz) and installs it manually.
Have you any idea?

Hi,
Same thing is happening to me!
I noticed the name of the lib in requirements.txt has no underscore, but It didn't work either
requirements.txt:
...
guess-language-spirit==0.5.3
...
Shouldn't it be 'guess_language-spirit==0.5.3'?

Oh yeah, so sorry about that! It's now fixed.

Hello everyone. I know the issue is closed but I had trouble installing the package and resulted in installing it manually

Hi everyone i still cannot install guess_language-spirit.
Could not find a version that satisfies the requirement guess_language-spirit (from versions: )
No matching distribution found for guess_language-spirit

@Xerrex My guess is that it was a temporary problem. I just verified that the guess_language-spirit package is still available on PyPI. Maybe PyPI was temporarily down when you tried, or your network was down. Give it another try, I just tested it here and it installs fine.

@miguelgrinberg Will keep trying but it has just failed. I ran pip install guess_language-spirit from here

Try install enchant before pip install:
apt-get install python3-enchant

@neo1691 I'll fix it, thanks!

:face_with_head_bandage: I still have not managed to install that guess_language-spirit am using
python 3.6.4

I can install  guess_language-spirit without any error. But when I run Flask run, I got a SyntaxError: invalid syntax, which is "from guess_language-spirit import guess_language". It seems like it is illegal to use "-" in "language-spirit".
someone known why?thanks

Could not find a version that satisfies the requirement guess_language-spirit==0.5.3 (from -r requirements.txt (line 18)) (from versions: )
No matching distribution found for guess_language-spirit==0.5.3 (from -r requirements.txt (line 18))

i still cannot install guess_language-spirit.

@imbyron the problem has to be on your side, I see version 0.5.3 in pypi: https://pypi.org/project/guess_language-spirit/0.5.3/

I'm also getting this error, but I'm doing the tutorial using pipenv instead of the instructed virtual environment. Not sure if that makes a difference.
ERROR: ERROR: Could not find a version that matches guess-language-spirit
No versions found

@sophyphreak this package has a tricky name, guess_language-spirit. Note that the first separator is an underscore, the second a hyphen. You used hyphens for both.

@miguelgrinberg I'm very sorry to contradict you, but whenever I run either pipenv install guess_language-spirit or pipenv install guess-language_spirit (the second is what is in the paper version of you very good book (which I'm very grateful you wrote)) whenever I wrun either od those scripts, it gets saved in my pipenv file as guess-language-spirit  and I don't know why. I'm not saying I'm not doing anything wrong, but if I'm doing something wrong, it's not that. (Again, thank you a lot for writing the book and keeping up with these github issues.)

@sophyphreak sorry, the package name is guess-language_spirit, it is the second separator that is an underscore, my bad. You can see this package in its PyPI page at https://pypi.org/project/guess_language-spirit/.
I don't use pipenv so I'm not super experienced with it, but after a quick test I can confirm that the package appears with two hyphens in the pipfile. But regardless of that, it installs and works fine.
(venv) $ pipenv install guess-language_spirit
Creating a Pipfile for this project…
Installing guess-language_spirit…
Adding guess-language_spirit to Pipfile's [packages]…
✔ Installation Succeeded
Pipfile.lock not found, creating…
Locking [dev-packages] dependencies…
Locking [packages] dependencies…
✔ Success!
Updated Pipfile.lock (9858d5)!
Installing dependencies from Pipfile.lock (9858d5)…
  🐍   ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 1/1 — 00:00:00
(venv) $ cat Pipfile
[[source]]
name = "pypi"
url = "https://pypi.org/simple"
verify_ssl = true

[dev-packages]

[packages]
guess-language-spirit = "*"

[requires]
python_version = "3.7"


Add Documentation - skipLast - Real World Example

Add a real world code example to the documentation to demonstrate how the operator can be used. Provide code that demonstrates what it can do but also a real world example of when you would use it.

@RHGeek Is there a specific reasoning you're spamming the repository with 3 issues per operator about documentaiton?

@david-driscoll it is a part of the docs initiative to add these for missing operators https://github.com/ReactiveX/rxjs-docs/issues/4

Should that not go on the rxjs-docs repo?

The discussion / decision was to add them over here. There are some previously made, these were the last that were needed. Looping in @ladyleet for explanation.

@rhgeek no, we made a decision to add all issues to the rxjs docs repo and it was already done - check the issues on the docs repo! Thx for your effort though. Ashwin did this awhile ago.

@ladyleet oh no. that was my misunderstanding. when i created the first 3 and linked them, we said everything looked good and then i created the first batch. I was finishing them up. my apologies and mess up. I'll clean this mess up then.

@rhgeek no worries! It was awhile ago so someone proceeded on the issue so they could get going with the docs.

Hahaa love it! :)

@rgbkrk I didn't know about it either until I read your comment :(.

well, at least there is some positive to my goofing then @rgbkrk and @martinsik. Glad to raise awareness ;-)

Happy about it too! We def welcome more contributors to the docs!


Test run failures should not cause subsequent tests to time out.

example:
test/playwright_test.exs:7
** (FunctionClauseError) no function clause matching in Playwright.Browser.new_page/2

The following arguments were given to Playwright.Browser.new_page/2:
    # 1
    {:error, %Playwright.Channel.Error{message: "Timeout 30000ms exceeded."}}
    # 2
    %{}

Attempted function clauses (showing 1 out of 1):
  def new_page(%Playwright.Browser{session: session} = browser, options)

stacktrace:
  (playwright 0.1.17-preview-6) lib/playwright/browser.ex:153: Playwright.Browser.new_page/2
  test/playwright_test.exs:3: Playwright.PlaywrightTest.__ex_unit_setup_0/1
  test/playwright_test.exs:1: Playwright.PlaywrightTest.__ex_unit__/2

👍🏻  We see this when we look for an element that doesn't exist within the timeout, the subsequent tests that re-use the browser don't recover. We'd like to see these timeouts returned as error tuples that don't crash the browser ideally
cc @mattwynne


allow pins to be zapped but not from pin position

This allows pins to be zapped and shown when they aren't pinned in the ranking for the page, eg in top, home, recent, or when visited directly.
This solves some of the issue presented in #773 and some the issues to be solved in #772 without introducing anything too new. It doesn't solve every corner of the issue but I think it might solve a goldilocks amount.
Merging immediately.

Mhh, you mentioned here that pinned posts no longer disappear from home but they do:
https://github.com/stackernews/stacker.news/assets/27162016/1b06f297-3d40-421a-9882-ada5b6e962bc


0p4-beta url link broken in recent months

This line is invalid for recent months (i.e. >04/24) when fetching 0p4-beta
https://github.com/ecmwf/ecmwf-opendata/blob/fdc807cff3f988ecba778e5b8920b6eedd6b2767/ecmwf/opendata/client.py#L233
It should not remove the folder prefix as both 0p25 and 0p4-beta reside in the same folder.

Is there anyone at ECMWF still maintaining this repo?...


Adds codecov.

🎉 New feature
Related to #https://github.com/maliput/maliput_infrastructure/issues/302
Summary
TODO
Info

https://github.com/colcon/colcon-mixin-repository/
https://github.com/colcon/colcon-lcov-result
https://github.com/ros-tooling/action-ros-ci#integrate-action-ros-ci-with-codecov
https://docs.codecov.com/docs

Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if it affects the public API)

Probably disabling branches checks makes sense. I will see configurations on other public projects

One configuration I tried in another branch is to set up components, one per each namespace:
This way we can get information of test coverage per each namespace:

Even though it is interesting, the amount of GH Action checks distracts a bit
  codecov.yaml ->

component_management:
  default_rules:  # default rules that will be inherited by all components
    statuses:
      - type: project # in this case every component that doens't have a status defined will have a project type one
        target: auto
        removed_code_behavior: fully_covered_patch
      - type: patch
        target: auto
        removed_code_behavior: fully_covered_patch

  individual_components:
    - component_id: api  # this is an identifier that should not be changed
      name: api  # this is a display name, and can be changed freely
      paths:
        - include/maliput/api/**
        - src/api/**
    - component_id: base
      name: base
      paths:
        - include/maliput/base/**
        - src/base/**
    - component_id: common
      name: common
      paths:
        - include/maliput/common/**
        - src/common/**
    - component_id: geometry_base
      name: geometry_base
      paths:
        - include/maliput/geometry_base/**
        - src/geometry_base/**
    - component_id: math
      name: math
      paths:
        - include/maliput/math/**
        - src/math/**
    - component_id: plugin
      name: plugin
      paths:
        - include/maliput/plugin/**
        - src/plugin/**
    - component_id: routing
      name: routing
      paths:
        - include/maliput/routing/**
        - src/routing/**
    - component_id: test_utilities
      name: test_utilities
      paths:
        - include/maliput/test_utilities/**
        - src/test_utilities/**
    - component_id: utilities
      name: utilities
      paths:
        - include/maliput/utilities/**
        - src/utilities/**


Create Count sort.php

Is this possible to merge this file?? Will this count towards hactoberfest 2020?

Closing this PR as it has become stale with no activity in a very long time


refactor: move ef tests to own testing crate

Motivation
I wanted to move the EF tests out of the main CLI since it does not make sense that it is user facing, support additional EF tests down the line, and create a new crate namespace specifically for more complex tests
Solution
I moved it to its own crate with abstractions based off of Lighthouse's testing crate. The main idea here is that there are different types of tests in https://github.com/ethereum/tests and we are currently only running a subset. Some of them might be of interest later on, e.g. the trie test, RLP tests and so on
The tests are feature gated to ensure no one accidentally runs them without the required files. The tests can be run with make ef-tests or manually by cloning the tests repo into testing/ef-tests/ethereum-tests and running cargo test -p ef-tests --features ef-tests
The reason for the testing subdirectory is to logically group other larger integration tests later on and possibly build common testing components in there for reuse (e.g. testnets)
I also cleaned up the test runner that was moved over from the CLI a bit so it is easier to reason about
Follow ups
Here are some possible follow ups (I will create issues for each if this is merged):

Add the ValidBlocks and InvalidBlocks suites. Currently we don't run these, presumably because they are formatted a bit different, but it might be worth runing them regardless. A new Suite type can be implemented for this if needed
Add the TransitionTests suite for testing fork transitions (we can't do this rn either)
Calculate the state root when there is no post state for the test cases, currently we don't do this, I am not sure why.

Codecov Report

Merging #2847 (b5f4189) into main (d6ccab1) will decrease coverage by 57.80%.
The diff coverage is 22.89%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##             main    #2847       +/-   ##
===========================================
- Coverage   71.44%   13.65%   -57.80%
===========================================
  Files         506      510        +4
  Lines       66256    66213       -43
===========================================
- Hits        47339     9043    -38296
- Misses      18917    57170    +38253

Flag
Coverage Δ

integration-tests
13.65% <22.89%> (-3.74%)
:arrow_down:

unit-tests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

bin/reth/src/cli.rs
0.00% <ø> (-20.74%)
:arrow_down:

bin/reth/src/lib.rs
0.00% <ø> (-100.00%)
:arrow_down:

testing/ef-tests/src/assert.rs
0.00% <0.00%> (ø)

testing/ef-tests/src/lib.rs
0.00% <0.00%> (ø)

testing/ef-tests/src/models.rs
0.00% <0.00%> (ø)

testing/ef-tests/src/cases/blockchain_test.rs
4.76% <4.76%> (ø)

testing/ef-tests/src/case.rs
42.85% <42.85%> (ø)

testing/ef-tests/src/result.rs
68.62% <68.62%> (ø)

testing/ef-tests/src/suite.rs
92.30% <92.30%> (ø)

... and 387 files with indirect coverage changes

Really great cleanup 💯


Enhancements based on polyglot example

deriving service name from  Endpoint contained in annotation (not binary as before)
instance details view  if url == null it shows service name
changed client spans of C* requests to use name query(the same as mysql instrumentation)  and added binary annotation sql.query with a query statement.
spanService#getSpan adds client's binary annotations if URL of server span is null.

Review notes:
please run polyglot-example
Bugs:

roda endpoint it not shown in distributed tracing tab (instance detail view is ok) -> FIXED
call curl -ivX POST -H 'Content-Type: application/json' 'http://localhost:3001/nodejs/createUser' -d '{"name": "jdoe"}' and  curl -ivX POST -H 'Content-Type: application/json' 'http://localhost:3000/dropwizard/users' -d '{"name": "jdoe"}' or curl -ivX POST -H 'Content-Type: application/json' 'http://localhost:3003/wildfly-swarm/users' -d '{"name": "jdoe"}'. Root node does not show option to select root dropwizard or wildfly-swarm as an option. (This might not be related to polyglot example.) @objectiser what do you think (jira https://issues.jboss.org/browse/HWKAPM-630)?

@objectiser could you please review?

@objectiser could you please rereview?


Build fail for OsX

Error in benchmark/ametsuchi/cache_benchmark.cc:56:25:
error:
moving a temporary object prevents copy elision
[-Werror,-Wpessimizing-move]
cache.put(*begin, std::move(Page()));

Use markdown next time please.


index-node API fails for non-ethereum subgraphs

When trying to get the status for subgraphs not on ethereum, for example, with the query
{
  indexingStatusForCurrentVersion(subgraphName: "lavabyrd/osmosis-block") {
    entityCount
    synced
    chains {
      network
      chainHeadBlock {
        number
        hash
      }
      latestBlock {
        number
        hash
      }
    }
  }
}

the server returns an error:
{
  "errors": [
    {
      "message": "Store error: store error: Cannot parse H256 value from string `b161...031`: Invalid input length"
    }
  ]
}

This is most likely because this EthereumBlock struct wants an H256; it should just work with any old Bytes

I believe this issue isn't limited to non-ethereum chains
Here is a mainnet subgraph that gives the same error
curl 'https://api.thegraph.com/index-node/graphql' \
  --data-raw '{"operationName":null,"variables":{},"query":"{indexingStatusForCurrentVersion(subgraphName: \"fredlacs/arb-bridge-eth\") {subgraph}}"}' \
  --compressed

{"errors":[{"message":"Store error: store error: Cannot parse H256 value from string `1936a1c6f98b02b678ea476b8301c9e278fbef04ffb81fa1e92ba8a099a7113b354027b866d328eb3cb6aea11d3a516d`: Invalid input length"}]}

@leoyvens is the fix deployed?

Hi guys, so wen merge? A lot of our service are down because of this.

Hi guys, so wen deployment? A lot of our service are down because of this.

In case it helps, we were able to work around it by querying _meta in the subgraph api instead of index-node
https://github.com/OffchainLabs/arb-token-bridge/pull/319

Hi guys, so wen deployment? A lot of our service are down because of this.

In case it helps, we were able to work around it by querying _meta in the subgraph api instead of index-node OffchainLabs/arb-token-bridge#319

Appreciate this!

This is now deployed. If the _meta field covers your use case, that is preferrable.


fix(CLOUDDST-24922): retry cosign in signing task

Retry failed cosign so that signing doesn't fail with temporary issues on pushing to quay.io.

I'm not sure we should do this before https://issues.redhat.com/browse/RELEASE-1251 is complete

I think RELEASE-1251 is to make it safe to retry the whole rh-sign-image-cosign task (maybe by checking if signatures exist before signing?), which is not conflict with retrying a single failed cosign command here.

I'm not sure we should do this before https://issues.redhat.com/browse/RELEASE-1251 is complete

I think RELEASE-1251 is to make it safe to retry the whole rh-sign-image-cosign task (maybe by checking if signatures exist before signing?), which is not conflict with retrying a single failed cosign command here.

You're right, sorry for the noise. I saw retries: 3 in a yaml file and assumed it was a pipeline yaml having the task retry 3x. Approved

/ok-to-test

/retest

/ok-to-test

/retest
Failed because multiplatform controller didn't start up

/ok-to-test

/retest

/retest

/ok-to-test

/retest


"Brăești", "Poiana", "Popeni" and "Vâlcelele" are listed in the drop-down menu

Description:
"Brăești", "Poiana", "Popeni" and "Vâlcelele" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Brăești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Brăești, Botoșani (Brăești)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 1
Type "Poiana" in the search bar.

Expected results
The location is listed in the drop-down menu as "Poiana, Botoșani (Brăești)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Type "Popeni" in the search bar.

Expected results
The location is listed in the drop-down menu as "Popeni, Botoșani (Brăești)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Type "Vâlcelele" in the search bar.

Expected results
The location is listed in the drop-down menu as "Vâlcelele, Botoșani (Brăești)".


ci: e2e optimism requires create-relayers job

Is there a reason why this was missing?

Hm, interesting, why does that job need the create-relayers job?

Hm, interesting, why does that job need the create-relayers job?

How are messages relayed in e2e tests? Ah wait, didn't have the Optimism docker setup its own relay? That would explain it.

Ok I just verified that optimism is the only e2e test that does not use our relayer for l1 resolution. However, it would be good if we did so...
This effectively means we are not testing our optimism relayer at all in a system test?

Ok I just verified that optimism is the only e2e test that does not use our relayer for l1 resolution. However, it would be good if we did so... This effectively means we are not testing our optimism relayer at all in a system test?

Yeah, that's pretty much always been the case. :sweat_smile:


Broken tilde key on german keyboard

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: MacOS Sierra (10.12.6)
Hyper.app version: 1.4.2
Link of a Gist with the contents of your .hyper.js: https://gist.github.com/hpohlmeyer/293b27027da45b31fa047ba563fd3dde
Relevant information from devtools No definition for keyCode: 229
The issue is reproducible in vanilla Hyper.app: yes

Issue
I am on a german keyboard layout, which "caches" the tilde key, for combination with other characters. Normally you could get the tilde character by pressing its shortcut (alt+n) and hit space. Since the tilde can not be combined with the space character, this results in the single tilde character (~). Since the last update, this behavior is broken.
The tilde key is stashed inside the text cursor and you type behind it. The only way to get the tilde character is to enter it multiple times. However, it will still be displayed inside the text cursor.
Here is a video, that should do a better job of explaining the problem:

I was going to create a similar issue.
I also can't combine special characters with letters, for example ˜ with n or ´with e.
I'm using MacOS Sierra (10.12.6) as well.

#2140
Probably the same issue.

Same issue here. US International keyboard on Mac Sierra.

Duplicate of #2140
Thank you for your feedback

Duplicate of #2140

Thank you for your feedback


Website Icon

The website doesn't have an icon! It just has the browser-specific default icon, this is an issue and should be fixed!
(Maybe use that snazzy blue/purple icon @2003cah made in that irccloud discord meme)

Do you mean a favicon?

yes i forgot the word

Consider your idea c o n s i d e r e d.

many thanks

Since cah has the image....

@2003cah get that image or your fired

If anything I'll probably just design something unique for the favicon

Then by all means please do

Wow rude

This is your motivation to make a favicon

When you literally already forgot and it's only been 12 hours

What should I make as a favicon, anyway?

I have no idea, just make something that combines a cat and the irccloud logo?

It took about 5 minutes, but try this, see if you can even see the catto in favicon form

Its great
10/10
whose cat is it?

V
E
R
Y

G
O
O
D

Pretty sure that's cah's cat

Consider this issue dabbed on


DRILL-5674: Support ZIP compression

Added ZipCodec implementation which can read / write single file.
Revisited Drill plugin formats to ensure 'openPossiblyCompressedStream' method is used in those which support compression.
Added unit tests.
General refactoring.

Jira - DRILL-5674.

@paul-rogers addressed code review comments.

Thanks for the answers to my questions. LGTM.
+1


Replace loading indicator

Use the following animation in place of the current 3-bar loading animation:
https://codepen.io/ruigewaard/pen/dyKZYQ

I uh ... I think this is a bit much:

I agree with instead using the logo is some form.
Or just ... not changing what already looks totally fine?

@nicolaus-sherrill please run a design cycle on this and make sure it's integrated into Figmas before engineering spends time on it.

We don't have an animated logomark.

I agree with @DarksightKellar the one above looks a bit too much.
I can look at some options, but I prefer the current one than this one.

Nice , @xanaramoss . Excited to get your take rest of @decentdao/design
This also has potential to be picked up now we have more progress on hats

when @decentdao/design has agreed on one of the options, we can move this to Ready

@decentdao/engineering @xanaramoss The point of this issue was to get a quick change to the element preloader per Parker's request with something else already created before doing anything more custom.
Suggest implementation of the original suggestion would be using a white alpha 4% color so that it would be very subtle over the cards. If others have suggestions of alternatives to swap in, I'm open to them, but Parker wants a change here.
My preferred custom solution would be to display an empty state of loading elements with a glare moving across the element (check youtube on a poor connection mobile for reference of this type of pattern), but that is going to take more work than swapping something stock.

@decentdao/engineering @xanaramoss The point of this issue was to get a quick change to the element preloader per Parker's request with something else already created before doing anything more custom.
Suggest implementation of the original suggestion would be using a white alpha 4% color so that it would be very subtle over the cards. If others have suggestions of alternatives to swap in, I'm open to them, but Parker wants a change here.
The ask was something more appropriate to the brand identity and much more subtle than the current three growing/shrinking bar design.
If we are going to produce something custom, my preferred solution would be to display an empty state of loading elements with a glare moving across the element (check youtube on a poor connection mobile for reference of this type of pattern), but that is going to take more work than swapping something stock.

@nicolaus-sherrill thanks for the context!
With the alpha I think that one might work hell. What about the one I did but with Alpha? Is it too much? It is because it's a repetitive element it might be too distracting with the circular movement?
For sure I can create one with your suggestion, but I need more visual cues before animating. Is this what you are referring too?

For sure I can create one with your suggestion, but I need more visual cues/references before animating. Something like this?

Yes, exactly, something like that! Per standups last week, engineering believes implementing it won't be too big of a lift. I think we also have additional design responsibility to create empty-state designs of components that are loaded in this way to handoff to ENG as part of this work.
Tom and I are going to discuss design backlog tomorrow and prioritize items, with this top-of-mind.


Cstore crashing server when enabled, not used

Hi Citus people,
We have very unusual case. Our postgres process crashes every time when we enable cstore_fdw. We don't use it, just build dependencies, put cstore_fdw in postgresl.conf file and create extension.
Server is postgres 9.6 and cstore_fdw is 1.5 on CentOS 7.
We get  server crashes on every insert, even though cstore is just enabled and not used. We tested that over last few days and we are sure cstore is causing problems, cause in the moment we remove it from shared_preload_libraries and restart server, everything works as expected. We get segmentation faults and server crashes and reason is "current transaction and exit, because another server process exited abnormally and possibly corrupted shared memory" and our postgres log is full of these lines. After that database get in recovery mode. We also have a lot of
`LOG:  all server processes terminated; reinitializing
LOG:  database system was interrupted; last known up at 2016-12-13 12:47:07 UTC
LOG:  database system was not properly shut down; automatic recovery in progress
LOG:  redo starts at 84/2DFFE8A8
`
Our query is `insert into posttag (domainid, postid, tagid)
select distinct t.domainid, t.postid, a.tagid
join tag a on t.domainid = a.domainid and t.tag = a.name
where 1=1
and t.domainid = p_domainid
and t.item = p_item
and t.processid = p_processID
and not exists (select 1 from posttag where domainid = t.domainid and postid = t.postid and tagid = a.tagid)` and our conf is (writing part of conf that seems related)`
shared_buffers = 4GB
work_mem = 1536MB
maintenance_work_mem = 1536MB
shared_preload_libraries = 'cstore_fdw'
effective_cache_size = 30GB`

Hello @dragomirr
That is a weird case, insert query on a different table should not trigger cstore_fdw at al.
Could you get a call stack to see where it crashes ? Also, could you double check if cstore is build against correct postgresql version in case there are multiple PG instances.

@dragomirr
So far I am not able to reproduce it locally.
My setup

centos-7.2.1511, kernel 3.10
postgresql 9.6.1 installed from postresql yum repo
cstore_fdw 1.5

Could you please share more information on your setup, schema and the complete query. This seems to be missing some parts.
thanks

I've missed to provide some important information. This happens when we have large datasets parallel insert and/or update.  Here is one of the queries, we have few of them (similar, not exact) running at the same time.
Also, I have checked, cstore is build againg postgres 9.6

insert into postrefererdomain (domainid, tzdate, referertypeid, domainname, postid, articlereads, timebounce, attentionminutestotal, attentionminutecount, articlereads100, averagereaddepthtotal, averagereaddepthcount, authors, sections, tags, createdate, longtail)
select t.domainid, t.tzdate, t.referertypeid, t.domainname, t.postid, t.articlereads, t.timebounce, t.attentionminutestotal, t.attentionminutescount, t.articlereads100, t.averagereaddepthtotal, t.averagereaddepthcount, t.authors, t.sections, t.tags, t.createdate, t.longtail
from ( select t.domainid, t.tzdate, t.referertypeid, t.referrer as domainname, t.postid, sum(coalesce(t.articlereads,0)) as articlereads, sum(coalesce(t.timebounce,0)) as timebounce, sum(case when coalesce(t.attentionminutestotal,0) < 0 then 0 else coalesce(t.attentionminutestotal,0) end) as attentionminutestotal, sum(case when coalesce(t.attentionminutestotal,0) < 0 then 0 else coalesce(t.attentionminutescount,0) end) as attentionminutescount, sum(coalesce(t.articlereads100,0)) as articlereads100, sum(coalesce(t.articlereads0,0)*0 + coalesce(t.articlereads10,0)*10 + coalesce(t.articlereads20,0)*20 + coalesce(t.articlereads30,0)*30 + coalesce(t.articlereads40,0)*40 + coalesce(t.articlereads50, 0)*50 + coalesce(t.articlereads60,0)*60 + coalesce(t.articlereads70,0)*70 + coalesce(t.articlereads80,0)*80 + coalesce(t.articlereads90,0)*90 + coalesce(t.articlereads100,0)*100) as averagereaddepthtotal,sum(coalesce(t.articlereads0,0) + coalesce(t.articlereads10,0) + coalesce(t.articlereads20,0) + coalesce(t.articlereads30,0) + coalesce(t.articlereads40,0) + coalesce(t.articlereads50,0) + coalesce(t.articlereads60,0) + coalesce(t.articlereads70,0) + coalesce(t.articlereads80,0) + coalesce(t.articlereads90,0) + coalesce(t.articlereads100,0)) as averagereaddepthcount, p.authors, p.sections, p.tags, p.createdate, case when t.tzdate >= p.createdate + p_daysLimitForLongTail and p.createdate > '1970-01-01' then 1 else 0 end as longtail from widbdataexchange.dp_refererstat_tmp t join post p on t.domainid = p.domainid and t.postid = p.postid where 1=1 and t.domainid = p_domainid and t.item = p_item and t.processid = p_processID group by t.domainid, t.tzdate, t.referrer, t.referertypeid, t.postid, p.authors, p.sections, p.tags, p.createdate ) t
where 1=1 on conflict (domainid, tzdate, referertypeid, domainname, postid) do update  set articlereads = postrefererdomain.articlereads + excluded.articlereads, attentionminutestotal = postrefererdomain.attentionminutestotal + excluded.attentionminutestotal, attentionminutescount = postrefererdomain.attentionminutescount + excluded.attentionminutescount, articlereads100 = postrefererdomain.articlereads100 + excluded.articlereads100, averagereaddepthtotal = postrefererdomain.averagereaddepthtotal + excluded.averagereaddepthtotal, averagereaddepthcount = postrefererdomain.averagereaddepthcount + excluded.averagereaddepthcount

We encounter segmentation faults.
And the issue exists even when foreign tables are not accessed at all.
segfault_trace.txt

Hello @damirda @dragomirr
I have added a check inside utility function in
Could you please see if the fix in https://github.com/citusdata/cstore_fdw/tree/utility_crash fixes the problem ?
thanks

Hi @mtuncer , we tried fix and it does not fix the issue.

Could you provide a call stack ? Also do you have another extension installed along with cstore_fdw, if so in which order is it inside shared_preload_buffers ?

Hello,
I ran into a similar issue today on my macbook.

Postgres installed from macports (postgresql96 @9.6.3_0) on Mac OS Sierra
cstore_fdw.so (built from source I think). It's been a while...

I was able to consistently reproduce the crash using this test case: https://gist.github.com/emiel/4d4fd8c5c5ba9173e3175a08bb055be4
The segfault appears to happen when invoking "truncate {table}".
(lldb) bt
* thread #1, stop reason = signal SIGSTOP
  * frame #0: 0x00000001016aae9f postgres`ExecuteTruncate + 228
    frame #1: 0x0000000102035791 cstore_fdw.so`CStoreProcessUtility + 960
    frame #2: 0x00000001016fa614 postgres`_SPI_execute_plan + 758
    frame #3: 0x00000001016fac2a postgres`SPI_execute_plan_with_paramlist + 93
    frame #4: 0x00000001020bea50 plpgsql.so`exec_stmt_execsql + 184
    frame #5: 0x00000001020bb909 plpgsql.so`exec_stmt + 229
    frame #6: 0x00000001020ba5d1 plpgsql.so`exec_stmts + 35
    frame #7: 0x00000001020b88d8 plpgsql.so`exec_stmt_block + 892
    frame #8: 0x00000001020b7a12 plpgsql.so`plpgsql_exec_function + 570
    frame #9: 0x00000001020b4252 plpgsql.so`plpgsql_call_handler + 193
    frame #10: 0x00000001016de3a0 postgres`ExecMakeFunctionResultNoSets + 186
    frame #11: 0x00000001016dd963 postgres`ExecProject + 418
    frame #12: 0x00000001016f113e postgres`ExecResult + 177
    frame #13: 0x00000001016d7c40 postgres`ExecProcNode + 96
    frame #14: 0x00000001016d4a4e postgres`standard_ExecutorRun + 257
    frame #15: 0x00000001017cccf8 postgres`PortalRunSelect + 245
    frame #16: 0x00000001017cc90f postgres`PortalRun + 488
    frame #17: 0x00000001017ca870 postgres`PostgresMain + 5692
    frame #18: 0x0000000101771dca postgres`PostmasterMain + 7390
    frame #19: 0x000000010170c60e postgres`main + 1140
    frame #20: 0x00007fffeb4fe235 libdyld.dylib`start + 1
    frame #21: 0x00007fffeb4fe235 libdyld.dylib`start + 1

Let me know if you need more info as I can still reproduce the issue.

@emiel thanks for the report. I will look into it.
This has a different call stack than the other reports. Also it requires 5 calls to a plpgsql function.
Can you try with the latest (v1.6) release of cstore_fdw if you haven't so ?
thanks

@mtuncer I had another look and I had 1.5 on my system. I tried with 1.5.1 and I get the segfault. I also tried 1.6 and then it appears to work, no segfault. So it looks to have been resolved in 1.6. Yeah!

@emiel great, be happy to see it is fine on your side

@mtuncer  In our case also, truncate  triggered segfault. 1.6 is on testing now

it was fixed in #184


Rethink the way notifications are sent to gRPC stream watchers

Currently notifying cache watchers is a manual process, we instrument the code path to defer a notification unconditionally. This is conservative and makes reasoning about notifications straight forward (we don't have e2e test coverage about version counters on caches, which reflects how many times notify has been called).
However there are downsides

Each call to update will trigger a stream to envoy, parse and reload on its end, this is not cheap for large cache sizes
This scales poorly in load testing and high update rate scenarios where lots of data is being changed in bulk.

This is the sequences of changes I propose

We instrument the caches so they know if there has been a change to their contents; initially this is just a sequence counter that is ticked when there is an Add or Remove.
We replace calls to notify in the per object code paths with a more general call; maybeNotify?, that is called unconditionally on the way out of the ResourceEventHandler code path. maybeNotify, as its name suggests will not notify if the internal sequence counter has not updated since the last maybeNotify.
When caches can choose to not notify, we can wrap the 4 caches in a single meta maybeNotify call and move that higher up the stack to the buffer layer so the sequence is; receive notification off channel, process then call maybe notify which will notify watchers for all affected caches.
We can then implement delayed notifications by running timer that starts when an update arrives at the buffer and is reset when another notification arrives. In that way we can have a small update window to batch updates if there is data in the buffer. This could probably be simulated with a call to len(buffer) after the update has been processed to see if there is another update immediately following the one we just updated.

Not for 0.6, moving to the backlog.

Related to #499. Scheduling to 0.14 to resolve by 1.0.0.beta.1


Dev

Hi Antonella can you check this?

@anniavdc The conflicts are solved by maybe we should pull dev branch and run npm start to double check this is still working before merging?


2524: Refactor feedback web

Short description

Refactor feedback on web by reusing shared logic from api-client and extracting things to components.
I chose not to merge Feedback and FeedbackContainer as both are still ~ 100 lines.
Proposed changes

Extract shared feedback logic with web to api-client
Extract code to new separate components (InputSection, Note, FeedbackButtons)
Adjust styling
Align code with native

Side effects

None.
Resolved issues

Fixes: #2524.

Nice! I like the separation of the components :) When sending search feedback there is still the message that no results are found. Which should be removed after sending feedback (at least in my opinion). But feel free to merge without changing this. :)

I would create a new (good first issue) for this :) Do you think we should hide the whole failure (smiley + message) after a feedback has been sent?


Added packs check

Background
Packs are getting outdated while new detections being added, this change allows to check whether packs needs to be updated.
Changes

added check-packs step

This was merged in as part of another sync PR; closing it out.


Version is missing in published docs

https://commbank.github.io/uniform/index.html

The latest version is ``.

Thanks Andy, I resolved this in #95-#97.


sqlite3.h file not found

I have installed SQLite through cocoa pods. I am facing an error in :
SQLite.swift>>standard>>fts3_tokenizer.h
#import "sqlite3.h" file not found

I've just run into this as well:
I created a brand new project in XCode.
pod init on the project directory
Added sqlite.swift as well as SQLCipher to the podfile
pod-install
Opened the project .xcworkspace
Pressed run
Tried adding the sqlite3 libraries as dependencies to the workspace, but no joy.
Help?

Ok I found my solution. I was using SQLite with GRDB.
I removed both of them & then installed them again & it worked..

I have the same error.

Reinstalling pods does not help. Any other ideas?


Request for MCP (Model Context Protocol) Support

Hello,
I’d like to ask if it would be possible to support the Model Context Protocol (MCP). MCP is an open protocol released by Anthropic, and so far, many third-party MCP server implementations have emerged. Integrating MCP could provide seamless access to this growing ecosystem of tools.
Is there any plan to support MCP in the future? Thank you!

@bigpo Thanks for the request!
What is your vision for MCP integration, or what would you say is currently preventing you from creating agents that interface with MCP servers?
Sorry, I am not yet too familiar with MCP as I have not had time yet to look into it closely, so please help me get a clear vision on this!

Currently, creating agents that interface with MCP servers requires duplicating integration work for each tool, as the framework lacks built-in support for the protocol.
Can you show me a code example of what you mean with this, or what it would look like for a single tool?

Also, as a developer/consumer of the framework, what would your expected usage be? I am interested but I'll need a lot more practical info, not just a generic description of what MCP is and can do
This info is important because if it's mostly just about not wanting to do boilerplate code, it could just be something in the CLI that scaffolds a basic tool with MCP support but I'll have to know exactly what you expect from it..

Hmm I'll have a look at it and play around with it when I have some time, but in the meanwhile if you can come up with an example that actually uses atomic agents and shows where the problem is, that would be extremely helpful!
Should anyone get to it before I do, I believe a viable first attempt might be to just make a tool with a dynamically constructed output schema


in-memory cache couldn't pass test

$ go test $(go list ./... | grep -v /vendor/) -cover
?   	go-cache-demo	[no test files]
?   	go-cache-demo/cache	[no test files]
ok  	go-cache-demo/cache/memory	1.016s	coverage: 0.0% of statements
--- FAIL: TestGetValue (0.00s)
	cache_test.go:52: content should '123456', but was ''
FAIL
coverage: 0.0% of statements
FAIL	go-cache-demo/cache/redis	1.024s
$ go version
go version go1.8.1 darwin/amd64

hey @xialingxiao, can you pull and try again?
I've increased the sleep time by 200ms just to be sure the key would be expired.

hmm, but the failed test is for TestGetValue, you increased it for TestGetExpiredValue .

@xialingxiao Ohh, what's failing is the tests inside redis package, right? You need a redis instance to run those tests. If you have docker, just run docker-compose up -d

my bad, sorry didn't notice that


Fix Point function mistakenly init to weight 1

@deerzq @saurfang

LGTM

Change title to weight 0?


MacOS support

Hey thanks for the cool flutter implementation.
I was wondering whether you plan on supporting MacOS as well?

Hi, Envomer.  Connecting the dots above... you are asking for Flutter support on MacOS?  Or just MacOS instrumentation?  Thanks!

Hey Johnny.
Now that flutter also supports building macos apps, i was curious for a newrelic flutter support for macos apps.
Is that something you plan on supporting as well in the near future?

@envomer we support Mac Catalyst linked apps, not native macOS.


Add base images for windows E2E test apps using SDKs.

Description
Add base images for windows E2E test apps using SDKs.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will partially close: #2695
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

/windows-base

/build-windows-base


Import error when compiling last git-lfs version with go 1.6.2 on linux-armv7

Hi,
I tried to install git-lfs on a ARMv7 board (Odroid XU4) I have strange import error. Is git-lfs working with go 1.6 ?
$ go version
go version go1.6.2 linux/arm
$ git --version
git version 1.9.1

GOPATH and GOROOT are setted.
Here is the trace:
$ git clone https://github.com/github/git-lfs
Cloning into 'git-lfs'...
remote: Counting objects: 14599, done.
remote: Compressing objects: 100% (65/65), done.
remote: Total 14599 (delta 33), reused 0 (delta 0), pack-reused 14534
Receiving objects: 100% (14599/14599), 4.93 MiB | 1.98 MiB/s, done.
Resolving deltas: 100% (9769/9769), done.
Checking connectivity... done.
$ cd git-lfs/
$ go build .
package .
	imports github.com/github/git-lfs/commands
	imports github.com/github/git-lfs/lfs
	imports github.com/github/git-lfs/vendor/_nuts/github.com/ThomsonReutersEikon/go-ntlm/ntlm: must be imported as _nuts/github.com/ThomsonReutersEikon/go-ntlm/ntlm
package .
	imports github.com/github/git-lfs/commands
	imports github.com/github/git-lfs/lfs
	imports github.com/github/git-lfs/vendor/_nuts/github.com/ThomsonReutersEikon/go-ntlm/ntlm
	imports github.com/github/git-lfs/vendor/_nuts/github.com/ThomsonReutersEikon/go-ntlm/ntlm/md4: must be imported as _nuts/github.com/ThomsonReutersEikon/go-ntlm/ntlm/md4
package .
	imports github.com/github/git-lfs/commands
	imports github.com/github/git-lfs/lfs
	imports github.com/github/git-lfs/vendor/_nuts/github.com/ThomsonReutersEikon/go-ntlm/ntlm
	imports github.com/github/git-lfs/vendor/_nuts/github.com/ThomsonReutersEikon/log4go: must be imported as _nuts/github.com/ThomsonReutersEikon/log4go
package .
	imports github.com/github/git-lfs/commands
	imports github.com/github/git-lfs/lfs
	imports github.com/github/git-lfs/vendor/_nuts/github.com/bgentry/go-netrc/netrc: must be imported as _nuts/github.com/bgentry/go-netrc/netrc
package .
	imports github.com/github/git-lfs/commands
	imports github.com/github/git-lfs/lfs
	imports github.com/github/git-lfs/vendor/_nuts/github.com/cheggaaa/pb: must be imported as _nuts/github.com/cheggaaa/pb
package .
	imports github.com/github/git-lfs/commands
	imports github.com/github/git-lfs/vendor/_nuts/github.com/spf13/cobra
	imports github.com/github/git-lfs/vendor/_nuts/github.com/inconshreveable/mousetrap: must be imported as _nuts/github.com/inconshreveable/mousetrap
package .
	imports github.com/github/git-lfs/commands
	imports github.com/github/git-lfs/git
	imports github.com/github/git-lfs/subprocess
	imports github.com/github/git-lfs/vendor/_nuts/github.com/kr/pty: must be imported as _nuts/github.com/kr/pty
package .
	imports github.com/github/git-lfs/commands
	imports github.com/github/git-lfs/lfs
	imports github.com/github/git-lfs/vendor/_nuts/github.com/olekukonko/ts: must be imported as _nuts/github.com/olekukonko/ts
package .
	imports github.com/github/git-lfs/commands
	imports github.com/github/git-lfs/lfs
	imports github.com/github/git-lfs/vendor/_nuts/github.com/rubyist/tracerx: must be imported as _nuts/github.com/rubyist/tracerx
package .
	imports github.com/github/git-lfs/commands
	imports github.com/github/git-lfs/vendor/_nuts/github.com/spf13/cobra: must be imported as _nuts/github.com/spf13/cobra
package .
	imports github.com/github/git-lfs/commands
	imports github.com/github/git-lfs/vendor/_nuts/github.com/spf13/cobra
	imports github.com/github/git-lfs/vendor/_nuts/github.com/spf13/pflag: must be imported as _nuts/github.com/spf13/pflag

I have the same message with $ go get github.com/github/git-lfs. Any idea ?

Unfortunately, that's the challenge in supporting a Go code base for Go 1.4-1.6. Use script/bootstrap to compile it: https://github.com/github/git-lfs/blob/master/script/bootstrap#L15
We've been talking about leaning into dropping support for Go 1.4/1.5, and converting completely to the new vendor format for dependencies, and then the extra env won't be necessary anymore.

Thanks for the quick reply.
I'm not sure to understand the bootstrap script, if I do a
curl https://raw.githubusercontent.com/github/git-lfs/master/script/bootstrap | bash it doesn't work...
OK, so you should explicitly document that it is not working for go 1.6. When you write "go 1.5+" it supposes it works for every minor version of go >1.5.

$ git clone https://github.com/github/git-lfs
$ cd git-lfs
$ script/bootstrap


rs2::pipeline pipe Infinity loop

| Camera Model                       | { D435 } |
| Firmware Version                   | <IP_ADDRESS> |
| Operating System & Version |  Win10  |
| Platform                                 | PC  |
| SDK Version                            |  {2.53.1 }                          |
| Language                            |  {C++ Into DLL }                          |
Issue Description
I link realsens2.dll to my C++ DLL.
When my program load all headers of the DLL it freez at line:
rs2::pipeline pipe;
All others declaration works well if i comment the pipeline declaration:
rs2::pipeline_profile profile;
rs2::frameset frames;
rs2::frameset aligned;
rs2::spatial_filter spat;
rs2::frameset frameTemp;
It's not a crash it's an infinity loop
I can detect my camera :
rs2::context ctx;
int size = ctx.query_devices().size(); => Return well 1

Hi @Didi3333  Of the rs2:: instructions that you have listed, usually the only one that would be placed before a pipeline start instruction is rs2::pipeline pipe; and rs2::context ctx; and the rest would be placed on or after the pipeline start line.
The spatial filter and alignment definitions would be placed before a wait_for_frames instruction.
For example:
rs2::context ctx;
int size = ctx.query_devices().size(); => Return well 1

rs2::pipeline pipe;
rs2::pipeline_profile profile = pipe.start();

rs2::spatial_filter spat;

rs2::frameset frames = pipe.wait_for_frames();

A simple introductory C++ test script can be found at the link below.
https://github.com/IntelRealSense/librealsense#ready-to-hack

I know,
My issue here is if i build my dll with only the line:
rs2::pipeline pipe
When it is loaded by my program that freez with no error
I will try with a previous version of the SDK.
I already succeed to use the SDK few years ago

Does the problem also occur with the Ready to Hack example that I linked to above, or only in your own script please?

@MartyG-RealSense  yes at the first line :
// Create a Pipeline - this serves as a top-level API for streaming and processing frames
rs2::pipeline p;

My understanding is that you are creating your own RealSense project in Visual Studio Enterprise 2022 on Windows and linking it to the realsense2.dll library file.  Is this correct, please?
A typical approach to RealSense C++ development in Visual Studio would be to link your project to three .props files provided by the RealSense SDK, as described in the tutorial at the link below.
https://github.com/EduardoWang/visual-studio-real-sense-record-and-playback-project

Indeed that Works :
std::shared_ptrrs2::pipeline pipe;
pipe = std::make_sharedrs2::pipeline();
Thank you

That's great to hear, @Didi3333 - thanks very much for the update!

Case closed due to solution achieved and no further comments received.


Bump T1 dependencies

Updated: nix/t1/dependencies/_sources/generated.json
nix/t1/dependencies/_sources/generated.nix

Blocked by https://github.com/chipsalliance/chisel/pull/4512


have complete lists downloadable

in Wikipedia we promote (?) this link:
https://pmb-service.acdh-dev.oeaw.ac.at/
to download all listperson, listplace etc.
the link does not work anymore

here all tei-lists can be found https://pmb.acdh.oeaw.ac.at/media/

i just added the url to wikipedia and now all the files are gone. but this is an open issue so I'm not complaining. just stating facts


PLUTO-659 - TCK: Contesting V2AddlFilterTests_SPEC2_20_Action_filter1

This PR has been tested against the pluto tck master:
https://github.com/ngriffin7a/portals-pluto/pull/25

Merged, thank you. :octocat: Sent from GH.


Lex object keys in normal mode

Fixes #829, where @sebmck couldn't use implements as the key in a
declared class type. This was happening because the key was lexed in
"type mode" which spat out a T_IDENTIFIER instead of a T_IMPLEMENTS, so
later on, in Parser_flow.identifier_or_reserved_word, the logic to
explicitly allow reserved words didn't fire, and we fell back to
identifier, which complains about the future reserved word.
After this change object keys in a type context are lexed in normal
mode, so the lexer will spit out the more specific token type, and
identifier_or_reserved_word can do its job.
This change does allow @@foo in object literals and class
declarations, which is absolutely wrong. However, we should really be
using [Symbol.iterator] instead of @@iterator, so adding a bunch of
error handling in the parser (tried it, was ugly) just didn't seem worth
it. Feel free to set me straight if I'm just being lazy... :)

Looks good to me :)

Merged! Thanks for tracking this down!


Add GitHub Action for testing of Networks

Feature Request
Similar to PyPSA-Eur implementation here, adding in a GitHub action to test network configurations would be good.
Suggested Solution
No response
Additional Info
No response

9777d41d260933686baf58d11e56e377063f7e90 created main.yml file for github CI actions. Pulled directly from PyPSA-EUR with modification for our repo.

#208 fixed the issue with the action not running.... Now I'm looking at the way we call the .test.sh script.... currently when you want to run a specific config.****.yaml you need to change the snakemake file to uncomment out the config you want to use...
We need to change this so the config is called directly from the snakemake run command.

While this does not test the networks, the Calliope team showcase a nice way of validating all configuration files against standardized schemas, here

Chatting with @ktehranchi, a potential way of testing workflow functionality is to:

For each test config, supply the existing intermediate network files
Generate new network files for the proposed changes (not sure how we go about this)
Test dataframes against one another

import pypsa
from pandas.testing import assert_frame_equal

n_fixture = pypsa.Network(fixture.nc)
n_new = pypsa.Network(new.nc)

assert_frame_equal(n_fixture.loads_t["p_set"], n_new.loads_t["p_set"]

Is this still opened? I think I can work on this.

@shankarkarki - it is still open! It does feels like a few things have been discussed in this thread, that may be worth breaking out:

The testing for valid configuration files (see also issue #382)
The testing of modules
The testing of the entire workflow (ie. given specific config files, a workflow should run)

May be worth breaking this out into separate issues to facilitate discussion on each topic. Replicating the PyPSA-Eur testing of the workflow (ie. item 3) for PyPSA-USA would probably be doable! But maybe @ktehranchi has other thoughts.

@shankarkarki let me know if you would like to chat about this issue! I agree with trevor on breaking out this ticket.  A good place to start would be to reference the testing set up in pypsa-eur for inspiration

On the testing of the entire workflow front, this repository may be a good reference. They give examples on how to call different config files for their CI, and how to set up simple data + config files for their tests.


[css] at-rule unknown error

I'm trying to use css-modules like so:
@value green: #aaf200;
and I keep getting
[css] at-rule unknown.
I've tried installing and uninstalling every css-modules extension I could find, but the error won't go away. Any ideas?
VSCode Version: 1.23.1
Node: 7.9.0
OS Version: Windows 7 Professional

The css support validated against the standard css spec. To turn off validation use
"css.validate": false
The request to support css-modules is #14539

I don't think disabling css validation completely is the correct approach for fixing this issue.   Is there any other possible solution?

we have https://github.com/Microsoft/vscode-css-languageservice/issues/51 to improve the handling of unknown @at rules.

I agree, I'd prefer not to have to give up CSS validation to use an at-rule in VS Code

I have “temporarily” gotten around this issue by moving CSS linting to Stylelint, but that should not be the desired solution.

me

I agree, I'd prefer not to have to give up CSS validation to use an at-rule in VS Code

Progress in tracked in Microsoft/vscode-css-languageservice#51.
@mfour-merickson If you can paste css examples where you get errors that would be helpful, so we can make sure these get fixed.

@aeschli  this is the main error for me:
@value green: #aaf200;


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/108907

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/109154

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/110314

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/110486

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/113117

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/118806

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/120007


V2: IRC parse errors crash the client

Steps to reproduce
It seems a message like this causes a PARSE_ERROR_ENCOUNTERED (newlines included as-is):
<EMAIL_ADDRESS>JOIN #k3nt0456
:jtv MODE #k3nt0456 +o k3nt0456
"

eventName is then undefined at emit. Skimming through the code, it looks like eventName should be *
Screenie for more context:

Your environment

Operating system(s): Electron on Win 10

Thanks for the work, I much prefer the v2 API so far.
Let me know if you want a PR, though I haven't tried debugging yet

Thanks for the find. I have observed this and a fix is hopefully underway.
I think it is due to the line-breaks being a mix of newlines \n and carriage returns \r. What I do now is clean up line-breaks with just one newline, and then split the message. Do you think this will fix this issue?
Parse errors are now emitted under * with { ..., event: PARSE_ERROR_ENCOUNTERED }, but this still leaves the problem of eventName === undefined in handleMessage(). It seems to me that only messages that could not be parsed will make it here, but since these messages will already be emitted under *, it might be safe not emit anything by default. What do you think?
Also, I am hoping the * event enough to add a little bit of forward-compatibility; should Twitch change the API in an unexpected way, users can still listen to * and parse the message manually until the library can be updated.

Also, thanks for your kind words. If you have any suggestions on how we can make v2 even better, please don't hesitate to post them.

but since these messages will already be emitted under *, it might be safe not emit anything by default. What do you think?

Absolutely agree.
Regarding v2 feedback, right now I'm still integrating the basics. I'm sure I'll have suggestions as I continue the upgrade process. I like that it's a little lower level in that it provides tags and PRIVMSG as they come from Twitch. This will be more future proof
It might be good to have a migration guide for v1 to v2, I can work on it

Cool.
A migration guide is a great idea. It will require less effort than adding v1 backwards compatibility and still be extremely useful. I will update #89.