updating to core v.0.13.0

all needed changes to make it work with v0.13.0

Unresolved: opentelemetry-propagator-grpc-census-binary - TextMapGetter has values defined as text whereas this propagator expect data to be Buffer. Should we create a new getter or add this type to TextMapGetter ?

Unresolved: opentelemetry-propagator-grpc-census-binary - TextMapGetter has values defined as text whereas this propagator expect data to be Buffer. Should we create a new getter or add this type to TextMapGetter ?

Does the spec require data to be a buffer ? Could we just propagate a base64 value of this buffer ?

Unresolved: opentelemetry-propagator-grpc-census-binary - TextMapGetter has values defined as text whereas this propagator expect data to be Buffer. Should we create a new getter or add this type to TextMapGetter ?

Does the spec require data to be a buffer ? Could we just propagate a base64 value of this buffer ?

I'm not changing anything in implementation or in the logic itself - previously it was possible but it was replaced with TextMapGetter which is the successor of the previous getter. But  TextMapGetter seems not to be compatible to what was previously.

@dyladan you wrote the TextMapGetter, can you please check it ?

@dyladan you wrote the TextMapGetter, can you please check it ?

looking now

@open-telemetry/javascript-approvers no unresolved things, as talked with @dyladan just added the info there and keep it like this for now until that issue is resolved.

@blumamir updated the statuses code, should be fine, now, thx for spotting that

@obecny
Sure, Thanks for taking the time to update the plugins.
Added few more places where StatusCode needs to be corrected


How to log errors in main and render process to a file?

Thank you team for developing this awesome boilerplate and continuing active development on it. I cannot thank you enough for giving me a head start.
I have a question. How can I log errors that are generated in main process and render process to a file, such that it works in development and production package both?
Besides, console.error(), it would be great if I can log warnings and errors that are thrown into Developer Tools Console, like this

See:

@amilajack If I understand correctly, other issues are focused on debugging. All I want is to generate a log file, which should have output of not just Console.error() but also Console.log(), Console.info().
Nodejs docs has an example of using a file for collecting logs. See this link.
const output = fs.createWriteStream('./stdout.log');
const errorOutput = fs.createWriteStream('./stderr.log');
// custom simple logger
const logger = new Console(output, errorOutput);
// use it like console
const count = 5;
logger.log('count: %d', count);
// in stdout.log: count 5

What I don't understand is how to make sure this will work in production package, and to make render and main process write to the same file.

console.log doesn't log to the regular console in dev tools. I logs to a server that you would need to run. It is discussed in the vscode issue

Forgive my ignorance. But I had my code littered with console.log(). The console.log always appeared in the Dev Tools during development. The console.log defined in the main process, appeared in the terminal where I kick started electron using npm run start-hot.

console.log doesn't log to the regular console in dev tools.

Are you saying in production, console.log doesn't log to the regular console in dev tools?

Are you saying in production, console.log doesn't log to the regular console in dev tools?

I'm actually not sure about that. I haven't tried that before. I just know that this project hasn't yet added support for development on the main thread.

I'm actually not sure about that.

Ok, just an FYI. I run database queries on main process.  It has always printed on the terminal from where I launched start-hot.

What about when you run npm run dev?

Same output. All console statements are working.

Interesting. Last time i tried this it didn't work.

@talha131 did you find a solution for this?


02_neural_network_classification_in_tensorflow - plot_decision_boundary function issue

while building plot_decision_boundary it is giving error as xx and yy not define.
Even though below is already define.
x_min,x_max = X[:, 0].min() - 0.1,X[:, 0].max() + 0.1
y_min,y_max = X[:, 1].min() - 0.1,X[:, 1].max() + 0.1
xx, yy      = np.meshgrid(np.linspace(x_min,x_max,100),
np.linspace(y_min,y_max,100))
Please advise

issue is coming at - x_in = np.c_[xx.ravel(),yy.ravel()]
tf version = 2.5.0

Issue was because of wrong indentation :-)

glad you got this solved :)


Implement string conversions

This implements the three string transformations described in #436:

Transform
Similar to https://www.typescriptlang.org/docs/handbook/2/template-literal-types.html#intrinsic-string-manipulation-types
NEW_VAR:
  transform: [uppercase, lowercase, capitalize]
  source: $VAR

(with the keyword convert as discussed in the comments/review)
Here's my actual use-case (slightly anonymized):
id: foo
language: python
rule:
  pattern: ObjectStatus.$A
  regex: ObjectStatus.(.*)_statuses
transform:
  B:
    replace:
      source: $A
      replace: '(.*)_statuses'
      by: '${1}_STATUSES'
  CHANGED:
    convert:
      source: $B
      convert: uppercase
fix:
  $CHANGED

This turns ObjectStatus.foo_statuses to FOO_OBJECT_STATUSES everywhere.

Hi @akx , thanks for the pull request!
I have tried Rust's regex crate and it looks like there is no way to transform string cases via regex.
While I do think it is useful for case transformation. The API needs some discussion.
Having two transformations does not look right to me.

I think the word convert will be better. So the ending API can be
transform:
  NEW_VAR:
    source: '$A'
    convert: uppercase

Sure, I can rename the field (and I guess StringTransformation to StringConversion).

Okay, it's convert now, but I'm not quite sure how to wrangle pub enum Transformation to always accept a convert – it'd now be
transform:
  NEW_VAR:
    convert:
      source: '$A'
      convert: uppercase

and
transform:
  CHANGED:
    replace:
      source: $A
      replace: '(.*)_statuses'
      by: '${1}_STATUSES'
      convert: uppercase

– I suppose we'd want
transform:
  NEW_VAR:
    source: '$A'
    convert: uppercase

and
transform:
  CHANGED:
    convert: uppercase
    replace:
      source: $A
      replace: '(.*)_statuses'
      by: '${1}_STATUSES'

but I'll look into that!

I will try to release this tomorrow! Thanks for your contribution!

@HerringtonDarkholme Oops, yeah, sorry! It's there now.

Hi @akx thanks for your contribution!
I have also slightly modified the API to
NEW_VAR:
  convert:
    letterCase: uppercase
    source: $A

so there is no two same convert and the goal of convert reads explicitly as letterCase.
I will release it in 0.12.1!

Released in 0.12.1!

Sure, that makes sense!
Thank you for accepting my contribution and thank you for the project in the first place!


[Snyk] Upgrade antd from 4.10.2 to 4.10.3

Snyk has created this PR to upgrade antd from 4.10.2 to 4.10.3.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 22 days ago, on 2021-01-18.

Release notes

Package name: antd

4.10.3 - 2021-01-18
🐞 Fix Button not adapting to the @ btn-border-width when loading. #28886 @ jjanssen
Table

💄 Add @ table-border-color less variable. #28903
🐞 Fix that invalid params passed to onChange event if define custom filterDropdown and nested filters. #28850 @ Meowu
💄 Tweak Table selection column width to 32px. #28073

Transfer

🛠 Refactor Transfer Search with React hooks. #28895 @ susiwen8
🌐 Added German translations for the Transfer component. #28826 @ aequi42

Upload

🐞 Support for capturing Error message for the Upload error tooltip. #28716 @ wangcch
🆕 Upload auto fills uid of fileList when not provided. #28832

🐞 Fix Slider getPopupContainer prop has no default value document.body. #28865 @ rinick
🐞 Fix Empty description validateDOMNesting warning. #28862
💄 Fix Tree filterTreeNode missing style. #28866
💄 fix Badge dot width issue when size="small". #28854

🐞 修复按钮在 loading 加载时 @ btn-border-width 失效问题。#28886 @ jjanssen
Table

🐞 修复 Table 自定义过滤器时 onChange 参数 filters 被错误转换及为空数组的问题。#28850 @ Meowu
💄 调整 Table 选中列宽度至 32px。#28073
💄 新增 @ table-border-color less 变量。#28903

Transfer

🛠 穿梭框 Search 组件使用 React Hooks 重构。#28895 @ susiwen8
🌐 增加了 German 德语翻译。#28826 @ aequi42

Upload

🐞 支持 Upload 报错提示对 Error 文本信息的捕获（Tooltip）。#28716 @ wangcch
🆕 Upload 在 fileList 没有提供 uid 时，会自动对其进行填充。#28832

🐞 修复 Slider getPopupContainer 属性没有默认值 document.body 问题。#28865 @ rinick
🐞 修复 Empty description 内使用 div 会报 validateDOMNesting 的问题。#28862
💄 修复 Tree filterTreeNode 高亮样式丢失的问题。#28866
💄 修复 Badge dot 宽度样式。#28854

4.10.2 - 2021-01-11
🐞 Fix import error when use antd in commonjs. #28715

🐞 修复 commonjs 下引入 antd 报错的问题。#28715

    from antd GitHub release notes

Commit messages

Package name: antd

2e290d4 docs: release 4.10.3 (#28904)
dd62098 style: add @ table-border-color (#28903)
19f3e6c refactor: rewrite Transfer search with hooks (#28895)
9daf50f test: fix codecov 100% (#28892)
005627e fix: Button loading state not respecting the border-width (#28886)
70a777f docs: update READMEs (#28884)
97796a4 feat(upload): support Error obj (message) (#28716)
0747b3c fix: codecov via removing emoji
0f0dc15 fix: custom table filterDropdown (#28850)
6f69c89 chore: delete config.yml (#28877)
f931158 fix: dont use document.body as slider's popup container (#28865)
9dd3912 style: Fix Tree/TreeSelect filterTreeNode missing style (#28866)
ec6f198 fix: Empty description validateDOMNesting warning  (#28862)
e3214c8 chore: use esbuild-loader (#28859)
9fad797 style: fix Badge dot small width (#28854)
4315ac5 chore: replace omit (#28846)
3006be0 Update README.md
72d0945 Update README.md
6f3ac58 chore: Add bundlesize badges
0b20c4e docs: about less version
68f594e docs: fix Table rowSelection.columnWidth default value
b913b26 Update index.en-US.md
3f30db3 Update index.zh-CN.md (#28835)
38bead8 chore: Auto fill uid (#28832)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Coverage decreased (-0.04%) to 69.719% when pulling 9344e8880471631d8df2ac814c88c25dcf53b578 on snyk-upgrade-9be048b834b7de0e2124aa3b737c6ab5 into 77acd7d3faa7f5cf14e38c9999451fde026fcb19 on develop.


add support for the TRAN keyword (T-SQL)

Impact

[X] Bug fix (non-breaking change which fixes expected existing functionality)
[ ] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
This is the fix for the issue #4098. It add support for the T-SQL Keyword "TRAN".
Currently liquibase splits sql statements only, if there are not between a "BEGIN" and "END" statement. Since most database start transactions with the "BEGIN TRANSACTION" command, the StringUtil class which is responsible for splitting statements, does ignore the "BEGIN" keyword if it is followed by the keyword "TRANSACTION".
T-SQL (the sql dialect from mssql-server) also supports a shorter version for "TRANSACTION" => "TRAN". The current version of liquibase does not check for keyword "TRAN". This pull request adds support for this keyword.
Things to be aware of

I just added the new keyword "TRAN" to the if statement, with intention to change as little as possible

Things to worry about

the current code also supports the keyword "TRANS", I don't know any database which supports the keyword "TRANS" to start an transaction, maybe this was just a typo and can be removed. But I don't know maybe there is a reason for this:).

Additional Context

Initial review:
Change is what I'd expect. Thanks!
Things to be aware of:

Nothing

Things to worry about:

Nothing

Rerunning test harness here: https://github.com/liquibase/liquibase-test-harness/actions/runs/4995573646


Dxf layer color

In DXF, it is possible to have a default color for a layer. This is ignored by meerk40t when the dxf is imported.
In the provided test file, the default color of layers "engrave" and "cut" are blue and red, and the line in each layer have default color. They appear blue and red in LibreCad,  but black when imported in meerk40t 0.6.19
[layer colors.zip](https://github.com/meerk40t/meerk40t/files/5974523/layer.colors.zip)

Okay, read up a bit on the layers uses apparently there's one layer object and the default color and line width can inherit from them. I'll lookup the layer and use that if it exists and isn't overwritten by local a local property which I understand to be the desired procedure for that.

https://github.com/meerk40t/meerk40t/releases/tag/0.6.20-beta2
Try that. Should be pretty reasonable. Just has a bylayer check so it shouldn't mess with other file loads.

Try that.

I tested, all my files loaded corectly.
Trying to test more picky cases, I found a thing that is not really important but may be corrected:
-Make a cut and an engrave layers with only colors defined (red / blue, width apparently defaults to 0mm at least in freecad but is probably just unset)
-Add a line in each layer (ok: each line appear identical, just the color changes)
-Change the color of the line in cut layer to blue (ok: lines both appear blue. ko: the width of the line in the cut layer uses a different default and appears wider)
I guess this should also apply to line types, but since meerk40t doesn't handle them it has now impact for now :)
Thank you for the great job :)
Default value when some other attribut changed.zip

I also discover that you can set the color "by group" in addition to "by layer" in dxf :)

Hm. I'd likely need to see an example of color by group to implement it.
There are some other attributes, I put in the width earlier and it was kinda annoying and seemed like it risked some stuff messing up, so I set it manually to 1 regardless. The specities of DXF are not my bread and butter.  But, I really don't want to risk adding in line widths with scaling issues since they can easily get screwy. I guess I could flag the layers as non-scaling. But, I'm not really sure the linewidth is entirely 1/10th mm or whatever it seemed to suggest. There's also some criteria like dotted that I could do with an operation but couldn't do as an element itself.

Indeed tricky. I think I rember 0mm in librecad mean "not set" and will be displayed 1 pixel wide whatever the zoom level is, and this does not change with scaling.
Here is a dxf file with on block, names my_block. This block containe two lines with "by layer" color, which appear red in a red layer,  and one line tht has "by clock color", which color will depend on the color set on a particular instance of a block.
The block then appear twice in the drawing : once with no color (then the third line take the layer color and is red), and once with the block color is set to blue (then the two first lines keep the red layer color, and the third one turns blue)
color by block.zip

ezdxf is spitting out insert entities which are blocks. But, taking a bit more spelunking to figure out how to get the entities I'd draw out of of that. They are apparently like groups. So there should be some way to find these subobjects. I think it's also related to why the R12 output from inkscape didn't give me any responses. They are wrapped in blocks and I'm not looking in those correctly.

https://github.com/meerk40t/meerk40t/releases/tag/0.6.20-beta6
Beta6 partially addresses that. Splits the blocks into their virtual entities but somehow still misses the of that last one. LibreCAD says it's Blue. Shows up black, though this is a pretty deep edge case at this point.


Tabs - List order Issue

Hi Team,
There is an issue with the order list.
The data needs should be in the same list order but in the second paragraph with the same bullet point as the below snap.

But it's not happening in the EDS.
@teshukatepalli1  as discussed please look into this

@kummu - Please validate

This is working as expected. Hence closing the ticket.


HDDS-6973. Refactor ObjectEndpoint.

See https://issues.apache.org/jira/browse/HDDS-6973

Thanks @szetszwo  work on this, @captainzmc Can you review this.
@szetszwo When the pr merged into master, I will continue to https://github.com/apache/ozone/pull/2858


Fully automate the build procedure on windows

As described in our wiki that although all our used libraries are covered by the create_vs_project.bat (which also does build for you) it requires to have some dependencies downloaded and installed before which could be cumbersome.
Furthermore its necessary to add those dependencies to the PATH, which is not really what windows users are used to do.
The list of those dependencies is:

git
CMake
Visual Studio (2015 or 2017)
Python
Conan
Node.js
Doxygen

It would be cool to provide an "install_requirements.bat" which downloads them, installs them (optimally also silently) and adds them to the PATH if they are not yet available. Or at least guides the dev through installing them (e.g. already downloads them but the users needs to install them manually then).

When we use git for media repository it just became an end user depedency again. We need to figure out how to ship it then again.
Also I somehow don't like that this is called "on Windows" when it just means VS on Windows :)

We will always need git in the build process.

I have talked about an end user dependency..

There is only vs on Windows supported right now
And I did not write anywhere that git is an enduser dependency did I? It's used by conan. But it should be.
If we make it an enduser dependency (we could if we i.e. want to use npm in the game somewhere) there will be a solution necessary to install it in the installer. But there will be anyways a similar solution needed for nodejs

When we use git for media repository it just became an end user depedency again.

In Inexor Flex we use the npm package nodegit. With nodegit there is no need to have git installed by the end user. See here:

NodeGit will work on most systems out-of-the-box without any native dependencies.

Git is a dependency to npm itself
Am 25.02.2017, 01:04, Andreas Schaeffer<EMAIL_ADDRESS>schrieb:
When we use git for media repository it just became an end user depedency again.
In Inexor Flex we use the npm package nodegit. With nodegit there is no need to have git installed by the end user. See here:
NodeGit will work on most systems out-of-the-box without any native dependencies.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@aschaeffer: nodegit is a npm package. Imo thats a bit weird, since npm uses git internally.. :D

We shouldn't make npm an end user dependency, also we can ship nodegit with releases, therefore having git on the end user computers.

Makes no sense for developers, sure.

Off topic? "Build procedure" has nothing to do with "end user dependency". In fact no single comment in this issue has anything to do with the original topic. Please create a separate issue and move the discussion there.

Npm is shipped by default and we heavily rely on it for the internal modules .....
Am 13.04.2017, 10:39, Croydon<EMAIL_ADDRESS>schrieb:
We shouldn't make npm an end user dependency, also we can ship nodegit with releases, therefore having git on the end user computers.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

For Conan: we could first check if pip is installed, if not, offering the setup of pip, then check if conan is installed, if not installing conan via pip.


Podman cannot start on Linux due to faulty homebrew.podman.service file

brew gist-logs <formula> link OR brew config AND brew doctor output
brew config:

HOMEBREW_VERSION: 4.4.6
ORIGIN: https://github.com/Homebrew/brew
HEAD: cc0b5d6d05d1f3af5b2f53e9fbb1e7bfa0c332ab
Last commit: 4 days ago
Core tap JSON: 21 Nov 00:46 UTC
HOMEBREW_PREFIX: /home/linuxbrew/.linuxbrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: :1
HOMEBREW_MAKE_JOBS: 16
Homebrew Ruby: 3.3.6 => /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.6/bin/ruby
CPU: 16-core 64-bit zen5
Clang: N/A
Git: 2.34.1 => /bin/git
Curl: 7.81.0 => /bin/curl
Kernel: Linux 6.9.3-76060903-generic x86_64 GNU/Linux
OS: Pop!_OS 22.04 LTS (jammy)
Host glibc: 2.35
/usr/bin/gcc: 11.4.0
/usr/bin/ruby: N/A
glibc: N/A
gcc@11: N/A
gcc: 14.2.0_1
xorg: N/A

brew doctor:

Your system is ready to brew.

Verification

[X] My brew doctor output says Your system is ready to brew. and am still able to reproduce my issue.
[X] I ran brew update and am still able to reproduce my issue.
[X] I have resolved all warnings from brew doctor and that did not fix my problem.
[X] I searched for recent similar issues at https://github.com/Homebrew/homebrew-core/issues?q=is%3Aissue and found no duplicates.

What were you trying to do (and why)?
Installed podman  and tried to start the service via brew services start podman.
What happened (include all command output)?
==> Successfully started podman (label: homebrew.podman)
Despite the message, podman did not start.
These loglines were present in systemd logs when using journalctl --user -u homebrew.podman
Nov 20 17:49:22 pop-os systemd[1687]: Started Homebrew generated unit for podman.
Nov 20 17:49:22 pop-os podman[113259]: Error: unknown flag: --time\
Nov 20 17:49:22 pop-os podman[113259]: See 'podman system service --help'
Nov 20 17:49:22 pop-os systemd[1687]: homebrew.podman.service: Main process exited, code=exited, status=125/n/a
Nov 20 17:49:22 pop-os systemd[1687]: homebrew.podman.service: Failed with result 'exit-code'.

Inspecting the Homebrew generated homebrew.podman.service reveals a problem with this particular line:
ExecStart=/home/linuxbrew/.linuxbrew/opt/podman/bin/podman system service --time\=0.
The backslash here prevents the systemd from starting the service.
What did you expect to happen?
Podman to start.
Step-by-step reproduction instructions (by running brew commands)
- `brew install podman`
- `brew services start podman`

This seems to rather be an issue regarding how we handle shell quoting when generating systemd service files. The \= escape in the ExecStart line, generated by Utils::Shell#shell_quote ^1, is not a valid escape in systemd ^2 so it is instead treated as two characters.
So, I think we may need to "drop back to the original approach" as mentioned in https://github.com/Homebrew/brew/pull/15880#issuecomment-1680579311. Escapes are hard to handle :(

@radicaled, the podman service file has been fixed by https://github.com/Homebrew/homebrew-core/pull/198617. Please do brew update, followed by brew reinstall podman.
As for the broader issue regarding how escapes like this are handled, do you mind if we continue to use this issue to track that? If not, please feel free to close this and I'll open another one.

As for the broader issue regarding how escapes like this are handled, do you mind if we continue to use this issue to track that? If you prefer it to be done elsewhere, please feel free to close this and I'll open another issue.

By all means, do whatever makes your life easier.
Thank you for fixing the bug, by the way!

@radicaled, the podman service file has been fixed by Homebrew/homebrew-core#198617. Please do brew update, followed by brew reinstall podman.
As for the broader issue regarding how escapes like this are handled, do you mind if we continue to use this issue to track that? If you prefer it to be done elsewhere, please feel free to close this and I'll open another issue.

@ZhongRuoyu
Hello, I just tried install nginx using the homebrew, the same thing happens with those escapes:
[Unit]
Description=Homebrew generated unit for nginx

[Install]
WantedBy=default.target

[Service]
Type=simple
ExecStart=/home/linuxbrew/.linuxbrew/opt/nginx/bin/nginx -g daemon\ off\;
WorkingDirectory=/home/linuxbrew/.linuxbrew

as you can see  execstart has wrong escapes
should be:
/home/linuxbrew/.linuxbrew/opt/nginx/bin/nginx -g 'daemon off;'
therefore service never starts:
nginx (homebrew.nginx)
Running: ✘
Loaded: ✘
Schedulable: ✘

logs `/home/linuxbrew/.linuxbrew/var/log/nginx/error.log`

2024/11/27 17:39:38 [emerg] 24058#0: unexpected end of parameter, expecting ";" in command line

but if I start it manually, it works:
`/home/linuxbrew/.linuxbrew/opt/nginx/bin/nginx -g 'daemon off;'`

Other reports of same issue:

https://github.com/Homebrew/homebrew-core/pull/195649
https://github.com/Homebrew/brew/issues/18236

Wrapping with quotes is possible if following rules of quoting -https://www.freedesktop.org/software/systemd/man/latest/systemd.syntax.html#Quoting

double quotes ("…") and single quotes ('…') may be used to wrap a whole item (the opening quote may appear only at the beginning or after whitespace that is not quoted, and the closing quote must be followed by whitespace or the end of line), in which case everything until the next matching quote becomes part of the same item. Quotes themselves are removed. C-style escapes are supported. The table below contains the list of known escape patterns. Only escape patterns which match the syntax in the table are allowed; other patterns may be added in the future and unknown patterns will result in a warning. In particular, any backslashes should be doubled

I believe some old versions of systemd also have a bug when quoting the command itself.

Environment variables are often mentioned as workaround using the rules of ${ ... } handling - https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html#Command lines

Use "${FOO}" as part of a word, or as a word of its own, on the command line, in which case it will be erased and replaced by the exact value of the environment variable (if any) including all whitespace it contains, always resulting in exactly a single argument.

This has been fixed in master and will be available to everyone after the next Homebrew release. After updating to the new release, affected formulae (including nginx -- FYI @tomasdziovenas) can be fixed with brew reinstall.

Thank you very much for your work!

This has been fixed in master and will be available to everyone after the next Homebrew release. After updating to the new release, affected formulae (including nginx -- FYI @tomasdziovenas) can be fixed with brew reinstall.


fix QAT version dependency

Context
What is the purpose of this PR? Is it to

[ ] add a new feature
[x] fix a bug
[ ] update tests and/or documentation
[ ] other (please add here)

We updated torchtune to use torchao 0.4.0. It breaks unless user has pytorch 2.4.0.  In our scripts, we were using import guards:
https://github.com/felipemello1/torchtune/blob/04ccbf2601653e0e2cceb75e59394df5517d26e3/torchtune/utils/quantization.py#L12
However, "TORCH_VERSION_AFTER_2_4" actually didnt include 2_4. This was fixed in torchao here: https://github.com/pytorch/ao/pull/684, but it wont be available to us until their next release.
After updating TorchAO and the import guards, another error was raised:
[rank0]:   File "/home/felipemello/.conda/envs/test_ao/lib/python3.10/site-packages/torchao/quantization/prototype/qat/utils.py", line 42, in forward
[rank0]:     assert input.dtype == torch.float32

This is because QAT recipe now requires the model to be in float32. More context here: https://github.com/pytorch/ao/blob/0b66ff01ab6ba4094823b8cb134ab5b5a744d73a/torchao/quantization/prototype/qat/utils.py#L39
Changing the QAT recipes to have dtpye = fp32 solved it
Changelog

Update torchao=0.4.0
Remove pin from Numpy (this is unrelated to this PR, but it was something we needed to do, so it made sense to test everything together https://github.com/pytorch/torchtune/issues/1344)
Temporarily change the import guards. They MUST be updated with the next torchao release. (should I add some assertion that checks torchao__version__ <= 0.4.0?)
QAT configs use fp32

Test plan
I was able to run the code below. But I did not try to compare with previous version.
tune run --nproc_per_node 8 qat_distributed --config llama3/8B_qat_full

cc @msaroufim

@felipemello1 Would you mind just also double checking our version guards for AO? We'll need to be extra careful around this now that we're relaxing this pin.
CI will only catch our tests, which are a subset of how our library is used.

Would you mind just also double checking our version guards for AO?

Not sure what you mean by it. Can you add an example or a link of what you would like me to do?

This change allows for stable builds of torchtune to break in the future. If there is a stable package for torchtune that works fine with torchao, and then torchao releases a new stable package with bc breaking changes, our existing stable packages would try to install the new torchao package and break. We need to keep torchao pinned and then use a tool like dependabot to keep the pinned version up to date.
For CI we should decide if we want to pin to the latest version of PyTorch and possible have separate tests for PyTorch nightlies with unpinned PyTorch libraries.

If there is a stable package for torchtune that works fine with torchao, and then torchao releases a new stable package with bc breaking changes, our existing stable packages

When users pip install torchtune the ao version should be pinned so the official release packages are guaranteed to work. If then users choose to upgrade AO there is no guarantee things will work but we'll try our best not to break things for no good reason
In tune CI you should always be testing all your latest stable dependencies and all your latest nightly dependencies. We should never be catching BC issues at release time but at nightly CI time, that way upgrading a stable release can be a safe activity

@felipemello1 How urgent is upgrading torchao? I will submit a fix in torchao itself to remove that assertion, but I don't think we want to change the default precision in the QAT recipes. We have another release planned in early september, but if that's too late for you maybe we can do a 0.4.1 release with the fix?

https://github.com/pytorch/ao/pull/692

We have another release planned in early september, but if that's too late for you maybe we can do a 0.4.1 release with the fix?

Thanks for the fix @andrewor14!
If making a release is not a huge effort, this would solve multiple problems: Our regression error, the import version, and the dtype. Itt would be convenient. However, i dont think that we have a huge number of users using QAT, so waiting for september wouldnt be terrible.
In summary, if making the release is easy, that would be very neat. But if its going to take you a considerable amount of time, we can wait 2 weeks.

Is this on hold until next torchao release then? And if so are we gonna just bump to 0.5.0? If so let's make sure that our nightly CI is green before that release

Is this on hold until next torchao release then?

thats my understanding


Browsing projects show error

Describe the bug

Clicking on the Projects button, opens a sidebar, which shows "Error: Loading Projects". see:

Also, the Create New Project does nothing.

To Reproduce
See above
Expected behavior

The Projects button should list all existing projects, and shouldn't show errors.
The Create New Project button should create a new project. If the feature is not supported yet, either disable the button and/or show a proper info-message.

Screenshots
See above
Desktop (please complete the following information):

OS: iOS 13.5.2
Browser: Chrome
Version: 127.0.6533.120 (Official Build) (arm64)

Additional context
Add any other context about the problem here.

seems like a Chrome issue with getting projects ( it is failing for me also when deploying contract )


Fix for #1067: show geocode in history

Added Geocode to entries in history list.

In other lists the gc-code is at the first position. Maybe we can do it here the same way. (And as another suggestion: replace the old ; with SEPARATOR)

I agree with @SammysHP opinion. Otherwise the code is fine to merge.

I thought about the first position too, but the history list is sorted by date/time by default and therefore i added it at the end. Should i change it anyway to the first position?

Great. I like that a refactoring to the much clearer StringUtils method is included.


Suggestion new features - Not null tags

Congratulations for the package !
I have a suggestion:
Dontt allow the inclusion of the tag if two spaces are entered in sequence at the beginning of the filling

Hi @edukmattos , thank you for your suggestion.
It's possible to prevent this. However, I'm not too sure about what to do if the delimiter are enter twice.
Maybe we can just not allow delimiters to be input? 🤔
If you have and desire behaviour please let me know.


WARNING: SSLSocket#session= is not supported

Step 2 : RUN logstash-plugin install --version 5.0.0 logstash-input-kafka
 ---> Running in 32fa66c5f699
Validating logstash-input-kafka-5.0.0
Installing logstash-input-kafka
WARNING: SSLSocket#session= is not supported

When I install this plugin its wait a long long long time.

Version:
Linux Ubuntu16.04:

@cutd thanks for the report! which version of Logstash are you running?

I use logstash-5.0.0 . Because of I am in China?

I've had this problem too.   help me,pls
I use Logstash-5.1.1. I'm from china.
This command let me wait for a night.
[root@ELK logstash]# bin/logstash-plugin install logstash-filter-dissect
Validating logstash-filter-dissect
Installing logstash-filter-dissect
Error Bundler::InstallError, retrying 1/10
An error occurred while installing logstash-core-event-java (5.1.1), and Bundler cannot continue.
Make sure that `gem install logstash-core-event-java -v '5.1.1'` succeeds before bundling.
WARNING: SSLSocket#session= is not supported
WARNING: SSLSocket#session= is not supported
Error Bundler::InstallError, retrying 2/10
An error occurred while installing logstash-core-event-java (5.1.1), and Bundler cannot continue.
Make sure that `gem install logstash-core-event-java -v '5.1.1'` succeeds before bundling.
WARNING: SSLSocket#session= is not supported
WARNING: SSLSocket#session= is not supported
Jan 04, 2017 12:38:19 AM org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec execute
INFO: I/O exception (java.net.SocketException) caught when processing request to {s}->https://repo.maven.apache.org:443: Connection reset
Jan 04, 2017 12:38:19 AM org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec execute
INFO: I/O exception (java.net.SocketException) caught when processing request to {s}->https://repo.maven.apache.org:443: Connection reset
Jan 04, 2017 12:38:19 AM org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443
Jan 04, 2017 12:38:19 AM org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443
Error Bundler::InstallError, retrying 3/10
An error occurred while installing logstash-core (5.1.1), and Bundler cannot continue.
Make sure that `gem install logstash-core -v '5.1.1'` succeeds before bundling.
WARNING: SSLSocket#session= is not supported
WARNING: SSLSocket#session= is not supported
Installation successful
[root@ELK logstash]#

[root@ELK logstash]# bin/logstash-plugin list | grep 'logstash-filter-dissect'
logstash-filter-dissect
[root@ELK logstash]#

pls.
Thank you.

[root@ELK logstash]# bin/logstash-plugin install /tmp/logstash-filter-dissect/logstash-filter-dissect-1.0.8.gem
Validating /tmp/logstash-filter-dissect/logstash-filter-dissect-1.0.8.gem
Installing logstash-filter-dissect
WARNING: SSLSocket#session= is not supported
WARNING: SSLSocket#session= is not supported
Jan 04, 2017 8:52:36 PM org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec execute
INFO: I/O exception (org.apache.maven.wagon.providers.http.httpclient.NoHttpResponseException) caught when processing request to {s}->https://repo.maven.apache.org:443: The target server failed to respond
Jan 04, 2017 8:52:36 PM org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443
Jan 04, 2017 9:18:46 PM org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec execute
INFO: I/O exception (org.apache.maven.wagon.providers.http.httpclient.NoHttpResponseException) caught when processing request to {s}->https://repo.maven.apache.org:443: The target server failed to respond
Jan 04, 2017 9:18:46 PM org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443

[root@ELK ~]# curl -I https://repo.maven.apache.org:443
HTTP/1.1 200 OK
Content-Type: text/html
Last-Modified: Wed, 10 Aug 2016 15:04:26 GMT
ETag: "57ab427a-134"
Fastly-Restarts: 1
Via: 1.1 varnish
Fastly-Debug-Digest: 781b95b67250800676087bf92e55ef0ae8915e6603b1ba1e4984f73a3fd9c3b9
Content-Length: 308
Accept-Ranges: bytes
Date: Wed, 04 Jan 2017 16:07:59 GMT
Via: 1.1 varnish
Age: 6122236
Connection: keep-alive
X-Served-By: cache-iad2151-IAD, cache-sjc3624-SJC
X-Cache: HIT, HIT
X-Cache-Hits: 1, 1
X-Timer: S1483546079.708775,VS0,VE0

[root@ELK ~]#

why ????
It can access this address(https://repo.maven.apache.org:443).
Do you need to download anything?
pls help me. Thanks
@talevy

Its a proxy problem, I'm not from China but from corporate internal network, you are missing maven proxy config:
/user/.m2/settings.xml:
<settings>
  <proxies>
   <proxy>
      <id>proxy</id>
      <active>true</active>
      <protocol>http</protocol>
      <host>proxy</host>
      <port>3128</port>
    </proxy>
  </proxies>
</settings>

no no no, Not the reason for the proxy. I have tried many times and found that this is the reason for China's network, Sometimes can be accessed, sometimes can not, But the number of failures is greater than the number of success


Option to just restart pod on image update detection

Is your feature request related to a problem? Please describe.
If I'm updating to a tag we shouldnt have to write back to the git repo as long as pull-policy: always is set
Describe the solution you'd like
Option to just restart the pod when the tag is updated
Describe alternatives you've considered
Git writeback would be fine except for the fact that all code goes through a review process and cant be commited directly to main
Additional context
Add any other context or screenshots about the feature request here.

Though I am not the maintainer of this project, your best bet is to use digest update strategy which is introduced exactly for this purpose (restarting a pod upon an update to a mutable tag).
It still requires a git write-back, though, because there's no way that argocd-image-updater can detect if the image is updated or not without comparing the image's sha hash and it must be included as part of the tag value.


hubble-proxy: add initial skeleton

This commit adds code to create the hubble-proxy binary for the new hubble proxy component.
Ref: https://github.com/cilium/hubble/issues/89

This change is

Coverage decreased (-0.01%) to 45.625% when pulling 490bcb131e066d35c4dd14cd624980d857f4e92d on pr/rolinh/hubble-proxy-cmd into 6d29bba62d7cef9d340848d360da2effc09f2485 on master.

test-me-please

Apparently on the CODEOWNERS front, the relevant codeowners were pulled in somehow, even though GitHub also pulled in janitors (which is why I stepped in), and even though I don't see these paths listed either in the existing codeowners file or any changes in this PR to the codeowners file..?
At least right now, GitHub is telling me that I'm a codeowner for all of the files in the review page, which suggests the janitor will be pulled in for any subsequent PRs.

Apparently on the CODEOWNERS front, the relevant codeowners were pulled in somehow, even though GitHub also pulled in janitors (which is why I stepped in), and even though I don't see these paths listed either in the existing codeowners file or any changes in this PR to the codeowners file..?

The relevant codeowners were pulled in because pkg/hubble is touched by this PR. But indeed, I should update the CODEOWNERS for the new hubble-proxy directory.

Please also extend the CODEOWNERS

Done.

test-me-please

test-me-please

test-me-please

test-me-please

@joestringer @glibsm Reading through the review comments, it wasn't clear to me whether we should merge this now and follow-up or require some of the comments to be addressed now. I assume Robin will look through and address what's obvious, it would be great for both of you to point out what you want to be addressed now vs later after Robin has refreshed the PR.

test-me-please

The specific items I was concerned about are already addressed.
I had a minor longer-term maintenance question on refactoring the basic cmd code here to better share, which I raised because this PR fixed an issue in the Cilium side as well and we just applied the same fix there:
https://github.com/cilium/cilium/pull/10545#discussion_r391356975
That said, the relevant code doesn't change often so it's not a bit deal to have multiple copies of it in the codebase.


Autocomplete outputs error to the OmniSharp log

Environment data
dotnet --info output:
.NET Command Line Tools (1.0.0-preview2-1-003177)

Product Information:
 Version:            1.0.0-preview2-1-003177
 Commit SHA-1 hash:  a2df9c2576

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  10.12
 OS Platform: Darwin
 RID:         osx.10.11-x64

VS Code version: 1.7.1
C# Extension version: 1.5.3
Steps to reproduce

Create empty C# project running .NET Standard 1.6.
Create C# class.
Show autocomplete.

Expected  behavior
There should be no errors in output.
Actual behavior
Omnisharp log shows error for each autocomplete:
[ERROR:Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware] An unhandled exception has occurred: Object reference not set to an instance of an object
[INFORMATION:OmniSharp.Middleware.LoggingMiddleware] /autocomplete: 500 36ms

Hi! Could you clarify the repro steps a bit? How did you create the empty C# project? Did you use dotnet new?

@DustinCampbell I've created project via custom project.json:
{
	"version": "1.0.0-*",

	"dependencies": {
		"Microsoft.AspNetCore.Mvc.Core": "1.1.0"
	},

	"frameworks": {
		"net46": { },
		"netstandard1.6": { }
	}
}

I've investigated. This exception occurs when autocompletion tries to find completion for variable name. For example, I'm entering: Exception e. When I enter e then exception logged:

Thanks for the detailed repro. I'll take a look.

OK. I have a PR out to omnisharp-roslyn to fix this issue. FWIW, the behavior should be mostly benign. The completion is the same whether the exception is thrown or not.

I see that completion works but any exception in the log warns. Thanks.

I've created a v1.6-beta2 release of the C# extension that contains this fix, among others. See this page for information on installing beta releases


Updated Gradebook Find Command

Changed gradebook update

Coverage increased (+0.5%) to 65.987% when pulling f521aca228ab8dc05b4c353919ad6839161d91c4 on tristyxxnana:v1.3.1 into 5bf0c8611c305f0347e4e3abff8ffba38e115f3d on CS2113-AY1819S1-T16-1:master.


Switch server to Javalin

Note: This is a pull request onto #361 rather than master because it depends on things changed in #361.

Next thing to do here is add the todo functionality and maybe switch to using some mongodb

All required lab 2 todo functions have been added, with test covering key features of the todos:

The database test has examples of testing getting all todos and getting specific todo with id.
The todo controller spec has examples of testing the two new features in todos: sort and limit.

This lab is basically about Angular in client. But do we want a more thorough test for the server?

Other than maybe changing the Database class to UserDatabase, this looks good to me. Great work @wallerli.

There is NullPointerException when I run these tests on VS code debugger. We might need to watch this after merged.

There is NullPointerException when I run these tests on VS code debugger. We might need to watch this after merged.

There is NullPointerException when I run these tests on VS code debugger. We might need to watch this after merged.

Was that a problem that existed before these recent changes that you know of or was that the first time you checked that? I have not run this code, so I was just looking for understandability, clarity, and consistency.

I am going to merge this, we can figure out the testing issue when we check the rest of the updates in the lab environment and fix bugs.


Submission appears twice in submissions

Created a new version of an item; now I see the new version twice among my submissions...

the table is created by sql query that uses dc.date.accessioned. As new version was a copy with all the metadata and because dc.date.accessioned is added automatically via InstallItem, the new version has had this field multiple times...
PR #64 also removes other "automatic" metadata, description.provenance, local.branding ...


Cop idea: detect stub_const that doesn't refer the const

When someone uses stub_const('Foo::BAZ', 42), all other constants (and methods) defined in Foo may be lost. This is explained in https://github.com/rspec/rspec-mocks/issues/1079. I've lost couple of hours debugging it the first time it happened to me, and since then few times returned such stubs at a code review. It would be nice to have a cop that warns about this behavior.

The issue happens only when Foo does not exist at the time you stub it with stub_const('Foo::BAZ', 42). In this case rspec-mocks does not know anything about Foo other than you need the namespace to define BAZ inside. Thus, it creates Foo as a module.
In my projects, I have a rule of never using nested stubbing without first requiring the “outer” constants. I don’t think we can enforce such a rule with static analysis alone. @dgollahon may know more – perhaps a job for RSpectre?

ping @dgollahon

I personally avoid this by just requiring all constants upfront.
Regarding rspectre, I think it would be out of scope/possibly difficult to track if the constant previously existed before stub_const. I don't envision rspectre as a tool you run frequently, so I don't think it's the kind of thing that is likely to have saved @Darhazer debugging time. I'm not sure rubocop-rspec would help that much either since an exception is already being raised and i don't know if people use rubocop to lint when they hit a bug frequently and then if they would run all cops rather than just ones categorized as linting cops.
Maybe rspec itself would accept a patch to issue a warning or somehow catch class/module mismatches when the constant is stubbed but the namespace doesn't exist or something like that. I'm really not quite sure what the appropriate response is here.
That said, I think it would be a good addition to rspectre to detect if the stubbed constant is ever accessed, as I imagine a fair number of stubs in the wild are unnecessary. I'll add an issue to that effect.


Is there a way to resolve a dependency from a config file e.g. bower.json

My title might be slightly confusing so I will give an example. Right now I am installing bourbon using bower. I have set bower_components to be in my included paths, so then I can do @import 'bourbon'. The problem is the main file for bourbon is nested quite deeply (/app/assets/stylesheets/bourbon). This means when I import I have quite a long import string each time.
I frequently use webpack too, and they have quite a clean approach to this in the form of a resolver plugin. I'm not sure how well this translates over to the node-sass paradigm so I thought I'd ask. With webpack I can say new webpack.ResolverPlugin.DirectoryDescriptionFilePlugin("bower.json", ["main"]) and this automatically reads the bower.json file of an imported folder and resolves my import statement to the correct file.
Is there an equivalent in node-sass?

Sounds like you want loadPaths

I can't seem to find anything about that option in the documentation. Do you mind pointing me to the right place? Or just explaining how it works from your knowledge?

Apologies it's includePaths in node-sass, which maps to loadPaths in Ruby Sass - https://github.com/sass/node-sass#includepaths

Hi @xzyfer
As I mentioned in the first post, I already have setup my include paths correctly. The problem is that the necessary files aren't necessarily in the root of the folder. The actual location is stored in files such as bower.json and package.json, but there is no way to read that information and have it interpreted correctly.

I've done something similar but for npm modules. You could try writing a plugin for sass-composer or adapting the src to suit your use-case.

You will need to write a custom importer.


Please expose hotkeys array

I am creating my own hotkeys help menu.  To do this I need to expose the scope.hotkeys array through the hotkeys service.  I am willing to submit a PR.

+1

@chieffancypants This one is probably closed by 52a76490f2a6aeb83d11ee59431a2e1ab6bc4e05

This has been solved a while back


orchestrator-core Improvements to migrate-workflows wizard

Problem to solve
When there are a lot of workflows and product_types, the current selection menu is a bit unwieldy. In other words, the list of workflows can become very long.
Intended users
All workfloworchestrator custom implementation developers.
Proposal

When selecting a workflow to create. Separate the workflows into the ones missing in the db and already present in the db.
Possibility to delete multiple workflows by entering a comma-separated list

Tasks

[ ]  extra step to separate by lifecycle state
[ ]  add (new) after not already linked workflows

Most users have migrated, closing.


Bug: Error supplying Required Value & Option with same Text

 Issue by Good-man
Tuesday Apr 25, 2017 at 14:54 GMT
Originally opened as https://github.com/gsscoder/commandline/issues/440

@gsscoder
Given:
class Options
{
    [Value(0, Required = true)]
    public string Text { get; set; }

    [Option("option", Required = true)]
    public string Option { get; set; }
}

mycmd.exe "test" --option "test"
produces:
ERROR(S):
  A required value not bound to option name is missing.

  --option        Required.

  --help          Display this help screen.

  --version       Display version information.

  value pos. 0    Required.

whereas
mycmd.exe "test1" --option "test2"
works fine.
It's not apparent why passing the same value would cause commandline to behave differently.

 Comment by JeremyMorton
Tuesday Aug 22, 2017 at 22:38 GMT

This is especially common when you have integer options and values, since it can be common to want to specify 0 or 1 for both an option and a value.

 Comment by sajagi
Thursday Oct 05, 2017 at 11:58 GMT

This bug is still present in the latest nuget package (2.1.1-beta), but it looks like it's fixed already in source code.

Resolved.
Try it online


Eratic Jitter caused when I updated

Describe the bug
Bones are bouncing for a bit then rocketing off(extreme stretching) then resetting at random.
To Reproduce
Happens to most people just standing around in town.
Expected behavior
Normal movement.
Screenshots and videos
Very big thigh

Desktop (please complete the following information):
Windows 10
** FSMP**

Installed version
CUDA: No_CUDA
AVX: AVX2

SKSE

installed version
2.2.3

Skyrim
1.6.640
Required files
AttachedFiles.zip
Additional context
This is behavior that appeared when I updated from 1.49.3 to 1.50.4rc-1

Hey Pop,
thank you for the good bug report.
Could you test with the No-CUDA, AVX version, please?
Day

Found the issue my headache clearly prevented me from thinking clearly when I tried to debug this before I opened this.
The base xml from bhunp(which I based mine on), has a setting that only seems to matter in the new version.

setting 4 to 0 solves it.
now that is taken care of may I ask question to someone who might know about ranges
on constraint definition

Is that damping also like the bones 0.0-1.0, a lot of xml's use greater then 1.

Hey Pop,
thank you for the good bug report. Could you test with the No-CUDA, AVX version, please?
Day

I forgot to mention this made no difference.


Minimal example of liberty gradle plugin is too verbose

In the OpenLiberty guide-gradle-intro guide, there is a significant amount of boiler plate stuff in the build.gradle file.
The liberty gradle plugin could be setting up all of the following things out of the box, so the user only has to override things that break the norm.
source compatibility and encodings:
sourceCompatibility = 1.8
targetCompatibility = 1.8
tasks.withType(JavaCompile) {
    options.encoding = 'UTF-8'
}

application and server configurations:
ext {
    ...
    appName = project.name
    warContext = appName
}
liberty {
    server {
        ...
        configFile = file("src/main/liberty/config/server.xml")
        packageLiberty {
            archive = "$buildDir/${appName}.zip"
            include = "usr"
        }
    }
}
war {
    archiveName = "${baseName}.${extension}"
}

needing to include/exclude integration tests:
test {
    reports.html.destination = file("$buildDir/reports/unit")
    reports.junitXml.destination = file("$buildDir/test-results/unit")
    exclude '**/it/**'
}

task integrationTest(type: Test) {
    group 'Verification'
    description 'Runs the integration tests.'
    reports.html.destination = file("$buildDir/reports/it")
    reports.junitXml.destination = file("$buildDir/test-results/it")
    include '**/it/**'
    exclude '**/unit/**'

    systemProperties = ['liberty.test.port': testServerHttpPort, 'war.name': warContext]
}

and needing to map dependencies between tasks provided by the liberty plugin:
clean.dependsOn 'libertyStop'
check.dependsOn 'integrationTest'
integrationTest.dependsOn 'libertyStart'
integrationTest.finalizedBy 'libertyStop'
libertyPackage.dependsOn 'libertyStop'

Closing as this is not a priority and has had no activity in 5+ years.


fix: added enum for job docker images

This will fix and close #29

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/flutter?version=dev:daefa46588c7751e7598d82229d515ddbb4be0c1

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/flutter?version=2.0.2


Handling oAuth refresh token

Hello,
I have oAuth authorization in my app. But I'm confused with the implementation of refresh token service.
At the moment I created instance of axios and apply to logic middleware.
After login I use my AuthService to set headers with authorization token to my axios instance, and set tokens to localStorage.
Then I create axios interceptor to handle 401 error and send request to get new token, after success response I change authorization header and resend original request with new token. It works fine, but it is not connected to redux-logic now. Request is called, and I get the response but not as redux action.
It looks like:

GET_CURRENT_USER_START
//token expired
GET_CURRENT_USER_ERROR
// here I want to call GET_CURRENT_USER_START action again after received new token

My interceptor:
let isAlreadyFetchingAccessToken = false;

const httpClient = axios.create({
  baseURL: config.APP_URL,
});

httpClient.interceptors.response.use(function (response) {
  return response
}, function (error) {
  const { config, response: { status } } = error;
  const originalRequest = config;

  if (status === 401) {
    if (!isAlreadyFetchingAccessToken) {
      isAlreadyFetchingAccessToken = true;

      return axios.post(refreshTokenUrl)
      .then((res) => {
        isAlreadyFetchingAccessToken = false;
        AuthService.saveAuth(res.data);
        originalRequest.headers['Authorization'] = 'Bearer ' + res.data.access_token;
        httpClient(originalRequest); // here request is calling but not as redux action
      });
    }
  }
  return Promise.reject(error)
});

export default httpClient;

How to handle oAuth2 refresh token in redux-logic?
Perfect scenario:

User hit button to receive data from api. // GET_USERS_START
Token is expired.
Browser get 401 error (Unauthorized). // GET_USERS_ERROR
Redux-logic automatically handle that, and make request for new token.
New token is received, headers of my axios instance is changed to new autorization token.
GET_USERS_START action is called automatically.

It would be good to see your logic that is doing a call with this http client. On the surface things look fine but would need to see the call site.


Is there any way to check if the chart open by OpenChart is ready?

Hello Vdemydiuk,
Greeting from Thailand! I am new to using MtApi and getting to love it so much! Thank you very much for your great work.
I am having a problem applying template of a chart after opening using OpenChart function. Sometimes the chart is opened very fast so template applying is successful but sometimes the chart open so slow and the code already apply the template causing exception thrown...
So, my question is, is there any way to check if the chart open by OpenChart is ready before executing the next line of code? Now i am using Thread.Sleep which would work for most of the graph, but it wait too long for normal forex chart and would still not long enough for some exotic chart...
Your guide will be very much appreciated.
Thank you very much!

Hi,
Thank you for your feedback.
I will investigate this problem and will let you know about some possible fix of it.

Thank you very much! Awaiting for your reply.

Hi,
please provide type of exception that you got during call function ChartApplyTemplate.

After i check the exception thrown, the exception is thrown from something else as the MtApi could not connect properly to the chart (because the chart is not opened properly) but the code could still continue to execute like new tick occur and the program fire QuoteUpdate event.
the error would repeat if you run this code
        NewChartID = MtApiClientA.ChartOpen(ChartToOpen, ENUM_TIMEFRAMES.PERIOD_M1);

        //System.Threading.Thread.Sleep(Settings.AdminSettingChartOpenCloseWaitTime);

        bool OperationResult;
        if (MtApiClientA.ChartApplyTemplate(NewChartID, MT4TemplateFileName))
        {
            OperationResult = true;
        }
        else
        {
            OperationResult = false;
        }

if this code is run without Thread.Sleep for about at least 1000 ms then surely the error occurs. But the error will not occur here. It will occur the next time MtApiClientA is accessed again.

@cychrn Hi. I am trying to reproduce your issue but can't. All is working fine on my side. My PC is fast so maybe it does not have this issue. I will try to test this case on slower PC.


Unset all values from global config for .insteadOf

When using this action with self-hosted runner it's likely that those values for .insteadof parameter are already set and thus setting those again throws an error:
warning: url.https://github.com/.insteadof has multiple values
error: cannot overwrite multiple values with a single value
       Use a regexp, --add or --replace-all to change url.https://github.com/.insteadOf.

Ref: https://github.com/fusion-engineering/setup-git-credentials/issues/4

This seems reasonable to me. I'm kinda curious what the use case behind multiple insteadOf values for ssh://github.com/ is, but for the auth token to work the URL must be rewritten to https://.
If it turns out there is a use case for inheriting the git settings from the host, we can always add an option to disable the URL rewrite entirely.

Thanks for the PR!


Check LICENSE

What is our licensing?

I changed it to MIT and this should be fine right @MarvinLorenz ?


Don't format files in obj folders

Out of curiosity, do we offer any sort of mechanism to opt out of the hard coded ignore paths?

Out of curiosity, do we offer any sort of mechanism to opt out of the hard coded ignore paths?

It isn't documented, but I am fairly certain you can opt out in the same way as a gitignore. Meaning if the gitignore ignores bin, there is some way to do !path/to/bin, I don't know if that is the proper syntax or not.


fix(export_dashboards): update role model.  phase 1

SUMMARY

Enable Export Dashboards with Associated Roles
Bug:
export/import dashboards doesn't support roles. see here issue
Solving:
In order to add roles [which are associated  to dashboards]  to the export_dashboards functionality,
(Via cli or http request),
we need that the role model will inherit from the ImportExportMixin class.
changes:

Role model - inherit from ImportExportMixin.
User Model - update the role relation

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

All test should pass
In order to enable dashboard RBAC we need to add enable 2 feature flag:
FEATURE_FLAGS =
{ "VERSIONED_EXPORT": True, "DASHBOARD_RBAC": True, }
ADDITIONAL INFORMATION

[ X] Has associated issue:
[ X] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Thanks for the contribution @michael-hoffman-26 ! Do I understand correctly that this PR is breaking up the other PR you recently opened in #18754 , and can therefore be closed?

Yes the #18754 can be closed

@michael-hoffman-26 @villebro this one has slipped through the cracks, but if we think it's worth following up on, what might the next steps be? CC @betodealmeida for an extra pair of eyes as an import/export guru :D

@michael-hoffman-26 any interest in getting this through? It definitely needs a rebase, at least. I'll mark it as Draft for now, and you can mark it as ready for review when it's rebased and (hopefully) passing CI. Thanks!


Handle high zoom levels better

At high zoom levels, there are several issues:
At zoom levels 17 or 18, the html and d3 renderers fail to show tiles because the css offsets are too large for browsers to handle.  To fix this, we need to adjust the camera and tile offsets.  This needs to be done keeping in mind that we want to rotate and tilt camera views in the future.
When using the standard map projections, at zoom levels about 18 or so, the vgl renderer starts misaligning tiles.  This is due to a loss in precision from the proj4 computations.  Either we need to increase the precision used in proj4 or provide an alternative for common projections.
At zoom level 25 or so, the vgl renderer starts having issues with tile alignment even when using pixel coordinates rather than a map projection.
When panning at zoom levels of 19 or higher, the pan becomes rough.

The loss of precision in the vgl renderer is caused by using a vec3 to store the tile origins.  vec3 uses a GLMAT_ARRAY_TYPE, which is 32-bit floating point, and thus loses precision of the origin.  I'll have a simple change to vgl that addresses this.  It doesn't fix the problems with the html and d3 renderers or with panning.

The loss of precision in the vgl renderer is caused by using a vec3 to store the tile origins. vec3 uses a GLMAT_ARRAY_TYPE, which is 32-bit floating point, and thus loses precision of the origin. I'll have a simple change to vgl that addresses this. It doesn't fix the problems with the html and d3 renderers or with panning.

:snowman: I saw the change.. cool!

With PR #482 and the appropriate vgl updates, the vgl renderer looks flawless up to zoom level 42 in Chrome.  At levels above that I start to see precision issues.

Well, 2^-42 degrees latitude is 25 nanometers.

Resolved via PR #497, #482, and others.


Upgrade to GHC 9.6.3

https://discourse.haskell.org/t/ghc-9-6-3-is-now-released/7682
And HLS <IP_ADDRESS>: https://discourse.haskell.org/t/haskell-language-server-2-3-0-0-is-now-available/7721

Fixed by #60.


Simplify Skip-to-content links

Fixes

Fixes #2474 by @alexstine
Description

This PR simplifies the "Skip to content" links, making them work without JavaScript.
Previously, the links used a Teleport to move the button to the top of the page. However, the teleports are really finicky, especially in SSR. When I tried migrating to Nuxt 3, teleports were causing client/server mismatch.
Besides, Openverse tries to use progressive enhancing, making  the server-rendered page without Javascript as much as possible work. With this change, "Skip to content" links should work even before the page is "hydrated", and JS starts working.
This PR adds the button at the top of the page in all layouts. This duplication should be removed after the migration to Nuxt 3, when we use app.vue as the top-level component.
VLink.vue is updated to not use a localized path for anchor links that start with # and link to an element on the same page as the link. Some computeds were unnecessary and removed.
Testing Instructions

Open different pages in the app, and navigate to the "Skip-to-content" button using Tab. It should be the first button on the page. On button click, you should be taken to the "main content" of the page. The screen reader should start reading the main content.
Checklist

[ ] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[ ] My pull request targets the default branch of the repository (main) or a parent feature branch.
[ ] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Documentation request
Would it be okay to use a more explicit ID than "content"? That ID is vague enough that I can imagine many would not think twice about removing it. WordPress.org uses wp--skip-link--target, for example. That's a fair bit more self-documenting and expressive as to the intention behind that specific ID, considering it needs to be that ID exactly. It would be tedious, but even refactoring it out into a constant that itself is documented would be an even better approach. If we did that I'd have no qualms about an innocuous ID like content, at least then its purpose would be clearly documented everywhere it is used.

I used your second suggestion and added a constant for the content id that is used for all of the skip-to-content link target elements.

Potential blocker
Whatever ID we land on, we could add the appropriate CSS to ensure the header never covers it when it is scrolled to as an anchor.
I'm 100% confident that this is a blocker, but for sighted users who use keyboard navigation, this would be a regression.

I've added scroll-mt-20 class to the skip to content target element in tailwind.css. This might not work well with the banners, but works with

This is looking really good. One thing I notice is that the focused area after clicking the ling no longer has a visible focus state as it does is production. Is that intentional?

This is looking really good. One thing I notice is that the focused area after clicking the ling no longer has a visible focus state as it does is production. Is that intentional?

I don't know whether the correct behavior is to have a visible focus state or not, but I added it in the latest commit. So, now it matches the prod.

I'll review this again tomorrow, @obulat


[V3] Implement new Concept Exercise: constructors

This issue describes how to implement the constructors concept exercise for the JavaScript track.
Getting started
Please please please read the docs before starting. Posting PRs without reading these docs will be a lot more frustrating for you during the review cycle, and exhaust Exercism's maintainers' time. So, before diving into the implementation, please read up on the following documents:

The features of v3.
Rationale for v3.
What are concept exercise and how they are structured?

Please also watch the following video:

The Anatomy of a Concept Exercise.

Goal
This exercise aims to teach students how constructors are implemented in JavaScript.
Learning objectives

Know that constructors are regular functions
Know how to use built-in constructors
Know how to define and use custom constructors
Know how to use the constructor class method
Understand the importance of the new keyword

Out of scope

Performance of built-in constructors vs. object literals

Concepts

constructors

Prerequisites

any data type used in the exercise
inheritance
classes

After

Performance of built-in constructors vs. object literals

Help
If you have any questions while implementing the exercise, please post the questions as comments in this issue.

I am closing this issue because we decided to cut concepts/concept exercises differently. See https://github.com/exercism/javascript/issues/951#issuecomment-778834953 for details. Constructors are now part of the classes concept (https://github.com/exercism/javascript/issues/1015).


doc: fix CachedResponseHandler ResponseCacher documentation

Hello!
Goals :soccer:
This PR updates the documentation of the ResponseCacher in CachedResponseHandler.
It changes the notion of Follow by the notion of Cache. It tries to follow the convention used in Redirector from RedirectHandler.swift.
The documentation is also generated in a second commit, which is dedicated to the jazzy run.
Thanks!

Thanks for the PR! We only update the Jazzy docs as part of a release, so please remove those changes from the PR.

Thanks!


Added description for production environment

The tutorial now ends at development point where a local development version of Jenkins is running inside Vagrant box.
Next we need to document how to deploy the installation to a real production CI-server.
This patch lists some ad hoc requirements that I came up without actually yet doing the deployment. The link for Ansible requirement was directly to CentOS 7 install instructions.

Thanks, this is a good idea. I added some comments to the commit.


Provide a way to configure the mainFields for webpack

The application build relies on the default webpack resolution of entry points for imported libraries, which are ["browser", "module", "main"] for a web application.
Per spec (I believe) the module entry contains the ESM5 version of the library, i.e. tree shaken but transpiled to ES5.
Some libraries, in particular those built with ng-packagr offer additional entry points, such as ESM2015 that contains a tree shaken version compiled to ES2015.
I suggest that the react scripts allow to override the desired priority order in which entry points are resolved, such that the application author can decide to consume a smaller version of a library (because it has been compiled to ES2015 instead to ES5).
In webpack this is accessible via the https://webpack.js.org/configuration/resolve/#resolvemainfields field, but this configuration is not exposed by react scripts.

Thanks for the suggestion! I don't think we're interested in supporting this at the moment; create-react-app is pretty against adding additional configuration except when it's necessary, and this is more of a performance optimization. Maybe we could add more resolutions by default if the community rallies more around a standard. I'm not very knowledgeable here though, so maybe that's already happened with ESM2015.

@heyimalex what is the current code generation strategy for react scripts? Will they create ES5 code or ES2015 code. In the typescript case I assume that they will use what's defined in tsconfig.json.
Would it be possible to add esm2015 to the lookup chain if tsconfig.json is already configured to generate es2015 level code? This would not require an additional configuration step and if a library does not support esm2015 nothing will break.

We use babel/preset-env and browserslist. It’s not so much that I don’t want to handle ES2015 code in node_modules (I’m pretty sure we currently do), but that I’m not sold on ESM2015 being the de-facto module entry point. For instance, I think node still hasn’t decided what their es modules entry point key is going to be. I expect some churn here soon.
It’s also just easier to punt on this than to expect packages used by our end-users to have their ESM2015 entry point properly configured, which is the problem I want to avoid; upstream lib just points ESM2015 to their non-compiled code, which has some non-standard ES2015 features (ie decorators), and then we break our user’s builds. If the ecosystem rallies around a standard, I would feel more solid pointing the finger at the misconfigured libraries (like we can for misconfigured libraries now), but until EVERYONE is opening those PRs that’s an annoying burden to put on CRA users.
I also can see the benefit, and maybe I’m overthinking it. Also I don’t speak for the whole team.
I just got really strong deja vu and I actually think this has been discussed before, so maybe we should find that issue hahaha.

Thanks for the explanation. I understand your conservative approach on this, once introduced it will be hard to remove it in the future if it turned out to be the wrong decision.
Standardization on the module entry points in package.json is unfortunately non existent, except for the main entry (afaik). Even the module entry is not well defined other than it using ES module syntax. I could e.g. not find any reliable information that it has to be ES5 code with ESM import style.
A sort of de-facto standard I am aware of is the Angular Package Format (https://goo.gl/jB3GVv). Despite having been defined by the competition, this is a concise spec and library generation is also well supported by tools such as ng-packagr (the later can also be used to create react projects without any remaining reference to Angular, despite the naming).
So I think it would be a good step to align with APF.

@CarstenLeue at the end of the README it says that if you need more customization you have alternatives. It seems very outdated.
Did you try CRACO?
https://github.com/gsoft-inc/craco


Documentation and examples for HuggingFace cross-encoders

I checked the documentation and the blog, but could not find HuggingFace cross-encoders.
I'm already using HuggingFace bi-encoders in first phase.
I'd like to use HuggingFace cross-encoders on second phase and/or global phase.

Hey @eostis,
Complete example https://github.com/vespa-engine/sample-apps/tree/master/transformers
Notice that we should

rewrite it to use https://docs.vespa.ai/en/reference/embedding-reference.html#huggingface-tokenizer-embedder tokenizer instead of the word piece implementation
Include a export script

Notice that we should
rewrite it to use https://docs.vespa.ai/en/reference/embedding-reference.html#huggingface-tokenizer-embedder tokenizer instead of the word piece implementation
Include a export script

Indeed, that was my point.

Do you think we could also use cross-encoders with https://docs.vespa.ai/en/reference/embedding-reference.html#huggingface-embedder ?

No, cross-encoders take both the query and the document as input at inference time, so it does not fit.

Thanks for your time @jobergum.
I'll deliver a first release of WPSOLR without the cross-encoders, and add it after more studying.
Vespa's blog is a very good starting point for that.

Added documentation on running different types of cross-encoders in Vespa.


Navigation took more than undefinedms

When the goto API has headers as options and timeout missing throws undefinedms error

goto('http://the-internet.herokuapp.com/basic_auth',{headers:{'Authorization': 'Basic YWRtaW46YWRtaW4='},waitForNavigation:false})
✘ Error: Navigation took more than undefinedms. Please increase the timeout., run .trace for more info.

Working as excepted. Currently its displaying the time period if it takes more than defined time.
Tested Version:
6e9aa9f


testPolicyWithCertificatePinningAllowsHTTPBinOrgServerTrustWithEntireCertificateChainPinned is failing

Certificate pinning tests in Tests/Tests/AFNetworking Tests/AFSecurityPolicyTests.m, such as testPolicyWithCertificatePinningAllowsHTTPBinOrgServerTrustWithEntireCertificateChainPinned, are failing with the assert:
Policy should allow HTTPBinOrg server trust because at least one of the pinned certificates is valid

This is blocking PRs.

Should be fixed with my most recent PR.


Use trade aggregation api in api

This thing: https://github.com/irisli/stellarterm/blob/master/api/functions/utils/tradeWalker.js#L35
Should use this api: https://github.com/irisli/stellarterm/blob/master/src/lib/MagicSpoon.js#L249

Done!


Need to be able to specify the AdminOverrideURL

Needed when connecting to certain office365 tenants where the powershell cant discover the management uri and the user is using a customer domain to login instead of an on microsoft domain.
For example
New-CsOnlineSession -OverrideAdminDomain fabrikam.onmicrosoft.com

Gui 2.0 addresses this #15


Can you support RTL?

This is effective for right-to-left languages, such as Hebrew and Arabic.

Does the layout not work out of the box with RTL when system language is Hebrew? I am new to RTL.

Not. It doesn't work. This needs to be defined within the code.


Use Tick.Price for fill price when bid/ask spread is not available

When an equity at tick resolution is used in Lean, it is seeded with a price using minute data.  For equities, this adds a TradeBar to the security.SecurityCache. When the ImmediateFillModel is then used with this security (and tick Bid/Ask spreads are not available), the ImmediateFillModel uses the tradebar that was used to seed the security to generate the fill price.
This PR uses the tick.Price in the ImmediateFillModel when the tick bid/ask spreads are not available.
This bug can also present itself when securities are removed and then re-added at a different resolution or with a different data type.  In order to prevent this, when a security is removed its cache is cleared.

Also potentially impacts some algorithms as when the security is removed the price will be reset to $0; where previously it would maintain its last price.


Implement ops for primitives + Ratios; ops for BigRational + primitives

Before this I was not able to use a primitive as the left-hand side of a core::ops::{Add, Sub, Mul, Div} method where the right-hand side was a Ratio of some type; this implements those. Also, I was not able to use a BigRational on the LHS and a primitive on the RHS of a core::ops::{Add, Sub, Mul, Div} method; this implements those as well (although I'm not sure I'm doing it in the most efficient code). I'm hoping these changes are welcome; I'm pretty new to the num crates and feel like I may have been missing something that should've been obvious.
Initially I'd manually implemented most of this stuff (not using generics), leading me to write a bunch of tests for all of the combinations of types, then refactored to use generics. Thus there's a bunch of tests that should cover all of the cases (hopefully not too many!). In doing so, it really started to feel like maybe some of the ops code could live in a separate file (mainly due to all of the tests), but since I'm not too familiar with this repo I decided to not rock the boat too much.
I've also done very little Rust work with others, so I may be missing some conventions--sorry about that! Please do let me know so I can tidy up accordingly.

Ok, I've got all builds except for the 1.15.0 one passing; I'm not sure how to deal with those {i,u}128 failures though. Any tips would be quite helpful.

When guarding code, please use #[cfg(has_i128)] instead of by feature, so it's still enabled by the build-script detection.  For integer literals like 0u128, even guarded code becomes a problem since it still has to parse by the old compiler.  You can let type inference handle it in some cases, like if calling fn foo(x: u128) then foo(0) is fine.  In other cases you might have to assign a local first, let x: u128 = 0, which still parses on the old compiler even though it doesn't know that type.

Ah, thank you @cuviper, that was super helpful (and makes total sense). Fixed all of those.
The other failures seem to have to do with isize::from() not being implemented for u8 and i16 until 1.26.0. I'm not really sure how to fix those tests (they seem relevant for current versions) so I've just commented them out (don't really like doing that) and left a TODO. I can remove these or whatever seems preferable, just let me know.

Are there any problems with this PR? Just wondering as I have some other changes I'm curious about making, but they sort of build on the changes here and I don't want to get too far along there if there are problems here. TIA

No problems AFAIK -- I was just on vacation and haven't come back to look at this again.  I'll try to review it soon!

@cuviper oh, nice! I mostly just wanted to give it a bump so it doesn't die. Thanks!

@cuviper thanks for the review! I hope to get to responding to all the things in the new few days. 🍻

I just remembered this PR and wanted to pop in and say that I had to backlog the work I was doing that depended on these changes. That work is still in my (day job) backlog but I’m not sure when I’ll get time to pick it back up.

Just wanted to give this a bump as I noticed the lack of primitive support as well. I have been creating Ratios from the integers to to the the math, but I don't think it's a great solution. If it would help, I might be able to take a look at the requested changes for this PR and see what I can do.


[BUG] Placeholder rendering fails loudly without PageContent or Model

Description
Non-root AppHook pages or Views that aren't tied to a model with placeholders will fail loudly if their parent template has any placeholders that are rendered with {% placeholder "name" %}
In CMS3 this works fine when inheriting and it just ignores the placeholders, but in CMS4 it breaks because it seemingly tries to render the placeholders. For example in our base:
{% block hero %}
    {% placeholder 'hero' %}
{% endblock hero %}

class SomeView(DetailView):
    template_name = "app/template.html"

    def get_object(self, queryset=None):
        return request.user    # Something here that doesn't define any placeholders

If we leave this block in our template.html it will attempt to render and break with NoneType should implement get_template because there's no PageContent or toolbar object.
Steps to reproduce
Steps to reproduce the behavior:

Create an app with at least 1 non-root view. Make sure there's a {{ placeholder "name" }} in the template
Add the app to a page
Go to the sub-page link
See error

Expected behaviour
In CMS3 this simply doesn't render the placeholder. The page can load as normal with only the available placeholders
Actual behaviour
In CMS4 this fails loudly with NoneType should implement get_template
Additional information (CMS/Python/Django versions)
Only requires django-cms > 4
Linked issue
https://github.com/django-cms/django-cms/issues/7712
Do you want to help fix this issue?

[ ] Yes, I want to help fix this issue and I will join the channel #pr-reviews on the Discord Server to confirm with the community that a PR is welcome.
[x] No, I only want to report the issue.

@Will-Hoey I've created a fix. You are invited to test run it (to ensure it works for your environment).

@fsbraun I'm in the midst of testing this, but I realise that we have cms-versioning installed as well which also seems to have a similar plugin renderer which is causing a similar issue https://github.com/django-cms/djangocms-versioning/blob/master/djangocms_versioning/plugin_rendering.py#L48
AttributeError: 'NoneType' object has no attribute '_meta' when it runs the rescan_placeholders_for_obj(current_obj)
I'm looking at decoupling versioning from the project for now so I can test this fix in isolation

Yes, well done. We need to change both.  Maybe there is a way of reducing code repetition.

@fsbraun thanks for the update. I had just realised that it only applies to specific versions of CMS. Thanks for the speed of the fix + responses!

My pleasure. I want to release django CMS 4.1.2 and djangocms-versioning 2.1 soon. It would be great to get this issue fixed for both, too.  Let me know your test results.
(Funny side remark: The comment in versioning's plugin_renderer refers to this issue - a typo that got me confused.)

I also noticed the typo...it had me both confused and impressed at the same time

@fsbraun patched the versioning ContentRenderer and removed the specific CMS version fixes. Works as expected so can confirm it'll be fixed next version. Will eagerly await the new releases! Thanks


Typo on #03

Some minor formatting proposals

Looks good but commits have to be signed, see instructions here: https://github.com/IBM/cap/blob/master/docs/contributing.md#dco-signing

@kant ping...


Weeds panel

Farm designer panel for viewing/managing weeds.

Empty state graphic + nav icon: Weeds Graphics.zip


remove provider specification when starting lvm2-lvmetad, use the default provider that the system can discover

not all redhat 7 family uses systemd as service startup. Amazon Linux  2017 is classified redhat family, but it doesn't use systemd, instead if uses init.d
The attribute on amazon linux 2017 is
node['platform'] => amazon
node['platform_family'] => rhel
node['platform_version'] => 2017.03

it will satisfy the check condition, but it will fail at starting the lvm2-lvmetad service using systemd provider (because it doesn't use systemd, instead it uses init.d
[ec2-user@ip-172-31-20-128 ~]$ sudo service lvm2-lvmetad status
lvmetad (pid  1891) is running...
[ec2-user@ip-172-31-20-128 ~]$ cat /etc/os-release
NAME="Amazon Linux AMI"
VERSION="2017.03"
ID="amzn"
ID_LIKE="rhel fedora"
VERSION_ID="2017.03"
PRETTY_NAME="Amazon Linux AMI 2017.03"
ANSI_COLOR="0;33"
CPE_NAME="cpe:/o:amazon:linux:2017.03:ga"
HOME_URL="http://aws.amazon.com/amazon-linux-ami/"

I believe the original change is to ensure lvm2-lvmetad is enabled/started, so lvm partition will work on redhat families. Hence I believe we should still include this for amazon linux 2017. Just need to make sure it's enabled/started by the correct provider
The change is to allow the lvm2-lvmetad service to be started using the system's default service startup provider

Additional investigation.
The reason this didn't fail for amazon linux 2016 is because amazon linux 2016 doesn't have the use_lvmetad config set to 1, hence it skipped the step to enable/start the lvm2-lvmetad service
[ec2-user@ip-172-31-28-89 ~]$ cat /etc/os-release
NAME="Amazon Linux AMI"
VERSION="2016.09"
ID="amzn"
ID_LIKE="rhel fedora"
VERSION_ID="2016.09"
PRETTY_NAME="Amazon Linux AMI 2016.09"
ANSI_COLOR="0;33"
CPE_NAME="cpe:/o:amazon:linux:2016.09:ga"
HOME_URL="http://aws.amazon.com/amazon-linux-ami/"
[ec2-user@ip-172-31-28-89 ~]$ sudo /sbin/lvm dumpconfig global/use_lvmetad
use_lvmetad=0

However for amazon linux 2017 if has the use_lvmetad config set to 1.
[ec2-user@ip-172-31-20-128 ~]$ cat /etc/os-release
NAME="Amazon Linux AMI"
VERSION="2017.03"
ID="amzn"
ID_LIKE="rhel fedora"
VERSION_ID="2017.03"
PRETTY_NAME="Amazon Linux AMI 2017.03"
ANSI_COLOR="0;33"
CPE_NAME="cpe:/o:amazon:linux:2017.03:ga"
HOME_URL="http://aws.amazon.com/amazon-linux-ami/"
[ec2-user@ip-172-31-20-128 ~]$ sudo /sbin/lvm dumpconfig global/use_lvmetad
use_lvmetad=1

hence it will try to start the lvm2-lvmetad service (as it requires it to have lvm working). But it fails because amazon linux 2017 chooses to use init.d instead of systemd

just a note, i tried removing if node['platform_family'] == 'rhel' && node['platform_version'].to_i >= 7
it failed on ubuntu
https://travis-ci.org/chef-cookbooks/lvm/builds/223384356
with
     ChefSpec::Error::CommandNotStubbed:
       Executing a real command is disabled. Unregistered command:

not sure why it's

Hi @tas50
Can you help me with some guidance on how to sign the DCO.
I'm a bit confused on what to do.

I've made a similar change to this on master and released it.
@Shuliyey Here's a overview of the DCO process and why we require it
https://blog.chef.io/2016/09/19/introducing-developer-certificate-of-origin/


Unable to specify the exact version of one crate

Describe The Bug

I followed the instruction in the README.md: here, and tried to specify a specific version of rustfmt by doing:
[tasks.fmt]
install_crate = { crate_name = "rustfmt", binary = "rustfmt", version = "1.4.38", test_arg = "--help" }
command = "cargo"
args = ["fmt", "--all", "--manifest-path=rsmain/Cargo.toml"]

but result in the below warning, and still the installed old version of rustfmt is used:
[cargo-make] INFO - cargo make 0.35.6
[cargo-make] INFO - Build File: Makefile.toml
[cargo-make] INFO - Task: fmt
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Running Task: legacy-migration
[cargo-make] WARN - Unable to read currently installed version for crate: rustfmt
[cargo-make] INFO - Execute Command: "cargo" "fmt" "--all" "--manifest-path=rsmain/Cargo.toml"
[cargo-make] INFO - Build Done in 2.21 seconds.

But in the same console if i do rustfmt --version i got rustfmt 1.4.37-stable (59eed8a2 2021-11-01) correctly, no idea what the WARN is complaining.
To Reproduce

Just create a default Makefile.toml and copy in the above task definition and run.
Wha am i missing? How should i make sure the version i want get installed?

thanks for notifying me. i'll check it out.

@lnshi the reason it didn't work for you is that rustfmt is installed from rustup which seems not to update the .crates.toml which i use to find the version.
I'm going to add an additional check using the --version cli command to find out of those type of crates.
however, in your specific use case, it won't help, because i think rustfmt installation instructions do not talk about simple cargo install. so maybe it will solve your issue, maybe it won't.

@lnshi you can try out the dev branch 0.35.7 which now has the fix for this.
would love your feedback to understand if it starts up the cargo install.

@sagiegurari thanks for the quick response, i will try it out

@lnshi this is now officially released. if you still face issues, feel free to open a new issue.


luci-base: apply fix for admin.lua

fix for #2048

Signed-off-by: Dirk Brenken<EMAIL_ADDRESS>

@jow OK to merge?

Hm, no not sure. I think it will cause SSH server changes to bypass the rollback mechanism. Will close this for now and come up with an alternative solution later.

Seems it does the job indeed - will merge it.

Merged with 32ee1873a - thanks!

Already forget about this one - thanks for merging!


captureEnd Event is not triggered inside writeAnchorTag function

Hi,
I am trying to write an extension for github mentions. However I figure out captureEnd event is not triggered in writeAnchorTag. FYI
https://github.com/showdownjs/showdown/blob/db69d02974df5df13ab68a655e7fa29178678e26/src/subParsers/makehtml/links.js#L132

Those events are not supported yet. I'm in the middle of a complete reqriting of the parser and event systems for version 2.0.

@tivie I see. I think the design is good. I am sorry I needed to check latest version rather than master.

No problem. I pushed those updates because I was having troubles with my local disk and didn't want to lose the code changes.


L4t ros2 base

How to try it
sudo apt install -y nvidia-container-toolkit qemu-user-static binfmt-support
docker run --gpus all --network host -it -e DISPLAY=$DISPLAY -v /tmp/.X11-unix/:/tmp/.X11-unix wamvtan/ros:galactic-ros-base-l4t-r32.6

In the container,
apt install g++-8 -y && \
    rm /usr/bin/gcc /usr/bin/g++ && \
    ln -s /usr/bin/gcc-8 /usr/bin/gcc && \
    ln -s /usr/bin/g++-8 /usr/bin/g++
cp -r /usr/local/cuda/samples /tmp
cd /tmp/samples/1_Utilities/deviceQuery
make -j`nproc`

/tmp/samples/bin/aarch64/linux/release/deviceQuery

root@devenv:/tmp/samples/5_Simulations/nbody# /tmp/samples/bin/aarch64/linux/release/nbody -benchmark
Run "nbody -benchmark [-numbodies=]" to measure performance.
-fullscreen       (run n-body simulation in fullscreen mode)
-fp64             (use double precision floating point values for simulation)
-hostmem          (stores simulation data in host memory)
-benchmark        (run benchmark to measure performance)
-numbodies=    (number of bodies (>= 1) to run in simulation)
-device=       (where d=0,1,2.... for the CUDA device to use)
-numdevices=   (where i=(number of CUDA devices > 0) to use for simulation)
-compare          (compares simulation results running once on the default GPU and once on the CPU)
-cpu              (run n-body simulation on the CPU)
-tipsy=<file.bin> (load a tipsy model file for simulation)
NOTE: The CUDA Samples are not meant for performance measurements. Results may vary when GPU Boost is enabled.
Error: only 0 Devices available, 1 requested.  Exiting.

When docker is launched with --gpus all, it mounts the host's nvidia-driver components into the container. And so, there is a limitation mentioned in https://github.com/NVIDIA/nvidia-docker/wiki/NVIDIA-Container-Runtime-on-Jetson#building-jetson-containers-on-an-x86-workstation-using-qemu

After all, we have to run it on Tegra devices


Initial Release: 1.0.0 version of the website

What does this PR do?
This PR is raised to implement the following features 👍:
API

[x] Use an API so you can base the development of the webapp around it.
[x] Use this Involvement API to record the different user interactions (likes and comments).

Interface

[x] Build home page and popup interfaces using the provided wireframes.

Home page

[x] When the page loads, the web-app retrieves data from Involvement and Items APIs.
[x] When the user clicks on the Like button of an item, the interaction is recorded in the Involvement API and the screen is updated.
[x] When the user clicks on the "Comments" button, the Comments popup appears.
[x] Home page header and navigation similar to the given mockup.
[x] Home page footer similar to the given mockup.

Comments popup

[x] When the comment popup loads, the web-app retrieves data from the Involvement and Items APIs.
[x] When the user clicks on the "Comment" button, the data is recorded in the Involvement API and the screen is updated.

Counters

[x] Count the number of items (home)
[x] Count the number of comments (popup)

Technical set up 🙌

[x] Set up the repository on GitHub and use Gitflow.
[x] Set up webpack.
[x] Set up a JavaScript testing library (Jest).
[x] Added the HTML for the structure.
[x] Added the SCSS file for the styling.
[x] Added the js file for DOM manipulation.
[x] Used the linter tool that analyzes my source code to flag programming errors, bugs, stylistic errors, and suspicious constructs. 💯

Thank you @elisha2kyakpo1 for the thorough review. We managed to fix all the warnings. 🥳


Added muteable prop for enabling/disabling the mute volume.

This should address the issue https://github.com/Werter12/material-ui-audio-player/issues/434
Adds a muteable prop to the AudioPlayer which passes down to the AudioVolumeControl to condition whether the audio is muteable or not.

@sairojgg thanks for contributing! I refined your PR a little bit. Now, the developer could choose to control the muted state or not.

@sairojgg thanks for contributing! I refined your PR a little bit. Now, the developer could choose to control the muted state or not.

Thank you for the great work you've done for this!


e2e  TestReceive/replication_with_outage is flaky

See: https://github.com/thanos-io/thanos/pull/3773/checks?check_run_id=1838083024#step:5:2345

See: https://github.com/thanos-io/thanos/pull/3773/checks?check_run_id=1838083024#step:5:2345

No check run found with ID<PHONE_NUMBER> for this pull request. :thinking: