Rename the github repo to match the pip package name

It would be good if we could rename the git repository to match up with the pip package name so that is more easily indexed and found via Google.
Furthermore, if we could add a link to this Git repository in the PyPi page it would make usage of the package simpler if someone just stumbles across the PyPi page.

+1 - I sometimes get confused when not finding the "-sdk"
@adriangonz if I update the name would anything break (CI, scripts, etc)?

+1 - I sometimes get confused when not finding the "-sdk"
@adriangonz if I update the name would anything break (CI, scripts, etc)?

I can't see any references to seldon-deploy-client so I think it should be alright to go ahead @axsaucedo!

I can't see any references to seldon-deploy-client so I think it should be alright to go ahead @axsaucedo!

Sounds good - just updated

Sounds good - just updated

Actually @adriangonz there may be references in the documentation that would still reference "-client" instead of "sdk - there is a redirect set up so this shouldn't be an issue, but we should still make sure it's updated (would only be an issue if we crete another repo called "seldon-deploy-client"

Actually @adriangonz there may be references in the documentation that would still reference "-client" instead of "sdk - there is a redirect set up so this shouldn't be an issue, but we should still make sure it's updated (would only be an issue if we crete another repo called "seldon-deploy-client"


New package: TheCannon v0.1.0

Registering package: TheCannon
Repository: https://github.com/ajwheeler/TheCannon.jl
Created by: @ajwheeler
Git reference: register/TheCannon/v0.1.0
Version: v0.1.0
Commit: afbb7c711ffc3005c293593291ff5b5b70fe87f3
Reviewed by: @ajwheeler
Reference: https://github.com/ajwheeler/TheCannon.jl/commit/afbb7c711ffc3005c293593291ff5b5b70fe87f3#commitcomment-33494356

Pretty weird name, have you seen https://julialang.github.io/Pkg.jl/v1/creating-packages/#Package-naming-guidelines-1 ? Maybe the name makes sense, what does the package do? Would be nice to add some information in your readme.

Apologies, I didn't realize a human would be looking at this.  I've added a bit more detail.  The package name is definitely appropriate, at lease within the (niche) stellar spectrum community.

Great! Can you also add some compatibility constraints to your Project file? At least e..g
[compat]
julia = "1"

see https://julialang.github.io/Pkg.jl/v1/compatibility/.

Consider enabling TagBot to make sure the release is persistent in your repo, see https://discourse.julialang.org/t/ann-tagbot-creates-tags-and-releases-for-your-julia-packages-when-theyre-registered/23084


Switch to Gaia

(This PR depends on #48 being merged)
Resolves #33
This will let us actually use gaia-based networks (baseserver is not compatible, so balance will always show 0). We can currently only use older networks like tak
AC:

[x] Switch to use gaia-1 network by default
[x] Switch to gaiaserver

We now have a working gaia server command in cosmos/gaia, but it's on a WIP branch. So if we merge this, things will work in development, but it would temporarily break production builds since our scripts pull that code using go build which only takes what is on master (it's not possible to specify another branch). So to finish this PR for merge we could either:

Modify the build scripts to checkout the WIP branch for gaia, which would make production builds work now, although they would be targeting an unstable WIP branch

OR

Merge the PR as-is, letting us work on top of this in development but leaving production builds non-functional until the gaia server command makes it into a cosmos/gaia master release

What do you guys think? @faboweb @keppel @nylira @jolesbi

I vote for merging this and communicate, that we are blocked on production build while gaiaserver is not in master.

This PR is almost done, but I'm having some trouble fixing the tests for the switching the light-client command from baseserver serve to gaia server serve.

This is ready for merge 🎉 just needs another review

Hm, merging develop into this is making a test fail (not hanging this time)

On it right now


Add add-karpenter-daemonset-priority-class

Description
When a DaemonSet is added to a cluster every node will get a new pod. There may not be enough room for this on every node. Karpenter cannot provision extra nodes just for the DaemonSet because the new pods are not scheduled the way regular pods are. It would require parallel scheduling logic that is not proper to Kubernetes. Therefore, eviction of regular  pods should happen instead. This can be achieved with the priority class system-node-critical.
Checklist

[x] I have read the policy contribution guidelines.
[x] I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
[x] I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

Thank you for this PR. Couple things. Could you merge main and also sign off on your commits, please?

Hi Chip,
I have to admit I never heard of signing off commits before. I will follow the procedure described in DCO to fix it.
The PR was created off the main branch, as requested in the contributions section. Do you mean I should merge main when fixing the DCO?
Best regards,
Werner.

I will start over with a new pull request because I'm afraid of breaking something.


[EDT-11121] updated download && preview methods + new DTO's

This PR introduces Font Families support by:

Adjusting download method (by removing previewType)
Adding a preview method with previewFormat param
Adding new models: FontFamily + FontStyle

Related tickets

EDT-1121

Pls resolve conflicts


Adding scenario status filters on the frontend

Overview
This PR adds Scenario (run) job status filtering.
Filtering via API is not yet available, so the filtering is done on the frontend.
Notes:

Filtering is currently done in the respective hook, so that we have it available seamlessly throughout the app

The commented out modal code was kept virtually unchanged

The filters (only the status one) are not sent to the backend, as it'd return no results
Each scenario's run status is currently pulled from api/v1/projects/{$projectId}/scenarios/status, run job
The original property status returned by the backend is not being used, nor overwritten as one would be inclined to do. Couple reasons for this:

Prevent conflicts when the backend implements that property
The ScenariosList deals with all sorts of job statuses (not just the run one), this way it should be clear that it's not the same one sent by the backend, plus that way there was no need to remain a bunch of variables in that component

I have noticed that the backend can return 1 of 4 different statuses: created, running, done, failure. I've added filters for all of them. (created are scenarios that have been created but were never run)
Filters/Search/Sorting will be cleared when switching probjects

Other notes:

I took the liberty to fix some typos in the code (mostly error messages, they wouldn't ever been seen by an user)
I also took the liberty of reorganising/refactoring the Scenarios#show component a little, because I have noticed that:

Two consecutive API calls were being made to the same endpoint, with with search/filters and the other without (excluding projectId).  This would cause double the rendering as well.
Both sets of returning data were a bit confusing, and not needed. If I had to take an educated guess, this would be from an initial stage of the project; possibly when searching was done in the frontend (which is no longer the case)
It's not perfect, but I mainly wanted to address the double-calls / double-rendering

Testing instructions

Create an empty project, with  no scenarios. Verify that:

The pretty screen to create a new scenario is show
The toolbar is not shown (search, filters)
The create scenario button at the very bottom is not shown

Create a few scenarios, ensure that:

Search still works correctly
Filters work correctly

It may be needed to mock job statuses returned by the API, as it'll be hard to catch scenarios with a running and a failure statuses.

Search + Filters together work correctly
When there are no results, the appropriate message is shown
The "Clear all" button in the filters model clears all filters
That when navigating to a new project, filters/search will be cleared
(it becomes a problem specially when switching to a project with no scenarios)

Feature relevant tickets
MARXAN-685
Screenshots

When navigating to a new project, previous filters remains.


Typos in README.md

Fixes some typos in the README.md, especially in its build instructions.

Thanks for the corrections, looks good to me.


Update back-end-server.md

SQL 2017 is supported on SfB Server 2015 so it would be supported on Mirroring:
https://docs.microsoft.com/skypeforbusiness/plan-your-deployment/requirements-for-your-environment/server-requirements#DBs
AlwaysOn is supported on SfB Server 2019, Mirroring not:
https://techcommunity.microsoft.com/t5/Skype-for-Business-Ignite-Blog/Ignite-2018-BRK3229-Everything-you-need-to-know-about-Skype-for/ba-p/264448

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@MicrosoftHeidi Hi Heidi, Changes look correct, could you please review and merge? Thanks!

@SerdarSoysal @MicrosoftHeidi Hi Heidi, any updates on this? Thanks

https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/1351


The method 'clampDouble' isn't defined for the type 'AppBackdrop'.

The method 'clampDouble' isn't defined for the type 'AppBackdrop'.

As mentioned in the readme, you should build with beta or master branches of flutter sdk.


overrideWith does not allow you to mock repositories, regression since overrideWithProvider

Previously, I was able to mock repository calls for overrideWithProvider with mockito when, however, since upgrading to Riverpod 2.1.1 and using the new syntax overrideWith in some cases it doesn't respect the when calls. This caused quite a number of tests to fail.
Left is old, right is new syntax:

overrideWithProvider has some detailed information about how to replacing a service with a fake implementation, however, I am not sure why exactly overrideWith sometimes does not respond to the .when. Would you be able to provide some advice/examples of the recommended way to test using overrideWith

Much appreciated

It's not a regression, but rather your refactoring is incorrect. Your old vs new don't match.
You might want to change your mock definition to:
MyNotifierMock createNotifierMock(Ref ref) {
  return MyNotifier();
}

Then used as
overrides: [provider.overrideWith(createNotifierMock)]

Alternatively, instead of setupAll you could use setup for creating your notifier.

overrideWithProvider has some detailed information about how to replacing a service with a fake implementation, however, I am not sure why exactly overrideWith sometimes does not respond to the .when. Would you be able to provide some advice/examples of the recommended way to test using overrideWith

overrideWith has a similar documentation. That's what the @macro is. If you hover overrideWith, your IDE should show you the documentation


Bump SRCREV to latest for Torizon OS 7.1.0-devel-202412 monthly pre-release

Related-to: TOR-3608

@lucasbernardestoradex, could you please try a local build with those bumps?
On RAC https://github.com/torizon/rac/commit/15c84bb597cad2970d98312e33d744aad929af7d, there was a bump on russh, so we might need to change the recipe as well.

@lucasbernardestoradex, could you please try a local build with those bumps? On RAC torizon/rac@15c84bb, there was a bump on russh, so we might need to change the recipe as well.

Of course, I will try this!


Anyone had a weird colour/panel issues like this (Videos in post) with FM6126A?

Anyone seen an issue like this with the FM6126A chips?  Half the panel doesn't work properly for specific colours (Blue and white at the very least in my case)

https://youtube.com/shorts/Lsooh_Fq6xk

https://youtube.com/shorts/Ftod6rLqdhg

5v 20a supply
ESP32 Trinity by Brian Lough

(Side note: How do I embed YT videos!?)

Problem with B1 or B2 pin.

Problem with B1 or B2 pin.

Maybe pin mapping perhaps??
If I use a Raspberry Pi Zero with the Adafruit RGB Matrix Bonnet, it works perfectly in all colours including blue and white.  So it's potentially an ESP32 issue, or a library issue (Or I need to check pin config)

Can you do a test and connect the R1, B1, G1 pins to the R2, B2, G2 output of the ESP32 and also the other way around (essentially draw the top half to the bottom of the panel, and the bottom half to the top)?
When you do this, do you get the issue in the SAME halves of the panel as it was originally (when connected correctly)?
IF so, then it indicates it's yet another issue with the 'secret' FM6126A initialisation registers potentially. Have you configured the ESP32 library with FM6126A as the panel type?


I can't navigate owned directories on root

The debian package has full access to the file system, but the snap package has some limitations due to snap security rules.
I have a folder into my root /src and it's owned by my current Ubuntu user, but gitkraken can't see it. I think this could be fixed using --classic as an installation flag (apps like Intellij or Atom use this flag).
sudo snap install gitkraken --classic

Otherwise I'm forced to use my "git folders" into my home.
OS: Ubuntu 17.10

This snap is not a classic so you can't just expect it to do what classic snap have granted permissions in the strict snap as you said have the limitation against which is correct as you said.
Though you can try linking your /src folder to home this could work out for you, which current user have permissions to that folder you say.

I have tried to make a sym link $HOME/src -> /src but gitkraken don't show the folder on the file browser (nautilus) to select.

Then I can't help you with this as the strict confinement does not allow snap to access it, though it can access it from mounted partitions when you connect the snap interface.
sudo snap connect gitkraken:removable-media
then it can access files from removable media in /media and /run/media.

Why gitkraken is not using a --classic installation?

Because this snap package is not built as classic it is rather build to be with strict permissions.

Hi, how can I make gitkraken access the /var/www directory ?

Thanks,
I've created the issue here on snapd
https://forum.snapcraft.io/t/create-an-interface-to-allow-snap-app-access-var-www-directory/5238


ARROW-17993: [CI][Release] Use Node.js 18 for verify-rc-source--macos-conda-

Because Node.js 17 and expect 29.1.2 are conflicted.
https://github.com/ursacomputing/crossbow/actions/runs/3224409421/jobs/5275509496#step:6:759
error<EMAIL_ADDRESS>The engine "node" is incompatible with this
module. Expected version "^14.15.0 || ^16.10.0 || >=18.0.0". Got
"17.9.0"

@github-actions crossbow submit verify-rc-source--macos-conda-

@github-actions crossbow submit verify-rc-source--conda-

+1


New rule: don't return a value inside a nursery?

See https://github.com/python-trio/trio/issues/1493 - I'm not sure whether this is a good idea for a lint rule, but wanted to track it so I can decide later.

Per https://github.com/python-trio/trio/issues/1493#issuecomment-2277211298, let's do it!

This also applies to anyio, which appears to behave identically to trio regardless of backend.
I don't think it applies to asyncio, or at least I'm not able to manifest any counterintuitive behavior. This is largely because you cannot manually cancel their cancelscope-equivalents, and asyncio.Cancelled will always be transformed to a TimeoutError, so whenever you're losing the return value it's because you're getting an exception thrown in your face.

I think this is still fairly hazardous:
async with asyncio.TaskGroup() as tg:
    tg.create_task(do_something_forever())
    await asyncio.sleep(5)
    return "all done!"

The return value won't get lost per se, but one does tend to expect a return statement to result in the caller being resumed promptly. Here nothing happens until do_something_forever() completes or is cancelled.


WIP - update readme for release

Still need to add a few things

Is this still a WIP?

Is this still a WIP?

@leogao2 whats going on with this? Should we merge? Dismiss?


Generated client has quotes for ProducesMediaTypes and ConsumesMediaTypes when it is empty

Problem statement
I have generated a client which uploads and downloads the file by making a POST request at the given endpoint for the api. The api requires not to have accept headers and gives me Error 406 if I mention anything in Consumes or Produces media type. But when I don't mention it in the swagger specification file the generated code has quotes in the field.
result, err := a.transport.Submit(&runtime.ClientOperation{
		ID:                 "abc",
		Method:             "POST",
		PathPattern:        "thepath",
		ProducesMediaTypes: []string{""},
		ConsumesMediaTypes: []string{""},
		Schemes:            []string{"https"},
		Params:             params,
		Reader:             &ApiReader{formats: a.formats},
		Context:            params.Context,
		Client:             params.HTTPClient,
	})

Please remove the sections that don't apply
Swagger specification
2.0
Steps to reproduce
Don't mention the "consumes" and "produces" in swagger specification file.
Environment
go version: go1.11.4
OS:
MacOS HighSierra

Empty string value is not a valid value.
I think you may work around the peculiarity of your server by removing this header with a custom Roundtripper for your client.


how to install this in VSCodium

Hi,
I stumbled upon this extension. Is it possible to install in VSCodium as well, and if so, how can I do it? Thank you in advance for your support :)

I never used VSCodium(I use code-oss), but I looked at the github page and it seems that you can simply download the extension from the marketplace. I can't guarantee that the extension will work because it relies on an unofficial feature, but I think that it should work anyway. Try to install it and follow the instructions on the extension page, and let me know if it doesn't work.


Bug with  mapping on timeout followed by backspace

I have found something that I believe to be a bug. It only affects Vim running in a terminal.
It can be reproduced using the following:

Vim running inside terminal that sends ASCII DEL (character code 127) when backspace is pressed
The following mappings:

set timeout
inoremap <bs> BACKSPACE TRIGGERED
inoremap ab test
inoremap a <nop>

Enter insert mode and press a and wait for the mapping to time out, now press backspace. This will not trigger the backspace mapping if there is one, and it won't trigger the default action for backspace if there is no mapping. Instead it will insert the ASCII delete character ^? with character code 127 literally in the text.
The problem also affects command mode, which can be observed by changing inoremap to cnoremap
Tested on version 8.0 invoked using vim -u NONE.

Same behavior is observed by using:
inoremap <expr> a ""

This behavior does not exist in Nvim, which might help someone trying to fix it.

I went back to v7.2 and it had the same behaviour in nocp mode. I believe neovim changed input processing quite a bit.

Looks like, the timedout flag needs to be reset, if the mapping timedout and did not insert anything.
I think this patch fixes it:
diff --git a/src/getchar.c b/src/getchar.c
index ff03905b4..21650cd39 100644
--- a/src/getchar.c
+++ b/src/getchar.c
@@ -2857,6 +2857,8 @@ vgetorpeek(int advance)
  * get a character: 3. from the user - get it
  */
                wait_tb_len = typebuf.tb_len;
+               if (timedout)
+                   timedout = FALSE;
                c = inchar(typebuf.tb_buf + typebuf.tb_off + typebuf.tb_len,
                        typebuf.tb_buflen - typebuf.tb_off - typebuf.tb_len - 1,
                        !advance

(sorry, no test, because I don't know how to test the timeout)

Christian wrote:

Looks like, the timedout flag needs to be reset, if the mapping
timedout and did not insert anything.
I think this patch fixes it:
diff --git a/src/getchar.c b/src/getchar.c
index ff03905b4..21650cd39 100644
--- a/src/getchar.c
+++ b/src/getchar.c
@@ -2857,6 +2857,8 @@ vgetorpeek(int advance)
  * get a character: 3. from the user - get it
  */
                wait_tb_len = typebuf.tb_len;
+               if (timedout)
+                   timedout = FALSE;
                c = inchar(typebuf.tb_buf + typebuf.tb_off + typebuf.tb_len,
                        typebuf.tb_buflen - typebuf.tb_off - typebuf.tb_len - 1,
                        !advance

Thanks.  Since this is complicated stuff, I tend to stay on the safe
side and only reset timedout when typebuf.tb_len is zero.
Would be nice to have a test for this, probably requires running this in
a terminal window.
--
I wonder how much deeper the ocean would be without sponges.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Would be nice to have a test for this, probably requires running this in a terminal window.

I'll have a look.

I tried sending various combinations of <bs>, &t_kb or ^?.


Added encode for the URI (#4511)

Pull request opened by the merge tool on behalf of #4511

Merged in d66b750952c664107ee0b13b24143bbac054c60c


Missing libraries during linking of the building script when linker is specified in config

I currently adjust a library to make it run on Windows. Therefore I have to make sure that the linker used in the building process is from Visual Studio 12. To this end, I define the VS 12 linker in a local cargo config file. Furthermore I have to run a building-script which accesses the environment. My problem now is that building fails at the linking stage (already of the building script) due to missing libraries. This only happens when I specify the linker explicitly. Weirdly, on a machine where Cargo defaults to VS 12's linker, it will include the libraries properly on default but will fail when the same linker is specified explicitly in the config. Am I missing some library include magic which is omitted when I specify the linker in a config file or is this a bug?
Example project:
Structure:
|   build.rs
|   Cargo.toml
|
+---.cargo
|       config
|
\---src
        main.rs

./build.rs:
use std::env;

fn main() {
    let manifest_dir = env::var("CARGO_MANIFEST_DIR").unwrap();
    panic!("Building!");
}

./Cargo.toml:
[package]
name = "some_binary"
version = "0.1.0"
build = "build.rs"

.cargo/config:
[target.x86_64-pc-windows-msvc]
linker = "C:/Program Files (x86)/Microsoft Visual Studio 12.0/VC/bin/amd64/link.exe"

src/main.rs:
fn main() {
    println!("Hello, world!");
}

Running the project with cargo run should produce a linker error with something like

LINK : fatal error LNK1181: cannot open input file 'ws2_32.lib'

or

LINK : fatal error LNK1181: cannot open input file 'advapi32.lib'

They correspond to libraries from the Windows Kit SDKs.

Oh to run linkers like link.exe manually you'd also need to set up a bunch of env vars. That typically happens automatically by the compiler, but if you specify linker yourself then you'd be responsible for taking care of that.
In that case I don't think that this is a Cargo bug, but feel free to let me know if there's still trouble getting it working!

I'd usually use the build-script to set up things like that but since that's where the linking already fails, I'm a bit at a loss here. 😐
My second attempt was to hardcode the missing libraries into the Cargo configuration for the target like this:
[target.x86_64-pc-windows-msvc]
linker = "C:/Program Files (x86)/Microsoft Visual Studio 12.0/VC/bin/amd64/link.exe"
rustflags  = ["-L C:/Program Files (x86)/Windows Kits/8.1/Lib/winv6.3/um/x64",]

However the flag is not included as seen by this error

Process didn't exit successfully: rustc build.rs --crate-name build_script_build --crate-type bin -g --out-dir C:\Users\User\Documents\Rust Projects\some_binary\target\debug\build\some_binary-7fef2f489dde8cdb --emit=dep-info,link -C linker=C:/Program Files (x86)/Microsoft Visual Studio 12.0/VC/bin/amd64/link.exe -L dependency=C:\Users\User\Documents\Rust Projects\some_binary\target\debug -L dependency=C:\Users\User\Documents\Rust Projects\some_binary\target\debug\deps (exit code: 101)

I also tried running cargo rustc --verbose -- -L C:/Program Files (x86)/Windows Kits/8.1/Lib/winv6.3/um/x64 which led to the same result. 😐

Have you found that the compiler doesn't automatically pick up these env vars and work correctly? Failing that, does executing inside of a visual studio command prompt work?

Hm this may be a bug in the compiler, then if it's not picking up the right SDK directories. If you want to open a bug against rust-lang/rust for that it'd be most welcome!

Okay, recent changes in the nightly have solved the problem! Thank you for your help!


Menu too long

When ui is zoomed in, cannot see bottom options, scrollbar or something is needed.

This is also a problem for tall screenshots.


Combobox / Select inside a Popover

Describe the bug (current behavior)
Hi! I have a popover for customizable line styles. I want a ComboBox for the selection of the line style (like dashed):

When I select an option, the popover close.
Expected Behavior
I would expect the option to be selected but the popover to stay open until I click outside of it.
Link to minimal repro
https://stackblitz.com/edit/github-6vfacf?file=src%2FApp.tsx
Steps To Reproduce

Click on the button to open the popover.
Select an item
Notice you wont have the value selected.

Package Version

[X] I'm using the latest version of iTwinUI.

Anything else?
No response

Thanks for reporting this! I think this might be a regression related to recent changes (#2209). We'll take a look and try to find a proper fix.

We're still looking into this. In the meantime, you can work around it in two ways:

By adding a <ThemeProvider> with portalContainer in your Popover. See stackblitz.
(Starting with 3.15.0) By changing the portal prop individually for Select or ComboBox.

I tested and it works with #1 for now, thanks!


Enable support for Kueue for GKETPUJob

Internal V5E testing capacity requires using Kueue. This PR allows you to specify which Kueue Queue to use. The GPUGKEJob already supported this so moving the shared config to GKEJob.

Do we need anything else to get this merged? Do we need another review from @ruomingp ?


POD ERR method "findByFullPath" does not exist

I get this error when trying to run an app generated with express-generator.
I don't undestand where the error could be ? Is is a NodeJS error or an internal pod error ?
Please help !!

any idea ? anyone ?

Yeah the latest pm2 has dropped findByFullPath in this commit
i hope pod can transition to a newer version of pm2


About linear encoders

I have a hobby project to build a linear motor powered 3d printer. I'm pretty comfortable with rust, but taking TTL output, driving linear motors, etc., is a bit new to me. would be keen to make a bit of project out of bringing in linear encoding and driving of linear motors, with a bit of help.

Hi @Ben-PH, welcome, sounds like a fun hobby project! :relaxed:
I'm not working on robokit at the moment, as I am focusing my attention elsewhere, but happy for you to contribute as you see fit. Let me know if you have any questions about why things are how they are.  (See a blog post about my use of generics in robokit.) Open to any Rust expertise that improves what I came up with.
What bits of help do you need? Happy to be a rubber duck for you here. :duck:
Do you have a specific linear motor and linear encoder in mind?

@Ben-PH Oh wow, making your own linear motor, that's incredible!

If this is an appropriate place to do this, I would appreciate your input:

I wish I could help more, but I'm not a mechanical engineer either, barely an electrical engineer, so this is beyond my knowledge.
All I can say is that, from the outside, your plan seems like a good place to start. I'm sure once you get going you'll learn and adapt.
Good luck! :pray:


Add preinstall script

I haven't tested this because uninstalling wget uninstalls google-chrome for some reason.

@gabru-md Could you test this.

preinstall.js ? is it missing ?

I've added the file. See 6ff41b. I don't know how it never got commited. I usually run git status all of the time, so I should have seen it.

@gabru-md I've made the changes that you have requested.

there were still some issues to be resolved.
I did it myself. changing the preinstall to postinstall and removing process.exit(0) at the end.
due to asynchronous nature of Node.JS, the exec command was not executed but the process ended faster. So had to remove it XD
Thanks for the contribution though.
Cheers!

@gabru-md The reason I set it to be preinstall was because I had assumed that if the installation of wget failed (e.g. no internet connection) the installation of LinuxSpells would still continue and break when it runs accio.
I may have had it wrong.


[Disruptive] Tree Warping & Magnet Boulders

Tree Warping out of a dungeon that has a Magnet Boulder will retain its position and paste it onto the overworld.

...and just to the left of that Magnet Boulder was a Minecart in the middle of the water, that could be jumped into and takes me nowhere!

I think the solution to this is just going to be not allowing tree warp from indoor locations, since you can always save warp to the entrance and then tree warp from there.
I might also look at what the code for being warped to outside a dungeon after getting the essence does, but if it's anything more than trivial then I'll probably opt for the former. I never intended tree warp to be a "feature" (although I expected it to be used that way anyway), just a mechanism to use if you're softlocked by location.

thinking about this based on #56, and maybe the solution is to eliminate the Tree Warp altogether, instead making S&Q start you at North Horon (like ALttP S&Q to Link's House) if done anywhere in the overworld or caves. this could theoretically be achieved by altering your respawn location the moment the title screen comes up, so that you can still death warp to your last entrance for speed purposes.

That's roughly how the first (and never released) implementation of tree warp worked, actually.  Speedrunners use S+C + soft reset anyway, so they don't lose anything if the behavior of S+Q is changed.
I probably could do that; it's just a bunch more code. Disallowing it indoors would just be another 5 bytes.

Tree warping limited to outdoor (overworld and Subrosia) areas in https://github.com/jangler/oos-randomizer/commit/0a1b42573a5da91339225f154e60c26247f08f24.

Just thought I'd point out that these are "static objects" (objects which remember their locations), and indeed the very last thing an essence does before warping you out is call the "clearStaticObjects" function. Shouldn't be difficult to implement that if you were so inclined.


Additional commands and fixed comments

I've made some changes that work here on my Linux box that I assume will work on other machines. They are primarily in response to my own needs which, it seems, are also some of the needs of the community (#78 and #86). There are probably better ways to deal with booting and quitting scsynth but it works for my purposes.
Sorry about all the random commits, I kept catching little things I missed; just got too excited that I can finally work with SC on Atom. Let me know your thoughts.

Thanks for this !  Very glad to see a contribution.
Those are perfectly correct ways of booting the server. Though I just left a note in the code. Should probably avoid making methods on the repl and just call eval from the controller.
Ideally they would be separate PR, but this project is too small to fuss about stuff like that.
The package.json file accidentally picked up some atom cache garbage. _atomModuleCache  which is 4k  That would need to be removed.
Thanks again ! Looking forward to merging this

Glad to be helpful; let me know if there are any other things I can do.
Just pushed another version that removed the server methods from repl and now just call eval from the controller.

Released. Thanks !


HDDS-7468. Recon: clusterState API Changes for adding missingContainerCount

What changes were proposed in this pull request?
Recon overview page shows the available containers/ total containers , however Recon frontend makes separate call to /missing API to get missing containers, so in order to avoid extra API call, this change is to add "missingContainers" field in /clusterState API itself to return the total number of missing containers which Recon frontend can use to display over UI. However this count has been capped or limited max by 1000 containers to avoid performance issue in retrieving the data from SQL DB. If number of missing containers returned is more than 1000, then UI will indicate this information to user with some tool tip mentioning that user can go to "Containers" page to get details of all missing containers where UI displays them in paginated form.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7468
How was this patch tested?
This patch was tested manually by using postman. Pls see screenshot below:

@dombizita @smengcl @smitajoshi12 , pls review and see the changes.

@devmadhuu checkstyle is failing
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestEndpoints.java
[426](https://github.com/apache/ozone/actions/runs/3446152813/jobs/5765403499#step:6:427)
 249: Line is longer than 80 characters (found 89).

@dombizita , Thanks for reviewing. Pls re-review. I have renamed the constant as you suggested.

Thanks for updating your patch. I just found getUnhealthyContainersSummary() inside ContainerHealthSchemaManager, which would give us the number of unhealthy containers in each state (it returns a list of UnhealthyContainersSummary, so we could use only the MISSING's count). Maybe we could use this instead of getUnhealthyContainers(), it doesn't have a limit parameter, but I think it is less performance to only retrieve the count for each state (correct me if I am wrong) and in this case we could display the exact value for missing container count. Let me know what you think of this. @devmadhuu  @smengcl

ContainerHealthSchemaManager

I don't think that getUnhealthyContainersSummary will be more performant, though it is fetching only containerState column from UNHEALTHY_CONTAINERS table, but the query is on relational DB only and it is going to scan full table to get count and then apply group by. In fact this may be more expensive compared to a limit query and getting for a specific state and if we add a index on containerState  column then it will be much faster. Attaching the screenshot of UNHEALTHY_CONTAINERS table for reference here. @dombizita @smengcl

ContainerHealthSchemaManager

I don't think that getUnhealthyContainersSummary will be more performant, though it is fetching only containerState column from UNHEALTHY_CONTAINERS table, but the query is on relational DB only and it is going to scan full table to get count and then apply group by. In fact this may be more expensive compared to a limit query and getting for a specific state and if we add a index on containerState column then it will be much faster. Attaching the screenshot of UNHEALTHY_CONTAINERS table for reference here. @dombizita @smengcl

You are right @devmadhuu, thanks for explaining it to me! I am fine with the changes, please take a look at it @smengcl

Thanks @devmadhuu for the patch, @dombizita for the review.


Update config to enable docfx v3 based on commit 507fdbac3db51f2683da…

…aee85f2cea8401a50831

Docs Build status updates of commit 741d987:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Ignore package-lock.json

When building Atom with newer version of npm,
it would generate package-lock.json at

apm/package-lock.json
script/package-lock.json

Maybe we can add package-lock.json to .gitignore to avoid accidentally add it to git index.

Package locks are meant to be committed.  However, they're still buggy (rebuilding on Linux and Windows with the package locks present usually result in an ansicolors issue) and we haven't fully decided how we're going to approach them.

@50Wliu, Just wondering why this (and the related issues #15155 and #15161) are closed. Seems since it's still an issue, they should still be open no?
Any possibility of changing script/build to nuke the offending package.lock files?


Don't work in python 3.6

This does not work in python 3.6, can it refresh?

The whole library is written in Python 2. We have no plans of updating to Python 3 in the short term, sorry.

I tried using it in python 2.7 but I also have many errors. Which version of python is compatible?

It should work with Python 2.7.
Have you followed INSTALL.md, DEPENDENCIES.md and FAQ.md?

Any updates? Have you managed to make it work?

Excuse me, I'm not going to use python 2. The other part of the project is all written in pyton 3.6 and has no way to go back to python 2


onPress callback called multiple times on GoogleSigninButton

This may be related to https://github.com/devfd/react-native-google-signin/issues/93
I was using the GoogleSigningButton for its looks, and using my own onPress function to sign in. I noticed that after logging in and out a few times, tapping the GoogleSigninButton resulted in multiple calls to my onPress method. There were 3+ account selection dialogs stacked atop one another.
When I replaced the GoogleSigninButton with a regular touchable opacity, the issue resolved.
Looking at the code, there is a call that looks like it should remove the listener when the button is unmounted: this._clickListener && this._clickListener.remove();, so maybe the RNGoogleSigninButtonClicked event is being emitted multiple times for some reason?
I'm using Android and 0.10.0

+1

+1 facing the same issue

@TiraO, others - were you able to find an elegant solution for this problem?
@raghudevan do you mean that you changed the library code?

Thanks for reporting @TiraO! I'm closing this as a duplicate. Discussion is happening in https://github.com/react-native-community/react-native-google-signin/issues/93.


I423 - Update openjp2 library to V2.3.0 - take two

Add updated openjp2 library
Modify SConscript to patch gdal to include V2.3.0
Add patch file

Opened in error - please see PR #580

Noureddine: Can you add the comment to the current PR?  For some reason, I
cannot see it when I go to github.com/google/earthenterprise.git.  Is it
not appearing because you commented in a close PR?
The OPENJPEG_VERSION variable is used, and only has meaning, inside of the
configure script.  Also, it is set but never used.
On Mon, Nov 6, 2017 at 5:21 AM, tst-nfarah<EMAIL_ADDRESS>wrote:

@tst-nfarah commented on this pull request.
In earth_enterprise/src/third_party/gdal/gdal-jp2-V2.3.0.patch
https://github.com/google/earthenterprise/pull/586#discussion_r149076393
:

+-  ac_fn_c_check_header_mongrel "$LINENO" "openjpeg-2.1/openjpeg.h" "ac_cv_header_openjpeg_2_1_openjpeg_h" "$ac_includes_default"
++  ac_fn_c_check_header_mongrel "$LINENO" "openjpeg-2.3/openjpeg.h" "ac_cv_header_openjpeg_2_1_openjpeg_h" "$ac_includes_default"

if test "x$ac_cv_header_openjpeg_2_1_openjpeg_h" = xyes; then :
cat >>confdefs.h <<_ACEOF
+-#define HAVE_OPENJPEG_2_1_OPENJPEG_H 1
++#define HAVE_OPENJPEG_2_3_OPENJPEG_H 1
_ACEOF

fi
+@@ -23743,11 +23743,11 @@
HAVE_OPENJPEG=yes
if test -r $with_openjpeg/include/openjpeg-2.0/openjpeg.h ; then

EXTRA_INCLUDES="-I$with_openjpeg/include $EXTRA_INCLUDES"

+-  elif test -r $with_openjpeg/include/openjpeg-2.1/openjpeg.h ; then
++  elif test -r $with_openjpeg/include/openjpeg-2.3/openjpeg.h ; then

OPENJPEG_VERSION=20100

I was referring to line 26 as its appear to have the version number: 20100.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/google/earthenterprise/pull/586#discussion_r149076393,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AaxYdF7Us2bSR1O_Zow0hT3RhIC2FjRYks5szwfUgaJpZM4QQqM6
.

If its not used, then may be no issue. In the original PR https://github.com/google/earthenterprise/pull/580 I did add comment that 'openjpegdataset.cpp' needs to be patched more. See my comment there.

What, specifically, needs to be patched?  I've taken a look at the diffs
for the two that you mentioned and they are quite extensive.  Is there a
pressing need for this?  Can we limit the scope to something small?
On Mon, Nov 6, 2017 at 2:52 PM, tst-nfarah<EMAIL_ADDRESS>wrote:

If its not used, then may be no issue. In the original PR
https://github.com/google/earthenterprise/pull/580 http://url I did add
comment that 'openjpegdataset.cpp' needs to be patched more. See my comment
there.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/google/earthenterprise/pull/586#issuecomment-342315317,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AaxYdEITtkaA7Fm_PSCDo_W40NrNXNRVks5sz423gaJpZM4QQqM6
.

@tst-nfarah I think I agree with @tst-eclamar here. Those changes do look pretty substantial. My original request was to not modify the gdal source archive. I think the additional changes could be made in a follow-up ticket. If we still get excellent performance without these changes, they may not be needed. However, if they are bug fixes, then that's something we can look into doing sooner.

@tst-ccamp @tst-eclamar
let's move this discussion to the open PR: https://github.com/google/earthenterprise/pull/580
As this PR is closed.
I'll add a comment there.


Readme and Code Fixes

Added decimal scalar to readme checklist
Fixed issues with the configuration type registration

Fixed exception messages of the float type


add an --export-to-file flag?

I love lolcat but it can sometimes be a hard sell convincing clients to install it into their production servers to render something like the MOTD dynamically instead of having a static file in /etc/motd.
I tried to pipe lolcat's output to a file/less/more/expect but I've been unsuccessful so far.
I would love to know if there is a tool already for this. Otherwise, it be great we could implement a flag like --export-to-file option where all the special color characters are used.

doh I feel dumb, just made this work with -f


ImportError: cannot import name 'iter_keys' from 'genno.core.key'

I have downloaded the toolbox; when importing it into my working environment, I experienced an error below (also as attached):
ImportError: cannot import name 'iter_keys' from 'genno.core.key' (/Users/meli0258/opt/anaconda3/envs/message_env/lib/python3.10/site-packages/genno/core/key.py)
Any idea if this is as expected?

Thank you - to update genno, would it be within the Messageix platform? Can we find instructions somewhere or?

Genno is a normal Python package installed in your virtual environment, which seems to be managed by Conda in your case. So please try running conda update genno within your venv.


Can compilerOptions->target be changed to ES5?

Currently ES6 is used by md2 for generating .js files for distribution.
According to this document: https://angular.io/docs/ts/latest/guide/typescript-configuration.html , Angular2 applications are suggested to use ES5 as the target.
I am using ES5 as the target of my Angular2 application. While testing the application, I got this error message:
PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR   SyntaxError: Unexpected token 'const'   at (path to my project directory)/karma-test-shim.js:62009 <- webpack:///~/md2/src/components/select/select.js:11:0
I guess that is because select.js is targeted to ES6.

well, I now use babel-loader to load those files and it works. So changing to ES5 may not be very important or urgent.

ok, we will update it soon...

We have updated ES5 you can use source code from dev branch or use npm install<EMAIL_ADDRESS>


Support json merge patch

Fixes #184
I added support for an extension called x-json-merge-patch. Schemas annotated with that extension wrap all their fields in a JsonNullable. The effect applies to all nested objects as well but not to $refed types. This is the usual behavior as described in RFC 7386 but also allows for custom behavior, should the need exist.
I'm not sure why or how one would combine this feature with discriminator-based polymorphism, so I didn't write any tests for it, but in theory, I added support for that as well.

Would this be better achieved using the content type instead of an extension?
      requestBody:
        required: true
        content:
          application/merge-patch+json:
            schema:
              $ref: "#/components/schemas/Resource"

@cjbooms In theory, yes, but in practice, I feel like you'd have to make too many assumptions. You'd have to run a discovery for all usages of the schema in controllers. But the real problem starts when you start using the same schema for both merge-patch+json and normal json. Then you'd have to generate multiple variants of the schema and all nested schemas as well.

@cjbooms In theory, yes, but in practice, I feel like you'd have to make too many assumptions. You'd have to run a discovery for all usages of the schema in controllers. But the real problem starts when you start using the same schema for both merge-patch+json and normal json. Then you'd have to generate multiple variants of the schema and all nested schemas as well.

I suppose in a future extension to this feature we could pre scan all schema objects referenced from that content-type and add the x-json-merge-patch key pre generation

I'm open to merging this feature, thanks for the contribution. Two things:

Should we add a new http-model-opts CLI parameter to allow users to opt-in?
If not doing 1. which is self documentating, please think of a way to document this feature in the README

I'm open to merging this feature, thanks for the contribution. Two things:
1. Should we add a new `http-model-opts` CLI parameter to allow users to opt-in?

2. If not doing `1.` which is self documentating, please think of a way to document this feature in the README

I don't think a CLI option is necessary here. This is not a breaking change and it already can be turned off conditionally by just not using the extension in OAS.
I added a bullet point to the README.md. I can see the potential for a more thorough feature documentation in general (I actually wanted to open an issue for this because I was struggling with the current polymorphism a lot). But, if that's a goal, it seems to be out of scope for this change.


How to set messages in the chat list

Unfortunately, I heard that the addMessages method was removed in version 1.4.6. In my project, a wake-up function was implemented, which requests the interface and renders a message "Hey, you haven't talked to me for a long time. Let me tell you a job" when no input is detected within 1 minute. Previously, I used the addMessages method to implement it. Now, after deleting this method, how should I add messages?

Hi @TasonIV.
The reason why addMessage method was removed is because the other properties were able to do everything that it did, such as initialMessages, hence there was no real purpose to overcomplicate the offered API and maintain another method.
Your use-case is very unique and something that usual chats don't exhibit. I can perhaps add an unofficial property called _addMessage that you can use, but I will not add it to the documentation for the aforementioned reasons. I will update this thread when the update has been done.

The _addMessage method is now available in the deep-chat-dev and deep-chat-react-dev packages version 9.0.105. These packages work exactly the same as the core packages it's just their names are different and I will be including this method in the next core package release.
The _addMessage method itself works just like the old addMethod, except the name has an underscore to indicate that this is not one of the official methods. Thanks!

Thank you for your prompt response and understanding. We look forward to the next update. Wishing you a happy life!

Hi, this has now been released in deep-chat and deep-chat-react package versions of 1.4.7.


Transaction canonical payload problems

As described in an issue https://github.com/onflow/cadence/issues/1652 the transaction RLP content produced by the Go SDK differs from the one produced by the JS. This originates from the JSON encoding of the Cadence arguments, where the Go std lib encoder adds an additional newline at the end of encoded content as seen here: https://cs.opensource.google/go/go/+/refs/tags/go1.18.2:src/encoding/json/stream.go;l=217
This encoded content is then used to produce the canonical payload form which differs from the one created by the JS.
As a workaround, until canonical JSON encoding is defined in Cadence we could handle this last newline character in Go SDK and make sure to strip it.

Connect with our  team representatives to help resolve your issue and troubleshooting .
Connect here: direct.lc.chat/14158209/
Hours of Operation
24/7 (Ready to fix issues)

One more:
https://github.com/onflow/cadence/issues/1652#issuecomment-1140285121

@lmcmz I see. Thank you for reporting. This encoding issues will be solved in this week.


Wrong search results and displays with key 'booktitle'

The following entry results in faulty search results and display.
@incollection{eilan_consciousness_2007,
  author = {Eilan, Naomi},
  booktitle = {Reading Merleau-Ponty: On Phenomenology of Perception},
  editor = {Baldwin, Thomas},
  publisher = {Routledge},
  title = {Consciousness, Self-Consciousness and Communication},
  year = {2007},
}

The entry shows up in telescope-bibtex as 'Eilan, Naomi (2007), Reading Merleau-Ponty: On Phenomenology of Perception'. Likewise, if I search for any of the words in the title, I don't find the entry. If I search for terms in the booktitle, the entry shows up. It seems that maybe when reading the .bib, the booktitle key is matched first, rather than the title which is further down in the entry. I have search_keys = {'author', 'year', 'title'} in my config.

Thanks for pointing this out. From a quick look at my code I think your guess at what causes this issue is correct. The fix should be relatively easy.


Standardise actions filenames and go version

Description
This changes the name of "ci-only" action to build as per comments in
https://github.com/openfaas/faas/issues/1585. Also pins go version
based on the same
Signed-off-by: Alistair Hey<EMAIL_ADDRESS>How Has This Been Tested?

see action on this PR
Checklist:
I have:

[ ] checked my changes follow the style of the existing code / OpenFaaS repos
[ ] updated the documentation and/or roadmap in README.md
[x] read the CONTRIBUTION guide
[x] signed-off my commits with git commit -s
[ ] added unit tests

yeh, your right. no go version needed, built in docker


[attn][tiny fix] fix attn backend in MultiHeadAttention

The original logic will never step into xformer backend branch, because attn_backend is the class object of a certain attention backend.
This pr fix that.

CI failed due to network request timeout


builder.isBuilder() user-defined type guard doesn't work in TS strict mode

It seems that the user-defined type guard mechanism on builder.isBuilder() doesn't work when Typescript is in strict mode. The type mechanism still considers the passed parameter as all possible types.
Example:
An action "create" on Payment ent, with input:
export interface PaymentCreateInput {
  amount: number;
  accountID: ID | Builder<Account, Viewer>;
}

which creates the following method in PaymentBuilder:
isBuilder<T extends Ent>(
  node: ID | T | Builder<T, any>,
): node is Builder<T, any> {
  return (node as Builder<T, any>).placeholderID !== undefined;
}

Note that for accountID, if the call to isBuilder() returns false, it must be of type ID (even though node could also be an ent).
When used in a trigger:
async changeset(builder, input) {
  const { accountID } = input;

  if (builder.isBuilder(accountID)) {
    return;
  }

  const account = await Account.loadX(builder.viewer, accountID);
  ....
}

It gives a typescript error:
Argument of type 'ID | Builder<Account, Viewer<Ent<any> | null, ID | null>, MaybeNull<Account>>' is not assignable to parameter of type 'ID'.
  Type 'Builder<Account, Viewer<Ent<any> | null, ID | null>, MaybeNull<Account>>' is not assignable to type 'ID'.ts(2345)

When strict mode is disabled, Typescript does consider accountID to be of type ID.
Alternative question: is there a better way to handle builders for a field edge in triggers? My logic assumes that the account is already created, but what if this happens in the same operation?

hmm. I thought i had used @ts-ignore here but it seems to work in cases I'm checking (in private repo).

Alternative question: is there a better way to handle builders for a field edge in triggers? My logic assumes that the account is already created, but what if this happens in the same operation?

can you expand more on this?
you can disable the builder type if you don't want it with disableBuilderType: true on the fieldEdge. it doesn't always make sense in all flows e.g. when creating dependent objects.
you can do await builder.getEntID()  to get the ent id if you want to use it for something else. doesn't work for autoincremented ids though.


Does React.memo work Server Side ?

Hi, I was reading the docs and is not clear to me wherever React.memo works when the components render server side.

@GregBorrelly Perhaps you could add a question label to the issue to draw more attention to it.


Fixed Button become inactive after first click on for animator "Get Result" #171

🛠 Fixes Issue
Fixed Button become inactive after first click on for animator "Get Result" #171

👨💻 Changes proposed
I made changes to the animator.ts file

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
event listener was added each time the getResult btn was initiated which led to the popup duplication
getCodeButtonElement.addEventListener

📷 Screenshots

Your build failed and you didn't fill the pull request properly.
Your pull request is rejected, reason 👉🏾is here👈🏾
Thanks for contributing, I hope you continue to do.


Compatibility Issue with whereAll and whereAny Methods in Laravel 10.47.0

The recent update to Laravel (version 10.47.0) introduced a new feature (#76) which has caused compatibility issues with the whereAll and whereAny methods in this package.
As a result of this update, attempting to use these methods in the application results in the following error being thrown:
Declaration of Tpetry\\PostgresqlEnhanced\\Query\\BuilderWhere::orWhereAll($column, ?string $operator, ?iterable $values): static must be compatible with Illuminate\\Database\\Query\\Builder::orWhereAll($columns, $operator = null, $value = null)

To temporarily address this issue, I have manually disabled the affected feature within the package, thus resolving the error.
I hope this issue will be fixed ASAP to ensure seamless compatibility with the latest version of Laravel. Thank you.

This has already been reported in #76 and is fixed with the newest release.


Table support

It would be great to have a table button for inserting tables, rows, and columns.

Hi!
It will never be in the Trumbowyg core. But anybody can code it as a plugin for Trumbowyg like colors plugin :)

Hopefully this https://github.com/Alex-D/Trumbowyg/pull/246 will help

There should now be the ability to add rows & columns individually.

Released in v2.2.0
Thanks for your contribution!


Not able to connect to LocalStack Sqs URL

Hi Folks,
I have been struggling to figure out why Im not able to connect to LocalStack sqs URL. I have setup LocalStack to run the queue in my local. I was able to send and receive the message using cli commands and also I was able to publish the message to this queue from my other non nestjs application but the ssut/nestjs-sqs throws the below error and I'm not sure why.
api/node_modules/sqs-consumer/dist/errors.js:40
    const sqsError = new SQSError(message);
                     ^
SQSError: SQS receive message failed: The address https://sqs.us-east-1.amazonaws.com/ is not valid for this endpoint.
    at toSQSError (/api/node_modules/sqs-consumer/dist/errors.js:40:22)
    at Consumer.receiveMessage (/api/node_modules/sqs-consumer/dist/consumer.js:173:43)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Im facing the same issue the only solution i found was to instantiate my own SQS Client
const sqsClient = new SQSClient({
     region,
     endpoint: 'LOCALSTACK_URL'
}) ;

Im facing the same issue the only solution i found was to instantiate my own SQS Client
const sqsClient = new SQSClient({
     region,
     endpoint: 'LOCALSTACK_URL'
}) ;

@agnarok Could you please let me know where exactly you instantiate the client and consume it? I have own service file and I'm consuming the message like below
@Injectable() export class QueueHandler {   constructor(private pService: PService) {}   @SqsMessageHandler(queueName, false)   async handleMessage(message: SQS.Message) {     const logger = new Logger(this.handleMessage.name);     try { //Business logic     } catch (error) {       logger.error(error.message, error.stack);       throw error;     }   }

SQSClient is an option for the consumer so your module should be something like this :arrow_down:
import { Module } from '@nestjs/common';
import { ConfigService } from '@nestjs/config';
import { SqsModule } from '@ssut/nestjs-sqs';

@Module({
  imports: [
    ProposalsModule,
    SqsModule.registerAsync({
      useFactory: (configService: ConfigService) => {
        return {
          consumers: [
            {
              name: configService.getOrThrow('AWS_SQS_QUEUE_NAME'),
              queueUrl: 'http://localhost:4566/000000000000/queueName',
              sqs = new SQSClient({
                  region: 'REGION',
                  endpoint: 'LOCALSTACK_URL'
               }) ;
             },
          ],
          producers: [],
        };
      },
      inject: [ConfigService],
    }),
  ],
  providers: [QueueHandler],
})

@agnarok I'm really confused now. SQSClient  is not part of this library so, not sure how do I instantiate it. Also is queueUrl  and endpoint are same?

@VivekPNs SqSClient is used internally in the lib, so you would need to import in your project to use it like i suggested.
Also, no endpoint and the queueUrl are not the same. The endpoint is used in the AWS SDK for pooling data

@agnarok But SqSClient is not part of the @ssut/nestjs-sqs library. Could you provide some snippets to understand better?

Finally, it works for me
this is a full code for ConsumerModule
don't forget to import ConsumerModule in the app module
`import { ConfigModule, ConfigService } from '@nestjs/config';
import { Module } from '@nestjs/common';
import { SqsModule } from '@ssut/nestjs-sqs';
import { ConsumerService } from './consumer.service';
import { SQSClient } from '@aws-sdk/client-sqs';
@Module({
imports: [
ConfigModule,
SqsModule.registerAsync({
imports: [ConfigModule], // Import the ConfigModule to use the ConfigService
useFactory: async (configService: ConfigService) => {
const accessKeyId = configService.get('sqs.accessKeyId');
const secretAccessKey = configService.get(
'sqs.secretAccessKey',
);
    // Retrieve the required configuration values using ConfigService
    return {
      consumers: [
        {
          name: configService.get<string>('sqs.queue_name'), // name of the queue
          queueUrl: configService.get<string>('sqs.url'), // url of the queue
          region: configService.get<string>('sqs.region'), // using the same region for the producer
          batchSize: 10, // number of messages to receive at once
          terminateGracefully: true, // gracefully shutdown when SIGINT/SIGTERM is received
          sqs:new SQSClient({
            region:configService.get<string>('sqs.region'),
            credentials: {
              accessKeyId: accessKeyId,
              secretAccessKey:secretAccessKey
            }
         })
        },
      ],
      producers: [],
    };
  },
  inject: [ConfigService],
}),

],
controllers: [],
providers: [ConsumerService],
exports: [ConsumerService],
})
export class ConsumerModule {}
`

@VivekPNs

Yup, I did the same way and it works. Thank you.

I apologize for cracking open an old issue, but I'm unable to find any more information on what I've found here.
This issue and one other article both have this attribute in the consumer options:
terminateGracefully: true, // gracefully shutdown when SIGINT/SIGTERM is received
Where did this come from and what did it do? I simply want to ensure that my NestJS app completes processing the message it's currently handling before terminating on a SIGINT or SIGTERM from ECS, might this help?
Cheers and thanks in advance!

Dropping a note here mostly b/c I know I'm going to be troubleshooting this same issue in ~5 years and will have forgotten WTF I did to fix it.
I had this same issue where the Nest.js app using this library couldn't communicate w/ the SQS queue I created in Localstack. The specific error I was getting was
/opt/transaction-monitoring/node_modules/.pnpm/sqs-consumer@11.1.0_@aws-sdk+client-sqs@3.664.0/node_modules/sqs-consumer/dist/cjs/errors.js:60
const sqsError = new SQSError(message);
                 ^

My setup was different though. I was using docker compose to spin up 2 services a localstack service and a transaction-monitoring-svc. The Nest.js/SQS consumer lived in the transaction-monitoring-svc container and the SQS Queue obviously lived in the localstack container.
So when registering the SqsModule I had to use http://localstack:4566 instead of http://localhost:4566 as the endpoint url, which is a subtle difference, but very necessary so that docker can resolve the IP address for the localstack container.
Here's a snippet showing how I registered the SqsClient
import { Module } from '@nestjs/common';
import { ConfigModule, ConfigService } from '@nestjs/config';
import { SQSClient } from '@aws-sdk/client-sqs';
import { SqsModule } from '@ssut/nestjs-sqs';

@Module({
  imports: [
    ConfigModule.forRoot({
      isGlobal: true,
      load: [configuration],
    }),
    HttpModule,
    SqsModule.registerAsync({
      imports: [ConfigModule],
      useFactory: (cfg: ConfigService) => {
        return {
          consumers: [{
            name:'transactions',
            queueUrl: cfg.get('transactionMonitoringQueueUrl'),
            sqs: cfg.get('env') === 'development' ? new SQSClient({
              region: 'us-east-1',
              endpoint: 'http://localstack:4566' // This was the http://localhost:4566 which would have worked if I was running the app from my laptop instead of within a docker contianer.
            }) : new SQSClient()
          }]
        }
      },
      inject: [ConfigService]
    })
  ]
})
export class AppModule {};


Stratigraphy Cleanup - Formation Level

Spreadsheet Emailed Includes

The Parent Group for each Formation that has one - not all Formations belong to a Group, but for those that do, can we ensure if user picks "Sooke Formation", it is linked to "Carmanah Group" - but they could pick Carmanah Group without drilling lower
Column "New Geological Formation" lists changes to a name or if the name is a Member instead, the correct Formation name
Column D lists where a Formation should be elevated to a Group name instead
Column E lists where a Formation should be revised to a Member name instead
Column F shows which names to move into a new list of "Informal Name or Map Unit"
Column G shows which terms to delete

Cleanup Rules

[x] Where “or” joins two or more terms, display all
[ ] Where “-“ connects two terms, separate and display both (E.g., Beattie Peaks-Monach should be Beattie Peaks Formation and Monach Formation). The exceptions are the formation names Toad-Grayling, Extension-Protection, Muncho-McConnell, and Ludington-Pardonet transitional facies which are acceptable hyphenated formation names.
[ ] Where “/“ connects two terms, separate and display both (E.g., Bocock/Pardonet should be Bocock Formation and Pardonet Formation)
[ ] For terms that include the word equivalent, leave the word equivalent in the term (E.g., display as Beaverhill Lake Formation equivalent)
[ ] Delete term (Troy Ridge) behind “Salmon River”
[ ] Delete “or Ked” behind Extension Protection
[ ] Delete “(cap)” behind “Gates”
[ ] Delete “Manning Park”
[ ] Change “with overlying Gates” to “Moosebar; Gates”
[ ] Change “with overlying Gates; capped by Quaternary” to “Moosebar; Gates”
[ ] Separate terms “Longarm Yakoun Maude Kunga” – “Longarm” is a Formation and “Yakoun Maude Kunga” are Groups
[ ] Espee Formation belongs to Ingenika Group

I'd suggest that most of the oddballs should be handled after MVP.


Stacked Column chart with a base other than zero

I have an application that I need its chart to be like this link from AccuWeather:
AccuWeather
I tried alot to designate a base for the chart using:
<RadzenValueAxis Min="@(weathers.Min(w => w.LowTemp))">
But the chart does not appear correctly. Is there a way in Radzen Blazor to do this?

This seems as a question that is better fitted for our forum.


install puppetlabs-stdlib 4.12.0 by puppet in openeuler

Description of PR
puppet module install puppetlabs-stdlib --version 4.12.0 in openeuler
How was this patch tested?
create the openeuler puppet docker image cmd:
sh build.sh trunk-openeuler-22.03
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id ()
[ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/

The modify code use this PR:
BIGTOP-3883: add smoke test for openeuler
commit: https://github.com/apache/bigtop/pull/1131/commits/d006a324e422cef6217354fd0e99956a73f60ede


Remove size restriction for mouse cursor

Fix #17992
I put a limit of 256x256 because on my linux machine any size bigger than this starts to flicker.
I think 256px is it enough for a cursor, right?
Tested on Win10 and Linux, dunno what will happen in other windows versions.
Mac is probably working, I'm without a virtual machine to test right now.

Now that Godot 3.1 has been released, we don't plan to cherry-pick new features and enhancements to the 3.0 branch, unless there is very strong support in favor of it. Removing cherrypick label for 3.0.


fix(select): pass prompt argument down to input component

@prompt never worked before..

:tada: This PR is included in version 5.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Log BDX messages

Problem
Fixes: https://github.com/project-chip/connectedhomeip/issues/11074
BDX messages are not logged
Change overview
Added logging of all supported BDX messages and the message parameters
Testing
Manually tested by initiating an OTA QueryImage command and see that BDX messages are logged to terminal

@carol-apple - could you explain what feature this is for and how?
I am trying to understand the referenced issue - it seems to ask for parsing output logs for testing  purposes. Are these logs expected in production apps or only in  test apps. Are there other ways beside 'parse logs'? I have concerns about asking 3rd party developers to expose their logs for validation purposes - small devices may maybe even remove some logs to save flash.

I believe test harness (or test application) should be allowed to somehow monitor/report on  BDX progress and steps, however I do not believe an approach of adding virtual log functions inside the BDX protocol itself is the path to achieve testability.
Could you add some sort of delegate for monitoring purposes in the BDX instad? Have the test app log, but do not force this logging code onto apps using BDX.

@carol-apple - could you explain what feature this is for and how?
I am trying to understand the referenced issue - it seems to ask for parsing output logs for testing purposes. Are these logs expected in production apps or only in test apps. Are there other ways beside 'parse logs'? I have concerns about asking 3rd party developers to expose their logs for validation purposes - small devices may maybe even remove some logs to save flash.

For posterity's sake, we've spoken offline and this change is temporary until TH can process the BDX message. https://github.com/project-chip/connectedhomeip/issues/11553 will be used to track the changes needed to revert this PR.


visitable_type is not insert corretly in Laravel >= 8.50

In laravel 8.50 DB::statement removes backslash automatically. So the visitable class name is not insert correctly.
App\Models\Article  =>  AppModelsArticle (Backslash were removed)

@mmrtonmoybd please check #14 and #19


Bring back toggle options to Mods tab.

Hi.
Any chance on updating this mod? I love your work. I use it all the time. I bumped it to BS v1.31.1 in the link below if it saves you any time. Its been working for me for a couple of months without any problems but I'm a novice programmer so it may not be done to your standards. Also, I guess the new BSIPA is coming out so v1.31.1 may be outdated soon. Thank you!
https://github.com/procedure1/Intro-Skip


testnet network support - g5mr939h8h9t0ry - validator,rpc,api

@k0kk0k , Your Moniker and validator addresses are required, please update the PR with those details

@k0kk0k , Your Moniker and validator addresses are required, please update the PR with those details

@k0kk0k , Your Moniker and validator addresses are required, please update the PR with those details

moniker: ushakov
valoper: akashvaloper1zhgh2tkgwe4r84ehe0ghsr0vah34w2znth6ezt

@k0kk0k , Your Moniker and validator addresses are required, please update the PR with those details

moniker: ushakov
valoper: akashvaloper1zhgh2tkgwe4r84ehe0ghsr0vah34w2znth6ezt


[Feature Request] Set table sort order run time

Existing Component
Yes
Component Name
el-table
Description
Imagine a use case of e - table component usage with server side pagination and sorting. I use vuex store to remember table layout before leaving the route with an intention to see the same layout next time I visit the view.I wonder how can I set the column sorting order programatically so visually I can see the active column with its sort order on.

Use default-sort: https://jsfiddle.net/leopoldthecuber/sqq8mdkd/

Thanks a lot!


add suffix_array

Coverage remained the same at 86.604% when pulling 5abf637ce2bfdc1ac87d3a613c27ac0bd99ca91c on suffix_array into 99ec7656188ce2d41a612dc2c5af08dc240c896c on master.


Datastructures and laser-rendered objects such as slot-tab.

There has been some discussion of non-svg objects in Meerk40t previously: see #24 for a multi-pass raster object, and #218 for gradients for bevelled edges. There are other laser specific object types like living-hinges that could be useful for design objects. The slot-tab edges for laser projects are based, in part, on material thickness. Which means the edge needs to re-generated for different thicknesses of material. If this information was stored and processed we could define a edge as a slot-tab edge and re-render that edge based on a material thickness entered.
Currently all the main objects within the tree are svg style objects. These are svg-shapes and svg-image objects with slight increases in metadata.  There are some cutcode objects that get added processed there which also contain laser settings. Some lasercode objects which provide even broader data structures, and blob data which is pre-compiled data for a particular laser type.
Implementing renderable data that would be converted to a specific type of path or provide particular laser-ready functions would require that our loading and saving format provide this additional information. In accordance with the need to implement fullsave these topics certainly call for discussion. Should we perform these sorts of laser rendered objects. These rendering objects exist in the realm of embroidery and a long term goal is to spin off some of the functionality here and make an embroidery application, so the difficulty here aligns really closely with other goals, such as defining an object as having an embroidered fill or defining an object as a satin-stitched shape or a particular fill motif. While different, there is notable overlap with the required concepts.
So, what sorts of planning steps should be made to make this possible? Should this be adapted into more-or-less SVG as current meerk40t files are processed currently and expected to be processed within Project: FullSave. Should this be deemed outside the realm of features and ignored. Does this require too much design and creation infrastructure (which is currently in the long term plans)?

The problem with those elements is that some of them do not actually fit well within SVG as a spec.
I think #598 offers some reasonable reasons for the shortsided problems here with svgelements being used natively in that space. While it works really nicely to load things and it saved a lot of development time it's a bit of an albatross around our necks in places. While this stuff can have some overlap with other code elements, I'm thinking FullSave might want to consider saving to its own format and merely export to SVG. Not that things don't work as they currently are, but there's no real restriction on what sorts of objects our nodes tree nodes can have and some stuff just needs to keep a lot more information than it currently does and that information is absolutely not a part of the SVG spec, and trying to shoehorn it in there may be in error.
Cutcode currently includes a few different elements that don't match spec either like Raw which merely consists of raw pixel movement values. Not lines or anything but a list of points to go and whether that point needs a laser strike or not. It might be better to just write element types that properly correspond to our needs rather than trying to make SVG serve as that purpose.
Fullsave would currently require things like laser-data-blobs and special-commands, and loading and saving of cutcode, and currently has operations save and load. These might be more easily done with more native saving and loading of objects, in ways that better reflect the modern direction of the program, but also directions that help with #577 etc. Since there's a future goal of some kinds of embroidery in a sister application and things like closed objects with fills and properties and satin stitches might also be better stored as their own data-classes too.
These wouldn't need to replace element nodes either, you could still have more simplistic versions of those nodes. But, it might be better to also have more robust objects if we could do that in a reasonable and consistent manner. So if you wanted a tab-slot pathsegment you would need to use a CutVector (or whatever the name ends up being) instead of a path. And just easily convert between the two. Since the types of data don't matter as much when there are plenty of simplified methods to make these bits easier.
It's built to be super-hackable and this is a way we could sort of hacking it ourselves. We do not need svgelements in cases where we're left to hack the data to try to shoehorn it into something we care about.

Too old to revisit


Add a comment to explain why we don't process code coverage on test fail

In #6894, code coverage processing was disabled because it produces spurious output. This PR just adds a comment to the current source that links back to that one for future reference.

@swift-ci please test

@swift-ci please test Windows

@swift-ci test windows


[BottomNavigation] Feature Wishlist

Per this PR comment, this can be a "meta-issue" for the features we'd like to eventually implement for the BottomNavigation component.

[ ] Support custom highlight color per selected item
[ ] Support badged icons
[ ] Support showing label only for selected item
[ ] Add constraints for number of children provided
[ ] Enforce appropriate label length and avoid overflows/breaks
[ ] Support custom background color on bar depending on selected item
[ ] Support expanding width of selected item
[ ] Add scrolling behaviors (hiding)
[ ] Determine how to handle larger displays (menu on left)

Determine how to handle larger displays (menu on left)

Out of scope for BottomNavigation, this is more like a narrow Drawer.

Support custom background color on bar depending on selected item

I think that this could easily be implemented in userland, but add a lot of overhead to the component API.

Add scrolling behaviors (hiding)

What do you mean by this? Can you elaborate?

Add scrolling behaviors (hiding)

What do you mean by this? Can you elaborate?

These were extracted from a TODO by @owencm. But I think he meant: From the spec:

The bottom navigation bar can appear and disappear dynamically upon scrolling:

Scrolling downward hides the bottom navigation bar
Scrolling upward reveals it

That's right. It's not priority work, but determining dynamic hiding
behaviours relating to scroll is one future task.
On Fri, Aug 5, 2016 at 6:11 PM Jackson Ray Hamilton <
<EMAIL_ADDRESS>wrote:

Add scrolling behaviors (hiding)
What do you mean by this? Can you elaborate?
These were extracted from a TODO by @owencm https://github.com/owencm.
But I think he meant: From the spec:
https://material.google.com/components/bottom-navigation.html#bottom-navigation-behavior
The bottom navigation bar can appear and disappear dynamically upon
scrolling:

Scrolling downward hides the bottom navigation bar
Scrolling upward reveals it

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/callemall/material-ui/issues/4912#issuecomment-237997513,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAREqKBKRZrv8rduBFag3G1pS0ncJroWks5qc98zgaJpZM4JeHQW
.

Ah yeah, that's a cool feature.
It also looks like there is some layout management needed with snackbars too.

What do you think library vs user should be responsible for with the dynamic hiding in conjunction with managing snackbars?
One of the difficulties from a library standpoint is that it can be risky to make assumptions about how the user has structured the frame of their application.
Portals can remove some of that risk, so managing the layout might be best in one of those.

I personally would argue for material UI to introduce some kind of
"framing" system (maybe this is what Portals is? I haven't heard of that).
The framing system could then take care of positioning for header bars,
snackbars and bottom navigation elements. It could also handle the issues
that arise when auto-hiding those elements on-scroll etc.
In the short run I presume the pragmatic option is to leave it up to
developers, which is IMHO effectively equivalent to saying snackbars will
overlap bottom navigation (sad panda) if that's the default.
On Fri, Aug 5, 2016 at 6:50 PM Nathan<EMAIL_ADDRESS>wrote:

What do you think library vs user should be responsible for with the
dynamic hiding in conjunction with managing snackbars?
One of the difficulties from a library standpoint is that it can be risky
to make assumptions about how the user has structured the frame of their
application.
Portals can remove some of that risk, so managing the layout might be best
in one of those.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/callemall/material-ui/issues/4912#issuecomment-237999584,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAREqNhr6KNu5FNj3ByEJ4zI5QVqoC5Pks5qc-hagaJpZM4JeHQW
.

Yeah I think it's definitely worth consideration. Especially once you consider toasts in the mix too. Right now it is difficult to implement certain material design application layout patterns. I wish it were easier with this library. Perhaps something to consider for next though.
The portal pattern is basically creating a div at the bottom of the body tag, so you have a bit more control of the component relative to the document body compared to just inserting a div somewhere in the middle of the application dom structure. This pattern is used as a base to implement things like modals, menus, etc... but it isn't necessarily restricted to elements that use the entire window.

This issue has no acivity in two years. It's probably not something people need us to work on. I'm closing.


k8s-service-trailing-slash-fix

Fixes #
The issue came up while fixing this: knative/pkg#2178, the tests are failing there because here the test cases expect a deadletter sink of k8s service with trailing slash.

Proposed Changes

Removing the trailing slash.
Replacing the strings with the const already there in objects_common.go

Please note that the tests will fail, blocked by the above mentioned PR merge.

/ok-to-test

@Shashankft9 can you please upgrade pkg to the latest so that tests can pass?

/retest

@Shashankft9  looks like there is some issue w/ the PR: https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/1115/pull-knative-sandbox-eventing-kafka-broker-build-tests/1422251468039131136
/home/prow/go/src/knative.dev/eventing-kafka-broker is out of date. Please run hack/update-codegen.sh
JUnit file /logs/artifacts/junit_D57NXlAJ.xml is created for reporting the test result

closing in favor of https://github.com/knative-sandbox/eventing-kafka-broker/pull/1123


Can't create dynamic pie chart

Hi
I'm trying to feed my pie chart with dynamic controller with no success.
This is my code:

$scope.vm.pieColumns = [
{"id": "S", "type": "pie", "name": "Small" },
{"id": "M", "type": "pie", "name": "Medium"},
{"id": "L", "type": "pie", "name": "Large"},
{"id": "XL", "type": "pie", "name": "Xtra Large" }
];
$scope.report = { "S": 45, "M": 34, "L": 54, "XL": 11 };
do you know what can be the problem?
thanks
Erez

There is an example online that does just this, can you verify if that helps you with your problem?
http://jettro.github.io/c3-angular-directive/examples/index.html#/callback

Going to close this issue in a few weeks without additional input

thanks a lot!


Find references from a given selected file (in explorer)

Today LSP specification support textDocument/references which works with symbol. It would be nice if LSP specification could provide a new LSP feature like file/references to find references from a file selected in the explorer.
Takes a sample with the HTML language server.
Given this HTML file:
<html>
	<link href="foo.css" />
</html>

It would be nice to open the contextual menu from the foo.css and have a Find File References menu

to retrieve the index.html as find file references.
//cc @aeschli

I think there are a lot of language which could use this new file/references feature like:

Java
XML
Template engine which uses include/import mechanism (XSL, Quarkus Qute template engine, etc)
other languages which supports textDocument/documentLink

//cc @fbricon @rgrunber @datho7561

I like that idea. I will move it to the spec repository .


Text hiding with a custom header

Trying to add a custom header. But, on clicking any title in left panel, top of the text on right panel is hidden. Any idea how to avoid this?
https://jsfiddle.net/majoshi1/ejbcpxtw/15/show
For example, on clicking API SERVER on left panel:
Expected:

Actual:

RapiDoc's link is behaving as expected. but the reason you are getting this is because the custom header you created is overlapping and covering the top section  of rapidoc.
you should find a way that it do not overlap or cover the rapidoc element, either using a styling which do not break html elements positional flow which happens when you uses css position = absolute, fixed, sticky or try provide a top margin to rapidoc to avoid overlap

Tried using rapidoc header and it seems to work. Although, it is possible to hide logo and also use all the space in header?
Rapidoc Header


Go back once to JWKS resource if kid is unknown

From https://openid.net/specs/openid-connect-core-1_0.html#RotateSigKeys:

The signer can begin using a new key at its discretion and signals the change to the verifier using the kid value. The verifier knows to go back to the jwks_uri location to re-retrieve the keys when it sees an unfamiliar kid value.

IdPs may add a public key to JWKS and use the corresponding private key right away to sign JWT.
Couper will currently not recognize this change (until it syncs JWKS) and throw an error, because it can't find a key for the new kid in its cached JWKS.
So instead of throwing an error, Couper should first sync JWKS, then try again to find the key.
This may also apply to the jwt access control.

This is a source of DoS. An attacker could send random kid values forcing upstream JWKS refresh attempts with every token.

In the jwt access control, yes.

The lookup of unknown keys would allow to cache a JWKS response forever (which ends with the next restart). We could change the default TTL for JWKS to forever (or a much longer value than one hour) or even remove the possibility to define the TTL completely.
But in case an unknown KID is received in a token, the refresh must be synchronous and we have to hold the request until ready.
A short TTL would allow to retrieve new keys in the background without interrupting traffic - but obviously it depends on the implementation of the signer if keys are ever published well before use.

https://support.okta.com/help/s/article/Access-Token-validation-failure-due-to-kid-mismatch?language=en_US:

Clients that cache keys should periodically check the JWKS for updated signing keys. Okta recommends a blended approach of regularly caching keys for performance and just-in-time checking by retrieving keys dynamically from the keys endpoint if the key read from the cache fails signature validation.


Clarification on quality filtering/trimming

Can you please clarify here and in the documentation or help files at what stage the quality filtering/trimming is done? Is it before or after the adapter trimming?
From the help file:
 Filtering & Post-trimming & Redistribution:
          -q, --end-quality  <int> Trim 3' end until specified or higher quality reached; (0)
          -Q, --mean-quality <int> The lowest mean quality value allowed before trimming; (0)

From the output:
8000000 read pairs processed; of these:
     23 ( 0.00%) read pairs filtered out by quality control
   4199 ( 0.05%) short read pairs filtered out after trimming by size control
    175 ( 0.00%) empty read pairs filtered out after trimming by size control
7995603 (99.95%) read pairs available; of these:
4834307 (60.46%) trimmed read pairs available after processing
3161296 (39.54%) untrimmed read pairs available after processing

Thanks!

The mean quality filtering is before adapter trimming while the end quality trimming if after adapter trimming. Thank you for your advice! I'll add this clarification to the skewer manual.

Sorry to hit up an old post, but it could help to have some clarification on the documentation:
 Filtering & Post-trimming & Redistribution:
          -q, --end-quality  <int> Trim 3' end until specified or higher quality reached; (0)
          -Q, --mean-quality <int> The lowest mean quality value allowed before trimming; (0)

For "The lowest mean quality value allowed before trimming", do you mean "...allowed before filtering"? It's not clear, at least to me, how --end-quality is different from --mean-quality, base on how the documentation is worded. It seems like --mean-quality means: "if the mean quality of the read is < the cutoff, then filter the read", but the wording appears to be otherwise ("trimming"). Is there a way to filter a read (no trim) based on average read quality?


p2p network txn handling, new constants, socket options

Relates to #291, cleans up txn handling, define constants for new magic numbers, add setting the NODELAY socket option.

I've named several magic numbers in net_plugin.cpp. This adds 9 potentially configurable values to the four existing. I think it would be a good idea to add either section names or prefixes to config options to avoid potential namespace collisions. For instance, change listen-endpoint, public-endpoint, and remote-endpoint to be p2p-listen-endpoint, etc. then the new values when added could be p2p-.
In fact, we don't need to do that to all config.ini options, http-server-endpoint is clear, as is plugin and producer-name.

closing, solution was merged in pr #403.