Repeating panel queries don't handle the "All" selection correctly

Describe the bug
When using a multi-valued dashboard variable and a repeating panel, the wrong value for the variable is substituted in each instance of the panel when the "All" value is selected. Or, more precisely, no value is substituted and the condition using the repeating variable is just dropped.
I suspect this isn't a bug with this particular datasource, maybe instead a bug with the sqlds library or somewhere else in the stack. I unfortunately don't know enough about Grafana to really track it down to the right place.
Versions
Grafana v8.4.1
Plugin built from revision fd5cdcf5c054fe8eef40915dae1145cfdbc7a0a7 aka. current latest.
Query
Dashboard showing this issue: https://mon.dolphin-emu.org/d/rvvg02qGk/analytics-quirks-report
Base query set for the repeating panel:
SELECT
  gameid AS `Game ID`,
  COUNT(*) AS `Count`
FROM default.event
WHERE
  type = 'quirk' AND
  quirk = '$quirk' AND
  gameid IS NOT NULL AND
  $__timeFilter(ts)
GROUP BY gameid
ORDER BY `Count` DESC

When selecting one or multiple value, but not "All", a sample substituted query (correct, note that it has the AND quirk = ...):
SELECT gameid AS `Game ID` , COUNT(*) AS `Count` FROM default.event WHERE type = 'quirk' AND quirk = 'uses-DVDLowOffset' AND gameid IS NOT NULL AND ts >= '1645024345' AND ts <= '1645629145' GROUP BY gameid ORDER BY `Count` DESC

When selecting the "All" value, every single panel has the same substituted query (broken, it doesn't have any filter on quirk, should be same as the previous case):
SELECT gameid AS `Game ID` , COUNT(*) AS `Count` FROM default.event WHERE gameid IS NOT NULL AND ts >= '1645024431' AND ts <= '1645629231' GROUP BY gameid ORDER BY `Count` DESC

To Reproduce
Steps to reproduce the behavior:

Add a multi-valued variable to a dashboard.
Create a repeating panel using the variable as a query filter.

Expected behavior
Every panel properly substitutes the right value for the repetition variable in the "All" selection case, instead of stripping out the filter.
Screenshots
Dashboard link (same as linked above): https://mon.dolphin-emu.org/d/rvvg02qGk/analytics-quirks-report
Additional context
n/a

@delroth #88 should fix this.
NOTE:  If you select ALL, it will optimize your query and just remove that line from your where clause, since it's not really filtering anything.
Also, when using multi value variables you'll want to use IN
SELECT
  gameid AS `Game ID`,
  COUNT(*) AS `Count`
FROM default.event
WHERE
  type = 'quirk' AND
  quirk IN ($quirk) AND
  gameid IS NOT NULL AND
  $__timeFilter(ts)
GROUP BY gameid
ORDER BY `Count` DESC

Updated to 0.12.2 and unfortunately the bug seems to still occur. Any chance you could reopen this?

NOTE: If you select ALL, it will optimize your query and just remove that line from your where clause, since it's not really filtering anything.

This is incorrect behavior in the case of repeated panels though. The way I understand it (and the way it works with other data sources, as far as I can tell), using a multi-valued variable with repeated panels should have each panel "see" only a single value for the variable.
To give an example, let's say there is a multi-valued variable with values "a", "b", "c". If I select "All" and have a repeated panel setup, I should have 3 panels each being filtered to the single values "a", "b" and "c" respectively. Instead, the ClickHouse data source right now shows 3 panels but each with no filter, which is not how repeated panels should operate.
Similarly, your previous comment on using "IN" instead of "WHERE" shouldn't apply to repeated panels. When repeating panels, there is no way the query should see more than one value for the variable, because each value maps to a different instance/repeat of the panel.
Happy to clarify further with some examples from other data sources in case my description isn't clear enough and/or you disagree with what I described as the "correct" behavior!

My suspicion, again, knowing pretty much nothing about Grafana: CHDatasource.ts:61
rawQuery = removeConditionalAlls(rawQuery, templateSrv.getVariables());
...
rawSql: this.replace(rawQuery, scoped)

I think this might be looking at the variable value at the dashboard level, vs. scoped which would be the value at the panel level. This would match the symptoms: the variable interpolation looks at the scoped variables and so does the interpolation correctly for the repeated panels when a set of values are selected. But when "All" is selected at the dashboard level, removeConditionalAlls deletes the filter even though the scoped variable would have a different value from "All".
If this is true, I think the correct fix would be to have removeConditionalAlls act on scoped instead of templateSrv.getVariables(), or possibly a combination of both. WDYT?

To support this theory, I added some logging in the relevant code path. First logged value is scoped, second is templateSrv.getVariables:

For the repeated panels, even though the value in templateSrv.getVariables is $__all, the value in scoped is the "instantiated" value for the panel (in this case, mismatched-gpu-colors-between-xf-and-bp).

#89 is my attempt at a fix, confirmed to work on my dashboard. I've also checked that a non-repeating panel still has its "All" filter stripped as intended.

Fixed by #89


Let constructor be idempotent

Since CID constructor is idempotent, we could clean code avoiding cleanCid (e.g. here)

Coverage decreased (-1.1%) to 86.154% when pulling 118d5b5473238fa6ae9eb75633b35b660b154a84 on enricomarino:patch-1 into 389fc1af1406b3324dc96a6d689c463db4b48cf7 on ipld:master.

Coverage decreased (-1.1%) to 86.154% when pulling 118d5b5473238fa6ae9eb75633b35b660b154a84 on enricomarino:patch-1 into 389fc1af1406b3324dc96a6d689c463db4b48cf7 on ipld:master.

Coverage decreased (-1.1%) to 86.154% when pulling 118d5b5473238fa6ae9eb75633b35b660b154a84 on enricomarino:patch-1 into 389fc1af1406b3324dc96a6d689c463db4b48cf7 on ipld:master.

ping @enricomarino :)

ack @diasdavid :)
You're right! No need to invoke new in constructor.
constructor (version, codec, multihash) {
    if (CID.isCID(version)) {
      let cid = version
      this.version = cid.version
      this.codec = cid.codec
      this.multihash = Buffer.from(cid.multihash)
      return
    }
    //...
}

If it's ok, I'd love to contribute (code + test in the same pull request...) :)

go for it :)

ready :)


How do I separate different log levels into different files?

Hello everyone. I want to distinguish log levels by file, like info.log and error.log, but I don't know how to implement this.
Below code does not work:
let log_file = format!("{}/{}.log", log_dir, log_name);
let err_log_file = format!("{}/{}.err.log", log_dir, log_name);
let info_writer =
	FileAppender::rotate_with_expire(&log_file, Period::Day, Duration::days(3));
let error_writer =
	FileAppender::rotate_with_expire(&log_file, Period::Day, Duration::days(3));
ftlog::Builder::new()
	.root_log_level(LevelFilter::Info)
	.root(info_writer)
	.filter("", "error_appender", LevelFilter::Error)
	.appender("error_appender", error_writer)
	.try_init()
	.expect("logger build or set failed");

I don't think it currently possible in ftlog to direct different level to individual files.

I don't think it currently possible in ftlog to direct different level to individual files.

Do you know if any other loggers have this feature?

idk. Maybe log4rs?

log4rs

thx. I decided to switch to it because I truly need this feature.


Setting up slanger on Heroku

Now that Heroku supports websockets I am trying to setup Slanger in a Heroku app to use it instead of Pusher.
For that porpuse I wrote a Procfile looking like this:
web: slanger --app_key somekey --secret somesecret --redis_address $REDISCLOUD_URL
In Heroku logs i get the following error:
Error R10 (Boot timeout) -> Web process failed to bind to $PORT within 60 seconds of launch
What am I missing?
I am also very interested in learning how would it be possible to scale slanger using Heroku. Is it Heroku suitable for running and scaling slanger or should I go for AWS EC2?
Thanks a lot in advance

@stevegraham how is the rewrite going? if you need some testing in Heroku or AWS let me know

It's almost done. The only thing left is to make the presence rosters work well across more than one Erlang node. Thanks for the nudge. ;)

awesome! thanks man

:) looking forward to it!

Google brings me here. So good to hear that stevegraham is working on it!!! Thanks man.

@stevegraham it would be nice if you can made a service for slanger. I tried to make it automatic start on boot but failed and don't know why? I used Upstart on Ubuntu server. Here is my config for Upstart:
# myservice - myservice job file

description "Slanger Service"
author "BigS"

# Stanzas
#
# Stanzas control when and how a process is started and stopped
# See a list of stanzas here: http://upstart.ubuntu.com/wiki/Stanzas#respawn

# When to start the service
start on runlevel [2345]

# Automatically restart process if crashed
respawn

# Start the process
exec slanger --app_key KEY --secret SECRET

@diegopau - addressing your scalability conerns,  slanger on EC2 + HAproxy (http://blog.haproxy.com/2012/11/07/websockets-load-balancing-with-haproxy) is a good solution.

Error R10 (Boot timeout) -> Web process failed to bind to $PORT within 60 seconds of launch
i found this error after launch slanger


WIP: Add a leanpubr preview/publish script

Summary
This is a first step toward: #11
This script we can use to publish or preview items to Leanpub. I still need to add instructions for this on CONTRIBUTING.md.
This would be the basic usage:
Rscript scripts/preview-leanpub.R \
-s jhu/jhudsl_course_template \
-a <Whatever your API Key is here>

Or you can set your API key to the environment so leanpubr will grab it.
Currently, I'm having troubles getting the preview to work -- I wonder if its because this will only work if the course is already published? Not sure.

The changes on this repo will be for a leanpub repo and thus in accordance with #19 will not be needed here. I will open a new PR on the Leanpub repo when its made for this script.


Vendor all dependencies with dep

changes

vendor dependencies with dep
check in vendor/
replace docker/docker imports with moby/moby (latest release in moby repo)
update docker deps to 17.05.0-ce
prune as much cruft from vendor/ as possible
make this project go get-able again

This is a great project, but the dependencies are in a bad state. This is partly due to trying to use git submodules to manage dependencies, but mostly to the complete mess that is docker's build, release, and versioning process. After some fighting, I was able to get dep to vendor the correct versions of moby/moby and the docker/docker transitive dependency. The dependencies are now in as good a state as I can make them.
I suspect you were using submodules to avoid checking in all the source code in vendor/. I realize large commits like these are ugly, but having an unbuildable project is uglier. Because of the docker/moby mess, your dependency situation is especially tricky. You can avoid a lot of headaches for users and contributors by just checking in your deps.

Hi! Thanks for your contribution and your efforts. I want to fix this. However, I'm very reluctant to take this PR as is. There are a few issues as I see it.
The first is that it is unnecessarily large. As I understand it, the total list of package dependencies is:
$ go list -f '{{join .Deps "\n"}}' github.com/pwaller/docker-show-context | xargs go list -f '{{if not .Standard}}{{.ImportPath}}{{end}}' | sed 's|.*vendor/||'

github.com/Sirupsen/logrus
github.com/docker/docker/builder/dockerignore
github.com/docker/docker/pkg/archive
github.com/docker/docker/pkg/fileutils
github.com/docker/docker/pkg/idtools
github.com/docker/docker/pkg/ioutils
github.com/docker/docker/pkg/pools
github.com/docker/docker/pkg/promise
github.com/docker/docker/pkg/system
github.com/docker/go-units
golang.org/x/net/context

So we should be able to avoid pulling in most of docker. If we consider these packages alone, it is clear that we should not need to vendor 218k+ lines of code. (I count somewhere more like 15k).
Another issue is that I want to be able to personally audit the code to the extent that I can. I can't accept a 218k+ line diff, unless I can independently generate it exactly. Better would be if I were supplied with instructions which generated such a diff. Better still would be to pull directly from the authoritative sources, so that one doesn't need to trust too much about my repository.
Another issue is that, docker may have renamed to moby, but their codebase is littered with package declarations indicating that it should still be imported as docker/docker. See https://golang.org/cmd/go/#hdr-Import_path_checking. I have just now learned that this checking is disabled in vendor directories, interestingly.
vgo is also on the near-term horizon, so I'm reluctant to start using a tool which may be soon obsolete.
So I'm thinking we might need another strategy. One possibility is to pull in the imports we need directly.
By the way, I have also been thinking about these issues in another context. I'm hopeful that vgo might provide a good route forward.

Please take a look at #6, I would be interested to know if it works for you.

FYI, I'm now away and not responding to messages for a little while. I'll come back to this in a couple of weeks. Apologies for the delay!

vgo is the future, but it's not here yet. If you're okay with making vgo a requirement for installing, that's fine. Personally, I would want to wait until August when Go 1.11 drops with "experimental" vgo support. That way docker-show-context could be installed without needing a parallel build tool. Meanwhile, docker-show-context is broken today.

Another issue is that, docker may have renamed to moby, but their codebase is littered with package declarations indicating that it should still be imported as docker/docker.

I don't think that's a correct interpretation of the import comments. I think they were trying to avoid breaking old package imports, not encouraging the use of docker/docker instead. The go spec says this:

In this way, import comments let package authors make sure the custom import path is used and not a direct path to the underlying code hosting site.

...but that's not how Docker are using it. docker/docker is just a GitHub redirect to moby/moby. I tried changing the URLs back to docker/docker and it was a dep solving failure. AFAICT my PR is the only way that works (with dep anyway). Your vgo PR is vendoring Ye olde docker from Feb 2017. You might be able to get the current release by changing the imports to moby/moby.
As for this being too much code, dep decided that it needed all that code. I trust it. I see there are github.com/Microsoft packages in vendor/, so I suspect the difference between go list and what dep is actually vendoring is due to Windows support. The output of go list may only be the dependencies needed to run on your system.
tl;dr It's up to you, but I'd land dep today and transition to vgo sometime after Go 1.11 drops.

Thanks again for your input. Sorry I chose not to go with your method. The vgo method now seems to work. Let me know if you see any issues with it (other than the fact that at the moment you have to grab the beta vgo tool! :))


Change default format

Most time I use this extension to modify chunks of HTML code inside WordPress Dashboard (Contact Form 7 plugin) and I want to use HTML as default, not Markdown.
So this is a feature request to add default syntax format as plugin option.

Hi,
This should not be too hard to implement, but I will not have time this week so a PR would be very welcome.


Non-visible slides when using CSS grid in combination with loop: true

Bug is related to

[x] embla-carousel (core package)

Embla Carousel version

v6.2.0

Describe the bug
When CSS grid (as described here) is used in combination with loop: true, the left offset of the last or first slide is not properly calculated and it leads to not showing the first/last card inside the carousel.
The calculation here is correct for flex-box: https://github.com/davidjerleke/embla-carousel/blob/master/packages/embla-carousel/src/components/SlideLooper.ts#L49-L63
But when display: grid is used for the embla__container the value left needs to be set relative to each slide/card instead of the container width (+ gaps).
CodeSandbox
https://codesandbox.io/s/embla-carousel-loop-vanilla-forked-4b75xf?file=/package.json
Or as standalone example: https://4b75xf.csb.app/
Steps to reproduce

Open https://4b75xf.csb.app/ (Carousel with loop: true and CSS Grid)
Last card is shown on the left
Click on previous button
Now the first card is not shown on the right

Expected behavior
That the last / first card is shown when looped using CSS grid.
Additional context
Initial Load: missing last card

Clicking on previous button: first card is not shown

Hi @klipstein,
Thank you for reporting this problem and a clear bug report.
I've been meaning to change the transition unit from % to px for a while. That might solve this problem because using absolute units won't cause problems with relative positioning like this bug.
The sole reason why I went with Embla using left/top over transform: translate() when shifting slide positions (when loop is activated), is because Safari is freaking out when transforming slides with the % unit. The % transform calculations in Safari isn't precise so it's rendering unwanted 1-5 px glitches between slides when shifting positions (this isn't an issue with other browsers though). So when I built this, I went with the left/top properties because I wanted the transition unit to be %. Working with pixels instead, which is an absolute unit, Safari is behaving correctly so therefore it might be worth migrating to px transitions.
A side note. If you're using grid-gap to add spacing between your slides you won't have a gap between the first and last slide. You'll need to add margin to the last slide or similar to achieve this.
This issue won't be my highest priority right now because as you mentioned it's possible to use flexbox instead. The following issue:

#281

...has the highest priority because it's very time consuming and I have to get rid of that.
Best,
David

This issue is rather an edge-case and I mostly wanted to document it (until potentially fixed) in case someone else stumbles upon it.

@klipstein, very much appreciated. I’ll see if changing unit to px solves the problem when I’m working on it.
Cheers,
David

@klipstein I’m working on Embla v7 now and this bug will be solved there.

Hi @klipstein,
If you're interested: v7.0.0-rc01 has been released. Feel free to try it out and confirm if the bug is gone if you want.
Cheers,
David

@klipstein thank you for your swift response and testing it 👍. The missing gap between the last and the first slide is expected because setting gap in CSS only applies gap between items and not to the end. Embla won't interfere with or modify the CSS you choose to add spacing and that's why this is something the user has to solve.
Again, thanks for confirming that the bug is gone.
Cheers,
David

Released with v7.


[EAP7-1795] Update the document to reflect the changes made to protoc…

…ol on wildfly-http-client 1.2.0.Final (see WEJBHTTP-86)
Signed-off-by: Flavia Rainone<EMAIL_ADDRESS>

Your changes look good but this PR needs a rebase @fl4via


Rendering a Table with no rows results in delimiter line being lost

Hi,
If you render a Table with no rows the delimiter line gets lost on rendering, which means if you parse it again then it becomes a Paragraph.
e.g.
When elm-markdown parses the following:
one | two
--- | ---

it is correctly parsed as a Table block
However when elm-markdown-transforms renders it, it becomes:
one | two

When elm-markdown parses it the next time it becomes a Paragraph instead of a Table
This doesn't seem right and breaks my application.
According to this spec, a table with no rows is valid markdown:
https://github.github.com/gfm/#tables-extension- (see example 205)

Good find.

Added a regression test
I've published a patch release (3.0.1)

Let me know if that works for you.

Good find.

Added a regression test
I've published a patch release (3.0.1)

Let me know if that works for you.

Thank you for the quick response again!
That is looking great, just one small thing... If you have a Paragraph after the Table (with no rows), when it is rendered an extra blank row is being inserted, is it possible tow remove that? It works as expected when there are rows.
Sorry if this seems a bit picky, but I'm round-tripping moving data between tables and it looks very odd when extra rows appear/disappear.
e.g. empty rows produces
one | two
--- | ---

para after table

should be:
one | two
--- | ---

para after table

Thank you for the quick response again!
That is looking great, just one small thing... If you have a Paragraph after the Table (with no rows), when it is rendered an extra blank row is being inserted, is it possible tow remove that? It works as expected when there are rows.
Sorry if this seems a bit picky, but I'm round-tripping moving data between tables and it looks very odd when extra rows appear/disappear.
e.g. empty rows produces
one | two
--- | ---

para after table

should be:
one | two
--- | ---

para after table

Sorry if this seems a bit picky, but I'm round-tripping moving data between tables and it looks very odd when extra rows appear/disappear.

That is absolutely fine. My goal for the pretty-printer is for it to be round-trippable and idempotent. I'm also trying to ensure this via tests, but haven't had much time to gather lots of test data/write a markdown fuzzer.
You can see these properties tested here:
https://github.com/matheus23/elm-markdown-transforms/blob/df47860dfac7488f750a129a617c5cee6dc56d5c/tests/Tests.elm#L29-L77
And e.g. some of the test data used is here:
https://github.com/matheus23/elm-markdown-transforms/blob/df47860dfac7488f750a129a617c5cee6dc56d5c/tests/Tests.elm#L270-L290
The data doesn't cover this case right now. I'll add a regression test and fix it.

Sorry if this seems a bit picky, but I'm round-tripping moving data between tables and it looks very odd when extra rows appear/disappear.

That is absolutely fine. My goal for the pretty-printer is for it to be round-trippable and idempotent. I'm also trying to ensure this via tests, but haven't had much time to gather lots of test data/write a markdown fuzzer.
You can see these properties tested here:
https://github.com/matheus23/elm-markdown-transforms/blob/df47860dfac7488f750a129a617c5cee6dc56d5c/tests/Tests.elm#L29-L77
And e.g. some of the test data used is here:
https://github.com/matheus23/elm-markdown-transforms/blob/df47860dfac7488f750a129a617c5cee6dc56d5c/tests/Tests.elm#L270-L290
The data doesn't cover this case right now. I'll add a regression test and fix it.

Actually, I'm not sure what exactly your issue is. I've added your example to the tests, and it round-trips and idempotency test just fine.
I've also just copy-pased your example into the online example website (https://elm-markdown-transforms.netlify.app/format-tables.html), and it produces just what you describe as "should be":

Please reopen this issue if there's a case I've missed :)
Maybe your case is a special case for when you're generating the markdown by yourself from elm rather than obtaining a markdown AST from parsing?

Actually, I'm not sure what exactly your issue is. I've added your example to the tests, and it round-trips and idempotency test just fine.
I've also just copy-pased your example into the online example website (https://elm-markdown-transforms.netlify.app/format-tables.html), and it produces just what you describe as "should be":

Please reopen this issue if there's a case I've missed :)
Maybe your case is a special case for when you're generating the markdown by yourself from elm rather than obtaining a markdown AST from parsing?

sigh, I checked again, I just missed the newline (barely visible in the screenshot). It is there.
I added a regression test:
https://github.com/matheus23/elm-markdown-transforms/blob/e6419b4c32156e633eb03115bff120e1b24f9797/tests/Tests.elm#L51-L67
And a fix.
Let me know if that works for you :)

sigh, I checked again, I just missed the newline (barely visible in the screenshot). It is there.
I added a regression test:
https://github.com/matheus23/elm-markdown-transforms/blob/e6419b4c32156e633eb03115bff120e1b24f9797/tests/Tests.elm#L51-L67
And a fix.
Let me know if that works for you :)

Thank you, that's all fixed now.
Pleased to hear about your round-trips and idempotency. I'm doing the same, parsing to a markdown AST, then transforming the AST before rendering it with your library. It's working nicely now. I wonder if another library of AST transformations might emerge out of it.
Cheers,
Paul

Thank you, that's all fixed now.
Pleased to hear about your round-trips and idempotency. I'm doing the same, parsing to a markdown AST, then transforming the AST before rendering it with your library. It's working nicely now. I wonder if another library of AST transformations might emerge out of it.
Cheers,
Paul


Number followed by newline replaces the field's data with numeric 0

Hi, when writing to an XLSX file, any \n translates the whole field number 0 automatically.
The string has to have a number. For example:
remarks = "hello world\n1234\n5678 Hello world\n"
worksheet.write(row, 4, remarks, fsize_8pt_wrapped_vtop)

Result:

So the string is replaced with 0. The way to fix this is to convert \n to whitespace or something. Is there any workaround?
Tried Onlyoffice and libreoffice to view xlsx files.
Temporary Solution:
remarks.gsub!(/^\d+$/) { |x| "#{x}\s" }

Adding a white-space or any other characters (like \u200B) fixes the issue. But it adds the extra unwanted character.

This is a bug. Give me some time to fix it.

v1.09.2 has been released.
try it.


Vagrantfile improvements

added version contraint for vagrant. Stops the run before suspicious bash provider errors
some ruby based cleanups. Empty lines, method names, string interpolation, regex call...

just one nitpick. otherwise, looks good. thanks!

silly rubocop, whining about trivial things...
It's nice and readable the way it is. I want it to be obvious so people can disable it easily if they want, without having to add yet another environment variable.
I'm ok with having line comments tho. If you prefer that.

ok updated it...
and indeed its a bit trivial... however i personally like tools like rubocop to keep things clean

some recent PRs were just merged. can you rebase?

ok did the rebase but please double check... had conflicts with lib/vagrant-dcos/provisioner.rb. Guess i resolved them but please review it.

oops. guess i should have merged this first. sorry. needs another rebase.

no worries.. on it

great! Thanks!


no uniqe ids

Problem
Platform tplink_deco does not generate unique IDs. ID 68-FF-7B-32-56-A8 already exists - ignoring device_tracker.bedroom_deco
Platform tplink_deco does not generate unique IDs. ID 28-87-BA-88-83-A4 already exists - ignoring device_tracker.hallway_deco
what can be done to resolve these?
TP-Link Deco Version
v2
Router Model
deco m4
Debugging Information
Platform tplink_deco does not generate unique IDs. ID 68-FF-7B-32-56-A8 already exists - ignoring device_tracker.bedroom_deco
Platform tplink_deco does not generate unique IDs. ID 28-87-BA-88-83-A4 already exists - ignoring device_tracker.hallway_deco

Are there other entities added from those mac addresses from different integrations?

????

..and this is a new one
Logger: homeassistant.helpers.frame
Source: helpers/frame.py:77
First occurred: 18:33:22 (1 occurrences)
Last logged: 18:33:22
Detected integration that restore_state.RestoreStateData.async_get_instance is deprecated, and not intended to be called by custom components; Pleaserefactor your code to use RestoreEntity instead; restore_state.async_get(hass) can be used in the meantime. Please report issue to the custom integration author for tplink_deco using this method at custom_components/tplink_deco/init.py, line 121: last_states = (await RestoreStateData.async_get_instance(hass)).last_states

Can you answer the above question? Can't help without more info.

not sure what the question is.. these are the MAC addr of the deco routers. no other integration is connected to these devices.

How did you verify that no integration is connected to those routers? The best way to verify is to look in your core.entity_registry file and look for that MAC address.
If you're sure they aren't coming from another integration, then please get debug logs https://github.com/amosyuen/ha-tplink-deco/blob/main/DEBUGGING.md#general-steps.
Also would like info on when you see the errors. e.g. At the integration first setup? Each time integration starts?

ok I dont know where this file is. I have smb installed but dont find it.
Amos Yuen @.***> ezt írta (időpont: 2023. júl. 20., Cs,
23:14):

How did you verify that no integration is connected to those routers? The
best way to verify is to look in your core.entity_registry file and look
for that MAC address.
If you're sure they aren't coming from another integration, then please
get debug logs
https://github.com/amosyuen/ha-tplink-deco/blob/main/DEBUGGING.md#general-steps
.
Also would like info on when you see the errors. e.g. At the integration
first setup? Each time integration starts?
—
Reply to this email directly, view it on GitHub
https://github.com/amosyuen/ha-tplink-deco/issues/188#issuecomment-1644617942,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACY67SLAPB43ZQKLGGXLQFTXRGNS7ANCNFSM6AAAAAAY35X4GI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Closing because no debug logs

No problem. I did not receive any answer either so I deleted the integration.


Incompatable type '()-> [AnyHashable: Any]'

Hello
I had follow installation instruction and also followed ios trubleshooting part as well (creating dummy.swift file) but i am facing two error

Method does not override any method from its superclass
Overriding method with selector 'constantsExport' has incompatible type '()->[AnyHashable: Any]'

Project  Details
react-native: 0.47.0
react-native-track-player: 0.2.4
xcode version: 9.1
os: MacOs Higher sierra (10.13.2)

This should not be a problem anymore with the latest react-native. Please, update your project.


chat-update event is not working

Hi! I want to track stream message but chat-update event is not working.

Hi there, does it throw any error message?

Any error messages etc. I'm not buying. The direct doesn't work, it doesn't return anything.

Just tried it on runkit and it seems to be working as expected:

It's really hard to pinpoint what is causing this as it seems to be an isolated case, but I'll do some more testing.

it was working yesterday but not now. But updating video stats is working.

I understand problem. If the clock is back it doesn't work.

I understand this problem. If the clock is back it doesn't work.


Allow and document usage with stable rust

ooh, alloc on stable :eyes:
I think we should document the MSRV, and also have CI check both latest stable and MSRV stable?

I think we should ~document the MSRV~ put the MSRV in the readme with the typical boilerplate, and also have CI check both latest stable and MSRV stable?

How would you phrase that? Technically, the MSRV is <1.68, the library itself compiles fine with 1.67 and possibly with much older versions as well.
It's only once you add extern crate alloc to your binary, that you need either #![feature(default_alloc_error_handler)] (which is automatically active with Rust 1.68), or #![feature(alloc_error_handler)] (which needs nightly).
Of course, this library is not very useful if you don't add extern crate alloc.
But again, technically, this works on stable rust <1.68:
  let allocated: &u8 = unsafe { &*HEAP.alloc(Layout::from_size_align(1,1).unwrap()) };

(Please ignore that it's probably UB because the memory is not initialized etc. - that's not the point here.)
So the current statement in the README, "Note that using this as your global allocator requires Rust 1.68.", is the most specific one I know which is both useful and technically correct.
Regarding boilerplate, currently the README refers to examples/global_alloc.rs which contains the boilerplate and not much more. This can probably be inlined into the README, the code is short enough. I'll add that to the pull request.
I'd add the CI check once 1.68 is officially released. According to https://releases.rs/, that'll be on March 9, five days from now.

BTW, none of this is necessary to use embedded-alloc on Rust 1.68. As long as the version of linked_list_allocator is at least 0.10.5, embedded-alloc 0.5.0 can today be used on 1.68.0-beta. All this PR actually does is making sure that the correct version of linked_list_allocator is used.

Had a quick look - seems OK to me.

Thank you! Could you also add the MSRV badge? ![Minimum Supported Rust Version](https://img.shields.io/badge/rustc-1.68+-blue.svg)

So you think it would be best to just say "MSRV = 1.68" even if it's technically working with older versions as well?
I tend to agree, because for the most obvious usage, 1.68 will be required. And people with more elaborate use cases which work without extern crate alloc probably know what they are doing and won't be confused by that badge.
Shall I add that badge right now, even though 1.68 is not yet released?

I think we should ~document the MSRV~ put the MSRV in the readme with the typical boilerplate, and also have CI check both latest stable and MSRV stable?

How would you phrase that? Technically, the MSRV is <1.68, the library itself compiles fine with 1.67 and possibly with much older versions as well. It's only once you add extern crate alloc to your binary, that you need either #![feature(default_alloc_error_handler)] (which is automatically active with Rust 1.68), or #![feature(alloc_error_handler)] (which needs nightly).
Of course, this library is not very useful if you don't add extern crate alloc. But again, technically, this works on stable rust <1.68:
  let allocated: &u8 = unsafe { &*HEAP.alloc(Layout::from_size_align(1,1).unwrap()) };

(Please ignore that it's probably UB because the memory is not initialized etc. - that's not the point here.)
So the current statement in the README, "Note that using this as your global allocator requires Rust 1.68.", is the most specific one I know which is both useful and technically correct.
Regarding boilerplate, currently the README refers to examples/global_alloc.rs which contains the boilerplate and not much more. This can probably be inlined into the README, the code is short enough. I'll add that to the pull request.
I'd add the CI check once 1.68 is officially released. According to https://releases.rs/, that'll be on March 9, five days from now.

oh I see. This is not as simple as I thought :sweat_smile:. This comment is really good info! Why not add that to the README?
i.e. document that:

MSRV is 1.68 stable
but you can use it in older versions with #![feature(alloc_error_handler)] or #![feature(default_alloc_error_handler)]
you can set a custom error handler in nightly with #![feature(alloc_error_handler)]

(I'm not sure we should mention the "manual" way to alloc, that's very cursed and I can't think of any reason someone would want that, especially now that you can use alloc on stable...)

Shall I add that badge right now, even though 1.68 is not yet released?

IMO why not? so it'll be ready right when it's released.

The MSRV is about the minimum version we want to support. I understand 1.68 is the first version where it really makes sense. We are not setting rust-version so it will continue to work with older versions.
I would also go ahead with the badge since it is only a few days away.

bors r+

Let's not be overtaken by events for the sake of the last 0.001%. We can always revise it again later.


jail.local.j2: sort service.items to ensure idempotency

The promised pull request made in the issue https://github.com/Oefenweb/ansible-fail2ban/issues/48

Fixes #48


haskell lib: add --enable-benchmarks in doBenchmark

Motivation for this change
doBenchmark adds the dependencies for benchmarks to be built, but does not actually build them. This is surprising - I would think that anyone setting this flag wants the build to check that the benchmarks build. They still aren't executed, but that's expensive and should probably indeed be done separately.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

ping?

Thanks!


Page is inaccurate; there is no "Delete Repository" action

I am a project administrator and the organization owner and I have every level of permission I can figure out how to get the Azure platform to grant me on this stuff I've created, and still I cannot delete this repository. This page telling me there's a button for it when there isn't, doesn't help. Is the button hidden because I'm somehow not authorized? Please disable it instead and explain why I, the supreme owner of everything to do with our Azure pipelines, am not authorized to delete the empty repository that was automatically created for our well-established existing project.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b03af1d9-4eeb-ac18-d517-a0a44a2478be
Version Independent ID: 842691c8-8c41-facf-2cff-03542262f2e5
Content: Delete a Git repo from your project - Azure Repos
Content Source: docs/repos/git/delete-existing-repo.md
Product: devops
Technology: devops-code-git
GitHub Login: @apawast
Microsoft Alias: sdanie

@JoshDreamland -- Josh, thank you for your feedback.  You may find answers here:

Azure DevOps Support Bot
Azure DevOps on Stack Overflow

@apawast -- Apeksha, please look into this issue.

The issue in my case was that this was, indeed, the only git repo in my project. But I didn't ask for that repo; we already have one. And instead of a grayed out box that says "This is your only repository. Please disable Git from the 'General' tab instead," I was met with a missing menu item that the documentation said should be there.
In this case, my journey was as follows:

Create Project.
Notice it has six different services attached to it, including a Git repository.
Wonder if the Git repository may interfere with implementing CI for my existing reposity.
Attempt to delete it.
Find no way to delete it, check docs.
Docs have an image showing a delete button, but the delete button isn't actually there.

Short-term, this could be solved by tweaking whatever logic hides the button from me so that it does something useful instead (see suggestion at beginning of this post).
Long-term, it would be nice if the button actually worked, and simply disabled the repository option for me, instead.

Typical MS confusion. Get your documentation corrected!

It's already documented in this article.

Hi Mike.
The issue is more about discoverability. As a user, I can't identify why a button is missing, but if it is grayed out and has the above snippet as hovertext, I would not need to refer to the documentation at all (much less be shown an image of a button that isn't on the page I'm looking at).


Fix broken icons

please check this as I had to merge to get latest changes so it pulls in your last commit

Thanks! Released as<EMAIL_ADDRESS>


GLANCETRACKERAPI.destroy() or stop()

Thanks for the lightweight library.
It would be better if there is a method to stop the tracker completely and stopping the camera stream, cleaning the canvas.
something like GLANCETRACKERAPI.destroy()

Hi @santosh898
I have added an option in the toggle_pause method, it can now shut down the camera video stream (so the camera light turns off).
I have updated the documentation and enabled this feature in the provided integration samples. You can check it out here: https://jeeliz.com/demos/glanceTracker/demos/integration/
GLANCETRACKERAPI.toggle_pause(true, true); --> pause and shut camera
GLANCETRACKERAPI.toggle_pause(false, true); --> resume and re-get camera

When the tracker is paused and camera turned off, nothing is running, no loop or whatever.
The memory footprint is neglictible.
Best,
Xavier


Property "quality" will copy image

react-native: 0.63.2
react: 16.13.1
react-native-image-picker: 2.3.3

init a new react-native demo
add  'react-native-image-picker'
try demo, and is ok.(Choose from Library & choose a picker)

import ImagePicker from 'react-native-image-picker';

// More info on all the options is below in the API Reference... just some common use cases shown here
const options = {
  title: 'Select Avatar',
  customButtons: [{ name: 'fb', title: 'Choose Photo from Facebook' }],
  storageOptions: {
    skipBackup: true,
    path: 'images',
  },
};

/**
 * The first arg is the options object for customization (it can also be null or omitted for default options),
 * The second arg is the callback which sends object: response (more info in the API Reference)
 */
ImagePicker.showImagePicker(options, (response) => {
  console.log('Response = ', response);

  if (response.didCancel) {
    console.log('User cancelled image picker');
  } else if (response.error) {
    console.log('ImagePicker Error: ', response.error);
  } else if (response.customButton) {
    console.log('User tapped custom button: ', response.customButton);
  } else {
    const source = { uri: response.uri };

    // You can also display the image using data:
    // const source = { uri: 'data:image/jpeg;base64,' + response.data };

    this.setState({
      avatarSource: source,
    });
  }
});

add property 'quality', and it's bad!(Choose from Library & choose a picker)

const options = {
    title: 'Select Avatar',
    customButtons: [{name: 'fb', title: 'Choose Photo from Facebook'}],
    storageOptions: {
      skipBackup: true,
      path: 'images',
    },
    quality: 0.2,                  // add this line
  };

  /**
   * The first arg is the options object for customization (it can also be null or omitted for default options),
   * The second arg is the callback which sends object: response (more info in the API Reference)
   */
  ImagePicker.showImagePicker(options, (response) => {
    console.log('Response = ', response);

    if (response.didCancel) {
      console.log('User cancelled image picker');
    } else if (response.error) {
      console.log('ImagePicker Error: ', response.error);
    } else if (response.customButton) {
      console.log('User tapped custom button: ', response.customButton);
    } else {
      const source = {uri: response.uri};

      // You can also display the image using data:
      // const source = { uri: 'data:image/jpeg;base64,' + response.data };

      this.setState({
        avatarSource: source,
      });
    }
  });

if you choose a picker, then this picker will copy one.

same here, after picking an image from the library (Android) it automatically creates the same image without a background. Then I have 2 images in the library

same here, do you have a solution?

same here, do you have a solution?

delete quality property

same here, do you have a solution?

delete quality property

Version 2.x.x is not longer supported, please upgrade to 3.x.x
This issue is fixed in latest version


Vagrant rsync should support --copy-dirlinks

When running vagrant provision, the rsync is invoked with a static set of options. Currently that is:

# from vagrant-libvirt/action/sync_folders.rb
            command = [
              "rsync", "--del", "--verbose", "--archive", "-z",
              "--exclude", ".vagrant/",
              "-e", "ssh -p #{ssh_info[:port]} #{proxycommand} -o StrictHostKeyChecking=no -i '#{ssh_info[:private_key_path]}'",
              hostpath,
              "#{ssh_info[:username]}@#{ssh_info[:host]}:#{guestpath}"]

For files that use symlinks that point outside of the rsync-ed folder, you'll get dead symlinks.
I propose that --copy-dirlinks be added, but only as an option. This means that if you'd like to use this option, there's a way to set it from the vagrantfile.
If you can guide me on the correct way to glue in the options in the vagrantfile, I'm happy to write the patch. I think it would be useful to specify it on a per-type-of-thing sync-ing sort of way.
Let me know,
James

http://docs.vagrantup.com/v2/synced-folders/rsync.html

@sciurus I don't need this anymore, and @pronix points out it seems to be configurable now with the options args. I didn't test, but it's okay to close :)


graph unknown-command subgraph.yaml fails with a 'Failed to load subgraph' error

When you run
graph generate-types subgraph.yaml

or
graph foo subgraph.yaml

it fails with a Failed to load subgraph error, which is very confusing and incorrect. It should instead tell users that generate-types/foo is an unknown command and then probably print the usage/help text.

Also, update docs. Step 5 tells you to paste this into your package.json
{
"scripts": {
"codegen": "graph generate-types subgraph.yaml",
"build": "graph build subgraph.yaml",
"build-ipfs": "graph build --ipfs /ip4/<IP_ADDRESS>/tcp/5001 subgraph.yaml"
}
}


Limitations while using WIP

Hello,
Seems that file "preview" in Windows Explorer is locked when file is WIP protected.
Could be useful to add this info into this document.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6f23c9b6-81aa-b06d-5c19-196ac933b6ff
Version Independent ID: 0c7eb396-4274-c546-6063-6d38382b956d
Content: Limitations while using Windows Information Protection (WIP) (Windows 10)
Content Source: windows/security/information-protection/windows-information-protection/limitations-with-wip.md
Product: w10
Technology: windows
GitHub Login: @DulceMontemayor
Microsoft Alias: dansimp

@lightupdifire
The issue has been noted and the document will be revised in the light of your feedback.
Thank you.
cc @VLG17

@lightupdifire This is indeed a good remark. As far as i know, this is not caused by the WIP policy but by a Windows functionality called Encrypting File System (EFS), which is leveraged by the WIP policy when corporate marked data is written to disk.
In my opinion this should not be added to the WIP limitations page, because it's not WIP specific.

@VLG17 Preview brakes after WIP policy activated, the background is, of course, is the EFS, but articles about EFS outdated, quite complex to understand what is happening from Enterprise-level...
So like we selected Microsoft product as Intune for MDM, then we select WIP as provided policy for the file encryption and using Setup of Microsoft 365 E3/Business license... and at the result, we should go back to articles to read about EFS :) Maybe some FAQ can be added explaining this? So in the future, other people, who just follow "click next next next", can understand that this will be happening with "preview"...

@lightupdifire Understood, i will think of a note to add to the WIP limitations article. I hope this is ok.

@lightupdifire
With the help of your feedback, the content has been updated with relevant changes accordingly. Thanks.


add planks and lunges

Describe the feature you'd like
A clear and concise description of what you want to happen and why.
Additional context
Add any other context or screenshots about the feature request here.

unit of planks : seconds


⚠ Turnos 24x7 has degraded performance

In 1364495, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 916 ms

Resolved: Turnos 24x7 performance has improved in 95b7491.


[BUG] Incorrect KeyboardButton label

Describe the bug
The label displayed on KeyboardButton is incorrect.
To Reproduce
Steps to reproduce the behavior:

You can copy the snippet code below:

import pytermgui as ptg

with ptg.WindowManager() as manager:

    def handleClick():
        window.close()

    window = ptg.Window(
        ptg.Label("Button Help"),
        ptg.KeyboardButton("Help", lambda *_: handleClick()),
        ptg.Label("Button Test with index 1"),
        ptg.KeyboardButton(
            "Test",
            lambda *_: handleClick(),
            index=1,
        ),
        index=1,
    )

    window.set_title("Error")
    manager.add(window)
    manager.run()

Run program.
See the error.

Expected behavior
KeyboardButton("Help") will look like: "[ (H)elp ]", and KeyboardButton("Test", index=1) will give "[ T(e)st ]" just like in the document:

Screenshots

System information
PyTermGUI version 6.4.0

System details:
    Python version: 3.10.4
    $TERM:          xterm-256color
    $COLORTERM:     truecolor
    Color support:  ColorSystem.TRUE
    OS Platform:    Linux-5.15.0-41-generic-x86_64-with-glibc2.35

No idea how this slipped through, thanks for the shout!


Fixed #29502 -- Allowed autocomplete_fields to function with only view permission to related object

https://code.djangoproject.com/ticket/29502

@codingjoe Could you comment? Ta.
I wondered about having the autocomplete widget provide a better error message than "The results could not be loaded." when we get a 403 — but I didn't look at the JS yet. What do you think?

Can you check if raw_id_fields also works with the view permission?

Thanks for making the edits @timgraham.

Can you check if raw_id_fields also works with the view permission?

Yes. It works perfectly.

No permission: 403 on the pop-up, but if I happen to know the ID creation works as expected.
Only view permission: Pop-up functions as expected. (I can select the related object as needed.)

@carltongibson

I wondered about having the autocomplete widget provide a better error message than "The results could not be loaded." when we get a 403 — but I didn't look at the JS yet. What do you think?

I guess that is possible with a custom transport you can define an a custom error handler and provide a better message. You will need to add your own translations tho :/


feat: automated releases and auto labelling

Part of https://github.com/github/github-ospo/issues/78
Pull Request

Proposed Changes

[x] lint pr title adhering to conventional commits (helps with auto labelling)

[x] Update CONTRIBUTING.md

[x] automated releases
[x] how to file a bug report
[x] how to file an enhancement

[x] Update pull_request_template with new standard

[x] setup autolabelling through release-drafter github action config
[x] create auto-labeler workflow
[x] change release-drafter workflow to release

[x] create release, including new tag
[x] create discussion announcement based on release
[x] build container images, tag them and release them

Manual Actions:

[x] create revert and maintenance labels
[x] put repository and category IDs into secrets for the discussion create action

Readiness Checklist
Author/Contributor

[x] If documentation is needed for this change, has that been included in this pull request
[x] run make lint and fix any issues that you have introduced
[x] run make test and ensure you have test coverage for the lines you are introducing

Reviewer

[x] Label as either bug, documentation, enhancement, infrastructure, or breaking

I think these releases may silently fail on major version changes since we aren't updating action.yaml files. That sound right to you? We can make that a future pr (set of prs) if desired.

yes, currently, we, as the PR reviewers, need to confirm the action.yml was updated if we're going to flag a PR with the breaking label.  We can automate that though.  Definitely a new PR.
Do you think this work is a major version bump?  I haven't been doing that. 😬

No major bump needed for this one, just looking to the future.


rollback Cause cache dirty reading

TransactionalCache rollback() do not execute delegate.clear()
Cause dirty reading

Hello @causeThenEffect ,
We need a test case or demo project that replicates the problem.

sorry，it is a mistake


Mlapson/update deprecated GitHub actions

Summary
Follow-up from https://github.com/Qiskit/qiskit-ibm-runtime/pull/1439 by changing the upload-artifact action to v4 from v3.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.555%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5076

Relevant Lines:
6224

💛  - Coveralls


Can not check in 2.83

the error also occurs in 2.90

Thanks for the report. This is already fixed in the development version of cats.


Extensions with 0 installs should say 0 installs in viewlet

VSCode Version: Code - Insiders 1.6.0-insider (c94c824db64a88bd4909da2e84e44316dbf8e8fb, 2016-09-28T06:23:37.103Z)
OS Version: Linux x64 4.4.0-38-generic, Ubuntu 16.04

#12647
It shows the extension with nothing on the right, why not be explicit?

I do see it though. 😕

Hmm :confused:


Support printing negatives in Kconfig.write_autoconf()

Some forks of the C implementation of Kconfig (notably, used in
coreboot and depthcharge) offer an option to include false values
defined to zero in generated header files.
This adds support for an equivalent feature to Kconfiglib, so it can
be made use of in those codebases.

@ulfalizer can you review?


Support for active_model_serializers

Hi all,
I'm using Neo4j and need to serialise objects and associations for an HTTP API.
The way I do this with ActiveModel-compliant objects is to use active_model_serializers, which doesn't work out-of-the-box with Neo4j Rails.
To get the basic support I need I added the following to an initializer in my Rails app:
Neo4j::Rails::Model.send(:include, ActiveModel::SerializerSupport)
Neo4j::Rails::Relationships::NodesDSL.delegate(:active_model_serializer, to: :to_a)

This is something I'd normally add to the wiki of a project for others to find, but before doing so I wanted to get some feedback on where you think it would be appropriate, if at all.

Hi,
I've tried to follow the steps listed but I think something has changed since this was outlined.
Is there a new solution for using the active_model_serializer gem?
Also, in general, is there a better approach to rendering json?
Thank you


Update diagrams packages

Add new packages: diagrams-cairo, diagrams-gtk, diagrams-rasterific
Delete obsolete package: vector-space-points

Travis, try again, there is gtk-diagrams-<IP_ADDRESS> now.

thank you!


Updated Twitter blur functionality

Todo

[x] Fix Twitter blur functionality by blurring all parts of the tweet
[x] Increase blur to accommodate for video/images

Motivation
Politicry only blurs the text for Twitter. The user is still able to see other parts of the tweet that they may not like to see such as graphic/unwanted video and images
Summary of changes
Changed search to search for each 'article' rather than each 'div[lang="en"]' in extension\public\worker\twitter.js
Attached GitHub issue
Closes #97
Checklist

Documentation

[x] New functions and methods have additional comments added to document their usage

Local Build

[x] Extension has been tested to build correctly cd extension && yarn && yarn build

GitHub

[x] Target branch has been set correctly
[x] PR has been rebased onto target branch
[x] PR has been assigned an owner
[x] Author has performed a self-review of the code
[x] Removed the WIP message from the top of this PR

Note on number of commits: Created a new fork and laptop has no storage space remaining so I cannot install cypress for the repository (so I cant test anything. The only way that I can see if the tests pass is to push to GitHub). Cannot free up any more space - have done so 4 times over the past month.

Nice fix! I've tested it and it works on my side too.
Are you able to lower the blur effect? Previously, it was set to a high value because it wasn't enough to completely blur the text. Now that the whole post is blurred, I don't think we need the blur to be so extreme. You might need to experiment with what blur value works best for both text and image. Alternatively, you could blur these separately.
See comment where this was discussed: #81 (comment)

I purposely increased the blur because the images and videos were not being blurred enough and they were still able to be made out. IIRC instagram is on 30px so its nowhere near as blurry as that (I've set this one to 20px after some playing around with it.) Any less and the image becomes somewhat recognisable.


Add option to only rebuild packages when changed in Emacs

This would help with #9. Probably we should also handle some simple cases like the build directory or repository being deleted, which users might try if they didn't know about straight-rebuild-package.

This is now available; let me know if the new option works for you:
(setq straight-check-for-modifications 'live)

@nico202
@dieggsy
@tummychow

(I'm pinging the people who have commented about the slowness of Emacs init with straight.el, especially on older or embedded systems.)

:+1:, this is a huge improvement for my setup. First load after booting went down to 3s or something thereabouts (from 50+). Thanks.

@raxod502 Indeed this shaves off about a second from my startup time, but it's a little unclear to me exactly what this does or when packages are actually rebuilt?

@dieggsy Instead of detecting modifications using find(1) at Emacs init, modifications are detected by checking buffer-file-name when before-save-hook is invoked in Emacs. When that happens, the name of the repository in which a file was modified is appended to build-cache.el. This information is then used at startup to rebuild the correct packages without having to check at that time. Does that answer your question?
The docstring is reproduced below for the benefit of future visitors.
straight-check-for-modifications is a variable defined in ‘straight.el’.

When to check for package modifications.
Value ‘at-startup’ means do it when straight.el is bootstrapped
during Emacs init. Value ‘live’ means hook into
‘before-save-hook’ to detect modifications as you make them (this
means modifications made outside Emacs are not detected, but
speeds up init). Value ‘never’ means don’t check automatically.
In this case you must use ‘straight-rebuild-package’ whenever you
modify a package, before restarting Emacs.

ah, yeah that clarified it. thanks!


[Bug]: Select widget throws an incorrect error for missing value property

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Select widget throws an incorrect error for missing value property when source data in fact has a valid array. Can be reproduced on a new binding on a new widget too.
Affects view mode too, i.e. widget displays empty data
Steps To Reproduce

Another evaluation issue :
On importing the app, the source data (with server-side data configured) is not getting evaluated
https://www.loom.com/share/3372e61a30b64aa88fa80eb6dac6acf9
Public Sample App
No response
Environment
Release
Issue video log
https://www.loom.com/share/d059cbfff59b43d5b4dfbea9e4007b17?focus_title=1&muted=1&from_recorder=1
Version
Cloud

@Rishabh-Rathod Working fine
screen-capture (3).webm


Rare v2 token not working for settlements

Trades with this token cause settlements to fail: https://blockscout.com/poa/xdai/address/0x57e93BB58268dE818B42E3795c97BAD58aFCD3Fe/contracts.
This issue just captures the work to investigate why, although it is likely for the same reason there are issues with Rare v1.

Difficult to say, as the code is not verified. On tenderly we see:

Maybe some kind of transfer fee when using a relayer. On Honeyswap, I was able to manually swap to wxDAI


Fix build with gcc13

Submission Checklist

[x] Run unit tests: ./runTests.py src/test/unit
[x] Run cpplint: make cpplint
[ ] Declare copyright holder and open-source license: see below

Summary
With GCC 13, some C++ Standard Library headers have been changed to no longer include other headers that were being used internally by the library (see, e.g. this). This has affected many other projects.
I noticed this when trying to run the tests with:
python runTests.py -j$(nproc) src/test
The fix is simple, <cstdint> has to be included manually.
Intended Effect
Fix build with g++13
How to Verify
Run the tests
Side Effects
None?
Documentation
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

@serban-nicusor-toptal any idea why this wouldn't have been caught by the bleeding-edge pipeline?

Oh, something else probably includes cstdint when we're doing complete CmdStan builds, which is why we missed it

Hey, I'm not sure. Just ran a fresh build, making sure everything is built with the latest, and checked versions afterward, looks fine there.

I'm using g++ (GCC) 13.2.1 20230801 with
#-- Compiler and Linker Flags
#CPPFLAGS=""
CFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions \
        -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security \
        -fstack-clash-protection -fcf-protection"
CXXFLAGS="$CFLAGS -Wp,-D_GLIBCXX_ASSERTIONS"
LDFLAGS="-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now"
LTOFLAGS="-flto=auto"

Oh, wait... I just realized that the python script is downloading from https://github.com/stan-dev/stanc3/releases/download/nightly/linux-stanc instead of using the compiled ones. So I cannot use that in my PKGBUILD.
Let me rerun the tests manually.

This is probably a different question/issue, but what is the right way of compiling CmdStan and run all tests (including stan and stan_math) with the binaries that were generated when compiling CmdStan (and not precompiled ones from Github). I think the issue is that the Makefile in (stan/make/tests) does not try to use the binaries in the parent folder (cmdstan/bin).

It looks like this is also an issue with clang++-17. I just had a CRAN submission fail with this error on Debian & Clang 17:
clang++-17  -std=gnu++17 -I"/home/hornik/tmp/R/include" -DNDEBUG -I"../inst/include" -D_REENTRANT -DSTRICT_R_HEADERS -D_HAS_AUTO_PTR_ETC=0 -DEIGEN_PERMANENTLY_DISABLE_STUPID_WARNINGS -I'/home/hornik/lib/R/Library/4.4/x86_64-linux-gnu/Rcpp/include' -I'/home/hornik/lib/R/Library/4.4/x86_64-linux-gnu/RcppEigen/include' -I'/home/hornik/lib/R/Library/4.4/x86_64-linux-gnu/BH/include' -I'/home/hornik/lib/R/Library/4.4/x86_64-linux-gnu/RcppParallel/include' -I'/home/hornik/lib/R/Library/4.4/x86_64-linux-gnu/rapidjsonr/include' -I/usr/local/include -DUSE_TYPE_CHECKING_STRICT -D_FORTIFY_SOURCE=3   -fpic  -g -O3 -Wall -pedantic -c model_methods.cpp -o model_methods.o
In file included from model_methods.cpp:1:
In file included from ../inst/include/stan/io/json/json_data.hpp:4:
In file included from ../inst/include/stan/io/json/json_data_handler.hpp:5:
../inst/include/stan/io/json/json_handler.hpp:97:38: error: unknown type name 'uint64_t'
   97 |   virtual void number_unsigned_int64(uint64_t n) {}

@serban-nicusor-toptal how hard would it be to add the Stan unit tests to our bleeding-edge-compilers pipeline? So it would be Math unit (gcc/clang) -> Stan unit (gcc/clang) -> building a bunch of models (gcc/clang)

@serban-nicusor-toptal how hard would it be to add the Stan unit tests to our bleeding-edge-compilers pipeline? So it would be Math unit (gcc/clang) -> Stan unit (gcc/clang) -> building a bunch of models (gcc/clang)

Should be fairly simple I hope, will give it a try this weekend.


Use filtersjs as a MySaaS extension.

Add the app.rb file.
Setup extension.rb to add a link to /developers/selectrowsjs/example.html in the footer of MySaaS, in the section Developers.
Setup extension.rb to call the file selectrows.min.js when load a page of MySaaS.
Remove the hard-coded call to filers.min.js from MySaaS.
Add the extension in the config.rb of your MySaaS project, and test it in the /leads/results screen.
Add a new section #. Using Filters.Js as a [MySaaS](https://github.com/leandrosardi/mysaas) Extension in the README.md file of the filtersjs project. There, explain how to add filters.js as an extension of MySaaS.
Here is a good example that you can follow: https://github.com/leandrosardi/leads#1-getting-started.

Done.


max pooling accepts kernels which are too big

If I set the kernel to be bigger than the dimension size in python, it just reduces that dimension to 1. I presume this works correctly for max pooling (though perhaps doing more calculations than necessary?), but it might mess up average pooling. Regardless, it should probably raise a warning/error to let the user know the dimensions mismatch.

here is code in infershape:
    oshape[2] = std::min(dshape[2] + 2 * param_.pad[0] - param_.kernel[0] + param_.stride[0] - 1,
                         dshape[2] + 2 * param_.pad[0] - 1) / param_.stride[0] + 1;
    oshape[3] = std::min(dshape[3] + 2 * param_.pad[1] - param_.kernel[1] + param_.stride[1] - 1,
                         dshape[3] + 2 * param_.pad[1] - 1) / param_.stride[1] + 1;
    CHECK(oshape[2] > 0 && oshape[3] > 0) << "Pooling: kernel size exceed input";

Looks like it crashes in this case unless pad is big enough. Are you padding?

I'm using the default pad.

That's strange. It should have crashed. Could you print something before src/operator/pooling-inl.h:183 and check if there are anything wrong?

any progress on this thread? please reopen if there is update


populate fields selection

Hey,
Using mongoose-paginator for pagination. while using with populate method how can i select the fields i want to from populate fields.
userContent.paginate({},{lean:true,populate:['user_id']}).
I want to select fields from populated collection

Hi! You can specify object with options for populate http://mongoosejs.com/docs/api.html#document_Document-populate

Thanks. For help @Jokero


fix: redraw issue with virtual scroll while dragging scrollbar

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
https://code.siemens.com/simpl/simpl-element/-/issues/401
What is the new behavior?
User will not have to explicitly move scrollbar to see blank rows updated after doing scroll
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Hi @timowolf , @fh1ch  Kindly take a look at this PR
Thank you

@chintankavathia Many thanks for the great contribution


Default table action configuration

I don't understand the motivation... looping through every action every time to replace a simple ?? 🤔

This PR is still very WIP and experimental, @danharrin. 😄
The purpose is the following:
Currently, actions in the table package are configured to be links and size sm by default.
Design-wise, the empty state actions should be md and button instead.
This PR aims to find a way to configure these default sizes when the action has no size set explicitly (null).

Thoughts, @danharrin?

I think this work should be done in the setters which contains some similar logic like passing ->table() I think.
Also you need to pass link() to the row actions.

Yeah, but the issue with moving it to the setter would be that it's hard to override the default size and such, right?

By the time the setter is run, the action is set up, so the null check will still work.

I think that maybe instead of the null check, we introduce a new defaultSize() method and property which is then used inside getSize()

Sounds interesting! Do you want to set up a POC in this PR?
I can work it out after that.

Replaced by #5792


Do you any algorithm in Lua?

Hi, everyone!

Do you know any algorithm implementation in any language, that you wanna share with us?

Open a pull request in any of the programming languages available, or in Lua this case

I'm implementing a few algorithms here for this repo. I may send a PR in the weekend.
Intended algorithms:

Bubble Sort
Selection Sort
Merge Sort (alternative implementation)
Quick Sort
Range Sum


Optimize Chef::CookbookSynchronizer#remove_deleted_files

Description
The existing implementation of the remove_deleted_files method is inefficient on large numbers of cached files.
As an example, assume you have 100 active cookbooks with 25 recipes each. In the old code, this meant:

cookbook_segment called 2500 times (which isn't cheap, see files_for)
manifest_segment.select bit means 2500 array creations, with 25 manifest_record comparisons for every file (62,500 total)

The proposed new version:

cookbook_segment called 100 times
manifest_record_paths has 100 array creations
to_be_removed has 100 arrays created, 100 array comparisons

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

@jaymzh since you commented and the most recent changes are in response to your comment, can you please review again?

The only failing test was the Sonar one which doesn't work for external (fork-based) contributions.
Nice work @dafyddcrosby , thanks!


Invalid value "OriginIssuer"

With cert-manager in version v1.10.0 cert-manager-controller throws the following error, certs are successfully issued though.
The issuerRef.kind requirements have changed.
E1031 19:23:01.329393       1 checks.go:95] cert-manager/controller/certificaterequests-issuer-selfsigned/handleSecretReference "msg"="failed to get issuer" "error"="invalid value \"OriginIssuer\" for issuerRef.kind. Must be empty, \"Issuer\" or \"ClusterIssuer\"" "resource_kind"="Secret" "resource_name"="server37-k9rtd" "resource_namespace"="default" "resource_version"="v1"

Do you have an example of what you're doing? As best I can tell the requirements have not changed.,

Using annotations on the Ingress object:
metadata:
  annotations:
    cert-manager.io/issuer: origin-issuer
    cert-manager.io/issuer-group: cert-manager.k8s.cloudflare.com
    cert-manager.io/issuer-kind: OriginIssuer

Cert-Manager logs:
E1102 17:44:21.342458 1 checks.go:95] cert-manager/controller/certificaterequests-issuer-selfsigned/handleSecretReference "msg"="failed to get issuer" "error"="invalid value \"OriginIssuer\" for issuerRef.kind. Must be empty, \"Issuer\" or \"ClusterIssuer\"" "resource_kind"="Secret" "resource_name"="my-cert-origin-cert-ltvz2" "resource_namespace"="my-cert-test" "resource_version"="v1"

That looks correct to me. AFAICT, I have nothing to do with this code path. Do you by chance have a SelfSigned Issuer configured in this cluster?
@JoshVanL Based on the error message here, this looks to be a regression caused by https://github.com/cert-manager/cert-manager/pull/5336. WDYT?

That looks correct to me. AFAICT, I have nothing to do with this code path. Do you by chance have a SelfSigned Issuer configured in this cluster?

No, I only have a ClusterIssuer and an OriginIssuer, which both use Cloudflare.

@JoshVanL Based on the error message here, this looks to be a regression caused by cert-manager/cert-manager#5336. WDYT?

Even if I rollback cert-manager to an earlier version, my certificates still don't seem to get verified.

my certificates still don't seem to get verified

This is likely an unrelated issue. The OP reported that despite this issue the certificates issued just fine (which makes sense, the self-signed issuer is the one complaining here).

As mentioned above, I believe this is a bug in cert-manager, where the selfsigned controller is looking resources it's not responsible for managing, then logging an error. I plan on opening a bug there with more information.

I think we already have a relevant bug open on cert-manager: https://github.com/cert-manager/cert-manager/issues/5601
This is a confusing log message which shouldn't be printed - but issuance shouldn't ever be affected by this as far as I understand! :grin:

Closing because IR was fixed upstream in 1.11.0. Thanus for the PR there @SgtCoDFish.


Added rule: declaration-colon-newline-after

Added rule: declaration-colon-newline-after with option always-multi-line

Groovy.


UML

Document your initial object-oriented analysis and design using a UML class diagram (or diagrams), focusing on the most important anticipated classes, interfaces, and relationships. Include detail on key attributes and methods. Include notes on the use of design patterns among the classes. Add notes if the purpose of a class or interface is likely not clear to an outsider. The diagram(s) may be reverse engineered from the code, but must be edited, arranged, and selective (not a raw dump). The diagram(s) must be neat and tidy, and drawn well using tools like eUML2 and dia and embedded as image(s) in your team wiki.

A list of the classes currently implemented in our code that I think needs to be in the UML:
User List
User
Claim list
Claim
Expense List
Expense Item
Amt - Currency
Any others???

FYI. I will be working on user list and user.
The URML diagram will be created using DIA, and I will upload the dia files to the google drive one its finished. (and image to the wiki)

Since all the models inside an UML diagram are closely coupled, all the models above need to be connected inside one single UML diagram.
In order for use to do this we need to use the same software, and copy paste them onto the same file.
So make sure to use DIA, so we can merge the diagram later.

why don't we just use the built-in eclipse extension to make the diagram? it will do it for us and all we have to worry about is formatting it. i think it will be better. I can do it in 30 sec on my computer. I think it is better than having all different diagrams to merge. if we do it with eclipse, we can do it on Tuesday at our meeting( I will bring my laptop) and I can show you how to do it. we can then edit it and it will create a separate UML file.  There is no need to complicate things.  What do you guys think?

i will do Claim and ClaimList then.
Make sure we send everything to Jim so he can put everything together afterwards

My email<EMAIL_ADDRESS>

make sure we are not adding any unnecessary getters and setters in the UML. it should only include add/remove/boolean methods. otherwise it will get really cluttered

Should we worry about listeners in the UML?

Uh, is there anything I can do with the UML?

Could you maybe do the storyboard? That would be useful.

yep. I can work on that.

When I was rereading the USs about tags it seemed like the list of tags should be independent of each individual claim, so that when assigning tags to a claim they are just chosen from a previously created list of tags.To fit this model I added a button on the ClaimList page so that the user could add/remove tags from a tag list. This seems to fit better with US03.02. What do you think?

Just make a list as an attribute in the claim class.  That would solve all
the problems of not sharing tags
On Feb 22, 2015 5:43 PM, "vanbelle"<EMAIL_ADDRESS>wrote:

When I was rereading the USs about tags it seemed like the list of tags
should be independent of each individual claim, so that when assigning tags
to a claim they are just chosen from a previously created list of tags.To
fit this model I added a button on the ClaimList page so that the user
could add/remove tags from a tag list. This seems to fit better with
US03.02. What do you think?
—
Reply to this email directly or view it on GitHub
https://github.com/CMPUT301W15T12/C301Project/issues/16#issuecomment-75475815
.

But that wouldn't work in the case where a tag is created but not associated with a claim

Why I mean is add a tag to the claim taglist every time you associate one
with it. Other than that it stays in 'storage'  in the taglist class
On Feb 22, 2015 5:57 PM, "vanbelle"<EMAIL_ADDRESS>wrote:

But that wouldn't work in the case where a tag is created but not
associated with a claim
—
Reply to this email directly or view it on GitHub
https://github.com/CMPUT301W15T12/C301Project/issues/16#issuecomment-75476555
.

ok, that makes more sense. In that case though we will need to add a class Tag List to the UML.


Package updgrade fixes

Fixed pushed change
For point 1 PR: https://github.com/ello/webapp/pull/552
For point 2 PR: https://github.com/ello/webapp/pull/550

@ansh-k Looks much better now. Can you please merge the relevant PRs so that I can review them once more?


Get Layout string as it is, not rendered one

Question

NLog version: 4.2.3
Platform: .Net 4.5
Is there any API method that returns Layout as it is, not rendered value.
var runningNLogConfig = NLog.LogManager.Configuration; // running configuration
runningNLogConfig.AllTargets.Where(t => t is NLog.Targets.FileTarget).ToList().ForEach(t =>
{
  NLog.Targets.FileTarget fileTarget = t as NLog.Targets.FileTarget;
  string filename = fileTarget.FileName.ToString(); // works ok, returns in my case: "D:\\${date:format=yyyy-MM}\\${date:format=dd-MM-yyyy}_log.txt"

FileName.ToString() returns what I need, but is this correct approach?

you need fileTarget.FileName.Render(...)

One solution is to cast it to SimpleLayout which has method OriginalText. Of course if default layout is SimpleLayout, which I suppose it is.

Yes, that is what you need.
All Layoutable properties of a target are SimpleLayouts

By all target you mean also DatabaseTarget, SmtpTarget. . . all targets that exist in NLog.Targets namespace ?
Just curious how come this is allowed:
t.CommandText = "insert into logevent .  ."; // CommandText is of type NLog.Layouts.Layout```

How can string be accepted as layout. Does c# makes this transformation or does NLog implement such convertion (some method that handles this: if typeof string returm new SimpleLayout...)

Yes I mean a properties (with type layout)  of all targets like file, database. All of them are in the that namespace indeed.
The string to layout is an implicit conversion. A c# feature.  :)

Thank you for pointing to source code. I see now, it creates SimpleLayout, thank you.


Error running command: colmap feature_extractor --database_path

Thank you very much for this great work, I ran into a problem when I used my own dataset, which is more than 700 images, using colmap to convert to nerfstudio format when reporting this error, if you can help me, would be very grateful

Can you try running colmap -h in terminal? this usually means that a colmap version without GPU support was installed.

Thank you for the answer, I installed colmap according to the official process, and then this should show that CUDA is not enabled, how should this be solved, is it because of the problem of CMAKE_CUDA_ARCHITECTURES=70 I set when compiling? My graphics card is 1080ti

You might have more luck on the discord / colmap github on installation issues. A quick fix for now is to use the --no-gpu flag in the ns-process-data command. This will slow down processing, but should still work.

I installed colmap according to the official process, and then this should show that CUDA is not enabled, how should this be solved, is it because of the problem of CMAKE_CUDA_ARCHITECTURES=70 I set when compiling? My graphics card is 1080ti

Thank you for your answer, it's still too slow without GPUs, I'll go to the colmap community for answers

You might have more luck on the discord / colmap github on installation issues. A quick fix for now is to use the --no-gpu flag in the ns-process-data command. This will slow down processing, but should still work.
I used "--no-gpu" but still get an error, what's going on


feat: l2 metrics service

🤖 Linear
Closes ZKS-228
Description

L2MetricsService implementation on metrics package
add zk provider method for fetching blocks range for a given L1 Batch

as discussed offline @0xkenj1, we let the service consumer handle errors instead of returning undefined for consistency


[Event Hubs] Documentation Updates

Summary
The focus of these changes is to add context for processor behaviors regarding how load balancing interacts with consumer groups and storage.  Also included are fixes for spelling, typos, and formatting in other docs.

API change check
API changes are not detected in this pull request.


Create generate_VC functionality

Create Generate VC Template functionality within TEE (See Identity Quest section below for more information)
generate_VC should accept the following params:

ruleset-id
idhub-address
params (Optional JSON payload)

If it refers to the VC-generation extrinsic, it's already done in the vc-management pallet.
If it means the generation of the JSON-format VC with concrete fields, it's superseded by #72 (which is assigned to @jingleizhang as he designs the VC content)
Close this ticket for now.


write_to_file tool fails when inline comments are detected in code (and sometimes not)

Which API Provider are you using?
Anthropic
Which Model are you using?
Claude 3.5 Sonnet
What happened?
Code suspected of causing the error below:
interface ViewportPriority {
    visible: number      // Currently visible content
    adjacent: number     // Content just outside viewport
    cursor: number       // Content around cursor
    recent: number       // Recently edited content
}

(1)

[write_to_file for 'proposed_CurrentState.md'] Result:
The tool execution failed with the following error:
<error>
Content appears to be truncated. Found comments indicating omitted code (e.g., '// rest of code unchanged', '/* previous code */'). Please provide the complete file content without any omissions if possible, or otherwise use the 'apply_diff' tool to apply the diff to the original file.
</error>

Next attempt:
(2)

<thinking>
I apologize for any confusion. The content I provided was actually complete - it didn't have any truncated sections or omitted code. Let me try writing the file again with the exact same content.
</thinking>
<write_to_file>
<path>proposed_CurrentState.md</path>

The above steps 1 & 2 are repeated 2x. Then the following starts:

Assistant:
 <thinking>
I notice that the error might be triggered by the inline comments in the ViewportPriority interface. Let me modify those to be more descriptive field names instead of using comments.
</thinking>
 <write_to_file>
<path>proposed_CurrentState.md</path>

The suspected culprit is simplified to remove comments:
interface ViewportPriority {
    currentlyVisibleContentPriority: number
    adjacentContentPriority: number
    cursorProximityPriority: number
    recentlyEditedPriority: number
}

But...then this happens again:

User:
[write_to_file for 'proposed_CurrentState.md'] Result:
The tool execution failed with the following error:
<error>
Content appears to be truncated. Found comments indicating omitted code (e.g., '// rest of code unchanged', '/* previous code */'). Please provide the complete file content without any omissions if possible, or otherwise use the 'apply_diff' tool to apply the diff to the original file.
</error>

Eventually, after a few more attempts, Cline is able to pick an approach that succeeds (by re-reading the file itself to find line numbers).
I think the original issue was the inline comments, but I looking at its logic I don't think Cline is refreshing a document's line numbers (or context in general) after applying changes - leading it to see and receive conflicting versions of files to work with.
Steps to reproduce

Ask Cline to create a document (.md)
Ask it to use either write_to_file or apply_diff to insert code with inline comments (// inline comment) into the new doc
Example code:

interface ViewportPriority {
    visible: number      // Currently visible content
    adjacent: number     // Content just outside viewport
    cursor: number       // Content around cursor
    recent: number       // Recently edited content
}

Relevant API REQUEST output
No response
Additional context
Related to this issue, it looks like none of those errors/failures are reported in the GUI as errors - just Cline talking to itself.

Not sure if it's working as intended or not, but figured I'd toss it in here too.

Looks like this may be related to (or a dupe of) #131 .

@ryanjoachim any chance you can upload the export of that chat as a gist? I wonder if there's something wrong with https://github.com/RooVetGit/Roo-Cline/blob/eab4a80981c5bf360a1e77e0037b11de3a2dd777/src/integrations/editor/detect-omission.ts#L12

Your code does include "content" in a comment 🤔

I'm not able to easily repro in my unit tests, but I wonder now if it has something to do with the data streaming in and us constantly evaluating this.

 Thank you!


IntelliJ IDEA module dependency instructions

IntelliJ 14 didn't know how to handle dependencies/imports based on the project generated by gen-idea.

Hi @jballer,
I have tested with IntelliJ 14 again and it worked fine.
Could you try importing a fresh new IDEA project? (to make sure the errors you see are not due to running gen-idea multiple times which might have generated a wrong idea config):
Inside IntelliJ, delete play-with-scalajs-example, then
$ cd play-with-scalajs-example
$ rm -r .idea/ .idea_modules/
$ sbt gen-idea
Inside IntelliJ, File/Open..., choose play-with-scalajs-example to import all the projects

Odd. I don't know what was wrong the first time, but subsequent removal and gen-idea worked. Thanks for looking into it!

FYI, I've found with IJ 14.0.3 and latest scala plugin, I can just import top level folder and everything works. No use of gen-idea at all.

:+1:


⚠ ClamAV has degraded performance

In b7f0aa5, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 52 ms

Resolved: ClamAV performance has improved in f4d83db after 14 minutes.


Supersede specialized messages with CloudMessage

Result of a conversation with @artaex at https://gitter.im/kreait/firebase-php ^^
:octocat:

I'm happy with these changes!

Merged with 0bdb3245e54c15ba39742b7ba5584a1bc8550c4e

Released with 4.14.0


License for Open Source Software Protection?

Hi @headkaze !
I'm so excited that Hackintool is finally an open-source software!
I think it's better to have a license (GPL, BSD, etc) to protect this wonderful project.
:P

:)


Improve deserialization errors of untagged enums

What does this PR try to resolve?
# .cargo/config.toml

[http]
ssl-version.min = false

Before:
$ cargo check
error: data did not match any variant of untagged enum SslVersionConfig

After:
$ cargo check
error: error in /path/to/.cargo/config.toml: could not load config key `http.ssl-version`

Caused by:
  error in /path/to/.cargo/config.toml: `http.ssl-version.min` expected a string, but found a boolean

How should we test and review this PR?
The first commit adds tests showing the pre-existing error messages — mostly just "data did not match any variant of untagged enum T" with no location information. The second commit replaces all #[derive(Deserialize)] #[serde(untagged)] with Deserialize impls based on https://docs.rs/serde-untagged/0.1, showing the effect on the error messages.
Tested with cargo test, and by handwriting some bad .cargo/config.toml files and looking at the error produced by rust-lang/cargo/target/release/cargo check.

Thanks!  I'm assuming this will also offer some (slight) performance improvements based on my own profiling with untagged.
@bors r+
Any thoughts on adding derive support for this?

:pushpin: Commit 3871aecf3e8c2a830997a26179278aef3f90568d has been approved by epage
It is now in the queue for this repository.

:hourglass: Testing commit 3871aecf3e8c2a830997a26179278aef3f90568d with merge 97e73c75c7494115492375fb629315cbaf8b3b38...

Yeah we could potentially add derive support by having the call site tag the type of each of the variants.
pub enum SslVersionConfig {
    #[serde(string)]
    Single(String),
    #[serde(map)]
    Range(SslVersionConfigRange),
}

:sunny: Test successful - checks-actions
Approved by: epage
Pushing 97e73c75c7494115492375fb629315cbaf8b3b38 to master...


Pass dialog instance to onIconDialogIconsSelected

Would it be possible for you to change onIconDialogIconsSelected so it has the dialog arguments/instance as a parameter?
I'd like to show icons in a RecyclerView. When the user clicks on the icon it should open the icon dialog to set/change it and on the callback I'd like to know which item was clicked on so the list can be updated. I was planning to use setArguments() and getArguments() to set the ID of the item or something like that.

Yes I can add that parameter.
I would suggest just saving the position of the clicked icon in your fragment/activity/presenter/etc and use it to change the drawable when an icon is selected.

Sure, there are workarounds for this but with that parameter, it could be much simpler and cleaner, I guess. Thanks for considering this.

This is added in v2.4.0

Thank you.


KAFKA-16068: Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin scanning errors

Jira
The ConnectorValidationIntegrationTest creates test plugins, some with erroneous behavior. In particular:
[2023-12-29 10:28:06,548] ERROR Failed to discover Converter in classpath: Unable to instantiate TestConverterWithPrivateConstructor: Plugin class default constructor must be public (org.apache.kafka.connect.runtime.isolation.ReflectionScanner:138) [2023-12-29 10:28:06,550]
ERROR Failed to discover Converter in classpath: Unable to instantiate TestConverterWithConstructorThatThrowsException: Failed to invoke plugin constructor (org.apache.kafka.connect.runtime.isolation.ReflectionScanner:138)
java.lang.reflect.InvocationTargetException

I found 4 methods with erroneous behavior:

testConnectorHasConverterWithNoSuitableConstructor()
testConnectorHasConverterThatThrowsExceptionOnInstantiation()
testConnectorHasHeaderConverterWithNoSuitableConstructor()
testConnectorHasHeaderConverterThatThrowsExceptionOnInstantiation()

These plugins should be eliminated from the classpath, so that the errors do not appear in unrelated tests. Instead, plugins with erroneous behavior should only be present in the TestPlugins, so that tests can opt-in to loading them.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

This has been superseded by #16647 and so is no longer necessary.


:book: Deploy most recent release documentation as 'latest' alias

Summary
I noticed that on https://docs.kcp.io, the "default" release (the release you get when going to https://docs.kcp.io/kcp/) points to 0.11. The reason for that is that the "default" release was set at some point manually, but it was never automated.
This PR:

tries to figure out if the pipeline is running for the latest released version series (e.g. v0.23 at the moment)
if so, updates a version alias "latest" to the version while deploying
ensures that the default version points to the "latest" alias

Related issue(s)
Fixes #
Release Notes

NONE

This should be ready for review now.

/cc @xrstf

/approve

/lgtm


Fix JSON object store

Changed the type of EphemeralObjectStore.slabs to map[string]refSlab. The JSON object store was not persisted because slab.EncryptionKey did not implement encoding.TextMarshaller. There was an additional reference issue between the slabs map and refObject.SlabID after reloading the store if left as a slab.EncryptionKey.

ah, I see. Honestly, using EncryptionKey as the slabID is kind of a hack; it's just a convenient way of getting a unique ID for the slab. Key material probably shouldn't be used as a map key, since that will create copies of it -- and preventing copies is why I made entropy a pointer in the first place! That said, I think it's ok to play more fast-and-loose with these keys, because objects have a second layer of encryption anyway. So maybe changing entropy to a non-pointer is the way to go.


Segmentation fault

Note: This is just a template, so feel free to use/remove the unnecessary things

Type: Bug

Expected Behavior
npm run dev should start the dev server without any issues
Actual Behavior
sh: line 1: 78600 Segmentation fault: 11  npm run babel-node -- server/index.js
[nodemon] app crashed - waiting for file changes before starting...

Steps to Reproduce
So I upgraded to node 6, and that might be what is at the root of this, because I have been getting some other strange behavior, but occasionally when come back to my project and start it up I occasionally get this Segmentation fault error.
I did some Googling and found this issue in the node repo, so I did what it said, and killed my modules and reinstalled. Which fixes it, but is a pain to have to do once or twice a day. Has any one else be having this issue?

bumped kerberos (which was segfaulting for me)
npm i after grabbing this change and let me know if it is fixed

ok ill pull the latest and keep you updated. Hopefully that should clean up the stack traces that keep clogging up my terminal.


Release Google.Cloud.Language.V2 version 1.0.0-beta01

Changes in this release:
Initial release.
PiperOrigin-RevId: 555681517

Created release for Google.Cloud.Language.V2-1.0.0-beta01

Looks like we're still waiting for full roll out - will retry periodically.


Request for Changelog Entries Regarding Minimum/Supported Ruby Versions

The CHANGELOG mentions version 4 dropping support for Ruby 1.8.  It would be helpful to have this information for other changes in supported Ruby versions, to allow us to more easily find a usable version prior to upgrading to Ruby 3.x.
It would also be helpful to include a mention of the current requirement in the README.
Thanks!

I have only personally released versions 5.0.0 and up, and only used those versions with Ruby 3.0 and up. It worked for me, but it may not work for you. I have no information about versions before 5 beyond "they didn't work for me on Ruby 3".
No Ruby version (or anything else, for that matter) is officially supported—you get what's in the repo, and pull requests are welcome if you need to make changes for it to work for you.