Optimize wording of FAQ "What do the exposure check logs show?"

Website URL Path: https://www.coronawarn.app/en/faq/#keys_matches
Line / Paragraph:
Question:

It is a common misunderstanding - at least for German speaking users - to assume that the number below the "Exposure checks" is the number of people you met the past 14 days.

See e.g. Twitter
I am assuming - please correct me! - that the wording on that page is created by Google, thus out of direct reach for us.
Even if so, we could still improve FAQ entry What do the exposure check logs show. Do you agree on the following?

Introduction

The exposure check logs show how many keys that report a positive test result are downloaded from the server, and how many of them are matching the keys that your phone has collected. For infos about the app flow, see How do you get information about a risk of infection? for details.

Well, no. The number on the "landing page" is only the number of the "check packages". Each package contains thousands of keys and does not indicate any number of people involved since each person is represented by multiple keys. It must be stated that the number on the landing page does not tell anything about the number of people someone has met.

Missing hint how to reach the following captions
It should be mentioned, that tapping on "Exposure checks" will open the exposure log, were you can inspect each package.

I am assuming - please correct me! - that the wording on that page is created by Google, thus out of direct reach for us.

Your assumption is correct.

Missing hint how to reach the following captions
It should be mentioned, that tapping on "Exposure checks" will open the exposure log, were you can inspect each package.

This would surely nice to be included, the question is if this is on every Android Version, which supports ENF the same or if this behavior is different on different versions (cc @daimpi).

Introduction

The exposure check logs show how many keys that report a positive test result are downloaded from the server, and how many of them are matching the keys that your phone has collected. For infos about the app flow, see How do you get information about a risk of infection? for details.

Well, no. The number on the "landing page" is only the number of the "check packages". Each package contains thousands of keys and does not indicate any number of people involved since each person is represented by multiple keys.

Just so everyone is on the same page what we're talking about here, the number on the landing page looks like this in Android (btw. @Ein-Tim is there a similar number in iOS?):

Tbh: I don't think the introduction of this FAQ entry refers to this number, but rather tries to make a more general statement what kind of information can be found in the EN log.
The meaning of this number is described in the "Exposure checks" section of this FAQ entry, which makes sense given that this number is found right where it says "Exposure checks":

For each day, there is an entry for each of the last 14 days, see My exposure log shows multiple, simultaneous checks for exposures.

Although I've to admit that this description is also not entirely clear. It would be easier to understand if it could explicitly say something about this number like "therefore your log will contain 14x14=196 checks". But unfortunately this will almost never be true because

Google actually shows/counts checks performed for more than the past 14 days
even if they only counted the past 14 days there will be quite some ppl for whom this number is higher/lower b/c of issues like API 39508 and failing background checks.

It is a common misunderstanding - at least for German speaking users - to assume that the number below the "Exposure checks" is the number of people you met the past 14 days.
[…]
It must be stated that the number on the landing page does not tell anything about the number of people someone has met.

I agree with this idea. I've also encountered a fair share of ppl who mistook this number for the number of ppl they met over the past 14 days. In such cases I usually tell them that this information cannot be known by CWA or ENF because the pipeline was designed with "privacy by design" in mind and link them to my summary here.
Maybe a sentence could be added to the "Exposure checks" section of the FAQ entry? Something along the lines of "Note: the number shown here is in no way related to the number of people you met over the last 14 days."? What do you think?

Missing hint how to reach the following captions
It should be mentioned, that tapping on "Exposure checks" will open the exposure log, were you can inspect each package.

This would surely nice to be included, the question is if this is on every Android Version, which supports ENF, the same or if this behavior is different on different versions (cc @daimpi).

Yes I also agree that this would be a nice addition. And yes: afaik this looks the same for all Android devices running ENF.

Just so everyone is on the same page what we're talking about here, the number on the "landing page" looks like this in Android with English language settings (btw. @Ein-Tim is there a similar number in iOS?)

No, there is nothing like this in iOS @daimpi (in the Versions >iOS 13.7 there was a number which showed how many new files were downloaded in the last 24 hours, but iOS 13.7 and above don't show this anymore)

Thanks for your comments.
We also had a couple of users from the store community that raised the same question. So this is indeed something that needs a better explanation.
New wording is already in progress.
Best regards
Corona-Warn-App Open Source Team

As this will also be updated by Google soon, we will only add a short explanation and not change the complete FAQ-entry.
https://www.coronawarn.app/de/faq/#keys_matches
https://www.coronawarn.app/en/faq/#keys_matches
Pls. replace the explanation in the yellow-highlighted section:

DE
Dieser Wert gibt nicht die Anzahl der Begegnungen wieder.  Das Auswählen eines Eintrages führt zur Detailansicht mit den entsprechenden Zeitstempeln und der Anzahl der abgeglichenen Schlüssel.
EN
This value does not reflect the number of encounters. Please tap one level further: This is where the checks of up to 15 days are logged (today plus the last 14 days). Selecting an entry leads to a detailed view with the corresponding time stamps and the number of matched keys.


Remove a few useless cpp files from standard build

These files can not be built using MSVC, and they don't seem to be used on a UNIX-y build either, so I disabled them completely.
But since I can not test Android, if they are needed there, please tell me and I will add them back with a small if…

Hey, thanks for taking the time @pinaraf . It seems is crashing only in the test void test_documentDeletion();. So I am merging now and I am going to create a separate ticket for this. Awesome work.

Hi
That crash is quite weird.
As posted in https://github.com/paulovap/qtpdfium/issues/17 it was working flawlessly on my setup (Windows 7 + VC++14).
If I find any way to reproduce that crash, I'll look into it.


🐛 Fix adding sections to hidden needs

Previously hidden needs would not be added to the doctree. However, this meant that the add_sections transform did not add section related fields to the needs data.
This caused errors in the docs builds when filters required these fields.
The needs node is now created in the doctree, but marked with a hidden attribute, and these nodes are skipped in removed before the HTML/LaTeX rendering.

Note there is currently, I feel, a confusing behaviour in the nodes info:
the "hide" boolean field can be set, by the :hide: directive option ✅,
but there is also a "hidden" field that is set by: https://github.com/useblocks/sphinx-needs/blob/a16fb72d44b2c9f65c4065e386e2ad37d0a25870/sphinx_needs/needs.py#L583
this is never used though, so I don't see why it is there 🤔

I'm not a big supporter of the visitor functions, as this is a builder-specific implementation. So other builders are not supported out of the box. Sphinx-Needs tries to avoid this; in my experience, this can become a maintenance hell.
For instance, I know that these kinds of builders are used with Sphinx-Needs as well:
json, Confluence, text
Is there any chance to get it done without visitor-specific functions?

I'm not a big supporter of the visitor functions, as this is a builder-specific implementation.
Is there any chance to get it done without visitor-specific functions?

Good point @danwos, I've moved it to a doctree-resolved event, does this look better

as I have the feeling that its implementation is quite slow and walking the whole doctree is somehow inefficient

Now skipping doctree walks with no needs: https://github.com/useblocks/sphinx-needs/pull/995/commits/cc6d3c1287ff6dfe9d58dad296bb426be8975920
But for sure could be improved later


feat: Added first version of a CI-focused testing pipeline

Description

Added first version of a CI-focused testing pipeline

Runs by default once a week - and for every merge to main if utilities are changed

Added test script for resource sorting script

The idea is to build atop this initial setup with future tests and as such enable regression tests
Pipeline Reference

Pipeline

Type of Change

[x] Update to CI Environment or utilities (Non-module affecting changes)
[ ] Azure Verified Module updates:

[ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:

[ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
[ ] Breaking changes and I have bumped the MAJOR version in version.json.
[ ] Update to documentation

@AlexanderSehr can you resolve the conflict?

@AlexanderSehr can you resolve the conflict?

done


importlib-metadata 2.x works

The major version needs to remain constrained.

@kislyuk this could have easily been a comment telling @swills what to do -- this is pretty poor form especially because you essentially took the patch and applied it yourself :( https://github.com/kislyuk/argcomplete/commit/cc3be4f681cf7ba2e79084f936c6eb635fe2ce84

@asottile I appreciate your feedback.


.gitignore not found in published tool

npm converts all .gitignore files to .npmignore files (including the one in src/res/ which is simply a template for the new projects.

This also can interrupt the copying of app.js causing it to be empty


feat(icons): Add logout, run, sparkles, tablet & volume-alert icons

Changes description
Closes https://github.com/Decathlon/vitamin-android/issues/150
Context

Checklist

[x] Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
[x] Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
[x] Check your code additions will fail neither code linting checks.
[x] I have reviewed the submitted code.
[x] I have tested on a phone device/emulator.
[ ] I have tested on a tablet device/emulator.
[ ] I have tested on a large screen device/emulator.
[ ] If it includes design changes, please ask for a review with a core team designer.

Does this introduce a breaking change?

[ ] Yes
[x] No

Screenshots
Phone

Tablet

Large screen

Other information

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/62ac2962b2dd627a/build/02a36374-e20d-493b-8ad6-fd2794806068/artifact/fef5f9610e5a55c7/p/8910c42c853a570a964c27160ee50c51

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/62ac2962b2dd627a/build/8840ab72-9b0a-4cd0-8267-11ded2b645df/artifact/99ec9c3a8a20114e/p/b387db3e6dde48daf448f6db1c92ef80


Fix Issue 13856 - std.stdio.readln stomps arrays

This avoid interference of readln with standard arrays.
It also avoids an allocation when passing a stack allocated buffer that is large enough to hold the line.
https://issues.dlang.org/show_bug.cgi?id=13856

N.B. Merge conflicts / needs rebase.

Sorry for the delay, now rebased.

is this good to go?

It's ok if we can live with a small loss in performance for some uses of readln. See the benchmarks above, there are also improvements in other cases. I couldn't check the performance on linux/OSX though.

I think the fact that using a stack-allocated array to buffer for readln results in always allocation is enough to make this pull worth doing.

Will this make it into 2.067? It is blocker for me and I think stomping should be a big problem for readln. Think security! What about the children? :p

Just did another quick review, looks fine to me.

The solution seems quite complicated. What is the root of the problem? Is that the fact that readln() writes all the way up to GC.sizeof?

Is that the fact that readln() writes all the way up to GC.sizeof?

Yes. The fix is a bit complicated because it is conservative in changing the API.
As discussed above it would be faster and safer if readlnImpl would never shrink the passed buffer and return a slice into it. That would make assumeUnique on the returned slice invalid, though, so appending to it is likely to produce an allocation.

As @rainers alluded to, the issue is that there is no communication from one call of readln to the next call, indicating the ownership of the array.
But the big fix I see here is that you could never use a stack buffer for readln (it would just malloc immediately, even if the line fit into the passed buffer). This is somewhat different problem than the title indicates, but it's fixed by this as well.
The solution is complex because readln is complex. It's a different implementation per OS, optimized for that OS's C runtime's available tools.
The correct fix would be to return both the line length and the buffer length, so the next call to readln kept that info. But that means an API change.

Here is what we could do.

Tell people to use stdin.byLine() instead of looping on stdin.readln(buf).
Add a hack that caches the maximum buffer length in a static variable across multiple calls to readln to make the current interface fast and correct.

Anyone knows why this turned into a regression?
https://issues.dlang.org/show_bug.cgi?id=14310

As usual the interactions of the GC, arrays, slices, stomp protection, and the array append cache are way too complex for anyone to work with.

We're lacking a byLine(buf) to replace reason completely.

Will this make it into 2.067? It is blocker for me and I think stomping should be a big problem for readln. Think security! What about the children? :package:

This used to be broken before and I no longer want to delay the release. As a workaround you can use byLine instead.
To fix this problem, we should make readln correct but inefficient, deprecate it, and add a byLine(buf) as replacement.

To fix this problem, we should make readln correct but inefficient, deprecate it, and add a byLine(buf) as replacement.

No. readln serves a completely different need. byLine is not meant for reading one line.
I agree with changing the API however, as discussed earlier in this thread. Even getline as defined on Posix systems gets it right.

No. readln serves a completely different need. byLine is not meant for reading one line.

It's mainly the loop usage which causes us headache.
The obvious API that takes a buffer and returns a slice can't be overloaded with readln, any good proposals for an API?

Not corrupting memory trumps being slower. Discussions of new APIs aside, I think this should go in as-is for now. InvalidMemoryOperationErrors are difficult to debug. Besides, we have an I/O API overhaul in front of us still (std.io).

Rebased and conflicts resolved. These are now the timings of the benchmark above on windows:
win32/master
readln1: 129 ms
readln2: 170 ms
byLine: 127 ms
551312 bytes used

win64/master
readln1: 601 ms
readln2: 652 ms
byLine: 599 ms
801664 bytes used

win32/fix
readln1: 120 ms
readln2: 128 ms
byLine: 105 ms
2128 bytes used

win64/fix
readln1: 287 ms
readln2: 288 ms
byLine: 265 ms
5648 bytes used

So it's faster for all tests now, probably due to recent changes to byLine.

Great! @MartinNowak @schveiguy OK to merge?

What's up with all the makefile changes?

Looks like a case of git's core.autocrlf converting the Unix line endings to CR LF. @rainers you will need to fix that and rebase.

Looks like a case of git's core.autocrlf converting the Unix line endings to CR LF. @rainers you will need to fix that and rebase.

Arrgh, this keeps coming back again and again... Should be fixed now.

So it's faster for all tests now, probably due to recent changes to byLine.

Yeah, there was some focus on that. Also, assumeSafeAppend had a degenerate case if the Block info wasn't in the cache yet.
I assume nothing has really changed since I last said LGTM, I'm not a big fan of how rebasing erases all the historical commits unless they were commented on. In any case, I think it still looks good.

So it's faster for all tests now, probably due to recent changes to byLine.

As said above, I have tested this only on Windows. readlnImpl is versioned for other platforms, so it would be nice if someone could verify the benchmarks on these.

Will checks this, should be fine though.

It's a lot slower on linux.
readln1: 80 ms
readln2: 97 ms
byLine: 62 ms

vs.
readln1: 49 ms
readln2: 49 ms
byLine: 38 ms

Because _d_arraysetcapacity is called for each line to obtain the buffer capactiy.

We should rethink the API and consider other fixes before hacking around an inherent problem.

To fix this problem, we should make readln correct but inefficient, deprecate it, and add a byLine(buf) as replacement.

No. readln serves a completely different need. byLine is not meant for reading one line.

Yes, and that's why readln doesn't need to be optimized for reusing the buffer, we should have byLine(buf) for that or even better implement byLine() with a scope malloc/realloc/free buffer.

We should rethink the API and consider other fixes before hacking around an inherent problem.

Please let's fix the memory corruption first.

this bug exists since ages, can't be that urgent
we can't correctly fix readln, but this patch unnecessarily slows down byLine
workaround is simple, dup the line before appending to it
we recently improved readln performance, this eats up the gain
readln is particularly important because it's one of the first things people try/benchmark and D was notoriously slower here than most scripting languages

Yes, and that's why readln doesn't need to be optimized for reusing the buffer, we should have byLine(buf) for that or even better implement byLine() with a scope malloc/realloc/free buffer.

Improving byLine is fine, we probably have more flexibility here. The designer in me cringes that we have separate implementations for byLine and readln...
To @CyberShadow's point, if the slowdown is not fixable without fixing the array stomping, then array stomping should have priority. Perhaps fixing byLine will alleviate this issue.

Rebased and ReadlnAppender removed from the HAS_GETDELIM version aswell as the bad GC.sizeof optimization. This is probably slightly faster for byLine, but will add a few allocations for the readln1 benchmark.

What is the status on this?

readln is particularly important because it's one of the first things people try/benchmark and D was notoriously slower here than most scripting languages

Well, is it better if the D benchmark corrupts memory and dies, then? What sort of impression would that make, that D is so buggy it can't even do something as basic as read a few lines without crashing?
People keep running into this bug again and again:
<EMAIL_ADDRESS>https://issues.dlang.org/show_bug.cgi?id=14578
I don't claim to understand the problem in full, but I can't believe there is something to disagree on here when the choice is between performance and not corrupting memory.

People keep running into this bug again and again:

To be fair, as much as I want this to go through, those issues should be fixed by latest head.

What is the status on this?

I guess it needs someone with a linux system to verify the latest version does not reduce the performance of the benchmarks.

To be fair, as much as I want this to go through, those issues should be fixed by latest head.

Not sure why these should be fixed, the changed allocation pattern in byLine will just hide most occurences.

This is what I see on Linux x64 (best of 3 runs):
before:
readln1: 59 ms
readln2: 58 ms
byLine: 45 ms

after:
readln1: 80 ms
readln2: 57 ms
byLine: 45 ms

If the question is should we keep bogus but faster version then I suggest to merge and get correct version even if it's less efficient in 1 out of 3 use cases.

This is what I see on Linux x64

Note that byLine has been changed not to use readln, so it can be removed from the benchmarks.

Not sure why these should be fixed, the changed allocation pattern in byLine will just hide most occurences.

I didn't notice this message before, can you explain this further @rainers?

I didn't notice this message before, can you explain this further

ByLine still calls readln, see ByLine.popFront.
The recent change in byLine is that it remembers the original buffer and keeps it for the next call to readln if the returned line is shorter. Otherwise the returned larger buffer is used for the next call. This causes larger buffers being used, so chances of hitting the last bytes of the buffer are reduced.
Some versions of readlnImpl use standard array operations on the buffer, e.g. buf ~=, buf.length = or buf.dup, which causes the allocation block to also hold array length information. These are stomped when GC.sizeof is used in a later call to determine the length of the buffer.

So @rainers @schveiguy and @MartinNowak  are we good to go?

So @rainers @schveiguy and @MartinNowak are we good to go?

No objections from my side ;-) I just removed bad the CRs...

So @rainers @schveiguy and @MartinNowak are we good to go?

I am a little hesitant because the performance difference is so large (according to your numbers, it's about 33% slower), and the readln1 use case is the most common that could be used (just passing in the same buffer). I don't know if it's fixable without adjusting the API as discussed.
On the other hand, it's all an implementation issue, which can be fixed later if possible. One thing I foresee happening is someone complains "what the hell happened to performance of readln" and this gets reverted knee-jerkily. For some reason people are allergic to bug fixes that cut performance these days. Perhaps fixing memory corruption is a good enough defense. In any case, my LGTM still stands. I think it's a worthwhile change.

Perhaps fixing memory corruption is a good enough defense.

Do we have a test case which reproduces the memory corruption problems on master? As I understand, most common occurrences of memory corruption have already been fixed?

Perhaps fixing memory corruption is a good enough defense

Being fast and incorrect is wrothless. So I'm merging this.

Do we have a test case which reproduces the memory corruption problems on master?

The test cases that failed for the original byLine should also fail for readln loop implemented in the same way as readln1 (as that is how byLine was originally implemented).

@schveiguy add a test case like that in a separate pull ? Then reverting this would regress on the auto-tester.

add a test case like that in a separate pull ?

I think @rainers already added one.

But I don't think that would stop a revert, they'd just revert the test too.

Accidental revert would be stopped. Reverting test case is an extra burden that won't go lightly.

Accidental revert would be stopped. Reverting test case is an extra burden that won't go lightly.

I hope accidental revert would never happen.
I also have seen most of the time reverts do not happen lightly, and such a move (committing test case in separate pull to prevent reverts) wouldn't be viewed positively.

Auto-merge toggled on

Being fast and incorrect is worthless. So I'm merging this.

Thanks.

those weren't memory corruption issues, but asserts. Memory corruption is quite easy, just use a slice of an existing buffer as the buffer for readln

The unittest in this PR shows some failing use patterns, but this depends on implementation details of rt.lifetime. The stomping initially doesn't corrupt any memory outside the memory block, but this can happen later by a combination of the BlkAttr.APPENDABLE flag and bad length information, for example when trying to append to the array. The actual effect is hard to predict and can be anything from going by undetected and the test application crashing.

Regarding the performance drop: maybe we should just add an example to readln that uses the same pattern as byLine:
    char[] buf;
    while(!f.eof())
    {
        char[] ln = buf;
        f.readln(ln);
        if (ln.length > buf.length)
            buf = ln;
        /// use ln
    }

This should yield the same performance as byLine.

we should just add an example to readln that uses the same pattern

Yes, please!

@rainers Good idea - something along the lines of being roughly equivalent to this code.

https://github.com/D-Programming-Language/phobos/pull/3485


chore: replace instances of VITE_NAMESPACE, tagline etc with env('KUMA_*') equivalents

Description
During:

https://github.com/kumahq/kuma-gui/pull/466
https://github.com/kumahq/kuma-gui/pull/507
https://github.com/kumahq/kuma-gui/pull/560

We added an env helper function to access non-changing/static 'environment variables'
We should replace all the various ways we used to access these variables with the new env helper.
Most of our "environment variables" are accessible via env, but over the past few weeks I have noticed that there are probably one or two more we need to add to env, this could be done as part of this task.

I still see "VITE_NAMESPACE" in the codebase so I'm assuming this is not stale. Please close if I'm mistaken.

This still needs cleaning up. Removing VITE_NAMESPACE and KUMA_PRODUCT_NAME because of const productName = encodeURIComponent(env('KUMA_PRODUCT_NAME')) in src/services/env/Env.ts.


VSCode is not taking new gradle version installed after restart

Does this issue occur when all extensions are disabled?: Yes/No. Yes

VS Code Version: 1.62.2
OS Version: BigSur v11.6

Steps to Reproduce:

installed gradle version 5.6.1 using sdkman
sdk install gradle 5.6.1
sdk default gradle 5.6.1
restarted VSCode and closed all terminal.
VSCode does not want to use the new installed gradle version.
in Bash the new installed gradle has taken effect.

have you tried closing the vscode application entirely? that's necessary to refresh the environment

4.restarted VSCode and closed all terminal.

@daskabe can you run which gradle and echo $PATH? The problem might be on your end and depend on your shell launch scripts


YoutubeAudioSourceManager Exception handling

Hi
Since a recent update lavaplayer throws FriendlyException: Received unexpected response from YouTube whenever a YouTube video is unavailable / blocked with the actual exception hidden as cause of the "Failed to parse: " RuntimeException. The issue seems to be that YoutubeAudioSourceManager#getTrackInfoFromMainPage wraps all Exceptions thrown by YoutubeAudioSourceManager#checkStatusBlock into a new FriendlyException even if the thrown Exception is also a FriendlyException, shouldn't FriendlyExceptions just get propagated? I'll create a pull request that can be merged if my approach was correct.
[ERROR] 2019-10-29 17:55:02.545 [lava-daemon-pool-info-loader-2-thread-1] UrlAudioLoader - lavaplayer threw an exception while loading track https://www.youtube.com/watch?v=KNbKUp7Almw
com.sedmelluq.discord.lavaplayer.tools.FriendlyException: Received unexpected response from YouTube.
	at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioSourceManager.getTrackInfoFromMainPage(YoutubeAudioSourceManager.java:403) ~[lavaplayer-1.3.23.jar:?]
	at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioSourceManager.loadTrackWithVideoId(YoutubeAudioSourceManager.java:209) ~[lavaplayer-1.3.23.jar:?]
	at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioSourceManager.loadFromUrlWithVideoId(YoutubeAudioSourceManager.java:331) ~[lavaplayer-1.3.23.jar:?]
	at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioSourceManager.loadFromMainDomain(YoutubeAudioSourceManager.java:268) ~[lavaplayer-1.3.23.jar:?]
	at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioSourceManager.loadNonSearch(YoutubeAudioSourceManager.java:338) ~[lavaplayer-1.3.23.jar:?]
	at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioSourceManager.loadItemOnce(YoutubeAudioSourceManager.java:197) ~[lavaplayer-1.3.23.jar:?]
	at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioSourceManager.loadItem(YoutubeAudioSourceManager.java:132) ~[lavaplayer-1.3.23.jar:?]
	at com.sedmelluq.discord.lavaplayer.player.DefaultAudioPlayerManager.checkSourcesForItemOnce(DefaultAudioPlayerManager.java:437) ~[lavaplayer-1.3.23.jar:?]
	at com.sedmelluq.discord.lavaplayer.player.DefaultAudioPlayerManager.checkSourcesForItem(DefaultAudioPlayerManager.java:419) ~[lavaplayer-1.3.23.jar:?]
	at com.sedmelluq.discord.lavaplayer.player.DefaultAudioPlayerManager.lambda$createItemLoader$0(DefaultAudioPlayerManager.java:218) ~[lavaplayer-1.3.23.jar:?]
	at java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:264) [?:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java) [?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
	at java.lang.Thread.run(Thread.java:834) [?:?]
Caused by: java.lang.RuntimeException: Failed to parse: [
{"page":"watch","csn":"_Wy4Xey5FpqdgQeD07jwAQ","rootVe":3832},
{"preconnect":["https:\/\/r4---sn-n0ogpnx-cnal.googlevideo.com\/generate_204","https:\/\/r4---sn-n0ogpnx-cnal.googlevideo.com\/generate_204?conn2"],"page":"watch"},
{"csn":"_Wy4Xey5FpqdgQeD07jwAQ","page":"[.....]8FsiEwjIuLbo9cHlAhWMst4KHdrZAUw=","commandMetadata":{"webCommandMetadata":{"url":"/service_ajax","sendPost":true}},"signalServiceEndpoint":{"signal":"CLIENT_SIGNAL","actions":[{"signalAction":{"signal":"SKIP_NAVIGATION"}}]}}}}}},"webWatchNextResponseExtensionData":{"relatedVideoArgs":""}},"url":"\/watch?v=KNbKUp7Almw\u0026hl=en"},
{"page":"watch","timing":{"info":{"st":396}}}]

	... 15 more
Caused by: com.sedmelluq.discord.lavaplayer.tools.FriendlyException: This video contains content from
TV TOKYO Corporation
, who has blocked it in your country on copyright grounds.

	at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioSourceManager.checkStatusBlock(YoutubeAudioSourceManager.java:430) ~[lavaplayer-1.3.23.jar:?]
	at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioSourceManager.getTrackInfoFromMainPage(YoutubeAudioSourceManager.java:395) ~[lavaplayer-1.3.23.jar:?]
	... 14 more

(I omitted most of the huge JSON that gets printed)

I just rebased and YoutubeAudioSourceManager has been changed. Same code has been moved to the new DefaultYoutubeTrackDetailsLoader though, so this still applies.

Merged.


MINOR: Update rocksDB dependency to 4.9.0

rocksdbjni version 4.9.0 now includes support for running on Windows; this PR updates Kafka Stream's dependency to that version.  Tests pass locally, except for a timeout in testReprocessingFromScratchAfterReset that doesn't seem related; it happens with and without this change.
This contribution is my original work and I license the work to the project under the project's open source license.

LGTM


Intrusion Detection pagination is deffective

Steps to reproduce

Go to the Alerts tab
Let's say you have 10 entries. By default you'll be shown 7 and there will be 2 pages of logs
Change the view to show 50 entries and press the search button. (Would be nice if a button press wasn't required)

Expected result

10 entries on the page
1 page only in the pagination, bottom left
Showing 1 to 10 of 10 entries, bottom right

Actual result

10 entries on the page
2 pages in the pagination, bottom left
Showing 1 to 7 of 10 entries, bottom right

Due to the often large file, the pagination is always a guestimate of the actual results. The backend process parses the data until it found requested number and exits his search, without knowing about the possible rest of them (this would just take too much time).
The bootgrid component we use unfortunately doesn't seem to handle the response for the last page very well if the number of results equals the total number.
At first we implemented the search without the button, but you really don't want that... it can get very busy in different processes doing a search on a very large file, so we choose to explicitly ask for a refresh on all changes here.
Long story short, the pagination is probably never going to be perfect for this type of operation.

timeout


Null safety

You should probably also update the example shown in the README

You should probably also update the example shown in the README

done

Ping @Darshan0

Ping @Darshan0

Hey @Darshan0 I hope you are doing well, when will be this feature available as release?


jspm shim missing

Please update the dependencies in jspm registry
https://github.com/jspm/registry/blob/master/package-overrides/github/DmitryBaranovskiy/raphael%402.1.2.json
More about Shim at:
https://github.com/jspm/registry/wiki/Configuring-Packages-for-jspm

This should be addressed. It's causing many headaches in our system right now.

Care to explain? Can't the jspm registry PR be done by anyone?
Anything needs to change in Raphael?


fix(cli): set autoUpdate a boolean for gk describe yaml/json output

Closes #765
📑 Description
This PR changes JSON/YAML output to glasskube describe so autoUpdate is a boolean value instead of a string "Enabled" or "Disabled"
✅ Checks

[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required

ℹ Additional Information
This would be a breaking change as the output for autoUpdate has changed from a string value to a boolean value
Here's a screenshot showing the new output format:

Perfect @christophenne I'll proceed as you suggest

@doncicuto the other PR is merged, so the pkg.AutoUpdatesEnabled is available now.

 We just updated our workflow and policy to put less strict requirements on PR branches. Please merge the latest commits from main to get these benefits.


Add REST API

Initial testing suggests that the API draft works well enough that we want to make it available in the dev environment. As there will initially only be internal users, even if breaking changes must be made it should be tolerable.

To avoid possible interference with the production environment, it seems better to temporarily build an image with a different name and use that in dev, without yet performing this merge.


Allow multiple servers per process

This change allows specifying more than one github-mastodon pair for publishing in the same process. Needed for the case where one single bot should publish issues and PRs from more than one repo.

Found two bugs:

"Won't publish to Mastodon" when debug is false. Should say the opposite.
When the first server has no more issues/PRs to read, it stops attempting to read the next ones.


MAINT: Update leveraged ETF list

Updated with data using http://www.etf.com/etfanalytics/etf-finder
Checked against http://etfdb.com/etf-launch-center/

Any status on #754?
@jmccorriston

Coverage remained the same at 86.312% when pulling 0bc692a8bca3cfaf0cf4f9169859066ed78c07b4 on update-leveraged-etfs into c460af0a400d9fe0de530ca4ebc907e516905e2c on master.

Coverage remained the same at 86.312% when pulling 0bc692a8bca3cfaf0cf4f9169859066ed78c07b4 on update-leveraged-etfs into c460af0a400d9fe0de530ca4ebc907e516905e2c on master.

Coverage remained the same at 86.312% when pulling 0bc692a8bca3cfaf0cf4f9169859066ed78c07b4 on update-leveraged-etfs into c460af0a400d9fe0de530ca4ebc907e516905e2c on master.

Coverage increased (+0.3%) to 86.604% when pulling f5ff4fc48a7c962c4d153212443a6f3234e27f75 on update-leveraged-etfs into c460af0a400d9fe0de530ca4ebc907e516905e2c on master.

Moving https://github.com/quantopian/zipline/pull/754 to this branch.

Coverage remained the same at 86.754% when pulling a5ecaf4c3a712531e2c692e0a8f6fedff898118c on update-leveraged-etfs into cf44fcb207e30a4c547071c726c929f08a292c4a on master.


Add saved searches

WIP -

Fix bugs with searches (always show all severities)
Adding saved searches

@epicfaace This should be mostly ready to review. Note one bug -- when clicking on a saved search, it links to the correct search url, which is then immediately overwritten by the elasticsearch UI library. Any ideas on how to navigate to the page and show the correct results while still being able to pass state?

When feeds are blank, it might be good to have a message that says "Perform a search and save it to add something to the feed":


Optimize the performance of H264 packaging

Optimize the performance of H264 packaging
Description
Sending package H264 in my program is quite performance intensive. Then through ppfrof, it was found that the range of nalu is relatively slow, and it will create slices multiple times. Use bytes.Index lookup index can significantly improve performance
Before:

After:

Great change @ziminghua!
It is possible to support both start codes? https://learn.microsoft.com/en-us/windows/win32/directshow/h-264-video-types#h264-bitstream-with-start-codes

Sorry, I didn't consider Appendix B originally, so I optimized the original performance. If I want to support both start codes, I think this is possible.

@Sean-Der Hello, what do you think of the current update.

@ziminghua great work! Lets merge it. I am out of time, I will merge first thing tomorrow
Code is much easier to read also :)

@ziminghua I tagged v1.8.2 so you can use this now! Thank you so much for the contribution :)


[WFLY-17501] Refactoring - eliminating usage of deprecated CapabilityServiceBuilder.addCapabilityRequirement() methods from EJB subsystem

https://issues.redhat.com/browse/WFLY-17501

/retest

/retest


[Front end] Sign up modal

Sign in modal has the input boxes in a weird order for password/verify password. Order makes more sense to have password and then verify password boxes in that order

fixed :)


Review to remove some wrong points

Now, one might argue saying we can implement pick and omit as below:
...
The major challenges we see with the above implementations:

It is not ergonomic!
If we opt for the destructuring way it doesn't work at all for pick, or for omit with dynamic values.

Is it necessary to describe this? I think the proposal mainly aims to provide a convenient method, rather than introducing an unimplementable way before. @hemanth @ljharb

The most common argument about pick and omit would be that we can implement them as below or using destructering. We need to highlight that it is not ergonomic and doesn't really work for dynamic destructering?

@ljharb @hemanth pls review the lastest changed.

@aleen42 I personally preferred the previous version as it was verbose about the different possibilities.
If we want to keep it concise we should maybe provide a code block identifying the limitations of destructering with an example and highlight how pick and omit can help?

@hemanth How about adding code snippet like this
So what props these methods have given us in comparison with destructuring?

Destructuring cannot clone a new object while Object.pick canObject.pick({a : 1, b : 2}, ['a']); // => {a: 1}

// when using destructuring
const {a} = {a : 1, b : 2};
{a}; // => {a: 1}

We can specify which properties to pick or omit by a list of keys or a predicate method, while destructuring requires a hardcoded number of properties (although their names can be dynamic)const input = {a : 1, b : 2, c : 3};
Object.pick(input, ['a', 'b']); // => {a: 1, b: 2}
Object.pick(input, val => val < 3); // => {a: 1, b: 2}

// when using destructuring
['a', 'b'].reduce((obj, key) => {
    const {[key] : value} = input;
    return Object.assign(obj, {[key] : value});
}, {}); // => {a: 1, b: 2}
Object.entries(input).reduce((obj, [key, value]) => {
    return Object.assign(obj, value < 3 && {[key] : value});
}, {}); // => {a: 1, b: 2}

Got it on the code samples.
We can clone with Object.assign or const {...clone} = obj ?
But for Stgse-1 if we were to define the problem statement it would be?

@hemanth Sorry, I don't know the meaning.

@aleen42 We should try to clearly state the purpose of this proposal.
What is the existing challenge and what is this proposal solving?

@aleen42 We should try to clearly state the purpose of this proposal.
What is the existing challenge and what is this proposal solving?

@hemanth OK, I have removed two snippets and just say out the challenges before this proposal.

@aleen42 we can keep the code.
For Stage-1 we should just discuss the problem statement, use-cases, prior art.
For Stage-2 we should talk about the solution, syntax and alternative approach.
If there are no objections for Stage-1 or clarification needed we can try proposing for Stage-2

@hemanth OK, I have kept both snippets.

@aleen42 We can close this PR for now, as we went to Stage-1 with the existing  readme, we can enhance it later as we work towards Stage-2.


Q: Exposing props to allow for easier UI abstraction

💬 Questions and Help
Firstly, the project looks awesome, having come from a heavily styled-components and styled-system background.
My first question, is around how you might expose props for creating UI components. Often with projects, we tend to abstract the UI components such as Button, Input and so on, into more reusable components with strict Typescript interfaces.
In essence, we would take something like this....
<x.button
      type="button"
      color="white"
      transition
      bg={{ _: 'emerald-500', hover: 'emerald-800' }}
    >

Into it's own Button component and expose props such as variant which may then further style the component.
This removes the requirement to always pass a bunch of reused props every time the primary button is needed. It also removes the @xstyled... calls from all pages and into less components, should the need to change arise.
Previously with styled-system we used to generate/build prop types (interfaces) so that we could further expose those props should we wish. For the above example, we might want to expose bg but everything else be behind the scenes. What would be the recommended approach for this?
Furthermore, is there any documentation around creating variants? I read that some of the variants part was deprecated as it was confusing. But interested to learn more around what approach might be best. In the above example, just creating variants for buttons that are predefined by the actual Button component, rather than exposing x.button everywhere.
Thanks!

I'm a big fan of having a utility that behaves similarly to styled(MyComponent) from styled-components.
interface ButtonProps {
  children: React.ReactNode;
}

const Button = styled<ButtonProps>(x.button, {
  type: 'button',
  color: 'white',
  transition: true
  bg: { _: 'emerald-500', hover: 'emerald-800' }
})``;

const DangerButton = styled<ButtonProps>(Button, {
  bg: { _: 'red-500', hover: 'red-800' }
})``;

@StuartMorris0 maybe the approach in https://github.com/gregberge/xstyled/issues/224 could help you.


Some features that might be useful

Thanks for the wonderful job.  I'm considering using this in place of regular responsive navigation.
One feature that might help, on small screen, the option to show only the active tab, or no tab at all.  Because I would need most of the tab space for status, toolbar icon, etc.

Hey @whoever123, take a look now. On screens smaller than 480px, you'll likely only see the active tab, plus the dropdown menu.


Support for netstandard2.0

Since both Topshelf and Unity support net452 and netstandard2.0, should Topshelf.Unity also multi-target both?

@Kesmy Yes, it would be great! Help appreciated!

Note for myself (or if I get hit by a bus...):
This will result in minimum-version upgrades to Topshelf 4.2.1 and Unity.Abstractions 4.1.0, to minimize the number of additional dependencies.

Hey. Hope you don't mind me taking this one (it has been open a while 😄)
I've just opened PR #19 that should support netstandard2.0 and net452.

Closed by #19
@kstrt  @Kesmy Thank you for your contribution! Appreciate it.


Skipped builds fail

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

App Id
d1zloo668ozrvr
AWS Region
eu-west-1
Amplify Hosting feature
Frontend builds, Monorepo
Describe the bug
Diff deployment correctly detects when there are no changes and skips running the build, but then fails because it complains that the build artefact doesn't exist. See logs and buildspec below.
Expected behavior
When a build is supposed to be skipped I would expect it to actually be skipped, not to fail.
Reproduction steps

Enable diff deployments
Click re-deploy this version

Build Settings
cdk.aws_codebuild.BuildSpec.fromObjectToYaml({
    version: 1,
    applications: [
      {
        appRoot,
        frontend: {
          phases: {
            preBuild: {
              commands: [
                "npm ci",
                'echo "NEXT_PUBLIC_HOST=$AWS_BRANCH.$AWS_APP_ID.amplifyapp.com" >> .env.production',
                'echo "NEXT_PUBLIC_GIT_SHA=$(git rev-parse HEAD)" >> .env.production',
              ],
            },
            build: {
              commands: ["npm run build"],
            },
            postBuild: {
              commands: [
                "shopt -s dotglob", // include filenames beginning with a ‘.’ in the results of filename expansion, except '.' and '..'
                `mv -f .next/standalone/${appRoot}/* .next/standalone`,
              ],
            },
          },
          artifacts: {
            baseDirectory: ".next",
            files: ["**/*"],
          },
          cache: {
            paths: ["../../node_modules/**/*", ".next/cache/**/*"],
          },
        },
      },
    ],
  });

Log output

2023-01-26T12:23:43.726Z [INFO]: # Determining if there are deployable frontend differences relative to repository root at: apps/admin
2023-01-26T12:23:43.726Z [INFO]: # NOTE: Set the AMPLIFY_DIFF_DEPLOY_ROOT environment variable to a valid relative path to override the default, ie: dist
2023-01-26T12:23:43.770Z [INFO]: # No differences detected.
2023-01-26T12:23:43.771Z [INFO]: # Defaulting to Node version 16
2023-01-26T12:23:52.878Z [INFO]: # Node version 16 is available for installation
2023-01-26T12:23:52.960Z [INFO]: # Installing Node version 16
2023-01-26T12:23:58.864Z [INFO]: # Now using Node version 16
2023-01-26T12:23:58.951Z [INFO]: No live updates for this build run
2023-01-26T12:23:58.953Z [INFO]: Setting NEXT_PRIVATE_STANDALONE=true to produce .next/standalone directory
2023-01-26T12:23:58.954Z [INFO]: # Retrieving cache...
2023-01-26T12:23:59.022Z [INFO]: # Extracting cache...
2023-01-26T12:23:59.024Z [INFO]: # Extraction completed
2023-01-26T12:23:59.025Z [INFO]: # Retrieved cache
2023-01-26T12:24:37.165Z [INFO]: ## Skipping Frontend Build & Deploy, No changes detected...
2023-01-26T12:24:37.268Z [INFO]: ## Build completed successfully
2023-01-26T12:24:37.269Z [INFO]: # Starting caching...
2023-01-26T12:24:37.274Z [INFO]: # Creating cache artifact...
2023-01-26T12:24:37.278Z [INFO]: # Created cache artifact
2023-01-26T12:24:37.278Z [INFO]: # Uploading cache artifact...
2023-01-26T12:24:37.351Z [INFO]: # Uploaded cache artifact
2023-01-26T12:24:37.351Z [INFO]: # Caching completed
2023-01-26T12:24:37.353Z [INFO]: Setting NEXT_PRIVATE_STANDALONE=true to produce .next/standalone directory
2023-01-26T12:24:37.354Z [INFO]: # No custom headers found.
2023-01-26T12:24:37.356Z [ERROR]: !!! CustomerError: The base directory '.next' you have specified in your amplify.yml does not exist. Make sure you run 'next build' or specify the correct name for your NextJS build directory.
2023-01-26T12:24:37.356Z [INFO]: # Starting environment caching...
2023-01-26T12:24:37.356Z [INFO]: # Uploading environment cache artifact...
2023-01-26T12:24:37.430Z [INFO]: # Uploaded environment cache artifact
2023-01-26T12:24:37.430Z [INFO]: # Environment caching completed
Terminating logging...

Additional information
We use the GitHub App integration with a monorepo so builds are frequently skipped. However, when they are skipped it causes the checks on a PR to fail, which is annoying. This also means we can't distinguish between actual failures and "skips" without signing in to the AWS console and checking the build logs. Very annoying.

Hi @jdpst 👋🏽 thanks for raising this issue. We are currently working on reproducing and root causing this issue. Will update once we have next steps.

@hloriana any updates?

Any updates on this? Having the same problem with a turborepo setup.
2023-08-09T10:09:09.030Z [INFO]: ## Skipping Frontend Build & Deploy, No changes detected...
2023-08-09T10:09:09.030Z [INFO]: ## Build completed successfully
2023-08-09T10:09:09.031Z [INFO]: # Starting caching...
2023-08-09T10:09:09.042Z [INFO]: # Creating cache artifact...
2023-08-09T10:09:25.152Z [INFO]: # Created cache artifact
2023-08-09T10:09:25.253Z [INFO]: # Uploading cache artifact...
2023-08-09T10:09:36.259Z [INFO]: # Uploaded cache artifact
2023-08-09T10:09:36.365Z [INFO]: # Caching completed
2023-08-09T10:09:36.372Z [INFO]: # No custom headers found.
2023-08-09T10:09:36.458Z [ERROR]: !!! CustomerError: Build output not found in /codebuild/output/src3965271401/src/<<repo>>/amplify-compute-bundle-output/compute/.next/server, please check your build artifacts path
2023-08-09T10:09:36.458Z [INFO]: # Starting environment caching...
2023-08-09T10:09:36.460Z [INFO]: # Environment caching completed

Any update on this? Also having the same issue when build is skipped from no diff status:
2023-09-04T20:29:19.240Z [INFO]: # NOTE: Set the AMPLIFY_DIFF_DEPLOY_ROOT environment variable to a valid relative path to override the default, ie: dist
2023-09-04T20:29:19.356Z [INFO]: # No differences detected.
2023-09-04T20:29:19.357Z [INFO]: No live updates for this build run
2023-09-04T20:29:19.360Z [INFO]: # Retrieving cache...
2023-09-04T20:29:38.445Z [INFO]: # Extracting cache...
2023-09-04T20:29:56.018Z [INFO]: # Extraction completed
2023-09-04T20:29:56.324Z [INFO]: # Retrieved cache
2023-09-04T20:30:31.434Z [INFO]: ## Skipping Frontend Build & Deploy, No changes detected...
2023-09-04T20:30:31.504Z [INFO]: ## Build completed successfully
2023-09-04T20:30:31.505Z [INFO]: # Starting caching...
2023-09-04T20:30:31.516Z [INFO]: # Creating cache artifact...
2023-09-04T20:31:06.356Z [INFO]: # Created cache artifact
2023-09-04T20:31:06.446Z [INFO]: # Uploading cache artifact...
2023-09-04T20:31:21.512Z [INFO]: # Uploaded cache artifact
2023-09-04T20:31:21.591Z [INFO]: # Caching completed
2023-09-04T20:31:21.598Z [INFO]: # No custom headers found.
2023-09-04T20:31:21.603Z [ERROR]: !!! CustomerError: Artifacts base directory not found in build output, please check your buildSpec

We are also running into the very same issue.
We have Nuxt 3 apps in Turborepo.
Our amplify.yml looks like this:
version: 1
applications:
  - appRoot: apps/appOne
    frontend:
      buildPath: /
      phases:
        preBuild:
          commands:
            - npm install -g pnpm
            - nvm use 18 && node --version
            - corepack enable && npx --yes nypm install
        build:
          commands:
            - pnpm build:appOne
      artifacts:
        baseDirectory: .amplify-hosting
        files:
          - "**/*"
  - appRoot: apps/appTwo
    frontend:
      buildPath: /
      phases:
        preBuild:
          commands:
            - npm install -g pnpm
            - nvm use 18 && node --version
            - corepack enable && npx --yes nypm install
        build:
          commands:
            - pnpm build:appTwo
      artifacts:
        baseDirectory: .amplify-hosting
        files:
          - "**/*"

And then for each app in the Amplify dashboard, we set the environment variables to:
AMPLIFY_DIFF_DEPLOY: true
AMPLIFY_MONOREPO_APP_ROOT: (the path to the app)
Deployment works fine without AMPLIFY_DIFF_DEPLOY (or setting it to false), but not with it set to true.
Here are the logs
2024-03-14T10:20:49.854Z [INFO]: # Determining if there are deployable frontend differences relative to repository root at: apps/appOne
2024-03-14T10:20:49.854Z [INFO]: # NOTE: Set the AMPLIFY_DIFF_DEPLOY_ROOT environment variable to a valid relative path to override the default, ie: dist
2024-03-14T10:20:49.911Z [INFO]: # No differences detected.
2024-03-14T10:20:50.828Z [INFO]: No live updates for this build run
2024-03-14T10:20:50.833Z [INFO]: # Retrieving cache...
2024-03-14T10:20:50.833Z [INFO]: # Retrieved cache
2024-03-14T10:21:10.943Z [INFO]: ## Starting Backend Build
                                 ## Checking for associated backend environment...
                                 ## No backend environment association found, continuing...
                                 ## Completed Backend Build
2024-03-14T10:21:10.951Z [INFO]: {"backendDuration": 0}
                                 ## Skipping Frontend Build & Deploy, No changes detected...
2024-03-14T10:21:11.030Z [INFO]: ## Build completed successfully
2024-03-14T10:21:11.039Z [ERROR]: !!! CustomerError: Failed to find the deploy-manifest.json file in the build output. Please verify that it exists within the "baseDirectory" specified in your buildSpec. If it's not there, we will also check the .amplify-hosting directory as a fallback. When using a framework adapter for hosting on Amplify, double-check that the adapter settings are correct.
2024-03-14T10:21:11.040Z [INFO]: # Starting environment caching...
2024-03-14T10:21:11.040Z [INFO]: # Environment caching completed
2024-03-14T10:21:11.040Z [INFO]: # A new default build image based on Amazon Linux 2023 is now generally available. The image includes newer versions of Node.js, Python, and Ruby that you can use to build your app. To use the new image, select "Amazon Linux:2023" in the "Build settings" section for your app in the Amplify console.
Terminating logging...

Technically it's working, as it's not building, but having the Amplify dashboard report failed deployments seems wrong.

@Namstel We pushed an update last week to fix this issue. AMPLIFY_DIFF_DEPLOY should now work as expected - Please let us know if you continue to face issues.


Can't open new Wolfram Notebooks

Describe the bug
After an apparently successful installation, opening new Wolfram Notebooks fails with an error "command wolframLanguageNotebook.newNotebook not found" (screenshot attached). The same happens with the Manage Kernel command.
Expected behavior
A new notebook should open.
Screenshots

Environment (please complete the following information):

Operating system: Ubuntu 20.04.4 LTS
Mathematica/Engine: 13.0.0
VS Code: 1.64.2
Version: 0.0.9

Additional context
I've checked that the wolframscript command does work as expected from the CLI, and that there are no running Wolfram processes when trying to open a notebook.
I was able to make the extension work on another machine (which, however, runs Windows).

It might be an issue related to snap (#6).

Exact same issue here, latest OSX, vscode (M1 processor).
Anything we can do to debug the issue?

Exact same issue here, latest OSX, vscode (M1 processor). Anything we can do to debug the issue?

The extension does not work on m1 macbook natively (#4) due to the dependency on zeromq. But running vscode with rosetta 2 seems to be working.

@njpipeorgan zeromq is now supporting macOS arm64 as described https://github.com/zeromq/zeromq.js/pull/522 here.
Will this issue be fixed by updating the zeromq dependency?

I am also facing the same issue on M1 Mac.

I am on a mac too, but with Intel processor. Same issue here. MacOS Ventura 13.5.1 and Wolfram Engine 13.3. It worked a while ago for me, so it might be the upgrade to Wolfram Engine 13.3 or some problem with a newer version of VSCode or the Plugin itself. I cannot tell.


[parent-issue] geo /geospatical

just to maintain a good overview, this parent issue bundle all geo-issues

[x] https://github.com/apache/pinot/issues/655
[ ] https://github.com/apache/pinot/issues/5209#issuecomment-612113176
[x] https://github.com/apache/pinot/issues/5280
[x] https://github.com/apache/pinot/issues/7163
[ ] https://github.com/apache/pinot/issues/7190
[ ] https://github.com/apache/pinot/issues/7506
[ ] https://github.com/apache/pinot/issues/7766
[ ] https://github.com/apache/pinot/issues/8050
[ ] https://github.com/apache/pinot/issues/8301
[x] https://github.com/apache/pinot/issues/8547
[ ] https://github.com/apache/pinot/issues/10801
[ ] https://github.com/apache/pinot/issues/12805
[ ] https://github.com/apache/pinot/issues/14703

@Jackie-Jiang
maybe you could add the parent and geo label to this issue
and geo label to all mentioned issues?


Reopen stdin for binary as needed

Fixes #1688

Looks like a spurious Travis failure on the Android build.  We've removed Travis support on master so I'll check this in.

Rebased


feat: record error event when event name is invalid

Description

record an error event when event name is invalid

General Checklist

[x] Added new tests to cover change, if needed
[ ] Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
[x] Documentation update for the change if required
[x] PR title conforms to conventional commit style
[ ] If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (813caa9) 100.00% compared to head (cceebea) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           24        24
  Lines          964       966    +2
  Branches       176       176
=========================================
+ Hits           964       966    +2

Files Changed
Coverage Δ

src/provider/ClickstreamProvider.ts
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/80180

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/89746


Missing dt_on_output

To Whom It May Concern,
I am trying to compile MOMMS with rust-1.28.0-nightly and newest BLIS, but got the following error messages:
error[E0063]: missing field dt_on_output in initializer of kern::ukernel_wrapper::blis_types::auxinfo_t
--> src/kern/ukernel_wrapper.rs:62:28
|
62 |             let mut info = auxinfo_t{
|                            ^^^^^^^^^ missing dt_on_output
error[E0063]: missing field dt_on_output in initializer of kern::ukernel_wrapper::blis_types::auxinfo_t
--> src/kern/ukernel_wrapper.rs:79:28
|
79 |             let mut info = auxinfo_t{
|                            ^^^^^^^^^ missing dt_on_output
error[E0063]: missing field dt_on_output in initializer of kern::ukernel_wrapper::blis_types::auxinfo_t
--> src/kern/ukernel_wrapper.rs:96:28
|
96 |             let mut info = auxinfo_t{
|                            ^^^^^^^^^ missing dt_on_output
error: aborting due to 3 previous errors
For more information about this error, try rustc --explain E0063.
error: Could not compile momms.
Could you please provide some help?  Thanks very much.

Hello,
Because MOMMS uses Rust nightly, and (to a lesser extent) because the low level interfaces in BLIS change occasionally, every so often I have to update MOMMS.
I'ill do so in the next couple of days, and feel free to ping me again if I haven't gotten to it by Monday.

This should be fixed by c463b10. BLIS added support for casting the output of the microkernel to a different datatype and I have added support for it.
Note that as of right now, MOMMS requires ICC to compile the HSW micro-kernels.
Let me know if it works for you.

Look in src/exper. The exper_l* executables run the experiments in there.
The "./exper_l3" runs an experiment comparing GEMM performance implemented with the loops that make up Goto's algorithm and loops that make up another algorithm (without performing packing).

By running ".exper_l3" I got the following error message (compiled with 1.31.0-nightly):
./exper_l3
thread 'main' panicked at 'called Option::unwrap() on a None value', libcore/option.rs:355:21
stack backtrace:
0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
at libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
1: std::panicking::default_hook::{{closure}}
at libstd/sys_common/backtrace.rs:71
2: std::panicking::rust_panic_with_hook
at libstd/panicking.rs:227
at libstd/panicking.rs:476
3: std::panicking::continue_panic_fmt
at libstd/panicking.rs:390
4: rust_begin_unwind
at libstd/panicking.rs:325
5: core::panicking::panic_fmt
at libcore/panicking.rs:77
6: core::panicking::panic
at libcore/panicking.rs:52
7: momms::composables::spawn::cpuset_for_core
8: exper_l3::test
9: std::rt::lang_start::{{closure}}
10: main
11: __libc_start_main
12:
thread '' panicked at 'called Result::unwrap() on an Err value: "PoisonError { inner: .. }"', libcore/result.rs:1009:5

What system and compiler are you using? The experiments spawn threads and use hwloc to bind them to CPUs, and it looks like the error you are encountering is occurring during that process.

I'm using:
Linux 3.10.0-693.17.1.el7.x86_64
gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)
icc (ICC) <IP_ADDRESS> 20180524
hwloc-2.0.2
llvm/clang 6.0.0

Hi, sorry I've been slow to work on this. I just pushed a commit to handle when the CPU binding using hwloc doesn't work. Instead of crashing, it just continues without doing CPU binding. Does it fix your issue?


Add a test action

My travis CI started to require a plan change even if this is OSS, so I will move to GHA.
I removed coveralls for now as it's hard to run with multi jobs and matrixes.

All green!


Add support individual attributes for inputs in CheckboxList and RadioList widgets

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Fixed issues
#82

👍


20MHz crystal oscillator doesn't work with hx711

Hi, i'm from Brazil and i appreciate your work. I'm study them to my engineering in electronics. i would like to know which model of hx711 are you using (i mean which factory batch of hx711 are you using), because my hx711 doesn't work with crystal osscilator 20MHz (model HC49) when i put the rate pin to high level (5V) the hx711 return to me 70~80Hz like he is using his internal osscilator itself. The hx711 only work with the 20MHz crystal when i put the rate pin in low level (0V) and i receive 18 sample rate data as well the datasheet informed.
I suppose two things:
.the 20MHz crystal oscillator it's not exactly 20MHz, that can be a little bit more like 20,102MHz (example)
.the 20MHz crystal oscillator it's exactly 20MHz indeed, but the hx711 doesn't support this frequency of 20MHz.
Despite the time when your library was released, i hope and wait with your help/answers.
PS: the model (factory batch) of hx711 i already used is hx711 7916042F.

Hi, sorry for the delayed answer.
I don't know the batch of the chip I tested this with, but it should not matter as the option of connecting an external x-tal up to 20mhz is documented in the data sheet, and should work in both high and low rate. Could it be that pin 14 is was connected to ground when you tried the high rate?


Social Profiles structured data

Create module or include that automatically handles generating the social profiles structured data.
https://developers.google.com/search/docs/data-types/social-profile
This would be possible to generate all in HubL using the linked accounts in HubSpot.
May have to loop through follow_me() but atleast some of the data can be pulled to generate this making it automatic and easier to do.
This feature however should be optional, toggled by a boolean in theme-settings.css
This feature depends on a lot of other things to be in place, not least of which is a default template.


Request for documentation on building from source

Thanks for the request!

Done: https://github.com/solana-labs/wallet-adapter#build-from-source


Add burste to Contributors list

It's my first time to open a pull request...
Collaborating with others makes me feel excited,
I hope I can do something helpful for the open source community.  :)

@Burste, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


[zh] Remove reviewer for topology and cluster-kubeadm

Re-sync en content
Remove reviewers from metadata
Add link anchors
Fix punctuation

Related PR

#33903
#33954
#33958
#33959

@Sea-n  What are the related PRs? Do you mean this PR has dependencies on them or something like that?

Those PRs are all mainly for removing reviewers: from metadata, I think mentioning them in a PR can be better to track months later.

/approve

/approve

/assign

/lgtm


Can isDeviceConnected detect devices connected through the OS Bluetooth?

I'm currently trying to see if the package can detect if a device that's currently connected through the OS's Bluetooth module is also seen as connected within the app.  Essentially I'm doing the following things:

Connecting the device through the Android OS's Bluetooth functionality
Calling isDeviceConnected on the device_id to see if it's connected.

When I call startDeviceScan and I scan for the device, it comes up, but when I call isDeviceConnected or device.isConnected, I receive a False. Does that mean that even if a Bluetooth device is connected through the OS, the module will not recognize the device as connected?

On my case, I connected to a BLE device through the IOS Bluetooth menu (outside the app context), then when I enter the app, I need to know which is the device I am connected to.
When I do what I described above, the connected device does not show on the scanAndConnect method, which is expectable, since the device is not available anymore. However I would like to know what is the device that I am connected to.
I tried connectedDevices(), without passing any device_id on the arguments array, because I don’t have any device_id to compare to, but the answer is always empty.  I just need to know what is the device that I am connected if this is the case. Is there any way to achieve it?

Currently the library only tracks what it connected to. There is no way to find what is connected to the mobile.

@jclrosa have you found a workaround for this?


AfriSAR_AGD_1681 documentation

dataset documentation

@sdradsb should this PR include docs/source/tutorials/AfriSAR_AGB_Maps_1681_susan.ipynb ?

@sdradsb did you mean to close this PR?

@abarciauskas-bgse no, I was waiting for your comments to make any required changes. Does the documentation look good?

@sdradsb it's really close I think, I think this comment needs to be addressed: https://github.com/MAAP-Project/maap-documentation/pull/140#discussion_r1056688940
This PR needs to be reopened in order to merge the new documentation You should be able to reopen this PR but you may need to restore susam/dataset-tutorial-for-stac this branch too.

@abarciauskas-bgse there was a typo in the branch name when I created it,.It was named susam/dataset-tutorial-for-stac , so I renamed the branch to susan/dataset-tutorial-for-stac , and I think that deleted the pull request. I will go ahead and put a new PR from the renamed branch (susan/dataset-tutorial-for-stac).
Also, #140(comment) has been addressed in the new branch. Apologies for the confusion.

thanks @sdradsb , could you open a new PR with the new (renamed) branch?

@abarciauskas-bgse just created a PR with the new branch (susan/dataset-tutorial-for-stac)

PR Link : https://github.com/MAAP-Project/maap-documentation/pull/141


[BUG]: createSubscription does not populate subscriber information

Is there an existing issue for this?

[X] I have searched the existing issues.

🐞 Describe the Bug
When using <PayPalButtons />, the subscriber's information is not populated in the form fields. This is the code being used:
createSubscription={(_, actions) => {
  return actions.subscription.create({
    plan_id: selectedPlan.id,
    application_context: {
      cancel_url: window.location.href,
      shipping_preference: 'NO_SHIPPING',
    },
    subscriber: {
      email_address: profile.email,
      name: {
        given_name: profile.firstName,
        surname: profile.lastName,
      },
    }
  })
}}

And here is the simplified version of the code in CodeSandbox with all dependencies updated to the current as of submitting this ticket.
😕 Current Behavior
When I add the subscriber object to the props, the information is not populated in the form.
🤔 Expected Behavior
When I add the subscriber object to the props, I expect the information to show in the form.
🔬 Minimal Reproduction
1. Go to https://codesandbox.io/s/fancy-waterfall-odtfsg?file=/src/App.tsx
2. Click the Debit/Credit Card button
3. Observe none of the subscriber's info is populated

🌍 Environment
| Software         | Version(s) |
| ---------------- | ---------- |
| react-paypal-js  |  7.8.1     |
| Browser          |  Chromium  |
| Operating System |  Windows   |

Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

➕ Anything else?
No response

Bump

Bump


Feedback Feature: Game directory settings:

How did it automatically detect the game directory before because it seemed to quite work well.
Could this not be an optional setting if it fails to auto detect said directory instead of now being the default to select manually ?
I would assume especially for users where their RSI launcher and game files are separated by choice ?
In other words, if SCUtil is inside the \Roberts Space Industries\SCUtil, can it still autodetect the \Roberts Space Industries\Star Citizen\ folder ?

Just a suggestion, perhaps on the Settings > Game directory screen, add a note below  the text box and state that the user can select the drive or better yet the root folder on the drive where it is installed to speed up the detection


ERROR "Cannot read property 'state' of undefined"on windows7/10

INFO atParam is AKP94S2Rqa2ZIoWC8d91cKqwr1mGxI3lUA:1498938033896.
Uploading [=======================================================================================] 100% 0.0s
ERROR TypeError: Cannot read property 'state' of undefined
at C:\snapshot\upload-gphotos\lib\index.js:603:31
at next (native)
at onFulfilled (C:\snapshot\upload-gphotos\node_modules\co\index.js:65:19)
at tryCatcher (C:\snapshot\upload-gphotos\node_modules\bluebird\js\release\util.js:16:23)
at Promise.module.exports.Promise._settlePromiseFromHandler (C:\snapshot\upload-gphotos\node_modules\bluebird\js\release\promise.js:512:31)
at Promise.module.exports.Promise._settlePromise (C:\snapshot\upload-gphotos\node_modules\bluebird\js\release\promise.js:569:18)
at Promise.module.exports.Promise._settlePromise0 (C:\snapshot\upload-gphotos\node_modules\bluebird\js\release\promise.js:614:10)
at Promise.module.exports.Promise._settlePromises (C:\snapshot\upload-gphotos\node_modules\bluebird\js\release\promise.js:693:18)
at Async._drainQueue (C:\snapshot\upload-gphotos\node_modules\bluebird\js\release\async.js:133:16)
at Async._drainQueues (C:\snapshot\upload-gphotos\node_modules\bluebird\js\release\async.js:143:10)
at Immediate.e.Async.drainQueues (C:\snapshot\upload-gphotos\node_modules\bluebird\js\release\async.js:17:14)
at runCallback (timers.js:672:20)
at tryOnImmediate (timers.js:645:5)
at processImmediate [as _immediateCallback] (timers.js:617:5)
upload file type:mkv video file

Hmm... I have no idea why causing error...
Please check below and report to me.

Try to upload other .mkv file
Try to upload .mp4 file which converted from original
Try to upload small video file (if you will upload fuge file)
Try to upload via Web browser (Is your file supported by Google Photos?)
Check your video format via ffprobe

@3846masa I have sucessfully upload a 5GB mkv file to Google photos via the upload-gphotos linux client,so it might not be the size problem,and I can use firefox and chrome to upload the  same mkv video suceessfully which failed on upload-gphotos windows client.


Add test to check 'flow_names' argument is working as expected on FlowRequest results

Add tests under tests/statistics_filter
Get the traffic statistics based on flow_names argument
Validate the stats returned are based on user provied flow_names

Added with #190


oninput on input type="number" does not work properly

setSelectionStart is not supported on input type="number" (limitation in HTML standard) and because of the re-rendering, the cursor position goes to the beginning of the number after each keystroke. Typing 123 then yields 321.

One approach would be to use input type="text" and rebuild input type="number" functionality. We would need to have a way to set the cursor position from the server side. An attribute paro-cursor-selection-start=3 and paro-cursor-selection-end=3 would be possible, but not sure I like that idea.


[Docs-update] Introduction ecosystem contains deprecated and archived repositories

What docs page needs to be fixed?

Section: Introduction
Page: Ecosystem

What is the problem?
I find that there are some libraries mentioned in the documentation that are deprecated or archived.
The list of repositories that I checked:
Deprecated:

Angular-redux/store
Jumpsuit/jumpstate

Archived:

Redux-insights
Redux-ui
Redux-devtools-inspector
Redux-devtools-chart-monitor
Redux-little-router

What should be changed to fix the problem?
Removing the libraries from the ecosystem section.

Please feel free to file PRs that update that page!


ci: add empty circleci config to make github happy

Just for the time being until we have the circle ci config ready

Closing. Will push a PR with the real config.


pytest: add "--skip-flash" option

The pytest is always trying to flash when running on real HW (--device-type=hardware). On ARM64 Cortex-A platform like RPI5 there no way to implement flashing through pytest framework now: the Zephyr binary has to be stored on SD-card and loaded by bootloader.
Add "--skip-flash" option which still will allow to run pytest with shell interface manually after platform is booted and shell is ready.

@lorc @firscity @xakep-amatop @oleksiimoisieiev


add support for max-circular-dep

add support for max-circular-dep

Thanks @ReuDa. Could you please add a test for each command?

Hi @effoeffi ,
Thanks for having a look. In the meantime, I switched to the CLI in my Github Actions to have a bit more control over what's happening.
So I probably won't put any effort into this one. Sorry. Will close the PR.


Question: How would I do this with Phi 2?

Hi there!
Is it possible to teach Phi 2 model from Microsoft using this repo?
Thanks for info :).

Yes you can, though there is no official pretrained instruct model for phi2. That means you can use any chat template you like and maybe experimenting with a few will help.
All you have to do is pick one of our translated datasets for your language and change the base_model optional parameter in finetune.py.
In this case, DPO finetuning will greatly help too so try to do that after regular (SFT) finetune


Cookies on requests are sent "randomly" to API functions

If an Azure Functions API (for a Static Web App) includes a Set-Cookie header on the response, that cookie is provided "randomly" to future API requests, irrespective of what the browser actually sends (in a Cookie header) in an HTTP request to the API.
To reproduce
Basic SWA setup
Create a new GitHub repository with an empty HTML file. Create Static Web App through Portal as per these instructions; for build presets select "Custom", set API to /api.
Create an api folder; in that folder, run func init --worker-runtime dotnet then create a new Azure function with func new -t "HTTP Trigger" -n Test.
Function and Frontend
Create a simple C# function that reads the current value of the test cookie, and sets a new cookie if a setcookie query parameter is present: https://github.com/bgrainger/StaticWebAppCookies/blob/master/api/Test.cs
Create a simple JavaScript function in the HTML that makes repeated requests to the /api/Test endpoint, periodically setting a new cookie, and dumping the results into the current page: https://github.com/bgrainger/StaticWebAppCookies/blob/master/index.html
Expected output
If you run swa start and func start, you will get the following output in the HTML:
API output:
Request Cookie = .
Request Cookie = .
Request Cookie = . Setting cookie to 3.
Request Cookie = 3.
Request Cookie = 3.
Request Cookie = 3. Setting cookie to 6.
Request Cookie = 6.
Request Cookie = 6.
Request Cookie = 6. Setting cookie to 9.
Request Cookie = 9.
Request Cookie = 9.
Request Cookie = 9. Setting cookie to 12.

Every third request instructs the API to set a new cookie, and then subsequent requests send that cookie to the backend.
Actual output
Push the code to GitHub so that it gets deployed to Azure. My example site is at https://nice-grass-0c7fb261e.azurestaticapps.net/. It produces this output:
API output:
Request Cookie = .
Request Cookie = .
Request Cookie = . Setting cookie to 3.
Request Cookie = 3.
Request Cookie = .
Request Cookie = . Setting cookie to 6.
Request Cookie = 3.
Request Cookie = 6.
Request Cookie = . Setting cookie to 9.
Request Cookie = .
Request Cookie = 3.
Request Cookie = 6. Setting cookie to 12.
Request Cookie = 12.
Request Cookie = 12.
Request Cookie = 3. Setting cookie to 15.
Request Cookie = .
Request Cookie = .
Request Cookie = . Setting cookie to 18.
Request Cookie = 18.
Request Cookie = 18.
Request Cookie = 15. Setting cookie to 21.
Request Cookie = 12.
Request Cookie = .
Request Cookie = 18. Setting cookie to 24.
Request Cookie = 21.
Request Cookie = 21.
Request Cookie = 21. Setting cookie to 27.
Request Cookie = 24.
Request Cookie = 9.
Request Cookie = 27. Setting cookie to 30.

Note that due to https://github.com/Azure/static-web-apps/issues/371, the Set-Cookie header actually includes expires=Mon, 01 Jan 0001 00:00:00 GMT; so it's never actually set in the browser. That is, the web browser never actually sends a Cookie header to the Static Web App API. Yet the API is reporting that it's set on most requests. (If you were to fix that expires setting on the cookie you would still find that the cookies read by the API are "random" and unassociated with the actual requests.)
If the cookie is used for authentication, this could be a serious security issue, as logged-in users might see data for other users (because the cookies sent by the browser are unrelated to the cookies processed by the Functions API backend).
On a minor note, it's a little frustrating that local development doesn't reproduce this problem; it only happens when it's deployed to Azure.

There's no problem inside a standalone Azure Functions App (without the Static Web App proxy): https://cookie-test-func.azurewebsites.net/api/Home deployed from https://github.com/bgrainger/FunctionsCookies.

Thanks @bgrainger we'll look into this. /cc @mkarmark

The fix for this issue has now been globally deployed, and customers should no longer experience this behavior. Let me know if there is still any unexpected behavior regarding the function cookies!

Looks good; thanks!


Add transfer learning (TL) technique such as ProjectR to scanpy

[ ] Additional function parameters / changed functionality / changed defaults?
[x] New analysis tool: A simple analysis tool you have been using and are missing in sc.tools?
[ ] New plotting function: A kind of plot you would like to seein sc.pl?
[ ] External tools: Do you know an existing package that should go into sc.external.*?
[ ] Other?

We are increasingly using ProjectR as a transfer learning technique from one dataset onto others.  It would be great if this were part of the scanpy package, since most of the rest of what we do with single-cell uses scanpy.  I'm going to start working on integration of the two but doubt I have the data science experience currently to submit a PR to this project for it.
Are there any plans already in the works to pull in transfer-learning techniques such as this?
Relevant links:

Article in Bioinformatics
Article in Cell
GitHub

Hi @jorvis ,
ProjectR as far as I'm aware relies on some form of matrix decompositon (PCA, NMF) and do transfer learning with learnt weights. In some sense, it's similar to ingest. However, it would be a bit complicated to port it from R.
It doesn't seem super complicated to have it in scanpy as an additional tool, but it's not really a priority now. If you have anything in mind and would want to try with submitting a PR, it would be very much appreciated and we would definitely have a look!
I'll close this for now, but pls feel free to re-open if you want to continue discussion or would like to discuss implementation.


Any call to modal.destroy() throws a jQuery addClass error

It seems that when using Marionette and Backbone.modal, any call to modal.destroy() whether from the modalsContainer (i.e App.modalsContainer.destroy()) or from within the view (i.e. this.destroy) uses a reference to this.modalEl instead of this.$el.
This causes an undefined reference in a jQuery addClass statement to fail with:
Uncaught TypeError: Cannot read property 'addClass' of undefined

inside the Modal.prototype.destroy function, particularly with this line:
this.modalEl.addClass("" + this.prefix + "-modal--destroy");

I currently just run this in the onDestroy() event handler in the view to get around it but this should be fixed:
this.modalEl = this.$el

this.modalEl is actually a wrapped element around the template and is generated on render. Did you overwrite the render method in your view? That would explain it, because I can't reproduce this.

Ah yes, I was overwriting render. That explains it. Thanks!


Item Modals: Unleashed Edition

Might close #87
Featuring:
Namespace tooltips with searching (fixes #minecraft:pickaxes and #c:pickaxes being indistinguishable)

This uses platform-specific implementations for getting mod titles, so we had to fix an issue in the buildscript that broke those.

Replacing IconModal and ItemQuestIcon(Item) with ItemModal and ItemQuestIcon(ItemModal.Value)
https://github.com/terrarium-earth/Heracles/assets/55819817/9dc44130-0793-4ba9-afa1-0924365c0cd1
https://github.com/terrarium-earth/Heracles/assets/55819817/9d55d044-56f7-4e9e-8f5a-a0d0bd261107

ItemModal.Value seemed very useful and very related to RegistryValue, so I made it into a class called ItemValue that extends RegistryValue instead. It can similarly represent an itemstack (with nbt), a tag, or an item.
The inheritance is a bit messy as RegistryValue was never really designed for this, so that could be improved in the future.

Also fixed a crash and made it so that item task icons show their NBT (for, for example - this potion task! which showed a water bottle before, and only said Potion in the title)

The good news is - Our current quests still work great! which would imply there aren't any legacy codec parsing issues.

Set for review again.

Looks like a change has introduced some codec issues and crashing so I've gotta check that out first.

Sorted! Accidentally put a null where a t -> null should've been during either mapping, assuming that was a valid shortcut.
Set for review again!


Windows compatibility

Make it windows compatible. Needs src-d/go-siva#40.
Fixes #29

Works beautifully for me https://github.com/src-d/hercules/pull/197 Thank you @jfontan :+1:


⚠ BeyondHD has degraded performance

In 2ed9582, BeyondHD ($BHD) experienced degraded performance:

HTTP code: 200
Response time: 1145 ms

Resolved: BeyondHD performance has improved in c353bb7.


names of layers

Converter has feature for keeping the layers of the names same using names='keep'. I have a pytorch model which has some common names for layers. It would be better if they can be names as 'layer1', 'layer2' and so on if 'layer' is repetitive.

Hello, yes, would be good to have this naming policy. Will schedule this feature.


Fix pod Index

The Index we previously used MUST be added before the informer starts. This is challenging when we use a shared index informer, especially if we consider this is not always used, multicluster, possible future usage of indexes, etc.
Previously, there were race conditions where sometimes the indexer was added after the informer started.
Instead, we re-implement the Index concept on top of informers, to work around this issue. This also allows us to expose a much easier to use API.
Please provide a description of this PR:

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio_exp
50a7f1ac78535ef55b32973887f2a6a67ebe354c
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Add Table of contents to readme[GSSOC'23]

Is your feature request related to a problem? Please describe.
User cannot go directly to something he is searching in readme file , he has to read full readme file to find a specific part.
Describe the solution you'd like
Making a table of contents for readme file makes it easier for users to navigate through readme file with ease. They can directly click on the link to go to required section.
It will look similar to this:

Describe alternatives you've considered
No response
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @Durgesh4993 thanks for raising this issue. But we don't need it for now/


Added check for sane pixel spacing value

When pixel spacing values are malformed, such as "0.2\0\0.20000", the pixel spacing values can be set to incorrect values, such as 0. This breaks basically all functions in Cornerstone. This PR just adds a check for sane pixel spacing values.

merge conflict, integrating on master


Add ValidationView

For the HS256 algorithm it would be nice to have a view that you can pass a token and it returns if it's valid or not. For when you don't want to hand out your secret but still want to offer a way to validate the token.

Thanks for reminding me about this.  I meant to add something like this a while ago when I was trying to provide similar features as django-rest-framework-jwt but I ended up forgetting about it.  I'll try and find some time over the weekend to add this.  Tested pull requests are also welcome.

Feel free to wait.

It's not that important
We'll probably use this at work so I'll have some time to do it and do a pull request. ;-)

See #12

@hvdklauw I ended up taking a different approach to fixing this issue.  I'm bummed I didn't get to use your work, but I really appreciate your taking the time to do it all the same.

Awesome, I think your solution is much nicer!


New fork swagger-typescript-api-nextgen with extra features and fixes

Please check out my fork: swagger-typescript-api-nextgen, maybe it will be useful for those who need a secure version with updated dependencies, as well as support for current axios and other fixes.
The package is present in the npm (swagger-typescript-api-nextgen).
✨ The fork key differences

Axios v0.27.2+ support
Updated dependencies to eliminate vulnerabilities
Merged features and fixes from next to master and some commits from origin pull requests:

Docs: added "generateClient", "typePrefix", "typeSuffix" options to readme for NodeJS usage (#335)
Feature: add an option to disable throwing an error when request.ok is not true (#297)
Feature: add a parameter to sort types and types properties (#299)
Feature: load prettier config from your project by default (#286)
Feature: allow passing "patch" option to "swagger2openapi" (#283)
Fix: missing title of object type (#303)
Fix: reject and exit with code 1 if error (#295)
Fix: missing extractRequestBody field in type
Fix: problem with missing HttpResponse type with --to-js option
Fix: unable to cancel fetch request with AbortSignal (#329)

Is there a reason these changes aren't a PR for swagger-typescript-api project?

Looks like recently, activity is returning to this repo. Maybe this would be a good time to have the changes merged back into this original repo?

Hi @grandsilence , your fork looks good !
This project is not abandoned, just I was not have a free time to work on it :)
If you want to improve your fork, please merge the latest version of swagger-typescript-api, cause I fixed a lot of bugs and add a lot of features :)

Hi @js2me,
First of all, thanks for the great work on the generator.
I am currently using the nextgen package, but would love to switch back to the original one. That being said, the main reason I started using the swagger-typescript-api-nextgen was this change:
templates/base/http-clients/axios-http-client.eta
- import axios, { AxiosInstance, AxiosRequestConfig, AxiosResponse, ResponseType } from "axios";
+ import type { AxiosInstance, AxiosRequestConfig, AxiosResponse, ResponseType } from "axios";
+ import axios from "axios";

For my project, not using type modifiers for type-only imports throws errors, because of the following tsconfig.json options:
{
  "compilerOptions": {
    "preserveValueImports": true,
    "importsNotUsedAsValues": "error",
  }
}

Is there any chance this could make it into one of the following versions?


GO:0140295    pathogen-derived receptor ligand activity  /needs qualification

GO:0140295    pathogen-derived receptor ligand activity
Definition (GO:0140295 GONUTS page)
The activity of a pathogen-derived entity that interacts with a host receptor to activate effector-triggered immunity. PMID:20601497
This is a term we requested to annotate a necrotrophic effector.
This term should only be used  got necrotrophic effectors whose evolved function is to act as a ligand to  induce the plant host immune system.
We should add to the definition.
We can also be more precise about the receptor when
https://github.com/geneontology/go-ontology/issues/18031
(this is the only receptor)
Once 18031 is done I will refine this definition accordingly

Also add synonyms:
exact necrotrophic effectors
exact host-selective toxins
PMID:22241993
The cysteine rich necrotrophic effector SnTox1 produced by Stagonospora nodorum triggers susceptibility of wheat lines harboring Snn1.
Abstract
The wheat pathogen Stagonospora nodorum produces multiple necrotrophic effectors (also called host-selective toxins) that promote disease by interacting with corresponding host sensitivity gene products. SnTox1 was the first necrotrophic effector identified in S. nodorum, and was shown to induce necrosis on wheat lines carrying Snn1. .......The SnTox1-Snn1 interaction results in an oxidative burst, DNA laddering, and pathogenesis related (PR) gene expression, all hallmarks of a defense response. In the absence of light, the development of SnTox1-induced necrosis and disease symptoms were completely blocked. ...... This research further demonstrates that necrotrophic fungal pathogens utilize small effector proteins to exploit plant resistance pathways for their colonization, which provides important insights into the molecular basis of the wheat-S. nodorum interaction, an emerging model for necrotrophic pathosystems.

A comment had already been added.
Add synonyms
related necrotrophic effector
related host-selective toxin

I don't know why I referenced 4412 it should have been 18042, closing...


Hackage release?

Working on it..

Done.. -> https://hackage.haskell.org/package/hspec-webdriver-1.2.1


Demo: Mimic "Princeton Digital Library of Islamic Manuscripts" in Pom

http://library.princeton.edu/projects/islamic/
Not with all objects, obviously, but this is a really good case for what we want from Pom.

When we build this, we should export the exhibit so we can still wipe Pom's staging and put it back in.