Explorer preview integration not working properly after upgrading Win10 to Win11

Microsoft PowerToys version
0.85.1
Installation method
GitHub
Running as admin
No
Area(s) with issue?
File Explorer: Preview Pane
Steps to reproduce
I had issues after upgrading to Win11. PDF, TXT, and SVG previews were not working anymore.
Here is what I had to do to fix it:
https://www.elevenforum.com/t/windows-11-pro-no-longer-shows-preview-of-pdf-files.19042/post-511236
In short: I had to DISable PDF and Source code file previews in Power Toys.
PDF, and TXT might have to do with conflicting preview handlers (Acrobat handler for PDF, Windows built-in handler for TXT).
Weird though that I had to DISable SVG previews and ENable SVG thumbnail previews for them to work again in the preview pane.
✔ Expected Behavior
I was expecting that nothing would change due to the upgrade to Win11, as I had not installed any programs or apps afterwords.
❌ Actual Behavior
Previews for PDF, TXT and SVG had stopped working in the preview pane.
Other Software
Likely Adobe Acrobat PDF preview handler, Win11 built-in TXT preview handler (if exists)

I have a similar issue, except that in my case, I can see that SVG and PDF previews are working, but TXT previews will not...
errr, wait a second, all of a sudden it started working perfectly. I didn't even change any settings.
That's very odd.

The only thing I can think of to explain this behavior is that I uninstalled and reinstalled PowerToys and then disabled ans re-enabled Peek before I posted the above message, and that there was a delayed resolution of the preview pane error for some reason.


Help to make Expand Cardview with this library :/

Hello guys, I have my own card and I want to make them ExpandCard with this library
I hope some can help soon :(

It isn't too hard to implement.
You need use 9-patch and some custom drawables...


ImportError: cannot import name 'WarmupLinearSchedule' from 'transformers'

How to Overcome this error?

@adiv5 hi
from transformers import AdamW, get_linear_schedule_with_warmup
# line 81
lr_scheduler = get_linear_schedule_with_warmup(optimizer, warmup_steps=warmup_steps, t_total=t_total)

@adiv5 hi
from transformers import AdamW, get_linear_schedule_with_warmup
# line 81
lr_scheduler = get_linear_schedule_with_warmup(optimizer, warmup_steps=warmup_steps, t_total=t_total)

I guess t_total is replaced by num_training_steps. Refer to transformers doc

The syntax is:
from transformers import AdamW, get_linear_schedule_with_warmup
# line 81
lr_scheduler = get_linear_schedule_with_warmup(optimizer, num_warmup_steps=warmup_steps, num_training_steps=t_total)

The syntax is:
from transformers import AdamW, get_linear_schedule_with_warmup
# line 81
lr_scheduler = get_linear_schedule_with_warmup(optimizer, num_warmup_steps=warmup_steps, num_training_steps=t_total)


Stochastic sinkhorn: add rng to solver arguments

Add random number key to sinkhorn API.
This can be used for:

subsample data points in initialization
possibly for projected transport

Started working on this here:
https://github.com/JTT94/ott/tree/subsample_initializer
Will detail proposal in full once tested
Example:
https://colab.research.google.com/drive/1jIrrBwCbg783dtxfzwDmLX87OuGyx5nm?usp=sharing

#309  closes


How to import the functions and static variables from another .ipynb file?

Hi everybody. If I want to implement some functions in a .ipynb file, and invoke these functions in another .ipynb file, is there any way to do that?
I saw "%run" or "%load" work with Python kernel, but not in IJava kernel.
Thanks a lot.

Hi @BoyuanYan, I misunderstood this as a duplicate of #52 but it is really an extension of it to also work with notebooks.
Currently implementing it in the base kernel and will have this available under %load as well. Thanks for the suggestion!

Support landed in SpencerPark/jupyter-jvm-basekernel@114023d314554fbb9d0c0992eb740abcaa679a6c and so we will get this in IJava in next release.

Got it. Thanks for your response.


request: add "consortium" as legal person

There is a request from @maciej-jedynak to add a "consortium" schema as legal person
Definition:
A consortium is an association of two or more individuals, companies, organizations or governments with the objective of participating in a common activity or pooling their resources for achieving a common goal. (https://en.wikipedia.org/wiki/Consortium)
I was thinking of making a simple schema:

shortName
fullName
members
homepage
contactInformation

@apdavison @olinux @UlrikeS91 @bweyers what do you think?

ok with me

Same here. Sounds useful, no objections 🙂

@olinux & @bweyers I will implement this request then. @olinux once it's done the EBRAINS KG (Editor & Search) needs an update I assume.


fix: re-export tonbo_macro::KeyAttributes

Close #94

Just ran cargo +nightly fmt, CI should pass now.

Thank you @QuarticCat 😄 I hope there are more collaborations in the future


Update to Source Files for November Release

Updates the source files pf the langpack with the latest strings, and updates the XLFs as well.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 41.578%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
30788

Relevant Lines:
69356

💛  - Coveralls


comment_hashtag missing amount in definition

Hello
Placing some test I discovered that is missing the amount field in the sign function:
instabot/bot/bot.py
315   def comment_hashtag(self, hashtag):
316	        return comment_hashtag(self, hashtag)
Instead in implementation function:
instabot/bot/bot_comment.py
46   def comment_hashtag(self, hashtag, amount=None):
47	    self.logger.info("Going to comment medias by %s hashtag" % hashtag)

Thanks, @maverjk!


Role timers sometimes don't update/save on Wizard's Den

Description
On Wizard's Den, role timers sometimes don't appear to be saving correctly.
I'll play a role, say chemist, that should count towards CMO. Before a round, I'll see "X more minutes" needed for CMO. After the round, sometimes my role timer will update correctly (I see less minutes required for CMO). Sometimes, X doesn't change.
Reproduction
I'm not sure. I wasn't able to reproduce locally (using the default sqlite database on Win 10) yet. Maybe I haven't tried hard enough. But this has happened to me several times on Wizard's Den. I've spoken to admins and other players and believe this is not an isolated issue.
Screenshots
N/A
Additional context
If you believe you've seen this happen to you, please comment with:

The server you were playing on
Role(s) if you remember
Phase of the moon? Time of day? Anything else you might think is relevant.

Departments as a whole aren't tracked.

Departments as a whole aren't tracked. Only the requirement as a sum of its parts.

I misspoke there. Edited "for medical units" to "towards CMO". Point being, some of the time played isn't being counted.

Overall or role playtime?

both

Does this persist even after rejoining?

fixes on rejoin is what ive heard from several players

So the role times are being tracked correctly but in some situations server doesn't send the updated timers to clients. FWIW role timers are only sent in round lobbies.

Rejoining doesn't fix it for me, nor does it fix it if I rejoin after 12 hours. I think it's not saving correctly, too.
In the rounds where it saves correctly, I see it update immediately by the next round.

You can quickly find many player reports of the timer not updating by searching "timer" on the official Discord.
I still don't have a reliable way to reproduce.
I fixed a logic error in #10681 that (I believe) is not related to this issue. We'll find out in a day or two whether or not this improves things or makes no difference.

Another example as recent as yesterday posted on the forums: https://forum.spacestation14.io/index.php?/topic/1146-i-played-sec-for-about-3-hours-trying-to-get-the-final-minutes-to-unlock-captain-just-to-find-out-that-the-game-counted-none-of-them/
At this point we probably need a server admin to help debug this.

fixed?


arm_joint_controller reports status ABORTED

I'm trying to control utra6_850 using Rviz
I already succeeded controlling the manipulator using ut_arm_dashboard
But when I use command
roslaunch utra_controller utra_server.launch utra_ip:=<IP_ADDRESS>
and
roslaunch utra6_850_moveit_config run_with_utra.launch utra_ip:=<IP_ADDRESS>
I could plan the path, but planning time was very short like 0.02 sec even I changed Velocity scaling & Accel scaling
In my opinion, It was impossible to control the velocity of robot now
Also most of case, execute was failed with error
[ INFO] [1681462929.607289224]: call ret: 0
[ INFO] [1681462929.607301980]: Recieve action successful!
[ERROR] [1681462929.711048367]: utra pause or stop!!
[ INFO] [1681462929.711227509]: Controller utra6_850/arm_joint_controller successfully finished
[ WARN] [1681462929.711383446]: Controller handle utra6_850/arm_joint_controller reports status ABORTED
[ INFO] [1681462929.711471542]: Completed trajectory execution with status ABORTED ...
[ INFO] [1681462929.711631766]: Execution completed: ABORTED
[ INFO] [1681462929.726594582]: ABORTED: Solution found but controller failed during execution

What should I do to solve this problem?
Oh also I saw an error in dashboard like this

Hi,
were you able to solve it?
I have the same problem and after searching I think that the problem is becouse the hardware and gazebo is trying to send back to moveit.
if you see the end of the rqt graph there is gazebo and utarm_servo_... trying to communicate with move_group

and the terminal for moveit are outputting in high speed:
[ WARN] [1702377795.979577824,<PHONE_NUMBER>00]: processStatus: Previously received status from [/gazebo], but we now received status from [/utarm_mvservo_trajectory]. Did the ActionServer change? [ WARN] [1702377796.052882026,<PHONE_NUMBER>00]: processStatus: Previously received status from [/utarm_mvservo_trajectory], but we now received status from [/gazebo]. Did the ActionServer change? [ WARN] [1702377796.187705629,<PHONE_NUMBER>00]: processStatus: Previously received status from [/gazebo], but we now received status from [/utarm_mvservo_trajectory]. Did the ActionServer change? [ WARN] [1702377796.257843731,<PHONE_NUMBER>00]: processStatus: Previously received status from [/utarm_mvservo_trajectory], but we now received status from [/gazebo]. Did the ActionServer change? [ WARN] [1702377796.386407734,<PHONE_NUMBER>00]: processStatus: Previously received status from [/gazebo], but we now received status from [/utarm_mvservo_trajectory]. Did the ActionServer change? [ WARN] [1702377796.457298436,<PHONE_NUMBER>00]: processStatus: Previously received status from [/utarm_mvservo_trajectory], but we now received status from [/gazebo]. Did the ActionServer change? [ WARN] [1702377796.590359939,<PHONE_NUMBER>00]: processStatus: Previously received status from [/gazebo], but we now received status from [/utarm_mvservo_trajectory]. Did the ActionServer change? [ WARN] [1702377796.662512541,<PHONE_NUMBER>00]: processStatus: Previously received status from [/utarm_mvservo_trajectory], but we now received status from [/gazebo]. Did the ActionServer change? [ WARN] [1702377796.835774545,<PHONE_NUMBER>00]: processStatus: Previously received status from [/gazebo], but we now received status from [/utarm_mvservo_trajectory]. Did the ActionServer change?
so should we close one of these topic forcefully?

Hi , did you solve this problem?
I think my problem has a connection with your problem.
https://github.com/UmbraTek/ut_arm_ros/issues/7#top

Hello
Looking at studio shows that the controller reported an error, and all the problems were due to the fast speed of the planning trajectory of rviz, which caused errors and execution failures. When the control error is reported, the error needs to be reset first, and the execution time (speed) of rviz needs to be controlled.

Hi , did you solve this problem?
I think my problem has a connection with your problem. #7 (comment)

Hi
Yes I sloved this problem
I think I deleted all package and re-installed, and everything was working well
And My problem was related to controll robot in real-word, but your problem is to controll robot in gazebo, so just follow the manual and search more information in google

uninstalling and installing everything ros related solved it.
thanks


Feature Request: Sitemap

A website (or a part of it) should have a sitemap.
@themsaid Do you plan such a feature? Or do you prefer a PR for that? I can implement that, if you want to.

As @mallardduck mentions, it's outside the scope of the package, wink is just the dashboard for your content, it can include some helpers to help with the frontend but I don't see a sitemap or RSS feed are to be considered, there are tons of packages out there to help you with that.


Root fixed on Gpose

Hello, until now I did not encounter any problem with Customize, but following an update, as soon as I enter Gpose, there is a feature that I can no longer use, it is the modification of the dimension of the character ... indeed, when I try to reduce or enlarge a character... it automatically reverts to 1, and it's problematic, knowing that I would like to benefit from the advantages of C+ AND the advantages of Anamnesis, but that I have to choose between the two.

+1

Note #84 first paragraph.
Also note that C+ intention is mostly use outside of Gpose, many features will disable itself inside gpose.
Also please refrain from bumping your own issues.


Question: Using both ReplayMod and ServerReplay together?

Hi,
can this be installed alongside the usual ReplayMod?
I'm specifically talking about the situation where I would play a singleplayer world and share it to LAN (the LAN world in Minecraft runs as an integrated server).
Will there be any interference between ServerReplay and Replaymod or will these work together?

You don't even need to share it to LAN. It should work out of the box. You can also change the recording directory to be the replay client directory so you don't have to move files around.
I haven't actually tested it but there shouldn't be any issues, if there are please report them here - it is a bug and I will fix it.


Order Edits by Locations

This PR changes the Ordering of Edits from content > location > end_location
to location > end_location > content.
This is the more natural order in my view and has the added benefit that
comparing the content is only necessary for edits that start and end at the same
location, which should be rare.
Changing the field order, unfortunately, changes all snapshots...
A good example why we shouldn't use the serialized Diagnostic in test assertions.

Current dependencies on/for this PR:

main

PR #3895

PR #3896

PR #3897

PR #3901

PR #3904

PR #3905   👈

This comment was auto-generated by Graphite.


Added new term "idiopathic"

fix #3177

I created :

New subclass of ‘disease characteristic’ class: ‘idiopathic vs non-idiopathic’
2 subclasses of ‘idiopathic vs non-idiopathic’:
---‘idiopathic’
---‘non-idiopathic’ subclasses
I added axiom to express that ‘idiopathic’ and ‘non-idiopathic’ are disjoint

Still to do (if review is ok)

[ ] Add source to the subclass and general class axioms
[ ] Add definition to the new ‘idiopathic vs non-idiopathic’ class

@nicolevasilevsky : could you please check that I created the terms correctly?
I have some questions (especially about the axiom, I want to make sure I got it right) whenever you have reviewed this draft and you have a moment.

I don't see the disjoint axiom, I added it so you can see how it looks. Good idea!

for the source on the subclassOf axiom, you can add your ORCID
nice job on this, looks good!

Thank you @nicolevasilevsky
I did add the disjoint axiom in protege, and I can see it on my computer... Next time we meet, let's check that I added it correctly/in the right place.


Should we switch to always using phenomT for the zeroecc waveform?

Right now, we use PhenomT only for NR, while for other models like SEOB/TEOBResum we use the quasicircular limit of those models.
Another option is we say our definition of ecc/meanano is to use PhenomT as the quasicircular waveform. This can make it more standard in some sense.
However, for the package itself, the user is required to provide the dataDict, so it's up to them.
I'm talking more about what plots we show in the paper.

We already have the option to provide the approximant for zero ecc waveform when loading NR modes. For LAL it uses the same approximant as the ecc one. May be add an option for LAL as well in the future. Closing it for now.


Fix: Updated algorithm typo

Please drizzle community, I just updated this PR and it includes very important bug fixes


pull request for e2e test at 12/15/2016 02:45:10

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Facades on connectors not dropping when broken

Not sure if this is intended behavior but when I break a facade that is on any connector (all 4 colors both regular and advanced and the routing connector) the facade block doesn't drop. Breaking facades on cables the facade block drops.
Versions:
xnet-1.12-1.6.7
mcjtylib-1.12-2.6.5

Does this still happen in XNet 1.6.8? What tool are you breaking it with?


Updated icons based on Spotify's redesign

Here's updated assets for Spotify-Notifications, based on the Spotify redesign. Included are:
AppIcon.icns
icon.icns
status_bar_colour.tiff

https://dl.dropboxusercontent.com/u/8895/spotify-notifications-icons.zip
Here's what it looks like with the proper icons:

:+1:

@randybruder could you PR that thing? or create a fork?

@drewcovi I don't see how, the three files mentioned in the original post aren't in the Github project, just the compiled release. Don't know how to PR/fork it if the files aren't there for me to replace.

@randybruder Check the 0.5.X branch (https://github.com/citruspi/Spotify-Notifications/tree/0.5.X), the status bar assets are under Spotify Notifications and the app icons are under Spotify Notications/Images.xcassets/AppIcon.appiconset.

+1 for this PR

Ok, made a PR. No idea if I did it right.
https://github.com/citruspi/Spotify-Notifications/pull/54

@randybruder  I think you did it right, but the images are the old green not the new green.

Ok, think I did it right this time.
https://github.com/citruspi/Spotify-Notifications/pull/55

dy-no-mite! well done on what I'm guessing is a first PR! For future reference, you can always continue to commit to an open PR, no need to close and create anew!

Well, first two now. It was the different branches thing that was tripping me up, I didn't realize forking a repo would also fork all the branches too. Thanks for your help.

Rad! Does anyone know how to update the application file on the main website?

That would involve compiling the code (probably updating the version to 0.5.2) and having @citruspi update the main website.

That would involve compiling the code (probably updating the version to 0.5.2) and having @citruspi update the main website.

Correct. Sorry about dropping the ball on this, it's been on my todo list but it just kept getting postponed.
I'll need to do a couple things to get the pull request shipped. I'd like to accomplish these today, but I'm going to provide a checklist so that the status of the issue is a little more transparent.

[ ] Review the changes
[ ] Bump the version and update the Change Log
[ ] Merge the changes in
[ ] Build and codesign an archive for users
[ ] Tag the release and upload the archive
[ ] Update the link on the site
[ ] Update the recipe for Homebrew Cask

I'll update this pull request as I make progress towards it.
Also, big thanks to @randybruder for the pull request and congrats on the first (two) pull request(s)! :tada:

Okay, so its been merged, archived, signed, tagged, and released. The website has been updated.
I've submitted a pull request to Homebrew Cask for the new version - caskroom/homebrew-cask#14276.
I think once that's merged in we're good to go.

Hot damn

:+1

+1

Well, it's official. :cake:

Nice one! :tada:

This is great, thanks @citruspi @randybruder !
:clap:


testrun: print time

Could be merged to 6.10.0.

Just to see how the output is, I looked at https://travis-ci.org/UIUC-PPL/charm/jobs/601931014#L5471 and I don't see time being printed by testrun.
Running on 1 processors:  ./msgqtest +setcpuaffinity
charmrun>  /usr/bin/setarch x86_64 -R  mpirun -np 1  ./msgqtest +setcpuaffinity
Charm++> Running on MPI version: 3.1
Charm++> level of thread support used: MPI_THREAD_FUNNELED (desired: MPI_THREAD_FUNNELED)
Charm++> Running in SMP mode: 1 processes, 1 worker threads (PEs) + 1 comm threads per process, 1 PEs total
Charm++> The comm. thread both sends and receives messages
Converse/Charm++ Commit ID: v6.10.0-rc2-21-g0ad4991
CharmLB> Load balancer assumes all CPUs are same.
Charm++> cpu affinity enabled.
Charm++> Running on 1 hosts (1 sockets x 1 cores x 2 PUs = 2-way SMP)
Charm++> cpu topology info is gathered in 0.000 seconds.
All 8 stl msgQ tests passed
[Partition 0][Node 0] End of program

Just to see how the output is, I looked at mpi-smp test from travisci for this patch (https://travis-ci.org/UIUC-PPL/charm/jobs/601931014#L5471) and I don't see time being printed by testrun.
Running on 1 processors:  ./msgqtest +setcpuaffinity
charmrun>  /usr/bin/setarch x86_64 -R  mpirun -np 1  ./msgqtest +setcpuaffinity
Charm++> Running on MPI version: 3.1
Charm++> level of thread support used: MPI_THREAD_FUNNELED (desired: MPI_THREAD_FUNNELED)
Charm++> Running in SMP mode: 1 processes, 1 worker threads (PEs) + 1 comm threads per process, 1 PEs total
Charm++> The comm. thread both sends and receives messages
Converse/Charm++ Commit ID: v6.10.0-rc2-21-g0ad4991
CharmLB> Load balancer assumes all CPUs are same.
Charm++> cpu affinity enabled.
Charm++> Running on 1 hosts (1 sockets x 1 cores x 2 PUs = 2-way SMP)
Charm++> cpu topology info is gathered in 0.000 seconds.
All 8 stl msgQ tests passed
[Partition 0][Node 0] End of program

Thanks, should be fixed now.


TypeError on first run

Fresh Docker install from Unraid Community App Store.
No log file available (latest docker version)
Link to logs (required)
TypeError: '<' not supported between instances of 'str' and 'int' Traceback (most recent call last):   File "//plex_meta_manager.py", line 69, in <module>     if screen_width < 90 or screen_width > 300: TypeError: '<' not supported between instances of 'str' and 'int'

can you try using the develop tag and see if it works

It appears that corrected the issue. Trakt authentication finished, and now it has connected to my libraries. Thanks!

no problem!


[faq] different typefaces?

as far as I can tell, the font size and maybe even type are different in the question and answer sections (see screenshot). looks a bit strange, should be adjusted.

This is closes by #77


RTIC Monotonic for RTC and TIMER

This PR aims to add rtic monotonic implementations for the RTC and TIMER.
As #384 requested. This would allow users of the hal to use native implementations
of the Monotonic trait rather than third-party ones and therefore ensure future support for the
feature.
Added

monotonic.rs ( holds all of the rtic monotonic related implementations )
2 new optional dependencies, fugit and rtic-monotonic
1 new feature flag for all hals --features monotonic
1 new example crate ( monotonic-blinky )

Features

Configurable frequency ( can use all valid frequencies for the rtc and timer respectively )
Compile time or initiation time guarantees that the frequency is valid.

Usage
There exists an example of how to instantiate the monotonic rtc and timer in nrf-hal/examples/monotonic-blinky.
RTC
The RTC cannot at compile time guarantee that the frequency is correct.
It does however check this at initiation time, so for any invalid
frequency it will throw an error leaving the user to correct the frequency.
By taking a reference to the clock object we can ensure that the
lfclk is enabled.
// RTC0 with a frequency of 32 768 Hz
type MyMono = MonotonicRtc<RTC0, 32_768>;

let clocks = hal::clocks::Clocks::new(cx.device.CLOCK);
let clocks = clocks.start_lfclk();

let mono = MyMono::new(cx.device.RTC0, &clocks).unwrap();

Timer
The timer abstraction supports frequency gating since there are only 9 different prescaler values.
This ensures that the MonotonicTimer object is not constructible for any frequency that does
not yield a valid prescaler. The documentation for the MonotonicTimer lists all
valid frequencies in a table with their corresponding time until overflow.
// RTC0 with a frequency of 16 MHz
type MyMono = MonotonicTimer<TIMER0, 16_000_000>;
let mono = MyMono::new(cx.device.TIMER0).unwrap();

Recommended actions
Squash and merge to remove the long commit history.
Alternatives
There are already a few third-party implementations of these features that are less configurable

https://gist.github.com/korken89/fe94a475726414dd1bce031c76adc3dd
https://github.com/kalkyl/nrf-play/blob/47f4410d4e39374c18ff58dc17c25159085fb526/src/mono.rs
https://github.com/rtic-rs/rtic/tree/master/rtic-monotonics/src/nrf

@diondokter Not quite sure how the review process works but figured I'd mention you here since we have discussed earlier PRs

Hey, this looks pretty nice! However...
I'm not a maintainer here (though I think I might have some limited permissions). In fact, this crate has no active maintainers at this point...
So I don't know how to continue. Best thing would be to find a new maintainer.
Lately in the embedded rust matrix chat, the recommendation has been to go with embassy-nrf which you can use blockingly as well.

@qwandor Would you mind looking through this?

Thanks! I've updated this to work with current master and fixed a bunch of small things. It looks good, except that it doesn't build for nrf51 or nrf52832. Is that expected?

Thanks! I've updated this to work with the current master and fixed a bunch of small things. It looks good, except that it doesn't build for nrf51 or nrf52832. Is that expected?

This should not be the case, at least not for the nrf52832 chip as the docs specify the same field, I think that it is simply a matter of the field names either not existing in the pac or being different from that of the nrf52840 that we tested on. I will look into it

Thanks for working on this!
I'm easily confused. Should this trait be named rtic-monotonic? Or is it more general than that?

@qwandor  it seems that we might need to modify the bits manually or re-write parts of the PAC. As this is a small feature I think that it is better to simply unsafely modify the bits and not re-write the PAC for this.
I implemented a short fix that should be tested before including as it adds three extra bits of unchecked unsafe code.
https://github.com/Kyrne/nrf-hal/tree/fix_missing_parts_of_pac

Thanks for working on this!
I'm easily confused. Should this trait be named rtic-monotonic? Or is it more general than that?

This is probably a good idea.

Thanks! We should probably fix the PAC to add the missing fields, but I'm alright with this for now.

Thanks for working on this!
I'm easily confused. Should this trait be named rtic-monotonic? Or is it more general than that?

Do you mean the feature flag?

Thanks! We should probably fix the PAC to add the missing fields, but I'm alright with this for now.

If at all possible it would be great to test it on these devices though, I only have access to 52840 devkit so I cannot test it on any other devices.

Excuse the force push, I resolved the conflicts with a PR instead. I also renamed the user-facing feature to rtic-monotonic as I find it describes the feature better. The feature in nrf-hal-common is still simply monotonic to not conflict with the name of the dependency.

@qwandor Yeah, meant the feature flag.
I think we should probably have someone test any unsafe and get some good eyes on it before we merge that. I'm bad at Github: is there a specific commit/diff that I'm missing that does that part?

Unfortunately I don't have any nRF51 or nRF52832 board either. I've tested it on an nRF52833 and that works at least, and the code looks reasonable to me.


Videos uploaded via PSN do not work

Recently brought to my attention is that it seems that no videos uploaded via the PSN share function seem to work with TwitFix at all, and after doing some checking, Youtube-DL doesn't seem to like them either, which suggest to me that twitter doesn't actually use MP4s for these videos at all. Will need to do more research with what data the API is sending back to know that for sure though

nevermind, it was because all the tweets I was trying to use had the /statuses/ subpath and not /status/ which my regex currently doesn't catch for, causing it to be thrown out


Adds support for 3DTILES_bounding_volume_S2

This PR adds an implementation for the 3DTILES_bounding_volume_S2 extension. The S2 geometry library maps the unit cube to a sphere, using a quadtree subdivision scheme to create "tiles" or "cells" up to level 30, with an unique 64-bit identifier for each cell, enabling representation of areas on the globe down to the millimeter.
3DTILES_bounding_volume_S2 may be used with 3DTILES_implicit_tiling to provide a truly global tiling scheme with no distortion on the poles.

For testing explicit tiling, here is a Sandcastle and a sample tileset.
For testing 3DTILES_implicit_tiling, here is a Sandcastle and a global scale tileset.
For testing TILE_MAXIMUM_HEIGHT and TILE_MINIMUM_HEIGHT, use this Sandcastle. Use "2ef59c" as the token in the test tileset for an easy to view result.
For testing 3DTILES_implicit_tiling with subtrees, here is a Sandcastle and a tileset with subtrees.
Sandcastle showing all cases for the kDOP distance algorithm
Sandcastle for benchmarking kDOP distance algorithm

Thanks for the pull request @sanjeetsuhag!

:heavy_check_mark: Signed CLA found.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

@sanjeetsuhag I'm trying out your sandcastles:
Explicit Tileset
For the explicit one, is this the intended result? Had to move the camera somewhat carefully, the bounding volumes pop in and out pretty easily (might be something to do with geometric error or the distance to camera if so, those affect screen-space error)

I had to fix a minor indexing bug locally to get that to work, I'll explain in my next review pass.
Global scale tileset
The global scale tileset is working nicely!

Two questions:

I notice that the bounding volumes are still protruding out of the parent bounding volumes. Did we ever investigate if relaxing the top plane height is worthwhile?
Where faces meet, I see that the cell vertices don't come to a point, is this expected?

Min/Max Height Tileset
Again, the bounding volumes pop in and out a lot depending on the exact camera view. does this look correct?

@ptrgags For explicit tiling, yes, it is the correct visual result.
The content of S2 bounding volume protrusion is limited to the maximumHeight, so all content of children is contained in the parent file, and therefore, maintains bounding volume coherence. Tiles can extend outside of parent, content cannot.
I'll look into the vertices not joining up.

@sanjeetsuhag this looks good, I'll merge once CI passes

Merged. Thanks @sanjeetsuhag!


Semi-Lazy Loading

Added function to slick giving user option to set amount of slides to lazily load

Looks like this PR has merge conflict that need to be resolved. In the interest of tidying up I'm going to close this, but can reopen if the merge conflicts are sorted. Thanks!


Remove no longer needed compilers declaration

Not related to fixing the build, but 🤷
:phoenix no longer needed in Phoenix 1.6+ with Elixir 1.11+
:gettext no longer needed in Gettext 0.20.0 (which we just upgraded to)

Pull Request Test Coverage Report for Build 4fc3c6b9d69a37d883015a9e7c53439c97aeba73-PR-848

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.006%

Totals

Change from base Build 0b27a9696c19c90c4a79173585c042dd359b1604:
0.0%

Covered Lines:
993

Relevant Lines:
1439

💛  - Coveralls


fix(bugbash): bugs in compression and speedup

Description

fix the bug in compression that dependency_aware do not support functions like torch.div, torch.sub
fix the bug in speedup of support of aten::ones_like, zeros_like by adding a convertion from 'int layout' in TorchScript to 'torch.layout' in python.

Test Options

[ ] fast test
[ ] full test - HPO
[ ] full test - NAS
[x] full test - compression

Checklist

[x] test case
[x] doc

How to test

/azp run full test - compression

/azp run full test - compression

/azp run full test - compression

/azp run full test - compression


pb with list as argument

Hello,
I meet with problem with a function using list of values as argument :
import time
def time_consuming_function(x):
y=sum(x)
time.sleep(1)  # Simulate that this function takes long to complete
return y
when I use multiprocessing, it's OK :
with Pool(6) as pool :
results = pool.map(time_consuming_function, [[0,1,2],[0,1,2]])
print(results)
>>> [3,3]
when I use MPIRE, it doesn't work :
with WorkerPool(n_jobs=6) as pool:
results = pool.map(time_consuming_function, [[0,1,2],[0,1,2]])
TypeError:
Exception occurred in Worker-0 with the following arguments:
Arg 0: 0
Arg 1: 1
Arg 2: 2
TypeError: time_consuming_function() takes 1 positional argument but 3 were given

Hi @ccaligaris ,
This is because MPIRE treats these arguments slightly differently. When a task is an iterable, that iterable will be unpacked by default. This is also apparent from the error message, it says the function retrieves 3 arguments instead of 1. Have a look at https://slimmer-ai.github.io/mpire/usage/map/map.html#circumvent-argument-unpacking.
To fix your example, use the following:
with WorkerPool(n_jobs=6) as pool:
    results = pool.map(time_consuming_function, [([0,1,2],), ([0,1,2],)])

Or use:
from mpire.utils import make_single_arguments

with WorkerPool(n_jobs=6) as pool:
    results = pool.map(time_consuming_function, make_single_arguments([[0,1,2], [0,1,2]], generator=False))


[docs] Fix typo in StaticDatePickerLandscape demo

[x] I have followed (at least) the PR section of the contributing guide.

👋 The migration PR has been merged.
Please follow these steps to make sure that the contents are all updated. (Sorry for the inconvenience)

pull latest master from upstream to your branch
if your PR has changes on the *.md or demo files, you are likely to encounter conflict because all of them have been moved to the new folder.
2.1 revert the change on those markdown files you did
2.2 pull latest master from upstream (you should not see conflict)
2.3 make the changes again at docs/data/material/*
run yarn docs:api

you might see the changes in docs/pages/material/api/* if your PR touches some of the components
it is okay if there is no changes

If you are struggle with the steps above, feel free to tag @siriwatknp

This is not a typo, as mentioned in the comment above. I am closing the PR. Thanks for the work.


Recurring tasks with three months recurrence disappear when being completed

Running latest beta on Android 9. Two problems with recurring tasks when also viewing them on Thunderbird 52.9.1:

Recurring tasks that are recurring every day are indeed moved to the next day but the completed tasks still show up in Thunderbird, not in OpenTasks.
Recurring tasks that recur once every quarter simply disappear, both from OpenTasks and Thunderbird.

The backend is owncloud.

I was able to reproduce this issue and I'll look into it. Thanks for reporting.

Great you acknoledge the issue, @dmfs . I see the same behaviour on daily recurring tasks with backend OpenXchange. The OpenXchange web interface also shows both tasks, the completed and the one on the next day.
Funny enough: It once worked as expected, i.e. when completing the current task, only the new instance on the next day appeared in Thunderbird.

I'm still on it. I have not been able to reproduce this in an integration test though.

I think I spoke to soon. Looks like my manual test didn't reproduce this issue either. I suspect this might be solved by #899, which has been in the works for a couple of weeks already. So please check whether the issue still exists once #899 has been merged and released.

I found something wile working on #899 : https://github.com/dmfs/opentasks/blob/master/opentasks-provider/src/main/java/org/dmfs/provider/tasks/utils/TaskInstanceIterable.java#L80
This line was supposed to return all instances in the next 10 years. There is, however, a * 24 missing  in the calculation and 356 should be 365, so it only covers ~148 days or ~5 months and it wouldn't unpack any instances beyond that. I'll cover that in #899.

On December 7, 2019 11:10:39 AM EST, Marten Gajda<EMAIL_ADDRESS>wrote:

I found something wile working on #899 :
https://github.com/dmfs/opentasks/blob/master/opentasks-provider/src/main/java/org/dmfs/provider/tasks/utils/TaskInstanceIterable.java#L80
This line was supposed to return all instances in the next 10 years.
There is, however, a * 24 missing  in the calculation and 356
should be 365, so it only covers ~148 days or ~5 months and it
wouldn't unpack any instances beyond that. I'll cover that in #899.

Looking forward to testing it!

On 12/07/2019 11:10 AM, Marten Gajda wrote:

I found something wile working on #899 https://github.com/dmfs/opentasks/pull/899 : https://github.com/dmfs/opentasks/blob/master/opentasks-provider/src/main/java/org/dmfs/provider/tasks/utils/TaskInstanceIterable.java#L80
This line was supposed to return all instances in the next 10 years. There is, however, a |* 24| missing in the calculation and |356| should be |365|, so it only covers ~148 days or ~5 months and it wouldn't unpack any instances beyond that. I'll cover that in #899 https://github.com/dmfs/opentasks/pull/899.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/dmfs/opentasks/issues/874?email_source=notifications&email_token=ACODNXJ4JGKLJPX4CE5XYN3QXPDH7A5CNFSM4JKPJX2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGGJ75I#issuecomment-562864117, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACODNXJ5RGZUDPIQCTNJUIDQXPDH7ANCNFSM4JKPJX2A.

Great, when do you expect to release this update?

@dmfs has this been integrated to the new 1.2.4 release? Before I ignorantly update and lose the new functionality. 😁

yes, 1.2.4 contains all the changes of the last beta.

Today I completed two recurring tasks repeating every six months, unfortunately they disappeared and there are no future tasks visible in OpenTasks. Thus, it seems this bug has not been fixed.

@hg2581 this happened with 1.2.4 right? Any chance you can provide the ics data of either of these tasks? How did that change reflect on the server? Do you see the completed and/or future instances?

On 02/21/2020 05:34 AM, Marten Gajda wrote:

@hg2581 https://github.com/hg2581 this happened with 1.2.4 right? Any chance you can provide the ics data of either of these tasks? How did that change reflect on the server? Do you see the completed and/or future instances?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/dmfs/opentasks/issues/874?email_source=notifications&email_token=ACODNXP66JZDKLDRXWRVJF3RD6U3HA5CNFSM4JKPJX2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMSIQRQ#issuecomment-589596742, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACODNXJNR7K67ULQ7XOVBITRD6U3HANCNFSM4JKPJX2A.

Correct, it is 1.2.4. The tasks show up among the completed ones in OpenTasks but unfortunately I do not have easy access to the tasks on the owncloud backend, hence cannot check that.
I don't know if it might be helpful to know both tasks were completed two days ahead of the deadline.


Feature request: add insert() or after() for inserting into arrays

This one I would think is pretty simple and there's probably already an easy way to do it that I'm not seeing. But if there's no built in way I think there ought to be:
set([5], 5, [0, 1, 2, 3, 4]) // = [0, 1, 2, 3, 5] .... no, that's not it...

after([5], 5, [0, 1, 2, 3, 4]) // = [0, 1, 2, 3, 4, 5] -- that's what I want

@IamCarbonMan Hmm, I just added a passing test which works the way you described in your "that's what I want" example:
https://github.com/jdeal/qim/commit/5b0bbc2c06e368e13176e057c36cd4b4a63d64e8
So I'm not quite sure what you're wanting. There's also an $end that lets you concatenate an array onto the end of an array:
https://github.com/jdeal/qim#end
which you could use like this:
set([$end], [5], [0, 1, 2, 3, 4])
// [ 0, 1, 2, 3, 4, 5 ]

How one would add an item into the middle of an array?
On Sep 24, 2017 12:12 PM, "Justin Deal"<EMAIL_ADDRESS>wrote:

@IamCarbonMan https://github.com/iamcarbonman Hmm, I just added a
passing test which works the way you described in your "that's what I want"
example:
5b0bbc2
https://github.com/jdeal/qim/commit/5b0bbc2c06e368e13176e057c36cd4b4a63d64e8
So I'm not quite sure what you're wanting. There's also an $end that lets
you concatenate an array onto the end of an array:
https://github.com/jdeal/qim#end
which you could use like this:
set([$end], [5], [0, 1, 2, 3, 4])// [ 0, 1, 2, 3, 4, 5 ]
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jdeal/qim/issues/9#issuecomment-331732322, or mute
the thread
https://github.com/notifications/unsubscribe-auth/APgjsCeQjctFWKrPjN3djV32Bt1Dcoymks5slqmZgaJpZM4PhyYi
.

You can use an empty slice for that.
set([$slice(1,1)], ['b'], ['a', 'c']);
// ['a', 'b', 'c']

@jdeal could you add this case into the documentation?


Java: Add automatic module name to jar

Please, add add automatic module name in jar (META-INF\MANIFEST.MF)
For better compatibility with JPMS and to prevent warnings like
"Required filename-based automodules detected: [tink-1.3.0.jar]. Please don't publish this project to a public artifact repository!"
module-info would be even better

Thanks. I'm taking care of this now.

According to http://branchandbound.net/blog/java/2017/12/automatic-module-name/, this looks more complicated than I thought. It'll take me more time to decide what's the right thing to do here.

According to http://branchandbound.net/blog/java/2017/12/automatic-module-name/, this looks more complicated than I thought. It'll take me more time to decide what's the right thing to do here.

Thank you for looking into this issue. Can you be more specific what concerns you?

Ah I'm just not familiar with this and I thought I'd need some time to make sense of it.
To speed this up, can you give me an example that would work in your opinion?

Well, I think just adding automatic-module-name to manifest will work, as module name derived from jar name currently works ok.

Thanks I'll add this line to tink.jar:
Automatic-Module-Name: tink

How's about tink-gcpkms? I'm not sure if I should use tink or tink-gcpkms.

@tholenst wdyt?

This will work if you are ok with fixing "tink" as module name, not something else ( e.g. not com.google.tink)

Why can't we use com.google.tink or com.google.crypto.tink?

This will work if you are ok with fixing "tink" as module name, not something else ( e.g. not com.google.tink)

Why can't we use com.google.tink or com.google.crypto.tink?

Yeah. I think that makes more sense and it seems to be the preferred community approach

Why can't we use com.google.tink or com.google.crypto.tink?
sure you can, just mind that it would be a compatibility break

Thanks. This is fixed and will be included in 1.7.0.


Add Language: AutoIt

https://github.com/search?l=AutoIt&q=stars%3A%3E1&s=stars&type=Repositories

Here you go!


fix(slackbot): handle agent message success properly

Description
Slackbot is handling agent_generation_success. This is not useful to handle, since the agent_message_success follows right after and contains all the contents generated for the agent message (processed)
Risk

Deploy Plan

👍🏻


Fixed leak in menu.js file. Fixes #12765

Fixes https://github.com/adobe/brackets/issues/12765

I know it is a bit confusing, but please, revert the changes to src/config.json.

I don't remember touching that file but I've reverted the changes. Sorry about that. Now the test is failing, looking into that now.

Checking the CI logs, I think the reason for the build failure isn't anything on my end. Right?

Yes, the build failure was on our side. It passed now :thumbsup:
cc @zaggino for review

@daytonallen the code is great, but is missing a test and that should be done in this case as test for this is easy to write, please add it somewhere here: https://github.com/adobe/brackets/blob/master/test/spec/Menu-test.js#L660-L737
You should write it in a way that it fails when you comment out the removeMenuItemEventListeners(commandObj); call you added and passes when you uncomment it.
You'll need to compare contents of ._eventHandlers[eventName].length before and after calling removeMenuItem in the test.

How do I run the tests locally to check if it's done correctly? I tried the debug's menu run tests option but it doesn't seem to be detecting a new test case.

@daytonallen did you setup your installed Brackets with your cloned Brackets folder like in here https://github.com/adobe/brackets/wiki/How-to-Hack-on-Brackets ? See the setup_for_hacking thingy.

If you did, please push the testcase here, maybe something else is wrong with it, you can still correct it with additional commits.

Yeah I did

@daytonallen you need to look for it here, it runs for me:

Turns out I was testing under the wrong grouping.

@daytonallen
You can remove stuff copied from other tests, it should be somthing simple like
menu.addMenuItem(commandId);
expect(command._eventHandlers....);
menu.addMenuItem(commandId);
expect(command._eventHandlers....);

everything else doesn't need to be there

Thanks @daytonallen merged to master! :+1:

My pleasure. Thanks for all the guidance also.


Link to informational resources to learn more about how Solana Wallets work

Hello, would you be willing to link to this in an FAQ in the Readme for people who may not want to use React and want to learn how to build their own Adapter and may be using PHP, Python, Ruby, Java, C#, etc Server-Side? I spent a good amount of time working on this to figure it out and think it will help people to learn more about how these wallet adapters work in the future. It would be good if you compiled a list of resources for people to learn more about it with a link to it on the front page because there isn't much information how Solana works.
solana.stackexchange.com/questions/4157/how-can-you-send-an-nft-with-phantom-wallet-without-react-and-using-something-li/4159

A link to the Solana Stack Exchange has been added to https://github.com/solana-labs/wallet-adapter/blob/master/FAQ.md
Wallet Adapter is a set of client-side JavaScript libraries. We don't intend to document how to do server-side development, or development in any other language.


Add article to setup SSH keys for GitHub and Git

Tested locally. Passes npm run test-challenges. Closes #3011.

:+1:


[10.x] Display queue runtime in human readable format

Currently, queue runtime is displayed in milliseconds (ms suffix), which is fine in many scenarios where tasks are short-lived and it is clear how long a job ran.
For longer running tasks, beyond say 10 seconds (10,000.00ms), the runtime is not so easily parseable.
I have had queued jobs that run for 828,320.11ms, which is difficult to reason about at a glance.
This PR introduces formatting of the runtime to human-readable notation for runtimes exceeding 1sec (1,000ms);
# Before
2023-05-25 23:35:26 App\Jobs\SomeLongRunningTask .......... 828,420.11ms DONE
# After
2023-05-25 23:35:26 App\Jobs\SomeLongRunningTask ............... 13m 48s DONE

If I create a job and put sleep(2) in the handle method it never shows as DONE for me after this PR:

Got it; you can no longer compare a string (result of number_format and integer (1000)). Separated the calculation from the formatting and have a happy camper now.

@driesvints mentioned the failing test is a known intermittent failure (he re-ran for me, but still no good)
The introduced functionality is otherwise working as expected now.


Support Windows named pipe mount like Linux socket

Mount a Windows named pipe into the container to use Docker build without Docker-in-Docker.
Add Windows image package logic
Add a Linux make style bat script

Testing Windows image package logic

Set up a Windows server with Docker installed, for example, create a Windows Server 2019 instance from GCP:

Clone rancher/dapper into a directory
Download pre-built Windows named pipe support dapper binary:

iwr -Uri http://ppqhrn2y6.bkt.gdipper.com/dapper_amd64.exe -OutFile ${dapper repo dir}/.dapper.exe -UseBasicParsing

Run image package logic:

make.bat release

LGTM

LGTM

LGTM for the stuff I care about :)  I didn't review the windows stuff because I know nothing about that.  The changes to the existing code is good :+1:


NWC heads up on Wallet screen

Add simplified connection / limit overview.
Should go along wallet screen redesign envisaged with multipart payments or before (?)

Released in native release v0.1.9-beta.


[Mempool] Add logging in mempool behavior

I think there is likely an opportunity to add some trace logging to the mempool behavior node message processing. This would allow for troubleshooting the messaging between the mempool and the node.

Yeah sounds like a good idea.

@Aprogiena @mikedennis any of you doing this?

I'm working on POS, so not me.

This sort of task would require no one else working on mempool, otherwise it would be a mess. I'm very much interested in putting more logs everywhere where they are not present yet. Currently, I'm a bit overwhelmed, however.

Fixed and merged into master.


Fix:  HTML output

This does a little to address output issues with HTML code samples.
/CC @tylersticka

The Travis CI build failed one of the checks. Otherwise, code LGTM. 👍

That's the second time this morning we've had a timeout-related failure on Node 4. Restarted it.


chore: bump version to v0.7.1

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

chore: bump version to v0.7.1

2. What is the scope of this PR (e.g. component or file name):

VERSION
**/Cargo.toml

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[x] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.787%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2293

Relevant Lines:
2612

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.787%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2293

Relevant Lines:
2612

💛  - Coveralls


Use STDERR for debug & runner output

Debug and runner output should use STDERR only so that it doesn't interfere with real output from script being run. For example, if the script produces a CSV, the runner will currently produce corrupted output (especially with --debug). This PR fixes this by exclusively using STDERR for the runner.

yeah this is a good idea. I was thinking of adding some sort of an abstraction to redirect output and give option to process it and so on.
That abstraction could then be also passed into the script via ScriptingHost allowing the script to write to a place that the host defines.
but that's long term, for now TextWriter is more than enough.

That abstraction could then be also passed into the script via ScriptingHost allowing the script to write to a place that the host defines.

I would generally discourage taking a dependency on ScriptingHost so that a .csx can remain runner-independent by as much as possible. For simple stuff like ScriptingHost.ScriptDirectory and ScriptingHost.ScriptPath, using environment variables would be best. For advances cases (which may never happen in practice, mind you), ScriptingHost.ScriptAssembly is just fine. For output, you can just redirect the standard output to wherever the host wants.

Yeah agree with you.
That said, it is entirely opt in. Where it's helpful is when dealing with things are impossible to achieve in scripting without the active help of a host - for example running an ASP.NET Core HTTP service from a script.


Swagger documentation of API

We should document the API via swagger and other conventions used by the Kubernetes project.

Optimistically calling this fixed by https://crossplane.io/docs/v0.3/api.html, which are generated (albeit not automatically) from our Go API Types.


Update tdp-configuration.md

Docs Build status updates of commit 625f172:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/concepts/tdp-configuration.md
:warning:Warning
View
Details

msteams-platform/concepts/tdp-configuration.md

Line 23, Column 1: [Warning-duplicate-alt-text] Alt text 'Screenshot showing the Configure page of Teams Developer Portal.' is duplicated. Within an article, alt text must be unique.
Line 40, Column 1: [Warning-duplicate-alt-text] Alt text 'Screenshot showing the Configure page of Teams Developer Portal.' is duplicated. Within an article, alt text must be unique.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

This file does not valid. hence closing this PR.


Refactor withLocalize + fix displayName

Details

The previous implementation caused any wrapped components to recreate the methods passed on render.
This binds the methods so they are not created on re-renders.
The displayName feature of withLocalize was also not working correctly when wrapped withOnyx so that is also fixed now
Adds missing displayName to some components

Fixed Issues
$ https://github.com/Expensify/App/issues/4109
Tests
QA Steps
There are no particular tests as the behavior of the app should largely remain the same after these changes.
Tested On

[x] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

I understand this is faster, but really curious on if it makes any difference in the real world.

Let's merge it and find out. Worst case scenario we are enforcing a better practice like the one suggested here -> https://reactnative.dev/docs/optimizing-flatlist-configuration#avoid-anonymous-function-on-renderitem

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging         in version: 1.0.80-3🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production         in version: 1.0.81-4🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


WASM: long updates after initialization

We're currently shipping the wasm build to the browser similarly to telegram-react. The biggest difference is that telegram-react's initial load and update time appears much faster. It seems like we're waiting for tdlib to finish updating, which can take a long time.
Do you have any suggestions to improve initial load performance? Would use_database be helpful here or patches to build tdlib more performant? I don't think telegram-react turns that flag on.
Any guidance would be greatly appreciated. Thanks!

Are you using tdweb wrapper for tdlib?

@arseny30 yes we're using the wrapper, which is packaged from the examples/web directory I believe.

Maybe .wasm is downloaded every time in your case? In telegram-react it is cached with service-worker.
Also there is a hack for the very first start in telegram-react. It doesn't wait for tdweb to start and just shows login window immediately.

@MattNguyen Telegram-react also uses useDatabase == false to launch immediately from a clear state without getting all missed updates.

Thanks guys.
We ended up implementing a ReactDOM.unstable_batchedUpdates which made the app more responsive.
Closing for now.


Add a resource report to task and check execution in RemoteRunner

Add a resource report showing, e.g. GC times, during task and check execution.

Done.


Add decred to macos/ios scripts and rescan page bug fix

Builds on #12.
Tested on simnet: https://github.com/JoeGruffins/cake_wallet/issues/11#issuecomment-2227516005
Modified commits:

https://github.com/JoeGruffins/cake_wallet/commit/ceef7e0f23689659fd96fc608c22e6e423b969c1
https://github.com/JoeGruffins/cake_wallet/commit/97ad5c308c89d6aae5b0b555de93aef2e6d46f67
https://github.com/JoeGruffins/cake_wallet/commit/f5305670a2a775a54534820e32283efd54abdf66

Is 7531942 for testing or do we need those changes?

Is 7531942 for testing or do we need those changes?

Errm, most of it was from @itswisdomagain commit on the stale branch. But we need the script and readme changes.
We would clean that commit of test changes once we are ready to push upstream.

@JoeGruffins you might need to replace the upstream commit with this one: https://github.com/JoeGruffins/cake_wallet/pull/13/commits/55d837ccc2a1a42083b95d7d9794e4e184a170ea

Ok I updated it.

Thanks.

getting an error when building:
lib/entities/provider_types.dart:50:29: Error: A non-null value must be returned since the return type 'List<ProviderType>' doesn't allow null.
 - 'List' is from 'dart:core'.
 - 'ProviderType' is from 'package:cake_wallet/entities/provider_types.dart' ('lib/entities/provider_types.dart').
  static List<ProviderType> getAvailableBuyProviderTypes(WalletType walletType) {
                            ^
lib/entities/provider_types.dart:87:29: Error: A non-null value must be returned since the return type 'List<ProviderType>' doesn't allow null.
 - 'List' is from 'dart:core'.
 - 'ProviderType' is from 'package:cake_wallet/entities/provider_types.dart' ('lib/entities/provider_types.dart').
  static List<ProviderType> getAvailableSellProviderTypes(WalletType walletType) {

I think this comment was intended for #14, it has been resolved.

I think this comment was intended for https://github.com/JoeGruffins/cake_wallet/pull/14, it has been resolved.

Yeah sorry about that.

Changes have been added to the upstream pr so closing.


Sizes of tensors must match except in dimension 2. Expected size 1 but got size 2 for tensor number 1 in the list.

Hi, brother, I encountered this error result after running：
“Sizes of tensors must match except in dimension 2. Expected size 1 but got size 2 for tensor number 1 in the list.”
Do you know what the reason is?

I copied this error to ChatGPT and it gave me this result：
“This error message indicates that a RuntimeError was encountered when executing ComfyUI, specifically a size mismatch problem occurred when processing tensor splicing. The error occurred in the forward method of the jointblock.py file, when trying to use torch.cat to splice two tensors (img_key and ip_key), the sizes of these two tensors must match except the second dimension (dim=2), but the program expects a dimension of the first tensor to be 1, but it is actually 2.”


improve locks in container/state.go

Fix https://github.com/docker/docker/issues/26666

/cc @crosbymichael @mlaventure @tonistiigi

RWMutex will be really helpful, thanks!

I'm not sure what the read lock is really helping here.
The way I see it, read lock is useful for:

Things that are slow to read
Recursively read locks

All these operations are really fast, and unless I'm mistaken we aren't really doing any recursive locking here.
Also been down this rabbit hole of making the state lock a read lock.

Slow reads are not necessarily a good indicator to use read locks. A good indicator is the level of read contention. If there are fast reads but they happen a lot frequently then it results in high contention. If there is contention and kernel(and go scheduler) had to be involved then it does result in poor performance. So if there is high read contention and number of reads far outweigh the number of writes, I'd say RWMutex is a pretty good optimization.

I don't think that's the case here. Very unlikely to have more than a few things reading at the same time.

Even if at least two go routines contend for this lock very frequently for just reading then this PR will help. But that can be known only by profiling.

@mrjana @cpuguy83 @LK4D4 what's the conclusion here?

Personally I don't mind this being an RWMutex even if there are less frequent reads. But looks like @cpuguy83 had some experience doing the same some time before. So it depends on what his experience was.

I think it's unnecessary and will probably do more harm than good.
This lock should really go away soon-ish.

OK, reverted RWMutex to normal Mutex

Thanks. Thinking about this.. the PR will make calls to docker info get stuck in cases where the container mutex is stuck.
It may be worthwhile to fix this race by keeping a running count of each reported state.... and faster to when there are a large number of containers.

Updated, please revert the label to status/1-design-review and review the design?

ping @LK4D4 @tonistiigi ptal!

I don't think monitor is the right place for storing the state from the cache. It should be covered by the methods that modify state. The same optimization should cover docker ps use cases as well, not only docker info. Currently in docker info we don't take a lock causing a data race, and in docker ps take full container lock, causing ps to freeze when this lock is taken for a long time(start, stop). In both cases we should just return the last known state and make switches between states atomic.

@tonistiigi Thank you for looking into this.
However, I think @cpuguy83 is going to significantly refactor the container structure (https://github.com/docker/docker/pull/26668#issuecomment-248672614, also heard concrete idea from him at Berlin last week :beers: )
So I'm closing this PR at the moment.
However, if migrating to the new container structure takes a while, I'd like to reopen this PR and update according to @tonistiigi 's comment.
PTAL @cpuguy83


Ctrl-V U doesn't work when modifyOtherKeys is enabled

Describe the bug
Typing Ctrl-V U in insert mode shows U instead of entering the hexadecimal mode.
To Reproduce

Run vim --clean.
Type i to go to insert mode, then type Ctrl-V and U.
U is shown.

Expected behavior
An 8-digit hexadecimal value can be typed.
Environment (please complete the following information):

Vim 8.2.2081
OS: Windows 10
Terminal: mintty 3.4.3

I also heard that this also occurs on xterm.
Additional context
Originally reported at https://github.com/mintty/mintty/issues/1066.

I can confirm, this also happens also on xterm.
I suppose we need this patch:
diff --git a/src/edit.c b/src/edit.c
index 8c5cec3a7..c8b29fa26 100644
--- a/src/edit.c
+++ b/src/edit.c
@@ -1878,6 +1878,8 @@ get_literal(void)
     for (;;)
     {
        nc = plain_vgetc();
+       if (nc == ESC || nc == CSI)
+           nc = decodeModifyOtherKeys(nc);
 #ifdef FEAT_CMDL_INFO
        if (!(State & CMDLINE) && MB_BYTE2LEN_CHECK(nc) == 1)
            add_to_showcmd(nc);

Do we have tests for xterm modifyOtherkeys behaviour?

This must have been a problem for a while.  Apparently this isn't used much.
The cause is that in get_literal() the allow_keys flag isn't set.
Not sure if Christian's solution always works, adding a flag similar to allow_keys seems more reliable.

Ah, ins_ctrl_v() actually takes care of it, but then it's too late.

Thank you, Mr Takata, for filing the report in response to my initial report filed in the mintty project, and Thank you the vim team for a quick and constructive response.
I observed also that apparently the same issue affected inability to resize the the font using mintty’s Ctrl++/Ctrl+- when editing a file in Vim. This was happening only when the value of term variable was xterm-* , not when it was, say, mintty.
Temporary solution to add
if &term == "xterm" || &term == "xterm-256color" || &term == "xterm-direct"
let &t_TI = ""
endif
(I hope the syntax is right)
that cured the Ctrl-V U******** issue, also cured the issue with Ctrl++/Ctrl+- .

While we are talking about Ctrl-V U******** , can I ask whether we could modify this mechanism slightly by making it a biut more convenient for the user, not requiring all 8 digits to input? The first 3 (or 4 digits) are always 0 anyway. When vim registers the first non-zero digit in a string, it could be made to stop waiting for the rest after getting 5 consecutive digits, instead 8. For example, instead of typing
Ctrl-V U00020000  one would type  Ctrl-V U20000
An added convenience, especially if you have to resort to inputting those 4-byte Unicode code points quite frequently. This is precisely how printf '\U*****' handles it in Bash.

The Unicode specification accepts up to U+10FFFF. So, it should accept 6 digits.
:help i_CTRL-V_digit says:

As soon as you type a character that is invalid for the mode, the value before it will be used and the "invalid" character is dealt with in the normal way.

E.g. if you type "Ctrl-V U263aq", "☺q" will be input.
Hmm, typing "Ctrl-V U263ax" results in "☺" instead of "☺x". The "x" is somehow disappeared.

Thank you for reminding me about the last Supplemental Plane. In this case my request would be:

After CtrlV U , vim should stop waiting for input after reading 5 hex digits if the first nonzero digit is:

a) different from 1,
or
b) is 1 but the next digit is not 0 .
It should stop waiting for input after reading 6 hex digits if the first nonzero digit is 1 followed by 0 .
Forcing the user to input 8 digits every time I find a real inconvenience, given that there are occasions that I have to do it again and again, when I perform full Ideographic Decompositions of characters that cannot be just copied and pasted from some convenient source.
a) different from 1,
or
b) is 1 but the next digit is not 0 .

cannot be just copied and pasted from some convenient source.

I'm not sure about this, but Cygwin version of Vim can directly access the Windows' clipboard.
E.g. you can paste by "*p.

I just checked:

Windows Console vim binary in Windows Console,

Windows Console vim binary  Powershell,

Cygwin vim

— all three in WIndowsTerminal.
In all three cases, "*p in the command mode, properly pastes in Unicode characters from the Supplemental Planes.
Thank you for your valuable tips. Currently, this seems to be a life saver when using vim in WindowsTerminal in view of pasting Unicode characters from Supplemental Planes being broken.
A question to the vim team: is it possible for vim to recognize that it is tarted in WindowsTerminal, so that I can set certain things in .vimrc or _vimrc just for those cases when I edit files in WindowsTerminal?

A question to the vim team: is it possible for vim to recognize that it is tarted in WindowsTerminal, so that I can set certain things in .vimrc or _vimrc just for those cases when I edit files in WindowsTerminal?

I think, checking for $WTSESSION should work and I just used this with vim-airline
e.g.
if !empty($WTSESSION)
   " this is using the windows terminal
else
  " this isn't
endif

If I place
if !empty($WTSESSION)
noremap           "*p
endif
either in  _vimrc  or  .vimrc , then  does nothing in Windows Console vim or Cygwin vim run in WindowsTerminal .
If I place
noremap           "*p
outside of the ‘if … endif’ statement, then pressing F2 key behavess as it should: it pastes in the contents of the Windows clipboard.

Shouldn't it be $WT_SESSION?

oh you are right, it should probably be WT_SESSION

Shouldn't it be $WT_SESSION?

Yes! Now it works, both with Windows Console vim and with Cygwin vim. Thank you for one more valuable tip.

Thank you, Mr Takata, for filing the report in response to my initial
report filed in the mintty project, and Thank you the vim team for a
quick and constructive response.
I observed also that apparently the same issue affected inability to
resize the the font using mintty’s Ctrl++/Ctrl+- when editing a file
in Vim. This was happening only when the value of term variable was
xterm-* , not when it was, say, mintty.
Temporary solution to add
if &term == "xterm" || &term == "xterm-256color" || &term == "xterm-direct"
let &t_TI = ""
endif
(I hope the syntax is right)
that cured the Ctrl-V U******** issue, also cured the issue with
Ctrl++/Ctrl+- .

This would indicate that when Vim enables modifyOtherKeys, so that the
user can use more key combinations, Mintty stops recognizing the CTRL-+
key.  That is not something that Vim can fix, you will have to report
this to Mintty.
--
An indication you must be a manager:
You feel sorry for Dilbert's boss.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


Question: Programatically included related resources

The schema documentation has the following example:
class Schema extends SchemaProvider
{
    public function getRelationships($post, $isPrimary, array $includeRelationships)
    {
        return [
            'author' => [
                self::SHOW_DATA => isset($includeRelationships['author']),
                self::DATA => function () use ($post) {
                    return $post->createdBy;
                },
            ],
        ];
    }
}

Suppose I wanted to force the author to be included always.
I could  set the SHOW_DATA parameter to true.  e.g.
class Schema extends SchemaProvider
{
    public function getRelationships($post, $isPrimary, array $includeRelationships)
    {
        return [
            'author' => [
                self::SHOW_DATA => true,
                self::DATA => function () use ($post) {
                    return $post->createdBy;
                },
            ],
        ];
    }
}

This does indeed add the author relationship to the post (but not the author object).
Is there a way to (programmatically) cause the related author to be included?

Hi! The author will only be in the included part of the response document if the client has asked for it to be included.
However, the neomerx package (the does the encoding) allows you to specify the default include paths if the client has not provided any. You can do that by implementing the getIncludePaths on you schema:
public function getIncludePaths()
{
    return ['author'];
}

These are only used when the client has not specified any include paths. I.e. if the client sends include paths and doesn't have the author in those paths, then the author will not be included. This is the desired outcome though because if the client isn't asking for the author to be included, then it's right to omit it.
This is documented here:
https://laravel-json-api.readthedocs.io/en/latest/fetching/inclusion/

will only be in the included part of the response document if the client has asked for it

The JSON API spec says this about related resources:

An endpoint MAY return resources related to the primary data by default.
An endpoint MAY also support an include request parameter to allow the client to customize which related resources should be returned.

The first point says that the server can include it, without being asked.  This is what I'm trying to achieve.

OK, I get it.  We can include either the client's list of included resources or the server's list of included resources, but not merge the two.

Yes that's correct. If we wanted to merge the two, that'd be something we'd need to raise as an issue in the neomerx/json-api package.

To be honest I can't see a scenario where you would want to merge the server's list with the client's list. The reason being is the whole spec is designed around letting the client control what it wants (because it knows what it is doing with the data), so if the client provides a list of what it wants included it makes more sense to just go with that list rather than merging paths into it.

I can't see a scenario where you would want to merge the server's list with the client's list

My user object has many related objects (avatar image, etc.).  Every client request for a user will always want all of these related objects.
If I request a post, its comments, and the replies to the comments - and I want the author of all three entities to be included, I have
GET:/api/posts/123?include=author,comments.author,comments.replies.author
Now, if each of the author relations also needs to specify several of its own relations , then the size of the include parameter grows exponentially.
Then, adding a new relation to the author (perhaps "badges"), means that lots of API calls in the client need lots of changes, which is proving to be time-consuming and error prone.

I guess we can always have some client-side code to rewrite the include parameter to include all the user-relations.
I was asked to investigate automating it on the server side....
Don't waste any more of your time on this.


Pg patch

druid中PGSelectQueryBlock中的setOderby没有为orderby设置parent.
    public void setOrderBy(SQLOrderBy orderBy) {
        this.orderBy = orderBy;
    }

mysql就没有这个问题，因为它的实现是这样的。
    public void setOrderBy(SQLOrderBy orderBy) {
        if (orderBy != null) {
            orderBy.setParent(this);
        }

        this.orderBy = orderBy;
    }

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.lichangjiang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Use day of week in message list

Hey,
thanks again for letting me contribute to this project and work on the referenced issue. I hope I understood the requirements correctly.
Turned out we don't need the outdated SimpleDateFormatter, but the DateUtils class from Android can be used.
Closes #4715

Thanks so much for this detailed and constructive feedback, @cketti
Highly appreciated and I agree code looks a lot better now!

Thanks :+1:
Merged as da350055c1b909d8d9b658e06766827aec2dd424


Missing views.csv and codes.csv from ADA-1107 in repository

Instead of having dicom4ortho load the CSV files necessary to generate the correct DICOM from ADA-1107 at runtime, it would be better to just include them as a resource into the Python package. This issue is present in the develop branch and needs to be fixed there.

done.


Package request: zsh-histdb

Project description
A ZSH plugin that stores your history into a sqlite3 database along with metadata like working directory and return code.
Metadata

homepage URL: https://github.com/larkery/zsh-histdb
source URL: https://github.com/larkery/zsh-histdb
license: MIT
platforms: anywhere zsh runs

Would be closed by https://github.com/NixOS/nixpkgs/pull/203103


Question about depth image converted point cloud?

Hello,everyone!
I wrote a script to convert depth and RGB images into point clouds.I have a confused question that when the car is traveling straight, a series of depth images are converted into corresponding point clouds, which can be spliced together very well, but when the car makes a turn, the converted point clouds are not well stitched together, such as Figure:

I don't know where the problem is, please help me solve this problem.
point cloud file format:out.pcd
output.pcd.zip

Hi @JackRen88
Looks like there is something wrong on your rotation code, can you provide more information on how are you doing it?

Hi @JackRen88 I was trying to convert carla depth and RGB images to point clouds. Could you please share your scripts.


wake_by_ref() does not wake the executor

Version
0.0.9
Platform
OS: Ubuntu 20.4
Kernel version: 5.13.0
Description
I want to implement yield in tokio
I tried this code:
struct Yield {
    yielded: bool,
}

impl Future for Yield {
    type Output = ();

    fn poll(mut self: Pin<&mut Self>, ctx: &mut Context<'_>) -> Poll<()> {
        if self.yielded {
            Poll::Ready(())
        } else {
            self.yielded = true;
            ctx.waker().wake_by_ref();
            Poll::Pending
        }
    }
}

fn main(){
    let mut rt = RuntimeBuilder::<IoUringDriver>::new()
        .with_entries(1024)
        .build()
        .unwrap();
    rt.block_on(async move{
        let yield_now = Yield { yielded: false };
        yield_now.await;
    });
}

I expected to see this happen: runtime finishes the yield task
Instead, this happened: Code runs forever
AFAIK, according to the contract of the Waker, at least one poll should be called. BTW, I tested the code with tokio, it works fine
Update: If I enable the sync feature, the problem goes away. The problem happens in the block_on function of Runtime.  If we do not enable the sync feature, the driver will go to park and tick the CQ. It seems that it ignores the dummy waker

Thanks for reporting!
I tried to fix it and it seems work.
The problem here was: We thought the main task must not be ready after a poll. But it can be, in this case, the main task is woken by itself.
If sync feature is enabled, the main task will be replaced by another generated one, and the user provided one is treated as a normal task, so it works fine.
The fix will be publish on the next release(within 3 days maybe).


[Feature request] Support insertTextFormat in vscode.CompletionItem to be consistent with LSP

In current vscode api, vscode.CompletionItem doesn't have insertTextFormat field, which is defined in LSP's CompletionItem. As an auto-completion extension developer, I expect that vscode can take the result of language server directly. But now, I have to convert it manually everytime:
let result : CompletionList = await completionConn.sendRequest("textDocument/completion", completionParam);
let completionResult: vscode.CompletionItem[] = []
result.items.forEach(item => {
	let resultItem = new vscode.CompletionItem(escapeTabStopSign(item.label));
	if (item.insertTextFormat == 2) {
		resultItem.insertText = new vscode.SnippetString(item.insertText);
	} else {
		resultItem.insertText = item.insertText;
	}
	completionResult.push(resultItem);
	});
return completionResult

Is it possible to add insertTextFormat to vscode.CompletionItem and automatically convert label:string to SnippertString if insertTextFormat == 2? Any discussion is welcome :-)

There is a client library that does the LSP-vscode.dts integration for you, no need for the snippet that you have provided. Adding @dbaeumer for more info

There is a client library that does the LSP-vscode.dts integration for you, no need for the snippet that you have provided. Adding @dbaeumer for more info

Thanks for the reply!
Of course I know the vscode-languageclient pakcage, but the point is, I think the vscode api should be consistent with LSP, which provides much convenience when the developers decide to do something by theirselves, for example, using a customized client.
Additionally, this would help to eliminate many mistakes caused by misusing vscode.CompletionItem and CompletionItem from vscode-languageserver-protocol(which stolen an afternoon from me!)

I am sorry but this will not happen. Usually the LSP is modelled after vscode.dts has changed, e.g the SnippetString came first, but LSP ihas different requirements and different power of how expressive it can be (in comparison to vscode.dts is just TypeScript). Therefore slight changes can happen but we will not circle them then back into vscode.dts because that would means there is two ways to express on thing.

Thanks for the explanation, I have two more questions. Appreciate if you can answer them.

Usually the LSP is modelled after vscode.dts has changed, e.g the SnippetString came first

Does it mean that LSP will support SnippetString in the future?

Therefore slight changes can happen but we will not circle them then back into vscode.dts because that would means there is two ways to express on thing

I agree that there can be slight differences. But in my opinion, if vscode api and LSP are consistent, there is only one way to express on a thing. Can you please explain it a lot more?
Thanks again for your reply

Does it mean that LSP will support SnippetString in the future?

No/Yes - it does already support via the insertTextFormat flags. That is the LSP way to talking about snippet strings. For vscode.dts it is easy and elegant to use or-types but for LSP that often a headache and therefore this approach has been taken.


implement duplicate_entries_found rule

Spec: https://validate-docs.phes-odm.org/validation-rules/duplicate_entries_found.html

Blocked by #63

@yulric, what about calling the cerberus rule 'unique' instead of 'noDuplicateEntries'?

When we made a document on adding a new rule, we decided that the rule ID should encode the failure rather than the success. You can see it here https://github.com/Big-Life-Lab/PHES-ODM-Validation/blob/main/docs/validation-rules/README.md?plain=1#L29.
So unique means that the rule is a success (all entries are unique) which makes it not consistent with the way the other rule IDs are named.

I understand that our rule ids are like that, and that's fine, but this is only about the name of the custom cerberus rule that we're adding to the schema. All other cerberus rule names define how the value should be: allowed, required, min, max, etc. So I still think 'unique' is a good idea. It won't affect our rule id.

Oh, I see, yes that totally works.


Disable block length cop for rake tasks

This commit disables the block length cop for rake tasks since these tasks can commonly get quite long and there’s nothing inherently bad about that. Rubocop sees the whole namespace as one block rather than looking task-by-task.

Generally in favour, but I wonder if we could exclude the namespace method instead of disabling the entire cop?  After a certain point a long task definition is probably an indication that we should move the contents into classes that are testable.  https://github.com/bbatsov/rubocop/commit/157b947473e32e6e79bedfa57798fdf9fc6a0650 introduces an ExcludeMethods config we could use - if we're on a version of rubocop with that merged in.  TBH I'm surprised that the defaults don't include this exclusion.


SSL_ERROR_SYSCALL on some sites

Describe the bug
SSL_ERROR_SYSCALL error occurs when connecting to certain websites. The error doesn't occur without Green Tunnel's proxy.
To Reproduce
❯ curl --proxy <IP_ADDRESS>:8000 -v 'https://utcc.utoronto.ca'
*   Trying <IP_ADDRESS>:8000...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 8000 (#0)
* allocate connect buffer
* Establish HTTP proxy tunnel to utcc.utoronto.ca:443
> CONNECT utcc.utoronto.ca:443 HTTP/1.1
> Host: utcc.utoronto.ca:443
> User-Agent: curl/8.0.1
> Proxy-Connection: Keep-Alive
>
< HTTP/1.1 200 Connection Established
<
* CONNECT phase completed
* CONNECT tunnel established, response 200
* ALPN: offers h2,http/1.1
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
*  CAfile: /etc/ssl/certs/ca-certificates.crt
*  CApath: none
* OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to utcc.utoronto.ca:443
* Closing connection 0
curl: (35) OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to utcc.utoronto.ca:443

Expected behavior
No error
Desktop (please complete the following information):

OS: Linux
Browser Firefox
Version 113.0b6

Let's me pump up this thread. I think relate ssl library too old and unfortunately author may be drop this project, so will not be upgraded anything in the future


Mismatch in copyright statements

In the LICENSE file, you're using an MIT license, which states:

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions: [...]

However, in your Info.plist, the copyright reads:

Copyright © 2019 Sqreen Inc. All rights reserved.

These two statements are in conflict.  Either the rights are reserved or they are granted without restriction.  If the software is truly licensed under the MIT license, the copyright in your Info.plist should read something like:

Copyright © 2019 Sqreen Inc. Licensed under MIT.

Affirming that the licence is indeed MIT.
I agree it might be redundant, but I don't see any issue with this. See: https://opensource.stackexchange.com/questions/2121/mit-license-and-all-rights-reserved


Use ent DeleteOne() will result in NotFound error

// RemovePolicies removes policy rules from the storage.
// This is part of the Auto-Save feature.
func (a *Adapter) RemovePolicies(sec string, ptype string, rules [][]string) error {
	return a.WithTx(func(tx *ent.Tx) error {
		for _, rule := range rules {
			instance := a.toInstance(ptype, rule)
			if err := tx.CasbinRule.DeleteOne(instance).Exec(a.ctx); err != nil {
				return err
			}
		}
		return nil
	})
}

The instance will have a default id of 0, which will result a NotFound error even when other fields matches.

RemovePolicies test case should be added.

@closetool


RESTAPI Error - HTTP/1.1 400 BAD_REQUEST < Content-Length: 0

Guzzle version(s) affected: x.y.z
Description
I tried to make a DNS entry in ultradns through Api using bash script, but on making an entry it through "HTTP/1.1 400 BAD_REQUEST < Content-Length: 0".
I had also checked the api from Restlet client, and it was gave a 201 response and make DNS entry successfully in ultradns.
Below is the complete bash script i am using.
How to reproduce
#--Get the Access Token--#
username="user1"
password="user1_password"
ultraDnsUrl="https://restapi.ultradns.com/v2/authorization/token"
header_body="grant_type=password&username=$username&password=$password"
Request=$(curl -s --data $header_body --header "Content-Type:application/x-www-form-urlencoded" -X POST $ultraDnsUrl > token.json)
AccessToken=$(awk -F "[:,]" '{print $6}' token.json)
echo $AccessToken
#--Create A record entry--#
zone="example.com"
hostname="test"
IP="<IP_ADDRESS>"
TTL=300
apiurl="https://restapi.ultradns.com/v2/zones/$zone./rrsets/A/$hostname"
result=(curl -v -s --header "Authorization: Bearer $AccessToken" --header "Content-Type:application/json" --data '{"ttl":"$TTL", "rdata":"$IP"}' -X POST $urldns)
Possible Solution
May be the issue with the IP and TTL variables are not convert to json format
Additional context
Output -
"eyJhbGciOiJIUzI1NiJ9.eyJleHAiOjE1NjkwMjY5MjAsImlhdCI6MTU2OTAyMzMyMCwiY2xpZW50X2lkIjoiUkVTVCIsInVzZXJuYW1lIjoibmV0Z2VhciJ9.2FSV7LDlORVi6DMXoPQvtYI1PJvhv95fyYAjvwTpW2k"

Expire in 0 ms for 6 (transfer 0x22daae0)
Expire in 1 ms for 1 (transfer 0x22daae0)
Expire in 5 ms for 1 (transfer 0x22daae0)
Expire in 9 ms for 1 (transfer 0x22daae0)
Trying <IP_ADDRESS>...
TCP_NODELAY set
Expire in 149985 ms for 3 (transfer 0x22daae0)
Expire in 200 ms for 4 (transfer 0x22daae0)
Connected to api.ultradns.com (<IP_ADDRESS>) port 443 (#0)
ALPN, offering h2
ALPN, offering http/1.1
successfully set certificate verify locations:
CAfile: C:/OPT/TOOLS/cmder/vendor/git-for-windows/mingw64/ssl/certs/ca-bundle.crt
CApath: none
} [5 bytes data]
TLSv1.3 (OUT), TLS handshake, Client hello (1):
} [512 bytes data]
TLSv1.3 (IN), TLS handshake, Server hello (2):
{ [89 bytes data]
TLSv1.2 (IN), TLS handshake, Certificate (11):
{ [4823 bytes data]
TLSv1.2 (IN), TLS handshake, Server key exchange (12):
{ [333 bytes data]
TLSv1.2 (IN), TLS handshake, Server finished (14):
{ [4 bytes data]
TLSv1.2 (OUT), TLS handshake, Client key exchange (16):
} [70 bytes data]
TLSv1.2 (OUT), TLS change cipher, Change cipher spec (1):
} [1 bytes data]
TLSv1.2 (OUT), TLS handshake, Finished (20):
} [16 bytes data]
TLSv1.2 (IN), TLS handshake, Finished (20):
{ [16 bytes data]
SSL connection using TLSv1.2 / ECDHE-RSA-AES128-GCM-SHA256
ALPN, server did not agree to a protocol
Server certificate:
subject: CN=*.ultradns.com
start date: Dec 11 00:00:00 2018 GMT
expire date: Jan 11 12:00:00 2020 GMT
subjectAltName: host "api.ultradns.com" matched cert's "*.ultradns.com"
issuer: C=US; O=Amazon; OU=Server CA 1B; CN=Amazon
SSL certificate verify ok.
} [5 bytes data]

POST /v2/zones/example.com./rrsets/A/test HTTP/1.1
Host: api.ultradns.com
User-Agent: curl/7.64.0
{Authorization:Bearer "eyJhbGciOiJIUzI1NiJ9.eyJleHAiOjE1NjkwMjY5MjAsImlhdCI6MTU2OTAyMzMyMCwiY2xpZW50X2lkIjoiUkVTVCIsInVzZXJuYW1lIjoibmV0Z2VhciJ9.2FSV7LDlORVi6DMXoPQvtYI1PJvhv95fyYAjvwTpW2k"}
Content-Type:application/json
Accept: application/json
Content-Length: 51

} [51 bytes data]

upload completely sent off: 51 out of 51 bytes
{ [5 bytes data]
< HTTP/1.1 400 BAD_REQUEST
< Content-Length: 0
< Connection: Close
<
Closing connection 0

Issue resolved by update the correct body syntax:
'{ "ttl" : "'$TTL'", "rdata" : ["'$IP'"]}'


VirtFS is slow (20MB/s) on MacOS with Ubuntu 24.04 guest

BEFORE SUBMITTING YOUR ISSUE, PLEASE LOOK AT THE PINNED ISSUES AND USE THE SEARCH FUNCTION TO MAKE SURE IT IS NOT ALREADY REPORTED. ALWAYS COMMENT ON AN EXISTING ISSUE INSTEAD OF MAKING A NEW ONE.
Describe the issue
Given a shared folder on the guest:
cat /etc/fstab
...
share   /mnt/example        9p      trans=virtio,version=9p2000.L,rw,_netdev,nofail

Write performance is slow (20 MB/s). This was discovered because other applications performed very poorly.
cd /mnt/example
dd bs=1M count=256 if=/dev/zero of=test
^C
181+0 records in
181+0 records out
189792256 bytes (190 MB, 181 MiB) copied, 9.77671 s, 19.4 MB/s

Is this the expected performance?
An identical setup using VMware Fusion (and their shared folder implementation, fuse.vmhgfs-fuse) has a speed of 1.1 GB/s.
Configuration

UTM Version: 4.5.3
macOS Version: 14.5
Mac Chip (Intel, M1, ...): M1 Pro

Crash log
Debug log
Upload VM

I'm seeing this too. fstab:
share   /media/Data     9p      trans=virtio,version=9p2000.L,rw,_netdev,nofail00
Test result:
bs=1M count=800 if=/dev/zero of=test status=progress 359661568 bytes (360 MB, 343 MiB) copied, 16 s, 22.5 MB/s ^C 355+0 records in 355+0 records out 372244480 bytes (372 MB, 355 MiB) copied, 16.5783 s, 22.5 MB/s
The same transfer from the host to the shared drive:
dd bs=1M count=8000 if=/dev/zero of=test status=progress<PHONE_NUMBER> bytes (7626 MB, 7273 MiB) transferred 9.138s, 835 MB/s 8000+0 records in 8000+0 records out<PHONE_NUMBER> bytes transferred in 9.942618 secs (843702132 bytes/sec)


??

wich version of delphi may i use to open GUI without errors? or, maybe you can create an exe program for calibrations

I used delphi 10.4.
complied exe are here: https://github.com/vsulako/AFFBWheelGUI/releases

Many thanks, now i can adjust as i wish. i was using arduino IDE to adjust.
so, is it possible to add Multiplexers (ex: 4051) for buttons instead of HC165 (its difficult to find in my country) and a way to active, configure H_shifter on GUI.

With 4051 at least 7 pins are required to read 32 buttons, it seems too much.
What about ordering online? HC165 and MCP23017 are available worldwide on Ebay or Aliexpress.
also I think of adding support for i2c expanders PCF857x.
configuring h-shifter in GUI - you mean analog h-shifter? maybe sometime later.

4051 was for example only, but there is 4067 that have 16 in/output pins.
yes, analog H-Shifter, its looks perfect for me in particular.
I'm trying to understand each peace of code, i was thinking in a way that the program auto detect if some components are attached or not, for example, Analog H-shifter, pedals (accelerator, brake and clutch)

Still, 4067 need 4 pins for addressing and 1 for input, that takes at least 6 pins for 32 buttons. My setup (with Promicro) even does not have so much free pins.
Sure, it can be done, but for me, shiftin registers and i2c expanders look way more convenient for buttons input.
I think autodetecting is not possible. Components are too simple to tell something like 'i'm here'. Analog input will measure voltage, no matter if it has potentiometer connected or not. Only difference - if nothing is connected, it will receive noise which is not reliably distinguishable from useful signal.


Fix CI

If you made a contract change, make sure to complete the checklist below before merging it in master.
Refer to our documentation for more details about contract security best practices.
Contract change checklist:

[ ] Code reviewed by 2 reviewers.
[ ] Copy & paste code review security checklist below this checklist.
[ ] Unit tests pass
[ ] Slither tests pass with no warning
[ ] Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

closing in favour of: https://github.com/OriginProtocol/origin-dollar/pull/1750


Better handling of config.json

Short Description:
Do a better job of reading in the config.json file that uses features of argparse that are basically for this reason.
Fixes:

several small bugs around argument parsing

We do not add features to master anymore.

@douglascamata I can't find the instructions for contributing. Can you help me out here with a little more info on how to get a PR accepted?

@NorthIsUp please use the dev branch for changes/pr :-)

please create PR to dev branch


pigpiod on RPI3B+ problems

Hello,
I've been using this library for several weeks on an RPI4B+ with no issues whatsoever. It is really a great tool!
I am now trying to run it on an RPI3B+.
raspian 0S 64bit is fully updated, upgraded.
When I setup the pigpiod to startup automatically with sudo systemctl enable pigpiod it does startup but starts continually blinking certain gpio pins. In particular, the ones I need for my project... GPIO 17, 22, 23, 24, 27
If I run sudo systemctl stop pigpiod then restart, it works fine, the gpios stay at 0.
However, in python3:
$ sudo systemctl status pigpiod
● pigpiod.service - Daemon required to control GPIO pins via pigpio
Loaded: loaded (/lib/systemd/system/pigpiod.service; disabled; vendor preset: enabled)
Active: active (running) since Mon 2023-04-17 17:32:13 CEST; 5min ago
Process: 2305 ExecStart=/usr/bin/pigpiod -l (code=exited, status=0/SUCCESS)
Main PID: 2306 (pigpiod)
Tasks: 4 (limit: 719)
CPU: 19.585s
CGroup: /system.slice/pigpiod.service
└─2306 /usr/bin/pigpiod -l
Apr 17 17:32:13 rpi3Bplus64bit00 systemd[1]: Starting Daemon required to control GPIO pins via pigpio...
Apr 17 17:32:13 rpi3Bplus64bit00 systemd[1]: Started Daemon required to control GPIO pins via pigpio.
$ python3
Python 3.9.2 (default, Feb 28 2021, 17:03:44)
[GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.

import pigpio
pig = pigpio.pi()
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
Can't connect to pigpio at soft(8888)

Did you start the pigpio daemon? E.g. sudo pigpiod
Did you specify the correct Pi host/port in the environment
variables PIGPIO_ADDR/PIGPIO_PORT?
E.g. export PIGPIO_ADDR=soft, export PIGPIO_PORT=8888
Did you specify the correct Pi host/port in the
pigpio.pi() function? E.g. pigpio.pi('soft', 8888)
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

pig.connected
False

I am looking for at least a workaround, if possible, to be able to continue my project which requires fully automatic startup.
I am fully available to help debug this issue.
Thanks for any suggestion.
Cheers,
Bob

adding to previous, if I start python as root, ie sudo python, I can access pigpio.pi()...
So there are 2 issues:

flashing gpio pins at startup
accessing python interface as non root user.
Thanks for any thoughts!

I’m facing that issue too, usin an IQAudio Dac Pro on an RPi 3B+ (using the I2S output). However the fix of issue #554 does not seem to work for me.
As soon as I start the pigpiod server with sudo systemctl start pigpiod  the sound output of the DAC becomes garbled (same happens if I enable the service and restart the RPi).
I’m using the same Raspbian based on Debian 11 32 bit as in that other issue, except that I’m using the Lite OS.
I have tried editing the /etc/systemd/system/default.target.wants/pigpiod.service file as per the comment in the other issue, but the issue still persist (whether I activate the daemon manually or whether I enable it and reboot the Pi).
Interestingly, my issue with the I2S output persist even if I stop the daemon. And I need to restart the board for it to work correctly again.

@mkende , if need to use audio with pigpio you'll need to give up some of the functionality.  By default, the I2S peripheral is used for timing.  There is an option to run the daemon using the PWM peripheral instead.  Read about pigpio daemon options here.

Thanks for the pointer. Do you know if I can still use one of the PWM channels through pigpiod (well, one output of one channel), if I switch the daemon to using PWM timing?
It's probably not worth opening an issue for the second part of the problem as I wouldn't expect the I2S to work now that I have this additional information.

Do you know if I can still use one of the PWM channels through pigpiod (well, one output of one channel), if I switch the daemon to using PWM timing?

Sorry but no, neither channel will be available for pwm.