Align protocol validation in galley with pilot

This is to align protocol validation in galley while creating ServiceEntry and SyntheticSeriviceEntry.

@Nino-K: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
e882f9d98ba5f95946e978d42df481329c3d0f13
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K can you just use the code directly? Is it not common?

Most of this validation code is in Pilot, however I'm working on a PR which is going to move a lot of these validation into common so both Pilot and galley can reference that. However my goal behind this PR is to see if the logic makes sense before refactor.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
e882f9d98ba5f95946e978d42df481329c3d0f13
link
/test lint_istio

integ-galley-local-tests_istio
e882f9d98ba5f95946e978d42df481329c3d0f13
link
/test integ-galley-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
e882f9d98ba5f95946e978d42df481329c3d0f13
link
/test lint_istio

integ-galley-local-tests_istio
e882f9d98ba5f95946e978d42df481329c3d0f13
link
/test integ-galley-local-tests_istio

unit-tests_istio
e882f9d98ba5f95946e978d42df481329c3d0f13
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-galley-local-tests_istio
e882f9d98ba5f95946e978d42df481329c3d0f13
link
/test integ-galley-local-tests_istio

unit-tests_istio
e882f9d98ba5f95946e978d42df481329c3d0f13
link
/test unit-tests_istio

lint_istio
9d3f52d666daef66efbfadd98ac183f0b30a52d5
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
9d3f52d666daef66efbfadd98ac183f0b30a52d5
link
/test lint_istio

unit-tests_istio
9d3f52d666daef66efbfadd98ac183f0b30a52d5
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
ee912fd705cc71d7266362689c5ab04268519df5
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

There should be at least one updated test case in instance_test.go for this change, right? Something that should fail before the fix and succeed after.

There should be at least one updated test case in instance_test.go for this change, right? Something that should fail before the fix and succeed after.

@sushicw there was a test case that expected to recieve ports for a an empty name and was failing.

@sushicw PTAL

@Nino-K: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
c2dc2d21038ff95f9940343bd085d917574577fc
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
c2dc2d21038ff95f9940343bd085d917574577fc
link
/test integ-mixer-k8s-tests_istio

lint_istio
c2dc2d21038ff95f9940343bd085d917574577fc
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@Nino-K: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests-distroless_istio
c2dc2d21038ff95f9940343bd085d917574577fc
link
/test e2e-simpleTests-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests-distroless_istio
c2dc2d21038ff95f9940343bd085d917574577fc
link
/test e2e-simpleTests-distroless_istio

pilot-multicluster-e2e_istio
c2dc2d21038ff95f9940343bd085d917574577fc
link
/test pilot-multicluster-e2e_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests-distroless_istio
c2dc2d21038ff95f9940343bd085d917574577fc
link
/test e2e-simpleTests-distroless_istio

pilot-multicluster-e2e_istio
c2dc2d21038ff95f9940343bd085d917574577fc
link
/test pilot-multicluster-e2e_istio

e2e-simpleTests-cni_istio
c2dc2d21038ff95f9940343bd085d917574577fc
link
/test e2e-simpleTests-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@Nino-K: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
c2dc2d21038ff95f9940343bd085d917574577fc
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio


Runtime error

When is try and start my dedicated server (local TADST), i get this error: https://gyazo.com/4ba525ad0956dece803993a417feee05
When I try and start a AltisLifeServer, just to compare, it works fine. So it's something that happends when i try and launch with your framework.
I've tried reinstalling the runtime c++ program, but still doesn't work.
Don't know if you have any fixes to this, or i'm the only one?
Regards, ValleiE

Hey,
This was something that appeared after the new Arma 3 updates and I haven't found any good way to solve it other than using the x64 server executable.

Now it just crashed. Thats wierd.
I'm going to try and see if i can fix it.

Please post your client and server rpts and your extdb3 logs.

It's something todo with your system driver's

Make sure to install the requirements for extdb3.

@superihippo whats this about any clue? [Thread 4712] extDB3: SQL: Initialized: NULL = ""
[Thread 4712] extDB3: Locked

Go over to our Discord and ask Optix there. I can't currently provide support.
Closing since there hasn't been a response from the op.


Add issue form

Codecov Report

Merging #28 (65f3db7) into main (08c52da) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           28        28
  Branches         8         8
=========================================
  Hits            28        28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c52da...65f3db7. Read the comment docs.


feat: support for v8 code cache

This PR adds V8 code cache support for ES modules loaded through ModuleLoader, and for scripts evaluated through evalContext (used by require in Deno). Embedders have full control over whether code caching is enabled, and how code cache is retrieved/stored.

Codecov Report
Attention: Patch coverage is 87.81250% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 80.88%. Comparing base (c11bc3d) to head (1071fa6).

Files
Patch %
Lines

core/modules/map.rs
75.00%
24 Missing :warning:

core/modules/loaders.rs
27.27%
8 Missing :warning:

core/modules/mod.rs
57.14%
3 Missing :warning:

core/ops_builtin_v8.rs
92.85%
3 Missing :warning:

core/runtime/jsrealm.rs
66.66%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
+ Coverage   80.74%   80.88%   +0.13%
==========================================
  Files          97       97
  Lines       23945    24255     +310
==========================================
+ Hits        19334    19618     +284
- Misses       4611     4637      +26

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[SRP] Support Active Directory and regenerate kerb keys

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Can one of the admins verify this patch?

ARM team signed off in https://github.com/Azure/azure-rest-api-specs-pr/pull/895


Fix no hyrax/editor and no admin set js error

JS fixes
This fixes two JS errors from the latest Sufia merge.
One of the errors was Error: No hyrax/editor , which I fixed by changing the name of the class to editor_control and the other error was caused by not having an admin set, which I fixed by doing some checks.
@projecthydra-labs/hyrax-code-reviewers

Significant portions of this look like the fix currently in Sufia that is scheduled to be ported in the next merge.  See https://github.com/projecthydra/sufia/pull/3155  I prefer we use that to keep a consistent history with Sufia.


Make Reparse more Distinct from Catchup in CLI

Right now it's hard to tell if a reparse or a regular catchup is happening.
I think we should log transactions in DEBUG perhaps?

Related to #2455


Fix website playground icons

Before

After

All changed packages have been documented.

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/2942/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/2942/


Firebase AuthUI exception serialization error when logging in with Google

General Information

Android device: Samsung, Huawei, Hisense, TECNO
Android OS version: 5,6,7
Google Play Services version: 16.1.0
Firebase/Play Services SDK version: 16.0.6
FirebaseUI version: 4.2.1

Describe the problem:
Some of the users encounter a problem when using Google as their Identity provider. The UI loading indicator on the top of the screen just hangs there and loading goes on forever. Some of them have even a video of the problem. My observations were that there was no error thrown, because what happens when Firebase Auth returns an exception is that it is  communicated back to the user uder the form of a dialog. However, in this case we do not receive anything, which means that the block of code which handles logging the exception and presenting an adequate error message is not being called. So the stacktrace which I have pasted below might not actually be the real cause of the problem, however, I have failed to find any other developers encountering the same issue.
Steps to reproduce

Start the application
User gets presented with Authentication Screen
User presses Login with Google button
Loading indicator hangs

Observed Results:
Crashlytics has logged the following exception:
Non-fatal Exception: com.firebase.ui.auth.FirebaseUiException
Exception serialization error, forced wrapping. Original: com.firebase.ui.auth.FirebaseUiException: Play Services update cancelled, original cause: com.google.android.gms.common.api.ApiException: 13:
com.firebase.ui.auth.KickoffActivity$2.onFailure (KickoffActivity.java:72)
com.google.android.gms.tasks.zzl.run (Unknown Source:4)
android.os.Handler.handleCallback (Handler.java:739)
android.os.Handler.dispatchMessage (Handler.java:95)
android.os.Looper.loop (Looper.java:145)
android.app.ActivityThread.main (ActivityThread.java:6934)
java.lang.reflect.Method.invoke (Method.java)
java.lang.reflect.Method.invoke (Method.java:372)
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1404)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1199)
Relevant Code:
    val providers = Arrays.asList<AuthUI.IdpConfig>(
            AuthUI.IdpConfig.GoogleBuilder().build(),
            AuthUI.IdpConfig.FacebookBuilder().build(),
            AuthUI.IdpConfig.EmailBuilder().build())

    startActivityForResult(
            AuthUI.getInstance()
                    .createSignInIntentBuilder()
                    .setIsSmartLockEnabled(false)
                    .setTheme(R.style.GreenTheme)
                    .setLogo(R.drawable.logo_white_android)
                    .setAvailableProviders(providers)
                    .build(),
            RC_SIGN_IN
    )

Hello Sam,
So this would mean that it is something which occurs from time to time and
there is nothing that we can do about it ?
Best regards,
Angel Angelov
On Tue, Feb 5, 2019 at 5:47 PM Sam Stern<EMAIL_ADDRESS>wrote:

Sounds like Google Sign In failed and FirebaseUI just caught and wrapped
the exception:
Original: com.firebase.ui.auth.FirebaseUiException: Play Services update cancelled, original cause: com.google.android.gms.common.api.ApiException: 13:
My best guess would be that this happens when the user tries to use Google
Sign In, needs to update Play Services, and then the update does not finish.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/firebase/FirebaseUI-Android/issues/1579#issuecomment-460688136,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AsVNg3mpY5wrg05bWR-DlqHv8p69kH4eks5vKaeKgaJpZM4ai5tS
.

Alright, please do let me know if there is any resolution to this problem. Thanks!

Having the same issue from time to time. In one of those cases, user had Xiaomi phone and had to enable a Google access for my app in the phone settings or something like that.

I am having this :
Sign in unsuccessful Exception serialization error, forced wrapping.  Original: com.firebase.ui.auth.FirebaseUiException: Play Services update cancelled, original cause: com.google.android.gms.common.api. ApiException: 9: Error connecting to Google Play services
when using a huawei phone which does not have google play services ; when I am using a device with google play services, there is no error. What I don't understand is that google play services are no longer required for firebase authentication, so I am wondering what may be the cause !

I have the save exception some times
original cause: com.google.android.gms.common.api. ApiException: 9: Error connecting to Google Play services

Hi, @kamdaou
Did you manage to figure out the reason for this problem? Some of my app users are reporting the same problem when trying to sign in from Huawei phones.
I can't understand either why Firebase throws this exception if Google Play Services is not a requirement for Firebase Auth.
Can anyone help with this?

Hi @leocorder
Yes, in my case I was using the following code:
startActivityForResult(
       AuthUI.getInstance()
           .createSignInIntentBuilder()
           .setAvailableProviders(providers)
           .build(),
       MainFragment.SIGN_IN_REQUEST_CODE
   )

But AuthUi is a prebuilt UI and probably needs Google Play services. So, I created my UI instead and used a password-based authentication. You could use it for devices that don't have Google Play services. Here is the link for doing that.

Thanks for your quick response @kamdaou. I'm using similar code to initiate the sign in/sign up flow in my app.
Unfortunately I believe the only solution currently would be to actually implement my own UI, as you did, since FirebaseUI depends on Google Play Services, although Firebase Auth does not. Thank you for your help.


[Website] Website inventory page created and updated date entries

👉 This task is the following step for #1045.
User needs:
As a Carbon for IBM.com owner, I need to see how many website pages, categories, and website pages are published on the website. I also need a way to know when the page is published and edited to better view the website's growth.
Steps:

[x] Add the scripts to each individual website pages to get the data connected.

Notes:
The date information can be found in the "History" tab of each .mdx page.

Acceptance criteria

[x] All website pages listed in the inventory list have the created and updated dates.

@photodow I have entered the Created and Published dates to every website page I can found as promised. There are three 404 pages for which I do not know where to enter the dates. For example, on the 404 pages, I found the created date as of 8/14/2019 and the last updated date as of 10/19/2020, but I am unsure which part of the page I should enter in the markdowns the dates.
Please take a look, and it's a pleasure to work on this last task for the website with you, James!


Update the license to GNU AGPLv3+.

The license was different in the LICENSE file and README files. One was MIT and the other one was GNU GPL. I updated the license to GNU AGPLv3+. It's basically GPL but with one additional note, that asks everybody to publish the source code (or link to it here) that uses the theme in their project.
It's just to make sure the theme remains free (as in freedom) if someone uses it publicly, and one can't make it proprietary against the community (or your) benefit.
It's best license to use for such program.

Thanks for your merge request, but I do not want to change the license without having a look.

I understand, I explained what AGPLv3+ does in the issue #56.


C64 multibank cartridges

The c64 sports a cartridge port that adds 8Kb of data at the address $8000 in memory. Many of them have also the feature that the ROM contains multiple banks and let you switch between them.
So the formats use would be

a special cart format with a header.
plain binary read of the cart
PRG with the load address as a word at the start.

I'm not saying the program doesn't support this use case, but I would like to hear the suggestions on how to go about working with them.
Carts.zip

You can see an example of a cartridge dump with a header at https://6502disassembly.com/nes-smb/SuperMarioBros.html -- the header becomes part of the disassembly and has an address, because assemblers need to send the data somewhere, and SourceGen guarantees the the entire original file is reproduced.  It gets a little weirder for the graphics ROM (at the end of the disassembly), since that isn't actually addressable by the 6502... but since it isn't, the address used doesn't matter.
One of the things you'll notice in the SMB disassembly is that there are a couple of addresses near the start (VBlank1, VBlank2) that overlap with the fake addresses for the cartridge header.  SourceGen is intended to work with overlays, so address references in the current segment are prioritized over others, and it works fine.
The one place it gets weird is when control transfers directly between segments, e.g. you flip the ROM bank and suddenly you're executing elsewhere.  There's no built-in mechanism to automatically trace execution that way, so any such points would have to be explicitly marked as code entry points.
There's currently no way to teach SourceGen how to skip headers and extract the PRG load address automatically, but doing it manually doesn't take very long.
I found the format described here and created a sample project (attached).  I just formatted the first couple of bank headers.  I used $1000 for the header data because it's outside the normal address range.
sample.zip
You'll notice that +0000bf and +0020cf are both address $806f, but looking at the cross-reference table you can see that they're only referenced by other code within the same bank.
(It looks like it's using an inline print function (e.g. JSR to $8604 at +000110), so the instruction tracing will be a bit off unless you add an extension script to format the inline data.)

Many thanks for the promt reply!
We have had the discussion on headers in the past, and I sympathize with the position that your logic means that all file content needs to go somewhere, whereas mine is that what is meta data shouldn't be mixed-up with the actual binary content. For the purpose of not walk around that minefield again, I stripped the cartridge file of all the headers and implemented the raw binary.
I guess you can say that there are three levels here;

File formats with metadata headers for stuff like emulators and such. These headers are not really native to the system - rather native to the ecosystem. The CRT files you reference (as per the link to codebase64), and also commonly the SID files, are of this category.

Fileformats with system native metadata headers. This is where the C64 PRG file fits. The two bytes header doesn't have an address as they are the native system metadata to tell the system the address

In system headers, that are like "structs" in some high level programming languages. This data is indeed placed in memory at an address. The c64 cartridges binary start on $8000 and has has two vectors, followed by the string "CBM80" to tell the Kernal (system ROM) that this is an autostart unit. (This is a link describing that: https://codebase64.org/doku.php?id=base:assembling_your_own_cart_rom_image - I mean the "CBM80 autostart" part)

So we disagree that metadata headers (1 and 2  above) should have an address, but this is a separate discussion where I already surrendered, so I wanted to get back to the point ;-)
The raw binary image I work with has 7 banks - all with the "header" described in 3. So there are 7 blocks of $8000 to $9fff. Given that you have automation in traversing the code, that means that it's important that when addressing an address, it's quite picky that you mean the address in the current bank.
It seems it works perfectly fine to set the address to a block, and the address is changed from that point. So I was able to set $8000 on all the respective starting points.
I will work on that ROM a bit and see what I conclude.

The Apple IIgs OMF format is essentially a worst-case variant of # 2 in your list: not only are there headers galore, the code and data is relocatable.  When loaded into memory by the system, instruction operands and data items that reference addresses within the program are filled in.  I didn't want to build an OMF decoder into the main part of the disassembler, so I did something similar to what you did: I re-implemented the system loader, and generated a new binary with just the bytes that are actually present in memory while the code is executing.  The trouble with doing so is that you lose valuable information, like the offset at which each segment starts, as well as meta-data like whether something is a code or data segment.  So the OMF conversion tool generates a stripped binary and a pre-populated project at the same time.  The project has .org directives at the start of each segment and comments identifying segment type, loader alignment restrictions, etc.
Something similar could be done for a CRT file, stripping the headers while generating .org directives and meta-data comments at the start of each chunk.  Unless you're doing this to a lot of files it's probably not worth the effort of generating a full project file though.  I have experimented with "SourceGen Edit Commands" in the past, which would allow you to write a tool that stripped the binary and generated a simple list of ".org" statements and comments, which could then be manually imported into a new project.
In any event, I believe the answer to the question of whether or not a binary with multiple overlapping segments can be successfully disassembled is "yes".  So far I've only done it in unit tests though.  There are related issues, like whether using Ctrl+G to go to an address does the right thing, that haven't been exercised much.  (Hint: it does not do the right thing; it actually goes to the first instance of the address in the file, rather than the one in the segment you're in. Patch to follow.)

The emulator VICE has a cart convertion tool that allows me to take the CRT and generate a bin. It doesn't generate the skeleton project of course but the added value for this particular use case is quite small,.so I am good on the removal of metadata.
I should have experimented more before asking the question so I don't risk taking your time with topics already found in a FAQ, but I still hope this is not.
My main point was really a question if the program properly could handle the scenario where you have the same address appear multiple times in the binary. I would assume there needs to be a way to define segments, and that all references would use the current segment if they reference addresses inside the segment.
The logical behavior would be that a reference to an address would point to the first instance (like you Goto command does) or that it would reference all instances. I would assume it needs special attention if you would be contextually aware and reference a particular instance which is not the first.

I have received errors on the assembly both for TASS and ACME. I will send that as a private mail as I am not sure how interested the general public is in that.

The 64tass code generation issue is discussed here: https://sourceforge.net/p/tass64/bugs/59/
Short version: I didn't fully understand how 64tass generates binaries.  The code gen needs to operate in slightly different modes based on whether the output could be directly loaded into a 64K system.
I'll tie that specific problem to this issue for tracking purposes.

64tass code generation should be fixed in https://github.com/fadden/6502bench/releases/tag/v1.7.5-dev3


Add methods truncateTable, renameTable, addColumn, dropColumn to MigrationBuilder

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Fixed issues
-

👍

👍


Docs/add typescript types

This is a fix up of my previous types. Didn't do it correctly for react components

got conflict mate


Hoe doesn't work

Describe the bug
The hoe doesn't perform the tasks a hoe should do when right clicking on soil or plants to collect. This was reproduced using copper hoe & redstone hoe's. I can dig with it when left click, but right click functions don't do anything.
Versions
Supertools version: 1.19.2*

Tested it just now. Every Material doesn't work. Will be fixed soon.


[CHORE] Replace fetch api with axios

Description
Replace all fetch APIs with Axios also handle the errors

Hi @leewan-09, I would like to work on this issue. Please assign it to me. Thanks.

Hi @leewan-09, I would like to work on this issue. Please assign it to me. Thanks.

sure

@aanchal-fatwani let me know if you are able to run the app locally. Or you can join our discord server to get help. Link in the readme

@leewan-09  can you assign the issue for me?

@aanchal-fatwani are you working on the task?

@leewan-09 can you assign the issue for me?

Sure, create a pr

I see no one assigned to this task, can I do this?

hi @Shivank12batra this issue has active PR already


NaN in some cases

It looks like the summarization is sometimes broken with an extra player "ship" in the list - and consequently the last one being broken

it happens this is due to... suspense... a scopely bug in the CSV export:

I wish they would provide a file with much more structured data than this afterthought vomit of information.
The file does not even explicitly contains the battle type (armada, solo, ship battle, base station attack...), misses relationships between various datasets provided in the file, etc.

It seems the issue came back after my last refactorings :-(


[BUG] Remove ComposableTimeSeriesForestRegressor

See issues linked in https://github.com/sktime/sktime/pull/3561
The regressor has been broken for an undetermined amount of time and is a duplicate either way. It should be removed IMO.

See issues linked in sktime/sktime#3561
The regressor has been broken for an undetermined amount of time and is a duplicate either way. It should be removed IMO.

good stuff, is that the correct issue to link to though? Seems to be about CNNRegressor

https://github.com/sktime/sktime/issues/3832
anyway, lets get rid


article endpoint

including :

create article
read all article
read article
update article
delete article

Bonus :

create article image
update article status
delete article image

minor unit test

simple unit test. not including testing related upload image


installed tailwind and daisyui and tester theme added, components and…

… pages folder added

Fixed it. Should be ready to go.


Guidance for use with ssh ProxyCommand

Hi there,
I'm trying to use this with my own Bastion host (unfortunately I can't use cloudposse/bastion). I want to be able to use the ProxyCommand so that I can pass my private key through to the target host, however if I do this, the sudo logs are encrypted.
I'm using the following ssh config:
HOST remote-server
  IdentityFile ~/key.pem
  ForwardAgent yes
  ProxyCommand ssh ec2-user@bastion-ip nc %h %p

I've also tried the ProxyCommand with -W but this seems to require turning on AllowTcpForwarding and nothing is captured in the sudo logs.
Cheers

@dmcd, Yes, you're doing everything correctly. Unfortunately, that's the expected behavior & it's not possible to capture clear-text output if using nc with ProxyCommand, since you're basically logging the encrypted tunnel. In fact, I recommend removing nc from the bastion container to prevent this behavior.
Your best alternative is to modify your commands to use a nested ssh and leverage ssh-agent forwarding to make it as seamless as possible.
E.g. To run uptime on a server called foobar from the bastion, you would run:
ssh bastion.ourcompany.com ssh foobar uptime
Alternatively, you can maybe use ForceCommand to force an automatic ssh to foobar, making it more "transparent" to the user, but there's no way that I know of to combine %h with ForceCommand

Awesome! thanks @osterman, I've removed nc from the bastion. I have ssh-agent forwarding working and can now see the sudo logs in clear-text.
For anyone else, this is how I set it up:
HOST bastion-ip
  IdentityFile ~/key.pem
  ForwardAgent yes

$ ssh-add remote-server-key.pem

Then I can ssh with:
$ssh -A -t ec2-user@bastion-ip ssh ec2-user@remote-server-ip

I needed to add -t to get round the following error:
Pseudo-terminal will not be allocated because stdin is not a terminal.

Awesome! Thanks for sharing your solution so that it can benefit others.
Btw, I recommend dropping IdentityFile in your .ssh/config and relying on your agent to handle all authentication; just make sure you add all SSH keys to your agent. You can also drop the -A on the command line, since this is redundant with ForwardAgent yes option.  There is probably a config option for -t, but don't recall what it is.


Fixing discover_counter_types API function

This fixes #1787: discover_counter_types not working

@stevenrbrandt Could you please verify whether this fixes your problem?

@stevenrbrandt reported that this fixes his problem


Doesn't work with web sources

Hey, neat plugin! just tried it today and sadly it doesn't work for embedded images from the web. For example, doesn't work with this code:
![|500](https://imgaz2.staticbg.com/thumb/large/oaupload/banggood/images/58/DC/9937f2af-3de1-4fbe-8a57-37681815fe26.jpg)

I actually never tried it with web embedded images.
If I find the time I will look into it and keep you updated when I get it working.


Generate Java class from JSON

https://www.baeldung.com/java-generate-class-from-json

No need to generate a class this time. VIA CEP API already provides a Cep class.


[HELP (Not Launching/ Crashing)]

Checklist

[X] I have given details of my install including Distribution, Wayland/ XOrg, Parameters Used, echo $XAUTHORITY, etc.
[X] I have provided logs showing any errors, if available (use DEBUG=1 zwift)
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of previous issue.

Describe the issue
I successfully installed docker.
I try to run zwift but I get:
$ zwift
You are running latest zwift.sh 👏
permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Post "http://%2Fvar%2Frun%2Fdocker.sock/v1.47/images/create?fromImage=netbrain%2Fzwift&tag=latest": dial unix /var/run/docker.sock: connect: permission denied
docker: permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Head "http://%2Fvar%2Frun%2Fdocker.sock/_ping": dial unix /var/run/docker.sock: connect: permission denied.
See 'docker run --help'.
Error - Error can't run zwift, check variables!

Distribution Details
linux mint 22
just installed docker
I have an old nvidia card
Reproduction steps

type zwift
press enter

You are probably not a part of the docker group. You need to add yourself to the docker group.
Can't remember quite what the command is, but something like usermod -aG docker username

Thanks for the response, I tried:
$ sudo usermod -aG docker MY_USER_NAME
logged out, and in again, and tried zwift  command:
$ zwift
You are running latest zwift.sh 👏
permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Post "http://%2Fvar%2Frun%2Fdocker.sock/v1.47/images/create?fromImage=netbrain%2Fzwift&tag=latest": dial unix /var/run/docker.sock: connect: permission denied
docker: permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Head "http://%2Fvar%2Frun%2Fdocker.sock/_ping": dial unix /var/run/docker.sock: connect: permission denied.
See 'docker run --help'.
Error - Error can't run zwift, check variables!

I also see my user name in the group:
$ grep docker /etc/group
docker:x:999:MY_USER_NAME

I no longer get that error. I will look up the next error  ;-)


feat: adding faker.js support to gherkin

To generate fake data inside examples on your gherkin tests

I added a plugin called fakerTransform. This plugin adds a callback on transform function that will turning the faker API using a mustache string format inside example of the gherkin scenario outline before running the test steps

Type of change

:rocket: New functionality

Checklist:

[ x ] Tests have been added
[ x ] Documentation has been added (Run npm run docs)
[ x ] Lint checking (Run npm run lint)
[ x ] Local tests are passed (Run npm test)

Thanks man. I'm happy to help.


Add kubelet credentialprovider API reference

This is a followup of #30859.
/hold
until #30859 is in.

Preview of updated pages:

https://deploy-preview-30860--kubernetes-io-main-staging.netlify.app/docs/reference/
https://deploy-preview-30860--kubernetes-io-main-staging.netlify.app/docs/reference/config-api/kubelet-credentialprovider.v1alpha1/
https://deploy-preview-30860--kubernetes-io-main-staging.netlify.app/docs/tasks/kubelet-credential-provider/kubelet-credential-provider/

Related enhancement issue https://github.com/kubernetes/enhancements/issues/2133 and KEP
Can we get a @kubernetes/sig-node-pr-reviews review on the proposed Kubelet CredentialProvider (v1alpha1) page
/sig node

/assign

/hold cancel

/approve

/lgtm


Prevent unauthorized reads before they happen

This prevents us from leaking information about what patient resources
exist / don't exist on the system, which was deemed useful in case an
implementer uses sensitive data for the Resource.id of the Patient
resources (which still isn't advised).
Signed-off-by: Lee Surprenant<EMAIL_ADDRESS>

LGTM

Message is consistent?

Since we're not divulging any information that the user hasn't directly passed us, I opted for a more verbose message.  Example:

Interaction with 'Patient/123abc' is not permitted under patient context 'xyz'.

This contrasts with the more generic message we return in the other cases where the resource(s) involved in the interaction belong to some compartment that we (and potentially the end user) doesn't know until it is executed.


INSTALL and LOAD httpfs didn't perform in a batch as instructed

hello friends,
thanks a lot for wonderful duckdb.
i managed to try it, but encountered a small problem.
the suggestion to run
%%sql
INSTALL httpfs;
LOAD httpfs;
didn't work for me, instead i could run %sql with each of the separate lines.
thanks again,
alex

hey @alexbodn, we fixed the issue reported by @Alex-Monahan in https://github.com/ploomber/jupysql/issues/674 and it'll be part of the next release
I ran:
In [1]: %load_ext sql
Found pyproject.toml from '/Users/eduardo/dev/jupysql'

In [2]: %sql duckdb://

In [3]: %%sql
   ...: INSTALL httpfs;
   ...: LOAD httpfs;
   ...:
   ...:
Running query in 'duckdb://'
Out[3]:
+---------+
| Success |
+---------+
+---------+

In [4]: quit
Closing duckdb://

in the development version and it's also fixed so it looks like it was the same problem.


Title screen doesn't always inherit the menus framerate value

This issue comes from the exiting event of menus, which sets the framerate limit back to the normal value instead of the menus value. I have some ideas for how I would like to fix this.

This might be resolved with my useMenuLimit update.
Will investigate later.


Provide an alpine package of executable

0x07aa9c7e03a795d250a2ac48bd73b9c7f8adab69a549cebd97fc157a093a5a4a

We've switched to publishing via Prometheus upstream promu packaging. For distribution packages, we should move this to the upstream issue.
https://github.com/prometheus/promu/issues/93


Run inference on custom data

To run inference on custom data you need to train the proposed solution from scratch:

First of all, collect images of needed face. Extract facial keypoints for each.
Then you need to finetune ALAE on your images, use code from here. We use VGG19 perceptual loss to minimize identity gap.
Use finetuned ALAE and train the model using this script.


Rewrite netunicorn.director.mediation to stateless version

Remove code-fired tasks, store tasks in the DB, and implement a loop to look for things into the DB.

Probably isn't the best decision at the current level.
Probably will return to it later.


Can't have resources with multiple endpoints on the same scheme in the manifest

See https://github.com/dotnet/aspire/blob/eeb1266a29949ad3f31fddd4a8c8cf956d079db2/src/Aspire.Hosting/Publishing/ManifestPublishingContext.cs#L245-L247
I just hit this trying to build out a sample that adds HealthChecksUI. Adding a named HTTP(S) endpoint to a project dedicated to health checks UI causes manifest publishing to error with an exception due to the line above.
@mitchdenny @ReubenBond @davidfowl

Is this fixed now @ReubenBond?

@ReubenBond can you update the status here? I think you fixe this.

Fixed in https://github.com/dotnet/aspire/pull/2719


While extracting attention weights, set segment_ids all zeros ?

The code in this line means set segment ids to zeros for both segments, I don't know whether this is a bug?
https://github.com/clarkkev/attention-analysis/blob/7b4ed20b2c58a211970ffc19c2d957b2c35ea0ea/extract_attention.py#L30

It is pretty normal to finetune BERT with a single segment of [CLS][SEP]. For most tasks there aren't really two segments (e.g., dependency parse examples are a single sentence) so it is fine. But yes, it may have been better to set the segment ids as 0 for the first segment and 1 for the next for our unlabeled data analysis.


Update payout comment

Testing result.
https://github.com/ubiquity/bounty-bot/issues/165

Sorry but small detail:
I wanted the truncated wallet address to be four characters longer to closer match the width of the claim "button"
[ CLAIM 500 DAI ]
0x123456...123456


reserve fee as an .env variable

Have the fee reserve as an env variable, defaults to 4000 msats

One nitpick: python variable is called RESERVE_FEE_MIN and environment variable is LNBITS_FEE_RESERVE_MIN
Consistent name like RESERVE_FEE or FEE_RESERVE would be nicer.

@talvasconcelos, unfortunately tests are still failing (bleskomat extension?).

Let's get this PR back out of the grave. Any reason why the default is increased from 2 sat to 4 sat?

Let's get this PR back out of the grave. Any reason why the default is increased from 2 sat to 4 sat?

i think it was Ben's call!

Codecov Report

Merging #631 (f45c055) into main (48a5751) will decrease coverage by 2.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
- Coverage   41.84%   39.67%   -2.18%
==========================================
  Files         216      218       +2
  Lines       11388    12021     +633
==========================================
+ Hits         4765     4769       +4
- Misses       6623     7252     +629

Impacted Files
Coverage Δ

lnbits/core/services.py
53.21% <100.00%> (-0.04%)
:arrow_down:

lnbits/settings.py
94.73% <100.00%> (+0.29%)
:arrow_up:

lnbits/wallets/lndrest.py
17.39% <0.00%> (-21.50%)
:arrow_down:

lnbits/wallets/cln.py
21.69% <0.00%> (-12.92%)
:arrow_down:

lnbits/db.py
80.80% <0.00%> (-9.61%)
:arrow_down:

lnbits/wallets/macaroon/macaroon.py
27.53% <0.00%> (-5.80%)
:arrow_down:

lnbits/app.py
66.19% <0.00%> (-4.26%)
:arrow_down:

lnbits/extensions/watchonly/views_api.py
22.03% <0.00%> (-2.43%)
:arrow_down:

lnbits/bolt11.py
78.57% <0.00%> (-2.39%)
:arrow_down:

lnbits/commands.py
72.85% <0.00%> (-1.43%)
:arrow_down:

... and 24 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


ZeroDivisionError

I am receiving the ZeroDivisionError at the end of the last step of the first epoch. For some reason, iter_test is equal to zero which causes the error.
Currently, running the StyleTTS2 Webui with 12gb of VRAM with RTX 3060. I could already train some voices. However, at some point started to receive the current error.
File "C:\Users\User\Desktop\StyleTTS2\StyleTTS-WebUI\venv\Lib\site-packages\styletts2\train_finetune_accelerate.py", line 726, in main
logger.info('Validation loss: %.3f, Dur loss: %.3f, F0 loss: %.3f' % (loss_test / iters_test, loss_align / iters_test, loss_f / iters_test) + '\n\n\n')
^~
ZeroDivisionError: division by zero
Could that be related with the torch? I am using the version 2.3.1 as suggested. At the initialization I am receving the following statements as well.
C:\Users\User\Desktop\StyleTTS2\StyleTTS-WebUI>call venv\Scripts\activate
C:\Users\User\Desktop\StyleTTS2\StyleTTS-WebUI\venv\Lib\site-packages\pyannote\audio\core\io.py:43: UserWarning: torchaudio._backend.set_audio_backend has been deprecated. With dispatcher enabled, this function is no-op. You can remove the function call.
torchaudio.set_audio_backend("soundfile")
177
bert loaded
bert_encoder loaded
predictor loaded
decoder loaded
text_encoder loaded
predictor_encoder loaded
style_encoder loaded
diffusion loaded
text_aligner loaded
pitch_extractor loaded
mpd loaded
msd loaded
wd loaded
Running on local URL:  http://<IP_ADDRESS>:7860
To create a public link, set share=True in launch().
No language specified, language will be first be detected for each audio file (increases inference time).
Lightning automatically upgraded your loaded checkpoint from v1.5.4 to v2.4.0. To apply the upgrade to your files permanently, run python -m pytorch_lightning.utilities.upgrade_checkpoint C:\Users\User\.cache\torch\whisperx-vad-segmentation.bin
Model was trained with pyannote.audio 0.0.1, yours is 3.1.1. Bad things might happen unless you revert pyannote.audio to 0.x.
Model was trained with torch 1.10.0+cu102, yours is 2.3.1+cu121. Bad things might happen unless you revert torch to 1.x.
Loaded Whisper model

I had this issue before myself but I just deleted the training data and renamed my audio file to something plain and then did it again and the error  didn't come up again.

Can you check if it's related to this issue?
https://github.com/JarodMica/StyleTTS-WebUI/issues/14

Closing for now, reopen if it's still occuring


How would I add a JS file that registers multiple components?

https://github.com/ngokevin/aframe-physics-components/blob/master/dist/aframe-physics-components.js
This physics component is bundled up with physics-body and physics-world. They are coupled and are bundled with cannon.js.

I would turn url into urls and make it an array

Also, I think it might be nicer to turn this into an array of objects and have slug be a key. Or at the very least duplicate slug?

Possible syntax:
aframe-physics
  - name: physics-body
    versions:
      0.3.0:
        version: <version>
        path: <path>.min.js
  - name: physics-world
    versions:
      0.3.0:
        version: <version>
        path: <path>.min.js

Array of objects has the advantage that the name of each component is specified.
But just bundling components may not be enough, similar cases could also include a system. leap-hands and aframe-extras.physics, for example.

That'd make sense. It'd still allow a one component per file, and we can perhaps in the future allow component packs depending on how things go.

This is the format I used for Holodeck Club's manifest.jsons.
I would suggest using the unpkg (née npmcdn) syntax (e.g., https://unpkg.com/package@version/file). You can read these notes on the syntax.
{
  "components": [
    "/common/assets/js/voice-controls.js",
<EMAIL_ADDRESS>    "annyang",
<EMAIL_ADDRESS><EMAIL_ADDRESS>    "github:nylki/aframe-lsystem-component",
    "https://holodeck.club/common/assets/js/lib/voice-nav.js",
    "maxkrieger/aframe-draw-component",
<EMAIL_ADDRESS>  ]
}

Just some thoughts.

@donmccurdy your format looks good, i'm gonna start implementing it

Great! That would be enough for me to pull a few components in from aframe-extras. Maybe three-model and ply-model. Can figure out systems another day. 🙂

For like the ocean component, you can either give it its own package.json + directory...or just build a dist within aframe-extras. Either way currently, needs a separate dist. Separate directory is preferred so we can give it its own README/preview image.
Yeah, need to think about systems since your physics isn't 1:1...(physics system <- body, joint, etc). It'd be awesome just to checkbox physics.

👍 i just extended my build script to create dists for whitelisted components, that should fine work for ocean.
Will probably export physics to a repo, but still at least a couple components + a system involved yeah.

Need to figure out a way to match a component with a GitHub README hmm

@donmccurdy This seems doable:
  aframe-physics:
    names: body, dynamic-body, static-body, joint
    versions:
      0.3.0:
        version: ^1.0.0
        path: dist/aframe-physics.min.js

https://github.com/aframevr/aframe-registry/pull/26

@ngokevin I'm late on this (saw that you merged a patch already) but what about changing names to components? Then, if/when we're ready to support systems, primitives, etc., the naming and distinction would be explicit?

That sounds good...I'll file an issue.


Fix cat common query parameters

This extracts the cat APIs changes from https://github.com/elastic/elasticsearch-specification/pull/3297.

💚 All backports created successfully

Status
Branch
Result

✅
8.x

✅
8.17

Questions ?
Please refer to the Backport tool documentation


Enhancing the "Get Started" button

Issue
As you can see the Get Started button can be enhanced by adding shadow on hover or other CSS elements.
https://github.com/MonalikaPatnaik/UMatter/assets/53009878/dfcd9467-1c9d-4de8-b0c5-21700b3b6e40

@MonalikaPatnaik Sorry Actually I forgot to mention that I am a GSSoC'23 contributor.
Can you please add the GSSoC tag to the issue ?

Yeah..you can work on this!
Thanks!


Correction for raw affiliation Aeres University of Applied Sciences; Wageningen University and Research Centre

Correction needed for raw affiliation Aeres University of Applied Sciences; Wageningen University and Research Centre
raw_affiliation_name: Aeres University of Applied Sciences; Wageningen University and Research Centre
new_rors: 03jnx2c74;04qw24q55
previous_rors: 04qw24q55
works_examples: W2941292489
contact: 2ffec7c467af2517cd14053e2ddbcf38:0820d31d837d0395e2a3 @ hotmail.com

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Refactor vinti_sim (was VintiSimulationGNU) as an Octave function

Inputs:

Initial condition (state vector)
Drag condition (e.g., tumbling, frontwise, etc.)
Simulation length (iterations)

Outputs:

Array of output state vectors (1 for each predicted time)
Consider logging inputs as a flag option

Rewrite Mainvinti.c to read/write from/to stdin/stdout

some options for command line argument parsing https://stackoverflow.com/questions/9642732/parsing-command-line-arguments-in-c

Done in branch new-vinti-sim


Unclear meaning of attribute "validate_signature"

There is an attribute "validate_signature" on the service provider. This attribute overrides whether service_provider.valid_signature? actually does check the signature of a document.
However, if we ask if a request is valid, then only the metadata is checked and not this attribute.
My suggestion would be to unify all the occurrences under a method
def ServiceProvider::validateSignature?
  attributes[:validate_signature] || (metadata.respond_to?(:sign_authn_request?) && metadata.sign_authn_request?)
end

but I am not sure if this was the intended semantic?

@immerda I understand your confusion because ServiceProvider class is actually not implemented properly which means ServiceProvider class and SP Metadata is not properly working together as you mentioned. We are going to simplify the gem structure and reduce configuration if SP metadata already has the configs otherwise it should be overridden by ServiceProvider configs as you mentioned.

I will close this question since no other question has been raised for a long time. Please open it if you have more questions related to your original one.


fennel-language-server: init at 2022-10-26

Description of changes
Language Server for Fennel (https://github.com/rydesun/fennel-language-server)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

merge when


[WIP] Update Byte Buddy to 1.12.6 (fixes #7)

all info in #7

Just to update here - I am still looking into this, but I haven't fixed it yet.
The interesting bit is that -keep class tech.httptoolkit.relocated.** { *; } isn't sufficient. That means there's some low-level detail of the transformation that r8 is doing that breaks something. That's not super surprising (I can imagine all sorts  of changes which shouldn't affect any normal usage but do affect bytebuddy somehow) but it's quite inconvenient.
We can work around this by editing the include/exclude rules in the distJar gradle task (which copies in specific original untouched class files on top of the r8 output) and that works, but it's a tradeoff to try and do that for the smallest compatible set of files required to make this work.
I do have a working patch, by excluding net.bytebuddy.** and org.objectweb.asm.** entirely from r8, and adding an include/exclude for just tech/httptoolkit/relocated/net/bytebuddy/agent/**/* to the gradle distJar build. That leaves us with a dist jar of 3MB though, which is a fair jump on the 1.75MB JARs we've had until now. This compares to 4.6MB for the unminified build. I'm also not 100% sure why this works yet, which i don't love.
At the end of the day, it's not a disaster to push the size up, and maybe we'll have to, but that extra weight goes directly onto the HTTP Toolkit download for every user, so I'd like to limit it if I can, or at least explain exactly what's going on and why shrinking this is impossible.
I'll keep digging and update when I have more :smiley:. Let me know if you work out any clues on your end in the meantime!

Unfortunately didn't have time to look into this.
It's really weird that keeping all shaded classes is not enough for this to work.
Did you also try to exclude only ASM or only bytebuddy?
I think that increasing the JAR size by 1.25MB (I know that it's 70% 😄) hurts but the installer is at 80MB already (at least for win). If we still try to minimize the bytebuddy/asm code these kind of problems could bite us again in the future. Altough I understand the struggle as not everyone is using this and would be penalized by having to download more...

I think that increasing the JAR size by 1.25MB (I know that it's 70% :smile:) hurts but the installer is at 80MB already (at least for win).

True, but these kind of things add up. And this also affects server updates (currently ~30MB) and this JAR gets copied into Docker containers when they're intercepted too (as part of a payload of about 10MB total). It's not critical, but I would like to avoid letting any of this creep up too much.
Anyway, I've managed to pull the size down a bit further (to 2.3MB) and simplify the config en route by disabling R8's automated optimizations entirely. Looks like those were only saving 0.1MB anyway, and hopefully that'll make this much less fragile in future generally, since it now mutates the code far less. I've pushed that change here.
I think this'll do for now. I'm going to merge this and release as 1.3.0 in just a sec. I've also fixed the annoying R8 build warnings from Akka & Scala on main, so hopefully it'll be easier to investigate and debug all any similar issues like this in future.
Thanks again for all your help and hard work on this! Really glad we've managed to get it working :smile:

Great!, good job :)


Problem with cs50.dev platform

I did a rebuild and now it takes too long to load the cs50.dev platform
Version: 1.93.0
Commit: 4849ca9bdf9666755eb463db297b69e5385090e3
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/<IP_ADDRESS>
Embedder: codespaces

/question please use your course support channel.


[CELEBORN-1773] Revert [CELEBORN-1376] Push data failed should always release request body

What changes were proposed in this pull request?
Revert CELEBORN-1376.
Why are the changes needed?
Duplicate release data, because Encoder will release it event send replica data timeout.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing uts.

@RexXiong  @AngersZhuuuu  PTAL.

Duplicated with https://github.com/apache/celeborn/pull/2992


net-mgmt/zabbix-agent: add variants support / release 1.10

for #2129
depends on https://github.com/opnsense/tools/pull/251

@fraenki Having this still open while wanting to build variants from tools clogs up the build so I am going to merge this now.

@fichtner Thanks :)


Webpack 4.5 support added

@kolychev So sorry to reply so late, I clearly have missed this PR. Thank you!


momentjs returning a different result in browser than in karma unit test

I am writing some unit tests for my AngularJS app with karma and jasmine. I am also using momentjs.
When I call the same function from the moment library in the browser I get a different result than from the karma unit test.
It's breaking my unit tests.
In the browser this is what I get:

In my unit test I get a different result. For example when I call the function to get the start of the month and week I get '1' instead of 53 for the week number.
Calendar.data.currentCalendarMonth = moment('01-01-2017', dateFormat).clone().startOf('month');
//showing different results than in the browser
console.log(Calendar.data.currentCalendarMonth.format());
console.log(' week ', Calendar.data.currentCalendarMonth.week());

Here is my codepen with the reproduced bug: https://codepen.io/aubz/pen/VNQjgV
Edit: I am using these moment dependencies in my project:
"moment-timezone": "0.5.4",
'moment/min/moment-with-locales.js',
'moment-timezone/builds/moment-timezone-with-data.js',

Can you try with the latest versions of moment & moment-timezone?

Please re-open if you still have concerns.
I don't think the unit test should affect Moment.


Possibility to add commands/templates to ignore list.

I don't like to see 500 ls in my history.

:+1:


IMAP timeout not configurable

Given this BT:

CRITICAL: Account.0.Driver.0 unhandled error occurred while reacting to event ('connect', (), {}): abort: IMAP4 protocol error: no response after 2 secs
ERROR   : IMAP4 protocol error: no response after 2 secs
Traceback (most recent call last):
  File "/home/michael/workspace/imapfw/imapfw/edmp.py", line 404, in react
    self._cache[topic] = self._react(topic, args, kwargs)
  File "/home/michael/workspace/imapfw/imapfw/edmp.py", line 382, in _react
    return func(*args, **kwargs)
  File "/home/michael/workspace/imapfw/imapfw/drivers/imap.py", line 31, in connect
    return self.imap.connect(host, port)
  File "/home/michael/workspace/imapfw/imapfw/imap/imap.py", line 125, in connect
    self.imap = imaplib2.IMAP4(host, port, debug=3, timeout=2)
  File "/home/michael/workspace/imapfw/imapfw/imap/imaplib3/imaplib2.py", line 372, in __init__
    self.welcome = self._request_push(name='welcome', tag='continuation').get_response('IMAP4 protocol error: %s')[1]
  File "/home/michael/workspace/imapfw/imapfw/imap/imaplib3/imaplib2.py", line 188, in get_response
    raise typ(exc_fmt % str(val))
imapfw.imap.imaplib3.imaplib2.abort: IMAP4 protocol error: no response after 2 secs

It would be nice to be able to set this on a per-connection level in the rascal file. And in any case, two seconds seem to be really short. I guess a sane default would be at least 10 seconds, probably even 30.

Yes. I'm using short delays to fail fast while hacking on imapfw. Exposing this setting at some point is still a TODO.
We have more important work underway, for now. :-)

Allright with the priority, but why closing this issue then, instead of keeping it as a remainder for the TODO?

This issue is pertinent. I have a lot of things in mind and I'm in the way of sharing this with new contributors. I don't want issues to become our next TODO list.

We recently moved the TODO to the public writable wiki. I've added your items to the list.
Thank you for the reports!


[Overlapping] trim spread to 6 decimals

fix #1245

[ ] input limitation
current:
when typing 0.1234567890123456789
the input allows user input to proceed past the 6th decimal
when focus out of the input field, it trims the visible data to 6 decimals

updated:
when typing 0.1234567890123456789

limit the input field to only accept 6 decimals. do not allow input any value past the 6th decimal.


Added BrandId and allowReassign to template request

Rebased/squashed/tweaked/merged, thanks @jnjcub !


False positive: B018

Ruff 0.0.260
Reproducer:
(sphinx) PS I:\Development\sphinx> pytest -vvv bug_b018.py
========================================================================================================= test session starts =========================================================================================================
platform win32 -- Python 3.11.0, pytest-7.2.2, pluggy-1.0.0 -- I:\Mambaforge\envs\sphinx\python.exe
cachedir: .pytest_cache
rootdir: I:\Development\sphinx, configfile: pyproject.toml
plugins: xdist-3.2.0
collected 1 item

bug_b018.py::test_attribute_error PASSED                                                                                [100%]

========================================================================================================== 1 passed in 0.01s ==========================================================================================================
(sphinx) PS I:\Development\sphinx> type bug_b018.py
import pytest

def test_attribute_error():
    obj = object()
    with pytest.raises(AttributeError):
        obj.nonexistent
(sphinx) PS I:\Development\sphinx> ruff --isolated --show-source --select B018 bug_b018.py
bug_b018.py:7:9: B018 Found useless expression. Either assign it to a variable or remove it.
  |
7 |         obj.nonexistent
  |         ^^^^^^^^^^^^^^^ B018
  |

Found 1 error.
(sphinx) PS I:\Development\sphinx>

I think that this may be related to #3453 and #3455, as this is a regression from 0.0.259 to 0.0.260.
In tests it can be useful to check that an attribute does not exist, or some behaviour relating to side effects on accessing an attribute. Perhaps if unittest or pytest context managers are detected, B018 should not be raised?
Thanks,
Adam

Yeah I considered not flagging any expressions that use attributes or subscript accesses as "useless". It would've limited the rule significantly, but it also would help us avoid a class of false-positives...

I will prefer if it stays as is, it is better having to add a noqa than having a dangling attribute reference, that either means it's a non-required expression or is a descriptor with secondary effects. The first one should be deleted, the second one should be avoided and both require human intervention.

... it is better having to add a noqa than having a dangling attribute reference

I would tend to agree in the general case, my specific request was that:

if unittest or pytest context managers are detected, B018 should not be raised

Would you agree with this, specifically in a testing context?
Thanks,
Adam

I think the request is reasonable but I'm hesitant to act on it. I see it as similarly to how we handle unused imports within ModuleNotFoundError-like try-except blocks. We don't ignore them, since it can be surprising to users and hard to understand the intent explicitly. But we do have a custom message that points users in the right direction for a more preferable pattern.
In this case, my preference would be to encourage a pattern like:
with blah blah:
    _ = obj.nonexistent

To me, that signals the intent that the variable is intentionally unused (and IIRC we should avoid flagging that as an unused local).

_ is often used as gettext translation variable.

It can be any var matching "dummy-variable-rgx" like _noqa =  = obj.nonexistent.

I came here with the same issue and I believe the underscore suggestion is a nice solution.

Closing this for now as we don't intend to change it, and I recently added the underscore suggestion to the docs (but may not be released yet, can't remember off-hand).


AttributeError: 'NoneType' object has no attribute 'cdequantize_blockwise_fp32'

Hi and thanks for your hard work. I am trying to generate a prompt but I get the following error regardless of the LLM I use.

Full stack trace:

2024-06-19T13:05:41.382058852Z Special tokens have been added in the vocabulary, make sure the associated word embeddings are fine-tuned or trained.
2024-06-19T13:05:41.382520912Z Seed is too large. Truncating to 32-bit:<PHONE_NUMBER>
2024-06-19T13:05:41.382541762Z 2024-06-19 13:05:41,382 - ComfyUI_omost.omost_nodes - WARNING - Seed is too large. Truncating to 32-bit:<PHONE_NUMBER>
2024-06-19T13:05:41.387806127Z The attention mask and the pad token id were not set. As a consequence, you may observe unexpected behavior. Please pass your input's `attention_mask` to obtain reliable results.
2024-06-19T13:05:41.387828417Z Setting `pad_token_id` to `eos_token_id`:128001 for open-end generation.
2024-06-19T13:05:41.393552811Z !!! Exception during processing!!! 'NoneType' object has no attribute 'cdequantize_blockwise_fp32'
2024-06-19T13:05:41.394116180Z Traceback (most recent call last):
2024-06-19T13:05:41.394125810Z   File "/workspace/ComfyUI/execution.py", line 151, in recursive_execute
2024-06-19T13:05:41.394144320Z     output_data, output_ui = get_output_data(obj, input_data_all)
2024-06-19T13:05:41.394146820Z   File "/workspace/ComfyUI/execution.py", line 81, in get_output_data
2024-06-19T13:05:41.394149030Z     return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
2024-06-19T13:05:41.394152070Z   File "/workspace/ComfyUI/execution.py", line 74, in map_node_over_list
2024-06-19T13:05:41.394154470Z     results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
2024-06-19T13:05:41.394156520Z   File "/workspace/ComfyUI/custom_nodes/ComfyUI_omost/omost_nodes.py", line 279, in run_llm
2024-06-19T13:05:41.394158670Z     generated_text = self.run_local_llm(
2024-06-19T13:05:41.394160780Z   File "/workspace/ComfyUI/custom_nodes/ComfyUI_omost/omost_nodes.py", line 243, in run_local_llm
2024-06-19T13:05:41.394163650Z     output_ids: torch.Tensor = llm_model.generate(
2024-06-19T13:05:41.394166290Z   File "/venv/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
2024-06-19T13:05:41.394168220Z     return func(*args, **kwargs)
2024-06-19T13:05:41.394170850Z   File "/venv/lib/python3.10/site-packages/transformers/generation/utils.py", line 1758, in generate
2024-06-19T13:05:41.394173030Z     result = self._sample(
2024-06-19T13:05:41.394175040Z   File "/venv/lib/python3.10/site-packages/transformers/generation/utils.py", line 2397, in _sample
2024-06-19T13:05:41.394176990Z     outputs = self(
2024-06-19T13:05:41.394179450Z   File "/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
2024-06-19T13:05:41.394181710Z     return forward_call(*args, **kwargs)
2024-06-19T13:05:41.394184090Z   File "/venv/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward
2024-06-19T13:05:41.394186280Z     output = module._old_forward(*args, **kwargs)
2024-06-19T13:05:41.394188250Z   File "/venv/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 1164, in forward
2024-06-19T13:05:41.394190370Z     outputs = self.model(
2024-06-19T13:05:41.394192430Z   File "/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
2024-06-19T13:05:41.394194630Z     return forward_call(*args, **kwargs)
2024-06-19T13:05:41.394196650Z   File "/venv/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward
2024-06-19T13:05:41.394198700Z     output = module._old_forward(*args, **kwargs)

Running on Runpod with a 4090.

I have not had time to look into it further unfortunately.


Add topics notebooks to the gallery

We briefly added a 'Showcase' page to the new holoviews website but decided that page wasn't worth another top level heading. Instead, we are going to hide that heading/page for now with the plan to add topics to the gallery (with custom thumbnails as necessary) to show the content that we had planned for showcase.
We aren't 100% on this plan just yet (other than hiding showcase for now) as we need to be sure everything we want can be framed in this way.

I'll work on cleaning up my logistic map and reaction diffusion notebooks. I know they work so it won't take long.

The topics examples should probably go to pyviz.org instead; I think they'll illustrate how to use PyViz tools to explore topics, rather than specifically how to use HoloViews.

Agreed. And the same thing has been decided for the datashader topics too?

Yes.

The notebooks now live on example.pyviz.org but we should still link to them.

Duplicate of #4037 now.


Provide calculated values (final paths, names, versions, etc) to user without building app

Issue Type

[ ] Bug Report
[x] Feature Request
[ ] Other

Current/Missing Behaviour
User has their values they pass to nwbuild, but no way of double-checking, changing or even seeing any value that nw-builder arrives at
Expected/Proposed Behaviour
User has an alternate "prepare" mode, where they can pass in their options and receive the calculated state (after parsing and applying defaults and path resolutions), to be able to check for validity and/or make adjustments
Usage like:
nwbuild({
	mode: 'prepare'
	// ...
});

Additional Info

Package version: 4.11.3
Operating System: Windows 10 x64
Node version: v20.9.0, 22.7.0
NW.js version: 0.92.0

https://github.com/nwutils/nw-builder/pull/1265#issuecomment-2488425920


WSAS-2030 : persisting module globally engaged status

Closing the PR due to,

This has API changed which cannot go with a patch release
The commit message needs to reflect the kernel JIRA

I will fix the above issues and will send a new PR.


No data in WaaSUpdateStatus table 3 days

Hi team, I met one issue that my 100+ machines has no data send to this table in 3 day. But actually per my check WaaSDeploymentStatus's latest data is today and the last scan time is 1 day ago.
Do you have any insights about this? I tried to run the script and it's succeeded...

@xuegao112 Which article are you referring to?

Hi @RAJU2529  This one:
https://docs.microsoft.com/en-us/windows/deployment/update/update-compliance-get-started

@xuegao112
The issues section of this repository is intended for product documentation issues only.
Please consider opening a product support ticket by the following link below for your problem so that it gets resolved quickly.
Windows 10 Support
Feel free to re-open this issue if you think there is a problem with the documentation.
Thank you.


Improve exponential backoff of mdns service resolution retries

Improve exponential backoff if mdns service resolution introduced in #268 by also backing off if service resolution fails.
Also, small do not issue a remove_service callback if the service is unknown.

@balloob This should be in HA 0.88


Response concerning "State of the field" for JOSS

@lungsi @mjsottile Here comes my review!
The final unchecked point is "state of the field". I am now aware of any similar package, and assuming that @lungsi doesn't either, he/she could simply add a sentence stating this. But that misses the point that the main reason for publishing this package is the lack of any other tools that implement the same techniques.
Originally posted by @khinsen in https://github.com/openjournals/joss-reviews/issues/3735#issuecomment-938733157

@khinsen @lungsi : Concerning "State of the field". I cannot find any published libraries on dimensional analysis in Clojure, but the problem is discussed online*. A book that keeps coming up is "Functional programming and applications" (ISBN: 10:<PHONE_NUMBER>). I have not read that book, but it apparently covers solving the problem using functional languages (obviously not in Clojure, as the book dates back to 1980). It is possibly relevant for the "state of the field", though.

http://www.leadlab.ca/2016/07/27/solving-the-trivial-problem-of-dimensional-analysis-in-clojure/
https://github.com/mfey/units2 (somewhat)

Originally posted by @oyvinht in https://github.com/openjournals/joss-reviews/issues/3558#issuecomment-945703201

Comments on the "State of the field" is given in the later paragraphs under the section "Statement of need".

Numerous softwares have been developed to deal with dimensions in some shape or form (Preussner, 2018; Sharma, 2021). Most incorporate the ability to tag quantities with units, however, few are capable of doing consistency checks and fewer still deal with dimensionless products let alone, deriving dimensionless products.
diman is designed with an emphasis on analysis; the application of the algebraic theory of dimensionally homogeneous functions (Langhaar, 1951). It can check for dimensional homogeneity of a given equation and can derive the complete set of dimensionless products of a given equation.

In addition to those mentioned above by @oyvinht I have found 55 dimensional related software products (as cited above (Sharma, 2021)—obsolete and active ones. The Clojure based units2 (https://github.com/mfey/units2 pointed out by @oyvinht) advertises to be "unit-aware computing", i.e. numerical computation with unit annotations, most of the discovered softwares target this use. Those that have analytical features are typically limited to performing checks for dimensional homogeneity. The number of tools capable of consistency checks are relatively lesser than those that target unit-aware computing. Tools capable of performing consistency checks are advertised as dimensional analysis tools.
Although the task of consistency checking with a pen and paper can be regarded as trivial (as suggested by the link provided by @oyvinht), its software implementation is more involved, as illustrated by Peter Henderson in eleven pages in the book "Functional programming and applications" (ISBN:<PHONE_NUMBER>), pages 60-71. Also many of these "dimensional analysis" tools that are capable of consistency checks perform consistency checks of units (e.g. if the right hand side has the unit feet/seconds and the left hand side has the unit meter/seconds, then the consistency check returns false), which suggests dimensions and units are considered as identical, but this is wrong. A unit reflects a particular measurement while a dimension is mathematical idea that refers to "the relationship between necessary coordinate concepts and the concept (of the quantity) which stands under them," the relationship and consequently the dimension is mathematically represented by some tag, in diman these are [M], [L], [T], [A], [K], [cd] and [mol].
The elementary function of dimensional checking—consistency checks of dimensions and not units—is a necessary function for derving dimensionless products. This capability and the ability to derive complete set of dimensionless products differentiates diman from all the above mentioned softwares. Although some dimensional softwares deal with dimensionless products in terms of a dimensionless unit tag for unit-aware computating, tools that deal with deriving dimensionless products are scarce. MATLAB® provides dimensional analysis feature within the Symbolic Math Toolbox, but this does not include function(s) to derived dimensionless products; this ability may be acquired via an add-on script (Thomas Tresch, 2021).

Your summary looks correct to me. There are indeed lots of solutions for unit-aware computation with physical quantities, for just about every language I know about, but that's something quite different from what diman does.


Timeline for Firefox VideoEncoder support

This is a question somewhat unrelated to this library, but:
I know most browsers have a public ticket system that allows devs to track the progress of features being added/fixed. I looked everywhere yesterday and couldn't find any mention of a timeline for VideoEncoder support in Firefox, like if it was even on their radar or not.
Do you know where to look for this? Are you in any secret discords where they talk about it?
Love your library by the way, was a breeze to implement & use, with no headaches yet.

It's funny you say this, because I feel exactly the same way. I was like, yeah for sure there's gonna be some thread about this, either some Reddit post or some Firefox internal discussion about WebCodecs support. But I also found absolutely nothing, as if they just won't ever consider adding it ever.
So yeah, I'm as lost as you are on this. Would be a shame if they don't feel the need to implement it at all. I'm sure it's a good amount of work, but Firefox is already packed with the codecs themselves, so "all it would take" is some wiring up. There is this, but I think it's just them saying "Yup, I think it's a good API". Besides that, nothing.
I think you'll need to resort to telling people to use Chromium or heck, even Safari. Hate doing that personally too, but what else can you do here.
And thank you for the nice words!

This mailing list post seems relevant: https://groups.google.com/a/mozilla.org/g/dev-platform/c/3g0fnn6682A

Huge news!

Look like VideoDecoder does not return undefined in Firefox Nightly anymore.


Fix typo in docs.md

External Contributor Checklist

🚨 Please review the guidelines for contributing to this repository.

[ ] Make sure that all commits follow the conventional commit specification for the Mender project.

The majority of our contributions are fixes, which means your commit should have
the form below:
fix: Quick typo fix

Changelog: <None>
Ticket: <None>

[ ] Make sure that all commits are signed with git --signoff. Also note that the signoff author must match the author of the commit.

Description
Please describe your pull request.
Thank you!

Hi @MarkGaskin, thanks a lot for the PR. It might sound a bit strange, but the patch cannot be merged until it is signed off by you, and follows the conventional commit style. The latter is already outlined in the PR description template, and the former can be done by amending the original commit (which you need for changing the description anyways):
git commit --amend -s, and then you can force-push with git push -f. At that point, the merge should be good to go.
Greetz,
Josef


[dkr] remove reference to the old libra_e2e image

Motivation
Following up 22bfee56f, the old image name libra_e2e is replaced with libra/validator.
Test Plan
Canarying in CI

Agreed. I will fold #6075 into this one.

/canary

/canary

:broken_heart: Test Failed - Build images and run cluster test

/canary

:broken_heart: Test Failed - commit-workflow

/canary

:broken_heart: Test Failed - commit-workflow

/canary

:sunny: Canary successful

/land
Rebased and removed the cutover temp variables used in canary. landing now


Changed some of the error handling

Using setFailed for error handling and moved log to debug

Bump @ethomson  here to see if you'd consider taking these changes.  Added setOutput here as well to enable a better workflow for Environments


Should multiply labeled edges be caught by Travis?

https://build.berkeleybop.org/job/release-go-ontology-daily-snapshot/133/
Removed: 2187 links
:: ERROR: multiply-labeled-edge: GO:0035278 GO:0006412 --> regulates negatively_regulates
Makefile:188: recipe for target 'go-basic.obo' failed
make: *** [go-basic.obo] Error 1
Build step 'Execute shell' marked build as failure
Archiving artifacts
Finished: FAILURE
I think the changing the logical def of GO:0035278 from:
'regulation of biological process'
and (mediated_by some miRNA)
and ('directly negatively regulates' some translation)
to
biological_process
and (mediated_by some miRNA)
and ('directly negatively regulates' some translation)
might fix this, but I am not sure that this is invalid in the non-filtered file. If you think this is the correct fix, I will make the simple edit.

I've looked at some other terms and
'biological regulation '
and ('positively/negatively regulates' some 'blah") also appears to work
eg: GO:0061767, negative regulation of lung blood pressure

Travis config is correct, but really this should be filtered as a redundancy.
Your fix above corresponds to the DP for regulation, so it's good to do it anyway.

I have fixed this so that the jenkins builds proceed.

I made the change but Jenkins still redballed with SAME issue

I looked and my fix seems to be reset to what it was, and not biological_process. Will try again.

SUCCESS! Blue Ball!!


Initializing a new BitSet using a byte[]

We have permission data stored as a byte[], can BitSet be initialized with a byte[]? If so, what would the syntax look like? something like: var bs = new BitSet(bitarray);
And if not, how would we implement it?

What do you expect to be in the array? The indexes of bits to be set or just binary values? I ask because I'm about to finalize v4 and it got array arguments. The elements of the array contains the indexes of bits to be set to 1.

Sorry, I'm having a hard time trying to figure out what you mean by "The indexes of bits to be set or just binary values". I'm looking for the same functionality that .NET BitArray(byte[] bytes) ctor provides.
Let me know if you have any other questions. Any chance we can get functionality by Thursday? Thanks!

To be precise, a BitSet that takes a Uint8Array.
We are, from the back end, encoding byte arrays (byte[]) into Base64 encoded strings. Then on the browser side we are decoding the Base64 string back into bytes (really Uint8Arrays) using Base64-js. We could like to then use BitSet to manage the set of bits as a bit array.

After reviewing the code, here is "an" implementation that accepts creating BitSets from a Uint8Array.
Here is some test code:
var fromTheWire = "JUI=";   // Byte array encoded in Base64.

//        Byte:   1    0
//which equals: 0x42 0x25 or 100 0010 0010 0101, with (msb) ...to... (lsb) (Note: which, I believe, is in reverse order than Hex string inputs).
var bytes = base64js.toByteArray(fromTheWire);

var accessRighs = new BitSet(bytes);
var ss = accessRighs.toString();    // expecting: "100 0010 0010 0101", actual: "100 0010 0010 0101"

var test = 0;
for(var i = 0; i < 16; i++)
{
    test = rights.get(i);
    // for i = 0, 2, 5, 9, and 14 should equal true. All else should equal false.
}

Code changes, I added the following to the end of parse(p)'s switch statement:
        case 'object':
            if (p instanceof Uint8Array) {
                var bits = 8;

                for (var i = 0; i < p.length; i++)
                {
                    n = p[i];
                    for (var j = 0; j < bits; j++) {

                        var k = i * bits + j;
                        var slot = Math.floor(k / bitsPerInt);

                        if (!P[slot])
                            P[slot] = 0;

                        P[slot] |= (n >> j & 1) << (k % bitsPerInt);
                    }
                }
            }
            else {
                throw 'Invalid param';
            }
            break;

I assume the code could be cleaned up and changed to support more than just Uint8Arrays but this is all we need to keep moving forward.
So, again, thank you for writing BitSet!
Note: base64js.toByteArray() came from here.

I'll push a new version tomorrow in the evening, I have a tight schedule atm, but I oriented on your question, if I can come up with a solution till tomorrow. Thanks for the code snippet, that helps in understanding what you're aiming for :)

Thanks for your patience and your participation in BitSet.js. I just published to the master. It's a really rough rewrite and please note, that I decided to make the library mutable.
If something breaks for you, please open a new ticket and I'll fix it! Otherwise, please let me know and I'll add the the tag v4.0.0 and publish it on npm.


start zone with kctf-

Otherwise, domain names that start with a digit will result in an invalid zone name

[E] could not register kctf.cloud subdomain

This is a breaking change, since you need to delete the old cloud dns zone since the name changed.


Cannot Install on Windows Due to File Path Length Limit

Every time I have tried to install this using Composer in Visual Studio I get an error saying that one of the files exceeds the 260 character OS file name limit. The file in question is:
vendor\composer\2bacad05\googleapis-google-api-php-client-services-9a0bab5\src\Contactcenterinsights\GoogleCloudContactcenterinsightsV1ConversationTranscriptTranscriptSegmentDialogflowSegmentMetadata.php
As you can see that file name is way too long. There is no acceptable reason for a professional developer to name any file in this manner. Please change the name of the PHP file to something like GCMetadata.php or something practical like that.

It looks like this was solved by @PostAlmostAnything by searching for "how to disable the 260 character limit using regedit on Windows"


Fix finding element index

Fixes #220
Similar to previous PR, I reworked finding element index to delegate that to container element.

Before

After

Ah, so you're saying that users don't like menu items in a random order? 😄
Thank you for the PR, I will take a look!

@Dreamescaper FYI I'm looking at this one, hope to get it in soon! I appreciate your patience. The huge blocker was the Auth PR and now that it's in, I'm free to look at all your PRs.

Thank you @Dreamescaper for the great PR! It's always nice to see that it's not only fixing a bug, but also improving the API design!


Is there a way to directly copy a string to mmap_sink?

When the string is large, iterating and assigning values becomes inefficient.
  std::string data{"word"};
  try {
    mio::mmap_sink mmap(path, 10);
    for (int i = 0; i < data.size(); ++i) {
      mmap[i] = data[i];
    }
  } catch (std::system_error e) {
    std::cout<<"error: "<<e.what()<<"\n";
  }

memcpy(&mmap[0], data.cstr(), data.size)

memcpy(&mmap[0], data.cstr(), data.size)

Thanks! I found that std::copy is also a good way.


[9.x] withCount() add failing test for example code from docs

Since #41914 the example from the docs no longer works.
use Illuminate\Database\Eloquent\Builder;

$posts = Post::withCount(['votes', 'comments' => function (Builder $query) {
    $query->where('content', 'like', 'code%');
}])->get();

echo $posts[0]->votes_count;
echo $posts[0]->comments_count;

will throw Undefined array key 1
This PR adds a failing test to cover the expected behavior.
A possible fix would be to check if the given array is a list array_values($relations) === $relations
    public function withCount($relations)
    {
        $relations = is_array($relations) ? $relations : func_get_args();

        if (count($relations) === 2 && array_values($relations) === $relations && $relations[1] instanceof Closure) {
            $relations = [$relations[0] => $relations[1]];
        }

        return $this->withAggregate($relations, '*', 'count');
    }

@taylorotwell merged master test passes now.
you can reopen and merge this PR for test hardening?

@nuernbergerA best that you send in a new pr


I would like to contribute tutorial for using Eclipse Cyclone DDS RMW

I would like to contribute how to use CycloneDDS as an alternative DDS vendor.
Signed-off-by: YuSheng<EMAIL_ADDRESS>

.. redirect-from::
Working-with-Eclipse-CycloneDDS

Working with Eclipse CycloneDDS [community-contributed]
Eclipse Cyclone DDS is a performant and robust open-source DDS implementation.
Cyclone DDS is developed in the open as an Eclipse IoT project. (see also: https://projects.eclipse.org/projects/iot.cyclonedds)
Before using Cyclone DDS and it's rmw package, you need a CycloneDDS installed in your system.
CycloneDDS uses the cmake build system, therefore you must ensure cmake is installed before trying to build it.
Compile and install Eclipse CycloneDDS from source
First, we need to clone the source code from github.
.. code-block:: bash
git clone https://github.com/eclipse-cyclonedds/cyclonedds.git -b
Then, use cmake to build the project
.. code-block:: bash
cmake -Bbuild -Hsrc -DCMAKE_BUILD_TYPE=Release
cmake --build build
cmake --build build --target install
After installation, CycloneDDS will be installed under your system.
Import rmw_cyclonedds into your ros2 working space
To use CycloneDDS, you will need to install rmw_cyclonedds on your ros2 working space.
rmw_cyclonedds is a ros2 package, use colcon to build it, and import it from the install/local_setup.bash script.
.. code-block:: bash
mkdir -p ~/ros2_ws/src/atolab/rmw_cyclonedds
cd ~/ros2_ws/src/atolab/rmw_cyclonedds
git clone https://github.com/atolab/rmw_cyclonedds.git
cd ~/ros2_ws
colcon build
source install/local_setup.bash
Switch to rmw_cyclonedds
Switching to rmw_cyclonedds is easy.
(see also: https://index.ros.org/doc/ros2/Tutorials/Working-with-multiple-RMW-implementations/)
You can switch to rmw_cyclonedds by specifying the environment:
.. code-block:: bash
export RMW_IMPLEMENTATION=rmw_cyclonedds
Run the talker and listener
Now you can test the ‘talker’ and ‘listener’.
.. code-block:: bash
ros2 run demo_nodes_cpp talker
.. code-block:: bash
ros2 run demo_nodes_cpp listener

@wjwwood @rotu I've updated the tutorial. Please tell me if there is something wrong.

@wjwwood @rotu this tutorial has been rewritten and retested by @evshary @cwyark. OK?


ISPN-14868 Remove and refactor Client Connection Pool

Ensure operation timeouts are cancelled on channel close

https://issues.redhat.com/browse/ISPN-14868

This doesn't cause any issues, just preemptive cancel to reduce references over time when a channel goes down.

Thanks, @wburns!


Allow Grids to be loaded from CSVs with an arbitrary number of non-essential data columns

:rocket:

[ ] Is your feature request essential for your project?

Describe the workflow you want to enable
Allow Grid objects to be loaded from CSVs with an arbitrary number of non-essential data columns, for example data on asset ownership, names, transmission line routing, etc.
Describe your proposed implementation
This will require refactoring how the case.mat files are generated, since currently the data tables are generated by dropping specified columns, rather than only writing certain columns.
The more complicated design issue is how to work with extra Grid information in the context of the current Scenario object framework. Currently, the information that's dropped from the tables that get interpreted by the simulation engine (those required for the power flow) get added to the case.mat file as additional tables which get re-loaded later by a Scenario in Analyze state which is reading the grid.mat file that gets produced by REISE.jl as a record of the exact power system parameters that were used in optimization (since REISE.jl makes some modifications to things like ramp rates, Pmin values, and linearization of cost curves). If we don't pass the extra information to the case.mat file to be read later, then we can only infer information by looking at the corresponding information in the base grid, which may have have changed since the Scenario was run, and won't cover any additions to the Grid that were made as part of the scenario setup. If we do pass extra information into the case.mat file for some grid models, then we end up with grid.mat objects with different sets of extra information that need to be interpreted differently.
Additional context
The corresponding PreREISE issue to write extra information to the HIFLD grid model CSVs is https://github.com/Breakthrough-Energy/PreREISE/issues/242.

This could also be relevant for Grids/Scenarios that are converted from PyPSA: we may want to be able to accept additional columns during translation, without breaking the ability to run PCMs.

Addressed in #701


TypeError: weight_only_quantize() got an unexpected keyword argument 'group_size'

System Info
Using 1 a100 GPU.  Using Nvidia-docker
slightly modified Dockerfile:
FROM nvidia/cuda:12.1.0-devel-ubuntu22.04

RUN apt update \
&& apt upgrade -y

RUN apt-get -y install python3.10 python3-pip openmpi-bin libopenmpi-dev

RUN apt install git -y

RUN pip3 install tensorrt_llm -U --extra-index-url https://pypi.nvidia.com

RUN apt install git-lfs \
&& apt install zsh -y \
&& apt install wget -y

RUN sh -c "$(wget https://raw.githubusercontent.com/ohmyzsh/ohmyzsh/master/tools/install.sh -O -)"

RUN pip install torch==2.1.0 torchvision==0.16.0 torchaudio==2.1.0 --index-url https://download.pytorch.org/whl/cu121

RUN pip install pynvml

WORKDIR /workspace

Who can help?
@trac
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[X] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction

Build and run the docker image.
Navigate to the examples/llama folder
Try building a model

For example:
python3 build.py \
    --model_dir meta-llama/Llama-2-7b-chat-hf \
    --dtype bfloat16 \
    --use_gpt_attention_plugin bfloat16 \
    --use_gemm_plugin bfloat16 \
    --remove_input_padding \
    --use_inflight_batching \
    --paged_kv_cache \
    --output_dir llama7b_tensorrt_bfloat16_int4awq \
    --use_weight_only \
    --weight_only_precision int4_awq \
    --max_batch_size 8 \
    --enable_context_fmha \
    --gpus_per_node 1 \
    --max_output_len 2048 \
    --parallel_build

It will fail
Traceback (most recent call last):
  File "/workspace/TensorRT-LLM/examples/llama/build.py", line 906, in <module>
    build(0, args)
  File "/workspace/TensorRT-LLM/examples/llama/build.py", line 850, in build
    engine = build_rank_engine(builder, builder_config, engine_name,
  File "/workspace/TensorRT-LLM/examples/llama/build.py", line 661, in build_rank_engine
    tensorrt_llm_llama = quantize_model(tensorrt_llm_llama, args.quant_mode,
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/models/quantized/quant.py", line 346, in quantize_model
    model = weight_only_quantize(model, quant_mode, **kwargs)
TypeError: weight_only_quantize() got an unexpected keyword argument 'group_size'

Expected behavior
I am not sure if the input is supposed to be an existing GPTQ model, or if it will implement it(I think it is the latter)
Either way, some other warning(in the first case), or a GPTQ model engine should be made.
actual behavior
It errors out.
additional notes
I tried other quants like awq as well.  Same issue.
If the issue is related to pytorch changes in docker image, I had to do that to solve another issue with Tensorrt-llm

Smooth quant seems broken as well.

Our latest main branch doesn't contain build.py under example/llama path.
Are u using a legacy version code base?
Please refer to new workflow doc for details with our latest code.

Please try main branch if possible since our coming release also will use new build workflow.

@nv-guomingz  correct me if I am wrong but the tensort-llm currently is only compatible with TensorRT-LLM v0.7.1?
@mallorbc
i got TensorRT-LLM v0.7.1 working with
tensorrtllm_backend v0.7.2
with this docker run command
docker run --rm -it -p <IP_ADDRESS>:8000:8000 --shm-size=2g --ulimit memlock=-1 --ulimit stack=67108864 --gpus all \
-v $(pwd)/all_models:/all_models \
-v $(pwd)/scripts:/opt/scripts \
-v ${HOME}/.cache/huggingface/:/root/.cache/huggingface/ \
nvcr.io/nvidia/tritonserver:24.01-trtllm-python-py3 bash

https://github.com/NVIDIA/TensorRT-LLM/issues/1064

@mallorbc Do you still have the problem? If not, we will close it soon.


list apphooks should sort and clarify its output

Currently if you run ./manage.py cms list apphooks you'll get slightly confusing output:
VideosApp
EventApp
VideosApp
EventApp
PressReleaseApp
NewsApp
PressReleaseApp
NewsApp

This could be consolidated to something like:
EventApp (draft/published)
NewsApp (draft/published)
PressReleaseApp (draft/published)
VideosApp (draft/published)

If the draft/published state is unnecessary, then it can be omitted.

I like the proposal!

Thanks @jsma for proposing this! Closed through #4585


update Indent rule

Referring to https://github.com/cereda/arara/issues/87
I do not know if that covers everything Chris has changed since I could not find a full changelog but its a start.
Nothing special as I have no experience with perl and only minor in YAML 😄
Let's see if the build passes.

Looks fine to me. 😉

Thanks for looking at this. Regarding line 26, should it be:
 +  flag: "@{isTrue(parameters.modifylinebreaks, '-m')}"

Also, can the -o switch be updated to reflect the changes in https://github.com/cereda/arara/issues/87

@cmhughes
I'll fix it right away. Regarding the -o changes: Would this be okay?
- identifier: outputfile
  flag: "@{[ '-o', output.tex ]}"

I don't remember how the underlying execution library handles -p=v key/value arguments, I will take a look later on and report back.


Add incoming webhooks to API routes

Main PR

https://github.com/bullet-train-co/bullet_train-incoming_webhooks/pull/2

Details
I added these namespaces explicitly so we can add newly super scaffolded incoming webhooks with ease.

@gazayas Incoming webhooks shouldn't be under /api/v1/webhooks/incoming. They should just be /webhooks/incoming.

Oh, I get it now! Yes, I can see why you thought this was needed, but it's actually not needed, thankfully! We don't need people to be able to see incoming webhooks via API.

No problem! I wasn't entirely sure so I added it just in case. Glad the new scaffolder made it over the finish line!