Support AsyncAPI v3

Hi,
Thanks for this project!
I wanted to give it a try but it doesn't seem to support AsyncAPI v3.
$ asyncapi-codegen -i ./asyncapi-v3.yaml -p asyncapi -o ./asyncapi.gen.go
 --- Anomalies detected in specification ---
version "3.0.0" is not supported

Any plan to support it?
Thanks!

Hi @gnuletik, thanks for reaching out !
Yes, I'll write the feature to support version 3, it should be available in the next weeks.
I'll let you know when it will be ready :smiley:

Sorry, I didn't have the time to work on it the past 2 weeks, but I'll work on it next week :)

@gnuletik, please let me know if there more to implement or some bugs :)

Thanks, it works like a charm!

Thanks for the king words !
It took a bit of code to implement it, so there is still some bugs, but it's on the right path 😄


Add auto layout helpers for centering a view vertically or horizontally.

@jnjosh Here is the jams we talked about.

This looks okay to me. Working on fixing some Travis Stuff then I'll merge.

Yo noobs! Lets get this merged... it isn't rocket science!
Love aggro scott

:scissors: Rocket Science :microscope:


Applied fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

Travis CI failed because there aren't any tests. Travis doesn't need to be enabled, so I've changed it only to run if there's a .travis.yml file present.


Preview PDF Externally with right click instead of hover?

Frequently you'll have a PDF inline with your notes so that you can preview it while reading. This means that the context menu will be enabled and you can no longer scroll (both for the PDF content, and the Note you're embedding a PDF in) and you need to click somewhere to disable the context menu. Currently it hinders the workflow a little bit.
I also feel like it goes against the general philosophy of this plugin, where you can copy image to clipboard by right clicking, and copy url by right clicking, but on PDFs, you hover instead of right clicking.
This plugin is great regardless, I use it daily!

The built in Obsidian viewer is about to change, so I'll probably wait a little for new functionality. I'm not sure how overriding the right click is possible technically, and if it clashes with other built in PDF functionalities (selecting text, etc). @mnaoumov what do you think?

@NomarCub I already made a PR to support new pdf viewer from Obsidian 1.3.0 . In previous pdf viewer it was not possible to handle right click. The new pdf viewer I didn't check if we can switch to the right click instead

I think this will fit in her:
The context menu being triggered on hovering, will interfere interacting with pdfs inside obsmd.

Right click would be neat, or an option to disable the plug-in only for pdfs, for the people who prefere working on pdfs inside obsmd.
Thanks a lot for the plug-in! :)

I added an option to disable the PDF context menu.
The Obsidian PDF viewer has this feature covered now anyway.

Thank you for the quick action! :)

The disable option and the build in Obsidian functionality addresses the concerns here.
Here's the native PDF menu now:

If @weldcloudnotes or someone else has no objection, I'll close this.

I spent half a year losing my mind over this hover beahviour without being able to identify its origin! Thank you for implementing an option to disable the PDF context menu (I would even suggest disabling it by default!).

Yeah, I should have done that earlier. I changed the default to disabled now. I'll make a release soon.


link: wrongly displaying links only connected to one node

the problem is that when a link connects between a node displayed and a node not displayed we get a link pointing from the visible node to the top of the screen. The expected behavior is that a link which is connected to a node not visible is not visible.

would you be able to share a topology dump ?

can you share a topology dump please ?

dump.json.txt

thanks

Should be fix: https://github.com/skydive-project/skydive-ui/commit/8854e12f1c3109c7a2747256a74049f710b7d4a6

fixed!


Update next-transpile-modules, next/link, and next/image for Next.js 13 support

Resolves PRD-906, PRD-907, PRD-908, PRD-911
Actually, we don't need next-transpile-modules anymore from Next.js v13.1, but we probably need to update it to support v13.0.
So far, I haven't seen any issues from updating next-transpile-modules on Next v12.

Currently having an error on the initial render in the builder for this commit:

Maybe instead of vendoring the SemVer utilities we can add the semver package as a dependency?

Added the semver as a dependency.

Ok. Will this only be used for the Next.js plugin? I wouldn't want to add semver as a dependency of the runtime itself

Maybe instead of vendoring the SemVer utilities we can add the semver package as a dependency?

Added the semver as a dependency.

Ok. Will this only be used for the Next.js plugin? I wouldn't want to add semver as a dependency of the runtime itself

Yes, only for the Next.js plugin and not for the runtime itself.

Should we also update Next.js, React, etc. in the peer dependencies of the package.json for that first commit?

I think we should update the peer dependencies on the last commit, as we need all the previous commits before we can support the Next.js v13.

Any reason why we don't have a changeset for each commit? It's ok not to have one for each commit, but we should make sure that the final changelog has a very clear explanation of what changed, why, and how it will impact a user if they upgrade as well as migration instructions if relevant

Yeah, I don't think we need a changeset for a refactor or anything that doesn't change the external behavior. Yes, I agree, let's do the final changelog together.


Sflix extension [Couldn't find any video links]

Steps to reproduce

Play any of the movies or TV shows.

Expected behavior
Short buffer proceeded by playback of video.
Actual behavior
Buffers for a while and then closes out the video. Gives an error/pop-up message that says "Couldn't find any video links."

I use the <IP_ADDRESS> cloudflare DNS, because otherwise, sflix, vidstream, and some other extensions to name a few, don't work.
Viewing the sflix site under Webview says that it's been blocked under an IT act, I live in India.

Viewing the sflix.to site under chrome, it comes up normally.
I had experienced this issue before, but then the sflix extension recieved an update and the problem was resolved.
Crash logs
No response
Aniyomi version
App version: <IP_ADDRESS> (standard, dc8d1af, 72, 2022-08-25T23:30Z)
Android version
Android version: 11 (SDK 30) Android build ID: ROQ31.166-63
Device
Device brand: motorola Device manufacturer: motorola Device name: cyprus64 Device model: moto e40 Device product name: cyprus64
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

[Forgot to add] PS:The sflix.to site comes up normally if I search it up on chrome, with the DNS turned on of course.

If this is an issue with an extension, I should be opening an issue in the extensions repository.


LongCount is executed on the client

LongCount is not translated to a COUNT in the SQL statement. All rows are retrieved and the count is done  on the client.
I'm using beta4-12290 packages.

fixed in #1849


This is a common operation, but ONNX doesn't give us a convenient way of expressing this

          This is a common operation, but ONNX doesn't give us a convenient way of expressing this. We could potentially extend either the [Flatten op](https://onnx.ai/onnx/operators/onnx__Flatten.html#l-onnx-doc-flatten) or [Reshape op](https://onnx.ai/onnx/operators/onnx__Reshape.html) to support this. This is a one-sided flatten. Alternatively, if reshape has an attribute to align the shape with existing shape starting from the end (instead of beginning), we could specify the new target shape as `[-1, 0, 0, 0]`. Just some idle thoughts ...

Originally posted by @gramalingam in https://github.com/microsoft/onnxscript/pull/1514#discussion_r1600499413

Is this supposed to be changing ops in pixelshuffle? I think we should make it more clear to look actionable.


How to set the end date using onDatesChange prop for DateRangePicker?

Hi, i am new to using react-dates.
i am trying to set the end date when user clicks on a date on calendar.
currently my code is as below, which sets the start date and end date. end date is 4 weeks from todays date. (schedule now how can i determine the end date when user clicks on calendar.
function handleDateChange = (dates: { startDate: moment.Moment | null }){
     const { startDate: newStartDate } = dates;

     if (newStartDate) {
         const newEndDate = moment(newStartDate)
             .add(4, 'weeks')
            .subtract(1, 'day');
         setStartDate(newStartDate);
         setEndDate(newEndDate);
      }
  }
}
<DateRangePicker
      onDatesChange={handleDateChange}
    />

how can i set the end date or retrieve end date in handleDateChange method. could someone help me with this. thanks.

@sindhuanamal hello!
end date is passed inside onDatesChange method as endDate:
const { startDate: newStartDate, endDate } = dates;

thanks. how does the daterangepicker component detect start and end dates. just for knowing it in more detail.

@sindhuanamal you can check this method:
https://github.com/airbnb/react-dates/blob/5b29610dba5a00c0e61ac6c84ea58f0991690d4f/src/components/DayPickerRangeController.jsx#L586-L673

thanks a lot.


[FEATURE REQ] Add bonus guide on how to run Tor relay

What & why
Tor network is under DDoS attack for some time. More people running Tor relays would help. People having good enough Internet connection and powerful enough hardware could help Tor network (and also Bitcoin, as a lot of privacy stuff there currenty depends on Tor) by doing that.

What are the risks associated with it?
@kristapsk: wdyt of #1110 about setting up a Tor bridge? I can't review it as I don't know enough about Tor and networking.

I'm running a obfs4 Tor bridge: https://metrics.torproject.org/rs.html#details/C390F4996FE42E2623B47FB2FA96B2D9A771F358
Following official docs, they say no risk associated with running a Tor bridge because summarizing Tor bridges are nodes in the network that are not listed in the public Tor directory --> ref: https://community.torproject.org/relay/types-of-relays/

Something to keep in mind: Running a relay requires some serious preconditions that may cause trouble for a lot of home setups. Here's one of them: A non-exit relay should be able to handle at least 7000 concurrent connections. (src)

In my case, my Tor bridge: https://metrics.torproject.org/rs.html#details/C390F4996FE42E2623B47FB2FA96B2D9A771F358
Last log:
Jan 06 18:17:36 Tor[17986]: Heartbeat: Tor's uptime is 18 days 0:00 hours, with 380 circuits open. I've sent 266.22 GB and received 266.67 GB. I've received 52843 connections on IPv4 and 0 on IPv6. I've made 124867 connections with IPv4 and 0 with IPv6.
No problem was detected with my router or local internet connection in my house or any device.
I'm using Technicolor TC7230


Bump MIN_PEER_PROTO_VERSION to 70208

Drop old (pre-v0.12.2.x) peers

utACK. I see you added the 12.2.2 milestone :+1:


copy changes for smart wallet notices

📝 Changed routes:

/dashboard/wallet

(view full size)

Commit f62d46af03b55d47c5bd930d4643afe153292cb1 (https://thirdweb-kdtb7hqzy.thirdweb-preview.com).


High Kube API Server Usage 600+ req/sec

What happened:
I'm seeing extremely high CPU usage across multiple clusters that have this deployed. High request rate to the Kube API Server for WATCH pod and WATCH namespaces.
600-700 requests/sec, 8 weeks ago I was at 1.2k requests/second and 12 weeks ago over 2k requests/sec.
I've also witnessed that the fluentd CPU usage has been high during this same period, likely correlated.
What you expected to happen:
Not for it to make so many request/per second
How to reproduce it (as minimally and precisely as possible):
Unsure yet, still investigating. As far as I can tell my configuration is standard, nothing out of the ordinary beyond the basic setup.
Anything else we need to know?:
A restart of the fluentd-hec container fixes the problem. It appears something is in a tight failure loop and is constantly spawning requests to the kube-apiserver
Environment:

Kubernetes version (use kubectl version): 1.5.10
Ruby version (use ruby --version):
OS (e.g: cat /etc/os-release): rancher-os
Splunk version:
Others:

Saw a lot of buffer errors regarding expired execution to the upstream HEC endpoint. I neglected to copy and paste the exact errors.

Why does every fluentd-hec need to watch pods/namespaces? I thought that the fluentd-hec is only monitoring local pod files? Is that for the metadata it adds on?

Yes, correct. to enrich event with metadata.

this seems like a issue fixed with latest SCK release. what version of SCK chart and hec image are you using?

SCK 1.4.0 -- that's good to know, I'll look at upgrading ASAP. If that's fixed then fantastic, maybe this issue will help someone else that runs into this.

Didn't think to look at the release notes only for issues related to this
From release notes.

library update which fixes a bug that causes high requests to k8s api server and high CPU usage.

Will upgrade to 1.4.1.
Thanks for pointing that out.

great! let me know how it goes!

yep, known issue with 1.4.0, see https://github.com/splunk/splunk-connect-for-kubernetes/issues/359

Dupe of #359. 1.4.1 seems to have fixed. Thanks.


python312Packages.twentemilieu: 2.1.0 -> 2.2.0

Diff: https://github.com/frenck/python-twentemilieu/compare/refs/tags/v2.1.0...v2.2.0
Changelog: https://github.com/frenck/python-twentemilieu/releases/tag/v2.2.0

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 362872

x86_64-linux

:white_check_mark: 5 packages built:

home-assistant-component-tests.twentemilieu
python311Packages.twentemilieu
python311Packages.twentemilieu.dist
python312Packages.twentemilieu
python312Packages.twentemilieu.dist


6.4.1 - InnertubeError: Counterfactual not found

Steps to reproduce
I use Vercel to deploy my app, but the build log shows error log and says its a bug
Failure Logs
InnertubeError: Counterfactual not found!
This is a bug, want to help us fix it? Follow the instructions at https://github.com/LuanRT/YouTube.js/blob/main/docs/updating-the-parser.md or report it at https://github.com/LuanRT/YouTube.js/issues!
Introspected and JIT generated this class in the meantime:
class Counterfactual extends YTNode {
  static type = 'Counterfactual';
  impression_endpoints: {
    0: {
      click_tracking_params: string,
      command_metadata: {
        web_command_metadata: {
          send_post: boolean,
          api_url: string
        }
      },
      feedback_endpoint: NavigationEndpoint
    }
  };
  enable_shared_feature_for_impression_handling: boolean;
  constructor(data: RawNode) {
    super();
    this.impression_endpoints = {
      0: {
        click_tracking_params: data.impressionEndpoints.0.clickTrackingParams,
        command_metadata: {
          web_command_metadata: {
            send_post: data.impressionEndpoints.0.commandMetadata.webCommandMetadata.sendPost,
            api_url: data.impressionEndpoints.0.commandMetadata.webCommandMetadata.apiUrl
          }
        },
        feedback_endpoint: new NavigationEndpoint(data.impressionEndpoints.0.feedbackEndpoint)
      }
    };
    this.enable_shared_feature_for_impression_handling = data.enableSharedFeatureForImpressionHandling;
  }
}

Expected behavior
I didn't know what to expect cause this error happen on build process, in local i didn't see this error
Current behavior
I can't deploy it to Vercel, working only on local
Version
Default
Anything else?
No response
Checklist

[X] I am running the latest version.
[X] I checked the documentation and found no answer.
[X] I have searched the existing issues and made sure this is not a duplicate.
[X] I have provided sufficient information.

I have this problem recently.


Add CL Queries to Stargate whitelist

Background
Currently, queries for concentrated liquidity are actively being developed.
Upon these queries being finished being added, we should add them to stargate whitelist to enable Contracts calling them.
Note that these queries should be double checked if they are deterministic before being added to stargate whitelist.
Acceptance Criteria

CL Queries have been added to stargate whitelist
They have been confirmed that they are deterministic

This has been finished


Fix the Windows build

Last time I checked Haywire's multi-threaded support doesn't work on Windows due to a libuv bug that I had trouble tracking down.
Haywire should build on Windows and at least support single threaded mode.

It builds fine on windows with vs2015 rc, just ran build.bat, plenty of warnings but no errors, didn't try the benchmarking though

Wow really? I haven't touched it in ages! Any chance you could benchmark single-threaded and multi-threaded mode to make sure it works? I suspect at least multi-threaded mode will be broken.

first off, http_response_cache.c needs to include time.h otherwise it crashes instantly when built for 64-bit.
wrk is problematic to build on windows so I ignored it and ran it from a virtual linux box instead, command line
../bin/wrk/wrk --script ./pipelined_get.lua --latency -d 30s -t 8 -c 32 http://<IP_ADDRESS>:8000 -- 64

it didn't accept -R as a param for some reason so I removed it.
results are here for single threaded
https://gist.github.com/Paxxi/c6ff33f23c49e57b166c
Trying to run it with 4 threads it dies in haywire\lib\libuv\src\win\stream.c#uv_listen with stream->type set to 0.

Yeah I suspect the IPC consumer piping I'm doing for multi-threading is a problem on Windows. It did work at one time I believe but then all the sudden stopped working. I suspect a libuv bug but I'm not 100% sure. It could be the Haywire implementation.
Yeah -R is used in wrk2
https://github.com/giltene/wrk2
Wrk2 is good for more correct latency metrics because it accounts for coordinated omission. We should probably include both Wrk for max requests/second benchmarks and Wrk2 for latency benchmarking.
How about removing -R for now from the benchmark script so it doesn't confuse people?

I also wonder if we are using the wrong pipe name format for Windows to work properly. Can you change it in Haywire and see if it fixes anything?
https://github.com/aspnet/KestrelHttpServer/blob/lodejard/stuff/samples/TcpEcho/Program.cs#L133

Maybe split benchmark.sh into two, one for wrk and one for wrk2?
I'll see if I have some time during the weekend to test some more and rry that change

Hitting an issue compiling on VS 2015 Update 1
Is there a work around for this?
"e:\Git\haywire\haywire.sln" (default target) (1) ->
"e:\Git\haywire\haywire_hello_world.vcxproj.metaproj" (default target) (4) ->
"e:\Git\haywire\haywire_shared.vcxproj.metaproj" (default target) (5) ->
"e:\Git\haywire\haywire_shared.vcxproj" (default target) (6) ->
(Link target) ->
  http_request.obj : error LNK2019: unresolved external symbol strndup referenced in function hw_print_request_headers [e:\Git\haywire\haywire_shared.vcxproj]
  e:\Git\haywire\builds\windows\debug\haywire_shared\haywire.dll : fatal error LNK1120: 1 unresolved externals [e:\Git\haywire\haywire_shared.vcxproj]

I think this is fixed by #97

@nmdguerreiro  that does fix it :+1:


Craft to inventory doesn't go to inventory until second click

I added EMI to ATM9. While trying to craft to inventory, clicking once put the amount of material in the crafting bench but doesn't go into the inventory. I need to click a second time for it to work but then it craft twice the amount required.

I've noticed this in the past but only in heavily modded packs. It works fine in vanilla. If you find out what mod is causing this issue I can look into it.

Is there a way to log what happens?
I don't really want to inspect all 400 mods.

Nope, this is an unknown issue the only solution is bisecting and manually testing.

Dang :/

I've discovered Fast Workbench is the cause (or one of the causes) of this. There's nothing EMI can do, and the "Fast" mods are notoriously incompatible with other mods, so unfortunately I'll have to close this issue.

I've discovered Fast Workbench is the cause (or one of the causes) of this. There's nothing EMI can do, and the "Fast" mods are notoriously incompatible with other mods, so unfortunately I'll have to close this issue.

What even does Fast Workbench do? It's in every modpack I play but I don't get what it does exactly.

I've discovered Fast Workbench is the cause (or one of the causes) of this. There's nothing EMI can do, and the "Fast" mods are notoriously incompatible with other mods, so unfortunately I'll have to close this issue.

What even does Fast Workbench do? It's in every modpack I play but I don't get what it does exactly.

It aims to improve the performance of crafting, especially shift-crafting stacks of things, but evidently introduces it's own sets of issues in the process.

Various performance improvements to crafting, but they rely on some assumptions that break other mods.

Various performance improvements to crafting, but they rely on some assumptions that break other mods.

Is it worth removing or the performence improvement are just that good?

Worth testing both. Craft to inventory is way too important for my productivity so I'd always go for it


[dv] fix a typo in tl_device_access_types_testplan

Signed-off-by: Weicai Yang<EMAIL_ADDRESS>

Sorry that is probably my typo...

no worries. thanks for updating the wording.


performance

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: Harald Gutbrod:x: abaphackerHarald Gutbrod seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Peer connection to self should not be allowed

This is supposed to be prevented by the duplicate nonce check:
https://github.com/squeaknode/squeaknode/blob/f0ccc7288a5f27df5638bb2daa2d8f7eb15659a7/squeaknode/network/connection_manager.py#L112-L117
Not sure why it's not working.

Probably because the outgoing peer has not been added to the self.peers yet.

Not a big deal now that http is used. Closing.


Add timeline and dataframe methods

Close #42
Add timeline and dataframe methods to the wxee.TimeSeries class to help preview when images are available.
Add plotly as a project dependency.

Codecov Report

Merging #44 (02ad9df) into main (3b0dfcc) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   95.40%   95.55%   +0.14%
==========================================
  Files          12       12
  Lines         479      495      +16
  Branches       47       49       +2
==========================================
+ Hits          457      473      +16
  Misses         18       18
  Partials        4        4

Impacted Files
Coverage Δ

wxee/time_series.py
92.85% <100.00%> (+0.64%)
:arrow_up:

wxee/utils.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b0dfcc...02ad9df. Read the comment docs.


update package deps to the latest

update package deps to the latest

[x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

This possibility / probably addresses https://github.com/dart-lang/dart-pad/issues/2926?

It looks like this fixes https://github.com/dart-lang/dart-pad/issues/2926 for the stable channel, but I'm still seeing failures for  the Cloud Build step to deploy dart-services beta and main.

Hmm, OK, good to know.


Fix Issue #8 Endpoint Links Failing

Fixed by escaping auto-URI generator indicated by scheme:// to scheme://

@CHromek or @jasonrhodes could one of you review so I can merge this. I've added the labels for "Ready to Merge" so you can just update the label if it is good, thanks a bunch.

Hey @bdeanindy, I think this needs to go into SparkPost/sparkpost-api-documentation-DEV first? Also, what does it fix? Does it "de-linkify" those links?

@jasonrhodes this is a hotfix and we can pull it into our internal DEV version. Yes this just "de-linkifies" the links. (love the technical terminology). :+1:

This change looks ok to me. Just want to ensure that it gets back into the DEV version.

Of course, it should be part of our deployment process from our DEV copy to pull from the master branch of this repository prior to pushing code (to resolve any conflicts and the like).
I'll merge this now into this repository.
Thanks @CHromek and @jasonrhodes :100:


Build failure: ffado

Steps To Reproduce
Steps to reproduce the behavior:

build ffado without substitution

Build log
$ nix build --no-substitute github:nixos/nixpkgs?rev=a18429cc57dff286a9d0f92715dfb8897c21ad5f#ffado
sourcing setup hook '/nix/store/yq6n8b0mnk0qxzbs3ajsjcp8ziwqylrl-patchelf-0.15.0/nix-support/setup-hook'
sourcing setup hook '/nix/store/iks1pihvbilsh5sy8qvpd638k422w9i8-update-autotools-gnu-config-scripts-hook>
sourcing setup hook '/nix/store/h9lc1dpi14z7is86ffhl3ld569138595-audit-tmpdir.sh'
sourcing setup hook '/nix/store/m54bmrhj6fqz8nds5zcj97w9s9bckc9v-compress-man-pages.sh'
sourcing setup hook '/nix/store/wgrbkkaldkrlrni33ccvm3b6vbxzb656-make-symlinks-relative.sh'
sourcing setup hook '/nix/store/5yzw0vhkyszf2d179m0qfkgxmp5wjjx4-move-docs.sh'
sourcing setup hook '/nix/store/fyaryjvghbkpfnsyw97hb3lyb37s1pd6-move-lib64.sh'
sourcing setup hook '/nix/store/kd4xwxjpjxi71jkm6ka0np72if9rm3y0-move-sbin.sh'
sourcing setup hook '/nix/store/pag6l61paj1dc9sv15l7bm5c17xn5kyk-move-systemd-user-units.sh'
sourcing setup hook '/nix/store/jivxp510zxakaaic7qkrb7v1dd2rdbw9-multiple-outputs.sh'
sourcing setup hook '/nix/store/ilaf1w22bxi6jsi45alhmvvdgy4ly3zs-patch-shebangs.sh'
sourcing setup hook '/nix/store/cickvswrvann041nqxb0rxilc46svw1n-prune-libtool-files.sh'
sourcing setup hook '/nix/store/xyff06pkhki3qy1ls77w10s0v79c9il0-reproducible-builds.sh'
sourcing setup hook '/nix/store/ngg1cv31c8c7bcm2n8ww4g06nq7s4zhm-set-source-date-epoch-to-latest.sh'
sourcing setup hook '/nix/store/gps9qrh99j7g02840wv5x78ykmz30byp-strip.sh'

trying http://subversion.ffado.org/changeset?format=diff&new=2846&old=2845
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
^M  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0^M  0     0    0     0   >
curl: (22) The requested URL returned error: 404
error: cannot download musl.patch from any mirror

Additional context
The Ffado dev wiki seems to have gone offline: http://subversion.ffado.org
which is why the musl patch can't be pulled from it.
Notify maintainers

@cillianderoiste
@michojel
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output here

Add a :+1: reaction to issues you find important.

Already fixed in staging: https://github.com/NixOS/nixpkgs/commit/0a5599cda2cd2c442c27bc37d36826956245f2ab


Remove the stdlib and inspector dependency from the runtime

We’ve implemented our own self-hosted standard library within Framework, but we’re still using the same Runtime that notebooks use which depends on the notebook standard library. Related to #573, we should restructure the Runtime so that it doesn’t depend on @observablehq/stdlib and @observablehq/inspector, giving users (and us) more flexibility and saving a few bytes.

I tree-shaked the runtime dependency in #843, so this followup task just applies to releasing a new version of the Observable Runtime that does the tree-shaking internally (rather than bundling stdlib). See this workaround:
https://github.com/observablehq/framework/blob/main/src/client/runtime.js


Integrate property editor from dataforge-vis project

Generate schemes for plotly models and integrate JS property editor.

Probably will be implemented in visionforge wrapper instead.

Probably will be implemented in visionforge wrapper instead.

It will be done other way around via integration in VisionForge


Break-up Package For Easier Download & Updates

Hi @leifoolsen,
Thank you for such a wonderful set of mdl-extensions. I am gradually introducing some into my public-beta app
Now, I'm based in Kenya, where internet is more often than not very flaky. Downloading your zip is 20MB. It can take me anywhere between 30mins to 1hr when net misbehaves which is very often. And thats using Internet Download Manager.
Is it possible to have the pre-compiled assets as a separate zip file? Because that would be less than 1MB and would allow for easier downloading and upgrading.
Regards.

Hello @The-Don-Himself
Thank you for reporting this.
Size of the library has not been in my thoughts, probably because we are used (spoiled) with high speed internet lines.
I would certainly consider modularize the library, but this is unfortunately something ahead. I probably will not put any work in this before MDL verson 2 arrives.
What I possibly can do relatively quickly is to split demo application into a separate repo. Since the demo application contains many larger image files, I think such a split is something that can increase download speed. But at the same time, a split will make it harder to test components visually, so I have to find a solution that does not impede visual testing  Unfortunately, I can not give any timing for such a split since my time is filled up with the development of new (WAI-ARIA friendly) components. Among other things, I will soon have completed a menu-button component which is in accordance to WAI-ARIA Authoring Practices [section 2.20] (https://www.w3.org/TR/wai-aria-practices/#menubutton)
BTW: The site you're building looks nice 👍

Hi @leifoolsen,
Thank you for considering this issue and more so for your compliments on my site, again worth noting that is only possible from gracious libraries like mdl and mdl-ext.
Splitting the demo into a separate repo makes sense but I wouldn't want a solution that increases the workload on your part especially since I'm sure low-speed-internet devs (if there such a term!) are in the vast minority and also because it seems you're the sole dev behind mdl-ext.
So I think this can wait until you have the time, or when the library grows with more contributors who can take on such tasks.  Will close this for now but please keep it in mind for later. Thanks.

Hi @leifoolsen ,
Some what related issue. Building a web app that currently only requires mdl-ext accordion component. Is there any way to achieve/build that without the entire pack?
On a side note, I the relatively new menu buttons are awesome!
Cheers.

@The-Don-Himself : Will fix this i release 0.13.11. The release will be significantly smaller. Will also document how to require a specific component (using webpack)

@leifoolsen That is awesome thanks, can't wait :1st_place_medal:

MDLEXT will now come with a separate ES2015 directory that enables loading of individual components. I have also included an example that shows the use of this.
About the accordion: We have used this component in two different projects @ work and it begins to reveal some weaknesses in the way it is programmed. A refactoring of code will be required. There will probably be changes in CSS class names and markup structure. JavaScript code will be broken down into smaller modules, partly to prepare for MDL-2


errors

Traceback (most recent call last):
File "/home/yuqing/Coinsweeper/main.py", line 4, in
from bot.utils.launcher import process
File "/home/yuqing/Coinsweeper/bot/utils/init.py", line 2, in
from . import launcher
File "/home/yuqing/Coinsweeper/bot/utils/launcher.py", line 10, in
from bot.config import settings
File "/home/yuqing/Coinsweeper/bot/config/init.py", line 1, in
from .config import settings
File "/home/yuqing/Coinsweeper/bot/config/config.py", line 4, in
class Settings(BaseSettings):
File "/home/yuqing/Coinsweeper/bot/config/config.py", line 8, in Settings
Which is API_HASH is undefined, also asks to edit .env file which i can't find

Copy it from .env-example then edit it


Implement instrumentation/telemetry in the zero/trace_decoder/evm_arithmetization

Marko, is this a dupe of https://github.com/0xPolygonZero/zk_evm/issues/15?

@0xaatif I would say expansion, #15 only mentions trace decoder. I will close 15 as duplicate.

@0xaatif Also, I am not sure why #15 has a hard requirement for the Prometheus. Why wouldn't we use OpenTelemetry to also have an option collect logs/traces beside metrics?


Supporting 2FA as of 29th Feb

I am trying to host the boarding website locally as a test run, but want have all the users using 2FA so that I'm ready for the changes that are coming later in February (Apple imposed).
I have followed the 2FA guide here, but I don't understand how this relates to boarding in particular.

As per the Apple Guidelines, as long as the user configured within Boarding is not the Account Holder, 2FA is NOT required

Only developers with the Account Holder role (formerly the “Team Agent”) in the Apple Developer Program, Apple Developer Enterprise Program, or iOS Developer University Program need to enable two-factor authentication. Developers who are registered for a free account or who have other team roles are not required to enable two-factor authentication.

Closing due to reasons above


Add 'any' type as shorthand to interface{} for better code readability

It would be better if we allow programmers to use "any" instead of "interface{}" because it's quicker to type and has better common sense. For your information, this changes inspired from TypeScript which has "any" type, similar with golang's "interface{}".

@googlebot I signed it!

The built-in package only exists for documentation and this is not the way to start a discussion about such a thing. The proposal process should be followed, and I suspect this has come up before. I'm going to close this.


Make SDKROOT immediately assigned

This avoids re-expanding and rerunning the xcrun command for each time
the SDKROOT variable is used (i.e. once per file built).

ship


Disable react/require-default-props

With es6 we can define default values in the destructured props argument. I vote we disable the require-default-props and use es6 default values instead. The issue with that, though, is that I don't think it's lintable.
Here's an example case that is an error, but shouldn't be IMO:
const Component = ({ name = '' }) => {
  return (Hello {name});
};

Component.propTypes = {
  name: PropTypes.string
};

Error: propType "name" is not required, but has no corresponding defaultProp declaration

👍

Fixed in release v3.2.1


KHR_materials_transmission sample model artifacts

The KHR_materials_transmission support looks amazing, however I think there's a minor artifact visible in the TransmissionTest sample model, most noticeable in the TranmssionTexture w/ Opacity column of spheres.  Looking at the image captured in the release notes for v1.8.1, I see fresnel highlights on the outer edge of the sphere.  This should not be visible.

Yes.  Specifically, the test model is using alpha blending here, not transmission, so the material itself shouldn't be present at that location.

(Separately, we should probably make a test model that compares a completely transmissive material to a zero-alpha-coverage material, to highlight this difference)

Our loader should be applying the "fade" blend mode to regular glTF materials (both diffuse and specular get the opacity defined in the material) but our "blend" mode to any material with transmission (only diffuse is affected by the opacity). What is KHR_materials_transmission supposed to do? Still use the "fade" model?
@emackey In the glb file I'm using the BlueTransWithMask material uses KHR_materials_transmission.

/ping @MiiBond can you comment?

It looks like those spheres define a baseColorTexture and include an alpha value of 0.0 for those "holes".  The spec defines the transmission tint through this baseColor factor, which would cancel out the f_transmission contribution to your final color.

only diffuse is affected by the opacity

In KHR_materials_transmission, both diffuse and specular are still affected by alpha opacity. The transmission is controlled only by the "transmissionFactor/Texture". The material should still be completely invisible where alpha is zero.

Thanks for the clarification.

@prideout I still see the specular reflections in the cutout parts of the material.

Git mixup, it's fixed now, thanks @prideout!


Double-click

Hi! Thanks for reporting this feature/bug/question!
Please keep / fill in the relevant info from this template so that we can help you as best as possible.
Type (choose one):

Bug

NPE version: 5.2.49+290c8f97cd
OS version: Windows 7 Professional x64
Installed from: Chocolatey.org
In case of a BUG:

What is the current result? Double-clicking a package in Windows Explorer opens NPE but the package is not open inside NPE
What is the expected result? NPE opens and the selected package opens automatically inside it.
Please post full exception details in case of an Exception (message, stacktrace, inner exceptions). No exceptions shown.
Are there any workarounds? yes -> Opening NPE and manually selecting File -> Open...
Is there a version in which it did work? Not AFAIK
Is there a package on Nuget.org which shows the bug? No, behavior present in all cases.

Do you double click on a nupkg? Or a nuspec?

In a .nupkg file.

Are there spaces in the path to the package? Does it work if there aren't?
Might be a quoting issue https://github.com/NuGetPackageExplorer/NuGetPackageExplorer/blob/master/PackageExplorer/ChocolateyInstall.ps1#L14

Copying the package to a folder without spaces solves the problem.

Thanks for the confirmation!

This should be fixed in v5.4.1, thanks @onovotny !


Konnected component follow up

Description:
Follow up to #13670 based on post-merge feedback from @MartinHjelmare.

Makes device_discovered synchronous since this callback is doing synchronous I/O with the Konnected device over the LAN.

Checklist:

[ ] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Let's continue here. I'm getting the angry github unicorn a lot when trying to load #13670. That thread is too long.

How do I get the entity_id to store in a dict? It's unclear to me where this is set or how to retrieve it. self.entity_id returns None from inside the entity class. I must be missing something here.

You might not need the entity_id. You don't need it specifically to use the dispatcher. I just mentioned it as an example identifier of an entity.
There's two parts to the dispatcher, a connect function and a send function. First you connect a target function to a target key. Then you send an update to the target key which will call all connected target functions of the target key.
The target key can be anything that is specific enough for what you want to target. If you want to target a specific entity, the entity_id is probably good. You could also use the builtin id function on the entity instance to get a unique id of the entity instance, if you don't need the key to be persistent between restarts.
You want to connect the entity target method from the entity coroutine method async_added_to_hass. At this point, the entity_id will be available on the entity, ie it will be something other than None.

I understand conceptually.
Could you point me to a component that uses this pattern? This would help me tremendously.

I've used it in the mysensors component.
https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/mysensors.py#L523
https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/mysensors.py#L661-L671

I think this addresses everything. Thank you for the help, @MartinHjelmare. I really learned a lot here.
cc @syssi @OttoWinter

I think this is ready to go. Thanks again @MartinHjelmare.


ProviderServicePactFile

Hello,
I was wondering what happened to the ProviderServicePactFile class. I upgraded the pact.net in the stub library, to the latest version and I am getting error that this class doesn't exist.
Do you have any suggestions?
Thanks.
Behdad.

Hey @b3hdad
Now that we use the ruby host as the engine, it takes care of writing the Pact file for us, so we don't need that model anymore.
What are you using ProviderServicePactFile for?

Hi @neilcampbell,
If you go to the bottom of the page for Pact.Net, you will see I have referenced two tools. One is the Pact.Net Stubbing library and one is the Simulator. Both of which can be used to isolate services based on what is in the pact file. So to stub a service, during pact automation, one can add the stub library to the project, and provide the pact file and the library will act as that as that service.
So I was using this class to read the pact file to construct a response and send back to the dependent service.
There are quite a few downloads on the library. Not sure what we can do?

Ah yep, thought it may be for those.
You can still do it, you will just need to create you own copy of that type (ProviderServicePactFile) and read the pact file from disc, then deserialise into a ProviderServicePactFile or call whatever you want to call it.

If I do it this way wouldn't the schema go out of sync with the class over time?

Yeah it may do when the pact specification changes, however that is very infrequent.

Ok sure. Thanks @neilcampbell , I will find the class in git history and move it the tools.

https://github.com/SEEK-Jobs/pact-net/blob/1.3.2/PactNet/Mocks/MockHttpService/Models/ProviderServicePactFile.cs


Add _id for fields that expect an integer id

To be consistent, anywhere input is expected to be an integer based id
the field has been appended with _id.

Thanks!

Coverage remained the same at 71.772% when pulling db592e5c096badfef1fa63a5e9d5e073a5c7d674 on RobertDeRose:feature/make-id-use_id-in-name into 334badbdf1002bb5cad600752584a3236b342da6 on linode:master.

Coverage remained the same at 71.772% when pulling c857c417113d6f3d439c101fcd5afc63d78dbced on RobertDeRose:feature/make-id-use_id-in-name into<PHONE_NUMBER>e833c0ebc670cf6610c88b32dbc36f on linode:master.

Coverage remained the same at 71.772% when pulling 5d37ee63fa596f9090f2f34c2b7b4372c57ee2c1 on RobertDeRose:feature/make-id-use_id-in-name into<PHONE_NUMBER>e833c0ebc670cf6610c88b32dbc36f on linode:master.

Coverage remained the same at 71.772% when pulling c86984e56650b17f4ee955b76c330e80061dcebe on RobertDeRose:feature/make-id-use_id-in-name into 1714e33026a2e74087b3cb959080e660e40852b6 on linode:master.

Coverage remained the same at 71.743% when pulling bd5bb65fb9c2441dcd3d7d4da05f78421219bdb2 on RobertDeRose:feature/make-id-use_id-in-name into 8e3265a2c919fdfae35e42e6b36028b83b4253c4 on linode:master.

Coverage remained the same at 71.689% when pulling e21bdede75eb47649bedf3d6f31529f7523e1c08 on RobertDeRose:feature/make-id-use_id-in-name into f6bcfd8d591b8e0a960cb87346e8249c868a0349 on linode:master.

Coverage remained the same at 71.689% when pulling e21bdede75eb47649bedf3d6f31529f7523e1c08 on RobertDeRose:feature/make-id-use_id-in-name into f6bcfd8d591b8e0a960cb87346e8249c868a0349 on linode:master.


Update the readme

As the plug-in for Obsidian has been approved, edit the readme to reflect the same.

+1
I was able to install as an "official" Obsidian plugin.


VST3 ToneGenerator is broken with JUCE7

Hi,
I've tested with ToneGenerator only (Lin and Win).
Build prior JUCE7 tag:

After (set sine value+, then adjust/reduce freq):

I's due this change https://github.com/juce-framework/JUCE/commit/964a1aa870a05b48cee46faa3375946c8ff7f4cd (compiled with JUCE prior to this commit works fine)
the code is need to be updated for the new API

Fixed in a6273f2c9f25f6945cc21df1b3e4d2ff02d7894c


nexd: rename all *Nexodus receivers to nx.

Not sure about this one.   Doing it one big bang, gets the job done, but it might cause grief for folks rebasing branches.

@nerdalert probably has the largest WIP branch for exit node support. What do you think, @nerdalert ?


change default fedora URL

This allows fedora to work without needing to expose it via traefik and DNS.
With this change we can disable public access to fedora by adding the traefik-disable label to our docker-compose.yml

So, I guess we need to determine whether we want fedora exposed by default. If we do, then we just document how to shut it off, which would include making this change. I will leave this open so we can discuss it at the next tech call.

Good point. We just talked about this in the tech call. I am going to document this instead.


perf: check for experiments and auto operarions before subscribing to pubsub

Summary

Implement serverless architecture for persisters:

event-persister-evaluation-events-ops
event-persister-goal-events-ops
event-persister-evaluation-events-dwh
event-persister-goal-events-dwh

reference: https://github.com/bucketeer-io/bucketeer/issues/612

/cla sign

/cla sign


[CMake] Fix find_package for libXml2 on case sensitive filesystems.

This fixes the find_package to work on a case sensitive file system when LLVM_ENABLE_LIBXML2 is true.  The cmake finder is FindLibXml2.cmake. Otherwise, if set, the build will fail with:
CMake Error at CMakeLists.txt:929 (find_package):
By not providing "FindLibxml2.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "Libxml2", but
CMake did not find one.
Could not find a package configuration file provided by "Libxml2" with any
of the following names:
Libxml2Config.cmake
libxml2-config.cmake

@swift-ci Please smoke test

Aren’t strings as a universal data type just the greatest.
Thanks for the patch!
@swift-ci please smoke test


Specifying controller for ExpandablePanel causes runtime error

If ExpandablePanel gets initialized with an external controller, the build causes a runtime error as ExpandableButton cannot find a controller ancestor and tries to call a method on null.
This is caused by a small error in the _ExpandableNotifierState:initState() method, where the code checks for widget.controller null value and fails to initialize the state's controller field. The solution is to remove the if statement around the controller initialization:
void initState() {
    super.initState();
    //if (widget.controller == null) {
    controller = widget.controller ??
        ExpandableController(initialExpanded: widget.initialExpanded ?? false);
    //}
  }

Please let me know if you need a PR for this.

Hello,
Thank you for filing this. I will take a look today.

On Dec 21, 2019, at 6:00 PM, atessift<EMAIL_ADDRESS>wrote:

If ExpandablePanel gets initialized with an external controller, the build causes a runtime error as ExpandableButton cannot find a controller ancestor and tries to call a method on null.
This is caused by a small error in the _ExpandableNotifierState:initState() method, where the code checks for widget.controller null value and fails to initialize the state's controller field. The solution is to remove the if statement around the controller initialization:
void initState() {
super.initState();
//if (widget.controller == null) {
controller = widget.controller ??
ExpandableController(initialExpanded: widget.initialExpanded ?? false);
//}
}
Please let me know if you need a PR for this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Fix IE 6,7 & 8

Looks like a missing polyfill.

When I use this in IE, the hashes come out different? On Edge they are the same though.


Replace haml gem with hamlit implementation

Near 8.54x faster than haml v5.0.0.beta.2: https://github.com/k0kubun/hamlit

Build is failing, You'll need to change it here too: https://github.com/tryshoppe/shoppe/blob/master/lib/shoppe.rb#L4

There is still an error and I don't know what the reason is.

bundle install log still installing haml and not hamlit, looks like the change to gemspec is not picked up. Could be git issue or something.
Moreover hamlit requires Ruby 2.2.0+, could you try updating Shoppe .ruby-version to reflect that.

Finally.


Docker build

Updated dependencies and got rid of dependencies that do not exist in public maven repos.
Also there is docker build stage, so. there is no need to run mvn clean package before building docker image

I've no idea about docker. maybe @kaby76 can review?

Sorry, can't look at this at the moment.  I'm on vaca for a couple of days.

@kaby76 can you take a look at this please? looks good to me


Client generator is missing --verbose option

Bug Report
You should be able to specify -v or -vv to enable debug logging. The plugin generator and every example service has this but the client generator does not.
Repro or Code Sample
ni-measurement-plugin-client-generator --all -v

Expected Behavior
It enables info (-v) /debug (-vv?) logging.
Current Behavior
Usage: ni-measurement-plugin-client-generator [OPTIONS]
Try 'ni-measurement-plugin-client-generator --help' for help.

Error: No such option: -v

Possible Solution

Context
Testing #966
Your Environment

OS & Device: Windows
ni-measurement-plugin-sdk-service version: 2.1.0 main
MeasurementLink version: 25.0.0d71
Python version: 3.9.13

AB#2902967

@bkeryan I don't know if this is a simple fix or not, but can we change it to tech debt so it's not on our 28d bug list?

It's a simple fix and I'd rather fix it.


Extended file attributes support

Are there any plans to implement extended file attributes? Most modern Linux filesystems have them (ext4, ...), and some OSes (e.g. Haiku, which I work on) deeply integrate them into the desktop layer to the point where they have a hard dependency on the boot and home filesystems having extended attributes.

And, also, what about extended attributes indexes, like in BFS in BeOS/Haiku? This option confers database capabilities to the file system which could be very useful to have a very well integrated and powerful desktop (like, again, BeOS/Haiku).


Implement some beam operators (w3)

Operators

[x] DROP_INDEX
[x] PROPAGATE
[x] GLUE
[x] GREATER_SCALAR
[x] LESS_SCALAR
[x] FILTER
[x] TIMESTAMPS
[x] RESAMPLE
[x] SUBTRACTION
[x] FILTER_EMPTY_INDEX
[x] CAST
[x] LEAK
[x] UNIQUE_TIMESTAMPS

Thanks!


fix pushing hidden and deleted properties to the queue (3.1)

[x] @joeferner
[x] @diegogrz
[x] @mwizeman @sfeng88
[x] @joeybrk372 @rygim @jharwig @EvanOxfeld

Testing Instructions: None, covered by another PR
Points of Regression: None
CHANGELOG
Added: Pushing onto the gpw queue when a published property has been changed
Fixed: Added an additional validation of the status when the graph property runner checks for whether or not any GPWs are interested

Can you rebase/squash and merge


from the example given for Text function, are you certain "mm" stands for month and minutes?

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2548fd17-5e1c-99d3-b7f7-a0b48c56c2bf
Version Independent ID: f645f526-3e2c-ae5f-965d-a64c6a9094df
Content: Show text, dates, and times in canvas apps - Power Apps
Content Source: powerapps-docs/maker/canvas-apps/show-text-dates-times.md
Service: powerapps
Sub-service: canvas-maker
GitHub Login: @mduelae
Microsoft Alias: tapanm

Thanks for your comment, @TheDrRichard. This issue has been assigned to the doc author for review.


Add support for Python 3.13

Resolves #108.

It appears that uvicorn and gunicorn don't support Python 3.13 yet, so we'll stay with 3.12 for the Docker image.


Set up 32-bit ARM pipeline on Packet

See also #72  for 64-bit ARM on Packet.

[x] Wait for 32-bit server availability

Do they even support 32-bit ARM?

we are able to build 32-bit ARM using https://ci.adoptopenjdk.net/computer/build-scaleaway-armv7-centos7/. It's just a very slow machine so a more powerful machine would be great

Opened https://github.com/AdoptOpenJDK/openjdk-build/issues/78 for the better build.


Add the -arch package option for AIR Android.

This adds the -arch option for ADT. Using -arch x86 is the only way to run AIR on certain devices, and on other x86 devices it makes the application much faster (my test app runs ~3x faster with this option on an Android tablet with an Intel CPU)
For more info see http://blogs.adobe.com/flashplayer/2014/04/adobe-air-now-supports-x86-android.html

Great! Thanks for the PR!
A snapshot build is now available


Graph benchmarks

Graph benchmarks results clearly show that we need to run them periodically so we propose following format of running of benchmarks.
Benchmarks schedule:
-For full in memory tests (100% of data in cache) - run them every night on bare metal server. All other tasks should be switched off.
-For disc backed cache (only 20 % of data in load cache, but in future even less , I think 5% is good number) run every weekend.
What those tests do ? They compare perfomance of latest released version and version which is built from develop. If results are lower more than on X% (see below) if we compare them with released version - tests should fail.
What results are gathered:

Median (not average) of operations per second - tests fail if result is below than 10%.
99 percentile of operations per second - tests fails if result is below 15%.
100 percentile of operations per second - tests fail if result is below 30% , because we measure system jitter there too..
Time is needed to execute all test - tests fails if result is below 15%.

What tests we are going to run:
-Load of graph data from at least 2 real data sets.
-Batch load of graph data
-Short path performance
-In future we will add YCSB tests too.

Yes! The benchmark testing will increase ODB's quality immensely. The other gain from this is you'll be able to quickly see if any supposed performance boosting changes actually work as expected or not. It will also raise everyone's confidence too. Good decision!
Scott

@smolinari creating of tests is not enough, measuring everything right is also important. :-)

@laa - Absolutely Andrey! The benchmarks must be meaningful, in order to be effective and helpful.
Scott

duplication


Documentation, delete_callback, optimizations and sh1ft-at-github change for off

Added sh1ft-at-github change for unbinding. Made binds namespaced, so that they do not interfere with other binds.
Moved delete_callback binding outside of the callback binding, so that it is used even when the callback is not defined.
Added variables for deleteBtn and cancelBtn (minor optimization).
Adapted the documentation to reflect the actual implementation when it comes to attributes (data_type was in documentation but data-type is used).
Added callback parameters section to documentation.

Thanks for the contribution.


feat: Optimize code and directory structure

Description

Optimize code and directory structure

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[] This change requires a documentation update

Just to make sure if this PR are name change operation? Otherwise it's not possible to review 118 files with effective quality. Last but most, make the API test run and increase new ones if needed.

The newly added and modified APIs have been completed in the previous round of PR. This PR only moves files and renames them to conform to the specifications in structure, without modifying logic. The API and WebUI tests have passed


helm waits for cronjob to start and times out

Like the title says. How do we deploy a cronjob without helm waiting for the job to start?
Output of helm version: 2.14.3
Output of kubectl version: 1.13.10
Cloud Provider/Platform (AKS, GKE, Minikube etc.):  AWS

Can you please share the command you ran for this to happen?

I have tried to reproduce this and found that it has to do with a PVC being referenced, which needs a storageclass that has
volumeBindingMode: WaitForFirstConsumer

@Morriz If the PVC is created, does it work as expected?

Closing as this question has been inactive for 9 months. Core maintainers have asked for a response, but no response was provided. Thank you for your question.


Access IMU data in controller.cpp

Hello whoenig,
I am using you code to do CF  control. Now I want to estimate CF's speed using Kalman FIlter. And I want to get the IMU (x acceleration) in the code. Could you help me figure  out how to do this? I think it should be related to void onImuData(uint32_t time_in_ms, logImu* data) in cf_server.cpp. However, I am not good in C++, could you give me hint?

I don't think that the IMU data will help you that much: You can only get the data at 100 Hz and, depending on what other messages the CF sends back, there can be a significant delay between the measurements and the time you receive the data. You will achieve much better results if you implement state estimation and control on-board. Both crazyswarm (http://crazyswarm.readthedocs.io/en/latest/) and official crazyflie firmwares come with Kalman filters.

@whoenig  Thanks. It turns out the update equation of my Kalman filter is wrong. Now I can estimate the speed. Even though it is not accurate enough, but is much better that using dx/dt


SalesForce TLS error

Hi Guys,
I would like to ask on how to fixed the error below.
Exception at ConstructorUNSUPPORTED_CLIENT: TLS 1.0 has been disabled in this organization. Please use TLS 1.1 or higher when connecting to Salesforce using https.
I can't connect to there api because of this error.

@jokerxvier , PHP SoapClient uses cURL under the hood, which uses OpenSSL for secure connections, and perhaps this issue has relation with supported/installed protocols for your machine, not being a specific Salesforce issue, but an installation/environment issue.
Consider verifying OpenSSL and cURL versions installed at your server and perhaps upgrade them.


Allow skipping by guessed mime type

useful for making sure we're not trying to check image / css / js links.
May be useful to whitelist instead?

jpeg, css, js, png, are all now skipped by default. We do however need to be able to configure this list


Use older fixed log4js version

Description
Use a fixed version for log4js.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
Not needed.
[] It includes documentation for these changes in /doc.

I'll merge this PR since master is now broken. @lodoyun please review it anyway


[Plugin] Cloud Carbon Footprint

Cloud Carbon Footprint Plugin
ThoughtWork's Cloud Carbon Emissions Measurement and Analysis Tool
Understand how your cloud usage impacts our environment and what you can do about it. This plugin brings the functionallity of the open source project Cloud Carbon Footprint into Backstage.

Estimates
Forecast

Recommendations
Carbon Intensity Map

Checkout the Cloud Carbon Footprint Demo to get a gasp of the possible capabilities of this plugin
From the project documentation:
Vision
The vision for this product is to be a trusted tool for its accuracy and comprehensiveness, and aids organizations to take tangible steps towards reducing their cloud emissions. In its future, we see built-in intelligence to make recommendations on actions that can be taken and what impact they will have.
As an open source project, we hope that its evolution and direction is community driven and meets the needs and use cases identified. We welcome all feedback and input on how this product can grow, in terms of directions, features, methodology changes, and code updates.
For more visibility into the work planned and happening, please visit the project board or create an issue.
For feedback, questions, or if you’d like to collaborate on shaping the product direction, please reach out to<EMAIL_ADDRESS>How it works
Cloud Carbon Footprint works by taking your cloud provider usage data, converting it into energy, and then taking into account the power usage effectiveness of the cloud provider’s data centers and the carbon intensity of the region where the data center pulls power from.
For a more detailed and in depth explanation into the approach and methodology, please reference the Methodology Page.

How does it integrate into Backstage:
We will provide 2 new plugins:
Cloud Carbon Footprint Plugin: Add a frontend plugin to display a Cloud Carbon Footprint Plugin. This page relies heavily on components from the @cloud-carbon-footprint/client & will try to display the same information as the standalone application.
Cloud Carbon Footprint Backend Plugin: Add a backend plugin for querying the emissions through the API. This plugin is just a small wrapper around the @cloud-carbon-footprint/api. It will create & use an instance of the @cloud-carbon-footprint/api express router by importing it from the project.
For using the plugin you need to define several variables in your app-config.yaml. The plugin requires separate configuration for each cloud provider. It also requires specific permissions and billing exports to be configured.
The CCF docs are the source of truth for CCF configuration. This readme aims to guide users how to inject relevant configuration into Backstage using its static configuration mechanism.
To see data, set follow the setup for one or more of the cloud providers.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@tudi2d hej, i've made some additional changes to the backend allowing minimal config for GCP to be plugged in via backstage config. i used that code to read actual data from my own GCP account!
I wonder if we should try to fill that out for all the cloud providers. CCF requires auth tokens for AWS and Azure so we would need to inject some of them as secrets. What do you think?
we almost have the client libraries published, after which i can plug it in here and try to resolve the merge conflicts.

We'd love to get this one in!

Had to rebase for the DCO.
It should now be possible to set all the CCF config through app-config. I've tested it on my GCP account and we have some folks trying it out on TW resources in AWS. Hopefully with the updated readme and comments in the config schema, anyone should be able to try it out. let me know if you find anything or see anything else we should address!

ok - something broke our Git history here. I tried to fix it & it should be ok-ish now, but rebasing is not fun anymore...
Anyway - there is a blocking thing breaking tsc right now:

CCF overrides the types for MUI theming - not sure how to avoid this, but yeah - we can't bring this in 😕
Also I was wondering if there is a better way to express the conditionals in convertConfig.ts. I bet we find a way to make this shorter & more intuitive.

Alright, I'll catch up with the CCF folks about the theme. Is your feeling that if we can sort out the theme and simplify the config conversion, that would put us in a good place? Or is the impact on lockfile still concerning?

@austin-garrard so I was wondering about 2 thinks atm:

Is there are a reason for the following versions to be fixed or can we add a ^...?

    "@material-ui/lab": "4.0.0-alpha.57",
    "moment": "2.29.1",
    "react-router-dom": "6.0.0-beta.0",

We briefly talked about the cache files. They are not visible in the review so I want to mention it. Is there anyway such that they are not injected in the packages/backend of the whole project but just into the backend plugin folder? 😕

changing the version specifier to compatible should be fine.
there might be some work planned around the cache file so i'll get back to you on that. generally it should be possible to make its placement configurable

Wanna check in on this one, we discussed adding it to a separate repo because of the large number of deps. Is that still where we're headed and should we then close this?

Hey @Rugvip, yes we are in the process of creating a separate repo for the plugin https://github.com/cloud-carbon-footprint/ccf-backstage-plugin.
still working through a few issues & docs but we are hoping to make a PR into your microsite soon! Please let us know if you have any feedback or suggestions.


Change Unique Key Constraint in inquisition.TrafficNodeStats to Include Field Type ID

Currently, the TrafficNodeStats table has a unique constraint on it only for the node_val field. This excludes the use case where an IP is used as both a src and dst.
The fix for this is to update the constraint to include the field_type_id field.

Completed with commit
https://github.com/magneticstain/Inquisition/commit/133f1e1ccacc202421918e2ea514705fb7ec1964


Removing consent string construction

While investigating https://github.com/InteractiveAdvertisingBureau/Consent-String-SDK-Java/pull/24 I've noticed that the current implementation takes a base64 consent string, decodes / parses it and constructs the VendorConsent object. While doing that it takes all the fields and reconstructs the consent string. I wonder what's the function of that part of code?
It seems to only add complexity and room for error (as per the aforementioned pull request). Furthermore it seems really inefficient to do all that work when base64 string is already available. In high-load adtech environment this is seems way too costly.
If it's meant as some kind of validation / sanity check, then maybe a better solution would be having a separate encode/decode functions, which could be used in tests and users that really want them.

I agree. It seems to me that concerns of representing Consent and encoding/decoding base64 string should be separated. Right now they are mixed together and that causes these issues.
I am also thinking for the high load environment, it would be better to have VendorConsent object backed by byte array only, with methods extracting data from byte array on the fly, without constructing any other fields to store extracted data. Assuming in majority of the cases field needs to be read once this would not cause increase in CPU cycles but would really cut down on garbage generation.
Not sure how much of this can be done without breaking existing API, but I'll give it a stab once I get few min.

Resolved in #30


Importing rpm fails on openSUSE Leap from a virtualenv

What happened? What is the problem?
The rpm module fails to initialize rpm in a virtualenvironment on openSUSE Leap with python 3.11. To reproduce:
$ podman run --pull=always --rm -it registry.opensuse.org/opensuse/leap:15.6
# zypper -n in python311 python311-pip python311-rpm
# cd home/
# python3.11 -m venv .env3
# source .env3/bin/activate
(.env3) # pip install rpm
Collecting rpm
  Downloading rpm-0.1.0-py3-none-any.whl.metadata (2.5 kB)
Downloading rpm-0.1.0-py3-none-any.whl (4.0 kB)
Installing collected packages: rpm
Successfully installed rpm-0.1.0

[notice] A new release of pip is available: 24.0 -> 24.1.1
[notice] To update, run: pip install --upgrade pip
(.env3) # python
Python 3.11.9 (main, Apr 15 2024, 10:36:26) [GCC] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import rpm
Traceback (most recent call last):
  File "/home/.env3/lib64/python3.11/site-packages/rpm/__init__.py", line 102, in <module>
    _shim_module_initializing_
NameError: name '_shim_module_initializing_' is not defined

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/.env3/lib64/python3.11/site-packages/rpm/__init__.py", line 105, in <module>
    initialize()
  File "/home/.env3/lib64/python3.11/site-packages/rpm/__init__.py", line 94, in initialize
    raise ImportError(
ImportError: Failed to import system RPM module. Make sure RPM Python bindings are installed on your system.
>>>

What did you expect to happen?
The import to succeed
Example URL(s)
No response
Steps to reproduce
No response
Workaround

[ ] There is an existing workaround that can be used until this issue is fixed.

Participation

[X] I am willing to submit a pull request for this issue. (Packit team is happy to help!)

Also hit by this issue but it seems to affect only the Leap 15.6 image and not a bare-metal installation.

Looks similar to the problem I found on Red Hat's ubi9 with the python311 stack there: https://github.com/packit/rpm-shim/issues/10


Feature Request - pls. support the latest version of urllib3

What is your feature request? Please describe.
Currently this library is locked to a two year-old version of urllib3.  urllib3 is now up to 2.2.2 -- it has been on 2.* for more than a year.
Describe the solution you'd like
Can you please update requirements.txt to support the latest version of urllib3?
Describe alternatives you've considered
Unfortunately we cannot downgrade urllib3 in our own codebase bc it leads to a cascade of downgrades that reintroduces a security vulnerability.
Additional context
n/a

+1. Also if the dependencies could be loosened in general that would be fantastic. E.g. dotenv is pinned to version ==20.0.0
(IIRC).
A simple unpinning of the dependencies in setup.py as is standard practice in all libraries would suffice


I don't understand Cache#get in your README.md  what syntax is this?

Hi there,
first of all, thanks for the great module!  Next, I don't understand the syntax you specify in your readme:
Cache#get(key[, options])
What is the "#"?
Also, I am trying to find examples for how to update my cache after a delete action on my data is done... I am thinking I should be using .touch operation, but can't find any examples..
Can you help clarify?

Error: CacheFactory.touch is not a function

What is the "#"?

# it denotes an instance member of a class. . would denote a static member.

Also, I am trying to find examples for how to update my cache after a delete action on my data is done

You want to remove something from the cache? Use Cache#remove(key)

Thanks for the response, can you please give an example of "it denotes an instance member of a class"?
I am currently caching http requests for a UI view that lists videos in a table.
When a video is added / updated or deleted somewhere in my app, I have to mark the cache as dirty.
For now, i am just destroying the cache for the http key and rebuilding it.
But I noticed you have a "touch" function... unfortunately, I don't know how to use it.
If you are on codementor, I have placed a live help request here: https://www.codementor.io/dashboard#/active-requests/3826997295

Calling Cache#touch does not mark an item as dirty, it refreshes the item's expiry datetime, making it as if the item has just been re-inserted. If you know an item in the cache is old, remove and refresh it.
Doing cache.touch('some-key') is the same as doing cache.put('some-key', cache.remove('some-key')).

can you please give an example of "it denotes an instance member of a class"?

class Foo {
  // Referred to in documentation as Foo.beep
  static beep () {}

  // Referred to in documentation as Foo#boop
  boop () {}
}

Foo.beep(); // Call Foo.beep which is a static member
const foo = new Foo(); // Call Foo#boop which is an instance member

Hi jmdobry,
I see that CacheFactory is a provider which can be injected into  controllers, but when I try to inject into   "Cache" into services,  it says "unknown provider"
how then, can I access "Cache#touch"?

There isn't any provider for Cache. You create an instance of Cache by calling createCache.
angular.module('myApp', ['angular-cache'])
  .run(function (CacheFactory) {
    var cache = CacheFactory.createCache('my-cache');

    cache.put('foo', 'bar');
    console.log(cache.get('foo')); // "bar"

    cache.touch('foo'); // etc.
  });

Hi jmdobry, How can I mark the cache as dirty?

What do you mean by "dirty"?

I needed to update my cache when a new user logs in - so I wanted to mark the cache so that it would be replaced with new content instead of retrieving the old content.
But what I ended up doing was just destroyAll
and that seamed to do the trick


Migrate tasks to use childManagerAccountID

~currently holding on https://github.com/Expensify/Web-Expensify/pull/37963~
Details
Just starting to use the new accountID property instead of email, in order to limit the emails we're passing around the app. This has been available for a few weeks but forgot to migrate this.
Fixed Issues
$ Part of https://github.com/Expensify/App/issues/19007 (wasn't noticed before)
Tests
Tests related to https://github.com/Expensify/App/pull/19990:
Tests for https://github.com/Expensify/App/issues/19089

Login with Expensifail account
Go to FAB > Assign task
Enter title, description and click on next button
Click on assignee  and select any user or enter an email or phone number to select a new user if don't have any user
Click on confirm button to create a new task
Verify that the assigned user displays as mention in the task preview
Edit the title of this task
Logout and login again
Verify that the assigned users still displays as mention in the task preview as well

Tests for https://github.com/Expensify/App/issues/19959

Go to App and Click on + icon
Select Assign task option
Create a new task
Go to settings > logout
Login again
Verify that the task name is created in above display

Tests for https://github.com/Expensify/App/issues/19967

Go to any chat
Click on + icon and select Assign task option
Enter title and description
Click on Next button
Click on confirm task button
click on title
Edit task title
Go back to previous report screen
Verify that Task title is updated

Make sure this still works (from this recent PR):

Go to any chat (1:1 & group at least)
Click + button in composer
Click Assign task
Input a title => Click next
Verify that by default the "share somewhere" is in that chat, and will not set an assignee by default and no error message
Click Confirm task.
Verify that the task is created with no assignee & it doesn't show an empty avatar

[ ] Verify that no errors appear in the JS console

Offline tests
Same as above
QA Steps
Same as above

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Updated test steps & added screenshots - I thinkkkkk we could get a C+ to help test this, once the web-e PR is on staging :D

feel free to get a C+ to help review if you'd like!
also cc @puneetlath in case you're free to review

Thanks @bondydaa , good find 🤦

asked in contributor plus to get someone to test and do the checklist for us.

Checking that regression you mentioned @0xmiroslav 👍

Ya so it kinda makes sense that the mentioned user doesn't exist the way we have it right now because I temporarily forgot login won't exist for these brand new users, since you don't "know" them.
So the possible changes are:

We try to show login, then as a backup show displayName
We go directly to showing displayName in the mention

cc @puneetlath @thienlnam any preferences here? Tagging you both since this is a combo of Task & Mention feature

Hm yeah that's interesting. We're going to migrate mentions to be accountID-based but it's just not quite done yet. So whatever we do for now will be temporary. I think we can just do whatever is easiest.

Awesome, then I will probably just switch to defaulting by displayName for now 👍

@0xmiroslav ready for re-review please 🙏

@0xmiroslav if neither exist then htmlForTaskPreview will just be <comment>${taskTitle}</comment>, no?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.38-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.38-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


NS8 related errors

After upgrading my project to NS8, I am receiving these errors 1 at build time and 1 at runtime:
***** Fatal JavaScript exception - application has been terminated. ***** NativeScript encountered a fatal error: Uncaught Error: Cannot find module 'application' at webpackMissingModule(file: src/webpack:/{workspace-name}/node_modules/nativescript-app-icon-changer/app-icon-changer.ios.js:3:26 at ../../node_modules/nativescript-app-icon-changer/app-icon-changer.ios.js(file: src/webpack:/{workspace-name}/node_modules/nativescript-app-icon-changer/app-icon-changer.ios.js:3:26 at __webpack_require__(file: src/webpack:/{workspace-name}/webpack/bootstrap:24:0 at fn(file: src/webpack:/{workspace-name}/webpack/runtime/hot module replacement:61:0 at ../../libs/xplat/nativescript/features/src/lib/profile/settings/user/user-settings/user-settings.component.ts(file:///app/bundle.js:37646:87) at __webpack_require__(file: src/webpack:/{workspace-name}/webpack/bootstrap:24:0 at fn(file: src/webpack:/{workspace-name}/webpack/runtime/hot module replacement:61:0 at ../../libs/xplat/nativescript/features/src/lib/profile/user-profile-routing.module.ts(file:///app/bundle.js:37727:110) at __webpack_require__(file: src/webpack:/{workspace-name}/webpack/bootstrap:24:0 at fn(file: src/webpack:/{workspace-name}/webpack/runtime/hot module replacement:61:0 at ../../libs/xplat/nativescript/features/src/lib/profile/user-profile.module.ts(file:///app/bundle.js:38088:86) at __webpack_require__(file: src/webpack:/{workspace-name}/webpack/bootstrap:24:0 at fn(file: src/webpack:/{workspace-name}/webpack/runtime/hot module replacement:61:0 at <…>
and also
CONSOLE ERROR: ERROR Error: Uncaught (in promise): Object: {"code":-1,"message":{}} CONSOLE ERROR: ERROR Error: Uncaught (in promise): TypeError: Cannot read property 'nativeApp' of undefined TypeError: Cannot read property 'nativeApp' of undefined at AppIconChanger._supportsAlternateIcons (file: src/webpack:/{workspace-name}/node_modules/nativescript-app-icon-changer/app-icon-changer.ios.js:9:0 at file: src/webpack:/{workspace-name}/node_modules/nativescript-app-icon-changer/app-icon-changer.ios.js:18:0 at new ZoneAwarePromise (file: src/webpack:/{workspace-name}/node_modules/zone.js/fesm2015/zone.js:1387:0 at AppIconChanger.isSupported (file: src/webpack:/{workspace-name}/node_modules/nativescript-app-icon-changer/app-icon-changer.ios.js:17:0 at file: src/webpack:/{workspace-name}/node_modules/nativescript-app-icon-changer/app-icon-changer.ios.js:28:0 at new ZoneAwarePromise (file: src/webpack:/{workspace-name}/node_modules/zone.js/fesm2015/zone.js:1387:0 at AppIconChanger.changeIcon (file: src/webpack:/{workspace-name}/node_modules/nativescript-app-icon-changer/app-icon-changer.ios.js:26:0 at ProfileIconPickerComponent.changeAppIcon (file: src/webpack:/{workspace-name}/libs/xplat/nativescript/features/src/lib/profile/settings/components/profile-icon-picker/profile-icon-picker.component.ts:17:24 at ProfileIconPickerComponent_Template_Image_tap_3_listener (file: src/webpack:/{workspace-name}/libs/xplat/nativescript/features/src/lib/profile/settings/components/profile-icon-picker/profile-icon-picker.component.html:24:11 at executeListenerWithErrorHandling (file: src/webpack:/{workspace-name}/node_modules/@angular/core/__ivy_ngcc__/fesm2015/core.js:15285:0
To fix the first error which happens at build time, I updated lines 3 and 4 in app-icon-changer.ios.js in my node_modules and the project built just fine.
var application = require("@nativescript/core");
var frame_1 = require("@nativescript/core");
I was unable to fix the second error, which happens at runtime when I select an icon to change to.
I'm new (~5 months) to nativescript and am wondering if this would be the only fix that a PR might need or would there be more to bring this amazing plugin up to NS8 standards. I am using Nx workspaces with xplat on NS8 with angular. Please let me know what I can do to help get this plugin to build and run with NS8. Thank you Eddy!

For anyone who is interested, I found a solution which is the following.
It is not necessary to use this plugin any more, as Nativescript offers the possibility to access Objective-C types with Javascript. https://v7.docs.nativescript.org/core-concepts/ios-runtime/overview
So my code solution that worked for me is as followed:

I struggled a lot with the Info.plist so here is what worked for iPhones and iPads (at least in my case):

Do the same for <key>CFBundleIcons~ipad</key>
But most important was, to put the icons into the project folder:

I hope this helps. Sorry for the images, I was not able to post it in a code block in a nice way.

Nice! I plan to implement the app icons in our iOS app at some point but it is not high priority at the moment. Thanks for documenting some more on getting it running with NS8. I'm sure this will be useful to others in the future.


Factor out chunked reader from Client::request_events

Currently the chunk buffering is inlined into the request_events call.
This makes the function huge, hard to follow, and hard to test.
It would be better if there was a more cleanly separated Reader like struct that dealt with buffering and error handling of un-closed chunks specifically.
Not a big issue, but it makes that code a bit awkward.

Yeah, I was going to ask about this. Is the response stream of line delimited JSON? Can we use tokio_util::codec::FramedRead with tokio_util::codec::LinesCodec?

Yeah, I was going to ask about this. Is the response stream of line delimited JSON? Can we use tokio_util::codec::FramedRead with tokio_util::codec::LinesCodec?

Ooh, yeah those look promising. The body of the fn looks very much like an impl Decoder at the very least.
Yes, it's newline delimited JSON. You have to test it after each chunk to see if you have a complete object since the objects can exceed MTU.

Ooh, yeah those look promising. The body of the fn looks very much like an impl Decoder at the very least.
Yes, it's newline delimited JSON. You have to test it after each chunk to see if you have a complete object since the objects can exceed MTU.