Disable X-Pack Welcome screen

Hi,
I'm running the full ELK 5.4.0 stack with the kibana searchguard plugin searchguard-kibana-5.4.0-2 and the elasticsearch searchguard plugin com.floragunn:search-guard-5:5.4.0-12 on a Centos 7.3.1611 with java 1.8.0_121.
The cluster contains 1 master node on which also the kibana and logstash are located and 2 data/master nodes.
Searchguard restrictions and authentication is working perfectly fine. The issue I'm having is that the "X-Pack Welcome screen" is always being displayed even when disabled in kibana: Screenshot
For me it looks like this is caused by the fact that querying settings within the kibana index for the value of xPackMonitoring:showBanner and xPackMonitoring:allowReport is not allowed while unauthenticated:
Failed to load resource: the server responded with a status of 403 (Forbidden) /api/kibana/settings
Is this a known issue / is this working correct for someone else who's running parts of x-pack in parallel with searchguard?
Thanks in advance.

We will look into this ...

I'm havign the same issue here, same setup.

This likely affects all users who run X-Pack in parallel with Search Guard. Your analysis of the problem is correct, it's unauthenticated requests from the X-Pack plugin. We're working on a solution, but it might take some more time to find the best one.

We've prepared a snapshot which will hopefully fix the issue with the welcome screen. However, if you're using multi tenancy as well, theres one caveat:
Since the settings for the welcome screen are stored in the global Kibana index, you need to opt-out for each tenant separately. We might improve this by copying the settings automatically, but this will require changes to the ES multitenancy module as well.
If you want to give the snapshot a try, please find it here:
https://cdn.filestackcontent.com/CvVSU9jLRUe7w4mqMZ9w

First of all: Thank you verfy much for the quick support!

However, if you're using multi tenancy as well, theres one caveat:

That's not an issue for me since we're not using the multi tenancy feature yet. We are not even planning todo so in the future.
Unfortunately I'm not able to get the snapshot working. Here's what I did:

Create a backup of the existing searchguard-kibana plugin
Replace /usr/share/kibana/plugins/searchguard with kibana/searchguard-kibana from the zip file
set ownerships on /usr/share/kibana/plugins/searchguard to kibana:kibana
restart kibana

Once the restart did complete successfully - the welcome message on the login screen is gone!
But somehow logging in is not working anymore - no matter which user I take. The message An error occurred while checking your credentials, make sure your have a running Elasticsearch cluster secured by Search Guard running. is being displayed once login has been clicked.
Following URL is being reported with a 404 while logging in:
https://kibana.bahag.com/searchguard/api/v1/auth/login 404 (Not Found)
And there's also the 403 for the xpack api call:
https://kibana.bahag.com/api/xpack/v1/info 403 (Forbidden)
Rolling back to the original version brings everything back to the initial behaviour with a working login.
One more additional side note - when changing the following line in the index.js of the snapshot version
-            APP_ROOT = '';
+            APP_ROOT = '/searchguard';

I get back to the initial state WITH the welcome message and a WORKING login without rolling back the whole plugin.
Do I need to change something else beside replacing the kibana-searchguard-plugin?
Thx in advance,
mat1010

Hi!
yes, the point of this snapshot release is to change the URL structure and remove the "searchguard" part. The X-Pack plugins contain some hardcoded paths, especially "/login" and "/logout", which our plugin needs to resemble. Otherwise, the Welcome Screen ist displayed on the login screen (where we don't have any authorized user) instead of Kibana (where we are past the login screen and have an authenticated user).
So, if you change the APP_ROOT back to "searchguard", you will see the old behavior again. The snapshot works here locally and on our integration systems, so could you please first check if it works if you start with a fresh browser, i.e. no cookies and an empty local and session storage?
Thanks!

@mat1010 ping - does it work for you with an "empty" browse, i.e. no cookies or local/session storage?

Sorry for the missing reply. I tested it with a completly fresh browser and had some of my co-workers testing it - also running fresh / private sessions. Same issue on all systems and browsers. I hadn't replied yet since I wanted to doublecheck our apache reverseproxy settings so that they do not have any negative impact. I will report back once I was able to verify that.

Ok, thanks and no problem. We will have another look at this tomorrow, the message:
An error occurred while checking your credentials, make sure your have a running Elasticsearch cluster secured by Search Guard running.
Means that the call from the plugin to /_searchguard/authinfo to authenticate the user has failed or this endpoint is not reachable on ES. Please have a look at your proxy settings, and we will also double-check the plugin code tomorrow. Like I said, it works here, so I'm positive we can find the missing bit quickly. Thanks for your input and tests!

I have the problem also.  ES 5.4.2  search-guard is 5.4.2-14   the kibana is searchguard-kibana-5.4.2-3.zip
i only have change the APP_ROOT to '';
the x-pack welcome pages not see , but can't log in to kibana
with out "An error occurred while checking your credentials, make sure your have a running Elasticsearch cluster secured by Search Guard running.";
thanks
@jochenkressin

@zqc0512 Changing only the APP_ROOT in index.js is not enough, please diff the 5.4.0 branch against the 5.4.0-monitoring branch to see all changes.

@floragunncom  i use search-guard <IP_ADDRESS> can use u give 5.4.0?
can use this:https://cdn.filestackcontent.com/CvVSU9jLRUe7w4mqMZ9w  ?
thanks.

@floragunncom
can tell me where change about it ?
thanks.

http://floragunncom.github.io/search-guard-docs/kibana.html
"First download the Search Guard Kibana plugin matching your Kibana version from github"
No, the versions need to match, that's a limitation by Kibana.
For the changes, just make a diff the between 5.4.0 branch against the 5.4.0-monitoring. The code is completely public.

@jochenkressin @floragunncom
I have it working now.
Here are the proper steps for a successfull upgrade:

Remove the current kibana-searchguard plugin
Restart kibana to have all caches rebuild WITHOUT the searchguard plugin
Once the restart completed without the searchguard plugin, place the new version of the plugin into /usr/share/kibana/plugins/searchguard and do another restart. Now the plugin should work like expected.

Thanks a ton for the great work! Looking foward to see this in the stable release.

Oh, great that you got it working, and thanks very much for your input. Bloody caching again ;) We'll  document this once v4 of the plugin with the X-Pack support is out.

@jochenkressin @floragunncom
i use search-guard-kibana 5.4.2   when the V4 plugin can out put to use ?
thanks.

@zqc0512 Try this snapshot for 5.4.2: https://cdn.filestackcontent.com/8iA0PPUXQtOtdMyqkIun
In order to avoid caching problems, please follow @mat1010 advise above.


Windows agent is not able to gracefully shutdown job processes

We constantly see these logs when reading job-service-wrapper.wrapper.log for the garden-windows job:
Stopping garden-windows
DEBUG - ProcessKill 8416
INFO  - Found child process: 10024 Name: conhost.exe
INFO  - Found child process: 14036 Name: powershell.exe
INFO  - Stopping process 10024
INFO  - Send SIGINT 10024
WARN  - SIGINT to 10024 failed - Killing as fallback
INFO  - Found child process: 10220 Name: gdn.exe
INFO  - Stopping process 10220
INFO  - Send SIGINT 10220
WARN  - SIGINT to 10220 failed - Killing as fallback
INFO  - Stopping process 14036
INFO  - Send SIGINT 14036
WARN  - SIGINT to 14036 failed - Killing as fallback
INFO  - Stopping process 8416
INFO  - Send SIGINT 8416
WARN  - SIGINT to 8416 failed - Killing as fallback
INFO  - Finished garden-windows

This issue affects other jobs as well.
It seems like it has been addressed by winsw here: https://github.com/winsw/winsw/pull/487#issue-595573006
Environment:
Tanzu Ops Manager + BOSH Director version: v2.10.39-build.450
VMware Tanzu Application Service version: v2.11.19
VMware Tanzu Application Service for Windows version: v2.11.11
Windows stemcell version: windows2019 2019.48

We currently don't have community resources available to look into this. We happely review a PR addressing this issue. Alternatlify you could raise an issue with VMware since it looks like you are using their commercial distribution of the windows stemcell.


Combine samd11 and same51 into common/thumbv6 + BSC clean-up

Remove reference to samd21 module from BSCs
Combine samd11 and samd21 into common/thumbv6m using feature flags
Change import convention within BSCs

All BSCs re-export functionalities provided by HAL
BSCs do not refer to modules that should be considered an implementation detail of HAL {common,samxXX}
Update edition in older BSC crates to 2018, switched extern crate usages to use

This is also a breaking change to bsps as it shuffles around the exports and also as a result changes the documentation. If that is a change that is wanted, Im not sure why it would be included in this pr and not as its own separate change

@jacobrosenthal When it comes to API breakage, this PR only expands existing API and preserves existing one fulfilling semver's requirement for a minor change. Considering a documentation change (namely a re-export note) seems really strict for me. New re-exports populate the same (or more) symbols in the namespace in a cleaner way while being effectively undisruptive for an end user. I guess it boils down to where one decides to put the boundary of "API breakage". Every piece of code built against these crates will keep compiling with these changes in place.
I can put export shuffling in other PR if that's a problem. I decided not to because this PR will contain re-export changes either way but limited to removal of samxXX references.

@jacobrosenthal I decreased the scope of this PR.

To be clear I think what the public api looks like is a valuable conversation i just would expect some explanation what api is being refactored towards and why.
I cant personally speak to what people want to collapse the features down to, others have been refactoring along these lines for a while now and I presume theyll weigh in

I like these changes. I actually don't think it goes far enough. But I agree with @jacobrosenthal that I would like to see some conversation about the public API. Several changes have been moving in this general direction, but we haven't really decided on a vision for a refactored API.
I would suggest getting rid of the common module altogether. Now that all of the chip-specific directories are gone, I don't see any need for it. We can just elevate all the existing modules. I think that would be clearer and more intuitive.
I would also like to see a consistent naming scheme for embedded-hal, atsamd-hal and the BSPs. I think I've seen instances where all three of them have been imported as hal, which I think is really confusing. I would propose that all BSP examples import the BSP as bsp. And I would propose we somehow distinguish between embedded-hal and atsamd-hal in a consistent way. I would suggest two options: either ehal & hal, or hal & sam respectively. I don't have a strong preference for any particular name, but I don't like using the same name for different crates throughout the project.
By the way, thanks @vccggorski for getting rid of the last two chip specific directories. I did some similar refactoring a while back for the sercom module. At the time, I thought about doing this as well, but I didn't want to get sidetracked.

Note, @jacobrosenthal started some discussion on a similar topic in #357.

@bradleyharden

I like these changes. I actually don't think it goes far enough. But I agree with @jacobrosenthal that I would like to see some conversation about the public API. Several changes have been moving in this general direction, but we haven't really decided on a vision for a refactored API.
I would also like to see a consistent naming scheme for embedded-hal, atsamd-hal and the BSPs. I think I've seen instances where all three of them have been imported as hal, which I think is really confusing. I would propose that all BSP examples import the BSP as bsp. And I would propose we somehow distinguish between embedded-hal and atsamd-hal in a consistent way. I would suggest two options: either ehal & hal, or hal & sam respectively. I don't have a strong preference for any particular name, but I don't like using the same name for different crates throughout the project.
Note, @jacobrosenthal started some discussion on a similar topic in #357.

I think that this comment of yours should definitely be a part of a thread #357. In my next PR (after getting that one merged in) I planned to change BSPs even further. At this point, the most reasonable option is to join my and @jacobrosenthal effort from December and continue the discussion there.

By the way, thanks @vccggorski for getting rid of the last two chip specific directories. I did some similar refactoring a while back for the sercom module. At the time, I thought about doing this as well, but I didn't want to get sidetracked.

Also to @vcchtjader! :) He was doing the heavy lifting here

I would suggest getting rid of the common module altogether. Now that all of the chip-specific directories are gone, I don't see any need for it. We can just elevate all the existing modules. I think that would be clearer and more intuitive.

Definitely agree. I'll start working on that.

I would be fine with merging. The changes are technically breaking, but upgrading would be trivial. I think @jacobrosenthal might want to see a more complete vision for the end point though.
I think I can summarize the proposed end point discussed so far as:

Remove chip-specific modules and common module.
Make the thumb modules private, to indicate that they are an implementation detail.
Consider the remaining modules public and let them become the official API.
Rename imports across the HAL and the BSPs to increase consistency and clarity
Update the BSPs to re-export the HAL itself, rather than modules within the HAL. I think that's what @jacobrosenthal was getting at in #357.

Am I missing anything? Is this a sufficiently detailed vision? If so, I say let's implement it.


No way to get MethodInfo from RPC function

Let me just say, I'm very impressed by the extensibility of protobuf-ts. The reflection API is very useful and seems to meet almost any problems I might be facing. However, there are some problems which I feel could have a cleaner solution.
I'm trying to implement a simple batching system. I started implementing this using the following code:
  async batchSame<I extends object, O extends object>(
    method: MethodInfo<I, O>,
    requests: I[]
  ): Promise<O[]> {
    const req = BatchSameRequest.create({
      endpoint: `/${method.service.typeName}/${method.name}`,
      requests: requests.map((r) => method.I.toBinary(r)),
    });
    const { responses } = await this.batch.batchSame(req).response;
    return responses.map((raw) => method.O.fromBinary(raw));
  }

However, I quickly realized that there didn't really seem to be any way to access a MethodInfo without invoking a request... Looking at the generated code, I saw that the generated methods access specific indices, and there's no way to access them outside of that context...
    key(input: KeyRequest, options?: RpcOptions): UnaryCall<KeyRequest, KeyResponse> {
        const method = this.methods[2], opt = this._transport.mergeOptions(options), i = method.I.create(input);
        return stackIntercept<KeyRequest, KeyResponse>("unary", this._transport, method, opt, i);
    }

My proposal: Introduce a { [method: string]: MethodInfo<I,O> } and use that instead since it's more ergonomic to work with... Although performance might hurt a little... I'm not entirely sure.
Also, if anyone has ideas for how to temporarily circumvent this limitation, please let me know.

I didn't do that to preserve method order, same with message fields. Having a plain array in the same order as the proto source is the best thing to have if you have zero knowledge about the types.
But what you seem to want is access to MethodInfo by name, while preserving input and output types.
We'd have to generate literals like this:
export const MyService = {
    typeName : "x.MyService",
    options: {},
    methods: {
        unary: {
            name: "Unary",
            localName: "unary",
            I: StringValue,
            O: Int32Value,
            serverStreaming: false,
            clientStreaming: false,
            options: {},
            idempotency: undefined,
        }
    }
} as const;

It would let you state batchSame(MyService.methods.unary, ...).
There are some issues:

We only generate partial method info and use normalizeMethodInfo() to set default values, saving code size
MethodInfo also has a service property but we don't have access to the service in the literal
const typing lets code generation errors slip in more easily

I think it's a very interesting idea. Object.keys(MyService.methods) would retain the source order.

@Bluskript, reading this again I noticed that you can get away with a cast:
const mi = Haberdasher.methods.find(m => m.name === "MakeHat") as MethodInfo<Size, Hat>;
assert(mi !== undefined);

const requests: Size[] = [];
batchSame(mi, requests);

It's not type safe, but will get the job done if you need it.

Thanks for the tip, I came up with a slightly more scuffed and unsafe solution quite recently but it works too:
export async function batchGetUsers(conn: Connection, users: string[]) {
	const data = await conn.batchSame(
		"/protocol.profile.v1.ProfileService/GetProfile",
		users.map(userId => ({
			userId,
		})),
		GetProfileRequest,
		GetProfileResponse,
	);
	return data.map(r => r.profile);
}

while I changed my batchSame function to look like this:
	async batchSame<I extends object, O extends object>(
		path: string,
		requests: I[],
		input: IMessageType<I>,
		output: IMessageType<O>,
	): Promise<O[]> {
		const req = BatchSameRequest.create({
			endpoint: path,
			requests: requests.map(r => input.toBinary(r)),
		})
		const { responses } = await this.batch.batchSame(req).response
		return responses.map(raw => output.fromBinary(raw))
	}

It would still be nice if a generalized solution for all methods can be made, without requiring additional codegen though.


add colorbar to the ImageViewer

in guiUtils.py, add colorbar item, and add sync the update sequence.
probably also make a function in utils to create the imageViewer, the label for the mouse hover/click event, and also for the color bar at this point so the code isn't repeated to generate all those three times in gui.py

probably also with this task figure out a better way to display the object in the viewer

should also make it variable by the user in the gui, so that they could change the max abs value the colorbar has.


Compile-time constants as bitlengths?

How much work would this feature be?  I do understand that the plugin needs direct access to the actual bit length in order to compute things, but this would be nice to have.  For example, I could then write:
pub const CARDS_PER_HAND: usize = 4;
bitfield!{PlayerState,
    cards: [3; CARDS_PER_HAND],
    has_knocked: 1,
    drinks_ordered: 2,
}
fn my_function(…) {
    /* Code that can use CARDS_PER_HAND for other things. */
}

I'm aware that for an actual game, using a bitfield would be a bad idea; I just wanted to avoid "foo" and "bar", and demonstrate that keeping CARDS_PER_HAND a const is actually meaningful, because now one could change the game to use 5 cards.  Or something.
Not a must-have, but I haven't seen any other issue asking for that feature.  Maybe it's out of scope if it's too much work.  I hope not :)

As far as I know, constants are not available at the time of the macros expansion. It's not possible to just use the constant like the literal int are used now.
One approach would be to keep the constant in the generated code but its complicate everything and it become impossible to determine the type (u8, u16, etc.) of the field. I'm not event sure it really possible.
Another approach would be defining the constant inside the macros invocations:
bitfield!{PlayerState,
    pub const CARDS_PER_HAND: usize = 4;
    cards: [3; CARDS_PER_HAND],
    has_knocked: 1,
    drinks_ordered: 2,
}

It would work, but there are some limitations. I don't really like this solution.
A third approach would be to use macros for the constant and expand them before parsing the code, but I don't know if it's at all possible.
A last solution would be to add a macros like bitfield_const to define a const available for the other call to bitfield! (the values would be stored in a global variable in the plugin code).
I think one of the last two solutions would be the best.
I don't really have time to research/implement this myself at the moment, but would be happy to accept a pull request.

… use macros for the constant and expand them before parsing the code

Hehe, sounds like good ol' C code.

It's not possible to just use the constant like the literal int are used now.

I hope(d) that Rust (presumably using LLVM's CTFE) can indeed do that, and evaluate the actual value of the expression at compile-time, just like static_assert! seems to be able to do, using rustc_const_eval::eval_const_expr.  It's easy enough for me to read, but I would have a hard time writing this in a PR!  :-)
The linked package does the evaluation at a later compilation phase, so maybe this function can't be used.
Overall: yup, sounds like it's too much effort.  I'll just mark each place with a comment like CARDS_PER_HAND, and use find/replace to update it later, should the need arise.

I hope(d) that Rust (presumably using LLVM's CTFE) can indeed do that, and evaluate the actual value of the expression at compile-time, just like static_assert! seems to be able to do, using rustc_const_eval::eval_const_expr.

static_assert! can evaluate the constant because it runs in a later compilation phase (the part that evaluate the expression is a LateLintPass). When the macros are expanded, the constants are not yet available.

using rustc_const_eval::eval_const_expr.

Turns out, the internal compiler API s not only "unstable", but actually unstable.  Adapting to a new-ish version of rustc takes some effort, and that probably doesn't compile anymore, either.


Pop failure!

Issues Guideline
Following information can help us to resolve the issue faster.

Library version :1.3.6
Support-v4 version:
Logs

E/Fragmentation: Pop failure! Can't find FragmentTag:(包名省略).DeviceOperationFragment in the FragmentManager's Stack.

Screenshots

求教原因
In addition, we do not accept issues unrelated to Fragmentation.

怎么解决的？


use semver >= v5.5.0 so semver.coerce is there

using semver.coerce here https://github.com/kulshekhar/ts-jest/blob/v23.10.2/src/util/hacks.ts#L20
and we have it as 5.x in package.json, but .coerce was introduced in semver v5.5.0 https://github.com/npm/node-semver/commit/e7092b4040360f1b24c1119defe45ed3b38a77ef , so need to be more explicit about semver version
cc @huafu

Pull Request Test Coverage Report for Build 1937

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.458%

Totals

Change from base Build 1934:
0.0%

Covered Lines:
1029

Relevant Lines:
1076

💛  - Coveralls


Add files via upload

Hello! I'm a little worried about the correctness of you files' contents.
Let's look at one of your files:
-2,-3,-11,-1,0,0,0,1,0
-2,-3,-11,-1,0,0,0,1,0
2,1,1,-4,-2,0,1,1,0
2,1,1,-4,-2,0,1,1,0
2,1,1,-4,-2,0,1,1,0
2,1,1,-4,-2,0,1,1,0
0,0,1,6,3,0,-1,-1,0
0,0,1,6,3,0,-1,-1,0
-1,-2,-1,-4,-6,-2,0,-1,0
-3,-1,1,-3,-1,0,-1,0,0
-3,-1,1,-3,-1,0,-1,0,0
-3,-1,1,-3,-1,0,-1,0,0
2,5,28,10,-1,-1,0,-1,0
2,5,28,10,-1,-1,0,-1,0
2,5,28,10,-1,-1,0,-1,0
2,5,28,10,-1,-1,0,-1,0```
As you can observe, three to four consecutive EMG readings are often the same... This is extremely unlikely to happen...
A number of factors could cause this... For example the Myo sampling rate is 200 Hz but the BLE protocol only allows us to send data at max 50 Hz (we are sending four readings in the same time moment).
There could be an error in the way you are reading the received data?
As you are probably using a library to read the data, this could be a problem with the library (unlikely)...
What I think is most likely happening: you have an event that fires every time there is new EMG data... Due to BLE you get 4 readings, basically at the same time. The event fires four times and by the time you consume the previous data, there is already new data in your variable. In this case you should use a lock or similar mechanism...
Of course I could be wrong here...
I you want, we can look at your code together (messasge me on MS Teams).

The other thing I noticed is that the filenames are incorrect. For example, the flexion.txt file should be called 1.txt (as per readme).


Remove forEachFeature from ol.source.Vector

This function was not considering features with null geometry.
see #7862

@openlayers/core do you have any opinion on this?

When someone is interested in efficiently iterating over features with geometry, then forEachFeature is more efficient because it used the forEach function from rbush. So it might be better to just document that it's only for iterating over features with geometry, instead of removing it.

@ahocevar yes, good point. I'll update the documentation

trivial, merging.


Question about claim indexing with the AgeCredential schema

The AgeCredential schema stores the birthDay in the first index data slot (index value 3 in the Merkle tree):
	birthDay := big.NewInt(19950704)
	claim, _ := core.NewClaim(kycAgeSchema, core.WithIndexID(holderId), core.WithIndexDataInts(birthDay, nil), core.WithRevocationNonce(revNonce))

But doesn't that allow issuing multiple birthday claims instead of just one, since the two claims would have unique index hashes?

Would it be better to use a value data slot instead, so only one AgeCredential could be issued? This would still allow making corrections since a new version could still be published.

That's a good point. As the index part contains the schema hash and identity id, it's sufficient to ensure only 1 claim of that schema for a specific user ever exists in the claim tree.

Moved to https://github.com/iden3/tutorial-examples/issues/1


Details in the implementation of BigGAN

Hi, I find that there are some details in the implementation of BigGAN worth paying attention to.
First, I notice that the default moments used for batchnorm during inference are the accumulated values:
https://github.com/google/compare_gan/blob/3af50e3adcf9bde65deb1b65cd2e784b2e857b3a/example_configs/biggan_imagenet128.gin#L30
https://github.com/google/compare_gan/blob/e0b739fe71c22068878c317e5943c9f11c570638/compare_gan/architectures/arch_ops.py#L299-L304
Does it mean that the hyperparameter decay for batchnorm is not used at all?
https://github.com/google/compare_gan/blob/3af50e3adcf9bde65deb1b65cd2e784b2e857b3a/example_configs/biggan_imagenet128.gin#L28
Second, I also notice that the shortcuts are added only when  in_channels !=out_channels:
https://github.com/google/compare_gan/blob/3af50e3adcf9bde65deb1b65cd2e784b2e857b3a/compare_gan/architectures/resnet_biggan.py#L339
which is different from BigGAN-pytorch:
https://github.com/ajbrock/BigGAN-PyTorch/blob/98459431a5d618d644d54cd1e9fceb1e5045648d/layers.py#L388
https://github.com/ajbrock/BigGAN-PyTorch/blob/98459431a5d618d644d54cd1e9fceb1e5045648d/layers.py#L427
that uses shortcuts all the time and the shortcuts are learnable when in_channels !=out_channels or when the block is an upsampling or downsampling block.
Third, I find that BigGAN-pytorch omit the first relu activation in the first DBlock by setting preactivation=False, which is consistent with the implementation of WGAN-GP(I guess since the range you use for the imput of D is [0,1] instead of [-1, 1], the first relu does not harm). Also, in the shortcut connecting of the first DBlock in WGAN-GP and BigGAN-pytorch, pooling comes before convolution, while in this repo, convolution comes before pooling, as in the other DBlocks.
Do you think these discrepancy would have a significant influence on the performance of BigGAN?
Thanks

same question.

that uses shortcuts all the time and the shortcuts are learnable when in_channels !=out_channels or when the block is an upsampling or downsampling block.

Are you sure about that? The logic of doing the conv_sc stuff appears to be the same in both compare_gan and BigGAN-Pytorch: check channels, and if not, not.
You may have a point about the pooling/convolution order. Have you tried swapping them? I hope it doesn't make a difference. (mooch noted that compare_gan never converged to the quality of the original BigGAN or BigGAN-Pytorch, but that no one knew why; we found the same thing, the final quality, no matter how many runs we did, was never nearly as good as it should be. Convolution-then-pooling instead of pooling-then-convolution doesn't seem like it ought to matter that much... but who knows?) Do you have a diff for that or have you tried running it?


Cannot edit or download file with comma on Web

Describe the bug
I have a file New file,.txt with a comma in the file name. Using the web client I'm unable to edit or download.
Steps to reproduce

Use web client running ocis backend
Create text file with comma
Edit and download fails
Repeat with file rename without comma to see that it works again

Expected behavior
Edit and download to work

Actual behavior
Edit comma file:

TypeError: Cannot read properties of undefined (reading 'status')
    at Object.getFileContents (index.html-ZHQpx7wf.mjs:1:42232)
Failed to load resource: net::ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION

Download comma file:

Setup
Docker compose using mostly default settings from examples in ocis repo.
5.0.0-rc.3
Additional context
Edit and download of same comma file works on desktop client and android client
Update: https://github.com/owncloud/ocis/issues/8361#issuecomment-1926586274 - this issue is Chromium specific as found by Jan

@saw-jan are there API and/or webUI acceptance tests that cover common "interesting characters" in file and folder names?
If the API tests pass but web tests fail, then that will narrow done where the problem might be.

are there API and/or webUI acceptance tests that cover common "interesting characters" in file and folder names?

We do have API test for file upload/download having comma in its name
https://github.com/owncloud/ocis/blob/4d5490a60135df8beb8a64626192e6555858f74e/tests/acceptance/features/coreApiWebdavUpload/uploadFile.feature#L80-L99
And we also have webUI test but that doesn't check the file content in the editor.
https://github.com/owncloud/web/blob/59b5bbe6d77af2a530a224abd351f738d2237966/tests/acceptance/features/webUICreateFilesFolders/createFile.feature#L19-L22

Those acceptance tests are passing, so we can upload and download file names that have a comma in them - good.

Docker compose using mostly default settings from examples in ocis repo. 5.0.0-rc.3

@streaminganger Which docker-compose file did you use? I couldn't reproduce it with these versions:
ownCloud Web UI 8.0.0-rc.2
Infinite Scale 5.0.0-rc.3 Community

@JammingBen @kulmann FYI

I can't reproduce the download and viewing issue with the current ocis docker image.
But I can observe, that we have issues with the filename, while downloading a file with the name si,claro.txt will result in downloading the file as si not even with the extension if using chrome, but works with firefox
@micbar from my understanding we can't fix this in web, ocis needs to provide the Content-Disposition Header with the file name, which is currently missing https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition

It could be possible that you need to wrap the filename in double quotes in order to work with chrome: https://stackoverflow.com/questions/49003459/file-download-error-only-in-file-name-with-comma

The Content-Disposition header is present, it seems like there were quotes missing from the UTF-8 part of the header PR above should fix it.

Which resulted in chrome or chromium disposed the the header sometimes, kind of a weird behavior 🤷♀
With the bugfix @dragonchaser provided. The issue won't be present in any browser anymore.
Closing when merged.
Thanks for the report @streaminganger 💪


Require at least ruby 2.0

Drop 1.9.3 from texting matrix, and take advantage of "new" things like __dir__ and require_relative.

Closing this for now. This should wait for the 2.0 development effort.


Parsing region comments

Hi,
Is there a way to parse region comments that appear after the # symbol on each line? For example, if I put a label 10 on the region we get # text={10} but I cannot see from the examples or docs that parsing this is possible.
Cheers
James

Here's an example using pyregion:
>>> import pyregion
>>> reg = pyregion.parse('icrs; circle 1 2 3 # text={10}')[0]
>>> print(reg.__dict__)
{'coord_list': [1.0, 2.0, 3.0], 'attr': ([], {'text': '10'}), 'params': [Number(1), Number(2), Number(3)], 'name': 'circle', 'continued': None, 'exclude': False, 'coord_format': 'icrs', 'comment': 'text={10}'}

Here's an example using the new regions package:
>>> import regions
>>> reg = regions.ds9_string_to_objects('icrs; circle 1 2 3 # text={10}')[0]
>>> print(reg.__dict__)
{'vizmeta': {'text': '{10}'}, 'meta': {'include': ''}, 'center': <ICRS Coordinate: (ra, dec) in deg
    (1.0, 2.0)>, 'visual': {}, 'radius': <Quantity 3.0 deg>}

It looks like both packages give you access to the comment contents.
@jmccormac01 - Is this what you need or do you need it in some other format?
Anyone -- please make pull requests to improve the documentation of both packages!

I'm closing this now.
@jmccormac01 - If you still have a question or feature request, please re-open file a new issue!


Mnist example missing source code

Cannot find the main function script and the docker file which were in the /build dir in the old repo.
Not sure whether it was removed on purpose, but I think it should be included.

@xyhuang
Yeah, it was removed on purpose. Idea was to pull from docker hub not build (Docker runner pulls a docker image if build/Dockerfile file does not exist). In PR #7, source code is back.


How was weights/hardnet_petite_base.pth trained?

Hi, I'm looking to convert this repo to Tensorflow.  I believe most of the operations here are standard and it should be relatively straightforward to convert to Tensorflow.
I will however need to regenerate the pretrained weights for hardnet_petite_base.  I was wondering if you could share the details of how you trained this?
Is the structure, just the decoder portion of the network followed by an FC layer to the number of classes and then Trained on ImageNet for 100 epochs?

Hi, yes we trained it with ImageNet for the first 100 epochs out of a totally 150 epochs of cosine learning rate schedule.

Hi thank you. And to confirm the architecture of the petitie base is : the decoder + fc layer + softmax  to classify the classes?

Yes, just add a fc layer with a cross entropy loss should be fine.

How much hours have you spent for training the model with ImageNet?


Organize Meijo visit #1

Eight students and two professors from Meijo University will fly in on Feb 23 and leave March 1.
They arrive at hotel in Davis on the evening of Feb 23. Jason will likely join them for dinner that evening.
They are staying at the University Park Inn and Suites.
Leaving Davis for SF on the 27th in evening. Possible dinner that night too.
They will come to our critical design reviews that are scheduled on the 27th.
They will participate in Engineering Week activities the 24th.

Tasks

[ ] Create schedule for the group.
[ ] Organize the lunch: select students, order catering, find space, selected students will need to share something about their culture.
[ ] Organize the campus tour (Monday)
[ ] Get campus parking passes
[ ] Schedule in e week events on friday
[ ] Get Rube Goldberg materials for the e-week activity
[ ] Schedule in the Sacramento Japanese exhibit on Sat or Sun
[ ] Think about other Sac area options for the weekend day
[ ] Check in with Petros about a possible snow visit for the weekend.
[ ] Schedule and EFL tour on Monday.
[ ] TAs (optional), Jason, and them have lunch at MU on Friday
[ ] Catered lunch on Monday
[ ] Friday night dinner at Davis restaurant
[ ] Jason will host dinner the weekend day they come to Sacramento
[ ] Announce and lottery to choose students for lunch in class (or online) (can be done in 22/23 sections)
[ ] Make a statement explaining culture game

Clarification needed: is Feb 27 their last day in Davis and the rest of the trip (through March 1) will be in SF?

I think they are planning to leave Davis late afternoon or evening on the 27th. The remaining part of the trip will be in SF.
FYI, I emailed Kelley Weiss inquiring about the E Week events. Waiting on response.

This could potentially be interesting for them on the weekend:
http://www.sacmag.com/Sacramento-Magazine/Arts-Culture/Sacramento-Events-Calendar/index.php/name/Kokoro-The-Story-of-Sacramentos-Lost-Japantown/event/12820/

Request put in for Kemper 1131 for the catered lunch on Monday. It holds about 40 people.

EFL tour is loosely scheduled for 10 or 11 on Monday the 27th. 9am is a bit early for the shop staff to set up glasses and whatnot, but it's flexible enough to schedule it so the students can attend a design review on Monday morning.

I think this went pretty smoothly. Notes have been added to the instructor guide for most of my tasks.


chore: update u4a-component to support menu management

What type of PR is this?
/kind chore

What this PR does / why we need it
Which issue(s) this PR fixes

Fixes #
Special notes for your reviewer

@zggmd


Using Subjects as Observers

I think this is a bug. Currently RxJS 5 Subjects cannot be used as Observers in source.subscribe(subject), even though Subject implements the Observer interface.
// Rx 5
observable.subscribe(
  subject.next.bind(subject),
  subject.error.bind(subject),
  subject.complete.bind(subject)
)

//Rx 4
observable.subscribe(subject.asObserver())

This should be simple to fix, but should be accompanied by tests too.

This is totally a bug. They should work as observers. It's half the point.

Also, you shouldn't have to use asObserver.

Agreed.

@blesh Apparently I'm not able to reproduce the bug, it seems everything is ok. See PR #828. I'm awaiting for a bug report from @TylorS who originally reported this bug to me.

@staltz ... I did fix a bug semi-related to this a while ago: #724
That might have been the culprit... I don't know.

@staltz Isn't this similar to issue https://github.com/ReactiveX/RxJS/issues/748?

@staltz @ntilwalli I just tried every Subject type from the latest build and I couldn't reproduce this issue.
If we can't reproduce it, can we close this?

Yeah let's close, Tylor couldn't reproduce it either.

This actually did not fix the issue from #748.  I've created a pull request with a fix for that issue.  https://github.com/ReactiveX/RxJS/pull/863

@ntilwalli is right: There is a minor issue that Subjects are being unnecessarily wrapped in Subscribers. This is less of a "bug" and more of a "refactor".


fixed ipv6 address join ipv4 group failed

Motivation:
#10995
when io.netty.channel.unix.Socket is ipv6 and join a multicast group with ipv4 address will cause io.netty.channel.ChannelException: setsockopt() failed: Invalid argument (at least in Linux centos.dev 4.18.0-240.10.1.el8_3.x86_64 #1 SMP Mon Jan 18 17:05:51 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux)
Modification:
check if target group address is ipv6 before call  io.netty.channel.epoll.LinuxSocket#joinGroup(java.net.InetAddress, java.net.NetworkInterface, java.net.InetAddress)
I'm not sure if this modification is currect, but i checked source code of java NIO
Java_sun_nio_ch_Net_canJoin6WithIPv4Group0(JNIEnv* env, jclass cl)
{
#if defined(__APPLE__)
    /* IPV6_ADD_MEMBERSHIP can be used to join IPv4 multicast groups */
    return JNI_TRUE;
#else
    /* IPV6_ADD_MEMBERSHIP cannot be used to join IPv4 multicast groups */
    return JNI_FALSE;
#endif
}

seems ipv6 address can't join ipv4 group except osx
Result:
test on Linux 3.10.0-514.el7.x86_64 #1 SMP Tue Nov 22 16:42:41 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux exception   setsockopt() failed: Invalid argument has fixed
Fixes #10995

@wineway did you verify this really fixed the issue ? Maybe you could also add a unit test ?

@wineway did you verify this really fixed the issue ? Maybe you could also add a unit test ?

of cource my manual test has passed, and i would try to add proper unit test
I can explain why this modification can work;
refer to java nio implement; in linux, ipv6 socket can join ipv4 multicast group
Java_sun_nio_ch_Net_canIPv6SocketJoinIPv4Group0(JNIEnv* env, jclass cl)
{
#if defined(__linux__) || defined(__APPLE__)
    /* IPv6 sockets can join IPv4 multicast groups */
    return JNI_TRUE;
#else
    /* IPv6 sockets cannot join IPv4 multicast groups */
    return JNI_FALSE;
#endif
}

but  IPV6_ADD_MEMBERSHIP can't be used to join ipv4
Java_sun_nio_ch_Net_canJoin6WithIPv4Group0(JNIEnv* env, jclass cl)
{
#if defined(__APPLE__)
    /* IPV6_ADD_MEMBERSHIP can be used to join IPv4 multicast groups */
    return JNI_TRUE;
#else
    /* IPV6_ADD_MEMBERSHIP cannot be used to join IPv4 multicast groups */
    return JNI_FALSE;
#endif
}

so we should use IP_ADD_MEMBERSHIP instead of IPV6_ADD_MEMBERSHIP or IPV6_JOIN_GROUP
the original  bool ipv6 depend on if local socket is instance of ipv6,
when ipv4 group pass in, it will initialize as sockaddr_in6 by netty_unix_socket_initSockaddr function, and will be set option IPV6_JOIN_GROUP, this will cause an exception
and in fact, when isIpv6 == true , no matter group addr or interface addr is Inet4Adder, we shouldn't pass  ipv6 = true to netty_epoll_linuxsocket_joinGroup
and alse, in joinSsmGroup , java nio implement will check if  source is same type with group
        if (source != null) {
            if (source.isAnyLocalAddress())
                throw new IllegalArgumentException("Source address is a wildcard address");
            if (source.isMulticastAddress())
                throw new IllegalArgumentException("Source address is multicast address");
            if (source.getClass() != group.getClass())
                throw new IllegalArgumentException("Source address is different type to group");
        }

but netty implement didn't do this, I am not sure if we should add this check or just let it go

@wineway did you sign our icla ?
https://netty.io/s/icla

@wineway did you sign our icla ?
https://netty.io/s/icla

@normanmaurer sure, I have add tests, PTAL
thx

@wineway the unit test fails... please check

@wineway Thanks!


Dice pools don't sort

Rolling, say, 10d10 doesn't give me them in ascending or descending order.  The option to do either would be welcome.

Seconded.


Removing parameters & variables

Right now, creating variables and changing built-in parameters from their default values are irreversible actions. Both of them create entries in the Outline & Inspector views which you can't remove and which clutter up the view.
Some interface to fix this would be nice:

deletion "X"
drag to trash bin
right click and select "delete"

Absolutely agree. Another interface option to fix this is setting the
expression to an empty string and defocusing the code editor to reset it.
On Tuesday, September 29, 2015, Joshua Horowitz<EMAIL_ADDRESS>wrote:

Right now, creating variables and changing built-in parameters from their
default values are irreversible actions. Both of them create entries in the
Outline & Inspector views which you can't remove and which clutter up the
view.
Some interface to fix this would be nice:

deletion "X"
drag to trash bin
right click and select "delete"

—
Reply to this email directly or view it on GitHub
https://github.com/cdglabs/apparatus/issues/7.


Disable coloring of comments icon for comments created by user itself

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

It has been lamented by some users that the new comment icon is also getting colored when a user itself creates a new comment, and this comment is also listed as unread for this user. This PR changes this behaviour: The new comment icon is no longer colored in this case, and the created comment is not listed as unread.

With this new behavior, we now get that the new comments icon is not colored anymore when you've just published a comment (which is great I think). Yet, you still see your own comment in the comments list (/main/comments). Do we we want that? I have no strong preference but tend towards not seeing your own comment in the comments list (since we also disabled the indicator color on the comments icon, so users might get confused why the comments icon is not colored even though the list shows a comment).

Yet, you still see your own comment in the comments list (/main/comments).

I cannot reproduce that (was it related to the bug I introduced?) Note that comments are grouped for media. So, if someone else made a new comment on the same medium, it will show in the list. If you can still reproduce it, I would need more info.

With a fresh database, I cannot reproduce this issue anymore, it was probably related to the old logic when you created new reader instances.

We should discuss whether adding a uniqueness constraint in the reader model on the thread/user columns makes sense in order to have an additional saftey net.

I think this would be really helpful. It could be done in a new PR where we also update the usage of Rails' persistance methods, so that methods with validations are used.

I rewrote the code a little since the last review. In particular I adressed the following issue that occured in the last reviewed version:
If two users A and B who have cleared all comments before wrote a comment at around the same time for the same medium (during that time not seeing whether new comments are popping up), the user who posted their comment last , say B, would get a yellow commentsIcon (because the flag was set by A's comment), but when clicking the icon, no comments would appear (because the thread was marked as read by B's post). In the new version, it is checked whether new comments by other users have been posted. If this is the case, the commentsIcon is colored for B, and the thread appears in the new comments list as unread.
Please check if I did not introduce some new issue by this ;-).

Thanks, I've played around with it and it works, code looks good too.
There is still one little (workflow) issue in the following scenario:
Scenario: Users A and B write comments simultaneously on the same medium. A posts the comment first. Then B posts the comment. Since we haven't implemented something like websockets, person B will only be notified of the comment of person A once B has published his/her comment. Then suddenly, the comments icon is colored for person B. Person B clicks on it and finds that the "Latest post" is by him/herself - which is correct. Still, it seems that the icon was only colored because of B's comment, so person B might just dismiss the comment directly and therefore miss the comment of person A.
In my opinion, this is really an edge case and not easily fixable (and "Latest post" is still correct), so we might just totally ignore it.

I think we should ignore this edge case here, since formally, everything is correct. (We might an explanation of this for users in the docs in #311, though).

Remember to "squash and merge".


Update account password

Besides GET and DELETE operations on accounts, we also need to support PATCH in order to:

update password (with/without password confirmation field, see #33)
update other account related fields, if / when necessary (display name etc.)

My best guess is that the non-updateable fields are ID and email (which would complicate the scenarios too much), so they should only be accepted, but ignored in the payload (see additionalProperties property in Swagger docs)

To avoid having a user locked out by someone who changes his password just by having access to the user's computer, the usual implementation of this feature requires the old password along with the new password.
We allow users to make accounts via third-party login, so with no password. For such cases this feature cannot be safely provided because there is no old password to check against before making changes.
This adds complexity I don't think this functionality is worthy of, especially since users will be able to change their password via account recovery (#32) which is also safe for accounts with no previous password.
However, I do agree the other account details should be updateable so I extended the specs in #11. I'll close this for now. If this is really such a pain for the users we can always reopen it.


Improve Card layout

Is your feature request related to a problem? Please describe.
No, just an extra feature that I would like to add
Describe the solution you'd like
Adding cards with the title of the book and shorter description which comes once you hover.
Describe alternatives you've considered
Making the layout as a grid
Additional context
No response

Can you please assign this to me


geodesic distance uses a spherical model

I am not sure if there is a bug or is misunderstood something.
According to your documentation your offer two different methods for calculating the distance between two points (lat, lon):

geopy.distance.geodesic
geopy.distance.great_circle

So I just wanted to compare your methods for a spherical and a ellipsoidal earth model. On the one hand on a spherical earth model there shouldn't be a difference between two points on the equator (east and west) as well on the two points on both poles (north and south). Using your method geopy.distance.great_circle it behaves like my expectation.
But on the other hand using an ellipsoidial earth model there should be a difference because the earth-"height" differs from the earth-"width". So using the same assumption points for your geopy.distance.geodesic it returns the same distance value for the equator points aswell as for the north pole-south pole points.
To make it clear see following code fragment:
from geopy.point import Point
from geopy.distance import geodesic, great_circle

# equator
p1 = Point(latitude=0, longitude=-90) # 0 0m 0s N, 90 0m 0s W
p2 = Point(latitude=0, longitude=+90) # 0 0m 0s N, 90 0m 0s E

# north-south
p3 = Point(latitude=+90, longitude=0) # 90 0m 0s N, 0 0m 0s E
p4 = Point(latitude=-90, longitude=0) # 90 0m 0s S, 0 0m 0s E

# great circle distance
gc_distance_p1_p2 = great_circle(p1, p2) # 20015.115070354455 km
gc_distance_p3_p4 = great_circle(p3, p4) # 20015.115070354455 km

print(gc_distance_p1_p2)
print(gc_distance_p3_p4)
print(gc_distance_p1_p2 == gc_distance_p3_p4) # True <--- fine

# geodesic distance
gd_distance_p1_p2 = geodesic(p1, p2) # 20003.931458625444 km
gd_distance_p3_p4 = geodesic(p3, p4) # 20003.931458625444 km

print(gd_distance_p1_p2)
print(gd_distance_p3_p4)
print(gd_distance_p1_p2 == gd_distance_p3_p4) # True <--- wrong

Let me try to explain it differently. According to this website https://www.space.com/17638-how-big-is-earth.html:
"[...] the equatorial circumference of Earth is about 24,901 miles (40,075 km). However, from pole-to-pole — the meridional circumference — Earth is only 24,860 miles (40,008 km) around."
So these values differ for equatorial circumference and meridional circumference.

Some additional information:

geopy version: 1.20.0
python version: 3.6.8
os: Linux Mint 19.1 Cinnamon

For an oblate (flattened) ellipsoid, the geodesic  path between 2 opposite
points on the equator is via one of the poles, not along the equator. Try
repeating your experiment from lat,lon = 0,0 to 0,90 and to 90,0.
—Charles
On Sat, Jun 29, 2019 at 08:51 philippvarga<EMAIL_ADDRESS>wrote:

I am not sure if there is a bug or is misunderstood something.
According to your documentation your offer two different methods for
calculating the distance between two points (lat, lon):

geopy.distance.geodesic
geopy.distance.great_circle

So I just wanted to compare your methods for a spherical and a ellipsoidal
earth model. On the one hand on a spherical earth model there shouldn't be
a difference between two points on the equator (east and west) as well on
the two points on both poles (north and south). Using your method
geopy.distance.great_circle it behaves like my expectation.
But on the other hand using an ellipsoidial earth model there should be a
difference because the earth-"height" differs from the earth-"width". So
using the same assumption points for your geopy.distance.geodesic it
returns the same distance value for the equator points aswell as for the
north pole-south pole points.
To make it clear see following code fragment:
from geopy.point import Point
from geopy.distance import geodesic, great_circle
equator
p1 = Point(latitude=0, longitude=-90) # 0 0m 0s N, 90 0m 0s W
p2 = Point(latitude=0, longitude=+90) # 0 0m 0s N, 90 0m 0s E
north-south
p3 = Point(latitude=+90, longitude=0) # 90 0m 0s N, 0 0m 0s E
p4 = Point(latitude=-90, longitude=0) # 90 0m 0s S, 0 0m 0s E
great circle distance
gc_distance_p1_p2 = great_circle(p1, p2) # 20015.115070354455 km
gc_distance_p3_p4 = great_circle(p3, p4) # 20015.115070354455 km
print(gc_distance_p1_p2)
print(gc_distance_p3_p4)
print(gc_distance_p1_p2 == gc_distance_p3_p4) # True <--- fine
geodesic distance
gd_distance_p1_p2 = geodesic(p1, p2) # 20003.931458625444 km
gd_distance_p3_p4 = geodesic(p3, p4) # 20003.931458625444 km
print(gd_distance_p1_p2)
print(gd_distance_p3_p4)
print(gd_distance_p1_p2 == gd_distance_p3_p4) # True <--- wrong
Let me try to explain it differently. According to this website
https://www.space.com/17638-how-big-is-earth.html:
"[...] the equatorial circumference of Earth is about 24,901 miles (40,075
km). However, from pole-to-pole — the meridional circumference — Earth is
only 24,860 miles (40,008 km) around."
So these values differ for equatorial circumference and meridional
circumference.
Some additional information:

geopy version: 1.20.0
python version: 3.6.8
os: Linux Mint 19.1 Cinnamon

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/geopy/geopy/issues/364?email_source=notifications&email_token=AARRDGRJZASJHC373VD5HKTP45LE7A5CNFSM4H4KK5H2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G4OEJZQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARRDGW3NPZYTBKQA6BJQSTP45LE7ANCNFSM4H4KK5HQ
.

--
Charles Karney<EMAIL_ADDRESS>Princeton, NJ 08540

Perfect, my mistake.
Thanks for the quick response, I will close this issue.


Bot should at first only unmute player who called meeting/reported body

Like 10 sec to let him tell his story, and only then unmute everyone else as well.

https://github.com/denverquane/automuteus/issues/203


update-packages is failing due to conflicts between concurrent pub get processes

We are sometimes seeing failures in flutter update-packages when a pub get process throws an exception due to invalid filesystem state in the pub cache.
This seems to be happening especially often in Cirrus CI jobs.  Several Dart->engine and Skia->engine rolls recently failed due to this:
(examples: https://github.com/flutter/engine/runs/4730759888 and https://github.com/flutter/engine/runs/4723438043)
update-packages starts multiple concurrent instances of pub get in order to improve performance (see https://github.com/flutter/flutter/commit/01af8e5987e4ed1f4ea12675975e98bc0ebe87ac).
It looks like this may be unsafe if the pub get processes are simultaneously trying to download a package and update the pub cache.
update-packages also tries to prewarm the cache and force a download of the necessary packages before running pub get on the various Flutter subcomponents.
@gspencergoog What is the prewarm expected to handle?
The prewarm is parsing the pubspec.yaml files in the subcomponents and fetching their direct dependencies.  But it appears to be skipping the autogenerated transitive dependencies declared in those pubspec.yaml files.
If the transitive dependencies are pinned to a different version than the one fetched by the prewarm, then the pub get calls for the subcomponents will still need to download more packages.  That can result in conflicting cache writes that cause errors in pub get.

The prewarm is expected to handle all of the packages and their dependencies. The idea is that it takes the union of all (transitive) packages used in the tree and makes a project that depends on those packages, and then runs pub get on that fake package to warm the cache. I don't see why it wouldn't download all of the transitive dependencies as well at that time.
One thing I could try is to run the subsequent pub get calls with --offline, which would prevent the command from even going to download new packages.  It should then fail version solving if it didn't get it in the initial pub get of the fake package.

I tried capturing a pubspec.yaml for the fake package.  It had a dependency section containing the union of the direct dependencies but it excluded the autogenerated transitive dependencies (see https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/commands/update_packages.dart#L751)
A fetch of the fake package will download some version of the transitive dependency packages.  But if the fake pubspec.yaml does not have a version constraint for the transitive packages, then the downloaded version may not match the exact version needed by subsequent pub get runs.

Thanks, that makes sense. I'll see if I can add the transitive dependencies, with their version numbers.

I think I have a fix for this: once I updated the fake project generation to include the version numbers of all the transitive dependencies, I can now run all of the remaining pub get runs with --offline successfully, and I don't have and extra version in my pub cache afterward.
I'll write up a test and send that out for review.

This blocked https://github.com/flutter/flutter/issues/96018


[Usage]: Specify the number of tokens to be generated

Your current environment
vllm
How would you like to use vllm
I want to specify the number of generated tokens for each request using vllm. Is there a way to do so?

You can use a combination of max_tokens and ignore_eos in sampling params to achieve this. https://docs.vllm.ai/en/latest/dev/sampling_params.html
There's also active work in #3124 for minimal tokens.

You can use a combination of max_tokens and ignore_eos in sampling params to achieve this. https://docs.vllm.ai/en/latest/dev/sampling_params.html
There's also active work in #3124 for minimal tokens.

Thanks! But the max_tokens parameter is a global setting and it applies to all the request. Can I specify the number of generated tokens seperately for each request?


change initial condition perturbation to be deterministic

Purpose

Replace rando perturbation in initial condition with a sin wave.
To-do

Content

[ ] I have read and checked the items on the review checklist.

bors r+


Fix up istioctl proxy-config

Address a few cases where I was getting nil pointer exceptions from the tool while attempting to debug bad Pilot config pushes. Also swaps all marshaling code to use jsonpb rather than json, and as well as other miscellaneous cleanup (e.g. use sort.Slice rather than a third party lib for the same).
Nearly the entire diff (~500 LoC) is a result of updating the golden files because I removed a layer of indentation when printing JSON blobs (which IMO is a good thing, easier to read in a terminal).

@ZackButcher: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
e75d97a6967fc3f7ad1ae9881840acb1375d5148
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ZackButcher: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
e75d97a6967fc3f7ad1ae9881840acb1375d5148
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
e75d97a6967fc3f7ad1ae9881840acb1375d5148
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm /approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: liamawhite, ZackButcher
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [ZackButcher]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ZackButcher are you able to rebase and retrigger the tests?

@ZackButcher: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Have picked this to #8946, so close this one.
/close

@fisherxu: Closing this PR.

In response to this:

Have picked this to #8946, so close this one.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Empty address record is created when an account without address is saved

Critical Changes
Changes
Issues Closed
New Metadata
Unpackaged Metadata
Deleted Metadata
Testing Notes

Looks good, all test suites passing


regex changed in method isAlphaNumeric(val) => ids using paragraph sign are evaluated as invalid

Short description
Using the latest version of w2ui (2.0) is not letting us start our project anymore. Function isAlphaNumeric() is returning false for our ids. We use only w3.org suggested characters in our project's ids. I found out that you removed the '§' from your regex. According to [(W3.org)](https://www.w3.org/TR/CSS21/syndata.html#:~:text=In CSS%2C identifiers (including element,hyphen followed by a digit.) it is a valid character to use in CSS.
What is current behavior
Console output : "ERROR: Property "name" has to be alpha-numeric (a-z, 0-9, dash and underscore)."
Page not visible.
What is desired behavior
w2ui should be initialized as before
Link to jsfidle/codepan with sample code
...
Steps to reproduce or sample
use ids that contain '§' in it

well, there was no change to isAlphaNumeric for 3 years.  Plus it only allows letters and numbers, which paragram is not. What probably happened is now it requires name for controls to be alpha numeric. I wish to keep it that way.
However, I can offer you a couple solutions:

After loading w2ui.js file, you can customize it by overwriting w2utils.checkName function and allow names with paragraphs.
Or you can remove paragraphs from widget names

Thank you!!


docs(README): concatenate description sentences

:tada: This PR is included in version 1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[WIP] Extract raftstore and pd crates

What have you changed? (mandatory)
This is the initial steps to extracting pd and raftstore modules, which have a number of interdependencies. It has done many of the initial, easier steps, in particular there is only
one pd submodule remaining in tikv; but I have to take a break from this for a week or
so, so I'm posting this so others can see the approach I'm taking.
I've started by pulling out submodules with no interdependencies, then handling modules with simple interdependencies, leaving reexports in place temporarily.
The big challenge here will be interjecting some abstractions between pd and raftstore so that they do not directly depend on each other. raftstore also has a few other in-crate dependencies but they are
relatively easier to resolve.
What are the type of the changes? (mandatory)

Bug fix (change which fixes an issue)

How has this PR been tested? (mandatory)
cargo check
Does this PR affect documentation (docs) update? (mandatory)
no
Does this PR affect tidb-ansible update? (mandatory)
no
Refer to a related PR or issue link (optional)
https://github.com/tikv/tikv/issues/3352
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)

I have a refactor sequence that almost entirely extracts the pd module, leaving behind what I think is a reasonable amount of connective code between pd and raftstore, so I'm going to start this patch from scratch focusing just on cleanly extracting the pd crate.

Well, I'm still working on this branch, even though I expect to need to redo the whole thing, so I'll keep this open in case anyone is interested.

This now has pd extracted, and raftstore about 1/3 extracted. They are parallel dependencies, that each themselves depend on a new grab-bag crate, tikv_misc.

This isn't worth keeping open. I'll just use it as a reference when I re-do the pd extraction.


License

Under which License is this project distributed?

BSD-licensed
2018-03-08 5:23 GMT+08:00 jwijffels<EMAIL_ADDRESS>
Under which License is this project distributed?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/xiaohuiyan/BTM/issues/18, or mute the thread
https://github.com/notifications/unsubscribe-auth/AHMkglipohxXglm2dRYX_UjX_-FDdY2lks5tcE_UgaJpZM4ShLf5
.

Thank you for the information. Would it be possible to add that license to the repository?

I wouldn't mind creating an R wrapper around this code, but for this, can you please add the license file in the repository. Thank you!

Thanks, jwijffels! I have added Apache License in the code.

I wouldn't mind creating an R wrapper around this code, but for this, can you please add the license file in the repository. Thank you!

Thanks, jwijffels! I have added Apache License in the code.

Where is it, can't find the license :)

Sorry, the uploading takes a few of minutes. It can be found now.

Great! Many thanks!

FYI. I've made an R package wrapping the C++ code. It's currently avaiable at https://github.com/jwijffels/BTM
Feel free to provide feedback before I'll push it to cran.

FYI. It's now also distributed on CRAN https://CRAN.R-project.org/package=BTM


support CORS option ?

Hi experts !
I really love angular-jwt and use it for my production projects. It runs so good until I have CORS issue.
I need to use interceptor for every get/post/put requests, but it also causes the CORS issue....
The url I browse is : https://axa.mydomain.com and my angularjs api is calling Google App Engine cloud endpoint which is https://axa-prod.appspot.com/_ah/api/v5/xxxxxx this request would trigger CORS issue due to interceptor force to append 'Authentication'  header? (Correct me if i'm wrong.)
I've tried to confiig $httpProvider in app.js  , but didn't get luck!
  delete $httpProvider.defaults.headers.common['X-Requested-With'];
  $httpProvider.defaults.withCredentials = true;
  $httpProvider.defaults.useXDomain = true;

Anyone have better suggestions to solve this CORS issue? Thanks!

Below is my angularjs code for interceptor
.config(function Config($httpProvider, jwtInterceptorProvider) {
  jwtInterceptorProvider.tokenGetter = function() {
    var access_key = localStorage.getItem('access_key');
    //console.log(access_key)
    return access_key
  }
  $httpProvider.interceptors.push('jwtInterceptor');
})

Hi @axacheng,
Hope you have been already able to solve this issue as it is quite old, but let me answer it as it is still open.
Enabling CORS support must be done on the server side. It is driven by Access-Control-Allow-Origin http header. I Googled for you something that might help you: http://enable-cors.org/server_appengine.html
But do not use * as it allows requests from all domains. You should always specify only the domain you really want to allow requests from.

Thanks for your answer @Shimmi :) Closing as I think this covers it.


[WIP] drop gitpython in favor of scmrepo

related: https://github.com/iterative/dvc/issues/9100
Should fix https://github.com/iterative/gto/issues/369

Drops support for Python < 3.8
Replaces gitpython usage with scmrepo
Migrates tests to use pytest-test-utils

Codecov Report
Patch coverage: 83.75% and project coverage change: +0.10% :tada:

Comparison is base (73b1dfb) 85.36% compared to head (52cd44e) 85.47%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   85.36%   85.47%   +0.10%
==========================================
  Files          18       18
  Lines        2125     2120       -5
==========================================
- Hits         1814     1812       -2
+ Misses        311      308       -3

Files Changed
Coverage Δ

gto/constants.py
100.00% <ø> (ø)

gto/utils.py
79.16% <ø> (-2.50%)
:arrow_down:

gto/index.py
80.73% <75.71%> (-0.52%)
:arrow_down:

gto/git_utils.py
75.24% <76.38%> (-3.57%)
:arrow_down:

gto/registry.py
90.53% <87.50%> (-0.04%)
:arrow_down:

gto/tag.py
92.50% <90.38%> (+2.70%)
:arrow_up:

gto/api.py
90.14% <97.43%> (+0.63%)
:arrow_up:

gto/base.py
88.38% <100.00%> (ø)

gto/ext.py
72.50% <100.00%> (+0.70%)
:arrow_up:

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DVC officially, supports Python 3.8 through 3.11 but GTO CI is only run against 3.8 through 3.10 (GTO CI fails if you enable 3.11). As far as I can tell, the 3.11 failure is because GTO requires outdated pylint and mypy installations that are just broken on 3.11.
IMO there is a lot more work that needs to be done in GTO to bring it in line with current DVC and iterative/py-template standards, but for the time being I am leaving all of that alone (GTO codebase fails pylint/mypy checks after updating and enabling the py-template or DVC configurations for those tools)

This PR will require changes in studio - gitpython instances can no longer be passed into the GTO calls (cc @amritghimire)

Thanks, I can look into it once It gets merged.


Include the layer arn's on the releases like all the other DataDog lambda layer repos

Expected Behavior
On the releases for this repo, the set of arn's for the layer versions this release correspond to is included in a code block in the release description.
Examples:

Java: arn:aws:lambda:<AWS_REGION>:464622532012:layer:dd-trace-java:8
Ruby: arn:aws:lambda:<AWS_REGION>:464622532012:layer:Datadog-Ruby2-7:16
JS: arn:aws:lambda:<AWS_REGION>:464622532012:layer:Datadog-Node12-x:88
Python: arn:aws:lambda:<AWS_REGION>:464622532012:layer:Datadog-Python37:69

Go: arn:aws:lambda:<AWS_REGION>:464622532012:layer:????:??

Actual Behavior
There is no trace whatsoever anywhere in the repo or DataDog docs about what layer arns/versions are, or even what their format looks like for golang.
Working at a company that restricts what's possible to do in the AWS console means we cannot just browse for simple things like this or even take wild guesses.  It's inconsistent with all of the other datadog lambda layer repositories.  This would be a small change to release behavior, but make a huge impact for end users (in my opinion, or at least for other devs finding themselves in my unfortunate situation).
If anything, please consider this for the sake of consistency and bc it will improve the experience of your end users, even if just a little. <3
Steps to Reproduce the Problem

Go to literally any other DataDog/datadog-lambda-* releases page and look for arn
See the releases in an easy to read code block
Got to this repo's releases page, look for arn to no avail.
Suffer X_X

Specifications

Datadog Go Lambda package version: Literally all of them.
Go version: N/A

Stacktrace
N/A

@frumpled Thanks for your feedback! The reason we don't publish Lambda layers for Golang is because Golang requires your application code and the datadog tracer code to be compiled into a single native binary, and there isn't yet a good way to distribute the tracer as a standalone binary and dynamically link it at the runtime. In short, this limitation is due to inherent differences between Golang and other languages you mentioned.
That said, we are trying to be creative and searching for solutions to make tracing Golang Lambda functions easier. If anyone has ideas, please leave a comment below and inspire us :) Thank you!

@frumpled I hope my previous explanation clarified the technical limitation here. I'm closing the issue for now, because after reviewing with our engineers again we still don't see any viable solutions. Thanks for flagging the problem to us though, really appreciated!


Support finetuning with the AxoNN backend

Changes apart from AxoNN -

[x] multi-node support
[x] lower lr of optimizer (the default is too high for finetuning)
[x] add gradient clipping

Evidence for correctness -

Identical loss curves with FSDP in fp-16


Instant app crash on opening, SQLiteException: file is not a database

Avoid duplicates

[x] Bug is not mentioned in the FAQ
[x] Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[x] Bug is not already reported in another issue

Describe the bug
I click on the app icon/select "open app" in exposure settings to open the app. Main activity is shortly visible, then app crashes. No error message displayed (This differs from other bug reports). After a few tries Android suggests to uninstall the App.
Expected behaviour
No crash expected. In case it happened the app could recover by re-initializing the missing/corrupt database.
Steps to reproduce the issue
Simply open the app. The app worked fine since it was released and got auto-updated each time new releases had been available. No specific action required to break it.
Technical details

Mobile device: ZTE Axon 9 Pro
Android version: 9, Security Patch level July 1, 2020
App Version: 1.3.1
Prioritized Background Activity: On
Battery Power saver options turned off, "Adaptive Battery" off, CWA set as "Don't optimize"

Possible Fix
unclear. Will try re-installing the app
Additional context
2020-10-07 11:47:35.801 2898-16555/? I/ActivityManager: START u0 {act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] flg=0x10200000 cmp=de.rki.coronawarnapp/.ui.LauncherActivity bnds=[290,1500][540,1814]} from uid 10030
2020-10-07 11:47:35.824 2898-16555/? I/ZTEAppProfile: apk (de.rki.coronawarnapp) at top
2020-10-07 11:47:35.825 12616-12616/? I/i.coronawarnap: GetResourceLocales CollectLocales
2020-10-07 11:47:35.826 12616-12616/? I/chatty: uid=10239(de.rki.coronawarnapp) identical 1 line
2020-10-07 11:47:35.826 12616-12616/? I/i.coronawarnap: GetResourceLocales CollectLocales
2020-10-07 11:47:35.829 12616-12616/? I/i.coronawarnap: GetResourceLocales CollectLocales
2020-10-07 11:47:35.837 2898-3257/? I/AutoScreenEnhacementManagerService: onCreate : ComponentInfo{de.rki.coronawarnapp/de.rki.coronawarnapp.ui.LauncherActivity}
2020-10-07 11:47:35.841 2898-3257/? I/AutoScreenEnhacementManagerService: onStart : ComponentInfo{de.rki.coronawarnapp/de.rki.coronawarnapp.ui.LauncherActivity}
2020-10-07 11:47:35.844 2898-3257/? I/AutoScreenEnhacementManagerService: onResume : ComponentInfo{de.rki.coronawarnapp/de.rki.coronawarnapp.ui.LauncherActivity}
2020-10-07 11:47:35.863 2898-16555/? I/ActivityManager: START u0 {cmp=de.rki.coronawarnapp/.ui.main.MainActivity} from uid 10239
2020-10-07 11:47:35.879 2898-3257/? I/AutoScreenEnhacementManagerService: onPause : ComponentInfo{de.rki.coronawarnapp/de.rki.coronawarnapp.ui.LauncherActivity}
2020-10-07 11:47:35.882 2898-16555/? I/ZTEAppProfile: apk (de.rki.coronawarnapp) at top
2020-10-07 11:47:35.901 2898-3257/? I/AutoScreenEnhacementManagerService: onCreate : ComponentInfo{de.rki.coronawarnapp/de.rki.coronawarnapp.ui.main.MainActivity}
2020-10-07 11:47:35.911 2898-3257/? I/AutoScreenEnhacementManagerService: onStart : ComponentInfo{de.rki.coronawarnapp/de.rki.coronawarnapp.ui.main.MainActivity}
2020-10-07 11:47:35.962 2898-3257/? I/AutoScreenEnhacementManagerService: onResume : ComponentInfo{de.rki.coronawarnapp/de.rki.coronawarnapp.ui.main.MainActivity}
2020-10-07 11:47:36.023 2898-2926/? I/ActivityManager: Displayed de.rki.coronawarnapp/.ui.main.MainActivity: +142ms (total +205ms)
2020-10-07 11:47:36.038 2898-3257/? I/AutoScreenEnhacementManagerService: onStop : ComponentInfo{de.rki.coronawarnapp/de.rki.coronawarnapp.ui.LauncherActivity}
2020-10-07 11:47:36.038 2898-3257/? I/AutoScreenEnhacementManagerService: onDestroy : ComponentInfo{de.rki.coronawarnapp/de.rki.coronawarnapp.ui.LauncherActivity}
2020-10-07 11:47:36.183 720-1237/? W/SurfaceFlinger: Attempting to set client state on removed layer: Splash Screen de.rki.coronawarnapp#0
2020-10-07 11:47:36.183 720-1237/? W/SurfaceFlinger: Attempting to destroy on removed layer: Splash Screen de.rki.coronawarnapp#0
2020-10-07 11:47:36.343 12616-12616/? E/AndroidRuntime: FATAL EXCEPTION: main
    Process: de.rki.coronawarnapp, PID: 12616
    net.sqlcipher.database.SQLiteException: file is not a database: , while compiling: select count(*) from sqlite_master;
        at net.sqlcipher.database.SQLiteCompiledSql.native_compile(Native Method)
        at net.sqlcipher.database.SQLiteCompiledSql.compile(SQLiteCompiledSql.java:3)
        at net.sqlcipher.database.SQLiteCompiledSql.<init>(SQLiteCompiledSql.java:10)
        at net.sqlcipher.database.SQLiteProgram.<init>(SQLiteProgram.java:17)
        at net.sqlcipher.database.SQLiteQuery.<init>(SQLiteQuery.java:1)
        at net.sqlcipher.database.SQLiteDirectCursorDriver.query(SQLiteDirectCursorDriver.java:9)
        at net.sqlcipher.database.SQLiteDatabase.rawQueryWithFactory(SQLiteDatabase.java:5)
        at net.sqlcipher.database.SQLiteDatabase.rawQuery(SQLiteDatabase.java:1)
        at net.sqlcipher.database.SQLiteDatabase.keyDatabase(SQLiteDatabase.java:6)
        at net.sqlcipher.database.SQLiteDatabase.openDatabaseInternal(SQLiteDatabase.java:4)
        at net.sqlcipher.database.SQLiteDatabase.openDatabase(SQLiteDatabase.java:10)
        at net.sqlcipher.database.SQLiteDatabase.openOrCreateDatabase(SQLiteDatabase.java:8)
        at net.sqlcipher.database.SQLiteOpenHelper.getWritableDatabase(SQLiteOpenHelper.java:14)
        at net.sqlcipher.database.SupportHelper.getWritableDatabase(SupportHelper.java:1)
        at androidx.room.RoomDatabase.inTransaction(RoomDatabase.java:1)
        at androidx.room.RoomDatabase.assertNotSuspendingTransaction(RoomDatabase.java:1)
        at androidx.room.SharedSQLiteStatement.createNewStatement(SharedSQLiteStatement.java:4)
        at androidx.room.SharedSQLiteStatement.acquire(SharedSQLiteStatement.java:4)
        at de.rki.coronawarnapp.storage.tracing.TracingIntervalDao_Impl$4.call(TracingIntervalDao_Impl.java:3)
        at androidx.room.CoroutinesRoom$Companion$execute$2.invokeSuspend(CoroutinesRoom.kt:2)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:2)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:18)
        at androidx.room.TransactionExecutor$1.run(TransactionExecutor.java:1)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
        at java.lang.Thread.run(Thread.java:764)
2020-10-07 11:47:36.345 2898-11086/? W/ActivityManager:   Force finishing activity de.rki.coronawarnapp/.ui.main.MainActivity
2020-10-07 11:47:36.365 2898-3224/? W/InputDispatcher: channel '99af9b1 de.rki.coronawarnapp/de.rki.coronawarnapp.ui.main.MainActivity (server)' ~ Consumer closed input channel or an error occurred.  events=0x9
2020-10-07 11:47:36.365 2898-3224/? E/InputDispatcher: channel '99af9b1 de.rki.coronawarnapp/de.rki.coronawarnapp.ui.main.MainActivity (server)' ~ Channel is unrecoverably broken and will be disposed!
2020-10-07 11:47:36.369 2898-16555/? I/ActivityManager: Process de.rki.coronawarnapp (pid 12616) has died: vis  +99TOP
2020-10-07 11:47:36.369 2898-16555/? I/ZTEPoint_AI_AUTOSTART_CONTROL: died processName: de.rki.coronawarnapp
2020-10-07 11:47:36.369 2898-11913/? I/WindowManager: WIN DEATH: Window{99af9b1 u0 de.rki.coronawarnapp/de.rki.coronawarnapp.ui.main.MainActivity}
2020-10-07 11:47:36.369 2898-11913/? W/InputDispatcher: Attempted to unregister already unregistered input channel '99af9b1 de.rki.coronawarnapp/de.rki.coronawarnapp.ui.main.MainActivity (server)'
2020-10-07 11:47:36.373 720-1489/? W/SurfaceFlinger: Attempting to set client state on removed layer: de.rki.coronawarnapp/de.rki.coronawarnapp.ui.main.MainActivity#0
2020-10-07 11:47:36.373 720-1489/? W/SurfaceFlinger: Attempting to destroy on removed layer: de.rki.coronawarnapp/de.rki.coronawarnapp.ui.main.MainActivity#0
2020-10-07 11:47:36.374 720-1489/? W/SurfaceFlinger: Attempting to destroy on removed layer: AppWindowToken{188a128 token=Token{936f34b ActivityRecord{bae7c1a u0 de.rki.coronawarnapp/.ui.main.MainActivity t11011}}}#0

edit: 7.10., made clear that battery saving options are turned off

@stephankn
This seems related to https://github.com/corona-warn-app/cwa-app-android/issues/642 , however you wrote:

No error message displayed (This differs from other bug reports).

Call stack here and on #642 is different. Also the other one allowed the app to print an error message, which was not the case for me. I had to read logcat via adb.
It could be that a corrupted SQLite file leads to both symptoms. In another report it was mentioned that the used SQL Encryption library is quite buggy.

Might be related to https://github.com/corona-warn-app/cwa-app-android/issues/1121 not sure though, stacktrace looks different only symptoms seem to match.
@stephankn don't uninstall your CWA this will delete all your collected and sent keys. Try those instructions instead.

@daimpi thanks for mentioning. Too late for me, as I had to quickly re-enable the app. So it seems that I lost the history on the Google API as well. The first comments on #642 indicated that Google stores this data, not the app, so I thought it will be safe. As I have only 14 exposure checks listed in the google settings, all dating today after re-installing I fear history is lost. A later comment in the previous mentioned issue seems to confirm that Google API deletes data on uninstall; https://github.com/corona-warn-app/cwa-app-android/issues/642#issuecomment-688267231
So for others affected, please follow the instructions mentioned by daimpi.

fore reference: In a meanwhile closed ticket showing similar symptoms, a comment indicated that the used library is buggy and showed such DB corruptions for 1.5% of users: https://github.com/corona-warn-app/cwa-app-android/issues/579#issuecomment-656284863

@stephankn ah pity… yes the Exposure Notification Framework (ENF) data will be deleted upon uninstalling the last ENF app, it's only preserved if you have another one (e.g. SwissCovid) installed when deleting CWA.
It seems like a fix for OP might be coming with PR https://github.com/corona-warn-app/cwa-app-android/pull/1235 at the end of the month though 🙂.

Hi @KommX ,
I understand it as follows:
CWA worked fine before until today.
You registered a QR code successfully. You closed CWA.
After you opened CWA the next time, the error (app crash and/or error "file is not a database") occured? Or did it occur immediately after the QR code registration (without closing CWA)? It's not unimportant to have that detailed information, because it might help fixing the bug later.

@vaubaehn
Almost.
I registered the QR code successfully, there was something like "no results yet for your test".
Next time I opened the app, it was like a newly installed app with all the information on how to use the app (activate bluetooth, active location services, ...) and stuff that is shown after first start of the app. This was already weird, but during this setup the app crashed.
And now it crashes every time directly after starting it.
I don't see any error message.

@KommX
Thanks for your response.
Do you remember how you closed the app after registering the QR code? Did you maybe "swipe off" CWA to close it? Or did you press the closing Button "O"? What would you say, how much time was spent between closing CWA and then opening again (and seeing the setup process like newly installed) - was it less than 5 minutes, or maybe more than 10 minutes or even hours?

Only thing you can do now is to reset the app data (don't uninstall!).
The assumptions what happened to the data are a little bit outdated in #1053 , but the process to recover is still the same.
To make it short: All the data of CWA are stored encrypted. CWA uses an androidx.security module to make use of the encryption. That module uses another open source module (tink), to handle encryption keys in conjunction with the Android built-in KeyStore. Unfortunately, that KeyStore behaves unreliably, and tink didn't cover that unreliability good, so that in the end CWAs data was falsely overwritten and hence unrecoverable lost. This happens in rare cases only, and the CWA devs are already working flat out to find proper solutions to that problem.
Not only CWA is affected, also other Corona tracing apps, that use a similar approach for data privacy. And also other Apps in general have run into that problem. The identification of the problem is quite young, as it was hard to find.
Nevertheless, could be good if you tried to answer my last above questions, as the answers could help to develop a solution.
Thank you, good luck and stay healthy!

If I remember correctly I locked my phone via power button and closed the app later (after picking up the phone again) via "home button", but I'm not entirely sure.
After that, the app was closed for more than an hour and then the introduction stuff began to happen.
It's too bad, that I'll have to reset the app. Hopefully, the test result will be negative anyways, so that no possibility to warn other people will be lost.

@KommX

It's too bad, that I'll have to reset the app. Hopefully, the test result will be negative anyways, so that no possibility to warn other people will be lost.

Even if you reset the CWA data in the app, as long as you don't uninstall/reinstall it, your keys will still be saved in the Google Exposure Notification Framework (ENF). So if your result turns out positive, you can still request a Tele-tan from the hotline and share your keys to warn others.

@daimpi
I didn't know that. Thank your for the hint!

After having used it for months without an issue, CWA failed on me again. This time in version 1.5.0, which includes PR #1235. It fails in the newly added code. So the root cause here and freshly in #1469 might be related.

@stephankn Does the error still occur in the latest update (version 1.5.1) for you?

Corona-Warn-App Open Source Team


treatwell using rails?

so, now that i learn that TW is using rails, i wonder, when can i get an API token?
currently i must query the API with session cookies. i think TW can do better.
yes, i raised this question to partner@ but they didn't even understand what i was talking about.
while i run my own salon where i use TW, simultaneous i developed my own PoS/accounting for my salon and need some API calls.
it's no fun :(
pls send help!
production code (lol)

 agent = Mechanize.new
  response = agent.post('https://connect.treatwell.nl/api/authentication.json', {
      user: 'xxxx',
      password: 'xxxx',
      persistentLogin: false
    }, { 'Content-Type' => 'application/json' }
  );

  # CN = open
  # CP = checked out

  url = "https://connect.treatwell.nl/api/venue/xxxx/calendar.json?date-from=2023-11-20&date-to=2023-11-20&include=appointments&appointment-status-codes=CN,CR"
  json = JSON.parse(agent.get(url).body);

  a = json.fetch("appointments").collect do |appointment|
    OpenStruct.new(
      time: appointment.dig("startTime"),
      name: appointment.dig("consumerName"),
      email: appointment.dig("consumerEmail"),
      phone: appointment.dig("consumerPhone")
    )
  end.sort_by(&:time)

Hi @krtschmr, thank you for asking!
As far as I know there are no publicly supported APIs, so I think your implementation might be unstable as there's no agreement to keep supporting that type of authentication going forward.
Treatwell do has products already available with POS hardware integration, so I'd like to encourage you contacting our sales representative that can surely help you and your salon finding a suitable solution.


need reject image rulset

hello
need reject image rulset but  allow image from same domain and second level domain
and work when suspend on this tab activated

ok there is a allow_styles_and_images_same_site.ruleset
now need rulset reject image for any  request and work in suspend on this tab


Translate website to the Russian language

Currently the website is available only in English language.
Some users are not comfortable when support of Russian language is absent.
Add the Russian language support as optional language.

Probably use next-intl package


service behind istio-proxy can not be reach

we try deploy a service with istio sidecar, and find some access issue
1, the normal one is:
[root@d0404 ~]# telnet <IP_ADDRESS> 4670
Trying <IP_ADDRESS>...
Connected to <IP_ADDRESS>.
Escape character is '^]'.
ZHTTP/2 client preface string missing or corrupt. Hex dump for received bytes: 0d0aConnection closed by foreign host.
2, the failure one is:
[root@d0404 ~]# telnet <IP_ADDRESS> 4670
Trying <IP_ADDRESS>...
Connected to <IP_ADDRESS>.
Escape character is '^]'.
Connection closed by foreign host.
3,after get inside the pod and visit service directly, which means container itself, it is ok
kubectl exec -it kubectl get pod -n fate-9999 | grep clustermanager | awk '{print $1}' -n fate-9999 sh
sh-4.2# curl <IP_ADDRESS>:4670                                                                                +Unexpected HTTP/1.x request: GET /
4, between container and pod, only istio-proxy may has problem, but we check the log of istio-proxy, did not find any error
2020-12-10T02:02:11.408653Z	info	Envoy proxy is ready
any idea?

i just test bookinfo example, it's ok,
is it possible that i did not add any virtualservice or destinationrule, as i understand, after injecting label like "istio-injection=true" to namespace, everything should be fine. maybe i'm wrong,
if so, how to set these?


Add documentation for android libraries

Merged as 75a1f335fc60c43c9c5d0af68aae990fcdfa6887 (which will show up when I push the release here shortly).


Motion controller model not always loaded when playing in Editor

Overview
Motion controller model not always loaded when playing in Editor
Expected Behavior
Motion controller model loaded when playing in Editor
Actual Behavior
Sometimes the motion controller model is not loaded when playing in Editor
Steps to reproduce
Play in editor
Immediately activate the window of another program
I made a little debug taking a look at the source code of MotionControllerModel.dll.
The dll make a request of SpatialInteractionManager for the active window, so if you change the window when the toolkit is trying to get the model, the model is not loaded.
I modified the code of the dll to trace some messages.
When the model is not loaded because the active window is not Unity I get:

When the model is loaded the active window is with class name 'UnityHoloInEditorWndClass' and I get:

Sometimes also if the focus is on Unity, the model is not loaded. In this case the active window is with class name 'UnityContainerWndClass' (the main window of Unity):

When the model is not loaded it seems that Unity doesn't have a top level window with class name 'UnityHoloInEditorWndClass':

When the model is loaded it seems that Unity always has a window with class name 'UnityHoloInEditorWndClass' but it is not a top level window:

When the model is not loaded this two workarounds can be usefull:

Stop the app, close the portal and restart the app letting Unity to start the portal.
or
Stop the app and switch off the controllers. Start the app and then switch on the controllers.

Unity Editor Version
2017.3.0f3
Mixed Reality Toolkit Release Version
Current release

This should be fixed in the 2017.4.3 release. Please reopen if not.


a question regarding file formats

hi,
the output files i got from the schiller mt-101 are .cmp, .bak, .qrs, .pdf
your scripts dont seem to support these formats,
can you fancy a solution/workaround for that?
or can you propose a library that does support those formats?
thanks

@chrenova I apologize for the late reply. It was something with my GitHub notifications. Basically this tool comsumes .raw file which can be found on SD card of the device. .qrs contains information about patient and the device and .cmp is a subset of ECG data from .raw. .bak` is a temporary file.
The content of .cmp essentially is a ecg_block in this tool. It should be simple to accept this format as well, I can make it after a while.


Language tests: Eliminate warning for instance/static method clash

This is the test specific issue for #31201, which has the details.
The goal of this issue is to change all relevant tests in tests/... of the SDK repo such that they are based on the expectation that it is no longer a static warning (nor an error) when a class B declares a static member n and a subclass C of B declares an instance method, getter, or setter also named n.

It is not trivial to find the affected tests, but here are some results:
Status files contain the following entries for override_field_test/02 which is definitely testing the topic of this issue:
language_2_analyzer.status:override_field_test/02: CompileTimeError
language_2_dartdevc.status:override_field_test/02: CompileTimeError

Hence, the analyzer and dartdevc seem to emit the error that they shouldn't, but the test has been updated to have the correct expectation, and the tools are blamed for emitting a compile-time error that they shouldn't: All is well!
The following tests are related, but they are concerned with the converse case (a static member in a subclass has a name clash with an inherited instance member, which is still an error):
field_override3_test.dart
getter_override_test.dart
method_override7_test.dart

In other words, I can only spot one single test which is testing the topic of this issue, and it is marked correctly, and the tools that do not behave as specified are marked as they should in status files.
With that, I'll conclude that the tests are OK, and close this issue.


Why is "testthat" in "Imports" and not in "Suggests"?

https://github.com/r-hyperspec/hySpc.dplyr/blob/8bd5dc1eef25036a0c14a7e5366cff36f8d653fb/DESCRIPTION#L21

... because we need to import some of its functions for our .test<-() and hyperSpec.dplyr.unittest() functions.
I think we may want to put that into a hySpc.helpers package, though. That will make it easier to keep the code working similarly across the package zoo.

Ok. I raised this issue as usually testthat is not used directly by users of a package, but just by developers. So it usually goes to Suggests in R packages.

Dependency to testthat will be removed in favor of hySpc.testthat: #26


Improve iOS React Native sync mechanism

EarlGrey on iOS synchronizes with async OS tasks such as network requests using objects that conform to GREYIdlingResource. These objects listen on a resource like the network stack and are polled by EarlGrey to say whether this resource is busy or not (isIdleNow).
Our current phase 1 sync mechanism has 2 new Idling Resources specific for React Native.
The current implementation uses heuristics (moving average of the time that takes a bridge command to travel the full cycle) and this isn't ideal.
We want to improve the sync mechanism, remove the heuristics and make it more robust.

Implemented.


JavaScript error in the main process

As the application is started, the following error message comes up:
A JavaScript error occurred in the main process
Uncaught Exception:
Error: Code signature at URL file:///Users/len/Library/Caches/cc.buechele.Goofy.ShipIt/update.1SlPaJT/Goofy.app/ did not pass validation: code failed to satisfy specified code requirement(s)

I had the same problem, realized that it was due to being an old version (3.4.something). If you download the latest from the releases page, the error should go away.

Ah right makes sense - @lensherm Can you confirm what version you're working on - and also where did you see the error (was it a popup), can you send a screen shot?
Thanks!

It was the latest version as of the submission. It was a popup, but I
finally ended up removing the application and reinstalled it from scratch.
So far no issues.
On Wed, Jan 1, 2020 at 3:36 PM Jerrold Poh<EMAIL_ADDRESS>wrote:

Ah right makes sense - @lensherm https://github.com/lensherm Can you
confirm what version you're working on - and also where did you see the
error (was it a popup), can you send a screen shot?
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/danielbuechele/goofy/issues/474?email_source=notifications&email_token=AKOW5USU4MS37RLMI3V6KNLQ3T5FRA5CNFSM4KBFYDCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH5MDNY#issuecomment-570081719,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKOW5UWTH5GV3UPJAHFTMNLQ3T5FRANCNFSM4KBFYDCA
.

Ah ok, will close for now but feel free to reopen if you run into it again 🙂

I have been running to the same issues for a couple months now. Updating to the latest version fixes the issue. It will be nice if we have an auto-updater feature build in the app.