Failed to isolate due to pnpm pack

I have tried to make my setup work for a firebase monorepo with isolate-package and firebase-tools-with-isolate, but It doesn't seem to work when running the command "isolate" in the deploy process.
I tried to clear my pnpm cache and reinstall my pnpm dependencies multiple times, but it didn't solve the problem.
Output of logLevel debug when running npx isolate
info Using isolate-package version 1.19.0
debug Found tsconfig at: ./tsconfig.json
debug Workspace root resolved to W:\DevXpress\inspectogo
debug Isolate target package (root)\packages\functions
debug Isolate output directory (root)\packages\functions\isolate
debug Cleaned the existing isolate output directory
debug Detected package manager pnpm 9.12.1
debug Use PNPM pack instead of NPM pack
debug Detected pnpm packages globs: [ 'packages/*' ]
debug Registering package packages\security_rules
debug Registering package packages\functions
debug Registering package packages\firestore_models
debug Registering package packages\admin_cli
debug Packed (temp)/inspectogo_firestore_models-2.1.0.tgz
debug Unpacking (temp)/inspectogo_firestore_models-2.1.0.tgz
debug Moved package files to (isolate)\packages\firestore_models
error Command failed: pnpm pack --pack-destination "W:\DevXpress\inspectogo\packages\functions\isolate\__tmp"

Error: Command failed: pnpm pack --pack-destination "W:\DevXpress\inspectogo\packages\functions\isolate\__tmp"

    at genericNodeError (node:internal/errors:984:15)
    at wrappedFn (node:internal/errors:538:14)
    at ChildProcess.exithandler (node:child_process:422:12)
    at ChildProcess.emit (node:events:518:28)
    at maybeClose (node:internal/child_process:1105:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:305:5)

I also tried running the command earlier when I didn't have firebase-tools-with-isolate set up, and I was getting this error:
Output
Running command: pnpm isolate
info Using isolate-package version 1.19.0
error Command failed: pnpm pack --pack-destination "W:\DevXpress\inspectogo\packages\functions\isolate\__tmp"

Error: Command failed: pnpm pack --pack-destination "W:\DevXpress\inspectogo\packages\functions\isolate\__tmp"

    at genericNodeError (node:internal/errors:984:15)
    at wrappedFn (node:internal/errors:538:14)
    at ChildProcess.exithandler (node:child_process:422:12)
    at ChildProcess.emit (node:events:518:28)
    at maybeClose (node:internal/child_process:1105:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:305:5)
node:events:496
      throw er; // Unhandled 'error' event
      ^

Error: spawn pnpm isolate ENOENT
    at notFoundError (W:\DevXpress\inspectogo\node_modules\.pnpm\cross-spawn@6.0.5\node_modules\cross-spawn\lib\enoent.js:6:26)
    at verifyENOENT (W:\DevXpress\inspectogo\node_modules\.pnpm\cross-spawn@6.0.5\node_modules\cross-spawn\lib\enoent.js:40:16)
    at cp.emit (W:\DevXpress\inspectogo\node_modules\.pnpm\cross-spawn@6.0.5\node_modules\cross-spawn\lib\enoent.js:27:25)
    at ChildProcess._handle.onexit (node:internal/child_process:294:12)
Emitted 'error' event on ChildProcess instance at:
    at cp.emit (W:\DevXpress\inspectogo\node_modules\.pnpm\cross-spawn@6.0.5\node_modules\cross-spawn\lib\enoent.js:30:37)
    at ChildProcess._handle.onexit (node:internal/child_process:294:12) {
  code: 'ENOENT',
  errno: 'ENOENT',
  syscall: 'spawn pnpm isolate',
  path: 'pnpm isolate',
  spawnargs: []
}

isolate.config.json
{
  "targetPackagePath": "./packages/functions",
  "logLevel": "debug"
}

The command runs perfectly fine though when I try to run it by hand: pnpm pack --pack-destination "W:\DevXpress\inspectogo\packages\functions\isolate\__tmp"
I am under the impression it breaks because it doesn't expect a local dependency. Could this be the case?

Found the solution, should have RTFD.
https://github.com/0x80/isolate-package?tab=readme-ov-file#define-version-field-in-each-package-manifest
I think we should update the source code to pre-check whether the version is defined in package.json files, because it is pretty unintuitive to know this has to be done, and the error message is very generic.
I'll leave this open so author sees it.

Thanks for reporting and good to hear you found the solution. I agree that this should be detected.
It seems very much the same type of problem as this one https://github.com/0x80/isolate-package/issues/95
... so I will try to do both at once.

Closed in favor of #95


Fix the tracer/profiler for accuracy.

This also collapses some of the hierarchy where it makes sense.

The failure is jenkins tripping over itself just before the end it seems.  It did run coverage and it's fine.  All the tests pass.


Implementing json schema support

Hey @cdebost , thank you for your work on this pkg :)
We (lushateam) are thinking of using it but we will probably need jsonschema support
Can I submit a pr implementing it? Just want to make sure you are open to it before I start working on it

Hi @Ronserruya, I'll gladly review and release jsonschema support if you submit a PR.

Released at https://pypi.org/project/aws-glue-schema-registry/1.1.0/


fix torch NOPScaler shape

Description of changes:
scale because of the mean gets squeezed prematurely and thus the self.keepdim has no effect
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

@lostella I added a test as well


Add FC071 to check that LICENSE file is included

Stolen from https://github.com/sous-chefs/sc-foodcritic-rules/blob/master/rules.rb
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

@coderanger Does Github recognize COPYING. That's pretty common in older projects, but Github keys off LICENSE with some cool metadata now.

Yep they're using a gem that only looks for the license file, which is the goal here. If people really want copying that can be added, but I suspect that sourceforge crowd and the chef crowd don't overlap much.

:+1:


[PowerToys Run] Update to net5

Summary of the Pull Request
What is this about:
What is include in the PR:
How does someone test / validate:

Build an installer and install
Go through PowerToys Run checklist https://github.com/microsoft/PowerToys/blob/releaseChecklist/doc/releases/tests-checklist-template.md#powertoys-run

Quality Checklist

[X] Linked issue: #12285
[ ] Communication: I've discussed this with core contributors in the issue.
[ ] Tests: Added/updated and all pass
[ ] Installer: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Docs: Added/ updated
[ ] Binaries: Any new files are added to WXS / YML

[ ] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

Actually, wait a bit on this one, please.


Control report severity level separately to exit code

Is your feature request related to a problem? Please describe.
Currently in bandit the minimum severity for reporting and for triggering an exit code of 1 is always the same - controlled by -l, -ll and -lll. This means, for example, that I cannot run bandit in CI with all vulnerabilities going into a report, while failing the CI job on more severe issues.
Describe the solution you'd like
Being able to control the two separately. For example, -lll can still control both, but perhaps having presence of equivalent -L flags overriding what triggers an exit code of 1. So here's my example above in this format:
bandit -r code_dir -l -LLL

Describe alternatives you've considered
I could just run bandit twice: the first time reporting everything with --exit-zero; the second time just reporting high severity and allowing the exit code to influence CI.
Additional context
This is part of how I'd like our CI to work whereby I use the excellent Microsoft open source Bandit SARIF formatter to create a SARIF report, which pushes to Github security issues.

dup of #640?


spend_p2sh example fails

Hi,
I'm trying to run examples\spend_p2sh_transaction.py
but when I try to broadcast the signed transaction I get back:
'code': -26
'message': 'mandatory-script-verify-flag-failed (Script evaluated without error but finished with a false/empty top stack element)'

Stackoverflow suggests there is something wrong with the signing (like one field has to be zeroed while signing other field).
config:  (in: 13xx, out: 11xx address)
from 3LNAAKJmuv7ZrFLcmUif5cAZwEvj7J8a8g
to 1B8unyP6dqLq2k5wn7RHQuLeQF87SWyfws
txin = TxInput('c34279de38a03b744c79e14eb71528c5b026be4e18c1f88b265c66a4bc55ff88', 0)
to_addr = P2pkhAddress('1B8unyP6dqLq2k5wn7RHQuLeQF87SWyfws')
txout = TxOutput(to_satoshis(0.00000985), to_addr.to_script_pub_key() )

Hi @mrx23dot
The txin.script_sig' part updates the unlocking script with the new signature. Objects in python are passed by reference.
Is the redeem script you are using P2PK?
If yes, I will need to investigate more.
It would help me If you can simulate an example in testnet (create a P2PK output and share the key) so that I can try it out.

Got the email. I won't have time to look at it today.
Until I do though, note that the example tries to spend a P2SH locking script that contains a P2PK (not P2PKH or segwit) redeem script. If the redeem script is not a P2PK script, it is expected to fail.
All, P2SH scripts start with 3 (or 2 in testnet) regardless of what they contain.
The example script is a P2SH(P2PK) script.
A nested segwit is a P2SH(P2WPKH or P2WSH).
A native segwit starts with bc1.
Hope the above helps

I don't know about such a wrapper.
So, in order to spend a P2SH you need to know the redeem script. If we know the redeem script and we have the appropriate private key we can modify the example script to spend it without any issues.
The only person that knows the redeem script is the person that created the P2SH address.
If the redeem script is P2PK then the example should be working and I will try to see what went wrong.
Just give me the redeem script, exactly as used to create the P2SH address, and we'll spend it :-)

This is the locking script of a P2SH. It can contain any arbitrary Bitcoin script. The contained script is called redeem script. Only the person that knows the redeem script can spend the funds.
If you know the private key you could try to spend it as P2SH(P2WPKH) or as P2SH(P2PK). But it could be an arbitrary script, so no luck there.
I am closing this issue as it seems it is not related to the library.


Build RIOT examples in ci

Closes #101

This should be done now and is ready for review

Yeah actually the RIOT compiler is quite strict. I have already disabled a few rules to make it run.
I think for now I could disable this rule also to make the ci run for now, but we should fix it in another PR

Yeah, it appears that GNU C allows it, but not ISO C. We are currently using several GCC extensions so technically we arent ISO C compatible. That could be an issue

Nice the test now runs successfully :)
I opened #105 to not forget about the compiler issues, or to at least move the discussion there if we want to be ISO-C compatible or not etc.

Sorry I accidentally merged using the wrong button and moved all the commits to the main branch.
I fixed it now


Improve eaxample: ANSYS DPF-Post: Transient Anaysis (access time steps)

I couldn't figure out how to access results (like displacement) over time when using dpf-post with a transient simulation. The only example for transient analysis also does not show how to do it (in fact I don't know which result is used there for the plots - the last substep?). So how is it done? Also, I would suggest to improve the example, to show this.

Hmm, I found a "solution" for my problem (should be similar for the examle);
    time_steps_list = solution.time_freq_support.time_frequencies.data_as_list
    x_data = []
    y_data = []
    for time in time_steps_list[:-1]:
        x_data.append(time)
        displacement_fields__selection = solution.displacement(named_selection=named_selection, time=time)
        tip_disp = displacement_fields__selection.vector.get_data_at_field(0)[0]
        # tip_disp_norm = displacement_fields__selection.norm.get_data_at_field(0)[0]
        y_data.append(tip_disp[2])

But I'm pretty sure thats not how it should be done, because its extremly slow (its only one node in the selection, but each timestep in the for-loop takes roughly 0.2s). Also, for some reason I have to exclude the last timestep, or it crashes when reaching tip_disp = displacement_fields__selection.vector.get_data_at_field(0)[0]
Traceback (most recent call last):
  File "<input>", line 1, in <module>
  File "C:\Program Files\JetBrains\PyCharm 2021.2.2\plugins\python\helpers\pydev\_pydev_bundle\pydev_umd.py", line 198, in runfile
    pydev_imports.execfile(filename, global_vars, local_vars)  # execute the script
  File "C:\Program Files\JetBrains\PyCharm 2021.2.2\plugins\python\helpers\pydev\_pydev_imps\_pydev_execfile.py", line 18, in execfile
    exec(compile(contents+"\n", file, 'exec'), glob, loc)
  File "D:/myPython/Al_cantilever/only_post_process.py", line 8, in <module>
    post_process_dpf(result_path, geo_data)
  File "D:\myPython\Al_cantilever\post_dpf.py", line 87, in post_process_dpf
    get_tip_movement(solution)
  File "D:\myPython\Al_cantilever\post_dpf.py", line 64, in get_tip_movement
    tip_disp = displacement_fields__selection.vector.get_data_at_field(0)[0]
  File "D:\myPython\Al_cantilever\venv\lib\site-packages\ansys\dpf\post\vector.py", line 28, in vector
    return super()._get_result_data(self._operator_name, self._data_sources, self._model)
  File "D:\myPython\Al_cantilever\venv\lib\site-packages\ansys\dpf\post\result_object.py", line 54, in _get_result_data
    return ResultData(operator_name=operator_name, data_sources=data_sources,
  File "D:\myPython\Al_cantilever\venv\lib\site-packages\ansys\dpf\post\result_data.py", line 52, in __init__
    self._evaluator = ResultEvaluator(operator_name, data_sources, model, elem_average,
  File "D:\myPython\Al_cantilever\venv\lib\site-packages\ansys\dpf\post\result_evaluation.py", line 129, in __init__
    time2 = tfq.get_frequency(cumulative_index=(lower_index+1))
  File "D:\myPython\Al_cantilever\venv\lib\site-packages\ansys\dpf\core\time_freq_support.py", line 259, in get_frequency
    return self._get_frequency(step, substep, cumulative_index, cplx)
  File "D:\myPython\Al_cantilever\venv\lib\site-packages\ansys\dpf\core\errors.py", line 103, in wrapper
    raise DPFServerException(details) from None
ansys.dpf.core.errors.DPFServerException: cumulative index out of range

Hi @natter1 !
I've started looking at this and clearly it seems the Result objects are for now not meant to be scoped on a time_freq_support containing more than one value.
I suggest using the PyDPF-Core capabilities for now, as shown in this Transient Analysis Result Example.
Once the PyDPF-Post capabilities are able to do this, the exemple should indeed be updated.
I'll mark this as an enhancement for PyDPF-Post.


listing conflicts (forks)

Can we add an example for listing forked records? Should we add a method osm.conflicts() for this?

This would be good to have as a method, or at least an example.

I added an example in test/fork_count.js:
var hyperlog = require('hyperlog')
var fdstore = require('fd-chunk-store')

var level = require('level')
var db = level('/tmp/whatever.db')
var logdb = level('/tmp/whatever.log')

var osmdb = require('../')
var osm = osmdb({
  log: hyperlog(logdb, { valueEncoding: 'json' }),
  db: db,
  store: fdstore(4096, '/tmp/whatever.store')
})

osm.kv.createReadStream({ values: false })
  .on('data', function (row) {
    console.log(row.key, row.links.length)
  })

hyperkv has a createReadStream() method to list all the active keys, and row.links contains an array of all the forks of that key. When row.links.length > 1, there exists more than one version of a document. I've also added this use-case to the test suite and documented osm.kv.


[google_maps_flutter] use WaitUntilTouchesEndedPolicy to fix the cameraIdle not called issue on iOS

Description
We use a different gesture recognizer blocking policy to handle the issue where google maps' onCameraIdle is not called when the map is on a stack.
The policy is implemented in https://github.com/flutter/engine/pull/15940
This PR also updates the google_maps_flutter's min Flutter version to 1.16.3 which is the oldest version that supports WaitUntilTouchesEndedPolicy.
The tests of the gesture policy is implemented in https://github.com/flutter/engine/pull/15940
Related Issues
https://github.com/flutter/flutter/issues/33988
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

Does this work with a LazyLoadIndexedStack ?  I'm still having this issue.  Used like this:
LazyLoadIndexedStack(index: _selectedIndex, children: [
        Stack(children: <Widget>[
          GoogleMap( ....


Segfault when removing a pattern that isn't the last pattern

To reproduce:

Start plebtrk
Copy the order
Clone the pattern
Go to Order 0
Remove pattern 0
Go back to Order 1
Crash happens

Fixed. Orders who pointed to later pattens weren't being shifted down properly when an earlier pattern was removed.


Optional "allowSpaces" argument to prevent splitting on spaces

Some of the tags entered in my app require spaces, it would be great if we could support this through an extra argument. I've added an optional argument that defaults to false in order to keep the current behavior by default.

https://space.stackexchange.com/help/tagging

Tags can just as well be "Episode 1", "Chapter 2" or whatever, tags are not always limited to just one word. I already forked it and am using the fork, but I figured others might benefit from it as well in the future.
I don't mind either way.

https://space.stackexchange.com/help/tagging


Yankpad show repeated snippets

This is a really handy package for org-mode users. However, whenever I invoke the function yankpad-insert I see repetitions of the snippets I currently have for the mode I am in.
Notice in the picture of the option's that gets displayed are repeated options.

Here is my Yankpad configuration:
(use-package yankpad
  :config
  (bind-key "<f9>" 'yankpad-map)
  (bind-key "<f12>" 'yankpad-expand)
  (bind-key "C-c s" 'yankpad-insert))

Though it's not a critical bug, it's annoying and any solution would be appreciated.

Hi! Happy to hear that you enjoy the package. Could you post your yankpad-file? I haven't had this problem myself.

Hi! Happy to hear that you enjoy the package. Could you post your yankpad-file? I haven't had this problem myself.

Yeah mon (Jamaican Voice) nice work. The problem seems to have mysteriously disappeared after deleting two of the three snippets I had.
Here's what my yankpad.org file looked like:
* emacs-lisp-mode
** use-package
(use-package $0)
** function
(defun $0)
** package-install
(unless (package-installed-p '${0})
   (package-install '$0))

While I have you here, there is another small query that you might be able to help me with. Are there anyway to do mirroring in the snippets. yasnippet has this feature, but I haven't been able to get it to work in Yankpad. An example of what I was trying is in the package-install snippet above.

Yeah mon (Jamaican Voice) nice work. The problem seems to have mysteriously disappeared after deleting two of the three snippets I had.
Here's what my yankpad.org file looked like:
* emacs-lisp-mode
** use-package
(use-package $0)
** function
(defun $0)
** package-install
(unless (package-installed-p '${0})
   (package-install '$0))

While I have you here, there is another small query that you might be able to help me with. Are there anyway to do mirroring in the snippets. yasnippet has this feature, but I haven't been able to get it to work in Yankpad. An example of what I was trying is in the package-install snippet above.

The bug has returned. After using Yankpad for the past few days I have found that this bug occurs when I have snippets for multiple modes.
Here's my current Yankpad file:

emacs-lisp-mode
** use-package
(use-package $0)
** function
(defun $0)

org-mode
** Weekly Planning
\*** Last weeks big 3
\***** How far did you get [%]$7
****** [$2] $1
\****** [$4] $3
\****** [$6] $5
\***** What worked?
\****** $8
\***** What didn't work?
\****** $9
\***** What will you keep doing?
\****** $10
\***** What will you improve?
\****** $11
\***** What will you start doing?
\****** $12
\***** What will you stop doing?
\****** $13
\**** Review tasks and actions [/]$17
\***** [$14] DEFERRED TASKS
\***** [$15] DELEGATED TASKS
\***** [$16] REVIEW DAILY NOTES
\**** Important updates, deadlines and task this week [/]$24
\***** [$19] Personal
1. $18
\***** [$21] Professional
1. $20
\***** [$23] Learning
1. $22
\**** Big 3
\***** $25

snippets when in emacs-lisp-mode

snippets when in org-mode

The bug has returned. After using Yankpad for the past few days I have found that this bug occurs when I have snippets for multiple modes.
Here's my current Yankpad file:

emacs-lisp-mode
** use-package
(use-package $0)
** function
(defun $0)

org-mode
** Weekly Planning
\*** Last weeks big 3
\***** How far did you get [%]$7
****** [$2] $1
\****** [$4] $3
\****** [$6] $5
\***** What worked?
\****** $8
\***** What didn't work?
\****** $9
\***** What will you keep doing?
\****** $10
\***** What will you improve?
\****** $11
\***** What will you start doing?
\****** $12
\***** What will you stop doing?
\****** $13
\**** Review tasks and actions [/]$17
\***** [$14] DEFERRED TASKS
\***** [$15] DELEGATED TASKS
\***** [$16] REVIEW DAILY NOTES
\**** Important updates, deadlines and task this week [/]$24
\***** [$19] Personal
1. $18
\***** [$21] Professional
1. $20
\***** [$23] Learning
1. $22
\**** Big 3
\***** $25

snippets when in emacs-lisp-mode

snippets when in org-mode

This has to be related to ivy because when you disable ivy-mode, yankpad items in emacs' built-in completion-read interface aren't doubled as they are in ivy interface.
I verified this on emacs 28 with heavily customized doom, on emacs 27 with vanilla doom and also on vanilla emacs 27 config.

@AloisJanicek Thanks you for bug searching!

The bug was introduced in #75, but should be fixed now. Sorry for not noticing earlier @Randy1Burrell, I hadn't pulled the Github version into my local branch.


Dark mode shadow

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
When dark mode is enabled (data-bs-theme="dark"), shadows remain black, which makes it difficult to see.
Reduced test cases
https://codepen.io/allistairlee/pen/ZEmgMaq
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
No response
What version of Bootstrap are you using?
5.3.1

We had them go white for dark mode, but it was a little wonky looking. Dark mode's shadows could just be darker, but that's still something to flesh out more. Open to suggestions in a PR.

Just ran into this myself. I was reading around for recommendations and found this helpful Atmos blog article, with the following advice for communicating depth/elevation:

In light mode, we usually use shadows to communicate depth. The higher the surface is, the closer it is to the light source and the bigger shadow it casts. While this approach wouldn't work in a dark mode, we can use the same "light source" theory and apply it to the surface color.
So instead of changing only the shadow size, we can also make the surface lighter the higher it is. Think about the light source being closer and shining brighter on the surface.

with the great comparison image shown below. So maybe Bootstrap could take a similar approach. I certainly find the dark theme shadows in this image (even the "lowest" ones) to pop a lot more than the current Bootstrap dark theme ones.

which file?

Looking forward to seeing this resolved in 5.4.0!


FC-Louvain clusering fails for the provided example

$ python3 fast_consensus.py -f examples/karate_club.txt --alg louvain

multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
  File "/usr/lib/python3.5/multiprocessing/pool.py", line 119, in worker
    result = (True, func(*args, **kwds))
  File "/usr/lib/python3.5/multiprocessing/pool.py", line 44, in mapstar
    return list(map(*args))
  File "fast_consensus.py", line 97, in louvain_community_detection
    return cm.partition_at_level(cm.generate_dendrogram(networkx_graph, randomize=True, weight='weight'), 0)
AttributeError: module 'networkx.algorithms.community' has no attribute 'partition_at_level'
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "fast_consensus.py", line 352, in <module>
    output = fast_consensus(G, algorithm=args.alg, n_p=args.parts, thresh=args.tau, delta=args.delta, procs=args.procs)
  File "fast_consensus.py", line 124, in fast_consensus
    communities_all = pool.map(louvain_community_detection, get_yielded_graph(graph, n_p))
  File "/usr/lib/python3.5/multiprocessing/pool.py", line 260, in map
    return self._map_async(func, iterable, mapstar, chunksize).get()
  File "/usr/lib/python3.5/multiprocessing/pool.py", line 608, in get
    raise self._value
AttributeError: module 'networkx.algorithms.community' has no attribute 'partition_at_level'

You are right, this issue occurred when I used the community from networkx.algorithms instead of python-louvain, it might be helpful to comment in the imports like:
import community as cm   # python-louvain community

By the way, I realized that issue afterwards, a bit extended your algorithm (mostly I/O formats) and added it to the Clubmark benchmarking framework: https://github.com/eXascaleInfolab/clubmark/blob/master/algorithms/fast_consensus.py
Moreover, we submitted a paper to BigData '19, where your algorithm is evaluated together with almost a dozen others. Overall, it has high accuracy but is much less scalable than Louvain being not always robust to small network pertubations. There main (technical) issue is that convergence of the Fast Consensus Louvain (FCoL) significantly and non-linearly depends on the number of worker processes in the multiprocessing pool even fixing all the algorithm-related parameters (n_p, tau, delta), which should not happen in theory.
Namely,  FCoL converges on amazon and dblp (https://snap.stanford.edu/data/#communities) within couple of hours for the default values of tau, delta and n_workers = n_p = 5, but it can not converge within several days (basically, it hangs) setting n_workers <= 2 for the same n_p = 5. In practice, the difference there is only in the time when the workers are started. It seems, when all workers are started simultaneously then Louvain yields (approximately) the same results and does not require any consensus-related processing at all (probably, they have a tie breaking strategy depending on a low-resolution timer, system time). But when the workers are started in distinct time and Louvain yields distinct partitions then your algorithm fails to converge (hangs) for the default tau, independently on delta (I tried all values in the range 0.02 .. 0.1 with the step 0.01) and setting n_p = 5. It seems, for n_p = 10 on the single worker the convergence also never happens. So, you might need to investigate the outlined issue further and reconsider either the default tau or something else to ensure the proper convergence.

Thanks a lot for your feedback. I will look into the issues you mentioned for real world datasets and see if it can be improved.


Initial Commit

merging your PR thanx for contribution.

show some love by starring some of my repos and follow me on GitHub.


Add bundle-size testing directory

This adds a bundle-size directory which assists in testing Connect and Protobuf-ES with various bundlers. It will enable us to test how changes to those libraries affect bundle size and tree-shaking across an array of popular bundlers in the ecosystem.
Note that this directory is not meant to show an example of any sort as the others do. This is just for our own testing purposes.

@timostamm Let me know what you think about this first attempt at a bundle-size directory. It is not yet currently wired up to CI because I wanted to get your thoughts first.
Also, it is not yet hooked into manage.mjs. I think it should at least be a part of the forceupdate command so that we can easily bump up the dependencies, but wasn't sure if you thought it should be a part of the test run of that script also.

manage.mjs expects the scripts "generate", "build", "test", and "ci". https://github.com/connectrpc/examples-es/pull/1366 adds them. This means "bundle-size" can now use mange.mjs's commands, and should also plug nicely into ci (you need to update the workflow).


Fix typo on A level validation for undergraduate submissions

Context
Change content on A level validation message
Changes proposed in this pull request

Guidance to review

Change cycle switcher to 2025
Add no A levels under other qualifications section
Try to apply for an undergraduate course
See the new message

 TDA Apply: Typo - Add "an" rather than "your" A-Level


Fix typo on: About Branches page

fix 1 typo and delete unnecessary space

Why:
Typo. For having nice, grammatically correct docs ^^
No issue or PR found that addresses this.

What's being changed:
The sentence:

The default branch is also the initial branch that Git checks out locally out when someone clones the repository.

and:

GitHub 's

Check off the following:

[x] All of the tests are passing.
[x] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)

[n/a] For content changes, I have reviewed the localization checklist
[n/a] For content changes, I have reviewed the [Content style guide for GitHub Docs (https://github.com/github/docs/blob/main/contributing/content-style-guide.md).

Thanks so much for opening a PR to fix up this article @thisIsTheFoxe! I'll update the branch and get this merged once tests are passing 🍏


Loading bar inconsistencies

Description
I'm seeing different behavior with the loading bar when identical content is loaded from different sources. Not sure if this is a  issue or not but thought I would share.
When loading from a local source (or CDN in the Glitch demo) it acts as expected and completes shortly before the model displays. When loading from our 3d API the bar quickly fills and there is an extended wait until something shows.
Live Demo

https://fierce-expensive-source.glitch.me/

Browser Affected

[x ] Chrome
[x ] Firefox

OS

[x ] Android
[ x] Windows

Versions

model-viewer: v0.10.0

Interesting; can you tell me more about your 3D API? And have you tried both glTF and glb models?

This is the Smithsonian 3D API. Right now we are just serving the glbs. It's not a roadblock for us, but just thought it was interesting that there was inconsistent behavior. Thanks for taking a look!
-Jamie

@cdata Since you wrote the progress tracking code, do you have any thoughts on why the behavior is not consistent?

I'm moving this to a discussion as I'm pretty sure this is a server thing rather than a model-viewer issue. @gjcope Are you still seeing this?


COM Exception when changing background color

Hi,
I have an issue when I try to change the background color to a hex value on the spash screen using the minimal template. If I change  in Views/Splash.xaml (line 7) to  I get the following exception when trying to run the app.
An exception of type 'System.Runtime.InteropServices.COMException' occurred in mscorlib.ni.dll but was not handled in user code
Additional information: Error HRESULT E_FAIL has been returned from a call to a COM component.
This seems to have started after upgrading to Template10 1.0.6. Is anyone else having this problem?

I have COMException too!
And it's here: https://github.com/Windows-XAML/Template10/blob/master/Template10 (Library)/Common/BootStrapper.cs#L311
I can't create custom color, it's brush and style in Custom.xaml

Ack. I wonder if it just needs an OfType<>() filter.
I can't chase this for a little while. Windows 10 Tour events are about to start around the country - maybe I will see you at one of them - I'll try to debug this in the gaps.

If it's a platform bug, will be fixed when the windows 10 mobile rtm published?

I do not have the answer to this question.


Add sRGB color space support

This could be added as a simple post-processing effect callback that takes pixels as input. That would allow a custom processing effect really easily. All calculations of colors (for example: gradients) will be done in linear space, only when saving the image will this callback be applied.

Actually I'm quite dumb, this is not something that the library itself has to deal with. Or maybe I'm wrong here too, I don't know. Either way, I'm closing this.


How to make text blink using RichTextFx?

I want to make my text blink. So, I did this way.
CSS:
.my-class {
     -fx-animation: blinker 1s linear infinite;
}

@keyframes blinker {
  50% {
    -fx-opacity: 0;
  }
}

Java:
StyleClassedTextArea textArea = new StyleClassedTextArea();
textArea.append(text, "my_class");

But it didn't work. Could anyone help me?

Umm, I've looked in the latest JavaFX CSS Reference guide and I don't find either -fx-animation: or @keyframes in there ?  The latter according to the reference is not supported, see the limitations section.
If you can figure out how to do this on an ordinary JavaFX Text node then you should be able to get it to work in StyleClassedTextArea. I suggest asking on StackOverflow to see if somebody maybe knows how to do this on a Text node.

There's unfortunately no API in RichTextFX to do that. Here's a method though that'll return the last Node.
But be WARNED that any edits to a paragraph / line or visibility changes (e.g. scrolling out of view and then back) will result in it being recreated and your effects being lost !
private Optional<Text> getLastTextNode( GenericStyledArea<?,?,?> area )
{
    Parent virtualFlow = (Parent) area.getChildrenUnmodifiable().get(0);
    Parent navigator = (Parent) virtualFlow.getChildrenUnmodifiable().get(0);
    List<Node> boxList = navigator.getChildrenUnmodifiable();
    Parent lastBox = (Parent) boxList.get( boxList.size()-1 );
    Parent lastParagraph = (Parent) lastBox.getChildrenUnmodifiable().get(0);
    List<Node> contents = lastParagraph.getChildrenUnmodifiable();

    for ( int n = contents.size()-1; n > -1; n-- )
    {
        Node item = contents.get( n );

        if ( item instanceof Text )
        {
            System.out.println( item );
            return Optional.of( (Text) item );
        }
    }

    return Optional.empty();
}

@Jugen Thank you very much for your help. An issue was opened here about adding CSS animation to JavaFX, so , I think I will wait for it - maybe in 5 - 10 years they will do it.


open orders change on portfoilo

Change Frozen Funds in open orders to Total Cost

Leave is Frozen Funds for now....need to speak with Joey first

Label Should be Total Cost (Eth)
The calculation for this is the same as escrowed eth in the old version


Tree construction with IQTree

IQTree is more or less the standard for building trees from viral genomes. A somewhat costly step that it does by default is to do full model testing to decide on the right model. Perhaps as per Rambaut et al. we might just settle on HKY85+G.


Follow-up work on ChatJson

Do not merge until the checklist is 100% done.

[x] Change extra field type to ChatJson
[x] Decode ChatJson encoded as a JSON string
[x] Decode ChatJson encoded as a JSON array
[x] Apply syntactic sugar if ChatJson can be encoded as a JSON string
[ ] Handle all fields
- [x] "text"
- [ ] "translate"
- [ ] "with"
- [ ] "score"
- [ ] "selector"
- [x] "extra"
- [x] "bold"
- [x] "italic"
- [x] "underlined"
- [x] "strikethrough"
- [x] "obfuscated"
- [x] "color"
- [x] "clickEvent"
- [x] "hoverEvent"
- [x] "insertion"
[x] Error on unknown field
[ ] Reject additional fields in "clickEvent" and "hoverEvent"

Removed “Apply syntactic sugar if ChatJson can be encoded as a JSON array” from the checklist, it seems this is not always decoded by Notchian.


How to get contacts profilePhoto?

I received all contacts by command getContacts. For each contact object I have profilePhoto and remoteFile objects. How to get profile image for each contact?

You can use downloadFile to download them.

@levlam I need to execute downloadFile for each contact or it can be done by one command for all contacts?

See documentation of the request.

@levlam Is it required to be signed in for loading images?

Defniitely.

If I have profilePhoto.id and remoteFile.id, is there any solution to get image using only App api_id and App api_hash?

No.

@levlam thanks.

@levlam I am looking into downloadFile Documentation and can't find where to sent remoteFile.id which I want to download, file_id parameter takes only int value, or I misunderstand something?

https://core.telegram.org/tdlib/docs/classtd_1_1td__api_1_1get_remote_file.html
https://core.telegram.org/tdlib/docs/classtd_1_1td__api_1_1file.html

@zelenin Thanks.


Allow Utils to be defined on ActionDispatch::Request on Rails 4.0.x

Somewhere in my Rails 4.0.13 application someone defined an empty Utils module on ActionDispatch::Request.
To test in the unit tests I was able to in test/helpers.rb modify the following:
module ActionDispatch
  module SharedRoutes
    def before_setup
      @routes = SharedTestRoutes
      super
    end
  end
  if ActionPack.version < Gem::Version.new('4.1')
    class Request < Rack::Request
      class Utils
      end
    end
  end
end

I can add the above no problem but it feels slightly over-bearing to assume Utils was defined on ActionDispatch::Request for all tests given ActionPack 4.0.  I can add it if anybody wants.  Or the other way was to create a new file.  I am open to work with whoever to write the appropriate unit test for this if required.

@austinrfnd who is defining that Ultils?

Closing since there is no response.


Can I use Bootstrap inside docz?

Question
I am wondering if I can I use Bootstrap inside docz.
Description
It is not my choice to use Bootstrap but the repo I will be working on is a legacy and I'm planning to use docz to provide a kind of UI Library hence I need to set the components using bootstrap.
I have tried to install directly bootstrap and try to add another css processor, currently just having css({preprocessor: 'less'}), but when running it seems that I am missing something with my transpiler or build process.

This was the first question I had to ask myself, as well, when I started using docz (10 minutes ago, hehe).
I came up with this super nasty workaround, basically, I'm using Helmet to inject the bootstrap CSS file. Seems to work OK for me:
---
name: MyComponent
---

import { Playground } from 'docz'
import { Helmet } from 'react-helmet'
import MyCompoennt from './MyComponent.js'

# MyComponent

## Basic usage

<Playground>
  <Helmet>
    <link
      rel="stylesheet"
      href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-alpha.6/css/bootstrap.min.css"
      integrity="sha384-rwoIResjU2yc3z8GV/NPeZWAv56rSmLldC3R/AZzGRnGxQQKnKkoFVhFQhNUwEyJ"
      crossOrigin="anonymous"
    />
  </Helmet>
  <MyComponent />
</Playground>

I guess I will create a <CustomPlayground> component now that does that all the time, so I don't have to import Helmet all the time in all my .mdx files.

Did you see Custom head tags introduced in 0.10.0?

@denisborovikov oh awesome! I didn't know about doczrc.js, yet. Seems like htmlContext is not yet documented in the official docs anywhere, right?

Move fast, break things. There're many things not documented yet.

Thanks so much @denisborovikov and @mbrochh. As suggested, using htmlContext  Bootstrap is up and running by just adding:
doczrc.js
 javascript
htmlContext: {
    head: {
      links: [{
        rel: 'stylesheet',
        href: 'https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-alpha.6/css/bootstrap.min.css'
      }]
    },
    body:{},
    footer: {
      scripts: [
        {
          src:'https://code.jquery.com/jquery-3.1.1.slim.min.js'
        },
        {
          src:'https://cdnjs.cloudflare.com/ajax/libs/tether/1.4.0/js/tether.min.js'
        },
        {
          src:'https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-alpha.6/js/bootstrap.min.js'
        }]
    }
  }

docz/dist/index.html
html
<!doctype html>
<html lang="{{ lang }}">
    <head>
        <meta charset="UTF-8">
        <link rel="stylesheet"<EMAIL_ADDRESS>        <link href="/static/css/vendors.3ab91c9bbd7c77a236e2.css" rel="stylesheet">
        {{ head }}
    </head>
    <body>
        <div id="root"/>
        {{ footer }}
        <script src="/static/js/runtime~app.3ab91c9bbd7c77a236e2.js"></script><script src="/static/js/vendors.86aa8b62.js"></script><script src="/static/js/app.d04063f9.js">
        </script>
    </body>
</html>

Thanks to help us @denisborovikov, I'll work this weekend to make this documentation and release the new version 🙏

I'm unable to get the htmlContext to work, am I missing something?
export default {
    themeConfig: {
        colors: {
            primary: '#8443b9',
            secondary: '#00b6a7',
            grey: '#ccc'
        }
    },
    htmlContext: {
        head: {
            links: [{
                rel: 'stylesheet',
                href: 'https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-alpha.6/css/bootstrap.min.css'
            }]
        }
    }
}


Use CMake interface to Drake when building external project

This change is

Thanks for picking this up btw, was going to find it difficult to catch time for it today.


Setup metrics.labs.cityindex.com loadbalancer

Setup a "load balancer" behind metrics.labs.cityindex.com; that sends 90% of the traffic to the "current" deployment, and 10% to the "release candidate" deployment.

IIS7 should be able to do this for us:  http://learn.iis.net/page.aspx/486/http-load-balancing-using-application-request-routing/

metrics.labs.cityindex.com domain is now setup
*.metrics.labs.cityindex.com -> metrics.labs.cityindex.com
 Pinging metrics.labs.cityindex.com [<IP_ADDRESS>] with 32 bytes of data:
 Pinging metrics.labs.cityindex.com [<IP_ADDRESS>] with 32 bytes of data:

IIS ARR load balancing is setup to round robin between current & next

Currently only one of these 2 is requesting authentication

It should work correctly now


syntastic: error: checker python/pylint: can't parse version string (abnormal termination?)

Having this error in vim:
syntastic: error: checker python/pylint: can't parse version string (abnormal termination?)
Didn't find solution in other ticket related.
Details:
Messages maintainer: Bram Moolenaar<EMAIL_ADDRESS>"sib.py" 26L, 1178C
syntastic: error: checker output:
This option u'required-attributes' will be removed in Pylint 2.0This option u'ignore-iface-meth
ods' will be removed in Pylint 2.0pylint 1.6.5,
astroid 1.4.9
Python 2.7.13 (default, Jan 19 2017, 14:48:08)
[GCC 6.3.0 20170118]
syntastic: error: checker python/pylint: can't parse version string (abnormal termination?)
syntastic: 28.960523: g:syntastic_version = '3.8.0-2 (Vim 800, Linux, GUI)'
syntastic: 28.960699: &shell = '/bin/bash', &shellcmdflag = '-c', &shellpipe = '2>&1| tee', &sh
ellquote = '', &shellredir = '>%s 2>&1', &shelltemp = 1, &shellxquote = '', &autochdir = 0, &sh
ellxescape = ''
syntastic: 28.961280: UpdateErrors: python
syntastic: 28.961564: CacheErrors: python
syntastic: 28.962192: g:syntastic_aggregate_errors = 0
syntastic: 28.962376: getcwd() = '/home/bree'
syntastic: 28.972093: system: command run in 0.009025s
syntastic: 28.972523: CacheErrors: Invoking checker: python/python
syntastic: 28.973282: SyntasticMake: called with options: {'errorformat': '%E%f:%l:%c: %m', 'ma
keprg': 'python /srv/tools/share/dotfiles/vim/bundle/syntastic/syntax_checkers/python/compile.p
y sib.py', 'env': {'TERM': 'dumb'}, 'returns': [0]}
syntastic: 29.005239: system: command run in 0.031536s
syntastic: 29.005729: getLocList: checker python/python returned 0
syntastic: 29.006005: getLocList: checker python/python run in 0.033338s

What's wrong?
Thanks

Please see #1950.  If that doesn't point you to a solution please run pylint --version in a terminal and post the output.

I tried to redirect it to dev/null. Now, no error on vim startup, but synsatix check is not working.
$ pylint --version This option u'required-attributes' will be removed in Pylint 2.0This option u'ignore-iface-methods' will be removed in Pylint 2.0pylint 1.6.5,  astroid 1.4.9 Python 2.7.13 (default, Jan 19 2017, 14:48:08)  [GCC 6.3.0 20170118]

I tried to redirect it to dev/null.

Then please consider reading again the post I mentioned.

The file I was working on was named "stat.py" and the name was the source of the issue:
$ pylint --version
Fatal Python error: init_import_size: Failed to import the site module
Python runtime state: initialized
Traceback (most recent call last):
  File "/home/snipesoft/.pyenv/versions/3.8.0/lib/python3.8/site.py", line 580, in <module>
    main()
  File "/home/snipesoft/.pyenv/versions/3.8.0/lib/python3.8/site.py", line 563, in main
    known_paths = venv(known_paths)
  File "/home/snipesoft/.pyenv/versions/3.8.0/lib/python3.8/site.py", line 468, in venv
    candidate_confs = [
  File "/home/snipesoft/.pyenv/versions/3.8.0/lib/python3.8/site.py", line 473, in <listcomp>
    if os.path.isfile(conffile)
  File "/home/snipesoft/.pyenv/versions/3.8.0/lib/python3.8/genericpath.py", line 33, in isfile
    return stat.S_ISREG(st.st_mode)
AttributeError: module 'stat' has no attribute 'S_ISREG'

The issue was gone after renaming the file to another name.


Can not get the sample programs to compile and run.

Hi.
I am trying to run the sample program CustomControlsSample and am getting 34 errors in CustomControlsSamples.csproj when I simply open the solution that are variations on:
Error	NU1106	Unable to satisfy conflicting requests for 'System.Diagnostics.Tools':
System.Diagnostics.Tools (>= 4.3.0) (via package/NETStandard.Library 1.6.1),
System.Diagnostics.Tools (>= 4.3.0) (via package/NETStandard.Library 1.6.1),
System.Diagnostics.Tools (>= 4.3.0) (via package/NETStandard.Library 1.6.1)
Framework: (.NETPortable,Version=v4.5,Profile=Profile111)
CustomControlsSamples	...
When I try to run the Droid version I get 83 errors - the original ones plus a number that are variations of:
"CS0234	The type or namespace name 'Forms' does not exist in the namespace 'Xamarin' (are you missing an assembly reference?)"
(There are different error messages as well, but I expect that if I get past some of these the rest will also go away.)
In the code I get red squiggly lines under : ContentPage with the message:
"The type or namespace 'Contentpage' could not be found (are you missing a using directive or an assembly reference?)"
And for InitializeComponent() I get
"The name InitializeComponent  does not exist in the current context.
I expect this works fine for most people. Any insight on how to make it work for me is appreciated.
I'm wondering if I have the wrong version of something, and if so how I would find it?
Thanks!

Hi @WillAutioItrax, I've pushed the latest edits, It should be working now. Or at least I hope so :'). Try again and please let me know. Are you working on Mac or Windows?

Hi @DottorPagliaccius , I am using VS2017 version 15.8.5 on Win 10 desktop.
I downloaded a new copy of the code with mixed results.
I did not get the "34 errors" mentioned earlier for just opening the project. Yay!
After building each of the Xamarin.CustomControls.* projects, I tried to run CustomControlSamples.Droid on an android tablet. I got the following errors:
1)
`Severity	Code	Description	Project	File	Line	Suppression State
Error		Error occurred while restoring NuGet packages: An item with the same key has already been added.

Severity	Code	Description	Project	File	Line	Suppression State
Error	NETSDK1004	Assets file 'C:\Users\will.autio\Documents...\src\CustomControlsSamples\obj\project.assets.json' not found.
Run a NuGet package restore to generate this file.
CustomControlsSamples	C:\Program Files\dotnet\sdk\2.1.402\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets	198

Severity	Code	Description	Project	File	Line	Suppression State
Error		The "ResolveLibraryProjectImports" task failed unexpectedly.
System.IO.FileNotFoundException: Could not load assembly 'CustomControlsSamples, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken='. Perhaps it doesn't exist in the Mono for Android profile?
File name: 'CustomControlsSamples.dll'
at Java.Interop.Tools.Cecil.DirectoryAssemblyResolver.Resolve(AssemblyNameReference reference, ReaderParameters parameters)
at Java.Interop.Tools.Cecil.DirectoryAssemblyResolver.Resolve(String fullName)
at Xamarin.Android.Tasks.ResolveLibraryProjectImports.Extract(DirectoryAssemblyResolver res, ICollection1 jars, ICollection1 resolvedResourceDirectories, ICollection1 resolvedAssetDirectories, ICollection1 resolvedEnvironments)
at Xamarin.Android.Tasks.ResolveLibraryProjectImports.Execute()
at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
at Microsoft.Build.BackEnd.TaskBuilder.d__26.MoveNext()	CustomControlsSamples.Droid

Severity	Code	Description	Project	File	Line	Suppression State
Error	CS0006	Metadata file 'C:\Users\will.autio\Documents...\src\CustomControlsSamples\bin\Debug\netstandard2.0\CustomControlsSamples.dll' could not be found	CustomControlsSamples.iOS	C:\Users\will.autio\Documents...\src\iOS\CSC	1	Active
`
Error 1) is new. The first time, I got the other 3 errors. In 2) I read "Run a NuGet package restore" so I tried that and when I ran it again, I got the errors you see before you now.
I think 3) and 4) are because CustomControlsSamples did not compile successfully. That leaves me with 1) and 2). Do you have any insight as to what is missing and how to fix it?
Thanks!
Will

What?? Somehow I clicked something that closed the issue. Sorry.
Oh - there are two buttons "Close and Comment" and "Comment". I hit the wrong one.

hi, any update on this issue. Even i am facing the same issue :(

@cjkarande You are on Windows too? Because on my Mac everything's fine, I tried on Windows and I'm having the same problems (more or less). So strange, it should work on either OS. I will do some checks and I'll let you know.

@DottorPagliaccius  Yes I am on Windows 10. Thanks in advance for your support.

@WillAutioItrax @cjkarande try now ;)

@DottorPagliaccius Awesome!! Works like a charm. Thanks for looking into this for us.

Glad to hear that ;)


Support for inheritance in views to save typing

Something like this seems like a good approach:
view :link do
  attribute :id
  attribute :name
  attribute :href
end

view :default, inherit: :link do
  # everything from :tiny view
  attribute :foo
  attribute :bar
end

view :extended, inherit: :default do
  # everything from :default view (and recursively :tiny view)
  attribute :tags
end

Then at least we only define an attribute once. (as long as views are incremental)

+1

Some consideration should be given to what happens if an attribute is defined that is already in the parent view. In that case, overriding the inherited parent's attribute definition makes sense to me.

Doing such a thing needs to handle circular references, and that's complex.
It is also not clear what the rules of priority of attribute definitions would be (especially if an attribute can be inherited 3 levels down, and overriden in a view from the middle...)
Anyway...I think that doing that is way to complicated and adds a bunch of unnecessary complexity for the gain.
doing exactly what you want is just as easy as:
      view :my_view do
        schema.attributes.keys.map{|k| attribute k }
      end

I think that's perfectly reasonable no?
If anything, we could see about adding some better named function to get the key names of the attributes of the media_type...to avoid doing schema.attributes.keys. But even then...it's just 3 chaned methods instead of only one...

I didn't know about schema.attributes.keys.map{|k| attribute k } and am perfectly happy to use that, so I'll take back my +1 :)

Wouldn't view :default, attributes: :all make sense as an option?

@gampleman if that's what you want, you can use the :master view. It's always created for any blueprint because it is needed for things like example generation. It's not documented just because it only has internal use (although, we could easily document that fact if it seems useful). Be careful though, as many complex mediatype relationships do have cyclical loops, so one has to be careful about the views you use for rendering embed sub-attributes that are mediatypes themselves.

We could support inherit as just sugar for copying the definition of an existing view.
But how relevant/useful is this with the recent field expansion changes?

Yeah I think we can close this issue.

yup, its DSL built on Ruby, so helpers for less typing can be easily built for apps/devs that want that feature. I'm closing it.
If there's any strong feelings about this please re-open it and discuss some of the specific use cases.


fix stream-db.deno test

This PR fixes the stream-db.deno test by making sure that all the write are performed sequentially.
I have found this when working on an implementation of add_row that had more than one await point. Awaiting the promises conccurently give no guarantees that the insert will be performed in order. This is fixed by awaiting each write.

I'm not sure what this test is supposed to test, but the root of the problem is that the test depends on Data.cursor() returning the entities in order of num. Maybe a better fix would be to use Data.cursor().sortBy("num")?

One way on another, we have to make ordering deterministic, both approaches fix the issue

Well, I don't think that we guarantee that Data.cursor() produces data in insertion order, so making sure that the ordering is deterministic by explicit sortBy() might be the more robust fix.

ok fair :)


[Bug] Enable ResourceQuota by adding Resources for the health-check init container

Why are these changes needed?
Flyte will create ResourceQuota for each Kubernetes namespace. To support ResourceQuota, each container in the namespace requires setting resource limits. However, the injected health-check init container does not specify the resource limits.
Why am I using the same resource configurations for the init container as those used in the Ray container?
In Kubernetes Pod, all init containers will be executed in a sequence, one by one, and each init container must complete successfully before the next one starts. On the other hands, when all init containers complete successfully, all application containers will start in parallel, and the startup order is arbitrary.
For example, we have 3 init containers and 3 application containers. The execution order will be:
init1 -> init2 -> init3 -> app1, app2, app3
The Pod's effective request/limit for a resource is the higher of:

the sum of all app containers request/limit for a resource
the effective init request/limit for a resource

Example: max(max(init1, init2, init3), sum(app1, app2, app3))
Hence, using the same resource configurations for the init container as those used in the Ray container will not waste resources.

Related issue number
Slack thread: https://ray-distributed.slack.com/archives/C02GFQ82JPM/p1681294121762329
Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[x] Unit tests
[x] Manual tests
[ ] This PR is not tested :(

# Step 0: Build the Docker image for this PR
# Step 1: Install the KubeRay operator with this new Docker image
helm install kuberay-operator kuberay/kuberay-operator --version 0.5.0 --set image.repository=controller,image.tag=latest

# Step 2: Create a namespace flyte and ResourceQuota.
kubectl create ns flyte
kubectl apply -f resource_quota.yaml

# resource_quota.yaml
apiVersion: v1
kind: List
items:
- apiVersion: v1
  kind: ResourceQuota
  metadata:
    name: project-quota
    namespace: flyte
  spec:
    hard:
      limits.cpu: "8"
      limits.memory: 3000Mi

# Step 3: Install a RayCluster with resource limit/request for both head & worker groups in the `flyte` namespace.
# => Expected behavior: Both head & worker Pods should be created successfully.
helm install raycluster kuberay/ray-cluster --version 0.5.1 -n flyte

If you use helm install kuberay-operator kuberay/kuberay-operator --version 0.5.0 in Step 1, only the head Pod will be created in Step 3.

@pingsutw would you mind testing this change with Flyte? Thanks!


Add Telegram notifications

Hello!
I'm very happy to suggest this feature to you!  🥳
I add a way to send notifications by Telegram and i have implemented it on each new controllable connection.
For exemple, there is a screenshot of my conversation with my bot:

Note: it's my first time with Go, thank you for being nice to me 🤓
I hope you like it 🌟😉

Hey @Suniron!
This looks awesome thanks!
I have been thinking about adding in generic webhook functionality for a now while and this is a great step towards that.
At the moment I wont be accepting this directly as its telegram specific. But if you rework this to be a generic webhook implementation so we can integrate RSSH with discord/slack/otherweb hook compatible platforms that'd be fantastic!
I see that telegram itself doesnt support incoming webhooks. So making the webhook implementation may not suite your workflow. But there are bots like this one https://github.com/defp/Telegram-incoming-webhooks, which would allow telegram to accept generic webhooks .

To make this a bit easier, if we support slack style webhooks we get both slack & discord for free.
https://api.slack.com/messaging/webhooks#getting_started
Unfortunately I dont think the project I've listed previously supports the slack format.

Hey @Suniron!
This looks awesome thanks! I have been thinking about adding in generic webhook functionality for a now while and this is a great step towards that.
At the moment I wont be accepting this directly as its telegram specific. But if you rework this to be a generic webhook implementation so we can integrate RSSH with discord/slack/otherweb hook compatible platforms that'd be fantastic!
I see that telegram itself doesnt support incoming webhooks. So making the webhook implementation may not suite your workflow. But there are bots like this one https://github.com/defp/Telegram-incoming-webhooks, which would allow telegram to accept generic webhooks .

No problem, i will keep my feature in my fork for my personnal usage 🤓.
I will try later to integrate Discord / Slack webhooks to begin. 🤞
Thank's for your answer and no worry for the rejection 😇

Hi @Suniron
Im about to be implement very simple webhooks in rssh, which will enable a user to specify a url that events get posted to.
Beyond a client leaving/joining, is there anything else you'd want?
Essentially, this feature will allow you to make companion applications that then pass the data on to telegram/discord.
E.g
Rssh -> "x connected" -> small ingestion application -> Telegram


[gui] The paths of classes in decompiled code are messed up

Issue details
The paths of classes in decompiled code are messed up.
Jadx version
1.5.0
Java version
11
OS

[ ] Windows
[ ] Linux
[X] macOS

Please elaborate what you want to express by your very brief description "The paths of classes in decompiled code are messed up."?
Please provide e.g. example decompiled code and highlight what problems you have identified.

No response - closing


Questions about access to system resources?

@dominicletz saw your video on this very nice work.   Some questions are below.

Is there a way to listen to UDP/TCP socks from this native app?   I have some services that broadcast to the system and I was wondering how the system blocks or allows this type of data connection.
Is there a way to access the microphone, or video camera of the device?  I have a system that takes phone calls.
How is video rendering within the application does the processor take a performance hit?  Can it play 4k streams?  Playing of audio?   Adjusting sound and so on?
How does mobile hand-off to wi-fi look when trying to connect outbound?

For updating -- you might want to take a look at the https://www.nerves-project.org/ which has a nice method to roll out updates.

Hi @chavenor thanks for having a look! On your questions:

Yes of course you can. All network features are available, even on the Android and iOS builds you got full access. In fact those even use TCP for internal communication between "native" and Elixir worlds already.
Haven't tried microphone or video camera, at least Erlang's wx library does not seem to support those, but you might try via browser features. The browser is always webkit based (even on windows) so you should have nearly feature equality.
Since we're rendering everything through a browser window it's basically as good as the OS can do here. Webkit video playback is generally hardware accelerated.
Mobile hand-off, does not exists inside the desktop-library because all communication is inside the device. It's all native with no external communication. If you're doing network communication in your own application you will have to deal with network disconnects there -- not sure this answers your question though?

Hope this helps
Cheers!


Server fails to compile on GCC 4.8.2

This is an error related to the templates, the templates might actually not be needed.

Didn't work


Clarify Frame::HostFunction

What problem does your feature solve?
The name here confuses me. I don't understand the intention. Based on the code, it looks like we are only using Frame::HostFunction as the initial frame when calling in via invoke_function (this behavior is fine). But the name suggests that we would push a Frame::HostFunction every time a host function is called, which we are not doing (this behavior is also fine). Perhaps we can come up with a name that indicates the actual usage?
What would you like to see?
A better name that indicates the actual usage.
What alternatives are there?
Leave the name as is, with some comments about what it actually means. I don't feel great about this though.

@jonjove will this need to be completed ahead of Meridian or can we de prioritize this work into a later iteration or just backlog it for now in now iteration?

Backlog it, it's purely about code quality and is not observable to users.

Not really sure what's the best action here.
I get the confusion but the Frame definition is purely internal so maybe we just leave it as is and add some documentation in the code. Also this is also fairly engrained with the InvokeHostFunctionOp (https://soroban.stellar.org/docs/getting-started/invoking-contracts-with-transactions#invokehostfunctionop) definitions, which means entering the Host environment via one specific host function with three possible actions (invoke contract /create contract/update wasm), which is the basis of the soroban transactions.
Given this is hard to change, and the benefit is heavily out-weighted by potential confusion and adaptation cost. I'll move this to post-testnet to add better code documentations in the host.

@jayz22  I noticed this again while working with the Frame type recently and agree with Jon's position that it's too easy to read this as meaning "any time a host function is invoked". I would like to propose changing it to  Frame::InitialInvokeHostFunctionOp or Frame::TopLevelInvokeHostFunctionOp or Frame::OutermostInvokeHostFunctionOp or something like that, for clarity.


Request/Response Fragmentation & Assembly

This fragments and reassembles frames for request/response.
There is one unit test failing related to cancellation that I haven't figured out yet. It's caused by the use of concat somehow.
Here is the unit test output showing multiple NEXT_COMPLETE frames for a large response:
CLIENT ==> Writes from client->server: Frame[0] => Stream ID: 0 Type: SETUP Payload:    Written from Thread[main,5,main]
SERVER <== Input from client->server: Frame[0] => Stream ID: 0 Type: SETUP Payload:    Read on Thread[RxNewThreadScheduler-1,5,main]
CLIENT ==> Writes from client->server: Frame[0] => Stream ID: 2 Type: REQUEST_RESPONSE Payload:    Written from Thread[Time-limited test,5,FailOnTimeoutGroup]
SERVER <== Input from client->server: Frame[0] => Stream ID: 2 Type: REQUEST_RESPONSE Payload:    Read on Thread[RxNewThreadScheduler-1,5,main]
needs fragments
SERVER ==> Writes from server->client: Frame[0] => Stream ID: 2 Type: NEXT_COMPLETE Payload: data: "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxy ...
CLIENT <== Input from server->client: Frame[0] => Stream ID: 2 Type: NEXT_COMPLETE Payload: data: "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz ...
SERVER ==> Writes from server->client: Frame[0] => Stream ID: 2 Type: NEXT_COMPLETE Payload: data: "ijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefg ...
SERVER ==> Writes from server->client: Frame[0] => Stream ID: 2 Type: NEXT_COMPLETE Payload: data: "qrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmno ...
CLIENT <== Input from server->client: Frame[0] => Stream ID: 2 Type: NEXT_COMPLETE Payload: data: "ijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefgh ...
SERVER ==> Writes from server->client: Frame[0] => Stream ID: 2 Type: NEXT_COMPLETE Payload: data: "yzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvw ...
CLIENT <== Input from server->client: Frame[0] => Stream ID: 2 Type: NEXT_COMPLETE Payload: data: "qrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnop ...
CLIENT <== Input from server->client: Frame[0] => Stream ID: 2 Type: NEXT_COMPLETE Payload: data: "yzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwx ...

(Note that unit test failure is expected)

Here is the performance hit by adding this logic:
BEFORE

Benchmark                                 Mode  Cnt        Score        Error  Units
ReactiveSocketPerf.requestResponseHello  thrpt    5  1586266.732 ± 195924.575  ops/s

AFTER

Benchmark                                 Mode  Cnt        Score        Error  Units
ReactiveSocketPerf.requestResponseHello  thrpt    5  2750088.796 ± 457478.484  ops/s

Related to implementation of https://github.com/ReactiveSocket/reactivesocket-java/issues/61

Closing in favor of rebased https://github.com/ReactiveSocket/reactivesocket-java/pull/63


Backup implementation for Ensembles

How do you scale a currently running ensemble from N clusters to N+1
cluster without losing data?

I had a ensemble running of 2 clusters (each with 1 master and 1
server)
I tried the following, but could not retain all the data (I had just 1
bucket):

1. Export backup of the bucket of both the servers.
2. Restart the servers using the update cluster.json files. So now I
have a ensemble of 3 cluster (the third cluster is also 1 master and 1
server)
3. Import the backup on both the servers.
4. When I try to GET all data, it shows 404 for some of the records.

I even tried cleaning the masters before joining the servers in the
new ensemble, but faced the same issue.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 10 Jun 2011 at 2:58

Hey Rohit,

the bug should be fixed on trunk.
To execute a backup export/import you need to:
1) Execute a bucket export on one server for every ensemble cluster: i.e., if
you have an ensemble with 2 clusters and 4 servers, just execute the export on
two servers (one per cluster).
2) Import all previously exported backups: Terrastore will take care of
properly routing the imported data even if ensemble has changed.

Any chances you can try it out?

Original comment by<EMAIL_ADDRESS>on 1 Jul 2011 at 4:29

Changed state: Started

Original comment by<EMAIL_ADDRESS>on 2 Jul 2011 at 3:45

Changed state: Fixed
Added labels: Type-Defect, Priority-High, Project-Terrastore, Milestone-0.8.2


meson fixes 2

I'm curious about this clock_gettime check. has_header_symbol will never fail and so the librt logic gets skipped. I assume it should probably be something like:
conf_data.set('HAVE_CLOCK_GETTIME', compiler.has_function('clock_gettime', args: defs))
if not conf_data.get('HAVE_CLOCK_GETTIME')
  rt = compiler.find_library('rt')
  clock_lib = rt
  conf_data.set('HAVE_CLOCK_GETTIME', compiler.has_function('clock_gettime', args: defs, dependencies: rt))
  if not conf_data.get('HAVE_CLOCK_GETTIME')
    threads = dependency(threads')
    conf_data.set('HAVE_CLOCK_GETTIME', compiler.has_function('clock_gettime', args: defs, dependencies: threads))
    clock_lib = threads
  endif
endif

https://github.com/Alexpux/mingw-w64/blob/master/mingw-w64-headers/crt/time.h#L273
I could just define _POSIX_THREAD_SAFE_FUNCTIONS directly.

_POSIX_THREAD_SAFE_FUNCTIONS should be defined by the headers.
In the repo linked above mingw-w64-headers/crt/unistd.h and mingw-w64-libraries/winpthreads/include/pthread.h both include pthread_unistd.h, which sets _POSIX_THREAD_SAFE_FUNCTIONS.  Guessing: perhaps #include <unistd.h> will help detect those definitions?

BTW, lighttpd already tries to detect and provide localtime_r() and gmtime_r():
https://github.com/lighttpd/lighttpd1.4/blob/master/src/sys-time.h
On newer OS releases, localtime() and gmtime() are generally supposed to be thread-safe and reentrant.
Also, lighttpd is primarily single-threaded, so this is among the less urgent things to sort out.  (I generally prefer to code with thread-safe and reentrant routines for future-proofing.)

Hmm? I don't see pthread_unistd.h defining _POSIX_THREAD_SAFE_FUNCTIONS. If not done in meson.build, it's not found.
Still, it's nice to have them available.

_POSIX_THREAD_SAFE_FUNCTIONS is defined in the former, not the latter
./mingw-w64-libraries/winpthreads/include/pthread_unistd.h
./mingw-w64-headers/crt/pthread_unistd.h
I have not traced what determines if the former is pulled in versus the latter.

As long as the header existence has already been checked before this point, why not check for header existence before trying to compile?
foreach f, h : functions
  if conf_data.get('HAVE_@0@'.format(h.underscorify().to_upper())
    conf_data.set('HAVE_@0@'.format(f.underscorify().to_upper()), compiler.has_function(f, prefix: '#include <@0@>'.format(h), args: defs))
  endif
endforeach

has_function will fail when header is missing.

added extra commit for muon compatibility.

Sorry for taking so long to get back to this.  If you no longer have time or inclination to work on this, I'm happy to commit parts of it.  Please let me know either way with a brief note.

I'm curious about this clock_gettime check. has_header_symbol will never fail and so the librt logic gets skipped. I assume it should probably be something like:
conf_data.set('HAVE_CLOCK_GETTIME', compiler.has_function('clock_gettime', args: defs))
if not conf_data.get('HAVE_CLOCK_GETTIME')
  rt = compiler.find_library('rt')
  clock_lib = rt
  conf_data.set('HAVE_CLOCK_GETTIME', compiler.has_function('clock_gettime', args: defs, dependencies: rt))
  if not conf_data.get('HAVE_CLOCK_GETTIME')
    threads = dependency(threads')
    conf_data.set('HAVE_CLOCK_GETTIME', compiler.has_function('clock_gettime', args: defs, dependencies: threads))
    clock_lib = threads
  endif
endif

I'll defer to your expertise here.  To test, I'd have to find an ancient Linux system with clock_gettime in -lrt instead of in libc (implied -lc).  Please go ahead and add this change to the PR.

Why is adding '-D_POSIX_C_SOURCE' needed?

I am unable to accept that change as-is since I know there are cases where it conflicts.  Is this needed specifically for mingw?  If so let's figure out a more constrained solution for mingw, or remove from this PR.

As long as the header existence has already been checked before this point, why not check for header existence before trying to compile? (untested:)
foreach f, h : functions
  if conf_data.get('HAVE_@0@'.format(h.underscorify().to_upper())
    conf_data.set('HAVE_@0@'.format(f.underscorify().to_upper()), compiler.has_function(f, prefix: '#include <@0@>'.format(h), args: defs))
  endif
endforeach

has_function will fail when header is missing.

My suggestion (theoretically) checks that the header was discovered by earlier checks, so would not run has_function if the required header does not exist.  If that works, then the same code can be used for gmtime_r, localtime_r, and clock_gettime.
Side note: please sort functions
Separately, I plan to remove xgetopt.c since it is not present in the source code and because I have provided a local win32 getopt implementation in lighttpd.

Aha!  It appears that you added https://github.com/lighttpd/lighttpd1.4/pull/120/commits/c36b9016688b0e489ea4f10e1ad48eb1731a1502 with -DPOSIX_C_SOURCE for the inline functions gmtime_r and localtime_r in mingw.
...I guess that also highlights a blind spot in the other function checks.  Were those other functions to be implemented as inline functions, then such functions would not be found in the library, but rather only in the header, and so would not be detected when the function is actually present, but not as a symbol in the tested library.

Come to think of it, would it be better if all the tests were compiler.has_header_symbol() for symbols likely to be in libc, and then compiler.has_function() could be used only for those symbols for which a different library might need to be specified, e.g. -lrt ?

I just traced through headers in mingw.  lighttpd src/sys-time.h https://github.com/lighttpd/lighttpd1.4/blob/master/src/sys-time.h redirects gmtime_r() and localtime_r() when _WIN32 is defined, and _WIN32 is defined under mingw.  Therefore, https://github.com/lighttpd/lighttpd1.4/pull/120/commits/c36b9016688b0e489ea4f10e1ad48eb1731a1502 is not necessary and can be removed from this PR.

Some more history on _POSIX_THREAD_SAFE_FUNCTIONS from the mingw-w64-public mailing list:
2014:
https://sourceforge.net/p/mingw-w64/mailman/mingw-w64-public/thread/CAOYw7dtTTRrR0asBjVxVRfivqmHBmi2cAZ4TajREgRQvYxBXLA%40mail.gmail.com/
2019:
https://sourceforge.net/p/mingw-w64/mailman/mingw-w64-public/thread/fc80aa9e-012c-db28-f7a3-e424b6cd4540%40codeweavers.com/

Please review the changes I pushed to the head of https://git.lighttpd.net/lighttpd/lighttpd1.4/src/branch/personal/gstrauss/master
I use compiler.has_header_symbol() in the loop over functions.
I sorted functions and retained compiler.has_function() for clock_gettime, removing the cygwin-specific code.

FYI: I took another look through mingw headers and _POSIX_THREAD_SAFE_FUNCTIONS is used in a small number of places to protect #define of functions (e.g. gmtime_r()) to win32 approximations (e.g. gmtime_s()).  This is not needed in lighttpd, but if you wanted to extrapolate to other packages, then defining _POSIX_THREAD_SAFE_FUNCTIONS on mingw builds appears to be a more precise solution than defining _POSIX_C_SOURCE.

Thank you, @neheb!
Patches have been accepted and pushed to lighttpd master branch.


USBD event handling rework

USB device stack - power state tracking.
In a real life application with USB device stack, we need to keep track of power state. if the cable is connected or not and if the bus is suspended or active. I see it as a fundamental feature, so it could be embedded in USBD to simplify application.
Currently, USBD acts as a proxy passing driver events to the class implementation and the only way knowing the bus state in application is to use class callback - classes forward the event from driver. To make things worse, we will get multiplied events (i.e. "suspended") when using a multiple classes/instances (composite device).
Power / bus events are related to the stack itself and IMO should not be coming from class.
This is how see it:
A main dispatcher in usb_device.c (just like the one for composite device) which will forward driver events to every class instance + application callback (only necessary events, like cable connect/disconnect, etc.).
Classes would pass only related events in a callback, i.e. HID events.
In such case - do we still need to split implementation info composite and non-composite device?
I would prefer to avoid #ifdef CONFIG_COMPOSITE_DEVICE everywhere.
Please let me know what you think.

In such case - do we still need to split implementation info composite and non-composite device?
I would prefer to avoid #ifdef CONFIG_COMPOSITE_DEVICE everywhere.

No, this should go away.
I started working on it, but I do not have time to finish it. @aurel32 has opened a PR that goes in this direction https://github.com/zephyrproject-rtos/zephyr/pull/11041

Closed by #20375


Add a bot approval workflow

In some of our Paketo Buildpacks that consume automation from https://github.com/paketo-buildpacks/github-config, we have implemented a workflow to auto-approve and auto-merge our PRs opened by bots (Dependabot / Paketo Bot). This reduces overhead for maintainers, since our tests should catch any errors that get introduced.
It would be great if the UPX buildpack, and others in the Utilities grouping had this automation. It may be even better to create automation for these buildpacks in paketo-buildpacks/github-config so we can reduce the number of places we have to make changes.
@dmikusa-pivotal is there any reason against doing this?

To this point, the Java buildpacks team has taken the approach of not auto approving anything. Instead, we have a tool that we use to bulk merge PRs across repos. It's similar but it allows us to have a human review/confirm before merging anything.
What types of PRs would this merge automatically? Do you have specific examples? Also, what's required for this to work? I'm guessing we'll need an added workflow, which requires changes to pipeline-builder. Is there anything else we'd need to change? Do we need to modify project permissions?
Thanks

@dmikusa-pivotal I wasn't aware of this tool, I can check it out. It might be helpful for the @paketo-buildpacks/utilities-maintainers to familiarize themselves with it.
Our automation auto approves any PRs that are opened by Paketo Bot or Dependabot and also pass a set of tests. For example, in our implementation buildpacks the approve-bot-pr.yml runs whenever a workflow called "Test Pull Request" successfully completes. It downloads the PR payload (we uploaded it during Test Pull Request), and then check the author, commit verification, and if any human committers added onto the PR. If all the conditions are met, we approve the PR. We also have the auto-merge workflow, which runs once there is a PR review, and will just merge in the PR.
You can see an example of what this looks like in the checks associated with this PR, and it's associated bot approval workflow.
I guess what will be required here is that we will need to add the related workflows. I'm not aware of the pipeline builder, so I'm not sure what else would need to happen.

In general, all of our non-java implementation buildpacks and language family buildpacks share a common set of workflows and actions defined in github-config. Since the Java buildpacks do something separate, it might not be worthwhile to move all of these buildpacks over to a different standard. When I filed this issue, I wasn't aware of the tool you mentioned and was looking for a way to reduce overhead for maintainers/make it a more cohesive experience with the other buildpacks we maintain.

@dmikusa-pivotal I wasn't aware of this tool, I can check it out. It might be helpful for the

I can demo the tool, if it would be helpful. I put this tool together when I started working on buildpacks cause previously we were merging things manually, which was time-consuming. Feedback on the instructions/tools would be welcome.

You can see an example of what this looks like in the checks associated with this PR, and it's associated bot approval workflow.

One thing that worries me about auto-merge capabilities is that we don't have the same test design. There are no integration tests, where you'd actually pack build something, with any of the Java/utilities buildpacks. Instead, we have taken the approach of leaning on our unit tests as much as possible. We make use of mocks to test some integration scenarios and we do the occasional bit of manual integration testing (depending on what is being changed/merged). The net benefit is that our tests are lightweight and run very quickly. The downside is that there's occasionally some manual testing required, which gives me concern with auto merging PRs.

I'm not aware of the pipeline builder, so I'm not sure what else would need to happen.

All of the workflows for Java/Utilities buildpacks are auto-generated by the pipeline-builder. There's an update-pipeline.yml workflow that runs and will submit PRs that keep everything in sync. To make a change to a workflow, you have to update the pipeline-builder. Then all of the buildpacks will pick up the change automatically (they'll get PRs submitted). What we'd have to be careful of is that if you try to change stuff manually, you end up in a fight with pipeline-builder where it tries to overwrite your changes. If we did want to go forward with changes, we'd probably want to PR those into pipeline-builder.

In general, all of our non-Java implementation buildpacks and language family buildpacks share a common set of workflows and actions defined in github-config. Since the Java buildpacks do something separate, it might not be worthwhile to move all of these buildpacks over to a different standard.

I think my vote would be to hold off on auto merging. The tool we have for batch merging makes things pretty quick, so while auto-merging stuff would be faster, I think there would be less of a time savings than if we were going from manual merge to auto-merging. Plus there are the concerns above, regarding manual testing that we'd need to address or at least workaround (like my auto merging a smaller subset of PRs).
I'm open to other opinions though. If someone feels strongly and wants to put in the work to add in auto-merging.

@dmikusa-pivotal your concerns are valid here, I was missing some context around the Java/Utilities buildpacks testing strategy, as well as the pipeline-builder information that you shared. I think I agree at this point that we should hold off as well, it just doesn't make sense to shoehorn these buildpacks into that pattern when it doesn't really fit. I would love to get a demo of that tool at some point, I will set up some time! Closing this issue out for now.


Can you license this under an open source license?

Or rather, can I use this with attribution?

I added LICENSE.txt to the repository.
https://github.com/keijiro/GaussianBlur/commit/4a5dec9a6ccb53b3e7449765af48dd895a31baa7


Adding automerging for konflux prs that update tekton

Potential problem: https://issues.redhat.com/browse/KFLUXBUGS-1886

We should not face the linked issue here in GH w/ ci-operator per my understanding. Feel free to merge
/lgtm

/retest-required


Not all CameraAttributesPhysical or CameraAttributesPractical resource properties emit the 'Changed' signal

Tested versions
Reproducible in: 4.3.stable and 4.4.dev3.
System information
Arch Linux - Godot v4.3.stable
Issue description
Connecting the changed signal from a resource that inherits from CameraAttribute, i.e CameraAttributePhysical and CameraAttributePractical, only gets emitted when changing CameraAttributes specific properties.
E.g. exposure_sensitivity and auto_exposure_enabled will emit the changed signal, whereas changing properties like frustum_far (CameraAttributesPhysical) or dof_blur_amount (CameraAttributesPractical) do not.
Expected all resource properties to emit the changed signal.
Steps to reproduce

Add a Camera3D to a scene
Apply either a CameraAttributesPhysical or CameraAttributesPractical resource to the Camera3D's Attribute property
Add a script and function that connects the changed signal of Camera3D's Attributes property that outputs something
Run the scene and change Attributes values
Observe that only properties defined in the base CameraAttribute resource emit the changed signal

Sample script
extends Node3D

@onready var camera: Camera3D = %Camera3D

func _ready() -> void:
	if camera.attributes:
		if not camera.attributes.changed.is_connected(_attributes_changed):
			camera.attributes.changed.connect(_attributes_changed)

func _attributes_changed() -> void:
	print("Changing Camera Attributes")

Minimal reproduction project (MRP)
camera-attributes-changed-signal.zip

Can't confirm in latest master [1bffd6c73b44b85e5889f54e14b2193940cf5bb1] it works for the properties tested, please add some code to trigger these changes to help making the exact issue clear as I cannot replicate it

Have attached a video showcasing the issue with the MRP above.
Beyond this, I am not sure what else I can share that isn't already in the original post with the script sample?
0:00 to 0:31 is where the changed signal gets emitted just fine when modifying the exposure and auto_exposure properties.
0:31, and onwards, is where the non-exposure properties are changed, which do not emit the signal and where the issue lies.
https://github.com/user-attachments/assets/32a7ba36-ec79-4565-82ca-5a509eb40373

With clearer reproduction steps I can indeed reproduce this


Revert "Revert "Jvenstad/fix node repo cache""

Reverts vespa-engine/vespa#7953
Wrongly accused, sorry :(

Already reverted in https://github.com/vespa-engine/vespa/pull/7954

No worries :)


Not working with Flutter Version 3.22 in release mode.

It seems to be working fine for me. Can you provide more details or a minimal repo with repro steps?

Android only. make sure to run with --release flag.
Flutter: 3.22.2


fix(boilerplate): remove GestureHandlerRootView

Please verify the following:

[ ] yarn test jest tests pass with new tests, if relevant
[ ] yarn lint eslint checks pass with new code, if relevant
[ ] yarn format:check prettier checks pass with new code, if relevant
[ ] README.md (or relevant documentation) has been updated with your changes

Describe your PR

Removes unnecessary <GestureHandlerRootView /> from app.tsx
This wrapper is only necessary if specifically using the Gesture Handler API (which the demo application does not)
Coached by @satya164 in this Twitter thread

:tada: This PR is included in version 9.8.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat: autocomplete suggestion

Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
[x] Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
[x] Check the commit's or even all commits' message styles matches our requested structure.
[x] Check your code additions will fail neither code linting checks nor unit test.
[x] I have added necessary documentation (if appropriate)

Linked Issues
Fixes
Description

Please describe your pull request.
❤Thank you!
Post merge checklist

[x] Follow steps from the guidelines for contributing to this repository.
[x] If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

@120EE0692 please resolve conflicts

There are formatting issues flagged in the checks.

@rutajdash it seems to be something else

There are formatting issues flagged in the checks.

@rutajdash it seems to be something else

Check the prettier output stage. The script fails when it finds formatting errors.

There may be more files

There may be more files

@rutajdash no formatting issue.


Added filtering and sorting feature for files

Description
Added filtering and sorting features for the files. Changes had to be made to both frontend and the backend. Previously
(already available) search filter was implemented on the frontend not the backend. So it was inefficient because all files had to be fetched and then filtered according to the searched text on frontend.
Now all sorting and filtering is done on the backend and and filtered files sent to client.
This is what implementation looks like

I made changes to only about 5 files but after merging the upstream/main into my branch, it is now showing 17 files changed. Does this make it difficult for you to review the changes.
Please review and let me know if you want more change
Fixes #3
Fixes #4
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Hey @anomic30 please review my changes and let me know if they are good enough to be merged? I'll then resolve the conflicts.

Hi @ozair-dev, can you please resolve the conflicts and raise a PR again?

@anomic30 do I really have to raise another PR? Can't I just commit to this already made PR?

@ozair-dev
Yes, I am closing this PR as of now.


Add Rocky Linux 9 RC1 test reports

VirtualBox 6.1 (Windows 7 64-bit), UEFI without Secure Boot;
Workstation 15.5 Player (Windows 7 64-bit), UEFI with Secure Boot;
Hyper-V 10 (Windows 10 64-bit), UEFI with Secure Boot.

Thank you for the contribution, also looks good to me!


METRON-254 pcap inspector emits fields that are named based on the enum, rather than the standardized field names

PcapInspector utility prints field names that are enum names (i.e. SRC_ADDR) as opposed to the standard field names (ip_src_addr)
Check this by running some pcap data through (follow steps 1-7 from https://github.com/apache/incubator-metron/pull/156)

+1

+1 Looks solid


Add BGV-like modulus switching support to BFV

Currently, HPSPOVERQLEVELED automatically drops extra RNS limbs inside homomorphic multiplication and key switching, but the full ciphertext modulus is used for all operations. Also, modulus switching is supported at the very end (before decryption).
We want to add an ability to do modulus switching even when more computations need to be performed. Moreover, we want to support encoding of plaintexts at a specific level (similar to how it works in BGV).

A summary of the BFV operations that have been changed:

Added support for encoding at a desired level
Added support for encryption from reduced plaintext (some precomputed parameters were extended to a vector)
Fixed decryption to support the scenarios with intermediate leveles
Fixed compression to leave more than 1 RNS limb after compression


Firebase Cloud Message sending, runs in a thread, initiated from ActivityPostSave

Runs the cloud notification in a thread, so that the call to ActivityPostSave is not slowed down by the extra work.
This uses the Python version of the Java threads API, but CPython is inherently single threaded -- it runs only one
thread at a time, and switches execution between threads to simulate simultaneous execution.  CPython does not provide the concurrent threading that you get in Java or C, where threads can be started up to run concurrently on other processor cores, but it does allow activity_post_save_view(request) to return quickly (in about 70ms on a MacBookPro), and then runs the thread (as currently loaded down with lots of temporary logging) in about 300ms for a single fcm notification send.
(As an experiment I ran firebase_notification_send_to_cordova_apps 20 times in a loop within the thread and the time to execute activity_post_save_view was unchanged, but the thread took about 2 seconds to complete.)
So with our load balancing setup, a Django instance would be tied up for an average of about 70ms for the ActivityPostSave execution, and would continue to be further tied up with the 300ms for the "notification send" thread to run to completion.
This eliminates the need to batch process the notifications.

Partially addresses wevote/WeVoteServer/issues/1450
Still needs some testing when this makes it to the live server.

👍


Plots with wcsaxes

Channel maps and simple map example plots with wcsaxes and symlog scaling. Also using gold-purple colorbar which is more colorblind-friendly - should we generalise?

By generalise you mean change all plots to this scheme? I would keep them as they are, as these colours were used in actual publications. You can add a comment about colour-blindness in the readme above your plot, so that people are aware of this detail.

By generalise you mean change all plots to this scheme? I would keep them as they are, as these colours were used in actual publications. You can add a comment about colour-blindness in the readme above your plot, so that people are aware of this detail.

 I got mixed up there, I just thought having a general parameter for colorbar/colors for all plots would be nice. But this is out of scope of interferopy since the plotting are not core functionalities but examples.

 I got mixed up there, I just thought having a general parameter for colorbar/colors for all plots would be nice. But this is out of scope of interferopy since the plotting are not core functionalities but examples.


Improve TypeScript rules to enforce unchecked indexes check

Related to #1469
This PR introduces an initial set of enhancements aimed at improving the maintainability of the front-end codebase.
Changes:

Enabled the noUncheckedIndexedAccess rule to enforce stricter type safety when accessing values by index.
Configured typescript-eslint and enabled a rule to block non-null assertions, promoting safer handling of nullable values.
Addressed existing TypeScript errors and resolved no-non-null-assertion violations resulting from the above changes.

Benefits:
These updates improve the application’s stability by encouraging proper handling of nullable states and reducing the risk of crashes during refactoring.
Note:
In scenarios where handling empty states adds unnecessary complexity, non-null assertions can still be used. For such cases, the ESLint rule can be disabled selectively for specific lines to balance safety and simplicity.

you love to see it


[AutoPR imagebuilder/resource-manager] Add private preview API for Azure Image Builder

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5055

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/4174


Enhancement of FX vanilla option product, trade and pricers

This work closes #816

Closed by #882


fixed a typo

@anoj-9771 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good; thanks @anoj-9771.


Frontend Test Failing

CI started failing on the frontend test a couple of days ago. It corresponds with this change on the rustdoc side: the character "⎘" was added after item names in the headers, allowing users to copy the item's relevant use path.
Cool change, it just breaks the doc UI test. No actual attribute code needs to be changed. An easy fix would be to use something like substring to just grab the first n characters and match those.
No release should be necessary to resolve this.

The issue is resolved now. Tests once again pass :)


Type narrowing is not allowed if variable is reassigned after the use site inside if block

Current implementation is very conservative when looking for assignments during application of type narrowing.
function len(x: number | string) {
	 if (typeof x === 'number') {
		 var t = x.toExponential();
		 //x = "aaaa"; // uncomment me
	 }
}

variable is reassigned after the usage of narrowed type but type narrowing still not kicked in

We'd have to do flow analysis to properly reason about this. That might be worthwhile (and would allow us to detect unreachable code, unassigned variables, etc. as well), but we need to consider the impact on complexity and performance.

btw, there is already a PR for control flow analysis: #1287

Control flow looks really nice :+1:

So what is the proposal?

I've opened a PR #6959 that will fix this.

I think that this can be closed, #8010