Auto playing the next song

Is your feature request related to a problem? Please describe.
The current song is played on loop.
Describe the solution you'd like
It would be great if it skips to the next song once completion of the current song and adding a additional feature for playing a song on loop.

@Satyam1923 I would like to work on this issue under GSsoC'24

@rahulpoonia29 as you have raised this issue currently under index.ejs at audio tag we already have autoPlay tag included.
So i want you to edit script.js and add code to have a loop feature with three click implement

autoplay current song
loop  around
autoplay off
You can add button for it and take icons reference from hugeicons
also,
add shuffle button along with it
if you can then let me know

@Satyam1923 Sure, I'll be happy to work on the issue.

👋 Hello! I'd be happy to help with this issue. Could you please assign it to me? Thank you! 🚀

@IP80808080 fine


adds hint to checkout submodules

Thanks for your pr! The only thing I'm not sure about is that this sets the nightly override for the directory above the nebulet directory when we want the override just on the nebulet folder.

Awesome, lgtm!


Implement add_alternate_id operation for purchase order store

Implement sqlite and postgres implementations

This story is out-of-date and no longer relevant.


Option to enable/disable endpoint error handling in C++ benchmark

Add option to allow enabling/disabling endpoint error handling in C++ benchmark, switching the default to disable matching ucx_perftest.

Is the flag setting the wrong way round?

You're right, thanks for catching. Changes are applied now. 😄

Thanks for reviewing/approving @wence- !

/merge


How to keep track of number of running threads?

In may be a request for enhancement rather than an issue, but , is there a way to keep track of number of active threads at each time?
X= thpool->num_threads_working; gives me the following error:
Myprog.c:872:40: error: dereferencing pointer to incomplete type ‘struct thpool_’
X=thpool->num_threads_working;
Thanks,

I had a look at this and with commit #48ae25d35a83febdff1b921acc5e41c71a60fda7 you should be able and do that now. However you need to follow the API.
In your case:
X=thpool_num_threads_working(thpool);

You can also have a look on the tests here.

Thanks for the quick enhancement!  That worked great.


Test Framework quit unexpectedly

I can't run my code due to this error:

also please put up a detailed guide on how to use it since i cant create a configuration for the generated file in cmakelists

Are you able to run g++ from a regular terminal? I think this could be the issue.
If you are using clang change build command for c++ in Settings / Preferences > AutoCp basically change g++ to clang++

i cant create a configuration for the generated file in cmakelists

I don't know what u mean by that. to create a configuration try

Right-click generated file > Run 'Your File' or
Right-click generated file > More Run/Debug > Run 'Your File'

I will try to change this to more appropriate like Run 'Your File' with AutoCp or something like that in the next update

also please put up a detailed guide on how to use it

I will try my best to write articles as soon as I got some important features ready for this plugin

Hi, thanks for the quick reply.
I fixed the problem of the testing framework quitting, it was due to my newer mingw installation which i forgot to add to PATH.
However, now the plugin just gives me wrong answer on an accepted solution. Is this a known bug or am i missing something?
Also, by creating a run configuration i meant that adding the file to cmakelists.txt using the add single file for execution plugin doesn't work since it always contains a whitespace, so if I want to run the code locally do i need to create another file and use it?
Thanks

However, now the plugin just gives me a wrong answer on an accepted solution. Is this a known bug or am i missing something?
Yes, It is a bug fixed it just now, will release it soon along with other changes.

Also, by creating a run configuration i meant that adding the file to cmakelists.txt using the add single file for execution plugin doesn't work since it always contains a whitespace, so if I want to run the code locally do i need to create another file and use it?

remove or change whitespaces to something else for now.  u won't need additional files for running the code.

Ah thanks!
Great plugin just needs some polishing :)


Implement two-line and three-line text lists

See list specs.
We don't have two or three-line lists implemented over on the Polymer side just yet, but do in Angular. It would be nice to have vanilla versions implemented too.
Three line:

In a three-line list, each tile contains a maximum of three lines of text.

Two line:

In a two-line list, each tile contains a maximum of two lines of text. The amount of text can vary between tiles within the same list.

Note: Component does not include the cyan bar at the top. That is just for example purposes.
We do have one list variation in material-sprint branch at the moment, which could be useful to use as a base.

Closing. WSK will only focus on the boilerplate side of things. We'll tackle this upstream in material lite.


Test asynchronous dynamic imported components

How can I test components that look like following:
class MyComponent extends React.Component {
  constructor() {
    this.state = {
      imported: false;
    }
  }

  render() {
    if (someCondition && !this.state.imported) {
      this.loadComponent();
    }
    return (

Hello world

        {this.otherComponent}

    )
  }

  async loadComponent() {
    this.otherComponent = await import('./OtherComponent');
    this.setState({ imported: true });
  }
}

I am aware of the issue #346 (Testing Async Components) but this doesn't help much because I don't use any library that I could mock. I use import() explicitly here because I want to load a really heavy React component only under some circumstances.

You'd want to make sure you're using a babel transform in tests that makes import() work in node.
Then:
const wrapper = shallow(<MyComponent />);
return wrapper.instance().loadComponent().then(() => {
  wrapper.update();
  // assertions
});

Thank you. It does work in my case. It's not sooo beautiful because the test knows about the internal privat implementation (.loadComponent()) and in TypeScript I have to make it public (it was private in my project) but it seems that this is the best solution.
👍


Add a custom allocator for TAs

There are some functions that deal with dynamic allocation on TAs. Although the available memory is determined at compilation time using ta headers. Those functions are enough for implementing a custom allocator for rust TAs.

yes. I created this issue just for tracking what you did earlier..Would be nice to start moving things to dev.


Getting Selector fails with: TypeError: (0 , _exportableLib2.default) is not a function

Are you requesting a feature or reporting a bug?
Bug
What is the current behavior?
Trying to get a Selector is raising a TypeError
What is the expected behavior?
It should get the Selector.
How would you reproduce the current behavior (if this is a bug)?
Every time I run the test. I see the page loading okay, so it's nothing in my codebase, I don't think.
Provide the test code and the tested page URL (if applicable)
Tested page URL:
Test code
import Selector from 'testcafe';

fixture `Landing`
  .page `http://localhost:3000`
;

test('Landing on the homepage', async t => {
  const headerText = await Selector('.Header').textContent;
  await t
    .expect(headerText).eql('Disordered Personality')
  ;
});

Specify your

operating system: Ubuntu 18.04
testcafe version: 0.20.3
node.js version: v8.11.3

Hi @biot023
Change your code as follows:
import { Selector } from 'testcafe';

fixture `Landing`
  .page `http://localhost:3000`
;

test('Landing on the homepage', async t => {
  const headerText = await Selector('.Header').textContent;
  await t
    .expect(headerText).eql('Disordered Personality')
  ;
});

Oh, good grief! Thanks @miherlosev !
I've not done any JS programming for a month or so -- my apologies!


Adds DartPad option to the DartDoc snippet generator.

Description
Updates the snippet generation tool in /dev/snippets with a new flag, --dartpad. If the flag is present, the HTML output generated by the tool for use at api.flutter.dev will embed a DartPad iframe to show its application-style sample code.
As part of this change, the snippet tool tag for the AppBar class has been updated to use the new flag. Once it's verified as working, the flag can be added to other widgets' snippets as desired.
q.v. https://github.com/dart-lang/dart-pad/pull/1238 (change to DartPad itself that adds the loading of sample code from api.flutter.dev)
Related Issues
https://github.com/dart-lang/dart-pad/issues/1222
Tests
I added the following tests:

Two new tests in configuration_test to verify that the right HTML skeleton file is chosen based on the type parameter and dartpad flag.
An additional test in snippet_test to verify that the generate method in SnippetGenerator properly generates HTML output with DartPad.
Updates to existing tests as necessary to match function signature changes.

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
[x] No, this is not a breaking change.

@gspencergoog PTAL when you get the chance.

PTAL


fix dublicate export LinearGradient class

Hi react-native-comunity team.
I just fixed duplicate export LinearGradient class.
Please check and merge it
Thanks

There aren't duplicate exports. One is named export and other one default export. Check my PR for correct fix: https://github.com/react-native-community/react-native-linear-gradient/pull/357

superseded by #357


feat: add hotkey access for searchbar

Notes for Reviewers
This PR adds feature #66

Hotkeys: ctrl + k or ⌘ + k (Mac)
The root html file has been modified.
Hotkey focus preference is given to the Header search bar.
styles added in the root html.

Footnote:
Followed the README.md to run the dev server I noticed there's an issue arise with the make docker command due to an undefined rule in the Makefile.
Signed commits

[x] Yes, I signed my commits.

Only / is needed as the shortcut key.

Made changes.

Hey @phukon  Let's discuss this on website call tomorrow at 6:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.

The only hotkey that we're seeking to add here is that of /. You can remove any code pertaining to ctl and k

Squashed commits and rebased my current branch.
Changed variable names for clarity.

@leecalcote  The commit history was getting messy. Hence discarded the 4 redundant commits. Will make a new PR now.

'hotkey func' given it's own partial and now lives in the footer

@phukon are you in the community Slack?

@phukon are you in the community Slack?

thanks for the heads up.. I just joined.


Fix for #85. Static resource when run in Tomcat (or other app server)

Fix for #85
Please review this fix before I'll merge it.

I'm using spark with tomcat8.
staticFileLocation("/public")

seemed to work.
But there is a problem, all the files are served with content type "text/plain".
So when including CSS files with absolute path
<link rel="stylesheet" href="/example.css"/>

it will work and be used in FireFox and Chrome. But Chrome throws an error that it must be "text/css". And Internet-Explorer (even the newest Edgte-Version) does also so, and is even not loading the CSS!
See SEC7113: "SEC7113 - CSS was ignored due to mime type mismatch"
https://msdn.microsoft.com/en-us/library/hh180764(v=vs.85).aspx
Is there already a way to activate/configure Content-Types/MIME for static files... ?


verify job is taking >15 min

What would you like to be cleaned:
Verify is taking too long
https://testgrid.k8s.io/sig-scheduling#pull-kueue-verify-main&width=20
Would increasing the number of CPUs help? Otherwise, what is being particularly slow?
Why is this needed:
This adds more time to the release process.

@Vandit1604 is this something you would be interested in invesitgating?

Helpful Dashboard: https://monitoring-eks.prow.k8s.io/d/96Q8oOOZk/builds?orgId=1&from=now-7d&to=now&var-org=kubernetes-sigs&var-repo=kueue&var-job=pull-kueue-test-integration-main&var-build=All&refresh=30s

@Vandit1604 please write /assign in a comment

/assign
I'll take a look at this

The delay is because of shell-lint rule. I updated it taking https://github.com/kubernetes/kubernetes/blob/0a31504ee114e363df9d69158c2e639858b8273b/hack/verify-shellcheck.sh as reference.
Here is the diff with the changes
diff --git a/hack/verify-shellcheck.sh b/hack/verify-shellcheck.sh
index c566f772..b4850dbf 100755
--- a/hack/verify-shellcheck.sh
+++ b/hack/verify-shellcheck.sh
@@ -17,11 +17,44 @@
 # allow overriding docker cli, which should work fine for this script
 DOCKER="${DOCKER:-docker}"

+
 SHELLCHECK_VERSION="0.9.0"
 SHELLCHECK_IMAGE="docker.io/koalaman/shellcheck-alpine:v0.9.0@sha256:e19ed93c22423970d56568e171b4512c9244fc75dd9114045016b4a0073ac4b7"

+# common arguments we'll pass to shellcheck
+SHELLCHECK_OPTIONS=(
+  # allow following sourced files that are not specified in the command,
+  # we need this because we specify one file at a time in order to trivially
+  # detect which files are failing
+  "--external-sources"
+  # include our disabled lints
+  "--exclude=${SHELLCHECK_DISABLED}"
+  # set colorized output
+  "--color=${SHELLCHECK_COLORIZED_OUTPUT}"
+)
+
 # Currently disabled these errors will take care of them later
-DISABLED_ERRORS="SC2002,SC3028,SC3054,SC3014,SC3040,SC3046,SC3030,SC3010,SC3037,SC3045,SC3006,SC3018,SC3016,SC3011,SC3044,SC3043,SC3060,SC3024,SC1091,SC2066,SC2086,SC2034,SC1083,SC1009,SC1073,SC1072,SC2155,SC2046"
+SHELLCHECK_DISABLED="SC2002,SC3028,SC3054,SC3014,SC3040,SC3046,SC3030,SC3010,SC3037,SC3045,SC3006,SC3018,SC3016,SC3011,SC3044,SC3043,SC3060,SC3024,SC1091,SC2066,SC2086,SC2034,SC1083,SC1009,SC1073,SC1072,SC2155,SC2046"
+
+scripts_to_check=("$@")
+if [[ "$#" == 0 ]]; then
+  # Find all shell scripts excluding:
+  # - Anything git-ignored - No need to lint untracked files.
+  # - ./_* - No need to lint output directories.
+  # - ./.git/* - Ignore anything in the git object store.
+  # - ./vendor* - Vendored code should be fixed upstream instead.
+  # - ./third_party/*, but re-include ./third_party/forked/*  - only code we
+  #    forked should be linted and fixed.
+  while IFS=$'\n' read -r script;
+    do git check-ignore -q "$script" || scripts_to_check+=("$script");
+  done < <(find . -name "*.sh" \
+    -not \( \
+      -path ./_\*      -o \
+      -path ./.git\*   -o \
+      -path ./vendor\* -o \
+      \( -path ./third_party\* -a -not -path ./third_party/forked\* \) \
+    \))
+fi

 # Download shellcheck-alpine from Docker Hub
 echo "Downloading ShellCheck Docker image..."
@@ -29,6 +62,9 @@ echo "Downloading ShellCheck Docker image..."

 # Run ShellCheck on all shell script files, excluding those in the 'vendor' directory
 echo "Running ShellCheck..."
-"${DOCKER}" run --rm -v "$(pwd):$(pwd)" -w "$(pwd)" "${SHELLCHECK_IMAGE}" \
-  find .. -type f -name '*.sh' -exec shellcheck --exclude="$DISABLED_ERRORS" {} +
+"${DOCKER}" run \
+  --rm -v "$(pwd)" -w "$(pwd)" \
+    "${SHELLCHECK_IMAGE}" \
+  shellcheck "${SHELLCHECK_OPTIONS[@]}" "${scripts_to_check[@]}" >&2 || res=$?
+
 echo "Shellcheck ran successfully"

diff
root@vandit-box:/home/vandit/Github-Forks/kueue# time make verify
go mod tidy
git --no-pager diff --exit-code go.mod go.sum
/home/vandit/Github-Forks/kueue/bin/golangci-lint run --timeout 15m0s
./hack/verify-shellcheck.sh
Downloading ShellCheck Docker image...
docker.io/koalaman/shellcheck-alpine@sha256:e19ed93c22423970d56568e171b4512c9244fc75dd9114045016b4a0073ac4b7: Pulling from koalaman/shellcheck-alpine
Digest: sha256:e19ed93c22423970d56568e171b4512c9244fc75dd9114045016b4a0073ac4b7
Status: Image is up to date for koalaman/shellcheck-alpine@sha256:e19ed93c22423970d56568e171b4512c9244fc75dd9114045016b4a0073ac4b7
docker.io/koalaman/shellcheck-alpine:v0.9.0@sha256:e19ed93c22423970d56568e171b4512c9244fc75dd9114045016b4a0073ac4b7

What's Next?
  View a summary of image vulnerabilities and recommendations → docker scout quickview docker.io/koalaman/shellcheck-alpine:v0.9.0@sha256:e19ed93c22423970d56568e171b4512c9244fc75dd9114045016b4a0073ac4b7
Running ShellCheck...
Unknown value for --color. Valid options are: auto, always, never
Shellcheck ran successfully
./hack/verify-toc.sh
Checking table of contents are up to date...
Cleaning up...
/home/vandit/Github-Forks/kueue/bin/controller-gen \
	crd:generateEmbeddedObjectMeta=true output:crd:artifacts:config=config/components/crd/bases\
	paths="./apis/..."
/home/vandit/Github-Forks/kueue/bin/controller-gen \
	rbac:roleName=manager-role output:rbac:artifacts:config=config/components/rbac\
	webhook output:webhook:artifacts:config=config/components/webhook\
	paths="./pkg/controller/...;./pkg/webhooks/...;./pkg/util/cert/...;./pkg/visibility/..."
go mod download
/home/vandit/Github-Forks/kueue/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./apis/..."
./hack/update-codegen.sh go
Generating defaulter code for 2 targets
Generating conversion code for 2 targets
Generating openapi code for 3 targets
Generating applyconfig code for 3 targets
Generating client code for 3 targets
Generating lister code for 3 targets
Generating informer code for 3 targets
SED=/usr/bin/sed ./hack/update-helm.sh
cd  /home/vandit/Github-Forks/kueue/site/genref/ && /home/vandit/Github-Forks/kueue/bin/genref  -o /home/vandit/Github-Forks/kueue/site/content/en/docs/reference
I0317 20:44:00.067350   25439 main.go:142] Parsing go packages in sigs.k8s.io/kueue/apis/kueue/v1beta1
I0317 20:44:04.056445   25439 main.go:325] Output written to /home/vandit/Github-Forks/kueue/site/content/en/docs/reference/kueue.v1beta1.md
I0317 20:44:04.056472   25439 main.go:142] Parsing go packages in sigs.k8s.io/kueue/apis/config/v1beta1
I0317 20:44:32.410099   25439 main.go:325] Output written to /home/vandit/Github-Forks/kueue/site/content/en/docs/reference/kueue-config.v1beta1.md
I0317 20:44:32.410127   25439 main.go:142] Parsing go packages in sigs.k8s.io/kueue/apis/kueue/v1alpha1
I0317 20:44:35.994253   25439 main.go:325] Output written to /home/vandit/Github-Forks/kueue/site/content/en/docs/reference/kueue-alpha.v1alpha1.md
sed -r 's/v[0-9]+\.[0-9]+\.[0-9]+/v0.6.1/g' -i README.md -i site/config.toml
/home/vandit/Github-Forks/kueue/bin/yq e '.appVersion = "v0.6.1"' -i charts/kueue/Chart.yaml
git --no-pager diff --exit-code config/components apis charts/kueue/templates client-go site/

real	2m34.515s
user	3m42.774s
sys	0m55.102s

the time came down significantly
before the change, the output time of make verify was ⬇

Hi, any progress on this?
Given how slow it is, I would even be in favor of dropping some linters.

I have been investigating the rules in make verify but no luck to find which rule is taking how much time. But we have the time around ~15 mins even before February. The CPU usage is 0% in the link provided in the comments https://monitoring-eks.prow.k8s.io/d/96Q8oOOZk/builds?orgId=1&from=now-7d&to=now&var-org=kubernetes-sigs&var-repo=kueue&var-job=pull-kueue-test-integration-main&var-build=All&refresh=30s. According to that, increasing the number of cores might not help decreasing the time.
Which linters should we remove?

Could you try disabling some, running and seeing which ones make the most impact?

.PHONY: verify
verify: gomod-verify ci-lint fmt-verify shell-lint toc-verify manifests generate update-helm generate-apiref prepare-release-branch
	git --no-pager diff --exit-code config/components apis charts/kueue/templates client-go site/

gomod-verify : it go mod tidy's the project
ci-lint : it install and use the golangci-linter on the project
fmt-verify : formats golang code
shell-lint : checks any errors or warnings in shell-lint
toc-verify : It checks and generates if the TOC is latest. (I don't know where this TOC exists maybe https://kueue.sigs.k8s.io/docs/)
manifests: Need to dive deeper in this one.
generate: generate: Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations and client-go libraries.
update-helm: updates helm,Automatically sync RBAC files in helm chart.
generate-apiref: Generate and publish API reference documentation for Kueue.
prepare-release-branch: We use this to update version in README.md, site, kustomize and chart. I think this can be removed from verify.

toc-verify -> It checks and generates if the TOC is latest. (I don't know where this TOC exists, maybe https://kueue.sigs.k8s.io/docs/)
generate-apiref-> Generate and publish API reference documentation for Kueue.
I think these two can be removed from verify since we only need to check these before every release. I'm saying this on the basis of assumption the TOC and API reference gets updated after every release of Kueue.

How long do you estimate each of them to take?
Running them for each PR has the intent of preventing changes from merging if the authors forgot to run those commands before committing.
TOC is for /keps

OTOH, it looks like some builds are using 2 CPUs (even a little bit more)

maybe it does make sense to increase the limits and GOMAXPROCS?

That's what I was thinking we should increase the limits and GOMAXPROCS  and see if it makes any difference.

I'm ok with a brute force approach: send the PR, let's see if the time changes. If it doesn't, we revert and look into other options.

https://github.com/kubernetes/test-infra/blob/b4ef1ec5bfe29168267ff37a1f2ab4ad3727c67f/docs/eks-jobs-migration.md#known-issues
Should we set GOMAXPROCS to automaxprocs to see if it makes any difference.

Nice detective work @Vandit1604!
I looked at the job now and it looks to be around 8-9 minutes.

Since we have achieved the goal of being under 10 min, I'm happy to close this.
Thanks @Vandit1604!
/close

Your Welcome @alculquicondor
Since, I have been contributing to Kueue for some time. Now, I would like to dive in a Kueue-specific Golang issue.
All I see in issue tabs are marked as feature-requests. Is there anything In which I can contribute.
If you could only point me to something.

If you have any experience with helm, perhaps you can take this #1798

Thanks, I do have worked with helm charts previously.
I'll take a look into it.


UI-7461 - Adds the ability to migrate calculated measures from the legacy pivot folder in AUI-4 to AUI-5

Summary
This PR introduces the ability to migrate calculated measures from AUI-4 to AUI-5. In order to do this, a new CLI parameter has been introduced -p which is the path to the file containing the JSON representation of the pivot folder on an AUI-4 content server.

I would split things differently, with more decoupling:
const calculatedMeasures = getCalculatedMeasures(...);
const migratedUIFolder = migrateUIFolder(..., calculatedMeasures);

where you would use a sub migrateCalculatedMeasures function in migrateUIFolder.

Hello @antoinetissier, given your above suggestion, I've added a new commit that reworks how the calculated measures are migrated. In my opinion, the new way is simpler and easier to understand for future devs. I haven't had the chance to add tests for it yet, but I'm going to hand this off to you for review and if you agree that the new way is improved, I'll go ahead and add some tests. Let me know what you think!


Check.PY Failed For Planning Sample

I follow the instruction, unable to connect to TM1 using Anaconda Prompt, I fill in user name as Admin, password empty or Apple, I definitely do not have CAM set up for it, port number or server name confirmed correct using POST, rest API query.  Not sure why target machine actively refuses it, and what I did wrong.  I did try the right click check.py folder with shift, one time I got powershell window up, it does not recognize python as a cmdlet.

when you leave address empty TM1py will assume you are connecting to localhost.
Are you running the script on the same machine as the TM1 server ?

Hi Marius, not the same machine, I run in my laptop,not server.  I will enter server name and try again today, you are correct about local host issue.
Shirley
Sent from Yahoo Mail for iPhone
On Thursday, July 18, 2019, 10:49 PM, Marius Wirtz<EMAIL_ADDRESS>wrote:
when you leave address empty TM1py will assume you are connecting to localhost.
Are you running the script on the same machine as the TM1 server ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


SyncProtectionSpec::_systemClockSourcePriorityList does not express an order

The order of the clock source is significant.
The current way of modeling the systemClockSourcePriorityLis is not qualified for expressing an order.
Order shall be expressed by a composed datatype containing a rank attribute.
Proposal to the 5G-xhaul call on 14th of February 2024:

The SyncProtectionSpec::_systemClockSourcePriorityList attribute shall change from LTP reference datatype to systemClockSourcePriorityType datatype.
A systemClockSourcePriorityType datatype shall be created.
The systemClockSourcePriorityType datatype shall contain the following attributes:

_systemClockSource as a key attribute and reference on an LTP
rank : INT8 configurable and with comment "Defines the rank of the clock source."

The semantics of the rank attribute is not clearly defined: How are the rank values ordered?
The attribute should better be called priority so that it is aligned with the ssm-enable-status attribute whose description refers to priority.
The attribute seems to be redundant: The Core Model defines the selection-priority attribute for fc-port instances:
    leaf selection-priority {
      type int64;
      default "0";
      description
        "The preference priority of the resource in the protection scheme for a particular FC.
         The lower the value the higher the priority.
         A lower value of selection priority is preferred
         If two resources have the same value they are of equal priority.
         ...";
    }

Two alternative modelings have been discussed for substituting the systemClockSourcePriorityList and the externalClockSourcePriorityList attributes.

Using one FC for modeling the Selector B only
Using two FC for modeling Selector A and Selector B, and an additional T4LpSpec class comprising an inputAtSelectorC attribute for modeling Selector C.

Vendors with equipment providing a T4 output that might be different from the T0 output are asked to state their preference in modeling by Tuesday 27th of February 2024.

Result of the discussion on 27th of February 2024:
It turned out that there is an existing description about how to use definitions of the ONF Core IM (e.g. FC, Switch, FcPort) to substitute the systemClockSourcePriorityList and externalClockSourcePriorityList attributes at the module level of the Synchronization modelling.
The existing description shall be complemented by two sentences, which will result in:
"
This synchronization model augments the ONF Core Information Model to manage wireless transport devices according to ITU-T G.7721-2018. The following section gives guidance with respect of the usage of the ONF Core Information Model when implementing ITU-T G.8264 'Hybrid SDH/synchronous Ethernet SETG Function'. The ONF Core Information Model is flexible enough to cover all possible implementations described by Figure A.2.
Recommendation for implementing 'Hybrid SDH/synchronous Ethernet SETG Function':

The LogicalTerminationPoints representing a synchronization related termination point are unidirectional.
The Selectors A, B and C should be represented as ForwardingConstructs with FC-Switches and FcPorts.
The selectionPriority attribute at the FcPort should represented the configurable priority of a source.
The Selector B and the SETG function should be represented as a single ForwardingConstructs. Note: It is implementation specific, whether the output of the SETG function is represented by 0 or 1 or 2 LogicalTerminationPoints of LayerProtocol 'LAYER_PROTOCOL_NAME_TYPE_SYNCHRONIZATION_LAYER'.
If Selector A and Selector C are represented as individual ForwardingConstructs, then a LogicalTerminationPoints of LayerProtocol 'LAYER_PROTOCOL_NAME_TYPE_SYNCHRONIZATION_LAYER' must exist representing the output of Selector A and at the same time the input of Selector C.
In contrast to Selector A and B, Selector C is only implementing a forced switch without regarding priority or quality of the source.
Configuration which are not supported by the device, shall result in ErrorMessages (e.g. Function not supported).

"
The existing systemClockSourcePriorityList, externalClockSourcePriorityList and currentSourcePort attributes shall just be deleted.
RPCs for creating (, changing) and deleting FcPorts at the FCs representing the Selectors shall be defined in the next step.

Considering that only families of devices now being discontinued support T4, I would propose to implement only selector B if the devices deployed in the field are all configured with T4=T0. This means that the T4 output signal available on the connector is used to distribute the T0 clock to other equipment located on the site.


Plot circular path, save to CSV file

Finishes task https://app.asana.com/0/75198147526823/1208425065900229/f
I have created a new file plot_circular_path.py that generates n waypoints given a center and radius. I have also implemented the ability to save waypoints to a CSV file.

Reviewed, logic looks good. Just a few nits on formatting and bug catching


Poor contrast for workspace search and errors in notebooks in the Light+ V2 theme

Type: Bug
In addition to https://github.com/microsoft/vscode/issues/173255, https://github.com/microsoft/vscode/issues/173238, these elements are also hard to see in the Light+ V2 theme.
Active (focused) workspace search results on methods:

Error messages in Jupyter notebooks:

VS Code version: Code - Insiders 1.76.0-insider (c9e3ef865539061b5602c6b9ac6030332aa1ce70, 2023-02-06T05:24:21.999Z)
OS version: Linux x64 5.15.0-58-generic
Modes:
Sandboxed: Yes

@rebornix do you know what the notebook output token would be? I don't think I changed anything specific to notebooks in these new themes.

Perfect, thanks for checking. Feel free to close if it looks all good in the next Insiders update.

@daviddossett as @yy0931 pointed out we are using terminal colors.

Even worse for unsued python imports

Yep, this ended up just being a bad color assignment. Should be fixed now.


Clarify that baseline is optional for filesystem registries.

Related: https://github.com/microsoft/vcpkg/issues/30939

Thanks for the fix!


ci: invoke dagger directly through its GitHub Action

follow-up https://github.com/dagger/dagger-for-github/pull/56#issuecomment-1111730526
cc @sipsma
Signed-off-by: CrazyMax<EMAIL_ADDRESS>

Also following steps doesn't seem necessary to me: https://github.com/dagger/dagger/blob/2c195bcac4e133e2ed7396b3b73a0003e6f51eb9/.github/workflows/dagger-ci.yml#L61-L71
      - name: Sets env vars on push to main
        run: |
          echo "DAGGER_CACHE_TO=type=gha,mode=max,scope=${{env.DAGGER_CACHE_BASE}}-main" >> $GITHUB_ENV
          echo "DAGGER_CACHE_FROM=type=gha,scope=${{env.DAGGER_CACHE_BASE}}-main" >> $GITHUB_ENV
        if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}

      - name: Sets env vars on pull request
        run: |
          echo "DAGGER_CACHE_TO=type=gha,mode=max,scope=${{env.DAGGER_CACHE_BASE}}-${{github.event.number}}" >> $GITHUB_ENV
          echo "DAGGER_CACHE_FROM=type=gha,scope=${{env.DAGGER_CACHE_BASE}}-main type=gha,scope=${{env.DAGGER_CACHE_BASE}}-${{github.event.number}}" >> $GITHUB_ENV
        if: ${{ github.event_name == 'pull_request' }}

Cache access restriction across PR/branches is automatically handled by GitHub so you could directly use:
      - name: Build
        uses: dagger/dagger-for-github@v2
        with:
          cmds: |
            do build
        env:
          DAGGER_LOG_LEVEL: "debug"
          DAGGER_CACHE_FROM: "type=gha,scope=dagger-ci-build"
          DAGGER_CACHE_TO: "type=gha,scope=dagger-ci-build,mode=max"

More info: https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#restrictions-for-accessing-a-cache

@crazy-max Awesome, thanks, had no idea about the difference between run and uses.
For the steps that setup the different DAGGER_CACHE_TO env vars, the problem we were trying to address there was that Buildkit cache manifests overwrite each other. The goal was to be able to import cache from both our main branch and the PR specific cache. Are you saying that would work already? From what I could tell that wouldn't work as is, but I was going off reading GHA docs + the buildkit code rather than trying it, so wouldn't be surprised if I was wrong.

For the steps that setup the different DAGGER_CACHE_TO env vars, the problem we were trying to address there was that Buildkit cache manifests overwrite each other. The goal was to be able to import cache from both our main branch and the PR specific cache. Are you saying that would work already? From what I could tell that wouldn't work as is, but I was going off reading GHA docs + the buildkit code rather than trying it, so wouldn't be surprised if I was wrong.

Yes indeed. I think it will work only on first trigger of the PR and subsequent builds will overwrite it. Didn't try it myself though but worth to check that.

Thank you @crazy-max!
I don't think it's a problem right now but just flagging this: this essentially means that install-only won't honor caching (or at least, subsequent run steps using it won't work).
cmds is a little bit limited in what one can do compared to install-only (e.g. curl $(dagger do deploy --output-format json | jq -r .url))
If I understand what you're saying in https://github.com/dagger/dagger-for-github/pull/56#issuecomment-1111730526, exposing ACTION_ from an action to subsequent runs is not necessarily a best practice (huge hack), right?
Maybe long term what we'll do is expose the outputs to the action itself so there's never a need to do an install-only

Cache access restriction across PR/branches is automatically handled by GitHub so you could directly use:

That's definitely worth exploring, thank you!

@crazy-max Can you rebase your PR so we can merge it as soon as possible?


Question: What does the blinking red LED mean on the Steele PDB?

I tried to search for a while now but nothing found.

If it blinks in a regular, "heartbeat" rhythm: Everything is fine, the OSD main loop is running AND it is receiving data from the FC
If it blinks with a hiccup (little pause between blinks): OSD main loop is running but it is EITHER not receiving data from the FC OR it is waiting for user input to continue the last battery
It it does not blink at all: The OSD main loop does not run. This is not good and first remedy would be to flash the FW again. If that does not work or it still does not blink: not good. The led could be dead, but most likely the OSD chip is broken.


Only blank page rendered on Firefox Nightly

Attach (recommended) or Link to PDF file here:  exemption-letter.pdf
Configuration:

Web browser and its version: Firefox 94 Nightly
Operating system and its version: Win 10

Steps to reproduce the problem:

Open the attached file. No content has been rendered.

WFM, using the latest Nightly on Windows; hence this is most likely is a duplicate https://bugzilla.mozilla.org/show_bug.cgi?id=1730598 which has already been fixed.
Please make sure that you're actually using the very latest Nightly!


[App Config] Add tags filter & list by label methods for 2023-11-01 API version

Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
APIView has identified API level changes in this PR and created following API reviews.
@azure/app-configuration


Notification: re-render when urls property changes

It re-uses the code from NotificationElement. However, I'm not happy with the implementation. It seems that they are pretty much different to make sense to re-use the class.
It seems that what we want here is create a NotificationBaseElement where NotificationExternalElement and NotificationNonLatestElement can extend.
Example

However, I'm not happy with the implementation. It seems that they are pretty much different to make sense to re-use the class. It seems that what we want here is create a NotificationBaseElement where NotificationExternalElement and NotificationNonLatestElement can extend.

I don't quite follow here, is there a particular problem you see with the current approach?
Having a single element seems to make sense to me for now. We want both warnings to occupy the same space, and these warnings well never be shown at the same time. If we add a third, unrelated notification, we either want it to occupy the same space (turn the description into a list of messages for example), or I'm assuming we'll make this into a list of notifications instead.
But from a user's perspective, it's odd to require the user/theme author to define every individual notification we define, ie:
<readthedocs-notification-external-version class="..."></readthedocs-notification-external-warning>
<readthedocs-notification-outdated-version class="..."></readthedocs-notification-outdated-warning>
<readthedocs-notification-new-build class="..."></readthedocs-notification-new-build>
<readthedocs-notification-doc-diff class="..."></readthedocs-notification-doc-diff>
<readthedocs-notification-foo class="..."></readthedocs-notification-foo>

If we define different classes for each, then we need separate tags. There might be a better way to abstract the message from the element display though, this could be part of changing the notification to a notification list.

If we define different classes for each, then we need separate tags. There might be a better way to abstract the message from the element display though, this could be part of changing the notification to a notification list.

Yeah, I thought about this and I didn't arrived at a pattern where I was happy with it. I feel the lack of js knowledge here.
My original point about the implementation I've done here is that most of the functions/methods/properties from the class are not required for all the "notifications". For example calculateHighestVersion has nothing to do with the PR notification. this.urls is only used on the PR notification, generating confusions when working with the "non latest version notification", etc.
I think it makes sense to use the same <readthedocs-notification> tag. Is is possible to have two different isolated classes with their own functions but sharing the same HTML tag? Would that make sense? 🤔

On a different topic, it seems that our shadow DOM does not respect the exact same style on different sites:
Sphinx

Material for MkDocs

Do you have an idea what it could be?

Yeah, I thought about this and I didn't arrived at a pattern where I was happy with it.

Same, but I think we can develop this over time too and don't need to nail this implementation just yet. For basic/default usage, I think what we have now works well, but customization is where we will want to start building up this abstraction pattern more.
This is where I probably want to see what theme maintainers want to do with our data, and make this implementation flexible enough to fit those needs. For example, I see maintainers not wanting to use this notification element at all, and instead wanting the underlying information (version is outdated/version is a pull request) directly so they can adjust independent visual elements.
I can put up an issue with a few different directions from the HTML/JS side of things, maybe that is a good place to get some feedback to start.

most of the functions/methods/properties from the class are not required for all the "notifications"

Better naming could help here. Overall, the current design isn't bad though. When we figure out what the additional layer of abstraction is, this will feel cleaner.

is possible to have two different isolated classes with their own functions but sharing the same HTML tag?

It is not, and this will throw and exception actually.

Do you have an idea what it could be?

This looks like it's just font size, which is expected. The rem unit is still a relative unit in CSS ^1, but it is only relative to the root element font size. The em unit is also relative, but to the parent element and every parent element up the chain.
This behavior is what I'd expect though, and is generally more correct than dictating a different font size than the root element. To avoid this, we could use px or another absolute unit, which wouldn't be awful given the font-size is a CSS variable. But, generally, respecting the rem is going to be the best fit visually.

I've dropped some example patterns in https://github.com/readthedocs/readthedocs-client/issues/51 for now. But I'd say lets stew on that a bit, we don't need to get too fiddly just yet.

I updated the PR with the feedback received and I will merge it. I'm sure there will be more work to be done here, but we can always open more PRs 😉


Fail the nox-cross-arch-all job if any matrix job fails

Otherwise this job will be skipped, just like when the matrix jobs are skipped, resulting in a passed check when it should have failed.

Oh, right, the codeowner here is the @frequenz-floss/api-dispatch-team, not the SDK team, that's why... @stefan-brus-frequenz or @ktickner maybe can approve this? I guess we should make the SDK team an owner too...

We still need to merge this PR for the SDK team to be able to approve.

God dammit, the merge queue doesn't seem to be working at all :unamused:

But at least it seems to work: https://github.com/frequenz-floss/frequenz-client-dispatch-python/actions/runs/8936033687


Update to preview1 version

cc @victorhurdugaci \ @muratg

:shipit: after you figure out why travis failed


Refactor Predicateable and PositionDistrbutable to magnet pattern

PositionDistributable can be refactored in a straight forward way, but using it is a lot harder. Remember, that the magnet pattern is an overloading crutch. The overloaded methods get replaced with one method with one argument: The magnet. In this particular case def convert(magnet: PositionDistributable) = ???
However, PositionDistributable is used in context (see for instance Matrix.change) where it's result type depends on one of the arguments abstract types -  keeping the same API it's impossible to infer the correct types.
One way to go about is to simply change the matrix API to return an Aux object:
class Aux[T <: Tuner](slice: Slice[P], ...)  {
def apply (p: PositionDistributable[slice.S, TypedPipe]) = ??? // code from original Matrix.change goes here
}

def change[...](...) = new Aux(slice, ...)

But to be perfectly honest, I don't see the benefit - the type case pattern used now seems perfectly fine.
Maybe I don't quite understand the goal of the refactoring exercise.

@AndreasKostler - thanks for looking into this. The goal was to try and present a consistent interface for each API which is 'overloaded'. It would have been nice if we could present a (visually at least - since technically there's not that much difference) consistent pattern for the API signature and usage of it.
Note though that grimlock uses a modified magnet pattern; it applies it to a single argument as opposed to the full argument list. See for example Operable in the pairwise functions, Windowable in the slide functions, Partitionable in the split functions, Sampleable in the subset functions, Aggregatable in the summary functions, Transformable in the transform functions, or Squashable in the squash functions.
If however, as you point out, it isn't possible/practical to migrate PositionDistributable or Predicteable to a similar pattern then the best course of action would be to leave them as is. Another possible way around the problem of inferring the type would be to add add types as done here:
https://github.com/CommBank/grimlock/blob/partition/src/main/scala/au/com/cba/omnia/grimlock/framework/Matrix.scala#L337 (in particular the usage of S). However, this is far from ideal too.
Lets briefly discuss later today and decide on the best course of action.

Ah ok, I get you. The problem is the dependency on slice.S - I can work around this via the Aux pattern above or by having two parameter lists for change and co. , i.e. change(...)(p: PositionDistributable)
Both brake the API so I am not sure if it wins anything at all.
Thinking about it, I'm not even sure the latter would work.

Oh, I'll have a look at the link you've provided - it looks like it could work. However, there's still the exactly one argument issue. I'll do some trying and testing.

Refactor to use shapeless.Nat included overall code simplification - magnet pattern is no longer used


Add Envoy Gateway Support to Flagger

Add Envoy Gateway as a reference ingress controller to Flagger. See the Flagger docs for additional details.

Anyone else want to work on this? If not, I would like to assign this and work on this. Since this is a backlog task, I think I can work on this in low level priority, compared with implementing gateway api.

Feel free to work on the issue. However, it's currently in the backlog. We will be reviewing the backlog issues next week during the community meetings to plan for the v0.3.0 release. In my opinion, we have a ton of higher priorities to address for v0.3.0.

@Xunzhuo can you unassign yourself and add the help-wanted label.


terminus site code branch-create drops hyphens from branch names

If I were to run terminus site code branch-create --site=sitename --branchname=hotfix-up then the branch I actually get is "hotfixup".
I've also tried quoting the branch name like so: terminus site code branch-create --site=sitename --branchname="hotfix-up"
but the same thing happens.  Should I be escaping certain characters in branch names?  Should I be avoiding certain characters?
Thanks

I've removed the hyphen from the list of characters which Terminus will automatically remove from branch names. Here's the list of the ones it will still expunge:
'['
'_'
' '
']'
'+'


docs: Improve File tree picker in Helix with Zellij tip

Close #144
Showcase
https://github.com/user-attachments/assets/584696cb-89e0-4eaa-8cce-6faa84e350d6

Hey @sxyazi, if you don't like my mention of the patch let me know, I will remove it

Hi, I tested it today, and it works like a charm, this is gonna be an awesome improvement, thank you! 👍🏻
I removed the part with the custom prompt content because it was a bit beyond the scope of this tip, and I switched back to the original demo video since the new one was a bit too long. Hope this is fine with you.
Thanks again for your contribution to this tip! 🙏🏻


Using linuxbrew OpenSSL results in an error

Taken from https://github.com/prisma/prisma/discussions/14356#discussioncomment-4075604

@vladi-stevanovic for anyone else who finds this discussion I was encountering the same issue when running npx prism db pull
I'm running Ubuntu 22.04 with Node 18.12 LTS installed via NVM. I noticed that my OpenSSL version was also 1.1.1q installed by Linuxbrew.
Unlinking the Linuxbrew version so that the system version of OpenSSL (3.0.2) is used resolved the issue for me and I have been able to run the pull successfully.

brew unlink<EMAIL_ADDRESS>

In my case I had installed 1.1 trying to get a local MongoDB installation working on Ubuntu 22.04 unsuccessfully. Ended up using Atlas.

https://github.com/prisma/prisma/discussions/14356#discussioncomment-4080136

Can you describe a bit further how we could get our system into the same situation? We would like to be able to reproduce this and then hopefully find a better solution.

https://github.com/prisma/prisma/discussions/14356#discussioncomment-4081116

@jobyh thank you so much - been stuck with the same issue for weeks. I have no idea why I would have a duplicate (and outdated) version installed via homebrew, but gave it a last ditch attempt any way and sure enough it worked!

https://github.com/prisma/prisma/discussions/14356#discussioncomment-4084681

@John-Dennehy You’re welcome, I’m really pleased it has helped you too! Hoping it doesn’t break any other Homebrew packages which may have installed 1.1 as a dependency. Still, as you say, better not to be using the outdated version.

Can you describe a bit further how we could get our system into the same situation? We would like to be able to reproduce this and then hopefully find a better solution.

@janpio Yes, of course. In the context of Ubuntu 22.04 (LTS):

Ensure OpenSSL toolkit is installed sudo apt-get install openssl
Check system OpenSSL is v3 openssl version
Install Homebrew
Install NVM via Homebrew brew install nvm
Install Node LTS via NVM nvm install —lts
Install legacy OpenSSL via Homebrew brew install<EMAIL_ADDRESS>Check legacy OpenSSL is now being used openssl version
The above should recreate the system state into which I created a Next.js app and added Prisma which errored on npx prisma db pull. If you need detailed steps am happy to provide them.

I don’t think Prisma is doing anything really wrong because the cause is an outdated version of OpenSSL overriding the system version for that user. The problem is very frustrating from a DX perspective as it's not clear what action to take based on the error message so I appreciate you wanting to look for an improvement 🙂

https://github.com/prisma/prisma/discussions/14356#discussioncomment-4085894

I did a reproduction on GitHub Actions Ubuntu 22.04 here https://github.com/prisma/ecosystem-tests/pull/3204
Though the error is different

[...]
Query engine library for current platform "debian-openssl-3.0.x" could not be found.
You incorrectly pinned it to debian-openssl-3.0.x
[...]

https://github.com/prisma/prisma/discussions/14356#discussioncomment-4086099

@Jolg42 I wonder if the difference in error message could be related to the fact that Homebrew overrides for a specific user on the system (not all users)? Is the action running the command which triggers the error as a different user than the one whos path includes Homebrew?

This issue is reproducible with Prisma up to 4.8.1. Starting with Prisma 4.9.0, OpenSSL installed via Anaconda, Homebrew etc doesn't interfere with system OpenSSL library detection. I'm going to go ahead and close this issue.


Can not find class reference when clicking on function with "cmd+{left click}".

Can not find class/function reference when clicking on function with "cmd+{left click}".
It shows the error:

Couldn't Generate Swift Representation.
Error (from SourceKit):
Could not load module: FirebaseAnalytics

How can I solve this problem so I don't need to look up reference on document every time?

When I created my own project using Firebase pod, I succeeded looking up the reference.
Somehow it shows the error when I try the "AuthenticationExample". But the issue doesn't bother me now.

I found out the cause was I have a space in my Xcode project name, and then Xcode can not find the correct path of the frameworks.
This is the reference.
http://stackoverflow.com/questions/32894901/xcode-couldnt-generate-swift-representation-for-my-own-framework

Closing - sounds like that fixed it?

Yes, thanks. I feel embarrassed.


Loading Cesium 3D tiles broken?

Hi!
I am wondering whether the Cesium 3D tiles support is broken, or I am doing something wrong.
In the current version (1.8.3) I get an error message (Failed to load ....)
The same exact tileset can be loaded and visualised using version 1.8.0 (I have both versions of the 3DcityDB-web-map running and sharing the same data source).
I add for simple testing a zipped version of the dataset.
BR
tileset.zip

Thanks for the bug report. I fixed it  in https://github.com/3dcitydb/3dcitydb-web-map/commit/9966228394acc86c51578e40e322c9c699617e6a.


Support for bidirectional TileLink

We (libre-riscv.org) are considering adding OmniXtend support to our SoC, however, from what I understand, TileLink doesn't support accessing large amounts of memory without the memory being a slave agent, so we need a path in through the Ethernet port to the memory with the SoC acting as a slave, and we also need the SoC to act as a master to access other memory over the OmniXtend link.
Does OmniXtend support having a single Ethernet link support a bidirectional connection that has both a remote master to local memory/devices TileLink connection, and a local master to remote memory/devices connection? If not I think we should add that capability. Note that having a bidirectional link would not cause a loop in the TileLink agent graph, since each direction would be an independent link connected to different portions of the graph, allowing it to stay a DAG.
Proposed connection graph:
https://salsa.debian.org/Kazan-team/kazan/blob/master/docs/OmniXtend Bidirectional.svg

Yes, OmniXtend does support having a single Ethernet link support a bidirectional connection that has both a remote master to local memory/devices TileLink connection, and a local master to remote memory/devices connection.

Great! Thanks.


Cls bind step implementation

Description
Changes proposed in this pull request:

Implement cls bind step.
Refactor Audit log step

Related issue(s)

Wrong PR

closing as PR has been created her: https://github.com/kyma-project/control-plane/pull/533


[refactor] Convert ClientRenderer.visualizationMode into a EnumVisualizationMode.

Since it is possible to add methods to a enum class, why not use that to implement the visualization modes? This a) reduces the spaghetti code caused by placing the visualization mode code all over the place and b) makes it simpler to add new modes in the future.

Done


Please consider publishing version 0.0.16

Current master has version of the library 0.0.10, but pypi offers 0.0.16.
Please consider adding version 0.0.16 to the repository

bump

version

but it seems that the code needs to be updated as well to reflect 0.0.16 changes?


Enable Json logging configuration option

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: GregHanson
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [GregHanson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GregHanson: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@GregHanson: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
7a0e8f613731cf5f13e3b20117fc8ea8e1a0ad24
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
7a0e8f613731cf5f13e3b20117fc8ea8e1a0ad24
link
/test istio-integ-local-tests

prow/istio-presubmit.sh
7a0e8f613731cf5f13e3b20117fc8ea8e1a0ad24
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
7a0e8f613731cf5f13e3b20117fc8ea8e1a0ad24
link
/test istio-integ-local-tests

prow/istio-presubmit.sh
7a0e8f613731cf5f13e3b20117fc8ea8e1a0ad24
link
/test istio-presubmit

prow/istio-unit-tests.sh
7a0e8f613731cf5f13e3b20117fc8ea8e1a0ad24
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: GregHanson
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [GregHanson]
pilot/OWNERS [GregHanson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
7a0e8f613731cf5f13e3b20117fc8ea8e1a0ad24
link
/test istio-presubmit

prow/istio-unit-tests.sh
84a812a21f82ed52c5efa4d5cd4fdf4d3f61b945
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
84a812a21f82ed52c5efa4d5cd4fdf4d3f61b945
link
/test istio-unit-tests

prow/e2e-mixer-no_auth-mcp.sh
84a812a21f82ed52c5efa4d5cd4fdf4d3f61b945
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
84a812a21f82ed52c5efa4d5cd4fdf4d3f61b945
link
/test istio-unit-tests

prow/e2e-mixer-no_auth-mcp.sh
84a812a21f82ed52c5efa4d5cd4fdf4d3f61b945
link
/test e2e-mixer-no_auth-mcp

prow/istio-pilot-multicluster-e2e.sh
84a812a21f82ed52c5efa4d5cd4fdf4d3f61b945
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: GregHanson, rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [GregHanson,rshriram]
pilot/OWNERS [GregHanson,rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
84a812a21f82ed52c5efa4d5cd4fdf4d3f61b945
link
/test e2e-mixer-no_auth-mcp

prow/istio-pilot-multicluster-e2e.sh
84a812a21f82ed52c5efa4d5cd4fdf4d3f61b945
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
84a812a21f82ed52c5efa4d5cd4fdf4d3f61b945
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
84a812a21f82ed52c5efa4d5cd4fdf4d3f61b945
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
84a812a21f82ed52c5efa4d5cd4fdf4d3f61b945
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
84a812a21f82ed52c5efa4d5cd4fdf4d3f61b945
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Support multiple service CIDRs

Feature request
KEP-1880 Multiple ServiceCIDR ( and IPAddress allocation)
Use case

is this supported?


Update README.md

Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html

signed!

Hi, in the readme file for UiAutomator, you asked to enable "Android testing support library Repository". Are you sure that this is the correct name? Is this readme deprecated? I did not find any repository with that name. Thanks, M

@mcanonic Not sure that is relevant to this PR. Perhaps file a separate issue, or submit a PR to address those PR changes.


Support for convertion of MultipleWalletSingleTable to multitenant agent using managed keys

Dear team.
Currently were holders of several wallets in indy format and we are using mwst with independent agents, and we want to move to a multitenant agent, as we know the keys of all wallets, is there any way to convert them to multi tenant?
As askar doesn't support mwst, using mwst-as-stores generates a lot of databases which require a lot more space than the original.
Thanks in advance.

Closing as stale.


Lint/UnneededDisable of Metrics/LineLength that isn't unneeded

This line (among many others) is throwing an error for me:
  LARGE_DATA_STRING_PATTERN = %r{\A([A-Za-z0-9\+\/#]*\={0,2})#([A-Za-z0-9\+\/#]*\={0,2})#([A-Za-z0-9\+\/#]*\={0,2})\z} # rubocop:disable Metrics/LineLength

My full LineLength config is as follows:
Metrics/LineLength:
  Enabled:                       true
  Max:                           90
  AllowHeredoc:                  true
  AllowURI:                      true
  IgnoreCopDirectives:           true
  URISchemes:
    - 'http'
    - 'https'

Expected behavior
No error for Lint/UnneededDisable
Actual behavior
An error for Lint/UnneededDisable
RuboCop version
$ rubocop -V
0.47.1 (using Parser <IP_ADDRESS>, running on ruby 2.4.0 x86_64-darwin16)

I confirmed the report. Also, changing IgnoreCopDirectives to false gets the expected behavior (no offense from Lint/UnneededDisable). I suspect there's an unexplored edge case.
Sidenote: It would be nice if IgnoreCopDirectives were flipped to positive phrasing like IncludeCopDirectives, to make this easier to reason about.

As it turns out, it's really easy to reproduce this. Any line containing both non-directive # and directive # has the potential to run into this bug.
I'd be happy to submit a fix for this.

@bbatsov
The following line:
    COMMENT_DIRECTIVE_REGEXP = Regexp.new(
      ('\A# rubocop : ((?:dis|en)able)\b ' + COPS_PATTERN).gsub(' ', '\s*')
    )

Is it necessary for the regexp to have the \A assertion? It is one of the culprits behind this bug.


Add and synchronize typings

Makes applications leveraging TSHint (such as WebStorm) a bit happier :-)

This change is

Thanks for this PR!

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Hi Arthur,
What version of tslint and typescript compiler is the WebStorm IDE using? The typings you added a not necessary, since the typescript 2.4 compiler can infer them.
It would be nice if you figure out the typing inference in your setup, in order to stay in sync and not have to constantly update the code as the library progresses

Hi @dsmilkov ,
This'll resolve typings for even the latest version of WebStorm (2017.2.4), which uses TypeScript 2.4.2. Though it doesn't produce a critical compiler error, it does require a user to disable autocompletion in order to not get into a fight with tsc.

Thanks for clarifying. Hope WebStorm resolves this on their side soon. We use Visual Studio Code and the auto-completion works well without the explicit typings. In the meantime, feel free to send us typings as you get out of sync with master.
Cheers

We should be set for now. Indeed a little strange that WS doesn't infer the types properly while VS does. Either way; I'll keep an eye on this as you guys progress! Thanks!


How to correctly use custom claims in Nuxt App

Hi,
I have been a little confused lately, also with updating to 1.3.2 in my application I am wondering if I'm doing things right.
I cannot find a clear approach to this anywhere:
I am using a Supabase auth hook to add custom claims to my JWT, following this tutorial. This works, If I decode my JWT I get a claim called user_roles, which is an array of strings, one of them might be e.g. 'admin'.
How do I save this array / access it on client and server and during SSR?
I did the following:
Nuxt Plugin with useState("userRoles") which decodes the access_token in useSupabaseSession() and sets the state. In this plugin I also add an event listener to supabase.auth.onAuthStateChange which also decodes the jwt and sets the value of the state.
Server middleware which await serverSupabaseSession(event), decodes the access_token and adds it to context.
This seems to work 99% of the time. The exception is: My plugin that initializes my pinia stores. If I then fetch from the server, the context is empty.

I guess the question would be: How do I get my custom claim in SSR and add it to the event context, before everything else runs?

I found out that If I use a pinia action to fetch data in a plugin, the Supabase session is not yet available on the server.

Closing this question, since using the custom claims works with my methods, but the session is not always available. This might be a bug.
I cannot get my Pinia Stores to initialize with SSR. They fetch from an API route of the nuxt app, but, for some reason, the session is not present there at first.


buildBiolarkContainer fails on step 4/10

I tried to build the biolark container with "gradle buildBiolarkContainer". It failed, likely because http://bio-lark.org/hpo/hpo_cr_web.tar.gz is not accessible. The output is below:
:buildBiolarkContainer
Sending build context to Docker daemon 4.096 kB
Step 1/10 : FROM java:8
 ---> d23bdf5b1b1b
Step 2/10 : MAINTAINER<EMAIL_ADDRESS> ---> Using cache
 ---> a3d98185588c
Step 3/10 : WORKDIR /usr/src/
 ---> Using cache
 ---> 4b2a1025e2a9
Step 4/10 : ADD 'http://bio-lark.org/hpo/hpo_cr_web.tar.gz' /usr/src
Get http://bio-lark.org/hpo/hpo_cr_web.tar.gz: dial tcp <IP_ADDRESS>:80: i/o timeout
:buildBiolarkContainer FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':buildBiolarkContainer'.
> Process 'command 'docker'' finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 31.294 secs

This container needs to download the bio-lark web service from
http://bio-lark.org/hpo/hpo_cr_web.tar.gz
It looks like that's currently out of action. I'll pop an email to Tudor Groza and find out what the problem is


<1 star ratings don't work

Shows 0 stars. To test, simply change the value to 0.5.
Thanks!

To update, anything under 1 does not work - 0.75, 0.25 etc do not work.
Thanks

On Github Pages they are not displayed at all? Is it a blank space? Nevermind, I will upload one now.

They are displayed but as 0 stars.

Doesn’t seem to be working on your build either.

Yes, I think I know why, it seems a Github minification issue on stars, I am trying now to fix it.

Awesome, thanks.

Ah, yes, that was it. I imported the non scss version this time and it works.

Awesome, thanks. So I update stars.scss to stars.css and add the rendered file?
https://github.com/wowthemesnet/mediumish-theme-jekyll/commit/48d8c36e38787c3349e23155a4914e231f1bc1ac
Thanks

The manual update is this:

Add _starsnonscss in sass folder. link

Replace in main.css stars with starsnonscss. link

Awesome, thanks. Appreciate the support of the theme.

You can delete the old _stars.scss, I'm just leaving it in the repository for anyone who wants to have the preprocessor.


%{value} not present when using validate with a proc

Hi! 👋 Thanks again for this exceptional set of gems.
Describe the problem
When using validate ->(input)... and customizing the message, the %{value} token is not present. I put in a pry at the error location, and the only token available is valid, which is the proc itself.
Steps to reproduce the problem
key(:filename).ask("File name", required: true) do |q|
    q.modify :remove
    q.validate ->(input) { !File.exists?("app/somewhere/#{input}.html") }, "Filename %{value} already exists!"
end

Actual behaviour
It throws an error
KeyError: key{value} not found
/Users/bbugh/.rvm/gems/ruby-2.6.6/gems/tty-prompt-0.21.0/lib/tty/prompt/question.rb:87:in `%'
/Users/bbugh/.rvm/gems/ruby-2.6.6/gems/tty-prompt-0.21.0/lib/tty/prompt/question.rb:87:in `message_for'
/Users/bbugh/.rvm/gems/ruby-2.6.6/gems/tty-prompt-0.21.0/lib/tty/prompt/question/checks.rb:58:in `call'
/Users/bbugh/.rvm/gems/ruby-2.6.6/gems/tty-prompt-0.21.0/lib/tty/prompt/result.rb:17:in `with'
/Users/bbugh/.rvm/gems/ruby-2.6.6/gems/tty-prompt-0.21.0/lib/tty/prompt/evaluator.rb:20:in `each'
/Users/bbugh/.rvm/gems/ruby-2.6.6/gems/tty-prompt-0.21.0/lib/tty/prompt/evaluator.rb:20:in `reduce'
/Users/bbugh/.rvm/gems/ruby-2.6.6/gems/tty-prompt-0.21.0/lib/tty/prompt/evaluator.rb:20:in `call'
/Users/bbugh/.rvm/gems/ruby-2.6.6/gems/tty-prompt-0.21.0/lib/tty/prompt/question.rb:159:in `process_input'
/Users/bbugh/.rvm/gems/ruby-2.6.6/gems/tty-prompt-0.21.0/lib/tty/prompt/question.rb:114:in `render'
/Users/bbugh/.rvm/gems/ruby-2.6.6/gems/tty-prompt-0.21.0/lib/tty/prompt/question.rb:104:in `block in call'
/Users/bbugh/.rvm/gems/ruby-2.6.6/gems/tty-reader-0.7.0/lib/tty/reader.rb:107:in `subscribe'
/Users/bbugh/.rvm/gems/ruby-2.6.6/gems/tty-prompt-0.21.0/lib/tty/prompt/question.rb:103:in `call'
/Users/bbugh/.rvm/gems/ruby-2.6.6/gems/tty-prompt-0.21.0/lib/tty/prompt.rb:172:in `invoke_question'
/Users/bbugh/.rvm/gems/ruby-2.6.6/gems/tty-prompt-0.21.0/lib/tty/prompt.rb:193:in `ask'
/Users/bbugh/.rvm/gems/ruby-2.6.6/gems/tty-prompt-0.21.0/lib/tty/prompt/answers_collector.rb:73:in `public_send'
/Users/bbugh/.rvm/gems/ruby-2.6.6/gems/tty-prompt-0.21.0/lib/tty/prompt/answers_collector.rb:73:in `method_missing'
/Users/bbugh/projects/project/lib/tasks/sample/create.rake:12:in `block (3 levels) in <main>'
/Users/bbugh/.rvm/gems/ruby-2.6.6/gems/tty-prompt-0.21.0/lib/tty/prompt/answers_collector.rb:21:in `instance_eval'
/Users/bbugh/.rvm/gems/ruby-2.6.6/gems/tty-prompt-0.21.0/lib/tty/prompt/answers_collector.rb:21:in `call'
/Users/bbugh/.rvm/gems/ruby-2.6.6/gems/tty-prompt-0.21.0/lib/tty/prompt.rb:532:in `collect'
/Users/bbugh/projects/project/lib/tasks/sample/create.rake:9:in `block (2 levels) in <main>'
Tasks: TOP => sample:create

Expected behaviour
It would result in a value, like the other messages.
Describe your environment

OS version: MacOS Mojave
Ruby version: 2.6.6p146
TTY::Prompt version: 0.21.0

Hi Brian 👋
Thanks for using tty-prompt.
Before I try to answer your query, the current version is 0.23.0, so please upgrade as a lot has changed.

When using validate ->(input)... and customizing the message, the %{value} token is not present.

I'm curious to know how did you find the %{value}? I must admit this is the first time I hear about such an ability in the validate method and I cannot find it in the readme or the source code. I'm also curious about the %{} way of providing value, why this way? Is this a feature request?

Thanks for the quick reply!

Before I try to answer your query, the current version is 0.23.0, so please upgrade as a lot has changed.

Ack! Bundler strikes again. I just added the unversioned gem to my Gemfile and that's the version bundler pulled. Not the first time that has burned me - I've looked everywhere to see if bundler had some config hidden somewhere to choose cache over remote. Thanks for the heads up.

I'm curious to know how did you find the %{value}? I must admit this is the first time I hear about such an ability in the validate method and I cannot find it in the readme or the source code. I'm also curious about the %{} way of providing value, why this way? Is this a feature request?

It wasn't intended as a feature request, but I suppose it is now! It looks like I had a misunderstanding:

In the README, I saw that the %{value} token worked in convert and manually setting messages for range? and convert?.
When I put a binding.pry in at the tokenization code, the validate command had a token valid, but not value
I was able to get an output by trying both q.validate ->(input) { false }, "%{valid}" and q.messages[:valid?] = "%{valid}" which output the proc's inspect:File name: something
>> #<Proc:0x00007fe8956990f8@/Users/bbugh/projects/project/lib/tasks/sample/create.rake:30 (lambda)>

In Rails, validation messages also use %{value}, and I think this subconciously influenced my thinking.
Altogether, the result was that I made the incorrect assumption that the value token was expected to be available in all situations for setting messages (which would be really helpful in our use case).

My reply was way too hasty - sorry! I appreciate your patience with this issue. I only quickly looked at the validate method and didn't realise that %{value} is indeed used in convert and in methods. I 💯  agree that this should be supported. Do you have time to check against the master branch?

I checked on master, it works great! Thank you so much.
File name: test_file
>> Filename 'test_file' already exists!


Considering to Merge?

Hello,
are you considering to bring the API extensions to the main repo for this project?
If not, would it be possible to note in the readme what this fork does differently in a notable way and differentiate it more from the main repo?
Thanks,
Chris

+1

See https://github.com/illuspas/Node-Media-Server/pull/361

It's been merged you can close @chrisspiegl, thank you again.
https://github.com/illuspas/Node-Media-Server/pull/361


Fix missing close for canceled bundle downloads

Summary: Response is Closeable, so we must close it even if the download is no longer relevant. Found while running with StrictMode enabled and reloading quickly multiple times.
Differential Revision: D56629079

Merged as https://github.com/facebook/react-native/commit/dd51b38101a329abdf5edb9218e4bcda585c48eb


airline/powerline fonts broken on vim 8.1.0550

environment

This is with the powerline version of Fira Code

vim: 8.1.0550
vim-airline: I did PluginUpdate on Vundle, should be latest
OS: macOS High Sierra
Have you reproduced with a minimal vimrc: no
What is your airline configuration:let g:airline_powerline_fonts = 1
let g:airline#extensions#branch#enabled = 1
set laststatus=2
let g:airline#extensions#tabline#enabled = 1
let g:airline#extensions#languageclient#enabled = 0

if you are using terminal:

terminal: iTerm 2 Build 3.2.6beta2
$TERM variable: xterm-256color
color configuration (:set t_Co?): 256

actual behavior
Powerline fonts aren't rendered correctly on Vim 8.1.0550
expected behavior
Powerline fonts should be rendered correctly, as they are in Vim 8.1.0500

There haven't been any changes to neither Vim nor vim-airline that should affect the powerline fonts.  Please try with a minimal vimrc file.  Also, it looks like your updated vim does not use utf-8 encoding. Make sure this is enabled.

Setting utf8 encoding fixed the issue. Thanks!


[BEAM-1138] merging KeyedPValueTrackingVisitor with DirectGraphVisitor

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-1138] Description of pull request
[ ] Make sure tests pass via mvn clean verify.
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

@kennknowles does this look good?

Coverage decreased (-0.01%) to 70.573% when pulling 415df4a501c771e0133cd073c7643ebec8f1614f on hepeknet:BEAM-1138 into 2b470eaa385eff192db3d09c252d3a04b70acae8 on apache:master.

Thanks for putting this PR together. I think @tgroh is the best reviewer for this one.

Looks like this PR now has conflicts - can you rebase and force push please?

Any updates on this PR perhaps?


Add telegram handle in 100eyes

Feature: Auto-update telegram username
  As a user
  I want my user record in the database to be updated when I send a message to 100eyes via Telegram
  Because I want to change my telegram account name and the cached account name in the database must be updated accordingly

The telegram ID in our database must match the telegram id of the telegram user account. It is not wise to change the ID through the Web UI. Instead, everytime a user sends a message, we could update the user account with a potentially updated username. All telegram accounts have another, numeric ID, which seems to be immutable and we can distinguish user accounts via this numeric ID.

I'm going to edit this issue description..

BUT How to add a telegram user as 100eyes user (Lokalexperte) via interface?

It's not possible. You must initiate the conversation as the user.

BUT I want to create all my users in interface. The self-creation via telegram is spooky (at least).

No problem with double-opt-in. But CREATE has to be something different.

We will implement a way to create users manually, for E-Mail alone it's necessary. But we will not make the telegram username editable. If you want to have a user through Telegram, you must ask her/him.
@drjakob you can see the initial message of the bot when you send /start as a message to the Telegram bot. Right now it's saying `"Hello #{username}". Could you create a nice German explanation to ask the user to send an answer back to the bot?

"Hallo, schön, dass du an [PROJEKTNAME]* teilnimmst. Ich bin der Bot der Dialogsoftware 100eyes. Ich freue mich auf den Dialog mit dir. Bitte antworte mit kurz mit "Hallo" auf diese Nachricht, damit ich weiß, dass ich dir auf diesem Weg Nachrichten schicken darf."
Is it possible to fill [PROJEKTNAME] via 100UX? otherwise should be #50survivors


Documentation not updated for develop branch

General

pyfar version: 0.2.3

Description
The documentation for the develop branch is not updated on readthedocs. For example, the dsp/convolve is currently missing. We probably missed a setting somewhere?

I would suggest to drop develop from readthedocs.

Building the docs on rtd.org was simply broken due to dependency issues introduced by the use of the sofar and soundfile packages. I would vote for keeping building the develop docs for such cases.


New story that shows how a DataTable can be nested into another DataTable

Summary
It would be nice to have a new story that shows how a DataTable can be nested into another DataTable.
Justification
We already have a nice story that shows how to use regular Table nested into an expandable row of another regular Table (see http://react.carbondesignsystem.com/?selectedKind=Table&selectedStory=Nested Table&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Fstories%2Fstories-panel).
It would be nice to support nested DataTables as well and have a story demonstrating its usage.
Desired UX and success metrics
It should be possible to nest a DataTable inside the expandable row of another DataTable.
"Must have" functionality
Styles shouldn't break and it should be possible to have all the functionality of the nested DataTable working as expected, as is if it was a standalone DataTable.
Specific timeline issues / requests
No timeline! I have the feeling it should come out of the box with what we have, with a couple of minor styles adjustment such as IBM/carbon-components#2006
Available extra resources
See this code pen https://codepen.io/marcosimioni/pen/bZqKxN
I also have a story ready to be committed, I will attach it here as a PR.

Hi @marcosimioni! 👋 Thanks for taking the time to make this issue, unfortunately nesting data tables is not a use-case we support. Going to close this for now, but thank you so much for your time here 🙏

👍 Np! I totally understand! thanks for your comment!
Just to make sure @joshblack - based on the fact that we have a storybook story for nested Tables (http://react.carbondesignsystem.com/?selectedKind=Table&selectedStory=Nested Table&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Fstories%2Fstories-panel), does that mean this use case for regular Tables is supported?
I'd rather stay within the "boundaries" of the supported features, so .... if nested Tables is supported, then I will switch from DataTables to regular Tables indeed. For that I'm doing, they should be enough.

So the Table component shown currently was deprecated in v9, Table will instead point to DataTable.Table in v10 👍 Unfortunately this means that that use-case is going away in our next release 😞


Adaptive gradient clipping shouldn't be used in the final classifier layer

Describe the bug
In the paper it is mentioned that AGC is NOT used in the final layer.

Expected behavior
It will be great AGC can be disabled for final layer. Adding a check here may be sufficient to get the desired behavior.
Please let me know if i am misunderstanding something. Thanks.

Yeah, I did notice that in the paper, but I forgot to take note of it. I'll definitely add it. Thank you!

Hi, the SGD_AGC implementation kind of restricts the implementation since checking for linear layers makes it unusable for Transformer like architectures, but I could generalize this function in the generic AGC optimizer where I ignore the names of the modules. You can find the code in this commit eaa4b87173003a12b7927bd7e7553b47bfa55c7a and should be availble in the latest release. Do let me know if this works out !


Update general bibliography guidance to make exception to IETF, provide guidance for IETF

The "normal" bibliography guidance differs from IETF, where the Normative References and Informative References are two separate sections, and that the Informative References section is optional.
We should update metanorma.com for that. Thanks!
Ping @manuel489
Originally posted by @ronaldtse in https://github.com/metanorma/mn-templates-ietf/pull/12#issuecomment-643041672

PR added in https://github.com/metanorma/metanorma.com/pull/300

Task is merged. Closing.


BOLD dtypes are larger than necessary

fMRIPrep version: 20.1.0
In [1]: import nibabel as nb

In [2]: nb.load('sourcedata/sub-02/func/sub-02_task-repeatchange_run-5_bold.nii.gz').get_data_dtype()
Out[2]: dtype('<i2')

In [3]: nb.load('fmriprep/sub-02/func/sub-02_task-repeatchange_run-5_space-T1w_desc-preproc_bold.nii.gz').get_data_dtype()
Out[3]: dtype('<f4')

In [4]: nb.load('fmriprep/sub-02/func/sub-02_task-repeatchange_run-5_space-fsLR_den-91k_bold.dtseries.nii').get_data_dtype()
Out[4]: dtype('<f8')

I feel like I remember BOLD series being saved to the original precision, but I'm not hugely concerned about that. The CIFTI series should definitely not be float64.

The BOLD dtype is coerced to float32 when converted to GIFTI here
https://github.com/poldracklab/fmriprep/blob/eb3a40b827d277ce661e31c27f6ace40ef3c2be6/fmriprep/workflows/bold/resampling.py#L106-L115
I've submitted a fix for the CIFTI file @ https://github.com/nipreps/niworkflows/pull/532, would love to get your feedback to ensure I'm not causing a substantial change in the actual data

Now that the niworkflows PR is merged, can we just close this one?

we might want to fix the _preproc files first

i believe this is fixed now, closing


mommy should tell me her version

I know it's rude to ask mommy how old she is, but I'd like a way to ask her what her version is (and maybe a list of her moods).

A mood list can be kinda hacked around by doing CARGO_MOMMYS_MOODS="x", since we list the known moods when an unknown one is used.
Unknown mood x! We were compiled with: chill, thirsty, yikes
cargo mommy --version should probably detect the --version and print out the current version / known moods. Currently it just gets forwarded to cargo, so like
# cargo mommy --version
cargo 1.75.0-nightly (7046d992f 2023-11-08)
you did it~!

But
cargo 1.75.0-nightly (7046d992f 2023-11-08)
cargo-mommy 0.3.1 (0ec17361d8b)
<positive response, why not :3>

would be good

I think -v listing chill moods and -vV (or whatever the "really for reals cargo version" flag is) listing all moods would be reasonable.


Change --help formatting (and fix --info)

Change help formatting from

to

This avoids the help being pushed to right side by the longest option.
We DO NOT split the lines automatically and reflow them, you need to put newlines in the description manually, and keep each line short. This is to avoid splitting links (so they remain clickable), and to let the terminal reflow long lines, so user can widen their terminal and get the correct view without re-running.

Draft because I am waiting on whether I should keep the spaces between entries. And then I need to fix help tests that list the output literally.

Fails on native AOT tests now. Merging.


Stop current discovery process

There should be an option to stop the current discovery process via a button.
The only way to stop it currently is to change the text in the parts section, which isn't very obvious. Or refresh the page.

See https://github.com/iancoleman/multisig/commit/bba210911cf966cc91e6540cd458295851a589f8


Spelling

This is a simple commit on readability changing some spelling (Celsius, Fahrenheit) and capitalising when it's meant as text (and not code).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I haven't tested (as in, run the unt tests) as I have limited resources ATM.

Codecov Report

Merging #5 (cf33f67) into develop (be560fe) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop       #5   +/-   ##
========================================
  Coverage    99.36%   99.36%
========================================
  Files            5        5
  Lines          474      474
========================================
  Hits           471      471
  Misses           3        3

Impacted Files
Coverage Δ

tests/test_scalars.py
100.00% <100.00%> (ø)

tests/test_thermofeel.py
100.00% <100.00%> (ø)

thermofeel/helpers.py
95.23% <100.00%> (ø)

thermofeel/thermofeel.py
99.21% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be560fe...cf33f67. Read the comment docs.


Upgrading to 1.0 went bad

Hi,
coming from 0.10 to 1.0, the meta/raft.db file is preventing the new version to start.
There is a misleading message stating that it should be OK to delete it.
After deletion, the new version starts but the whole config is gone!
No problem for me to recreate the whole config but how may I reimport the previous data held in the olds .tsm files?
Also, please replace the message with a gigantic WARNING...

Strangely enough, when you create a database with the same name as the previous one, a "SHOW MEASUREMENTS" request lists all previously known measurements but no data point.

Upgrading to 1.0 from 0.10 requires a couple steps to update the metastore. Please see the documentation for upgrading from 0.10 to 1.0 for more detail. Please comment if the upgrade steps do not work as expected.

Please read the description again, the problem is how to reimport TSM data without the raft.db file?

FTR, here's the relevant documentation page: https://docs.influxdata.com/influxdb/v1.0/tools/influx_inspect/#influx-inspect-export
For me the final solution was:
$ influx_inspect export -dir /var/lib/influxdb -out export.txt -db your_db_name
$ influx -import -path=export.txt


Either-or modeling

There are several places in the model where it would be beneficial to specify that an attribute can be one of a choice of classes.  Examples include:

An item in an ordered list of outputs can be either a sublist or an output
A where clause can be either a simple condition (dataset/variable/comparator/value) or a compound expression
A compared value in a where clause condition can be either a single value or a multi-value list

At the moment, the first two examples are implemented simply as two different attributes, only one of which is expected to be used.  However, there is currently nothing in the model to constrain the use of the attributes.  The third example is currently implement as a multi-value list, which nothing in the model to constrain the number of values depending on the comparator.
Need to determine whether modeling of these types of constraint is needed and, if so, how should it be implemented.

Need to move this into a Discussion, as this PBI cannot be completed independently.


Merge in translations

Translation team commits that have latest Transifex translations were not cherry-picked for the 1.12 release.
The following commits should go into the recovery:
799166a481b75d6d3dc9f7f999f89e5b5645abcc, d87e0fe9e8065ecdca99da3d68d5abff952229df

I've cherry-picked all translations we had on master branch to the release.
Latest stats:
es has 5 untranslated strings.
fr has 5 untranslated strings.
it has 5 untranslated strings.
ja has 5 untranslated strings.
ko has 5 untranslated strings.
ru has 5 untranslated strings.
zh-cn has 6 untranslated strings.
zh-tw has 5 untranslated strings.

Please verify @dbaeumer 👼


HumanML3D and MoMask- Data I/O query

Hello, Thank you for great works in the motion-language field.
I would like to get some clarity, in general when momask or any transformer model, while using HumanML3D dataset;

Which numpy files are being used to train, and which data is obtained as the initial output from the models. Because when we setup HumanML3D dataset, we end up with new_joints and new_joint_vecs.
I understand there are several conversions and transformation between them and they are obtained from the raw joints data, however, I have a confusion as to which of these data the model actually sees, and ultimately outputs as tokens.
I assume from these output tokens the required formats (bvh, numpy, smpl etc) are recovered by processing further after the output from the models.

Please correct me if I am wrong, and kindly help me understand if it is the new_joints or the new_joint_vecs that go into the model and come out along with their associated texts.
Thank you.

Hi, thanks for you interests.
new_joint_vecs are motion feature vectors used as the model I/O and for better learning. Yes, the motion with traditional representation is recovered from this  motion feature vector.
new_joints are 3D motion recovered from new_joint_vecs to examine the feature extraction and recovering functions during HumanML3D preparation.

Hi @Murrol , I would like to quickly follow up with some additional queries.
Firstly thanks for the support.

I learnt that the data (frames, joints, co-ordinates)  is Y-up and in Right-Handed co-ordinate system, please correct me if Im wrong. However, I am unsure what rotation convention does this follow. Specifically the Euler angles/yaw,pitch,roll and their order + associated co-ordinates.
I believe these rotations can also be obtained from the 263 vectors, could you please guide me which of these columns are needed to extract these and how (the original motion processing in HumanML3D is quite challenging to understand this)

I appreciate your assistance and thank you again in advance :)

Yes, it's a y-up right-handed coordinate system. In SMPL pose parameter, the rotation representation is the Axis-Angle but not Euler Angle. You can convert the axis-angle to the Euler angle in your own rotation convention.
I'm not sure if we can extract the joint rotation information directly from the 263 vectors. For how to obtain rotations by optimization methods, you can refer to this answer https://github.com/EricGuo5513/momask-codes/issues/70#issuecomment-2316415620

One final question, so, the data (frames, joints, coordinates) is not in relative representation to its parent? So far, I have been assuming that's the case. Please confirm  if it is

global,
local to pivot/root (i.e., component),
or local to parent (relative)

Thank you for the answers. I will try the suggested method to extract angles.

they are global positions


Refactor Config-file-based auth

I wanted to support the credsHelper values in the .docker/config.json file. Along the way I kind of refactored all the code around that file and using it for credentials, because it was all kind of a mess.

Add support for credsHelper values in .docker/config.json. Closes #1037.
You can have different registries in the "auth" and "credsHelpers" sections, and their values will get used correctly. And if you want to auth with a registry that is not explicitly mentioned in either of those, the credential helper from "credsStore" will be used as a fallback. Closes #1042.
Added auto value classes DockerConfig and DockerCredentialHelperAuth to bind JSON into objects and avoid parsing out JSON in code. The former reflects the structure of the .docker/config.json file. The latter is the auth response received from a credential helper on a get, and sent on a store.
Abstracted all communication with credential helpers into its own class: DockerCredentialHelper. I implemented all the methods that are supported for these processes: get, list, store, and erase. (Right now only the get is used in any of the code, but the rest are available for users to use as they like. This might be something we want to expose through the main client? Or maybe not.) I followed the delegate pattern established in DockerHost (see #441 and code comments therein) to enable mocking out those system calls for tests.
Related to above, I removed some existing tests that were interacting with live credential helpers. I'm not comfortable storing and erasing values in secure locations on servers, let alone on my own machine, during tests. I didn't add back any tests of the credential helpers explicitly because... it feels like I would have just been mocking something and verifying that mock. I'd be testing "did Mockito work? yep!"
The credential helper get operation is mocked and used in some other tests that I added, since it is the one credential helper operation involved in the whole authentication chain.
There's probably other stuff I did in here.

Lastly, in my mind this fills some of the same role of the ECR support PRs #876 and #1013. Amazon has a docker credential helper (awslabs/amazon-ecr-credential-helper), so having that installed and referenced as a credsStore or credsHelper in your docker config file should allow docker-client to support it with minimal code changes. I don't know the degree to which this level of support is better or worse than a full ECR RegistryAuth implementation, because I don't know the intricacies of their auth API, so take that for what you will. But I expect (and hope) this will be sufficient to fulfill my needs.

Codecov Report

Merging #1051 into master will decrease coverage by 0.25%.
The diff coverage is 51.11%.

@@             Coverage Diff              @@
##             master    #1051      +/-   ##
============================================
- Coverage     67.37%   67.12%   -0.26%
- Complexity      774      795      +21
============================================
  Files           176      179       +3
  Lines          3234     3297      +63
  Branches        368      385      +17
============================================
+ Hits           2179     2213      +34
- Misses          898      921      +23
- Partials        157      163       +6

Ping @davidxia @mattnworb for review.

I didn't add back any tests of the credential helpers explicitly because... it feels like I would have just been mocking something and verifying that mock. I'd be testing "did Mockito work? yep!"

IMHO tests like what you can describe can still be useful to test that the class-under-test is behaving the way you expect based on the return value of the mocked method, but if all the class-under-test does is return the same value from the mocked method, then yeah I would agree it's not a very useful test.

I wrote some javadoc on the new classes DockerConfig, DockerCredentialHelper, and DockerCredentialHelperAuth. I also wrote some on RegistryAuth, even though I didn't write that, because why not?
I also rebased on master, cleaned up a couple things, and logged the changes.

thanks for also updating the changelog ❤

I'll try to release 8.12.0 with this in it next

my gpg is screwed up so I did not get to finish releasing this today, will take another crack on Monday.

8.12.0 has been released!