Suggested code should use formatting preferences of the editor

please complete the following information:

OS version: Windows_NT x64 10.0.19045
Editor: vscode
Editor version: 1.81.1
Programming language: js
TabNine extension version: 3.8.4
Engine version (could be located within Tabnine Hub): 4.5.28-60

Issue Details:
The suggested code does not obey formatting preferences, i.e. indentation as tabs, opening brackets on new line, etc
gz#26154(related to Zendesk ticket #26154)

@vanowm
Can you please send us an example? (Screenshot/video)
Can you please try and update your Tabnine version?

Well, that's kind of stupid if issues being closed due to inactivity...seriously???

Ok, which one is it? wontfix or completed? It's definitely not fixed.


Membership as a class

Wondering if there are plans to create a Membership class to be able to attach properties to the link between agents? Or is there another way to express this in the current version?
There you can express the start en especially the end Date of a Membership for example.

EditorialCommittee: A good idea. We support this and will integrate a class "Membership", with properties about the start and end time and a classification of the type of membership ("hasObjectType skos:concept").

I just came across the class Affiliation. It connects a Person and an Organisation, allows to classifiy the affiliation with a skos:concept and lets you set a start time and an end time.
However, in the current definition it cannot connect two Persons. Would that be sufficient anyway?

Hi Juergen, yes that's pretty much what it is I think.
I don't think it is necesary to connect more than one agent, since I think a membership should be a distinct class that connects one person (or one organisation) to one organisation.
So a group consisting of four members will have 4  "affiliations" connected to it?
Correct me if  I'm misunderstanding something...

Right.
Every member can have his own start and end time of the membership. That makes it neccessary to provide an affiliation per member.
However, I am not sure, whether we need to express 'affiliation' s between 'organisation' s and between 'persons' as well? If you have a case for that, please let us know!

Hi Juergen,
Between persons and persons, no. But organisations can be member of other organisations. (f.e. a daughther company or a subteam, a subrecordlabel...) ... and that membership can also be limited in time.
In that respect I think the word affiliation is not hierachical enough? In case of persons and organisations the relationship is always clear, but in case of organisations it needs to be made explicit which is the "bigger" part...
Just my two cents ofcourse!


When formatting XML used tab size is always 2 spaces

On Windows, Sublime 3143, Exalt 0.3.3 when I format an XML the tabs are 2 spaces instead of 4 as it is specified in the default Sublime preferences.

Sorry for the late reply.
I addressed this issue in https://github.com/eerohele/exalt/issues/1#issuecomment-233311727.

I wouls like to leave this ticket open - it's really like sand in shoes having tabs as 2 spaces :)  I'll pursue solution from within lxml.

Sure thing! If you find anything, please let me know and I'll definitely see about implementing it.
There was a post on Hacker News a couple a days ago about a single-file Python XML formatter that might be serve as alternative solution. I'll see if I can find it.

Maybe this http://effbot.org/zone/element-lib.htm#prettyprint? Even lxml mentions this element library.
I have to admit that I'm Python noob so I'm not sure how usable this might be for you.

The thing is that other than defining the indent width, lxml's pretty-printer works really well. Most other pretty-printers seem to rely on regular expressions and fall apart pretty quickly. That's why it's not necessarily very easy to find a replacement for lxml.

lxml seems to be calling the C code in here https://github.com/ConradIrwin/libxml2/blob/master/HTMLtree.c
Doesn't seem like an easy fix which seems crazy given how common an indent_spaces type param is for pretty printing functionality

Yep, the situation is really perplexing. I guess I have to live with it and do some post find/replace myself :|


Exploring existing namespaces instructions

I am trying to investigate how to add a new app to pychromecast however I am having trouble with the "Exploring existing namespaces" instructions. It seems chrome://net-internals/#capture has been replaced with chrome://net-export. I've followed the instructions provided on the chrome://net-internals/#capture page and have managed to import a net-export however I have been unable to find the Tr@n$p0rt section. Are there any updated instructions available for someone new to this project like me who is trying to get started?

When using https://netlog-viewer.appspot.com/#events and going through all SOCKETs I was able to find one that has a lot of JSON data. I'm pretty sure it's correct since it has stuff like
t= 6843 [st= 6654]  SSL_SOCKET_BYTES_SENT
                    --> byte_count = 154
                    --> bytes =
                      00 00 00 96 08 00 12 13  73 65 6E 64 65 72 2D 7A      .. ..sender-z
                      37 69 39 64 65 62 34 66  77 6F 6F 1A 0A 72 65 63   7i9deb4fwoo..rec
                      65 69 76 65 72 2D 30 22  23 75 72 6E 3A 78 2D 63   eiver-0"#urn:x-c
                      61 73 74 3A 63 6F 6D 2E  67 6F 6F 67 6C 65 2E 63   ast:com.google.c
                      61 73 74 2E 72 65 63 65  69 76 65 72 28 00 32 4A   ast.receiver( 2J
                      7B 22 72 65 71 75 65 73  74 49 64 22 3A 31 35 30   {"requestId":150
                      39 35 32 30 32 39 2C 22  74 79 70 65 22 3A 22 47   952029,"type":"G
                      45 54 5F 41 50 50 5F 41  56 41 49 4C 41 42 49 4C   ET_APP_AVAILABIL
                      49 54 59 22 2C 22 61 70  70 49 64 22 3A 5B 22 41   ITY","appId":["A
                      39 42 43 43 42 37 43 22  5D 7D                     9BCCB7C"]}


IdentitityServer persisted to Database

Hi,
Does someone managed with IdentityServer persisted to database ? Not InMemory Configuration.
I followed the guidelines, but i have an error when I try to add migrations:
dotnet ef migrations add InitialIdentityServerPersistedGrantDbMigration -c PersistedGrantDbContext -o Migrations/IdentityServer/PersistedGrantDbDb
Error:
No DbContext named 'PersistedGrantDbContext' was found.
Or
No DbContext named 'ConfigurationDbContext' was found if i add
dotnet ef migrations add InitialIdentityServerConfigurationDbMigration -c ConfigurationDbContext -o Migrations/IdentityServer/ConfigurationDb
Any help is appreciated.
Thanks.

Hi @mrccarvalho ,
did you implement the two necessary DbContexts & DbContextOptionsBuilders, which read the respective configuration and instantiate the DbContexts?
Best regards,
Florian

Hi @fhebel ,
first of all,  thank you so much for your reply.
I have this class and now the Contexts were found.
example for ConfigurationDbContext :

public class ConfigurationDbContext : IdentityServer4.EntityFramework.DbContexts.ConfigurationDbContext
{
public ConfigurationDbContext(DbContextOptions options,
ConfigurationStoreOptions storeOptions)
: base(options, storeOptions)
{
}
protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
{
if (!optionsBuilder.IsConfigured)
{
base.OnConfiguring(optionsBuilder);
}
}
}

on the other hand, i've got this error (after verbose migrations):

Found DbContext 'ConfigurationDbContext'.
Microsoft.EntityFrameworkCore.Design.OperationException: Unable to create an object of type 'ConfigurationDbContext'. For the different patterns supported at design time, see https://go.microsoft.com/fwlink/?linkid=851728
---> System.MissingMethodException: No parameterless constructor defined for type 'Clinguas.WebHost.Data.ConfigurationDbContext'.

Thank,
Best regards!

Hi @mrccarvalho,
sorry for my late answer.
Unfortunately it's more complicated. Keep in mind that dotnet ef migrations will actually run your code and connect to the database ...
Ok, so a good place to start is to create two context factories (sample: MigrationSimplDbContextFactory.cs):
public class ConfigurationContextFactory : IDesignTimeDbContextFactory<ConfigurationDbContext>

public class PersistedGrantContextFactory : IDesignTimeDbContextFactory<PersistedGrantDbContext>

Then you have to add your two new DbContexts to Startup.cs:
services.AddIdentityServerDataStore(_configuration);

I would suggest to implement
public static IServiceCollection AddIdentityServerDataStore(this IServiceCollection services, IConfiguration configuration)

in ServiceCollectionExtensions.cs like
public static IServiceCollection AddCustomizedDataStore(this IServiceCollection services, IConfiguration configuration)

And finally you need to initialise your IdentityServerDb in Startup.cs
public void Configure(IApplicationBuilder app, IWebHostEnvironment env)

I hope that helps ...
Best regards,
Florian
PS: You might want to go for a solution like I did for my commercial customers - that is to separate the tables of SimplCommerce from those in IdentityServer. Given that I'm using postgres I created a new schema and put the IdentityServer related tables there ...


DataFrame.getitem returns wrong type for a dict_keys object

import pandas as pd

some_columns = {
    "a": 1,
    "b": 2,
}
x  = pd.DataFrame.from_dict(some_columns)
y = x[some_columns.keys()]
reveal_type(y)  # note: Revealed type is "pandas.core.series.Series[Any]"

__getitem__ with a Generator is already annotated correctly, not clear to me why it doesn't use that overload here.

Generator requires a few different methods. I assume dict.keys() is Hashable and therefore the first matching overload is the Series overload.
Assuming str is the only iterable that we want to special case (@Dr-Irv), we could first have an overload for str, and then use Iterable (covers, lists, generators and dict.keys) but add an ignore comment (overlapping overloads).
There might be more places were we could first special case the exceptions, e.g., str, to then replace large list-like Unions with Iterable+ignore.


gpio dont change state in listener

Hi, with the new changes the listener is not getting the information for the tally status.
In fact, the gpio status change messages do not appear in the console

Which listener client?

tallyarbiter-gpolistener.py

Make sure that the GPO listener is NOT using the latest version of Python socketio client. A version increase was done recently and it’s not compatible with the tally arbiter server. You have to be on version 4 I believe.

@alverman did you get it working?

@alverman did you get it working?


sql batch return invalid results

The following query return nullPointerException. any idea?
I believe some data in this class make it return null pointer exception.
how can i send you guys a dummy data for your debug?
BEGIN
LET interest = SELECT * FROM interest ORDER BY (title ASC)
COMMIT
RETURN [$interest]

Hi

How do you send this data?  (Java, Binary, REST) ?
Which orientdb version are you using?

i have tried this at both console.bat and rest. both of them can't work as well.
FYI. i'm using latest version 2.0.3. i guess my data will cause this issue. Should i send you my schema for your debug?

i still have the issue after tested with 2.0.4 version.
FYI ..i will only work without array bracket.
A. Working Fine
BEGIN
LET interest = SELECT * FROM interest ORDER BY (title ASC)
COMMIT
RETURN $interest
B. No working
BEGIN
LET interest = SELECT * FROM interest ORDER BY (title ASC)
COMMIT
RETURN [$interest]

Tested and works. Created a function test():
BEGIN
LET interest = SELECT * FROM OUser ORDER BY name ASC
COMMIT
RETURN [$interest]

Then I've executed it from SQL:
select test()

Result:
{
    "result": [
        {
            "@type": "d",
            "@rid": "#-2:1",
            "@version": 0,
            "test": [
                [
                    "#5:0",
                    "#5:1",
                    "#5:2"
                ]
            ],
            "@fieldTypes": "null=z"
        }
    ],
    "notification": "Query executed in 0.123 sec. Returned 1 record(s)"
}

this is what i have at my end. any idea?
Cannot serialize record: com.orientechnologies.orient.core.sql.query.OResultSet@dc8ffcfd [ONetworkProtocolBinary]


Update site-recovery-support-matrix.md

Hi @Rajani-Janaki-Ram, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Rajani Janaki Ram). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@Rajani-Janaki-Ram : Thanks for your contribution to the Azure documentation! The author, @rayne-wiselman, has been notified to review your proposed change.

#sign-off


Upgrade configurations to python 3.7

@somexpert  @ldko This project doesn't seem to require changes in source code to upgrade it to python3. I have updated the dependencies and configuration settings to python3 and the tests worked fine. Please review this PR.

oh, also, if there are no backwards-incompatible changes, then couldn't we just merge this into master?

Well, it can be merged to master. But I'm not sure if the applications that use django-edtf are on python3, 'cos django-edtf has a dependency on edtf-validate.

oh, right, forgot that we're getting the py3 branch of that dependency. nvm then

Also, Is it necessary to run the tests in django 1.9 & django 1.10 anymore?

If we already have this deployed in Django 1.11 then I think we can drop tests for Django 1.9 and 1.10, since they aren't really supported anymore.

Shall I merge it directly to master as @somexpert suggested when you all think it's ready to get merged?

I think it makes sense, since django-edtf and its edtf-validate dependency are both compatible with Python 2.7 and 3+ on their master branches. But I may be overlooking something. What do you think, @ldko?

I think we should merge this into master.


Stylistic changes

Some small changes to the UI and text. This project has a lot of promise but there are some strange quirks to iron out, namely the interaction between hiding tabs manually and them fading out. Also, I feel that clicking next to the existing tabs should open a new tab. Anyway, going well and good luck!

Awesome! The changes look really good!
I will definitely look into the tabs-interaction.


add fixture 'eliminator/stealth-beam'

needed in this QLC+ forum thread

Export files validity
(Output of test script tests/github/exports-valid.js.)
Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>
Fixture eliminator/stealth-beam changed in this PR

d-light

attributes-correctness

:white_check_mark: eliminator/stealth-beam-5ch.xml
:x: eliminator/stealth-beam-16ch.xml
Show errors

Duplicate parameter name: FOCUS/PAN
Duplicate parameter name: FOCUS/TILT

ecue
ofl
qlcplus

xsd-schema-conformity

:white_check_mark: Eliminator-Lighting-Stealth-Beam.qxf


Fixed "Roadmap's" link, "good first issue" label link and added Milestone's link

Thanks for being watchful and contributing! :smile:


Conflation file structure

The conflation JSON now have a new line at the end that is breaking production scripts.

I can update our scripts, but we must separate the reaches and other data in different containers. Currently, they are all at the same level. Something like
"conflated_reaches": {...},
"otherdata": {...}

term
type
definition

reaches
dict
Reaches associated with the ras model. Reach ids are the keys of the nested dicts which contain the conflation results/metrics.

us_xs
dict
Contains relevant HEC-RAS info for the most upstream cross section associated with the reach.

ds_xs
dict
Contains relevant HEC-RAS info for the most downstream  cross section associated with the reach.

river
str
The river name for the cross section as it was specified in the source HEC-RAS model.

reach
str
The reach name for the cross section as it was specified in the source HEC-RAS model.

xs_id
float
The river station for the cross section as it was specified in the source HEC-RAS model.

min_elevation
float
The minimum elevation in the cross section station-elevation data as it was specified in the source HEC-RAS model.

max_elevation
float
The maximum elevation in the cross section station-elevation data as it was specified in the source HEC-RAS model.

eclipsed
bool
Specifies if the reach has been eclipsed (covered) by an upstream or downstream reach.

low_flow_cfs
int

high_flow_cfs
int

network_to_id
str
The to_id as specified in the attributes of the input hydrofabric layer.

metrics
dict
Contains the conflation metrics for the reach.

xs
dict
Metrics describing the deviations between centerlines at cross section locationss for the source HEC-RAS model and the hydrofabric.

centerline_offset
dict
Metrics describing the distance between the point where the source HEC-RAS centerline intersects the cross sections and the point where the hydrofabric reach intersects the cross section.

thalweg_offset
dict
Metrics describing the distance between the source HEC-RAS's thalweg and the point where the hydrofabric reach intersects the cross section.

lengths
dict
Metrics comparing the lengths of source HEC-RAS model centerline and the hydrofabric reach. These are computed from the most upstream cross section to most down stream cross section associated with the hydrofabric network.

ras
int
Length of the source HEC-RAS centerline between the most upstream and most downstream cross sections associated with the hydrofabric network.

network
int
Length of hydrofabric network between the most upstream and most downstream cross sections associated with the hydrofabric reach.

coverage
dict
Metrics describing tha extent of the hydrofabric reach that is covered by the source HEC-RAS model.

start
float
The upstream limit where the source HEC-RAS model provides coverage. Provided as a ratio of the entire hydrofabric reach.

end
float
The downstream limit where the source HEC-RAS model provides coverage. Provided as a ratio of the entire hydrofabric reach.

overlapped_reaches
list
Reaches that intersect the cross sections of the current reach.

eclipsed_reaches
list
Reaches that are eclipsed (covered) by the cross sections of the current reach.

metadata
dict
Metadata for the conflation.

source_network
dict
Data summarizing the source network

file_name
str
Source network file name.

version
str
Source network version.

type
str
Source network type.

conflation_png
str
A png depicting the conflation results.

conflation_ripple1d_version
str
The version of ripple1d used to conflate the source HEC-RAS model with the source network.

metrics_ripple1d_version
str
The version of ripple1d used to compute the conflation metric.

source_ras_model
dict
Metadata for the source HEC-RAS model.

stac_api
str
The stac api containing the source HEC-RAS model.

stac_collection_id
str
The stac collection containing the source HEC-RAS model.

stac_item_id
str
The stac item for the source HEC-RAS model.

source_ras_files
dict
files for the souce HEC-RAS model.

geometry
str
The geometry file used from the source HEC-RAS model.

forcing
str
The forcing file used from the source HEC-RAS model.

project-file
str
The project file used from the source HEC-RAS model.

plan
str
The plan file used from the source HEC-RAS model.

length_units
str
Units for the lengths specified in the conflation json.

flow_units
str
Units for the flows specified in the conflation json.

{
    "reaches": {
        "2826228": {
            "us_xs": {
                "river": "Baxter River",
                "reach": "Upper Reach",
                "min_elevation": 33.4,
                "max_elevation": 125.0,
                "xs_id": 84816.0
            },
            "ds_xs": {
                "river": "Baxter River",
                "reach": "Upper Reach",
                "min_elevation": 55.0,
                "max_elevation": 120.02,
                "xs_id": 84000.0
            },
            "eclipsed": false,
            "low_flow_cfs": 5668,
            "high_flow_cfs": 19588,
            "network_to_id": "2823932",
            "metrics": {
                "xs": {
                    "centerline_offset": {
                        "count": 2,
                        "mean": 14,
                        "std": 7,
                        "min": 9,
                        "10%": 10,
                        "20%": 11,
                        "30%": 12,
                        "40%": 13,
                        "50%": 14,
                        "60%": 15,
                        "70%": 16,
                        "80%": 17,
                        "90%": 18,
                        "100%": 19,
                        "max": 19
                    },
                    "thalweg_offset": {
                        "count": 2,
                        "mean": 383,
                        "std": 138,
                        "min": 286,
                        "10%": 305,
                        "20%": 325,
                        "30%": 344,
                        "40%": 364,
                        "50%": 383,
                        "60%": 403,
                        "70%": 422,
                        "80%": 442,
                        "90%": 461,
                        "100%": 481,
                        "max": 481
                    }
                },
                "lengths": {
                    "ras": 821,
                    "network": 838,
                    "network_to_ras_ratio": 1.02
                },
                "coverage": {
                    "start": 0.74,
                    "end": 1
                }
            },
            "overlapped_reaches": [],
            "eclipsed_reaches": []
        },
    },
    "metadata": {
        "source_network": {
            "file_name": "flows.parquet",
            "version": "2.1",
            "type": "nwm_hydrofabric"
        },
        "conflation_png": "Baxter.conflation.png",
        "conflation_ripple1d_version": "0.4.2",
        "metrics_ripple1d_version": "0.4.2",
        "source_ras_model": {
            "stac_api": "https://stac2.dewberryanalytics.com",
            "stac_collection_id": "ebfe-12090301_LowerColoradoCummins",
            "stac_item_id": "137a9667-e5cf-4cea-b6ec-2e882a42fdc8",
            "source_ras_files": {
                "geometry": "Baxter.g02",
                "forcing": "Baxter.f01",
                "project-file": "Baxter.prj",
                "plan": "Baxter.p01"
            }
        },
        "length_units": "feet",
        "flow_units": "cfs"
    }
}

NOTE: this example does not include an ecplipsd read...
 "eclipsed_reaches": ["1293098","1293099"]

@mdeshotel Overall looks great. Please see the attached markups in red for the terms description and here are some comments on JSON.
{
    "reaches": {
        "2826228": {
            "us_xs": {
                "river": "Baxter River",
                "reach": "Upper Reach",
                "min_elevation": 33.4,
                "max_elevation": 125.0,
                "xs_id": 84816.0
            },
            "ds_xs": {
                "river": "Baxter River",
                "reach": "Upper Reach",
                "min_elevation": 55.0,
                "max_elevation": 120.02,
                "xs_id": 84000.0
            },
            "eclipsed": false,
            "low_flow_cfs": 5668, // cfs should be removed
            "high_flow_cfs": 19588, // cfs should be removed
            "network_to_id": "2823932",
            "metrics": {
                "xs": {
                    "centerline_offset": {
                        "count": 2,
                        "mean": 14,
                        "std": 7,
                        "min": 9,
                        "10%": 10, // I think this is a lot of information, we should just have simple quartiles [11, 14, 17], but this is not a requirement
                        "20%": 11,
                        "30%": 12,
                        "40%": 13,
                        "50%": 14,
                        "60%": 15,
                        "70%": 16,
                        "80%": 17,
                        "90%": 18,
                        "100%": 19,
                        "max": 19
                    },
                    "thalweg_offset": {
                        "count": 2,
                        "mean": 383, // how come there is, this great of a difference when the centerline offset is only 14 feet
                        "std": 138,
                        "min": 286,
                        "10%": 305, // I think this is a lot of information, we should just have simple quartiles [11, 14, 17], but this is not a requirement
                        "20%": 325,
                        "30%": 344,
                        "40%": 364,
                        "50%": 383,
                        "60%": 403,
                        "70%": 422,
                        "80%": 442,
                        "90%": 461,
                        "100%": 481,
                        "max": 481
                    }
                },
                "lengths": {
                    "ras": 821,
                    "network": 838,
                    "network_to_ras_ratio": 1.02
                },
                "coverage": {
                    "start": 0.74,
                    "end": 1
                }
            },
            "overlapped_reaches": [],
            "eclipsed_reaches": []
        },
    },
    "metadata": {
        "source_network": {
            "file_name": "flows.parquet",
            "version": "2.1",
            "type": "nwm_hydrofabric"
        },
        "conflation_png": "Baxter.conflation.png",
        "conflation_ripple1d_version": "0.4.2",
        "metrics_ripple1d_version": "0.4.2",
        "source_ras_model": {
            "stac_api": "https://stac2.dewberryanalytics.com",
            "stac_collection_id": "ebfe-12090301_LowerColoradoCummins",
            "stac_item_id": "137a9667-e5cf-4cea-b6ec-2e882a42fdc8",
            "source_ras_files": {
                "geometry": "Baxter.g02",
                "forcing": "Baxter.f01",
                "project-file": "Baxter.prj",
                "plan": "Baxter.p01"
            }
        },
        "length_units": "feet",
        "flow_units": "cfs"
    }
}

terms.docx


parser: add mysql error ErrBadUser / ErrUserAlreadyExists

What problem does this PR solve?
Missing mysql error ErrBadUser and ErrUserAlreadyExists

Error number: 3162; Symbol: ER_USER_DOES_NOT_EXIST; SQLSTATE: HY000
Message: User %s does not exist.

https://dev.mysql.com/doc/refman/5.7/en/server-error-reference.html#error_er_user_does_not_exist

Error number: 3163; Symbol: ER_USER_ALREADY_EXISTS; SQLSTATE: HY000
Message: User %s already exists.

https://dev.mysql.com/doc/refman/5.7/en/server-error-reference.html#error_er_user_already_exists
What is changed and how it works?
Add mysql error ErrBadUser
Check List
Tests

No code

Code changes

None

Side effects

None

Related changes

None

This PR still in progressing.

LGTM


Use oauth2 plugin in hybrid mode to report errors

Summary
The deployment method adopts the hybrid mode(CP and DP).
When using the oauth2 plug-in, the token cannot be obtained on the DP node through /oauth2/token.
Error Logs
2020/08/03 23:11:02 [error] 23#0: *3685382 lua coroutine: runtime error: /usr/local/share/lua/5.1/kong/plugins/oauth2/access.lua:692: [off] cannot create 'oauth2_tokens' entities when not using a database
stack traceback:
coroutine 0:
[C]: in function 'generate_token'
/usr/local/share/lua/5.1/kong/plugins/oauth2/access.lua:692: in function 'execute'
/usr/local/share/lua/5.1/kong/plugins/oauth2/handler.lua:11: in function </usr/local/share/lua/5.1/kong/plugins/oauth2/handler.lua:10>
coroutine 1:
[C]: in function 'resume'
coroutine.wrap:21: in function coroutine.wrap:21
/usr/local/share/lua/5.1/kong/init.lua:758: in function 'access'
access_by_lua(nginx-kong.conf:89):2: in main chunk, client: <IP_ADDRESS>, server: kong, request: "POST /check/oauth2/token HTTP/2.0", host: "xxx.xx.com"
Reponse Content
Status Code: 500
{
"message": "An unexpected error occurred"
}
others

Kong version 2.1.0
DP Node

question
Can I use oauth plug-in in hybrid mode?
Are there other solutions?

Plugin compatibility of DB-less mode of kong applies to hybrid mode.
Please refer to this document: https://docs.konghq.com/2.1.x/db-less-and-declarative-config/#plugin-compatibility


About the pre-trained model

Thanks for your work! I wonder if "patrickjohncyh/fashion-clip" is the 1.0 model or 2.0 model?

Hello!
It's the 2.0 model, we replaced the weights:)


Add instructions on creating a project and setting default region

gcloud  config set compute/region us-central1

Let's avoid putting to much Google specific documentation in this repo. I want people to focus on the basic usage of VMs and networking which could translate into any environment.

I need to verify, but I think unless you set the region, some of the magic that is used to set variables fails (since it sets the variable from standard output)


'PLOCAL' was not found

OrientDB Version: v.3.0.23
Java Version: "11" 2018-09-25
OS: macOS 10.14.6 (18G95)
Steps to reproduce
Installed via Docker, docker-compose.yml :
version: '3'

services:
  orientdb:
    image: orientdb
    ports:
      - 2424:2424
      - 2480:2480
    environment:
      ORIENTDB_ROOT_PASSWORD: 'blabla'
    volumes:
      - ./orientdb/backup:/orientdb/backup

Now I need to create a db :

$ sudo docker run --rm -it orientdb /orientdb/bin/console.sh
orientdb> CREATE DATABASE PLOCAL:/databases/testdb

And getting :
orientdb> CREATE DATABASE PLOCAL:/databases/testdb

Error: com.orientechnologies.orient.core.exception.OConfigurationException: Error on opening database: the engine 'PLOCAL' was not found. URL was: PLOCAL:/databases/testdb. Registered engines are: ["embedded","remote"]

What do I miss here, please ? Thanks

@petervavro use this CREATE DATABASE remote:/databases/testdb ODBUSER ODBPWD plocal;
But the documentation is completely outdated.
Even the REMOTE:localhost throws an error. We have to write in lowercase to make it works...


[planned feature] add interface for OSQP

This is just an announcement of intent. I have recently looked into OSQP for use in micom as a QP solver suitable for large systems
and it looks decent. It is a bit slower than cplex or gurobi (about 10x) for bad problems but is robust and decently accurate. Package itself is pip or conda installable so it should be doable. One drawback is that it does not have a dedicated LP solver (you can solve LPs but it is less efficient than "real" ones). Still a good addition I would say.

This looks very nice. An open source QP solver would definitely be a good addition.


Support reload action in g:fzf_action

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[x] Linux
[ ] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[x] bash
[x] zsh
[ ] fish

Problem / Steps to reproduce
The following command works as expected on the commandline
ls | fzf --height=10 --bind='ctrl-p:reload(ls -A)'

It has the effect of using ls until user pressed Ctrl-P which then also shows the hidden files. I want to be able to do the same thing in neovim with the basic fzf plugin instaled.
Modify neovim config to include:
nnoremap <silent> <C-p> :call fzf#run(fzf#wrap({'source': 'ls'}))<CR>

let g:fzf_action = {
      \ 'ctrl-p': 'reload(ls -A)',
      \ }

However, this does not work and just closes the FZF window.
Is there a way to accomplish this in neovim?
Note: ls and ls -A are just examples. I want to be able to do this with other commands too.

g:fzf_action was not designed for that purpose.
You can do it like this.
nnoremap <silent> <C-p> :call fzf#run(fzf#wrap({'source': 'ls', 'options': ['--bind', 'ctrl-p:reload:ls -A']}))<CR>

Thanks! This worked great


Added project live codepen Editor

This closes #1017

Please review this @Kushal997-das

@Arpcoder , I’ve reviewed your code and noticed a few areas that need improvement. Here are the details:
Specific issues and suggestions :

Dead code files shall be removed.
Have a clear and organized repository structure.
Web development project should be deployed and the link should be provided in the readme file for inspection.
Also add images of the project in the readme file.

@Arpcoder , I’ve reviewed your code and noticed a few areas that need improvement. Here are the details:
Specific issues and suggestions :

Dead code files shall be removed.
Have a clear and organized repository structure.
Web development project should be deployed and the link should be provided in the readme file for inspection.
Also add images of the project in the readme file.

Which level label you will give to this issue?

@Arpcoder First fix the things what ghsharma said , before bothering about level.

@Arpcoder First fix the things what ghsharma said , before bothering about level.

Done

See the output is not showing properly. Try to fix that out.

Its already fixed.. If you refresh it, it will work properly... But leave now.


Fix torchvision MNIST download

This PR contains:

Adding the User-Agent header for torchvision MNIST dataset requests.

See pytorch/vision#3497 for more details.

Jenkins please retry a build

Jenkins please retry a build


nodesConfig pkg added (nodes.config object)

nodes.config object pkg

Please add unit test coverage.
Link for more info: https://github.com/openshift-kni/eco-goinfra#note-every-new-package-requires-a-coverage-of-all-its-public-functions-with-unit-tests-unit-tests-are-located-in-the-same-package-as-the-resource-in-a-file-with-the-name-resource_testgo-examples-can-be-found-in-configmap_testgo-and-metallb_testgo

Please add unit test coverage.
Link for more info: https://github.com/openshift-kni/eco-goinfra#note-every-new-package-requires-a-coverage-of-all-its-public-functions-with-unit-tests-unit-tests-are-located-in-the-same-package-as-the-resource-in-a-file-with-the-name-resource_testgo-examples-can-be-found-in-configmap_testgo-and-metallb_testgo

sure, but few questions before:

why you didn't ask about it for the apiservers and for the imageregistry pkg?
nodes.config with the name cluster is also created during cluster deployment and can be only edited (like changing cgroup value) - do we still need a unit test?

@kononovn all I can do is just to create an empty _test file

@trewest @achuzhoy @cdvultur PTAL


High Level API has been dropped

High Level API is the most poverful and extendable API of QPL. In perspective it is the best way to support IAA without user affection. JobAPI is ugle, not threadsafe and doesnt extendable without user affection and require a lot of memmory to keep JobAPI structure.
Moreover High level API was designed to resolve QPL workflow during compile time. In the first implementation it showed x1.5 performance grow in comparison with JobAPI, without microarhitectural optimisation.
In the long perspective, High level API must been replace Job API as library primary interface. I am sad that we didnt completed our goal.
PS. std runtime for C++ for C libraries is bad way. It will drop user expectations from the library.

Hi @Arvinos,
Thanks for the feedback, I do understand your point. However, High-Level API was not considered complete in the timeframe of major release, so the team had to make a call. It doesn't mean though that in the future Job API will stay the same and won't be converted to something resembling previous HL API model, or that for instance we won't re-introduce HL API. Your previous work is greatly appreciated and not lost.
As for C++-runtime, it is indeed not an ideal situation, but this dependency didn't appear with the latest commits btw, and if issue appears this would be re-worked of course.

Thanks for the answer. I hope, we will see that our work, ideas be completed at full.
Job API must die)


CAN Readings Leaf 2018

hi,
I'm using your android app, but its seems that in the newest leaf it can't read all the data. If i guess correctly if the data is not valid you don't upgrade it and leave it to default.
An example is that state of charge is always 100%(while in my car it was 95%).
Did you know if the protocol is different or there is some kind of bug?

The codes for 2018 are different and I haven’t been able to analyze logs users have sent me. I hit road blocks with Cordova and went on to develop an OBD Cordova plug-in. Haven’t had lots of time to tinker.

where did u take this log(if they are public)? or can you share them somehow?

in particular i need to know at least the basic information:
Speed
SOC (%)
available distance(Km)
do you think is possible with the log you have?

Any news on 2018+ models?
@Raven5650 did you get them eventually? I can't find any hints on the web :/


Namespaces not working in a browser

It throws on the second select() in a browser.
On Node.js it works.
If a: prefixes are removed it also works in the browser.
const select = xpath.useNamespaces({
  a: 'http://schemas.openxmlformats.org/spreadsheetml/2006/main'
})
const doc = new XMLDOM.DOMParser().parseFromString(xml)
values = select('//a:si', doc)
  // `Error: XPath parse error`
  .map(string => select('.//a:t[not(ancestor::a:rPh)]', string).map(_ => _.textContent).join(''))

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>\r\n<sst xmlns="http://schemas.openxmlformats.org/spreadsheetml/2006/main" count="4" uniqueCount="4"><si><t>One</t></si><si><t>Two</t></si><si><t>Three</t></si><si><t>Four</t></si></sst>

Edit: I checked again and actually it does return something select('//a:si', doc).
The second select throws Error: XPath parse error though.

So seems that it doesn't like the expression .//a:t[not(ancestor::a:rPh)].
Could be a xmldom issue then,

Ok, I'll just use the native XML for browser.

Reopen if you feel like this is an issue.

@catamphetamine I suspect this is probably a node name casing issue. HTML DOMs treat all node names as being all lowercase even if the actual tags have some other casing. So I suspect that the a:rPh node test is failing to find the intended nodes because they have a capital P in the name.
You can probably fix this by explicitly indicating the MIME type when you parse the markup:
const doc = new XMLDOM.DOMParser().parseFromString(xml, 'text/xml')

@JLRishe Thanks, though I don't think it's the case.
Yesterday I was fiddling with those selectors reducing them to simple ones and still got the error in the browser (most likely I did try removing the :not condition).
The other thing is, yeah, I migrated it to native DOMParser and it worked.
Today, when I got your comment, I went to test it and replaced native DOMParser with this library, and when using .evaluate() instead of select() it worked for some reason.
I no longer have the old select() code, it has been discarded yesterday, but now I see that when using xpath through .evaluate() it no longer throws in a browser.
I'll still use the native one though just because it's the native one and is supported in most browsers (incl. IE11).
https://github.com/catamphetamine/read-excel-file/blob/9965134deffc68ced0df1a3f3393dd1a96cd99fe/source/xmlNode.js
https://github.com/catamphetamine/read-excel-file/blob/9965134deffc68ced0df1a3f3393dd1a96cd99fe/source/xmlBrowser.js

@JLRishe Oh, actually, I just noticed: it's not using .evaluate() at all, seems that I moved that to simple select() yesterday.
So, yeah, weird, but now it works, even though using the same .useNamespace() and select().
I guess it could have been my code after all.

@catamphetamine Thanks for the update. After re-reading your initial post, I realize that my guess about node name casing was almost definitely wrong because I now noticed that the error you were getting was an XPath parse error, and nothing in the DOM would have caused that kind of error. I guess this will just have to remain a mystery.

I guess this will just have to remain a mystery.
Agreed )


Kekulized QM9

I was wondering if the qm9 dataset can be loaded with the molecules Kekulized or should I simply  turn smiles to mol and kekulize it and extract data from that kekulized smiles? Thanks!

Each Preprocessor have kekulize option.

https://github.com/chainer/chainer-chemistry/blob/56e83dedb5de9dc9eb08ebf292be9ba76a4883ba/chainer_chemistry/dataset/preprocessors/nfp_preprocessor.py#L28

So when you call get_qm9 method, you can pass preprocessor which is instantiated with kekulize=True

https://github.com/chainer/chainer-chemistry/blob/master/examples/qm9/train_qm9.py#L107-L113

Thanks!


Make it much easier to use Money instances with 'sum' builtin.

It also makes it much easier to do certain kind of calculations where you
start with a zero value (of 'any' currency), and build from there.

A rebased version of this has been merged to master.


Add topic "gitops"

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I am not the sole author or employee of a company who created the topic or collection I'm changing.

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
[ ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Similar to DevOps, AutoDevOps, ChatOps and DevSecOps, also GitOps can be part of a software development workflow.

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[ ] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Always a pleasure!


Idea: have a secion on website for followers of twitter: to create a sense of empathy

I got the idea from the website Ultrasoundmoney, which is related to Ethereum, and I think it will work well for the conditions of Iran.
The goal: is to create a sense of empathy between Twitter followers and a voice between people.
My suggestion is that these two emojis
One is: ✊Raised Fist and the other is Dove 🕊
✊🕊
https://emojis.wiki/dove/
https://emojis.wiki/raised-fist/
Anyone can join this movement by adding the emojis to their name or bio.
We will also create a Twitter list that everyone follows and will be a member of.
It needs a front end and an API.
Sample:
https://ultrasound.money/
With suggested emoji:

If you are ok, I can start working on it.

This is a good idea, but I'm not sure how much of an impact we can have on this. If the idea is get people to start adding those emojis to their bios, then I'm not sure how effective we can be to make that happen.
I like the idea of having a list of supporting users/profiles in one place, and I love the idea of creating a space where people feel like a family, all supporting the same cause. I just feel like there might be a better way to make it happen.


cmd/go: go get -u on main module bloats go.mod with unnecessary dependencies

What did you do?
Consider this simple test app:
package main

import (
	"fmt"
	"time"

	"github.com/jinzhu/gorm"
	_ "github.com/lib/pq"
)

var db *gorm.DB

func init() {
	var err error

	db, err = gorm.Open("postgres", "postgres://gorm:gorm@<IP_ADDRESS>/gorm?sslmode=disable")
	if err != nil {
		panic(err)
	}
}
func main() {
	t := time.Time{}
	db.Debug().Raw("SELECT NOW()").Row().Scan(&t)
	fmt.Println(t)
}

go.mod is also pretty simple:
module SomeDBTest

go 1.12

require (
	github.com/jinzhu/gorm v1.9.9
	github.com/lib/pq v1.1.1
)

Lets try to update this app dependencies by running go get -u -d, resulting go.mod will look as follows:
module SomeDBTest

go 1.12

require (
	cloud.google.com/go v0.41.0 // indirect
	github.com/DataDog/zstd v1.4.0 // indirect
	github.com/Shopify/sarama v1.23.0 // indirect
	github.com/denisenkom/go-mssqldb v0.0.0-20190710001350-29e7b2419f38 // indirect
	github.com/eapache/go-resiliency v1.2.0 // indirect
	github.com/go-kit/kit v0.9.0 // indirect
	github.com/gogo/protobuf v1.2.1 // indirect
	github.com/golang/protobuf v1.3.2 // indirect
	github.com/gorilla/mux v1.7.3 // indirect
	github.com/jcmturner/gofork v1.0.0 // indirect
	github.com/jinzhu/gorm v1.9.10
	github.com/kisielk/errcheck v1.2.0 // indirect
	github.com/konsorten/go-windows-terminal-sequences v1.0.2 // indirect
	github.com/lib/pq v1.1.1
	github.com/onsi/ginkgo v1.8.0 // indirect
	github.com/onsi/gomega v1.5.0 // indirect
	github.com/openzipkin/zipkin-go v0.2.0 // indirect
	github.com/pkg/errors v0.8.1 // indirect
	github.com/prometheus/common v0.6.0 // indirect
	github.com/prometheus/procfs v0.0.3 // indirect
	github.com/rcrowley/go-metrics v0.0.0-20190706150252-9beb055b7962 // indirect
	github.com/sirupsen/logrus v1.4.2 // indirect
	github.com/stretchr/objx v0.2.0 // indirect
	golang.org/x/crypto v0.0.0-20190701094942-4def268fd1a4 // indirect
	golang.org/x/exp v0.0.0-20190627132806-fd42eb6b336f // indirect
	golang.org/x/image v0.0.0-20190703141733-d6a02ce849c9 // indirect
	golang.org/x/mobile v0.0.0-20190711165009-e47acb2ca7f9 // indirect
	golang.org/x/net v0.0.0-20190628185345-da137c7871d7 // indirect
	golang.org/x/sys v0.0.0-20190712062909-fae7ac547cb7 // indirect
	golang.org/x/tools v0.0.0-20190712213246-8b927904ee0d // indirect
	google.golang.org/genproto v0.0.0-20190708153700-3bdd9d9f5532 // indirect
	google.golang.org/grpc v1.22.0 // indirect
	gopkg.in/jcmturner/gokrb5.v7 v7.3.0 // indirect
)

Now let's try go mod tidy if it's possible to remove some redundant dependencies:
module SomeDBTest

go 1.12

require (
	cloud.google.com/go v0.41.0 // indirect
	github.com/denisenkom/go-mssqldb v0.0.0-20190710001350-29e7b2419f38 // indirect
	github.com/jinzhu/gorm v1.9.10
	github.com/lib/pq v1.1.1
	golang.org/x/crypto v0.0.0-20190701094942-4def268fd1a4 // indirect
)

What did you expect to see?
Result of running go get -u -d should match corresponding go mod tidy on updated dependencies in go.mod, or match those lines in go.mod being updated according to documented behavior of go get -u without adding any additional indirect dependencies.
What did you see instead?
go.mod is bloated with indirect dependencies, forcing user to run go mod tidy additionally, or edit it manually.
System details
go version go1.12.7 windows/amd64
GOARCH="amd64"
GOBIN=""
GOCACHE="C:\Users\***\AppData\Local\go-build"
GOEXE=".exe"
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="windows"
GOOS="windows"
GOPATH="C:\Users\***\go"
GOPROXY=""
GORACE=""
GOROOT="c:\go"
GOTMPDIR=""
GOTOOLDIR="c:\go\pkg\tool\windows_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="NUL"
GOROOT/bin/go version: go version go1.12.7 windows/amd64
GOROOT/bin/go tool compile -V: compile version go1.12.7

@inliquid would you be able to try this with the Go 1.13 beta?
There were some bug fixes in this area (e.g., #29702), as well as the overall upgrade behavior changed in a way that often fairly dramatically decreases how many indirect dependencies get updated by go get -u, which also affected the meaning of several go get flags. This is summarized in the go get section of the draft Go 1.13 release notes:
https://tip.golang.org/doc/go1.13#go-get

@thepudds
Tried with this version:
$ gotip version
go version devel +89d300b Sun Jul 14 20:15:47 2019 +0000 linux/amd64

After running go get -u -d there is clean go.mod file with updated versions of dependencies and no indirect entries:
module SomeDBTest

go 1.13

require (
        github.com/jinzhu/gorm v1.9.10
        github.com/lib/pq v1.1.1
)

Then I tried go mod tidy with same result. Very good!

Glad to hear this is working. This was fixed in CL 174099 and a few follow-up CLs. Unfortunately, it's too big of a change to backport.
Previously, go get -u meant "upgrade the named modules and everything they transitively require". Without arguments, it would start at the main module, so it would upgrade everything in the module graph (way more than what anyone wants).
In go1.13, go get -u means "upgrade the modules providing the named packages and everything they transitively import". This is much narrower, and more similar to what go get -u did in GOPATH mode.


Make a let%bench or let%test that enqueues a bunch of transactions into the parallel scan to see how big it gets

(Deepthi) (paul found a preallocation library)

We now have a tool to tell us the size. Closing.


Plan on Vimeo

Hello guys
I trying to use the Viemo SDK on my Unity game, but even with the starter plan it still give me the error that must be Viemo PRO or Business
But here in the Vimeo Pricing plans, it don't have the pro plan
Which one of them we suposse to use?
Thanks

is vimeo support dead? can some one pls reply or is entire development team for this SDK been laid off?

Standard and above are the only plans that work. But it seems their team doesn't update the SDK anymore.


Unable to Start session

Hi,
me and a friend have been using this for a few months with no issues but couldn't get it to work recently.
Not doing anything fancy, just a game purchased on Steam that we've played before, and both using Windows 10 PCs.
Here's his description of what was happening on his end:
"so usually a web page opens and then the picture is loaded from your screen. This time the site started loading your screen for a couple of seconds, and I saw your screen, but then it threw me back to the site page and nothing further happened."
I tried sending him an invite a few times, and rebooting the game, but to no avail.
not sure if anyone else ran into anything similar recently.

had the same issue today, and this time I tried rebooting my computer, and it started working again.
So I guess just needed to do that.


Update 9.8.md

Add microflow changes require restart problem to known issues.

Hi @emirmx - was this KI verified by your SDM to be public? Also, what is the Jira issue for the fix?


How to avoid the loop when removing all options

I'm using the select to fetch some data for a calendar (fullcalendar.js) like this
var select_categories = tail.select(".select-categories", {
        search: true,
        multiSelectAll: true,
        locale: 'fr',
 });
select_categories.on("change", function(){
        calendar.refetchEvents();
}

the select has 19 options and it works great, but when i clic on "All" or "Remove all" the calendar.refetchEvents() event is called 19 times making 19 ajax requests which make the calendar very slow. In this situation how can i do to make only one request ?

Can you cache the result of the refetchEvents()? I don't know how exactly it's working.
Also, if you think this is a tail.select issue, feel free to submit a PR.


Update podspecs for latest Fabric changes

Summary
This pull request updates the Podspecs to reflect recent changes to Fabric, so they build with Fabric enabled again.
In React-Fabric.podspec, subspecs for the views legacyviewmanagerinterop, safeareaview, textinput, and unimplementedview are added. A minor tweak to the subspec for rncore was added blacklisting two codegen-generated files that have issues building, but are not actually needed yet and are empty.
In React-graphics.podspec, the header paths for Boost were added.
This is partially a retread of #26805, which had to be backed out due to issues with the changes to the Yoga podspec.
Changelog
[Internal] [Fixed] - Fixed building Fabric with the Cocoapods
Test Plan
RNTester can now compile.

It looks like the test_ios_detox_frameworks and test_ios_unit_frameworks failures on Circle CI are legit (we fixed these in master last week). To reproduce locally:
cd react-native
yarn
(cd RNTester && USE_FRAMEWORKS=1 pod install)
yarn test-ios

Output:
Testing failed:
	'boost/static_assert.hpp' file not found
	'memory' file not found
	'functional' file not found
	'cassert' file not found
	Could not build module 'jsireact'
	'iosfwd' file not found
	Could not build module 'React'
	Could not build module 'React'
	Testing cancelled because the build failed.

** TEST FAILED **

The following build commands failed:
	CompileC /Users/hramos/Library/Developer/Xcode/DerivedData/RNTesterPods-bgablzpmrtdrulbrsgmoybpwucma/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/React-RCTAnimation.build/Objects-normal/x86_64/RCTAnimationUtils.o /Users/hramos/fbsource/xplat/js/react-native-github/Libraries/NativeAnimation/RCTAnimationUtils.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler

Thanks, I'll take a look at that

Instead of removing those headers from private_header_files , I added  "$(PODS_ROOT)/Headers/Private/React-Core" to legacyviewmanagerinterop's header search paths - this is how it appears other specs are getting to these headers already. All tests now pass.


Allow disabling default keybindings

I have an insert mode keybind on <C-c><C-c>, which conflicts with the default <C-c> keybinding in nvim-cmp in such a way to cause Neovim to get stuck in an infinite loop and using up 100% CPU until I kill the process as soon as I press <C-c>.
…but that's a different issue for a different day.
There does not seem to be a way for me to disable this keybind currently, which is what I intend to address here.
Trying to configure it to nil does not work, as Lua cannot tell the difference between the key not being set and the key being set to nil.
The README mentions that you can get rid of entire tables by setting the value to false, but here I only want to remove a single table value and not the entire table. Setting the mapping to false causes an error to happen on every keypress instead since the keypress logic assumes all mappings are functions.
Setting the key to a placeholder function that just calls fallback (function(fallback) fallback() end) also does not work as it still triggers the bug for me.
This MR extends utils.misc.merge with this feature:

When base value is a function and the override is false, then the key is removed instead.

I understand that this is a very weird way to go about it. This is my initial suggestion with the least amount of changes needed, but I have some other alternatives that we could consider:

Alternative 1: We introduce our own sentinel value, like cmp.remove_key that you assign it to.
Alternative 2: In the system using mappings, filter out all non-functions before using it.

I hope this can open us up for a bit of discussion on how to solve this particular thing. I personally prefer Alternative 1 to the solution in this PR.
I added some more tests to the merge function before I remade it. I might have missed some feature of it, so please check my work here.

@Mange Thank you for your contribution. Your intention is correct but I think we should remove <C-c> default mapping for now.
I think vim.NIL can be used to removes the key explicitly. What do you about this of it?


modified state value is not reflected into the input field.

What version of million are you using?
2.6.4
Are you using an SSR adapter? If so, which one?
None
What package manager are you using?
yarn
What operating system are you using?
Windows
What browser are you using?
Chrome
Describe the Bug
The variable's state get reset when passing empty string but the input field doesn't get emptied. Problem is demonstrated more clearly through a video
https://github.com/aidenybai/million/assets/12785891/abd5b0cc-39e6-4271-bb73-d09643629e80
What's the expected result?
When resetting the status to empty value, then input field should be reset as well.
Link to Minimal Reproducible Example
Check the video (easy to reproduce)
Participation

[ ] I am willing to submit a pull request for this issue.

I'll come back to this issue when I have a better network connectivity

I had the same issue, I switched to making my input form an uncontrolled component in #655
I wasn't sure if its my implementation problem or the way million decides when to pass updated props to the child component.

I notified core team about this @UzairNoman, @vimode. Thank you both for this. We'll be looking into it.

This issue seems to be related to #797.

/bounty $50

Hey folks, as mentioned on MDN's setAttribute documentation

Using setAttribute() to modify certain attributes, most notably value in XUL, works inconsistently, as the attribute
specifies the default value. To access or modify the current values, you should use the properties. For example, use
Element.value instead of Element.setAttribute().

I've fixed it, opened a PR, and used el.value for such cases. It worked successfully here (I tested it against the github-user-search example). Let me know if there are any tweaks required for #833 :smile:

/attempt #680

/attempt #833


Touch Bar support

Basic Touch Bar support: compose button, and prev/next conversation navigation.
Also fixes prev/next navigation and changes keyboard shortcuts to ⌘[ and ], as ⌃[⇧]⇥ conflicts with the search feature (and the page overrides). I'm closing #343 since this PR includes it.

Since I don't have a computer with TouchBar, I unfortunately have no way of testing this.

After building and running in Xcode, you can enable the Touch Bar simulator from the Window menu (⌘⇧5).

@rsms You can also test it with Touch Bar Simulator (No Xcode needed).


⚠ Bofrost.lu has degraded performance

In aab24c4, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1013 ms

Resolved: Bofrost.lu performance has improved in 11e13f4.


Automated cherry pick of #1667: fix: task usercred should be utf8 charset

Cherry pick of #1667 on release/2.8.0.
#1667: fix: task usercred should be utf8 charset

/lgtm
/approve


[GoogleMap]: Markers aren't cleared out when provided backing field changes

Environment details
Kotlin 1.9.10
AGP 8.3.0-alpha11
Maps Compose 4.1.1
Compose Plugin 1.5.10
Steps to reproduce

Add a GoogleMap() composable and render MarkerComposables from a List provided by a ViewModel State or other data source
Change the List contents
Observe the contents within the markers change but not the positions

Code example
@Composable
actual fun MapView(
    modifier: Modifier,
    contentPadding: PaddingValues,
    userLocation: LatLong?,
    resultLocations: List<Stay.Minimal>,
    useTotalPrice: Boolean,
    onMarkerSelectionChange: (String?) -> Unit,
    onMapMoved: () -> Unit,
) {
    [...]

    BoxWithConstraints(modifier = modifier) {
        GoogleMap(
            modifier = Modifier.matchParentSize(),
            contentPadding = contentPadding,
            contentDescription = "Map view for properties with applied filters and search parameters",
            cameraPositionState = cameraPositionState,
            properties = properties,
            uiSettings = uiSettings,
            onMapClick = { currentSelectedMarkerId = null }
        ) {
            resultLocations.forEach { listing ->
                val location = LatLng(listing.location.latitude, listing.location.longitude)
                val markerState = rememberMarkerState(
                    position = location
                )
                MarkerComposable(
                    keys = arrayOf(
                        listing.id,
                        location,
                        useTotalPrice,
                        currentSelectedMarkerId ?: "",
                        previousSelectedMarkers
                    ),
                    state = markerState,
                    tag = listing.id,
                    onClick = {
                        currentSelectedMarkerId = it.tag as? String
                        true
                    }
                ) {
                    PricePill(
                        price = "${listing.totalPriceOfStay()}".formatAsMoney(),
                        isSelected = currentSelectedMarkerId == listing.id,
                        wasPreviouslySelected = previousSelectedMarkers.contains(listing.id)
                    )
                }
            }

            [...]
        }
    }
}

However by creating my own MutableState for the List, initialized as emptyList() I'm able to have the map clear and redraw the new markers.
GoogleMap(
    modifier = Modifier.matchParentSize(),
    contentPadding = contentPadding,
    contentDescription = "Map view for properties with applied filters and search parameters",
    cameraPositionState = cameraPositionState,
    properties = properties,
    uiSettings = uiSettings,
    onMapClick = { currentSelectedMarkerId = null }
) {
    markersToDraw.forEach { listing ->
        val location = LatLng(listing.location.latitude, listing.location.longitude)
        val markerState = rememberMarkerState(
            position = location
        )
        MarkerComposable(
            keys = arrayOf(
                listing.id,
                location,
                useTotalPrice,
                currentSelectedMarkerId ?: "",
                previousSelectedMarkers
            ),
            state = markerState,
            tag = listing.id,
            onClick = {
                currentSelectedMarkerId = it.tag as? String
                true
            }
        ) {
            PricePill(
                price = "${listing.totalPriceOfStay()}".formatAsMoney(),
                isSelected = currentSelectedMarkerId == listing.id,
                wasPreviouslySelected = previousSelectedMarkers.contains(listing.id)
            )
        }
    }

    [...]

    LaunchedEffect(resultLocations) {
        markersToDraw = resultLocations
    }
}

Stack trace
N/A
Following these steps will guarantee the quickest resolution possible.
Thanks!

If you would like to upvote the priority of this issue, please comment below or react on the original post above with :+1: so we can see what is popular when we triage.
@bmc08gt Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

Check the issue tracker - bugs and feature requests for Google Maps Platform APIs and SDKs
Open a support case - Get 1:1 support in Cloud Console.
Discord - chat with other developers
StackOverflow - use the google-maps tag

This is an automated message, feel free to ignore.

@bmc08gt I believe the most significant problem is your usage of rememberMarkerState(). You never actually update the MarkerState location. The rememberMarkerState() position parameter is only used for state initialization, not state updates.

@bmc08gt I believe the most significant problem is your usage of rememberMarkerState(). You never actually update the MarkerState location. The rememberMarkerState() position parameter is only used for state initialization, not state updates.

Im creating entirely new markers with new coordinates (each with their own MarkerState). The markers were being reused even though I was reiterating through an entirely new list with new unique identifiers. They isn't always going to be the same amount of markers every time being rendered in the map (list is filtered results).

@bmc08gt in your original example, do you reuse the List object and simply clear and completely repopulate it when you send updates? If so, it may help to use a completely new List object for your "entirely new list".
What I believe is happening: Compose tries to align the old contents of the list with the new contents, and trying to reuse whatever it composed before, in particular remembered MarkerState. Because you never tell Compose to update the marker positions, you get new Marker contents, but old positions.
If it does not work despite using a new List object every time, wrap your forEach loop with the new List object as a key:
key(resultLocations) {
    resultLocations.forEach {...}
}


Hard Crash when attaching external monitors using KVM

Hyprland Version
 System/Version info
Hyprland, built from branch  at commit 754eaf5b8b65c9764abe67ec2d599036cd51e381  ().
Date: 2024-01-24
Tag:

flags: (if any)

Bug or Regression?
Bug
Description
I've got two external 4k monitors using DP and flip back and forth between two laptops using a KVM. The laptop with Hyprland crashes on occasion when flipping back to it.
Crash log attached.
hyprlandCrashReport6786.txt
How to reproduce
Not sure. Here's my setup:
2 LG IPS 4K@60Hz IPS monitors
Level1Techs Dual Monitor KVM using Display Port
Machine 1: Dell XPS 9560 running Sway
Machine 2: Lenovo Thinkpad X1 Carbon 11th Gen running Hyprland
Thinkpad is connected to KVM through a Thinkpad Thunderbolt 4 dock. Both monitor cables are connected to the dock.
Kanshi is used to update layout and resolution on detection of output changes.
I'll be using the Dell for a while, come back to the Thinkpad, and the screen is black and the keyboard is locked, including caps lock. After 20-30 seconds it exits and goes back to the login screen.
This only happens occasionally.
Unclear if this is due to the KVM, the Thunderbolt dock, the change in external outputs, Kanshi, or all of them.
Crash reports, logs, images, videos
hyprlandCrashReport6786.txt

Relevant kanshi config
profile {
	output eDP-1 disable
	output DP-3 enable mode 2560x1440 scale 1

}

profile {
	output eDP-1 enable scale 1
}

Perhaps a coincidence but I also disable eDP-1.

Ok, I was able to reproduce this reliably by using unplugging the desktop monitor with kanshi running and I did a git bisect.
7b3d039 is the first bad commit
Unfortunately I don't have enough time or familiarity with the code to fix this myself for now. Hopefully @vaxerski takes a look at it.

had the same exact behavior happening to me. thxx for finding the bad commit, hopefully it's going to get solved

Perhaps a coincidence but I also disable eDP-1.

the idea is that Hyprland crashes due to no monitor available. So disabling the eDP-1 is causing the "issue".

I've upgraded to 0.34.0, and I haven't seen a crash yet, but I've seen the screen go fully red and had to go to a TTY to kill everything and relaunch. Mouse still moved.

red screen of death = lockscreen died
you can get around this by enabling restoring lockscreens in config and having a locked bind to launch swaylock or whatever lock

I'll say this is a dupe of #4628


Resolve tests

I'll take all those related to Add.

Remaining tests to fix
-> edit
-> list (some tests fail occasionally. Could be a bug with the Tag generation code.
-> UI tests

What's this? Test for EditCommand is it?
Ya the test for list command breaks randomly.


[Doc-Improvement][Visio-source-files]

Added folder for Visio source files. Added file tab-auth-sequence-diagram.vsdx.

Docs Build status updates of commit b642375:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/visio-source-files/tab-auth-sequence-diagram.vsdx
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


rolling_hash: Implement rolling_hash2 for aarch64

Change-Id: I1b57b18a7e5d0f7365c0550086e75802f065238f
Signed-off-by: Jerry Yu<EMAIL_ADDRESS>

@gbtucker please review

@gbtucker  , just update it , please review

Is it possible that you pushed this update to the wrong PR? The new update to this has title "sm3_mb:Add sm3_mb_test"

oops， I do wrong operation

@yuhaoth, does this pass the CI tests?  I get a lot of 'dangerous relocation' errors when trying to cross-compile.  Also some commented code in the _dispatcher.c.

@yuhaoth, does this pass the CI tests? I get a lot of 'dangerous relocation' errors when trying to cross-compile. Also some commented code in the _dispatcher.c.

Yes，It pass CI tests .
Could you share build log and compiler information?

As I looked into the error I see that the issue was on my end.  Sorry, I'll schedule for integration.


Output array as table

Is there an option to debug an array visually as array and another array as a table? Couln't debug an array as a table. Thanks for your help. The array is
#220
Apparently, In order for the latest versions of Kint to show 2-d arrays in tabular-view, no columns should have more than 50% empty cells .
Can i set the 50% to 90%, i didnt't find such option.

Duplicate of #219 and might not be relevant with 2.x-dev. Please test and give feedback, thanks!

Not a duplicate, but still might not be relevant


version 3.6.0 breaks Electron 80 (Chromium 80)

Verified that POST request works prior to upgrading to whatwg-fetech 3.6.0. Behavior the same with 3.6.1. Afterwards, with no other changes, we can see server receive Content-Length of 0 and empty body.
I found the offending line of code, simply commenting it out fixes things:
https://github.com/github/fetch/commit/5c6b055e6ae6f718f416c94bfcdc89693d0abdcb#r47472637
The branch system above is quite convoluted, but I think if you can ensure the original body is preserved when you assign here, things will still work. From what I can tell, my code was hitting the final branch (https://github.com/github/fetch/commit/5c6b055e6ae6f718f416c94bfcdc89693d0abdcb#diff-3fc6f1265a180d15035618e36ca1da88d092bacb4fc10a423938fa62e4f5f58fR246) and body being re-assigned there. But I tried a simple case of removing the body assignment there, and using body as the assignment instead on line 262, but it doesn't work. Making a new variable var origBody = body at the top of the branches and assigning that on line 262 does work however.
So probably want to look at cleaning up those branches. In the meantime, will be stuck at v3.5

Could you please post a small piece of code which would reproduce the problem you are seeing? With a small example, I should be able to help fix this issue. Without one, I will struggle a lot.

Well the issue seems to be with this line of code (line 246) because we are modifying the contents of body & _bodyText: https://github.com/github/fetch/commit/5c6b055e6ae6f718f416c94bfcdc89693d0abdcb#diff-3fc6f1265a180d15035618e36ca1da88d092bacb4fc10a423938fa62e4f5f58fR246
Then you are saying you are going to "save" the original body content into _bodyInit, but by this time it isn't true that body & _bodyText have the original contents. In fact it seems that in my case, the original contents of _bodyInit were already correct, and what's being assigned in line 246 is in fact wiping body and _bodyInit out entirely and that's why an empty body is sent to the server with this change.
SImply making this assignment on line 227 (
https://github.com/github/fetch/commit/5c6b055e6ae6f718f416c94bfcdc89693d0abdcb#diff-3fc6f1265a180d15035618e36ca1da88d092bacb4fc10a423938fa62e4f5f58fR227), a new line:
var origBody = body

Then changing line 262 (https://github.com/github/fetch/commit/5c6b055e6ae6f718f416c94bfcdc89693d0abdcb#diff-3fc6f1265a180d15035618e36ca1da88d092bacb4fc10a423938fa62e4f5f58fR262) to
 this._bodyInit = origBody

Also fixes the issue.
However, that is very much a hack for what is a very convoluted conditional branch tree that really should just be re-worked altogether. There's too much leaky logic going on in there.

This was fixed in https://github.com/github/fetch/releases/tag/v3.6.2

What are this things ??


Add subject validation

What is this PR?
Adding subject validation
Why need this change?
While using this library, I find that subject validation feature is needed. Also, subject validation is one of examples in the paseto-standard

@lyra95 the package has been published to NuGet, it should be available in a few minutes.
Thanks again for your contribution.


music time shifting snippet

on telegram android & IOS and telegram desktop if you reply a music or video and write a time (like 2:02) it gets like a link and if you click on it it opens the music or video and seek to that exact time
please add this feature.

@levlam Draft between devices takes a long time.
I think it can be sent here. Check the function between Desktop -> Android.
There is no synchronization in the input field when both clients are in the chat.

@isopen In most clients you need to leave the chat to synchronize draft.

@levlam Exiting Deskop client on Android, Draft does not come.

@isopen You must not close the client, you must close only the chat.

@levlam On both devices, close only chat?

@levlam gas is not wasted if you close only the chat on Desktop.
On Android, fresh Draft does not come to chat.

@levlam I suggest not saving gas. Due to gas savings, synchronization does not work well.

on telegram android & IOS and telegram desktop if you reply a music or video and write a time (like 2:02) it gets like a link and if you click on it it opens the music or video and seek to that exact time
please add this feature.

@levlam This functional function does not always work in bots on Android and Desktop.
eg: on incoming music files from the bot.

@levlam When forwarding messages with reply. No reply Gas is emitted.

Automatic search for entities of a new type textEntityTypeMediaTimestamp was implemented in the latest TDLib version.


chore: Make NodeClaim Spec Immutable on v1 API

Fixes #N/A
Description

Make NodeClaim Immutable on v1 API
V1 RFC: https://github.com/kubernetes-sigs/karpenter/pull/1222

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 78.305%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/node/termination/terminator/eviction.go
2
89.09%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
8713

Relevant Lines:
11127

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
11 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.06%) to 78.305%

Files with Coverage Reduction
New Missed Lines
%

pkg/test/expectations/expectations.go
2
93.69%

pkg/controllers/node/termination/controller.go
2
59.81%

pkg/controllers/provisioning/scheduling/preferences.go
7
86.67%

Totals

Change from base Build<PHONE_NUMBER>:
-0.06%

Covered Lines:
8713

Relevant Lines:
11127

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
9 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.08%) to 78.249%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/node/termination/controller.go
2
59.81%

pkg/controllers/provisioning/scheduling/preferences.go
7
86.67%

Totals

Change from base Build<PHONE_NUMBER>:
-0.08%

Covered Lines:
8659

Relevant Lines:
11066

💛  - Coveralls


Set unit models based on Vic2 culture

https://forum.paradoxplaza.com/forum/index.php?threads/the-vic2-to-hoi4-converter-project-development-thread.915440/page-47#post-23233126
"I have an idea for units models : try to clone the existing countries based on the primary culture of vic2, for example prussia should clone the german units. I know how to do it in the files and i've done some C++ if you need help. Maybe you can add some generic units as well based on mods ? Why not ancient romanian units for the generic eastern graphical culture for example ? "
https://forum.paradoxplaza.com/forum/index.php?threads/the-vic2-to-hoi4-converter-project-development-thread.915440/page-48#post-23234342
"You have to add a file in gfx/entities/ and then create a file yourFileName.asset and copy this :
#################################
BELGIUM - CLONED FRANCE
#################################
entity = {
clone = "FRA_infantry_entity"
name = "BEL_infantry_entity"
}
entity = {
clone = "FRA_infantry_2_entity"
name = "BEL_infantry_2_entity"
}
#################################
following this example this can lead to :
entity = {
clone = "clonedCountryTagHere_infantry_entity"
name = "yourTagHere_infantry_entity"
}
entity = {
clone = "clonedCountryTagHere_infantry_2_entity"
name = "yourTagHere_infantry_2_entity"
}
i assume it should work the same for tanks and planes. I already try this for a previous converted save and it have worked."

I disagree with this for a simple motivation. Those unit skins were specifically for those specific nations of OTL. The probability North Germany would have still used SS-styled uniforms in other timelines is pretty rare, considering cases where fascism never entered Germany at all.
Unit-voice mappings, instead, that I already proposed, have a degree of plausibility, since they're based upon "culture" (which roughly is language).


Download functionality tests

Make sure integration and unit tests for the download functionality are in place.

several tests are added for download in v2 code


when will a new release will be available with the like feed ?

If I want to use the update source before a release was out
do I need to replace the files from the src folder into the dist folder
will it work ?

Thank you !


Performing actions on keypress

First of all, thank you for your excellent work on this. Really like the package.
I'm having trouble figuring out how actions could be performed on keypress.
This is the screen of a console app I'm building

This is the code that tries to figure out which key has been pressed.
Unfortunately it know only works by pressing the letter and then enter. I want to get rid of the required press on enter to invoke the action.
How can this be achieved?

Tried a whole lot of variations to get this to work but no luck.
Latest attempt:
        $this->io->getInput()->on($eventName, function ($line) use ($callable) {
            $callable($line);

            $this->io->getReadline()->setInput('')->clear();
        });

Hope to find a solution soon, this is the last problem I need to solve before tagging a new release of my package.

I was peeking around (because of your tweet) and came up w/ pretty much the same solution as you. But that one works for me. Does it do something it shouldn't?

The thing is with that code in my previous comment, actions get executed multiple times. So pressing "a" runs the tests, pressing "a" again runs the tests twice, and so on. Can't find a good way to reset what has been typed before.

Yeah, I noticed this but I can't figure out why. If I replace the callable with a simple echo I don't get repeated echoes or characters. Which is strange.

Got it: $this->io->getInput()->removeAllListeners();

That appears to work for at least the "all tests" case.

Mmm, I don't understand 100% how you fixed this.
Tried:
        $this->io->getInput()->on($eventName, function ($line) use ($callable) {
            $callable(trim($line));

            $this->io->getInput()->removeAllListeners();
        });

Doesn't seem to be working...

Oh sorry, in your Terminal.php's removeAllListeners method:
public function removeAllListeners()
{
    $this->io->removeAllListeners();
    $this->io->getInput()->removeAllListeners(); // Added this line

    return $this;
}

This appears to break input on the filter screens though. Looking into that now.

Yeah, just figured it out and bumped on the breaking filter screens. Thanks for figuring this out together with me :-)

👍

Got it!
https://github.com/spatie/phpunit-watcher/blob/feature-interactivity/src/Terminal.php#L25-L38
I'm thinking removeAllListeners removed some internal listeners as well. Solved it by using once.

I'm glad you've got this sorted out already! Let's recap some of the nifty details here.
The following code will invoke the callback whenever data arrives on STDIN:
$stdio->getInput()->on('data', function ($data) {
    var_dump($data);
});

If you only want to execute this callback once for when the next input arrives, you should indeed use once() instead:
$stdio->getInput()->once('data', function ($data) {
    var_dump($data);
});

Both should work for the use case you've mentioned above, but note they actually work on raw data received from STDIN, which may expose more "data" than you may be aware of. This event will be emitted whenever new data on the STDIN stream is ready, which may not only include "user key presses".
In particular, special keys such as cursors or Fn will actually emit binary terminal codes that consist of multiple bytes (which may in turn contain ASCII bytes). Similarly, pressing non-ASCII keys such as ä will emit a single event with multiple bytes. Additionally, copy-pasting things into the terminal will emit a single event with multiple bytes.
To make things worse, keep in mind that the loop will process data as soon as it (is aware that it) arrives. This means that if you either block the loop or copy-paste big inputs, you may actually receive data in chunks which may contain multiple bytes. Additionally, these chunks can potentially be split at byte ranges so that a single UTF-8 characters can be broken into multiple chunks with incomplete UTF-8 sequences.
All of these are probably not an issue for your particular use case, so you should be able to consume this stream just fine. But these combined are the reason why the Readline class does all the heavy lifting internally and only exposes the data when the user presses ENTER.
I'm not opposed to exposing things through an easier API, but I'd love to hear some more thoughts on this first! Thanks for sparking this discussion, which I think is a very good step towards this API! :+1:

I'm not a big user of ReactPHP so I don't know what a good API for most users might be, this is just my two little cents with only my specific problem in mind.
For my package it would have been nice that a $stdio->onKeypress($callable) function would have been present.

Thanks for all your input so far!
Note that the above code will have to be deprecated via #62 for the upcoming v1.2.0 release. This is required in preparation for the upcoming v2.0.0 release (#50).
A proper way to register custom functions to key events has been worked out already and will be added again with the v2.1.0 release that will be released shortly thereafter.
This means that you can keep relying on the above behavior with the old version for now and I will update this ticket again for the v2.1.0 release :+1:


Remove workbench and its workflows

Description
Removing workbench and its workflows from SQL repository 1.3 branch to reduce unwanted CVE advisories for this branch
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

please fix the links in the README.md file pointing to the deleted folder

Does this mean all future SQL Workbench release should happen in the new repo? If so, we should remove it from all .x branch? Same for other clients code?

This change is only required for 1.3 branch workbench as it has CVEs, future releases for 1.3 branch should be done in new repo for workbench.

This change is only required for 1.3 branch workbench as it has CVEs, future releases for 1.3 branch should be done in new repo for workbench.

Does Workbench code in 1.x branch have the fix? If not, I think we should remove at least 1.x along with 1.3. Otherwise, future branch 1.4, 1.5 will have same CVE?

I agree, if 1.x doesn't have the CVE fix, we should remove it there too. Currently we're focusing on 1.3 branch as there's a release this week


add openid login to backstage bubble

TODO: we probably want to hide this for the average user. This at
least makes it easy to access this login form.

Does this just add it as an additional form alongside the existing one?
If so would it be possible to make it so you can toggle between the two?

That's what I meant by my TODO message. I guess toggling would be useful, but I guess some sort of stickiness would be useful - ie. if I always login via openid I'd always like that to be the open one.

stickiness would require sessioning, which we don't want, and besides we've made it so cookies are hard to see from javascript
so i think a toggle, with the user/pass being the default (since that's what 99% of users use) would be right (and less visually noisy)

@jdlrobson it's still not working right, sorry
Now it has the same problem that the frontpage had when logging with openid: when you log in with openid it raises a bunch of alerts about trying to create a space.
Since you did the fix on the frontpage I assume you can suss out what's up here?


Fixed Issue #311 (Updated README.md to add steps for setting up a firebase emulator)

What it Does

Closes #311
Updated the README.md to add steps for setting up a local firebase emulator

How I Tested

N/A

Notes

N/A

Screenshot

N/A

Thank you for contributing! @Vai-Man Please read the issue again, you need to update the getting started DocC documentation steps, NOT update the README file

I apologize for the oversight. I have updated the Getting Started DocC documentation as required. Please review the changes and let me know your thoughts.


upgrade xblock

@jcdyer on the review

Changes Unknown when pulling 28507c43d66f0276511f2b8d4fc714e9e57957d5 on sstudent/upgrade-x into ** on master**.

Changes Unknown when pulling e8b8206ff78b0a674282004288cd672eef18e7a5 on sstudent/upgrade-x into ** on master**.

Changes Unknown when pulling e8b8206ff78b0a674282004288cd672eef18e7a5 on sstudent/upgrade-x into ** on master**.

Changes Unknown when pulling 41deeee56bacc8750db3da15b7064405e57a1068 on sstudent/upgrade-x into ** on master**.

Changes Unknown when pulling a79214f01136908581649e05e7011b0c0764048a on sstudent/upgrade-x into ** on master**.

Changes Unknown when pulling a79214f01136908581649e05e7011b0c0764048a on sstudent/upgrade-x into ** on master**.

Looking at it again, I think you need the context manager (around link.click()) to avoid the race condition.

I had missed that the wait was now passing in the link, rather than looking for the html element of the page.

Changes Unknown when pulling 34b5aacb5dc9c5de2c678860a329febe8feea584 on sstudent/upgrade-x into ** on master**.


Wildcard TLDs not handled correctly?

I'm getting a ParseException for a domain like [something].compute-1.amazonaws.com when I call DomainParser.Get().
This seems to be caused by the TLD rule *.compute-1.amazonaws.com which contains 4 labels (including the wildcard character) and the domain also contains 4 parts. This results in the DomainParser thinking that the domain itself is a TLD due to this check:
//Domain is TLD
if (parts.Count == winningRule.LabelCount)

Or does the wildcard actually mean that the full string [something].compute-1.amazonaws.com is actually a TLD by itself?

In my view the rule says that [something].compute-1.amazonaws.com is the TLD.

I have found this information https://github.com/publicsuffix/list/pull/584

OK, so it's not a bug in this library, but just a very strange public suffix entry created by the AWS team.
We frequently see DNS requests for hostnames of the form ec2-[0-255]-[0-255]-[0-255]-[0-255].compute-1.amazonaws.com and they really don't appear to be TLDs, but I also don't see what could be done here if the AWS team registered that as a wildcard TLD.


Update sv.json

I fixed the whitelist message becuse they were in English.

Thanks for the PR.
Unfortunately this file has already being translated, but you based your PR on the master branch so you probably missed it.
Here's the link to the updated version:
https://github.com/tabarra/txAdmin/blob/develop/locale/sv.json


Trigger bot periodically

Add option to trigger bot every x hours/minutes.
i.e. Have the bot broadcast the forecast command every 24h

Add conditional logic to bot command. Only show output when temperature drops below 0 degrees Celcius or when it is raining.

PR #12 adds a hello command. It's possible to call this function every 10 seconds.

PR #13 Right now calls a daily forecast every 10 seconds which is too much.
Allow a time to be given and only check to alert at that time.


fix: prevent user from renaming duplicate name tags

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/46283
PROPOSAL: https://github.com/Expensify/App/issues/46283#issuecomment-2262085383
Tests

Open workspace > Tags
Click a tag group > Name field > Rename tag with the same name as the another tag.
Verify that: Error appears instead of rename successfully.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Open workspace > Tags
Click a tag group > Name field > Rename tag with the same name as the another tag.
Verify that: Error appears instead of rename successfully.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Uploading Screen Recording 2024-08-14 at 14.13.29.mov…

Android: mWeb Chrome
https://github.com/user-attachments/assets/e8d4ab61-34e2-49c9-a1b8-9a504ad46485

iOS: Native
https://github.com/user-attachments/assets/1c31a156-b8c4-4d1e-b538-d361355ee0c1

iOS: mWeb Safari
https://github.com/user-attachments/assets/a12bffcd-658a-4534-bfd5-eb9bb3f13c66

MacOS: Chrome / Safari
Uploading Screen Recording 2024-08-14 at 13.59.07.mov…

MacOS: Desktop
https://github.com/user-attachments/assets/e4bc0424-7eb9-4372-bc42-f4d1cdf62c62

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
failure ❌

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Reverse integrate from oct preview release

Data Plane API - Pull Request
Reverse integrate from oct preview release: https://github.com/Azure/azure-rest-api-specs/pull/20810
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your engagement record.

Link to engagement record issue:

Is this review for (select one):

[ ] a private preview
[ ] a public preview
[ ] GA release

Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified. Please share a link to the design document for the new APIs, a link to the previous Open API document (swagger) if applicable, and the root paths that have been updated.

Design Document:
Previous Open API Doc:
Updated paths:

❔Got questions? Need additional info?? We are here to help!

 Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

💬 Teams Channel
💌 email

Click here for links to tools, specs, guidelines & other good stuff
Tooling

Open API validation tools were run on this PR. Go here to see how to fix errors
Spectral Linting
Open API Hub

Guidelines & Specifications

Azure REST API Guidelines
OpenAPI Style Guidelines
Azure Breaking Change Policy

Helpful Links

Azure DevTools Wiki

You need to fix the breaking change and linter issue. Seems to be the same. Then I can merge. I can't merge with failed required checks.

You need to fix the breaking change and linter issue. Seems to be the same. Then I can merge. I can't merge with failed required checks.

It is confirmed the hostTemplate error is false alert. See the email I send you. So we can bypass both breaking change and lintdiff.

@weshaggard @lmazuel are you able to override? I can't since both failed checks are required.

@heaths looks like this should be mergable now when ready.