Developer experience repository audit from @mntnr!

:wave: Hey there! This is the developer experience audit from @mntnr for this repository. I've added in my thoughts below, in the form of a checklist. Looking forward to seeing what you think; let's see if we can resolve all of the open issues and make this repository shine ✨ 💖 ✨
Repository Review: probot/probot

🤖 A framework for building GitHub Apps to automate and improve your workflow

For notes on anything crossed out, look below. Note: I use [~] to mean that I have proposed a fix in a PR. I know it doesn't render properly in Markdown, but it works pretty well otherwise for that purpose. If I think that something is fine, even if it isn't valid according to this checklist, I've checked it off and included a note.
Reviewing the Repository Docs

[x] Is there a README?

[ ] Is it standardized?

It's OK that it isn't standardized, BUT I am confused by this repository, because I know that it holds the docs, but I don't know specifically what probot/probot does. Do I install it? How do I use it in particular? I think an install and usage section would be incredibly helpful here. For instance, you have the section on using robot - but I don't know if I need to include this library in my code or not. I am a bit confused. That means the docs could be tighter. Standardization might help with making sure that basic information is there for new users.

[~] Is it spellchecked?

See commit:eaed8f3

[x] Is there a Code of Conduct?

[x] Is it mentioned in the Contribute section of the README?

No, but it is a top-level file and in the CONTRIBUTING.md, so I think this is fine.

[x] Does it reference an email address for violations?
[x] Does it reference a second email address?

No, but I'm assuming that that is a GitHub-level email that doesn't go directly to the Probot maintainers. This is important in case the maintainers themselves don't adhere to the conduct and a user wants to complain. If this goes straight to @bkeepers, for instance, I would suggest adding another email address as a redundancy.

[x] Is there a LICENSE file?

[x] Is this matched in the package.json?
[~] Is the year correct? Updated to 2018. commit:3e6e2a2

[x] Is there a .github or docs folder?

It looks like you're using the docs folder to render docs on probot.github.io, which is clutch. However, you don't have syncing with the README for README.md, and I wonder if content could be deduplicated.
[ ] Is there an ISSUE_TEMPLATE.md?
[ ] Is there a PULL_REQUEST_TEMPLATE.md?

[x] Is there a CONTRIBUTING.md file?

There's a lot of work which can be done here; let's talk about it!

[ ] Is there a CHANGELOG? No. There should be ways to automate this. I would look at standard-changelog and also keepachangelog.com for understanding why.
[x] Does this pass alex adequately? Run alex *.md.
[x] Does the repository name itself pass on http://wordsafety.com?

Process

[ ] Can I install easily? No. I am unclear whether I ever install this repository, and there are no install instructions. It's very possible something I am missing something, and I'd like to have a note in the README saying that you don't need to install it.

Issues and Pull Requests

[x] Are there an acceptable amount of pull requests?
[x] Are there an acceptable amount of issues?
[x] Are an acceptable amount of issues less than six months old?
[x] Are there useful issue labels?
[x] Are the labels being used?
[x] Is there a good for beginners or up-for-grabs label?
[ ] Is there a waiting on contributor label? I find this useful for drive-by issues in particular; when it is the contributor's job to provide more information, this is the best signal to them and you that there's nothing for the maintainers to do.

Bots
Note: Neither of these are necessary, but they can help with some things. Check out https://probot.github.io/ for some tools. (Note: I had this in my template for all of these checklists; keeping it here for posterity, even though it is somewhat circular in this case.)

[x] Are there bots enabled? Of course! :D
[ ] Is there a CLA?

[ ] Is there a bot to help with the CLA?
I don't know if GitHub does this, but it doesn't seem like you'd need it for ISC? Ask your lawyer.

Metadata

[x] Is there a description on GitHub?

[x] Does the description match the README?

[x] Are the topics useful? Could have some more, maybe: automation, github, open-source, pm.
[x] Is there a website?

[x] Does the website match the project?

Package Metadata
Note: These should apply to package.json (JavaScript), *.cabal (Haskell), metadata.yml (Perl), and gemspec files (Ruby).

[~] Does the description match the gh-description?
[~] Is there a bugs field?
[~] Is there a homepage field?
[~] Are there appropriate keywords?

[~] Do these match the keywords on GitHub?

[ ] Run depcheck; do the deps make sense?

There are some unused dependencies. I would suggest looking at these in more depth.

TODO
This is a generally good repository as far as documentation goes, but I think there's a lot of work to be done. Specifically, it's unclear to me what your main README is doing as far as telling people to use probot/probot. I know that it is emphasizing probot as a tool, but I don't know how to use this particular repo very well. Some clarification would be great. I can't install this, because I'm confused why - that's not ideal. Let's work on making this messaging clearer!
As well, your Contributing doc limits interactions that are encouraged to checking out good first issues and submitting PRs; but there are loads more ways to get involved, like triaging, joining the slack, requesting features, reporting bugs, helping write docs, and so on. I would add sections for these things.
Generic

[ ] I would add a maintainers section, to make it clear who is on the maintainers team. This helps set expectations and clarifies for the users who they can talk to.
[ ] Add a link to your Slack! You want to engage with users there.
[ ] Consider adding a secondary email to the Code of Conduct as a contact - someone may have an issue with you but not want to tell you directly. I know, this idea may be awkward. But you will give them an option in case they do have an option, and this may be good for the overall health of the project.
[ ] Consider adding ISSUE_TEMPLATE.md and PULL_REQUEST_TEMPLATE.md files to your repository. It looks like you have your PRs well under control, but these may help you in the future. At the least, ask them to run the tests, first, and to read the Usage guides.
[ ] Consider adding a CLA or asking for signed commits, if you're worried about legality. This is generally only needed when you are building a business out of a code base. In your case, I think you're OK.
[ ] This audit does not cover license dependency. For that, I suggest using either licensee or an external tool like Fossa. Let me know if you want more help here.

Issues

[ ] Add 'discussion' labels to longstanding issues. I think your 'pinned' label does this, though.
[ ] Considering adding up-for-grabs as well as good first issue. See http://up-for-grabs.net. No reason you can't have both!
[ ] I label pull requests where I am waiting on the Contributor to respond waiting on contributor. This helps alleviate pressure on you to close them.

Contribute back?
This checklist is open source! If you have suggestions or think it could be better, contribute back on this GitHub repository: mntnr/audit-templates.

Is there a CHANGELOG?

Changes are in release notes: https://github.com/probot/probot/releases. Which I  prefer to a file committed to the repository because we can edit it after the fact.

Considering adding up-for-grabs

I’ve heard people saying that up-for-grabs might sound odd, especially to some non-native English speaking people. I prefer available. The label is configurable if we want to add the project to  http://up-for-grabs.net

Those are both very good points. I'll work those into the template in the future. Glad this is open source, now - walking through it today with a friend I realized it should be, so I'm going to start sourcing edits to the template and make it so other people can do them too. :)

Woo! Love this conversation and the feedback so far! 💖

Add a link to your Slack! You want to engage with users there.

We do have this link under the community section of the website and in the https://github.com/probot/probot#contributing section of the readme. Do you think it belongs somewhere else or somewhere more visible?

Add 'discussion' labels to longstanding issues. I think your 'pinned' label does this, though.

Pinned is a label that is exempt from stale bot, which is why we use it to prevent older issues from being closed. Do you think it would be worth renaming it (ie adding discussion as a stale-exempt label and using it) or is it clear enough?
With regards to the general comments about confusion about what probot is, I think we struggle a bit there since the bulk of our documentation is hosted on our website, and ideally, I think we would have new people start there to understand probot as opposed to coming directly to this repo. Do you think there's a better way to accomplish that or that the solution is just to clarify our readme more in the assumption that people will start here (as opposed to the website) anyways?

We do have this link under the community section of the website and in the probot/probot#contributing section of the readme. Do you think it belongs somewhere else or somewhere more visible?

No, I don't. I make mistakes sometimes, and I may have overlooked that. I think it's pretty clear in the README. I would definitely add it to the Contribute file, however. Let me know if you want me to add this note.

pinned

That makes more sense. I would keep using pinned, as it's a convention in your community and it makes sense when combined with Probot. What I would do is add a note about what the pinned label is doing. Happy to add this note.

we would have new people start there to understand probot as opposed to coming directly to this repo

I think the best thing to do here is to make that excessively clear in the README for this repository, too. "Hey, thanks for landing here. This repository is used for X and Y. If you're new to Probot, go to the website to learn more." Right now, the readme tries to instruct users on probot, but it doesn't clarify what the code in this repository is actually doing, which is why I am a bit confused. I had to figure out that the docs in docs/ were rendered on the website by sleuthing, and I'm still not sure what to do with the probot npm package - can I install it in my probot apps? Do I globally install it? (Do you see where I am tripping up, here?)

I think ideally, people should go to the website/our repo if they intend to build a probot app, for which the best place to get started programmatically is probot/create-probot-app which generates a scaffolding probot app (the template for which is probot/template) for them and it includes requiring the probot npm package.

This makes sense to me, and this is clear. Can you clarify what the code in this repository is doing, for me? When would I ever use the probot package?

You require probot as a high-level GitHub App framework for Node.js. You don’t require it in your code but instead use the probot binary to require your code, see https://github.com/gr2m/wip-bot/blob/04c8e8307fe0d6fda30e5cbc4b5bcdd5777f25c0/package.json#L12 for example. Then your entry .js file exports a function that receives a robot instance with which you can then listen to events coming from webhooks, e.g. see https://github.com/gr2m/wip-bot/blob/04c8e8307fe0d6fda30e5cbc4b5bcdd5777f25c0/index.js

@bkeepers I think this can probably be closed. Is there anything here you want me to open a separate issue for?

I'm gonna go head and close this out. Feel free to reopen if anyone thinks there's anything left to do here.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_ef779d24-d99a-4007-858f-8acbe094293a/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_ef779d24-d99a-4007-858f-8acbe094293a.git

Docs Build status updates of commit 92050d9:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


refactor secret controller

Refactor secret controller, now the controller watches for all secrets with a specific label. This approach allows to track if the secret was created but the label was added/removed later and no extra logic requires for updates This PR also adds removal of a remote cluster from the slice of clusters.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
Assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbezverk: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
392e8bbd9862e228c31616758ccd16175b657eb3
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
392e8bbd9862e228c31616758ccd16175b657eb3
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
392e8bbd9862e228c31616758ccd16175b657eb3
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
392e8bbd9862e228c31616758ccd16175b657eb3
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
392e8bbd9862e228c31616758ccd16175b657eb3
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
392e8bbd9862e228c31616758ccd16175b657eb3
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
392e8bbd9862e228c31616758ccd16175b657eb3
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
392e8bbd9862e228c31616758ccd16175b657eb3
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
392e8bbd9862e228c31616758ccd16175b657eb3
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
392e8bbd9862e228c31616758ccd16175b657eb3
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Fixed https://github.com/istio/istio/issues/5440

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: gyliu513
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
Assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks @sbezverk , also test in my local cluster and it works fine.
2018-05-08T07:05:31.476744Z	info	Processing delete: istio-system/myistio.icp
2018-05-08T07:05:31.476783Z	info	Deleting cluster member: myistio.icp
2018-05-08T07:05:31.476789Z	info	Number of clusters in the cluster store: 0
2018-05-08T07:06:05.964373Z	info	Processing add: istio-system/myistio.icp
2018-05-08T07:06:05.964410Z	info	Adding new cluster member: myistio.icp
2018-05-08T07:06:05.965273Z	info	Number of clusters in the cluster store: 1

FYI @sdake

Will this work with the existing code to populate the secrets?  You might consider removing that code in this PR.

@sdake will do.

New changes are detected. LGTM label has been removed.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
392e8bbd9862e228c31616758ccd16175b657eb3
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c0c34d49747f05dc0c7ab74acd43d54e2dcbbde5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
c0c34d49747f05dc0c7ab74acd43d54e2dcbbde5
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c0c34d49747f05dc0c7ab74acd43d54e2dcbbde5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
c0c34d49747f05dc0c7ab74acd43d54e2dcbbde5
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
c0c34d49747f05dc0c7ab74acd43d54e2dcbbde5
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: gyliu513
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
Assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@costinm Please review, @gyliu513  has tested it and it worked in his multi cluster env.

/retest

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
c0c34d49747f05dc0c7ab74acd43d54e2dcbbde5
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
c0c34d49747f05dc0c7ab74acd43d54e2dcbbde5
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c0c34d49747f05dc0c7ab74acd43d54e2dcbbde5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
c0c34d49747f05dc0c7ab74acd43d54e2dcbbde5
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c0c34d49747f05dc0c7ab74acd43d54e2dcbbde5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
c0c34d49747f05dc0c7ab74acd43d54e2dcbbde5
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c0c34d49747f05dc0c7ab74acd43d54e2dcbbde5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
c0c34d49747f05dc0c7ab74acd43d54e2dcbbde5
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
c0c34d49747f05dc0c7ab74acd43d54e2dcbbde5
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Some pictures taken in portrait orientation will be in the saved in landscape orientation.

There is code in CameraView that sets the orientation for photos, ONLY if it hasn't changed since the last photo was taken. This causes the orientation to not be set correctly, so the second photo will be in landscape.
if (lastPictureOrientation != outputOrientation) {
params.setRotation(outputOrientation);
lastPictureOrientation=outputOrientation;
}
If the if-statement is removed (and the orientation is set every time), it seems to work correctly.
This was tested on a Nexus 5 running android L.

I have the exact problem as BLuFeNiX. All pictures succeeding the first one are set to landscape. Also tested in Nexus 5 with Android L.

Same story (reproduced for Nexus 7 & Nexus 5).
Interesting fact, if you start working with camera in portrait orientation then rotate device to some landscape one and take photos, everything OK. But if your activity launches in landscape from most beginning you will get wrong orientation for all landscape orientated photos...

@commonsguy Is there any idea on how to make a workaround for this bug? What stuff may be broken if that condition will be removed?

@romanzes You are welcome to fork the library, make the change, and go with it.

@romanzes I made the change that I originally suggested, and everything seems to work fine.


PPG Handles

I'm trying to receive data from my Muse 2 in a Max MSP patch.
I am already able to retrieve all data except for the PPG sensors'.
Looking at the code for _handle_ppg(self, sender, data), I see the test if handle == 62, which triggers the actual sending of the data.
I am a newbie with BLE and this type of stuff, but a print of this variable shows only the values 54, 57 and 60, and never the 62 that is expected.
This also contradicts the comment at the top of this function.
Do these handles change with Muses? Mine is an MU-03.

Hi Vasco - Saw your note on the issues thread, and it sounds like you were able to subscribe to notifications from the Muse 2. I'm trying to pull EEG data from the headset in order to stream to a non-LSL output, and I was hoping you might have some advice. I posted my question here. Did you use one of the bleak or pygatt libraries to pull data?  Thanks!


Enhance the profile section ui #51

Pull Request Title
#51
Before

After merging this pull request

Type of change:

[✔ ] Enhancement

Checklist:

[✔ ] I have tested my changes and verified that they work
[ ✔] My code follows the style guidelines of this project
[ ✔] I have commented my code, particularly in hard-to-understand areas
[ ✔] I have made corresponding changes to the documentation
[ ✔] My changes generate no new warnings
[ ✔] I have added tests that prove my fix is effective or that my feature works
[ ✔] New and existing unit tests pass locally with my changes

@Yashgabani845 why this PR doesn't get merged till you any issue?


HostingNode / HostingCellNode - For SwiftUI

happens weird animation because of resizing
https://user-images.githubusercontent.com/1888355/173087871-139f04b4-ecf9-4154-8851-8e0fe6b869d2.mp4

working on fixing pods

@muukii I have noticed some awkward behavior when using HostingCellNode. Some of my rows get clipped for some reason:

As you can see, towards the bottom the circle images are not vertically centered and get clipped at the top.


In connecting to NLP service,While using sentences annotation getting  null value

I used the code from the below link
https://sergey-tihon.github.io/Stanford.NLP.NET//samples/CoreNLP.Server.html
Here sentences returns null
var sentences = document.get(sentencesAnnotationClass) as java.util.AbstractList;

If i use 'tokenize' and ssplit it is not returning null.When I add 'pos' then sentences above is giving null

Sample is fixed and updated in docs
        var sentencesAnnotationClass = GetAnnotationClass<CoreAnnotations.SentencesAnnotation>();
        var sentences = sentencesAnnotationClass.getClasses().Select(document.get).ToList();


Update to "edu.wpi.first.GradleRIO" version "2020.1.2"

Commit e551f4d75c6989057df1cc5f77cd13dbb197e4b5 adds this to one major branch of work (drivetrain work).  Can that be cherry-picked into the branch(es) with the launcher work?
Or even better, I see that there are only a few (3 non-merge) commits on the "drivetrain work" branches that aren't already in the "launcher work branches".  Can the "drivetrain work" commits be merged into the "launcher work" branches?

Oh, never mind.  It looks like this was done in the "launcher work" branch space in 3a3fad2de5a0331a80f2f0e189907341332e93b5.


Bootstrap onboarding service

Overview
For the fee-less attestation proposal we need to introduce a  new onboarding service that Valora will interact with as an API. This service will be responsible for gatekeeping access to the subsidy and also orchestrating meta-transaction flows in order to complete the subsidy.
This issue is the first step in building out this service by initialising a new package in celo-monorepo that will hold the service and setting up the skeleton of an HTTP API according to Celo best practices.

With Komenci in production, it seems that this issue should be closed. Feel free to re-open if I am wrong


fix kill after write issue

This approach fixes #11 i.e. if you have fibers reading from bus and you have kill immediately after write to the bus, then the write will be missed. I was able to fix that, but using same AVar.put on cell as write is doing and the kill is happening in the loop forked on initialization of the bus.
I have added some comments to the code but if something is not clear  or seams odd let me know.

The original implementation has many bugs. Just an example:
-- | Blocks until a new value is pushed to the Bus, returning the value.
read ∷ ∀ a r. BusR' r a → Aff a
read (Bus _ consumers) = do
  res' ← AVar.empty
  cs ← AVar.take consumers
  -- *** Kill here leaves consumers empty ***
  AVar.put (res' : cs) consumers
  AVar.take res'

Also, I suspect there is a conceptual problem with consumers. If a consumer is merely and actor doing the read effect, then any time at which the actor is not reading it is also not a consumer.
Lets say a particular actor just reads, then logs what was read, then starts again. While the actor is reading it is a consumer, but while the actor is logging it is not a consumer. Therefore, messages written while the actor is logging will not be read by that actor.
Is that what anyone is expecting of bus? What is actually the expectation? What is meant by consumer?

I think that bug you outlined can be fixed like this:
generalBracket (pure unit)
    { killed: const pure
    , failed: const pure
    , completed: \cs _ → AVar.put (res' : cs) consumers
    }
    (AVar.take consumers)

consumer now represent actors currently blocked by read.
I've been using it usually like this:
forever $ Bus.read >>= \res -> forkAff do ...

but I understand that in some case it might miss some values tho i haven't noticed that yet.

This is what's actually needed I think:
-- | Blocks until a new value is pushed to the Bus, returning the value.
read ∷ ∀ a r. BusR' r a → Aff a
read bus = consume bus $ Done >>> pure

data Step res = Loop | Done res

-- | Registers a new consumer on the bus. Blocks until the consumer returns
-- | `Done x` and then computation is resolved with the `x`.
-- | if Effect raises an exception it will be propagated
consume ∷ ∀ a r output. BusR' r a → (a → Effect (Step output)) → Aff output

This way consuming function can never miss anything. using just that I was able to implement:
-- | Same as `consume` but consuming function returns Aff instead of Effect.
-- | When consuming function is not completed and new value comes in, it gets
-- | killed and is invoked with new value.
consumeLatest ∷ ∀ a r output. BusR' r a → (a → Aff (Step output)) → Aff output


Match [attr] if key attr is present but empty (just like css does)

[attr]: Attribute exists and is not false-y.

CSS does not behave this way. It matches if the attr is present, no matter what value it has. Is there a way to changes this behaviour by configuration?
If not, would you merge a PR that allows this behaviour?

any opinion on that?


Modify the formula in the categorized column to better distinguish why a user is categorized as "invalid".

A small change in the column formula ...

... and the view looks much better

This improvement is tracked as DNEXT-23860


Multi layer

Thanks for sharing the code. The code always produces 1 in all three outputs in Multilayer folder. Would you check the code and would you add the question with requirements within the folder.

I don't remember how well that one worked so that might be normal output. What OS are you running on?

I use the Ubuntu operating system.

What version of Ubuntu? What version of GCC? How are you building and running it?

I have Ubuntu 18.10 and GCC 8.2.0 installed.


update CMake support

remove libpwq support and add internal_workqueue.
also add dtrace rules to generate provider.h

@MadCoder some updates to CMake support.  We'll need more than this before we can switch over, but this was a logical first step.  This is enough to at least get building libdispatch standalone and running the tests to work after the libpwq removal.

Update with a number of additional fixes/tweaks so that CMake is now working nicely for me on Linux to build and test dispatch in combination with swift/utils/build-script.  @MadCoder I think this is ready to merge.
The merge should have no actual effect (since it leaves the autoconf build in place).  Once this PR is merged, I will start submitting PRs to the other swift projects (swift, foundation, swiftpm) to incrementally switch them over to the new build system, once that is done we can finish the process by removing the autoconf-related files from libdispatch.

oops, @dgrove-oss I think I just obsoleted/conflicted some of this by merging @compnerd's #260, should have checked for older open PRs first, sorry

btw, before switching over other projects, it would be good to have the Darwin CMake build support in place so that we can test things together with other projects on Darwin also.
As mentioned in #260 I have mode some progress on that but it needs more work

no worries; @compnerd is better with CMake than I am.   I'll take a look and see if there are parts of this are still needed and put them in a new PR


CSI Secret Store Driver

User Story
As a cluster administrator
I want to offer my users in their namespaced environement the ability to retrieve secrets using -now standardized- CSI secret drivers
So that i can easily offer alternative secret provider in case of specific needs and still offer the same syntax to end users
Test Scenarios
Given the CSI driver is deployed on the cluster by an administrator
When a user creates their SecretProviderClass and secrets-store-inline
Then the user is able to retrieve secrets with inline volume
Given the CSI driver is deployed on the cluster by an administrator
When a user creates their SecretProviderClass with secretObjects
Then the user is able to retrieve secrets within a synchronized kubernetes secret
Implementation
Notes
CSI driver repository
https://github.com/kubernetes-sigs/secrets-store-csi-driver
Syntax example:  Sync as inline volume
https://secrets-store-csi-driver.sigs.k8s.io/getting-started/usage.html
Sync as secret
https://secrets-store-csi-driver.sigs.k8s.io/topics/sync-as-kubernetes-secret.html
Implementation Tasks
The following issues have been created to implement this user story:

Thanks for submitting this issue @Sheepux ! We are reviewing the request.

Any updates in this area? It would be nice to have a similar integration as for e.g. HashiCorp Vault (https://github.com/hashicorp/vault-csi-provider)

Any updates in this area? Looks like Secret Store CSI Driver will be a standard way in k8s now.


not allowing checkbox to get ticked when clicked on empty area of div present on left of checkbox and  accessible only through label name and checkbox itself

Fixes #1763 , #1778
After discussio in #1778
#1763 needs only small changes
Describe the changes you have made in this PR -
Screenshots of the changes (If any) -
before checkbox was accessible even in empty span of div

now checkbox accessible only through labelname and checkbox itself

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@tachyons have a review on this

@tachyons have a review on this

@tachyons have a review on this

@tachyons have a review on this

Add before and after screenshots

Add before and after screenshots

Add before and after screenshots

@tachyons screenshots are being added

Add before and after screenshots

@tachyons screenshots are being added

Can you also make PR title more descriptive about what is changed, Just "fix" won't make sense when we read this commit after few months

Can you also make PR title more descriptive about what is changed, Just "fix" won't make sense when we read this commit after few months

Can you also make PR title more descriptive about what is changed, Just "fix" won't make sense when we read this commit after few months

yup, edited it

Can you also make PR title more descriptive about what is changed, Just "fix" won't make sense when we read this commit after few months

yup, edited it

Can you also make PR title more descriptive about what is changed, Just "fix" won't make sense when we read this commit after few months

yup, edited it,please have a review now

@pavanjoshi914 , your first Title was very generic, your next title is very verbose but still doesn't give the reviewer the full picture!
Maybe something like this "Login Page: Checkbox click area fix" is a more appropriate name 😄. And in the description of the PR you can write whatever you need to explain full picture.

Thanks!

Can you also make PR title more descriptive about what is changed, Just "fix" won't make sense when we read this commit after few months

yup, edited it,please have a review now

@pavanjoshi914 , your first Title was very generic, your next title is very verbose but still doesn't give the reviewer the full picture!
Maybe something like this "Login Page: Checkbox click area fix" is a more appropriate name 😄. And in the description of the PR you can write whatever you need to explain full picture.

😅 I will use short and precise titles onwards..👍


Unable to use helm but kubectl works just fine

Hello,
When I try to do any operation with helm I get the following error: (ex: helm ls -A)
Error: Kubernetes cluster unreachable: Get "https://<IP_ADDRESS>:15000/version?timeout=32s": x509: certificate signed by unknown authority (possibly because of "crypto/rsa: verification error" while trying to verify candidate authority certificate "kubernetes")
The same error doesn't apply to kubectl, where I can do any opperation.
Kind config:
---
kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
containerdConfigPatches:
- |-
  [plugins."io.containerd.grpc.v1.cri".registry.mirrors."localhost:5000"]
    endpoint = ["http://kind-registry:5000"]
kubeadmConfigPatches:
- |
  apiServer:
    certSANs:
      - localhost
      - <IP_ADDRESS>
      - <IP_ADDRESS>
    extraArgs:
      authorization-mode: Node,RBAC
      timeoutForControlPlane: 4m0s
      enable-admission-plugins: NamespaceLifecycle,LimitRanger,ServiceAccount,TaintNodesByCondition,Priority,DefaultTolerationSeconds,DefaultStorageClass,StorageObjectInUseProtection,PersistentVolumeClaimResize,RuntimeClass,CertificateApproval,CertificateSigning,CertificateSubjectRestriction,DefaultIngressClass,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota
networking:
  disableDefaultCNI: true
  podSubnet: <IP_ADDRESS>/16
nodes:
  - role: control-plane
  - role: worker
  - role: worker
  - role: worker

The major change I made was generating new certificates in order to be able to access the server through that IP address (<IP_ADDRESS>):
docker exec `docker ps | grep control | cut -d" " -f 1` mv /etc/kubernetes/pki/apiserver.crt /etc/kubernetes/pki/apiserver-etcd-client.key /etc/kubernetes/pki/apiserver-kubelet-client.crt /etc/kubernetes/pki/front-proxy-ca.crt /etc/kubernetes/pki/front-proxy-client.crt /etc/kubernetes/pki/front-proxy-client.key /etc/kubernetes/pki/front-proxy-ca.key /etc/kubernetes/pki/apiserver-kubelet-client.key /etc/kubernetes/pki/apiserver.key /etc/kubernetes/pki/apiserver-etcd-client.crt /root
docker exec `docker ps | grep control | cut -d" " -f 1` kubeadm init phase certs all --apiserver-advertise-address `kubectl get no -o wide | grep control | cut -d" " -f 16` --apiserver-cert-extra-sans <IP_ADDRESS>,<IP_ADDRESS>
docker exec `docker ps | grep control | cut -d" " -f 1` mv /etc/kubernetes/admin.conf /etc/kubernetes/controller-manager.conf /etc/kubernetes/kubelet.conf /etc/kubernetes/scheduler.conf /root
docker exec `docker ps | grep control | cut -d" " -f 1` kubeadm init phase kubeconfig all
docker restart `docker ps | grep control | cut -d" " -f 1`

Configuration done on the control-plane container.

Output of helm version:
version.BuildInfo{Version:"v3.4.2", GitCommit:"23dd3af5e19a02d4f4baa5b2f242645a1a3af629", GitTreeState:"dirty", GoVersion:"go1.15.5"}
Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.2", GitCommit:"f5743093fd1c663cb0cbc89748f730662345d44d", GitTreeState:"clean", BuildDate:"2020-09-16T21:51:49Z", GoVersion:"go1.15.2", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.15", GitCommit:"2adc8d7091e89b6e3ca8d048140618ec89b39369", GitTreeState:"clean", BuildDate:"2020-09-14T07:56:51Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
kind version 0.9.0 running Kubernetes v1.16.15

Found out what the problem was.
Since the name of the kubeconfig was different from name of the cluster:
clusters:
  - cluster:
      name: kind-sandbox

The helm was detecting the certificate present inside the file.
Since I need to connect to multiple clusters, the way I populate the KUBECONFIG environment variable is through a script:
#!/usr/bin/env bash

DEFAULT_KUBECONFIG_FILE="$HOME/.kube/config"

if test -f "${DEFAULT_KUBECONFIG_FILE}"
then
  export KUBECONFIG="$DEFAULT_KUBECONFIG_FILE"
fi

ADD_KUBECONFIG_FILES="$HOME/.kube/config-files"
mkdir -p "${ADD_KUBECONFIG_FILES}"

OIFS="$IFS"
IFS=$'\n'
for kubeconfigFile in `find "${ADD_KUBECONFIG_FILES}" -type f -name "*.yml" -o -name "*.yaml"`
do
    export KUBECONFIG="$kubeconfigFile:$KUBECONFIG"
done
IFS="$OIFS"

If I set the KUBECONFIG variable with the value ~/.kube/config it works just fine.
With the script approach, the name of the file needs to mach name inside the file.

Found out what the problem was.
Since the name of the kubeconfig was different from name of the cluster:
clusters:
  - cluster:
      name: kind-sandbox

The helm was detecting the certificate present inside the file.
Since I need to connect to multiple clusters, the way I populate the KUBECONFIG environment variable is through a script:
#!/usr/bin/env bash

DEFAULT_KUBECONFIG_FILE="$HOME/.kube/config"

if test -f "${DEFAULT_KUBECONFIG_FILE}"
then
  export KUBECONFIG="$DEFAULT_KUBECONFIG_FILE"
fi

ADD_KUBECONFIG_FILES="$HOME/.kube/config-files"
mkdir -p "${ADD_KUBECONFIG_FILES}"

OIFS="$IFS"
IFS=$'\n'
for kubeconfigFile in `find "${ADD_KUBECONFIG_FILES}" -type f -name "*.yml" -o -name "*.yaml"`
do
    export KUBECONFIG="$kubeconfigFile:$KUBECONFIG"
done
IFS="$OIFS"

If I set the KUBECONFIG variable with the value ~/.kube/config it works just fine.
With the script approach, the name of the file needs to mach name inside the file.

hi @aanogueira. Glad you were able to determine the cause of the issue. Is there a patch required to fix this behaviour, or can we consider this resolved and close out the issue?

hi @aanogueira. Glad you were able to determine the cause of the issue. Is there a patch required to fix this behaviour, or can we consider this resolved and close out the issue?

It was kinda odd the fact that the helm was not able to connect to the cluster just because the file had a different name that the cluster name.
Once I have the time, I'll take a look at the code to check what is happening.
For now, I think that we can close this issue.
Thank you.

It was kinda odd the fact that the helm was not able to connect to the cluster just because the file had a different name that the cluster name.
Once I have the time, I'll take a look at the code to check what is happening.
For now, I think that we can close this issue.
Thank you.


fix(boilerplate): update RN to 0.69.7 for android fixes

Describe your PR

Upgrades react-native to 0.69.7 to get the Android fixes for https://github.com/facebook/react-native/issues/35210

:tada: This PR is included in version 8.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Added qmtech rp2040 daughterboard support

I have to make a few modifications about pin management since there is no RST neither TRST pins the for QMTECH rp2040 daughterboard, depending on the core FPGA pin configuration the default pin assingment can damage the FPGA pins.
Tested with my rp2040 and its reliable.

Thanks for this contribution!


(GH-1314) Auto-generate command reference docs

This commit adds a rake task to automatically generate the command reference docs
from the option parser.

CLA signed by all contributors.

What do you mean by deleted file?

documentation/bolt_command_reference.md should be deleted and only generated when the docs shipping pipelines run. Sorry my preview had shown that as a collapsed diff and I assumed it had been deleted (which is what we expect).


link to view of resumablejs return 404

hi
please check  link of resumable js blade file.
sorry can't speak english good.
thanks
https://github.com/pionl/laravel-chunk-upload-example/blob/master/resources/views/example/resumable.js.blade.php

https://github.com/pionl/laravel-chunk-upload-example/blob/master/resources/views/example/resumable.blade.php

I guess it was moved to https://github.com/pionl/laravel-chunk-upload-example/blob/master/example/resources/views/example/resumable.blade.php


GDExtension missing CallableCustom class and methods

Godot version
4.x
System information
N/A
Issue description
Currently GDExtension does not have access to the CallableCustom type at all. We can test if a Callable is custom but that's about it. This has become an issue for a addon I maintain that supports building as a module and GDExtension. The addon adds access to the luaAPI for godot. Before adding support for GDExtension when Lua tried to pass a function to GD we would create a Lua func ref and had a CallableCustom class which took that and invoked the Lua func ref in the call method. Creating a Lua func ref makes a copy of the method that must be cleaned up, so we would do that in the deconstructor.
However, when adding GDExtension support I found we don't get access to this class at all. The workaround I used was to expose a method to the class DB that took an array of args and the func ref, when Lua passed a function to GD we would return the Callable with the func ref bound.
There is 2 major issues with this workaround. It forces us to take the arguments as an array instead of being able to take any number. And the bigger issue IMO we do not have a deconstructor meaning I have no way of cleaning up the func ref.
Along with the missing class, Callable itself is also missing methods. We have is_custom(), but are notably missing get_custom(). I assume this is since the class isn't even exposed.
Steps to reproduce

Generate the extension_api.json and gdextension_interace.h files with: godot --dump-extension-api --dump-gdextension-interface
Search for CallableCustom in these files.

Minimal reproduction project
N/A

See: #78813

It's not an issue but a PR

This was implemented in https://github.com/godotengine/godot/pull/79005.


Switch back to shell module instead of command

As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running

/lgtm
/approve
correcting a tiny misunderstanding - can be nudged without further work.


Save Searches

Hat tip to Planet, whose explorer interface has a very handy "Save Search" worklow:

See https://github.com/azavea/raster-foundry/issues/2071; upon reflection, I think this functionality is the same thing as a monitoring project.


[Device problem]: after hold button.. send release message

Link
https://www.zigbee2mqtt.io/devices/WXCJKG13LM.html#xiaomi-wxcjkg13lm
Adapter version
2.7.5
What is missing or not working
i miss the release button message after press one button

2023-06-21 20:47:24MQTT publish: topic 'zigbee2mqtt/0x04cf8cdf3c75b805', payload '{"action":"button_1_hold","last_seen":"2023-06-21T18:47:24+00:00","linkquality":76}'
Info 2023-06-21 20:47:25MQTT publish: topic 'zigbee2mqtt/0x04cf8cdf3c75b805', payload '{"action":"button_1_release","last_seen":"2023-06-21T18:47:26+00:00","linkquality":72}'

Device exposes

Actually the data point button_1 should remain at hold  ture as long as you press it and fall back to false on release.


Add an elegant way to switch between simple and percentage stacked charts

https://chartscss.org/components/stacked/#simple-vs-percentage

Added in v1.2.0. You can now wrap the datasets instance within a SimpleStackedDatasets or a PercentageStackedDatasets decorator.


Free account misleading  message "No data for this time period"

Seems to be:  "Free account does not include ANY history"
Message should be changed.

Additionally, for free account:
A) history view should be disabled and
B) image view should have time dropdown disabled

C) After login free account should show simple view. (Current it displays image view.)
D) selecting a single sensor from the simple view should suppress:
D1) History
D2) zoom
D3) export CSV
D4) hours drop-down

String for free sensors with no data was improved. Other suggestions considered at a later time.


"Watch Demo" Button in Hero Section Redirects to YouTube Instead of Opening in a Dialog

Currently, when the "Watch Demo" button in the hero section is clicked, it redirects users to YouTube.com to view the demo. This external redirection affects user experience by taking them away from the website.
Proposed Solution:
Instead of redirecting to YouTube, the demo video should be displayed in a dialog/modal within the same website. This will improve user engagement by keeping visitors on the site while viewing the demo.
This change would enhance the user experience by providing a more seamless interaction.

That sounds better and cool approach go ahead on this, and please make sure to have responsiveness and also share screenshots/video while submitting the pr


Port to python3

This should work on both python 2 and python 3.
Both sets of unit tests pass for me.

This might fix #41 too

It should fix #41, I got here because of the error with pip using python3 and could clone and 'python setup.py install" .
But then I have some issues with:
JSONDecodeError("Unexpected UTF-8 BOM (decode using utf-8-sig)"


Java tutorial issues with Linux

I'd like to point out some issues I had with following the tutorial for Java on Linux and how I solved.
I'm using Ubuntu 16.04. Please take this as a discussion point; I'm not a  C# developer so I might have done something wrong, but the documentation should be easy to use for anyone (and I guess you want to support Linux' users as well)
On the first step I had to use another editor as Visual studio 2017 doesn't run on Linux; that means I had to build the project manually by command line
After having installed dotnet for Linux, went into /neo-compiler/neoj and run dotnet build I got
$ dotnet run
It was not possible to find any compatible framework version
The specified framework 'Microsoft.NETCore.App', version '1.0.4' was not found.

to make it work i had to change the neoj.csproj's line with the version I have installed (which was 2.0.5)
<RuntimeFrameworkVersion>2.0.5</RuntimeFrameworkVersion>
Created the HelloWorld.java class and compiled to .class with
javac HelloWorld.java -cp org.neo.smartcontract.framework.jar
sudo cp org.neo.smartcontract.framework.jar /usr/share/dotnet
then
$ dotnet run HelloWorld.class
Neo.Compiler.JVM console app v<IP_ADDRESS>
Find entrypoint:HelloWorld::Main
convert succ
write:HelloWorld.avm
SUCC

All good!
I can create a PR adding these information if you want

Please go ahead with that @ianaz

Created PR #396

Merged


Mex files compatibility with Mac OS

Great library, just some minor issues with the mex files on  64-bit Mac OS. Currently, there are no mexmaci64 files in the depository, so running the TSEMO_ Example.m gave errors.
Note  that  paretofront function is only available as paretoset.m from the Matlab file exchange. Also, the link http://liacs.leidenuniv.nl/~csmoda/code/EHVI.rar is broken, whereas the other link doesn't contain mac 64 mex files. (As a workaround, I used  the general hypervolumemonte function.)
Many thanks!

I added alternative .m files for each mex file, so it should work now. For both the hypervolume and the paretofront calculations the computational speed seems to be unaffected, but the invChol.m is signficantly slower, so it might be a good idea to recompile it using the c file.
Thanks for your helpful comments and hope it works now for you.

Fortunately, it's  easy for the invChol.m,  as https://se.mathworks.com/matlabcentral/fileexchange/34511-fast-and-accurate-symmetric-positive-definite-matrix-inverse-using-cholesky-decomposition contains an .m file for compiling the .c file.
I look forward to using your library. Thank you for the good work.


minikube-docker

What does this PR do?

[x] Adds new functionality
[ ] Alters existing functionality
[ ] Fixes a bug
[ ] Improves Documentation

A brief description of changes to implementation or controller behavior:
Added using docker as container.
Motivation for change:
Option to use docker as container.
Code Quality
Testing

[ ] I used existing unit tests
[x] I manually tested locally
[ ] I will manually test in a canary deployment

Please list your manual testing steps (sample yaml file, commands, important checks):
Checklist

[ ] The documentation is up to date
[ ] My code is sufficiently commented
[ ] I have tested to the best of my ability
[x] I have signed my commit (see Contributing Docs)

@nikos912000


When I press spacebar to pause/play, it overlays several duplicate tracks of the song

Basically I disabled the iTunes play/pause launch ability with a .dmg patch so I can use the play/pause button and have it just work for Radiant Player.  The issue is if I try to stop Radiant Player using spacebar even by mistake, pure instinct this aforementioned error occurs where the song plays over and over offset by the number of seconds paused basically.

Can you reproduce this in Safari?  (like, open GPM in Safari and try to replicate)

No, it just happens in Radiant Player.  I use Chrome and it doesn't happen there.  Just tried Safari too and not there either.


yarn dev throws long list of errors on typescript  branch

Hi.
The steps I followed:

git clone https://github.com/segmentio/evergreen.git
yarn
yarn dev

Everything went fine and I was able to run the storybook on localhost://6006.
But after this as I did :

git checkout typescript
yarn dev
And then a long list of errors were thrown.

`ERROR in ./.storybook/config.js
Module build failed: Error: Cannot find module '@babel/preset-typescript' from '/Users/biswarupbanerjee/Desktop/Dream/evergreen'
at Function.module.exports [as sync] (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/resolve/lib/sync.js:69:15)
at resolveStandardizedName (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/files/plugins.js:101:31)
at resolvePreset (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/files/plugins.js:58:10)
at loadPreset (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/files/plugins.js:77:20)
at createDescriptor (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/config-descriptors.js:154:9)
at items.map (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/config-descriptors.js:109:50)
at Array.map ()
at createDescriptors (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/config-descriptors.js:109:29)
at createPresetDescriptors (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/config-descriptors.js:101:10)
at passPerPreset (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/config-descriptors.js:58:96)
at cachedFunction (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/caching.js:33:19)
at presets.presets (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/config-descriptors.js:29:84)
at mergeChainOpts (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/config-chain.js:320:26)
at /Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/config-chain.js:283:7
at buildRootChain (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/config-chain.js:68:29)
at loadPrivatePartialConfig (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/partial.js:85:55)
@ multi<EMAIL_ADDRESS><EMAIL_ADDRESS>(webpack)-hot-middleware/client.js?reload=true ./.storybook/config.js
ERROR in ./.storybook/addons.js
Module build failed: Error: Cannot find module '@babel/preset-typescript' from '/Users/biswarupbanerjee/Desktop/Dream/evergreen'
at Function.module.exports [as sync] (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/resolve/lib/sync.js:69:15)
at resolveStandardizedName (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/files/plugins.js:101:31)
at resolvePreset (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/files/plugins.js:58:10)
at loadPreset (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/files/plugins.js:77:20)
at createDescriptor (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/config-descriptors.js:154:9)
at items.map (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/config-descriptors.js:109:50)
at Array.map ()
at createDescriptors (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/config-descriptors.js:109:29)
at createPresetDescriptors (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/config-descriptors.js:101:10)
at passPerPreset (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/config-descriptors.js:58:96)
at cachedFunction (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/caching.js:33:19)
at presets.presets (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/config-descriptors.js:29:84)
at mergeChainOpts (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/config-chain.js:320:26)
at /Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/config-chain.js:283:7
at buildRootChain (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/config-chain.js:68:29)
at loadPrivatePartialConfig (/Users/biswarupbanerjee/Desktop/Dream/evergreen/node_modules/@babel/core/lib/config/partial.js:85:55)
@ multi<EMAIL_ADDRESS>./.storybook/addons.js<EMAIL_ADDRESS>So how to fix this?

Did you install deps on the new branch when you switched? yarn install should do the trick.

Hi,
Yes I tried doing yarn install in the new branch as well.
But now the error log is as follows:
ERROR in [at-loader] ./src/autocomplete/stories/index.stories.tsx:39:8
TS2322: Type '{ children: ({ getInputProps, getRef, inputValue }: any) => Element; title: string; onChange: (selectedItem: any) => void; items: any[]; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes & Pick<Readonly<{ children: (props: any) => ReactNode; }> & Readonly<{ children?: ReactNode; }>, "children"> & Partial<...> & Partial<...>'.
Property 'title' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes & Pick<Readonly<{ children: (props: any) => ReactNode; }> & Readonly<{ children?: ReactNode; }>, "children"> & Partial<...> & Partial<...>'.
ERROR in [at-loader] ./src/autocomplete/stories/index.stories.tsx:55:8
TS2322: Type '{ children: ({ getInputProps, getRef, inputValue, openMenu }: any) => Element; title: string; onChange: (selectedItem: any) => void; items: any[]; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes & Pick<Readonly<{ children: (props: any) => ReactNode; }> & Readonly<{ children?: ReactNode; }>, "children"> & Partial<...> & Partial<...>'.
Property 'title' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes & Pick<Readonly<{ children: (props: any) => ReactNode; }> & Readonly<{ children?: ReactNode; }>, "children"> & Partial<...> & Partial<...>'.
ERROR in [at-loader] ./src/autocomplete/stories/index.stories.tsx:76:8
TS2322: Type '{ children: ({ getInputProps, getRef, openMenu, inputValue }: any) => Element; onChange: (selectedItem: any) => void; items: any[]; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes & Pick<Readonly<{ children: (props: any) => ReactNode; }> & Readonly<{ children?: ReactNode; }>, "children"> & Partial<...> & Partial<...>'.
Property 'onChange' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes & Pick<Readonly<{ children: (props: any) => ReactNode; }> & Readonly<{ children?: ReactNode; }>, "children"> & Partial<...> & Partial<...>'.
ERROR in [at-loader] ./src/autocomplete/stories/index.stories.tsx:92:8
TS2322: Type '{ children: ({ getInputProps, openMenu, getRef, inputValue }: any) => Element; isFilterDisabled: true; title: string; onChange: (selectedItem: any) => void; items: any[]; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes & Pick<Readonly<{ children: (props: any) => ReactNode; }> & Readonly<{ children?: ReactNode; }>, "children"> & Partial<...> & Partial<...>'.
Property 'title' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes & Pick<Readonly<{ children: (props: any) => ReactNode; }> & Readonly<{ children?: ReactNode; }>, "children"> & Partial<...> & Partial<...>'.
So as we were discussing in the spectrum chat we can either ignore typecheck in the stories or find/fix the type broken types.

Yeah these are two separate types of issues @Bisso1998
The first errors (in the issue) was due to not having npm modules installed (via yarn install) on the new branch yet.
The other errors are TypeScript errors in the stories. We started adding real types to some of the components, but haven't fully converted the stories to match apparently.
This is a great opportunity to fix the stories to use the types properly, and update the types where they need to be adjusted.
Since this isn't a bug with any evergreen releases or the dev commands I'm going to close this issue. Feel free to introduce PRs to resolve some of the mis-used types in the stories!

Perfect.
I will try fixing the stories.


Roll Flutter Engine from ab034478aeab to 2138572b4ec8 (2 revisions)

https://github.com/flutter/engine/compare/ab034478aeab...2138572b4ec8
2023-02-27<EMAIL_ADDRESS>Remove unused flag skia_canvaskit_enable_particles (flutter/engine#39925)
2023-02-27<EMAIL_ADDRESS>Fix shader doc references (flutter/engine#39855)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Enable max empty lines lint

This was a TODO from my original branch on TC, I didn't do it initially because there are quite a lot of violations, and it would have introduced something we weren't enforcing with scss-lint.

Roughly 53 violations in TC.

 Enable max empty lines lint

nice


[DM-25727] Deploy Gafaelfawr on Roundtable

This will take over the /login, /logout, and /auth routes, which
should be merged with the routes declared by the Roundtable ingress
and inherit the TLS settings from them.
Point at the current development branch since this will be tested as
an OpenID Connect provider for Open Distro for Elasticsearch.

Yes, indeed, good call. I moved it to the roundtable app.


add_with_form

Alright, I changed it. Lemme know what you think.

Build is still failing.  Can you try this:

Can you also update ipfs-api-backend-hyper and ipfs-api-backend-actix so they are exporting Form? This would mostly be for convenience so people don't have to import any additional libraries.

Sorry for the delay. Also, sorry, but I'm still new to rust, and I'm not entirely sure how to accomplish what you're asking.

No worries! Basically in ipfs-api-backend-hyper/src/lib.rs, you would add pub use multipart::client::multipart::Form (same with ipfs-api-backend-actix/src/lib.rs). This makes it so there isn't a need to declare a dependency on common_multipart_rfc7578, since you can import it directly from the backend library.
Then, I would update your doc test to this:
    /// ```no_run
    /// use ipfs_api::{IpfsApi, IpfsClient, Form};
    /// use common_multipart_rfc7578::client::multipart;
    /// use std::io::Cursor;
    ///
    /// #[cfg(feature = "with-builder")]
    /// let add = ipfs_api::request::Add::builder()
    ///     .wrap_with_directory(true)
    ///     .build();
    /// #[cfg(not(feature = "with-builder"))]
    /// let add = ipfs_api::request::Add {
    ///     wrap_with_directory: Some(true),
    ///     ..Default::default()
    /// };
    ///
    /// let mut form = Form::default();
    /// form.add_reader_file("path", Cursor::new(Vec::new()), "file.txt");
    ///
    /// let client = IpfsClient::default();
    /// let res = client.add_with_form(form, add);
    /// ```

Rather than import from common_multipart_rfc7578, you can import the Form directly from ipfs_api now.


Removing mirroring pipeline as it moved to ADO

Which issue this PR addresses:
Fixes: https://dev.azure.com/msazure/AzureRedHatOpenShift/_workitems/edit/10495285/
What this PR does / why we need it:
Moved the mirroring pipeline to ADO for several reasons

We are not compiling binaries (aro, container, etc), but rather consuming them.  Because of such, there is no need to sync the entire ARO-RP repo
We consume binaries from another ADO OneBranch pipeline that builds both aro and the container
There is nothing specific to the mirroring pipeline that needs external reviewing. We are only creating Ev2 manifests and bundling artifacts together

Test plan for issue:
https://dev.azure.com/msazure/AzureRedHatOpenShift/_build/results?buildId=49932648&view=results

/azp run ci


Added hls support for media window

Added hls.js dependency to package and hls support for window.
Scaling for hls is not tested thoroughly because i only had one tweet with such content. Also for some reason I wasn't able to get the actual video size of the video container for the new format but a downscaled value instead, which means that I'm multiplying manually. Whether this works for all cases, I don't know, so if you experience weird sizing with such content, that might be the issue.

Alright all the changes that I've made now should fix all the problems we've discussed.
In addition I also made it possible to drag a window now.
I believe that the change from 'on' to 'once' fixed the issue that windows would be rescaled based on the new popup window.

Everything works absolutely fine on both macOS and Linux. Great job!!
In the future, I hope that I will become able to open and close this popup by shortcut key. Maybe e (like a client I use formerly) and Esc?

Yay╭( ･ㅂ･)و ̑̑ ˂ᵒ͜͡ᵏᵎ⁾✩
Hmm yes shortcuts would be nice, as would a window with actual preferences.


Update of typo in instructions

In section 'Configure Azure AD SSO', section 4 c, the first identifier listed needs to be updated from
https://cxone.niceincontact,com/ to https://cxone.niceincontact,com/
Note the typo of ',' instead of '.'
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: edd5b644-622a-f65a-0651-4618dadb659c
Version Independent ID: 707d2bd6-279c-46c9-d945-6aad37759baf
Content: Tutorial: Azure AD SSO integration with NICE CXone - Microsoft Entra
Content Source: articles/active-directory/saas-apps/nice-cxone-tutorial.md
Service: active-directory
Sub-service: saas-app-tutorial
GitHub Login: @jeevansd
Microsoft Alias: jeedes

@ZeffyReport
Thanks for your feedback! We will investigate and update as appropriate.

@ZeffyReport
Thanks for your contribution for enhancing the documentation. We have Performed the Pull request, once it get approve by the author changes will reflect

#Application issue resign off


Checksum verification

The downloaded tar files should be checked against the corresponding sha256 checksum provided by Amazon here: https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/DynamoDBLocal.html
It should be enough to download the sha256 file and verify on build before extraction.

Something like this should work:
RUN curl -O https://s3-us-west-2.amazonaws.com/dynamodb-local/dynamodb_local_${DYNAMODB_VERSION}.tar.gz && \
    curl -O https://s3-us-west-2.amazonaws.com/dynamodb-local/dynamodb_local_${DYNAMODB_VERSION}.tar.gz.sha256 && \
    sha1sum -c dynamodb_local_${DYNAMODB_VERSION}.tar.gz.sha256 && \
    tar zxvf dynamodb_local_${DYNAMODB_VERSION}.tar.gz && \
    rm dynamodb_local_${DYNAMODB_VERSION}.tar.gz

Sounds good. I'll enhance it ASAP.
Thanks for reporting it @razor-x

Fixed here
A quick note,
I see  here that *.tar.gz.sha256 is not available for versions older than 2016-04-19.


Confusing API for subset_speciesList

This is recommendation based on my experience while reviewing this package for JOSS (https://github.com/openjournals/joss-reviews/issues/1768).
Is your feature request related to a problem? Please describe.
I was confused by the API for subset_speciesList. My reading of the vignette was that passing aou.ind would subset the data to only the provided AOU. This matched my intuition for how a function named subset_speciesList would work. However, as documented in the function documentation the behavior is actually the opposite, with the list of species provided being removed and all other species kept.
Describe the solution you'd like
I would consider either renaming this function to something like remove_species or changing the argument names to something like drop_species. This would make the i
Describe alternatives you've considered
Clarifying the vignette to make the behavior clearer would be another option, but I think intuitive naming would go a long way to preventing user confusion.

Agreed. Will update to include remove_spp.. Not sure what I was thinking..

@ethanwhite I have simplified subsetting by removing functions eluding to this, and rather supply  examples of species-level (and other taxonomic level) subsetting in the vignette currently housed in this branch.
Future development includes more niche species subsetting (e.g., function or argument to remove species with crappy detectability).


[WIP] CLI parser refactor

TODO:

[ ] Add failing test indicating exe/how_is is broken.
[ ] Fix things so said test passes.

closed + re-opened to attempt to trigger Hound (https://houndci.com/). doesn't seem to have worked.

whoops probably helps to configure hound first.

I'm just going to ignore hound for now, until I actually configure rubocop.


feat(plugin-chart-table): subject Add tooltip show multiple sort

Change header column tooltip text to notify the user about multi sorting
Related to: https://github.com/apache/superset/issues/10730
Before

AFTER

@villebro @ktmud
If you have any suggestions for other text for the tooltip.

How about "Shift + Click to sort by multiple columns"?

Shift + Click to sort by multiple columns

Sounds good to me. Changed!


Remove unecessary ALS CI files

Description
Remove ALS CI folder
Motivation
This is possible now that #915  is merged. I'll manage the ALS environment settings elsewhere

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 73.854%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3551

Relevant Lines:
4425

💛  - Coveralls


Upgrade to Laxar 2, webpack, Angular 1.6, Jasmine 2

Needs LaxarJS/laxar-angular-adapter#38

Implemented on master (v3.0.0)
BREAKING CHANGE
This widget has been updated to use Laxar 2 APIs. It requires Laxar 2 and can be installed from source or via NPM.


lookup test only features in test code

This PR tries to lookup test "only" features in test code only so that it is not enabled accidentally in production.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X] Does not have any changes that may affect Istio users.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
8e8d49ca7ff595bacd2202b64c9b7e803a5f09bd
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
2e5b813e6494352eb363528febd18865931bbf45
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
0b636228dda3bd1166abeaaf1eb1088927d9105d
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
4907a57913cf1ba23df771de2f5e236486605a5f
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Still working on it.

/retest

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
4907a57913cf1ba23df771de2f5e236486605a5f
link
/test integ-pilot-k8s-tests_istio

lint_istio
7f54b0d91ef572d56c5e3fef924bbc8ac34a1a09
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
7f54b0d91ef572d56c5e3fef924bbc8ac34a1a09
link
/test lint_istio

integ-pilot-k8s-tests_istio
7f54b0d91ef572d56c5e3fef924bbc8ac34a1a09
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

we could do a build tag but its a bit annoying since you need to rebuild

we could do a build tag but its a bit annoying since you need to rebuild

Yeah. I looked t that option but it is annoying to rebuild.

I will close this. I am looking at another solution. I will open a fresh PR when it is ready.