Engine troubleshooting section contains invalid config example

Problem description
When using configuration file listed in the Troubleshoot the Daemon section.
The illegal configuration example:
{
  "debug": true,
  "tls": true,
  "tlscert": "/var/docker/server.pem",
  "tlskey": "/var/docker/serverkey.pem",
  "hosts": "tcp://<IP_ADDRESS>:2376"
}

Particularly hosts parameter. Using the aforementioned syntax leads to inability to start docker daemon due to following error
$ cat /var/log/messages
…
May 17 19:06:11 dockerpit systemd: Starting Docker Application Container Engine...
May 17 19:06:11 dockerpit dockerd: unable to configure the Docker daemon with file /etc/docker/daemon.json: json: cannot unmarshal strin
g into Go value of type []string
May 17 19:06:11 dockerpit systemd: docker.service: main process exited, code=exited, status=1/FAILURE
May 17 19:06:11 dockerpit systemd: Failed to start Docker Application Container Engine.
…

Problem location

I saw a problem on the following URL: https://docs.docker.com/engine/admin/#troubleshoot-the-daemon

Project version(s) affected
# docker version
Client:
 Version:      17.04.0-ce
 API version:  1.28
 Go version:   go1.7.5
 Git commit:   4845c56
 Built:        Mon Apr  3 18:10:54 2017
 OS/Arch:      linux/amd64

Server:
 Version:      17.04.0-ce
 API version:  1.28 (minimum version 1.12)
 Go version:   go1.7.5
 Git commit:   4845c56
 Built:        Mon Apr  3 18:10:54 2017
 OS/Arch:      linux/amd64
 Experimental: false

Suggestions for a fix
While this can signify two potential possibilities:

Documentation contains illegal entry
Docker engine should not freak out when it sees string in hosts parameter.

the easy fix for (1) would be to correct documentation in this manner:
{
  "debug": true,
  "tls": true,
  "tlscert": "/var/docker/server.pem",
  "tlskey": "/var/docker/serverkey.pem",
  "hosts": ["tcp://<IP_ADDRESS>:2376"]
}

This allows to successfully start docker engine
As for the (2), I will create a separate issue in Docker Engine repo, and post a link in here.
Cheers

Unable to locate docker engine repository, it seems to be renamed to Moby, I lost track of this, can't figure out where I should create an issue. Oh well…

This has been fixed, thanks!


xActiveDirectory: Update Example List README with missing Resources

Pull Request (PR) description
This PR adds the resources that were missing to the Example List README.
This Pull Request (PR) fixes the following issues
None
Task list

[ ] Added an entry under the Unreleased section in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in resource directory README.md.
[ ] Resource parameter descriptions added/updated in schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

Merging #391 into dev will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##            dev   #391   +/-   ##
===================================
  Coverage    92%    92%
===================================
  Files        20     20
  Lines      2538   2538
  Branches     10     10
===================================
  Hits       2343   2343
  Misses      185    185
  Partials     10     10

Thanks for all these document fixes! 😃


Migrations with code

https://github.com/AlgebraicJulia/Catlab.jl/pull/823

Subsumed by the new package DataMigrations.jl.


Backend: DB setup using postgres

Beginning goal: Just save result of finished project

We implemented Firebase intstead


max char limit and related UI error messages are added.

What does this pull request aim to achieve? 💯
Resolves #1272
Please be concise and link any related issue(s):

[x] I have checked that no one else is working on similar changes.
[x] I have read the latest README and understand the development workflow.
[x] The name of this branch is: feature/<branch_name> (need to have cloned the repo not forked).
[x] This branch is rebased/merged with the latest master.
[x] There are no merge conflicts.
[x] There are no console warnings and errors.
[x] On the right hand side of this PR, I have linked the appropriate issue(s) under "Issues" and added a project progress under "Projects".

If you have better ideas for UI error messages I can replace them :)

Hi @OzkanAbdullahoglu
I have a question about edit Account for Individual and edit account for Organisation. Should we add this validation also on these screen as stated here #1272 ?
I saw this validation on the Create Organisation profile but not when I edited org profile.

@doheekim93
Please, do you accept this error message: Max character limit (60) is exceeded!

Hi @galeza, I think we have to implement same error type to edit screens, you are right. Let's decide If we are comfortable with message itself, then I can implement it to the other screens too.

Yes...we need to implement this for Create as well as Edit screens for Org and Individual. Currently for the Org description this error message is shown.

Hi @OzkanAbdullahoglu @galeza @tejasm2 -- I think we should keep the error message simple like the "Max. 160 characters" as shown in Tejas' screenshot! Thanks Ozkan!

@joshmorel @OzkanAbdullahoglu - can we make the min length 2? There are people with 2 letter first/last names

@joshmorel @OzkanAbdullahoglu - can we make the min length 2? There are people with 2 letter first/last names

In this PR the min length is only affecting organizations. However, I'd rather just make all of these required (so minLength: 1) and leave it at that. For individual's there might be some 1 letter names out there & for organisation's it's not really a big deal IMHO. The maxLength is more important for avoiding display bugs.

As mentioned by @galeza and others we need to implement for edit org/user account as well.
Two other things:

minLength: 3 I don't see that mentioned in the issue (or was it slack). We should just make it required & maxLength: 60 IMO. But if a PM requrested this then we need to at least display an error message.
I removed minLength limits, required ones also means minLength =  1 ;
In Organization Name, the required/minLength messages aren't being displayed in until submission while Organisation Contact E-mail and the user firstName/lastName fields are? Any idea why? It would be nice to be consistent.
This was coming from react-hooks-form I handled that by adding

  } = useForm({
    mode: "change",
  });

We should also add to B/E schema validators but we can do that later, in another PR.

Hi, I have tried to cover all as much as possible, please check that If I missed something. Also, I added email validation in create-organisation, and I set email max char limit to 30 too.

Looks good from an implementation standpoint :)


Create detail page for series

https://github.com/earslanyunus/A-Project-5-Frameworks/commit/056e7fd5ae3eb0dbc781e9a60a23e99b7d2faf52  function part is finished


Make _SignedInteger and _UnsignedInteger public

in order to enable use of shl/shr and other methods specialized for signed and unsigned integers in a generic context (e.g. for code handling all kinds of signed ints).
This fixes #2390

I've changed the label from "changed" to "added". Making a type public that was previously private is like adding that type to the public contract. Also, in semantic versioning terms, this is not a breaking change, as the "changed" label is meant to imply.


Reduce CP logs verbosity

Reduce ContainerPilot logs verbosity, set to ERROR by default
Fix process name issue in stop.sh

LGTM


Generator hangs on README exists

If a README exists I'm prompted what to do but the generator hangs instead of accepting input

Can you confirm that only happens when there is a README.md file in the working folder? Does that happen when any other file that may get overwritten by the generator?
Also I need to know your OS, and which versions of Node.js and npm (or Yarn) you're using.

I can confirm it started working when I had the idea the existing README is the ... and removed it.
I actually tried it again now and plaid with it, it also hangs on other files if they exist (tested: package.json)
how to reproduce ... simply run the generator twice in the same dir, you may ctrl+c the npm install
OS: Ubuntu 17.04
Node: 8.1.0
npm: 5.0.3
Cheers

I'll request you to upgrade to Node.js v8.1.2 then. Your issue seems related to a regression in the readline module found recently (sources: 1, 2).

I can confirm that as well.
I updated to 8.1.2 and it started working :)
Thx


Add installation steps

Hey @ayushpokh, looks like you forgot to add the installation instructions on the INSTALL.md file.
Can you update? We need that before adding it to the website.

Still waiting on this one to add to the website.

Sorry! Not in the habit of using git/github yet! Didn't see this as pending. Oof.

Updated!


make use of sync.Cond to reduce pilot cpu usage

This is a cherry-pick from #8123
reduce pilot cpu usage from about 20% down to below 1%

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zackbutcher
If they are not already assigned, you can assign the PR to them by writing /assign @zackbutcher in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


kanboard: 1.2.14 -> 1.2.15

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/kanboard/kanboard/releases.
meta.description for kanboard is: "Kanban project management software"
meta.homepage for kanboard is: "https://kanboard.net"
meta.changelog for kanboard is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.2.15 with grep in /nix/store/k33scag2392g59rldcdqs9xpbhdv9z0z-kanboard-1.2.15

directory tree listing: https://gist.github.com/30e558edaa7c2c713dbec78f2ca67175

du listing: https://gist.github.com/1339d5e46c59fe1c9912b5f71ce47708

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
kanboard

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/k33scag2392g59rldcdqs9xpbhdv9z0z-kanboard-1.2.15 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A kanboard https://github.com/r-ryantm/nixpkgs/archive/67e481159e836a0ff39b0fa44c97e64cadec9acf.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/k33scag2392g59rldcdqs9xpbhdv9z0z-kanboard-1.2.15
ls -la /nix/store/k33scag2392g59rldcdqs9xpbhdv9z0z-kanboard-1.2.15/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:
- kanboard

Maintainer pings
cc @fpletz @lheckemann for testing.

Bot built all packages dependent on this it and changelog looks good.


"error: The formatting failed please check the console for more details."

I have install the plugin with the guide of wiki, but after all I meet the problem, here is the output:
error: The formatting failed please check the console for more details.

JSFMT ==>
[Errno 32] Broken pipe

I was thought it was occur by the wrong node path, I have try to reset the path with some different expression, like /c/Program Files/nodejs/node.exe, C:/Program Files/nodejs/node.exe or  \"C:/Program Files/nodejs/node.exe\" but all of it doesn't work
I'm not sure, there may be the error origin? when I input npm ls esformatter, the output is
+--<EMAIL_ADDRESS>`--<EMAIL_ADDRESS>  `--<EMAIL_ADDRESS>deduped

I don't know which is wrong

hi @Orpheusown
are you following this guide? https://github.com/royriojas/esformatter-jsx/wiki/Usage-with-jsfmt
To be honest lately I haven't been using much esformatter-jsx, the project I'm currently working is using prettier and hence I haven't touch this project for a while.
I can still try to dig into why this is not working for you, but maybe using prettier will be easier for you https://prettier.io/, it is currently being used in big projects like react so this might be helpful for your use case too.


Visual Studio Sources list incomplete

Type: Bug
Hi
Recently added the Sailpoint Identitynow extension to make it easier to access data on a specific tenant. But after adding the tenant, I am only able to view 250 sources from the tenant. While the tenant currently has a total of 656 sources. Please advise.
Regards,
Imraan
Extension version: 0.0.12
VS Code version: Code 1.70.2 (e4503b30fc78200f846c62cf8091b76ff5547662, 2022-08-16T05:35:13.448Z)
OS version: Windows_NT x64 10.0.19044
Modes:

Implemented in v0.0.14


feat: upgrades to<EMAIL_ADDRESS>

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#42  👈
#41
#40
#39
#38
#37
#36
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @matthewhartstonge and the rest of your teammates on  Graphite


iOS stuck at loading when deployment meta is empty

I just installed the v1.2 for iOS to see if it fixes #28. However, the widget still doesn't load and the UI now will stuck at loading (regression?).
Upon checking, it seems that the decoder doesn't handle empty meta gracefully and the exception wasn't handled too (UI wise). Thus, it stuck at loading state (instead of, eg. showing error message).
Here's a screenshot for context:

Exception from decoder
Device stuck in loading state
Possible cause of decoder exception: meta contains empty object instead of data about commit

The error only happens in certain teams. I tried to check Vercel API docs to see if I can find when the API returns empty object for meta. No luck tho.
FWIW, I sometimes manually alias my deployment to promote from staging to live. Maybe those manual aliases are the one with empty meta.

Good catch. I don’t think I realised that a failed decoding for a single key would result in failure to decode the entire response; this should be fixed in 24e5b1d

Putting this here for future reference.
I've checked the fix (v1.2.1 of iOS) and it works. Now the screen won't get stuck if it sees manual deployment. Problem fixed ✔
In addition, I can also see if a push is manual deployment by checking the message (Manual Deployment). Thanks for this!


[wip] extract part of fluent-api from flipbox

Cool! But but why it's in a text file? )

https://github.com/fuse-box/fuse-box/issues/291

Can we amend before merged?

@leon-andria @nchanged where should file go? how should it be exposed?

The fluent API should be independent so it goals is abstract the parsed syntax.
This means that the api will return at the end the parsed arithmetic string. We need to take benefit of the current implement that is already well tested.
So the bundle should accept in parameters the arithmetic parsed object rather than just a string.
This will keep consistency of the current exposed bundle method.
For the fluent api, it may like below:
BundleExpression.startsWith('entry.ts', withDeps:boolean=false)
.include(['**/*.html'], withDeps:boolean=false)
.exclude(['moment'])
.packAs ('fuse-magic')
Does this make sense and unify the existing implementation?

i think we should have exclude and excludeDeps

this still doesn't answer the question, where should this file go? how is it exposed? fsbx.BundleExpression?

I think its good to put it under arithmetic folder under bundlerExpression.ts file. And the final result returns the PropParser object.
Overload methods bundle and initateBundle with typed PropParser type under https://github.com/fuse-box/fuse-box/blob/master/src/core/FuseBox.ts


Building failure on Win

Composer.json include script:
vendor/bin/phing install

On Win machines the proper path is "php vendor\bin\phing install"

I made a commit for this

Closing. Relating to #53


Register mistral actions with lots of errors during installation

OS & ST2 Version
root@RHTPINEC018:~# uname -a
Linux RHTPINEC018.corporativo.pt 3.10.0-693.2.2.el7.x86_64 #1 SMP Sat Sep 9 03:55:24 EDT 2017 x86_64 x86_64 x86_64 GNU/Linux
root@RHTPINEC018:~# st2 --version
st2 2.5.0

Errors while installing mistral (action register phase):
root@RHTPINEC018:/opt# /opt/stackstorm/mistral/bin/mistral-db-manage --config-file /etc/mistral/mistral.conf populate
2017-10-30 13:20:45.616 2675 INFO mistral.db.sqlalchemy.migration.cli [-] populating db
2017-10-30 13:20:46.030 2675 INFO mistral.actions.openstack.action_generator.base [-] Processing OpenStack action mapping from file: /opt/stackstorm/mistral/lib/python2.7/site-packages/mistral/actions/openstack/mapping.json
2017-10-30 13:20:46.052 2675 ERROR mistral.actions.openstack.action_generator.base [-] Failed to create action: nova.floating_ips_list: AttributeError: 'Client' object has no attribute 'floating_ips'
(...) thousand of ERRORs

It seems that the installation works fine anyway!

This is currently expected behavior. https://github.com/StackStorm/st2-packages/issues/487 is the existing tracking issue for fixing this properly in the near future. You can safely ignore these for now - as you point out, the installation will still work.


Remember last

Fixes #4808
Tests performed
Tested build variant on ASUS_X00TD with API level 28

@nicolas-raoul, please review this

@nicolas-raoul, review this, please

@4D17Y4, added the test and did some minor change, please review that, thanks

@nicolas-raoul, can you please review this

@4D17Y4, can you verify this ?

Thanks for your patience @arinmodi.

Just to clarify the functionality of this PR, this basically implements "Last opened screen (if it is Contributions or Nearby, otherwise Contributions)", correct?

Just to clarify the functionality of this PR, this basically implements "Last opened screen (if it is Contributions or Nearby, otherwise Contributions)", correct?

@misaochan Absolutely, correct

LGTM, @4D17Y4 feel free to merge when your requested changes have been made. :)

@4D17Y4, comments added, please review thanks


Dark Mode

Light text on dark background, triggered by browser dark setting. Would also be optimal to have some button to toggle by the user.

@tom-james-watson Can I work on adding this?

Yeah, sure! Though this should just be automatic based on the user's browser settings - I don't want to have a new toggle in the UI.

Do you think something like detoxed.news/dark would make sense for users of Tor and other anti fingerprinting browsers? Or would that just be unnecessary?

What do you mean by "detoxed.news/dark"?

Some anti fingerprinting browsers like Tor have the browser report light mode by default, and users aren't supposed to usually change it because it will make their fingerprint more unique.
Currently, "detoxed.news" is going to display dark/light based on the browser setting, but on browsers like Tor this will always be dark. Maybe at "detoxed.news/dark" it could always display dark?

Ahhh ok. No - I'm not interested in supporting that - unnecessary IMO.


Types: Pull parameter names from header files

I have read the CLA Document and I hereby sign the CLA

Uhhh, this shouldn't have been closed @jasnell

hmm... indeed it shouldn't have. I think it was closed automatically when landing @mrbbot's PR but github won't give me the option to reopen :-(

Huh. Ah well, I'll open a new PR


[Bug]: Colab errors on RETURNING syntax in sqlite

What happened?
Colab does not have an up to date sqlite version. We use the RETURNING syntax and this breaks in sqlite.
Versions
Colab chromadb>=0.4.0
Relevant log output
No response

Plan is:

Check if in colab (try: import google.colab)
Check if sqlite is < 3.35 (https://www.sqlite.org/lang_returning.html says sqlite < 3.35 does not support syntax)
If it is, pip install pysqlite3 and hotswap it https://gist.github.com/defulmere/8b9695e415a44271061cc8e272f3c300

This minimizes the affected surface area to colab users, but fixes it in their case. Users on bad sqlite versions outside of colab will still have the issue, but have a workaround they can use but doing the same outside the calling code, or updating their platform sqlite.

Closed by #851 and in 0.42.

this link has expired https://gist.github.com/defulmere/8b9695e415a44271061cc8e272f3c300

This link is still working for me - are you signed in when you attempt to access it?


[NewProduct] Motorola Mobility

Used the /we/ pages where available ("Rest of Europe"); /us/ otherwise; and if still that fails, anything goes.
No link for "moto g9", "moto e (2020)", "motorola one 5G UW ACE", "motorola one fusion"

Could you add use a releaseLabel/releaseCycle split, similar to #1340. That will ensure that the data is available cleanly over the API.
releaseCycle should be the kebab-case version of the current name being used. (moto-g-pro, moto-g-power-2022 etc)

@moviuro What's the source for the release dates in this PR?

Thanks. I generated an updated version here: https://gist.github.com/captn3m0/069b0fd5879b8a1a549a7dfc45634173, that might be helpful in updating this PR.
I think we can add a activeSupport column, similar to how we're tracking it for Samsung Mobiles. If Motorola is promising a "Next Android", then we can mark it as actively supported.

Okay, looks like we're still at 67 devices.

@captn3m0 can we change this to something like this ->
releaseLabel: {{"__RELEASE_CYCLE__" | replace:'-',''}}
and remove all releaseLabel: tags which doesnt need modification ( just like (year) parts)

This PR was rather old. I just rebased from master.

Just checked all the links, everything is OK except these:

https://www.motorola.in/smartphones-moto-g32/p (404)
https://www.motorola.com/we/smartphones-moto-g-play/p (404)
https://www.motorola.com/us/smartphones-moto-g-power/p (404)
https://www.motorola.com/we/smartphones-razr-5g ()
https://www.motorola.com/us/smartphones-moto-g-stylus/p (301) (redirected to https://www.motorola.com/us/smartphones-moto-g-stylus-gen-2/p)

For the first three those could work (must be checked first) :
diff --git i/products/motorola.md w/products/motorola.md
index 35bcd21..4652941 100644
--- i/products/motorola.md
+++ w/products/motorola.md
@@ -137,7 +137,7 @@ releases:
     releaseDate: 2022-08-01
     eol: 2025-08-01
     support: true
-    link: https://www.motorola.in/smartphones-moto-g32/p
+    link: https://www.motorola.com/we/smartphones-moto-g-32/p
 -   releaseCycle: "moto-g31"
     releaseLabel: "moto g31"
     releaseDate: 2021-11-01
@@ -182,12 +182,12 @@ releases:
     releaseLabel: "moto g power (2021)"
     releaseDate: 2021-01-01
     eol: 2023-01-01
-    link: https://www.motorola.com/us/smartphones-moto-g-power/p
+    link: https://www.motorola.com/us/smartphones-moto-g-power-gen-2/p
 -   releaseCycle: "moto-g-play-2021"
     releaseLabel: "moto g play (2021)"
     releaseDate: 2021-01-01
     eol: 2023-01-01
-    link: https://www.motorola.com/we/smartphones-moto-g-play/p
+    link: https://www.motorola.com/us/smartphones-moto-g-play/p
 -   releaseCycle: "moto-g-5g-plus"
     releaseLabel: "moto g 5g PLUS"
     releaseDate: 2020-07-01

But overall looks like it will be a page difficult to maintain !

But overall looks like it will be a page difficult to maintain !

Agreed. This is also true of other device pages - Samsung, NVIDIA.
I tried to write some code to scrape dates from the Motorala website, but it didn't work out - too much complexity in how the pages are rendered.

I converted my earlier comments to proper review comments.

@marcwrobel could you commit your requested changes on this PR whenever you have free time ?
This PR is waiting here for too long time. Lets we make your suggestions and merge it

@marcwrobel could you commit your requested changes on this PR whenever you have free time ?
This PR is waiting here for too long time. Lets we make your suggestions and merge it

Like @captn3m0 I am focusing on other PRs, feel free to review / apply my suggestions.

Closing this PR as nothing happened since more than 6 months. Will not delete the branch in case someone is interested to restart working on this.


Update antlr4 dep for cel, to fix crash

Updates antlr to fix envoyproxy/envoy-wasm#497
At that time only cel-cpp was updated, but not antlr.
We do not have a unit test that produces the crash.
I have verified that crash does happen with 1.7 build and it does not happen with build that includes antlr-4.7.2.

Can you also change https://github.com/istio/proxy/blob/release-1.7/WORKSPACE#L80 to 472?

@mandarjog: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

test-tsan_envoy_release-1.7
20dabb7645333ef2f6b4a6a5ede4457fa0d8a904
link
/test test-tsan_envoy_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test test-tsan_envoy_release-1.7

@mandarjog: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

test-tsan_envoy_release-1.7
20dabb7645333ef2f6b4a6a5ede4457fa0d8a904
link
/test test-tsan_envoy_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test test-tsan_envoy_release-1.7

@mandarjog per @kyessenov you need to update the antlr_dependencies to 472 as well.


Add support for registering checks with DeregisterCriticalServiceAfter

new string keyword "deregisterCriticalServiceAfter" added to registerService() and registerCheck()
test cases for both

Thank you for PR!
The new parameter type should be std::chrono::minutes rather than string. Please check other chrono duration parameters (e.g. lock_delay) for inspiration if needed.

Thanks for the quick turnaround, much appreciated!


Hi, I can't find the test data

I re-uploaded the sample data.
https://github.com/youngeun1209/NeuroTalk/tree/main/sample_data/test
Please check it!


OneofValidator should allow oneof fields to be empty

The current implementation of the OneofValidator does not allow any oneof field to be not set.
The expected behavior is that it is possible to have unset oneof fields, e.g. we have an origin_id fields in the EventContext message that may be empty by its contract:
// Meta-information for an event.
message EventContext {
    ...
    oneof origin {
        // The context of the command which generated this event.
        CommandContext command_context = 2 [(required) = true];

        // The context of the event which generated this event.
        EventContext event_context = 6 [(required) = true];

        // The event was imported using this `ActorContext`.
        ActorContext import_context = 11 [(required) = true];
    }
    ...
    // An ID of the origin messsage.
    //
    // The case of this `oneof` is always the same as the case of `origin` (except for
    // the `import_context`, which does not have a corresponding field in `origin_id`).
    //
    // The `origin` and `origin_id` groups are not merged for the reasons of binary compatibility.
    //
    oneof origin_id {

        // The ID of the origin command.
        CommandId command_id = 12;

        // The ID of the origin event.
        EventId event_id = 13;
    }
    ...
}

As discussed vocally, the only way to make oneof field required should be to use (required_field option as follows:
message EventContext {
    option (required_field) = "command_context | event_context | import_context";
    ...
    oneof origin {
        // The context of the command which generated this event.
        CommandContext command_context = 2;

        // The context of the event which generated this event.
        EventContext event_context = 6;

        // The event was imported using this `ActorContext`.
        ActorContext import_context = 11;
    }
    ...
}

The `required` option at the message field level for `oneof` fields should be treated now as a configuration error.

Also, by default, `oneof` fields should **not** be required

@yuri-sergiichuk please see if #521 addresses this issue. If so, please close.

Superseded by #521 and fixed in #523 (the new syntax described in the PR).


Remove version: Peppy.Osu! version 2024.114.0

https://github.com/microsoft/winget-pkgs/issues/152768#issuecomment-2102735187

Resolves #152768

Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/ppy/osu/releases/download/2024.114.0/install.exe
OK
(Automated message - build 882)


fix(Climbing): change VRTK_PlayerClimb to allow moving objects.

Allow modeling of Zip Lines, Helicopters, and other interesting moving climbable objects. Fix #697.

There were the following issues with your Pull Request

Commit: bc43029a0f86e136e196f7e15bd0165342d69e7f
Your commit message body contains a line that is longer than 72 characters

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com


32bit arch not supported - Error when initializing clarity-starter

When running npm init clarity-starter (with Rust installed) I get the following error >
$ npm init clarity-starter
System arch "ia32" not supported. Must build from source.
Updating git repository https://github.com/blockstack/blockstack-core.git
error: multiple packages with binaries found: bitcoin-neon-controller, blockstack-core, stacks-node
Cargo build failed with exit code 101
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>postinstall: node postInstallScript.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Still getting this error. Can anyone help?


[WIP] Add connected components to retworkx-core

This PR adds the connected_components and number_connected_components functions to retworkx-core. Needs a release note and maybe further tests and docs.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 42 (0.0%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.4%) to 97.738%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

retworkx-core/src/connectivity/conn_components.rs
0
42
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/shortest_path/all_pairs_dijkstra.rs
2
98.54%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
11063

Relevant Lines:
11319

💛  - Coveralls

@mtreinish Remaining is,

Add tests to docs
Release note
Remove retworkx's crate version of these functions and update python interface to point to retworkx-core version.

With current trait restrictions we can't really remove retworkx's crate version of these functions since they also work for directed StableGraphs.

Can you elaborate on this for me? What are the trait restrictions? Thanks.

This latest version should resolve all the open review issues here. The following changes have been made,

Remove the retworkx/src/connectivity/conn_components.rs file and change the mod.rs file in that directory to point to retworkx/retworkx-core/src/connectivity/conn_components.rs.
Change the 3 functions in retworkx-core/src/connectivity/conn_components.rs to work with either directed or undirected graphs.
Set up 3 layers of testing for the retworkx-core rust code. The first is doc-string tests. The second is tests within the module where a function is defined. The last is a new retworkx-core/tests directory, where more complex integration tests can be placed. Running cargo test within the retworkx-core directory will run all 3 types of tests.


Switch to geerlingguy docker and node

Closing, tried with fresh home desktop setup and ran into issues

Closing, tried with fresh home desktop setup and ran into issues


bug: parallel tasks conflict with each other

Neovim version (nvim -v)
NVIM v0.10.0-dev-673+g622ae2f53
Operating system/version
Ubuntu 22.04.2 LTS
Describe the bug
When I run .vscode/tasks.json in parallel, it appears some npm tasks are interfering with each other.
With below config, I run a backend project and a frontend project, both on separate npm files. The first task should load the package.json file from the /backendfolder. When I run this task it works. If I run the compound task, the backend task fails saying it cannot find the start task. The log file indicates it is working on the wrong package.json file. It appears the working directory configuration is not being picked up properly when running as a compound task.
Steps To Reproduce

nvim -u repro.lua
Create file as described below: .vscode/tasks.json, package.json & backend/package.json
:OverseerRun, select run all, note that the run backend task will fail
:OverseerToggle to see the results
:OverseerRun select run backend, it will work

Expected Behavior
The task should function the same as when running the task by itself. The cwd option should apply and the task should not fail.
Minimal example file
.vscode/tasks.json
{
  "version": "2.0.0",
  "tasks": [
    {
      "label": "run backend",
      "type": "shell",
      "command": "npm",
      "options": { "cwd": "${workspaceFolder}/backend" },
      "args": ["run", "backend"]
    },
    {
      "label": "run frontend",
      "type": "shell",
      "command": "npm",
      "args": [        "run",       "frontend"      ]
    },
    {
      "label": "run all",
      "dependsOn": ["run frontend", "run backend"]
    }
  ]
}

package.json
{
    "name": "frontend",
    "version": "0.0.0",
    "private": true,
    "scripts": {
        "frontend": "echo 'hi'"
    },
    "dependencies": {    },
    "devDependencies": {    }
}

backend/package.json
{
    "name": "backend",
    "version": "0.0.0",
    "private": true,
    "scripts": {
        "backend": "echo 'hi'"
    },
    "dependencies": {    },
    "devDependencies": {    }
}

Minimal init.lua
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({
    "git",
    "clone",
    "--filter=blob:none",
    "--single-branch",
    "https://github.com/folke/lazy.nvim.git",
    lazypath,
  })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  { "stevearc/dressing.nvim", config = true },
  {
    "stevearc/overseer.nvim",
    config = function()
      require("overseer").setup({
        -- add your overseer config here
      })
    end,
  },
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

Additional context

Should be fixed!


Question: HTTP Error (400): 'offset' not supported

HI,
Thanks for the awesome plugin.
i am using below two lines to return all printers in my controller file.
$printers = Printing::printers();
return $printers;
It does not show anything.
Then i find rawlink/laravel-printing/src/printing.php file where i pass the $e. Then i get the error [{"statusCode":"400","message":"HTTP Error (400): 'offset' not supported"}]
public function printers(): Collection
{
    try {
        $printers = $this->driver->printers();
    } catch (\Throwable $e) {
        $printers = collect([$e]);
    }
    $this->resetDriver();
    return $printers;
}

Am i doing something wrong?

Same here. I installed and was presented with an empty list. I dived deep and reached PrintNode\Client. It is the source of bug. I'll see if I can come up with something meaningful.

@flexchar Thanks bro, perfectly working

Same here. I installed and was presented with an empty list. I dived deep and reached PrintNode\Client. It is the source of bug. I'll see if I can come up with something meaningful.
~It seems like there is a pull-request fixing this issue back in 2017. Honestly it strikes me hard how the package of a commercial product is this abandoned. PrintNode/PrintNode-PHP#20~
Turns out they changed API for newly created users to use different offset string and thus why the issue arose. I created simple pull that fixes PrintNode/PrintNode-PHP#41. I also contacted them - they're planning on refreshing client libraries later this year.

So I'm having this same issue with the latest 1.3 version of this package.
Looking more into it, PrintNode patched this in dev-master but did not tag it. When trying to require dev-master, it doesn't work due to being locked to rc1.


Create Database - Support Passing DatabaseInput Dict

It would be nice if the calls to create_database supported the additional options that are supported when creating a database via boto.
AWS SDK for pandas is already passing DatabaseInput to the call to create the database, but is not exposing it in a way that can be extended by the caller.
The specific use case is that the LocationUri needs to be set on databases when Glue is configured to act as the Hive Metastore for EMR.

Thanks @bradleyhurley, I think that's a fair ask, I'll propose a change.

@bradleyhurley We just released last week so it will most likely be several weeks before another. As of now you'll need to pull the library into your codebase from git.


Show only circular indicator

Hi, is it possible to just the loading indicator without the message and center it?

check the child property

What do I need to do in the child property to remove the Text and also center the circularIndicator? Sorry I am new to flutter

Yeah, that's okay
pr = ProgressDialog(
      context,
      type: ProgressDialogType.Normal,
      isDismissible: true,
      /// your body here
      customBody: CircularProgressIndicator(
        valueColor: AlwaysStoppedAnimation<Color>(Colors.blueAccent),
        backgroundColor: Colors.white,
      ),
    );


support multiline parser in in_tcp plugin

From the doc:

Unlike other parser plugins, this plugin needs  special code in input plugin, e.g. handle format_firstline. So  currently, in_tail plugin works with multiline but other input plugins  don't work with multiline.

It would be nice to support multiline parsing in the in_tcp plugin as well. I am using in_tcp to process log events that are delimited by '\n'. But the log message inside the log event might also contain '\n'. So with the multiline parser I would be able to aggregate those in a single log event, which is currently not possible.

v0.12 is not maintained anymore, I'll close it.


[Enhancement] Implement an API for relating eve entities to wars.

Provide an API to help fill the gap left by ESI with regards to connecting characters/corporations/alliances to active/upcoming/historical wars.

I guess something like...
/api/wars?character_id=
/api/wars?corporation_id=
/api/wars?alliance_id=
to show wars only related to those entities would work - just need to make a lookup for character to see which corp they're in (easy enough)
After that you can always request all the wars related to those entities directly from /api/wars/ or from ESI 😅


Add option to not apply instrument- prefix to service names

This adds a new option prefix_service, true by default. Necessary because for some reason on lsstcam hosts services are being defined without the prefix, in contrast to eg comcam, which does use the prefix.

Agreed about the tests; but the existing coverage for this module is very basic, and I don't think I know how to add the necessary machinery to test more thoroughly.


runtime: GOMAXPROCS has outdated information

What version of Go are you using (go version)?

go version go1.15.1 linux/amd64

Does this issue reproduce with the latest release?
yes
What did you do?
Read a documentation of runtime.GOMAXPROCS
What did you expect to see?
According to go1.5 release notes there's no need anymore to explicitly call this function at the start of any golang application to set the maximum number of CPUs equal to runtime.NumCPU.
What did you see instead?
The number of logical CPUs on the local machine can be queried with NumCPU. This call will go away when the scheduler improves. is outdated.
Git blame tells that the last modification to this doc comments was made 9 years ago and it may confuse some users.

The number of logical CPUs on the local machine can be queried with NumCPU. This call will go away when the scheduler improves.

Neither of those statements is incorrect or outdated.
The first statement is correct. Not entirely sure why it is in the GOMAXPROCS docs, though. It suggests the maximum reasonable argument, perhaps? It could be worded better.
It's always been a desire to have the scheduler adjust its processor use automatically, so that GOMAXPROCS would not be necessary. (Not that I think we will ever get there, but one less knob would be great if we can figure out how to do it.)

@randall77, thank you for your comment. The issue that I was trying to describe is located in the description of the method which gives an example of how to use it. I remember the time when we had to explicitly call it in order to make async code work, now this call can be omitted and it simply makes no sense calling it with an argument NumCPU by default. That is why I think it is important to update this part of the description.
Now about the scheduler part. I can understand the idea to completely remove GOMAXPROCS call in the future even, but is it gonna happen someday? Probably. Should this information stay in the method description till that moment? Not sure.

The issue that I was trying to describe is located in the description of the method which gives an example of how to use it.

Where is that? It's not in the GOMAXPROCS doc.

I remember the time when we had to explicitly call it in order to make async code work, now this call can be omitted and it simply makes no sense calling it with an argument NumCPU by default.

You're right that a call to runtime.GOMAXPROCS(runtime.NumCPU()) can be omitted. (At least, on startup. It makes sense to do runtime.GOMAXPROCS(runtime.NumCPU()) if you previously called runtime.GOMAXPROCS with some other argument earlier in the program.)
But there's a big difference between "can be omitted" and "must be omitted". It's not hurting anything to leave it there.
To be clear, I'm happy with changing the description to say that GOMAXPROCS defaults to NumCPU.

Should this information stay in the method description till that moment? Not sure.

I'm not sure either. But someone at some point decided this was worth saying. I'm willing to give them the benefit of the doubt, if for no other reason than it introduces some hysteresis to doc changes so we don't keep changing our minds about it every release.

Where is that? It's not in the GOMAXPROCS doc.

I meant to say that you can interpret these doc comments like an example of how to use it.

But there's a big difference between "can be omitted" and "must be omitted". It's not hurting anything to leave it there.

I'd say that unnecessary call of the code instructions that makes no changes is already hurting us if we want to make things as good as we can.
The whole point I'm trying to make is that by reading current docs for this function you can misunderstand the usage of it. For me, it happened while I was reviewing the code. I checked the docs to make sure that I correctly remember that there was a change that  runtime.GOMAXPROCS(runtime.NumCPU()) for the current go version is the default behavior and what I've found is that The number of logical CPUs on the local machine can be queried with NumCPU. it's definitely not what I was looking for. That's why I had to search for the release notes to make sure that I'm not imagining things.


Error with class parsing

The code below is failed with PSReadLine loaded. Without PSReadLine the code is succeeed.
It is the parser issue not PSReadLine https://github.com/lzybkr/PSReadLine/issues/500#issuecomment-276768379

This is a bug in the parser - it should be throwing an  IncompleteParseException  instead of a  ParseException .

Steps to reproduce
Copy-Paste the code:
class foo
{
    [void]q() { $a=1 }

    [string]$bar
}

Expected behavior
Pass parsing without errors.
Actual behavior
PS C:\> class foo
>>> {
>>>     [void]q() { $a=1 }
>>>
At line:3 char:5
+     [void]q() { $a=1 }
+     ~~~~~~~~~~~~~~~~~~
Missing closing '}' in statement block or type definition.
    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : MissingEndCurlyBrace

PS C:\>     [string]$bar

PS C:\> }
At line:1 char:1
+ }
+ ~
Unexpected token '}' in expression or statement.
    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : UnexpectedToken

Environment data
----------------

<!-- provide the output of $PSVersionTable -->

```powershell
> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      5.0.10240.17146
WSManStackVersion              3.0
SerializationVersion           <IP_ADDRESS>
CLRVersion                     4.0.30319.42000
BuildVersion                   10.0.10011.16384
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3

Name                           Value
----                           -----
CLRVersion
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
GitCommitId                    v6.0.0-alpha.14-61-gfe3d01627a0e7a1a7882d880299ed9e2cb88c97e-dirty
BuildVersion                   <IP_ADDRESS>
PSVersion                      6.0.0-alpha
PSRemotingProtocolVersion      2.3
WSManStackVersion              3.0
SerializationVersion           <IP_ADDRESS>
PSEdition                      Core

1 I think this method can be used when calling【[Void]q】. but Is this method legal in class define? 【[Void] q ()】
2 I have tested the above code and found no problems.powershell.exe  5.1.14393.693
3 So my point is, upgrade your win10 to REDSTONE, win10 10240 version has less than 5%, and has been forced to push upgrade.

I found the root cause. Fix ready. @PowerShellTeam Please assign me.


pgo-client: 4.7.7 -> 4.7.10

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/CrunchyData/postgres-operator/releases.
meta.description for pgo-client is: A CLI client for Crunchy PostgreSQL Kubernetes Operator
meta.homepage for pgo-client is: https://github.com/CrunchyData/postgres-operator
meta.changelog for pgo-client is: https://github.com/CrunchyData/postgres-operator/releases/tag/v4.7.10
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.7.10 with grep in /nix/store/f1vav8zck8y2hlyk9jz6b50dp3zpycz6-pgo-client-4.7.10
found 4.7.10 in filename of file in /nix/store/f1vav8zck8y2hlyk9jz6b50dp3zpycz6-pgo-client-4.7.10

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
pgo-client

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/f1vav8zck8y2hlyk9jz6b50dp3zpycz6-pgo-client-4.7.10 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A pgo-client https://github.com/r-ryantm/nixpkgs/archive/2646204f1cd22b12cfe501b947021d7491179bf4.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/f1vav8zck8y2hlyk9jz6b50dp3zpycz6-pgo-client-4.7.10
ls -la /nix/store/f1vav8zck8y2hlyk9jz6b50dp3zpycz6-pgo-client-4.7.10/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

pgo-client

Maintainer pings
cc @bryanasdev000 for testing.

Result of nixpkgs-review pr 223039 run on x86_64-linux 1

1 package built:

pgo-client


Unable to log in production mode

When I try to run it on production mode I get the following warning: warn - application logger configu"ration in conf files is deprecated and has no effect. Use a logback configuration file instead."
And when I try to login, it doesn't accept the labrad password. I'm using windows 7

Does it work in dev mode?

Hi,
I figure it out. Pressing enter doesn't work, you have to click the login button. I was using the pre-build binary package.

Yeah that got fixed recently.


Add fixed nightly toolchain version for the formatting job

Sets in stone the nightly version of the toolchain used in the formatting CI job.

Codecov Report

Merging #997 (91c5c04) into main (ecc2047) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #997   +/-   ##
=======================================
  Coverage   30.02%   30.02%
=======================================
  Files         415      415
  Lines       26916    26916
  Branches     5243     5243
=======================================
+ Hits         8081     8082    +1
  Misses      16639    16639
+ Partials     2196     2195    -1

Flag
Coverage Δ

unittests-aries-vcx
30.02% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


The GetRows function corrupts the content of the Excel file

When using the GetRows function the Excel file's format is apparently corrupted.
Below is a program that will:

Create or open an existing Excel file named "test.xlsx".
Create a new sheet "test" (existing sheet "test" is deleted first)
Ask if the content of the test sheet should be read with GetRows
If "yes", the rows are printed to the terminal (this works fine)
A final save of the Excel file is done

Now, if one does not print the "test" sheet content to the terminal (point 3 and 4 above), there is no problem, i.e. the Excel file is intact and can be opened in Excel. If, on the other hand, one selects to print the content, the file is corrupted. When trying to open the Excel file afterwards in Excel, I get the error message:
"We found a problem with some content in 'test.xlsx'. Do you want us to try to recover as much as we can? If you trust the source of this workbook, click Yes"
However, the workbook is totally corrupted for the test program below. In another program, I have had the sheet being read by the GetRows function removed from the workbook, but the workbook could be opened normally.
Here is the test program:
package main

import (
	"fmt"
	"log"
	"os"

	"github.com/360EntSecGroup-Skylar/excelize/v2"
)

const s_file = "test.xlsx"
const s_sh_test = "test"

func main() {
	var wb *excelize.File
	var err error

	if fileExists(s_file) {
		wb, err = excelize.OpenFile(s_file)
		if err != nil {
			log.Fatal(err)
		}
	} else {
		wb = excelize.NewFile()
		err = wb.SaveAs(s_file)
		if err != nil {
			log.Fatal("Could not save new Excel file `", s_file, "`: ", err)
		}
		// fmt.Println("Immediate save of new Excel file after SaveAs")
		// saveXlFile(wb)
	}
	if sheetExists(wb, s_sh_test) {
		wb.DeleteSheet(s_sh_test)
	}
	wb.NewSheet(s_sh_test)
	// fmt.Println("Saving Excel file with new sheet test")
	// saveXlFile(wb)

	// add values to the test sheet
	sl_cells := []string{"A1", "A2", "A3", "B1", "B2", "B3", "C1", "C2", "C3"}
	for _, s_cell := range sl_cells {
		wb.SetCellStr(s_sh_test, s_cell, s_cell)
	}
	fmt.Println("Saving Excel file with cells filled in test sheet")
	saveXlFile(wb)

	s_ch := ""
	sl_menu := []string{"yes", "no"}

	for !contains(sl_menu, s_ch) {
		fmt.Printf("Read content of sheet `%s` using GetRows? [yes/no] \n", s_sh_test)
		fmt.Scanln(&s_ch)
	}
	if s_ch == "yes" {
		fmt.Printf("Content of sheet `%s`: \n", s_sh_test)
		rows, err := wb.GetRows(s_sh_test)
		if err != nil {
			log.Fatal(err)
			return
		}
		for i_row, row := range rows {
			fmt.Print("Row: ", i_row, "\t")
			for _, s_cell := range row {
				if s_cell == "" {
					s_cell = "[]"
				}
				fmt.Print(s_cell, "\t")
			}
			fmt.Println()
		}
	}
	saveXlFile(wb)
	fmt.Println("Final save of Excel file")
}

func saveXlFile(wb *excelize.File) {
	err := wb.Save()
	if err != nil {
		log.Fatal("Could not save the Excel file `", s_file, "`: ", err)
	}
}

func sheetExists(wb *excelize.File, s_sh_name string) bool {
	b_fnd := false
	for _, s_sh := range wb.GetSheetList() {
		if s_sh == s_sh_name {
			b_fnd = true
			break
		}
	}
	return b_fnd
}

func contains(sl_str []string, ss string) bool {
	if len(sl_str) == 0 || ss == "" {
		return false
	}
	for _, str := range sl_str {
		if str == ss {
			return true
		}
	}
	return false
}

func fileExists(s_file string) bool {
	info, err := os.Stat(s_file)
	if os.IsNotExist(err) {
		return false
	}
	if info.IsDir() {
		log.Fatal("Error: ", s_file, " is a directory")
	}
	return true
}

Thanks for your feedback, I've tested on the master branch code, and it works well, which version of this library are you using?

I was using v2.4.0,
When I changed to the master branch, the problem is no longer there, so perhaps something that was fixed already.

Okay, I close this issue.


Updates for new m3_ice package

oddly enough I think it will be OK here:

Windows will change the time correctly for daylight savings
Cygwin's unix time is based off the local Windows time
Python just has to correct Cygwin to correctly scale the Windows time

-A
Andrew Lukefahr
<EMAIL_ADDRESS>On Thu, Apr 27, 2017 at 12:25 PM, Pat Pannuto<EMAIL_ADDRESS>wrote:

@ppannuto commented on this pull request.
In platforms/m3/programming/mbus_snoop_snsv7_double_par_csv.py
https://github.com/lab11/M-ulator/pull/12#discussion_r113742351:

import time
import datetime
from datetime import datetime
+#Adjust the default timezone for Cygwin
+from sys import platform
+if platform == 'cygwin':

os.system('export TZ="UTC+4"')

Is this going to cause a problem when daylight savings time changes? (fuck
time zones.. they're the worst.. :( )
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lab11/M-ulator/pull/12#pullrequestreview-35157462,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATh_UDvr2728ZWm9gIyEw2gwQHXTUs5Uks5r0MGHgaJpZM4NKdSa
.

(╯°□°）╯︵ ┻━┻ time zones are the worst. Makes sense


[textanalytics] Update CHANGELOG.md

API change check
API changes are not detected in this pull request.


Remove a being commit container should not be permitted.

Description
Version: docker-1.11.2
Steps to reproduce the issue:

Commit a stop container
At the same time remove this container

The expected result should be:
When container is in commit operation, the delete should not be allowed.

@charlihappy2016 the image created when the commit is completed is it working? Or the commit fails?
Thanks

@gianarb  I tried (with devicemapper graphdriver), the commit is completed, but removing failed with error.
$ docker commit 943a5d04c85f
sha256:662917bef212abbcde83f00131052dbf3991c1f282126887a0c760287dbd1b79

$ docker rm 943a5d04c85f
Error response from daemon: Driver devicemapper failed to remove root filesystem 943a5d04c85fb77031bdec727c8341062f6f0034ea204f2a19eafd52ec292c5b: Device is Busy

As requested in your other issue; please provide the information that was asked for in the issue report template that was shown when opening your issue; https://github.com/docker/docker/issues/29653#issuecomment-268765358, as it may help to identify possible causes, and to reproduce what you're seeing.

@gianarb The image works well. But the container removes failed.

I also tried (with devicemapper graphdriver and docker-1.11.2), docker commit is always completed without any error message, and the image created can work well (maybe there are some files lost but I haven't found) .
But docker rm always returns an error like @coolljt0725 showed above. If I add -f to docker rm, then the container can be deleted. However, without -f, the status of the container being deleted will become DEAD, but I could remove it with docker rm again successfully.
So I don't think there is any problem, all behaviors seem intended.

	Docker version and info
Docker version
Client:
Version:      1.12.5
API version:  1.24
Go version:   go1.6.4
Git commit:   7392c3b
Built:        Fri Dec 16 02:30:42 2016
OS/Arch:      linux/amd64
Server:
Version:      1.12.5
API version:  1.24
Go version:   go1.6.4
Git commit:   7392c3b
Built:        Fri Dec 16 02:30:42 2016
OS/Arch:      linux/amd64
Docker info
Containers: 0
Running: 0
Paused: 0
Stopped: 0
Images: 3
Server Version: 1.12.5
Storage Driver: aufs
Root Dir: /var/lib/docker/aufs
Backing Filesystem: extfs
Dirs: 73
Dirperm1 Supported: false
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
Volume: local
Network: bridge overlay null host
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: apparmor
Kernel Version: 3.13.0-24-generic
Operating System: Ubuntu 14.04 LTS
OSType: linux
Architecture: x86_64
CPUs: 1
Total Memory: 3.861 GiB
Name: ubuntu
ID: XC5Y:RVTS:DCNV:MHBG:47SE:QPHU:GMJS:AYIQ:6526:IUNQ:YUDW:RNOT
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
WARNING: No kernel memory limit support
<IP_ADDRESS>/8
	Execute commands:

Commit testimage by container 94434112ab85:
docker commit 94434112ab85 tsetimage
During that process delete the container :
docker rm 94434112ab85
the remove result is fail with the log;
[root@localhost ~]# docker rm 94434112ab85
Error response from daemon: Driver devicemapper failed to remove root filesystem 94434112ab85d530e4e1607eda7de43fcf6d2bf6a8d3897df51f416697d7f450: Device is Busy
4.the commit result is:
[root@localhost ~]# docker commit 94434112ab85 tsetimage
sha256:847c20f6e50230249fb423129fd0cf921640cb479a89ba76a21d8aec40d14c9e

Ok, so I think I start to understand, but to be sure; the container you are committing; was it running when you committed it, or stopped ?
docker rm should fail if the container is either running (or "paused", which is what happens during commit), but will "proceed" if the container is stopped. I don't think we keep track of a "commit" being in progress, so that would explain why it tries to remove the container (but fails, because the filesystem is in use by the commit action).
@mlaventure @coolljt0725 any thoughts on this? is there a way for the daemon to track if a container is being "committed"?

@thaJeztah  I don't think there is  way to track if a container is being committed. Should we add a new field to container metadata to track this? or can we use Lock to lock container both on container removing and committing?

@coolljt0725 adding more locking sounds dangerous (@cpuguy83?), possibly a new state could be an option.

I haven't checked yet if docker image prune handles this different btw

I'd say a new state is better too. prune would have the exact same issue as it just call the same rm routine

I wouldn't lock the container.
I'd also like to no add a new state.
Maybe instead block at the fs layer.

And by "fs layer", I mean as in the layer store. Not the literal filesystem :)


ERROR "skpy.core.SkypeApiException" on Linux

my code:
def main():
    sk = Skype(skype_user, skype_password,connect=False)  # connect to Skype
    ch = sk.chats.chat(skype_group_id)
    jenkins_to_skype(server, ch)

error:
Traceback (most recent call last):
  File "/var/lib/jenkins/jobs/hpc_api_test/workspace/skype_jenkins.py", line 126, in <module>
    main()
  File "/var/lib/jenkins/jobs/hpc_api_test/workspace/skype_jenkins.py", line 121, in main
    ch = sk.chats.chat(skype_group_id)
  File "/usr/local/lib/python3.9/site-packages/skpy/chat.py", line 491, in chat
    json = self.skype.conn("GET", "{0}/users/ME/conversations/{1}".format(self.skype.conn.msgsHost, id),
  File "/usr/local/lib/python3.9/site-packages/skpy/conn.py", line 214, in __call__
    self.verifyToken(auth)
  File "/usr/local/lib/python3.9/site-packages/skpy/conn.py", line 351, in verifyToken
    self.getRegToken()
  File "/usr/local/lib/python3.9/site-packages/skpy/conn.py", line 478, in getRegToken
    self.verifyToken(self.Auth.SkypeToken)
  File "/usr/local/lib/python3.9/site-packages/skpy/conn.py", line 348, in verifyToken
    self.getSkypeToken()
  File "/usr/local/lib/python3.9/site-packages/skpy/conn.py", line 188, in inner
    return method(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/skpy/conn.py", line 424, in soapLogin
    self.getRegToken()
  File "/usr/local/lib/python3.9/site-packages/skpy/conn.py", line 484, in getRegToken
    endpoint.config()
  File "/usr/local/lib/python3.9/site-packages/skpy/conn.py", line 1063, in config
    self.conn("PUT", "{0}/users/ME/endpoints/{1}/presenceDocs/messagingService"
  File "/usr/local/lib/python3.9/site-packages/skpy/conn.py", line 237, in __call__
    raise SkypeApiException("{0} response from {1} {2}".format(resp.status_code, method, url), resp)
skpy.core.SkypeApiException: ('400 response from PUT https://azwcus1-client-s.gateway.messenger.live.com/v1/users/ME/endpoints/{dd69805b-64c8-418d-9b45-4855336f378f}/presenceDocs/messagingService', <Response [400]>)

PS:
It's ok for me to run this code on Windows,but the above error occurred on Linux.
can you help me?
thanks!

You didn't follow the issue template and didn't include the full HTTP request, so I can't see what the underlying error is.


tmux copying to system clipboard

I was able to do that a few weeks ago but forgot how I did it.
Maybe ref. https://www.rushiagr.com/blog/2016/06/16/everything-you-need-to-know-about-tmux-copy-pasting-ubuntu/ but AFAIRC it didn't require additional software while this article talks about an additional tool.

Duplicate of https://github.com/130s/hut_10sqft/issues/52


Test coverage does not count lines executed by a test in a different package

While working on issue #1186 I was perplexed that make coverage showed no executions of these methods:
https://github.com/elves/elvish/blob/6f3b8a787b8b8eb98e1436316f0d4cc1d00e4604/pkg/ui/text.go#L64-L86
Despite the fact that adding debugging print statements (or panic() calls) showed those methods were being run during test coverage. This article explains why that incorrect coverage occurs.
It is my opinion that indirect coverage is meaningful, and the default Go toolchain behavior is incorrect (i.e. undesirable), for this project. Will there be corner cases that are incorrectly considered to be covered via an indirect test? Maybe. Nonetheless, I don't think that adding explicit unit tests of the uncovered functions is more valuable than implicit tests from other packages. It's more useful to assume that indirect execution during a unit test (i.e., from a different package) is meaningful for this project's test coverage metrics.

I also have a discussion opened at codecov.io to explore whether
a) this project can be configured to produce more accurate coverage metrics for its Go code on codecov.io, or
b) the codecov.io treatment of Go code is currently broken. That is, too pessimistic due to not distinguishing statements always "executed" by the compiler (e.g., 'import(...)` blocks) versus statements executed at run-time.

There are valid reasons both for counting and not counting lines that are covered by tests in a different coverage.
If you think of each package as an individually reusable library, then the fact that the tests of another library exercise some lines in this library should not give you a free pass for not writing unit tests.
However, if you think of packages as just a way of grouping and organizing files in a large project, then a line should be considered covered as long as any test in this project exercises it.
The situation in the Elvish codebase seems to be somewhere in between, so a hybrid solution (if possible) would be ideal:

The top-level directories under pkg are on the end of individually reusable libraries; for example, the edit and eval packages are two very different libraries, and if a test against edit exercises a line in eval, that line should not be considered covered.

On the other hand, when I think about how to group the files within (say) eval into packages, I'm merely using packages as a way to organize code. I think of all code in eval and its subdirectories as one library. So if a test in eval/foo exercises a line in eval/bar, I do want to consider that line covered.

The situation in the Elvish codebase seems to be somewhere in between

Yes, but it is much closer to your second proposition, it seems to me. Yes, some bits of the code, like the web UI, should not be considered as exercising other bits of the code. However, AFAICT, that is not a significant source of differences in the coverage metrics. Even if those bits of the project skewed the coverage metrics it's not clear they do so sufficiently to justify complicating computing the coverage metrics.
Note that we're talking about, as I write this, a 2% coverage difference on macOS between the value reported by go tool -cover without and with this change (86.3% => 88.3%). Using the suggested hybrid approach results in a 0.2% increase in coverage (86.3% => 86.5%) but still shows that pkg/ui/text.go coverage is unchanged.
Note that the example in my opening comment involves code in pkg/edit that indirectly, yet explicitly, executes code in pkg/ui which is not correctly reflected in the coverage metrics using the current, or proposed hybrid, implementation. Whereas my change, as I write this, does correctly reflect those invocations.

I took a deeper dive into the difference in overall coverage as a result of my proposed change. I did so by manually running go tool cover -func=cover with and without my proposed change and comparing the results. The results are below. As you can see a lot of the change is due to code that has no explicit unit test but is implicitly tested via integration tests. Such as the functions in pkg/sys/termios.go. There are a few packages which had improved coverage that I don't yet understand. For example, pkg/parse/parseutil/parseutil.go. Yet others, such as the improved coverage of pkg/testutil/must.go are obviously due to indirect execution by other tests that, it seems to me, should be counted as exercising that code. Overall I don't see any reason to think my proposal produces inflated coverage that cannot be justified.
pkg/cli/addons/histwalk/histwalk.go:128:@walk                 70.0  90.0  20.0
pkg/cli/addons/navigation/navigation.go:53:@Handle            81.8  90.9   9.1
pkg/cli/addons/navigation/navigation.go:165:@SelectedName     80.0  90.0  10.0
pkg/cli/term/buffer.go:92:@TrimToLines                        83.3  91.7   8.4
pkg/cli/term/buffer_builder.go:119:@WriteSpaces                0.0 100.0 100.0
pkg/cli/term/buffer_builder.go:128:@MarkLines                 75.0 100.0  25.0
pkg/cli/term/setup.go:14:@Setup                                0.0 100.0 100.0
pkg/cli/term/setup.go:19:@SetupGlobal                          0.0 100.0 100.0
pkg/cli/term/setup.go:24:@Sanitize                             0.0 100.0 100.0
pkg/cli/term/setup_unix.go:14:@setup                          81.0  85.7   4.7
pkg/cli/term/setup_unix.go:54:@setupGlobal                     0.0 100.0 100.0
pkg/cli/term/setup_unix.go:58:@sanitize                        0.0 100.0 100.0
pkg/daemon/client.go:47:@SockPath                              0.0 100.0 100.0
pkg/eval/builtin_special.go:261:@use                          76.5  82.4   5.9
pkg/eval/compile_effect.go:616:@exec                          80.0 100.0  20.0
pkg/eval/eval.go:218:@InstallDaemonClient                      0.0 100.0 100.0
pkg/eval/eval.go:224:@InstallModule                            0.0 100.0 100.0
pkg/eval/eval.go:235:@SetArgs                                  0.0  75.0  75.0
pkg/eval/eval.go:260:@Eval                                    69.2  92.3  23.1
pkg/eval/frame.go:47:@SetLocal                                 0.0 100.0 100.0
pkg/eval/frame.go:161:@PipeOutput                              0.0 100.0 100.0
pkg/eval/mods/daemon/daemon.go:18:@Ns                          0.0  69.2  69.2
pkg/eval/mods/store/store.go:8:@Ns                             0.0 100.0 100.0
pkg/eval/ns.go:52:@HasName                                     0.0 100.0 100.0
pkg/eval/ns.go:59:@PopName                                     0.0 100.0 100.0
pkg/eval/port_helper.go:21:@PortsFromFiles                     0.0 100.0 100.0
pkg/eval/process_unix.go:15:@putSelfInFg                       0.0  40.0  40.0
pkg/eval/purely_eval.go:13:@PurelyEvalCompound                 0.0 100.0 100.0
pkg/eval/purely_eval.go:17:@PurelyEvalPartialCompound         92.6  96.3   3.7
pkg/eval/vals/concat.go:30:@Error                              0.0 100.0 100.0
pkg/eval/vals/conversion.go:32:@Error                          0.0 100.0 100.0
pkg/eval/vals/conversion.go:41:@Error                          0.0 100.0 100.0
pkg/eval/vals/conversion.go:115:@elvToFloat                   90.0 100.0  10.0
pkg/eval/vals/index.go:41:@Index                              81.8  90.9   9.1
pkg/eval/vals/iterate.go:29:@Iterate                          81.8 100.0  18.2
pkg/eval/vals/repr_helpers.go:20:@WriteElem                   85.7 100.0  14.3
pkg/eval/vals/repr_helpers.go:35:@String                      83.3 100.0  16.7
pkg/eval/vars/element.go:118:@HeadOfElement                    0.0 100.0 100.0
pkg/fsutil/gethome.go:17:@GetHome                             33.3  83.3  50.0
pkg/fsutil/search.go:14:@DontSearch                            0.0 100.0 100.0
pkg/glob/glob.go:29:@Glob                                     61.5  69.2   7.7
pkg/glob/glob.go:182:@matchElement                            93.5  96.8   3.3
pkg/glob/glob.go:246:@matchFixedLength                        81.2  87.5   6.3
pkg/glob/pattern.go:41:@Match                                 33.3 100.0  66.7
pkg/logutil/logutil.go:20:@GetLogger                           0.0 100.0 100.0
pkg/parse/parse.go:720:@exitusCapture                         85.7 100.0  14.3
pkg/parse/parseutil/parseutil.go:12:@FindLeafNode              0.0  85.7  85.7
pkg/parse/parseutil/parseutil.go:27:@Wordify                   0.0 100.0 100.0
pkg/parse/parseutil/parseutil.go:32:@wordifyInner              0.0 100.0 100.0
pkg/parse/parseutil/parseutil.go:46:@isCompound                0.0 100.0 100.0
pkg/parse/quote.go:59:@rtohex                                  0.0  87.5  87.5
pkg/parse/quote.go:73:@quoteDouble                            52.6  73.7  21.1
pkg/store/cmd.go:70:@IterateCmds                               0.0 100.0 100.0
pkg/store/cmd.go:84:@Cmds                                      0.0 100.0 100.0
pkg/store/cmd.go:93:@CmdsWithSeq                               0.0 100.0 100.0
pkg/store/dir.go:104:@Swap                                     0.0 100.0 100.0
pkg/sys/isatty_unix.go:10:@IsATTY                              0.0 100.0 100.0
pkg/sys/select_unix.go:11:@Select                             66.7 100.0  33.3
pkg/sys/signals_unix.go:11:@NotifySignals                      0.0 100.0 100.0
pkg/sys/termios.go:20:@TermiosForFd                            0.0 100.0 100.0
pkg/sys/termios.go:26:@ApplyToFd                               0.0 100.0 100.0
pkg/sys/termios.go:31:@Copy                                    0.0 100.0 100.0
pkg/sys/termios.go:37:@SetVTime                                0.0 100.0 100.0
pkg/sys/termios.go:42:@SetVMin                                 0.0 100.0 100.0
pkg/sys/termios.go:47:@SetICanon                               0.0 100.0 100.0
pkg/sys/termios.go:52:@SetIExten                               0.0 100.0 100.0
pkg/sys/termios.go:57:@SetEcho                                 0.0 100.0 100.0
pkg/sys/termios.go:62:@SetICRNL                                0.0 100.0 100.0
pkg/sys/termios_64bitflag.go:8:@setFlag                        0.0 100.0 100.0
pkg/sys/winsize_unix.go:20:@GetWinsize                         0.0  80.0  80.0
pkg/testutil/must.go:9:@MustPipe                               0.0  75.0  75.0
pkg/testutil/must.go:17:@MustReadAllAndClose                   0.0  80.0  80.0
pkg/testutil/must.go:27:@MustMkdirAll                          0.0  75.0  75.0
pkg/testutil/must.go:37:@MustCreateEmpty                       0.0  80.0  80.0
pkg/testutil/must.go:48:@MustWriteFile                         0.0  66.7  66.7
pkg/testutil/must.go:56:@MustChdir                             0.0  66.7  66.7
pkg/testutil/must.go:70:@Must                                  0.0  50.0  50.0
pkg/testutil/testdir.go:55:@InTempHome                         0.0 100.0 100.0
pkg/tt/tt.go:111:@Match                                        0.0 100.0 100.0
pkg/tt/tt.go:122:@matchOne                                    66.7 100.0  33.3
pkg/tt/tt.go:151:@call                                        81.8 100.0  18.2
pkg/ui/color.go:99:@parseColor                                92.3 100.0   7.7
pkg/ui/styling.go:182:@parseOneStyling                        93.8 100.0   6.2
pkg/ui/text.go:65:@Concat                                      0.0 100.0 100.0
pkg/ui/text.go:79:@RConcat                                     0.0  66.7  66.7
pkg/ui/text.go:196:@String                                     0.0 100.0 100.0
pkg/ui/text_segment.go:91:@Concat                              0.0  80.0  80.0
pkg/ui/text_segment.go:108:@RConcat                            0.0  66.7  66.7
pkg/ui/text_segment.go:149:@VTString                          75.0 100.0  25.0
al:@(statements)                                              86.3  88.3   2.0

The sole invocation of pkg/parse/parseutil/parseutil.go:12:@FindLeafNode (one of the functions that went from zero to non-zero coverage) is from pkg/edit/complete/complete.go. Ideally there would be an explicit unit test of FindLeafNode(). But it seems to me the indirect execution by pkg/edit/complete/complete.go is sufficient to consider the former to have been "covered" (to some extent) since the test of the Complete() function that called FindLeafNode() is likely to fail if Complete() behaved unexpectedly.

Yes, some bits of the code, like the web UI, should not be considered as exercising other bits of the code. However, AFAICT, that is not a significant source of differences in the coverage metrics.

I modified my proposed change to limit cross-package coverage to just those in the pkg/... tree. That made no difference to the overall coverage. We might want to use that modification to protect against future changes to tertiary packages (cmd/..., website/...) that might skew the core elvish coverage but doing so makes no difference today and is unlikely to make a difference in the future.

OK, I am convinced that calculating coverage for the whole project is a reasonable approach.


Python 3.11 support (Py-lint pinned too old version)

Describe the bug
On a system with python 3.11 the pre-commit hook fails.
While using the latest Scaffolding template.
To Reproduce
Affected versions: Latest scaffolding template with python 3.11
Steps to reproduce the behavior:

Change a file and run git commit -m "Update Project Template"
Traceback

Traceback (most recent call last):
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/bin/pylint", line 8, in <module>
    sys.exit(run_pylint())
             ^^^^^^^^^^^^
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib/python3.11/site-packages/pylint/__init__.py", line 21, in run_pylint
    from pylint.lint import Run as PylintRun
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib/python3.11/site-packages/pylint/lint/__init__.py", line 76, in <module>
    from pylint.lint.parallel import check_parallel
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib/python3.11/site-packages/pylint/lint/parallel.py", line 8, in <module>
    from pylint import reporters
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib/python3.11/site-packages/pylint/reporters/__init__.py", line 26, in <module>
    from pylint import utils
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib/python3.11/site-packages/pylint/utils/__init__.py", line 46, in <module>
    from pylint.utils.ast_walker import ASTWalker
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib/python3.11/site-packages/pylint/utils/ast_walker.py", line 7, in <module>
    from astroid import nodes
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib/python3.11/site-packages/astroid/__init__.py", line 51, in <module>
    from astroid.nodes import node_classes, scoped_nodes
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib/python3.11/site-packages/astroid/nodes/__init__.py", line 27, in <module>
    from astroid.nodes.node_classes import (  # pylint: disable=redefined-builtin (Ellipsis)
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib/python3.11/site-packages/astroid/nodes/node_classes.py", line 47, in <module>
    from astroid import decorators, mixins, util
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib/python3.11/site-packages/astroid/decorators.py", line 27, in <module>
    import wrapt
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib64/python3.11/site-packages/wrapt/__init__.py", line 10, in <module>
    from .decorators import (adapter_factory, AdapterFactory, decorator,
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib64/python3.11/site-packages/wrapt/decorators.py", line 34, in <module>
    from inspect import ismethod, isclass, formatargspec
ImportError: cannot import name 'formatargspec' from 'inspect' (/usr/lib64/python3.11/inspect.py)

pylint with mandatory checks.............................................Failed
- hook id: pylint
- exit code: 1

Traceback (most recent call last):
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/bin/pylint", line 8, in <module>
    sys.exit(run_pylint())
             ^^^^^^^^^^^^
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib/python3.11/site-packages/pylint/__init__.py", line 21, in run_pylint
    from pylint.lint import Run as PylintRun
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib/python3.11/site-packages/pylint/lint/__init__.py", line 76, in <module>
    from pylint.lint.parallel import check_parallel
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib/python3.11/site-packages/pylint/lint/parallel.py", line 8, in <module>
    from pylint import reporters
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib/python3.11/site-packages/pylint/reporters/__init__.py", line 26, in <module>
    from pylint import utils
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib/python3.11/site-packages/pylint/utils/__init__.py", line 46, in <module>
    from pylint.utils.ast_walker import ASTWalker
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib/python3.11/site-packages/pylint/utils/ast_walker.py", line 7, in <module>
    from astroid import nodes
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib/python3.11/site-packages/astroid/__init__.py", line 51, in <module>
    from astroid.nodes import node_classes, scoped_nodes
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib/python3.11/site-packages/astroid/nodes/__init__.py", line 27, in <module>
    from astroid.nodes.node_classes import (  # pylint: disable=redefined-builtin (Ellipsis)
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib/python3.11/site-packages/astroid/nodes/node_classes.py", line 47, in <module>
    from astroid import decorators, mixins, util
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib/python3.11/site-packages/astroid/decorators.py", line 27, in <module>
    import wrapt
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib64/python3.11/site-packages/wrapt/__init__.py", line 10, in <module>
    from .decorators import (adapter_factory, AdapterFactory, decorator,
  File "/home/myuser/.cache/pre-commit/reporjo1wbjm/py_env-python3/lib64/python3.11/site-packages/wrapt/decorators.py", line 34, in <module>
    from inspect import ismethod, isclass, formatargspec
ImportError: cannot import name 'formatargspec' from 'inspect' (/usr/lib64/python3.11/inspect.py)

**Expected behavior**
Being able to commit changes with pre-commit hooks.
Cause:
py-lint is pinned to a fixed version 2.11.1 which does not support python 3.11
https://github.com/Tecnativa/doodba-copier-template/blob/19b5ecbba0b0c5d645ed44b6d3dc8e680c2c2815/.pre-commit-config.yaml.jinja#L118-L119
Additional context
Pylint version 2.17.0

2.17 is a small release that is the first to support python 3.11 officially
with the addition of TryStar nodes.

Pylint-odoo is fixed to version 5.0.5. (Which is not latest)
https://github.com/Tecnativa/doodba-copier-template/blob/19b5ecbba0b0c5d645ed44b6d3dc8e680c2c2815/.pre-commit-config.yaml.jinja#L130-L138
Temporary solution
I was able to version bump pylint-odoo to 8.0.20 (Latest).
Yet pylint-odoo limits versionbump of pylint to 2.15
https://github.com/OCA/pylint-odoo/blob/84513d20ed69e8a1eaeccec5c37ce0f952a48098/requirements.txt#L2-L3
Version 2.15 was working for me on python 3.11
Additional questions
Is all this pinning of fixed versions necessary?

#401 should serve for that


Revert changes to linker scripts / --nmagic

--nmagic has side effects which a) break ukvm and b) we don't want in general (results in a single RWX phdr for the entire kernel). Revert those changes, and introduce a possible workaround for FreeBSD.

For the record, the workaround is here: https://sourceware.org/ml/binutils/2009-08/msg00512.html
(don't set OUTPUT_FORMAT() in linker scripts otherwise -z max-page-size does not work)

this works on FreeBSD (compiles, and the resulting test_hello.virtio) boots!


CASMTRIAGE-4039 Fix disk selection

Description

The current disk selection command was providing more than 1 device.
 lsblk -l -o SIZE,NAME,TYPE,TRAN -e7 -d -n | sort -h | awk '{print $2}' | xargs -I {} bash -c "if ! grep -Fq {} /proc/mdstat; then echo {}; fi"
sr0
sdb
sde
sdd

The command was properly returning devices that are not included in the old RAID, but it would coincidentally return sr0 (the remoteISO) first in some cases. This command has previously not returned sr0 first in other installs, in which case it has worked.
The multiple return is sloppy, but doesn't break the command. This change fixes the search command so that it ignores USBs and ROMs, preventing invalid devices like sr0 from being used.
Before:
loki-ncn-m001-pit:~ # lsblk -l -o SIZE,NAME,TYPE,TRAN -e7 -d -n
447.1G sda  disk sata
447.1G sdb  disk sata
447.1G sdc  disk sata
923.6G sdd  disk usb
460.3G sde  disk usb
  1.6G sr0  rom  usb

New lsblk:
loki-ncn-m001-pit:~ # lsblk -l -o SIZE,NAME,TYPE,TRAN -e7 -e11 -d -n | grep -v usb
447.1G sda  disk sata
447.1G sdb  disk sata
447.1G sdc  disk sata

The new lsblk command when used in the full disk selection command now produces this (filtering the RAIDed disks out):
disk="$(lsblk -l -o SIZE,NAME,TYPE,TRAN -e7 -e11 -d -n | grep -v usb | sort -h | awk '{print $2}' | xargs -I {} bash -c "if ! grep -Fq {} /proc/mdstat; then echo {}; fi" | head -n 1)"
echo "Using ${disk}"

output:
Using sdb

Checklist Before Merging

[ ] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[ ] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[ ] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport main


Report the url and key for autodecoding errors

Right now decoding errors are not reporting much information about what happened. It makes finding and fixing the invalid data quite hard. I think it would be great to improve this and I provide one such proposal in this PR but I am open to discuss (and implement) other ways of fixing this.
In case of any decoding error the proposed patch would create a new exception (keeping the original one as .__context__ for reference) with the __url__, __key__ from the sample and the offending key name. You can also catch these errors in handler and log just the interesting info (there is a sample attribute on the exception that allows you to inspect the sample before the failed decoding) but a default traceback would already give you most of the important info:
DecodingError: Caught DecodingError in DataLoader worker process 0.
Original Traceback (most recent call last):
  File "/root/workspace/webdataset/webdataset/autodecode.py", line 552, in decode
    result[k] = self.decode1(k, v)
  File "/root/workspace/webdataset/webdataset/autodecode.py", line 516, in decode1
    result = f(key, data)
  File "/root/workspace/webdataset/webdataset/autodecode.py", line 424, in torch_audio
    return torchaudio.load(fname)
  File "/opt/conda/lib/python3.10/site-packages/torchaudio/backend/soundfile_backend.py", line 221, in load
    with soundfile.SoundFile(filepath, "r") as file_:
  File "/opt/conda/lib/python3.10/site-packages/soundfile.py", line 658, in __init__
    self._file = self._open(file, mode_int, closefd)
  File "/opt/conda/lib/python3.10/site-packages/soundfile.py", line 1216, in _open
    raise LibsndfileError(err, prefix="Error opening {0!r}: ".format(self.name))
soundfile.LibsndfileError: Error opening '/tmp/tmpsexbhodx/file.mp3': File does not exist or is not a regular file (possibly a pipe?).

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/conda/lib/python3.10/site-packages/torch/utils/data/_utils/worker.py", line 308, in _worker_loop
    data = fetcher.fetch(index)
  File "/opt/conda/lib/python3.10/site-packages/torch/utils/data/_utils/fetch.py", line 41, in fetch
    data = next(self.dataset_iter)
  File "/root/workspace/webdataset/webdataset/pipeline.py", line 64, in iterator
    for sample in self.iterator1():
  File "/root/workspace/webdataset/webdataset/filters.py", line 301, in _map
    if handler(exn):
  File "/root/workspace/webdataset/webdataset/filters.py", line 80, in reraise_exception
    raise exn
  File "/root/workspace/webdataset/webdataset/filters.py", line 299, in _map
    result = f(sample)
  File "/root/workspace/webdataset/webdataset/autodecode.py", line 565, in __call__
    return self.decode(sample)
  File "/root/workspace/webdataset/webdataset/autodecode.py", line 556, in decode
    raise new_exc from exc
webdataset.autodecode.DecodingError: {'__url__': './guttenberg-audiobooks-raw-000010.tar', '__key__': 'synapseml_gutenberg_the_firefly_of_france_by_marion_polk_ang', 'key': 'mp3'}

I think there is a potential backwards incompatibility for people who expect to filter for specific exceptions in their custom handler functions. With  this PR they would get a DecodingError with the original exception waiting to be unpacked from the __context__ attribute which would break any code which, for example, runs isinstance on the exception.
Maybe it would be worth the trouble to add some code to always pass the original exception to the handler and optionally add the wrapped one as an optional keyword argument? OTOH this would complicate the "happy path" quite a bit and would probably make it quite confusing for new users.
Another approach would be to stuff the additional information into the original exception and modify the default handlers so it is printed by default (but then you will always get a printout even if you catch the exception unless you modify the handler).

Hey @tmbdev, is this something you'd consider merging at some point? I could spend some time to fix the tests and incorporate any suggestions you might have.

I've merged a slightly different version of this.


xSQLServerNetwork: Set-TargetResource is calling Alter() even when no change is necessary

Details of the scenario you tried and the problem that is occurring:
Set-TargetResource is calling Alter() even when no change is necessary. This is an issue found when building tests for this resource.
The DSC configuration that is using the resource (as detailed as possible):
n/a
Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a
What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a
Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev

Also changed so that it will only restart the service(s) if there was a change (and then only if RestartService was set to $true) .


We can show a "new" and/or "featured" indication for a song

I was looking through my log from yesterday and I saw these lines:
[2024.10.14-16.06.51:934][868]LogSparksSongCatalog: Adding dynamic Featured tag to song buddyholly
[2024.10.14-16.06.51:936][868]LogSparksSongCatalog: Adding dynamic Featured tag to song mrbrightside
[2024.10.14-16.06.51:936][868]LogSparksSongCatalog: Adding dynamic Featured tag to song sevennationarmy
[2024.10.14-16.06.51:938][868]LogSparksSongCatalog: Adding dynamic Featured tag to song whatislove
[2024.10.14-16.06.51:938][868]LogSparksSongCatalog: Adding dynamic Featured tag to song timeless
[2024.10.14-16.06.51:940][868]LogSparksSongCatalog: Adding dynamic Featured tag to song theedgeofglory
[2024.10.14-16.06.51:940][868]LogSparksSongCatalog: Adding dynamic Featured tag to song rainonme
[2024.10.14-16.06.51:941][868]LogSparksSongCatalog: Adding dynamic Featured tag to song comeandgo
[2024.10.14-16.06.51:941][868]LogSparksSongCatalog: Adding dynamic Featured tag to song hysteria
[2024.10.14-16.06.51:941][868]LogSparksSongCatalog: Adding dynamic Featured tag to song carryonwaywardson
[2024.10.14-16.06.51:942][868]LogSparksSongCatalog: Adding dynamic Featured tag to song song2
[2024.10.14-16.06.51:942][868]LogSparksSongCatalog: Adding dynamic Featured tag to song iwannagetbetter
[2024.10.14-16.06.51:943][868]LogSparksSongCatalog: Adding dynamic Featured tag to song killinginthename
[2024.10.14-16.06.51:944][868]LogSparksSongCatalog: Adding dynamic Featured tag to song bringmetolife
[2024.10.14-16.06.51:946][868]LogSparksSongCatalog: Adding dynamic Featured tag to song abcdefu
[2024.10.14-16.06.51:946][868]LogSparksSongCatalog: Adding dynamic Featured tag to song walkemdown
[2024.10.14-16.06.51:949][868]LogSparksSongCatalog: Adding dynamic Featured tag to song hottogo
[2024.10.14-16.06.51:949][868]LogSparksSongCatalog: Adding dynamic New tag to song oceanbreezebeats
[2024.10.14-16.06.51:949][868]LogSparksSongCatalog: Adding dynamic Featured tag to song sayitaintso
[2024.10.14-16.06.51:949][868]LogSparksSongCatalog: Adding dynamic New tag to song sayitaintso
[2024.10.14-16.06.51:949][868]LogSparksSongCatalog: Adding dynamic Featured tag to song fellonblackdays
[2024.10.14-16.06.51:949][868]LogSparksSongCatalog: Adding dynamic New tag to song fellonblackdays
[2024.10.14-16.06.51:949][868]LogSparksSongCatalog: Adding dynamic Featured tag to song undone
[2024.10.14-16.06.51:949][868]LogSparksSongCatalog: Adding dynamic New tag to song undone
[2024.10.14-16.06.51:949][868]LogSparksSongCatalog: Adding dynamic Featured tag to song happy
[2024.10.14-16.06.51:949][868]LogSparksSongCatalog: Adding dynamic New tag to song happy
[2024.10.14-16.06.51:949][868]LogSparksSongCatalog: Adding dynamic New tag to song buryafriend
[2024.10.14-16.06.51:949][868]LogSparksSongCatalog: Adding dynamic New tag to song tropicalheat
[2024.10.14-16.06.51:949][868]LogSparksSongCatalog: Adding dynamic New tag to song paradisepulse
[2024.10.14-16.06.51:950][868]LogSparksSongCatalog: Adding dynamic New tag to song infernoisland2
[2024.10.14-16.06.51:950][868]LogSparksSongCatalog: Adding dynamic New tag to song sizzlinsunshine
[2024.10.14-16.06.51:950][868]LogSparksSongCatalog: Adding dynamic Featured tag to song nightmareschoice
[2024.10.14-16.06.51:950][868]LogSparksSongCatalog: Adding dynamic New tag to song nightmareschoice
Thought it'd be cool to show an indicator on the overlay using this information, this would require the script to be running as the game is launching to make sure it catches the entries as they come. Edit: no it doesn't, the game periodically refreshes this info, I have multiple instances of it in the log. So you just have to display nothing on the matter until these lines appear in the log.

If this were to be implemented I think a more reliable way to set this flag would be through the API. I know fnfestival.co is able to do this by authenticating as a Fortnite client but I would prefer not to do that since it hasn't been necessary so far and I'm not sure what Epic thinks of this kind of data retrieval.


Tags swallowing exceptions

All tags currently swallows all exceptions. We don't have a control over it. But, some tags should also kill processing of it's parents. One example is a json processing, another is a filter declaration. We should not continue with the filter when some of its children fails.

My current thinking is a bit more breaking.

Current implementation of tag exception processing is not correct. On can't define which tag can and which can't swallow exceptions and continue page processing.
I'm thinking about introductions of "error boundaries".
Let any tag exception fail whole page.
Let template author decide which group of tags can transiently fail.

...
<!-- Optional name -->
<error:boundary name="persons">
    ...
</error:boundary>
...

<!-- Optionaly check later -->
<web:out error:passedBoundary="persons">

</web:out>

Closing as obsolete.


fix(package): Readme update and fix ignores

This fixes the npmignore so only the intended files are ignored. Also contains part 1 of a larger update to README

:tada: This PR is included in version 1.2.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Reference resolution fails for project with mix of subfolders and classpath references

if a project is configured as follows ...
src/main/resources/
    ├── openapi.yaml
    ├── types/
        ├── local-types.yaml

... and a model in openapi.yaml has a reference to a model in local-types.yaml, and in turn, that model is an alias to a model found in a classpath resource, then the reference is not resolved.
Example
openapi.yaml (root contract)
LocalModel:
  type: object
  properties:
    sharedModelField:
      $ref: 'types/local-types.yaml#/components/schemas/TypesModel'

local-types.yaml (exists in types folder sibling to root contract)
TypesModel:
  $ref: '/shared-types.yaml#/components/schemas/SharedModel'

shared-types.yaml (this is in shared-types.yaml resource in the classpath, not in file system)
SharedModel:
  type: object
  properties:
    name:
      type: string

The parser attempts to find resolve the reference to /shared-types.yaml by prepending the path of the local types directory, so it looks for types/shared-types.yaml and does not find it. This leave the reference unresolved.
Since the parser is unable to resolve the references, this affects downstream code generation, which creates invalid types for some properties.
A project with a unit test demonstrating the issue is here - https://github.com/douglasbgray/cp-example
This is first observed in version 2.0.24 and still exists in the most recent version 2.1.12.
Here is a PR with a fix and corresponding test - https://github.com/swagger-api/swagger-parser/pull/1892

PR was merged, issue was resolved. Closing.


Implement Poison for Elixir v1.3 calendar types

Hi @devinus,
Could you please implement Poison.Encoder for Elixir v1.3 calendar types and make a new release?
Elixir protocol implementation does not actually check if the thing you are implementing for exists at the moment of implementation, this means you can implement the protocols and be backwards incompatible. Here is how we implemented those for Phoenix.HTML.Safe protocol:
https://github.com/phoenixframework/phoenix_html/commit/d78a082aed6220bb0454a14203f48ee1274b43e6
I think the only difference is that you will want to invoke to_iso8601 on every type instead of to_string invoked in the link above.
Thank you! :heart:

Btw, the reason I am asking for a new release is because I will need it in Ecto. ;D

I think this can now be closed, @josevalim @devinus? 😁


Updating dataset in Indian Last Name

Description
I have added a few last-name titles widely used in India. Please assign it.
Screenshots
No response

Go ahead @Kumar-Ankit56 , but it must have 20+ las_names.