UNAUTHORIZED: authentication required when using multiple imagePullSecrets

What steps did you take and what happened:
Hi there, i am using the trivy-operator to scan my workloads on K8s. This seems not to work if a pod consists of multiple containers, whose images are pulled from different private registries.
So there are multiple containers (inside this pod) and multiple imagePullSecrets within the spec of the deployment definiton.
Trivy fails to pull those images.
What did you expect to happen:
Trivy succeeds to pull those images and scans them.
Environment:

Trivy-Operator version: 0.8.0
Kubernetes version: v1.23

@sfhl thanks you for reporting this issue , can you please add an example of pod manifest with multi containers and multi imagePullSecret

@chen-keinan
sure, so here is a shortened manifest containing this configuration:
...
---
apiVersion: v1
kind: Secret
metadata:
  name: registry-secret-1
  namespace: appstack
data:
  .dockerconfigjson: "XXXXXXXXXXXXXXXXX"
type: kubernetes.io/dockerconfigjson
---
apiVersion: v1
kind: Secret
metadata:
  name: registry-secret-2
  namespace: appstack
data:
  .dockerconfigjson: "XXXXXXXXXXXXXXXXX"
type: kubernetes.io/dockerconfigjson
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: "deployment"
  namespace: appstack
spec:
  replicas: 1
  strategy:
    type: "Recreate"
  selector:
    matchLabels:
      app: "deployment"
  template:
    metadata:
      labels:
        app: "deployment"
        workload: "deployment"
    spec:
      terminationGracePeriodSeconds: 30
      securityContext:
        {}
      hostNetwork: false
      hostPID: false
      hostIPC: false
      automountServiceAccountToken: True
      imagePullSecrets:
        - name: "registry-secret-1"
        - name: "registry-secret-2"
      containers:
        - name: "container-1"
          image: "git-images.registry.de/path/to/first/image/images/image-1:tag"
        - name: "container-2"
          image: "git-images.registry.de/path/to/second/image/images/image-2:tag"
...

kubernetes is pulling both images, the workload/pod is running, but trivy fails to pull with UNAUTHORIZED: authentication required;

kubernetes is pulling both images, the workload/pod is running, but trivy fails to pull with UNAUTHORIZED: authentication required;

thanks , I'll try to reproduce it

Hi there,
any update on this?

@sfhl working on it , probably I'll get a fix for next release 0.12.0

@sfhl based on your example, both Pod containers have the same container registry however using different credential ?

@sfhl thanks for the confirmation , I assume that we will have to support it as this is how kubernetes pull images
1st I'll have to add support to trivy to accept multi credential as currently it support only one

@sfhl I'm creating an trivy-operator v0.12.0-rc which will include a fix for this issue , could you please test it and confirm it solve the issue

hi, tested and seems to work,m thank you!
is it still needed to use version: v0.12.0-rcandtrivy.tag: 0.38.0`?

hi, tested and seems to work,m thank you! is it still needed to use version: v0.12.0-rc and trivy.tag: 0.38.0?

you can pick up latest trivy-operator v0.12.1 all included :)

hi, tested and seems to work,m thank you! is it still needed to use version: v0.12.0-rc and trivy.tag: 0.38.0?

you can pick up latest trivy-operator v0.12.1 all included :)

great, thank you!


App is not running after adding the package

I am facing this error:
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':app:checkDebugDuplicateClasses'.

A failure occurred while executing com.android.build.gradle.internal.tasks.CheckDuplicatesRunnable
Duplicate class kotlin.collections.jdk8.CollectionsJDK8Kt found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk8-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.10)
Duplicate class kotlin.internal.jdk7.JDK7PlatformImplementations found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk7-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.10)
Duplicate class kotlin.internal.jdk7.JDK7PlatformImplementations$ReflectSdkVersion found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk7-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.10)
Duplicate class kotlin.internal.jdk8.JDK8PlatformImplementations found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk8-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.10)
Duplicate class kotlin.internal.jdk8.JDK8PlatformImplementations$ReflectSdkVersion found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk8-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.10)
Duplicate class kotlin.io.path.ExperimentalPathApi found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk7-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.10)
Duplicate class kotlin.io.path.PathRelativizer found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk7-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.10)
Duplicate class kotlin.io.path.PathsKt found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk7-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.10)
Duplicate class kotlin.io.path.PathsKt__PathReadWriteKt found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk7-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.10)
Duplicate class kotlin.io.path.PathsKt__PathUtilsKt found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk7-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.10)
Duplicate class kotlin.jdk7.AutoCloseableKt found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk7-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.10)
Duplicate class kotlin.jvm.jdk8.JvmRepeatableKt found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk8-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.10)
Duplicate class kotlin.jvm.optionals.OptionalsKt found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk8-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.10)
Duplicate class kotlin.random.jdk8.PlatformThreadLocalRandom found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk8-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.10)
Duplicate class kotlin.streams.jdk8.StreamsKt found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk8-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.10)
Duplicate class kotlin.streams.jdk8.StreamsKt$asSequence$$inlined$Sequence$1 found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk8-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.10)
Duplicate class kotlin.streams.jdk8.StreamsKt$asSequence$$inlined$Sequence$2 found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk8-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.10)
Duplicate class kotlin.streams.jdk8.StreamsKt$asSequence$$inlined$Sequence$3 found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk8-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.10)
Duplicate class kotlin.streams.jdk8.StreamsKt$asSequence$$inlined$Sequence$4 found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk8-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.10)
Duplicate class kotlin.text.jdk8.RegexExtensionsJDK8Kt found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk8-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.10)
Duplicate class kotlin.time.jdk8.DurationConversionsJDK8Kt found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk8-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.10)

 Go to the documentation to learn how to Fix dependency resolution errors.

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 5s
Error: Gradle task assembleDebug failed with exit code 1
just after adding the package

seems the problem is on Android only
i tried the package on IOS and its working well
what should i do for android version to make it working ?

Have you tried flutter clean? Had some similar issues after updating to 5.0.1, but that command helped me.

yes i tried many time
i tried move back to old versions like 4
same same

same here ... any solutions?
flutter clean did not help
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':app:checkDebugDuplicateClasses'.

A failure occurred while executing com.android.build.gradle.internal.tasks.CheckDuplicatesRunnable
Duplicate class kotlin.collections.jdk8.CollectionsJDK8Kt found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk8-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.10)
Duplicate class kotlin.internal.jdk7.JDK7PlatformImplementations found in modules jetified-kotlin-stdlib-1.8.22 (org.jetbrains.kotlin:kotlin-stdlib:1.8.22) and jetified-kotlin-stdlib-jdk7-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.10)

Created a new flutter app: same error.
Mac M1 Sonoma 14.4.1
Android Studio Iguana | 2023.2.1 Patch 2
Flutter 3.19.6
Dart 3.3.4
DevTools 2.31.1

same here. I tried to update all of my packages but nothing is changed

yes it works @edibesad
Thank you so much

This is a dependency issue on your side. As of version 4.0.0 you need to upgrade to Java 17 / Android SDK 34 as noted in the changelog: https://github.com/juliansteenbakker/mobile_scanner/blob/master/CHANGELOG.md#400


⚠ Bofrost.de has degraded performance

In 1d097a8, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 882 ms

Resolved: Bofrost.de performance has improved in 914d80a.


docs: fix example

Fixed errors as:
Cannot read property 'search' of undefined
ReferenceError: $event is not defined

Thanks, @vkhv. Sensible correction!
This will be merged after #21. #29 will be merged after as well.

Fixed this in #34
Thanks, @vkhv


Generation tests sometimes exceed the 256 limit for a filename

Describe the feature
e.g. (in net461)
public Task GenerationOfEscapedTypes(string type, string conversions, string underlyingType, string className)
ends up with a test failure of:
 LargeTests.SnapshotTests.GenerationTests.EscapedGenerationTests.GenerationOfEscapedTypesTests.GenerationOfEscapedTypes(type: "internal readonly partial record struct", conversions: "Conversions.NewtonsoftJson | Conversions.SystemTex"..., underlyingType: "@record.@struct.@float.@decimal", className: "escapedTestsinternal_readonly_partial_record_struc"...)
   Source: GenerationOfEscapedTypesTests.cs line 84
   Duration: 183 ms

  Message:
System.IO.DirectoryNotFoundException : Could not find a part of the path 'C:\git\cleanroom\main\Vogen\tests\LargeTests\SnapshotTests\GenerationTests\EscapedGenerationTests\snap-v4.6.1\escapedTestsinternal_readonly_partial_record_structConversions_NewtonsoftJson _ Conversions_SystemTextJson@record.@struct<EMAIL_ADDRESS>
  Stack Trace:
__Error.WinIOError(Int32 errorCode, String maybeFullPath)
FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
FileStream.ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
StreamWriter.CreateFile(String path, Boolean append, Boolean checkHost)
StreamWriter.ctor(String path, Boolean append, Encoding encoding, Int32 bufferSize, Boolean checkHost)
File.InternalWriteAllText(String path, String contents, Encoding encoding, Boolean checkHost)
<Text>d__0.MoveNext() line 8
--- End of stack trace from previous location where exception was thrown ---
ExceptionDispatchInfo.Throw()
TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
<16 more frames...>
<<Verify>b__0>d.MoveNext() line 31
--- End of stack trace from previous location where exception was thrown ---
ExceptionDispatchInfo.Throw()
TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
ExceptionDispatchInfo.Throw()
TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
ExceptionDispatchInfo.Throw()
TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

  (result has additional output)

   Open test log

Use TestHelper.ShortenForFilename(className) used elsewhere

Fixed in 3.0.3 when generation tests were changed to use the same runner (the one that generates the dependencies at runtime based on the framework, rather than use the dependencies specified at compile time of the app)


🏗 separate layers for different responsibilities

Current dependencies on/for this PR:

main

PR #10   👈

This comment was auto-generated by Graphite.


Make the Latex Installation efficient

It would be good if we could make out Installation of Latex easy and also small with only packages necessary for running manim the default way. We can make a choco package for windows and a brew formula for mac and also a script to install in Linux(or publish to any Linux package manager).
I found TinyTex which already does it but it requires some extra modules to work with manim. But we can make it even less space and edit it so that it works with manim.
If we somehow get all the latex packages required for installation we could do this we easily by editing this file. Also, I found a list of packages here. This would be useful for newcomers.

Indeed this would be good. There has been much discussion about this on discord and github, I'll let others chime in @huguesdevimeux @yoshiask @PgBiel

Completly agree with that. IIRC latex packages (miktex, etc) are all broken on choco.
If we can make anything easier to install, we should not hesitate to do it !

Well, making such packages are out of the scope of this project, as LaTeX authors are responsible for their installation scripts. If we want this, we may create a make or something script which identifies the platform and runs commands accordingly.

The only thing which is now required is to know what are packages manim requires and nothing else. One could use texlive base framework and install just the packages required by manim, and that could be automated by a script. This issue is actually to find the packages required for it and not create a new latex package.

@naveen521kk, just to double check: the new #277 would close this issue, yes?

NO. WE SHOULD NOT DISTRIBUTE TEXLIVE OURSELVES.
See FAQ 2 of this doc.

I'm confused. This issue was suggesting the use of TinyTex, which was implemented in #277. But @naveen521kk says it doesn't solve the problem. What am I missing?

This issue for making a package (maybe chocolatey for windows) which has latex just required for manim. This can be easily done once the people at TinyTex work on choco package, by adding it as dependency and installing the extra package which manim requires, using tlmgr. Choco is for windows and similarly it can be done for other OS.(But I don't know.)

Ok so the suggestion is to package our own little version of TinyTex, and by no means for us to package/distribute texlive.
I know that's not what #227 is doing, but it is already using TinyTex, so in principle it did make the installation of Latex more efficient (at least on windows).

Ok so the suggestion is to package our own little version of TinyTex,

Yes. But TinyTex is a modified version of TexLive, and we are gonna do one similar to that for manim.

no means for us to package/distribute texlive

We can distribute it but the condition is that we should download/distribute it from the original source(CTAN repo). We can create a script or something which downloads from that source and modify it to be small.(Like how tinytex does).

(at least on windows)
Also, tinytex can be installed for other OS also.

Oooooh ok finally got it. Thanks!
So it seems like any progress on this issue must wait until TinyTex gets it together and uploads a choco package. If that's the case, I think we should close this and reopen when it's actually feasible.

I will reopen this issue when they create a choco package.

They(means me) have create it https://github.com/yihui/tinytex/pull/236#issuecomment-687230517

Great! So what are the next steps for us?

Great! So what are the next steps for us?

Create a chocolatey package for this with Id manim-tex(or something better?). I will do the rest just tell me the id and that I'd would be something used to install
choco install manim-tex.

This is done for windows
https://chocolatey.org/packages/manim-latex/2020.09
The chocolatey package is approved. I will soon add it to docs. Closing this issue.


Bonnie 1525

This PR re-enables the QRDA export functionality and updates the QRDA version of the exports to r5.
Pull requests into Bonnie require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable ("N/A") and :white_check_mark:.
Submitter:

[x] This pull request describes why these changes were made.
[x] This PR is into the correct branch.
[x] JIRA ticket for this PR: https://jira.mitre.org/browse/BONNIE-1525
[ ] JIRA ticket links to this PR
[x] Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
[x] If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced.
[x] Tests are included and test edge cases
[x] Tests have been run locally and pass (remember to update Gemfile when applicable)
[x] Test fixtures updated and documented as necessary ( see internal wiki ) NA
[] Code coverage has not gone down and all code touched or added is covered.

In rare situations, this may not be possible or applicable to a PR. In those situations:

Note why this could not be done or is not applicable here:
Add TODOs in the code noting that it requires a test
Add a JIRA task to add the test and link it here:

Branch
Back End Coverage
Front End Coverage

master
[Paste Output Here]
[Paste Screenshot Here]

[New Branch]
[Paste Output Here]

[ ] Automated regression test(s) pass

If JIRA tests were used to supplement or replace automated tests:

[x] JIRA test links: NA
[x] Justification for using JIRA tests: NA
[x] JIRA tests have been added to sprint NA

Reviewer 1:
Name: @jbradl11

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

[X] JIRA tests have been run and pass - N/A
[X] You agree with the justification for use of JIRA tests or have provided input on why you disagree - N/A

Reviewer 2:
Name: @c-monkey

[x] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[x] The tests appropriately test the new code, including edge cases
[x] You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

[X] JIRA tests have been run and pass - N/A
[X] You agree with the justification for use of JIRA tests or have provided input on why you disagree - N/A

Tests appear to be failing on travis and locally for me, is this expected? Also, the diff looks a little odd to me. When you are available lets talk about this PR.


advance  tabmenu function

my english is poor ;
this function preview : http://www.zi-han.net/theme/hplus/
the position at top ; [首页] background is black ； when you click lef  sidebar menu_list , the top tabmenu add a tab , the can close and switch , my feel this function is very good!! ;
everybody , feeling ?
thankyou verymuch !!!

+1

I am sorry. I am not sure I understand the request. The page you linked to uses INSPINIA template. Is that what you are looking for?

I ask function like browser tab,…can switch and close  ……when open new sidebar link at top menu add tab and websiteNo refresh all page

Looks like a good idea. We will consider it for a future version of AdminLTE.
Thanks!


CAPZ Flatcar images are reporting an error when loading audit rules

Motivation
Follow up to https://github.com/giantswarm/roadmap/issues/1659
With our custom CAPZ Flatcar image there is an error reported by the audit-rules.service

I can't understand the error
The rules seems to load properly

➜ k node-shell fctest1-control-plane-c6bd2cc2-c5x9v
spawning "nsenter-c9nmgj" on "fctest1-control-plane-c6bd2cc2-c5x9v"
If you don't see a command prompt, try pressing enter.

fctest1-control-plane-c6bd2cc2-c5x9v / # systemctl list-units --failed
  UNIT                LOAD   ACTIVE SUB    DESCRIPTION
● audit-rules.service loaded failed failed Load Security Auditing Rules

it reports an error on line 5 ( can't show th elogs since they expired by now )

All rules seems to have loaded though
fctest1-control-plane-c6bd2cc2-c5x9v / # cat /etc/audit/audit.rules
## This file is automatically generated from /etc/audit/rules.d
-D

-a exclude,never -F msgtype>=1400 -F msgtype<=1499
-a exit,always -F arch=b64 -S execve -k auditing
-a exit,always -F arch=b32 -S execve -k auditing
-w /var/lib/containerd/ -p rwxa -k containerd
-w /etc/containerd/ -p rwxa -k containerd
-w /etc/systemd/system/containerd.service -p rwxa -k containerd
-w /etc/systemd/system/containerd.service.d/ -p rwxa -k containerd
-w /run/containerd/ -p rwxa -k containerd
-w /opt/bin/containerd-shim -p rwxa -k containerd
-w /opt/bin/containerd-shim-runc-v1 -p rwxa -k containerd
-w /opt/bin/containerd-shim-runc-v2 -p rwxa -k containerd
-w /opt/bin/runc -p rwxa -k containerd
-w /opt/bin/containerd -p rwxa -k containerd

fctest1-control-plane-c6bd2cc2-c5x9v / # auditctl -l
-a always,exit -F arch=b64 -S execve -F key=auditing
-a always,exit -F arch=b32 -S execve -F key=auditing
-w /var/lib/containerd -p rwxa -k containerd
-w /etc/containerd -p rwxa -k containerd
-w /etc/systemd/system/containerd.service -p rwxa -k containerd
-w /etc/systemd/system/containerd.service.d -p rwxa -k containerd
-w /run/containerd -p rwxa -k containerd
-w /opt/bin/containerd-shim -p rwxa -k containerd
-w /opt/bin/containerd-shim-runc-v1 -p rwxa -k containerd
-w /opt/bin/containerd-shim-runc-v2 -p rwxa -k containerd
-w /opt/bin/runc -p rwxa -k containerd
-w /opt/bin/containerd -p rwxa -k containerd
-a never,exclude -F msgtype>=AVC -F msgtype<=1499

Also it doe snot happen 100% of the time on all nodes
TODO

[ ] Understand the issue
[ ] Investigate if other CAPI Providers also have the same issue
[ ] fix it

For Turtles

no errors on node creation

In CAPA, this is fixed with adding Restart=on-failure to audit-rules.service
- name: audit-rules.service
  enabled: true
  dropins:
  - name: 10-wait-for-containerd.conf
    contents: |
      [Service]
      ExecStartPre=/bin/bash -c "while [ ! -f /etc/audit/rules.d/containerd.rules ]; do echo 'Waiting for /etc/audit/rules.d/containerd.rules to be written' && sleep 1; done"
      Restart=on-failure <-- Added this


Make it possible to bind a route to query/body conditions

https://github.com/laasti/directions/commit/a41dc4a7b94acbf4f8e30d24ff656ef123edebeb


hasattr(tensor, "to") creates an error when using torch.compile

System Info
None

Information

[ ] The official example scripts
[ ] My own modified scripts

Tasks

[ ] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[ ] My own task or dataset (give details below)

Reproduction
Issue when compiling a model that has been dispatch to multiple gpus.
Error encountered:
  File "/home/marc/.venv/lib/python3.8/site-packages/torch/_dynamo/variables/builtin.py", line 1460, in call_hasattr
    return obj.call_hasattr(tx, name)
  File "/home/marc/.venv/lib/python3.8/site-packages/torch/_dynamo/variables/base.py", line 296, in call_hasattr
    unimplemented(f"hasattr {self.__class__.__name__} {name}")
  File "/home/marc/.venv/lib/python3.8/site-packages/torch/_dynamo/exc.py", line 221, in unimplemented
    raise Unsupported(msg)
torch._dynamo.exc.Unsupported: hasattr ConstDictVariable to

from user code:
   File "/home/marc/.venv/lib/python3.8/site-packages/torch/_dynamo/external_utils.py", line 38, in inner
    return fn(*args, **kwargs)
  File "/home/marc/accelerate/src/accelerate/hooks.py", line 165, in new_forward
    args, kwargs = module._hf_hook.pre_forward(module, *args, **kwargs)
  File "/home/marc/accelerate/src/accelerate/hooks.py", line 364, in pre_forward
    return send_to_device(args, self.execution_device), send_to_device(
  File "/home/marc/accelerate/src/accelerate/utils/operations.py", line 148, in send_to_device
    if is_torch_tensor(tensor) or hasattr(tensor, "to"):

This was something we added to enable accelerate to work with tensordict. cc @vmoens
Is there a way to make it work without having to use hasattr. One solution could be to make tensordict library an optional dependency and check if we indeed have a tensordict ? related issue : https://github.com/huggingface/accelerate/issues/2405
cc @muellerzr
To reproduce:
import os
import torch
from transformers import AutoModelForCausalLM, AutoTokenizer
os.environ["TOKENIZERS_PARALLELISM"] = "false" # silence warnings when compiling

device = "cuda"
ckpt = "meta-llama/Meta-Llama-3.1-8B-Instruct"

model = AutoModelForCausalLM.from_pretrained(ckpt, torch_dtype=torch.float16, device_map="auto")
# model.to(device)

tokenizer = AutoTokenizer.from_pretrained(ckpt)

prompt = "Why dogs are so cute?"
inputs = tokenizer(prompt, return_tensors="pt").to(device)

# Specify the max length (including both the prompt and the response)
# When calling `generate` with `cache_implementation="static" later, this is also used to create a `StaticCache` object
# with sequence length = `max_length`. The longer the more you will re-use it
model.generation_config.max_length = 128

# without `torch.compile`: each call takes ~ 5.0 seconds (on A100 80G + torch 2.3)
outputs = model.generate(**inputs, do_sample=False)
response = tokenizer.batch_decode(outputs)[0]
print(response)

# `torch.compile(model, ...)` is not recommended as you compile callbacks
# and full generate. We recommend compiling only the forward for now.
# "reduce-overhead" will use cudagraphs.
model.forward = torch.compile(model.forward, mode="reduce-overhead", fullgraph=True)
model.generation_config.cache_implementation = "static"

# with `torch.compile` (on A100 80G + torch 2.3)
# 1st call: ~ 90 seconds
outputs = model.generate(**inputs, do_sample=False)
response = tokenizer.batch_decode(outputs)[0]
# 2nd call: ~ 60 seconds
outputs = model.generate(**inputs, do_sample=False)
response = tokenizer.batch_decode(outputs)[0]
# 3nd call: ~ 1.5 seconds
outputs = model.generate(**inputs, do_sample=False)
response = tokenizer.batch_decode(outputs)[0]
print(response)

Expected behavior
compile as expected

I think the purpose here was to allow any class that has a to method, tensordict being just one example of that.
For some reason, this works on pytorch nightlies on my machine:
@torch.compile(fullgraph=True)
def func(x):
    if hasattr(x, "to"):
        return x.to("cpu")
    return x
func(torch.randn(3))

cc @anijain2305: dynamo doesn't support hasattr

In your case, you are testing with a tensor, not sure if this will work with another data type (On my example, it was failing with ConstDictVariable). Thanks for ping !

I think the purpose here was to allow any class that has a to method, tensordict being just one example of that.
Yes, i understand. if there is no good solution, i was just thinking on making sure that at least it works with tensordict !

Oh yeah insteresting, this fails:
import torch
from tensordict import TensorDict

@torch.compile(fullgraph=True)
def func(x):
    if hasattr(x, "to"):
        return x.to("cpu")
    return x
func(dict(a=torch.randn(3)))

but this runs
func(TensorDict(a=torch.randn(3)))

so it seems that dynamo only likes hasarttr if it's True lol.
Say this is patched in 2.5 for instance, would that solve the issue?

Say this is patched in 2.5 for instance, would that solve the issue?

Yeah ! This is the only issue I have right now in order to make big model inference (multi-gpu) + torch.compile works together. I tried to remove that and it was working fine. The goal for us would be to enable this starting from torch 2.5 since with torch 2.4, there were other errors that I didn't manage to debug. LMK if this is something that will be fixed on torch 2.5 !


Scrolling doesn't work in the construction menu

One of the recent PR's for the scrollbar fixed this. It isn't spazzy anymore.


error

cannot convert 'std::string' {aka 'std::__cxx11::basic_string'} to 'String'
how to solve it

I also have the same error. I have used ChatGPT to resolve errors and then upload them. It's working except for jamming and BLEspam.


Remove circular dependency from  by merging selection-controller into base.

Remove circular dependency from  by merging selection-controller into base.

Out of curiosity, is this being done for best practice? Or is it due to it causing an error with something?

Out of curiosity, is this being done for best practice? Or is it due to it causing an error with something?

It's due to some internal Google infrastructure that prefers not to deal with circular dependencies. Normally this style would be completely fine for TypeScript and ES modules.

@rictic review request (I can't actually add you since you aren't a collaborator, but I sent an invite).

As I recall, the internal infra (that I think is open sourced as the bazel TypeScript rules) does work fine with circular dependencies within an individual ts_library, it just can't have them between ts_libraries


Add MSRV note to README

Ref. https://github.com/rust-embedded/wg/issues/445

r? @therealprof
(rust_highfive has picked a reviewer for you, use r? to override)

We've hit #204  and all nightly builds are now failing due to llvm_asm!. We should mark nightly builds as allowed to fail.

I've updated the PR to also allow failures on nightly builds.

bors retry

@korken89 I've rebased the PR, could you re-review please?

bors r+

bors retry

bors retry

bors retry


Provide CRD yaml examples

I'm opening this here because https://github.com/rancher/types doesn't allow creating issues.
It would be nice to have a place where we can take a look at some examples for rancher's CRDs.

Rancher's CRDs are not a "public" interface and we do not support manipulating or creating them yourself or make any guarantee that their structure will stay the same or be compatible between versions.  Use the actual API, which you can explore by going to https://your-rancher/v3.

The reason I'm asking is because I'm trying to evaluate the multicluster apps and neither the rancher cil or the ui is allowing me to do it. I've opened issues about it.  I'd prefer to keep yaml manifests in a git repo.

#18017 and #18020 are the issues I was referring to in my previous comment. I'll take a look at the api and see if that's enough for my needs.

BTW, what is the recommended approach for managing cluster configuration?

API/Terraform/CLI are all options for this.
Let me know if there are any other questions.


Use MyST markdown for learn page

Result should be visually identical to the RST version. The nesting depth is visible in the outmost scope for MyST due to the matching of colon-fences, while in RST the nesting is due to semantic indentation only affecting the inner scopes.
Related

#10

Thanks sir, I will be patching this.

Feel free to start from this branch.

Thanks sir.

Thanks @awvwgk ! This seems about the same readable in both rst and md to me.

PR #24 resolves this. thus, I request this issue to be closed.
Thanks and Regards,
Henil Shalin Panchal
CC @awvwgk


CanvasRenderingContext2D.getImageData: suspicious pixel data

Creep JS detects some trash from the fingerprint: CanvasRenderingContext2D.getImageData: suspicious pixel data
I see in the fingerprint some data in canvas, but not sure what it means:
"canvas":"6f7184a9f7b9e522f1bb67d200be83b58313e9c61b8dabdb4f9c258599d1586926ba948a2c037522aa375fabf2374ac0cfe8f4997d4f0ca09c31839b634b160b7b8183837b7f7c7c7c7d8283828280817c7b7c7c827b80817f7c7c817d7b837b7e7e7b7c7f7d808080837b7f817d817c818282"

Already been discussed, use PerfectCanvas
https://github.com/CheshireCaat/puppeteer-with-fingerprints/issues/31

Thank you, its because it is adding noise by default.

Disabling adding noise will help, but will expose part of your real fingerprint.
I doubt that this is your intention.
You need to use PerfectCanvas.

To use paid ones I need to save all canvases with CanvasInspector and then put it inside perfectCanvasRequest param along with a key, correct?

Disabling adding noise will help, but will expose part of your real fingerprint.

But how to do it?


[bug] & removed if element has duplicated attributes

Please describe the bug
If an element has a duplicate attribute, for example because of issue #2265, all occurrencence of & in all its children will be removed.
For instance, this document

A & B

is turned into

A  B

Help us reproduce what you're seeing
Replication script:
#!/usr/bin/env ruby

require "nokogiri"

h1 = "\nA & B"
doc1 = Nokogiri::XML::Document.parse(h1)
p h1
p doc1.to_xml

raise "& missing" unless doc1.text.include? "&"

# NOTE: Attribute `foo` appears twice.
h2 = "\nA & B"
doc2 = Nokogiri::XML::Document.parse(h2)
p h2
p doc2.to_xml

raise "& missing" unless doc2.text.include? "&"

This is the output of the script:
"\nA & B"
"<?xml version=\"1.0\"?>\n\nA & B\n"
"\nA & B"
"<?xml version=\"1.0\"?>\n\nA  B\n"
RuntimeError: & missing
  ./test.rb:19:in `<top (required)>'

Expected behavior / Actual behavior
As long as a file is parseable, the & entity should be preserved.
Environment
$ nokogiri -v
# Nokogiri (1.11.7)
    ---
    warnings: []
    nokogiri:
      version: 1.11.7
      cppflags:
      - "-I/[RBENV]/versions/2.6.2/lib/ruby/gems/2.6.0/gems/nokogiri-1.11.7-x86_64-linux/ext/nokogiri"
      - "-I/[RBENV]/versions/2.6.2/lib/ruby/gems/2.6.0/gems/nokogiri-1.11.7-x86_64-linux/ext/nokogiri/include"
      - "-I/[RBENV]/versions/2.6.2/lib/ruby/gems/2.6.0/gems/nokogiri-1.11.7-x86_64-linux/ext/nokogiri/include/libxml2"
      ldflags: []
    ruby:
      version: 2.6.2
      platform: x86_64-linux
      gem_platform: x86_64-linux
      description: ruby 2.6.2p47 (2019-03-13 revision 67232) [x86_64-linux]
      engine: ruby
    libxml:
      source: packaged
      precompiled: true
      patches:
      - 0001-Remove-script-macro-support.patch
      - 0002-Update-entities-to-remove-handling-of-ssi.patch
      - 0003-libxml2.la-is-in-top_builddir.patch
      - 0004-use-glibc-strlen.patch
      - 0005-avoid-isnan-isinf.patch
      - 0006-update-automake-files-for-arm64.patch
      - 0007-Fix-XPath-recursion-limit.patch
      libxml2_path: "/[RBENV]/versions/2.6.2/lib/ruby/gems/2.6.0/gems/nokogiri-1.11.7-x86_64-linux/ext/nokogiri"
      memory_management: ruby
      iconv_enabled: true
      compiled: 2.9.12
      loaded: 2.9.12
    libxslt:
      source: packaged
      precompiled: true
      patches:
      - 0001-update-automake-files-for-arm64.patch
      - 0002-Fix-xml2-config-check-in-configure-script.patch
      compiled: 1.1.34
      loaded: 1.1.34
    other_libraries:
      zlib: 1.2.11

Hi, thanks once again for your well-written and clear report.
In this case, it's illustrative to also emit the document's errors. Updating the script to contain these lines:
--- bar.rb	2021-06-14 07:30:52.774562815 -0400
+++ baz.rb	2021-06-14 07:30:49.809562715 -0400
@@ -9,6 +9,7 @@
 doc1 = Nokogiri::XML::Document.parse(h1)
 p h1
 p doc1.to_xml
+p doc1.errors

 raise "& missing" unless doc1.text.include? "&"

@@ -17,5 +18,6 @@
 doc2 = Nokogiri::XML::Document.parse(h2)
 p h2
 p doc2.to_xml
+p doc2.errors

 raise "& missing" unless doc2.text.include? "&"

you'll see [] for the first document (i.e., no errors), but this for the second document:
[#<Nokogiri::XML::SyntaxError: 1:22: FATAL: Attribute foo redefined>]

We can see that the libxml2 does not consider the second document to be well-formed, but will try to recover because the default parse options used for XML include RECOVER. libxml2's recovery logic is different (and simpler) than the happy path logic, and as a result this element doesn't capture all of the original content.
Stated more simply: the error early in parsing this element leads to "recovery" logic failing to properly parse entities later in parsing.
If you'd like to submit a report upstream to libxml2, I'd be happy to provide some guidance. Please let me know!

Hi, thanks for the super quick triage. :)
I reported this issue upstream: https://gitlab.gnome.org/GNOME/libxml2/-/issues/270


first take on peering in CI

Which issue this PR addresses:
https://msazure.visualstudio.com/AzureRedHatOpenShift/_workitems/edit/7553173/
What this PR does / why we need it:
private visibility + peering means we don't have to fix up NSGs to get CI working
Test plan for issue:
hopefully e2e just works(tm)

/azp run e2e

Feel free to merge once you ready :)


Feat/proto files as package

Thanks for this proposal, which addresses an important problem -- how do we maintain a single source of truth for our proto definitions, including handling versioning.
I wonder how others do it, especially when also using different programming languages.
For .NET, it seems to be possible to also reference proto files at a given URL: https://learn.microsoft.com/en-us/aspnet/core/grpc/dotnet-grpc?view=aspnetcore-7.0#add-url
Maybe we could also think about a gh-pages deployment job that publishes new versions e.g. at https://eulynx-live.github.io/subsystems/proto/v1.0.0-build.23/point.proto ? What do you think?

NB: URLs like https://raw.githubusercontent.com/eulynx-live/subsystems//proto/point.proto come for free...


Deleting Tag not updating Note

Contact Details
No response
What happened?
When I click on the 'x' to delete a tag value the tag is not removed from the note. Is there something I am missing or not doing to allow values to be deleted?
What platform were you using?
Desktop
Version of the plugin
3.1.2
Relevant log output
No response
Are you using the latest version of the plugin in your Obsidian vault?

[X] I have verified that I am on the latest version

Are you check if there is a similar issue?

[X] I have verified that there are not similar issues

You have to close the menu previously (esc) to enable the remove buttons. We are searching a better way to manage the blur event


liquidwar: fix build

Motivation for this change
ZHF #45960

add missing dependencies readline and libtool that used to be propagated by guile but aren't anymore
build with guile 2.0 instead of 1.8

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: liquidwar
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Failure on aarch64-linux (full log)
Attempted: liquidwar
Partial log (click to expand)
[ 55%] Built target stdutil
[ 56%] Linking CXX shared module ../libvirtual.so
[ 56%] Built target virtual
[ 57%] Linking CXX shared module ../libwidgets.so
[ 57%] Built target widgets
make[1]: *** [CMakeFiles/Makefile2:100: CMakeFiles/csound64.dir/all] Error 2
make: *** [Makefile:163: all] Error 2
builder for '/nix/store/kmmb754plqwknvjz1djclfnxklyz3jya-csound-6.11.0.drv' failed with exit code 2
cannot build derivation '/nix/store/cr2z0hp65f029d8dfw5fn0vf2cfn8kn8-liquidwar6-0.6.3902.drv': 1 dependencies couldn't be built
error: build of '/nix/store/cr2z0hp65f029d8dfw5fn0vf2cfn8kn8-liquidwar6-0.6.3902.drv' failed

aarch64 failure is in a dependency, it did build on aarch64 before: https://hydra.nixos.org/job/nixpkgs/trunk/liquidwar.aarch64-linux/all

Success on x86_64-linux (full log)
Attempted: liquidwar
Partial log (click to expand)
shrinking /nix/store/cnnqly7sjd854c9nx2nss2k3nv5gkx30-liquidwar6-0.6.3902/libexec/liquidwar6scm-test
shrinking /nix/store/cnnqly7sjd854c9nx2nss2k3nv5gkx30-liquidwar6-0.6.3902/libexec/liquidwar6hlp-test
shrinking /nix/store/cnnqly7sjd854c9nx2nss2k3nv5gkx30-liquidwar6-0.6.3902/libexec/liquidwar6dsp-test
shrinking /nix/store/cnnqly7sjd854c9nx2nss2k3nv5gkx30-liquidwar6-0.6.3902/libexec/liquidwar6vox-test
shrinking /nix/store/cnnqly7sjd854c9nx2nss2k3nv5gkx30-liquidwar6-0.6.3902/bin/liquidwar6-0.6
gzipping man pages under /nix/store/cnnqly7sjd854c9nx2nss2k3nv5gkx30-liquidwar6-0.6.3902/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cnnqly7sjd854c9nx2nss2k3nv5gkx30-liquidwar6-0.6.3902/lib  /nix/store/cnnqly7sjd854c9nx2nss2k3nv5gkx30-liquidwar6-0.6.3902/libexec  /nix/store/cnnqly7sjd854c9nx2nss2k3nv5gkx30-liquidwar6-0.6.3902/bin
patching script interpreter paths in /nix/store/cnnqly7sjd854c9nx2nss2k3nv5gkx30-liquidwar6-0.6.3902
checking for references to /build in /nix/store/cnnqly7sjd854c9nx2nss2k3nv5gkx30-liquidwar6-0.6.3902...


Web - Incorrect "New workspace" and "New room" option in FAB popover after deleting all workspaces

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login with any account
Create some new workspaces (if necessary)
Switch to offline mode
Delete all workspaces
Click FAB
Verify that "New workspace" option is missing
Verify that "New room" option is still there

Expected Result:
"New workspace" should appear and "New room" should not appear when there's no workspace in offline mode.
Actual Result:
"New workspace" does not appear but "New room" appears when there's no workspace in offline mode.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.39-11
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/b8972ddd-e65b-4121-bc09-b563bdcc55b9
https://github.com/Expensify/App/assets/93399543/9970a8ff-1066-47f2-9265-9879e081d331
Expensify/Expensify Issue URL:
Issue reported by: @tienifr
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689315239330819
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
All workspaces are deleted in offline mode but there's still the "New room" option in the FloatingButton (there shouldn't be because there's no workspace to select); and there's not "New workspace" anymore.
What is the root cause of that problem?

In here, we're not filtering out deleted workspaces before displaying the options
In here, we're using the .pendingAction of the policy to check if it's active or not, however in here, we're not including pendingAction in the fields to provide to the component, so it's always undefined when the hasActiveFreePolicy check is run, leading to deleted workspace being counted as 'active'
In here, we're not filtering out deleted workspaces before using its length here to decide if we want to show the New room option.

What changes do you think we should make in order to solve the problem?

We should create a getActivePolicies util in PolicyUtils to filter out the active policies, which will exclude the pending delete policies

function getActivePolicies(policies) {
    return _.filter(policies, (policy) => policy && policy.type === CONST.POLICY.TYPE.FREE && policy.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);
}

Then use the util here to filter
2. We should include pendingAction field here
pendingAction: policy.pendingAction,

We should use the  getActivePolicies util to filter here as well

What alternative solutions did you explore? (Optional)
NA

Repro:
https://github.com/Expensify/App/assets/59587260/67e7ec55-500f-451f-a34f-cdb268576375

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01ba7d28619662c2f1

To fix this issue :
I'll use state variables to track workspace existence and offline mode.
Use conditional rendering to show/hide components based on states.
Display "New workspace" when offline and no workspaces exist.
Ensure "New room" is hidden in the same condition.

Closing this one in favour of https://github.com/Expensify/App/issues/22745. Thanks @tienifr!


[Release-1.8] Convert Stackdriver and Stats telemetry tests to use  Multicluster (#…

…27915)

Convert telemetry tests to use  Multicluster

Fix
Fix
Make prometheus multicluster aware
Make stackdriver nodePort, so can be queried from other clusters too and fix prom failures
fix dashboard test
fix dashboard test
fix dashboard test
change prom api's specific to cluster
Fix Build
fix
fix stackdriver test
Remove debug statement
fix test

fix build

fix build and change stats tcp metric to use echo

increase timeout for tcp stackdriver test

fix build

fix build

fix build

fix logging

change prom API

fix govet error

fix comments

fix build

fix st test

fix based on comments

fix build

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@gargnupur: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio_release-1.8
6dcf0c7a3d3fbb7ea0e767a2e6d18eaec0463509
link
/test release-notes_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio_release-1.8
6dcf0c7a3d3fbb7ea0e767a2e6d18eaec0463509
link
/test release-notes_istio_release-1.8

analyze-tests_istio_release-1.8
6dcf0c7a3d3fbb7ea0e767a2e6d18eaec0463509
link
/test analyze-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio_release-1.8
6dcf0c7a3d3fbb7ea0e767a2e6d18eaec0463509
link
/test release-notes_istio_release-1.8

analyze-tests_istio_release-1.8
6dcf0c7a3d3fbb7ea0e767a2e6d18eaec0463509
link
/test analyze-tests_istio_release-1.8

integ-distroless-k8s-tests_istio_release-1.8
6dcf0c7a3d3fbb7ea0e767a2e6d18eaec0463509
link
/test integ-distroless-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio_release-1.8
6dcf0c7a3d3fbb7ea0e767a2e6d18eaec0463509
link
/test release-notes_istio_release-1.8

analyze-tests_istio_release-1.8
6dcf0c7a3d3fbb7ea0e767a2e6d18eaec0463509
link
/test analyze-tests_istio_release-1.8

integ-distroless-k8s-tests_istio_release-1.8
6dcf0c7a3d3fbb7ea0e767a2e6d18eaec0463509
link
/test integ-distroless-k8s-tests_istio_release-1.8

integ-telemetry-k8s-tests_istio_release-1.8
6dcf0c7a3d3fbb7ea0e767a2e6d18eaec0463509
link
/test integ-telemetry-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@gargnupur: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio_release-1.8
6dcf0c7a3d3fbb7ea0e767a2e6d18eaec0463509
link
/test integ-distroless-k8s-tests_istio_release-1.8

integ-telemetry-k8s-tests_istio_release-1.8
6dcf0c7a3d3fbb7ea0e767a2e6d18eaec0463509
link
/test integ-telemetry-k8s-tests_istio_release-1.8

analyze-tests_istio_release-1.8
6dcf0c7a3d3fbb7ea0e767a2e6d18eaec0463509
link
/test analyze-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio_release-1.8
6dcf0c7a3d3fbb7ea0e767a2e6d18eaec0463509
link
/test analyze-tests_istio_release-1.8

integ-telemetry-k8s-tests_istio_release-1.8
6dcf0c7a3d3fbb7ea0e767a2e6d18eaec0463509
link
/test integ-telemetry-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio_release-1.8
6dcf0c7a3d3fbb7ea0e767a2e6d18eaec0463509
link
/test integ-telemetry-k8s-tests_istio_release-1.8

analyze-tests_istio_release-1.8
d8445769cafbc29186df1c0b5da98a1ff15faa2d
link
/test analyze-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio_release-1.8
d8445769cafbc29186df1c0b5da98a1ff15faa2d
link
/test analyze-tests_istio_release-1.8

integ-telemetry-k8s-tests_istio_release-1.8
d8445769cafbc29186df1c0b5da98a1ff15faa2d
link
/test integ-telemetry-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio_release-1.8
d8445769cafbc29186df1c0b5da98a1ff15faa2d
link
/test analyze-tests_istio_release-1.8

integ-telemetry-k8s-tests_istio_release-1.8
d8445769cafbc29186df1c0b5da98a1ff15faa2d
link
/test integ-telemetry-k8s-tests_istio_release-1.8

integ-distroless-k8s-tests_istio_release-1.8
d8445769cafbc29186df1c0b5da98a1ff15faa2d
link
/test integ-distroless-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@gargnupur: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio_release-1.8
d8445769cafbc29186df1c0b5da98a1ff15faa2d
link
/test integ-telemetry-k8s-tests_istio_release-1.8

integ-distroless-k8s-tests_istio_release-1.8
d8445769cafbc29186df1c0b5da98a1ff15faa2d
link
/test integ-distroless-k8s-tests_istio_release-1.8

analyze-tests_istio_release-1.8
d8445769cafbc29186df1c0b5da98a1ff15faa2d
link
/test analyze-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio_release-1.8
d8445769cafbc29186df1c0b5da98a1ff15faa2d
link
/test integ-distroless-k8s-tests_istio_release-1.8

analyze-tests_istio_release-1.8
d8445769cafbc29186df1c0b5da98a1ff15faa2d
link
/test analyze-tests_istio_release-1.8

integ-telemetry-k8s-tests_istio_release-1.8
d8445769cafbc29186df1c0b5da98a1ff15faa2d
link
/test integ-telemetry-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio_release-1.8
d8445769cafbc29186df1c0b5da98a1ff15faa2d
link
/test analyze-tests_istio_release-1.8

integ-telemetry-k8s-tests_istio_release-1.8
d8445769cafbc29186df1c0b5da98a1ff15faa2d
link
/test integ-telemetry-k8s-tests_istio_release-1.8

integ-distroless-k8s-tests_istio_release-1.8
d8445769cafbc29186df1c0b5da98a1ff15faa2d
link
/test integ-distroless-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

It will be useful to watch: https://prow.istio.io/?job=integ-telemetry-mc-k8s-tests_istio_release-1.8_postsubmit

@gargnupur: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio_release-1.8
4180f4c9e6b6bd182661472d093b467f0dd5cfb4
link
/test integ-telemetry-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-k8s-tests_istio_release-1.8

@gargnupur: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio_release-1.8
4180f4c9e6b6bd182661472d093b467f0dd5cfb4
link
/test integ-telemetry-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


FR: option to remove underline from to doc links

Links to docs are great but, for me at least, underlines catch my eyes too much and make code difficult to read. It looks too much like an exception.
Could you please add an option so links to docs not underlined?
Cheers,
Laurent

TIL you can configure to only underline in imports:

Then you can click import Time but Time.millisToPosix won’t be clickable.
Ideally I might still want Time.millisToPosix to be clickable (but not highlighted) (or even be able to see the source code for millisToPosix, which is sometimes useful for power users).

Oh that’s just great. Thanks @lydell :+1:


bbb-recorder (ffmpeg) runs out of memory when streaming live to RTMP

This is not directly related to bbb-recorder but hoping you could assist us.
We have been testing with bbb-recorder to rtmp live stream BBB sessions to YouTube Live. Thank you for your work, the project is well put together.
Our issue:
ffmpeg runs out of memory after some time depending on the size of the host (VMs). We are using Linode as our provider.
Looks like with:

2 VCPU / 4 GB it fails after less than 5 minutes
4 VCPU / 8 GB it fails after about 38 minutes

[ 4521.946279] oom-kill:constraint=CONSTRAINT_NONE,nodemask=(null),cpuset=6fe9a17c458df671ac76e9d83081eab78508fd7c9063ad98c9c4fd4085c653fb,mems_allowed=0,global_oom,task_memcg=/docker/6fe9a17c458df671ac76e9d83081eab78508fd7c9063ad98c9c4fd4085c653fb,task=ffmpeg,pid=3529,uid=0
[ 4521.946350] Out of memory: Killed process 3529 (ffmpeg) total-vm:8860260kB, anon-rss:7688164kB, file-rss:0kB, shmem-rss:12812kB, UID:0 pgtables:16288kB oom_score_adj:0
[ 4522.378152] oom_reaper: reaped process 3529 (ffmpeg), now anon-rss:16kB, file-rss:0kB, shmem-rss:12832kB
[ 4523.638944] br-42362ca21fc0: port 1(vetha0a8f11) entered disabled state
[ 4523.639298] veth4950752: renamed from eth0
[ 4523.714325] br-42362ca21fc0: port 1(vetha0a8f11) entered disabled state
[ 4523.718378] device vetha0a8f11 left promiscuous mode
[ 4523.718387] br-42362ca21fc0: port 1(vetha0a8f11) entered disabled state

Seems it might be related to the audio capture. We are using your pulseaudio daemon settings and all ffmpeg settings.
What we are hoping for:

We would like to be able to stream live (RTMP to YouTube Live) one session for up to 5 hours.

Our questions

Is that an issue you have ran into perhaps?
 For my project I am running similar & can easily run 2 sessions at a same time for more than 2 hours. I don't think you're getting full CPU power.

2 VCPU / 4 GB it fails after less than 5 minutes

Are you sure that you are getting dedicated CPU? For my project I am running similar & can easily run 2 sessions at a same time for more than 2 hours. I don't think you're getting full CPU power.

Thank you for your reply and you are correct. I was attempting to run on shared vcpu VMs.
Gave up and spun up a dedicated CPU for a few tests and things are much better there. There are still some occasional frame sync issues between xvfb and ffmpeg but that is almost normal I suppose.
Streamed for 6 hours+ a few times now.
Thank you very much for your project and your answer.