Code Quality: Refactor code and make it more modern

Hello (again again)!
In this PR I've done the following:

[x] Run Code Cleanup on the project - remove unnecessary using directives, format documents, etc.

[ ] Run special advanced code cleanup
[ ] Sort out .editorconfig

[x] Update namespaces of files to be consistent
[x] Change folder structure to match a modern project
[x] Fix NuGet package sources

...and various other changes that I will add here soon

[x]  Fix NuGet package sources

Can you explain what the purpose of this change is?

Can you explain what the purpose of this change is?

There was a duplicate entry for the NuGet Gallery server, and the name for MyGet was wrong.

Can you explain what the purpose of this change is?

There was a duplicate entry for the NuGet Gallery server, and the name for MyGet was wrong.

I guess I'm wondering why MyGet was kept in lieu of NuGet

I guess I'm wondering why MyGet was kept in lieu of NuGet

The NuGet Gallery server is automatically enabled as a global package source in Visual Studio. Having it inside the nuget.config file would cause it to be duplicated.

Essentially I think it would be best for IronPython to follow a similar structure as the .NET Runtime and Files:

Top-level folder
2nd-level folder
Comment

src
DLR IronPython.Analyzer IronPython.Modules etc.
Should also contain a README.md file

docs

This wouldn't exist because of #1812

tests

The Tests directory

build
Packaging
where [Pp]ackaging is the current top-level Package directory

utils

The Util directory

This is why I hate submodules..
about the 5th time I've had to reclone 🫤

/azp run

Probably going to have to break up the PR into smaller chunks. Pretty much impossible to review the changes as it is. I would suggest doing the code cleanup independently as it's more likely to be accepted than a major restructuring.
For the restructuring changes it's going to be harder to convince me as it just makes it more work to follow a file's history. Assuming that was not an issue for me, some of the proposed changes seem reasonable while others I do not understand. For example Src to src, DLR to runtime seem fine. StdLib to extensions/StdLib I do not understand.
Anyway if you want to keep this PR around to demonstrate and discuss the repo structure that's fine with me.

For example Src to src, DLR to runtime seem fine.

Any change to the location of the Git submodule will be a major headache for anybody having some workareas already checked out (like myself). I guess this is what @Lamparter refers to by using a hyperbole that "git crashes". The Git process does not crash, but is unable to smoothy switch branches/commits when the path to submodules changes, leaving a mess behind. It is possible to handle that with some extra help from command line, but Git GUI tools I know can't handle it. One way of handling it is to re-clone the complete work area, but not practical if the work area contains some local WIP that can't be lost.
Also renames that are different only in letter case can be problematic for git (which is case-sensitive on Linux, macOS), when working on systems that are case insensitive (Windows, macOS). macOS is particularly tricky here because, being Unix-like, it pretends to be case-sensitive but the actual file system is not (by default).
On the other hand, if such major overhaul is ever to be done, it is a good time to do it, when contributors' engagement is very low. From the aesthetic point of view src/runtime is fine, src/dlr is better (there are so many runtimes around). Also, think of the ease/difficulty of keeping main and 3.6 in sync and the necessary steps this would entail.
I would like to hear of some practical benefits for the restructuring beyond aesthetics that would justify the cost of the change (like interrupted file history, cross-branch merges, etc.)

From who have done this kind and scale of reorganization, git history isn't what the maintainer would concern because you can use GitHub's Commit History page, which provides viewers file history before renamed.
As an example, the structure of Files Community repo had looked very messy and most likely new contributors couldn't participate easily. Also when I was a new contributor of Files Community (now a member of the org tho), I strongly felt the root folder being very simple and having fewer dirs is the most important for me to understand the codebase better.
Before: https://github.com/files-community/Files/tree/884cca3646a7243f2c3429f32ea17350f0429ce7/src/Files.Uwp
Now: https://github.com/files-community/Files/tree/main/src/Files.App
However, given that the maintainers are mostly unable to review and I did such reorganization across a few PRs, you might consider to split up the work.

Thanks, I accidentally removed. But yes. This is more about gaining new contributes by having good codebase structure than about aesthetics.

Oh I guess I forgot to mention. Assuming we can reach a consensus and the PR is accepted I'm willing to deal with the whole merging of 3.6 complication. Although I do share @BCSharp's concerns regarding the change messing up local work areas I'm assuming the number of people that have one set up is limited. From my point of view I would likely make a fresh clone and take is as an "opportunity" to clean up/discard the branches I have locally.
It would be nice to hear from other community members (thanks to those who did chime in already) their thoughts regarding the proposed restructuring (but I guess the silence just shows how little involvement there is right now).

Just a few comments:

extensions: this is named directly after the extensions part of the .NET Runtime - Microsoft.Extensions.* which contain 'extensions' for building modern advanced apps, a bit like a community toolkit but builtin.
roslyn: while the name of the .NET Runtime compiler (MSBuild exists as well!), it is also the name of the analyser platform that comes with it - sometimes called CodeAnalysis but generally referred to as Roslyn (they had to name both the compiler and the analyser framework the same thing)
ipy: interestingly enough, I was already going to rename this to core as that's the same name as used in both Files and in .NET
eng: this is folder name is used across all .NET assembly repos and is short for Build Engine - the .NET DevOps organisation is at dev.azure.com/dnceng-public for example.
scripts: I had the same worry as you, though it was just too out of place in src; I thought to put it in .github but for obvious reasons that's completely out of place. I think the tests directory is best if you don't want it in the root.
console: this should be called platforms
utils: I'll get rid of them

Feel free to ask me to do anything you like, and if you need a hand anywhere, let me know! 😄
I've got a lot of things to work on, but I don't want the pain of merge conflicts until this is resolved (and hopefully merged!)

FWIW- I just started following the project recently. I like the direction
of the changes- though I haven't dug too deeply into the specifics. It does
make it easier to find things (and contribute) when the structure matches
other projects, especially MS conventions.
I'm sure there are other "lurkers" here 😅
On Tue, Nov 26, 2024 at 10:48 AM Lamparter @.***> wrote:

Just a few comments:

extensions: this is named directly after the extensions part of the
.NET Runtime - Microsoft.Extensions.* which contain 'extensions' for
building modern advanced apps, a bit like a community toolkit but builtin.
roslyn: while the name of the .NET Runtime compiler (MSBuild exists
as well!), it is also the name of the analyser platform that comes with it
sometimes called CodeAnalysis but generally referred to as Roslyn (they
had to name both the compiler and the analyser framework the same
thing)
ipy: interestingly enough, I was already going to rename this to core
as that's the same name as used in both Files and in .NET
eng: this is folder name is used across all .NET assembly repos and
is short for Build Engine - the .NET DevOps organisation is at
dev.azure.com/dnceng-public for example.
scripts: I had the same worry as you, though it was just too out of
place in src; I thought to put it in .github but for obvious reasons
that's completely out of place. I think the tests directory is best if you
don't want it in the root.
console: this should be called platforms
utils: I'll get rid of them

Feel free to ask me to do anything you like, and if you need a hand
anywhere, let me know! 😄
I've got a lot of things to work on, but I don't want the pain of merge
conflicts until this is resolved (and hopefully merged!)
—
Reply to this email directly, view it on GitHub
https://github.com/IronLanguages/ironpython3/pull/1815#issuecomment-2501216693,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJQCOX2V26GRYX67LTTDP32CSJ57AVCNFSM6AAAAABR6B3A6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBRGIYTMNRZGM
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Why the changes from internal to public? These are hidden on purpose.

Why the changes from internal to public? These are hidden on purpose.

They break ALL of the tests. I have absolutely no idea why these errors are occurring now and never before, but literally all of the tests are broken because of these fields being marked as internal.

Why the changes from internal to public? These are hidden on purpose.

They break ALL of the tests. I have absolutely no idea why these errors are occurring now and never before, but literally all of the tests are broken because of these fields being marked as internal.

Probably because you renamed the IronPythonTests project. :wink:

My perspective:

core: love it! 😍
extensions: although technically they contain modules, they are DLLs, being optional extensions to core (which also contains modules) so the name fits. E.g. ironclad would be an extension too. That said, IMO SdtLib is definitely not an extension and belongs to core.
platforms: i can live with that, though it is somewhat confusing as the documentation uses the term platform for .NET/Mono/.NET Framework etc. and sys.platform in Python is win32, linux, darwin etc.  But currently i have no better ideas. standalone? products? programs?
roslyn: fine; at first i was thinking about diagnostics, but, although a second analyzer is unlikely, there may be some code generators in the future. In that case, diagnostics does not work. OTOH, code generators should go to build? Maybe roslyn/diagnostics should go to build as well? (Pardon, eng. This will take time to get used to. 😉)
utils: get rid of them or move a level deeper (build?)
scripts: root is not the place indeed, and i think the main difficulty of placing this is because the folder became a catch-all bag of scripting files that had no obvious place to go. So, to clean it up, the collection will have to be split up: most of the scripts are code generators and belong in eng, some are related to installation/distribution (eng again but perhaps a different subfolder), some are related to testing so they can go into tests, and a few are really sort of utils or tools... Good luck in sorting...
runtime: i prefer dlr because runtime is vague and ambiguous: we use the CLR, the DLR, and IronPython itself has a Python "runtime" (now in core where it belongs).

Probably because you renamed the IronPythonTests project. 😉

Not to sound stupid, but how would that have made a difference?
There are also now issues being raised with the .NET Framework tests target since the engine references System.Runtime.InteropServices which isn't available in .NET Framework.

Another idea: platforms -> executables?

What about just console?
I wanted to create a more interactive IDLE-style editor that ships with IronPython, and I thought the perfect place to put it would be in platforms since the projects in that folder are the platforms through which you can use IronPython from. Perhaps just console is best and if the editor thing gets approved I'll put it in a different folder.

Probably because you renamed the IronPythonTests project. 😉

Not to sound stupid, but how would that have made a difference? There are also now issues being raised with the .NET Framework tests target since the engine references System.Runtime.InteropServices which isn't available in .NET Framework.

The assembly name is not specified in IronPythonTest.csproj so renaming it changes the assembly name. The assembly name is used in an InternalsVisibleToAttribute to expose the IronPython internals to it so they can be tested. There's an internal implementation of some of the InteropServices APIs in the IronPython assembly so it's the same issue.

What about just console? I wanted to create a more interactive IDLE-style editor that ships with IronPython, and I thought the perfect place to put it would be in platforms since the projects in that folder are the platforms through which you can use IronPython from. Perhaps just console is best and if the editor thing gets approved I'll put it in a different folder.

Personally not a huge fan of console since the IronPythonWindow is basically a console-less version of ipy. What about something like hosts?

scripts: root is not the place indeed, and i think the main difficulty of placing this is because the folder became a catch-all bag of scripting files that had no obvious place to go. So, to clean it up, the collection will have to be split up: most of the scripts are code generators and belong in eng, some are related to installation/distribution (eng again but perhaps a different subfolder), some are related to testing so they can go into tests, and a few are really sort of utils or tools... Good luck in sorting...

I guess we could shove it in eng for now (and now eng becomes a catch-all bag of stuff). :smile:

The assembly name is not specified in IronPythonTest.csproj so renaming it changes the assembly name. The assembly name is used in an InternalsVisibleToAttribute to expose the IronPython internals to it so they can be tested. There's an internal implementation of some of the InteropServices APIs in the IronPython assembly so it's the same issue.

Ah I thought it might be something like that! I didn't know that was possible 😅
I'll go ahead and fix the references and revert the changes.

Personally not a huge fan of console since the IronPythonWindow is basically a console-less version of ipy. What about something like hosts?

Platforms is probably just better at this point.

Personally not a huge fan of console since the IronPythonWindow is basically a console-less version of ipy. What about something like hosts?

Yes, i thought about it too when i realized what @Lamparter means by platforms:

the projects in that folder are the platforms through which you can use IronPython from.

This notion is captured by the term hosts throughout the IronPython/DLR codebase (and perhaps, .NET itself). The only problem with hosts is that ipy, the IronPython compiler, does not fit the bill, and it would be a pity to misplace it in hosts or create a separate directory just for it so that it is not misplaced.
Basically, there are the following projects to sort out:

two console hosts (ipy, ipy32)
two GUI-less launchers (ipyw, ipyw32)
console compiler (ipyc)
(hypothetical) GUI host (IDLE-like)

Options:

console:

captures ipy, ipy32, ipyc
excludes IDLE (gui?)
excludes ipyw, ipyw32 (launchers? daemons?)

hosts (a.k.a platforms to some):

captures ipy, ipyw, ipy32, ipyw32, IDLE
excludes ipyc

executables:

captures all of them, and only them; in fact, these projects are the only ones that can be selected as "startup project" in Visual Studio"

My current preferences are (in order):

executables (the longer i think about it)
hosts (if i squint i can put ipyc there; i'm not a fan of platforms in this role)
other (better be non-descriptive than misleadingly descriptive)

Your definition of executables is what I meant by platforms 😄

SdtLib is definitely not an extension and belongs to core.

I had second thoughts about it. Not to put it back in extensions (it doesn't fit there), but perhaps it would be better to promote it one level up. This is a unique part of IronPython since it is actually a part of CPython codebase, only slightly adapted to work around some compatibility issues between the two implementations. Also, it is not an essential part of IronPython — it is to provide library compatibility with CPython, e.g. that 3rd party packages can be imported and run. It is perfectly possible to run IronPython without StdLib, in that case it is just another (dynamic) programming language for .NET. The .NET library is rich enough by itself, if somebody doesn't care about CPython compatibility. Therefore, it is hard to call StdLib "core".
But I am particularly attached to this idea, placing StdLib in core is good enough. (Let's see how I feel tomorrow. 😄)

some projects set their binary location to exe which is too similar...

I hear you. Yes, luckily, we use bin for that. Well, perhaps some more ideas/second thoughts will come up in the coming days.

SdtLib is definitely not an extension and belongs to core.

I had second thoughts about it. Not to put it back in extensions (it doesn't fit there), but perhaps it would be better to promote it one level up. This is a unique part of IronPython since it is actually a part of CPython codebase, only slightly adapted to work around some compatibility issues between the two implementations. Also, it is not an essential part of IronPython — it is to provide library compatibility with CPython, e.g. that 3rd party packages can be imported and run. It is perfectly possible to run IronPython without StdLib, in that case it is just another (dynamic) programming language for .NET. The .NET library is rich enough by itself, if somebody doesn't care about CPython compatibility. Therefore, it is hard to call StdLib "core".
But I am not particularly attached to this idea, placing StdLib in core is good enough. (Let's see how I feel tomorrow. 😄)

Just more food for thought. I'm not sure if we have any tests covering IronPython running without the standard library, but I think it's layered in such a way that it might work without it (and IronPython.Modules?). Note that CPython has been moving features to Python implementations over the years and doesn't even run without the standard library. Whenever that happens we tend to drop the native implementation and use the Python one so maybe we'll get to a point where it's no longer possible to run stand-alone?

I don't think that's a really good idea...

I don't think that's a really good idea...

Can you elaborate?

I'm not sure if we have any tests covering IronPython running without the standard library,

Not that I know of.

but I think it's layered in such a way that it might work without it (and IronPython.Modules?).

It used to work, at least a few years ago (IDK about w/o IronPython.Modules), which I discovered accidentaly after forgetting to set IRONPYTHONPATH... There are some things that do not work properly (like that not all code paths can find the built-in codecs), but workarounds are known, issues are opened, and hopefully they will be fixed in the future.

Note that CPython has been moving features to Python implementations over the years and doesn't even run without the standard library.

Good point. Who knows how this will impact IronPython in the future. My favourite 😉  I've seen somewhere in the code (importlib boostrapper?) was a C# string containing a piece of Python code, compiled into the DLL and interpreted at runtime on start. Ingenious.

I don't think that's a really good idea...

What's gained in running without the standard library?

What's gained in running without the standard library?

Reduced deployment footprint (relevant in resource constrained cases, like e.g. embedded).
Reduced "attack surface" (removed unused code that may contain exploitable bugs; 3.4 is an old library, EOL upstream).

NB IronPython already supports it since the interpreter engine and the standard library are distributed in separate NuGet packages.

I don't understand why the tests are failing 🫤

Could not find a part of the path 'E:\Repositories\Lamparter\IronPython\Tests\Inputs\raise.py'

This path isn't specified anywhere, and the source code literally directs the tests to tests\python\Inputs and not Tests - I have no idea where it's getting this path from.

This one maybe?
https://github.com/Lamparter/IronPython/blob/refactor/tests/ironpython/Cases/IronPythonCases.cs

A few comments:
Test issue:
         public TestManifest(Type parent) {
-            var file = parent.Assembly.GetManifestResourceStream($"IronPythonTest.Cases.{parent.Name}Manifest.ini");
+            var file = parent.Assembly.GetManifestResourceStream($"IronPython.Tests.Cases.{parent.Name}Manifest.ini");

There's a bunch of files which had their perms altered from 100755 → 100644 (like ipy3.4, dos2unix.sh, etc.). Having proper permissions on these scripts is important.
.gitignore: I definitely do not like the generic catch all of every conceivable generated file types. Please remove the additions.
Not a fan of the tests folder structure. Maybe something like:

_ctypes_test
IronPython.Tests
suite (not sure I really like this one, but better than python)... or cases?

Otherwise it feels like it's almost there. Unfortunately I still can't review with GH because of the 3k file limit. Maybe we could split it up into smaller PRs, for example one with the non-src changes and then src? Guess I need to start looking at merging main into 3.6 before the refactoring...

Got it.

I've been gone from work on this project for a while to focus on other things. Back soon!


Add test for import with same name

:import {
-st-from: "./import.st.css";
-st-default: AutoGrid;
}
.grid{
-st-extends: AutoGrid;
}
.grid|
Should complete ::grid
[Works, no test]

Changed an existing test to have .momo::momo


Add support for SIP SRV record lookup

Add support for looking up SIP SRV records when they exist to correctly route SIP traffic.
_sip._tcp. for SIP
_sips._tcp. for SIP
According to RFC3263

hi @habakke . Thanks for looking into this. SRV lookup already exists and it is by default on. Please open issue to discuss your problem.


recent change has client make bad URLs

<EMAIL_ADDRESS>on 3 Jun 2013 at 5:39:
Change 49979a5f1445 introduces behavior that has the client make request like
this:

POST //www.googleapis.com/upload/drive/v2/files?uploadType=multipart&alt=json
HTTP/1.1
Host: www.googleapis.com
User-Agent: google-api-go-client/0.5
Content-Length: 23301
Authorization: Bearer redacted
Content-Type: multipart/related;
boundary=c18fb9c5303d177b9679b4c9a81b68442af746f6d0655c75fa57d001d1b8

AFAIK, it's not valid to say "VERB //host/path".

<EMAIL_ADDRESS>on 3 Jun 2013 at 6:00:
This issue was updated by revision 5d818df85e09.

««« original CL description
google-api-go-client: update generated code with new param encoding from
https://codereview.appspot.com/9671043/

R=adg, bradfitz
CC=golang-dev
https://codereview.appspot.com/9672043
»»»

R=campoy, bradfitz
CC=golang-dev
https://codereview.appspot.com/9958043

Successfully auto-migrated from code.google.com:
https://code.google.com/p/google-api-go-client/issues/detail?id=34

The breaking change was reverted:
https://code.google.com/p/google-api-go-client/source/detail?r=5d818df85e09
Closing.


Sandbox environment: add limit range creation

Description
This PR enhances the management of the sandbox environment, introducing the creation of a limit range object. It sets default request/limit values, preventing the need for explicit configuration in each deployment.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

[x] Automated tests
[x] Staging environment

/deploy-staging

/deploy-staging

/rebase

/merge


Set up Proactive Alerts based on metrics for HashIO

Problem
Currently we have a Relay / HashIO Dashboard with many useful metrics for monitoring the HashIO environments that are instrumental in finding, detecting and diagnosing bugs and performance issues.
Even when the role of the release manager is to monitor metrics and logs as part of the release process, sometimes bugs slips trough and we need to be able to react fast and that means having the appropriate alerts in place that notifies the person on call and subsequently the rest of the team.
More details:
https://www.notion.so/swirldslabs/Alerts-and-Monitoring-for-HashIO-Design-and-Overview-Document-306851dc065c41a4aa08c8a40516fe7c
Solution
A phased approach to improving our metrics and creating the alerts in place that we need to proactively get notified when something needs the development or devops teams to take a look.
Currently there are already some alerts in place by devops team, that work in place to make sure we are spending the right amount of HBAR a day/week/month.

[ ] Define Alerts
[ ] Configure PagerDuty Rotation Schedule for the Smart-Contracts Team
[ ] Create a KB (Knowledge Base) Notion page
[ ] Add Dashboard to the Relay Repo so they can be tracked
[ ] Logs ingestion integration with Grafana using Loki
[ ] Set-up Dashboards based on Logs

I have created an example that can be used as template for defining other alerts.
https://www.notion.so/swirldslabs/Alerts-63fff53c2e344d60be32b3f5c51e481a


How do I make the input names increase incrementally?

I'm using this, and I need a way to ensure the input names increase like the ID's are.

Cloneya already handlng it, You need to set field name as array <input type="text" name="name[1]"/>. Cloneya will automatically increment the numeric index of array.

Got it! tHX!

Hi gchokeen,
OK, I think this is not working - and I am looking at the actual demo page you have set up, the name field is not automatically incremented
Best,
Gabriela

You also need to set the (undocumented) config option serializeIndex to true to make it work. Note also that currently if you have more than one numeric bit in your fieldname cloneya will reset all of them to the clone index (see #42)

Aaah, ok, I see! Thanks Andrew!


Heisenbug

This is a reproducibility branch for the heisenbug that we've been investigating in the last days.

Run include("validation/dam_break_2d/validation_dam_break_2d.jl"). Ignore the error.
Copy validation_result_dam_break_wcsph_0015.json from the out folder to validation/dam_break_2d. This is the reference that we're comparing against now.
Repeating 1. should now run without errors and yield an error of 0.0. Running that on a single thread or multiple threads should be equivalent because both parallel NHS update and threading in interact! is disabled.
Changing parallel=false to parallel=true in the fluid interact! (weakly compressible rhs.jl, line 24) and running it on multiple threads yields a non-zero error for me.
When I comment out the two lines in semidiscretization.jl containing PtrArray and use the commented out unsafe_wrap lines there instead, I get the same results with and without threading (error zero, so the same as with PtrArray without threading).

Update: @svchb can't reproduce, and I can't reproduce either on an AMD CPU. I conclude that this is an macOS-ARM problem.

@efaulhaber Move this to an issue than we can close this.


Accounts

refactor accounts django app
add django-allauth
add LDAP support

Coverage increased (+0.3%) to 79.315% when pulling 525d215d26c5bfe41997ea22b02e0c8f39dde8a1 on accounts into bfe073671910efdd932b92c2bb40dc24c230733a on master.

Coverage increased (+0.3%) to 79.315% when pulling 525d215d26c5bfe41997ea22b02e0c8f39dde8a1 on accounts into bfe073671910efdd932b92c2bb40dc24c230733a on master.

Coverage increased (+0.3%) to 79.315% when pulling 525d215d26c5bfe41997ea22b02e0c8f39dde8a1 on accounts into bfe073671910efdd932b92c2bb40dc24c230733a on master.

Coverage increased (+0.3%) to 79.315% when pulling 525d215d26c5bfe41997ea22b02e0c8f39dde8a1 on accounts into bfe073671910efdd932b92c2bb40dc24c230733a on master.

Coverage increased (+0.3%) to 79.308% when pulling fcacf338da2b55ce5ea9283fac602044d6fe4bf4 on accounts into bfe073671910efdd932b92c2bb40dc24c230733a on master.

Coverage increased (+0.2%) to 79.168% when pulling a7fe1f1f7cf34747114b9a085885f364845142c3 on accounts into bfe073671910efdd932b92c2bb40dc24c230733a on master.

Coverage increased (+0.2%) to 79.168% when pulling fdc60461880ecd4361c376220bd84203ba3ec050 on accounts into bfe073671910efdd932b92c2bb40dc24c230733a on master.


Convert FirefoxExtension to WebExtension

This makes the extension compatible with the new WebExtensions API of Firefox (issue #45). It is just a copy of the ChromeExtension, with two changes in the manifest.json:

removed "background.persistent" entry
changed "options_page" entry to "options_ui.page"

For me it runs smoothly in debug mode. I'm not sure if anything else is needed.

I've been testing it a bit, I can cast from the menu list using 'send to rpi', but I didn't manage to make it work directly from the player page. I simply clicked the cast page button, but nothing work.
Am I doing smth wrong?

Hi @Tastyep, you were right. The active tab could not be fetched correctly. Should be working now.

That's great. Thanks ;)

Thanks a lot!! This is awesome :)


threading issue

When use following code to call runBenchmark() and set RECORDS in runBenchmark() to 1. The first print takes hundres of microseconds. Is there a way to keep logging thread hot internally?
std::thread t(& { runBenchmark();runBenchmark();runBenchmark(); });
t.join();

From ReadMe: It's recommended that user actively calls fmt::preallocate() once the thread is created, so even the first log can have low latency


Each iteration should have a fresh set of environment variables

Currently, the environment variables set by one iteration will be carried over to the next iteration. Each iteration should have clean environment variables or you will see some strange behavior.

The idea behind environment variables is a run-wide storage for key-value pairs. Clearing it after iterations or folders wouldn't make much sense.
You can use postman.clearEnvironmentVariables() to clear environment variables manually.


feat: ROS Noetic Support

This package is compatible with ROS Noetic, Melodic and Kinetic. Review the changes for further details.

Hi, idk will you respond to this issue or not, I've tried this package, and ur package, but I still get the same error here

Do you have any idea of what happenning here?

Please mention which ROS version you are using. Previously, the master branch, which is the default, had the original work, and the modified work was in the noetic branch. The noetic branch is now renamed as master and is the default. Could you remove the source code from your workspace and download it again? If you still get the "chrono_literals" error, you can change the following line in the CMakeLists.txt file:
set (CMAKE_CXX_FLAGS "-g -Wall -std=c++11")
with this one:
set (CMAKE_CXX_FLAGS "-g -Wall -std=c++14")


Typo: Missing "can"

"assembly references be added" -> "assembly references can be added"

@sylvan - Please review the proposed changes.  Thanks

Thanks again @andresnava. #sign-off for @sylvanc


Subscribe button missing on mobile

In Labs, Subscribe feature adds a subscribe button on desktop, but is missing on mobile.

@JBaczuk could you please provide some more information? I am not able to reproduce this. With subscriber mode switched on, I get the subscribe button in every blog post.

I'm sorry I just realized I was not on the latest version of Ghost.  I will update and verify.

It's definitely there :) http://demo.ghost.io/welcome/
On mobile it appears at the bottom of posts but not in the header navigation where there's limited space


Improve problems message for hdi failure

Background
Currently failure to create the hdi container always logs the same 2 problems in the problems view

Could not create the container "NAME"
SAP DBTech JDBC: [362]: invalid schema name: NAME#DI: line 1 col 6 (at pos 5)

This is not helpful and does not show the actual reason for the failure
Target
Add the actual problem that caused the failure to create HDI container to the problems view

Please, assign to me


Make gondle examples work again

Issue:
The examples no longer work in CodeSandbox environments.
Current Error message: "Invalid Host Header"
Current solution:
The examples are pulled directly from the GitHub repo (CodeSandbox pulls from master branch).
However, Code-Sandbox is constantly being modified, so these examples are currently no longer working.
Wanted
Maybe we'll get this solution working again.
Also ideas are welcome for alternative solutions.

This fix solved most of the issues. Most examples work again, thanks a lot @stefanibus
There remain two other problems:
module not found:

https://codesandbox.io/p/sandbox/github/merkle-open/gondel/tree/master/examples/plugin-data
https://codesandbox.io/p/sandbox/github/merkle-open/gondel/tree/master/examples/react-gondel

tsconfig.json

https://codesandbox.io/p/sandbox/github/merkle-open/gondel/tree/master/examples/typescript
https://codesandbox.io/p/sandbox/github/merkle-open/gondel/tree/master/examples/gondel-react

All examples now work again. Great. Thank you.


disconnect?

In the May Power BI feature summary (snippet below)  it mentions an improvement so that content can be shared to invited users and they’ll get just the one link that lets them accept the invite and access the content.  I can’t get the Power BI dev to share to an invited recipient unless they have the “export/share to external” switch enabled and have been granted this privilege, which if they have this, the external recipient doesn’t even have to be in an invited status in order to be able to share to them.  We need to be able to do ‘planned’ bulk invite (with no email), then let the Power BI dev share content to them (and we don’t want the dev to have the export/share with external privilege) and the recipient would get the one email when the content is shared to them.
Azure B2B invite workflow improvements for reports
We have seen increasing usage of our Azure B2B external user sharing features that help you collaborate securely across organizations. However, the invite acceptance workflow has been complicated because the user needs first to accept the Azure B2B invite, and then click the link to the Power BI content in a separate email.
Moving forward, we have simplified the workflow for reports so that invited external users get a single email to the report in Power BI. When they click the link, they accept the invite and can immediately access the content. It’s a simple way we’re trying to smooth out the wrinkles to make it easier to collaborate across organizations.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 725c3bff-b250-c882-6f2b-1f2cb7f00341
Version Independent ID: f48832e7-8fc5-498a-8522-435a8ce42129
Content: Distribute Power BI content to external guest users with Azure AD B2B - Power BI
Content Source: powerbi-docs/service-admin-azure-ad-b2b.md
Service: powerbi
GitHub Login: @mgblythe
Microsoft Alias: mblythe

Thanks for the feedback, brown1mr. I shared your comments with the PM owner for Power BI sharing and collaboration. Hopefully, a future release will make it even easier to collaborate with external (guest) users.

@brown1mr - closing this based on Kay's response.


[flaky-test] TestSteveDownstream

Note: This issue was repurposed to more recent failures in TestSteveDownstream which may have different root cause. The original description is in the collapsed section at the bottom of the issue.
Flaky Test
TestSteveDownstream
Release Branch
Source branch of PR: release/v2.9 (and release/v2.8 too)
GHA Build (if applicable)

https://github.com/rancher/rancher/actions/runs/10163267773/job/28110442691?pr=46372#step:30:667 (release/v2.9)
https://github.com/rancher/rancher/actions/runs/10182873508/job/28187098274?pr=45222#step:30:441 (release/v2.8)

=== RUN   TestSteveDownstream
    steve_api_test.go:301:
        	Error Trace:	/home/runner/work/rancher/rancher/tests/v2/integration/steveapi/steve_api_test.go:301
        	            				/home/runner/work/rancher/rancher/tests/v2/integration/steveapi/steve_api_test.go:255
        	            				/home/runner/go/pkg/mod/github.com/stretchr/testify@v1.9.0/suite/suite.go:157
        	            				/home/runner/work/rancher/rancher/tests/v2/integration/steveapi/steve_api_test.go:2691
        	Error:      	Received unexpected error:
        	            	unknown
        	Test:       	TestSteveDownstream
--- FAIL: TestSteveDownstream (7.13s)

Original Description
**Flaky Test**
TestSteveDownstream  rancher/tests/v2/integration/steveapi/steve_api_test.go:263

Release Branch
source branch of PR: release/v2.8
Drone Build (if applicable)
https://drone-pr.rancher.io/rancher/rancher/32472/6/2
pipeline stage URL:

=== RUN   TestSteveDownstream

    steve_api_test.go:263:

        	Error Trace:	/go/src/github.com/rancher/rancher/tests/v2/integration/steveapi/steve_api_test.go:263

        	            				/go/src/github.com/rancher/rancher/tests/v2/integration/steveapi/steve_api_test.go:255

        	            				/go/pkg/mod/github.com/stretchr/testify@v1.8.4/suite/suite.go:154

        	            				/go/src/github.com/rancher/rancher/tests/v2/integration/steveapi/steve_api_test.go:2693

        	Error:      	Received unexpected error:

        	            	Get "https://<IP_ADDRESS>:8443/v3": dial tcp <IP_ADDRESS>:8443: connect: connection refused

        	Test:       	TestSteveDownstream

--- FAIL: TestSteveDownstream (0.00s)

Seen this failing a few times recently (after moving to GHA), e.g. https://github.com/rancher/rancher/actions/runs/10080565381/job/27871551587?pr=46320#step:30:450

This test continues to fail a lot recently, e.g. 2/3 times on https://github.com/rancher/rancher/pull/46372 (last fail - https://github.com/rancher/rancher/actions/runs/10163267773/job/28110442691?pr=46372)

Added to v2.9-Next1 milestone purely for visibility purposes.

This test failed on https://github.com/rancher/rancher/actions/runs/10218950010/job/28277912902?pr=46430

another failure on the release/v2.8 branch: https://github.com/rancher/rancher/actions/runs/10222826592/job/28288699846?pr=46490#step:30:524

@igomez06 - I am going to move this out of the v2.9.1 since I don't think it's been fixed exactly. Let's try and get it for v2.9-Next1.

@igomez06 - I am going to move this out of the v2.9.1 since I don't think it's been fixed exactly. Let's try and get it for v2.9-Next1.
Nope it hasn't. Sounds good. Just to be clear on this ticket, it is dependent on this bug filed: https://github.com/rancher/rancher/issues/46391

@igomez06 - I am going to move this out of the v2.9.1 since I don't think it's been fixed exactly. Let's try and get it for v2.9-Next1.

Nope it hasn't. Sounds good. Just to be clear on this ticket, it is dependent on this bug filed: https://github.com/rancher/rancher/issues/46391

Since the associated bug with this flaky-test has been moved to v2.11, I am moving this ticket to correspond. @bmdepesa - can you help me make sure it gets assigned on the next iteration for 2.11?


no roomoccupant event emitted

a simple application.
X <--> a,b,c...
the problem is: the second (for example b) could not ran the roomoccupantListener for there's no event emitted while the first (a, as for this) goes well.
However,if I manually ran the roomOccupentListener, it works as well.
I'm confused and checked the docs and code, but no cause found.
//it won't be called for the second connection
function callTeacher(roomName, otherPeople,isPrimary) {
    easyrtc.setRoomOccupantListener(null); /
    //......

function init(){
    easyrtc.setRoomOccupantListener(callTeacher);
    easyrtc.setPeerListener(addToConversation);
    //......

Events orders need to be review in general.
Will check that.


Occasionally EC2 describe_instances returns no tags

If no tag filters are specified to the EC2 describe_instances call (or similar calls to describe other resource types) then AWS is allowed to return no tags at all:

http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/Using_Tags.html#Using_Tags_CLI

If this happens then EC2 filters on tag values fail as there are no tags to filter on.
This causes unexpected behavior.

it seems this may apply to any resources using the ec2 api, which all seem to return tags as part of their base describe calls. i checked other services documentation (asg, etc), none exude this caveat, on results outputs going awol.


Broken link to documentation (Edit extension page)

The link to the documentation on the "Edit extension" page is broken:
https://github.com/numbas/editor/blob/691e87cd755fe4095377c8201cf5cfad6c5c6f23/editor/templates/editable_package/edit_base.html#L20
(For themes it works as it is now, however.)

Thanks for reporting this!


mongocxx 3.2.0 :  mongocxx::options::index operator() call failed

error: no match for call to '(const mongocxx::v_noabi::options::index) ()
I have a function input argument defined as
const mongocxx::options::index& indexOpts;
With 3.2.0, I am now calling create_index() as
myCollection.create_index(keys, indexOpts());
indexOpts() failed with the error message mentioned above.

Hi @leo-zhu ,  can you give me more code to repro it?

Please open a new issue if this is still a problem for you.


PR #104070 - ui: add Created SQL Connections chart on SQL dashboard

Related PR: https://github.com/cockroachdb/cockroach/pull/104070
Commit: https://github.com/cockroachdb/cockroach/commit/731eef9a634f2619a5909e6ad709d91af401eb05
Fixes: CRDB-22359

Release note (ui change): added Created SQL Connections chart on
Metrics page, SQL Dashboard in DB Console.

The name of this chart was changed to "SQL Connection Rate"
in a later PR: https://github.com/cockroachdb/cockroach/pull/104978


i install the plugin ,when i click the save button,i got this error

[2017-08-22 02:41:46] mautic.ERROR: Symfony\Component\Debug\Exception\FatalThrowableError: Type error: Argument 1 passed to Mautic\SmsBundle\EventListener\SmsSubscriber::onPostSave() must be an instance of Mautic\SmsBundle\Event\SmsEvent, instance of MauticPlugin\MauticInfoBipSmsBundle\Event\SmsEvent given - in file /var/www/html/mautic-master/app/bundles/SmsBundle/EventListener/SmsSubscriber.php - at line 88 [] []

Please provide some additional information, like Mautic version you are using.

Accidentally found this behavior on one of my installations. Commit ef8e7aa solved this issue.


add option to upload known crash directory

Summary of the Pull Request
What is this about?
PR Checklist

[ ] Applies to work item: #xxx
[ ] CLA signed. If not, go over here and sign the CLI.
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?

Codecov Report

Merging #2950 (c9a88d5) into main (3c3f12a) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2950      +/-   ##
==========================================
- Coverage   29.09%   28.93%   -0.16%
==========================================
  Files         303      125     -178
  Lines       36170    13639   -22531
==========================================
- Hits        10523     3947    -6576
+ Misses      25647     9692   -15955

see 178 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


add SlideNavigationControllerWillReveal notification

With this event you can set different portraitSlideOffset for left and right menu (https://github.com/aryaxt/iOS-Slide-Menu/issues/139).

in cases openMenu gets called when the menu is already open. for example swiping and releasing. Maybe look into https://github.com/aryaxt/iOS-Slide-Menu/pull/146.


css: Fix Handle emoji not loading gracefully in PM list.

Fixes: #23516

Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@alya please review it. Thanks !

@timabbott I have used span instead of div as suggested. Please review it. Thanks !

@timabbott I'll mark this for integration review since you were looking at it earlier. Let me know if you need manual testing from my side (which seems a bit annoying to set up).

Merged after rewriting the commit message to explain the context a bit more and also note I cannot reproduce the original symptom. Thanks @Ujjawal3!


added Real Time Sudoku Solver

Pull Request for DL-Simplified 💡
Issue Title : [Project Addition] :Real Time Sudoku Solver Using OpenCV

Info about the related issue (Aim of the project) :
Name: Khushi Kalra
GitHub ID:abckhush
Email ID<EMAIL_ADDRESS>Idenitfy yourself: (Mention in which program you are contributing in. Eg. For a JWOC 2022 participant it's, JWOC Participant) GSSoC 2024 Contributor

Closes: #774
Describe the add-ons or changes you've made 📃
added Real time Sudoku solver.
Type of change ☑
What sort of change have you made:

[X] New feature (non-breaking change which adds functionality

How Has This Been Tested? ⚙
Yes, A sample demonstration video is included in the README.md file
Checklist: ☑

[X] My code follows the guidelines of this project.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly wherever it was hard to understand.
[X] I have made corresponding changes to the documentation.
[X] My changes generate no new warnings.
[X] I have added things that prove my fix is effective or that my feature works.
[X] Any dependent changes have been merged and published in downstream modules.

Hi @abhisheks008. I have made the desired changes. Kindly check.

Models Implemented
Exploratory Data Analysis Results
Performance of the Models based on the Accuracy Scores
These do not apply for my project/

Models Implemented Exploratory Data Analysis Results Performance of the Models based on the Accuracy Scores These do not apply for my project/

Brief your project and add the images in the README to demonstrate the process how it works.

I have updated the readme file as per requirements. The images are already present in the Images folder. Do you want me to change anything else?


Add Einaudi correggio school

Add Luigi Einaudi secondary school

@matteomalvezzi I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host einaudicorreggio.mo.it not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


Style frontpage

Right now it's basically copy & pasted from the RescueTime integration. Which doesn't really work for some reasons:

the most obvious one: it's not RescueTime
the Gallery should be available even for non-logged in users

Things to do:

[x] remove references to RescueTime
[x] add list of at least some Notebooks (most popular?)

Done.


Auto-Gather getting stuck in gathering window

Hi,
the auto-gather is getting stuck randomly in the gathering window so I will have to click them then the window will close, it'll move me to the next node and then open the window and it'll not do anything.
Any help appreciated!

I have a problem that the capture box in the game cannot appear, do you have it

I'm having this problem too.
And I've noticed that this problem often occurs when I empty my backpack after collecting “a certain collectible”, and then continue to collect the collectible, and then the window opens with no action


Http parsing check

Do not merge - in progress
resolves #151 by allowing jsonpath-like validation of api return body in the http_check binaries

Codecov Report

Merging #152 into master will decrease coverage by 1.72%.
The diff coverage is 59.45%.

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
- Coverage   84.26%   82.54%   -1.73%
==========================================
  Files          19       19
  Lines         623      653      +30
==========================================
+ Hits          525      539      +14
- Misses         98      111      +13
- Partials        0        3       +3

Impacted Files
Coverage Δ

lib/app/nagiosfoundation/check_http.go
76.47% <59.45%> (-23.53%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a75abdc...dff17c0. Read the comment docs.


Clicking New Game shows yourself as having joined the new game, but hasn't actually joined

Refreshing the page no longer shows the player, and allows you to click the Join Game button

Not sure which bug this was (probably a server connectivity one), but has been fixed now. Sequence to start a game has also been reworked


Add viewport resolution to the 3D editor's View Information pane

This closes https://github.com/godotengine/godot-proposals/issues/2205.
Preview
The label is "Size" as it's shorter than "Resolution". Also, debug information  haven't been reimplemented in the master branch yet, which is why they're all 0.

Thanks!

Cherry-picked for 3.2.4.


Avoid zero length streets

Currently, I have no example, where it would be necessary to list streets with zero length.

I think I fixed that on the way...


Add docs

What have I done
Added the manual steps of processing, which this pipeline automates.
Added process details for what is done in a pipeline.

Added a parameter that points to which email address that the data is going to be delivered to called delivered_to which is set to<EMAIL_ADDRESS>currently. Should change to<EMAIL_ADDRESS>when we get that working.
Usage example:
nextflow run main.nf --samplesheet /full/path/samplesheet.csv --delivered_to<EMAIL_ADDRESS>


Make addStyle() & Chameleon types public

Make addStyle function public to allow for better meta programming.
Make Chameleon types public to enable better type safety.

Please provide a valid description for your PR.

@tr1ckydev done.

Just curious, what kind of metaprogramming are you doing with addStyle?

Just curious, what kind of metaprogramming are you doing with addStyle?

https://github.com/Ratakor/clog/blob/c7112af746697452fc28431647dc9099927c8c36/src/clog.zig#L457
Since the interface for styles was not what I needed I made my own with an union(enum), the big switch is mainly because I prefer to stick to zig's naming style.


Using Couenne options from AmplNLWriter

I'm not sure if this is a problem with this interface or with my understanding of Couenne's options, but it doesn't seem like the options I specify affect the solver's behavior.
Here's a simple example:
using JuMP, AmplNLWriter

solver=AmplNLSolver("couenne", Dict("bonmin.allowable_gap"=>1,
                         "outlev"=>0,
                         "output_file"=>"results.out"))
m = Model(solver=solver)

srand(4)
nvar = 10
@defVar(m, -10 <= x[i=1:nvar] <= 10)
@setNLObjective(m, Min, sum{1/(1+exp(-x[i])), i=1:nvar})
@addConstraint(m, sum{x[i], i=1:nvar} <= .4*nvar)
@assert(solve(m) == :Optimal)

The output is exactly the same regardless of how I specify the allowable gap and outlev, and the file results.out never shows up. However, it does seem like Couenne knows something about these options, since the output starts with
Couenne 0.5 -- an Open-Source solver for Mixed Integer Nonlinear Optimization
Mailing list<EMAIL_ADDRESS>Instructions: http://www.coin-or.org/Couenne
couenne: output_file=results.out
bonmin.allowable_gap=100
outlev=0

My experience with Couenne is that it's not clear at all which options actually are respected. As you say, some seem to have no effect, like bonmin.allowable_gap. The only way I have successfully set some of the options is by using a couenne.opt file, which has to be placed in the working directory. Each line in this file should contain a key value pair, separated by a space, and seems to give access to more options than are supported by the command line. e.g. to set the allowable fractional gap:
allowable_fraction_gap 0.05

We chose not to add solver specific behavior into AmplNLWriter, but if you write a file like this to the working directory before the solve, it will get picked up.
As an example, the jump_pruning.jl in the examples folder takes about 10s to converge using Couenne with no options set, but the following will successfully set the relative tolerance and exit early:
shell> echo 'allowable_fraction_gap 0.01' > couenne.opt

julia> solver = CouenneNLSolver()
AmplNLWriter.AmplNLSolver("/Users/jack/.julia/v0.4/Homebrew/deps/usr/lib/../bin/couenne",Dict{ASCIIString,Any}())

julia> include(joinpath(Pkg.dir("AmplNLWriter"), "examples", "jump_pruning.jl"))
  > example: jump_pruning
Couenne 0.5.6 -- an Open-Source solver for Mixed Integer Nonlinear Optimization
Mailing list<EMAIL_ADDRESS>Instructions: http://www.coin-or.org/Couenne
couenne:
ANALYSIS TEST: NLP0012I
              Num      Status      Obj             It       time                 Location
NLP0014I             1         OPT -400.00001       29 0.019526
Couenne: new cutoff value -4.0000000800e+02 (0.027305 seconds)
Loaded instance "/Users/jack/.julia/v0.4/AmplNLWriter/.solverdata/model.nl"
Constraints:            8
Variables:              2 (0 integer)
Auxiliaries:            9 (0 integer)

Coin0506I Presolve 24 (-2) rows, 6 (-5) columns and 59 (-9) elements
Clp0006I 0  Obj -399.99001 Primal inf 40.312967 (4) Dual inf 58.942108 (1)
Clp0006I 8  Obj -197487.48
Clp0000I Optimal - objective value -197487.48
Clp0032I Optimal objective -197487.4793 - 8 iterations time 0.002, Presolve 0.00
Clp0000I Optimal - objective value -197487.48
Cbc0012I Integer solution of -400.00001 found by Couenne Rounding NLP after 0 iterations and 0 nodes (0.00 seconds)
NLP Heuristic: NLP0014I             2         OPT -400.00001       20 0.014536
no solution.
Clp0000I Optimal - objective value -197487.48
Optimality Based BT: 8 improved bounds
Probing: 6 improved bounds
NLP Heuristic: no solution.
Cbc0031I 5 added rows had average density of 2.6
Cbc0013I At root node, 5 cuts changed objective from -197487.48 to -605.79249 in 16 passes
Cbc0014I Cut generator 0 (Couenne convexifier cuts) - 22 row cuts average 2.9 elements, 17 column cuts (17 active)
Cbc0010I After 0 nodes, 1 on tree, -400.00001 best solution, best possible -605.79249 (0.05 seconds)
Optimality Based BT: 5 improved bounds
Optimality Based BT: 3 improved bounds
Optimality Based BT: 8 improved bounds
Optimality Based BT: 8 improved bounds
Optimality Based BT: 7 improved bounds
Couenne: new cutoff value -4.0000435404e+02 (0.132964 seconds)
Optimality Based BT: 6 improved bounds
Optimality Based BT: 3 improved bounds
Optimality Based BT: 8 improved bounds
Optimality Based BT: 6 improved bounds
Optimality Based BT: 7 improved bounds
Couenne: new cutoff value -4.0000595361e+02 (0.216213 seconds)
Optimality Based BT: 7 improved bounds
Cbc0010I After 100 nodes, 42 on tree, -400.00001 best solution, best possible -403.86423 (0.22 seconds)
Cbc0011I Exiting as integer gap of 3.8642216 less than 0 or 1%
Cbc0001I Search completed - best objective -400.00000799999, took 439 iterations and 101 nodes (0.22 seconds)
Cbc0035I Maximum depth 15, 0 variables fixed on reduced cost

 	"Finished"

Linearization cuts added at root node:         26
Linearization cuts added in total:             26  (separation time: 0.000174s)
Total solve time:                        0.223931s (0.223931s in branch-and-bound)
Lower bound:                             -403.864
Upper bound:                             -400.006  (gap: 0.95%)
Branch-and-bound nodes:                       101
Performance of                           FBBT:	   0.002143s,      187 runs. fix:          0 shrnk:   0.139821 ubd:  0.0869166 2ubd:          0 infeas:          0

It's a bit of a pain, but hopefully it should work

My experience with bonmin options is that they can be horribly broken. On a couple of occasions I've needed to hack the source to set specific options.

Writing an options file in the directory from which I invoke the solver seems to work for some options, but not all. The options file couenne.opt reads
allowable_fraction_gap 5.0
output_file fn.out

For small problems, this writes the output file fn.out, but solves the problem exactly. For large problems... well, it's been running for a day so far, so my guess is it's still trying to solve the problem exactly.
Miles, any advice on how to hack the source? (Or is there a different option name I should be using to tell the solver that a gap of 5 between the lower and upper bound would be perfectly ok with me?)

I think you could try allowable_gap 5.0 to set the absolute tolerance, allowable_fraction_gap sets the relative tolerance (sorry for the confusion!). It seems to work locally for me, it exits with:
Cbc0011I Exiting as integer gap of 3.8642216 less than 5 or 0%

I've found the best way to find the relevant options is through the default .opt files (and a lot of trial and error....), e.g.
https://github.com/coin-or/Couenne/blob/master/Couenne/src/couenne.opt
https://github.com/coin-or/Bonmin/blob/master/Bonmin/test/bonmin.opt
For whatever reason, the bonmin options seem to work with and without the bonmin. prefix, but don't get set properly through the command line args i.e. bonmin.allowable_gap works from the couenne.opt file, but as you saw not if you pass it on the command line.

Can you try the running the following to check if it works with the option setting (this is working on travis and appveyor as well as my machine):
using AmplNLWriter
solver = CouenneNLSolver()
open("couenne.opt", "w") do f
    write(f, "allowable_fraction_gap 0.0001")
end
include(joinpath(Pkg.dir("AmplNLWriter"), "examples", "jump_pruning.jl"))

Without the option file, it takes about 10 secs to converge, but with the tolerance it's about a second, and there's a message about exiting like Exiting as integer gap of 0.038215965 less than 0 or 0.01%
Same thing with the absolute tolerance:
using AmplNLWriter
solver = CouenneNLSolver()
open("couenne.opt", "w") do f
    write(f, "allowable_gap 5")
end
include(joinpath(Pkg.dir("AmplNLWriter"), "examples", "jump_pruning.jl"))

which shows something like Exiting as integer gap of 3.8642216 less than 5 or 0%
Hopefully that should pick it up!

That works! I suppose Couenne just doesn't know how to take advantage of an increased in the allowed gap for my problem.

Okay great! Miles might have more of an idea of how to get it working on your problem, I've never used it in any real capacity

No idea here. @emreyamangil and I once spent a day or so digging around Bonmin's source code to try and find its termination criteria without any success. I haven't looked at couenne but I'm guessing it might not be any easier.


Handle request too large

429 - message: Request too large for gpt-4o in organization org-3M84iZQTliRuKpVVeuB53iHJ on tokens per min (TPM): Limit 30000, Requested 49292. The input or output tokens must be reduced in order to run successfully. Visit https://platform.openai.com/account/rate-limits to learn more., type: tokens, param: null, code: rate_limit_exceeded

Retry with the split approach then?

That's strange, it should've retried with splitting approach.
@koppor, when you have time, could you attach me a PDF with this issue?

Additionally, the error message maybe should contain the file name. That could help to remember which PDF was used.

OMG, it seems I'm splitting documents, but instead passing a full document to AI. Working on it

@koppor, when you have time, try to load the document again. Should work now

Yeah, looks good:


Update playerlist.js

Line 85: Cannot set property 'isOpen' of undefined
Sugar is good tho

Line 85: Cannot set property 'isOpen' of undefined
Sugar is good tho

a. there is nothing on line 85
b. sugar?

And sugar = syntax sugar, yeah

I'm just confused about why self works but this doesnt

Because this changes depending on the context, and const self = this is just a way to save the context we want for later use

Because this changes depending on the context, and const self = this is just a way to save the context we want for later use

ohh i see

Just use an arrow function and the this context will be passed down to the child function

this is slightly better than before
however it can be improved a lot more, here is how if you're interested https://github.com/PrismarineJS/prismarine-web-client/pull/94/files#r593996913


fix query call

Fix http request with query parameter

Coverage increased (+0.001%) to 48.518% when pulling cd7761c598caeb1054314c55297db930eb259422 on devghosh:query_fix into 0eaf4727237a8b80c2799c948b42ea15999817d3 on jabong:master.

Coverage increased (+0.001%) to 48.518% when pulling cd7761c598caeb1054314c55297db930eb259422 on devghosh:query_fix into 0eaf4727237a8b80c2799c948b42ea15999817d3 on jabong:master.

Coverage increased (+0.001%) to 48.518% when pulling cd7761c598caeb1054314c55297db930eb259422 on devghosh:query_fix into 0eaf4727237a8b80c2799c948b42ea15999817d3 on jabong:master.

Coverage increased (+0.001%) to 48.518% when pulling 790a7110036673ffeed118915c25cf68505475d2 on devghosh:query_fix into 0eaf4727237a8b80c2799c948b42ea15999817d3 on jabong:master.

Coverage increased (+0.001%) to 48.518% when pulling 790a7110036673ffeed118915c25cf68505475d2 on devghosh:query_fix into 0eaf4727237a8b80c2799c948b42ea15999817d3 on jabong:master.


Add support for dry-run mode

Initial stab at supporting dry-run mode in the opa-grpc plugin, which defaults to false
If this is set to true, the grpc layer will unconditionally return true, regardless of what the query result was. This will be used in conjunction with console decision logging to query a whole package (e.g. data.mypackage (instead of only supporting boolean like data.mypackage.allow)) so that full context of what led to the decision can be logged.
This will likely only be a short-term strategy, until something like https://github.com/open-policy-agent/opa/issues/1508 is addressed, for two reasons:

We are at the very first stage of trying to roll out this infrastructure, and it's good to be running in this "shadow" mode where we allow no matter what, but we log what we would have done
Once we have some mileage on the infrastructure and https://github.com/open-policy-agent/opa/issues/1508 is addressed, we can have more confidence in allowing actual decisions to be returned while providing the context in response headers, and we can also consider rolling out decision changes in a "canary-like" fashion wherein we roll out new policies to a light weighted percentage of requests.

woops meant to create this in a separate fork

@danielpops This looks promising. Feel free to reopen when you're ready. We're happy to upstream this feature.


Low contrast update on account page #9294

Fixes Issue - #9294

Changes proposed

Fixed the low contrast text on the /onboarding.

Check List (Check all the applicable boxes)

[ x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[x ] This PR does not contain plagiarized content.
[x ] The title of my pull request is a short description of the requested changes.

Screenshots

We are glad that you want to contribute but the issue https://github.com/EddieHubCommunity/BioDrop/issues/9294 is assigned to someone else so we can't accept your Pull Request. I would recommend you to read our contributing guidelines https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md and close this Pull Request.

Sure, I get it :).


these two should equals ,but not , latitude was wrong

these two should equals ,but not , latitude was wrong
import numpy as np
import xarray as xr
data1 = xr.open_dataset('test1111111.nc')

#wrong code
> np.array(data1.sel(time='1990-1' , isobaricInhPa=200 ).z[: , ::-10 , ::10])
Out[37]:
array([[[109890.25, 109890.75, 109890.75, ..., 109888.25, 109889.25,
109889.75],
[110014.75, 110017.75, 110020.75, ..., 110006.75, 110009.75,
110012.25],
[110109.75, 110115.25, 110119.75, ..., 110098.25, 110101.75,
110106.25],
...,
[107800.25, 107824.75, 107845.75, ..., 107719.75, 107747.25,
107775.25],
[107684.25, 107697.75, 107709.75, ..., 107641.25, 107656.25,
107670.25],
[107585.75, 107587.75, 107589.75, ..., 107578.75, 107581.25,
107583.25]]], dtype=float32)

#right code
> np.array( data1.sel(time='1990-1' , isobaricInhPa=200 ).z)[: , ::-10 , ::10]
Out[38]:
array([[[109798.75, 109798.75, 109798.75, ..., 109798.75, 109798.75,
         109798.75],
        [109915.75, 109916.75, 109917.25, ..., 109912.75, 109914.25,
         109915.25],
        [110037.75, 110040.25, 110043.75, ..., 110028.25, 110030.25,
         110034.25],
        ...,
        [107776.25, 107797.25, 107818.75, ..., 107702.75, 107727.25,
         107753.25],
        [107662.25, 107673.25, 107683.25, ..., 107626.75, 107638.75,
         107650.75],
        [107571.25, 107571.25, 107571.25, ..., 107571.25, 107571.25,
         107571.25]]], dtype=float32)

The latitude is really messed up.
test1111111.zip
Originally posted by @jesieleo in https://github.com/pydata/xarray/discussions/6546

Please open a bug report, which contains instructions for how to produce one. Thanks @jesieleo


[Bug] start-storybook breaks when tsconfig.json has comments (preset-create-react-app)

Describe the bug
This sounds cracy but I do reproduce the following:
-> React ts project (created used create-react-app)
-> Storybook uses regular .jsx files
-> tsconfig.json at root looks:
 "compilerOptions": {
    "target": "es5",
    "lib": ["dom", "dom.iterable", "esnext"],
    "allowJs": true,
    "skipLibCheck": true,
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "module": "esnext",
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "noEmit": true,
    "jsx": "react-jsx",
    "baseUrl": "src",
    "noFallthroughCasesInSwitch": true
  },
  "include": ["src"]

I run (from package.json)
"scripts": {
  ...
  "storybook": "start-storybook -p 9009 -s public",
  ...
}

And everything works like a charm.

***
NOW, I add a comment to tsconfig.json
"compilerOptions": {
+   // whatever
    "target": "es5",
    "lib": ["dom", "dom.iterable", "esnext"],

And start-storybook -p 9009 -s public just breaks.
It raises multiple (several) ModuleNotFoundError
ModuleNotFoundError: Module not found: Error: Can't resolve ....

Expected behavior
Writting down a comment doesn't break the build
Screenshots and/or logs
please do ignore the specifics:
ModuleNotFoundError: Module not found: Error: Can't resolve 'utils/test-utils' in '/my-project/src/my-code'
    at /my-project/node_modules/@storybook/builder-webpack4/node_modules/webpack/lib/Compilation.js:925:10
    at /my-project/node_modules/@storybook/builder-webpack4/node_modules/webpack/lib/NormalModuleFactory.js:401:22
    at /my-project/node_modules/@storybook/builder-webpack4/node_modules/webpack/lib/NormalModuleFactory.js:130:21
    at /my-project/node_modules/@storybook/builder-webpack4/node_modules/webpack/lib/NormalModuleFactory.js:224:22
    at /my-project/node_modules/neo-async/async.js:2830:7
    at /my-project/node_modules/neo-async/async.js:6877:13
    at /my-project/node_modules/@storybook/builder-webpack4/node_modules/webpack/lib/NormalModuleFactory.js:214:25
    at /my-project/node_modules/enhanced-resolve/lib/Resolver.js:213:14
    at /my-project/node_modules/enhanced-resolve/lib/Resolver.js:285:5
    at eval (eval at create (/my-project/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)
    at /my-project/node_modules/enhanced-resolve/lib/UnsafeCachePlugin.js:44:7
    at /my-project/node_modules/enhanced-resolve/lib/Resolver.js:285:5
    at eval (eval at create (/my-project/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)
    at /my-project/node_modules/enhanced-resolve/lib/Resolver.js:285:5
    at eval (eval at create (/my-project/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:27:1)
    at /my-project/node_modules/enhanced-resolve/lib/DescriptionFilePlugin.js:67:43
resolve 'utils/test-utils' in '/my-project/src/my-code'
  Parsed request is a module
  using description file: /my-project/package.json (relative path: ./src/my-code)
    Field 'browser' doesn't contain a valid alias configuration
    resolve as module
      /my-project/src/my-code/node_modules doesn't exist or is not a directory
      /my-project/src/pages/living-app/screens/node_modules doesn't exist or is not a directory
      /my-project/src/pages/living-app/node_modules doesn't exist or is not a directory
      /my-project/src/pages/node_modules doesn't exist or is not a directory
      /my-project/src/node_modules doesn't exist or is not a directory
      /Users/cx01885/Workspace/living-apps/node_modules doesn't exist or is not a directory
      /Users/cx01885/Workspace/node_modules doesn't exist or is not a directory
      /Users/cx01885/node_modules doesn't exist or is not a directory
      /Users/node_modules doesn't exist or is not a directory
      /node_modules doesn't exist or is not a directory
      looking for modules in /my-project/node_modules
        using description file: /my-project/package.json (relative path: ./node_modules)
          Field 'browser' doesn't contain a valid alias configuration
          using description file: /my-project/package.json (relative path: ./node_modules/utils/test-utils)
            no extension
              Field 'browser' doesn't contain a valid alias configuration
      looking for modules in /my-project/node_modules
        No description file found
        Field 'browser' doesn't contain a valid alias configuration
              /my-project/node_modules/utils/test-utils doesn't exist
            .web.mjs
              Field 'browser' doesn't contain a valid alias configuration
              /my-project/node_modules/utils/test-utils.web.mjs doesn't exist
            .mjs
              Field 'browser' doesn't contain a valid alias configuration
              /my-project/node_modules/utils/test-utils.mjs doesn't exist
            .web.js
              Field 'browser' doesn't contain a valid alias configuration
              /my-project/node_modules/utils/test-utils.web.js doesn't exist
            .js
              Field 'browser' doesn't contain a valid alias configuration
              /my-project/node_modules/utils/test-utils.js doesn't exist
            .web.ts
              Field 'browser' doesn't contain a valid alias configuration
        No description file found
        no extension
          Field 'browser' doesn't contain a valid alias configuration
              /my-project/node_modules/utils/test-utils.web.ts doesn't exist
            .ts
              Field 'browser' doesn't contain a valid alias configuration
          /my-project/node_modules/utils/test-utils doesn't exist
        .web.mjs
          Field 'browser' doesn't contain a valid alias configuration
              /my-project/node_modules/utils/test-utils.ts doesn't exist
            .web.tsx
              Field 'browser' doesn't contain a valid alias configuration
          /my-project/node_modules/utils/test-utils.web.mjs doesn't exist
        .mjs
          Field 'browser' doesn't contain a valid alias configuration
              /my-project/node_modules/utils/test-utils.web.tsx doesn't exist
            .tsx
              Field 'browser' doesn't contain a valid alias configuration
          /my-project/node_modules/utils/test-utils.mjs doesn't exist
        .web.js
          Field 'browser' doesn't contain a valid alias configuration
              /my-project/node_modules/utils/test-utils.tsx doesn't exist
            .json
              Field 'browser' doesn't contain a valid alias configuration
          /my-project/node_modules/utils/test-utils.web.js doesn't exist
        .js
          Field 'browser' doesn't contain a valid alias configuration
              /my-project/node_modules/utils/test-utils.json doesn't exist
            .web.jsx
              Field 'browser' doesn't contain a valid alias configuration
          /my-project/node_modules/utils/test-utils.js doesn't exist
        .web.ts
          Field 'browser' doesn't contain a valid alias configuration
              /my-project/node_modules/utils/test-utils.web.jsx doesn't exist
            .jsx
              Field 'browser' doesn't contain a valid alias configuration
          /my-project/node_modules/utils/test-utils.web.ts doesn't exist
        .ts
          Field 'browser' doesn't contain a valid alias configuration
              /my-project/node_modules/utils/test-utils.jsx doesn't exist
          /my-project/node_modules/utils/test-utils.ts doesn't exist
        .web.tsx
          Field 'browser' doesn't contain a valid alias configuration
            as directory
              /my-project/node_modules/utils/test-utils doesn't exist
          /my-project/node_modules/utils/test-utils.web.tsx doesn't exist
        .tsx
          Field 'browser' doesn't contain a valid alias configuration
          /my-project/node_modules/utils/test-utils.tsx doesn't exist
        .json
          Field 'browser' doesn't contain a valid alias configuration
          /my-project/node_modules/utils/test-utils.json doesn't exist
        .web.jsx
          Field 'browser' doesn't contain a valid alias configuration
          /my-project/node_modules/utils/test-utils.web.jsx doesn't exist
        .jsx
          Field 'browser' doesn't contain a valid alias configuration
          /my-project/node_modules/utils/test-utils.jsx doesn't exist
        as directory
          /my-project/node_modules/utils/test-utils do
...

Environment

OS: macOs
Node.js version: v14.18.2
NPM version: 6.14.15
Browser (if applicable): --
Browser version (if applicable): --
Device (if applicable): --

This error is because toy have "baseurl" in your tsconfig. Rollup doesnt support that.


Does the random regression forest works with multi-variable in labels?

For example, each label is a vector of floats.

This appears to be a usage question, rather than a bug report or feature request, hence it is better asked on stackoverflow.


Replace kRPC

We should replace kRPC with gRPC. This will allow us to remove more kythe code from third-party.

Increasing priority; if we're going to change the protocol we should do it before more external analyzers get written.

We have several steps to making this work.

Fix up our third party repo and the build rules around them. It's a mess right now. We should use kythe as an example.
Add in grpc by setting GOPATH to thirdparty/go; doing a go get; adding in the BUILD rules needed for all of this.
Make it possible for grpc to generate service stubs from proto. This requires modifying bazel config (plugins=grpc, search for this in kythe for an example) and adding the implicit grpc dependencies. Kythe added this to their proto build rules with has_services flag. We're probably just going to want all of kythe's build rules for grpc.
Switch our code over to using grpc.

Part 1 is complete, D145.


Clarify Codespaces VSCode extension requirements

Why:
Github Codespaces does not support 32-bit versions of local VSCode.
This change clarifies the requirements for the GitHub Codespaces extension for VSCode. Users of 32-bit VSCode, like myself, have encountered an error stating, "Failed to start VS Code Remote server." The issue arises due to the GitHub Codespaces extension lacking support for 32-bit VSCode. This change will specify the need for a 64-bit version of VSCode, thereby saving users time.

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

@TheAverageStudents Thanks so much for opening a PR! I'll get this triaged for review ✨

@TheAverageStudents - Thanks for raising this. 👍
Let me just double-check this with Engineering before I merge this clarification.

I've been advised by Engineering that 32-bit VS Code is supported in some cases and there's currently a feature request for the VS Code remote agent relating to this. As a result we don't want to make this change to the docs, at least for now.
However, thank you for taking time to raise this PR.


Modify Hover behavior

is there a way to modify the hover behavior? for example pinning it at the top instead of the bottom? I am not really a fan of the hover at all.. I would prefer just a static link header on the top..
but sadly I am not a web designer.. any idea how I can accomplish this?
It would be nice to have an option for disabling the hover bar and having a static header at the top instead. Something like this on my current website: https://nullday.de/
(just without that left logo and right dark/light theme switcher of course)
The reason why i want to change from hello-friend-ng to hermit, is that hermit is blazing fast and hello-friend-ng got so bloated recently that it destroys my good google pagespeed ranking

To pin it to the top is very easy, the harder part is to adjust everything else. "Pinned to the top" and "Hovered at the bottom" are totally different page layouts. As you can see, in the original theme, the height of single page's title is not fixed, based on the page width, the height is different. If we pin the header to the top, this has to be adjusted. What's more, animations has to be removed, javascript that related to page scroll event has to be modified and mobile menu behaviour has to be changed as well.
It will be very difficult to support both at the same time.  Sometimes we just have to choose one!

I see, so it's far more complicated when I thought. (I am not a web-guy, so sorry for stealing your time with this issue) :)


The site doesn't load

Environment:
Microsoft Windows 7 Professional SP1
Google Chrome v. 79.0.3945.130
I try to open your site and get an empty page with these errors in console tab:

In Network tab:

Note:
About 1 second, the site tries to load (for a short time I see the page), but then everything disappears.

Are you using adblock?
I found a file https://csslayout.io/patterns-accordion-Cover~patterns-card-Cover~patterns-centering-Cover~patterns-cookie-banner-Cover~p~5fb8d316.js which will trigger a block rule in the lists

I just add a rule to let all the scripts from csslayout.io to bypass
@@||csslayout.io^$script,1p

@phuoc-ng Maybe configure output.chunkFilename in webpack.config.js with a name that exclude
the [name]? e.g. chunkFilename: 'chunk.[contenthash].js'

@DanSnow
Yeah, I use adblock. And think that problem about load the site because of it.  I can't check it out on this machine today, but on similar browser and OS all works now. Tomorrow will test and write about working of the site.

@DanSnow @RinatValiullov
Thanks for reporting the issue and the suggestion.
I made the PR to fix it here.
The website is also updated. Can you visit the website to see if it's fixed, @RinatValiullov?

I can confirm that the website is working after I comment out the custom rule for my adblock

All works now.
Thanks for well-timed support.


Dealing with pre-builts brought in by SDK bundled versions in repo source-build

Problem
Some SDK features are brought in dynamically via packages. Examples include: crossgen2, illink, targeting packs for downlevel .NET versions. The SDK determines what it should bring in via a set of 'bundled versions' that ship with the SDK in a props file   called Microsoft.NETCoreSdk.BundledVersions.props. Many repositories utilize these features while building. Runtime, for instance, uses crossgen and the illink tasks. The versions used are typically provided by the SDK that the repo is building with.
When building repositories in source-build mode (in isolation), previously source-built artifacts are not available, and therefore these packages will appear in the prebuilt report. This presents an issue to repos trying to get prebuilt clean in their repo-level source-build.
Broadly, we can divide these dynamically brought in tools into two categories:

Current: Those that are built in the current major product band (e.g. 8.0 crossgen).
Downlevel: Those that are built in a downlevel product band (e.g. net70 targeting pack).

In general, Current prebuilts are totally acceptable. Downlevel prebuilts are generally not acceptable. They should either be handled with SBRPs (e.g. in the case of targeting packs) or avoided altogether. For instance, we should not be using the 6.0 crossgen in the 8.0 source-build, because it's not built there. It may be built in 6.0 source-build, but that would require source-build partners to build downlevel products before building newer ones. That may not even be possible in some circumstances (e.g. if 6.0 didn't work on a specific distro).
So we need a way to avoid reporting these Current prebuilts in repo-level SB while still reporting Downlevel.
Approach taken
Because the Current bundled tools will generally have major versions that correspond with .NET's major version, we should exclude these prebuilts in the baseline, with the major version as part of the pattern. While possible, it's relatively rare that the repo will override the version of a tool to not match the SDK version. In those cases, the prebuilt will be flagged in the VMR build.
Alternate approach
Alternatively, we could automatically generate, for a given SDK, the set of "expected prebuilts" that are brought in dynamically, perhaps by parsing the bundled version props file. We would then apply a filter to remove the unacceptable ones (e.g. 7.0 illink).
This is approach is more accurate, as it would catch cases where a repo override a tool version before detection at the VMR level. However, it's more complicated to implement and we should go with a simpler approach for now.

/cc @mmitche @oleksandr-didyk @crummel @mthalman @dotnet/source-build-internal

[Triage] We should create a document that captures this policy in the repo documentation.


--blame-hang equivalent for AoT testing

Summary
Add a similar capability to dotnet test's --blame-hang functionality to make it easier to diagnose the source of hanging tests.
Background and Motivation
I have a test suite using the new AoT test runner where sometimes something hangs in one of the tests, but only when it's running in native AoT. The effectively identical tests I have that use xunit via dotnet test don't exhibit the same behaviour where I could use --blame-hang.
Additionally, using [Timeout(...)] doesn't seem to be having any effect. I'd expect the hanging test to timeout and fail, not hang.
Proposed Feature
A similar (I assume identical would be too difficult within a native AoT environment) set of command-line switches to allow for dumps to be generated to identify tests that hang. For example:
my-aot-tests.exe --blame-hang --blame-hang-dump-type <DUMP_TYPE> --blame-hang-timeout <TIMESPAN>

Alternative Designs
None.

There's a Microsoft.Testing.Extensions.HangDump package you can install. Info is here: https://learn.microsoft.com/en-us/dotnet/core/testing/unit-testing-platform-extensions-diagnostics
Is that what you want?

Thanks for the tip, I didn't know about that 🙇♂
Of course, I'm now having trouble getting it to work properly on not-Windows...

Alas, that lead me to #3097.

@martincostello I will close this ticket and we will handle support for hang dump in non-windows. We have explored multiple solutions and I don't recall the one we went with at the end.


Zfa fround handling of NaN

The Zfa spec for fround.* and froundnx.* describes how to handle Zero and Infinite inputs, but is silent about NaN.
The Zfa spec indicates these instructions implement the IEEE754-2019 roundToIntegral/Exact family of instructions, so if the input is a NaN, the output should be a NaN.
The Zfa spec is silent about what kind of NaN is produced.  Sail produces a canonical NaN.
I suggest clarifying the riscv_zfa spec by adding a sentence to 26.3 after "Zero and infinite inputs are copied to rd unmodified.":
"If the input is a NaN, the output is a canonical NaN."
[31] [M]: 0x000000008000300E (0xF0028053) fmv.w.x ft0, t0
f0 <- 0xFFFFFFFF7FC00001
mem[X,0x0000000080003012] -> 0x70D3
mem[X,0x0000000080003014] -> 0x4040
[32] [M]: 0x0000000080003012 (0x404070D3) fround.s ft1, ft0, dyn
f1 <- 0xFFFFFFFF7FC00000
mem[X,0x0000000080003016] -> 0xD06F
mem[X,0x0000000080003018] -> 0x83CF

I think one has to go back to the F extension (that D and Zfa are built
upon), where it says "Except when otherwise stated, if the result of a
floating-point operation is NaN, it is the canonical NaN. The canonical NaN
has a positive sign and all significand bits clear except the MSB, a.k.a.
the quiet bit."  (And the SAIL code matches this.)
Greg
On Sun, Jan 21, 2024 at 7:22 PM David Harris @.***>
wrote:

The Zfa spec for fround.* and froundnx.* describes how to handle Zero and
Infinite inputs, but is silent about NaN.
The Zfa spec indicates these instructions implement the IEEE754-2019
roundToIntegral/Exact family of instructions, so if the input is a NaN, the
output should be a NaN.
The Zfa spec is silent about what kind of NaN is produced. Sail produces a
canonical NaN.
I suggest clarifying the riscv_zfa spec by adding a sentence to 26.3 after
"Zero and infinite inputs are copied to rd unmodified.":
"If the input is a NaN, the output is a canonical NaN."
[31] [M]: 0x000000008000300E (0xF0028053) fmv.w.x ft0, t0
f0 <- 0xFFFFFFFF7FC00001
mem[X,0x0000000080003012] -> 0x70D3
mem[X,0x0000000080003014] -> 0x4040
[32] [M]: 0x0000000080003012 (0x404070D3) fround.s ft1, ft0, dyn
f1 <- 0xFFFFFFFF7FC00000
mem[X,0x0000000080003016] -> 0xD06F
mem[X,0x0000000080003018] -> 0x83CF
—
Reply to this email directly, view it on GitHub
https://github.com/riscv/riscv-isa-manual/issues/1195, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALLX6GWB4WE6H6M4DJGCNC3YPXLOTAVCNFSM6AAAAABCEQH4HOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4TEOJZGM2TENI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I did look at that, but I also saw that FMIN, FMAX, FCVT, FSGNJ*, FMV, FEQ, FLT, FLE and FCLASS specify behavior if an input is NAN.  The Zfa spec also describes Zero, infinite, and signaling NaN. There's just enough uncertainty that I felt a need to run Sail to verify the canonical NaN output.  I agree that the spec isn't wrong, but I think being explicit would save other people wondering.

For my part, I'd prefer to continue to fall back to the "except when otherwise stated" clause, on the basis that I don't want to spell it out for other instructions where the default behavior applies.

Thank you for the feedback.  Sounds like time to close this.


Broker and Meshsync pods, along with kube-rbac-proxy container are missing while installing with helm chart

Current Behavior

The Broker and Meshsync pods are missing after meshery is deployed using the helm chart
The kube-rbac-proxy container is also missing in the meshery-operator pod compared to the installation result that mesheryctl gives
Expected Behavior

We should provide a way to manually create CR instances for Broker and Meshsync after the CRDs are installed
We should also add the kube-rbac-proxy container to the meshery-operator pod so that the meshery installation process with helm chart is consistent with mesheryctl
Screenshots/Logs

With helm chart installation:
helm install test install/kubernetes/helm/meshery -n meshery --kubeconfig=$KUBECONFIG
NAME: test
LAST DEPLOYED: Wed Sep 15 15:07:05 2021
NAMESPACE: meshery
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
1. Get the application URL by running these commands:
     NOTE: It may take a few minutes for the LoadBalancer IP to be available.
           You can watch the status of by running 'kubectl get --namespace meshery svc -w test-meshery'
  export SERVICE_IP=$(kubectl get svc --namespace meshery test-meshery --template "{{ range (index .status.loadBalancer.ingress 0) }}{{.}}{{ end }}")
  echo http://$SERVICE_IP:9081/provider
2. All the Notes.txt of Meshery, Mesheryistio and Mesherylinkerd need to add the content here. This can be achieved by sub PR.

kubectl get pods -n meshery --kubeconfig=$KUBECONFIG
NAME                                    READY   STATUS    RESTARTS   AGE
meshery-677df7b644-kjg68                1/1     Running   0          76s
meshery-consul-5769bf7c9c-vqk6j         1/1     Running   0          77s
meshery-cpx-679cb4c5bb-5z8vc            1/1     Running   0          77s
meshery-istio-55bc6b4679-bhh84          1/1     Running   0          77s
meshery-kuma-64476f65fb-vzf98           1/1     Running   0          76s
meshery-linkerd-bb74b8dd9-bs6s9         1/1     Running   0          76s
meshery-nsm-846c648c97-xx8vw            1/1     Running   0          76s
meshery-operator-8899b86cf-cjsb4        1/1     Running   0          76s
meshery-osm-97995cd6f-pjfdd             1/1     Running   0          76s
meshery-traefik-mesh-65bc8888bc-nk5mn   1/1     Running   0          76s

kubectl get brokers.meshery.layer5.io -n meshery
No resources found in meshery namespace.

kubectl get meshsyncs.meshery.layer5.io -n meshery
No resources found in meshery namespace.

With mesheryctl installation:
kubectl get pods -n meshery
NAME                                    READY   STATUS    RESTARTS   AGE
meshery-58f5449cc-tjrmq                 1/1     Running   0          68s
meshery-broker-0                        2/2     Running   0          27s
meshery-consul-6cb6f89f66-wbjk2         1/1     Running   0          62s
meshery-cpx-8497c64cfc-2gh7v            1/1     Running   0          57s
meshery-istio-db9b99584-mhnrz           1/1     Running   0          66s
meshery-kuma-9b5ddbb77-dmnmz            1/1     Running   0          59s
meshery-linkerd-94c765956-swpjn         1/1     Running   0          64s
meshery-meshsync-5bcbc874f8-rzgsg       1/1     Running   2          25s
meshery-nginx-sm-5546bc9b5d-2qcxp       1/1     Running   0          52s
meshery-nsm-c7fd64dc4-nqdrd             1/1     Running   0          61s
meshery-operator-bddf9fd66-8sr68        2/2     Running   0          34s
meshery-osm-5ffd986b64-z674l            1/1     Running   0          56s
meshery-traefik-mesh-5d6695b5fd-zs5rl   1/1     Running   0          54s

kubectl get brokers.meshery.layer5.io -n meshery
NAME             AGE
meshery-broker   8m11s

kubectl get meshsyncs.meshery.layer5.io -n meshery
NAME               AGE
meshery-meshsync   8m46s

Environment

Host OS: Mac Linux Windows
Platform:  Kubernetes
Meshery Server Version: stable-v
K8s version any
Helm version any

Contributor Guides and Resources

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

Great write-up, @panyuenlau 💪


Show latest commit message on project page

The most recent Github update hides the latest commit message on a project page. Instead, it only shows the author, commit date, and SHA:

This seems like a misfeature to me - there's always enough space to display at least part of the commit message. Seeing a commit message by default is much more useful than a SHA - I have no reason to want to copy a SHA until I know what the commit does.
I think it would be useful to hide the SHA and use the extra space to display as much of the commit message as will fit.

Maybe we can just expand the commit message by default.

@kidonng: That's what I ended up implementing: https://github.com/sindresorhus/refined-github/pull/3278

This piece of information is actually already on the page. What if we inconspicuously highlighted the latest commit in the filelist?
Bold:

Blue line:

That's not much help for repositories with many top-level files (e.g. git), though it's an interesting idea.

I agree with @sersorrel, it's hard to discover in my opinion.
Can we always show the first line of the commit message (and user click expand to see the rest of the message and description)? (https://github.com/sindresorhus/refined-github/pull/3278#issuecomment-649488947)

This doesn't look great

But messing with negative margins and text-gray might fix it:

Can this feature be implemented with CSS only?
Would the negative margins cause conflicts?
Would this cause the content to jump? i.e. is the commit message lazily loaded?

I realized I want this. PR welcome to fix it as described above (only the commit title + centered on the avatar)

its comming back

They're onto us!!
However that change moves 2 links next to the branch selector, breaking latest-tag-button

@fregante Changing the selector from .breadcrumb to .file-navigation .flex-auto works on both layout, but...


createTable command with _id errors out

The following createTable() command:
{
  "createTable": {
    "name": "bots",
    "definition": {
      "primaryKey": "_id",
      "columns": {
        "_id": {
          "type": "text"
        },
        "name": {
          "type": "text"
        }
      }
    }
  }
}

throws the following error:
[{"message":"Server failed: root cause: (java.lang.IllegalArgumentException) Invalid CQL form [_id]: needs double quotes","errorCode":"SERVER_UNHANDLED_ERROR"}

Looks like we also need some double quotes for createTable?

@vkarpov15 yes, thank you for reporting this!

@vkarpov15 Cannot reproduce, see #1401 for attempted reproduction: table creation succeeds.

I confirmed this was due to an out-of-date version of Data API. createTable works fine on my end now.

Thank you for confirming @vkarpov15.


3695 optimism bedrock contract

Description

Type of change

[ ] Docs change / dependency upgrade
[ ] Configuration / tooling changes
[ ] Refactoring
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)
Fixes
Related pull request(s)

Looks good, would be great if you could add the offchain changes here as well.

Yep

tested one-off deployed contracts against a send message and verified it works with some updates!
want to refrain on further deployed testing until we have the first thing through staging. not sure how to properly feature-flag this one out outside of the spokeChainId check 🤔


make market volume default sort

convo in discord by Mr krug. I agree volume is more interesting.
Market default sort should be volume imo(edited)
Just noticed that got changed away to be recently traded
Makes it way harder to consolidate liquidity on open markets which is important for the success of this imo
Dunno how that got changed

Coverage remained the same at 64.687% when pulling bb64fbf8bbb32e56490a5ff61c68e309e4a46c4f on tomhaile/ch15780/make-market-volume-default-sort into ec0ad4f1c1c0486eecd7fc5cf553b1f44c82f12d on master.

Coverage remained the same at 64.687% when pulling bb64fbf8bbb32e56490a5ff61c68e309e4a46c4f on tomhaile/ch15780/make-market-volume-default-sort into ec0ad4f1c1c0486eecd7fc5cf553b1f44c82f12d on master.

Going to close this as Joey has said Open Interest is fine.


Haxe map access in Lua

What feature do you want to get added on the base engine?
Basically getPropertyFromGroup() and setPropertyFromGroup() but with haxe maps
To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.

vouch, raf has something very good planned for if this gets added

^

also please for other classes instead of just playstate

Done on a PR


Home Assistant TTS

Thank you for the wonderful nodes, I'm extremely novice but I've found your nodes extremely helpful to accomplish what I've set out to create so thank you for your work. I wonder if it would be possible to add Home Assistant Cloud TTS to your node? Or maybe I'm missing the functionality to implement other TTS services? Thank you again!

Hi
I’ll check that, but i think, it’s exclusively for Home Assistant users.

Thanks for your time either way it works out. Really appreciate what you’ve made as is.


Remove number pad support

This was confusing to people and a burden to package authors to have number pad keys behave differently than their equivalent key elsewhere on the keyboard.
See https://github.com/atom/atom-keymap/issues/42 for more details.
Closes #2527
Closes #2921
Closes #2972
Closes #3232

I'm just one person, but this change did make Atom a no-go for me.  I have 25 years of brief keymappings in my skull that are now impossible to duplicate in Atom, but used to be.
Atom is free and excellent, so I have no right to complain.  I just wanted to toss in my view in the off chance that the functionality might one day be restored.

With numpad on - I would like to see "Shift+7(Home)" resolve to 'Home'(move to first character in line)
However I am unable to map this using the keymap. This works fine in windows otherwise like in the notepad.


Clone project

When I compiled external proto files I got a lot of warnings and few compiler errors. I would like to fixed them, but can't clone the project, it says access denied.

You can create a fork and after your fixes make a pull requests.