Should there be a default impl for hal::serial::blocking::Write?

Hi,
in trying to fix the defmt-serial example for rp-hal I am struggling to use the blocking serial Write trait. Ideally defmt needs to do a blocking write, but it seems that it is not implemented for rp-hal. It is not possible to accept both the blocking and non-blocking since they would potentially conflict. I don't want to depend on the non-blocking, since I then would disable more sophisticated blocking impls for other HALs. Should there be a blocking impl for the rp-hal or at least opted in to the default Write impl?
I don't know where things are in newer embedded-hal to be honest.
Regards, Gaute

I guess you the title contains a typo and should read embedded_hal::blocking::serial::Write?
That's indeed not implemented. I doubt anyone plans adding it, given that it's from embedded_hal 0.2, and embedded_hal 1.0 does no longer contain this function.
But there is a function write_full_blocking that looks like it does exactly what you need: A blocking write to a serial port. Is there anything missing from that function?
https://docs.rs/rp2040-hal/latest/rp2040_hal/uart/struct.UartPeripheral.html#method.write_full_blocking
https://docs.rs/rp2040-hal/latest/rp2040_hal/uart/struct.Writer.html#method.write_full_blocking

Yes, but I can't use that one generically from defmt-serial. I'll look into whether eh1 has everything I need.

If you want to use a trait, on the main branch UartPeripheral implements embedded_io::Write, which has a method write_all.
https://docs.rs/embedded-io/latest/embedded_io/trait.Write.html#method.write_all
embedded_io is more or less the official replacement for the serial functions missing from embedded-hal 1.0.


Update akka-http, akka-http-spray-json, ... to 10.1.14

Updates

com.typesafe.akka:akka-http
com.typesafe.akka:akka-http-spray-json
com.typesafe.akka:akka-http-testkit

from 10.1.3 to 10.1.14.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.akka" } ]

labels: library-update, semver-patch

Superseded by #2241.


fix: remove [warning] from typedoc for external usage

running npx typedoc --entryPoints src --out build generates a number of warnings that are addressed here. This goes from misnamed or unnamed function parameters to exported types with unexported referenced types.
Motivation and Resolution
This PR addresses a number of [warning] reported by typedoc some of which that are small enhancement to use the starknet.js library, including:

renaming @param to match the function spec
naming function parameters
exporting underlying type with exposed type to ease the use for external projects

RPC version (if applicable)
0.6 and 0.7
Usage related changes
None
Development related changes
None
Checklist:

[x] Performed a self-review of the code
[x] Rebased to the last commit of the target branch (or merged it into my branch)
[ ] Linked the issues which this PR resolves
[x] Documented the changes in code (API docs will be generated automatically)
[ ] Updated the tests
[ ] All tests are passing

This PR contains a number of changes some of which are very easy like renaming @param and other are probably counter-productive like providing underlying types for the 0.6 RPC which we do not use anyway. Do not hesitate to provide some feedbacks:

if you agree on some of those changes and would like to get a separate PR
if you want some changes to be removed
if some changes do not make sense

Thank you for your review.

@0xknwn thanks!

Maybe you would prefer I rebase on next-version?

yes, could you please do this again on the next branch? we had some docs changes there merged that are not in develop


Switch names over to Path based stuff

Just the right thing to do, but also may make setting up Arbitrary stuff and allowing for prop testing to randomize more

All names are now OsString based types


testing linkless

👷 Deploy Preview for sit-cybersecurity processing.

Name
Link

🔨 Latest commit
8377d298ee96ce5e0a8d5236ca66c5d65d32e6b6

🔍 Latest deploy log
https://app.netlify.com/sites/sit-cybersecurity/deploys/64a4fba239b41500089ffd0b


Added an SPF Check button to the config tab for the client

@wolfthefallen @zeroSteiner

The changes to the requirements file can definitely not be merged. They'd remove a couple of necessary packages.

The dialogs would all look a bit better if a title were specified. A title can be provided as a third string argument. That way all the result messages could have a common title, same with the warnings etc.

@guitarmanj looks good, Thank you. Once I test, if everything works out i'll land it.
Need to test

[ ] spf check fail
[ ] spf check soft fail
[ ] spf check hard fail
[ ] spf fails with out email address
[ ] spf check pass

[ ] gui
[ ] gui resizes correctly
[ ] objects on the gui flow with the rest of the interface

For hard fail - securestate.com
For soft fail - google/Gmail
No spf: any of our clients hahaha
Sent from my T-Mobile 4G LTE Device
-------- Original message --------
From: Erik Daguerre<EMAIL_ADDRESS>Date: 9/16/16 17:00 (GMT-05:00)
To: securestate/king-phisher<EMAIL_ADDRESS>Cc: guitarmanj<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [securestate/king-phisher] Added an SPF Check button to the config tab for the client (#152)
@guitarmanjhttps://github.com/guitarmanj looks good, Thank you. Once I test, if everything works out i'll land it.
Need to test

spf check fail
*    spf check soft fail
*    spf check hard fail
*    spf fails with out email address
spf check pass

gui
*    gui resizes correctly
*    objects on the gui flow with the rest of the interface

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/securestate/king-phisher/pull/152#issuecomment-247707812, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHYH4RKG4gX0radcZkYf9DQTvj4wgTMGks5qqwNTgaJpZM4J-Nl-.


Using Enum in keys instead of hardcoding paths

Desc
I suppose that enums are not interpreted in keys, so they require manually entering paths, which is not very productive. It would be ideal to have a template that can be easily accessed using a class
🤏🏻 i18n.nahui.russia(_path="main.ftl")
👍🏻 i18n.nahui.russia(_path=FTLFiles.MAIN)

I don't think it's possible, because ast module does not execute py code, so it can't get Enum values from enums.
As you can see on screenshot - ast only sees code definition, not what's inside Enum.value. I think there should be a way to:

partially execute code (Bad Idea)
look for Enums with some "special markers" (better, but requires another module to parse Enums)

If choosing second option - it requires to recognize enums in the code and be sure this enum is "special".
I will be glad to hear possible ways (or even code) to solve this.

from enum import Enum

class FTLFiles(Enum):
    MAIN = "MAIN_FIELD"

from enum import Enum
from en import FTLFiles

class I18nContext:
    def get(self, key: str | Enum, **kwargs) -> str: ...

def test(i18n: I18nContext) -> None:
    i18n.get("some-key", _path=FTLFiles.MAIN)


Fix README.md typo

Thank you very much for your work! I have found react-markdown to be very useful.

Thanks! For the PR and for the kind words :-)


Any plans on releasing new version ?

Last released version was in 2014. It will be great if can release a latest version

Yes, there are plans. Stay tuned!

Are there any updates on this? I ran into #119 and wondered if there was a solution other than to switch to a different docker gradle plugin like https://github.com/bmuschko/gradle-docker-plugin

@frvi @mattgruter Any news? :)

Is there any movement on a new release? @frvi @mattgruter

@ysksuzuki
Do you think we should not use this plugin any more?
Now we do have same error as #119

Sorry for being unresponsive of this. Fully aware of the ask and agree completely. Will make it my mission to being able to release a new version. Not exactly sure when it will happen, there are some administrative issues to fix, but hopefully during the summer months

The issue was filed more than a year ago, is this plugin still alive? Or should we consider alternative ones?

Any news ?

Is this plugin still alive?

The answer is no. Recently i migrated to palantir
https://github.com/palantir/gradle-docker
On Sat, Sep 28, 2019 at 10:46 AM Alan Alencar da Silva <
<EMAIL_ADDRESS>wrote:

Is this plugin still alive?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Transmode/gradle-docker/issues/121?email_source=notifications&email_token=AAFCAWAWYMVMNHBBY6IY353QL6J55A5CNFSM4D3UT2IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD726YGY#issuecomment-536210459,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFCAWHUGKX2LFCYTZR5OUDQL6J55ANCNFSM4D3UT2IA
.


Merge prTesting_201903251029 branch to master branch

Docs Build status updates of commit 6ef53d1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


OSM-POI: Filter results by category

This is a new query parameter introduced for all routes used to filter the results by category. The high-level and subcategories are valid values for the query parameter (for subcategories see #17).
An additional query parameter must be introduced to determine whether the results must include all or just at least one of the queried categories.

The issue is obsolete with the new canvas. This will be possible once #86 is completed.


Unable to use code from a library that has been compiled with new react jsx transform

I had a tsconfig in react-msaview that said
https://www.typescriptlang.org/docs/handbook/jsx.html
jsx:"react-jsx"
This outputted code using the "new jsx transform" from react
https://reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html
changing to jsx:"react"
worked
The error message from when it wasn't working is
Error: 'jsx' is not exported by node_modules/react/jsx-runtime.js, imported by node_modules/react-msaview/dist/components/ImportForm.js

at /home/cdiesh/src/jbrowse-plugin-msaview/node_modules/react-msaview/dist/components/ImportForm.js:12:9

not really a high priority, just notable as some libraries may output this by default more perhaps


ColorFiltered conflicts with iOS WKWebview

ColorFiltered conflicts with iOS WKWebView.
When I use ColorFiltered to change my app to full gray, everything is fine on Android, but all iOS WKWebView on iOS is no longer visible, leaving pure gray.
This problem can be reproduced very well on webview_flutter.
The following is the code I tested on webview_flutter example
void main() => runApp(ColorFiltered(colorFilter: ColorFilter.mode(Colors.grey, BlendMode.color), child: MaterialApp(home: WKWebViewExample())));

Expected results:
I expect iOS to display an application with gray filters like Android
Actual results:
In fact, WKWebView has become invisible and has become a solid color

Doctor
[✓] Flutter (Channel master, 3.0.0, on macOS 12.4 21F79 darwin-arm (Rosetta), locale zh-Hans-CN)
    • Flutter version 3.0.0 at /Users/luffy/zcy_flutter_sdk_3_0_0
    • Upstream repository https://git.cai-inc.com/mobile-framework/flutter_sdk_3_0_0.git
    • Framework revision 7d07027cb7 (3 weeks ago), 2022-11-09 14:33:48 +0800
    • Engine revision d1b9a6938a
    • Dart version 2.17.0
    • DevTools version 2.12.2
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/luffy/Library/Android/sdk
    • Platform android-31, build-tools 30.0.3
    • ANDROID_HOME = /Users/luffy/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Ultimate Edition (version 2020.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.73.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (3 available)
    •  A (mobile)     • 00008110-222123123123 • ios            • iOS 15.6.1 19G82
    • macOS (desktop) • macos                     • darwin-arm64   • macOS 12.4 21F79 darwin-arm (Rosetta)
    • Chrome (web)    • chrome                    • web-javascript • Google Chrome 107.0.5304.121

[✓] HTTP Host Availability
    • All required HTTP hosts are available

Triage report
I can reproduce this issue with Master (3.6.0-13.0.pre.26).

Code Sample
import 'package:flutter/material.dart';
import 'package:webview_flutter/webview_flutter.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatelessWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  Widget build(BuildContext context) {
    return ColorFiltered(
      colorFilter: const ColorFilter.mode(Colors.grey, BlendMode.color),
      child: Scaffold(
        appBar: AppBar(
          title: Text(title),
        ),
        body: const WebView(
          initialUrl: 'https://flutter.dev',
        ),
      ),
    );
  }
}

Screenshot

@cyanglaz is this a duplicate of https://github.com/flutter/flutter/issues/39270?

@cyanglaz is this a duplicate of #39270?

Yes, closing this as dup with https://github.com/flutter/flutter/issues/39270

Triage report

Thank you for your Triage report

+1....


Installation issues

I have Python 3.6.9 and i get the following installation issues.
(venv_hf_optimum)$ pip install "optimum[onnxruntime]==1.2.0"
Collecting optimum[onnxruntime]==1.2.0
  Cache entry deserialization failed, entry ignored
  Could not find a version that satisfies the requirement optimum[onnxruntime]==1.2.0 (from versions: 0.0.1, 0.1.0, 0.1.1, 0.1.2a0, 0.1.2, 0.1.3, 1.0.0, 1.1.0, 1.1.1)
No matching distribution found for optimum[onnxruntime]==1.2.0

(venv_hf_optimum)$ python -m pip install optimum
Collecting optimum
  Cache entry deserialization failed, entry ignored
  Downloading https://files.pythonhosted.org/packages/a5/05/4f31c8ff3b01f8d99a6352528d221210341bf4b38859e8747cfc19c5cd9d/optimum-1.1.1.tar.gz (66kB)
    100% |████████████████████████████████| 71kB 755kB/s
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-vwtwg4zk/optimum/setup.py", line 3, in <module>
        from setuptools import find_namespace_packages, setup
    ImportError: cannot import name 'find_namespace_packages'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-vwtwg4zk/optimum/

Following steps let me install optimum, without errors:
$ virtualenv -p /usr/bin/python3.7 onnx_venv
$ source onnx_venv/bin/activate
(onnx_venv) $ pip install onnx==1.10.0
(onnx_venv) $ pip install onnxruntime==1.10.0
(onnx_venv) $ python -m pip install optimum

But post installation, I see following errors:
(onnx_venv) $ python
Python 3.7.5 (default, Dec  9 2021, 17:04:37)
[GCC 8.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from transformers import AutoTokenizer, pipeline
>>> from optimum.onnxruntime import ORTModelForSeq2SeqLM
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/datadrive/shilpa/work/github/huggingface_2/onnx_venv/lib/python3.7/site-packages/optimum/onnxruntime/__init__.py", line 51, in <module>
    from .configuration import ORTConfig
  File "/datadrive/shilpa/work/github/huggingface_2/onnx_venv/lib/python3.7/site-packages/optimum/onnxruntime/configuration.py", line 20, in <module>
    from datasets import Dataset
ModuleNotFoundError: No module named 'datasets'
>>>

Looks like support for Python <3.8 was dropped in https://github.com/huggingface/optimum/commit/a31e59eddafc53f6146a4850ffe91d4cfc00c0a6, see https://github.com/huggingface/optimum/blob/main/setup.py#L75 . I have no issue with pip install optimum[onnxruntime]==1.2.0 on Python 3.8. Is this a problem to you?
For the last issue, I think it is because datasets is installed through pip install optimum[onnxruntime] but not with pip install optimum. @mfuntowicz Shoud we put datasets as a global dependency https://github.com/huggingface/optimum/blob/800e01c466917570c68812f91722df24a6ab82b0/setup.py#L15 ?

@ShilpaSangappa could you try installing it with python3.8 or greater?

but not with pip install optimum. @mfuntowicz Should we put datasets as a global dependency

datasets is currently feature specific so need to have it as a global dependency

Yes, looks like all onnxruntime, onnxruntime-gpu, intel, graphcore and habana require datasets. Only the tests don't.

Nice @ShilpaSangappa.
We are also working on adding support for Python 3.7 back

https://github.com/huggingface/optimum/pull/176#pullrequestreview-969298043


Viewport grouping doesn't work in 6.0.1

Hello. I've made a post on the ag-grid forum: https://ag-grid.com/forum/showthread.php?tid=4186
The main question is: Is the viewport grouping possible? If yes then how? There's only one paragraph about this on the Viewport page and grouping is not so easy compared to viewport sorting and filtering.

Sorry, my bad.
Instead of providing a class to `cellRenderer' field, I was providing an instance of this class.

However, in 6.0.1 the grid stays completely silent even with default group renderer. So, now the question is: "Is viewport grouping possible in 6.0.1? If yes then how?"

grouping is not possible in viewport. this is because the data is on the server, it is not available to the grid to do the grouping.
you can still use the group cell renderer, however the data won't have any groups in it, so it won't make much sense.


Update docker, packages and project version to migrate to .NET 5

closing as .NET 5 work merged in


Handle /website #24

#24
Added Handle for GET(/Website) and
AboutPage for GET(/WebsiteProvider)

cc @warpech

Removed AboutPage

Looking good! Please merge


healthcheck.sh for liveness/readiness

Per
https://mariadb.org/mariadb-server-docker-official-images-healthcheck-without-mysqladmin/, mysql isn't included in mariadb:11.0+ images. And without enforcing a tcp option there are initialization stages that may report true ahead of the actual readiness.
ref: https://mariadb.com/kb/en/using-healthcheck-sh-script/

Evidently not working correctly. Timeout is occuring.

Adding galera_online test to official image container to match the existing test
https://github.com/MariaDB/mariadb-docker/commit/1792faf9319427c365cbc1918e575e223ae55470

Adding galera_online test to official image container to match the existing test
https://github.com/MariaDB/mariadb-docker/commit/1792faf9319427c365cbc1918e575e223ae55470

Wouldn't we need to bump to this server image version for the liveness/readiness probes to work properly? What about the users using previous images of the server?

Yes, I'll work out a backward compatible way.


Introduce GH Action for linters

What can be improved
We could have GH Action commenting on problematic lines of code for every PR using golangci-lint tool.
Why
golangci service was shut down last week.

Worth looking at:

https://github.com/reviewdog/action-golangci-lint (potentially worth looking at other pieces from Reviewdog)
https://github.com/actions-contrib/golangci-lint (but it's very basic - i.e. no review comments)


Text rotation hack and white space compression

ddrawRotText will draw rotated text with color or transparent
background. Optional boolean to compress white space. Doesn't support
extra fonts or textsize.

Thanks :)


Move over KeyPoolCreator from fuzzyc2cpg

All KeyPool code is in codepropertygraph, except for a handy utility method called KeyPools.obtain. Copied this one over from fuzzyc because I need it in other frontends, also added missing test.

:dancers: @tuxology


Out of Memory error while spill is enabled

I'm trying to analyze open food facts' database, but i'm getting an out of memory exception. The /tmp/duckswap gets created and populated, but i still get the exception.
import { Database } from "duckdb-async";

async function saveDataPostgres() {
    const db = await Database.create("/tmp/tmp.db", {
        max_memory: "512MB",
        threads: "4",
        temp_directory: "/tmp/duckswap",
    });
    await db.all(`CREATE TABLE products AS
        SELECT product_name_en, product_name_it, serving_quantity, serving_size, languages, nutriments FROM read_ndjson('/tmp/openfoodfacts-products.jsonl.gz', ignore_errors=True);`);
}

saveDataPostgres()

2024-08-26 14:53:09 node:internal/process/promises:391
2024-08-26 14:53:09     triggerUncaughtException(err, true /* fromPromise */);
2024-08-26 14:53:09     ^
2024-08-26 14:53:09
2024-08-26 14:53:09 [Error: Out of Memory Error: failed to allocate data of size 256.0 MiB (271.9 MiB/488.2 MiB used)] {
2024-08-26 14:53:09   errno: -1,
2024-08-26 14:53:09   code: 'DUCKDB_NODEJS_ERROR',
2024-08-26 14:53:09   errorType: 'Out of Memory'
2024-08-26 14:53:09 }
2024-08-26 14:53:09
2024-08-26 14:53:09 Node.js v20.17.0

As a sidenote, i am able to work with the database in general. For example, i can run DESCRIBE (SELECT * FROM read_ndjson('openfoodfacts-products.jsonl.gz', ignore_errors=True))

Thank you @antonycourtney. Indeed the duckdb cli seems to be able to handle this. This means the error has to do with duckdb node, did i understand correctly?


Git unrelated histories for git >= 2.9

adresses #223, without adding too much complexity
this change assumes git >= 2.9 as default ( and adds the missing option to git.merge and git.merge.preview)
for git < 2.9 it keeps former git.merge as git.merge.legacy and git.merge.preview.legacy
the latter is added as hint in README.md

Good solution, Thank you @robbatt  👍


Implement TissueMask mask for Tile with type dispatcher

Description
Now is possible to use the TissueMask mask also on Tiles:
from histolab.masks import TissueMask
from histolab.tile import Tile

tile = Tile(pil_img, None, None)
tissue_mask = TissueMask()

result = tissue_mask(tile) # same dimensions as the tile

Types of Changes

[ ] Core
[ ] Bugfix
[x] New feature
[x] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

Fixes: #311

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

hey @ernestoarbitrio what do I do with this CodeFactor issue?
src/histolab/filters/compositions.py#L91
Unnecessary pass statement (unnecessary-pass)

I wanted that method for the sake of the documentation, can I achieve the same result in another way?


Mutating webhooks

Implement (optional) mutating webhooks to reduce the number or restarts in new deployments when configmaps and secrets already exist.
Additional changes (based on observations during testing):

fix non-404 error handle when loading children
fix RBACs
test minimal and typical production setup
fixed reconcile loop when secrets/configmaps are missing. previously (even before my refactoring) wave would retry this with exponential-backoff
watch not (yet) existing secrets/configmaps for much faster updates when they are created. with the new watcher mechanism we do not rely on ownerReference and can watch for secrets/configmaps before they exist. this allows much faster reconciles (and allows us the get rid of polling; see previous point)
allow watching secrets/configmaps in other namespaces
when using webhooks: disable scheduling when secrets/configmaps are missing; reenable scheduling once secrets/configmaps; this prevents unneccessary container restarts.

technically, we patch the deployment to use an invalid scheduler; this will result in a Pending pod (instead of ContainerCreating which will eventually timeout); we store the original scheduler in an annotation and later reverse this
this allows to install helm releases and not have pods restart 2-3 times due to wave

Everything is tested. Let me know if you want any changes.
On top of #154.

I tested this on a cluster and it works fine. Fixed two issues which I noticed during testing.

Let me get this straight: Before this commit a deployment referencing a non-exiteant CM would be stuck at ContainerCreating stuck in k8s, but wave could start watching for the CM immediately and add the hash once it exists. After this PR wave holds the Pod in Pending until the cm exists, so that it will never run without the annotation?

Multiple cases:

Before
Without Webhooks (still an option after the change)
With Webhooks

a) All required CMs/secrets exist before the deployment
b) An optional secret is created after (a)
c) At least on required CMs/secret does not exist before the deployment (typical helm install case)
a) All required CMs/secrets exist before the deployment
1 + 2 Before and Without webhooks

Deployment is created
Deployment is scheduled without annotation and pods are created
Wave edits the deployment and add the annotation
Due to Kubernetes pod lifecycle pods start up and then shutdown
A rolling update is performed by the deployment controller
All pods are recreated and restarted

With webhooks

When deployment is created the webhook adds the hash as annotation
Deployment is scheduled with annotation and pods are created
Wave reconciles the deployment and starts watching all children
No restarts occur

b) An optional secret is created

Before

Wave will reconcile a deployment every 10 minutes. If that happens the hash is updated

2 + 3: With or Without webhooks

We watch all secrets (even not-yet-existing ones) and wave reconciles instantly

c) At least on required CMs/secret does not exist before the deployment (typical helm install case)

Before

Deployment is scheduled without annotation and pods are created
Pods are stuck in ContainerCreating (due to missing CM/secret)
Wave fails to read all required children and will run into exponential backoff trying
CM is added
Pods start up with the latest CM and are basically up to date
Eventually, wave reconciles (can take quite a while due to exponential backoff) and edits the deployment to add the annotation
A rolling update is performed by the deployment controller
All pods are recreated and restarted

Without webhooks

Deployment is scheduled without annotation and pods are created
Pods are stuck in ContainerCreating (due to missing CM/secret)
Wave starts watching all children (including non-existing CMs/secrets)
CM is added
Pods start up with the latest CM and are basically up to date
Wave is instantly starting a reconcile (due to our watch) and edits the deployment to add the annotation
A rolling update is performed by the deployment controller
All pods are recreated and restarted

With webhooks

When deployment is created the webhook unsets the kubernetes (pod) scheduler and adds an annotates to store the previous scheduler
Pods are created but stay pending as there is not scheduler which can schedule them
Wave reconciles the deployment and starts watching all children (including non-existing CMs/secrets)
CM is added
Due to the watch wave starts reconciling the deployment. It notices that all children exists and adds the hash annotation. It also restores the previous scheduler
A rolling update is performed by the deployment controller
Pending pods can be instantly replaces with new pods
All are created and start up
No restarts occur

To summarize:

If you do not use webhooks wave behaves slightly better than before (when adding CMs/secrets after the deployment). However, the number of restarts is mostly the same.
With webhooks we can prevent pod restarts in common scenarios. This reduces stress on the cluster saves a lot of resources

We could decide the make the scheduler trick optional. Webhooks would still have advantages for case (a). However, for us case (c) is far more common. We often install helm charts so this is quite common.

Thank you for that detailed answer.
LGTM, but: Is the scheduler name invalid somehow reserved?  If yes, I think I would prefer to call the invalid scheduler wave.pusher.com/invalid.

Should we do a release today or do you have any more changes in the pipeline?


Restrict opportunity pages

Summary
We have some opportunity routes that accept a framework family in the
route. Where this is the case, we should check that the framework
actually supports opportunity-style views before rendering a response.
Ticket
https://trello.com/c/WruHrcBf/456

The more code we put in like this, the more we'll have to refactor when we eventually get this modelled correctly at lot level. So yeah I'd rather chat about this before we go down this route any further, preferably with Louise as well.

Sure, let's chat - although this PR was the reason for the rest of the changes so it's a shame we're blocking this now rather than sooner.
But better now than never if we think it's worth it.

Spoke to @louzoid-gds and @galund  - we'll put this in, as the work's already done. Will add a comment to the API to formalise that we think this isn't an accurate representation of how direct_award/further_competition relate to procurement (specifically it should technically be at the lot-level not the framework-level).


enableFocusRing has no effect (macOS)

Proposal
As previously suggested, enableFocusRing would remove the focus around text inputs. However, it does not seem to work on macOS.

Summary
Details seen before here:
https://github.com/microsoft/react-native-macos/issues/680
(and a few times before that)
Motivation
For some designs and use cases, a focus ring is not helpful to the user, especially when the text input is focused for long periods of time.
Basic example
<TextInput enableFocusRing={false} />

(has no effect)

I did it!
Change the file: node_modules/react-native-macos/Libraries/Text/TextInput/Singleline/RCTUITextField.m
Add one line code at last: [self setFocusRingType:NSFocusRingTypeNone]; into initWithFrame function.
It will remove all TextInput components focus ring.

Hi there! I'm trying to fix this issue. When I'm doing
<TextInput enableFocusRing={false} />

I see enableFocusRing is equal false in the
\\ node_modules/react-native-macos/Libraries/Components/TextInput/TextInput.js
...
<RCTTextInputView
        ref={_setNativeRef}
        {...props}
        blurOnSubmit={blurOnSubmit}
        dataDetectorTypes={props.dataDetectorTypes}
        mostRecentEventCount={mostRecentEventCount}
        onBlur={_onBlur}
        onChange={_onChange}
        onContentSizeChange={props.onContentSizeChange}
        onFocus={_onFocus}
        onScroll={_onScroll}
        onSelectionChange={_onSelectionChange}
        onSelectionChangeShouldSetResponder={emptyFunctionThatReturnsTrue}
        selection={selection}
        style={style}
        text={text}
        test={false}
      />
...

But when I debug props on the native side it always comes as YES even if I don't set any value for it in my props.
// /node_modules/react-native-macos/React/CxxModule/RCTNativeModule.mm

So I'm stuck because of a lack of core codebase knowledge. Can anybody suggest a place where the prop value can be overwritten?

Here is my fix
diff --git a/node_modules/react-native-macos/Libraries/Components/TextInput/TextInput.js b/node_modules/react-native-macos/Libraries/Components/TextInput/TextInput.js
index a91f66f..03dc21a 100644
--- a/node_modules/react-native-macos/Libraries/Components/TextInput/TextInput.js
+++ b/node_modules/react-native-macos/Libraries/Components/TextInput/TextInput.js
@@ -1193,6 +1193,7 @@ function InternalTextInput(props: Props): React.Node {
         accessibilityState={props.accessibilityState}
         nativeID={props.nativeID}
         testID={props.testID}
+        enableFocusRing={props.enableFocusRing}
         {...additionalTouchableProps}>
         {textInput}
       </TouchableWithoutFeedback>
diff --git a/node_modules/react-native-macos/Libraries/Text/TextInput/Singleline/RCTSinglelineTextInputView.m b/node_modules/react-native-macos/Libraries/Text/TextInput/Singleline/RCTSinglelineTextInputView.m
index 7b44e38..e886aea 100644
--- a/node_modules/react-native-macos/Libraries/Text/TextInput/Singleline/RCTSinglelineTextInputView.m
+++ b/node_modules/react-native-macos/Libraries/Text/TextInput/Singleline/RCTSinglelineTextInputView.m
@@ -87,6 +87,13 @@ - (void)setUseSecureTextField:(BOOL)useSecureTextField {
     [self replaceSubview:previousTextField with:_backedTextInputView];
   }
 }
+
+- (void)setEnableFocusRing:(BOOL)enableFocusRing {
+    [super setEnableFocusRing:enableFocusRing];
+    if ([_backedTextInputView respondsToSelector:@selector(setEnableFocusRing:)]) {
+        [_backedTextInputView setEnableFocusRing:enableFocusRing];
+    }
+}
 #endif // ]TODO(macOS GH#774)

 @end
diff --git a/node_modules/react-native-macos/Libraries/Text/TextInput/Singleline/RCTUITextField.h b/node_modules/react-native-macos/Libraries/Text/TextInput/Singleline/RCTUITextField.h
index d02fef0..62be2cb 100644
--- a/node_modules/react-native-macos/Libraries/Text/TextInput/Singleline/RCTUITextField.h
+++ b/node_modules/react-native-macos/Libraries/Text/TextInput/Singleline/RCTUITextField.h
@@ -51,6 +51,7 @@ NS_ASSUME_NONNULL_BEGIN
 @property (nonatomic, assign) NSTextAlignment textAlignment;
 @property (nonatomic, getter=isAutomaticTextReplacementEnabled) BOOL automaticTextReplacementEnabled;
 @property (nonatomic, getter=isAutomaticSpellingCorrectionEnabled) BOOL automaticSpellingCorrectionEnabled;
+@property (nonatomic, assign) BOOL enableFocusRing;
 @property (nonatomic, strong, nullable) RCTUIColor *selectionColor;
 @property (weak, nullable) id<RCTUITextFieldDelegate> delegate;
 #endif // ]TODO(macOS GH#774)
diff --git a/node_modules/react-native-macos/Libraries/Text/TextInput/Singleline/RCTUITextField.m b/node_modules/react-native-macos/Libraries/Text/TextInput/Singleline/RCTUITextField.m
index f4c2bcf..c398a63 100644
--- a/node_modules/react-native-macos/Libraries/Text/TextInput/Singleline/RCTUITextField.m
+++ b/node_modules/react-native-macos/Libraries/Text/TextInput/Singleline/RCTUITextField.m
@@ -308,6 +308,24 @@ - (void)setSecureTextEntry:(BOOL)secureTextEntry

 #endif // ]TODO(macOS GH#774)

+@synthesize enableFocusRing = _enableFocusRing;
+
+- (BOOL)enableFocusRing {
+    return _enableFocusRing;
+}
+
+- (void)setEnableFocusRing:(BOOL)enableFocusRing {
+    if (_enableFocusRing != enableFocusRing) {
+        _enableFocusRing = enableFocusRing;
+    }
+
+    if (enableFocusRing) {
+        [self setFocusRingType:NSFocusRingTypeDefault];
+    } else {
+        [self setFocusRingType:NSFocusRingTypeNone];
+    }
+}
+

 #pragma mark - Placeholder

I'll create PR later.

Btw, how can I add enableFocusRing to the TypeScript declaration?

@dimaportenko Unfortunately, react-native-macos doesn't have typescript definitions for it's extra macOS specific types yet, you'll probably just want to add a @ts-ignore style comment to ignore the typescript error :/

@Saadnajmi got it, thanks!

@dimaportenko we ported this to rn-macos 0.64, so you should be able to use it with the latest rn-macos 0.64 package that should be published later today or tomorrow!

@Saadnajmi wow! You guys are amazingly fast!


PR for Reviewing VisualScript Module(aka Submodules) Patch

Preview PR to allow for an easier view over the changes required for the addition of modules(previously submodules) to Visual Script on top of the Visual Script Refactor PR.

Can you update to the latest master? there's some CICD integration that can help.

The current blocker is just the need to rebase for some of the final changes of the refactor PR. Will upload a few builds as soon as I get that done, and I push the changes here.
But it's ready to use, in form of builds and it shouldn't crash(I have thoroughly tested it, for what it's worth).
For testing prefer to try out the various features(dragging and dropping stuff, creating nodes, node swap, etc) rather than just a complex graph, they have a higher chance of failing.
Currently known issues,

[ ] Garbage errors from calls to functions during initialisation, and context switching.
[ ] Useless multi-value returns, only the first output value port of submodule node works atm, it's easy to fix I guess I just missed it(just realized.. lol), Though not sure if we want multi-value return but that's for later discussions.
[ ] The resource save format is unstable aka I will have to change it in the next commit so assume test files won't work across different commits. I don't like some of the things that are done in it.
[ ] Scrolling doesn't change with views, which is annoying (again just realized...).
[ ] Need to remove useless comments and stuff before finalization.

Maybe issues??

[ ] The Entry and Exit nodes are hard coded to be 0th and 1st nodes of the submodule, maybe this should be changed.
[ ] Typeguessing doesn't properly work across all nodes with the submodules, I don't think it's an essential but making a note anyways.
[ ] More nodes could be allowed to be used inside the submodules depending on whether it's internal or external, again not essential but making note.

What this doesn't cover,

Overall I haven't done any optimizations for the visual script, it maybe faster or slower but that's purely a byproduct.
The calls to the submodules atm are on the inefficient side, and optimizations can be planned, but again that has not been done.
Complete clean up of Visual Script, submodules make a bunch of old features redundant but I haven't removed them as ofc that should be a separate PR. And separately discussed as well.

Btw static tests failed due to wrong format of Licenses on top of files. Will have to figure out what went wrong here.

Is this able to be squashed?

Is this able to be squashed?
Yep, I can squash it whenever needed. I found a couple more bugs yesterday, should I fix them first or squash it first?

Resolving the reviews right now.

Regarding:
Modules Panel Patch: On top of Modules PR (Finished)
PR: https://github.com/swarnimarun/godot/pull/8
Branch(WIP): https://github.com/swarnimarun/godot/tree/master-visualscript-submodule-ux-patch
Modules(previously Submodules) PR on top of the Refactor base (Bug-Hunting)
PR: https://github.com/swarnimarun/godot/pull/7
Branch: https://github.com/swarnimarun/godot/tree/master-vs-submodule
Refactor of Visual Script to increase ease of use (Finished)
PR: https://github.com/godotengine/godot/pull/39649
Branch: https://github.com/swarnimarun/godot/tree/master-visualscript-refactor
What is the merge order?
If it's not already on Godot Engine org can you make sure all the prs are on there?

@fire
Refactor of Visual Script to increase ease of use
Then this.
I merged the other one already.
Alright, will squash both.

Can you make sure this is a pr on the Godot Engine repo, so it can be reviewed?


Add documentation for solving rules conflicts

Hi!
Turns out a lot of my problems from https://github.com/zetlen/eslint-plugin-package-json/pull/3 already exist in the master branch:
Test branch with minimal rules → Travis report
→ Offending rules:
    comma-dangle: ["error", {"objects": "always-multiline"}] # +4 errors
    quotes: ["error", "single"] # +33 errors
    semi: ["error", "never"] # +1 error

Could you add documentation for how to resolve conflicts with these rules? Probably in "Usage" in the readme.

@mk-pmb Unless I'm misunderstanding, this issue has more to do with ESLint proper than with package.json specifically. If two rules conflict, it's best not to run them on the same document, and you can use override configurations to do that.
I do need to add some better docs about how to make eslint run on package.json files in the first place.
If I'm misunderstanding your concern, please reopen the issue!


[BUG] useErrorBoundary does not work with atomsWithQuery

statusAtom doesn't return the error to Error Boundary even though I've set useErrorBoundary: true :
const queryOptions = {
  queryKey: ["key"],
  queryFn: async () => {
    throw new Error("Error");
  },
  useErrorBoundary: true,
  retry: 0,
};

const [dataAtom, statusAtom] = atomsWithQuery(() => queryOptions);

function JotaiData() {
  const [data] = useAtom(statusAtom);
  return
Jotai Data
;
}

function QueryData() {
  const { data } = useQuery(queryOptions);
  return
Query Data
;
}

function App() {
  return (

      <ErrorBoundary fallbackRender={() =>
Jotai Error
}>
        <JotaiData />
      </ErrorBoundary>
      <ErrorBoundary fallbackRender={() =>
Query Error
}>
        <QueryData />
      </ErrorBoundary>

  );
}

I expected this to show:
Jotai Error
Query Error

But it shows:
Jotai Data
Query Error

Reproduction: https://github.com/ahhshm/jotai-error-boundary-bug
Why I didn't use dataAtom?
Because it requires Suspense and I don't use it. I usually don't use Error Boundaries neither, but as a good practice I use an Error Boundary to show a fallback for general errors like 500 or network error:
const queryClient = new QueryClient({
  defaultOptions: {
    queries: {
      useErrorBoundary: (error) => {
        if (error instanceof AxiosError) {
          return !error?.response?.status || error.response.status >= 500;
        }
        return false;
      },
    },
  },
});

That's why I need Error Boundary but not Suspense.

Nice catch. It's not supported. We should actually omit the type.
It might be possible to support it, but it will make the integration code complex.
(Anyone interested can give a try though.)
I think the workaround is to throw an error on our end:
const [data] = useAtom(statusAtom);
if (data.hasError) throw data.error;

something like that.


Some fixes for running Olympus on Windows

Fixed some inconsistencies in path handling for using Olympus on Win operating systems.

Hello Felix, thank you for the updates!
A minor typo:
In file: src/olympus/planners/init.py
line 79:  for dir_name in glob.glob(os.path.join(home, "planner_*")):
line 80:            	planner_name = os.path.basename(planner_name)[8:]
planner_name --> dir_name

Fixed :-)


Update README.md to add system dependencies section

Replaces autogenerated/template/default README with something based on the current plugin features.
Closes #2

Thanks this would make it indeed easier to get started with this one


Colors not showing on ipython REPL

Hi, thanks for the wonderful plugin! One issue I have is, it seems the colors for syntax do not show in the ipython REPL started by iron nvim. Colors / syntax do show, however, when one starts a terminal and call ipython from inside nvim. Would you have any recommendation for adding in this configuration? Thanks! Attached are screenshots of examples.

It seems by default it's spawning python instead.
When I spawn an ipython repl, the buffer name is term://.//20205:ipython.
So probably I'm doing a poor job trying to find the actual executable and I'm missing ipython when trying to pick the repl, falling back to python executable.

I'll investigate this further, but meanwhile, you can try doing :term ipython to see if vim actually finds it. I'm using vim's mechanisms to find the executable, so if this runs, the issue might be somewhere else.
Another alternative would be to explicitly configure iron to use ipython:
" On your init.vim

lua << EOF
require('iron').core.set_config{
  preferred = {
    python = "ipython"
  }}
EOF

You are right. It seems iron wasn't executing ipython. Adding in the config lines below in "init.vim" solves the issue.
lua << EOF
require('iron').core.set_config{
preferred = {
python = "ipython"
}}
EOF

Glad to know it was solved!
Thanks for the issue and I'm glad you're having a good experience with iron.nvim.
Please don't refrain to open another issue if you have any other problems.
Best,
Henry


use https://github.com/toqueteos/webbrowser to open browser

https://github.com/toqueteos/webbrowser

Hmm. I think we should take a different approach here. I'd prefer we back off on what built-in browser commands and add in a way for a user to specify their own command that opens a browser.

Sorry I misunderstood your suggestion. The library looks but I do think it would be nice if we also allowed the user to provide their own browser command if need be.
@kevgo why did we add the browser types? I understand adding start for windows support but don't think we needed all the others.

@wsw0108 thanks for the pointer, the library looks nice! We were entertaining the idea of building something like this on our own at some point. Good to see that such things exist!
@charlierudolph We are following what Github is doing in their hub CLI tool. The additional browser commands are necessary for edge cases. Linux for example has a much larger variety of browsers and ways to launch them, based on the installed desktop environment etc. Also, not everybody has one of the mainstream browsers installed (as Opera users can attest).
I am fine allowing the user to specify a custom command to launch browsers, if there is strong demand for such a feature. So far I am not aware of any requests in that area. If we ever do this, we should provide reasonable defaults to launch commonly known browsers on our own. The less configuration people have to do to use Git Town, the better. It should just work out of the box for almost all people.


⚠ Bofrost.at has degraded performance

In 776a756, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1214 ms

Resolved: Bofrost.at performance has improved in 21f5bda after 13 minutes.


Rethink the profile system

I'm leaving this blank for now, but the profile system needs some rethinking that needs to be done for 2.0.0.
I'll fill this task with more details later.

Change 1 – benchmark categories, tasks, and profiles:

BenchmarkTask – a task like "end-to-end streaming latency". Contains a detailed methodological description for how to carry out evaluation in the task. Multiple profiles can be used with one task.
BenchmarkProfile – a collection of datasets with some common characteristics, like the profiles we already have in RB. Each profile can be used with many tasks.
BenchmarkCategory – a grouping of compatible tasks and profiles that can be mixed-and-matched freely (many-to-many). For example, "Streaming RDF data" category would include the tasks about RDF streaming protocols and the stream-* profiles we already have.

Each of these of course would have to have its metadata files and docs pages. This will add up quickly to many, many more files to be uploaded per release (challenge 1) and larger documentation builds (challenge 2).

Challenge 1 – more files per release:
Currently, the releases of the main RB repo hit 190 files, which is pretty close to what the rate limits allow. Pushing this further would almost certainly break things horribly. I think we would have to factor out the profiles, tasks, and categories to separate repos.

Categories – one repo per category, with a "ping" mechanism for the main repo to trigger an update. Releases uploaded separately. Versioning – require having a tagged release with the same tag in the task repo, for the tagged release in the main repo to go through. This is the less messy and more navigable option, so I'd go with that. It would, however, complicate the process of making releases. We could have a CI stage in the main repo that would trigger the release in the task repo automatically, which would completely solve the issue.
Tasks – defined in the category repo.
Profiles – same.

Currenly this would split the number of needed release files in half, but also will remove the need to upload a ton of files for each change in a dataset. This should be OK, as long as we don't start having a REALLY large amount of tasks per category, like in the dozens. Then more factoring-out would be required.

Challenge 2 – documentation:

The docs structure will change a lot and to be honest, the current approach with complete decoupling of the versioning we have now would just get horribly messy. I suggest we:

Use mike for RB versioning. This would also ensure much smaller doc builds (only one version at a time) and avoid any future compat issues with the docs generator.
Partially couple dataset and RB versioning. Keep separate version numbers for datasets (that is important), but have only one tagged dataset version per RB tagged version.
Same goes for schemas. Partially couple them with RB releases.
Change the URLs to something that makes more sense and is mike-compatible. Like /{version}/something.

Unfortunately, this will change A LOT of URLs we already had in place. This should all be redirected appropriately (w3id's staff are going to hate me for my long htaccess files...):

Priority should be given to things that have semantic metadata: datasets, profiles, main metadata, schemas.
Other pages – some links may break... but try to keep the amount of breakage low.

Planning
The scope of this task was "rethinking", so I will open subtasks that will deal with implementing this in practice.

Implement the benchmark category system

Update the ontology
Create benchmark category template repo
Create benchmark category repos for streams and flat datasets
Implement the CI for SHACL-based profiles
Implement the CI for publishing benchmark categories
Implement documentation generation for tasks, profiles, and categories, upload it as a tarball with the release

Write down task descriptions

Streaming serialization throughput
Streaming deserialization throughput
End-to-end streaming throughput
End-to-end streaming latency (constrained/unconstrained)
Flat serialization throughput
Flat deserialization throughput
RDF store load time

Restructure docs for the category system

Remove profiles from the main repo
Remove legacy code from the CI worker
Add CI for pinging the main repo on changes in category repos
Partially couple dataset and RB releases
Partially couple schema and RB releases
Add a system of redirects to keep the same version IRI scheme for ontologies
Restructure doc generation and uploading in the main repo
Add mike
Update PURL redirects
Update documentation


Recycle bin doesn't open

Has this bug been raised before?

[X] I have checked "open" AND "closed" issues and this is not a duplicate

Describe your issue:
when open recycle bin it creates another this pc tab
What OS do you have?
Windows 11
What edition?
Home..
OS Version?
22H2..
OS Build?
23585.xxx
Have you tweaked your Windows 11 look?
No
If "Yes" to the above, please explain how or what tools you have used.
No response
Put here any screenshots or videos (optional)
No response

Seems like a duplicate of https://github.com/w4po/ExplorerTabUtility/issues/7


Handle unprocessed or failed queues.

Describe the bug
Right now there is no way to handle unprocessed or failed queues. The project remains in queued state forever if the queue fails to process or pick it up.

Linked #189

With the new changes in the submission process, failed job details can be accessed via the horizon dashboard, and an exception will be raised on the larabug for further debugging.


nixosTests.installed-tests.flatpak: mark broken

Description of changes

mark test broken

Recent runs on hydra all fail on 1 hour timeout:
https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.installed-tests.flatpak.x86_64-linux/all?page=1
https://hydra.nixos.org/build/269180814
Last successful run on hydra was 2020-11-26 (even then it ran for 1h 43m 17s):
https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.installed-tests.flatpak.x86_64-linux/all?page=51
https://hydra.nixos.org/build/131428960
Later runs failed with "log limit exceeded" or "timed out".
After 1 hour timeout started working all failed on that timeout.
Tried to diagnose locally why it runs so slow, but unsuccessfully.
Tests run and pass, but very slowly.
CPU, RAM and disk-size do not seem to be constrained inside VM.
On a debian VM with nothing nix related tests run only:
make check -j$(nproc)
real	24m25.798s
user	14m49.127s
sys	10m56.422s

make check -j1
real	22m43.872s
user	7m48.761s
sys	6m2.961s

(weird difference, but much less than 1.5 hours)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 334375 run on x86_64-linux 1


ci: update testing for go1.13

Please take a look.

Those declarations are still weird. I will leave it.

For clarity, the go version directive will change if we introduce language feature uses above go1.12 since this is what it's for. How this interacts with multiple version support is still something that has not been properly clarified by the Go team.

shouldn't the go version be switched to 1.13 given 1.13 is the first official version to support modules

Go1.11 does with the experiment turned on, which is how we use them. When there is no requirement for GO111MODULES, then I suppose we should update the version directive.


startrail issue after upgrade.

So the last fix with the KEOGRAM work.  Now I am seeing a new issue with generating the startrail.  I did the ./endofnight.sh and the keogram upload to my webpage and then it went to the startrail and I see the following on the telent session
<endOfNight.sh: ===== Generating Startrails
Usage: startrails [-v] -d  -e  [-b  -o  | -s]
Source directory and file extension are always required.
brightness threshold and output file are required to render startrails
Arguments:
-h : display this help, then exit
-v : increase log verbosity
-s : print image directory statistics without producing image.
-d  : directory from which to read images
-e  : filter images to just this extension
-o  : output image filename
-S x : restrict processed images to this size
-b  : ranges from 0 (black) to 1 (white). Default 0.35
A moonless sky may be as low as 0.05 while full moon can be as high as 0                                                                                .4
ex: startrails -b 0.07 -d ../images/20180208/ -e jpg -o startrails.jpg

well the startrails do not generate at all.
Thanks
Mike

Just proposed a fix.  In the meantime, change line 81 to
"${ALLSKY_HOME}/startrails" **-d** "${DATE_DIR}/" **-e** ${EXTENSION} **-b** ${BRIGHTNESS_THRESHOLD} **-o** "${UPLOAD_FILE}"
The -d, -e, -b, and -o are now required.


Install pysheds library in sandbox environment

For our work on wetlands depth analysis, we have been using a package called 'pysheds'. https://github.com/mdbartos/pysheds
It would be really great if we could include this in the sandbox environment. I have been installing it into my own user environment and haven't found any issues with it interfering with other packages.
If it matters, this is how I have been using it:
$ git clone https://github.com/mdbartos/pysheds.git
$ cd pysheds
$ pip install .

installed in the latest image


Module for sqlite import/export

Now that we have dependency installation and loading it would be helpful to use system.data.sqlite to import csv files or pipeline input into sqlite databases.
That will be useful for geocoding, automation but also importing and enriching peoplestage outputs
Requirements:

Add options to connection string, eg to set pragma off
commit every n records
create new columns if needed
allow to save columns in json instead and fix some columns of data or fixed values
maybe allow to use pwsh.exe for parallelisation as a kind of booster
use measure rows to count the input file rows
Use linuxtimestamp for time save
use convertstrings when random strings are needed
use hashing module to create a unique value over column x, y, and z
allow to read a whole table, but exclude some columns
allow to read a json column as a whole row with preview of first/random/last columns
export data into csv files or into pipeline

And preparation for EAV 😉

For now trying to work with simplysql module. Closing this for now!


Kube-system page has Services for title

Version - v1.1.0-dev1
Steps to Reproduce:

Create a kubernetes environment & add hosts
Under Namespace, select kube-system

Results: The page title says Services
Expected: Page title should be System or kube-system.  Services is confusing because it looks like we have two services pages with different services on them.

Version - 5-24
Fine

kube-systemis just the name of a special namespace that things are sometimes put into, but that we have to list separately because it doesn't come back in the list of namespaces.  What you're seeing is still Services (or Pods, or RCs) in that namespace


Added PR remplate with checklist for reviewer.

Codecov Report

Merging #38 (59e0257) into master (a3e4022) will increase coverage by 2.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   86.69%   89.16%   +2.46%
==========================================
  Files          10       10
  Lines         203      203
==========================================
+ Hits          176      181       +5
+ Misses         27       22       -5

Flag
Coverage Δ

linux
89.16% <ø> (+2.46%)
:arrow_up:

windows
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

oteapi_dlite/strategies/serialise.py
84.84% <0.00%> (ø)

oteapi_dlite/strategies/parse_excel.py
91.42% <0.00%> (+0.25%)
:arrow_up:

oteapi_dlite/strategies/filter.py
83.33% <0.00%> (+6.06%)
:arrow_up:

oteapi_dlite/strategies/parse_image.py
90.47% <0.00%> (+7.86%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3e4022...59e0257. Read the comment docs.


Swipper navigation

Check that this is really a bug

[X] I confirm

Reproduction link
https://codesandbox.io/s/v8xmc3?file=/src/App.jsx:436-832
Bug description
i copy your code from your web "https://codesandbox.io/s/v8xmc3?file=/src/App.jsx:436-832"
"swiper-navigation-react" on your codesandbox when u click once it only swipe 1 slide, but in my react app when i click once its swipe 2 slide ( im not using typescript)
Expected Behavior
1 click next slide  swipe
Actual Behavior
1 click next slide  2 swipe
Swiper version
v8.1.5
Platform/Target and Browser Versions
chrome(macOS)
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[X] I'm willing to open a PR

Issue is closed because of outdated/irrelevant/not actual/needed more information/inactivity.
If this issue is still actual and reproducible for latest version of Swiper, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue


feat: connection url includes path

What does this change?
Resolves #144
Screenshots
n/a
What can I check for bug fixes?
Please briefly describe how you can confirm the resolution of the bug.
References
https://github.com/acot-a11y/acot/issues/144

@konojunya
Released as v0.0.13-canary.0.
If this release is okay, we will release stable :rocket:


Incorrect UPPER_SNAKE_CASE hint with short constant names

The image says it all really. I'm using the current most recent version of non-nightly rust-analyzer (updated about an hour ago when I launched VS Code, not sure exactly which version it is).
I have found that the hint incorrectly shows up if and only if there are no underscores between two non-underscore characters. E.g. AMOUNT_ shows the hint (it says I should write A_M_O_U_N_T_), but AMOUNT_2 does not.

Can you try in nightly? I think it's fixed:

^ Yeah, it's fixed in nightly. This is a duplicate of #6345, fixed in #6350, which isn't part of the latest release.
If you want, you could add
"rust-analyzer.diagnostics.disabled": ["incorrect-ident-case"],

to your configuration until the next release.

Thanks, I searched the issue tracker for duplicates but I must have been searching is:open. Thanks for your support!


Fix typos across Beginners lessons

Was looking through the lessons and noticed some simple typos

This is great, thanks so much! :100:

yyyeeeaaahhhhh


Make presenter public to fire send

Some properties were missing a public accessor level like the rest.
Additionally it changes the public level to open for func textView(_ textView: UITextView, shouldChangeTextIn nsRange: NSRange, replacementText text: String) as this method is commonly used to overwrite the UITextView behavior of accepting/modifying text input.

Thanks @ChaosCoder!


breaking change of Jaro-winkler boost

First off, thanks for thanks for updating the library after a long time @dguo @maxbachmann !
However, shouldn't the latest release be a minor version release and not a patch release given the breaking change introduced by changing the Jaro Winkler boost?
That is, shouldn't the latest release be 0.11.0 and not 0.10.1?

You are probably right. I janked the release and instead republished as 0.11.0.


Frontend Development - Components and Service Setup

Set up the Angular project in the frontend directory. Create a component to display the list of temples. Implement a service to communicate with the backend API for fetching temple data. Create a component to show detailed information about a specific temple.

Branch: feature/frontend
Branch: enhancement/frontend-styling


$transition$.params() cannot assign new value

Hi,
$transition$.params() in router 1.0+ is a read only object, but in my application, i do need to rewrite this object, i.e:
if( $transition$.params().caseId){ $transition$.params().caseId = '';}
These codes will generate an error cannot assign to read only property 'caseId' of object '#<Object>', is there any way that i can rewrite the params object?
Thanks!

I'm trying to achieve something similar as well. According to Chris transition params shouldn't be mutated, but rather create a new transition with the new params. See Twitter convo: https://twitter.com/gauiis/status/897114222404014080
The problem is this is the SAME STATE. Once WITHOUT params and then afterwards WITH params.
I have a state definition and an onEnter transition hook which calls API to get dates and assigns those dates as params. I'm not mutating the params, but creating a new transition (TargetState) with the added params. The following:
{
    name: 'ready',
    url: '/ready',
    onEnter: ($transition$ : Transition) => {
        'ngInject';

        const toStateParams = $transition$.params('entering');
        if (toStateParams.dateFrom && toStateParams.dateTo)
            return true;

        return APIService.getDates()
            .then((data : any) => {
                const dateFrom = moment(data.ReadyDateFrom).format('YYYY-MM-DD');
                const dateTo = moment(data.ReadyDateTo).format('YYYY-MM-DD');
                const newDate = { dateFrom, dateTo };

                // Don't mutate state transition params object, just create a new one
                // which overrides old one.
                const newStateParams = Object.assign({}, $transition$.params(), newDate);

                // Return the new target transition
                return $uiRouter.stateService
                    .target($transition$.to(), newStateParams, $transition$.options());
            });
    }
}

I get the following in TRANSITION $trace output:
Transition #6-0: Started  -> "Transition#6( ''{} -> 'ready'{} )"
Transition #6-0: <- Rejected "Transition#6( ''{} -> 'ready'{} )", reason: Transition Rejection($id: 6 type: 2, message: The transition has been superseded by a different transition, detail: 'ready'{"#":null,"dateFrom":"2015-09-23","dateTo":"2017-03-07"})

If I use $transition$.targetState().params() this seems to work.
@abbymrs Do this. Create a new transition with $transition$.router.stateService.target() and the new param values. To read them in your controller use $transition$.targetState().params(). $transition$.params() didn't work.

Not sure what the difference is.
According to docs:
https://ui-router.github.io/ng1/docs/latest/classes/transition.transition-1.html#params

params(pathname?: string): any
Gets transition parameter values
Returns any : transition parameter values for the desired path.

Desired path. According to source to is default.
https://ui-router.github.io/ng1/docs/latest/classes/transition.transition-1.html#targetstate

targetState(): TargetState
Gets the Target State
Returns TargetState : the TargetState of this Transition

This is how you can redirect a transition in an onEnter hook:
http://plnkr.co/edit/1w9TiLQ1De4Jx9R8Zqwf?p=preview

@gaui $transition$.params() and $transition$.targetState().params() should effectively be the same values

@christopherthielen Why does it reject the transition?
Transition #0-0: Started  -> "Transition#0( ''{} -> 'shipments.ready'{} )"
Running onEnter hook for: masterPage.shipments.shipments.ready
Transition params: {"#":null}
Transition #0-0: <- Rejected "Transition#0( ''{} -> 'shipments.ready'{} )", reason: Transition Rejection($id: 0 type: 2, message: The transition has been superseded by a different transition, detail: 'shipments.ready'{"#":null,"dateFrom":"2015-09-23","dateTo":"2017-03-07"})
Transition #1-0: Started  -> "Transition#1( ''{} -> 'shipments.ready'{} )"
Running onEnter hook for: masterPage.shipments.shipments.ready
Transition params: {"#":null}
Transition #1-0: <- Rejected "Transition#1( ''{} -> 'shipments.ready'{} )", reason: Transition Rejection($id: 1 type: 2, message: The transition has been superseded by a different transition, detail: 'shipments.ready'{"#":null,"dateFrom":"2015-09-23","dateTo":"2017-03-07"})

Here's my state declaration:
{
    name: 'shipments.ready',
    url: '/ready',
    data: {
        roles: [USER_ROLES.SHIP]
    },
    onEnter: ($transition$ : Transition) => {
        'ngInject';

        // Check if we have dates in the state's params
        // If we don't, we have to fetch the dates from API
        // and redirect the transition to the state again
        // with the dates in params.
        console.log(`Running onEnter hook for: ${$transition$.$to()}`);
        console.log(`Transition params: ${JSON.stringify($transition$.params())}`);
        const params = $transition$.params();
        if (!params.dateFrom && !params.dateTo) {
            const user = UserService.getUserProfile();
            if (!user) return;

            const start = moment().startOf('isoWeek')
                .subtract(18, 'weeks').format('YYYY-MM-DD');
            const end = moment().endOf('isoWeek')
                .add(6, 'weeks').format('YYYY-MM-DD');

            return ShipmentService.companyShipments(start, end,
                    user.SelectedCompany.PartnerCode)
                .then((data : any) => {
                    const dateFrom = moment(data.ShipmentsReadyDateFrom).format('YYYY-MM-DD');
                    const dateTo = moment(data.ShipmentsReadyDateTo).format('YYYY-MM-DD');
                    const newDate = { dateFrom, dateTo };

                    // Don't mutate state transition params object, just create a new one
                    // which overrides old one.
                    const newStateParams = Object.assign({}, params, newDate);

                    // Return the new target transition
                    return $transition$.router.stateService
                        .target($transition$.to(), newStateParams);
                });
        }
    }
}

@christopherthielen  I have a parent state with a controller, then child states that alter dates in that controller (previously $stateParams). Then I'm fetching data from API based on those dates.
Now with these transitions, because the onEnter redirects the transition to the SAME state (just with params), it supersedes that transition and rejects, thus $transition$.params() in the controller is always empty.
Do you have a solution?

@christopherthielen Is the behavior different when using component vs. controller ?

@christopherthielen Here's a plunkr: http://plnkr.co/edit/f45NOF2W4YbPqeZLytfg?p=preview

Why does it reject the transition?

Because a transition redirect creates new transition ... the original one is discarded.
@gaui I think the problem is that no state has the parameter declared.  Parameter values have to be applied to a state.
 Thank you.

I think this issue is resolved.  @abbymrs please refer to the above comments on how to redirect with new parameter values

@gaui thanks a lot!


Exec tachikoma update<PHONE_NUMBER>4707

:hamster::hamster::hamster:   Strategy none
Powered by Interval Pull Request as a Service - Tachikoma.io Announcement: 2015-06-28 Updated permissions - Tachikoma.io

Coverage remained the same at 67.647% when pulling 7ff6d68e3d063d9c4f758acda339ec80aa0c1f85 on pazjacket:tachikoma/update-20170926214707 into ec251e61adc687ae0589e5283f1773ece07521c0 on sanemat:master.

Coverage remained the same at 67.647% when pulling 7ff6d68e3d063d9c4f758acda339ec80aa0c1f85 on pazjacket:tachikoma/update-20170926214707 into ec251e61adc687ae0589e5283f1773ece07521c0 on sanemat:master.

Coverage remained the same at 67.647% when pulling 7ff6d68e3d063d9c4f758acda339ec80aa0c1f85 on pazjacket:tachikoma/update-20170926214707 into ec251e61adc687ae0589e5283f1773ece07521c0 on sanemat:master.


OpenAPI Specification Generator doesn't generate Schemas - only the endpoints.

This is the sample contract:
import { initContract } from '@ts-rest/core';
import { z } from 'zod';

const c = initContract();

export const Post = z.object({
  id: z.string(),
  title: z.string(),
  body: z.string(),
});

export const contract = c.router({
  createPost: {
    method: 'POST',
    path: '/posts',
    responses: {
      201: Post,
    },
    body: z.object({
      title: z.string(),
      body: z.string(),
    }),
    summary: 'Create a post',
  },
  getPost: {
    method: 'GET',
    path: `/posts/:id`,
    responses: {
      200: Post.nullable(),
    },
    summary: 'Get a post by id',
  },
});

Then I want to create Swagger Ui from it, using the OpenAPI plugin, who should generate the OAS. Like this:
import { contract } from './contract';
import { generateOpenApi } from "@ts-rest/open-api";

const postsApiDocs = generateOpenApi(contract, {
  info: {
    title: 'Posts API',
    version: '1.0.0',
  }
})

app.use('/docs', swaggerUi.serve, swaggerUi.setup(postsApiDocs, {
  explorer: true,
  swaggerOptions: {
    validatorUrl: null
  }
}))

But then when I navigate to localhost:3333/docs, I only see the endpoints but never the Schemas, like Post for example.

Is this something that is planned to be added?

Duplicate of #366


[Candidate 4v4 Dusty Rampage v2] Middle section requires symmetrical amount and placement of Refineries and Oil Derricks

Issue Description
Middle section has 1 Refinery and 1 Oil Derrick where one is placed close the each side.
Expected behavior
Middle section has symmetrical amount and placement of Refineries and Oil Derricks

Fixed with https://github.com/xezon/GeneralsRankedMaps/commit/5b0c46a63db733c667247de3e1ed8c9a51f8b098


[Proposal] Add Query String to Named Routes Generator

Add Query String Arguments Named Routes Generator
It would be really nice to be able to append query strings to named routes, particularly when redirecting.
URL::route('docs')->withQuery('hello' => 'world');

return Redirect::route('docs')->withQuery('hello' => 'world');

Could someone provide an example of this? I can't figure out the syntax for the life of me

@joelcdoyle
I have some problem on this. some time I can get this type
// http://my.website.com/myroute/?var1=value1&var2=value2
Sometime I can only get
// http://my.website.com/myroute/var1/value1/var2/value2
I don't know why.

@JoostK, however, if only use controller action but not url as router, the feature you mentioned is doesn't work any more, So I think this feature is very necessary.
Especially in the case that we can generate a url represent a GET request. which can be processed by Http\Request class


How to Easily Obtain a List of django-cjkcms Panels?

Currently, django-cjkcms has several tabs defined for the default page model (Content, SEO, Classify, Layout and Settings).

@cached_classmethod
def get_edit_handler(cls):
    """
    Override to "lazy load" the panels overridden by subclasses.
    """
    panels = [
        ObjectList(
            cls.content_panels
            + cls.body_content_panels
            + cls.bottom_content_panels,
            heading=_("Content"),
        ),
        ObjectList(cls.classify_panels, heading=_("Classify")),
        ObjectList(cls.layout_panels, heading=_("Layout")),
        ObjectList(cls.promote_panels, heading=_("SEO"), classname="seo"),
        ObjectList(
            cls.settings_panels, heading=_("Settings"), classname="settings"
        ),
    ]

    if cls.integration_panels:
        panels.append(
            ObjectList(
                cls.integration_panels,
                heading="Integrations",
                classname="integrations",
            )
        )

    edit_handler = TabbedInterface(panels)
    return edit_handler.bind_to_model(cls)

Suppose I want to add a new tab with information about the author. I don't want to override anything. I only need to get the information about the panels used by django-cjkcms. The problem is that django-cjkcms currently does not provide a method that returns a list of panels.

Wouldn't it be more convenient to separateget_edit_handler() method into two smaller ones - get_edit_handler() and get_panels()?
def get_panels(cls):
    panels = [
        ObjectList(
            cls.content_panels
            + cls.body_content_panels
            + cls.bottom_content_panels,
            heading=_("Content"),
        ),
        ObjectList(cls.classify_panels, heading=_("Classify")),
        ObjectList(cls.layout_panels, heading=_("Layout")),
        ObjectList(cls.promote_panels, heading=_("SEO"), classname="seo"),
        ObjectList(
            cls.settings_panels, heading=_("Settings"), classname="settings"
        ),
    ]

    if cls.integration_panels:
        panels.append(
            ObjectList(
                cls.integration_panels,
                heading="Integrations",
                classname="integrations",
            )
        )

    return panels

@cached_classmethod
def get_edit_handler(cls):
    """
    Override to "lazy load" the panels overridden by subclasses.
    """

    edit_handler = TabbedInterface(cls.get_panels(cls))
    return edit_handler.bind_to_model(cls)

I assume this would make easier to extend the models?
author_panels = [
    MultiFieldPanel(
        [
            FieldPanel('author_first_name', classname='full'),
            FieldPanel('author_last_name', classname='full'),
        ],
        heading="Author",
    ),
]

@cached_classmethod
def get_edit_handler(self):

    panels = CjkcmsPage.get_panels(self)
    panels += [
        ObjectList(self.author_panels, heading=_("Author")),
    ]

    edit_handler = TabbedInterface(panels)
    return edit_handler.bind_to_model(self)

Interesting. Implemented as suggested above, with a minor syntax fix. Will upload in commit of version 0.1.6 later today.


delete linux from fail port from tomlplusplus

What does your PR fix?
Build on GNU/Linux
If you can confirm success build on other platforms I also can delete them from cmake file

LGTM now, thanks for our PR. @marshevms.

LGTM now, thanks for our PR. @marshevms.

/azp run

/azp run

I think the other platforms were disabled mostly due to the right version of meson not available in the CI machine. If anyone is interested, probably just enabling them and check if CI is able to run correctly I guess is probably enough.

I think the other platforms were disabled mostly due to the right version of meson not available in the CI machine. If anyone is interested, probably just enabling them and check if CI is able to run correctly I guess is probably enough.

@traversaro
Thanks for your kindly reminder. We will check this later.

@traversaro
Thanks for your kindly reminder. We will check this later.

Confirmed tomlplusplus can work on osx platform now. I can build it without any problems on my local.

Confirmed tomlplusplus can work on osx platform now. I can build it without any problems on my local.


Sending events directly to an ActorRef instead of the callback

Hi,
I would like to process the events using Akka actors too, but I didn't find any option to specify a receiver actor, just the callback. It's true that I can forward the event directly from inside the callback to my actors, but I was just wondering if you were considering making this a first class option.
Thanks
/ping @brainstorm

This is definitely a good idea, to offer an API that forwards events to Actors.
Thinking that one way to do it would be to have messages that take an ActorRef (e.g. RegisterSubscriber) and internally it can still be implemented with callbacks.

I just pushed 0.3.1-SNAPSHOT to Sonatype which adds an API for sending EventAtPath events directly to an ActorRef.  API looks something like this:
monitorActor ! RegisterSubscriber(event = ENTRY_MODIFY, path = filePath, subscriber = actorRef)


infixl behaves as if imported modules exposed all operators

Here's a little module that illustrates the problem:
module Test where

(~) a b = 7

infixl 4 ~

This compiles fine under 0.16-alpha. But, it errors under 0.15, with the following error:
-- INFIX OVERLAP ------------------------------------------- Test.elm

The infix declarations for (~) must be removed.

5| infixl 4 ~
   ^^^^^^^^^^
The precedence and associativity can only be set in one place, and
this information has already been set somewhere else.

It is as if Signal.(~) had been auto-imported in 0.15. Except that it wasn't -- if you try to use it without importing it, you get the expected error.
Now, there is no point fixing this specific case in 0.15, since it works fine in 0.16. However, I can trigger the problem under 0.16 as well, with these two modules:
module Test where

(>>>) a b = 7

infixl 4 >>>

module Test2 where

import Test

(>>>) a b = 7

infixl 4 >>>

Note that Test2 compiles fine under 0.16 if you remove the import Test.
Also note that it doesn't help to remove (>>>) from the exports in Test -- infixl still behaves as though it had been exported. It also doesn't help to do something like import Test exposing (otherFunc) in Test2 -- that is, it doesn't help to explicitly limit the import or the exports.
So, this does appear to be a bug with how infixl treats imports -- it appears to act as though all operators had been imported.

In case anyone saw the first version of my original comment, I had to edit it for a typo in the second code example.

This is a known behavior of infix declarations right now. I believe there can only be one for each operator in the whole project. I'll make an issue that notes this more specifically. It would require a fairly serious change to the parsing code, so I won't be able to change this behavior in the short term.


DOC: fix default for preserve_topology in simplify docstring

Update docs.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 87.118%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
2394

Relevant Lines:
2748

💛  - Coveralls

Thanks @eripe970 !


Allow URL as file input

Currently, path validation only works for local paths but will fail when providing a URL.
This should change, and public/presigned URLs should be excepted.

Fixed and currently tested on the "feature/testing" branch.


Fix potential typo

Not sure this is correct, but I'm getting an error when I using this component and passing the "reconnect" prop.

Thanks for the PR 😄

Sure thing!
Thanks for writing the component.
ᐧ
On Wed, Jul 26, 2017 at 4:32 PM, Tiaan<EMAIL_ADDRESS>wrote:

Thanks for the PR 😄
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tiaanduplessis/react-native-websocket/pull/2#issuecomment-318071251,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUIUwn1hoHmSlGpbGvW32YfL3P3m0_HNks5sR03fgaJpZM4Oj78a
.

--
[image: logo] https://www.brothertongue.com/
Fred Quintão
Chief Product Officer
+33 (0)6 59 21 7567
www.brothertongue.com
https://www.brothertongue.com/
[image: Inline image 1]


add initial default apps

This PR:

adds initial default apps to vSphere clusters

[x] Update changelog in CHANGELOG.md.

[x] Make sure values.yaml and values.schema.json are valid.

I'm just gonna merge this in as there's nothing special here


In  the admin, in the history the history_change_reason is not displayed

In the admin view, I want to use the historical_change_reason but it's always displayed change
Expected behavior
The historical_change_reason field mentionned in the database and not only change
Screenshots

and in the database

Environment (please complete the following information):

OS: Windows
Browser:  Chrome
Django Simple History Version: django-simple-history==2.1.1
Django Version: Django==1.11.10

You can add the history_change_reason to the display using the history_list_display attribute on the admin class like so:
class MyAdminClass(SimpleHistoryAdmin):
    history_list_display = ['id', 'name', 'history_change_reason']

However, we should show the history_change_reason by default with a better display name, so I will accept this issue and submit a PR.


No autocompletion? Everything is magic?

I'm trying to get started using this library, however it seems everything is magic methods/properties that PhpStorm isn't picking up.
onOpen method - which provides the WsConnection connection parameter only has send and close methods. Is there any documentation anywhere except for that small hello world example? Feel like i'm missing something obvious here lol

@skipperbent src/Socket/WebSocket.php is an object-oriented, real-world example of Ratchet WebSocket currently used in PHP Chess Server. At the moment is working fine for a few concurrent connections.


Fix organic failures

There are some crashes errors we're seeing from monitoring:

[x] Error PA3001: Internal error. The input does not contain any JSON tokens. Expected the input to start with a valid JSON token, when isFinalBlock is true. Path: $ |  | .
[x] Error PA3005: Validation error: Group control Group6's state refers to non-existent child highLbl_2
[x] Error PA3001: Internal error. Object reference not set to an instance of an object.
[x] Error PA3001: Internal error. Object reference not set to an instance of an object.
[x] Error PA3005: Validation error: Test Step Step22 references screen CheckBox,Toggle,Slider and Rating that is not present in the app

Have resolved all the telemetry issues, hence closing the bug.


portfolio

Title and Issue number

Close #<issue_no>

Checklist:

[] I have mentioned the issue number in my Pull Request.
[] I have commented my code, particularly in hard-to-understand areas
[] I have created a helpful and easy to understand README.md

Title - portfolio. Issue number - #692
Please merge it under hacktoberfest2022
Close #697

Title -portfolio. Issue number -#697
Please merge it under hacktoberfest2022
Close #697

Closing as part of Hacktoberfest 2021 and now outdated.


wasm C code can't get a pointer-value immediately, have to wait some time

source code:
#include <stdio.h>
#include <pthread.h>
#include <unistd.h>
#include <time.h>

#define MAX_NUM_THREADS 3

_Noreturn void pthread_exit(void *);

void *thread_routine(void *arg)
{
    struct timespec ts;
    int i = 0;
    pthread_t *tid = (pthread_t *)arg;
    //sleep(1);
    printf("Enter thread %08x\n", (int)*tid);
    for(i = 0; i < 10; i++)
    {
        clock_gettime(CLOCK_REALTIME, &ts);
        printf("%llds %ldns: thread %08x running i=%d\n", ts.tv_sec, ts.tv_nsec, (int)*tid, i);
        sleep(1);
    }
    pthread_exit(NULL);
    return NULL;
}

int main(int argc, char** argv)
{
    pthread_t tids[MAX_NUM_THREADS];
    setbuf(stdout, NULL);//output immediately

    for (int i = 0; i < MAX_NUM_THREADS; i++) {
        if (pthread_create(&tids[i], NULL, thread_routine, &tids[i]) != 0) {
            printf("Thread creation failed\n");
        }
    }
    printf("pthread_join\n");
    for (int i = 0; i < MAX_NUM_THREADS; i++) {
        if (pthread_join(tids[i], NULL) != 0) {
            printf("Thread join failed\n");
        }
    }

    printf("before sleep\n");
    sleep(3);
    printf("Exit\n");

    return 0;
}

build:
opt/wasi-sdk/bin/clang --target=wasm32-wasi -pthread -O3  -Wl,--allow-undefined,--no-check-features -Wl,--export=__heap_base,--export=__data_end -Wl,--export=malloc -Wl,--export=free main.c -o test.wasm

run:
$ ./iwasm --max-threads=20 --heap-size=65535 test.wasm
Enter thread 00000000                                                                    //===>thread id not get correct value
1704705385s 805131021ns: thread 00000001 running i=0
Enter thread 00000000                                                                    //===>thread id not get correct value
1704705385s 805513255ns: thread 00000002 running i=0
Enter thread 00000000                                                                    //===>thread id not get correct value
1704705385s 805665156ns: thread 00000003 running i=0
1704705386s 808273644ns: thread 00000001 running i=1
1704705386s 811101859ns: thread 00000003 running i=1
1704705386s 819979233ns: thread 00000002 running i=1
1704705387s 814727723ns: thread 00000001 running i=2
1704705387s 822503027ns: thread 00000003 running i=2
1704705387s 835201966ns: thread 00000002 running i=2
1704705388s 818195647ns: thread 00000001 running i=3
1704705388s 829340960ns: thread 00000003 running i=3
1704705388s 854175241ns: thread 00000002 running i=3
1704705389s 823698363ns: thread 00000001 running i=4
1704705389s 838319743ns: thread 00000003 running i=4
1704705389s 875401961ns: thread 00000002 running i=4
1704705390s 828702692ns: thread 00000001 running i=5
1704705390s 847107535ns: thread 00000003 running i=5
1704705390s 878263286ns: thread 00000002 running i=5
1704705391s 834154848ns: thread 00000001 running i=6
1704705391s 855453612ns: thread 00000003 running i=6
1704705391s 912887171ns: thread 00000002 running i=6
1704705392s 841931376ns: thread 00000001 running i=7
1704705392s 865333238ns: thread 00000003 running i=7
1704705392s 931382623ns: thread 00000002 running i=7
1704705393s 848815045ns: thread 00000001 running i=8
1704705393s 872374532ns: thread 00000003 running i=8
1704705393s 968670058ns: thread 00000002 running i=8
1704705394s 858598053ns: thread 00000001 running i=9
1704705394s 885874963ns: thread 00000003 running i=9
1704705394s 983285488ns: thread 00000002 running i=9
before sleep
Exit

if add a sleep(1) before print thread id, the result is correct now
pthread_join
Enter thread 00000002                                                                    //===>thread id is correct
1704705801s 280416341ns: thread 00000002 running i=0
Enter thread 00000003                                                                    //===>thread id is correct
1704705801s 281247387ns: thread 00000003 running i=0
Enter thread 00000001                                                                    //===>thread id is correct
1704705801s 292010354ns: thread 00000001 running i=0
1704705802s 280998016ns: thread 00000002 running i=1
1704705802s 282319397ns: thread 00000003 running i=1
1704705802s 294618323ns: thread 00000001 running i=1
1704705803s 281254384ns: thread 00000002 running i=2
1704705803s 287189411ns: thread 00000003 running i=2
...

so It's very strange, anybody know this?
Thanks.

WAMR generates the thread ID in the spawn-thread implementation but is wasi-libc who sets the pthread_t * here. after calling wasi_thread_spawn.
The simplest solution would be to create independent args:
#include <stdio.h>
#include <unistd.h>
#include <pthread.h>

#define MAX_NUM_THREADS 3

void *thread_routine(void *arg) {
    printf("Enter thread %d\n", *((int *)arg));
    return NULL;
}

int main(int argc, char** argv) {
    pthread_t tids[MAX_NUM_THREADS];
    int buf[MAX_NUM_THREADS];
    setbuf(stdout, NULL);

    for (int i = 0; i < MAX_NUM_THREADS; i++) {
        buf[i] = i;
        if (pthread_create(&tids[i], NULL, thread_routine, &buf[i]) != 0) {
            printf("Thread creation failed\n");
        }
    }
    printf("pthread_join\n");
    for (int i = 0; i < MAX_NUM_THREADS; i++) {
        if (pthread_join(tids[i], NULL) != 0) {
            printf("Thread join failed\n");
        }
    }
    printf("Exit\n");
    return 0;
}

Output:
Enter thread 0
Enter thread 1
Enter thread 2
pthread_join
Exit

hello @tonibofarull , Thanks for your reply and solution
share another test result:
when I set iwasm main thread higher priority than default user thread,  It works fine.
so I think maybe have some synchronization issue in wasm, what do you think?
Thanks.

in the wasi-libc: int __pthread_create
ret = __wasi_thread_spawn((void *) args); //will let os task switch to run new thread
//but after that value changed:
*res = new;
so if target thread priority lower than current thread, new thread will not start immediately, the  *res = new; will first execute
so currently this dependent on priority except have some api just create thread but not start, after some work then enable it running

Interesting!
While we find a better solution, if you want to keep passing tids in args, you can synchronize the threads yourself at the WASM app level. I'm studying right now the internals of wasi-threads.

in fact, there is no requirement about this, just a interesting finding to your team, if it can make the wasm improve stability, I will very happy.


Improve installation docs

Description of problem
After completing the Cartographer installation process (using kind) and the quick method (single file), some observations arise:

Black background for code snippets is not specially helpful
Installation of cert-manager assumes user knows what kapp is, how to install and, especially, why to install that package using kapp
From this text:

ps.: although we recommend using kapp as provided in the instructions you’ll see here, its use can be replaced by kubectl apply.

What's the advantage of using kapp if, at the end, users could achieve basically the same using kubectl apply?

A consolidated list of prerequisites is needed
Some formatting improvements

@davidmirror-ops

Black background for code snippets is not specially helpful

Black is common for shell entered commands and their results. We use this as an accepted default.
Light backgrounds are used for code (yaml really) in our docs
Which ones specifically caused you trouble, can you go into detail?

Installation of cert-manager assumes user knows what kapp is, how to install and, especially, why to install that package using kapp
From this text:

@emmjohnson  suggests we just point to certmanager's install docs, I concur.

Some formatting improvements
So much has changed, I can't tell if there are any remaining. @davidmirror-ops do you have any specifics noted?

Some formatting improvements
So much has changed, I can't tell if there are any remaining. @davidmirror-ops do you have any specifics noted?

Agreed, so much has changed and so far I would only add:

Turn 'Prerequisites; into a numbered list
Number the steps on each installation method, just to make it easier for users following the steps

@davidmirror-ops

Black background for code snippets is not specially helpful

Black is common for shell entered commands and their results. We use this as an accepted default. Light backgrounds are used for code (yaml really) in our docs
Which ones specifically caused you trouble, can you go into detail?

I had some previous experience with the Knative docs where code snippets have a different color schema and somehow it makes it easier (at least for me) to read it.  It's weird as I agree black background is almost universal, but maybe it has to do with the contrast or font size (none of which can be tweaked with Markdown I believe)

It's weird as I agree black background is almost universal, but maybe it has to do with the contrast or font size (none of which can be tweaked with Markdown I believe)

@emmjohnson has done some work on install in #478 so let's move discussion of install into that PR (perhaps you'd like to review the PR @davidmirror-ops?)
Opened #487 for the contrast issue.
Closing


Insight widgets not displaying correctly on dashboard

Azure Data Studio Version: insider
OS Version: All

Steps to Reproduce:

Connect to a non-Azure server and open Manage dashboard

Expected: Widgets render correctly
Actual: Widgets don't render.

Does this issue occur when all extensions are disabled?: Yes/No

FYI @kburtram I'm also seeing this now after I cleared the previous settings I had and made some new connections. I'll try to dig into it to see if I can figure out what's going on

Fixed with https://github.com/microsoft/azuredatastudio/pull/20037


Reaction stereo mapped to non-bonded atoms causes exception

fixes #3155
The fix is to not mapped stereo in these cases.

Now, the real question is:  Is this a borked reaction that we should raise an exception for?

Are you sure that this isn't a fix related to #3147?

It sure is.  Let me fix and recheck in.. Btw there is a seg fault in the standardizer now, I can't see how this is related but I'll check.

Moved it to https://github.com/rdkit/rdkit/pull/3196


Enhancement: Make M.I.L.F. beatdrop cam zooming a modchart

Please check for duplicates or similar issues before creating this issue.
What is your suggestion, and why should it be implemented?


i cant key the code correctly

hi sir, my timezone is gmt+8, i modify the timezone and pass the param to $timeslice, but i keep keyin the code and keep cant match the code with my phone, anything i did it wrong? thank you.
createSecret();
echo "Secret is: ".$secret."\n\n";

$qrCodeUrl = $ga->getQRCodeGoogleUrl('Blog', $secret);
echo "Google Charts URL for the QR-Code: ".$qrCodeUrl."\n\n";

$oneCode = $ga->getCode($secret,$unixtimestamp);
echo "Checking Code '$oneCode' and Secret '$secret':\n\n";

$code=$_POST['txtCode'];
echo $code."";

$checkResult = $ga->verifyCode($secret, $code,30,$unixtimestamp);    // 2 = 2*30sec clock tolerance
if ($checkResult) {
    echo 'OK';
} else {
    echo 'FAILED';
}

?>

I guess the problem is that you give the current timestamp to the methods getCode() and verifyCode(). You need to give it the "time slice", which is a timestamp devided by 30... Maybe it works then?