Big memory leak when spawning too many Area2Ds

Tested versions

Reproducible in: v4.3.stable.mono.official [77dcf97d8]

System information
Windows 10 - Vulkan(Foward+) - Nvidea 1070
Issue description
There seems to be a big memory leak when spawning too many Area2D's too fast.
This leak also happens when using JoltPhysics2D.
And maybe some other problems.
Here it is working normally, spawning moving bullets.
Because the FPS drops, it spawns slower and doesn't leak memory.
298 MB static memory after 1000 Area2D spawned.
And 132k collision pairs
https://github.com/user-attachments/assets/cfc1854f-aad0-4e1f-a869-765d8605d369

And here it is leaking memory.
When I try to spawn non-moving bullets.
It spawns them very fast. But the memory goes up very fast.
906 MB static memory after 1000 Area2D spawned.
And 500k collision pairs
https://github.com/user-attachments/assets/8a5a6e4e-4087-443e-8502-776735114c51
I've also tested the same with Node2D and Character2D but they work fine.
This only happens with Area2Ds

PS: Its strange that the FPS in the MRP tanks to 4 FPS so fast with only 500+ nodes too.
I was getting a stable 40 frames with 2k bullets on my other project.
I thought maybe it was because I was spawning them there with coroutines, but the performance on the MRP stays at 4 FPS even after it finishes spawning the 1k bullets.
So something else might be wrong.

As a side-note, when the memory-leak example finishes spawning my computer starts screeching.
Which I'm guessing is my old HDD asking for help.
This also rarely happens here when windows starts indexing or reading tons of small files.
Not sure this is related but a fun tidbit.
Steps to reproduce
MRP:

Run the MRP project
Look at the monitor tab static memory

Expected: NOT to increase so much. Expected around 200-300 MBs.
Result: static memory 900+Mbs
Non-MRP:

Spawn 5 Area2D's each frame

Expected: Normal static memory increase.
Result: static memory increase very fast.
Minimal reproduction project (MRP)
MRP_memory-leak-physics.zip

I tested this project in a custom build of fafc07335bdecacd96b548c4119fbe1f47ee5866 and found the same memory usage of just over 900 MiB. Spawning moving nodes brought the framerate down to 1 FPS and the engine reported lower memory usage of 253 MiB, though strangely limiting the FPS through the project settings to the same 1 FPS still consumes the full 907 MiB. The terminal output does not report a memory leak.
I tried spawning non-moving nodes and changing them to moving halfway through and at the end the engine reported a peak of 435 MiB which dropped to 378 as the moving nodes stopped overlapping with the stationary ones. What was strange was that the moment I toggled to spawning moving nodes memory usaged dropped a little and then climbed at the slower pace untill peaking, then dropping again as I mentioned. Spawning all nodes on the same frame used a little more memory, at 930 MiB.
I'm on Ubuntu 24.10 using the iGPU of an R5 7600.

There is no memory leak because memory reduces with the collision pairs as the nodes move.
When nodes overlap, they are all monitored for collision resulting in an increase in collision pairings and memory use. 1000 * 1000 = 1000000 potential collisions and 500000 pairs. They don't move so the physics server doesn't have to do anything once they spawn, keeping performance stable.
There is less overlap when they move, but the physics server still has thousands of pairs to process per frame and performance drops.
If the bullets do not need to collide, you can disable the collision mask. Collision pairings will drop to zero.

Okay, maybe its not really a memory leak then, but the memory usage is strange no?
Note that this seems worse with Area2D.
I've also tested with CharacterBody2D and RigidBody2D.
Rigibody2D stays are 75Mb, but its a bit hard to test because they can't stay in place colliding, so not much collision pairs
But CharacterBody2D works differently:
Moving bodies: 132k pairs  | 132Mb memory
In-place bodies: 500k pairs | 279Mb memory
Growth of 2.1x
While Area2D is:
Moving bodies: 132k pairs  |  298 MB
In-place bodies: 500k pairs | 906 MB
Growth of 3.04x
In-place bodies using 1200 objects:
CharacterBody2D: 719k | 392 Mb
Area2D:                 719k, | 1.33 Gb
I guess its not that different when you look at the growth between them(2x vs 3x).

I got scared by the memory usage. I didn't know there would be such a big difference.
My understanding was that objects would 'sleep' if they were not moving for a while and would not actively check for collisions to save performance. (but I think that's just for rigidbodies, so Area2D and CharacterBody2D must be always checking collisions)


Update Java: 124. BT Maximum Path Sum

File(s) Modified: 124-Binary-Tree-Maximum-Path-Sum.java
Language(s) Used: Java.
Submission URL: _https://leetcode.com/submissions/detail/775415545/_

Thanks, @MaratKhakim!


Added cell counter and helper functions file

Added a cell counter script. The idea is:
Based on a GEO accession, retrieves the SERIES matrix file. Download that file locally, decompress it, and then call a helper function to read the matrices in the folder and return a cell number that will be printed.
Formats supported so far:

10x MEX format (mtx, barcode and genes)

Is this related to a dataset? a ticket?

This is kind-of related to all datasets
Related to the project cell count ticket in the operations board  (https://app.zenhub.com/workspaces/operations-5fa2d8f2df78bb000f7fb2b5/issues/ebi-ait/hca-ebi-wrangler-central/295)
I realised sometimes it's impossible to get the cell count from the paper.
I was getting the cell count by downloading the matrix and doing several operations, based on the format of the files, and then realised this is not the first time I do it
So I decided to write a script to
1 - Download the matrix files (we don't have any script for that)
2 - Count the cells so we can get an estimated cell count
I can create a ticket for this


FIX: don't always overwrite blit to True

When saving an animation to use with HTML(anim.to_html5_video()) in
ipython notebooks it seems necessary to disable blit manually.

@jaeilepp can you check? thx

Thanks @octomike

np, there is likely more to come :smile:


Windows下编译显示缺少头文件

在Windows下使用改写的命令编译src\data-channel：
clang++ main.cpp libwebrtc.a -I ../../third_party/webrtc/  -I ../../third_party/webrtc/third_party/abseil-cpp/  -DWEBRTC_POSIX   -lpthread -ldl
报错：
In file included from main.cpp:8:
In file included from ../../third_party/webrtc\api/create_peerconnection_factory.h:19:
In file included from ../../third_party/webrtc\api/peer_connection_interface.h:82:
In file included from ../../third_party/webrtc\api/async_dns_resolver.h:18:
In file included from ../../third_party/webrtc\rtc_base/socket_address.h:20:
../../third_party/webrtc\rtc_base/ip_address.h:15:10: fatal error: 'arpa/inet.h' file not found

静态库webrtc.lib已放到src\data-channel\，webrtc项目的头文件已提取到third_party\webrtc\。
请教一下还需要做什么才能顺利编译？

In Windows you should use -DWEBRTC_WIN instead of -DWEBRTC_POSIX in your build command.


Allow on the fly conversion of cyclists into pedestrians

One of the more unrealistic parts (and seemingly easy to fix) of current gridlocks is that cyclists are also stuck.
In reality cyclists would overtake cars (by driving in space between lanes) or by switching to walking.
Please close if that is actually hard to implement, but would it be possible to add dynamic conversion between cycling and walking (only in case of a traffic jam attracting cyclists, with sidewalk available without rerouting)
I propose to add event added on cyclist stopping, triggering in "N minutes. If cyclist moved more than 30 meters then do nothing. Otherwise convert cyclist to pedestrian and walk section along planned route where sidewalk is also present and later convert back to cyclist.
It would reduce one of unrealistic parts of AB Street gridlocks and maybe make them a bit more rare.
(During testing of new traffic model yesterday I ended with gridlock made out of cyclists alone, what was a complete nonsense)

This would be pretty tough, but it'd be a huge win for realism. I'll think about it. But first I want to prioritize fixes in #114 -- they might remedy the problems you're seeing here, and others.


[BUG] using mending on the vile sword breaks all soul shards for a world

I just ran into the weirdest bug. I was killing some golden cows (a mob from another mod) with my vile sword that I enchanted with soul stealer 5, sharpness 5 and unbreaking 3. Everything was work fine I was getting seven souls per kill, souls were being added, the tier went when the numbers reached a certain point...But then I noticed my sword was at half durability so I hoed into creative, spawned me an anvil and a mending enchantment book. After I added mending to the sword I went back to killing the cows and I repaired my vile sword with the experience that I gained...... but then I noticed that soul shard wasn't filling up.... so I grabbed another one out of creative, enchanted it with soul stealer 5, sharpness 5 and unbreaking 3... still no souls being added....I tried my other soul shard with golden cow souls on it (I was using a tier 2 soul shard in a soul cage spawner from this mod as I realized that would be faster than using two vanilla spawners with torcherino's on them) still no dice. I even spawned a completely new unbound soul shard... still no dice....I even left the world and got back in...still no dice

So, wait, you were killing entities spawned by the Soul Cage? Do you have countCageBornForShard enabled in the config?

wait what

there's a config for that

doh

By default, you cannot build up a shard's soul count by using entities spawned by a cage.

thanks for pointing that out


Update vulnerable gems

The vulnerability message is below. In order to upgrade activejob, I had to upgrade Rails to version <IP_ADDRESS>, which touched quite a few other gems.
Name: activejob
Version: 5.1.4
Advisory: CVE-2018-16476
Criticality: Unknown
URL: https://groups.google.com/forum/#!topic/rubyonrails-security/FL4dSdzr2zw
Title: Broken Access Control vulnerability in Active Job
Solution: upgrade to ~> 4.2.11, ~> <IP_ADDRESS>, ~> <IP_ADDRESS>, >= <IP_ADDRESS>

Name: loofah
Version: 2.1.1
Advisory: CVE-2018-16468
Criticality: Unknown
URL: https://github.com/flavorjones/loofah/issues/154
Title: Loofah XSS Vulnerability
Solution: upgrade to >= 2.2.3

Name: loofah
Version: 2.1.1
Advisory: CVE-2018-8048
Criticality: Unknown
URL: https://github.com/flavorjones/loofah/issues/144
Title: Loofah XSS Vulnerability
Solution: upgrade to >= 2.2.1

Name: nokogiri
Version: 1.8.1
Advisory: CVE-2018-14404
Criticality: Unknown
URL: https://github.com/sparklemotion/nokogiri/issues/1785
Title: Nokogiri gem, via libxml2, is affected by multiple vulnerabilities
Solution: upgrade to >= 1.8.5

Name: nokogiri
Version: 1.8.1
Advisory: CVE-2017-15412
Criticality: Unknown
URL: https://github.com/sparklemotion/nokogiri/issues/1714
Title: Nokogiri gem, via libxml, is affected by DoS vulnerabilities
Solution: upgrade to >= 1.8.2

Name: nokogiri
Version: 1.8.1
Advisory: CVE-2018-8048
Criticality: Unknown
URL: https://github.com/sparklemotion/nokogiri/pull/1746
Title: Revert libxml2 behavior in Nokogiri gem that could cause XSS
Solution: upgrade to >= 1.8.3

Name: rack
Version: 2.0.3
Advisory: CVE-2018-16471
Criticality: Unknown
URL: https://groups.google.com/forum/#!topic/ruby-security-ann/NAalCee8n6o
Title: Possible XSS vulnerability in Rack
Solution: upgrade to ~> 1.6.11, >= 2.0.6

Name: rails-html-sanitizer
Version: 1.0.3
Advisory: CVE-2018-3741
Criticality: Unknown
URL: https://groups.google.com/d/msg/rubyonrails-security/tP7W3kLc5u4/uDy2Br7xBgAJ
Title: XSS vulnerability in rails-html-sanitizer
Solution: upgrade to >= 1.0.4

Name: sprockets
Version: 3.7.1
Advisory: CVE-2018-3760
Criticality: Unknown
URL: https://groups.google.com/forum/#!topic/ruby-security-ann/2S9Pwz2i16k
Title: Path Traversal in Sprockets
Solution: upgrade to < 3.0.0, >= 2.12.5, < 4.0.0, >= 3.7.2, >= 4.0.0.beta8

I force-pushed this to remove the changes from #71 (removing capybara-webkit), so that this PR can be merged on its own and get us back to a green CI build.


shipping ppapi headers and components

Can you change this PR to merge to master branch?

@zcbenz fixed here https://github.com/atom/libchromiumcontent/pull/106


Steam/Electric Farmer does not detect tree growth from Oh The Biomes We've Gone

The Steam and Electric Farmer does not detect trees which grow from the Oh The Biomes We've Gone mod, even though vanilla trees and Integrated Dynamics menril trees are detected.
I reported this issue here: https://github.com/Potion-Studios/Oh-The-Biomes-Weve-Gone/issues/171 saying it may be because the TreeGrowthEvent this mod is listening for isn't being fired. The author of that mod wrote that the event would have to be fired and linked a screenshot of some code highlighting BlockGrowFeatureEvent.
However, trees from that mod, when they grow, still aren't cut down by this mod's farmer multiblocks.

I made a comment on the other issue on my findings. Not sure if there is a good way to add this support

I could make a conditional mixin that would inject at the end of TreeFromStructureNBTFeature#place from OTYG and capture the blocks placed. Might be worth doing

Added in Swedz/tesseract-neoforge#49


Holograms disappearing

Hello,
After deleting Holographic Displays beacuse of the same issue i got this plugin and I am still running into the same issues.. Holograms in spawn disappear after i leave the server and reconnect until i do /holo reload.
Hologram version: 2.12.
Server version: 1.15.2.
Server jar: Paper.

Can confirm, I get the same problem. Paper 443 for 1.8.8.
Here are my plugins:
ChunkLoader.jar
DiscordSRV-Build-1.18.4.jar
EasyBackupPlugin-3.3.2.jar
EnhancedBalTop-v<IP_ADDRESS>.jar
EssentialsX-<IP_ADDRESS>.jar
EssentialsXProtect-<IP_ADDRESS>.jar
EssentialsXSpawn-<IP_ADDRESS>.jar
Factions.jar
Holograms-2.12.jar
LuckPerms-Bukkit-5.0.72.jar
PlaceholderAPI-2.10.4.jar
PlayerVaultsX.jar
TabList.jar
Vault.jar
WildTP.jar
WorldBorder.jar
worldedit-bukkit-6.1.9.jar
worldguard-6.2.jar

yep, same issue
/holo reload seems to fix it though

I've set a button in my spawn so players can reload holograms themselves when they are disappearing. Would appreciate a plugin fix though

@preppy420 @editid1 @Elric02 could you guys please post a list of plugins used on the server? This seems to be an issue caused with conflicting plugin or some weird edge case that causes the holograms to disappear. I've done some basic testing by leaving myself logged in and wasn't able to get any holograms to disappear on a server with no plugins (even overnight).

AdvancedAchievements, BetonQuest, BossShopPro, ChestShop, Citizens, CoreProtect, CrateReloaded, CrazyAuctions, CrazyEnchantments, Essentials, EssentialsChat, EssentialsSpawn, Holograms, Jobs, LibsDisguises, LuckPerms, Multiverse-Core, MyCommand, MythicMobs, NametagEdit, NBTAPI, PlaceholderAPI, ProtocolLib, TabList, UltraCosmetics, Vault, VoxelSniper, WorldEdit, WorldGuard. All in the latest version.
Using PaperSpigot 1.15.2 build 205

Hey,
I have noticed a pattern to why the holograms are disappearing.
Whenever my friend, who is in a certain kingdom group (Using KingdomCraft) comes into the spawn world.

@LifelessNerd could you paste a full list of plugins you use?

Citizins, Coreprotect-2.14.4, Dynmap-3.0-beta-5-spigot, EssentialsX, EssentialsXAntiBuild, EssentialsXProtect, EssentialsXSpawn, EssentialsXXMPP all version <IP_ADDRESS>, Holograms-2.12, KingdomcraftFree, Luckperms-bukkit-5.0.72, MultiIventory, OldCombatMechanics, SimplePortals, Vault, VoxelSniper-5.172.0-SNAPSHOT, WorldGuardExtraFlags, multiworld, worldedit-bukkit-6.1.9, worldguard-bukkit-6.2.2
Using Spigot 1.12.2

Have you been able to recreate the issue?

Sorry to bump this thread, but having the same issue? any ideas?

Sorry to bump this thread, but having the same issue? any ideas?

At first I just had a loop command doing /holo reload, but that gave a lot of spam.
I switched over to Holographic Displays, they even have a tool to convert the currect holograms you have (I found out after I did this manually -_-)

I have the same problem, I have a Kit PvP server and when someone dies the holograms disappear until they leave and rejoin or I do /holo reload

@ItzMeLilG I would advise to switch to Holographic Displays since this issue has been open for more than 2 years...

I found the solution!!! It's because of the world folder! I changed the world completely and it works now...


Fix the README.md file

Ano.js
A discord.js clone but more simple and have more features.

Example usage:
const Ano = require('ano.js');

Example Format:
const Bot = new Ano.Bot({
  token: TOKEN,
  prefix: PREFIX,
  owners: ['Owner_ID','Owner_ID_2']
});

Note: The format is not official we may change it eventually.
Commmand Format (not official)

client.command({
  name: "hi",
  aliases: ['hello'],    // if none put nothing
  run {
  message.send('Hi ${message.author.username}')
  }
});

Note: basically none of this is official till otherwise

Fixed a spelling error and added 2 semicolons.

On it


Ability to control how product URLs are displayed/chosen

User Story

As a user, I want to have full control over how a product URL looks, so that I can use the CIF connector on an existing product site without changing anything from an SEO perspective, or from a marketing perspective.

Description & Motivation

Whoever is using the CIF library would like full control over how product pages respond, or category pages. This motivation came from a client using the CIF library and was unable to do this - workarounds were implemented for this client, but I thought it would be much cleaner if a UrlDelegator could be used to choose which UrlProvider to use. This way, custom client-specific code can be used to implement the UrlProvider class and the UrlDelegator will be able to use theirs or the default provider based on priority.

Deliverables

Make a UrlDelegator class so that custom versions of the UrlProvider can be implemented for client-specific product-name handling. The documentation would need to reflect that people can implement their own UrlProvider methods. The shouldProcess method of the UrlProvider will determine if the custom version should be used on a case-by-case basis.

Acceptance Criteria

A user of the CIF library should be able to have product pages be whatever page they want. If they have a custom/existing page template type, they should not have to modify the URL structure to make it work with CIF. An implementor can help write custom logic to define what the product-key is for any of their custom pages, which would then pull in the product on the page with the customer's existing URL structure.

Verification Steps

Implement your own version of the UrlProvider and set the ranking to the min value so it is used first. Validate that product info is coming into your page(s) and test out with categories as well, according to your implementation.

We did some major improvements in this area
a) since https://github.com/adobe/aem-core-cif-components/pull/738 customers can implement custom ProductUrlFromats and CategoryUrlFormats using the typical product attributes for that (url_key, url_path, sku, etc.)
b) since https://github.com/adobe/aem-core-cif-components/pull/792 and with a recent version of the Commerce AddOn it is now also possible to select the product/category url format per store (using the context aware CIF Configuration)
This in combination with Sling Mappings allows for the flexibility necessary for your described use case.


Grubs able to push around other grubs

Title says it - Grubs are able to semi-easily push around other grubs using their movement

https://github.com/apetavern/grubs/commit/f8ea7db411c9bbe1f32372bb007ce2b3cd76f277


docs(authentication): fix typo

Fix minor typo on the authentication's document.
Pull request checklist
Please check if your PR fulfills the following requirements:

[x] The changes have been tested successfully.
[ ] A changeset has been created (npm run changeset).

@jonz94 Thank you!


fix: Bump openapi version

Embarrassingly, I just made the same mistake I mentioned to avoid this morning 🤦
It's good that at least the CI failed since we cannot release the same version twice

To prove #341 is useful, I'll mention this issue whenever we forgot to bump the API version 😂. And eventually, maybe someone will add a linter to the CI.


fix: use registry argument on publish

The registry argument was not being used when calling cargo publish, causing it to try to publish to crates.io even when a different registry was passed.

woops, I'm sorry 😅 hopefully this didn't cause any trouble.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/39186

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/39459

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/39524

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/50782

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/50785


Callback not called if the back button is pressed

The cancel callback function is not called if the user presses the back button when the dialog is shown.

I have pulled a request to fix this #47

Fixed this issue at 1.0.3


Ktrofit

If use firebase, probably won't have a chance to use it

If don't use KMP, probably don't need it.


mdcTracer fails with NoopTracer instance

Description
In case client application doesn't have properly configured tracer and uses NoopTracer instance it will fail during incoming http call with 500 error.
Expected Behavior
Incoming http call should pass FlowFilter and reach application business logic.
Actual Behavior

Following exception thrown:
java.lang.NoSuchMethodError: io.opentracing.ScopeManager.active()Lio/opentracing/Scope;
	at io.opentracing.contrib.api.tracer.APIExtensionsTracer.activeSpan(APIExtensionsTracer.java:65)
	at io.opentracing.util.GlobalTracer.activeSpan(GlobalTracer.java:209)
	at io.opentracing.contrib.api.tracer.APIExtensionsTracer.activeSpan(APIExtensionsTracer.java:63)
	at org.zalando.tracer.DefaultFlow.activeSpan(DefaultFlow.java:75)
	at org.zalando.tracer.DefaultFlow.readFrom(DefaultFlow.java:23)
	at org.zalando.tracer.servlet.FlowFilter.doFilter(FlowFilter.java:25)
	at org.zalando.tracer.servlet.HttpFilter.doFilter(HttpFilter.java:28)

Possible Fix

Steps to Reproduce

The problem resides in utilising APIExtensionsTracer which is incompatible with OpenTracing-api 0.33.0.
Can be exposed by following test:
package org.zalando.tracer;

import io.opentracing.contrib.api.tracer.APIExtensionsTracer;
import io.opentracing.noop.NoopTracerFactory;
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertThrows;

class DefaultFlowNoopTracerTest {
    private final APIExtensionsTracer tracer = new APIExtensionsTracer(NoopTracerFactory.create());
    private final Flow unit = Flow.create(tracer);

    @Test
    void shouldThrowNoActiveSpanFoundException() {
        assertThrows(IllegalStateException.class, unit::currentId);
    }
}

Context

Your Environment

Version used: 2.0.0-RC.2
Link to your project:

Created fix as opentracing-contrib/java-api-extensions#21
If PR above will be accepted we'll need to update dependency to the new released version.

It's probably about time to roll our own version of java-api-extensions. The library ecosystem around opentracing is brittle enough as it is already. We should go with as little external dependencies as possible until the breaking API changes on OpenTracing settle down.


Where is gtest/gtest.h?

I am struggling. Where is gtest.h?
Update: ok it looks like I had to include Google's testing.
BTW it's great that someone is doing a C++ equivalent of this stuff from c#, thanks.

Hi @lawabider ,
thanks for your interest.
Yes, gtest.h is from Google test.
You can install Google Test using the vcpkg. (https://github.com/microsoft/vcpkg)
vcpkg install googletest
vcpkg install googletest:x64-windows


fix: Fix for amount not shown

What

Ensure that 0-amounts are shown for requirements

How

We validated using the amount as boolean value, however 0 is false. I added ternary checks instead of OR assignments to validate if value was a number, otherwise we use undefined.

Fixes CORE-1075

Will merge when #897 has landed in develop


Fs detail overflows it's container

The fs detail panel overflows it's container when the screen is narrow

After:


refactor: move shared functions to ccbr_tools and import them here

Changes
Import reusable helper functions from ccbr_tools
Issues
resolves #31
PR Checklist
(~Strikethrough~ any points that are not applicable.)

[x] This comment contains a description of changes with justifications, with any relevant issues linked.
[x] Write unit tests for any new features, bug fixes, or other code changes.
~[ ] Update docs if there are any API changes.~
~[ ] If a new nextflow process is implemented, define the process container and stub.~
~[ ] Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/~

is there a tacit dependency here on ccbrpipeliner/7 which will load the latest ccbr_tools which will have the tools needed?

yes, this design means we assume our biowulf users will access the pipeline CLIs by loading ccbrpipeliner/7+
if it is installed via pip (ie if someone wanted to install outside of biowulf), ccbr_tools will also be installed because it's a dependency (https://github.com/CCBR/CCBR_NextflowTemplate/pull/32/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R36)


Make it so the RazorDirectiveCompletionProvider doesn't load extra as…

…semblies in C#.

Added a layer of indirection to allow for proper Lazy loading of Razor and future async completion specific assemblies.

Should we have a work item to undo this once modern completion lands?

Have one already in VSTS that everyone always gets bugged about 😄.


feat(e2e): #178 add tests for app and about page

replaced  excessive 'return's by short arrow function shape

Thank you!

Question:
Do you think it will be better to get e2e run with headless chrome?
Thanks
On Tue, May 1, 2018 at 10:44 PM, Tomas Trajan<EMAIL_ADDRESS>wrote:

Merged #182
https://github.com/tomastrajan/angular-ngrx-material-starter/pull/182.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tomastrajan/angular-ngrx-material-starter/pull/182#event-1604022899,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABRmHqnJFVVXUtqnYMjVfTWLgSxcU88Rks5tuLscgaJpZM4TuUsa
.

--
http://gs500coder.blogspot.com

Also there is a great video from this year ngconf about testing

You also might be interested in small refactoring on top of your tests I just pushed to the master. It's basically additional shorthand arrow functions, a little bit of naming adjustments and simplifications.


WIP: Implement selective layer compilation

Work to equip compileTTF and compileOTF with a layerName kwarg and compileInterpolatableTTFs with a layerNames kwarg to only compile selected layers as a sparse master.
Currently, no features are compiled for these sparse masters from layers. What do we need? I'm thinking of e.g. moving anchors and having the mark-to-mark attachment work as expected -- or is this not necessary?

This does not reverse contour directions when compiling just the layer and inplace == True. Investigate later.

thank @madig for starting to work on this!

This does not reverse contour directions when compiling just the layer and inplace == True. Investigate later.

So the problem here is that cu2qu has this feature whereby it stores a boolean flag in the global font.lib after it has converted the outlines to quadratic which is meant to remember the UFO curve type and avoid to try re-converting the curves if the same UFO is passed to cu2qu a second time.
However, in the case of the non-default layers which hold the sparse, intermediate masters, and which need to be converted compatibly at the same time as the other default layers, this rememberCurveType option makes it so that cu2qu skips converting the non-default layer after the default one has been converted and thus the curveType flag is set.
We probably need to change cu2qu to store this curveType not in the global font's lib.plist, but in each specific layerinfo.plist's lib element, because really the curve type is not a font property but a layer property.

or technically speaking, it's a property of the single glyph...
I'm also thinking we could deprecate and eventually drop this rememberCurveType feature altogether.. Re-running cu2qu a second time on the same UFO containing quadratic curves (and reverseDirection is False) should be quite fast already and won't change the data, it simply reads and writes them back as they are.

i'm merging this PR into a branch on upstream repo so we can keep working on it together


Support for applying Request Authentication to specific routes

Currently if we apply RequestAuthentication (JWT) to Ingress, it applies to all routes because we match with any prefix
However, for Ingress it is desirable to scope it to certain routes so that only services that need JWT validation gets that feature.
The request is to support this requirement rule in Istio
https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/http/jwt_authn/v3/config.proto#extensions-filters-http-jwt-authn-v3-requirementrule
Alternative:
Envoy filter to apply this rule but this seems generic enough to add it to JWTRules.

@yangminzhu WDYT?

@yangminzhu Thank you. I did not know that JWT filter is a no-op if JWT does not exist.  It may be fine then
Will wait for @howardjohn's reply though

I did only look at authz. Does envoy support jwt at the route level even?
On Sat, Oct 30, 2021, 2:58 AM Rama Chavali @.***> wrote:

@yangminzhu https://github.com/yangminzhu Thank you. I did not know
that JWT filter is a no-op if JWT does not exist. It may be fine then
Will wait for @howardjohn https://github.com/howardjohn's reply though
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/35698#issuecomment-955183564, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXNZ3TJ3WAASJATPGE3UJO6T3ANCNFSM5GNLJ5PA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Oh nevermind I see there is a match.
IMO duplicating the matching in the filter is not a great design for this particular use case and will lead to mismatches, complexity, etc. Better would be to bind to a route which already has (much richer) matching. Authz does allow this

IMO duplicating the matching in the filter is not a great design for this particular use case and will lead to mismatches, complexity, etc. Better would be to bind to a route which already has (much richer) matching. Authz does allow this.

Are you suggesting some thing similar to this https://github.com/istio/api/blob/master/security/v1beta1/authorization_policy.proto#L323?

Ok. That  makes sense to attached JWT rules to VS

Ok. That makes sense to attached JWT rules to VS

+1


Rename template → view and rename template_tag → template

There's an SVG element called view so that's this plan out the window.

Aren't the SVG elements scoped with the block argument syntax anyway?

No, you can define a component that's natively an SVG.


Can't deactivate standard scratch org matching rules

Describe the bug
On a scratch there are 3 default matching rules. But you cannot deactivate them using the sfpowerkit:org:matchingrule:deactivate command.
To Reproduce
Steps to reproduce the behavior:

sfdx sfpowerkit:org:matchingrule:deactivate -n Account

Expected behavior
Expected that the default Account matching rule is deactivated. But it isn't.

@thvd  Do you have any duplicate rules on Account?  this should be deactivated before deactivating matching rules

The duplicate rules are all deactivated:

The Account matching rule is active:

And when i run:
sfdx sfpowerkit:org:matchingrule:deactivate -n Account

The result is:
Polling for Retrieval Status
Retrieved Matching Rule  for Object : Account
Preparing Deactivation
ERROR running sfpowerkit:org:matchingrule:deactivate:  Cannot set property 'ruleStatus' of undefined

Standard Rules cannot be deactivated using the command, as the metadata api do not support. Will fix the readme and error in the next release
The approach is to use custom duplicate rule and custom matching rules, deploy all of them as inactive, then utilize the commands  to activate once they are deployed

@azlam-abdulsalam good to know, so there is no way to disable the standard rules with the API. That's disappointing.
Thanks for the quick responses anyway.

@manisfdcsfdx  Can you investigate whether this behaviour changed in v47? and add the details to the readme

@thvd looks like a candidate for puppetteer , will enhance this command to support this in subsequent release

It would be good to turn off all those standard rules as it's not supposed to be used. It's more like a guided template to show the user how to configure it.


New version: SetProg v0.0.3

Registering package: SetProg
Repository: https://github.com/blegat/SetProg.jl
Created by: @blegat
Version: v0.0.3
Commit: 9dad51d82850c2070baceda445735a9d0d3783f6
Reviewed by: @blegat
Reference: https://github.com/blegat/SetProg.jl/commit/9dad51d82850c2070baceda445735a9d0d3783f6#commitcomment-34952667

TagBot tag


電撃文庫 FIGHTING CLIMAX IGNITION [PCSG00758]

App summary

App name: 電撃文庫 FIGHTING CLIMAX IGNITION
App serial: PCSG00758
App version: 1.00

Vita3K summary

Version: v1.6.0-3
Build number: ?
Commit hash: https://github.com/vita3k/vita3k/commit/[commit]
CPU backend:               Dynamic
GPU backend:  Vulkan

Test environment summary

Tested by: Mostazaniikkkk
OS: Android 11
Phone: Poco x3 Pro

Issues
Some maps don't load correctly
Screenshots

Recommended labels

Playable

you have forget log and add version of build

Several graphical issues on Vulkan on PC.


ARTEMIS-5110 add ability to identify retired IDs in log annotations

The broker uses unique IDs for logging statements. As logging changes over time we need a way to "retire" these IDs (e.g. when certain logging statements are no longer needed) to ensure they are not used
This commit does the following:

Removes all the logging methods which are no longer used and "retires" the corresponding ID (i.e. adds them to the retiredIDs list for that LogBundle).
Updates the validation for IDs that have been retired or are in active use including a new suggestion about a valid ID to use when an invalid ID is found.
Fixes all the regular expressions in all the various uses of @LogBundle to ensure there are no overlaps to prevent duplicates between bundles.

I don't think we should be suggesting the lowest/first available non-retired ID when someone reuses a current/retired ID. Those are more likely to be IDs that have been used before and removed, but dont yet have a retiredID value set to prevent their reuse.  I also don't think its worth adding 2 dependencies (both seemingly long-inactive) to the build to help do that.
We aren't short of new IDs in most cases, so I think recommending the next highest non-retired value makes more sense. I put together a change that drops the new deps and just takes the highest active ID found for the bundle, and keeps incrementing it until one is found that isnt retired, which is then also checked against the regex to verify not exceeding the limit. I also integrated the new check into the existing verification that was verifying ID reuse already.
I added some checking that the retiredIDs values match the regex, to help catch mistakes when defining them, and enforced the values given are sorted, both for readability reasons  later and impl reasons (and fixed the very few that were not already...using the sorted-for-you version included in the exception message).
I also added the class to the start of the exception messages above to make it clearer where the problem being reported is. (I saw you had started printing the class to stdout all the time, I wasn't sure if that was deliberate or just a leftover not-yet-made-debug).
https://github.com/gemmellr/activemq-artemis/tree/jbertram-ARTEMIS-5110_rebased has your changes rebased, and another commit (https://github.com/gemmellr/activemq-artemis/commit/87385e76b9d24dd7f8ab829a4a57b486de6f6586 currently) with difference around the above. (May still be bugs, I am pushing it early for comment hehe)
What do you think ?

@gemmellr, that looks good to me. Did you also add some new retired IDs?

@jbertram I looked at both commits on Robbie's branch and it looks good to me...

Did you also add some new retired IDs?

@jbertram No, I just rearranged 3 of the retiredIDs in ActiveMQServerLogger to satisfy the new sorted-values check that I added. Note the 3 IDs which are 'added in the middle' are the same 3 IDs being removed from the end (though in a slightly different order, as the 3 were not sorted to start with).

I pushed the changes to Justin's branch just as they were, updating the PR but keeping the complete set of changes.
I'll squash them all into the first commit and push to main to close the PR.


Fixed running of tests in parallel in some assemblies

In some of the test assemblies the xunit.runner.json file was missing. This is required as we need to specify to xunit to run the tests serial. In other words, disable parallelization.

awesome


Fix attachment uri in trx if same attachment filename is same

Update the attachment filename with targetFilename while moving all the attachments to one directory for trx report.

Fixes: https://github.com/Microsoft/vstest/issues/1626

@dotnet-bot test this please.

@dotnet-bot test this please


Fixed a bug that makes tSNE output change every time even with the same random seed

👍 for this change, this would be very useful to have reproducible results when using TSNE. I've tested that on some data and it seems to do the trick.

Cherrypicked via https://github.com/DmitryUlyanov/Multicore-TSNE/commit/fd760979bebbb4e15389b4060c2b77ed60aa5eae as this PR has more diff than it should.


how to insert a image

how to insert a image

I have the same problem

@gera2ld

It works if the image is on the web, but it is not shown if you do not add some text to allow it to have some space, as show in this issue.
If the image is from a local file, than it doesn't show at all. Trying to do so and checking the VSCode Developer Tools console I have found this error message:

Does it give you guys any clues?
Cheers.

is this planned to be fixed, or is there an workaround?

Let me check this weekend.

Do we have any update? Has been using alot recently when i found this extension, now got i am heavily need to include some images!

any updates?

same problem!

Same problem. (Remote works; local does not.)


Add slateJS content rendering

Resolves #37

This PR

Adds HTML elements corresponding to SlateJS API output
Adds highlight.js syntax highlighting for code blocks
Adds appropriate styles for each element

What changed


101 duplicate symbols for architecture x86_64

Linker command failed with exit code 1

Also for me, when I change Header Search Path to $(SRCROOT)/../node_modules/react-native-onesignal/ios in recursive
See my stack overflow post that describes well the problem : http://stackoverflow.com/questions/42626531/react-native-onesignal-duplicate-error-with-pods

In your package.json, copy here the line concerning react-native-onesignal please

I'm having a similar problem:

23 duplicate symbols for architecture arm64

Package.json:

"react-native-onesignal": "^3.0.3",

Please, delete your npm-modules folder.
Then, change in your package.json to put "react-native-onesignal": "3.0.2",
Run npm install
And try to build again on Xcode. Let me know if it changes something !

Followed your advice, and now I'm getting:

Undefined symbols for architecture arm64:
"OBJC_CLASS$_RCTOneSignal", referenced from:
objc-class-ref in AppDelegate.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Actually, I think I forgot to run react-native link react-native-onesignal after reinstalling. After linking, I'm getting a ton of errors:

@Pampounet
Here is my package.json
"react": "15.4.2",
"react-native": "0.40.0",
"react-native-android-location-services-dialog-box": "^1.2.0",
"react-native-checkbox": "^1.1.0",
"react-native-code-push": "^1.17.0-beta",
"react-native-country-picker-modal": "^0.2.10",
"react-native-drawer": "^2.3.0",
"react-native-easy-grid": "0.1.8",
"react-native-fbsdk": "^0.5.0",
"react-native-keyboard-aware-scroll-view": "0.2.7",
"react-native-maps": "^0.13.0",
"react-native-modalbox": "^1.3.9",
"react-native-onesignal": "^3.0.3".

For both two, are you using CocoaPods ?
Cause actually, the initial error occurres when you are using Cocoapods, since for the 3.0.3 version of react-native-onesignal, they have stopped using cocoa pods.
You were getting the duplicate error because you had cocoapods version of onesignal + 3.0.3 of react native onesignal that now integrates same Sdk  files (they are duplicated).
Either you stay on version 3.0.3 without cocoapods, or you go to 3.0.2 using cocoapods
For me, understanding this allowed me to solve the same problems...

@superquest what you can do is install oneSignal using pods then obtain oneSignal framework file . Then delete pods and manually link the onesignal framework to your project .along with libonesignal . that won't show any issue . I have done in the same way .But havn't tested it for notification in mobile .Once i will do that .I will update here .

Tried downgrading to 3.0.2, and now seeing same as @superquest, screenshot.
Going to try @GeekRishabh latest now...

Got it working! Here's what we did:

Removed react-native-onesignal from dependencies
Deleted the apps node_modules folder.
Installed and ran cocoapods-deintegrate on the project. (This may not apply to all; however in our case, the only reason we had pods in this project was for onesignal).
Ran through the installation process again, making sure to update any imports to < (we were updating from around v0.20 of rn to 0.42 😅  )
Cleaned project, quit/relaunched xCode.
????
PROFIT!!!

@Pampounet - your solution worked for me.
I have other pods installed, so here's what I did to remove OneSignal pod cleanly:

sudo gem install cocoapods-deintegrate
sudo gem install cocoapods-clean
from ios directory inside project, run pod deintegrate
pod clean
delete the line pod 'OneSignal' in your podfile
run pod install
assuming you have followed all of the other installation and config directions in the latest version of OneSignal (3.0.3 for me), then running build again should work and you will have kept your other existing pods (slightly different situation then @breadadams)

As @Pampounet noted going to 3.0.3 requires you to remove OneSignal from Cocoapods as well as follow the new iOS setup instructions.
https://github.com/geektimecoil/react-native-onesignal#ios-installation
@GeekRishabh @avishayil I think we can close this issue now.

The Running Example project part of README.md does not mention this part, wasted some hours on it. Would it help to also get the documentation on how to run it updated?

Hi there,
I am experiencing this same problem
ld: 233 duplicate symbols for architecture x86_64
I was compiling with 3.0.2 and moved on to the last 3.2.3, getting rid of cocoapods as explained in this thread. I double checked every pod related file and they are all gone. Basically i get the following for several files
duplicate symbol _OBJC_METACLASS_$_OSRequestSubmitNotificationOpened in:     /[...]/ios/OneSignal.framework/OneSignal(Requests.o)     /[...]/Library/Developer/Xcode/DerivedData/[AppName]-fmxhrnwitpecshtmi/Build/Products/Debug-iphonesimulator/libRCTOneSignal.a(Requests.o)
I also tried to remove everything from the Library/... but the error keeps showing up.
Thanx in advance for any help

@grafosecondo this does mean that somehow the native OneSignal SDK is getting included in your project. I would suggest running pod deintegrate, then follow the current setup guide to install OneSignal through npm (after linking you should see an RCTOneSignal Xcode subproject).


Add support for floats

See #7

I’ve removed support for float in new
float support is just for addition, subtraction, multiplication, and division.


apply prettier cleanup to latest changes

PR checklist

[ ] Addresses an existing issue: fixes #0000
[ ] New feature, bugfix, or enhancement

[ ] Includes tests

[x] Documentation update

Overview of change:
Prettier formatting for just about everything was added in #623:
https://github.com/Microsoft/tslint-microsoft-contrib/blob/f70d669310b3c225a1f1c3281bb493a1023caaab/package.json#L63
I was working on a contribution and wanted to ensure my changes fit this formatting, but running npm run prettier also formatted these files unrelated to my changes:
$ git rev-parse master
f70d669310b3c225a1f1c3281bb493a1023caaab
$ npm run prettier

><EMAIL_ADDRESS>prettier /Users/shiftkey/src/tslint-microsoft-contrib
> prettier --write "**/*.{js,ts,tsx,json,md}"

.github/ISSUE_TEMPLATE.md 380ms
...
tslint.json 17ms
$ git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   Release-Notes.md
	modified:   Releases.md
	modified:   TSLint-and-the-Microsoft-Security-Development-Lifecycle.md
	modified:   react-a11y-img-has-alt-Rule.md
	modified:   react-a11y-role-has-required-props-Rule.md
	modified:   react-a11y-role-supports-aria-props-Rule.md
	modified:   react-a11y-tabindex-no-positive-Rule.md
	modified:   react-ally-role-Rule.md
	modified:   react-no-dangerous-html-Rule.md

no changes added to commit (use "git add" and/or "git commit -a")

Feel free to clarify if some of these files (like Releases.md and Release-Notes.md) should not go through Prettier's formatting.

@shiftkey these are Wiki files that were migrated to main repo.
There is PR #818 that moves them to docs/ folder and Prettier formatter was applied in this commit
I will check if it will be possible to merge #818, so it won't produce a lot of unrelated changes for you.

@IllusionMH ok cool, looks like #818 is a superset of this change. I can workaround this in the meantime for my other work.

@shiftkey for your PR you can format everything, rollback these files and use git commit --no-verify skip Pretties formatting on pre-commit hook.

@IllusionMH I think the husky hooks are smart enough to only lint staged changes before committing - I haven't had to --no-verify just yet 👍

@shiftkey you are totally right - only staged files are affected!
I was under wrong impression after moving these files to another folder and avoiding formating.


Feature Request - More controls over Bars or User Roles

This is a big request related to the User Roles and Bar Access Controls.
Can there be more access controls related to bars than just a simple on/off switch for users? Currently, the user role "General" is capable of adding cocktails and ingredients in ALL BARS they can see. This seems bad. It would be nice if Bars themselves had user-specific restrictions. For example, Allow an option for users to make changes to their own bars but not to other people's bars. There really is no user role to accomplish this.....

The Guest role cannot change anything, only view
The General role can add contents across everyone's bars.

I'm not sure what the best way to implement this is......maybe modifying user roles or maybe making more granular privilege controls for each bar created....and the bar creator gets to decide on those permissions.
Or at a bare minimum can there be a user role that only allows the user to only modify contents of Bars which they created. Because currently the user roles are not very useful to me if the General User can change contents of all the bars on the BarAssistant instance....and the Guest can only View.
Thanks! Great update! I love this app man!
Edit: I just realized that the General role cannot Edit/Delete cocktails or ingredients they do not own but they can ADD cocktails or ingredients into anyone's bar they can see. This is what I'd like more control over

I don't think I see a problem with this, is there any specific problem you are trying to solve?

If you want a user to add his own cocktails/ingredients to a bar you assign a General role to him.
If you want a user to only view things in a bar you assign a Guest role to him.

My Problem:
In my instance I have my Bar I created. I want to be the only one who can Add Cocktails/Ingredients to my bar.
In my instance I also have created various user accounts for different people. I want each of them to be able to do the following:

View My Bar. Not modify it in anyway
Create their own Bar and manage (add/remove/edit) their own Cocktails and Ingredients.

I don't see a way to do this currently. Currently, the additional accounts I created for users are capable of adding cocktails/ingredients into MY Bar. They are not able to EDIT anything in my bar but they can create cocktails/ingredients in it.

Oh crap! I understand now. The user roles are PER BAR. Sorry, I did not grasp that until now. Let me ponder on this a while.

Ok. This can be closed without any action. I misunderstood how user roles operated. I can accomplish my goals with the current setup.


Another release?

I have put in a load more improvements to the conformal tools since our last release and we have squashed a couple of significant bus since our last release:
https://github.com/pygae/clifford/commit/835740b3e50553baf3e16c6d0dbf515ea87686ff
https://github.com/pygae/clifford/issues/67
So maybe time to put out another?

Maybe we should move to a regular release cycle?

up to you.  6mo?


Consistency in M2M_Doc threshold

The default doc_m2m_threshold	is 0.05 according to the global options, but it seems to be 0.01 in the newer experiment. In the network, 0.05 is prefilled and thus the degrees do not match within the motifs and the network. See snipit from one of the urineNGS016 motifs (loss of NH3)

adding an experiment option and setting the m2m_document threshold to 0.05 indeed changes the numbers:

So it seems like 0.01 is somehow the default value, whereas 0.05 is mentioned. I think we can go with 0.05.

Sounds like it's not picking up the global option. I can check that.

Ok, fixed. The problem was that if it couldn't find the option for the particular experiment it just randomly picked the first one it could find (maybe from another experiment). It now explicitly finds the global one. Note that this could cause crashes if the global options aren't set...


TokenStream implementation for host-macro communication

Related to #1132 .
Wait for this to be merged on Cairo side

how does this relate to https://github.com/starkware-libs/cairo/pull/6388?

how does this relate to starkware-libs/cairo#6388?

I don't think the #6388 directly relates to this PR. The changes there only change the Syntax Tree for macros, so it won't affect this certain PR. Yes, it might change something when it comes to Scarb macro host, but i'm not so sure about that. Even if it does, it's better to adjust to cairo changes in a separate change, as this is not related

Replaced with #1699


make JSX ending bracket on a new line

Is it possible to format JSX like this:
<div
    className="test"
    style={{
        height: "100px"
    }}
>                               <----- on a new line
    Something
</div>

At the moment I get
<div
     className="test"
     style={{
                height: "100px"                    <----- too much indentation
            }}>                                  <--- ">" symbol not on a new line
  Something
</div>

I tried countless options already without result, so I ask here. I use the esformatter-jsx plugin.
Many thanks.

Moved: https://github.com/royriojas/esformatter-jsx/issues/67


docs: Fix simple typo, depencies -> dependencies

There is a small typo in src/js/Ink/Namespace/ClassModule/1/lib.js, src/js/Ink/Namespace/StaticModule/1/lib.js.
Should read dependencies rather than depencies.

Thank @timgates42, I'll merge right away.


onclick validation method not only for checkboxes and radio buttons ?

Issue with instant validation.
When form field is active autosaved values are proposed (default for every form). If we choose autosaved value, by clicking on it, form field is not validated instantly, in other words error message is not removed despite value passes validation.
For example, we have a field "name" and rule of minimum 3 characters.
When we typed one character in the field, and switched to another field, field did not pass instant validation and error is populated.
If we return to this field and type "Bob" error is removed instantly (seems like http://jqueryvalidation.org/validate#onkeyup method handles this).
But if we return to the field "name" and instead of typing erase everything and select "Bob" from proposed autosaved values, error is not removed, even if we switch to another form field (maybe http://jqueryvalidation.org/validate#onfocusout method should hadle this but it does not).
This makes confusion in user experience, because user sees that validation is instant and errors are removed immediately after field passes validation. But in this case user selects correct value from autosaved items but error is not removed (field is not validated instantly).
There are workarounds, e.g. disable autosave for form or disable instant validation (set to false all methods except onsubmit). But how to resolve this with active instant validation?

Which version of this plugin do you use ?
Can you test if the master version works as expected or it behaves the same as your issue ? (just to make sure if the issue is fixed somehow or still there and should be fixed)

Downloading the latest changes
The unreleased development files can be obtained by:
Downloading or Forking this repository
Setup the build
Run grunt to create the built files in the "dist" directory

I suppose i need to build master version. Alas, this over my expertise. I use prepared version which i downloaded from site (jquery-validation-1.14.0.zip).

Here is the master version after the build (I put it on https://gist.github.com):
https://gist.githubusercontent.com/Arkni/40956198a7449d88fe0e/raw/4468022a0c984432b10284d946c26309424365eb/jquery.validate.js

https://gist.githubusercontent.com/Arkni/40956198a7449d88fe0e/raw/4468022a0c984432b10284d946c26309424365eb/jquery.validate.js

Tried this version. Result same as described in 1st post.

I just followed your steps and tested them using the demo bundled withing this plugin and it's working as expected.
Here is a screen-cast of the result:

Maybe I'm missing something.

You are right. I get exactly same behavior. My point is that after selecting "Bob" with mouse, error remains until there is a click outside a field. This i find misleading. I think error should dissapear exactly after "Bob" is selected (no need to click outside field).

I think error should dissapear exactly after "Bob" is selected (no need to click outside field).

I get it now. We can achieve that using the input event (>IE9), but jquery-validate only use blur, focus and keyup events. Maybe it's time to use this event.
//Cc @staabm

Thanks for examining this issue! Up to you to decide, whether it is worth it, especially taking into account development of new event.

I think this can be closed now, as the OP already fixed his issue using the work around mentioned in https://github.com/jzaefferer/jquery-validation/pull/1733#issuecomment-204176028


[EventHubs] Event Processor's global exception handler

Summary
The current EventProcessor implementation swallows up unhandled exceptions instead of reporting to the user about them.
https://github.com/Azure/azure-sdk-for-net/blob/de8e950ecf5d04e29f2383511f63a096724f2522/sdk/eventhub/Azure.Messaging.EventHubs/src/Processor/EventProcessor.cs#L246-L249
The same issue can be found in PartitionPump as well. The pieces of code that need attention are marked with a TODO comment, so they can be easily found.
Goal
Implement an exception callback so users can handle thrown exceptions by themselves.

Closing due to the recent reworking of the design; dedicated work items will be opened for the new design.


Stop Training

Hi,
How are you stopping the training? I'm pressing ESC and Python identifies the keyboard interrupt.
However, sometimes it does not create a replay buffer.
Wondering if I'm doing anything wrong here.
Thank you,
João

Cltrl C is Interrupt for me. Safety of the replay buffer can't be guaranteed unless the code ends gracefully. Stopping the program by interrupt should only be done to prevent the code from executing. You should lower the number of training steps if you want a smaller run.

Thank you Matthew.
Matthew @.***> escreveu no dia quinta, 1/04/2021 à(s)
03:01:

Cltrl C is Interrupt for me. Safety of the replay buffer can't be
guaranteed unless the code ends gracefully. Stopping the program by
interrupt should only be done to prevent the code from executing. You
should lower the number of training steps if you want a smaller run.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/werner-duvaud/muzero-general/issues/145#issuecomment-811582781,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACPAYRII3SBO2HY3BLEK5CTTGPHXVANCNFSM42E2HGTQ
.


Exception: Failed to generate

Hi, can you provide a detailed deployment tutorial? I may be having trouble with steps 2 and 3. How do I use the
2. export GENSIM_ROOT=$(pwd)
and 3. export OPENAI_KEY=YOUR KEY   ?
The following error occurs when running python gensim/run_simulation.py disp=True prompt_folder=vanilla_task_generation_prompt_simple :
Exception: Failed to generate
task creation time 0.002
task creation failure => count as syntax exceptions.
vanilla_task_generation_prompt_simple Trial 10 SYNTAX_PASS_RATE: 0.0% RUNTIME_PASS_RATE: 0.0% ENV_PASS_RATE: 0.0%
=========================================================
vanilla_task_generation_prompt_simple | TOTAL SYNTAX_PASS_RATE: 0.0% RUNTIME_PASS_RATE: 0.0% ENV_PASS_RATE: 0.0% DIVERSITE SCORE: 0.000
Model Folder:  output/output_stats/vanilla_task_generation_prompt_simple_27_05_2024_21:29:16
Total 0 New Tasks: []
Added 0  Tasks: []

Thanks for your interest. I might need more context to help debug this. I think it could be due to either (1) failure of writing syntax-correct code (2) some other errors.


Fix a simple thing that just annoys me. (dont have to merge this is my preference)

Yeah, so the roblox cookie in the .env is under ROBLOX_COOKIE and the token is under token=.
This PR just makes it so DISCORD_TOKEN replaces token in the .env to match the grammar of the cookie.
(this also requires a update of the docs, but they are not open source so I cannot do that)
no pressure in accepting! this is just something that i feel should be changed.

You should write in the docs to add --force to npm install when first installing, or npm will error.


Support config functions with trailing comma parameters

For config functions with large number of arguments, it is often necessary to format the arguments over multilines. In this case, it is common (and enforced by some code formatters, like black) that the last argument has a trailing comma. Minimal example:
#!/usr/bin/env python3

import sacred

ex = sacred.Experiment("test")

@ex.config
def default():
    x = 1
    y = 1

@ex.config
def f(
    x,
    y,
):
    z = x + y

@ex.automain
def main():
    pass

Running this in master sacred produces:
$ python3 test.py print_config
Traceback (most recent call last):
  File "test.py", line 12, in <module>
    @ex.config
  File "/home/adam/dev/sacred/sacred/ingredient.py", line 162, in config
    self.configurations.append(ConfigScope(function))
  File "/home/adam/dev/sacred/sacred/config/config_scope.py", line 25, in __init__
    self._body_code = get_function_body_code(func)
  File "/home/adam/dev/sacred/sacred/config/config_scope.py", line 146, in get_function_body_code
    func_body, line_offset = get_function_body(func)
  File "/home/adam/dev/sacred/sacred/config/config_scope.py", line 104, in get_function_body
    assert defs
AssertionError

With the changes in the PR, this produces expected behavior:
python3 test.py print_config
INFO - test - Running command 'print_config'
INFO - test - Started
Configuration (modified, added, typechanged, doc):
  seed = 505103377                   # the random seed for this experiment
  x = 1
  y = 1
  z = 2
INFO - test - Completed after 0:00:00

I assume that the failing checks are not caused by your changes


[SPARK-6865][SQL] DataFrame column names should be treated as string literals

For example, "a.b" should match a column named a.b.

Test build #30221 has started for   PR 5505 at commit 36f63a4.

Test build #30221 has finished for   PR 5505 at commit 36f63a4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30221/
Test FAILed.

Test build #30227 has started for   PR 5505 at commit a5f6983.

Test build #30227 has finished for   PR 5505 at commit a5f6983.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30227/
Test PASSed.

I discussed with michael offline -- given this would break self-join, we've decided to treat [dot] (i.e. ".") as a special case.

As https://github.com/apache/spark/pull/5638 handled self join correctly, should we reopen this PR?

That one actually doesn't handle most self join cases, since very often in self joins you join on different keys.


Retrieve the exteriorDefaultUrl into an image entity

Is your feature request related to a problem? Please describe.
No.
Describe the solution you'd like
I wish for the exteriorDefaultUrl and optionally the interiorDefaultUrl fetched into the new image entity in HA 2023.7. It would be nice to be able to illustrate my HA car dashboard with an image of my own car as it was configured/built.
Describe alternatives you've considered
Manually upload a photo of my car into Home Assistant

I will take a look at this tomorrow!

Great idea/feature! 👍

Working with version v1.7.6. Please test!

I can confirm it is working for my car, a XC60 Rechargee 2023. Thanks!

Let us see what you can make of this image. Would be useful for the community!

Here is an example dashboard for my car. The connection status is inoperable due to the current issue with retrieving it.
https://github.com/Dielee/volvo2mqtt/assets/16253150/a5f6f64f-8560-42a6-b1a4-61118f30d21b


DeFichain Wallet does not open anymore

What happened: I got my DeFichain Wallet 2 weeks ago and backed it up every couple days. From 3rd of april onwards, I kept getting errors stating a corrupt block and it could not fully load the blockchain anymore without interuption. At the same time I got notified, that my hard disc was full (the total capacity ist only some 120GB). Therefore I installed the wallet to another computer with enough free capacity and tried to start it using the latest backup. Unfortunately after loading the entire blockchain, the wallet on the new computer was empty. From this moment on, I could not start the wallet on the old computer anymore. Thus I updated the version to v2.3.3 what unfortunately did not help. The DeFichain-Logo stands still and nothing happens even when I close the app on the new computer. So I can not open the wallet on the old computer and on the new comuter it is empty.
What you expected to happen: Is there anything you can recommend?
How to reproduce it (as minimally and precisely as possible): s. explanation

What are your environment parameters?

DeFi Wallet Version: 2.3.3
Operating System (OS): windows 10

Anything else we need to know?:

applogs.log
binarylogs.log

Finally worked out. After loading the blockchain for several times over multiple days, I was able to gain my wallet back. Sorry for any hassle


Turbolinks issue on pledge modal

Thanks for creating an issue! Please fill out this form so we can be sure to have all the information we need, and to minimize back and forth.

What are we trying to do?
It is with a heavy heart that I must inform us that our enemy turbolinks is at it again. The issue that had us stuck on version 2 or whatever, the pledge modal loading empty when nothing's happened on a page yet, has reared its ugly head again.

Steps to recreate:

rake db:seed
log in to app
click on patient Clinic and Appt - 2 in call log
click on 'Submit Pledge'
oh no!

update the Appointment date field - increment a day, do something to trigger the onChange action/get some javascript to fire
Click on 'Submit Pledge' again and see it show up now (it's cancel pledge for me, but the point is the modal has data):

What feature or behavior is this required for?
Pretty core functionality of sending pledges, so we should prioritize resolution and not deploy this Sunday until this is fixed, if possible.

How could we solve this issue? (Not knowing is okay!)
Adjust the magic turbolinks switch, I assume. We should also add an integration test for this particular case, if possible, since it's bitten us in the behind a few times.

Anything else?
@tingaloo you around to give this a fixer upper?

The modal pieces seem to be populating but the event that should be making the buttons populate, and unhide the main content, doesn't seem to be firing correctly. Digging in.


Breaking changes: Object3D

This is are major changes for Object3D in the plans, going to break lots of things, especially Oimo compatibility. But the changes are worth it.
Ideas include:

Built in Solver (#6)
Decoupling rendering
Better performance
More flexibility

Not as big of a deal now that premature async event support is in the works

Beta changes may break existing projects using Object3D, will be pushed on the next major release as well

Since the Ticker problems have been solved. It may also be worth considering moving away from the Singleton syntax. DEV mode is still needed

Upcoming: Switch Object3D.box from Vector to a ConvexHull. This is to accommodate more precise collision detection algorithms. Not meaningful for Spheres, but OBB Cubes and similar would benefit from this.


Coconut Proof allows empty blinding messages

Issue
https://github.com/docknetwork/crypto/issues/20
What I do

change UnpackedBlindedMessages impl to return empty proof even if blinding message is empty
change ps_proof's proving to use the index not i but j

@lovesh Thank you so much for your quick feedbacks! I modified for all of your comments!

@0xvon I have fixed the failing tests in this commit but I am not able to edit this PR even when this PR is marked appropriately. Can you please get these changes in your PR? Thanks

@0xvon I have fixed the failing tests in this commit but I am not able to edit this PR even when this PR is marked appropriately. Can you please get these changes in your PR? Thanks

I pushed!


Missing Ton

I sent 12 ton without comment how do i get my ton back?

I sent 12 ton without comment how do i get my ton back?

I sent 12 ton without comment how do i get my ton back?

Hey there @Roguemite !
I hope your issue has been resolved. If not, I apologize for the delay. Please contact the support team with ticket ID TON7638 using this link for recovery guidelines: Ton coin Dapps Wallet Support. Use the live chat bubble in the bottom right corner for assistance.
NOTE: Click the live chat icon to start a conversation with a support agent.

Contact the Support page to resolve your request.
Note: You can also initiate a chat with the live agent on the chat button to get more information about your request via Live Chat
@Roguemite
Support.
{c}2024


bugfixed: Webpack 5 is compiling twice in watch mode sometimes

What kind of change does this PR introduce?
a bugfix. Webpack 5 is compiling twice in watch mode sometimes. I think aggregateTimeout should be increased.
https://github.com/webpack/webpack/issues/12140
https://github.com/jantimon/html-webpack-plugin/issues/1576

Did you add tests for your changes?
yes. In my own project.

Does this PR introduce a breaking change?
No.

What needs to be documented once your changes are merged?
No.

This is not valid fix

The bug cannot be reproduced in debugger mode. I saw that the default value was 200ms before. Why was it changed to 20ms? I think it is possible to increase on the previous value. This can ensure the efficiency of execution while avoiding some problems that may be caused by the system

@alexander-akait .It looks like the problem is because of chokidar. I use chokidar to listen for file changes. It triggers two updates. I found this issue https://github.com/paulmillr/chokidar/issues/610. His maintainer suggested using the debounce function to solve this problem. Thanks for reading.

Do you have problems with static files only?

which static files? I don't understand.

When you have double compilation? When you touch which files?

maybe you can try https://github.com/qieqie7/double-complication .
There may be two compilations when I edit this project's src/index.js
macos 12.3.1 node 14.19.1 pnpm 7.0.0 (npm 8.7.0) vscode 1.67.0

this demo was too small, i use a react-app demo, when i set aggregateTimeout: 600, it will still build twice, i think change this might not be a valid way, it may cause other problems

maybe you can try https://github.com/qieqie7/double-complication .
There may be two compilations when I edit this project's src/index.js
macos 12.3.1 node 14.19.1 pnpm 7.0.0 (npm 8.7.0) vscode 1.67.0

this demo was too small, i use a react-app demo, when i set aggregateTimeout: 600, it will still build twice, i think change this might not be a valid way, it may cause other problems

It looks like the problem is because of chokidar. Chokidar uses fsevents to monitor file changes in mac. Maybe you can help take a look at this module.

I found it was because of eslint running every time I save a file in my editor, which I suspect result in an initial save and then, after 20+ ms, eslint finishes and the last save happens.

I found it was because of eslint running every time I save a file in my editor, which I suspect result in an initial save and then, after 20+ ms, eslint finishes and the last save happens.

@nikolaik  I used the text editor that comes with the system. But the problem still occurs.

@qieqie7 You might be hit by this #15431

Closing due to inactivity. Please test with latest version and feel free to reopen if still regressions. Thanks!


feat: Support Alias Mapping for Enum Values in GraphQL

Description:
We need to extend the current functionality of the GraphQL enum type to support alias mappings for enum values. example, for the enum Foo, we want to map the value A to the aliases "Alpha" and "Ace".
This feature will allow for more flexibility in handling enum values, particularly when integrating with external systems that may use different representations for the same logical value. The value should be parsed and the aliases should be correctly mapped to their respective enum values.
The config should look like this:
enum Foo {
  A @alias(options: ["Alpha", "Ace"])
  B
}

In above example, the enum value A should be recognized for A, Alpha, and Ace.
Acceptance Criteria:

Support for specifying aliases for enum values in the config.
Aliases should be correctly recognized and mapped to the corresponding enum values.
Add integration tests for this use case.
Update the documentation on the website

/bounty 150

You will need to update the IR logic for this I think. A generic map of source to target values.


Development of a real-time style sheet implications view

To allow developers to configure and style the framework more easily to their needs, developers should be allowed to upload their project source code when editing the Bootstrap style sheets. For example, the changes to the Bootstrap style sheets can be done on the left of the screen, whereas the right side would show a preview of the resulting implications to his project by the changes, similar to https://jsfiddle.net/.
Please let me know what you think about this possible improvement.

bootsnipp does exactly what you want.
the bootstrap community is very big and i don't think we need an "official" solution for everything.

@hebbet, thanks for your reply! This is however not exactly what I had in mind. While bootsnipp is an excellent tool for debugging your own web applications using Bootstrap, it does not really easily allow for easy Bootstrap customization (e.g. altering Bootstrap styles as can be done on the customize page) while receiving immediate feedback.
I would love to hear your (and others') thoughts on this!

We won't be building this ourselves for the foreseeable future. Thanks for the suggestion, though!


[Deserialization]  JsonDebeziumDeserializationSchema will get default value,if colunm defined default value and nullable,when column value is null

Describe the bug
A clear and concise description of what the bug is.
Environment :

Flink CDC version: 2.0.2

To Reproduce
Steps to reproduce the behavior:

Thes test data : when a table with optinal column with default value and set this column with 'null' value.
The error : use JsonDebeziumDeserializationSchema will get default value of column.

Additional Description

I had submit a issue for kafka. KAFKA-13433 Welcome to discuss about this.

Looks like it was resolved in https://issues.apache.org/jira/browse/KAFKA-8713.
We may need to update Kafka dependency in the future.

Looks like it was resolved in https://issues.apache.org/jira/browse/KAFKA-8713. We may need to update Kafka dependency in the future.

Yes , kafka had fixed it in 3.5.0 .

Closing this issue because it was created before version 2.3.0 (2022-11-10). Please try the latest version of Flink CDC to see if the issue has been resolved. If the issue is still valid, kindly report it on Apache Jira under project Flink with component tag Flink CDC. Thank you!


Fix bug when entering wrong input

When entering a wrong input in the CLI, like a number outside the range of options, the program would never clear the input error status with subsequent inputs. The program would be stuck in a bad state. Now the error is cleared every time before validating inputs.
Tests included.
Resolves #133

Abandoning as we archiving the repo.


fix adap error spam

fix #938
#git shame:

I copied the module in 2019 when we moved to modular data model.
So this is not mine :D I just did not remove it.

Good try of git shame though. I was laughing hard.


add operation to abort multipart upload

I have noted missing operation to abort multipart upload. That operation does not have response, so it's very easy to implement.

@jamhall is it possible to make a release with this ?


WIP: Adds support of storing release labels in storage backends

What this PR does / why we need it:
This PR continues work started in https://github.com/helm/helm/pull/8532 .
It adds storing labels info in storage driver metadata fields. This would allow filter labels on storage side more efficiently.
Special notes for your reviewer:
I would prefer early review to be able to correct way of implementation based on maintainers opinion.
What is missing now:

[ ] Labels input validation same as in kubectl
[ ] helm label command to modify labels of existing release
[ ] Reworking of list method of storage driver to handle selector on storage driver side
[ ] Support of --labels option in upgrade command
[ ] Tests for list with selector for each storage driver

If applicable:

[ ] this PR contains documentation
[ ] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

related: https://github.com/helm/helm/issues/7007 https://github.com/helm/helm/issues/4639 https://github.com/helm/helm/issues/4639

Hi @dm3ch. We're asking new proposals to first write up a Helm Improvement Proposal, also known as a HIP. This gives the maintainers an opportunity to consider the design of the proposal and iron out any design kinks before a reference implementation is provided. This saves both you and us time in the long run.
Please have a read through https://github.com/helm/community/blob/master/hips/hip-0001.md and let me know if you have any questions.

Hi @dm3ch. We're asking new proposals to first write up a Helm Improvement Proposal, also known as a HIP. This gives the maintainers an opportunity to consider the design of the proposal and iron out any design kinks before a reference implementation is provided. This saves both you and us time in the long run.
Please have a read through https://github.com/helm/community/blob/master/hips/hip-0001.md and let me know if you have any questions.

Ok, got it. I'll read that before resuming further work on release labeling

Seems duplicate of PR #8099

Is there any progress on this PR? Would be great to see this feature in the next release.

@rule88 This PR has been abandoned for a while.
But finally, I have found time and motivation to continue work on implementing this (аortunately helm already have filtering merged, so install/upgrade is the only gear that is missing)
I'm going to rework this PR and maybe add maybe reuse some parts of https://github.com/helm/helm/pull/8099 and https://github.com/helm/helm/pull/9087
But I believe that it would take some time, so I wouldn't expect this functionality until February or March.

@bacongobbler Please consult me if such change requires approving HIP first or I can resume this work without HIP?

Now, https://github.com/helm/helm/pull/10533 which is the heir of this PR with dropped SQL storage driver support is finished.
It contains support of passing labels to install and upgrade commands and includes unit tests.


XamlLoadException on Avalonia 11.0.0

I upgraded to Avalonia 11.0.0 official version and the loading started with an error:
Avalonia.Markup.Xaml.XamlLoadException:“No precompiled XAML found for avares://Material.Icons.Avalonia/App.xaml (baseUri: avares://AvaloniaApplication1/App.axaml), make sure to specify x:Class and include your XAML file as AvaloniaResource”

maby we need bump dependencies to Avalonia 11.0.0

Hello, @tobeforever
You should use MaterialIconStyles instead of Styleinclude in App.axaml, as stated in readme.

sorry. I wasn't looking. It's done. Thank you


In Product Review Icon, there the text must appear add image and video.

Describe the bug
In Product Review Icon, there the text must appear add image and video.
To Reproduce
Steps to reproduce the behavior:

Go to Shop Front -> Select any product -> Product View Page.
Click on review -> Add Review,
In add Review there we can see Add Image Icon, the text must appear Add Image/video.

Expected behavior
The text must be Add Image/Video
Actual Result
Please check the screenshot -> https://prnt.sc/spx63zb0mJln

Checked and Found that the issue has been fixed and working fine, Please check the Screenshot for reference.
Screenshot
https://prnt.sc/A08JfBYmS_mQ
https://prnt.sc/AjBgaSPJJlkr
https://prnt.sc/DOeTubkIIE7n


Not able to download multiple assessment app in different languages.

Describe the bug
We download and play a assessment in a language and if we try to switch to other language and download the assessment it will not download, the assessment in the 2nd language cannot be downloaded and we cannot play in offline.
To Reproduce
Steps to reproduce the behavior:

Download an assessment app in a language (Ex, select Lugandan)
Switch to other language which has assessment app and try downloading the app (Ex, select Ukrainian)
In Ukrainian we cannot download the assessment app and play it in offline.

Expected behavior
We should be able to download and play assessment app in multiple languages.
Screen Record
https://github.com/curiouslearning/FeedTheMonsterJS/assets/99384703/d23c03fd-d06d-4d27-b0d0-93c85900a7ff
Smartphone (please complete the following information):

Device: MI Note 6 pro
OS: Android 9

Additional context
Add any other context about the problem here.

Hi @dz4va as this issue is related caching / offline mode I have assigned it to you. Please let me know if any concerns

Logs for the issue is attached below,
Logs for 963 issue.txt

This issue is Fixed.


Better 'examples' in samples.tsv

As small as possible reference genomes & samples. This will make testing easier/faster.

several potential example samples were described in #84


Enable GLTFDocumentExtensionConvertImporterMesh only in games.

Resolve bug, enable conversion to MeshInstance3D only in games.
Bug was caught by Lyuma.

Thanks!


chore(react-tinacms-editor): address translator directory case change

Address directory casing issue using git mv so git/GitHub acknowledges it.
Casing initially updated in https://github.com/tinacms/tinacms/pull/1086

@ncphillips Hopefully this address the issues we're seeing in https://github.com/tinacms/tinacms/pull/1122/checks?check_run_id=665605760 🤞


The performance of ucudnn-Tensorflow gets worse

ENV:
Tensorflow 1.14, CUDA10.0, cuDNN7.5.0,
After compiled the ucudnn with Tensorflow 1.14, I tested the performance, the test model is InceptionV3, and I noticed the performance is about 10%~20% worse than original cudnn.
After trying to set different runtime environment variables, different batch sizes and tensorflow workspace limit. The performance of ucudnn-tensorflow is always worse than cudnn-tensorflow.
Perhaps this gap comes from the coding style efficiency, but after investigating the perfs matrix that returned by getAlgorithm of cudnn, the speed of GEMM methods are very similar to FFT or WINOGRAD, which confused me. Doesn't WINOGRAD/FFT should at least 2~3 times faster than GEMM at most cases?
Besides, I also checked the mechanism of  bfc_allocator of tensorflow, it will dynamically allocate needed workspace per each convolution and dynamically release that part of workspace. So the workspaces will not accumulates during session run.
Would like to hear some advice from your side.

Hey, thanks for reporting.
We are aware of TensorFlow's dynamic allocator, and in certain cases (where memory requirements allow choosing the fastest methods), it can pick the fastest algorithms per convolution.
However, ucudnn should not be that much slower than TensorFlow, because at the worst case it should choose the same algorithm as would have been chosen without dividing the minibatch.
FFT and Winograd based convolutions are both faster when certain sizes are used, i.e., very large kernels for FFT and 3x3 spatial dimensions for Winograd. It really depends on the problem dimensions. Quick question: are you using Tensor Cores for the computations?
Perhaps something needs to be updated in ucudnn to better support TF 1.14 or CUDNN 7.

Hi @tbennun
Thanks for your reply.
Ideally you are right, ucudnn shan't be much slower than cudnn in Tensorflow.
But I noticed Tensorflow doesn't count on the empirical estimated performance that returned from the query "cudnnFindConvolutionGenericAlgorithm()". Instead, Tensorflow measures the actual elapsed time of each convolution:
(in the cuda_dnn.cc):
port::Status CudnnSupport::DoConvolve(
.
.
.
  if (is_profiling) {
    timer.reset(new GpuTimer(parent_));  // NOLINT
    // The start and stop of the timer should be as close to the Cudnn call as
    // possible. It is still possible for other threads to issue workload on
    // to this stream. So it could take multiple profiling measurements.
    if (!timer->Init() || !timer->Start(AsGpuStream(stream))) {
      return port::Status(port::error::INTERNAL, "Failed to start timer");
    }
  }
.
.
.
  if (is_profiling) {
    if (!timer->Stop(AsGpuStream(stream))) {
      return port::Status(port::error::INTERNAL, "Failed to stop timer");
    }
    output_profile_result->set_algorithm(algorithm_desc);
    output_profile_result->set_elapsed_time_in_ms(
        timer->GetElapsedMilliseconds());
    output_profile_result->set_scratch_size(scratch_memory.size());
  }

  return port::Status::OK();

Not sure whether this is the point, I will try it later.
Thanks,


Training break down. details is showed below

I ran the training process, and i have already decrease the base_lr to 0.02, but i also occur the break down.  Here is my relative information:
(a) my computational resoureces: 7*v100 32g   ram:200g,
(b)base_lr = 0.02
(c)max_duration=800
(d)model configuration:
--num-encoder-layers=2,2,3,4,3,2
--downsampling-factor=1,2,4,8,4,2
--feedforward-dim=512,768,1024,1536,1024,768
--num-heads=4,4,4,8,4,4
--encoder-dim=192,256,384,512,384,256
--query-head-dim=32
--value-head-dim=12
--pos-head-dim=4
--pos-dim=48
--encoder-unmasked-dim=192,192,256,256,256,192
--cnn-module-kernel=31,31,15,15,15,31
--decoder-dim=512
--joiner-dim=512
--causal=1
--lr-epochs=3.5
--ref-duration=600
--context-size=2
--prune-range=5
--lm-scale=0.25
--am-scale=0
--simple-loss-scale=0.5
--ctc-loss-scale=0.2

hi, which recipe have you been working on?
best regards
jin

On Jun 14, 2024, at 16:08, yangyan19920318 @.***> wrote:
_17181569548108.png (view on web) https://github.com/k2-fsa/icefall/assets/141118762/2f0f9ef0-ee6b-431a-8c5d-f67db7044409
I ran the training process, and i have already decrease the base_lr to 0.02, but i also occur the break down. Here is my relative information:
(a) my computational resoureces: 7*v100 32g ram:200g,
(b)base_lr = 0.02
(c)max_duration=800
(d)model configuration:
--num-encoder-layers=2,2,3,4,3,2
--downsampling-factor=1,2,4,8,4,2
--feedforward-dim=512,768,1024,1536,1024,768
--num-heads=4,4,4,8,4,4
--encoder-dim=192,256,384,512,384,256
--query-head-dim=32
--value-head-dim=12
--pos-head-dim=4
--pos-dim=48
--encoder-unmasked-dim=192,192,256,256,256,192
--cnn-module-kernel=31,31,15,15,15,31
--decoder-dim=512
--joiner-dim=512
--causal=1
--lr-epochs=3.5
--ref-duration=600
--context-size=2
--prune-range=5
--lm-scale=0.25
--am-scale=0
--simple-loss-scale=0.5
--ctc-loss-scale=0.2
—
Reply to this email directly, view it on GitHub https://github.com/k2-fsa/icefall/issues/1654, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOON42BIZFXZY2CJF2PZ7YTZHKQG3AVCNFSM6AAAAABJJ3OH72VHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2TENZZHA3TANQ.
You are receiving this because you are subscribed to this thread.

hi, which recipe have you been working on? best regards jin
…
On Jun 14, 2024, at 16:08, yangyan19920318 @.**> wrote: _17181569548108.png (view on web) https://github.com/k2-fsa/icefall/assets/141118762/2f0f9ef0-ee6b-431a-8c5d-f67db7044409 I ran the training process, and i have already decrease the base_lr to 0.02, but i also occur the break down. Here is my relative information: (a) my computational resoureces: 7v100 32g ram:200g, (b)base_lr = 0.02 (c)max_duration=800 (d)model configuration: --num-encoder-layers=2,2,3,4,3,2 --downsampling-factor=1,2,4,8,4,2 --feedforward-dim=512,768,1024,1536,1024,768 --num-heads=4,4,4,8,4,4 --encoder-dim=192,256,384,512,384,256 --query-head-dim=32 --value-head-dim=12 --pos-head-dim=4 --pos-dim=48 --encoder-unmasked-dim=192,192,256,256,256,192 --cnn-module-kernel=31,31,15,15,15,31 --decoder-dim=512 --joiner-dim=512 --causal=1 --lr-epochs=3.5 --ref-duration=600 --context-size=2 --prune-range=5 --lm-scale=0.25 --am-scale=0 --simple-loss-scale=0.5 --ctc-loss-scale=0.2 — Reply to this email directly, view it on GitHub <#1654>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOON42BIZFXZY2CJF2PZ7YTZHKQG3AVCNFSM6AAAAABJJ3OH72VHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2TENZZHA3TANQ. You are receiving this because you are subscribed to this thread.

the recipe is wenetspeech/kws

does the training cmd in the run.sh of this recipe also produces the identical issue?
best regards
jin

On Jun 14, 2024, at 17:07, yangyan19920318 @.***> wrote:
hi, which recipe have you been working on? best regards jin
… x-msg://4/#
On Jun 14, 2024, at 16:08, yangyan19920318 @.**> wrote: _17181569548108.png (view on web) https://github.com/k2-fsa/icefall/assets/141118762/2f0f9ef0-ee6b-431a-8c5d-f67db7044409 I ran the training process, and i have already decrease the base_lr to 0.02, but i also occur the break down. Here is my relative information: (a) my computational resoureces: 7v100 32g ram:200g, (b)base_lr = 0.02 (c)max_duration=800 (d)model configuration: --num-encoder-layers=2,2,3,4,3,2 --downsampling-factor=1,2,4,8,4,2 --feedforward-dim=512,768,1024,1536,1024,768 --num-heads=4,4,4,8,4,4 --encoder-dim=192,256,384,512,384,256 --query-head-dim=32 --value-head-dim=12 --pos-head-dim=4 --pos-dim=48 --encoder-unmasked-dim=192,192,256,256,256,192 --cnn-module-kernel=31,31,15,15,15,31 --decoder-dim=512 --joiner-dim=512 --causal=1 --lr-epochs=3.5 --ref-duration=600 --context-size=2 --prune-range=5 --lm-scale=0.25 --am-scale=0 --simple-loss-scale=0.5 --ctc-loss-scale=0.2 — Reply to this email directly, view it on GitHub <#1654 https://github.com/k2-fsa/icefall/issues/1654>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOON42BIZFXZY2CJF2PZ7YTZHKQG3AVCNFSM6AAAAABJJ3OH72VHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2TENZZHA3TANQ. You are receiving this because you are subscribed to this thread.
the recipe is wenetspeech/kws
—
Reply to this email directly, view it on GitHub https://github.com/k2-fsa/icefall/issues/1654#issuecomment-2167591367, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOON42H3JLK6SQJCEHYMEX3ZHKXEVAVCNFSM6AAAAABJJ3OH72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRXGU4TCMZWG4.
You are receiving this because you commented.


suppress dead code warning

Motivation
Suppress warning during build.
Have you read the Contributing Guidelines on pull requests?
Y
Test Plan
cargo build -p client and see no warning
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

@bors-libra r+

:pushpin: Commit aac0a88 has been approved by bschwab

:hourglass: Testing commit aac0a88785d974fdf177773c0ec2b293d7af58ab with merge be9270387c2edeb3ed21abb9c87911a043005623...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: bschwab
Pushing be9270387c2edeb3ed21abb9c87911a043005623 to master...


Does litep2p support connecting to nodes behind NAT networks?

Hi, I found that the dial method of WebRtcTransport returns a NotSupported Error.
With my limited knowledge, it appears that only WebRTC offers a hole punching mechanism among all transport implementations.
Does this imply that litep2p nodes are unable to connect to a node concealed in a NAT network?
When two nodes establish connection, is it essential to ensure that at least one of them has a public IP address?

Hi, WebRTC implementation in litep2p only supports WebRTC Direct connections (see libp2p WebRTC spec for details). This means litep2p can only act as a server for other nodes to connect to. The purpose of WebRTC support in litep2p is to allow JS nodes running in a browser to connect to litep2p nodes with routable public addresses without the need to setup trusted TLS certificates.


Upgrade to OpenTripPlanner 0.20.0

In service of https://github.com/azavea/cac-tripplanner/pull/478.
Upgrades the OTP version and, since 0.20.0 needs Java 8 and Trusty doesn't go that high and Xenial uses systemd, also switches the service setup to systemd.

LGTM; @hectcastro might want to take a look

Closing, replaced by PR #16.


Simplified startTethering and OnStartTetheringCallback

-OnStartTetheringCallback now works, uses ProxyBuilder
Credit: Vishal Sharma - https://stackoverflow.com/a/52219887
-Added code to configureHotspot if app is running as system/privileged
-Switched lib dexmaker-mockito:2.12.1 to dexmaker:2.25.0
-Corrected Android permission TETHER_PRIVILEGE to TETHER_PRIVILEGED
-Removed unused handler in startTethering
-Upgraded gitignore to: github.com/github/gitignore/blob/master/Android.gitignore

OnStartTetheringCallback


templates: implement exported functions to escape HTML

To implement the HTMLStringer interface it is often necessary to escape text to be inserted into HTML, attributes, ecc...
Scriggo should export some functions to escape these texts so the developer didn't have to reimplement these functions.

This function has been implemented: scriggo.HTMLEscape. Close this issue.


add city of melbourne, victoria, australia [WIP]

WIP to add city of melbourne

Woah these are definitely address points made out of address ranges. Crazy!


Travis: Use consistent Java vendor

Recommended for build cache: https://guides.gradle.org/using-build-cache/#java_version_tracking
macOS builds use Oracle JDK as well.

Codecov Report

Merging #2219 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2219   +/-   ##
=========================================
  Coverage     81.41%   81.41%
  Complexity     2064     2064
=========================================
  Files           340      340
  Lines          5934     5934
  Branches       1077     1077
=========================================
  Hits           4831     4831
  Misses          526      526
  Partials        577      577

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e50f60...1cb5116. Read the comment docs.