Manager Updates not Installing

Please check the troubleshooting guide in the Wiki before submitting an issue.
Describe the bug
When I update the mod manager, it reloads the manager and asks to do the same update I just installed.
To Reproduce
Steps to reproduce the behavior:

Open the un-updated mod manager
Update the manager
It will disappear, then reopen and ask for the same update again

Expected behavior
It would usually update successfully, however it is not accepting the update
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Windows 11

Additional context
N/A

What version are you on?

I just downloaded the latest version off GitHub, so it doesn’t happen
anymore but I was on the version before the latest version I know that.
On Fri, Jan 19, 2024 at 7:21 PM Sora @.***> wrote:

What version are you on?
—
Reply to this email directly, view it on GitHub
https://github.com/X-Hax/SA-Mod-Manager/issues/57#issuecomment-1901407126,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BFPGXYQ7R5HMZWFQRSP52H3YPMEZHAVCNFSM6AAAAABCCWQROWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBRGQYDOMJSGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

I've been having this issue too.  Every time a new update comes, it's the same deal.

As of today do you all still have this issue? I never managed to reproduce it, but I could share a debug build that you could try and hopefully help us find why this happens.

Yea last night I tried to update something and it didn’t update, just
crashed and reloaded the mod manager
On Sun, Apr 7, 2024 at 7:45 AM Sora @.***> wrote:

As of today do you all still have this issue? I never managed to reproduce
it, but I could share a debug build that you could try and hopefully help
us find why this happens.
—
Reply to this email directly, view it on GitHub
https://github.com/X-Hax/SA-Mod-Manager/issues/57#issuecomment-2041442257,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BFPGXYVGMEXNFBN7AQS54R3Y4EWXNAVCNFSM6AAAAABCCWQROWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGQ2DEMRVG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thanks for the answer. Can you try with this specific build?
SAModManager_Test_Update_Build.zip
When running it, it will ask you to update, just do it and let me know how it goes, it should download, install and restart itself. Once the restart is done, you should read on top 1.2.7 instead of 1.2.6.
Additionally, this build will logs all the information during the update process in a txt file named "application.log", in the same folder than the Manager.
If the issue persist after the update, please share the log file, this will be useful for debugging.

It downloads the application.log but restarts and asks to update again
On Sun, Apr 7, 2024 at 5:52 PM Sora @.***> wrote:

Thanks for the answer. Can you try with this specific build?
SAModManager_Test_Update_Build.zip
https://github.com/X-Hax/SA-Mod-Manager/files/14899065/SAModManager_Test_Update_Build.zip
When running it, it will ask you to update, just do it and let me know how
it goes, it should download, install and restart itself. Once the restart
is done, you should read on top 1.2.7 instead of 1.2.6.
Additionally, this build will logs all the information during the update
process in a txt file named "application.log", in the same folder than
the Manager.
If the issue persist after the update, please share the log file, this
will be useful for debugging.
—
Reply to this email directly, view it on GitHub
https://github.com/X-Hax/SA-Mod-Manager/issues/57#issuecomment-2041620402,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BFPGXYUI2VJFTRRB27JRHPLY4G52TAVCNFSM6AAAAABCCWQROWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGYZDANBQGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Can you share the application.log file?

I think I sent it, did you get it?
On Sun, Apr 7, 2024 at 7:21 PM Sora @.***> wrote:

Can you share the application.log file?
—
Reply to this email directly, view it on GitHub
https://github.com/X-Hax/SA-Mod-Manager/issues/57#issuecomment-2041642001,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BFPGXYWKG77FLF3TDGXEZA3Y4HIGVAVCNFSM6AAAAABCCWQROWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGY2DEMBQGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Nop, please share a direct link.

Any news on this? These logs would really help.

Well, if OwenDino-Studios isn't going to, I guess I will:
2024-04-18 09:07:06 - Manager Started! Debug mod enabled.
2024-04-18 09:07:06 - Looking for Manager Update command...
2024-04-18 09:07:06 - doupdate command NOT found.
2024-04-18 09:07:06 - Linux wasn't detected, the Manager will act like we are on Windows.
2024-04-18 09:07:06 - Steam Folder was found through Windows method at: C:\Program Files (x86)\Steam
2024-04-18 09:07:06 - Now looking for Steam config file...
2024-04-18 09:07:06 - libraryfolders.vdf file found... now attempting to get paths...
2024-04-18 09:07:06 - Path Found: C:\Program Files (x86)\Steam
2024-04-18 09:07:06 -
Auto Game Detection starts now...
2024-04-18 09:07:06 - Now looking for games in the same folder as the Manager...
2024-04-18 09:07:06 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build\sonic.exe
2024-04-18 09:07:06 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build\sonic2app.exe
2024-04-18 09:07:06 - Now looking for games through Steam...
2024-04-18 09:07:06 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure DX
2024-04-18 09:07:06 - Found Game!
2024-04-18 09:07:06 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure 2
2024-04-18 09:07:06 - Found Game!
2024-04-18 09:07:06 - SA Mod Manager (1.2.6 - 7bc52af)
2024-04-18 09:07:06 - Checking for Manager updates...
2024-04-18 09:07:06 - Display Changelog
2024-04-18 09:07:10 - User accepted the Manager Update
2024-04-18 09:07:10 - Created SATemp folder.
2024-04-18 09:07:10 - Now Downloading Manager Update
2024-04-18 09:07:10 - DL LINK: https://github.com/X-Hax/SA-Mod-Manager/raw/master/SA-Mod-Manager/Resources/UpdateTest.zip
2024-04-18 09:07:10 - Dest Folder: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build.SATemp
2024-04-18 09:07:11 - Download Update completed.
2024-04-18 09:07:11 - Extracting: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build.SATemp\UpdateTest.zip in: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build.SATemp
2024-04-18 09:07:11 - Extraction completed, now deleting archive: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build.SATemp\UpdateTest.zip
2024-04-18 09:07:11 - Starting New Manager at: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build.SATemp\SAModManager.exe
2024-04-18 09:07:12 - Manager Started! Debug mod enabled.
2024-04-18 09:07:12 - Looking for Manager Update command...
2024-04-18 09:07:12 - doupdate command found.
2024-04-18 09:07:12 - Installing update...
2024-04-18 09:07:12 - Args 2: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build.SATempArgs 3: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build\SAModManager.exe
2024-04-18 09:07:12 - Moving Manager Exe from: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build.SATemp\SAModManager.exeto: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build\SAModManager.exe
2024-04-18 09:07:12 - Finished Updating, restarting Manager one more time.
2024-04-18 09:07:13 - Manager Started! Debug mod enabled.
2024-04-18 09:07:13 - Looking for Manager Update command...
2024-04-18 09:07:13 - doupdate command NOT found.
2024-04-18 09:07:13 - Linux wasn't detected, the Manager will act like we are on Windows.
2024-04-18 09:07:13 - Steam Folder was found through Windows method at: C:\Program Files (x86)\Steam
2024-04-18 09:07:13 - Now looking for Steam config file...
2024-04-18 09:07:13 - libraryfolders.vdf file found... now attempting to get paths...
2024-04-18 09:07:13 - Path Found: C:\Program Files (x86)\Steam
2024-04-18 09:07:13 -
Auto Game Detection starts now...
2024-04-18 09:07:13 - Now looking for games in the same folder as the Manager...
2024-04-18 09:07:13 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build\sonic.exe
2024-04-18 09:07:13 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build\sonic2app.exe
2024-04-18 09:07:13 - Now looking for games through Steam...
2024-04-18 09:07:13 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure DX
2024-04-18 09:07:13 - Found Game!
2024-04-18 09:07:13 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure 2
2024-04-18 09:07:13 - Found Game!
2024-04-18 09:07:13 - SA Mod Manager (1.2.6 - 7bc52af)
2024-04-18 09:07:14 - Checking for Manager updates...
2024-04-18 09:07:14 - Display Changelog

Any news on this? These logs would really help.

Thank you for sharing the logs. It looks like the Temp folder path is wrong as it's missing a backslash. I don't know why that happens, but I tried to implement some manual fixes, we will see how this goes.
Can any of you try this new build and let me know how this goes please?
Regardless of the result, please share the logs again after.
SAModManager_Test_Update_Build_2.zip

Still didn't work.  Here's the log:
2024-04-18 11:41:19 - Manager Started! Debug mod enabled.
2024-04-18 11:41:19 - Temp Folder is: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_2.SATemp
2024-04-18 11:41:19 - Could not find a missing slash in the temp folder. Path should be correct.
2024-04-18 11:41:19 - Looking for Manager Update command...
2024-04-18 11:41:19 - doupdate command NOT found.
2024-04-18 11:41:19 - Linux wasn't detected, the Manager will act like we are on Windows.
2024-04-18 11:41:19 - Steam Folder was found through Windows method at: C:\Program Files (x86)\Steam
2024-04-18 11:41:19 - Now looking for Steam config file...
2024-04-18 11:41:19 - libraryfolders.vdf file found... now attempting to get paths...
2024-04-18 11:41:19 - Path Found: C:\Program Files (x86)\Steam
2024-04-18 11:41:20 -
Auto Game Detection starts now...
2024-04-18 11:41:20 - Now looking for games in the same folder as the Manager...
2024-04-18 11:41:20 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_2\sonic.exe
2024-04-18 11:41:20 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_2\sonic2app.exe
2024-04-18 11:41:20 - Now looking for games through Steam...
2024-04-18 11:41:20 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure DX
2024-04-18 11:41:20 - Found Game!
2024-04-18 11:41:20 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure 2
2024-04-18 11:41:20 - Found Game!
2024-04-18 11:41:20 - SA Mod Manager (Dev Build - 1.2.6)
2024-04-18 11:41:20 - Checking for Manager updates...
2024-04-18 11:41:20 - Update found! Displaying Changelog
2024-04-18 11:41:23 - User accepted the Manager Update
2024-04-18 11:41:23 - Created SATemp folder.
2024-04-18 11:41:23 - Now Downloading Manager Update
2024-04-18 11:41:23 - DL LINK: https://github.com/X-Hax/SA-Mod-Manager/raw/master/SA-Mod-Manager/Resources/UpdateTest.zip
2024-04-18 11:41:23 - Dest Folder: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_2.SATemp
2024-04-18 11:41:24 - Download Update completed.
2024-04-18 11:41:25 - Extracting: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_2.SATemp\UpdateTest.zip in: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_2.SATemp
2024-04-18 11:41:25 - Extraction completed, now deleting archive: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_2.SATemp\UpdateTest.zip
2024-04-18 11:41:25 - Starting New Manager at: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_2.SATemp\SAModManager.exe
2024-04-18 11:41:26 - Manager Started! Debug mod enabled.
2024-04-18 11:41:26 - Temp Folder is: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_2.SATemp.SATemp
2024-04-18 11:41:26 - Could not find a missing slash in the temp folder. Path should be correct.
2024-04-18 11:41:26 - Looking for Manager Update command...
2024-04-18 11:41:26 - doupdate command found.
2024-04-18 11:41:26 - Installing update...
2024-04-18 11:41:26 - Args 2: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_2.SATemp Args 3: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_2\SAModManager.exe
2024-04-18 11:41:26 - Moving Manager Exe from: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_2.SATemp\SAModManager.exe  to:  C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_2\SAModManager.exe
2024-04-18 11:41:26 - Finished Updating, restarting Manager one more time.
2024-04-18 11:41:26 - Manager Started! Debug mod enabled.
2024-04-18 11:41:26 - Temp Folder is: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_2.SATemp
2024-04-18 11:41:26 - Could not find a missing slash in the temp folder. Path should be correct.
2024-04-18 11:41:26 - Looking for Manager Update command...
2024-04-18 11:41:26 - doupdate command NOT found.
2024-04-18 11:41:26 - Linux wasn't detected, the Manager will act like we are on Windows.
2024-04-18 11:41:26 - Steam Folder was found through Windows method at: C:\Program Files (x86)\Steam
2024-04-18 11:41:26 - Now looking for Steam config file...
2024-04-18 11:41:26 - libraryfolders.vdf file found... now attempting to get paths...
2024-04-18 11:41:26 - Path Found: C:\Program Files (x86)\Steam
2024-04-18 11:41:27 -
Auto Game Detection starts now...
2024-04-18 11:41:27 - Now looking for games in the same folder as the Manager...
2024-04-18 11:41:27 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_2\sonic.exe
2024-04-18 11:41:27 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_2\sonic2app.exe
2024-04-18 11:41:27 - Now looking for games through Steam...
2024-04-18 11:41:27 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure DX
2024-04-18 11:41:27 - Found Game!
2024-04-18 11:41:27 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure 2
2024-04-18 11:41:27 - Found Game!
2024-04-18 11:41:27 - SA Mod Manager (Dev Build - 1.2.6)
2024-04-18 11:41:27 - Checking for Manager updates...
2024-04-18 11:41:27 - Update found! Displaying Changelog

So it fails to detect that the backslashes are missing in the path, hu, this is weird.
Maybe it's because of the '.' in SATemp path, so let's see without it:
SAModManager_Test_Update_Build_3.zip
If the issue persist, can you try by running it as admin? Also, may I ask what OS are you using? The op is on Windows 11 so I wonder if it's related to this.

I use Windows 11 as well, it didn't work normally, or as an admin.  Here's what I got normally:
2024-04-18 14:38:18 - Manager Started! Debug mod enabled.
2024-04-18 14:38:18 - Temp Folder is: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3.SATemp
2024-04-18 14:38:18 - Switching...
2024-04-18 14:38:18 - New Temp Folder is: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp
2024-04-18 14:38:18 - Looking for Manager Update command...
2024-04-18 14:38:18 - doupdate command NOT found.
2024-04-18 14:38:18 - Linux wasn't detected, the Manager will act like we are on Windows.
2024-04-18 14:38:18 - Steam Folder was found through Windows method at: C:\Program Files (x86)\Steam
2024-04-18 14:38:18 - Now looking for Steam config file...
2024-04-18 14:38:18 - libraryfolders.vdf file found... now attempting to get paths...
2024-04-18 14:38:18 - Path Found: C:\Program Files (x86)\Steam
2024-04-18 14:38:18 -
Auto Game Detection starts now...
2024-04-18 14:38:18 - Now looking for games in the same folder as the Manager...
2024-04-18 14:38:18 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\sonic.exe
2024-04-18 14:38:18 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\sonic2app.exe
2024-04-18 14:38:18 - Now looking for games through Steam...
2024-04-18 14:38:18 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure DX
2024-04-18 14:38:18 - Found Game!
2024-04-18 14:38:18 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure 2
2024-04-18 14:38:18 - Found Game!
2024-04-18 14:38:18 - SA Mod Manager (Dev Build - 1.2.6)
2024-04-18 14:38:18 - Checking for Manager updates...
2024-04-18 14:38:18 - Update found! Displaying Changelog
2024-04-18 14:38:21 - User accepted the Manager Update
2024-04-18 14:38:21 - Created SATemp folder.
2024-04-18 14:38:21 - Now Downloading Manager Update
2024-04-18 14:38:21 - DL LINK: https://github.com/X-Hax/SA-Mod-Manager/raw/master/SA-Mod-Manager/Resources/UpdateTest.zip
2024-04-18 14:38:21 - Dest Folder: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp
2024-04-18 14:38:26 - Download Update completed.
2024-04-18 14:38:26 - Extracting: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp\UpdateTest.zip in: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp
2024-04-18 14:38:26 - Extraction completed, now deleting archive: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp\UpdateTest.zip
2024-04-18 14:38:26 - Starting New Manager at: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp\SAModManager.exe
2024-04-18 14:38:27 - Manager Started! Debug mod enabled.
2024-04-18 14:38:27 - Temp Folder is: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp.SATemp
2024-04-18 14:38:27 - Could not find a missing slash in the temp folder. Path should be correct.
2024-04-18 14:38:27 - Looking for Manager Update command...
2024-04-18 14:38:27 - doupdate command found.
2024-04-18 14:38:27 - Installing update...
2024-04-18 14:38:27 - Args 2: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp Args 3: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SAModManager.exe
2024-04-18 14:38:27 - Moving Manager Exe from: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp\SAModManager.exe  to:  C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SAModManager.exe
2024-04-18 14:38:27 - Finished Updating, restarting Manager one more time.
2024-04-18 14:38:28 - Manager Started! Debug mod enabled.
2024-04-18 14:38:28 - Temp Folder is: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3.SATemp
2024-04-18 14:38:28 - Switching...
2024-04-18 14:38:28 - New Temp Folder is: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp
2024-04-18 14:38:28 - Looking for Manager Update command...
2024-04-18 14:38:28 - doupdate command NOT found.
2024-04-18 14:38:28 - Linux wasn't detected, the Manager will act like we are on Windows.
2024-04-18 14:38:28 - Steam Folder was found through Windows method at: C:\Program Files (x86)\Steam
2024-04-18 14:38:28 - Now looking for Steam config file...
2024-04-18 14:38:28 - libraryfolders.vdf file found... now attempting to get paths...
2024-04-18 14:38:28 - Path Found: C:\Program Files (x86)\Steam
2024-04-18 14:38:28 -
Auto Game Detection starts now...
2024-04-18 14:38:28 - Now looking for games in the same folder as the Manager...
2024-04-18 14:38:28 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\sonic.exe
2024-04-18 14:38:28 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\sonic2app.exe
2024-04-18 14:38:28 - Now looking for games through Steam...
2024-04-18 14:38:28 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure DX
2024-04-18 14:38:28 - Found Game!
2024-04-18 14:38:28 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure 2
2024-04-18 14:38:28 - Found Game!
2024-04-18 14:38:28 - SA Mod Manager (Dev Build - 1.2.6)
2024-04-18 14:38:28 - Checking for Manager updates...
2024-04-18 14:38:28 - Update found! Displaying Changelog
And here's what I got as an admin:
2024-04-18 14:38:18 - Manager Started! Debug mod enabled.
2024-04-18 14:38:18 - Temp Folder is: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3.SATemp
2024-04-18 14:38:18 - Switching...
2024-04-18 14:38:18 - New Temp Folder is: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp
2024-04-18 14:38:18 - Looking for Manager Update command...
2024-04-18 14:38:18 - doupdate command NOT found.
2024-04-18 14:38:18 - Linux wasn't detected, the Manager will act like we are on Windows.
2024-04-18 14:38:18 - Steam Folder was found through Windows method at: C:\Program Files (x86)\Steam
2024-04-18 14:38:18 - Now looking for Steam config file...
2024-04-18 14:38:18 - libraryfolders.vdf file found... now attempting to get paths...
2024-04-18 14:38:18 - Path Found: C:\Program Files (x86)\Steam
2024-04-18 14:38:18 -
Auto Game Detection starts now...
2024-04-18 14:38:18 - Now looking for games in the same folder as the Manager...
2024-04-18 14:38:18 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\sonic.exe
2024-04-18 14:38:18 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\sonic2app.exe
2024-04-18 14:38:18 - Now looking for games through Steam...
2024-04-18 14:38:18 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure DX
2024-04-18 14:38:18 - Found Game!
2024-04-18 14:38:18 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure 2
2024-04-18 14:38:18 - Found Game!
2024-04-18 14:38:18 - SA Mod Manager (Dev Build - 1.2.6)
2024-04-18 14:38:18 - Checking for Manager updates...
2024-04-18 14:38:18 - Update found! Displaying Changelog
2024-04-18 14:38:21 - User accepted the Manager Update
2024-04-18 14:38:21 - Created SATemp folder.
2024-04-18 14:38:21 - Now Downloading Manager Update
2024-04-18 14:38:21 - DL LINK: https://github.com/X-Hax/SA-Mod-Manager/raw/master/SA-Mod-Manager/Resources/UpdateTest.zip
2024-04-18 14:38:21 - Dest Folder: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp
2024-04-18 14:38:26 - Download Update completed.
2024-04-18 14:38:26 - Extracting: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp\UpdateTest.zip in: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp
2024-04-18 14:38:26 - Extraction completed, now deleting archive: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp\UpdateTest.zip
2024-04-18 14:38:26 - Starting New Manager at: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp\SAModManager.exe
2024-04-18 14:38:27 - Manager Started! Debug mod enabled.
2024-04-18 14:38:27 - Temp Folder is: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp.SATemp
2024-04-18 14:38:27 - Could not find a missing slash in the temp folder. Path should be correct.
2024-04-18 14:38:27 - Looking for Manager Update command...
2024-04-18 14:38:27 - doupdate command found.
2024-04-18 14:38:27 - Installing update...
2024-04-18 14:38:27 - Args 2: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp Args 3: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SAModManager.exe
2024-04-18 14:38:27 - Moving Manager Exe from: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp\SAModManager.exe  to:  C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SAModManager.exe
2024-04-18 14:38:27 - Finished Updating, restarting Manager one more time.
2024-04-18 14:38:28 - Manager Started! Debug mod enabled.
2024-04-18 14:38:28 - Temp Folder is: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3.SATemp
2024-04-18 14:38:28 - Switching...
2024-04-18 14:38:28 - New Temp Folder is: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp
2024-04-18 14:38:28 - Looking for Manager Update command...
2024-04-18 14:38:28 - doupdate command NOT found.
2024-04-18 14:38:28 - Linux wasn't detected, the Manager will act like we are on Windows.
2024-04-18 14:38:28 - Steam Folder was found through Windows method at: C:\Program Files (x86)\Steam
2024-04-18 14:38:28 - Now looking for Steam config file...
2024-04-18 14:38:28 - libraryfolders.vdf file found... now attempting to get paths...
2024-04-18 14:38:28 - Path Found: C:\Program Files (x86)\Steam
2024-04-18 14:38:28 -
Auto Game Detection starts now...
2024-04-18 14:38:28 - Now looking for games in the same folder as the Manager...
2024-04-18 14:38:28 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\sonic.exe
2024-04-18 14:38:28 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\sonic2app.exe
2024-04-18 14:38:28 - Now looking for games through Steam...
2024-04-18 14:38:28 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure DX
2024-04-18 14:38:28 - Found Game!
2024-04-18 14:38:28 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure 2
2024-04-18 14:38:28 - Found Game!
2024-04-18 14:38:28 - SA Mod Manager (Dev Build - 1.2.6)
2024-04-18 14:38:28 - Checking for Manager updates...
2024-04-18 14:38:28 - Update found! Displaying Changelog
2024-04-18 14:39:14 - Manager Started! Debug mod enabled.
2024-04-18 14:39:14 - Temp Folder is: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3.SATemp
2024-04-18 14:39:14 - Switching...
2024-04-18 14:39:14 - New Temp Folder is: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp
2024-04-18 14:39:14 - Looking for Manager Update command...
2024-04-18 14:39:14 - doupdate command NOT found.
2024-04-18 14:39:14 - Linux wasn't detected, the Manager will act like we are on Windows.
2024-04-18 14:39:14 - Steam Folder was found through Windows method at: C:\Program Files (x86)\Steam
2024-04-18 14:39:14 - Now looking for Steam config file...
2024-04-18 14:39:14 - libraryfolders.vdf file found... now attempting to get paths...
2024-04-18 14:39:14 - Path Found: C:\Program Files (x86)\Steam
2024-04-18 14:39:15 -
Auto Game Detection starts now...
2024-04-18 14:39:15 - Now looking for games in the same folder as the Manager...
2024-04-18 14:39:15 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\sonic.exe
2024-04-18 14:39:15 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\sonic2app.exe
2024-04-18 14:39:15 - Now looking for games through Steam...
2024-04-18 14:39:15 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure DX
2024-04-18 14:39:15 - Found Game!
2024-04-18 14:39:15 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure 2
2024-04-18 14:39:15 - Found Game!
2024-04-18 14:39:15 - SA Mod Manager (Dev Build - 1.2.6)
2024-04-18 14:39:15 - Checking for Manager updates...
2024-04-18 14:39:15 - Update found! Displaying Changelog
2024-04-18 14:39:17 - User accepted the Manager Update
2024-04-18 14:39:17 - Created SATemp folder.
2024-04-18 14:39:17 - Now Downloading Manager Update
2024-04-18 14:39:17 - DL LINK: https://github.com/X-Hax/SA-Mod-Manager/raw/master/SA-Mod-Manager/Resources/UpdateTest.zip
2024-04-18 14:39:17 - Dest Folder: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp
2024-04-18 14:39:18 - Download Update completed.
2024-04-18 14:39:18 - Extracting: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp\UpdateTest.zip in: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp
2024-04-18 14:39:19 - Extraction completed, now deleting archive: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp\UpdateTest.zip
2024-04-18 14:39:19 - Starting New Manager at: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp\SAModManager.exe
2024-04-18 14:39:20 - Manager Started! Debug mod enabled.
2024-04-18 14:39:20 - Temp Folder is: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp.SATemp
2024-04-18 14:39:20 - Could not find a missing slash in the temp folder. Path should be correct.
2024-04-18 14:39:20 - Looking for Manager Update command...
2024-04-18 14:39:20 - doupdate command found.
2024-04-18 14:39:20 - Installing update...
2024-04-18 14:39:20 - Args 2: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp Args 3: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SAModManager.exe
2024-04-18 14:39:20 - Moving Manager Exe from: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp\SAModManager.exe  to:  C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SAModManager.exe
2024-04-18 14:39:20 - Finished Updating, restarting Manager one more time.
2024-04-18 14:39:20 - Manager Started! Debug mod enabled.
2024-04-18 14:39:20 - Temp Folder is: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3.SATemp
2024-04-18 14:39:20 - Switching...
2024-04-18 14:39:20 - New Temp Folder is: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\SATemp
2024-04-18 14:39:20 - Looking for Manager Update command...
2024-04-18 14:39:20 - doupdate command NOT found.
2024-04-18 14:39:20 - Linux wasn't detected, the Manager will act like we are on Windows.
2024-04-18 14:39:20 - Steam Folder was found through Windows method at: C:\Program Files (x86)\Steam
2024-04-18 14:39:20 - Now looking for Steam config file...
2024-04-18 14:39:20 - libraryfolders.vdf file found... now attempting to get paths...
2024-04-18 14:39:20 - Path Found: C:\Program Files (x86)\Steam
2024-04-18 14:39:20 -
Auto Game Detection starts now...
2024-04-18 14:39:20 - Now looking for games in the same folder as the Manager...
2024-04-18 14:39:20 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\sonic.exe
2024-04-18 14:39:20 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_3\sonic2app.exe
2024-04-18 14:39:20 - Now looking for games through Steam...
2024-04-18 14:39:20 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure DX
2024-04-18 14:39:20 - Found Game!
2024-04-18 14:39:20 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure 2
2024-04-18 14:39:20 - Found Game!
2024-04-18 14:39:20 - SA Mod Manager (Dev Build - 1.2.6)
2024-04-18 14:39:21 - Checking for Manager updates...
2024-04-18 14:39:21 - Update found! Displaying Changelog

Sorry about no response, I will check when I get home (I’ll set an alarm) I
think it did the same thing however
On Thu, Apr 18, 2024 at 9:08 AM dqf318 @.***> wrote:

Well, if OwenDino-Studios isn't going to, I guess I will:
2024-04-18 09:07:06 - Manager Started! Debug mod enabled.
2024-04-18 09:07:06 - Looking for Manager Update command...
2024-04-18 09:07:06 - doupdate command NOT found.
2024-04-18 09:07:06 - Linux wasn't detected, the Manager will act like we
are on Windows.
2024-04-18 09:07:06 - Steam Folder was found through Windows method at:
C:\Program Files (x86)\Steam
2024-04-18 09:07:06 - Now looking for Steam config file...
2024-04-18 09:07:06 - libraryfolders.vdf file found... now attempting to
get paths...
2024-04-18 09:07:06 - Path Found: C:\Program Files (x86)\Steam
2024-04-18 09:07:06 -
Auto Game Detection starts now...
2024-04-18 09:07:06 - Now looking for games in the same folder as the
Manager...
2024-04-18 09:07:06 - Checking for:
C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build\sonic.exe
2024-04-18 09:07:06 - Checking for:
C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build\sonic2app.exe
2024-04-18 09:07:06 - Now looking for games through Steam...
2024-04-18 09:07:06 - Checking for: C:\Program Files
(x86)\Steam\steamapps\common\Sonic Adventure DX
2024-04-18 09:07:06 - Found Game!
2024-04-18 09:07:06 - Checking for: C:\Program Files
(x86)\Steam\steamapps\common\Sonic Adventure 2
2024-04-18 09:07:06 - Found Game!
2024-04-18 09:07:06 - SA Mod Manager (1.2.6 - 7bc52af
https://github.com/X-Hax/SA-Mod-Manager/commit/7bc52af9d6773dec275c656f248ce0d32cba5db0
)
2024-04-18 09:07:06 - Checking for Manager updates...
2024-04-18 09:07:06 - Display Changelog
2024-04-18 09:07:10 - User accepted the Manager Update
2024-04-18 09:07:10 - Created SATemp folder.
2024-04-18 09:07:10 - Now Downloading Manager Update
2024-04-18 09:07:10 - DL LINK:
https://github.com/X-Hax/SA-Mod-Manager/raw/master/SA-Mod-Manager/Resources/UpdateTest.zip
2024-04-18 09:07:10 - Dest Folder:
C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build.SATemp
2024-04-18 09:07:11 - Download Update completed.
2024-04-18 09:07:11 - Extracting:
C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build.SATemp\UpdateTest.zip
in: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build.SATemp
2024-04-18 09:07:11 - Extraction completed, now deleting archive:
C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build.SATemp\UpdateTest.zip
2024-04-18 09:07:11 - Starting New Manager at:
C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build.SATemp\SAModManager.exe
2024-04-18 09:07:12 - Manager Started! Debug mod enabled.
2024-04-18 09:07:12 - Looking for Manager Update command...
2024-04-18 09:07:12 - doupdate command found.
2024-04-18 09:07:12 - Installing update...
2024-04-18 09:07:12 - Args 2:
C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build.SATempArgs 3:
C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build\SAModManager.exe
2024-04-18 09:07:12 - Moving Manager Exe from:
C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build.SATemp\SAModManager.exeto:
C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build\SAModManager.exe
2024-04-18 09:07:12 - Finished Updating, restarting Manager one more time.
2024-04-18 09:07:13 - Manager Started! Debug mod enabled.
2024-04-18 09:07:13 - Looking for Manager Update command...
2024-04-18 09:07:13 - doupdate command NOT found.
2024-04-18 09:07:13 - Linux wasn't detected, the Manager will act like we
are on Windows.
2024-04-18 09:07:13 - Steam Folder was found through Windows method at:
C:\Program Files (x86)\Steam
2024-04-18 09:07:13 - Now looking for Steam config file...
2024-04-18 09:07:13 - libraryfolders.vdf file found... now attempting to
get paths...
2024-04-18 09:07:13 - Path Found: C:\Program Files (x86)\Steam
2024-04-18 09:07:13 -
Auto Game Detection starts now...
2024-04-18 09:07:13 - Now looking for games in the same folder as the
Manager...
2024-04-18 09:07:13 - Checking for:
C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build\sonic.exe
2024-04-18 09:07:13 - Checking for:
C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build\sonic2app.exe
2024-04-18 09:07:13 - Now looking for games through Steam...
2024-04-18 09:07:13 - Checking for: C:\Program Files
(x86)\Steam\steamapps\common\Sonic Adventure DX
2024-04-18 09:07:13 - Found Game!
2024-04-18 09:07:13 - Checking for: C:\Program Files
(x86)\Steam\steamapps\common\Sonic Adventure 2
2024-04-18 09:07:13 - Found Game!
2024-04-18 09:07:13 - SA Mod Manager (1.2.6 - 7bc52af
https://github.com/X-Hax/SA-Mod-Manager/commit/7bc52af9d6773dec275c656f248ce0d32cba5db0
)
2024-04-18 09:07:14 - Checking for Manager updates...
2024-04-18 09:07:14 - Display Changelog
Any news on this? These logs would really help.
—
Reply to this email directly, view it on GitHub
https://github.com/X-Hax/SA-Mod-Manager/issues/57#issuecomment-2063829169,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BFPGXYT5EA5VP3LXG3VXVKLY57AVHAVCNFSM6AAAAABCCWQROWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRTHAZDSMJWHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Here is a video attached, I’ll send the log file in a second email
On Sun, Apr 7, 2024 at 5:52 PM Sora @.***> wrote:

Thanks for the answer. Can you try with this specific build?
SAModManager_Test_Update_Build.zip
https://github.com/X-Hax/SA-Mod-Manager/files/14899065/SAModManager_Test_Update_Build.zip
When running it, it will ask you to update, just do it and let me know how
it goes, it should download, install and restart itself. Once the restart
is done, you should read on top 1.2.7 instead of 1.2.6.
Additionally, this build will logs all the information during the update
process in a txt file named "application.log", in the same folder than
the Manager.
If the issue persist after the update, please share the log file, this
will be useful for debugging.
—
Reply to this email directly, view it on GitHub
https://github.com/X-Hax/SA-Mod-Manager/issues/57#issuecomment-2041620402,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BFPGXYUI2VJFTRRB27JRHPLY4G52TAVCNFSM6AAAAABCCWQROWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGYZDANBQGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

On Thu, Apr 18, 2024 at 6:44 PM OwenDino Studios @.***>
wrote:

Here is a video attached, I’ll send the log file in a second email
On Sun, Apr 7, 2024 at 5:52 PM Sora @.***> wrote:

Thanks for the answer. Can you try with this specific build?
SAModManager_Test_Update_Build.zip
https://github.com/X-Hax/SA-Mod-Manager/files/14899065/SAModManager_Test_Update_Build.zip
When running it, it will ask you to update, just do it and let me know
how it goes, it should download, install and restart itself. Once the
restart is done, you should read on top 1.2.7 instead of 1.2.6.
Additionally, this build will logs all the information during the update
process in a txt file named "application.log", in the same folder than
the Manager.
If the issue persist after the update, please share the log file, this
will be useful for debugging.
—
Reply to this email directly, view it on GitHub
https://github.com/X-Hax/SA-Mod-Manager/issues/57#issuecomment-2041620402,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BFPGXYUI2VJFTRRB27JRHPLY4G52TAVCNFSM6AAAAABCCWQROWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGYZDANBQGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Sorry for the very late answer, I've been busy and also I had no other ideas at that point, I attempted to re create the issue on a Windows 11 VM, but the update also worked fine there, so this is still very confusing to me. It's difficult to understand what's going on without being able to reproduce the bug, so I hope you can understand that and I appreciate your patience.
The way the update system works is it downloads the update in a folder called SATemp, extract it, open the new exe, then the new version is supposed to copy itself to replace the old exe and finally restart itself after the copy finished.
Based on what you both tell me and the logs, my theory is that the copy fails somehow and the previous exe is still there and that's why it ends being a loop with the update never finishing properly. It's possible that the copy fails because of a perm issue or maybe a race condition (ie the exe gets run before the copy finished).
With that in mind, I reworked the way the copy is handled with an attempt to wait that the old exe is closed before installing the new version. If you all can attempt this build, that would be appreciated.
SAModManager_Test_Update_Build_4.zip

Did the update, and it worked!  Here's the log:
2024-05-17 09:32:19 - Linux wasn't detected, the Manager will act like we are on Windows.
2024-05-17 09:32:19 - Steam Folder was found through Windows method at: C:\Program Files (x86)\Steam
2024-05-17 09:32:19 - Now looking for Steam config file...
2024-05-17 09:32:19 - libraryfolders.vdf file found... now attempting to get paths...
2024-05-17 09:32:19 - Path Found: C:\Program Files (x86)\Steam
2024-05-17 09:32:32 - Linux wasn't detected, the Manager will act like we are on Windows.
2024-05-17 09:32:32 - Steam Folder was found through Windows method at: C:\Program Files (x86)\Steam
2024-05-17 09:32:32 - Now looking for Steam config file...
2024-05-17 09:32:32 - libraryfolders.vdf file found... now attempting to get paths...
2024-05-17 09:32:32 - Path Found: C:\Program Files (x86)\Steam
2024-05-17 09:32:32 -
Auto Game Detection starts now...
2024-05-17 09:32:32 - Now looking for games in the same folder as the Manager...
2024-05-17 09:32:32 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_4\sonic.exe
2024-05-17 09:32:32 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_4\sonic2app.exe
2024-05-17 09:32:32 - Now looking for games through Steam...
2024-05-17 09:32:32 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure DX
2024-05-17 09:32:32 - Found Game!
2024-05-17 09:32:32 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure 2
2024-05-17 09:32:32 - Found Game!
2024-05-17 09:32:35 - Now Installing New Manager Update...
2024-05-17 09:32:38 - New Version installed!!!
2024-05-17 09:32:38 - DoUpdate command started
2024-05-17 09:32:38 - Now Replacing old exe...
2024-05-17 09:32:39 - New Version installed!!!
2024-05-17 09:32:39 - Linux wasn't detected, the Manager will act like we are on Windows.
2024-05-17 09:32:39 - Steam Folder was found through Windows method at: C:\Program Files (x86)\Steam
2024-05-17 09:32:39 - Now looking for Steam config file...
2024-05-17 09:32:39 - libraryfolders.vdf file found... now attempting to get paths...
2024-05-17 09:32:39 - Path Found: C:\Program Files (x86)\Steam
2024-05-17 09:32:39 -
Auto Game Detection starts now...
2024-05-17 09:32:39 - Now looking for games in the same folder as the Manager...
2024-05-17 09:32:39 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_4\sonic.exe
2024-05-17 09:32:39 - Checking for: C:\Users\dqf31\Downloads\SAModManager_Test_Update_Build_4\sonic2app.exe
2024-05-17 09:32:39 - Now looking for games through Steam...
2024-05-17 09:32:39 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure DX
2024-05-17 09:32:39 - Found Game!
2024-05-17 09:32:39 - Checking for: C:\Program Files (x86)\Steam\steamapps\common\Sonic Adventure 2
2024-05-17 09:32:39 - Found Game!

Thanks for testing, the new Manager update has been made public, so this issue should now be fixed. Although doing a regular update from 1.2.8 to 1.2.9 might not work for you guys since it's lacking the fixes made in 1.2.9, but starting from this new version, all the new updates should work fine. Thanks again for your patience and testing.

Tried it in the manager, and actually, it did what it was supposed to.


Re-work appearance of sourcecheme

Updated in https://github.com/rbjaxter/budhud/commit/9c29969362b537a859844d30a716e80a9173f7ca


Can you specify polyphonic words when you encounter them in your reasoning?

Checks

[X] This template is only for question, not feature requests or bug reports.
[X] I have thoroughly reviewed the project documentation and read the related paper(s).
[X] I have searched for existing issues, including closed ones, no similar questions.
[X] I confirm that I am using English to submit this report in order to facilitate communication.

Question details
If there is a polyphonic word in the given text, can the pronunciation of this word be fixed while reasoning?

I have searched for existing issues, including closed ones, no similar questions.

you can refer to previous issue
polyphonic 多音字 etc.


build errors on opensuse

Guys,
I'm trying to get things rolling on openSUSE Tumbleweed. So far so good, but during build I'm getting this error:
/home/harry/dev/hypervisor/bfelf_loader/test/test.cpp:263:20: error: could not convert ‘false’ from ‘bool’ to ‘std::shared_ptr’
Could you help out?

Huh.... yeah that code is wrong. It should return nullptr on both (there is more than one) "return false".

I merged a fix for your issue. Let me know if that helps. We have not tested OpenSUSE yet but it should work so long as you have a GCC compiler >= 4.9 and CMake >= 3.0. Let us know how it goes.

Thanks! I'll try it out this weekend. I've got an setup-opensuse ready to be merged if it works. I'll keep you posted.

FYI, I should have a PR today that cleans up some of our script naming that will affect what your working on. Specifically, we are removing the "-" from the scripts in favor of "_". So the name of the setup script for OpenSUSE would be "setup_opensuse.sh".

ok, no prob.

@spockfish this has been fixed in the following PR: https://github.com/Bareflank/hypervisor/pull/349
I updated the scripts to use a setup_common.sh to remove duplication, and the os-release info is now being used were possible. I also updated the script to use OpenSUSE Leap 42.2 instead of Tumbleweed as I would prefer to have a stable release to work from when possible. Although OpenSUSE takes a lot longer to install / compile Bareflank, it works great once it's all setup.


Added {String Permutation Problem} [{python}]

A recursive funciton to output a list of all the possible permutations of that string.
For example, given s='abc' the function should return ['abc', 'acb', 'bac', 'bca', 'cab', 'cba']

Fixes #{581}
By submitting this pull request I confirm I've read and complied with the below declarations.

[x] I have read the Contribution guidelines and I am confident that my PR reflects them.
[x] I have followed the coding guidelines for this project.
[x] My code follows the skeleton code structure.
[x] This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
[x] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.

Hi! Thanks for showing interest in contributing to this repository.
Please make sure that you have ticked the points mentioned in PR description correctly.
Thanks again!

Please open an issue and add extension to the file.

Comment on 5fe0478c998733d3dc48ccced021dffdb3f2f8d8, file string_permutation/permute.py, line 9.
Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.
The issue can be fixed by applying the following patch:
--- a/tmp/tmp6rhzt9zx/string_permutation/permute.py
+++ b/tmp/tmp6rhzt9zx/string_permutation/permute.py
@@ -6,7 +6,7 @@
 For example, given s='abc' the function should return ['abc', 'acb', 'bac', 'bca', 'cab', 'cba']
 '''
     out = []
-
+
     # Base Case
     if len(s) == 1:
         out = [s]

Comment on 5fe0478c998733d3dc48ccced021dffdb3f2f8d8, file string_permutation/permute.py, line 13.
Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.
The issue can be fixed by applying the following patch:
--- a/tmp/tmp6rhzt9zx/string_permutation/permute.py
+++ b/tmp/tmp6rhzt9zx/string_permutation/permute.py
@@ -10,7 +10,7 @@
     # Base Case
     if len(s) == 1:
         out = [s]
-
+
     else:
         # For every letter in string
         for i, let in enumerate(s):

Comment on 5fe0478c998733d3dc48ccced021dffdb3f2f8d8, file string_permutation/permute.py, line 17.
Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.
The issue can be fixed by applying the following patch:
--- a/tmp/tmp6rhzt9zx/string_permutation/permute.py
+++ b/tmp/tmp6rhzt9zx/string_permutation/permute.py
@@ -14,7 +14,7 @@
     else:
         # For every letter in string
         for i, let in enumerate(s):
-
+
             # For every permutation resulting from Step 2 and 3 described above
             for perm in permute(s[:i] + s[i+1:]):

Comment on 5fe0478c998733d3dc48ccced021dffdb3f2f8d8, file string_permutation/permute.py, line 25.
Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.
The issue can be fixed by applying the following patch:
--- a/tmp/tmp6rhzt9zx/string_permutation/permute.py
+++ b/tmp/tmp6rhzt9zx/string_permutation/permute.py
@@ -22,7 +22,7 @@
                 out += [let + perm]

     return out
-
+
 def main():
   permute('abc')

Comment on 5fe0478c998733d3dc48ccced021dffdb3f2f8d8, file string_permutation/permute.py, line 20.
Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.
The issue can be fixed by applying the following patch:
--- a/tmp/tmp6rhzt9zx/string_permutation/permute.py
+++ b/tmp/tmp6rhzt9zx/string_permutation/permute.py
@@ -17,7 +17,7 @@

             # For every permutation resulting from Step 2 and 3 described above
             for perm in permute(s[:i] + s[i+1:]):
-
+
                 # Add it to output
                 out += [let + perm]

Comment on 5fe0478c998733d3dc48ccced021dffdb3f2f8d8, file string_permutation/permute.py, line 29.
Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.
The issue can be fixed by applying the following patch:
--- a/tmp/tmp6rhzt9zx/string_permutation/permute.py
+++ b/tmp/tmp6rhzt9zx/string_permutation/permute.py
@@ -26,6 +26,6 @@
 def main():
   permute('abc')

-
+
 if __name__ == '__main__':
     main()

Comment on 5fe0478c998733d3dc48ccced021dffdb3f2f8d8, file string_permutation/permute.py, line 1.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmp6rhzt9zx/string_permutation/permute.py
+++ b/tmp/tmp6rhzt9zx/string_permutation/permute.py
@@ -1,4 +1,5 @@
 def permute(s):
+

 '''
 A recursive funciton to output a list of all the possible permutations of that string.

Comment on 5fe0478c998733d3dc48ccced021dffdb3f2f8d8, file string_permutation/permute.py, line 9.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmp6rhzt9zx/string_permutation/permute.py
+++ b/tmp/tmp6rhzt9zx/string_permutation/permute.py
@@ -6,7 +6,7 @@
 For example, given s='abc' the function should return ['abc', 'acb', 'bac', 'bca', 'cab', 'cba']
 '''
     out = []
-
+
     # Base Case
     if len(s) == 1:
         out = [s]

Comment on 5fe0478c998733d3dc48ccced021dffdb3f2f8d8, file string_permutation/permute.py, line 13.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmp6rhzt9zx/string_permutation/permute.py
+++ b/tmp/tmp6rhzt9zx/string_permutation/permute.py
@@ -10,7 +10,7 @@
     # Base Case
     if len(s) == 1:
         out = [s]
-
+
     else:
         # For every letter in string
         for i, let in enumerate(s):

Comment on 5fe0478c998733d3dc48ccced021dffdb3f2f8d8, file string_permutation/permute.py, line 17.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmp6rhzt9zx/string_permutation/permute.py
+++ b/tmp/tmp6rhzt9zx/string_permutation/permute.py
@@ -14,7 +14,7 @@
     else:
         # For every letter in string
         for i, let in enumerate(s):
-
+
             # For every permutation resulting from Step 2 and 3 described above
             for perm in permute(s[:i] + s[i+1:]):

Comment on 5fe0478c998733d3dc48ccced021dffdb3f2f8d8, file string_permutation/permute.py, line 20.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmp6rhzt9zx/string_permutation/permute.py
+++ b/tmp/tmp6rhzt9zx/string_permutation/permute.py
@@ -17,7 +17,7 @@

             # For every permutation resulting from Step 2 and 3 described above
             for perm in permute(s[:i] + s[i+1:]):
-
+
                 # Add it to output
                 out += [let + perm]

Comment on 5fe0478c998733d3dc48ccced021dffdb3f2f8d8, file string_permutation/permute.py, line 25.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmp6rhzt9zx/string_permutation/permute.py
+++ b/tmp/tmp6rhzt9zx/string_permutation/permute.py
@@ -22,10 +22,11 @@
                 out += [let + perm]

     return out
-
+
+
 def main():
-  permute('abc')
+    permute('abc')

-
+
 if __name__ == '__main__':
     main()

Comment on ddc780bb7de8ae1bad403ed2530607ac077da53a, file string_permutation_problem.py, line 9.
Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.
The issue can be fixed by applying the following patch:
--- a/tmp/tmppaaj6dk8/string_permutation_problem.py
+++ b/tmp/tmppaaj6dk8/string_permutation_problem.py
@@ -6,7 +6,7 @@
 For example, given s='abc' the function should return ['abc', 'acb', 'bac', 'bca', 'cab', 'cba']
 '''
     out = []
-
+
     # Base Case
     if len(s) == 1:
         out = [s]

Comment on ddc780bb7de8ae1bad403ed2530607ac077da53a, file string_permutation_problem.py, line 13.
Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.
The issue can be fixed by applying the following patch:
--- a/tmp/tmppaaj6dk8/string_permutation_problem.py
+++ b/tmp/tmppaaj6dk8/string_permutation_problem.py
@@ -10,7 +10,7 @@
     # Base Case
     if len(s) == 1:
         out = [s]
-
+
     else:
         # For every letter in string
         for i, let in enumerate(s):

Comment on ddc780bb7de8ae1bad403ed2530607ac077da53a, file string_permutation_problem.py, line 17.
Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.
The issue can be fixed by applying the following patch:
--- a/tmp/tmppaaj6dk8/string_permutation_problem.py
+++ b/tmp/tmppaaj6dk8/string_permutation_problem.py
@@ -14,7 +14,7 @@
     else:
         # For every letter in string
         for i, let in enumerate(s):
-
+
             # For every permutation resulting from Step 2 and 3 described above
             for perm in permute(s[:i] + s[i+1:]):

Comment on ddc780bb7de8ae1bad403ed2530607ac077da53a, file string_permutation_problem.py, line 20.
Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.
The issue can be fixed by applying the following patch:
--- a/tmp/tmppaaj6dk8/string_permutation_problem.py
+++ b/tmp/tmppaaj6dk8/string_permutation_problem.py
@@ -17,7 +17,7 @@

             # For every permutation resulting from Step 2 and 3 described above
             for perm in permute(s[:i] + s[i+1:]):
-
+
                 # Add it to output
                 out += [let + perm]

Comment on ddc780bb7de8ae1bad403ed2530607ac077da53a, file string_permutation_problem.py, line 25.
Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.
The issue can be fixed by applying the following patch:
--- a/tmp/tmppaaj6dk8/string_permutation_problem.py
+++ b/tmp/tmppaaj6dk8/string_permutation_problem.py
@@ -22,7 +22,7 @@
                 out += [let + perm]

     return out
-
+
 def main():
   permute('abc')

Comment on ddc780bb7de8ae1bad403ed2530607ac077da53a, file string_permutation_problem.py, line 29.
Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.
The issue can be fixed by applying the following patch:
--- a/tmp/tmppaaj6dk8/string_permutation_problem.py
+++ b/tmp/tmppaaj6dk8/string_permutation_problem.py
@@ -26,6 +26,6 @@
 def main():
   permute('abc')

-
+
 if __name__ == '__main__':
     main()

Comment on ddc780bb7de8ae1bad403ed2530607ac077da53a, file string_permutation_problem.py, line 1.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmppaaj6dk8/string_permutation_problem.py
+++ b/tmp/tmppaaj6dk8/string_permutation_problem.py
@@ -1,4 +1,5 @@
 def permute(s):
+

 '''
 A recursive funciton to output a list of all the possible permutations of that string.

Comment on ddc780bb7de8ae1bad403ed2530607ac077da53a, file string_permutation_problem.py, line 9.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmppaaj6dk8/string_permutation_problem.py
+++ b/tmp/tmppaaj6dk8/string_permutation_problem.py
@@ -6,7 +6,7 @@
 For example, given s='abc' the function should return ['abc', 'acb', 'bac', 'bca', 'cab', 'cba']
 '''
     out = []
-
+
     # Base Case
     if len(s) == 1:
         out = [s]

Comment on ddc780bb7de8ae1bad403ed2530607ac077da53a, file string_permutation_problem.py, line 13.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmppaaj6dk8/string_permutation_problem.py
+++ b/tmp/tmppaaj6dk8/string_permutation_problem.py
@@ -10,7 +10,7 @@
     # Base Case
     if len(s) == 1:
         out = [s]
-
+
     else:
         # For every letter in string
         for i, let in enumerate(s):

Comment on ddc780bb7de8ae1bad403ed2530607ac077da53a, file string_permutation_problem.py, line 17.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmppaaj6dk8/string_permutation_problem.py
+++ b/tmp/tmppaaj6dk8/string_permutation_problem.py
@@ -14,7 +14,7 @@
     else:
         # For every letter in string
         for i, let in enumerate(s):
-
+
             # For every permutation resulting from Step 2 and 3 described above
             for perm in permute(s[:i] + s[i+1:]):

Comment on ddc780bb7de8ae1bad403ed2530607ac077da53a, file string_permutation_problem.py, line 20.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmppaaj6dk8/string_permutation_problem.py
+++ b/tmp/tmppaaj6dk8/string_permutation_problem.py
@@ -17,7 +17,7 @@

             # For every permutation resulting from Step 2 and 3 described above
             for perm in permute(s[:i] + s[i+1:]):
-
+
                 # Add it to output
                 out += [let + perm]

Comment on ddc780bb7de8ae1bad403ed2530607ac077da53a, file string_permutation_problem.py, line 25.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmppaaj6dk8/string_permutation_problem.py
+++ b/tmp/tmppaaj6dk8/string_permutation_problem.py
@@ -22,10 +22,11 @@
                 out += [let + perm]

     return out
-
+
+
 def main():
-  permute('abc')
+    permute('abc')

-
+
 if __name__ == '__main__':
     main()

Comment on 09584d692677153fd9300225dabeb8d993b8d6b3, file string_permutation_problem.py, line 9.
Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpg2gzjux8/string_permutation_problem.py
+++ b/tmp/tmpg2gzjux8/string_permutation_problem.py
@@ -6,7 +6,7 @@
 For example, given s='abc' the function should return ['abc', 'acb', 'bac', 'bca', 'cab', 'cba']
 '''
     out = []
-
+
     # Base Case
     if len(s) == 1:
         out = [s]

Comment on 09584d692677153fd9300225dabeb8d993b8d6b3, file string_permutation_problem.py, line 13.
Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpg2gzjux8/string_permutation_problem.py
+++ b/tmp/tmpg2gzjux8/string_permutation_problem.py
@@ -10,7 +10,7 @@
     # Base Case
     if len(s) == 1:
         out = [s]
-
+
     else:
         # For every letter in string
         for i, let in enumerate(s):

Comment on 09584d692677153fd9300225dabeb8d993b8d6b3, file string_permutation_problem.py, line 20.
Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpg2gzjux8/string_permutation_problem.py
+++ b/tmp/tmpg2gzjux8/string_permutation_problem.py
@@ -17,7 +17,7 @@

             # For every permutation resulting from Step 2 and 3 described above
             for perm in permute(s[:i] + s[i+1:]):
-
+
                 # Add it to output
                 out += [let + perm]

Comment on 09584d692677153fd9300225dabeb8d993b8d6b3, file string_permutation_problem.py, line 17.
Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpg2gzjux8/string_permutation_problem.py
+++ b/tmp/tmpg2gzjux8/string_permutation_problem.py
@@ -14,7 +14,7 @@
     else:
         # For every letter in string
         for i, let in enumerate(s):
-
+
             # For every permutation resulting from Step 2 and 3 described above
             for perm in permute(s[:i] + s[i+1:]):

Comment on 09584d692677153fd9300225dabeb8d993b8d6b3, file string_permutation_problem.py, line 25.
Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpg2gzjux8/string_permutation_problem.py
+++ b/tmp/tmpg2gzjux8/string_permutation_problem.py
@@ -22,7 +22,7 @@
                 out += [let + perm]

     return out
-
+
 def main():
   permute('abc')

Comment on 09584d692677153fd9300225dabeb8d993b8d6b3, file string_permutation_problem.py, line 29.
Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpg2gzjux8/string_permutation_problem.py
+++ b/tmp/tmpg2gzjux8/string_permutation_problem.py
@@ -26,6 +26,6 @@
 def main():
   permute('abc')

-
+
 if __name__ == '__main__':
     main()

Comment on 09584d692677153fd9300225dabeb8d993b8d6b3, file string_permutation_problem.py, line 1.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpg2gzjux8/string_permutation_problem.py
+++ b/tmp/tmpg2gzjux8/string_permutation_problem.py
@@ -1,4 +1,5 @@
 def permute(s):
+

 '''
 A recursive funciton to output a list of all the possible permutations of that string.

Comment on 09584d692677153fd9300225dabeb8d993b8d6b3, file string_permutation_problem.py, line 9.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpg2gzjux8/string_permutation_problem.py
+++ b/tmp/tmpg2gzjux8/string_permutation_problem.py
@@ -6,7 +6,7 @@
 For example, given s='abc' the function should return ['abc', 'acb', 'bac', 'bca', 'cab', 'cba']
 '''
     out = []
-
+
     # Base Case
     if len(s) == 1:
         out = [s]

Comment on 09584d692677153fd9300225dabeb8d993b8d6b3, file string_permutation_problem.py, line 13.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpg2gzjux8/string_permutation_problem.py
+++ b/tmp/tmpg2gzjux8/string_permutation_problem.py
@@ -10,7 +10,7 @@
     # Base Case
     if len(s) == 1:
         out = [s]
-
+
     else:
         # For every letter in string
         for i, let in enumerate(s):

Comment on 09584d692677153fd9300225dabeb8d993b8d6b3, file string_permutation_problem.py, line 17.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpg2gzjux8/string_permutation_problem.py
+++ b/tmp/tmpg2gzjux8/string_permutation_problem.py
@@ -14,7 +14,7 @@
     else:
         # For every letter in string
         for i, let in enumerate(s):
-
+
             # For every permutation resulting from Step 2 and 3 described above
             for perm in permute(s[:i] + s[i+1:]):

Comment on 09584d692677153fd9300225dabeb8d993b8d6b3, file string_permutation_problem.py, line 20.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpg2gzjux8/string_permutation_problem.py
+++ b/tmp/tmpg2gzjux8/string_permutation_problem.py
@@ -17,7 +17,7 @@

             # For every permutation resulting from Step 2 and 3 described above
             for perm in permute(s[:i] + s[i+1:]):
-
+
                 # Add it to output
                 out += [let + perm]

Comment on 09584d692677153fd9300225dabeb8d993b8d6b3, file string_permutation_problem.py, line 25.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpg2gzjux8/string_permutation_problem.py
+++ b/tmp/tmpg2gzjux8/string_permutation_problem.py
@@ -22,10 +22,11 @@
                 out += [let + perm]

     return out
-
+
+
 def main():
-  permute('abc')
+    permute('abc')

-
+
 if __name__ == '__main__':
     main()

Please do not create multiple PRs for the same problem.


erc-712: Adds proposal events for calling webhooks

This code borrows from the latest master of Snapshot Hub to process events for the purpose of calling webhooks.
I have first added to the erc-712 branch as I thought it best to test on Muse0 production first. Additionally, many of our new DAOs are Tribute DAOs.
Changes proposed in this pull request:

Adds new events table
Adds events/index for processing events at an interval
Adds events to the database on proposal submission
Adds **/subscribers/local.json to .gitignore
Adds subscribers/local.example.json
Adds qoomon/docker-host to local Docker Compose file for allowing traffic to reach the Docker host
Adds new env var SERVICE_EVENTS
Adds cross-fetch lib
Adds @types/pg

TODO

[x] Add SERVICE_EVENTS=1 to Kubernetes config file in lao-backends

In addition to merging these changes into erc-712 branch you should also apply them to branch-v5.0.1-erc712 branch. Our production Tribute DAOs (including Muse0) are using releases created from that branch.
The erc-712 branch has been updated to keep up with the latest changes in tribute-contracts, but our production Tribute DAOs haven't been updated for all that yet. That's the reason we had to create the branch-v5.0.1-erc712 branch.

In addition to merging these changes into erc-712 branch you should also apply them to branch-v5.0.1-erc712 branch. Our production Tribute DAOs (including Muse0) are using releases created from that branch.
The erc-712 branch has been updated to keep up with the latest changes in tribute-contracts, but our production Tribute DAOs haven't been updated for all that yet. That's the reason we had to create the branch-v5.0.1-erc712 branch.

Thank you - whew good to know this.


Inconsistency between JS and Scheme backends regarding Unicode (double-)escapes

Hello dear team,
I seem to have encountered an inconsistency between the behaviour of programs compiled for the JS backend and for the Chez Scheme backend in the context of doubly escaped Unicode codepoints in strings.
The following line, compiled for the Node.js backend and executed in a Windows console:
println("\\u000A is the Unicode representation of \\n")
prints, as expected:

\u000A is the Unicode representation of \n

However, when compiled for the Chez Scheme backend, it prints:

\012 is the Unicode representation of \n

The generated Scheme code is (println_1 "\\012 is the Unicode representation of \\n").
Apparently, the Scheme version partly honours the double escape (insofar as it preserves it, and doesn't print an actual newline), but nevertheless converts the hexadecimal Unicode value into its octal representation.
Triple-quoting doesn't prevent that either.
Unless I'm missing or misunderstanding something, this currently makes it necessary to use a workaround like
println("\\" ++ "u000A")
to print

\u000A

literally on the Scheme backend.
(Tested on Effekt from 2024-09-13, as of commit 19089d3)
Kind regards,
Michael

Hi @sideburns3000,
thanks for the very nice and detailed issue!
This indeed looks like something we might want to fix.
As far as I can tell, in both backends (JS and Chez rest.), we just search-and-replace these characters in order to escape:
https://github.com/effekt-lang/effekt/blob/22ebac276e7f75ac45bd2e95646f5e6d3ad78540/effekt/shared/src/main/scala/effekt/generator/js/Transformer.scala#L23
https://github.com/effekt-lang/effekt/blob/22ebac276e7f75ac45bd2e95646f5e6d3ad78540/effekt/shared/src/main/scala/effekt/generator/chez/Transformer.scala#L46
But then in Chez, we do the following:
https://github.com/effekt-lang/effekt/blob/22ebac276e7f75ac45bd2e95646f5e6d3ad78540/effekt/shared/src/main/scala/effekt/generator/chez/package.scala#L78-L88
which is fine, but I think we should merge this with the escape function and actually make sure we process \\ first (cc @b-studios), or at least modify the regex.
This is related to #521 and the need to revamp escapes a little bit.


Fixing permissions

Description

Please include a summary of the change and, if applicable, which issue is fixed. Please also include relevant motivation, context, and screenshots.
Fixed permissions to ensure admin privileges.

Testing

Please briefly note how you tested and verified your changes.
Tested to ensure normal behavior with admin.

Reviewers

Tag one or two teammates to review your code. Ideally, you should tag people who have worked on the same files or similar features to notify them of your changes. If you pair programmed with someone, please indicate that here as well.

Checklist

[X] I ran python manage.py format to autoformat my code according to the style guidelines of this project
[X] I have commented my code, particularly in hard-to-understand areas

Trying to get my commits up.


implement BestIndex estimated cost and usable constraint for when rep…

…ository is supplied

Codecov Report

Merging #153 (7181f04) into main (f21a89a) will decrease coverage by 0.08%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   68.47%   68.38%   -0.09%
==========================================
  Files          29       29
  Lines        1589     1594       +5
==========================================
+ Hits         1088     1090       +2
- Misses        321      323       +2
- Partials      180      181       +1

Impacted Files
Coverage Δ

tables/internal/git/log.go
77.94% <50.00%> (-1.45%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f21a89a...7181f04. Read the comment docs.


Draft docs for recognition and sponsorship

These are for two related purposes:

recognise help from people and orgs (mainly orgs) that isn't time and effort; like, free CI accounts

make room for sponsorships, which opens up another way for people and orgs (mainly orgs) to help the Flux project

I expect these will need a few iterations. I just wanted to get them in view.
Also see the discussion in https://github.com/fluxcd/flux2/discussions/4335 -- comment where you are most comfortable :-)

@squaremo I'd love to help getting this merged asap. There's only 2 comments open that sound like they're pretty quickly addressed. wdyt?

I rebased this from 1858baaa and I may have messed up one of your signatures @squaremo - sorry about that!


feat(circle): disables linter for ci build

Short description of what this resolves:
As we have now golangci as separated PR check this will disable linter for CI build on CircleCI.
Changes proposed in this pull request:

explicitly defines the default goal (all)
introduces build-ci target without linter
switches to build-ci for circle-ci builds
first compiles then run tests for all and build-ci

Fixes #157

@aslakknutsen This PR will be exceptionally merged w/o the review as you are not available this and coming week. Adding you as a reviewer though so you can see what has been changed.


EnterExit.pwn compatibility issue

After trying to test EnterExit.pwn, I realized its using an old version of fader.inc. I tried to update the code for the latest fader.pwn, but it resulted in a bugged entrance. After walking up to the entrance, it fades the screen; but doesn't unfade back (stuck at black screen).

https://github.com/Agneese-Saini/SA-MP/commit/6b522fed467f22a0af097575c3c454a6abc636a6


hostapp-update-hooks:999-resin-boot-cleaner: Clean-ups for EFI

It's been observed on EFI machines that at the first boot after
provisioning there is some bootstrap code in the first sector of
the boot media (even though during provisioning we make sure we
remove this bootstrap code). In such a case (only on some machines),
the next time we reboot the machine, it will not recognize the media
as a valid EFI boot media and the boot will fail.
Changelog-entry: Make hostapp-update-hooks clean-up legacy grub to ensure correct future EFI boot
Signed-off-by: Florin Sarbu<EMAIL_ADDRESS> Front conversations

@resin-ci retest


ImportError: /lib64/libm.so.6: version `GLIBC_2.27' not found

I'm running into some issues during the installation.
My NVIDIA driver version is 12.2. When I set up a Conda environment with Python 3.10, I get an error saying 'GLIBC_2.27' not found, which indicates that my GLIBC version is too low. But when I switch to Python 3.9 in the Conda environment and try to install the corresponding version of PyRosetta, I end up with a "Floating point exception" error. Do you have any ideas on how to fix this? I'd really appreciate your help.

Can you try again now with a clean install? A new PyRosetta version was pushed

I'm running into similar issues. I tried a clean install, but I keep getting floating point exception with python versions >= 3.9. I tried 3.8, but that runs into type errors with objects not being subscriptable. Are there any ways to get past the floating point exceptions.

What kind of jax version are you running? It is quite difficult to get the versions right on certain systems. What if you include "libgcc-ng" as package during the conda install?


daytona: init at 0.1.0

More info: https://github.com/daytonaio/daytona/
CC @Tpuljak @idagelic
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Hi @drupol,
Daytona Engineer here. 👋
Thanks for opening the PR!
We definitely have a plan to release a Nix package of the binary in the coming weeks.
If it's okay with you, we'd love to collaborate with you on this. Because the package will be rapidly changing in the next few weeks, we wouldn't want you to spend valuable time on packaging it before we believe it's ready.
You're welcome to join our Community Slack to discuss this further and chat about the upcoming features and fixes.

@Tpuljak I can't specify the Version while building the app.
I currently use -X internal.Version=0.1.0 but that doesn't seems to have any effect. Do you have any clue?

Hi @drupol,
Daytona Engineer here. 👋

Hi!

Thanks for opening the PR!
We definitely have a plan to release a Nix package of the binary in the coming weeks.

Cool!

If it's okay with you, we'd love to collaborate with you on this. Because the package will be rapidly changing in the next few weeks, we wouldn't want you to spend valuable time on packaging it before we believe it's ready.

Sure, your help if definitely valuable for packaging it correctly.

You're welcome to join our Community Slack to discuss this further and chat about the upcoming features and fixes.

I might probably join, but I rather keep our exchange public if it's ok for you. Like so if I'm not available for doing something, one of the other maintainers can also take the lead.

@Tpuljak I can't specify the Version while building the app.
I currently use -X internal.Version=0.1.0 but that doesn't seem to have any effect. Do you have any clue?

Please ignore my question, I found the answer in https://github.com/daytonaio/daytona/pull/86

Hi @drupol,
Since we're new to packaging binaries for Nix, we'd love your input on how to approach this.
As stated in our License here, the Daytona binary is built and distributed by the organization.
From your experience, does it make sense to include daytonaio in the maintainers entry of the package so that way it's clear that the organization is part of the packaging while you still maintain contribution rights?
We're talking with orgs with similar licenses to see the best way to approach this.
In the end, we'd love to give credit to you as well, of course, but we need to ensure that our license is covered.

Let's discuss this tomorrow, we can organise a meeting if you want.

Let's discuss this tomorrow, we can organize a meeting if you want.

Sure! We'll be in touch.

@Tpuljak What's the status with version 0.2.0? Do we need to have a meeting before merging this PR?

Heads up to those using both daytona and programs.ssh in home-manager: you'll need to add:
programs.ssh.includes = [ "daytona_config" ];

otherwise you'll be getting errors about a read-only filesystem when Daytona tries to add itself to the config.

@mogery Have you tested this derivation? Is it working for you?

@mogery Have you tested this derivation? Is it working for you?

Yeah, I changed it to pull 0.5.0 but it's working flawlessly otherwise.

I just updated to version 0.5.0 and included the docker provider. However, it looks like daytona doesn't look in the patch. I might report that issue upstream so that the docker provider (and potentially others) will be correctly detected.

Oh, I haven't tried to make Docker work on NixOS. I don't actually use it like that on local, I just use the CLI on Nix with the profile of an Ubuntu VM I've set up that runs the Daytona server.

Oh, I haven't tried to make Daytona + Docker work on NixOS. I don't actually use it like that on local, I just use the CLI on Nix with the profile of an Ubuntu VM I've set up that runs the Daytona server.

Do you mind making a demo or write a bit of documentation on how to use it?

programs.ssh.includes = [ "daytona_config" ];

Also, where is coming from daytona_config in here?

Do you mind making a demo or write a bit of documentation on how to use it?

Bit busy right now, but will do it ASAP.

Also, where is coming from daytona_config in here?

CLI creates it to set up SSH tunnels to the containers.

@mogery ^^

@mogery I'm looking for feedback before merging...

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/1016/119

I figured out how to run the server (it was pretty obvious), and it looks like it's trying search the wrong place for the providers.
After clearing ~/.config/daytona (it was needed) and running the non-wrapped server, it downloaded the provider into ~/.config/daytona/providers/docker-provider/docker-provider.
I can't really look into it more right now, but I think it's worth looking into.
I am not sure, which is better:

prefetch the binaries into the nix-store
let the program handle the fetching of the binaries

both work, because the binaries seem to be statically linked

I figured out how to run the server (it was pretty obvious), and it looks like it's trying search the wrong place for the providers. After clearing ~/.config/daytona (it was needed) and running the non-wrapped server, it downloaded the provider into ~/.config/daytona/providers/docker-provider/docker-provider, so the $out/share/daytona/providers directory probably has to have the same nesting. I can't really look into it more right now, but I think it's worth looking into.
I am not sure, which is better:
* prefetch the binaries into the nix-store

* let the program handle the fetching of the binaries

both work, because the binaries seem to be statically linked

I also encountered the same issue and I already had a chat with the Daytona devteam, they are going to have a look at it tomorrow. In the meantime, I've disabled the provider linkage until they fix the issue.

It is easier and less diverging of upstream behaviour, so as long as it runs on NixOS by default, I think it's fine not to prefetch.

I removed the prefetch of docker provider. This is now ready for review.

Seems like the wrapping was not actually removed

fixed!

@Tpuljak ready to be merged?

Looks good to me.
Let's get approval from @metcalfc and @vedranjukic and we're good to go.

@Tpuljak  I want to clarify a few things.
In the NixOS/Nixpkgs ecosystem, maintainer refers to the person responsible for maintenance (tracking upstream updates and eliminating errors that occur in this ecosystem). Maintainers don't stand for upstream developers.
If your company's business operation model prompts you to maintain related packages on various distributions all by employees, you can ask employees to open a new PR and add them to the maintainer-list (or on behalf of your company's identity). But at the same time, I should note that Nixpkgs does not prevent anyone else who wants to maintain it from adding their name to the meta.maintainers field of the package.
In the case of maintenance by others, as long as your software functions properly on this platform, we may not consider the rest of your business plan as a blocker for any of our actions (unless this conflicts with laws and regulations). In other words, we may not wait for your permission for some actions. We may also not use your partnership model to communicate with you. Please tolerate Nixpkgs's operating mode, regards.

@Aleksanaa thank you for the insights.
We are new to contributing packages to the Nix ecosystem and want to make sure we comply with its operating mode.
Because our license prohibits third parties from distributing the Daytona binary under the name daytona, we wanted to make sure all sides are in compliance with that. Additionally, we wanted to make sure @drupol is being properly attributed for his work in this PR.
We hope our way of communication is not misconstrued as us pushing our agenda against Nixpkgs's standards but as a way to ensure compliance with both parties. Daytona would love to be a part of the Nix ecosystem and accept best practices while doing so.

LGTM :shipit:


Model 5: select command is sometimes masked

In module 5, if the student loads packages in a funky order, the select command might be attempting to access the one from the MASS package instead of dplyr.

If students create a new project like they're supposed to and Run All right away, this should never be a problem. I'm debating if it's more confusing than helpful to replace select with dplyr::select everywhere. Alternatively, maybe detach("package:MASS") (or possibly detach("package:MASS", unload=TRUE)--I need to investigate this command) would be less obtrusive.

I think the "new project, run all" reminder is at least a good patch...


Simple discovery of foreign key targets

closes #133

Codecov Report

Merging #134 (edcdc0c) into master (e9da4b8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #134   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           25        25
  Lines         2238      2171   -67
=========================================
- Hits          2238      2171   -67

Impacted Files
Coverage Δ

src/pycldf/dataset.py
100.00% <100.00%> (ø)

tests/test_dataset.py
100.00% <100.00%> (ø)

tests/test_db.py
100.00% <0.00%> (ø)

src/pycldf/orm.py
100.00% <0.00%> (ø)

tests/conftest.py
100.00% <0.00%> (ø)

tests/test_orm.py
100.00% <0.00%> (ø)

tests/test_util.py
100.00% <0.00%> (ø)

src/pycldf/terms.py
100.00% <0.00%> (ø)

src/pycldf/sources.py
100.00% <0.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9da4b8...edcdc0c. Read the comment docs.


release: Updated Readme.md

Added driver release 2.0.0 to the release information table
Signed-off-by: Chaitanya<EMAIL_ADDRESS>

Looks good to me.


Adjust start date for Maine CDC Website format.

Fixes March 30 - April 1 data as mentioned in covidatlas/coronadatascraper#631,

Thanks for healing the timeseries!


Fix right ikHand wrongly triggered problem.

Sibling PR: https://github.com/webaverse/pistol/pull/10
Fixed the problem that right ikHand was wrongly triggered when activating sword in aim mode.

Hello @avaer , if just merge this but not the sibling PR https://github.com/webaverse/pistol/pull/10 , will cause the pistol to not work properly.


Add payout stakers

Summary by CodeRabbit

New Features

Introduced a new search functionality with a search bar and results display.
Added a new PendingRewards component for tracking and selecting staking rewards.
Implemented a Review component for confirming staking payouts.
Created a new route for solo staking rewards payout.
Enhanced the home page with a quick action bar and an account creation option.

Improvements

Revamped the Alert component with improved user experience and visual style.
Updated the RewardsDetail component to fetch data using a new address prop.
Added a TxDetail component for detailed transaction information display.

Bug Fixes

Fixed type issues in the Checkbox2 component by casting variables to strings.

Refactor

Refactored and renamed functions in the staking components for clarity.
Moved and organized imports and props in various components for better code quality.

Chores

Updated the NEW_VERSION_ALERT constant to reflect the new version identifier.

We've encountered this situation before, and using iadd, isub, and iaddn in these types of calculations is not advisable. It could lead to inaccurate results.


Grid state not correctly restored on restart

Testing https://github.com/microsoft/vscode/issues/78137
Starting state that I made:

Then I moved one of the sashes:

Then I restarted:

You can see that the sash position didn't save.

@bpasero where does the editor grid stuff get saved, not sure why it wouldn't be properly saved in grid layout

@sbatten it gets stored into the memento of the editor part:
https://github.com/microsoft/vscode/blob/8ebfa686ec8eafb4b25c7ee37a90bd21b59583dd/src/vs/workbench/browser/parts/editor/editorPart.ts#L939

I have been seeing this issue from time to time especially in the exploration electron 6 builds: my sidebar width still resets on starting up vscode

@beastdestroyer and what is your setting for workbench.useExperimentalGridLayout?

@bpasero  It has always been on since introduced as a setting

I would wait for a more recent exploration build where a couple of changes went in specifically around serialization.

@joaomoreno we can discuss this in our deep dive tomorrow as this results from the many layout calls happening during initial layout propagating down to the nested grid which gets a lot of different sizes ruining its serialized layout.

Only happens for vertical sashes of the editor grid.


integ: fix missing clean up in vlan integration tests

The missing clean up in these tests were causing that
tests/integration/timeout_test.py was failing after running
tests/integration/vlan_test.py.
Signed-off-by: Fernando Fernandez Mancera<EMAIL_ADDRESS>

Coverage remained the same at ?% when pulling 275a5a664c28078e5c5fc2b8ec5b2c641136dd7b on ffmancera:vlantest_cleanup into 0f0995ef37cbbcb357df6ccdae0cf14d6ae21eb5 on nmstate:master.

Coverage remained the same at ?% when pulling 275a5a664c28078e5c5fc2b8ec5b2c641136dd7b on ffmancera:vlantest_cleanup into 0f0995ef37cbbcb357df6ccdae0cf14d6ae21eb5 on nmstate:master.

integ: fix missing clean up in vlan integration tests

tests, integ: Fix ...

The missing clean up in these tests were causing that
tests/integration/timeout_test.py was failing after running
tests/integration/vlan_test.py.

The timeout integration tests fail due to improper vlan tests cleanup.
To fix the issue, remove explicitly the vlan interfaces in the tests.
This also shows a real issue that merits a bug. Removing a base interface (of a vlan) does not implicitly remove its dependent vlans. It should, or it should not allow to remove the base (more likely).

Done, thanks! I've created https://github.com/nmstate/nmstate/issues/835 to discuss and track this bug.


Metadata and Infoset data walking refactored

I did this in runtime1.api package.
Please review that package and the tests which no longer need the DINode classes, nor ElementRuntimeData.
There are still quite a few classes/enums etc. shining through the API like PrimTypeNode and SchemaFileLocation.
I have clobbered JAPI/SAPI for the time being because they were making the necessary refactoring impossible, so ignore them.
I also wasted hours - had a terrible time with javadoc and scaladoc failing when doing publishLocal/publishM2
resulting in no japi nor sapi jar. That's why I ended up commenting out most of the javadoc/scaladoc in JAPI/SAPI so that I could get on with things.
(You would think just telling sbt "don't create the doc" would be possible, but it seems not to be.)
I also backed out sbt to 1.7.3 because of wierdness.

Closed. Superceded by https://github.com/apache/daffodil/pull/1112


Feat: Adding Social Media icons to Login Page

Describe the feature
@SUGAM-ARORA  want to add social media icons as well as images to the Login/Signup Page. Kindly assign this issue to me.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Ojas-Arora Issue assigned to you


Issue running install.bat and api.bat

Hello, I have an issue where whenever I try to run install.bat it would output this:
ERROR: Invalid syntax. Default option is not allowed more than '1' time(s).
Type "TIMEOUT /?" for usage.
Requirement already satisfied: pytchat in c:\users\blank\documents\silly\sillytavern-launcher\public\scripts\extensions\third-party\youtubelivechatlocalapi\venv\lib\site-packages (from -r requirements.txt (line 1)) (0.5.5)
Requirement already satisfied: Flask in c:\users\blank\documents\silly\sillytavern-launcher\public\scripts\extensions\third-party\youtubelivechatlocalapi\venv\lib\site-packages (from -r requirements.txt (line 2)) (3.0.3)
Requirement already satisfied: Flask-Cache in c:\users\blank\documents\silly\sillytavern-launcher\public\scripts\extensions\third-party\youtubelivechatlocalapi\venv\lib\site-packages (from -r requirements.txt (line 3)) (0.13.1)
Requirement already satisfied: Flask-Cors in c:\users\blank\documents\silly\sillytavern-launcher\public\scripts\extensions\third-party\youtubelivechatlocalapi\venv\lib\site-packages (from -r requirements.txt (line 4)) (4.0.1)
ERROR: Could not find a version that satisfies the requirement json (from versions: none)
ERROR: No matching distribution found for json
I tried removing "json" from requirements.txt after reading that python has a built in json module and ran into an error when trying to launch api.bat which output this:
Traceback (most recent call last):
File "C:\Users\blank\Documents\Silly\SillyTavern-Launcher\public\scripts\extensions\third-party\YoutubeLiveChatLocalApi\app.py", line 2, in
from flask_caching import Cache
ModuleNotFoundError: No module named 'flask_caching'
Press any key to continue . . .
I tried uninstalling and reinstalling the entire folder, as well as flask and flask_caching from the library which had no effect. I also tried renaming flask_cache to flask_caching after finding Cache was defined there in init, which gave me another error with werkzeug.
I have java version 1.8.0_421 and python 3.11.9 installed and the folder is located in the third party folder alongside Extension-LiveChat.

try install manually using python 3.10
make the virtual environment using this command
python3.10 -m venv venv


Chaning the MaterialWindow Title bar color

Sorry for my ignorance, this may be something super obvious but somehow I am not finding it :(
Is it possible to change the color of the Title bar for the MaterialWindow?
Thanks for your help.
P.

Sorry, never mind!
I knew that is easy :)
BorderBackgroundBrush


chore(main): release 1.0.6

:robot: I have created a release beep boop
1.0.6 (2024-03-02)
Bug Fixes

Fixes issue where the file watcher wouldn't look in folders (a8d5a96)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/javalent/calendarium/releases/tag/1.0.6 :sunflower:


setAccents does not work for different time zones

I have three dates in PST time zone: Dec 27, Dec 01, Dec 13
When I call setAccents they get set on Dec 26, Nov 30, Dec 12
val map = mutableMapOf<Date, Collection<Accent>>().apply {
    calendarMap.forEach { entry ->
        val (date, list) = entry
        val keyDate = dateFormatter.parse(date)
        Log.v(TAG, keyDate.toString())
        put(keyDate, list.map { value ->
            DotAccent(10f, key = value.startDate)
        })
    }
}
monthView?.setAccents(map)

12-12 16:48:01.108 6864-6864/? V/MainActivity: Tue Dec 27 00:00:00 PST 2016
12-12 16:48:01.108 6864-6864/? V/MainActivity: Thu Dec 01 00:00:00 PST 2016
12-12 16:48:01.108 6864-6864/? V/MainActivity: Tue Dec 13 00:00:00 PST 2016

If I switch my phone time zone to Tokyo time, it will show on the right dates.

Hi @andytung, Thanks for the report.
I am not sure why this issue occurs since the library uses the default timezone (TimeZone.getDefault()) and default locale (Locale.getDefault()). We will add a feature to change the timezone and locale to use in the library.
Thank you.

You can now set TimeZone and Locale explicitly in Release 1.0.1.
Thanks!


Superuser no longer relevant

With the implementation of keybox, we no longer require using the Superuser account aka zeus
This can now be removed from the Linux playbooks
@gdams do you agree?

Wasn't the idea of the superuser that it protects us if keybox goes rogue and removes our keys?

good point. lets kept it.


pip install pymeasure generates error

I get the following error when trying to install via pip:

[cbrown@cbrown2` ~]$ sudo pip2 install pymeasure
Collecting pymeasure
Using cached PyMeasure-0.4.3.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-build-9TN0h5/pymeasure/setup.py", line 57, in
long_description=open('README.rst').read() + "\n\n" + open('CHANGES.txt').read(),
IOError: [Errno 2] No such file or directory: 'CHANGES.txt'
----------------------------------------

Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-9TN0h5/pymeasure/
[cbrown@cbrown2 ~]$ sudo pip2 install pymeasure==0.4.2
Collecting pymeasure==0.4.2
Using cached PyMeasure-0.4.2.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-build-62toxu/pymeasure/setup.py", line 55, in
long_description=open('README.rst').read() + "\n\n" + open('CHANGES.txt').read(),
IOError: [Errno 2] No such file or directory: 'CHANGES.txt'
----------------------------------------

Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-62toxu/pymeasure/
[cbrown@cbrown2 ~]$

@cbrown1, thanks for reporting this. It looks like CHANGES.txt is not included in MANIFEST.in, so its not being rolled in with the package. I will fix this shortly.
I'm curious if this effects the wheel version. Do you have wheel installed?

I can confirm that the wheel does install properly on python3, and also that the github version now installs on python2.
Thanks!

Great. PyMeasure only supports Python 3 to help phase out Python 2.7. Are the pip issues specific to Python 2.7?

Thanks @cbrown1 for looking into this! Since this only affects the non-wheel pip installs, I will hold off on making a new release. I suspect that most users will have wheel installed, or be using the Anaconda distribution (since it includes the Qt libraries, which can be troublesome to install).
I will leave this open until the next release to inform anyone else who has this issue.

The PyPI tarball is the canonical source for packaging by Linux distributions. Please reconsider the value of providing a sane PyPI tarball.

@ghisvail, this is already fixed on master and is just waiting on a new release. I wanted to wait until more substantial updates went through, but I'm open to making a new release if this is a show stopper for you. Keep in mind this bug only affects non-wheel pip installs. Given the Qt dependencies, I expect most users will go for the Anaconda distribution route and few will be using non-wheel pip. What do you think?

I'm open to making a new release if this is a show stopper for you.

It is currently a show-stopper for making a Linux package, but I took this opportunity to iron out some problems I discovered on the GitHub tagged release (#77, #78, #79, #80). Once these are all addressed, it would be nice to make a new release.

Keep in mind this bug only affects non-wheel pip installs.

Quoting myself above: The PyPI tarball is the canonical source for packaging by Linux distributions. As a prospective packager, I am very much affected by this bug.

I wanted to wait until more substantial updates went through

Tagging releases is quite cheap these days, so I fail to understand the value in waiting (RERO).

This is fixed in the newest release. Thanks everyone!


When sharing, where do public Gists get created?

Here are the versions I'm running.

I have a private sync set up and working great.
Then I went to Sync: Advanced Options > Sync: Share settings with public GIST.
It progressed successfully and the said something like "you're good to go, share this ID with others".
What I'm having trouble is figuring the ID.  I don't see a public gist created under my Gist profile and the success message didn't mention it either.
Thanks for any help!

Hey. Wanted to report back how I fixed my own problem.
I had to run the command
Sync: Download Settings from Public Gist
before running
Sync: Share Setting with Public Gist.
Doing it in that order created the Gist and returned ID correctly.
Best,
Jeremy

Glad to know it helped


Support for PostgreSQL in dbpool.

Similar to MySql, added support for PostgreSQL.

Merged, thanks!