[Enhancement] avoid access external table when reloading

Fixes #issue
On Table::onReload():

For MaterializedView, it needs to reload the relatedMvId into base table
For external table, it doesn't make sense, since accessing the external table is expensive

So here we skip the BaseTableInfo::getTable if it's an external table.
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[x] 3.0
[x] 2.5

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)


Colour thresholds not working

Hi,
I have a sensor that displays the remaining time in Kwh of my Powerwall battery.
No matter what I put into the Color Threshold field to make the value less than, equal to, or greater than - the card seems to only obey the colour option I enter for "bigger"
If I invert the value then no matter what I enter into Color Threshold only the color option for "smaller" is obeyed.
I'm hoping it's just me missing something obvious!

Hey there 👋
Nice catch. Basically the value used for the arrow coloring was set before all of the value processing, so any modifications (absolute, inverted) got ignored...
I will close the issue with the next release!
Take care and stay safe!

Fixed in the latest release. Take care! 👍


[bug] can not add new templates  after one deleted  previously

When trying to fix a mistake in one template I've deleted first.
Now I'm trying to define again with the same name  and this is the error.
> kapacitor define-template UMBRAL_2EX_CC_UA_FMEAN_TST -tick ./tpl/UMBRAL_2EX_CC_UA_FMEAN_TST.tick.tpl
template UMBRAL_2EX_CC_UA_FMEAN_TST already exists

with this output trace
log messages must have 'L!' prefix where L is one of 'D', 'I', 'W', 'E'[log] 2017/09/22 14:44:15 http: panic serving <IP_ADDRESS>:45919: runtime error: invalid memory address or nil pointer dereference
goroutine 331 [running]:
net/http.(*conn).serve.func1(0xc420bee780)
        /usr/local/go/src/net/http/server.go:1491 +0x12a
panic(0x1cd80a0, 0xc4200120f0)
        /usr/local/go/src/runtime/panic.go:458 +0x243
github.com/influxdata/kapacitor/services/task_store.(*Service).convertTemplate(0xc420358a00, 0xc422af58e0, 0x1a, 0x0, 0xc4205f8000, 0x1cf2, 0x0, 0x0, 0xed15430cf, 0x254af1ea, ...)
        /root/go/src/github.com/influxdata/kapacitor/services/task_store/service.go:1368 +0x157
github.com/influxdata/kapacitor/services/task_store.(*Service).handleTemplate(0xc420358a00, 0x2e340e0, 0xc422af51e0, 0xc420804c30)
        /root/go/src/github.com/influxdata/kapacitor/services/task_store/service.go:1409 +0x1d4
github.com/influxdata/kapacitor/services/task_store.(*Service).(github.com/influxdata/kapacitor/services/task_store.handleTemplate)-fm(0x2e340e0, 0xc422af51e0, 0xc420804c30)
        /root/go/src/github.com/influxdata/kapacitor/services/task_store/service.go:135 +0x48
github.com/influxdata/kapacitor/services/httpd.authorize.func1(0x2e340e0, 0xc422af51e0, 0xc420804c30, 0x1fba4d3, 0xa, 0x1, 0x2ea8360, 0x0, 0x0, 0xc420376570)
        /root/go/src/github.com/influxdata/kapacitor/services/httpd/handler.go:714 +0xe9
github.com/influxdata/kapacitor/services/httpd.authenticate.func1(0x2e340e0, 0xc422af51e0, 0xc420804c30)
        /root/go/src/github.com/influxdata/kapacitor/services/httpd/handler.go:579 +0xa6d
net/http.HandlerFunc.ServeHTTP(0xc4203ec820, 0x2e340e0, 0xc422af51e0, 0xc420804c30)
        /usr/local/go/src/net/http/server.go:1726 +0x44
github.com/influxdata/kapacitor/services/httpd.jsonContent.func1(0x2e340e0, 0xc422af51e0, 0xc420804c30)
        /root/go/src/github.com/influxdata/kapacitor/services/httpd/handler.go:818 +0xb1
net/http.HandlerFunc.ServeHTTP(0xc4203ec8c0, 0x2e340e0, 0xc422af51e0, 0xc420804c30)
        /usr/local/go/src/net/http/server.go:1726 +0x44
github.com/influxdata/kapacitor/services/httpd.gzipFilter.func1(0x2e2bd60, 0xc422af51a0, 0xc420804c30)
        /root/go/src/github.com/influxdata/kapacitor/services/httpd/handler.go:811 +0x1e3
net/http.HandlerFunc.ServeHTTP(0xc4203ec920, 0x2e2bd60, 0xc422af51a0, 0xc420804c30)
        /usr/local/go/src/net/http/server.go:1726 +0x44
github.com/influxdata/kapacitor/services/httpd.versionHeader.func1(0x2e2bd60, 0xc422af51a0, 0xc420804c30)
        /root/go/src/github.com/influxdata/kapacitor/services/httpd/handler.go:827 +0xbc
net/http.HandlerFunc.ServeHTTP(0xc4203eca00, 0x2e2bd60, 0xc422af51a0, 0xc420804c30)
        /usr/local/go/src/net/http/server.go:1726 +0x44
github.com/influxdata/kapacitor/services/httpd.cors.func1(0x2e2bd60, 0xc422af51a0, 0xc420804c30)
        /root/go/src/github.com/influxdata/kapacitor/services/httpd/handler.go:860 +0xee
net/http.HandlerFunc.ServeHTTP(0xc4203eca60, 0x2e2bd60, 0xc422af51a0, 0xc420804c30)
        /usr/local/go/src/net/http/server.go:1726 +0x44
github.com/influxdata/kapacitor/services/httpd.requestID.func1(0x2e2bd60, 0xc422af51a0, 0xc420804c30)
        /root/go/src/github.com/influxdata/kapacitor/services/httpd/handler.go:870 +0x138
net/http.HandlerFunc.ServeHTTP(0xc4203ecb40, 0x2e2bd60, 0xc422af51a0, 0xc420804c30)
        /usr/local/go/src/net/http/server.go:1726 +0x44
github.com/influxdata/kapacitor/services/httpd.logHandler.func1(0x2e2bd60, 0xc422af5180, 0xc420804c30)
        /root/go/src/github.com/influxdata/kapacitor/services/httpd/handler.go:878 +0xfa
net/http.HandlerFunc.ServeHTTP(0xc4203ecba0, 0x2e2bd60, 0xc422af5180, 0xc420804c30)
        /usr/local/go/src/net/http/server.go:1726 +0x44
github.com/influxdata/kapacitor/services/httpd.recovery.func1(0x2e33e20, 0xc421306410, 0xc420804c30)
        /root/go/src/github.com/influxdata/kapacitor/services/httpd/handler.go:887 +0xfa
net/http.HandlerFunc.ServeHTTP(0xc4203ecc40, 0x2e33e20, 0xc421306410, 0xc420804c30)
        /usr/local/go/src/net/http/server.go:1726 +0x44
github.com/influxdata/kapacitor/services/httpd.(*ServeMux).ServeHTTP(0xc42035b110, 0x2e33e20, 0xc421306410, 0xc420804c30)
        /root/go/src/github.com/influxdata/kapacitor/services/httpd/mux.go:163 +0x7f
github.com/influxdata/kapacitor/services/httpd.(*Handler).ServeHTTP(0xc420123b80, 0x2e33e20, 0xc421306410, 0xc420804c30)
        /root/go/src/github.com/influxdata/kapacitor/services/httpd/handler.go:365 +0xcf
net/http.serverHandler.ServeHTTP(0xc421442900, 0x2e33e20, 0xc421306410, 0xc420804c30)
        /usr/local/go/src/net/http/server.go:2202 +0x7d
net/http.(*conn).serve(0xc420bee780, 0x2e360a0, 0xc42007d3c0)
        /usr/local/go/src/net/http/server.go:1579 +0x4b7
created by net/http.(*Server).Serve
        /usr/local/go/src/net/http/server.go:2293 +0x44d

I've tried to create again with other name, with this result:
> kapacitor define-template UMBRAL_2EX_CC_UA_FMEAN_TST2 -tick ./tpl/UMBRAL_2EX_CC_UA_FMEAN_TST.tick.tpl
unknown type "unknown TaskType 0"

I'm working with Kapacitor 1.3.1 (git: master 3b5512f7276483326577907803167e4bb213c613)

@toni-moreno can you include the exact repro steps?

Hi @desa I've finally recreated completely the kapacitor.db as it seems to have some corrupted data.
to reproduce the problem , I  did a simple delete template with working  tasks defined from this template running yet. And after a tried recreate again,  but I forgot the "-type stream", and the log shows the stack trace in previous comments..
The rename could be done with the correct command  (adding -type stream).
Perhaps the problem was forgot the -type stream but anyway the db seems to have corrupted data.

Hi @desa I' think this issue  could be easily resolved by only recreating de db, so I will  close, in  order to priorize  important issues

@toni-moreno I'd like to reopen the issue just so that we have it logged somewhere. That way we can prioritize appropriately.


enableWhenExpression Support

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #https://github.com/google/android-fhir/issues/819
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct.
[x] I have read the Contributing page.
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
[ ] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
[x] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@jingtang10 can we arrange a meeting to discuss this PR?

@RaaziaTarique , has this PR been discussed with Jing?


Roll Flutter Engine from 32c056aeda68 to 48ef1f8bd878 (1 revision)

https://github.com/flutter/engine/compare/32c056aeda68...48ef1f8bd878
2022-06-22<EMAIL_ADDRESS>[impeller] Use mapping based 'Texture::SetContents' in image decoder and text render context (flutter/engine#33477)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Udeler Authenticator is not working [Bug]

After downloading Udeler Authenticator it's says "Package is invalid: 'CRX_REQUIRED_PROOF_MISSING'.

#metoo

I solved the issue using the following steps:

Download the extension from the link given by the developer (Use this command in terminal: wget https://www.udeler.com/UdelerAuthenticator.crx)
Change the file type from .crx to .zip.
Extract the file using any archive manager.
Go to chrome://extensions/ -> enable developer mode.
Choose 'Load unpacked' and select the folder obtained after extracting the above file. (Ignore the error in the extensions page)
Open Udeler -> click on anonymous login icon -> visit udemy.com.
You will now see that the authentication is successful in the application.

It is still not working.


Unbind Variant methods that change immutable types.

Fixes #62706.
Code is commented instead of removed to clarify why they should not be re-added.

I think you can add a comment like "Do not bind rotation, scale, skew, ..." and remove the dead code.
But shouldn't we outright remove those methods in C++ too? That would be much cleaner.

@akien-mga Those are useful in C++ for performance, but in script since types are immutable they can't really be exposed.

@akien-mga done

Thanks!


Silent mode? yfinance.download()

Any silent mode option for .download()?
Do not echo to console and a bit faster.

Are you looking for the progress=False argument to yf.download?

Yes, thank you very much!
获取 Outlook for iOShttps://aka.ms/o0ukef

发件人: Trevin Gandhi<EMAIL_ADDRESS>发送时间: Sunday, June 28, 2020 12:57:15 AM
收件人: ranaroussi/yfinance<EMAIL_ADDRESS>抄送: Big Horse<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>主题: Re: [ranaroussi/yfinance] Silent mode? yfinance.download() (#336)
Are you looking for the progress=False argument to yf.download?
―
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/ranaroussi/yfinance/issues/336#issuecomment-650585846, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIFL7YTPW5J5FLORAOLCA73RYYQGXANCNFSM4NZHH7AQ.


Add client secret in the challenge response

Add client secret in the challenge response if present in the auth params

@bjinwright I found this issue where I needed to pass back the client secret if present in the challenge response the fix worked for me - let me know if you have any concerns

@bjinwright any concerns with this Pull Request? any changes you would like me to make? Thx

Thanks @bjinwright


Misleading error message for invalid annotation format

What happened?

When adding annotation to make resource ready (based on README example):
 gotemplating.fn.crossplane.io/ready: True

I am getting an error:
crossplane: error: cannot render composite resource: pipeline step "render-templates" returned a fatal result: "User" template is missing required "gotemplating.fn.crossplane.io/composition-resource-name" annotation

This is misleading because I have setgotemplating.fn.crossplane.io/composition-resource-name annotation, and the real error is caused by an invalid format of ready annotation (boolean instead of string). It works when I change it to:
 gotemplating.fn.crossplane.io/ready: "True"

How can we reproduce it?

What environment did it happen in?
Function version: 0.3.0

Just ran into this issue as well... title README.md is misleading, and this error message makes it even harder to pinpoint. Dunno how many hours I would wasted if you didn't create this issue @lewyg - thanks

What's happening here is that the YAML decoder will interpret unquoted True or False values as a boolean true or false.
ex
When setting the following in a composition
apiVersion: example.crossplane.io/v1beta1
kind: Example
metadata:
  annotations:
     gotemplating.fn.crossplane.io/ready: True
     crossplane.io/composition-resource-name: example

and output the unmarshaled object you will see
{Object:map[apiVersion:apiVersion: example.crossplane.io/v1beta1 kind:Example metadata:map[annotations:map[gotemplating.fn.crossplane.io/ready:false crossplane.io/composition-resource-name: example]] }

This conversion is problematic when such annotations are expected to be strings, as demonstrated in the following snippet:
Later in  RunFunction you see
name, found := obj.GetAnnotations()[annotationKeyCompositionResourceName]
if !found {
	response.Fatal(rsp, errors.Errorf("%q template is missing required %q annotation", obj.GetKind(), annotationKeyCompositionResourceName))
	return rsp, nil
}

GetAnnotations will internally call NestedStringMap . In this case, it will hit the not ok condition and return an error.
func NestedStringMap(obj map[string]interface{}, fields ...string) (map[string]string, bool, error) {
        ....
	for k, v := range m {
		if str, ok := v.(string); ok {
			strMap[k] = str
		} else {
			return nil, false, fmt.Errorf("%v accessor error: contains non-string key in the map: %v is of the type %T, expected string", jsonPath(fields), v, v)
		}
	}
	....

Since GetAnnotations ignores the returned errors, we end up with a nil map which results in the  template is missing required annotation error.


Integration fastdotcom not updated - Fast.com can measure uploads but integration and documentation support only Downloads

The problem

Fast.com now does uploads as well as downloads, but the documentation incorrectly states that Fast.com only support measuring download speeds, both the component and the documentation must be updated to reflect the true reality.
Environment

0.105.4

Home Assistant release with the issue: 0.105.4
Last working Home Assistant release (if known): Not related to version - integration not updated
Operating environment (Hass.io/Docker/Windows/etc.): Docker
Integration causing this issue: Fast.com
Link to integration documentation on our website: https://www.home-assistant.io/integrations/fastdotcom/

Problem-relevant configuration.yaml

fastdotcom:
scan_interval:
minutes: 30

Traceback/Error logs

Additional information

Sorry for the bad formatting, configuration.yaml is configured correctly but the formatting on this report is incorrect.


CSV with timedeltas generated with and old version of pandas cannot be parsed anymore

I have been using an older version of pandas (0.13.1) and serialized several timedeltas in a data frame. These timedeltas ended up like this in the generated CSV file:
-1 days +23:30:00.000000000

This format cannot be parsed anymore. It seems that the + sign in front of the hours causes the parsing to fail:
In [24]: pd.to_timedelta('-1 days 23:30:00.000000000')
Out[24]: numpy.timedelta64(-171000000000000,'ns')

In [25]: pd.to_timedelta('-1 days +23:30:00.000000000')
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-25-79414e44ea89> in <module>()
----> 1 pd.to_timedelta('-1 days +23:30:00.000000000')

/usr/lib/python2.7/dist-packages/pandas/tseries/timedeltas.pyc in to_timedelta(arg, box, unit)
     60
     61     # ...so it must be a scalar value. Return scalar.
---> 62     return _coerce_scalar_to_timedelta_type(arg, unit=unit)
     63
     64 _short_search = re.compile(

/usr/lib/python2.7/dist-packages/pandas/tseries/timedeltas.pyc in _coerce_scalar_to_timedelta_type(r, unit)
     76
     77         # we are already converting to nanoseconds
---> 78         converter = _get_string_converter(r, unit=unit)
     79         r = converter()
     80         unit='ns'

/usr/lib/python2.7/dist-packages/pandas/tseries/timedeltas.pyc in _get_string_converter(r, unit)
    140
    141     # no converter
--> 142     raise ValueError("cannot create timedelta string converter")
    143
    144 def _possibly_cast_to_timedelta(value, coerce=True):

ValueError: cannot create timedelta string converter

this was corrected in 0.17.0 (as well as being more performant).
In [1]: pd.to_timedelta('-1 days 23:30:00.000000000')
Out[1]: Timedelta('-1 days +23:30:00')

In [2]: pd.to_timedelta('-1 days +23:30:00.000000000')
Out[2]: Timedelta('-1 days +23:30:00')


Fix escaped commas in uBO scriptlet parameters

Escaped commas are highlighted incorrectly.
Example rule:
##+js(trusted-set-cookie, gravitoData, {"NonTCFVendors":[{"id":1\,"name":"Facebook"\,"consent":true}\,{"id":3\,"name":"Google"\,"consent":true}\,{"id":9\,"name":"Twitter"\,"consent":true}]}, 1year)

from https://github.com/uBlockOrigin/uAssets/blob/a7d6966930f7648d9cc5740f5b03fb05f86029d4/filters/annoyances-cookies.txt#L63

Show screenshot

Reported by @peace2000

@scripthunter7 @slavaleleka On my end this doesn't seem to be fixed despite a month has passed.
Still escaped commas are shown red: https://github.com/uBlockOrigin/uAssets/blob/a7d6966930f7648d9cc5740f5b03fb05f86029d4/filters/annoyances-cookies.txt#L63
Also, now as uBO has started to support using quotes in values https://github.com/uBlockOrigin/uAssets/blob/562d4c6043f38ec3786dc34119d26e711140d6cf/filters/annoyances-cookies.txt#L124 I see that the quoted value still has commas colored in red.

@peace2000

Still escaped commas are shown in red: https://github.com/uBlockOrigin/uAssets/blob/a7d6966930f7648d9cc5740f5b03fb05f86029d4/filters/annoyances-cookies.txt#L63

GitHub highlighter takes time to update, you can learn more at https://github.com/AdguardTeam/VscodeAdblockSyntax#reporting-issues

Also, now as uBO has started to support using quotes in values https://github.com/uBlockOrigin/uAssets/blob/562d4c6043f38ec3786dc34119d26e711140d6cf/filters/annoyances-cookies.txt#L124 I see that the quoted value still has commas colored in red.

At first glance, this appears to be a new issue that needs to be fixed, since this feature is not yet supported by the highlighter.

However, there seems to be no issues in quoted AG values for some reason https://github.com/AdguardTeam/AdguardFilters/blob/2c9040591d31c180b99e2a599e7150a7b5c7a2a5/AnnoyancesFilter/Cookies/sections/cookies_specific.txt#L232

Yes, because the two types of scriptlet parameter management are a little different.

Oh okay. Thanks for the info.


Update Azure DevOps Pipelines

Update the existing Azure DevOps Pipelines to support multiple OSes and multiple Python versions, following the conventions in the other Responsible AI repos. Also adds a code coverage build.

New PR-Gate:
https://dev.azure.com/responsibleai/interpret-community/_build/results?buildId=7316&view=results
New Nightly:
https://dev.azure.com/responsibleai/interpret-community/_build/results?buildId=7311&view=results
New Code-Coverage:
https://dev.azure.com/responsibleai/interpret-community/_build/results?buildId=7312&view=codecoverage-tab


Colour Badges - not auto-awarding?

Check doctrine listeners still work after #129
Add some tests!

Fixed by a0c59a40cd710bfbc5d557828af76899d69e0091 and ca4941095265e5b433e21c72529c6338ab456f8e


Add Decimal variant hash function

The decimal variant hash function is required for the compilation of FieldAccessTypedExpr.

@mbasmanova below is the bt

It looks the expression is ConstantTypedExpr. @karteekmurthys can you confirm?

It looks like the expression is ConstantTypedExpr

That makes sense as ConstantTypedExpr stores the constant value as Variant. Let's update the PR description to fix the expression type and clarify that hash function is required to avoid run time, not compile time check.

I am working on addressing the review comments.

So with this hash implementation, two nulls with different precision/scale is considered different?

@Yuhta that is right. It is safe if NULL is tied to precision, scale like a regular unscaled value.


Sample JSON

I know its not technically valid JSON because of the comment lines (// *) BUT
"name": "pid-XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX"
should have a comma like
"name": "pid-XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX",
so when the comments are removed it is valid.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: db44bc8f-a6d7-8651-165d-929230435633
Version Independent ID: c7847825-9d79-419e-a177-aca5872f1431
Content: Azure partner and customer usage attribution
Content Source: articles/marketplace/azure-partner-customer-usage-attribution.md
Service: marketplace
GitHub Login: @yijenj
Microsoft Alias: yijenj

@vincepower Thanks for your comment. The feedback has been shared with the content owner for further review. Thanks for your patience.

Thank you. I have made that change.
#please-close


Wechaty v1.x API

@padlocal I have upgraded the code base with the ES Module & Wechaty v1.x, please review and let me know what you think.
Thank you very much!
Related to:

https://github.com/wechaty/puppet/issues/164
https://github.com/Chatie/tsconfig/issues/16

Have removed the ESM from this PR with the latest commits.
I hope we can upgrade to Wechaty v1 soon!

我把esm分支拉到本地跑了一下，发现安装依赖并没有问题，action 跑的时候可能是超时导致的失败。不过安装完依赖在运行npm run test 的时候，出现了一下报错，似乎是wechaty-puppet/types的引用存在问题，按照正常情况应该引用的是esm里的types，但是在运行test的时候查找的是cjs中的types

node环境：16.13.0
Mac

nvm use v16
Now using node v16.13.0 (npm v8.1.0)
➜  puppet-padlocal git:(esm) npm i
npm WARN deprecated<EMAIL_ADDRESS>This is a stub types definition. quick-lru provides its own type definitions, so you do not need this installed.
npm WARN deprecated<EMAIL_ADDRESS>Moved to 'npm install @sideway/pinpoint'
npm WARN deprecated<EMAIL_ADDRESS>This version has been deprecated and is no longer supported or maintained
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Moved to 'npm install @sideway/formula'
npm WARN deprecated<EMAIL_ADDRESS>Moved to 'npm install @sideway/address'
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>This version has been deprecated and is no longer supported or maintained
npm WARN deprecated<EMAIL_ADDRESS>Critical security vulnerability fixed in v0.21.1. For more information, see https://github.com/axios/axios/pull/3410
npm WARN deprecated<EMAIL_ADDRESS>Switch to 'npm install joi'

added 1175 packages, and audited 1337 packages in 2m

7 packages are looking for funding
  run `npm fund` for details

13 vulnerabilities (8 moderate, 5 high)

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
➜  puppet-padlocal git:(esm) npm run test

><EMAIL_ADDRESS>test
> npm-run-all lint test:unit

><EMAIL_ADDRESS>lint
> npm-run-all lint:es lint:ts lint:md

><EMAIL_ADDRESS>lint:es
> eslint "src/**/*.ts" "tests/**/*.test.ts" --ignore-pattern tests/fixtures/

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <4.5.0

YOUR TYPESCRIPT VERSION: 4.5.5

Please only submit bug reports when using the officially supported version.

=============

><EMAIL_ADDRESS>lint:ts
> tsc --isolatedModules --noEmit

><EMAIL_ADDRESS>lint:md
> markdownlint README.md

><EMAIL_ADDRESS>test:unit
> jest

WARNING: NODE_ENV value of 'test' did not match any deployment config file names.
WARNING: See https://github.com/lorenwest/node-config/wiki/Strict-Mode
WARNING: NODE_ENV value of 'test' did not match any deployment config file names.
WARNING: See https://github.com/lorenwest/node-config/wiki/Strict-Mode
 FAIL  tests/wechaty-api.test.ts
  ● Test suite failed to run

    **Cannot find module 'wechaty-puppet/types' from 'node_modules/wechaty/dist/cjs/src/mods/mod.js'**

    Require stack:
      node_modules/wechaty/dist/cjs/src/mods/mod.js
      tests/wechaty-api.test.ts

      at Resolver.resolveModule (node_modules/jest-resolve/build/resolver.js:324:11)
      at Object.<anonymous> (node_modules/wechaty/src/mods/mod.ts:39:1)

 FAIL  tests/wechaty-login.test.ts
  ● Test suite failed to run

    **Cannot find module 'wechaty-puppet/types' from 'node_modules/wechaty/dist/cjs/src/mods/mod.js'**

    Require stack:
      node_modules/wechaty/dist/cjs/src/mods/mod.js
      tests/wechaty-common.ts
      tests/wechaty-login.test.ts

      at Resolver.resolveModule (node_modules/jest-resolve/build/resolver.js:324:11)
      at Object.<anonymous> (node_modules/wechaty/src/mods/mod.ts:39:1)

 FAIL  tests/wechaty-push.test.ts
  ● Test suite failed to run

    **Cannot find module 'wechaty-puppet/types' from 'node_modules/wechaty/dist/cjs/src/mods/mod.js'**

    Require stack:
      node_modules/wechaty/dist/cjs/src/mods/mod.js
      tests/wechaty-push.test.ts

      at Resolver.resolveModule (node_modules/jest-resolve/build/resolver.js:324:11)
      at Object.<anonymous> (node_modules/wechaty/src/mods/mod.ts:39:1)

ReferenceError: You are trying to `import` a file after the Jest environment has been torn down. From tests/wechaty-api.test.ts.

      at node_modules/gifwrap/src/gifcodec.js:7:15

ReferenceError: You are trying to `import` a file after the Jest environment has been torn down. From tests/wechaty-push.test.ts.

      at node_modules/gifwrap/src/gifcodec.js:7:15

ReferenceError: You are trying to `import` a file after the Jest environment has been torn down. From tests/wechaty-login.test.ts.

      at node_modules/gifwrap/src/gifcodec.js:7:15
Test Suites: 3 failed, 3 total
Tests:       0 total
Snapshots:   0 total
Time:        5.557 s
Ran all test suites.
ERROR: "test:unit" exited with 1.

Hi @leochen-g
Thank you very much for taking look at this PR!
The error messages you have posted is very wired because we can require wechaty without any problem with CLI:
$ node
Welcome to Node.js v16.13.2.
Type ".help" for more information.
> require('wechaty-puppet/types')
{
  ContactGender: [Getter],
  Contact: [Getter],
  FriendshipScene: [Getter],
  Friendship: [Getter],
  Image: [Getter],
  Message: [Getter],
  Post: [Getter],
  Tap: [Getter],
  Sayable: [Getter],
  Payload: [Getter],
  Dirty: [Getter],
  ScanStatus: [Getter],
  YOU: [Getter],
  CHAT_EVENT_DICT: [Getter],
  PUPPET_EVENT_DICT: [Getter]
}

So I added another minimum unit test that loads the wechaty and found that it can work without any problem, with tap runner:
$ ./tests/wechaty-login.spec.ts
TAP version 13
# Subtest: smoke testing
    ok 1 - bot has created
    1..1
ok 1 - smoke testing # time=6.318ms

1..1
# time=17.664ms

So I guess the problem might relate to the jest test runner?
Not sure about it but hope the above information could be helpful for the future investigating.

@huan 有点不太明白哈，就是现在1.x版本使用的应该是esm的导入方式引入包，但是我看报错，引入的wechaty是cjs的，这个是不是不太对，packages.json 里我看并没有type: 'module' ,其他puppet里我看是有这个配置的，会和这个有关系吗

现在1.x版本使用的应该是esm的导入方式引入包

This is partially correct.
The 1.x version of Wechaty is built with a Dual-ESM-CJS pattern, which means that when it is loaded by an ESM module then it will be an ESM module, otherwise when it is loaded by a CJS module then it will be a CJS module.
When the Wechaty is loading with the correct version of the wechaty-puppet-padlocal (which is a CJS module), then it will act as a CJS module and be loaded as CJS.

但是我看报错，引入的wechaty是cjs的，这个是不是不太对

According to my above explanation: when the CJS wechaty-puppet-padlocal load the wechaty, the wechaty will be in CJS mode.

packages.json 里我看并没有type: 'module'

If the package.json specifies a type: 'module', then it means that the current module is ESM.
wechaty-puppet-padlocal has no type: 'module' so it's a CJS

其他puppet里我看是有这个配置的

wechaty, wechaty-puppet, and other Wechaty ecosystem modules have 'type: 'module' by default, which means that they are ESM modules.
And we have enabled the Dual-ESM-CJS for them when they have been built, so they can be used either by ESM or CJS.
I hope my explanations help you understand the situation, please feel free to let me know if you have more questions.

好的 谢谢解惑 我再研究一下

@leochen-g You are welcome!

any progress?

Finally! Congratulations! 🎉


Feature playwright tests cleanup

This updates the playwriting web tests to use a packaged version of the fixture.
It also fixes a number of minor issues with the tests and organises the test project a bit.
Using the fixture, we can remove the default ISocialMediaProvider instances, and only inject our stub. This is cleaner than delving into the code and updating a static list.
There is also some clean-up for the main web app.

I've incorporated some of the changes that were made to the fixture into the new package, but I also think that there were some assumptions made about the way it works that were incorrect. I have tried to document the alternatives and why/when to use the isolated versions (or not).
Please feel free to open a discussion or similar to better delve into this.

All playwright tests are now passing. Nothing is skipped. Works on github actions and locally.

Thank you very much for this contribution!


Feature 1

#1

Codecov Report

Merging #14 into master will increase coverage by 2.22%.
The diff coverage is 56.33%.

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   56.04%   58.27%   +2.22%
==========================================
  Files          25       28       +3
  Lines         728      798      +70
==========================================
+ Hits          408      465      +57
- Misses        320      333      +13

Impacted Files
Coverage Δ

src/Horarium/HorariumServer.cs
30.43% <0%> (+30.43%)
:arrow_up:

src/Horarium.AspNetCore/HorariumLogger.cs
25% <25%> (ø)

src/Horarium.AspNetCore/JobFactory.cs
40% <40%> (ø)

...rarium.AspNetCore/RegistrationHorariumExtension.cs
76.19% <76.19%> (ø)

src/Horarium/HorariumClient.cs
28.57% <0%> (+28.57%)
:arrow_up:

src/Horarium/Handlers/StatisticsJobs.cs
57.14% <0%> (+57.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c931361...e73f7ff. Read the comment docs.


Update MeiliSearch version in README (v0.22.0)

Should be merged once MeiliSearch v0.22.0 is released

Update README
Uncomment test since the related issue is fixed in v0.22.0

bors try


Configuration Sample for WKC in CPD 4.5.x and beyond

In Cloud Pak for Data v4.5.x, there are multiple options for installing WKC; specifically whether to include certain legacy capabilities or not, and whether to include newer functionality around lineage, quality, and factsheets.
https://www.ibm.com/docs/en/cloud-paks/cp-data/4.5.x?topic=catalog-preparing-install
Can we please get a sample configuration for how to select these different options with the Cloud Pak Deployer?
Thank you.

Piggybacked with #197


Broken images and "The handle is Invalid" error on web farm

Description of bug
DnnImageHandler generates an exception while serving images when the nodes of a farm use a shared network folder as the web root.
Steps to reproduce

Set up a simple web farm with ARR where all nodes share a common physical path in the network
Clear the ~\App_Data_imagecache folder
Navigate to the home page and log in (the user avatar is shown correctly)
Press F5 to refresh

Current behavior
The user avatar is broken.
There is an HTTP 500 error in the browser console related to DnnImageHandler.ashx.
Expected behavior
The user avatar should be displayed correctly.
Screenshots

Error information
The handle is invalid. (Exception from HRESULT: 0x80070006 (E_HANDLE))

Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.Runtime.InteropServices.COMException: The handle is invalid. (Exception from HRESULT: 0x80070006 (E_HANDLE))

Source Error:
An unhandled exception was generated during the execution of the current web request. Information regarding the origin and location of the exception can be identified using the exception stack trace below.

Stack Trace:
[COMException (0x80070006): The handle is invalid. (Exception from HRESULT: 0x80070006 (E_HANDLE))]

[HttpException (0x80004005): An error occurred while communicating with the remote host. The error code is 0x80070006.]
   System.Web.Hosting.IIS7WorkerRequest.RaiseCommunicationError(Int32 result, Boolean throwOnDisconnect) +4478821
   System.Web.Hosting.IIS7WorkerRequest.FlushCore(Boolean keepConnected, Int32 numBodyFragments, IntPtr[] bodyFragments, Int32[] bodyFragmentLengths, Int32[] bodyFragmentTypes) +11941829
   System.Web.Hosting.IIS7WorkerRequest.FlushCachedResponse(Boolean isFinal) +743
   System.Web.HttpResponse.UpdateNativeResponse(Boolean sendHeaders) +1330
   System.Web.HttpRuntime.FinishRequestNotification(IIS7WorkerRequest wr, HttpContext context, RequestNotificationStatus& status) +182

Affected version

[X] 10.00.00 alpha build (in development)
[X] 09.06.01 latest supported release
(and this probably goes back all the way to initial versions)

Affected browser

[X] Chrome
[X] Firefox
(I didn't try on other browsers)

Merged


Revert "updated bsd year from 2014 to 2017"

Reverts jupyter/nature-demo#20
Copyright should have year of first publication.

Thank you.


[Feature] Allow connecting to web sockets

Summary
Allow developers to connect to web sockets to build apps that can subscribe to events and real-time databases.
Motivation
Reddit comment: I'm missing an option to communicate over a web socket. I.e streaming a log file and/or sending multiple responses from my API would be super useful. Also, would sending and receiving messages from MQTT be a feasible feature?
It'll be useful for dashboards where data is updated in real-time.
Users could also add a chat window.
Additional Context
https://www.reddit.com/r/AskProgramming/comments/hn043x/any_opensource_alternatives_to_retool_or/gbyg694/?context=3
 Front conversations
Workaround
https://community.appsmith.com/t/how-to-create-an-appsmith-app-which-integrates-with-websockets/1958

MQTT

I am also waiting for this feature in appsmith because I am using appsmith monitoring work so without WebSocket I want to refresh every time in appsmith.

@Vibeesarma as a workaround, you can poll the data from your datasource using setInterval

@Nikhil-Nandagopal sorry, any updates of this feature?

@baguse none yet. We're currently focusing on improving the current integrations so we haven't added any new ones

Here is an alternative to how we can currently integrate websockets with Appsmith
https://community.appsmith.com/t/how-to-create-an-appsmith-app-which-integrates-with-websockets/1958

It would be helpful to have sockets exposed now the you have released the ability to add Custom Objects. In our use case a number of our network hardware vendors offer socket based communication for configuration of equipment and we would like to add this to one of our internal applications.

I'm trying to build something on Nostr with Appsmith but currently this is being a blocker. Do we have any roadmap to support websockets?

hello team,
When will this feature incorporated into Appsmith, we are planning to use web-sockets to create some realtime system.

any updates? how to use websocket

i think this would be helpful for example connecting to a stock broker API, to get instant live prices. Still a newbie :)

We actually have a tutorial available on how to do this now!
https://community.appsmith.com/tutorial/integrating-websockets-appsmith

Looking forward to an easy-to-use interface for websocket. I think it is very useful.

@fwhdzh Could you tell us what type of app you are building that requires real-time websockets? We'd also like to understand the backend service you are using for websockets

I'm building a website in which the user can click a button to send a request to the background to start a series of tasks. These tasks are executed sequentiall. However, the time budget they need can vary widely. I want the backend to be able to give the frontend a feedback when each task is done.
I knew I could solve this problem with better system design. For example, I can store the "feedback" in a database and show them in another format using AppSmith's DataSource. But for now, I don't want my application to interacte with a database. I could also use setInternal() to continously queries the backend, but that would be not elegant. Therefore, I think it is helpful to have a websocket can detect every update of the background and sent it to the frontend.

i am trying to build a bot for trading that requires me to have a WebSocket
to pull in live stock price ticker from my trading provider API to execute
trade if a particular price strikes
thank
Anto

Thanks
Anto
On Fri, Nov 3, 2023 at 6:35 AM Feng Wenhan @.***> wrote:

I'm building a website in which the user can click a button to send a
request to the background to start a series of tasks. These tasks are
executed sequentiall. However, the time budget they need can vary widely. I
want the backend to be able to give the frontend a feedback when each task
is done.
I knew I could solve this problem with better system design. For example,
I can store the "feedback" in a database and show them in another format
using AppSmith's DataSource. But for now, I don't want my application to
interacte with a database. I could also use setInternal() to continously
queries the backend, but that would be not elegant. Therefore, I think it
is helpful to have a websocket can detect every update of the background
and sent it to the frontend.
—
Reply to this email directly, view it on GitHub
https://github.com/appsmithorg/appsmith/issues/1866#issuecomment-1791763723,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOQV4K4YPZXTCIHX7MZSAKDYCQ7NHAVCNFSM4T7VMUAKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCNZZGE3TMMZXGIZQ
.
You are receiving this because you commented.Message ID:
@.***>

I'm building a dashboard that shows vehicle movements in real-time. Will be helpful to have this feature for connecting with websockets or MQTT.

@SrijitaRoy913 this is now possible. We have a guide for this here
https://docs.appsmith.com/build-apps/how-to-guides/set-up-websockets

Thanks for adding the feature!


Request to add HTML previews to notebook directories

When downloading a notebook, it is not obvious how to locate the HTML files.  These previews are helpful for the user to decide if the notebook applies to their data before downloading.
Since some users will browse these files via the repository directly, it would be helpful to provide either a copy of the html files or a hyperlink.
For example, DrizzlePac notebook 'aligning mosaics' is here:
https://github.com/spacetelescope/hst_notebooks/tree/main/notebooks/DrizzlePac/align_mosaics/align_mosaics.ipynb
But the preview file is at a very different URL:
https://spacetelescope.github.io/hst_notebooks/notebooks/DrizzlePac/align_mosaics/align_mosaics.html
This may be confusing for users, and I have had trouble navigating back and forth without bookmarking both pages. Any ideas how we can improve this?

Spoke with @eteq yesterday and got some helpful feedback.  Erik notes that we cannot put the rendered HTML pages into the github folders but we can link from the github pages back to the HTML pages.


show Boolean operators for combined queries

The query entries in the history really need to use Boolean operators (AND, OR, NOT) in the display for combinations. The descriptions with "union" and "intersect" are downright incomprehensible, as well as inconsistent with the rest of the internet's search engines.
As I've said on calls, I also want the Boolean operators show on the query-combining buttons; there I don't mind whether it's instead of or in addition to the union/intersection/subtraction language but I look for AND, NOT, and OR, so it slows me down not to see them.

The problem is that we have (lot's) of evidence that many people misinterpret Boolean AND/NOT or OR..... Lots of biologists don't know the difference between logical AND and well, ordinary  "AND" unfortunately.... (or even AND and OR come to that), and  at least  the Union/intersect is unambiguous.
But I guess as the visual clue is on the buttons, so  it doesn't make that  much difference so I'm happy for it to swap...although I think this way is clearer for the average user.

I still don't have a problem with the query-building buttons having both - it's the presence of AND (etc.) that I need, more than the absence of "intersection" (tho the latter doesn't communicate anything useful to me). I.e, I would find "OR (union)" and "AND (intersection" labels long-winded but basically OK.
I also don't have any first-hand observations of my own where people have problems understanding AND, NOT, and OR. Nor have I seen data from any studies.
The results really really need to use AND/NOT/OR, though, because the brevity is essential to making them readable. And if we have dual-labeled buttons, people will learn what AND means. They can then use the info all over the rest of the web, which uses Boolean operators.

I've made the buttons look a bit more buttony but now the AND, OR and NOT images look bad.  I'll work on that.

but now the AND, OR and NOT images look bad. I'll work on that.

They are slightly better now.

I don't see them after shift reload?

I don't see them after shift reload?

It wasn't a big change.  I only mentioned it in the issue so I wouldn't forget to fix them..

Label buttons
UNION/AND
INTERSECT/OR
Change labels in  history to Boolean

This change will appear in the dev overnight and in the preview sometime during the morning.


Do not suppress errors in SQL code blocks within Markdown files

The issue Trivadis/plsql-and-sql-coding-guidelines#130 describes a case where it would be beneficial to have the formatter to report errors in SQL code blocks of a Markdown file.
format.js reports errors in non-Markdown files by default (see https://github.com/Trivadis/plsql-formatter-settings/blob/sqldev-22.2.0/sqlcl/format.js#L522). However for Markdown files this feature is explicitly suppressed. The reason is, that not every SQL block in a Markdown file must be compatible with the Oracle dialect. However, I suggest to show the error by default and add an option to suppress  the reporting of errors in files (in general).

New options:
option noerr<scope>  suppress syntax errors. Valid values for <scope> are all, ext, mext, e.g. noerr=mext
The example would mimick the current behavior.

It's difficult to identify the code block with an error in a Markdown file. A solution would be to print the number of the SQL code block processed. Something like this:
Formatting file x of y: markdown.md... #1... done... #2... skipped... #3... done... done.

In this case 3 SQL blocks were processed. Block 1 and 3 where have been formatted. Block 2 has been skipped due to a syntax error.


Add new numbers starting with "96" in Nepal.

Recently new phone numbers have come in use  which start with "96".

May I know where do u find the mobile phone prefix?
As I try to find it in google, like this:
http://www.searchyellowdirectory.com/reverse-phone/977/
it stated 98, 99 are the mobile.


webhook/semaphore: Add only summary line to the notification message.

Commit messages with multiple lines in the body make the notification too noisy. The summary line of the message is sufficient in the notification.
Testing Plan:
Updated the existing test to verify this.

I wonder if we should change the common GH_PUSH_TEMPLATE to call the field commit_summary rather than commit_message; I think that might be the root cause of the semaphore webhook having used a full commit message there?

Yes, we could change the name of the field to be commit_summary instead of commit_message.


refactor: shared labels template

Cherry-picked the commit from https://github.com/SUSE/minibroker/pull/19, then applied some fixes to allow other labels to be set without having to set them in the template.

/hold
This PR needs to be updated just before getting merged. At the same time, it's blocked due to @jandubois CLA issue.

/check-cla

/hold cancel
@mook-as This should be ready for review.


Deleting old cutouts

Figure out how to delete old cutouts.
We made the cutouts table so that old cutouts can be deleted
CREATE TABLE cutouts.cutouts (
    imjd int,
    "cutoutId" ascii,
    cutoutimage blob,
    "objectId" bigint,
    PRIMARY KEY ((imjd, "cutoutId"))
)

What is the correct query to do this in cqlsh? The obvious doesn't seem to work ...
cqlsh:cutouts> delete from cutouts where imjd=60000;
InvalidRequest: Error from server: code=2200 [Invalid query]
message="Some partition key parts are missing: cutoutId"

The imjd column should actually be a float. Either that or a truncated float - so that we can select it exactly. Or (imjd, smjd) where secs is an integer number of seconds (intra day) generated from the mjd. Then we have the "entropy" that we need to evenly distribute the data.  So our whole index would be something like ((imjd, smjd), "cutoutId") - or we just have a new column which is mjdsecs, which is just a concatenation of imjd and the number of seconds in that day (e.g. mjdsecs, hence index would be just (mjdsecs, "cutoutId"). Will do some local experiments...) Could be 10s of seconds or minutes. We already calculate the imjd from the jd anyway, so why not go a bit deeper than just days. A single column makes things easier to select. E.g. mjd * 1000 + (int)(day/1000) or mjd * 100000 + (number of seconds).

It also turns out that Cassandra has a built in TTL (time to live) when doing INSERTs (specified in seconds), which would completely eliminate the need to do the deletes manually.  E.g.:
INSERT INTO cutouts (imjd, "cutoutId", cutoutimage, "objectId") VALUES (...) USING TTL 7776000;

(where 7,776,000 seconds is 90 days - or we could calculate the offset from the MJD in the alert packet)
We could experiment with doing inserts with very low TTL.  If we go down this route we should change the definition of the table to explicitly use the Time Window Compaction Strategy.
Experiments to follow for both methods above.


Feature request: Add --installation-path option to anaconda formula

Hi.
Description of feature/enhancement
Add an option to change the path the Anaconda installation script installs itself to.
Justification
By default the Anaconda installation script installs to ~/anaconda[3]. Users who don’t want software installed in their home directory, which is not meant to contain software, have no option to change this path atm. Luckily the install script offers to change this path by supplying a -p PREFIX option but it is not supported by the anaconda formula.
From Anaconda's usage message:
-p PREFIX    install prefix, defaults to /Users/dirk/anaconda3

Unfortunately I don’t know ruby and haven’t found documentation about adding options to formulas so I cannot do it myself.
Example use case
Installing anaconda to /opt/anaconda[3] to avoid polluting one's home directory.

adding options to formulas

We don’t have formulas, we have casks. Those don’t support install flags, and there’s no plans to introduce the feature.

But we can make it install somewhere else by default. https://github.com/caskroom/homebrew-cask/pull/32706


Missing Active Authority while adding active authority

This is a re-post of https://github.com/cryptonomex/graphene/issues/630, since it can be solved in GUI alone.
Exception Missing Active Authority is reported while trying to add TEST56ankGHKf6qUsQe7vPsXTSEqST6Dt1ff73aV3YQbedzRua8NLQ as another active key authority to http://testnet.bitshares.eu/#/account/testaccount1/permissions/, even if threshold set to 1 and weight of all keys set to 1. Private key of the new new public key is 5K9piFpyJ15zcYBc4R3gAeLFYb6PuRFEiDCbzLkSL9C4d7fWLyB .
Original key pairs of that account:

Active: TEST8me6d9PqzTgcoHxx6b4rnvWVTqz11kafidRAZwfacJkcJtfd75 5JBqM3timYgxvAjd7ddBhr4mdQq8foP3rLVXrphZCs6aYdJ48u2
Owner: TEST6vGWLjXrB971RXKoejCsZoAsv1wbfEmwNK7deN3kcdYQFck8wb 5JSKnvw8AodxNrgE8uETCApJUmZ7u3t1tSWp3ay823MNhmyAmqS

It turns out that the transaction which contains multiple key authorities and signed by GUI is rejected by witness_node.
As @theoreticalbts commented in https://github.com/cryptonomex/graphene/issues/630#issuecomment-199950145
and https://github.com/cryptonomex/graphene/issues/630#issuecomment-199981206, the issue can be fixed in GUI:

the key_auths are sorted when this structure is serialized. So if the GUI isn't using the same sorting as the C++, it's not going to accept the sig.

The currently used sorting mechanism is to convert the keys to addresses, then sort by address. Addresses themselves are sorted by hex value.

The branch https://github.com/cryptonomex/graphene/commit/38a0f3a9a4e611d806342e77632e1b58a1172c56 implements a sort-keys binary which creates 100 public keys and sorts them. The GUI should work if it sorts the keys in the same order. Sorting consists of converting the keys to addresses, converting the addresses to hex and then sorting the hex values. Addresses should be sorted the same way for address_auths.

To be more clear, the method to convert a public key to address is:
       auto dat = pub.serialize();
       addr = fc::ripemd160::hash( fc::sha512::hash( dat.data, sizeof( dat ) ) );

The master and the stealth branch will sort public keys by the address.  Sample data from @theoreticalbts's sort-keys program was used to show the sorting is not alphabetical but instead by address..

@jcalfee I think this code need to be reverted (addresses should be sorted in ascending order)

Don't revert..I fixed it...
Sorry about all the messy diff, the atom spaces plugin goes crazy changing the whole file.  I have disabled it.

Confirmed to be working in current master.


Making the landing page responsive

kindly assign me this task to contribute in desired changes under GSSoC'23 @mhdamaan79

Already assigned to someone


[azure-core-cpp] Update to 1.1.0

Update vcpkg ports for Azure SDK release. This release may contain multiple ports.

All features are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

cc @RickWinter, @vhvb1989

cc @ras0219-msft

LGTM, thanks!


Make "student" singular when only 1 student is displayed

Changes

Update message to be grammatically correct when only 1 student is listed

Codecov Report

Merging #279 (9b065a6) into master (5fd50b1) will increase coverage by 1.32%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master     #279      +/-   ##
============================================
+ Coverage     74.31%   75.64%   +1.32%
- Complexity      925      972      +47
============================================
  Files           105      105
  Lines          2920     2985      +65
  Branches        396      418      +22
============================================
+ Hits           2170     2258      +88
+ Misses          647      619      -28
- Partials        103      108       +5

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

...va/seedu/address/logic/commands/SearchCommand.java
95.23% <66.66%> (-4.77%)
:arrow_down:

...ain/java/seedu/address/commons/util/ChartUtil.java
45.94% <0.00%> (-1.12%)
:arrow_down:

...main/java/seedu/address/model/student/Student.java
96.42% <0.00%> (+6.87%)
:arrow_up:

...seedu/address/model/student/StudentStatistics.java
85.71% <0.00%> (+42.85%)
:arrow_up:

...a/seedu/address/model/student/GroupStatistics.java
82.22% <0.00%> (+82.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fd50b1...9b065a6. Read the comment docs.


Add option for SSL version

PaySimple only accepts SSL connections with version TLSv1.2. Since this is an option that can be passed to RestClient and the PaySimple configuration is bound to change in future, I've added this as the option ssl_version that is set just like the API key and API user configurations. Yes, it doesn't look like a setting for the Paysimple module, but it at the same time kind of is since it's a restriction from their end.

Hey @jerryjohnjacob , thanks for the request. I agree that it's a useful settings, though it'd be nice to have TLSv1.2 as a sensible default value for ssl_version, so that we wouldn't have to specify it every time unless it changes. Could you please add it?

@koss-lebedev Really sorry for the late response. Yes, I think a default makes sense. I have updated the repo with the necessary changes :)

Thanks, merged it in


feat: add css preload tag when prerendering

Adding a <link rel="preload"> tag to prerendering for stylesheets is helpful for static page rendering. This is especially useful when deploying to Cloudflare, which looks for preload tags with its Early Hints feature.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

[x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Looks good to me. @benmccann was there a reason we didn't have this even before we added Link headers in https://github.com/sveltejs/kit/pull/5735 ?

I think that it's probably because that in the general case it doesn't actually do anything and just adds extra page weight since CSS is already loaded with highest priority. This is kind of a Cloudflare-specific functionality. I feel like the best solution here would probably be for Cloudflare to send early hints for all CSS rather than just preloaded CSS so that we don't have to duplicate all the CSS tags as preload tags and so that more of their customers benefit from that functionality.

@benmccann That's fair, do you think it would be in-scope to have adapter-cloudflare output any Link headers in prerendered pages to Cloudflare's _headers file instead of the changes in this PR?

For this PR: I think the above changes I've suggested are probably more resilient long-term but harder to work out the implementation details. In the short term, would there be support for adding in <link rel="preload"> tags instead of the headers as a configuration option, disabled by default?

@dario-piotrowicz any chance you might be able to put in a request to have Cloudflare send early hints for all CSS rather than just preloaded CSS? (see above for context: https://github.com/sveltejs/kit/pull/12247#issuecomment-2125528274. happy to clarify on Discord if that's easier)

Dario suggested an interesting answer that might be the way to go here. I tested and, at least in chrome, you don't need both a tag to preload it and a tag to load it. You can simply preload it and that is enough. My firefox instance isn't starting, so I can't test there.
That would break IE users, but that ship may have sailed. Perhaps we should user agent sniff and not do it there though? Might have to take a look at https://github.com/sveltejs/kit/pull/6265 to see how badly broken we are in IE right now

@benmccann Sorry for the super delayed response. I updated this feature to be gated behind a config option that defaults to false, since I'm not super confident about changing the default behavior to only emit using preload tags with the standard stylesheet <link> tags. Is this reasonable for merging?

LGTM. @benmccann what do you think? It has a config option defaulting to false at the moment so it shouldn't break anything.

We've generally tried to avoid adding options to reduce user complexity. I think always adding the preload in place of the normal css loading would be preferable. The framework should take care of these decisions for users. By creating an option we just add decisions that users are responsible for making

Okay, will close based on discussion above.


Updating README on Example branch

Updates
I updated the readme file. Please review and accept.

Thoughts
I probably shouldn't, but okay. 👍


🔄 Synced file(s) with BetaHuhn/github-files

Synced local file(s) with BetaHuhn/github-files.

Changed files

Synced local  .github/workflows/release.yml with remote  workflows/versioning/release.ymlSynced local  .github/workflows/lint.yml with remote  workflows/node/lint.ymlSynced local  LICENSE with remote  LICENSE

This PR was created automatically by the action-github-file-sync workflow run #474147881

:tada: This PR is included in version 1.0.1 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.1 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


CI/CD and Download Compiled Version

Hi,
I created some GitHub Actions to test and compile the Go program. A user can then download the compiled and ready to use version. No golang needed.
You must adjust the Workflow permissions and allow read and write:

Then you can create a release with the tag format v*.*.*.
GitHub Action will compile and upload the compiled binaries to the release.
Example: https://github.com/Cyclenerd/go-andotp/releases
I also changed the min. go version to 1.20 for Windows and ARM support.
The README.md is optimized for copy and paste.
Best regards
Nils

Thank you for taking time to improve the release format and introducing CI/CD. Let me get back to this PR this coming weekend.

@Cyclenerd Can we add build instructions in README (commands in build.sh should be fine). Rest looks good. Thanks.

Thank for the feeback @RijulGulati. I added a little more help to the README.

Merged! Thanks.


Exception has occurred: HTTPError HTTP Error 403: Forbidden

🐛 Bug

To Reproduce
Steps to reproduce the behavior:
1.data = datasets.MoleculeNet(root='.',name='FreeSolv')
Dataset Download is forbidden.

Expected behavior

Environment

OS:
Python version:
PyTorch version:
CUDA/cuDNN version:
GCC version:
Any other relevant information:

Additional context

Please see https://github.com/rusty1s/pytorch_geometric/issues/1794.

thanks

Please see #1794.
Hi,  I think the address changed again. I found the new address should be "https://deepchemdata.s3-us-west-1.amazonaws.com/datasets/SAMPL.csv"


CRAYSAT-1620: Changes for setting up SAT on an external system

Since public access to artifactory.algol60.net is being shut down, it is no longer possible to install SAT CSM Python Dependencies by setting PIP_EXTRA_INDEX_URL and installing the source tarball or binary distribution versions of SAT dependencies.
This commit updates the instructions for setting up SAT on an external system to provide steps to install the required packages from source rather than from artifactory.
Test Description: I ran the relevant steps locally and verified I could install SAT into a VirtualEnv without accessing artifactory.
Testing
See commit message
Pull Request Checklist

[X] Version number(s) incremented, if applicable
[X] Copyrights updated
[X] License file intact
[X] Target branch correct
[X] CHANGELOG.md updated
[X] Testing is appropriate and complete, if applicable
[X] HPC Product Announcement prepared, if applicable

@ekamin-hpe, just curious, is this change for Papaya or Alice?

@ekamin-hpe, just curious, is this change for Papaya or Alice?

I think it would be for both Papaya and Alice, but it's kind of a complicated question because it's not really for any release.
These instructions are sort of "unofficial" instructions on setting up SAT on an external system and the deadline for this change is whenever CASM shuts down external access to csm-python-modules. Really if these instructions existed on the release/2.3 branch (raspberry) I would entertain the idea of patching that branch as well.


Update stepped process documentation

Related issues
Closes #1868
Description
I added a callout message to inform our users about the $stepped-process-max-items variable.
Motivation & Context
Have a better documentation for the stepped process component.
Types of change

Refactoring (non-breaking change)

Live previews

https://deploy-preview-1908--boosted.netlify.app/docs/5.3/components/stepped-process/

Checklist
Contribution

[x] I have read the contributing guidelines

Accessibility

(NA) My change follows accessibility good practices; I have at least run axe

Design

(NA) My change respects the design guidelines defined in Orange Design System
(NA) My change is compatible with responsive display

Development

[x] My change follows the developer guide
(NA) I have added JavaScript unit tests to cover my changes
(NA) I have added SCSS unit tests to cover my changes

Documentation

[x] My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

[x] My change introduces changes to the migration guide
(NA) My new component is added in Storybook
(NA) My new component is compatible with RTL
(NA) Manually run BrowserStack tests
(NA) Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
[ ] Code review
(NA) Design review
(NA) A11y review

After the merge

[ ] Manually launch Percy tests

Questions waiting for your opinions:

[ ] Should this information be in a callout or not?
[ ] Should we rename the $stepped-process-max-items variable because it's not really a limitation as explained in the related issue.  But it will be a breaking change and not really needed? 🤔


fix typo

this line were throwing a referrence error when the update function wasnt successful

Whoops. Thanks!


Infer type-graphql fields from mikro-orm properties

Is your feature request related to a problem? Please describe.
I have come to MikroORM due to Prisma + Nexus not supporting MongoDB yet. As I want to use GraphQL, I find that I have a lot of repeat code due to having to declare both @Field() from type-graphql and @Property from @mikro-orm/core.
Both of them declare the same thing in different ways. For example @Field(() => [Task]) to define a collection in type-graphql, and @Property(() => Task) followed by new Collection<Task>(this) in mikro-orm
You may consider me lazy for this request, but the main driver behind this request is the fact that about half of my MikroORM development time is trying to figure out why the graphql portion doesn't work (eg accidentally doing @Field(() => Task) instead of @Field(() => [Task]) - so if it could be derived from the existing declaration, development would be faster.
I am going to use the following entity in this example - this is an example snippet from a user entity.
@Entity()
@ObjectType()
export class User extends BaseEntity {
  @Field()
  @Property()
  public name: string;

  @Field()
  @Property()
  public email!: string;

  @Property()
  public password: string;

  @Field(() => [Task], { nullable: true })
  @OneToMany({
    entity: () => Task,
    mappedBy: "owner",
    nullable: true,
  })
  public tasks? = new Collection<Task>(this);

  @Field(() => [Group], { nullable: true })
  @OneToMany({
    entity: () => Group,
    mappedBy: "leader",
    nullable: true,
  })
  public groups? = new Collection<Group>(this);
}

I guess there would then be an option inside mikro-orm.config.ts that is like outputGraphql: true which enables this inferrance.
Describe the solution you'd like
I would like the @Field() to be assumed, unless I say otherwise. One example could be @Private() decorator.
@Entity()
export class User extends BaseEntity {
  @Property()
  name: string;

  @Property()
  email!: string;

  @Property()
  @Private()
  password!: string;

  @OneToMany({
    entity: () => Task,
    mappedBy: "owner",
    nullable: true,
  })
  tasks? = new Collection<Task>(this);

  @OneToMany({
    entity: () => Group,
    mappedBy: "leader",
    nullable: true,
  })
  groups? = new Collection<Group>(this);
}

Describe alternatives you've considered
The first alternative could be for the public and private scopes to define whether it gets output to GraphQL or not. But this is probably worse practice than above.
@Entity()
export class User extends BaseEntity {
  @Property()
  public name: string;

  @Property()
  public email!: string;

  @Property()
  private password!: string;

  @OneToMany({
    entity: () => Task,
    mappedBy: "owner",
    nullable: true,
  })
  public tasks? = new Collection<Task>(this);

  @OneToMany({
    entity: () => Group,
    mappedBy: "leader",
    nullable: true,
  })
  private groups? = new Collection<Group>(this);
}

While I do understand why you want it, this is definitely not something to be part of this repository. Good idea for a 3rd party module for sure - if I would be using type-graphql myself, I would have probably made such 3rd party module already - but I am not :]
Btw you are basically asking for me to fill the type-graphql metadata - that itself sounds very wrong idea, and might not be even possible (depends on where/how type-graphql stores the metadata).

While I do understand why you want it, this is definitely not something to be part of this repository. Good idea for a 3rd party module for sure - if I would be using type-graphql myself, I would have probably made such 3rd party module already - but I am not :]
Btw you are basically asking for me to fill the type-graphql metadata - that itself sounds very wrong idea, and might not be even possible (depends on where/how type-graphql stores the metadata).


How can i use name "fields" in BaseModel?

Question
Because of my needed for software, i want to use "fields" name in BaseModel.
Is it possible to to use the name of "fields"?
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
pydantic version: 1.4
            pydantic compiled: True
                 install path: /DataStorage/cheesiang_leow/handwritten_recognizer/production/fastapi_prod/venv/lib/python3.6/site-packages/pydantic
               python version: 3.6.5 |Anaconda, Inc.| (default, Apr 29 2018, 16:14:56)  [GCC 7.2.0]
                     platform: Linux-4.15.0-66-generic-x86_64-with-debian-buster-sid
     optional deps. installed: []

import pydantic
from pydantic import BaseModel

class Model(BaseModel):
    name_1:str
    name_2:str
    fields: List[Dict]

model = Model()
...

The code i ran above it shows below's error.
Traceback (most recent call last):
  File "model.py", line 76, in <module>
    class Model(BaseModel):
  File "pydantic/main.py", line 191, in pydantic.main.ModelMetaclass.__new__
  File "pydantic/utils.py", line 93, in pydantic.utils.validate_field_name
NameError: Field name "fields" shadows a BaseModel attribute; use a different field name with "alias='fields'".

I know if i use other name like Fields is ok, but i want to use lowercase fields.
I don't understand the meaning of use a different field name with "alias='fields'".
Do you have any example with this?

as per the docs
Use
import pydantic
from pydantic import BaseModel

class Model(BaseModel):
    name_1:str
    name_2:str
    fields_value: List[Dict]

    class Config:
        fields = {'field_value': 'fields'}


Add documentation

The scripts require some basic and easy to read documentation. Right now they just have the comments, which are not that good.
This documentation should include at least:

Parameters list
Usage example
What does the script do
Language and framework they are meant for

Maybe Jekyll can be useful for this?
Check this for example: http://java-design-patterns.com/patterns/

Alternatively just use Sphinx.


Swift package manager support

Issue: https://github.com/nlohmann/json/issues/2802
Discussion: https://github.com/nlohmann/json/discussions/2806
This adds support for the Swift Package Manager on Apple platforms.
I had to add an empty file to make SPM build the target, as header-only targets are not currently supported in the Swift Packages.
Similar solution has been used in Apple's swift-numerics repository:
Discussion: https://forums.swift.org/t/header-only-library-using-swift-package-manager/42700
Repository: https://github.com/apple/swift-numerics/blob/main/Sources/_NumericsShims/_NumericsShims.c

Pull request checklist
Read the Contribution Guidelines for detailed information.

[x]  Changes are described in the pull request, or an existing issue is referenced.
[x]  The test suite compiles and runs without error.
[x]  Code coverage is 100%. Test cases can be added by editing the test suite.
[x]  The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

Please don't

The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for these kind of bugs). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
Please do not open pull requests that address multiple issues.

Do all files need to be put into the repository root?

As for now, this is impossible, as the "Swift Package" is defined as:
"a git repository with semantically versioned tags, that contains Swift sources and a Package.swift manifest file at its root."
https://github.com/apple/swift-package-manager/blob/main/Documentation/Usage.md#creating-a-package
So, the Package.swift should be in the root. However, the empty file can be located anywhere.

Coverage remained the same at 99.982% when pulling 7e92c8af4b6d3fcfc0b01637095a6b19082e99fb on richardtop:swift-package-manager into e10a3fac8a255433146e3f06a703dc110fc3c3da on nlohmann:develop.

Please, let me know if there is anything preventing this pull request from being merged, I'm happy to make changes to get this finalized.

However, the empty file can be located anywhere. Would you like me to relocate it somewhere?

is that file really needed?

Yes, unfortunately, there is no way around it. I've added the comment about why that file is needed, it's a known limitation of the Swift Package Manager. Even Apple's official repositories use this approach: https://github.com/apple/swift-numerics/blob/main/Sources/_NumericsShims/_NumericsShims.c

I honestly do not like this. For Homebrew, I have a dedicated repository not to "spam" this repository: https://github.com/nlohmann/homebrew-json. Maybe this is a good approach also for the Swift package manager - especially if the file does not need to be updated with every release. What do you think?

While I also don't like it, I'm not sure if this is possible with the current state of the SPM, as it expects Package.swift to be in the root of the repository.
Since it's known limitation, I'm pretty sure it'll be resolved in next versions of the SPM, since it's developing really fast.
On the other hand, not supporting SPM would complicate usage of this library for Apple platforms developers, as SPM is becoming the industry standard when managing dependencies for Apple apps.

I honestly do not like this solution. I am sorry that this is inconvenient for Apple users, but if every package manager dumps a few files to this repo, then it starts to get really ugly... Sorry.

No problem, I understand. Apple users always have to think different✌


Update to support multiple targets for tabs

Support multiple targets for tabs, fixes #19964

@Johann-S: maybe you add a test?

@amos-whitewolf: can you rebase and also take care of the unit test?

Closing due to lack of response. You can comment here and we can re-open the PR, if you decide to resume working on the requested changes.
This is an automated reply

Is there any update on this?

If the op replies and take care of the reviews, doens't this need a update on docs or an example to show when this use case is important or why bs support it?
Sorry if i missed some point that explain this.

If the op replies and take care of the reviews, doesn't this need a update on docs or an example to show when this use case is important or why bs support it?
Sorry if i missed some point that explain this.

Yeah, that's what I was looking for as well. As I am trying to use it break up news articles with other content, that are all linked via panels.


allow set to set alpha

I have around this code on which I have to hold the clone to be able to change the alpha.
function hueColor(aColor) {
  const color = aColor.clone().set({ 'hsv.s': 100, 'hsv.v': 100 })
  color.alpha = 1
  return color.display({ precision }).toString()

It would be nice if this could be done in one step, like
function hueColor(aColor) {
  return aColor
      .clone()
      .set({ 'hsv.s': 100, 'hsv.v': 100, 'alpha':1 })
      .display({ precision }).toString()
}

I totally agree! Have you tried it, I thought it was already possible.

I believe I did


React-group-project: Rocket booking

In this PR
I implement

Actions to book a rocket
Actions to cancel a booking for a rocket
Toggle the reservation button so that the text corresponds to the state
Toggle the reserved badge to display on not depending on whether the rocket is booked
Styled the rocket page to be consistent with the provided mock

STATUS: APPROVED 🎉🎉🎉
Hello @kkolade  !
Great job! We can now merge this pull request!.

Highlights
Correct linters ✅
Great use of gitflow ✅
Good code design and implementation ✅
Good API implementation  ✅
Required Changes ♻
None
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
N/A
Cheers and Happy coding!👏


feat: handling multiple designs

Closes #792

Nice work! 🙂
Since this PR will cause performance issues, we could implement a selector to let users decide whether they need to use multiple designs or not. As discussed offline, a good option would be to create a global flag to perform this selection.

Agreed. As we discussed, I think it is a great suggestion. Thanks @AlejandroFernandezLuces! By default I would leave it active for multiple designs.


Added The Piggott C of E School

https://www.piggottschool.org

@Max-Hitchings First stage of verification passed, official domain is piggottschool.org as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@Max-Hitchings Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Should throw an error if two PathMaps share an identical remotepath or localpath

Steps to reproduce:

Work on projects from two machines with different local directory structures, and share Atom settings between them for convenience.
Enter PathMaps as the following:

    PathMaps: [
      "remotepath;localpath"
      "/sites/mysite/www;/Users/mitch/Documents/work/mysite"
      "/sites/mysite/www;/Users/mitch/Documents/home/mysite"
    ]

Attempt to set a breakpoint from the code stored in home

This would pertain to the opposite as well (a localpath points to two remotepaths).
Resolution:

Reduce PathMaps in remotePathToLocal and check for identity before returning, showing a Notification to the user if duplicates are found.

Happy to work on a PR if this is something people are interested in.

It would be great if you could provide a PR to fix this.

Should be fixed in v0.3.0


[Quickdraw] I am here to learn how to open and close issues on Github! 🤠

I am here to learn how to open and close issues on Github! 🤠
I will close it in 10 seconds 🤞

ok

everyone i was bored in cs class and have since prayed for forgiveness. i sincerely apologize to anyone reading this comment


KeyError: 'text'

I tried to execute the following command,
autotrain llm --train --project_name my-llm --model meta-llama/Llama-2-7b-hf --data_path ./ --use_peft --use_int4 --learning_rate 2e-4 --train_batch_size 12 --num_train_epochs 3 --trainer sft

but I keep getting a 'key error'.
> ERROR   train has failed due to an exception:
> ERROR   Traceback (most recent call last):
  File "/home/liang/miniconda3/envs/huggingface/lib/python3.10/site-packages/autotrain/utils.py", line 280, in wrapper
    return func(*args, **kwargs)
  File "/home/liang/miniconda3/envs/huggingface/lib/python3.10/site-packages/autotrain/trainers/clm/__main__.py", line 297, in train
    trainer.train()
  File "/home/liang/miniconda3/envs/huggingface/lib/python3.10/site-packages/transformers/trainer.py", line 1555, in train
    return inner_training_loop(
  File "/home/liang/miniconda3/envs/huggingface/lib/python3.10/site-packages/transformers/trainer.py", line 1815, in _inner_training_loop
    for step, inputs in enumerate(epoch_iterator):
  File "/home/liang/miniconda3/envs/huggingface/lib/python3.10/site-packages/accelerate/data_loader.py", line 556, in __iter__
    next_batch, next_batch_info = self._fetch_batches(main_iterator)
  File "/home/liang/miniconda3/envs/huggingface/lib/python3.10/site-packages/accelerate/data_loader.py", line 519, in _fetch_batches
    batches.append(next(iterator))
  File "/home/liang/miniconda3/envs/huggingface/lib/python3.10/site-packages/torch/utils/data/dataloader.py", line 633, in __next__
    data = self._next_data()
  File "/home/liang/miniconda3/envs/huggingface/lib/python3.10/site-packages/torch/utils/data/dataloader.py", line 677, in _next_data
    data = self._dataset_fetcher.fetch(index)  # may raise StopIteration
  File "/home/liang/miniconda3/envs/huggingface/lib/python3.10/site-packages/torch/utils/data/_utils/fetch.py", line 32, in fetch
    data.append(next(self.dataset_iter))
  File "/home/liang/miniconda3/envs/huggingface/lib/python3.10/site-packages/trl/trainer/utils.py", line 464, in __iter__
    buffer.append(self.formatting_func(next(iterator)))
  File "/home/liang/miniconda3/envs/huggingface/lib/python3.10/site-packages/trl/trainer/utils.py", line 440, in <lambda>
    self.formatting_func = lambda x: x[dataset_text_field]
KeyError: 'text'

My dataset looks like below:
text, label
12345, 1

do you have any other csv or data files in ./ ?

Only this one.

is it named train.csv or something else? when using csvs the valid names are only train.csv and valid.csv if you dont specify the name explicitly using --train-split and --valid-split

Thank you for your response. Indeed, the issue was that I named the training set something other than train.csv. After renaming it, the training proceeded normally.

I am having the same error, even in a did have atrain.csvfile that i did put in a directory called data, and I did specify the directory path using --data_path

Same as above.


Consider more tasks for a weekly cron

We currently have two cron jobs that close stale issues and pull requests, and I can think of some other things it might be nice to automate on a similar timescale in the core package specifically:

Running the IERS update script (update_builtin_iers)
Updating the list of contributors in credits.rst (EDIT: see astropy/astropy-procedures#122 and https://github.com/sunpy/sunpy/blob/master/tools/generate_releaserst.xsh)

and potentially other actions. This could then result in a e.g. weekly or monthly PR by the bot to update the relevant files.
We could also consider some kind of automation for backports, and could leave a comment on PRs that can't be backported cleanly (or open an issue about it). Obviously this requires more thought, but just brain dumping for now.
If we can automate some of these things, it could mean less work at release time.

This looks like an "epic" (JIRA speak!) and will need to be broken down to smaller items that people can tackle. Or at least a concrete check list.
Like, the first 2 bullets can be turned into checkboxes, and then the "brain dumping" part can be a few more.

We currently have two cron jobs that close stale issues and pull requests

By the way, are the cron job scripts even in this repo? I cannot find them.

For "Updating the list of contributors," does that cron job have git installed?

Imo updating the contributors from cron will generate more interrupts and actions for maintainers than doing it in one go before a release. Names are not easy, and many times are not automatable (see badly configured git, duplicate names, etc).

Running the IERS update script

Here are the steps from astropy release procedures:

Use git to grab the latest master branch of astropy.
Change directory to astropy/utils/iers/data.
Execute update_builtin_iers.sh.
Open a PR if there is a difference (in eopc04_IAU2000.62-now?).

Re: Running the IERS update script
I have a proof-of-concept script using batchpr in this gist. Seems to work when there is a change (see astropy/astropy#10500).
TODO:

Have to test to see if it will refrain itself from opening a dummy PR when there is no diff.
Have to think about what happens when there is a PR open by the cron job already, but we are not fast enough to merge it, and cron job kicks off again and opens a duplicate PR.


Syntax Highlighting for Expr

Currently Expr objects display as simple monospace, which is hard to read for more complex expressions. Would be really nice to hook into syntax highlighting here somehow.

This is something that really should be fixed in Julia Base, by adding text/markdown or text/html show methods for Expr.

Wouldn't it be quite a lot easier to reuse CodeMirror and its highlighting in the Jupyter frontend?

Ah, but of course, it is just a trivial definition if you use markdown output;
function Base.show(io::IO, ::MIME"text/markdown", x::Expr)
  println(io, "```julia")
  show(io, x)
  println(io, "```")
end

@MikeInnes: how and where does your show method work?


TC-CC-3.4 Test case queries

I'm wondering how the test goes to commission TH when the DUT selects the client role of the cluster, the DUT itself is a commissionee, except that it contains client clusters. could it be that the DUT here needs to run a chip-tool tool? The example is as follows
tests:
#- label: "Wait for the device to be commissioned"
#  cluster: "DelayCommands"
#  command: "WaitForCommissioning"
- label: "PreCondition: Set TH OnOff to On"
  cluster: "On/Off"
  wait: "On"

- label: "DUT sends MoveToHue command to TH an Hue with _TransitionTime 300"
  wait: "MoveToHue"
  PICS: CC.C.C00.Tx && CC.C.F00

@yf-fan-org Could you reach out to @Survensa and ask on how to run this test


buildGhidraJar  and Python support

Hi,
buildGhidraJarREADME.txt states Use of other non-Java scripting languages such as Python is not supported when running  from a single Ghidra jar configuration.
I wonder why this is the case and what would be required to add python scripting support (on my own)?

I'm guessing that Jython doesn't know how to find its own files when they exist only within the jar.  I'll have to play with it a bit more to give you an exact answer though.

That would make sense. Thanks, I'll play around with that and close the issue for now.


Releasing v5.3.2

(I've already published to Rubygems).

You can just commit these when making a release @mzikherman. Thanks for taking care of that!

I have the Rubygems permission to publish it but I don't think I'm a collab on this repo in GitHub (I didn't have the right creds to push upstream).

You were invited, just never accepted, go to https://github.com/mongoid/mongoid-slug/invitations.

Ah, just did it, thanks for helping out this open source n00b @dblock

Check email spam too for next time.


Unable to use chromedp Docker image

What versions are you running?
Running the chromedp/headless-shell:latest docker image
Running Ubuntu 18.04
What did you do? Include clear steps.
Running the container with the command outlined in the readme:

docker run -d -p 9222:9222 --rm --name headless-shell chromedp/headless-shell

The command runs successfully, but when looking into the container I see a lot of error messages. What could be the issue? Thank you!
What did you see instead?
`[1030/152232.814939:WARNING:resource_bundle.cc(428)] locale_file_path.empty() for locale
[1030/152232.967497:WARNING:resource_bundle.cc(428)] locale_file_path.empty() for locale
DevTools listening on ws://<IP_ADDRESS>:9222/devtools/browser/e5dbacd0-ef6a-467a-913e-4b222813d674
[1030/152233.322688:WARNING:resource_bundle.cc(428)] locale_file_path.empty() for locale
[1030/152233.323287:ERROR:egl_util.cc(60)] Failed to load GLES library: /headless-shell/swiftshader/libGLESv2.so: /headless-shell/swiftshader/libGLESv2.so: cannot open shared object file: No such file or directory
[1030/152233.323837:WARNING:resource_bundle.cc(428)] locale_file_path.empty() for locale
[1030/152233.324883:ERROR:viz_main_impl.cc(167)] Exiting GPU process due to errors during initialization
[1030/152233.326917:WARNING:gpu_process_host.cc(1207)] The GPU process has crashed 1 time(s)
[1030/152233.482589:WARNING:resource_bundle.cc(428)] locale_file_path.empty() for locale
[1030/152233.482899:ERROR:egl_util.cc(60)] Failed to load GLES library: /headless-shell/swiftshader/libGLESv2.so: /headless-shell/swiftshader/libGLESv2.so: cannot open shared object file: No such file or directory
[1030/152233.483855:ERROR:viz_main_impl.cc(167)] Exiting GPU process due to errors during initialization
[1030/152233.485564:WARNING:gpu_process_host.cc(1207)] The GPU process has crashed 2 time(s)
[1030/152233.485677:ERROR:browser_gpu_channel_host_factory.cc(138)] Failed to launch GPU process.`

solution ??

Did you solve the problem, I encountered the same problem

@donfrigo why did you close this issue? Is it a non-issue? Pls comment

Hi @briansorahan! I closed it in favor of https://github.com/chromedp/chromedp/issues/502, although I still haven't figured out this whole issue.


More typescript & cleanups

This is a second step in the transition to TypeScript (#7).
For now I:

renamed all files to .ts/.tsx
deleted some unused code (#22)
fixed issues that came up (see commit comments)

Some axios calls had options not appropriate for axios, e.g. referrer, agent and credentials. I just commented those since everything works without them. But it's interesting that one of those (agent) was responsible for BACKUP_PROXY stuff on goodjudgement. Unsure, should I fix BACKUP_PROXY properly, or are we ok without it?
PS: enabling strict in tsconfig.json (i.e., the actually useful mode which gives most benefits from using typescript) displays 523 errors. I'll either temporarily turn it on from time to time and try to bring this number down (without spending too much time on this), or wait until other code cleanups first.

So the goodjudgment script doesn't currently work on heroku. But I figured it did work if I used, e.g., some proxies from Hetzner (https://spys.one/proxy-asn/24940/). This wasn't working, so my workaround is to run a crontab on my machine. But fixing the proxying would be great.

Feel free to merge this @berekuk; I'm not seeing how that could cause any particular problems.

Yeah, I'm going to merge this; don't think anything particularly bad will happen.


Report name issue.

Hi,
the ExtentManager.cs class has the private static ExtentHtmlReporter getHtmlReporter() method which instantiates the htmlReporter = new ExtentHtmlReporter(ReportLocation);
The ReportLocation is a string path to the location and name of the report.
Ex: D:\Projects\MyProject\ExtentReports\my_report_name_dd-MM-yyyy.html.
This worked perfectly on version 2, but after upgrading to v4 the html report is created with the name index.html instead of the name I give it.
Ex: D:\Projects\MyProject\ExtentReports\index.html
Also there are two distinct html files created, index.html and dashboard.html, instead of a single report file.
How can this issue be solved? I need to give my report a specific name.
Thank you.

can you specify the exact version and the .net framework version you are using?

NET 4.7.2
ExtentReports 4.0.2 and 4.0.3 both have the same behavior.

@dod0o This is the expected behavior with the version4 HtmlReporter.  It creates upto 4 files depending upon the attributes that are created.  This is also true for all new version4 reporters, to maximize performance and obviously to keep each file focused on its specific tasks.
If you would like the old behavior, use the version3 port of HtmlReporter:
var v3html = new ExtentV3HtmlReporter();

^ With that being said and with version-4 reporters, instead of specifying the file name, you now need to specify the directory name with your timestamps and all files will be created likewise.

So, there's no way to change the file name of the report?

Hi @jaideep-dhumal  Where to use this line of code? When i put in [AfterTestRun] it doesnt works?

I have written this line of code after publishing result to Extent file.
Example:
extent.Flush();
if (!File.Exists(newNameFullPath))
{
File.Move(oldNameFullPath, newNameFullPath);
}
Hope this helps.

I have written this line of code after publishing result to Extent file.
Example:
extent.Flush();
if (!File.Exists(newNameFullPath))
{
File.Move(oldNameFullPath, newNameFullPath);
}
Hope this helps.


ci: retry rootfs download if it fails

Since Powershell 6+ invoke-Webrequest has a retry option. Use this option in case of failure together with the resume option.
Besides, the path to action.yaml was wrong.
UDENG-1813

end to end tests are failing because 24.04 != 23.10


fix(es/ts): preserve export =

Description:

BREAKING CHANGE:
TypeScript strip config changed.

Related issue (if exists):

#4758
#4898

Does this PR fixes those issues?

Oh sorry I was in mobile so I couldn't look details.
Why is this PR required?

Does this PR fixes those issues?

No, but it's related.
Only import foo = require is mentioned in #4898, but export = is similar.
We have talked about this in #4758.

I got it, thanks!

Oh sorry I was in mobile so I couldn't look details.
Why is this PR required?

I will open an issue to clarify it.


Temporarily fix wasmtime on aarch64 by not constructing per-inst address map.

The current build of wasmtime on aarch64 panics immediately because the
debug infrastructure constructs an address-to-instruction map
unconditionally now, and the new backend does not yet support debug info
generally (#1523). In this particular case, the address-map construction
consults the encoding info, which is not implemented by the new backend
and causes the panic.
This fix simply avoids generating per-instruction entries in the address
map; it at least gets us going until we plumb SourceLocs all the way
through the new pipeline.

r? @alexcrichton


Molecule custom Dockerfile

Issue Type
Trying to use Dockerfile.j2 to install some packages but doesn't do anything.

Bug report

Molecule and Ansible details
molecule 3.2.1 using python 3.7
    ansible:2.10.4
    delegated:3.2.1 from molecule
    docker:0.3.3 from molecule_docker

Molecule installation method (one of):

pip

Ansible installation method (one of):

pip

Detail any linters or test runners used:
Desired Behavior
Install the packages from Dockerfile.j2
Actual Behaviour
Packages not installed

Uhmm I'm not sure what is going on with plugins but it seems like you need to open this over here:

https://github.com/ansible-community/molecule-docker

Uhmm I'm not sure what is going on with plugins but it seems like you need to open this over here:

https://github.com/ansible-community/molecule-docker

Also, can you give more details @bcochofel? Where did you put your Dockerfile.j2 and what was in it? What was the output of the run and perhaps using --debug. We can't do much for you with the issue as it is.

Also, can you give more details @bcochofel? Where did you put your Dockerfile.j2 and what was in it? What was the output of the run and perhaps using --debug. We can't do much for you with the issue as it is.

So yes, as I know understand it hopefully correctly, you'll want to re-open this on https://github.com/ansible-community/molecule-docker. This functionality is now based in a plugin. Hope that is clear.

So yes, as I know understand it hopefully correctly, you'll want to re-open this on https://github.com/ansible-community/molecule-docker. This functionality is now based in a plugin. Hope that is clear.

Yes, thank you
On Thu, Jan 7, 2021, 21:36 decentral1se<EMAIL_ADDRESS>wrote:

So yes, as I know understand it hopefully correctly, you'll want to
re-open this on https://github.com/ansible-community/molecule-docker.
This functionality is now based in a plugin. Hope that is clear.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ansible-community/molecule/issues/3020#issuecomment-756400159,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACS4TO6FLGOZBUHKSIWQTP3SYYSNTANCNFSM4VREF64A
.

Yes, thank you
On Thu, Jan 7, 2021, 21:36 decentral1se<EMAIL_ADDRESS>wrote:

So yes, as I know understand it hopefully correctly, you'll want to
re-open this on https://github.com/ansible-community/molecule-docker.
This functionality is now based in a plugin. Hope that is clear.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ansible-community/molecule/issues/3020#issuecomment-756400159,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACS4TO6FLGOZBUHKSIWQTP3SYYSNTANCNFSM4VREF64A
.