PSR-4 compliant

Is there any plan to make this package a PSR-4 compliant?

see https://github.com/erusev/parsedown/pull/328

However, I do not see an argument for changing, this package provides exactly one class, that is not namespaced. It does not really matter if you choose PSR-4 or PSR-0 for loading it.

Ah didn't realize there's already a PR for that. My apology.


Return the removed value as part of the Result when calling remove

This patch addresses a TODO to return the removed value when calling remove. Now native returns the removed value in the Result

Thanks you @AlvinKuruvilla for you PR !!

Can you please update commit name by conventional commit formatting?
https://www.conventionalcommits.org/en/v1.0.0/

@AlvinKuruvilla Well done!! Your work has been merged 🙂!

:tada: This PR is included in version 0.6.0 :tada:
The release is available on:

0.6.0
GitHub release

Your semantic-release bot :package::rocket:


added workflow for closing old issues

Related Issue
Fixes #206
Description
This feature aims to automate the process of managing old issues, ensuring that the repository remains organized and focused on relevant tasks. By automatically closing old issues, it reduces manual overhead for repository maintainers and helps keep the issue tracker tidy and up-to-date.
Type of PR

[ ] Bug fix
[X] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Checklist:

[X] I have performed a self-review of my code
[X] I have read and followed the Contribution Guidelines.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[ ] I have commented my code, particularly in hard-to-understand areas.

@Saurav-Pant please review and merge this PR

@Saurav-Pant please add the 'gssoc' and level labels

@Saurav-Pant please change the 'level2' label to 'level1' label as per instructions which you might have recieved


[now-dev] not recognizing new files

I have a @now/next server running. When I add a new file (let's say foo.js) and try to import them, I got Can't resolve '../foo' in '/private/var/folders/pv/3ly_0lwn2px67vcsk72lt2x80000gq/T/co.zeit.now/dev/workPaths/bha8gsib/packages/website/pages'

Could you try with now@canary and let me know if that fixes things for you?

@TooTallNate I'd installed now@canary but not it doesn't even start my next app. This is my now.json:
{
  "version": 2,
  "name": "xxxxx",
  "alias": "xxxxx",
  "scope": "xxxxx",
  "builds": [
    { "src": "packages/api/src/index.js", "use": "@now/node" },
    { "src": "packages/website/package.json", "use": "@now/next" }
  ],
  "env": {
    "SHOPIFY_ENDPOINT": "@shopify_endpoint",
    "SHOPIFY_ACCESS_TOKEN": "@shopify_access_token",
    "WORDPRESS_ENDPOINT": "@wordpress_endpoint"
  },
  "routes": [
    {
      "src": "/api",
      "dest": "packages/api/src/index.js"
    },
    {
      "src": "/article/(?<slug>[^/]+)",
      "dest": "packages/website/article?slug=$slug"
    },
    {
      "src": "/(.*)",
      "dest": "packages/website/$1"
    }
  ]
}

It does start the app on http://localhost:5000 but it is not accessible at http://localhost:3000, only the api endpoint (http://localhost:3000/api).

Is there an error message printed or anything like that? What exactly do you mean by "it doesn't even start my next app"?

Sorry I miss expressed. It does start the nextJS app on port 5000 but it is not available on port 3000 (the now dev server).


Add support for RSASSA-PSS signatures.

This is described in RFC8230. Both OpenSSL and MbedTLS support is added.
The test suite includes some sign/verify self-tests, along with some
"known good" signatures, that are verified. As additional confirmation,
I've made sure the signatures produced by t_cose could be verified by
the pycose library, and vice-versa.
Fixes #43

Hi Paul, this look really good. Thank you!
It will take me some days to review it and merge it.
It could use an update to the readme, but I can do that if you want.
Thanks again!
LL

Hi Laurence,
I've tried to build with tdv and fixed the various warnings. I've also had to fix some warnings that were present even before my changes.
I was also able to add the RSA defines to tdv's b.sh without any trouble. Once this PR is merged I can make a very simple PR to tdv to add that. It does make the test time grow exponentially of course.
I'll have a stab at updating the README later today.
On an unrelated note, do you know what nm's -U flag is for on your machine? I'm getting errors when running tdv/sizes.sh, as -U seems to expect an extra argument: https://sourceware.org/binutils/docs/binutils/nm.html

What compiler and OS are you working on? We want to work for all -- I'm just curious.  I work on MacOS with both gcc and llvm/clang.
   -U     Don't display undefined symbols.

The nm size calc is a bit temperamental.
I'm still seeing a fair number of warnings. A sample of some of the main ones is below.
make: *** [src/t_cose_sign1_sign.o] Error 1
Makefile.ossl
crypto_adapters/t_cose_openssl_crypto.c:411:23: warning: cast from 'const struct evp_md_st *' to 'void *' drops const qualifier [-Wcast-qual]
ossl_result = EVP_PKEY_CTX_set_signature_md(context, md);
^
/usr/local/include/openssl/evp.h:1284:70: note: expanded from macro 'EVP_PKEY_CTX_set_signature_md'
EVP_PKEY_CTRL_MD, 0, (void *)(md))
^
crypto_adapters/t_cose_openssl_crypto.c:417:23: warning: cast from 'const struct evp_md_st *' to 'void *' drops const qualifier [-Wcast-qual]
ossl_result = EVP_PKEY_CTX_set_rsa_mgf1_md(context, md);
^
/usr/local/include/openssl/rsa.h:135:65: note: expanded from macro 'EVP_PKEY_CTX_set_rsa_mgf1_md'
EVP_PKEY_CTRL_RSA_MGF1_MD, 0, (void *)(md))
^
2 warnings generated.
test/t_cose_sign_verify_test.c:401:29: warning: implicit conversion changes signedness: 'int' to 'enum t_cose_err_t' [-Wsign-conversion]
return_value = 2000 + (int32_t)return_value;
~ ~^~~~~~~~~~~~~~~~~~~
test/t_cose_sign_verify_test.c:409:29: warning: implicit conversion changes signedness: 'int' to 'enum t_cose_err_t' [-Wsign-conversion]
return_value = 3000 + (int32_t)return_value;
~ ~^~~~~~~~~~~~~~~~~~~
test/t_cose_sign_verify_test.c:415:29: warning: implicit conversion changes signedness: 'int' to 'enum t_cose_err_t' [-Wsign-conversion]
return_value = 4000 + (int32_t)cbor_error;
~ ~^~~~~~~~~~~~~~~~~

FYI, I made a fix to tdv so that these errors will get caught. GCC gets them, bug llvm/clang doesn't.

So far I'd been using GCC only. I've run it under Clang and got the same warnings as you now. I've fixed the ones in t_cose_sign_verify_test.c, but the OpenSSL ones seem tricky.
EVP_PKEY_CTX_set_signature_md is a macro around EVP_PKEY_CTX_ctrl, and the latter takes in a void* argument as a universal pointer. The "invalid cast" is part of the macro definition and out of our control.

Check out the implementation of UsefulBufC_Unconst() in qcbor. I'm not sure this is the only solution, but it might work.

Latest commit should address the final OpenSSL warning, by using a pragma.

FYI, I can compile and run everything without error now.
In the process it made me realize the dependency on the latest QCBOR for OpenBytes. Because it requires the very latest because of the QCBOR bug fix I'm worried this will catch some people out. Not sure what to do about this yet.
(and I am really glad you thought to use it here. It hadn't occurred to me).

Also, you may which to add a copy right for yourself or your organization for all the files you changed.

I pushed the submit review button too soon. Here's one more request.
I made a release of QCBOR -- v1.1.  It has a define for "QCBOR_1_1". I'd like t_cose to have an #ifndef QCBOR_1_1 that gives a warning that says QCBOR v1.1 is necessary for this version of t_cose.
This is because OpenBytes is very new and it is unlikely that the user of t_cose will have the latest QCBOR. I don't want them to get a confusing compiler error. I want to keep the main t_cose branch very clean and commercial quality.  Note also, you can't turn off RSA to avoid the compiler error because ECDSA depends on OpenBytes too.
Also, at this point I've done a thorough review of the whole PR. Thank you for the super high quality work!
I think this should probably become t_cose 1.1. The question is whether the Edwards stuff should be included. Are you planning to do the other half of it?

I've added the QCBOR_1_1 ifdef. I've made it a #error rather than a warning, because it seems #warning is non standard and gives me a (second) warning when compiling in pedantic mode.
I'll finish the EDDSA work soon, hopefully in the next couple of days.

Btw let me know if you'd like me to squash all the commits as one.


Update case-study-the-pursuit-of-more-personal-computing.md - Adjusted padding around About the author tile and text

Adjusted padding around About the author tile and text

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/case-study-the-pursuit-of-more-personal-computing.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


added footer, updated links and content

Closes #104

I just added some front-end facelift details. Every few days I notice something else and want to correct it.


feat: add flutter

required for renovatebot/renovate#6049
closes #200
blocked by https://github.com/renovatebot/renovate/issues/12820

Hey what is up with this PR? I created https://github.com/renovatebot/renovate/pull/11132 which depends on this in theory.

What's missing for this pull request?

Deconflicting and time 😉

I resolved the conflicts and fixed linting errors in a fork of mine: https://github.com/BjoernPetersen/buildpack/tree/feat/flutter
Seems like I'd need to either heavily adjust the CI config or create a competing PR here to test the build/lang job. Would you be open to pulling the changes from my fork into this PR?

Feel free to open a pr and target my branch

Hi, any update on this?

Now that this is merged, can I use it for https://github.com/renovatebot/renovate/pull/11132 ? The PR has been locked though, so should I create a new one?

nope:

https://github.com/renovatebot/docker-sidecar/pull/15

yes, please reopen /reuse the existing pr. I also added a comment the the parent issue


[FEATURE] Is there a way to download the dataset and run it locally?

Description
I am using the NIH Chest X-ray Dataset dataset, is there any way to download the dataset for local use?
Use Cases
No response

Description
I am using the NIH Chest X-ray Dataset dataset, is there any way to download the dataset for local use?
Use Cases
No response

Hi @BLQNXAY can please check if the API below is the one that you are looking for https://docs.deeplake.ai/en/latest/deeplake.html#deeplake.deepcopy

I'm very sorry for the delay in replying. The API documentation you provided can achieve my goal. Thank you very much for your help. @activesoull


Update code examples - resolveHtml is no longer valid

According to @mvhoute:
https://gitter.im/Kentico/Kontent?at=5e4d50a389f30b12651899fa
resolveHtml is no longer valid.
It can be found at:
https://docs.kontent.ai/tutorials/develop-apps/get-content/dealing-with-structure-in-rich-text?tech=javascript#a-resolving-tweets-within-rich-text

Please verify if it's really the case and update all occurrences of rich text resolution according to the new best practice.

Hey,
The resolveHtml method is valid and is one of 2 options you can use to resolve HTML in rich text elements (see https://github.com/Kentico/kontent-delivery-sdk-js/blob/master/lib/elements/elements.ts#L213)
The other option is to call resolveData which gives you additional, contextual information.
From the gitter it seems the question relates to the gatsby plugin which creates its own resolvedData property for rich text elements. From looking at the code, it seems the property should be there - https://github.com/Kentico/gatsby-source-kontent/blob/master/src/decorators/richTextElementDecorator.js#L54
I would suggest updating to latest version of Gatsby plugin.


Add  search functionality in the leaderboard

Search box will help to find a particular student easily among the student on GFG platform .
Directly raise PR if your interested to solve this issue .
Once done attach a Screen Shot and Video Recording for the same . You can upload the video on google drive and attach link for the same in the comment once done .

Working on this issue!


Redis expire returns a signed long, not uint

From my understanding redis uses msec_t which is a long when returning the value of GetExpire here
https://github.com/antirez/redis/blob/unstable/src/module.c#L1636
the problem is that since this library uses an uint64 it's impossible to do key.GetExpire() == rm.NO_EXPIRE because the first is a uint64 and the second a signed int (in this case also negative) and we have to either do int64(keyTTL) != rm.NO_EXPIRE or keyTTL == ^uint64(0)
Wouldn't be better to have GetExpire return a signed int so we can just compare them directly?

pr is welcome, otherwise I will look into this later, maybe this weekend.


Make EtcdConsistentStore::NextAvailableSequenceNumber() use /serving_sth

When there are no entries in /sequenced_entries then our next available sequence number is the one after the numbers covered by /serving_sth.

Done with the review, just that one minor comment. :wink:

LGTM


Blink when I change number of led in live

We can change the number of LEDs directly (in live) with http://192.168.0.xxx/pixelconf?ct=NBLED cool.
But to do this gently, for example 10 to 144, I put some intermediates,
But each command turns off/on LEDs, so it's not really absolutely smooth :-)
Maybe one custom animation, in STATIC, but how define the number of leds On?
Thanks for your goods ideas ;-)

Hi @pbenaim,
I'm not sure what's the idea behind changing the number of LEDs in that way, but I don't think the WS2812FX library that does the animation job for McLighting in the background wasn't built to be used that way.
Maybe you want to have a look at the Range commands in the MQTT and Websocket protocol: https://github.com/toblum/McLighting/wiki/WebSocket-API#payload-numledhexrgbnumledhexrgbnumledhexrgb-
Best regards
Tobias

Work very well 👍
And with beta I can play with more than 99 🥇


fix(readme): update doc (starter kit) link

Please read and mark the following check list before creating a pull request (check one with "x"):

[x] I read and followed the CONTRIBUTING.md guide.
[x] I read and followed the New Feature Checklist guide.

Short description of what this resolves:
Wrong URL Starter Kit documentation

Hey @crissty, good catch, thanks!


When to release your dataset?

Hi, sorry to bother you. I'm very inspired by your work. I want to know when will you release your dataset?

We just uploaded code and dataset


Fix entering command mode when searching

I found the issue that entering command mode when searching.
I fixed it.
and I changed the way of writing ":noh" and ":hlsearch".
My commit is dirty, sorry... could you please look the final changes when checking.

Hi @SeitaHigashi! Thanks for the contribution! Can you describe some steps on how to reproduce the issue? I tried many things and it didn't enter the command mode

Thank you for response, @asiryk!
I didn't explain myself well enough. When searching, this plugins is entering command mode for a moment, then back to normal mode.
I'm using notice.vim, I can see the command prompt for a moment.
e.g.,

:AutoHlsearch{lhs}

":" is entering command mode
"CR" is back to normal mode
so, entering command mode for a moment.

In top page video, we can see the command in the bottom for a moment.

@SeitaHigashi, Oh, ok I see. That makes much sense to me, I'll merge your pr.
I initially refused to use vim.o.hlsearch because it seemed to me like it caused flickering sometimes, also somebody noticed that as well. But I'm not quite sure this is because of this setting.

I fixed it. thanks in advance.

Thanks for the contribution again <3


Create an Analytics component in Shaka for an integration with BigQuery

We are planning an integration with Google Cloud Services and BigQuery to allow Shaka users to easily collect and understand the data related to how their media is being watched and interacted with.
(See the prototype presentation here).
This is a tracker for the Shaka Analytics component. Design and concept paper docs are to follow.

I think it would be very nice to have a generic Analytics module, and that there is a specific module for integrating with BigQuery, but that applications can also add modules for integration with other services. What do you think?

Yeah, our design is in sync with that. The Shaka component is gonna listen to analytics-related events and send them to the endpoint, provided by the app.
As part of the BQ integration, we'll provide the code for the BQ-connected endpoint, but anyone's welcome to write their own backend for other services.

Is anyone interested in this? If not, the issue will be closed in 7 days.


Mobile touch drawing not aligned correctly

Touch controls on mobile are not aligned with the image

This is a device or operating system specific issue, at least on my Galaxy S6 Edge (Android 7.0). Issue does not happen on iOS. Closing this as a non-issue.

Fixed!


Vert.x stack futurisation

This issue keeps track of the futurisation of the Vert.x stack, it's an umbrella issue

[x] vertx-core
[x] vertx-redis-client
[ ] vertx-auth
[ ] vertx-web
[x] vertx-bridge-common
[x] vertx-mqtt
[x] vertx-kakfa-client
[x] vertx-cassandra-client
...

in which moment of futurisation plan will the Future interface extend CompletionStage?

Hi,
I think that's something we can think about.
At the moment I would rather keep Vert.x Future as is and add a toCompletionStage method on it rather than extending it.
Julien

On 5 Aug 2019, at 17:48, Cristiano Gavião<EMAIL_ADDRESS>wrote:
in which moment of futurisation plan will the Future interface extend CompletionStage?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/vert-x3/issues/issues/472?email_source=notifications&email_token=AABXDCQIL7BGTU2JWEYGU73QDBDUZA5CNFSM4H26DLE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3SHTTY#issuecomment-518289871, or mute the thread https://github.com/notifications/unsubscribe-auth/AABXDCQSKB5ALG5EOAZ3FX3QDBDUZANCNFSM4H26DLEQ.

@vietj how about adding the toCompletionStage method in milestone4 ?

I would like actually to come up with several proposals for Future


Rename, edit and link notebooks

This PR updates all tutorial notebooks that are currently in the tutorials folder of the main branch. Two notebooks (census and proximity) have not been merged yet and therefore are not included in this PR. I will update this PR to include those two notebooks once they have been merged.
All notebooks now follow a consistent file naming pattern. This includes numbering all notebooks in the following order:

Reprojecting and Resampling
Coregistration
Mosaicking
Geospatial Classification
Local Tools
Focal Statistics
Surface Tools
Proximity Tools [not yet included in this PR]
Zonal Statistics
Census Data [not yet included in this PR]
Landcover Classification

The basic thoughts behind this order:

Notebooks 1 to 4 cover basic operations that are used in many of the subsequent notebooks
Notebooks 5 to 9 cover operations that generally follow the categories of the Map Algebra Functions (Local Operations, Focal Operations, Global Operations, and Zonal Operations).
The census data notebook (10) is similar to zonal statistics, as much of what happens there is defining and plotting zones and therefore fits in well right behind the Zonal Statistics notebook.
The Landcover Classification notebook goes beyond the other notebooks since it introduces PyTorch.

Other than renaming and ordering notebooks, this PR includes the following updates:

Add a "Click on this link to go to the next notebook" link at the bottom of each notebook.
Check and update external and internal links
Edit for stylistic consistency, orthography, and interpunctuation (based on the Microsoft Writing Style Guide).

Since the Landcover Classification was note created by makepath, this PR only changes the filename but leaves the file unchanged otherwise.

Thanks. I believe the README links to these notebooks. Can you make sure those links are updated?

And FYI, proximity has been merged now.

@Tom Thanks for your feedback! My recent commits add the proximity notebook and also update the links in README.md.

Thanks @TomAugspurger
I'm noticing some error when searching for STAC items using pystac_client. Are there any changes with the API or with the set up on Planetary Computer?
bounds = [-57.151965, -2.530125, -55.710724, -1.179033]

catalog = pystac_client.Client.open(
    "https://planetarycomputer-staging.microsoft.com/api/stac/v1"
)
jrc = catalog.search(collections=["jrc-gsw"], bbox=bounds)

items = list(jrc.get_items())
print(f"Returned {len(items)} Items")

---------------------------------------------------------------------------
NotImplementedError                       Traceback (most recent call last)
/tmp/ipykernel_359/2968004645.py in <module>
      4     "https://planetarycomputer-staging.microsoft.com/api/stac/v1"
      5 )
----> 6 jrc = catalog.search(collections=["jrc-gsw"], bbox=bounds)
      7
      8 items = list(jrc.get_items())

/srv/conda/envs/notebook/lib/python3.8/site-packages/pystac_client/client.py in search(self, **kwargs)
    166                 'No link with "rel" type of "search" could be found in this catalog')
    167
--> 168         return ItemSearch(search_link.target, stac_io=self._stac_io, client=self, **kwargs)

/srv/conda/envs/notebook/lib/python3.8/site-packages/pystac_client/item_search.py in __init__(self, url, limit, bbox, datetime, intersects, ids, collections, query, sortby, fields, max_items, method, stac_io, client)
    171         else:
    172             self._stac_io = StacApiIO()
--> 173         self._stac_io.assert_conforms_to(ConformanceClasses.ITEM_SEARCH)
    174
    175         self._max_items = max_items

/srv/conda/envs/notebook/lib/python3.8/site-packages/pystac_client/stac_api_io.py in assert_conforms_to(self, conformance_class)
    212         """
    213         if not self.conforms_to(conformance_class):
--> 214             raise NotImplementedError(f"{conformance_class} not supported")
    215         else:
    216             return True

NotImplementedError: ConformanceClasses.ITEM_SEARCH not supported

The staging deployment is going through some changes. Does using https://planetarycomputer-staging.microsoft.com/api/stac/v1 work for you?

Thanks for the insights. The stagging doesn't work. "https://planetarycomputer.microsoft.com/api/stac/v1 works though.

@Tom this PR should now be up to date with main. It now also includes the census notebook which I renamed to fit the pattern of the other notebooks. I also added a link to the next notebook at the end, as we have for all the other notebooks. I think this PR is now ready to merge!


Enhanced The UI of the contributions page

I have enhanced the UI in such a way :

Fixed the dark mode colors correctly now it is changing its color according to the dark mode
Added Number of contributions did by each user
Converted cards to rectangle to show all details
Justified all content properly at center

Fixes #484
Type of change
Please mark with an X the type that applies:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactor code
[ ] Documentation update
[ ] Other (mentioned in the issue number)

How Has This Been Tested?
Tested by repeatedly refreshing the page and changes
Test A: Describe here
Test B: Describe here (if required)
Screenshots and Videos

Checklist
Please mark with an X the items that apply:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

@hustlerZzZ Please review and if any changes please let me know .
If you like that then please assign lvl2 if found it suitable for that


How to change settings ?

I have raspberry pi 3, Flir Lepton 3.0  and Lepton thermal camera Breakout board v1.4.
Before capture thermal images, I need to enable Radiometry Mode, need to enable FFC as automatic, need to enable Telemetry Mode as header using Python.
Can anybody help me to do this?

pylepton doesn't support sending CCI commands at this time.
You could use ctypes to integrate functions from the SDK. A user on the FLIR Lepton group has done it this way: https://groups.google.com/forum/#!topic/flir-lepton/i8rq6g7wZuQ


Improve line and branch coverage for Http policy related files.

Our line coverage bar for the repo is is 90% and branch coverage is 70%.
Though HTTP pipeline and policies are challenging to add unit tests for (and in some cases require live tests that run nightly to improve coverage), these files are significantly below our current bar:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2104943&view=codecoverage-tab

For example, the az_http_pipeline_policy_credential() function isn't covered by any test.
https://github.com/Azure/azure-sdk-for-c/blob/c3bfd1430d7e329b3d839e60a6dd8f2892901b59/sdk/src/azure/core/az_http_policy.c#L97-L113
This becomes necessary to support services that use the HTTP protocol such as storage, which we currently have as part of a feature branch.
https://github.com/Azure/azure-sdk-for-c/blob/5c6fa6eef60f39aa2e251d79c26892c6f0131bec/sdk/src/azure/storage/az_storage_blobs_blob_client.c#L147-L157
Brought up in https://github.com/Azure/azure-sdk-for-c/pull/2443#discussion_r1070191198
cc @antkmsft

Hidden by https://github.com/MicrosoftPremier/VstsExtensions/issues/219
Blocked https://github.com/Azure/azure-sdk-for-c/pull/2591 : we're working around by temporarily lowering the thresholds in feature/v2 until each file is at required levels.


Current people on space

If we can know the curee t people who are in space using API. If it is oky as oer your project will like to work on it.

This may be a feature in another section of the website, not relevant at the moment.


Question: does this work  without involving Sessions?

In a REST-API only configuration ?

In v2, yes with some changes. I recommend using v3 (beta) if you're just starting. You can read about tenant identification, including using request data, for v3 here: https://www.notion.so/Tenant-identification-dbfb4aec83224de9aa8c06dc6fe4dc56

great, I'll dive in.
Another question:
Is it possible to have nested tenants?
I mean something like:
Landlord->Tenant1->SubTenant1
->SubTenant2
->Tenant2->SubTenant1
->SubTenant2

With some work on your part, yes. Why do you need that?

the

With some work on your part, yes. Why do you need that?
On a project there is this idea:
If a multinational company has a main office worldwide, then, for each country has a Tenant, for each county in that country a SubTenant

You can use single-db tenancy inside multi-db tenancy pretty easily

@stancl I am exploring this sub tenant idea. You say it could be done pretty easily. Do you have a minute to explain how you think it could resolve and bootstrap those subtenants in the single-db? I guess I can't wrap my head around how you'd structure the tenant resolution


Trying To Run "PHP ARTISAN SERVE" returns No Such File or Directory on line 17

Hi,
This is the error line returned on my terminal:
PHP Warning:  require(C:\Users\Xampoo\wwwroot\canvas\bootstrap/../vendor/autoload.php): failed to open stream: No such file or directory in C:\Users\Xampoo\wwwroot\canvas\bootstrap\autoload.php on line 17
PHP Fatal error:  require(): Failed opening required 'C:\Users\Xampoo\wwwroot\canvas\bootstrap/../vendor/autoload.php' (include_path='.;C:\php\pear') in C:\Users\Xampoo\wwwroot\canvas\bootstrap\autoload.php on line 17

Running Win10, 64. But the same happens on Linux too.

Did you run composer install? Seems like the Laravel Framework was not downloaded.

You are completly right.  Is it possible upgrade to LL5.5?

@Bitart Currently we're in the process of upgrading the app to Laravel 5.4. So 5.5 is still a little ways out.

Thank you!

run composer install command in the root directory of your project in cmd

@qamarabbas408 Is this a question related to #353?

yep
On Thu, Feb 13, 2020 at 1:15 AM Todd Austin<EMAIL_ADDRESS>wrote:

@qamarabbas408 https://github.com/qamarabbas408 Is this a question
related to #353 https://github.com/cnvs/canvas/issues/353?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cnvs/canvas/issues/353?email_source=notifications&email_token=AHV4WM2SZPJDW46IUYEAYITRCRKHZA5CNFSM4DZC3TEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELSHIJI#issuecomment-585397285,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHV4WM5AJTM33Q2IZDJV5TDRCRKHZANCNFSM4DZC3TEA
.

Just verifying, you're not using php artisan serve on the cnvs/canvas repo, correct?
This repo is a package that's pulled into a Laravel app, and a lot has changed since this issue was opened in 2017, like it not being a standalone app anymore.


Excessive stack depth comparing types 'Plugin_2' and 'Plugin_2'

Bug Report
🔎 Search Terms

Excessive stack depth comparing types

🕗 Version & Regression Information
Occurs on all Typescript versions
Node: v16.15.0
🙁 Actual behavior
Hello, I am trying to build a universal library for renderless components and composables as a plugin for Vue2 and Vue3 with the use of vue-demi. When I try to use the plugin in my Vue3 application locally via yarn link I get the following error: Excessive stack depth comparing types 'Plugin_2' and 'Plugin_2'. I am not sure if this is related to vue-demi or to typescript. The same issue is also posted here: https://github.com/vueuse/vue-demi/issues/160
I already tried some solutions from other similar issues, for example changing the VSCode Typescript version to the workspace version with several versions with no luck.
This is the repository of the Plugin: https://github.com/whitelabel-market/wallet-connector-vue
The plugin is created like this:
import {
  ConnectModal,
  ConnectContent,
  ConnectTitle,
  ConnectButton,
} from "./components/modal";
import { WALLET_CONTEXT, createWallet } from "./hooks";
import type { App, Plugin } from "vue-demi";

export function WalletConnectorVue(options: any): Plugin {
  return {
    install(app: App) {
      app.component("ConnectModal", ConnectModal);
      app.component("ConnectContent", ConnectContent);
      app.component("ConnectTitle", ConnectTitle);
      app.component("ConnectButton", ConnectButton);
      app.provide(WALLET_CONTEXT, createWallet(options));
    },
  };
}

You can reproduce this when you use the library as follows in a Vue3 project with typescript:
import { createApp } from "vue";
import App from "./App.vue";
import router from "./router";
import { INFURA_ID } from "./utils/constants";
import { WalletConnectorVue } from "@whitelabel-solutions/wallet-connector-vue/dist";

const app = createApp(App);

app.use(
  WalletConnectorVue({
    appName: "App Name",
    infuraId: INFURA_ID,
    chainId: 1,
    authereum: { key: "" }, // Yet required (but unused) in ConnectorUserOptions type
    fortmatic: { key: "" }, // Yet required (but unused) in ConnectorUserOptions type
  })
);

app.use(router);
app.mount("#app");

Notice that I am using the local build from the /dist folder! The /dist folder can be built with pnpm build

The VSCode intellisense also shows me this error directly:

One thing I noticed is, that when I use this not as a plugin and just import the components directly, it works. The following example also works:
const app = createApp({
  setup() {
    provide(
      WALLET_CONTEXT,
      createWallet({
        appName: "App Name",
        infuraId: INFURA_ID,
        chainId: 1,
        authereum: { key: "" }, // Yet required (but unused) in ConnectorUserOptions type
        fortmatic: { key: "" }, // Yet required (but unused) in ConnectorUserOptions type
      })
    );
  },
  render: () => h(App),
});

Only when using this as a plugin as described above, it doesn't work. I really need help here, because I have absolutely no idea how to fix this.
🙂 Expected behavior
No error

I just tested this with the built version from npm (https://www.npmjs.com/package/@whitelabel-solutions/wallet-connector-vue) and this is working.
So I assume this has something to do with the local development but I am not sure why, because the /dist folder is the same as what is published on npm.

Hello, can anyone please help? The problem still exists.


[improvement] add search functionality to all prof view and gpa view

Instead of getting the user to ctr+f, add a search bar to those places

Fixed with latest branch


feat: make MM in-app mobile detection happy again (again) (again)

Description

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

High Risk PRs Require 2 approvals

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

Engineering

Operations

Screenshots (if applicable)

#6531  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gomesalexandre and the rest of your teammates on  Graphite


php:5.6-apache not serving files anymore

Hello,
thanks for your work in this project! With your last release the behavior of the image changed, which is why it is currently not usable, but I think we can fix this :-) With the latest image, the container does not serve the PHP files, but starts in an interactive mode on the console:
web_1    | Interactive shell
web_1    |
web_1    | php > Interactive shell
web_1    |
web_1    | php > Interactive shell
web_1    |
web_1    | php > ⏎

This repeats until the container dies.
I start the container and mount the files to /var/www/html
volumes:
  - ./html:/var/www/html

Thanks for your help!

Hi @n2o ! Sorry for the inconvenience.
I just tried and docker run --rm -it chialab/php:5.6-apache currently works for me, as it starts an Apache server with apache2 -D FOREGROUND.
However, yesterday I pushed a refactor that caused all images to be built upon php:latest, which has PHP 8.0.11 and no Apache server by default. We solved it in #88 and should have been fixed by yesterday at around 5pm UTC… can you check again if the problem still persist? Remember to docker pull chialab/php:5.6-apache first to ensure you use the latest built image…


Problem with routes params ended with space(s)

Slim v 3.6
Have this kind of route:
$this->map(['GET', 'OPTIONS'], '/users/{login}/', '\DD\Controllers\UsersController:showProfile');

If i'll try to access like '~/users/<login> [only space(s) here]     /' request is hanging for several seconds (5-15) and then return empty result. =\

This one is related to FastRoute.... Closing.


SSL profile: add advanced settings

Is your feature request related to a problem? Please describe.
When creating a TLS profile in AS3 declaration, some advanced settings are not available, such as 0-RTT and Dynamic Record sizing.
Describe the solution you'd like
Add advanced SSL parameters in TLS object class (ie TLS_server / TLS_client):

0-RTT: https://support.f5.com/csp/article/K54135010
'Allow Dynamic Record sizing': https://techdocs.f5.com/en-us/bigip-15-1-0/big-ip-system-ssl-administration/additional-ssl-profile-configuration-options.html#GUID-F80A18B3-1C88-465F-946B-9942D95399AE

Describe alternatives you've considered
None.
Additional context
N/A

Hi,
same for the renegotiation part:
renegotiate-max-record-delay
renegotiate-period
renegotiate-size
secure-renegotiation
The only one that is taken in account is renegotiationEnabled.
The request is coming for ISP Orange.

Created Jira AUTOTOOL-3488 and prioritized

This has been resolved in the 3.41.0 release of AS3.


extract TPrint from upickle-pprint

see https://github.com/lihaoyi/upickle-pprint/issues/209#issuecomment-301025851 for more details

see https://github.com/lihaoyi/TPrint/pull/2


make metrics-exporter queries parallel

All metrics related to system.parts on HDD + Raid0 + ClickHouse 19.16 take long time when we have many system.parts
SELECT COUNT(*)
FROM system.parts
┌─COUNT()─┐
│   28022 │
└─────────┘

1 rows in set. Elapsed: 3.406 sec.

Actually, it should also be improved on ClickHouse side: https://github.com/ClickHouse/ClickHouse/issues/19570

Actually, it should also be improved on ClickHouse side: https://github.com/ClickHouse/ClickHouse/issues/19570

Why not both?

Why not both?

@Enmk cause most of queries on current metrics exporter use UNION ALL ... and make in parallel on clickhouse side
but queries related to system.parts make a lot of "fstat syscall" for calculate all system.parts columns  instead of only requests,
so, system.parts related queries is the slowest part of generating /metrics endpoint

@Enmk cause most of queries on current metrics exporter use UNION ALL ... and make in parallel on clickhouse side
but queries related to system.parts make a lot of "fstat syscall" for calculate all system.parts columns  instead of only requests,
so, system.parts related queries is the slowest part of generating /metrics endpoint


PARQUET-1820: [C++] pre-buffer specified columns of row group

This hooks up Antoine's read coalescing implementation to the Parquet reader; it takes into account row groups and column indices, so it should be good for both scans of the entire file and selecting a few columns out of many. It also exposes some options on the Parquet ReaderProperties to control this. (Is exposing Arrow types like that ok, or should I wrap things?)
I'll have benchmarks later. It seems a clear win locally and against remote S3, but from EC2->S3 when I initially tried it was worse. I believe it's because the "naive" read happened to be near optimal on the particular dataset tested.
Marking this WIP as I'd like to get feedback on the approach.
I believe this subsumes PARQUET-1698/#6138. This is not exposed yet to Python or Datasets.

It seems we may have a return of the gRPC MacOS TLS issues :cry:
Note that MiB/s numbers are not comparable in the benchmarks since it's using the file size, not the actual data size. (They are only comparable between the Naive and Coalesced variants of the same benchmark in a relative sense.) Benchmarks are divided into 'All' and 'Pick' variants; 'All' scans the entire file, while 'Pick' selects a subset of columns.
 Otherwise it will not make good use of the range cache.
(perhaps you should add benchmarks for ReadTable as well?)

Nice... but you'll also need to refactor parquet::arrow::FileReader::ReadRowGroups so that it doesn't read per-column anymore. Otherwise it will not make good use of the range cache.
(perhaps you should add benchmarks for ReadTable as well?)

Ah, to make sure I understand...while buffering and reading are both parallelized, buffering of the file still likely proceeds roughly sequentially through the file, so you'd also want to read sequentially by both row groups and columns (whereas right now it is sequential only in columns)?
I believe we only schedule reading once the corresponding column chunk is fetched, which is quite a bit more complicated, but avoids this entirely.

No, what I mean is that FileReader::ReadRowGroups seems to create a separate row group reader per column, so it won't actually coalesce column reads.
(I might be mistaken, because it's quite convoluted and I struggle to follow it)

Ah - as implemented, that's actually OK.
You are right, the logic is fairly convoluted, but it boils down to calls to GetColumnPageReader which in turn returns a pre-buffered column chunk. So even though there are lots of redundant calls above this, the coalesced chunk gets used. (For instance, I had originally initialized the cache at a different layer, and noticed it was 100x slower; it turns out that the cache was getting recreated for each column chunk!)
https://github.com/apache/arrow/pull/6744/files#diff-2d20597229806f20349e26d7c1841d2fR134

Still, it may be nice to add a benchmark through ReadTable?

Yes - I'll add a benchmark for that method as well.

You are right, ReadTable is much faster. The benefits of coalescing are also less pronounced.
 Also, why so many benchmark variations?

There's a lot of variants since it's 2 datasets x 2 file sizes x 2 read methods (GetRecordBatchReader/ReadTable) x naive/coalesced x whole table scan/column selection scan. Maybe I can consolidate to just use one dataset?
A and B variants select a different subset of columns; A selects some contiguous columns and a random column that is not contiguous; B selects a large block of contiguous columns.

I'm not sure the 2 file sizes are useful. One dataset sounds good.

I consolidated the benchmarks as suggested. New results (slightly edited to make the table less wide)
-------------------------------------------------------------------------------------------------------------------------
Benchmark                                                                     Time           CPU Iterations
-------------------------------------------------------------------------------------------------------------------------
ReadAll1Mib/real_time                                                  47837389 ns    4154307 ns        432   20.9042MB/s    20.9042 items/s
ReadAll100Mib/real_time                                               332134343 ns  281574544 ns         68   301.083MB/s    3.01083 items/s
ReadAll500Mib/real_time<PHONE_NUMBER> ns<PHONE_NUMBER> ns         16   351.666MB/s   0.703332 items/s
ReadChunked100Mib/real_time                                           707542014 ns  205847141 ns         30   141.334MB/s    1.41334 items/s
ReadChunked500Mib/real_time<PHONE_NUMBER> ns<PHONE_NUMBER> ns          6   145.096MB/s   0.290192 items/s
ReadCoalesced100Mib/real_time                                         290279656 ns   21532593 ns         78   344.495MB/s    3.44495 items/s
ReadCoalesced500Mib/real_time<PHONE_NUMBER> ns   92265675 ns         19   465.603MB/s   0.931206 items/s
ReadParquet_c402_r250K_GetRecordBatchReaderAllNaive/real_time<PHONE_NUMBER>3 ns<PHONE_NUMBER> ns          1   57.0771MB/s  0.0653716 items/s
ReadParquet_c402_r250K_GetRecordBatchReaderAllCoalesced/real_time<PHONE_NUMBER> ns<PHONE_NUMBER> ns          4   163.341MB/s   0.187078 items/s
ReadParquet_c402_r250K_ReadTableAllNaive/real_time<PHONE_NUMBER> ns  170837981 ns          6   267.832MB/s   0.306753 items/s
ReadParquet_c402_r250K_ReadTableAllCoalesced/real_time<PHONE_NUMBER> ns  331081110 ns          7   301.283MB/s   0.345066 items/s
ReadParquet_c402_r250K_A_GetRecordBatchReaderPickNaive/real_time      306004203 ns  121640076 ns         67   2.78641GB/s    3.26793 items/s
ReadParquet_c402_r250K_A_GetRecordBatchReaderPickCoalesced/real_time  182058306 ns   88337047 ns        116   4.68341GB/s    5.49275 items/s
ReadParquet_c402_r250K_A_ReadTablePickNaive/real_time                 138946292 ns   22178893 ns        152   6.13657GB/s    7.19703 items/s
ReadParquet_c402_r250K_A_ReadTablePickCoalesced/real_time             146829280 ns   23934889 ns        143   5.80711GB/s    6.81063 items/s
ReadParquet_c402_r250K_B_GetRecordBatchReaderPickNaive/real_time<PHONE_NUMBER> ns  598575984 ns         13   542.682MB/s   0.621546 items/s
ReadParquet_c402_r250K_B_GetRecordBatchReaderPickCoalesced/real_time  576703601 ns  358843513 ns         35    1.4785GB/s    1.73399 items/s
ReadParquet_c402_r250K_B_ReadTablePickNaive/real_time                 404123906 ns   32751624 ns         52   2.10988GB/s    2.47449 items/s
ReadParquet_c402_r250K_B_ReadTablePickCoalesced/real_time             360928803 ns   48464849 ns         57   2.36239GB/s    2.77063 items/s

-------------------------------------------------------------------------------------------------------------------------
Benchmark                                                                     Time           CPU Iterations
-------------------------------------------------------------------------------------------------------------------------
ReadAll1Mib/real_time                                                   4011530 ns    2294831 ns       5276   249.281MB/s    249.281 items/s
ReadAll100Mib/real_time                                               221357532 ns  215162891 ns         97   451.758MB/s    4.51758 items/s
ReadAll500Mib/real_time                                               989960126 ns  969320630 ns         21   505.071MB/s    1.01014 items/s
ReadChunked100Mib/real_time                                           193956992 ns  151945848 ns        107   515.578MB/s    5.15578 items/s
ReadChunked500Mib/real_time                                           943875254 ns  757594068 ns         21   529.731MB/s    1.05946 items/s
ReadCoalesced100Mib/real_time                                         181865371 ns   19172161 ns        113   549.857MB/s    5.49857 items/s
ReadCoalesced500Mib/real_time                                         776506125 ns   92814525 ns         27    643.91MB/s    1.28782 items/s
ReadParquet_c402_r250K_GetRecordBatchReaderAllNaive/real_time<PHONE_NUMBER> ns<PHONE_NUMBER> ns          4   151.203MB/s   0.173176 items/s
ReadParquet_c402_r250K_GetRecordBatchReaderAllCoalesced/real_time<PHONE_NUMBER> ns<PHONE_NUMBER> ns          4   186.236MB/s     0.2133 items/s
ReadParquet_c402_r250K_ReadTableAllNaive/real_time<PHONE_NUMBER> ns  171329843 ns          8   332.213MB/s    0.38049 items/s
ReadParquet_c402_r250K_ReadTableAllCoalesced/real_time<PHONE_NUMBER> ns  320970455 ns          9   369.089MB/s   0.422726 items/s
ReadParquet_c402_r250K_A_GetRecordBatchReaderPickNaive/real_time       91340293 ns   78444093 ns        227   9.33491GB/s    10.9481 items/s
ReadParquet_c402_r250K_A_GetRecordBatchReaderPickCoalesced/real_time   96119092 ns   67156895 ns        235    8.8708GB/s    10.4038 items/s
ReadParquet_c402_r250K_A_ReadTablePickNaive/real_time                  58827838 ns   13867009 ns        337    14.494GB/s    16.9988 items/s
ReadParquet_c402_r250K_A_ReadTablePickCoalesced/real_time              63920321 ns   16956693 ns        322   13.3393GB/s    15.6445 items/s
ReadParquet_c402_r250K_B_GetRecordBatchReaderPickNaive/real_time      619930624 ns  546266739 ns         34    1.3754GB/s    1.61308 items/s
ReadParquet_c402_r250K_B_GetRecordBatchReaderPickCoalesced/real_time  544559535 ns  400422370 ns         39   1.56577GB/s    1.83635 items/s
ReadParquet_c402_r250K_B_ReadTablePickNaive/real_time                 319740625 ns   30092849 ns         64    2.6667GB/s    3.12754 items/s
ReadParquet_c402_r250K_B_ReadTablePickCoalesced/real_time             304040170 ns   49492436 ns         71   2.80441GB/s    3.28904 items/s

Second table is without added latency?

Also, is the performance consistent with your expectations?

Yes, with added latency as usual (20±2ms), sorry
Not quite, but the coalescing parameters aren't tuned. I will try a run with what should be correct parameters for the second case (max 10 MiB chunks)

With latency adjusted, with coalescing tuned (10 MiB max chunk size, 1MiB max gap size):
-------------------------------------------------------------------------------------------------------------------------
Benchmark                                                                     Time           CPU Iterations
-------------------------------------------------------------------------------------------------------------------------
ReadAll1Mib/real_time                                                  48035987 ns    4411622 ns        439   20.8177MB/s    20.8177 items/s
ReadAll100Mib/real_time                                               298848863 ns  250317142 ns         69   334.617MB/s    3.34617 items/s
ReadAll500Mib/real_time<PHONE_NUMBER> ns<PHONE_NUMBER> ns         17   398.441MB/s   0.796883 items/s
ReadChunked100Mib/real_time                                           699278181 ns  200726294 ns         30   143.005MB/s    1.43005 items/s
ReadChunked500Mib/real_time<PHONE_NUMBER> ns<PHONE_NUMBER> ns          6   147.008MB/s   0.294016 items/s
ReadCoalesced100Mib/real_time                                         254209084 ns   19287598 ns         82   393.377MB/s    3.93377 items/s
ReadCoalesced500Mib/real_time<PHONE_NUMBER> ns   95045293 ns         18   434.372MB/s   0.868744 items/s
ReadParquet_c402_r250K_GetRecordBatchReaderAllNaive/real_time<PHONE_NUMBER>4 ns<PHONE_NUMBER> ns          1   56.9317MB/s  0.0652051 items/s
ReadParquet_c402_r250K_GetRecordBatchReaderAllCoalesced/real_time<PHONE_NUMBER> ns<PHONE_NUMBER> ns          4   163.071MB/s   0.186769 items/s
ReadParquet_c402_r250K_ReadTableAllNaive/real_time<PHONE_NUMBER> ns  177300582 ns          6   253.296MB/s   0.290105 items/s
ReadParquet_c402_r250K_ReadTableAllCoalesced/real_time<PHONE_NUMBER> ns  330817963 ns          7   292.501MB/s   0.335008 items/s
ReadParquet_c402_r250K_A_GetRecordBatchReaderPickNaive/real_time      305852937 ns  121533387 ns         68   2.78779GB/s    3.26955 items/s
ReadParquet_c402_r250K_A_GetRecordBatchReaderPickCoalesced/real_time  178690044 ns   84715352 ns        110   4.77169GB/s    5.59628 items/s
ReadParquet_c402_r250K_A_ReadTablePickNaive/real_time                 133761603 ns   20133540 ns        160   6.37443GB/s    7.47599 items/s
ReadParquet_c402_r250K_A_ReadTablePickCoalesced/real_time             145886468 ns   24326293 ns        143   5.84464GB/s    6.85465 items/s
ReadParquet_c402_r250K_B_GetRecordBatchReaderPickNaive/real_time<PHONE_NUMBER> ns  607414595 ns         13   540.289MB/s   0.618804 items/s
ReadParquet_c402_r250K_B_GetRecordBatchReaderPickCoalesced/real_time  587585502 ns  367286433 ns         35   1.45111GB/s    1.70188 items/s
ReadParquet_c402_r250K_B_ReadTablePickNaive/real_time                 407224990 ns   33607524 ns         51   2.09381GB/s    2.45564 items/s
ReadParquet_c402_r250K_B_ReadTablePickCoalesced/real_time             378675524 ns   50927701 ns         56   2.25167GB/s    2.64078 items/s

This is roughly what we'd expect, except for ReadParquet_c402_r250K_A_ReadTablePickCoalesced being slower than ReadParquet_c402_r250K_A_ReadTablePickNaive - some more digging will be needed there.

This is roughly what we'd expect, except for ReadParquet_c402_r250K_A_ReadTablePickCoalesced being slower than ReadParquet_c402_r250K_A_ReadTablePickNaive - some more digging will be needed there.

OTOH, ~6 GB/s is respectable either way. Not sure we need to prioritize this.

Ah as I mentioned, the figures are only right in a relative sense, since I couldn't easily grab the actual size of the result arrow::Table.

Ok, but if the actual figures are higher than 6 GB/s then my point holds even more :-)

The actual figures are much lower since I just used the file size as a rough proxy in all cases. In scenario A we read 6 of 402 columns so the actual rate is 1.5% of listed (so, 95MiB/s for naive and 87MiB/s for coalesced).
You are right, likely this is an outlier :) Having to hand-tune the parameters is inconvenient, we had thought about having it tune itself in response to network conditions, but decided this was hard/impossible due to the GIL in our original implementation.

Taking a look at this

Thanks for the review!

It might be nice to have a convenience for prebuffering an entire row group. Something like
auto rg = file_reader->RowGroup(i);
rg->PreBufferAllColumns();

I think it's not worth it given this is a relatively low-level API, but may be handy if you do expect people to be using this directly often (instead of via ArrowReaderProperties).

Ok, this should be ready. Looks like the Rust lint is failing on master.

One thing for consideration: we've been looking at using this with buffering multiple files in memory. (This way, any unexpected latency in I/O for subsequent files gets hidden while processing the first Parquet file.) One thing we've noticed is that the coalescing is often self-defeating. If you have three files A, B, and C, oftentimes C will finish loading before B, and so you're unnecessarily blocked. It's even worse because with the default internal thread pool, C is occupying slots in that pool that could otherwise have been used to finish B more quickly. It would be ideal if we could block C from starting I/O until B has at least started all of its I/O, and similarly for B.
The current APIs aren't powerful enough to implement this: even if you overrode RandomAccessFile::ReadAsync, you don't know what all the ranges read will be, and can't use that information to schedule I/O.
I realize Datasets has similar concepts: a sophisticated client can get individual FileFragments and evaluate them with its own scheduling. This by itself isn't enough to give us what we want, but it's worth considering, and would give another performance boost for large datasets.
To work towards implementing scenarios like this, would a different approach than the one here be preferable? Instead of having the Parquet reader control coalescing and I/O, we could have some API to get the byte ranges that would be read for a given combination of columns and row groups. We could then refactor reader APIs to accept a read coalescer that the caller should have pre-populated.
Or should I take this back to the mailing list (with more context)? This starts to feel close to the question optimizing I/O inside of Datasets, and I admit I'm not up to date with how the project has progressed.

Yes, we should discuss on the mailing list.
For the record, IO-related tasks should almost certainly not be using the default global thread pool, which is intended for CPU-intensive tasks. Eventually absent a path forward on sane nested parallelism, we're going to continue to see either highly suboptimal performance or scenarios where we can't use parallelism because of the risk of deadlocks.
In the meantime, I think we need to create an explicit scheduler API (probably higher level / more abstracted than the current ThreadPool API) so that an application can make sense of the IO tasks that are being issued when reading multiple files in parallel. This would extend to the Datasets API presumably also.

@lidavidm If you want to read three files in parallel, and process data as it arrives (i.e. not necessarily in order), I think the datasets API is what you want. I don't understand what read coalescing has to do with it, as you can't coalesce reads from different files.

@pitrou I think the problem is the global IO thread pool
https://github.com/apache/arrow/blob/master/cpp/src/arrow/io/interfaces.cc#L310
So if you read multiple files in parallel, they trample each other a bit when trying to do coalesced reads of their respective parts of the file

Ah, I see. The number of threads is certainly enough for local files, but it could be higher for remote filesystems. Ideally, perhaps each kind of remote filesystem has its own tweaks.

However, beware that, the more remote IO requests you issue in parallel, the longer they'll take individually given fixed bandwidth limits.

However, beware that, the more remote IO requests you issue in parallel, the longer they'll take individually given fixed bandwidth limits.

Yes, and this is why our internal Python version of this prevents file B from starting to read until file A has at least started (if not completed) all its IO (that is, B doesn't enter the thread pool until all reads for A have completed or are on the thread pool).
I'll write up something more detailed for the mailing list. I'll also try to share some data from our current C++ PoC which illustrates the problem.

Yeah, I think one definite thing that needs to happen at minimum is externalizing the thread pool used for asynchronous IO calls so that the user is able to set whatever concurrency limit makes sense for them.
A perhaps more bigger picture issue is how to broker resource allocation more fairly amongst multiple consumers, since the current mode is that every consumer is greedy and able to hose the thread pool.

I wrote up a ticket for round-robin task scheduling which might help with this https://issues.apache.org/jira/browse/ARROW-8626

Just as a quick example, here's what can happen if you just try to read multiple files in parallel (the third graph): https://www.lidavidm.me/arrow/coalescing/vis.html
Bars are trace spans that I got by manually instrumenting our code and bits of Arrow. They're organized by thread ID (y axis) and time (x axis) and color-coded with the file they're associated with. You can see, in the third row from the bottom, how a read for file_1.parquet gets held up because all the I/O for other files happens first. (Admittedly, it doesn't matter much in this example because no processing is being done on the data.)

I replied to the ML thread with more context, hopefully that clears it up.

Thank you both for all the feedback!

thanks @lidavidm! I'm confident we'll be able to devise some solutions to the resource allocation problem


[/sqllab#search] better defaults

On Query Search page

default search to "1 hour ago" rather than "28 days ago" (to view most recent searches by default)
default to current user's queries

Can I work on this?

@aayushshah15 yes, please do!

Notice: this issue has been closed because it has been inactive for 338 days. Feel free to comment and request for this issue to be reopened.


apply the provided column information to the highlighting

This applies the provided information from Cppcheck and improves the highlighting.
Example:
        <error id="returnDanglingLifetime" severity="error" msg="Returning pointer that will be invalid when returning." verbose="Returning pointer that will be invalid when returning." cwe="562" file0="C:/Users/Username/AppData/Local/Temp/FGuuaiWE_test.cpp">
            <location file="C:\Users\Username\AppData\Local\Temp\FGuuaiWE_test.cpp" line="5" column="9"/>
            <location file="C:\Users\Username\AppData\Local\Temp\FGuuaiWE_test.cpp" line="4" column="37" info="Pointer to container is created here."/>
        </error>

Before:

After:

This might look a bit strange. Here's how Cppcheck displays it:
/mnt/s/clion/example_lite_3/test.cpp:5:9: error: Returning pointer that will be invalid when returning. [returnDanglingLifetime]
 return c;
        ^
/mnt/s/clion/example_lite_3/test.cpp:4:37: note: Pointer to container is created here.
 const char* c = std::string().c_str();
                                    ^
/mnt/s/clion/example_lite_3/test.cpp:5:9: note: Returning pointer that will be invalid when returning.
 return c;
        ^

Just highlighting the column in question might be too subtle. It might make more sense to limit it to the token and it looks like the Document offers that but I wonder how consistent that would be. The end of the affected code could also be provided by Cppcheck but that would require upstream changes.

We should only highlight the token in question. We could try to determine this information ourselves (I think the Document even offers a function for that).
Or Cppcheck could offer the information in the output. I filed a ticket about offering this information: https://trac.cppcheck.net/ticket/12250.


Layer parameter warnings

By design, all parameters are optional and everything is serialised; this unfortunately creates some headaches with forgetting to include data, including data as the first parameter (which is id) and American spelling of color.
Raise warnings for the following:

data missing
any parameter name matching colour

closed in #18


changed directory of the problem with updated README as mentioned

Related Issue

Mention issue for which this pull request is a part of (please mention issue number # )
#110

Proposed Changes

Change 1
Changed the directory of  Trapping Water Problem with Optimized solution.
Chnage 2
Updated ReadMe file accordingly.

Additional Info

Any additional information or context

Checklist

[x] ✅ My code follows the code style of this project.
[x] 📝 My change requires a change to the README.
[x] 🎀 I have updated the README accordingly.
[x] 👀 I have read the CONTRIBUTING document.
[x] ✨ I have added tests to cover my changes.
[x] 🚩 All new and existing tests passed.
[x] 🌟 ed the repo

Changed the root directory of the problem from Problem Statement & Solutions to Dynamic Programming.

Changed the the code file trapping_water from Problem Statement & Solutions to Dynamic Programming  with updated README file as mentioned by the mentor.The README file follows the guidelines.

The change is required by the mentor mentioned while reviewing the PR.

https://github.com/Lakhankumawat/LearnCPP/issues/110

After making the changes mentioned ran the code with proper input and got the desired output.

Ran my program in Vs code.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Output Screenshots

Screenshot #1
Screenshot #2

Changed Directory
ReadMe File

|

@all-contributors please add @shubhamlakheraa code ,


User manual update: added asPolygon, asMultiPoint

Coverage remained the same at 78.683% when pulling d6c3b7f119db5bc79b63fb77e3f0d4c0df9a732f on solarjoe:master into 629f9a4dc6e3f2080f1e2ed214daec3413bf54b0 on Toblerity:master.

🙏 @solarjoe


do not support nest param

such as
A = 100
B = A+200
calc(B)

I don't quite understand what the issue is. Could you provide a bit of example code and describe what you expected versus what result you got? If at all possible providing an actual expression string would be helpful.


F5 doesn't work when focus is in editor when Sublime is installed

See: https://github.com/OmniSharp/omnisharp-vscode/issues/1341
If this extension is not installed, F5 works when focus is in the text editor. When the extension is installed, F5 does not work.

@waderyan the issue is that on the mac this extension binds F5 and CTRL+F5 to the sort lines commands.
I would argue that the Debug (F5) and Run (CTRL+F5) are more important than the sort lines commands and these keybindings should not be rebound.
         {
                "mac": "f5",
                "win": "f9",
                "linux": "f9",
                "key": "f9",
                "command": "editor.action.sortLinesAscending",
                "when": "editorFocus"
            },
            {
                "mac": "ctrl+f5",
                "win": "ctrl+f9",
                "linux": "ctrl+f9",
                "key": "ctrl+f9",
                "command": "editor.action.sortLinesDescending",
                "when": "editorFocus"
            },

I would argue that F5 is a primary

Makes perfect sense.

Fixed


Move redshift, snowflake, bigquery plugins

It seems such a waste of time
If that's what it's all about
Mama if that's movin' up
Then I'm movin' out
I'm movin' out

These are private for now, while we set up automated tests and do some repo housekeeping:

https://github.com/dbt-labs/dbt-redshift
https://github.com/dbt-labs/dbt-snowflake
https://github.com/dbt-labs/dbt-bigquery

We ran + passed 455 integration tests on Postgres, the same number as on the develop branch currently.
I've commented out non-Postgres RPC integration tests. The real resolution here will come in #3755.

Planned merge: Saturday, Oct 2. We're freezing all code Friday, October 1 @ 5 pm ET. We'll incorporate any updates to adapters + integration tests in the dbt-redshift, dbt-snowflake, and dbt-bigquery repos, and then merge this PR.


Improve types

@barry4dev I think this cleanup thing a bit. I don't think fixing the generic type tho for formContext

Thanks, @barry4dev looks like it's not breaking formContext and useForm works fine. I am going to merge it in and publish. it's an improvement for now.


Bump to 1.4.0, conda smithy regenerate

https://github.com/asascience-open/thredds_crawler/releases/tag/1.4.0

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


[WFLY-10655] SEVERE error on deploy of ear: "Unable to obtain CDI 1.1…

JIRA: https://issues.jboss.org/browse/WFLY-10655

@jamezp This caused a regression, seems to break JSF bundled in EARs, opened https://github.com/wildfly/wildfly/pull/11458


Update NodeJS version to 8.x

Ballerina Composer now uses package-lock feature of NPM which is only available with NPM 5.x and NodeJS 8.x. Hence, we need NodeJS 8.x in builders too.

https://docs.npmjs.com/files/package-lock.json


Use https for eirini url

Hi capi! When we merged your PR: https://github.com/cloudfoundry/cf-for-k8s/pull/14 we ran into app push issues so we took a look at potential changes and found that the communication with eirini was updated from https to http. When we reverted that change, functionality returned to our cf.
In the meantime, we've added an overlay to cf-for-k8s, but wanted to make sure the actual fix made it back to y'all. Feel free to ping us with questions!
Thanks,
Andrew and Dave @davewalter

Looking into this -- I see that commit 9defb2e76145a086e851a462349ec2eefd597768 brought in the change to go from https to http.
@selzoc I see your name on this commit. Any context behind that commit?

@christarazi looks like a bad copy/paste.  Feel free to go ahead and merge this
(should uaa internal url also be https?)

Hmm not sure. I'm going to merge this and think about the UAA url separately.


Alerting Custom URL Skip verifying the server's certificate chain and host name

Hi !
I want to use a self hosted Mattermost for custom alerting notifications, unfortunately it does use an internal certificate authority not recognized by Gatus :
[watchdog][handleAlertsToTrigger] Ran into error sending an alert: Post "https://mattermost.****.***/hooks/hy3ajdg*****": x509: certificate signed by unknown authority

It would be nice to add an insecure option for alerting.custom.
Thank you for Gatus ! Easy to setup and configure, gets the job well done !
Best regards,

Released in v1.4.1

@ziedzaiem If you don't mind, would you let me know if the new feature works properly? I only briefly tested it, so a confirmation would be much appreciated :)

@ziedzaiem If you don't mind, could you let me know if the new feature works properly? I only briefly tested it, so a confirmation would be much appreciated :)

Hi ! It works as expected ! Thank you very much :)


JupyterLab 3.0 Support

Elevator Pitch
Demonstrate JupyterLab 3.0 support shortly around initial release.
Benefits

no nodejs/webpack/npm needed to install new packages
pure pip/conda-distributable build times
first-party support of worker-loader
improved workspace support
improved single-document mode may be good for offline jyve builds

Resources

enough of the stack is ready to start basic testing, e.g. binder
workspaces might provide some new and interesting opportunities

Risks

implementation

front-end

kernels will have changed again, even beyond the unfinished work on #44

backend

significant nbconvert changes have landed
jupyter_server needs to be accounted for

testing

robot

command palette has changed (two menu clicks, or a three-key chord)

upstream

robotframework-jupyterlibrary needs significant overhaul

Related

supersedes #44

there will be no point in supporting jupyterlab 1/2 in light of the above benefits

maybe consider abandoning jyve, contribute to more recent:
https://github.com/jtpio/jupyterlite

Wow, that is amazing.

Yep, jyve is dead, long live lite.

Long live lite :slightly_smiling_face: :tada:


YAML error on Ruby 3.1.0

Expected behaviour
Everything works with no issues.
Actual behaviour
I'm seeing warnings about the date: key when parsing the blog posts:
YAML Exception parsing [PROJECT_PATH]/boon-blog/source/articles/2014-09-23-setting-up-a-middleman-blog.html.md: Tried to load unspecified class: Date

The frontmatter looks like:
---
title: Setting up a Middleman Blog
date: 2014-09-23
tags: technical, blogging, middleman
authors: Robert Fletcher
---

For some reason, the rendered result of this is that the blog posts show up without their titles.
Steps to reproduce the problem
You can run middleman serve on this branch.
Additional information

Ruby version: 3.1.0
Middleman version: 4.4.2
Middleman Blog version: 4.0.3
OS version: x86_64-linux

I would recommend keeping Middleman 4.x projects on Ruby 2.x
There are some PRs to enable Ruby 3.1 support, but those are on the Middleman 5.x branch and unlikely to be backported.

I would recommend keeping Middleman 4.x projects on Ruby 2.x
There are some PRs to enable Ruby 3.1 support, but those are on the Middleman 5.x branch and unlikely to be backported.

@tdreyno I see, do you know when 5.x will be released?

@tdreyno I see, do you know when 5.x will be released?

Looking a lot like never, but the master branch is up to date and being updated to current releases just in case.

@tdreyno Should I be making plans to move to a different static site generator?

I was able to get around this by adding the time to the date.

There is no reason to be using Ruby 3.x with Middleman. I suggest utilizing rvm or Docker to allow Middleman v4 to continue to operate in the environment it expects.

@mockdeep @puyo we finally pushed some fixes in v4 and now it works fine with all these Ruby versions (From 2.5 to 3.3): https://github.com/middleman/middleman/blob/1d1e7528d16dad59a15e988ea5aed171c79a7736/.github/workflows/ci.yml#L12
So I think you can close this issue 🙏🏼


[UG] Edit email constraint

Codecov Report

Merging #395 (793f082) into master (fd1dc09) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #395   +/-   ##
=========================================
  Coverage     68.41%   68.41%
  Complexity     1131     1131
=========================================
  Files           135      135
  Lines          3866     3866
  Branches        521      521
=========================================
  Hits           2645     2645
  Misses          996      996
  Partials        225      225

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd1dc09...793f082. Read the comment docs.


AuthConfig status conditions

Adds conditions and proper summary of the status of the AuthConfig, taking into account the state for each host name listed in spec.hosts.
Two conditions are defined:

Available means at least one host from spec.hosts linked to AuthConfig in the cache
Ready means all host names from spec.hosts linked to the AuthConfig in the cache

When it is not possible to link all hosts to the AuthConfig, due to a host already taken by another AuthConfig in a different k8s namespace, the AuthConfig will never be Ready (condition reason HostNotLinked). It can still be Available though (activated via other hosts).
Users can read the list of hosts that succeeded being linked to the AuthConfig in status.summary.hostsReady: []string.
Summary status conditions and possible states:

Type
Status
Reason
Message
Meaning

Available
True
HostsLinked
N/A
At least one host from spec.hosts was linked to the AuthConfig in the cache. Requests sent to the linked host can be expected to be protected by this AuthConfig. User can check status.summary.hostsReady for the list of host names that did succeed being linked to the AuthConfig in the cache.

Available
False
HostsNotLinked
No hosts linked to the resource.
No host from spec.hosts was linked to the AuthConfig in the cache. No request will cause this AuthConfig to be evaluated by Authorino. Only possible status for Ready is False in this case.

Ready
True
Reconciled
N/A
The AuthConfig is cached for all host names from spec.hosts.

Ready
False
HostsNotLinked
One or more hosts not linked to the resource
Failed to cache the AuthConfig for one or more host names from spec.hosts. User should check status.summary.hostsReady for the list of host names that did succeed being linked to the AuthConfig in the cache; occasionally none.

The counters and indicators in the status sub resource, used as well to define the print columns when listing the authconfig resources, were moved into Status.Summary.
The following indicators have been added to the summary:

hostsReady []string - list of the host names from spec.hosts linked to the AuthConfig in the cache
numHostsReady string - indicator of the number of hosts linked to the AuthConfig in the cache, in the format n/N, where n is number of hosts linked and N is the total number of hosts in spec.hosts.

Column names were also modified for simplicity.
Closes #314.
Verification steps
make local-setup # clusterWide: true

kubectl create namespace user-1
kubectl -n user-1 apply -f -<<EOF
apiVersion: authorino.kuadrant.io/v1beta1
kind: AuthConfig
metadata:
  name: auth-1
  namespace: user-1
spec:
  hosts:
  - talker-api.<IP_ADDRESS>.nip.io
  response:
  - name: x-auth-data
    json:
      properties:
      - name: authconfig
        value: auth-1
EOF

kubectl create namespace user-2
kubectl -n user-2 apply -f -<<EOF
apiVersion: authorino.kuadrant.io/v1beta1
kind: AuthConfig
metadata:
  name: auth-2
  namespace: user-2
spec:
  hosts:
  - talker-api.io
  - talker-api.<IP_ADDRESS>.nip.io
  response:
  - name: x-auth-data
    json:
      properties:
      - name: authconfig
        value: auth-2
EOF

kubectl get authconfigs -A -o wide
# NAMESPACE   NAME     READY   HOSTS   AUTHENTICATION   METADATA   AUTHORIZATION   RESPONSE   WRISTBAND
# user-1      auth-1   true    1/1     0                0          0               1          false
# user-2      auth-2   false   1/2     0                0          0               1          false

kubectl -n user-1 get authconfig/auth-1 -o jsonpath={.status}
# {"conditions":[{"lastTransitionTime":"2022-07-12T17:30:16Z","reason":"HostsLinked","status":"True","type":"Available"},{"lastTransitionTime":"2022-07-12T17:30:16Z","reason":"Reconciled","status":"True","type":"Ready"}],"summary":{"festivalWristbandEnabled":false,"hostsReady":["talker-api.<IP_ADDRESS>.nip.io"],"numAuthorizationPolicies":0,"numHostsReady":"1/1","numIdentitySources":0,"numMetadataSources":0,"numResponseItems":1,"ready":true}}

kubectl -n user-2 get authconfig/auth-2 -o jsonpath={.status}
# {"conditions":[{"lastTransitionTime":"2022-07-12T17:30:16Z","reason":"HostsLinked","status":"True","type":"Available"},{"lastTransitionTime":"2022-07-12T17:30:16Z","message":"One or more hosts not linked to the resource","reason":"HostsNotLinked","status":"False","type":"Ready"}],"summary":{"festivalWristbandEnabled":false,"hostsReady":["talker-api.io"],"numAuthorizationPolicies":0,"numHostsReady":"1/2","numIdentitySources":0,"numMetadataSources":0,"numResponseItems":1,"ready":false}}

not sure about "Ready" when there are any loose ones

Ready should be true only when there are no loose ones, @didierofrivia.
https://github.com/Kuadrant/authorino/blob/6bf5315a63e2a0cdc580623cf088534506476cd4/controllers/auth_config_status_updater.go#L66


no stock field in product schema

add the stock field to product schema of fix this bug. It crashes the cart page

Hi, Actually I changed stock to quantity, and then I forgot to refactor. Now fixed,
Thank you.


Multigrading option

Is there the option to use multigrading feature of block_mesh utility by classy_blocks? ? I cannot find any info about it in source code and examples

Yes, multigrading is supported but not explicitly demonstrated in examples.
It's actually so simple that there's very little to demonstrate.
One such example would be the orifice plate, https://github.com/damogranlabs/classy_blocks/blob/master/examples/chaining/orifice_plate.py
# chop to a sensible number of cells;
# dilute long inlet/outlet sections
shapes[0].chop_radial(start_size=cell_size)
shapes[0].chop_tangential(start_size=cell_size)
shapes[0].chop_axial(length_ratio=0.9, start_size=cell_size * cell_dilution, end_size=cell_size)
shapes[0].chop_axial(length_ratio=0.1, start_size=cell_size, end_size=t / 8)

shapes[6].chop_axial(length_ratio=0.1, start_size=t / 8, end_size=cell_size)
shapes[6].chop_axial(length_ratio=0.9, start_size=cell_size, end_size=cell_size * cell_dilution)

So here for shape 0 (inlet) the first 90% of length is graded from coarse to normal and the last 10% goes down to first cell thickness in the boundary layer.
Shape 6 is the same but as it's outlet, it's vice versa.
Hope that answers your question.

Thank you for your reply. The problem is that i'm working with asymmetric geometry and use wedge operation on face. Unfortunately wedge does not support radial, tangential or axial chop and chop method has now length_ratio keyword argument
Is there any chance to use multigrading with wedge. Sorry if my questions very simple, but im realy dont understand it(

If you're using Operations, you just use something like wedge.chop(axis, length_ratio=..., ...) instead.
For Wedge specifically, you only use axis 0 (axial direction) and 1 (radial). The rest is the same.


App is stuck on splash screen

Our production app is stuck on the Splash screen for some users.
Seems to be the issue https://github.com/flutter/flutter/issues/98973
We are using Flutter version 2.10.3
It seems that this issue is fixed with 2.10.3 https://github.com/flutter/flutter/wiki/Hotfixes-to-the-Stable-Channel#2103-march-02-2022 but still our app users complain that it is not working.
Device Details:
Android device: SM-A127M
Android os version: 11

Android device: moto g (30)
Android os version: 12

Hi @deepak786, Thanks for filing the issue. In order to investigate this issue further, we would need a local reproduction sample project. Is this affecting only on Android or IOS too?

@maheshmnj
We have the users reporting this issue for the Android only.

flutter doctor -v
[✓] Flutter (Channel stable, 2.10.3, on macOS 12.3.1 21E258 darwin-x64, locale
    en-US)
    • Flutter version 2.10.3 at /Library/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7e9793dee1 (8 weeks ago), 2022-03-02 11:23:12 -0600
    • Engine revision bd539267b4
    • Dart version 2.16.1
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/appleapple/Library/Android/sdk
    • Platform android-31, build-tools 30.0.2
    • ANDROID_HOME = /Users/appleapple/Library/Android/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)

[✓] IntelliJ IDEA Community Edition (version 2019.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.66.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 2.26.1

[✓] Connected device (2 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 12
      (API 31) (emulator)
    • Chrome (web)                 • chrome        • web-javascript • Google
      Chrome 100.0.4896.127

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Thanks for the info @deepak786, However, we won't be able to investigate this issue without a local reproduction. Can you please share it?

I do understand that this issue is in production reported by your users, But this wouldn't be actionable on our side if this cannot be locally reproduced. I would suggest you to please share the sample project which was reproducible for your users by removing all the confidential and unnecessary part of code that wouldn't help in reprodcution making it minimal.


autoregressive wrapper generate should accommodate variable lengthed prefixes

https://github.com/lucidrains/x-transformers/blob/a3373cb9f7ead1db1905eab420dd2c80e263e054/x_transformers/x_transformers.py#L1195
Here we need to slice the mask as well.

@LouChao98 oh, when would you need a mask for decoder training?

@LouChao98 i'm just going to disallow it until a legitimate use case comes up https://github.com/lucidrains/x-transformers/commit/a651c19ac108e45f5a8e8ab9a74d04a41988aaf2

To prevent access to left padding tokens, a mask is required for batch decoding with different prefixes.

Oh, my mistake.  The issue is here
https://github.com/lucidrains/x-transformers/blob/2d1aca2df5c282170b168cf5e5ab04cda18df077/x_transformers/x_transformers.py#L914-L916
This should be disabled if using cache. No need to slice mask.

@LouChao98 how are you doing your positional embedding in the presence of left padding tokens?

@LouChao98 actually, i can fix your issue in another way by tomorrow's end, without masking of left padding. i haven't considered variable lengthed prefixes in the current implementation

@LouChao98 i'm kind of in this mindspace anyways; currently stuck on how to approach batched speculative decoding (where i am actually considering left padding tokens and facing positional embedding issues)

the solution for you would be passing in the prefix lengths, and incrementing it and indexing out the correct logit on each iteration

actually maybe you are right with the left padding tokens, I can't think of a clean way to manage the kv cache otherwise
ok let me meditate on this tomorrow morning over a cup of coffee or two

If we can assume the mask is continuous (left padded and right padded), I think the only change to pos emb is about absolute pos emb. We can use the cumsum of the mask instead of torch.arange to get the correct pos emb.
If not use a mask or padding, we may use a block-wise attention. I know a paper implement a more complexicated attn (hash-sparse attn), achieving a near flash-attn speed: https://openreview.net/pdf?id=BQEaklwG9P

@LouChao98 yea no worries, i can fix the variable prefix length problem, and in turn also make a dent in the batched spec decoding problem
yea, that hash sparse attention paper isn't great, just use flash attention 2

@LouChao98 do you want to check out 1.22.8? you will simply have to pass in prompt_lens at .generate and it should automatically take care of all the masking, positional offsetting, etc (all while maintaining kv cache)

ok, this was actually very helpful, as it leads up to batched spec decoding, which is much more difficult (but made simpler after crafting the align function)

I doubt the need of realign:
https://github.com/lucidrains/x-transformers/blob/98d750f7c607563f3f00edc319a8c2d3a36e17ef/x_transformers/autoregressive_wrapper.py#L249-L252
Just out = out[:, t:] can extract the generate texts.
Besides, because prompt_lens is not updated, realign + slice will always get zeros.

I also suggest to remove seq_start_pos in RotaryEmbedding because it do not affect the result of self attn but confuse readers.

I doubt the need of realign:
https://github.com/lucidrains/x-transformers/blob/98d750f7c607563f3f00edc319a8c2d3a36e17ef/x_transformers/autoregressive_wrapper.py#L249-L252
Just out = out[:, t:] can extract the generate texts.
Besides, because prompt_lens is not updated, realign + slice will always get zeros.

yes you are right, made the change
and yes, you are also right about rotary, it should be shift invariant, i think? i'll need to revisit the math

@LouChao98 ok, i've reverted the rotary embedding offsetting
do you want to give it one more review?

I found a bug in AbsolutePositionalEmbedding and ScaledSinusoidalEmbedding. I am sorry for not checking the abs emb parts in previous.
https://github.com/lucidrains/x-transformers/blob/77c8464785a5e261c52c1ddd7a48cc53c30f5528/x_transformers/x_transformers.py#L218-L219
The offset should be applied as follows, because during generation, the inputs are left padded.
pos = (pos - offset[..., None]).relu()

Everything else looks great.

@LouChao98 🤦 ok, yes, should be fixed

Hah, great. Thanks for your effort. I think we can close this now.

@LouChao98 yea no problem, thanks for opening the issue. really led somewhere nice


Lithuania

In \sources\lt\countrywide.json:
bad url:
http://lakis.lakd.lt/ArcGIS/rest/services/LAKD_lokatorius/MapServer/0
new url:
http://www.visimarsrutai.lt/arcgis/rest/services/LAKD_lokatorius/MapServer/0
or
https://eismoinfo.lt/arcgis/rest/services/LAKD_lokatorius/MapServer/0
~700k address, but they are very old 2012.
The newest addresses are presented here:
http://www.visimarsrutai.lt/services-ext/api/gazetteer/search
addressFound:1012423
another APIs: http://www.visimarsrutai.lt/services-ext/api?_wadl
or Lithuania Address Register:
https://www.registrucentras.lt/adr/index_en.php
on map:
https://www.regia.lt/map/vilniaus_m?x=583001&y=6059623&identify=true&aobkodas=175-327-181&lang=3
https://www.regia.lt/map/resources/AdresuServisas/search_new/query=?query=a&sav_adm_id=461&searchAll=true&start=0&count=Infinity

Adreso Numeris:
https://www.registrucentras.lt/gwa/rest/services/GR/LinLab/MapServer/2

If you can find something where their license is open, that would be great!

Closing this and tracking with new issue with verified okay copyright: https://github.com/openaddresses/openaddresses/issues/5728


Prevent errors on a wider array of valid conditionals

Currently, VKV will throw an error with the below conditional, despite it being valid in the Source engine:
GameUIButtonsSmall
{
    "1"    [$WIN32]
    {
        "bitmap"    "1"
        "name"        "Buttons"
        "scalex"    "0.5"
        "scaley"    "0.5"
    }
}

This PR completely removes the positional validity check from conditionals. It's possible that this change is too permissive, so let me know if it can be made a bit more specific.

This needs tests.

Tests have been added 🙂

I'm still not entirely sold on the "key" [$CONDITION] "value" case being intentionally valid, the rest looks fine to me.


chip-tool PersistentStorage: support for CASE resumption keys

Problem
chip-tool PersistentStorage is broken with CASE resumption which uses keys containing '='. It can write the key/value pairs but upon read they end up something different. As a result console is flooded with error messages since none of the keys can be found.
Change overview
Make sure that CASE resumption key/values read match the written ones.
Testing

tested manually using chip-tool
no other tools are affected
see also discussion at https://github.com/project-chip/connectedhomeip/pull/20181

In the meantime fixed by #20239


[Bug]: Documentation link broken

What happened?
Following https://bazelbuild.github.io/rules_nodejs/ leads to error page.
Version
Documentation error, not bazel related.
How to reproduce
No response
Any other information?
No response

Thanks for reporting. I believe the broken link was in rules_js. Fixed there now. It would be helpful for maintainers to also link to where the link was broken or put up PR fix the fix.

For reference, the link was broken because rules_nodejs was donated by Google to the Linux foundation and it moved from the bazelbuild GitHub org to bazel-contrib. Looks like GitHub doesn't re-direct for these. New docs URL is https://bazel-contrib.github.io/rules_nodejs/


Suggestion for easier-to-review docs

Including how-to for the idea of having a single-line-per-sentence
Hopefully the instructions are clear?
Then I made the suggested changes across the document, which should help demonstrate the (potential) value.
This practice is very useful when working on longer, denser, and more complex documentation.
For example, we can use GitHub directly for collaborative reviews of project docs, like we did with the governance file in this project: https://github.com/operate-first/community/commits/main/governance.md
I'm not sure how common this practice is elsewhere, but we also used it for theopensourceway in most of the AsciiDoc files and the PDF is 149 pages all together.

To see the value of this kind of change, take a look at the source diff for this PR:
https://github.com/pAI-OS/paios/pull/6/files#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055
The changes in green show how each sentence now has a line number and a + symbol. This allows for granular web-based commenting and commit of suggestions into the branch, all from the web interface. It is more accessible to non-coders (although still obscure compared to word processor view.)


[Bug]Not able to process custom template

Describe the bug
Hi, I have created a custom OMR sheet and custom template json file (both files attached for reference). I am trying to run the program as described in the guidelines. The program working perfectly with all samples in samples folder (sample1 through 6).  However, with the custom OMR sheet, I am getting mixed results. For empty bubbles, it is giving "ABCD" instead of empty. For some fields, it gives output with multiple options. Can't we use same template for both the files?
Sample OMR.docx
Results_04PM.csv
sample7.zip
To Reproduce
Steps to reproduce the behavior:

Download the sample7.zip (attached). Unzip and copy sample7 folder to inputs folder.
Note: The file template.json prepared based on test1.jpeg using command 'python main.py --setLayout'
Command(s) used 'python main.py'
Check results in .\outputs\sample7\Results folder.

Expected behavior
Both files should be processed properly. Results_04PM.csv file also attached for reference.
Desktop

OS: [Windows 10 Pro]
Python version: 3.11.3
OpenCV version: 4.6.0

Hi @mjskishore, there are a few ways you can try to fix this.

Try increasing the bubble dimensions a bit. My guess is that the letters A, B, C, D are getting detected as marked bubbles.
Increase your template dimensions to a width more than 1000px and relatively the bubble dimensions
Reduce the threshold values for GLOBAL_PAGE_THRESHOLD_BLACK and GLOBAL_PAGE_THRESHOLD_WHITE

Closing for inactivity. Feel free to reopen if any queries


is the webpanel working for me personally not idk why it just doesnt connect with the miner

What's the URL you're connecting to the web panel with (you can censor the URL/IP if they aren't a local address)? You can run the checker and see. And is the database folder (db) and database file (db/unamwebpanel.db) writable? You can check by creating a new configuration and see if it appears in the edit list.

yes

thanks for your help in this one it was a problem with the hoster with the /hack