Add a method in item sketch to retrieve active keys

This is a small addition to the list of current methods supported under ItemSketch.
In many applications, it's required to know at each stage what are the current active Items residing in the hashmap. Instead of indirectly calculating based on the current map size and all, we can get info directly regarding a list of current active keys residing in the hashmap.
Also using this we can get to know which key got removed from consecutive timestamps T1 and T2 or which new one got added.
sketch.getWhichKeysAreActive()_T1 - sketch.getWhichKeysAreActive()_T2

Can you explain more about why it's important to know non-frequent items at any given point in time? This will in general return a bunch of noise that would be filtered out using even the less-aggressive NO_FALSE_NEGATIVES flag. It does not provide a way to distinguish actual frequent items from a few items that happened to be added once but have low enough counts as to be meaningless.

The appropriate way to compare sketch contents over time would be to use .getFrequentItems(ErrorType.NO_FALSE_NEGATIVES) -- you'll certainly get some false positives, but you'll get anything that at least might rise above the noise.

Hi @jmalkin, apologies for the late reply.
The obvious use case is that at any given time point, I can get an accurate instance of what are the current probes residing in the hash data structure, which I feel can not be tried out via any other current api calls/combination of them.
You are right that at any point the activeKeys might not be relevant to the entire stream as a whole considering a heavy hitter application, where initial such activeKeys will be counted as noise.

An interesting utility that I am also exploring in my work is to capture these fluctuating keys, which occur intermittently due to lower than group median freq - thus classifying as noise. As compared to CMS sketches which stores instead every possible incoming item frequency (thus including this noise as well), it can hint towards by how much fraction is the Frequent Item sketch more accurate than CMS (might not be in all cases) since CMS contains the noise factor for applications like heavy hitters.

Also in applications like anomaly detection, where any item from the stream might be anomalous, then for each item, we would like to calculate some custom anomaly score which in turn is determined by the individual item frequency over time. In such scenarios, it might be required to track each individual item and how it appears in the sketch over time.

These are some ideas that are coming to my mind and also during my work I am requiring use cases as such, although examples like these might be rare, and one might alternatively get to know if an item exists in the sketch if getEstimate(item) != nan.
Look forward to your thoughts / suggestions

@prateekiiest
Prateek,I am curious as to why you only want the array of active items and not their associated frequencies at a point in time.  The current freq count will give you a lot of information about the potential stability of the item in the sketch.  Also having access to the current ub and lb will enable you to infer the same conclusions the sketch makes about whether an item's lb exceeds the noise floor or just the ub, and thus it's likelihood of being a frequent item.  I would think you would want what we already define as a Row, just not filtered.
We try to discourage users from trying to infer meaning to retained items that the sketch considers to be noise.  That is why the Rows returned by the getFrequentItems(...) methods are filtered by an ErrorType and never include the noise.  However, you apparently are performing more extensive analysis, even on the noisy items, that is beyond the scope of the design of the sketch.
If we are to do this, Instead of enabling just getActiveKeys(), which is essentially a hack to address your application, perhaps we should extend the ErrorType to include "ALL_ITEMS", so that the Rows returned by getFrequentItems(..) would contain everything.   This would be a more general solution that may be useful to other applications in addition to yours.
I would like to open this issue more broadly to our community to get some other opinions.
Cheers,
Lee.

I have opened a discussion on our<EMAIL_ADDRESS>list.  Please join us there.

There is not much support for this PR (see above discussion).

If this is for research purposes, the user can make their own copy and add the method.
It isn't clear that this PR would benefit the community at large and potentially could give misleading information (noise) to users that are not that familiar with the statistical properties of the sketch.
We can alway reopen this issue in the future, but for now I am closing this PR.

See above comment.


Bug or API issues? (altrank / galaxyscore script) - Reopened

Hi guys, sorry to be annoying again. I'm on your side
But there is an error that I don't know if it's already an API error or a bug in the altrank and galaxyscore script encoding
I haven't used these scripts for a long time since I used botassistexplorer but for some reason this script got stuck and doesn't renew the coins in the altrank list (3c-tools error, not the script)
I did a clean install of the script installing helper requirements and the error persists.

04:45 ~/3commas-cyber-bots (main)$ ./galaxyscore.py
2022-11-02 04:45:44 - galaxyscore - INFO - 3C Cyber Bot-Helper galaxyscore
2022-11-02 04:45:44 - galaxyscore - INFO - Started on Wednesday 04:45:44 2022-11-02
2022-11-02 04:45:44 - galaxyscore - INFO - Notifications are disabled
2022-11-02 04:45:44 - galaxyscore - INFO - Created example config file '/home/droidg/3commas-cyber-bots/galaxyscore.ini', edit it and restart the program
04:45 ~/3commas-cyber-bots (main)$ ^C
04:46 ~/3commas-cyber-bots (main)$ ./galaxyscore.py
2022-11-02 05:47:11 - galaxyscore - INFO - 3C Cyber Bot-Helper galaxyscore
2022-11-02 05:47:11 - galaxyscore - INFO - Started on Wednesday 05:47:11 2022-11-02
2022-11-02 05:47:11 - galaxyscore - INFO - Notifications are disabled
2022-11-02 05:47:11 - galaxyscore - INFO - Loaded configuration from '/home/droidg/3commas-cyber-bots/galaxyscore.ini'
2022-11-02 05:47:11 - galaxyscore - INFO - Reloaded configuration from '/home/droidg/3commas-cyber-bots/galaxyscore.ini'
2022-11-02 05:47:11 - galaxyscore - INFO - Fetched 3Commas pairs blacklist OK (0 pairs)
2022-11-02 05:47:11 - galaxyscore - INFO - Fetched 3Commas price OK (20522.48)
Traceback (most recent call last):
File "/home/droidg/3commas-cyber-bots/./galaxyscore.py", line 372, in
usdtbtcprice = get_threecommas_btcusd(logger, api)
File "/home/droidg/3commas-cyber-bots/helpers/threecommas.py", line 74, in get_threecommas_btcusd
if isnan(price):
TypeError: must be real number, not str
04:47 ~/3commas-cyber-bots (main)$ ./altrank.py
2022-11-02 04:48:25 - altrank - INFO - 3C Cyber Bot-Helper altrank
2022-11-02 04:48:25 - altrank - INFO - Started on Wednesday 04:48:25 2022-11-02
2022-11-02 04:48:25 - altrank - INFO - Notifications are disabled
2022-11-02 04:48:25 - altrank - INFO - Created example config file '/home/droidg/3commas-cyber-bots/altrank.ini', edit it and restart the program
04:48 ~/3commas-cyber-bots (main)$ ./altrank.py
2022-11-02 05:50:35 - altrank - INFO - 3C Cyber Bot-Helper altrank
2022-11-02 05:50:35 - altrank - INFO - Started on Wednesday 05:50:35 2022-11-02
2022-11-02 05:50:35 - altrank - INFO - Notifications are disabled
2022-11-02 05:50:35 - altrank - INFO - Loaded configuration from '/home/droidg/3commas-cyber-bots/altrank.ini'
2022-11-02 05:50:35 - altrank - INFO - Reloaded configuration from '/home/droidg/3commas-cyber-bots/altrank.ini'
2022-11-02 05:50:35 - altrank - INFO - Fetched 3Commas pairs blacklist OK (0 pairs)
2022-11-02 05:50:35 - altrank - INFO - Fetched 3Commas price OK (20520.29)
Traceback (most recent call last):
File "/home/droidg/3commas-cyber-bots/./altrank.py", line 360, in
usdtbtcprice = get_threecommas_btcusd(logger, api)
File "/home/droidg/3commas-cyber-bots/helpers/threecommas.py", line 74, in get_threecommas_btcusd
if isnan(price):
TypeError: must be real number, not str
04:50 ~/3commas-cyber-bots (main)$
Thank you and sorry for my inconvenience. Cheers

Unfortunately the free lunarcrush api was revoked, so botassistexplorer (3c-tool) affected it as well. I guess there is no API error

Update: I bought the API for one day from lunarcrush and the script error is the same 😔

The api v3 uses different endpoints. I reckon changing all lc scripts will be necessary.

Thanks, just replied to the other issue as well. Yes, these scripts need some work to match the new endpoint. Will look into this, not sure when however.

Thanks, just replied to the other issue as well. Yes, these scripts need some work to match the new endpoint. Will look into this, not sure when however.

Nice thanks!

@dangalv @thematikma I have updated some code, using my new api3 key I got so far...
I'm still recovering from illness, maybe you can try and give some results...

@cyberjunky @dangalv @amargedon Many thanks for your efforts! I will have a try later and post results.
And a speedy recovery to @cyberjunky

It doesn't look to me API is free for any /coins calls (you need at least 240 credits per day 24 * 10 if you call every hour) which costs:

@dangalv @thematikma I have updated some code, using my new api3 key I got so far... I'm still recovering from illness, maybe you can try and give some results...
2022-11-06 13:26:40 - altrank - ERROR - Fetching LunarCrush data failed 500 {"error":"Error: You must have at least $1 USD in your LunarCrush payments account to use this endpoint."}

thank you mate! I hope you feel better, as soon as I can I will try the new config and let you know how it went

@cyberjunky
Well, I tell you about my experience with the galaxyscore script, which is the script one I need.
The coins are fetched but even if I put a high rank of 150 of the altrank coins and from 40 of galaxyscore, neither activates the bot.
Each API call spends an exuberant amount of credits about 10 credits, and I'm naive thinking that I was going to have 2000 calls. I mean, with one dollar you only get 20 calls to the bot. A scam by lunarcrush.
But removing that detail, the script no longer has any error but does not place any coin on the bot

I agree with that. I would wish for a more attractive plan for private users. ~ $350 a year for hourly calls is nuts imho. I guess one could stop the scripts, when the market is low and safe some usd.

I'm honestly thinking about writing some grabber from webui in the future. If it would be possible, you would only need to have Lv. 4. which is one-time payment I suppose.

@dangalv the 10 credits was what I expected it would cost for each call (after looking at the pricing), if you could buy 20K credits and call once every hour it would not be so bad...  but the 1$ per day annoys me
That it would gonna cost a lot of money was expected for months... and I think altrank/galaxyscore is not that good anymore anyway...
If you still want me to debug the issue with the ranks please include the debug output.
@gh61 if the developer api doc tool returns live data we just can scrape that ;-) no levels needed, but I can't check.

I'm honestly thinking about writing some grabber from webui in the future. If it would be possible, you would only need to have

It is possible already for free with the developer documentation (https://lunarcrush.com/developers/api/coins) . It provides a sample request, but it return the true data. So you dont need to have any Level access to get the data. However, the website is a bit difficult to scrape with no clear html id's etc.

I was able to extract the api token used for testing api request on DEV API DOC.
When I used it in the script api requests to LC are now working.
I don't know, if everyone got the same token, or is it my personal.
So check yours:

@dangalv I fixed he sorting issue in latest code for altrank, only tested with seperate call, since api.3commas.io is down for me..

@dangalv I fixed the sorting issue in latest code for altrank, only tested with seperate call, since api.3commas.io is down for me..

Yes, the 3commas api is currently down

Then when it is enabled I will keep trying to see what happens

altrank working
no same luck with galaxyscore

Great detail of turning off the bot when the credits or day are over :)

altrank working no same luck with galaxyscore

I fixed the galaxyscore issue.
Look like a bug in the LunarCrush API, whenever you sent desc=0 or desc=1 as parameter (which are allowed) the API give false responses.


Remove ES6 example code and validate JS code examples

Fixes #401. Waiting for better CDN of candela so that we can replace links with ones that will point to the latest candela.

Current coverage is 58.36% (diff: 100%)

Merging #427 into master will not change coverage

@@             master       #427   diff @@
==========================================
  Files            26         26
  Lines           711        711
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            415        415
  Misses          296        296
  Partials          0          0

Powered by Codecov. Last update b8698ed...eeb7665

Since we now have a recent candela on npm, we can change sphinx and examples to point to //unpkg.com/candela.
The JS examples are now standalone and have been manually tested by copy/pasting into separate index.html files and viewed in-browser.
Ready for review.

The PR build failed because girder-client got a 400 error while uploading test images. I've restarted the build, but all the tests did pass.

Yes please do, because I don't know what you would want changed :)

@jeffbaumes PTAL at  e55cd5887587fc41a271a30201dc42676f7d4b08 and let me know if that looks ok. If yes, I'll do the rest of the examples as well.

Looks great, go for it.

@jeffbaumes I changed the rest of the examples. Let me know if it looks good and then I'll approve the PR.

Looks great, thanks! Your changes LGTM

Caught one more indent style fix in the getting started section.

Ah, thanks! I had meant to fix that stretch of example code but forgot.


Improved testing options

Improved version of #286
Changes:

Allows you to run: npm run test:e2e -- --browser=chrome --metric=TTFB.
Adds a precommit test for any stray it.only's or browser.debug's left around.
Adds instructions to contributing file.
Moves Code of Conduct and Contributing files to more commonly known locations to make them easier to find.

Closing in favour of #460


CLI args

Motivation
Out of the box, LeakGAN does not work when specified through main.py. Instead, an error occurs that TensorFlow flags doesn't know how to parse argument 'g'. This is due to the fact that main.py parses arguments with getopt, but the LeakGAN constructor uses tf.app.flags.
Changes
To get LeakGAN to work properly, I modified main.py to also utilize tf.app.flags. Since these flags are intended to be global and distributed, it's perfectly legal to have flags specified in different parts of the system (i.e. LeakGAN specific args only in the LeakGAN constructor). The overall functionality is identical, with the exception that main.py args need to use their longform version (e.g. --gan_type instead of just -g).
Additionally, I factored out the definitions of the test_file, oracle_file, and generator_file to the Gan class (since they were used by every GAN type), and made them able to be specified by CLI args as well.

Additionally, this fixes a bug in the current implementation, in which the -h command states, that you should use "-t realdata", while it's "-t real" instead.

the args defined in leakGan's constructer can not  be use as this method.


OCPBUGS-33377: Modify token secret MCS hash in place

We are relying on .image and .proxy here to trigger upgrades and create a new tokenSecret https://github.com/openshift/hypershift/pull/3714/files#diff-c666a2a9dc48b0d3de33cc8fa3a054f853671f0428f9d56b263750dfc6d26e00R266
but then we use the whole .config for the hash in the token and mcs secret https://github.com/openshift/hypershift/pull/3795/files#diff-681fe9efe998da46c20a41e51c975bac6a9b14e93b7705f40da204d30a0ddebcR49.
Say a new NodePool is created or something triggers a rolling upgrade:
- A new token secret gets created.
- Before the ignition controllers watches it and can generate the payload, the hc.config changes to e.g. include an IDP.
- The MCS secret hc-configuration-hash is updated accordingly.
- The token secret hc-configuration-hash is not updated, because that only happens on token secret creation.
- The ignition controller tries to generate the payload and it fails perpetually with https://github.com/openshift/hypershift/pull/3795/files#diff-7cc71524ad99a2a526cceabd327a67c2767dc0c49e5c4aa8629ca88b0d205072R131
This will also be the case if the ignition server gets recreated by any reason (e.g. management cluster dataplane recycling), all the token secrets which e.g. hc.config.idp changed after they were created will fail to re-generate the payload forever.
This PR mitigates the discrepancy by letting the hash to be changed inplace in the token secret.
Follow up: Only set the hash based on the same input that triggers a new token secret creation.

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/hold
a bit

cc @sjenning

Hey @enxebre will this be backported to 4.16, 4.15 and 4.14?


Cow: Watch couponzatps.com

Cow requests the watch of the watch_keyword couponzatps\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

couponzatps\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Cody Gray in Charcoal HQ


Remove octoprint Recv: message

When copying the gcode output directly from the Octoprint terminal, there's an additional "Recv:  " message prepended to the MBL output. This PR trims that text

Works great, thanks.


[TASK] Add network selection component and implement network-based page access in Tangle dApp

Overview
Currently, the tangle-dapp connects to the Tangle Testnet by default. However, we should enable users to connect to various networks, including:

Tangle Mainnet
Tangle Testnet
Custom Endpoint

To implement this, consider using the network selection component from the stats-dapp as a reference. This component allows users to input custom endpoints and connect to either the Tangle Mainnet or Testnet.

Additionally, we should implement network-based access restrictions for certain pages on the tangle-dapp, depending on the user's selected network. For example, the Restaking feature should be available on the Testnet but not on the Mainnet for now. This restriction can be enforced by displaying a Not Supported modal.

Checklist

[ ] Add Network Switch Component: using the network selection component from the stats-dapp  to allow users to input custom endpoints and connect to either the Tangle Mainnet or Testnet.
[ ]  Implement Non-Supported Modal: Create a user-friendly modal to inform users when a feature is not available on their current network.
[ ] Identify Features/Pages for Gating: List features/pages that should be gated on specific networks.

The UI here in the issue should be updated CC @monaiuu

Updated Handoff
Update network switching feature, allowing users to seamlessly toggle between mainnet, testnet, and a custom RPC endpoint.
Reference: For an example of a similar implementation, see the network switch component at app.webb.tools.
Custom Endpoint Flow

Step 1: The user interacts with the network switch component, which displays three options: Mainnet, Testnet, and Development.
Upon selecting "Development," a dropdow input field is triggered for the user to input their RPC URL.

Step 2: The user enters the RPC endpoint URL into the input field and submits it for validation.

Step 3: Feedback and Error Handling

If Valid: Update UI to reflect the switch to Custom Endpoint, and proceed to switch the network connection to use the provided custom RPC endpoint.
If Invalid or Unresponsive: Provide the user with an error message indicating the failure to connect or validate the RPC endpoint.

@yurixander I also updated the above comment to completely hide Service Overview and Restake pages from the side navigation so it is not accessible for public for launch. Only if connected to development would these pages be accessible.

Gate Service Overview & Restake: Remove Service Overview Page & Restake Page from side navigation. Only if user is in development would this be accessible.

Will be handling this on a separate issue.


[Bug] testimonial UI broken with additional img

https://lifesciences.danaher.com/us/en/blog/organoid-expansion-business-outgrows-incubator.html - Actual (PROD)

https://stage.lifesciences.danaher.com/us/en/blog/organoid-expansion-business-outgrows-incubator.html - Cuurent page STAGE (Broken)

@dave-nichols - is this the bug ? or expected behavior ? please confirm.
CC: @mhaack

Closing this task as it is expected behavior.


Routing endpoint to right controller

Exists endpoints:
/Cards/{code}/Transactions
/Transactions
/Users/{id}/Transactions
Problem: When is called endpoint /Users/{id}/Transactions, than is executed controller for /Transactions.
IMHO: This commit is solution, but I may be don't see other possible problems from this change.

Can you please open MR in https://github.com/contributte/apitte repository?

Can you please open MR in https://github.com/contributte/apitte repository?

Created new MR https://github.com/contributte/apitte/pull/185


[Hub Generated] Publish private branch 'ssivathas/mobilenetwork-fix-plurality'

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/10288

This PR as already been approved in https://github.com/Azure/azure-rest-api-specs-pr/pull/10288.
To deal with the breaking SDK changes we will re-request SDK generation. This API version just got released and there are no customers using the SDKs yet so we want to get theses breaking changes in now.

@msyyc do you need anything from me to merge this PR? The ARM review board has already approved the breaking changes in https://github.com/Azure/azure-rest-api-specs-pr/pull/10288.

Hi @qiaozha @ArcturusZhang @tadelesh Could you help review SDK breaking?

Hi @msyyc @qiaozha @ArcturusZhang @tadelesh can you provide an update on this PR please? When can it be merged?

@sathiyan-sivathas Since the breaking changes have not been approved in private repo PR, you need to do the breaking change review first.

Hi @msyyc @qiaozha @ArcturusZhang @tadelesh, I have received breaking change approval on this PR. Can you merge the PR please? I will retrigger SDK generation as soon as this PR is merged.


GLES extensions not equivalent to GL extensions

Attention @pantosj .
In gl_common.h there are a few equivalencies defined so that certain GLES-specific extensions act like the GL/ARB extension is available.
I ran into a crash because the GL code was checking for HasExt[ARB_viewport_array] then trying to call glGetFloati_v to fetch the current viewport details. The device only provided NV_viewport_array though and so the function would only be available as glGetFloati_vNV. I think the same problem would happen with OES_viewport_array because it defines a glGetFloati_vOES version of the function.
What's the ideal solution here? I can see a few different possibilities but I don't know what is the correct fix.

Hi @baldurk  ! First of all I apologize for the late reply. We have not encountered this problem since none of these extensions are supported on our phones. I think a possible solution would be to overwrite the affected function pointers with their OES or NV versions, for example in the gl_emulated.cpp, after adding them to gl_hookset.h. But I'm afraid that similar problems can arise with other extensions too. Previously it seemed that the non-suffixed functions always exist, but apparently this is not the case.
What are your possible solutions to this problem?

My ideas may not be valid. I thought either one:

Set up glGetFloati_vNV and glGetFloati_vOES as aliases of glGetFloati_v, like glGetFloati_vEXT is. This should still favour the non-extension version of the function, but if it's missing and one of the ext functions is present it will use it. I think this is similar to what you describe doing in gl_emulated.cpp. However this is only OK to do if these functions really are 100% interchangeable. This would need to also apply to the other functions.
Remove the EXT_COMP_CHECK(ARB_viewport_array, NV_viewport_array) if they aren't equivalent. E.g. if those extensions don't provide the other parts of ARB_viewport_array that are used like indexed scissor.

It kind of depends on if these extensions really are exactly the same, so we can just use their functions if present, or if they're really a bit different in which case it needs special handling. It looks to me like ARB_viewport_array == NV_viewport_array just with different function suffixes, so the first option is probably OK here, but it makes me worry about the other EXT_COMP_CHECK checks too to know if the extension checks are really equivalent or not.

In addition to PR #710 I also reviewed the EXT_COMP_CHECK and HasExt[..] checks and compared the affected extensions again. In many cases these are the same, or if there are differences, they are treated in the right place. I do not think that the compatibility problem could be solved better than currently.


Comment on: Server Configuration

configuration.md

Enter your comment here:
Hi its important to mention that after having configured both the webserver and rest server in the settings area for the new settings to take affect you must quit and restart 4d or your calls will get this error in the response.
{"__ERROR":[{"message":"REST login failed","componentSignature":"dbmg","errCode":1822}]}

We added a note, thanks


Fix error when dragging anchors with parent's size == 0

Fixes #41212

Thanks!

Cherry-picked for 3.2.4.

I am seeing this error in version 4.1.1 when trying to drag anchors on a panel.
scene/gui/control.cpp:856 - Condition "parent_rect_size.x == 0.0" is true.
I can change through transform without getting this error.

@ysfdc This PR is 3 years old and for an entirely different version of the engine. Please open a new bug report and describe how you're reproducing the issue.


Firefox 61 JS DDNs

As a Web developer I want to know about the latest JavaScript features in Firefox 61, so that I can test and make use of new technologies.

[ ] Implement String.prototype.trimStart and String.prototype.trimEnd

All done :)

Not sure why this was re-opened. I think it is done.


Fixed CSS issue of testimonials section not responsive in screens low…

…er than 768px and tidied up code
Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed!
Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

What issue does this fix?.
Testimonials Section is not Responsive in screens lower than 768px
https://github.com/zero-to-mastery/Keiko-Corp/issues/976
Summarize what this PR fixes:-
I set the width of the #testimonial-carousel .carousel-item to 80% and adjusted the margins, so they don't add up to over 100%. Also I removed some extra margins on this element which were causing issues.
What ISSUE NUMBER does this fix?
Testimonials Section is not Responsive in screens lower than 768px #976
https://github.com/zero-to-mastery/Keiko-Corp/issues/976
Fixes #
Fixed the testimonial section not responding on screens smaller than 768px.
Checklist
(Add an x between the brackets to check the items)

[x] I have summarize what this PR fixes above
[x] I have provided the issue ID/URL above
[x] I have not added Bootstrap or jQuery and used correct styling guide.
[x] This PR fixes only the issue mentioned above (create separate PRs for separate issues)
[x] I was the first one to claim the issue or I created the issue - I created the issue

I've just seen that this ticket wasn't open for someone to claim, my apologies, I'll close this MR.

Is it okay to get merged in, as I don't think this issue was resolved fully.

Hi :) is it possible for you to add the "hacktoberfest-accepted" label to this as it's showing up as "pending" in my Hacktoberfest Profile


Fixing SCSS

Was getting an error on my version of SASS Rails (4.0.5)

That won't fix anything, your change will output this CSS code
.cookies-eu.content-holder {
  display: inline-block;
  padding: 0 20px;
}

And this is what we want
.cookies-eu .cookies-eu-content-holder {
  display: inline-block;
  padding: 0 20px;
}

We need to have the .cookies-eu-content-holderchild that exists only when his parent is applied too (.cookies-eu)
I assume that you have problem with the & &-content-holder operator because that didn't exist in SASS Rails (4.0.5), will update the SCSS file without them, tnx :)


bad request when try to retrieve s3 file

Describe the bug
Bad request 400 when try to retrieve from external source (s3 bucket)
To Reproduce
Steps to reproduce the behavior:

s3/ec2 setups:

Setup CORS on s3 bucket to grant GET permission from ec2 instance
Grant ec2 permission to access s3 bucket (AWS security roles)

web

setup s3 source on Tasks
Start labeling

Expected behavior
Retrieve and display audio file
Screenshots

Environment (please complete the following information):

OS: docker image running on ubuntu 20.04 aws server. Archlinux as client
Browser Firefox/Chrome
Version docker latest (0.7.3)

Additional context
By default, the bucket is blocking all public request, but i tested if making it public solve the issue but it persists

I think it relates with the signature parameter on the generated url.  The structure is:
https://BUCKET.s3.amazonaws.com/path/to/file/filename?AWSAccessKeyId=AWS_ACCESS_KEY_ID&Signature=SIGNATURE&Expires=EXPIRATION
When I remove it, it works (now I'm testing using my bucket public, so maybe it's not required?). Could it be that the signature generation has something wrong?
Here are the signature and url generation docs: https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-query-string-auth.html

Had the same issue. Turns out it is indeed the default boto signature generation that doesn't work on all regions (new regions, introduced after 2014).
Way to reproduce: use a bucket in e.g. eu-central. Images do not load as a result.
I submitted a merge request with the change that fixed it for me: https://github.com/heartexlabs/label-studio/pull/402.
Additionally, you may have to create a ~/.aws/config file to set the region the bucket is in.
Example:
[default]
region=eu-central-1

Had the same issue. Turns out it is indeed the default boto signature generation that doesn't work on all regions (new regions, introduced after 2014).
Way to reproduce: use a bucket in e.g. eu-central. Images do not load as a result.
I submitted a merge request with the change that fixed it for me: #402.
Additionally, you may have to create a ~/.aws/config file to set the region the bucket is in.
Example:
[default]
region=eu-central-1

Thank you for the fix, I was having the same issues.
I checkout out release/0.7.5 and it kept failing for me.
Only after setting .aws/config file it finally started showing images.
My config file looks as follows
maxim@maxim-ThinkPad-E480:~$ cat ~/.aws/config
[default]
region=us-east-2

I wonder if label-studio should recommend setting this as best practice, I'd be a bit cautious here as it's a system-wide setting that might break other stuff for the user.
Maybe a better option would be to automatically retrieve the location and then apply the region for a newly established AWS connection?
https://stackoverflow.com/a/34811723

@maximveksler May you create a PR with auto region selection?

We described possible solutions here:
https://labelstud.io/guide/storage.html#CORS-and-access-problems


[BUG] Unknown object types PyComplexObject, incomplete types PyTypeObject, PyLongObject when use -DCYTHON_LIMITED_API

Describe the bug
Use undefined objects when -DCYTHON_LIMITED_API enabled.
cython_ydb_extension.c:2067:75: error: unknown type name ‘PyComplexObject’; did you mean ‘PyCodeObject’?
 2067 | static CYTHON_INLINE double __pyx_f_7cpython_7complex_7complex_4real_real(PyComplexObject *__pyx_v_self); /* proto*/
      |                                                                           ^~~~~~~~~~~~~~~
      |                                                                           PyCodeObject

...
cython_ydb_extension.c:6154:10: error: invalid application of ‘sizeof’ to incomplete type ‘PyTypeObject’ {aka ‘struct _typeobject’}
 6154 |   sizeof(PyTypeObject), __PYX_GET_STRUCT_ALIGNMENT_3_1_0a0(PyTypeObject),
      |          ^~~~~~~~~~~~

...
cython_ydb_extension.c:921:38: error: invalid application of ‘sizeof’ to incomplete type ‘PyLongObject’ {aka ‘struct _longobject’}
  921 | #define PyBoolObject                 PyLongObject
      |                                      ^~~~~~~~~~~~

Code to reproduce the behaviour:
https://github.com/rekby/ydb-c/blob/753186e99f165cfaeb3f7c8c48a192634dc661d2/cython_ydb_extension/cython_ydb_extension.pyx
Expected behaviour
compile the module fine (it is compiled without -DCYTHON_LIMITED_API)
OS
linux
Python version
3.10.12
Cython version
3.1.0a0 (commit 72221faa1362c4c5b2fa1d8b4ba1a195e97a5c5f)
Additional context
The problem existed at 3.0.10 too.

Duplicate of https://github.com/cython/cython/issues/5634

The Limited API on Cython 3.0 isn't useable for anything non-trivial.
On Cython 3.1 we intend to support a lot (but not everything). However right now, many of the changes aren't yet merged. If you want to test out the pending changes (or the understanding that it's an unreviewed testing branch) then look at https://github.com/cython/cython/issues/6082


Remove logShowMoreSmartSnippetSuggestion and logShowLessSmartSnippetSuggestion

https://coveord.atlassian.net/browse/KIT-1614
This is technically breaking if somebody is already using it, but it's so recent that it's very unlikely. If you're too worried about the breaking change, I can close this PR.

Just check whether the breaking change has been released in prod. If we did release it, then just deprecate it

Just check whether the breaking change has been released in prod. If we did release it, then just deprecate it

We did (at-least in NPM), I'll deprecate it then.


Can't get the console_test GUI to work (AEGHB-19)

I flashed my ESP32 WROOM with the firmware in get-started/csi_rev_router and it all seems to be working perfectly fine.
Then, I followed the instructions in https://github.com/espressif/esp-csi/tree/master/examples/console_test (my case - only a single esp32). The flashing process finished without any errors, but the GUI does not show anything.
The log window is empty and the router doesn't show the device connected.
Since I'm not using the S3, I set the baud flag to 115200, but I also tried the example's 921600. Both didn't work.
Any tips to what I might be doing wrong?
Cheers,

After you use esp_csi_tool.py to run the GUI, you need to manually press EN on the ESP32 development board. This is because there is a bug in the ESP32 serial port. If you open the serial port through python without restarting the device, garbled characters will appear.

you need to manually press EN on the ESP32 development board

Doesn't work for me...
(esp32-wroom-32)

If you have CP210x, max baud rate will be 921600, not 2000000!
In examples/console_test/tools/esp_csi_tool.py, function serial_handle:
set baudrate to 921600.
In examples/console_test/sdkconfig.defaults:
change all baud rates from 2000000 to 921600.
Also, you may have to do in examples/console_test/main/app_main.c:
#define LED 2

//static led_strip_t *g_strip_handle    = NULL;

esp_err_t led_init()
{
    // Configure pin
    gpio_config_t io_conf;
    io_conf.intr_type = GPIO_PIN_INTR_DISABLE;
    io_conf.mode = GPIO_MODE_OUTPUT;
    io_conf.pin_bit_mask = (1ULL << LED);
    io_conf.pull_down_en = 0;
    io_conf.pull_up_en = 0;
    gpio_config(&io_conf);

    gpio_set_level(LED, 1);
    vTaskDelay(500 / portTICK_RATE_MS);
    gpio_set_level(LED, 0);
    return ESP_OK;
}

esp_err_t led_set(uint8_t red, uint8_t green, uint8_t blue)
{
    gpio_set_level(LED, 1);
    vTaskDelay(100 / portTICK_RATE_MS);
    gpio_set_level(LED, 0);

    return ESP_OK;
}

After the above procedures, everything began to work for me!

@zenbooster Thank you very much for finding the root cause of this issue, I will fix it in the next version

@zenbooster sir,I set the baud rate as you instructed.in examples/console_test/main/app_main.c:  should I add your code  here, or delete the original and write it directly as this?

Sorry for the long absence.
@zenbooster thanks for the explanations, I can confirm that it's working now.
(I replaced the original c code with your code).
Ok to close.
Cheers,

Hello, @idofr
Closing this issue, feel free to reopen with more updates. Thanks.


Leverage service config for health endpoint

See https://github.com/edgexfoundry/edgex-go/pull/2401

No health endpoints exists at individual service level; health status is available solely via go-mod-registry.  Closing without further action.


 The flatten flag needs to be passed through convert_enum in irgen::emitConstantValue.
Fixes a compiler crash.
rdar://113942221

@swift-ci smoke test windows

@swift-ci smoke test windows


Refresh Token

Can anyone get the refresh token?
// create google client object
$client = new Google_Client();
$client->setClientId($client_id);
$client->setClientSecret($client_secret);
$client->setRedirectUri($redirect_url);
$client->setAccessType('offline');
$client->setScopes(array('https://www.googleapis.com/auth/drive'));

// get token
if (isset($_GET['code'])) {
	$client->authenticate($_GET['code']);
	$_SESSION['token'] = $client->getAccessToken();
	$_SESSION['token_start_time'] = time();
	header('Location: '.$redirect_url);
	exit;
}

The token I got didn't included the refresh token. And I try to call $client->revokeToken($_SESSION['token']). It doesn't revoke the the token.

Are you sure you're not overriding your $_SESSION object somewhere? Could you paste in a working, complete code example we can use to verify?

I noticed the same issue when re-running the auth process.
On the second run through of
 $client->authenticate($_GET['code']);

will return an access token but fail to give you a refresh token as requested.
This seems to be because you haven't manually revoked the token through the google account/security settings (https://security.google.com/settings/security/permissions).

Shouldn't need to be a revoke, but it could well be because the user was signed in without a consent screen - for 2nd and future sign ins the consent screen may be skipped and the refresh token not returned. You can trigger a consent screen with the prompt parameter, which should result in a refresh token.


Important note for dataset generation!

Hi,
"python -m piper_train.preprocess" is not enable to treat double quote ("), maybe single quote too.
The preprocess is ended with Ok, but in the stage of training it's stopped by "RuntimeError: CUDA out of memory. ..."  error.
Be careful!
I lost a hug time to discover and fix this problem.

Hi @ican24,
You can down the batch size, according to your dataset size.

Yes, surely, but it significantly slows the machine learning: 4-8 times.
More easy to remove quotes.

Could you please elaborate on the problem, our dataset has many quote " and I'm not sure what is the problem with it?

I am trying to fix the problem with commands
sed -i 's/"//g' metadata.csv
sed -i 's/”//g' metadata.csv
sed -i 's/“//g' metadata.csv

The quotes are meaningless in TTS.
Maybe you need to add other commands too in your case.
Those fixed my problem and I went ahead.

I mean why do quotes cause Cuda OOM, is there parsing problem with training code but not preprocessing?...

It is hard to say. I am not Deep Learning programmer. It needs to carefully analyze the existing code.

If your meta csv file has a line with only one quote, the csv reader will continue to read the next lines until it find the next quote, so several lines will be merged into one, creating a huge line and cause memory overflow. This should be fix be setting quotechar to None in this line: https://github.com/rhasspy/piper/blob/master/src/python/piper_train/preprocess.py#L421 i.e rd = reader = csv.reader(csv_file, delimiter="|", quotechar=None)


⚠ Spryr has degraded performance

In d0ffda1, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 3782 ms

Resolved: Spryr performance has improved in 597ed82 after 7 minutes.


ceph-salt barfs out a Traceback when Salt gets "Valid metadata not found at specified URL" error from zypper

When repos are not fresh (and sometimes even when they are), zypper occasionally throws a "valid metadata not found at specified URL" error. Salt and ceph-salt could handle this more gracefully than they do now:
    master: Starting the execution of: salt -G 'ceph-salt:member' state.apply ceph-salt
    master: [2020-04-30 18:28:47.269958] [node2.octopus-4n] [STAGE] [BEGIN] Distribute SSH keys
    master: [2020-04-30 18:28:47.305720] [node2.octopus-4n] [STAGE] [END  ] Distribute SSH keys
    master: [2020-04-30 18:28:47.310786] [node2.octopus-4n] [STAGE] [BEGIN] Install and update required packages
    master: [2020-04-30 18:28:47.367788] [node1.octopus-4n] [STAGE] [BEGIN] Distribute SSH keys
    master: [2020-04-30 18:28:47.372835] [node3.octopus-4n] [STAGE] [BEGIN] Distribute SSH keys
    master: [2020-04-30 18:28:47.375437] [node1.octopus-4n] [STAGE] [END  ] Distribute SSH keys
    master: [2020-04-30 18:28:47.378390] [node1.octopus-4n] [STAGE] [BEGIN] Install and update required packages
    master: [2020-04-30 18:28:47.384565] [node3.octopus-4n] [STAGE] [END  ] Distribute SSH keys
    master: [2020-04-30 18:28:47.388160] [node3.octopus-4n] [STAGE] [BEGIN] Install and update required packages
    master: [2020-04-30 18:28:47.700442] [master.octopus-4] [STAGE] [BEGIN] Distribute SSH keys
    master: [2020-04-30 18:28:47.711976] [master.octopus-4] [STAGE] [END  ] Distribute SSH keys
    master: [2020-04-30 18:28:47.716377] [master.octopus-4] [STAGE] [BEGIN] Install and update required packages
    master: [2020-04-30 18:29:08.774148] [node2.octopus-4n] Finished with failures
    master:
    master: Failure in minion: node2.octopus-4node.com
    master: __id__: install required packages
    master: __run_num__: 9
    master: __sls__: ceph-salt.software
    master: changes: {}
    master: comment: "An exception occurred in this state: Traceback (most recent call last):\n\
    master:   \  File \"/usr/lib/python3.6/site-packages/salt/state.py\", line 1987, in call\n\
    master:   \    ret = self.states[cdata['full']](*cdata['args'], **cdata['kwargs'])\n  File\
    master:   \ \"/usr/lib/python3.6/site-packages/salt/loader.py\", line 2030, in wrapper\n \
    master:   \   return f(*args, **kwargs)\n  File \"/usr/lib/python3.6/site-packages/salt/states/pkg.py\"\
    master:   , line 1606, in installed\n    pkgs, refresh = _resolve_capabilities(pkgs, refresh=refresh,\
    master:   \ **kwargs)\n  File \"/usr/lib/python3.6/site-packages/salt/states/pkg.py\", line\
    master:   \ 944, in _resolve_capabilities\n    ret = __salt__['pkg.resolve_capabilities'](pkgs,\
    master:   \ refresh=refresh, **kwargs)\n  File \"/usr/lib/python3.6/site-packages/salt/modules/zypperpkg.py\"\
    master:   , line 2797, in resolve_capabilities\n    refresh_db(root)\n  File \"/usr/lib/python3.6/site-packages/salt/modules/zypperpkg.py\"\
    master:   , line 1300, in refresh_db\n    out = __zypper__(root=root).refreshable.call('refresh',\
    master:   \ '--force')\n  File \"/usr/lib/python3.6/site-packages/salt/modules/zypperpkg.py\"\
    master:   , line 351, in __call\n    raise CommandExecutionError('Zypper command failure:\
    master:   \ {0}'.format(self.error_msg))\nsalt.exceptions.CommandExecutionError: Zypper command\
    master:   \ failure: Signature verification failed for file 'repomd.xml' from repository 'octopus-repo1'.\n\
    master:   Repository 'octopus-repo1' is invalid.\n[octopus-repo1|https://download.opensuse.org/repositories/filesystems:/ceph:/octopus:/upstream/openSUSE_Leap_15.2]\
    master:   \ Valid metadata not found at specified URL\nHistory:\n - Signature verification\
    master:   \ failed for repomd.xml\n - Can't provide /repodata/repomd.xml\n\nPlease check if\
    master:   \ the URIs defined for this repository are pointing to a valid repository.\nSkipping\
    master:   \ repository 'octopus-repo1' because of the above error.\nSome of the repositories\
    master:   \ have not been refreshed because of an error.\n"
    master: duration: 14717.992
    master: name: install required packages
    master: result: false
    master: start_time: '20:28:53.730077'
    master: state: pkg_|-install required packages_|-install required packages_|-installed
    master: [2020-04-30 18:29:08.913287] [node1.octopus-4n] Finished with failures

properly formatted:
An exception occurred in this state: Traceback (most recent call last):

  File "/usr/lib/python3.6/site-packages/salt/state.py", line 1987, in call
    ret = self.states[cdata['full']](*cdata['args'], **cdata['kwargs'])
  File "/usr/lib/python3.6/site-packages/salt/loader.py", line 2030, in wrapper
    return f(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/salt/states/pkg.py", line 1606, in installed
    pkgs, refresh = _resolve_capabilities(pkgs, refresh=refresh, **kwargs)
  File "/usr/lib/python3.6/site-packages/salt/states/pkg.py", line 944, in _resolve_capabilities
    ret = __salt__['pkg.resolve_capabilities'](pkgs, refresh=refresh, **kwargs)
  File "/usr/lib/python3.6/site-packages/salt/modules/zypperpkg.py", line 2797, in resolve_capabilities
    refresh_db(root)
  File "/usr/lib/python3.6/site-packages/salt/modules/zypperpkg.py", line 1300, in refresh_db
    out = __zypper__(root=root).refreshable.call('refresh', '--force')
  File "/usr/lib/python3.6/site-packages/salt/modules/zypperpkg.py", line 351, in __call
    raise CommandExecutionError('Zypper command failure:

salt.exceptions.CommandExecutionError: Zypper command
 failure: Signature verification failed for file 'repomd.xml' from repository 'octopus-repo1'.

 Repository 'octopus-repo1' is invalid.

 [octopus-repo1|https://download.opensuse.org/repositories/filesystems:/ceph:/octopus:/upstream/openSUSE_Leap_15.2]
 Valid metadata not found at specified URL
History:
 - Signature verification
 failed for repomd.xml
 - Can't provide /repodata/repomd.xml

Please check if the URIs defined for this repository are pointing to a valid repository.
Skipping repository 'octopus-repo1' because of the above error.
Some of the repositories have not been refreshed because of an error.

More fun with the Salt Zypper module!


v8: Fix - Add additional package namespaces to the driver chain.

Additional package namespaces are now registered automatically into the driver chain. Now the c5 migration tool works.
There are still two open questions.

$pkgAutoloaderMapCoreExtensions is set in the migration tool to true. If I handle the mapping information the same as the ClassLoader does, say Concrete\\Package\\MigrationTool maps to /packages/migration_tool/src/Concrete the package isn't installed properly. Are there other packages out there, which use $pkgAutoloaderMapCoreExtensions=true?
The mapping paths are stored as absolute paths in config/database.php. This can generate problem if the web page is moved. Shall I change the absolute paths to relative paths? (If so, every mapping path has to be prepended during bootstrap.) Any preferences?

#3693

Thanks. Will check it out soon. Our preference is definitely to not store absolute paths - we have always liked that a concrete5 site is relatively easily moved from one host to another without modifying database or config entries

Regarding your first question – There are other classes using $pkgMapCoreExtensions, but I'm not sure if any entities will be found in that packages/your_package/src/Concrete namespace. I suppose it's possible.. ?

I have merged this pull request – but let's make sure to get any other outstanding updates into this branch quickly. Thanks for your work on this! Also, I've updated the core so that all entity objects are contained within src/Entity, which should speed things up when not using the cache.

I've made a new pull request concerning the relative paths.

To keep all comments in one place, I'll post my questions here. By the way, the change with moving all entity objects to src/Entity made the site significantly faster.
My solutions concerning the pkgAutoloaderMapCoreExtensions = true didn't work out yet. I think, I haven't understood the issue yet entirely.
How would the namespace of an entity in a package named "example" with property pkgAutoloaderMapCoreExtensions = true be set?
Concrete\Core\Entity\Example\TestEntity, Concrete\Entity\Example\TestEntity or Concrete\Package\Example\Src\SomeFolders\TestEntity?

I couldn't find one concrete5 package on Github which uses $pkgAutoloaderMapCoreExtensions = true. So, I think we can ignore this special case for now until the specifications are clearer. Any thoughts on this?

The concrete5 calendar package in v8 (which isn't publicly available) uses entities within this special namespace. We put attributes within the Entity namespace, found in the src/Concrete folder.
In general, if this boolean is set to true, the entity path would then be
Concrete\Package\YourPackage\Entity\Whatever\MyEntity.php
and the path to the entity would be packages/your_package/src/Concrete/Entity/Whatever/MyEntity.php

OK. So it's basically just an additional source path for the default package namespace.

Yes. It maps into src/Concrete . It's a pain that it's so complicated but we botched namespaces on the release of 5.7 and have to do it this way for backward compatibility concerns.


The app does not support Chinese, resulting in Chinese characters being displayed as garbled text.

Duplicate of https://github.com/go-vikunja/app/issues/82


fix: ignore no_index around OfNat.ofNat in norm_cast

This PR ensures norm_cast doesn't fail to act in the presence of no_index annotations
While leanprover/lean4#2867 exists, it is necessary to put no_index around OfNat.ofNat in simp lemmas.
This results in extra Expr.mdata nodes, which must be removed before checking for ofNat numerals.

This should fix the build error in https://github.com/leanprover-community/mathlib4/pull/20169


Getting a key from KeyVault. UnhandledPromiseRejectionWarning: RestError: AKV10032: Invalid issuer. Expected one of ..

Package Name:  @azure/keyvault-secrets, @azure/identity"
Package Version: ^4.1.0
Operating system: MacOS
[x] nodejs

version: 12.7.0

[ ] browser

name/version:

[ x] typescript

version: 3.8.2

Is the bug related to documentation in

[ ] README.md
[ ] source code documentation
[ ] SDK API docs on https://docs.microsoft.com

Describe the bug
I was following the docs how to reading key-valut in NodeJs+TS
https://docs.microsoft.com/en-gb/javascript/api/overview/azure/keyvault-keys-readme?view=azure-node-latest
After following the steps in create KV, assign SP, and access policy and running example I get an error. This one looks like Authentication problem.
RestError: AKV10032: Invalid issuer. Expected one of ... - found https://sts.windows.net/1ff9bcf8-6255-4717-b.../.
$: node index.js
(node:11788) UnhandledPromiseRejectionWarning: RestError: AKV10032: Invalid issuer. Expected one of https://sts.windows.net/72f988bf-86f1-.../, https://sts.windows.net/f8cdef31-a31e-4.../, https://sts.windows.net/e2d54eb5-3869-4.../, https://sts.windows.net/33e01921-4d.../, https://sts.windows.net/975f013f-7f24-47.../, found https://sts.windows.net/1ff9bcf8-6255-4717-b.../.
    at new RestError (/~/nodejs-key-vault/node_modules/@azure/core-http/dist/index.js:2387:28)
    at handleErrorResponse (/~/nodejs-key-vault/node_modules/@azure/core-http/dist/index.js:3238:17)
    at /~/nodejs-key-vault/node_modules/@azure/core-http/dist/index.js:3177:18
    at processTicksAndRejections (internal/process/task_queues.js:85:5)
(node:11788) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
(node:11788) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

follow - https://docs.microsoft.com/en-gb/javascript/api/overview/azure/keyvault-keys-readme?view=azure-node-latest - 'Getting a key' section

run

const { DefaultAzureCredential } = require("@azure/identity");
const { KeyClient } = require("@azure/keyvault-keys");

const credential = new DefaultAzureCredential();

const vaultName = "<YOUR KEYVAULT NAME>";
const url = `https://${vaultName}.vault.azure.net`;

const client = new KeyClient(url, credential);

const keyName = "MyKeyName";

async function main() {
  const latestKey = await client.getKey(keyName);
  console.log(`Latest version of the key ${keyName}: `, latestKey);
  const specificKey = await client.getKey(keyName, { version: latestKey.properties.version! });
  console.log(`The key ${keyName} at the version ${latestKey.properties.version!}: `, specificKey);
}

main();

Expected behavior
Login and display KV details
Screenshots
If applicable, add screenshots to help explain your problem.

Good day @shershen08 ! I'll be doing my best to help you.
Let's start with an indirect approach to see how far can we go. If you use the Azure CLI, are you able to run the following?
az login
az account set --subscription SUBSCRIPTION_ID
az keyvault key list --vault-name KEY_VAULT_NAME

If not, please reply with what error you see!
If you are able to execute the above, let's try the following:

Instead of DefaultAzureCredential, for the purpose of this test, please use DeviceCodeCredential. You will see something like the following in the terminal: To sign in, use a web browser to open the page https://microsoft.com/devicelogin and enter the code XXXXXXXXXX to authenticate.
Go to https://microsoft.com/devicelogin and enter the code that you received in the console message.
After that, the program should work!

Please let me know if this doesn't work. I'll keep my eyes on this issue so that I can reply as soon as possible.

Thanks for the details @sadasant
Indeed when running with DeviceCodeCredential
I get authentication window, but then another error - see:
$: node index.js
To sign in, use a web browser to open the page https://microsoft.com/devicelogin and enter the code XXXXXX to authenticate.  <---- this part is good

(node:38286) UnhandledPromiseRejectionWarning: RestError: Access denied to first party service.
Caller: name=from-infra;tid=f8cdef31-a31e-4b4a-93e4-XXXXXXX; appid=04b07795-8ddb-461a-bbee-XXXXXXXX; iss=https://sts.windows.net/f8cdef31-a31e-4b4a-93e4-XXXXXXX/
Vault: MY_VAULT_NAME_HERE;location=francecentral

@shershen08 Did the CLI approach work? az keyvault key list --vault-name KEY_VAULT_NAME?
So far this seems to be a credentials issue. Identity is a bit weird to work with! (we're actively trying to make it better, but it will take some time).
Let's try something:

Follow this approach: https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/keyvault/keyvault-keys/test#aad-based-authentication
Once you have your Client ID, Tenant ID and the Secret, use the ClientSecretCredential instead of the DeviceCodeCredential, pass first the tenant ID, then the client ID, then the secret, like: let credential = new ClientSecretCredential("<AZURE_TENANT_ID>", "<AZURE_CLIENT_ID>", "<AZURE_CLIENT_SECRET>");.
Try again!

Do you get an error?
Please let me know both answers, the Azure CLI one and the ClientSecretCredential one. We'll get through this! 🙌

yes, approach with ClientSecretCredential using:
let credential = new ClientSecretCredential("<AZURE_TENANT_ID>", "<AZURE_CLIENT_ID>", "<AZURE_CLIENT_SECRET>");.

worked well, thanks @sadasant
via CLI also I could get details

@shershen08 thank you for your response! Good luck on your project and keep in mind that you're welcome here anytime 🌞


Update all.json

Retrospective Metamask fakes spotted in May that were not present in the list
Many have already been revoked.
Adding for completeness.
(I was on vacation, thus the no activity for a week).

checked against accidental flagging of good links with
https://github.com/MetaMask/eth-phishing-detect/blob/master/src/config.json

Not sure about the MM links at all. Since MM anyway does check them.

I guess Metamask users are natively protected "out of the box" by eth-phishing-detect  so it is a bit redundant to have them here as well.
(i.e. you have to have the plugin installed on the browser in order to be able to even use metamask in the first place, and the phish protection it is already baked in it)
I only added because there were already few MM entries present and committed and I decided it is OK to add more, but i didnt really think about the redundant "dual layer" of security being added on the wrong place.
Cheers.


[Decompiler] Implement IR2 Type Analysis Pass

Mostly the same as IR1's, but it's a little bit stricter on the use of inline assembly.  There were some things that "worked" in IR1, but weren't really correct. Now they fail completely which is better behavior.
The biggest change is that this now runs before the "structuring" pass, so some details are different from the old IR1 implementation.

Pull Request Test Coverage Report for Build 476505758

28 of 679 (4.12%)  changed or added relevant lines in 14 files are covered.
8 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.8%) to 57.839%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

common/type_system/TypeSystem.cpp
12
14
85.71%

decompiler/util/TP_Type.h
0
2
0.0%

decompiler/IR2/AtomicOp.h
0
3
0.0%

decompiler/IR2/AtomicOp.cpp
10
15
66.67%

decompiler/IR2/Env.cpp
0
5
0.0%

decompiler/util/TP_Type.cpp
0
6
0.0%

decompiler/IR2/Env.h
0
7
0.0%

decompiler/util/DecompilerTypeSystem.cpp
0
8
0.0%

decompiler/IR/IR_TypeAnalysis.cpp
0
45
0.0%

decompiler/Function/TypeAnalysis.cpp
0
48
0.0%

Files with Coverage Reduction
New Missed Lines
%

decompiler/IR2/AtomicOp.h
3
78.95%

decompiler/ObjectFile/ObjectFileDB_IR2.cpp
5
0%

Totals

Change from base Build 476181116:
-0.8%

Covered Lines:
21765

Relevant Lines:
37630

💛  - Coveralls

Pull Request Test Coverage Report for Build 476505758

28 of 679 (4.12%)  changed or added relevant lines in 14 files are covered.
8 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.8%) to 57.839%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

common/type_system/TypeSystem.cpp
12
14
85.71%

decompiler/util/TP_Type.h
0
2
0.0%

decompiler/IR2/AtomicOp.h
0
3
0.0%

decompiler/IR2/AtomicOp.cpp
10
15
66.67%

decompiler/IR2/Env.cpp
0
5
0.0%

decompiler/util/TP_Type.cpp
0
6
0.0%

decompiler/IR2/Env.h
0
7
0.0%

decompiler/util/DecompilerTypeSystem.cpp
0
8
0.0%

decompiler/IR/IR_TypeAnalysis.cpp
0
45
0.0%

decompiler/Function/TypeAnalysis.cpp
0
48
0.0%

Files with Coverage Reduction
New Missed Lines
%

decompiler/IR2/AtomicOp.h
3
78.95%

decompiler/ObjectFile/ObjectFileDB_IR2.cpp
5
0%

Totals

Change from base Build 476181116:
-0.8%

Covered Lines:
21765

Relevant Lines:
37630

💛  - Coveralls


Taking a photo upload a png instead of jpg

In FSSourceListViewController, after taking a photo the NSData is a png UIImagePNGRepresentation, but the extension added is .jpg. Since camera images don't have transparency, using UIImageJPEGRepresentation instead should allow uploading significantly faster. I tested and it's 2-3 times faster to upload using UIImageJPEGRepresentation at full quality.

Hi @cerupcat sorry for a late response, I was on vacation.
Thanks for the catch - I'll release new version with fix this week


Output of "flutter channel beta" when there's a hot fix pending is disturbing

I downloaded v1.4.9-hotfix.1-beta and tried to do flutter channel beta and the output was concerning:
ianh@ianh:~/dev/test-install$ tar xf flutter_linux_v1.4.9-hotfix.1-beta.tar.xz
ianh@ianh:~/dev/test-install$ cd flutter/
ianh@ianh:~/dev/test-install/flutter$ bin/flutter channel beta
  ╔════════════════════════════════════════════════════════════════════════════╗
  ║ A new version of Flutter is available!                                     ║
  ║                                                                            ║
  ║ To update to the latest version, run "flutter upgrade".                    ║
  ╚════════════════════════════════════════════════════════════════════════════╝

Switching to flutter channel 'beta'...
git: From https://github.com/flutter/flutter
git:  + 88fa7ea40...09cbc34a0 beta                    -> origin/beta  (forced update)
git:    6c7b6833c..0ba67226e  dev                     -> origin/dev
git:    6c7b6833c..514fb2c7c  master                  -> origin/master
git:  * [new branch]          revert-30339-tap-buttons -> origin/revert-30339-tap-buttons
git:    e9dd13d1a..5ae6952c0  revert-30873-revert-30414-remove-hover-pressure -> origin/revert-30873-revert-30414-remove-hover-pressure
git:  * [new branch]          revert-30951-roll_branch -> origin/revert-30951-roll_branch
git:  * [new branch]          revert-30991-caretheight -> origin/revert-30991-caretheight
git:  * [new branch]          revert-30995-revert_engine -> origin/revert-30995-revert_engine
git:  * [new branch]          revert-31736-roll_build -> origin/revert-31736-roll_build
git:  * [new branch]          revert-31801-revert-30339-tap-buttons -> origin/revert-31801-revert-30339-tap-buttons
git:  * [new branch]          v1.5.4-hotfixes         -> origin/v1.5.4-hotfixes
git:  * [new tag]             v1.5.0                  -> v1.5.0
git:  * [new tag]             v1.5.1                  -> v1.5.1
git:  * [new tag]             v1.5.2                  -> v1.5.2
git:  * [new tag]             v1.5.3                  -> v1.5.3
git:  * [new tag]             v1.5.4                  -> v1.5.4
git:  * [new tag]             v1.5.4-hotfix.1         -> v1.5.4-hotfix.1
git:  * [new tag]             v1.5.8                  -> v1.5.8
git:  * [new tag]             v1.5.5                  -> v1.5.5
git:  * [new tag]             v1.5.6                  -> v1.5.6
git:  * [new tag]             v1.5.7                  -> v1.5.7
git: Already on 'beta'
git: Your branch and 'origin/beta' have diverged,
git: and have 1 and 173 different commits each, respectively.
git:   (use "git pull" to merge the remote branch into yours)
ianh@ianh:~/dev/test-install/flutter$

As a user I don't know what to make of all this nonsense.
cc @jonahwilliams

@jonahwilliams, @Hixie
I reproduced this pulling to the beta repo that was last pulled on April 29.
I resolved conflicts by hand. Then thought a bit about causes. My hunch is that something was cherrypicked from the master then down the line rebased.
Of course doing manual resolves in such a huge repo might be out of reach for many less experienced Flutter newcomers. Worse, after manual merge the origin and local HEAD will diverge even if the files content is same (due to the commit message and timestamps going into the hash). So more voodoo is needed to get both into sync.
While it may feel innocent now, I think it is very serious situation mostly about one's trust in master's (google/github) upstream repo consistency. I suppose that most audience will be taught to rm -rf then to clone/reinstall again. I have no time to investigate it further, so I attach the diff from the malfunct then fixed repo. In hope it may hint you about root cause of this glitch.
Workaround
Checkout master, then pull, and only then update branches that are behind master.


Kubernetes Deployment failing with CNI "networkPolicy": "azure"

Is this a request for help?:
Yes
Is this an ISSUE or FEATURE REQUEST? (choose one):
ISSUE
Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)
Kubernetes
https://github.com/Azure/acs-engine/blob/master/examples/cni/kubernetes-azure.json
What happened:
Error:
Resource: k8s-master-41119652-0/cse0
Type: Microsoft.Compute/virtualMachines/extensions
StatusMessage:
{
"status": "Failed",
"error": {
"code": "ResourceDeploymentFailure",
"message": "The resource operation completed with terminal provisioning state 'Failed'.",
"details": [
{
"code": "VMExtensionProvisioningError",
"message": "VM has reported a failure when processing extension 'cse0'. Error message: "Enable failed: failed to execute command: command terminated with exit status=1"."
}
]
}
}
Azure Script Extension log:
+ /var/lib/waagent/Microsoft.Azure.Extensions.CustomScript-2.0.3/bin/custom-script-extension install
time=2017-06-12T11:40:14Z version=v2.0.3/git@f21ef81-clean operation=install seq=0 event=start
time=2017-06-12T11:40:14Z version=v2.0.3/git@f21ef81-clean operation=install seq=0 status="not reported for operation (by design)"
time=2017-06-12T11:40:14Z version=v2.0.3/git@f21ef81-clean operation=install seq=0 event="created data dir" path=/var/lib/waagent/custom-script
time=2017-06-12T11:40:14Z version=v2.0.3/git@f21ef81-clean operation=install seq=0 event=installed
time=2017-06-12T11:40:14Z version=v2.0.3/git@f21ef81-clean operation=install seq=0 status="not reported for operation (by design)"
time=2017-06-12T11:40:14Z version=v2.0.3/git@f21ef81-clean operation=install seq=0 event=end
Writing a placeholder status file indicating progress before forking: /var/lib/waagent/Microsoft.Azure.Extensions.CustomScript-2.0.3/status/0.status
+ nohup /var/lib/waagent/Microsoft.Azure.Extensions.CustomScript-2.0.3/bin/custom-script-extension enable
time=2017-06-12T11:40:15Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 event=start
time=2017-06-12T11:40:15Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 event=pre-check
time=2017-06-12T11:40:15Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 message="checking for state migration"
time=2017-06-12T11:40:15Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 message="no old state found to migrate"
time=2017-06-12T11:40:15Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 event="comparing seqnum" path=/var/lib/waagent/custom-script/seqnum
time=2017-06-12T11:40:15Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 event="seqnum saved" path=/var/lib/waagent/custom-script/seqnum
time=2017-06-12T11:40:15Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 event="reading configuration"
time=2017-06-12T11:40:15Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 event="read configuration"
time=2017-06-12T11:40:15Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 event="validating json schema"
time=2017-06-12T11:40:15Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 event="json schema valid"
time=2017-06-12T11:40:15Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 event="parsing configuration json"
time=2017-06-12T11:40:15Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 event="parsed configuration json"
time=2017-06-12T11:40:15Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 event="validating configuration logically"
time=2017-06-12T11:40:15Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 event="validated configuration"
time=2017-06-12T11:40:15Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 event="creating output directory" path=/var/lib/waagent/custom-script/download/0
time=2017-06-12T11:40:15Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 event="created output directory"
time=2017-06-12T11:40:15Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 files=0
time=2017-06-12T11:40:15Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 event="executing command" output=/var/lib/waagent/custom-script/download/0
time=2017-06-12T11:52:53Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 event="failed to execute command" error="command terminated with exit status=1" output=/var/lib/waagent/custom-script/download/0
time=2017-06-12T11:52:53Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 event="enable failed"
time=2017-06-12T11:52:53Z version=v2.0.3/git@f21ef81-clean operation=enable seq=0 event="failed to handle" error="failed to execute command: command terminated with exit status=1"

What you expected to happen:
Deployment to succeed
How to reproduce it (as minimally and precisely as possible):
Following values used to generate template:
"apiVersion": "vlabs",
"properties": {
"orchestratorProfile": {
"orchestratorType": "Kubernetes",
"kubernetesConfig": {
"networkPolicy": "azure"
}
},
"masterProfile": {
"count": 1,
"dnsPrefix": "udayk8sazure",
"vmSize": "Standard_D2_v2"
},
"agentPoolProfiles": [
{
"name": "agentpool1",
"count": 2,
"vmSize": "Standard_D2_v2",
"availabilityProfile": "AvailabilitySet"
},
{
"name": "agentpool2",
"count": 2,
"vmSize": "Standard_D2_v2",
"availabilityProfile": "AvailabilitySet"
}
],
Anything else we need to know:

Same here..

1

Can someone take a look at this?
Its currently a show stopper for many deployments..

@brendanburns - correct this is a duplicate of #561 - Outbound internet does not work with CNI plugin

Up until several days ago I was able to successfully deploy azure cni clusters. The deployment completed successfully along with the cse..
The outgoing internet issue happens without relation to the cluster deployment process.
The deployment should succeed.

Sorry but how does outbout internet connectivity has to do with this issue? Im unable to create a cni cluster at all, meaning the template development fail. this effectively means kube-cni is broken.

@anhowe look at what you wrote in #561  -
"To repro:

deploy a cluster with CNI
kubectl exec to the container, and try to access the internet from a container"

In this issue you can't even get past step 1.. the cluster itself doesn't deploy.
Seems like this isn't a dup..

Trying to debug this, I looked at the azure agent logs (since the error comes from the script extension) I couldn't find anything meaningful but I this I can guess that the agent is unable to download he script or one of its resources before executing, so it be related (still needs confirmation). BUT if it's indeed because of cni outbound internet issue, how did we expect the deployment to ever succeed? Also - this worked just couple of days ago

I just deployed a new cluster with CNI plugin and latest acs-engine. It works fine.

I can also confirm updating acs engine from 5/22 to latest works fine.

Spoke too soon :-(
Although deployment is not failing; Kubernetes is not getting installed either.
root@k8s-master-41119652-0:/var/lib/waagent/custom-script/download/0# kubectl version
Client Version: version.Info{Major:"1", Minor:"6", GitVersion:"v1.6.2", GitCommit:"477efc3cbe6a7effca06bd1452fa356e2201e1ee", GitTreeState:"clean", BuildDate:"2017-04-19T20:22:08Z", GoVersion:"go1.7.5", Compiler:"gc", Platform:"linux/amd64"}
The connection to the server localhost:8080 was refused - did you specify the right host or port?
root@k8s-master-41119652-0:/var/lib/waagent/custom-script/download/0# ls -alh
total 8.0K
drwx------ 2 root root 4.0K Jun 13 17:43 .
drwx------ 3 root root 4.0K Jun 13 17:43 ..
-rw------- 1 root root    0 Jun 13 17:43 stderr
-rw------- 1 root root    0 Jun 13 17:43 stdout

We need the logs for the waagent run, something went wrong, but it's hard to know what...

From: uday31in<EMAIL_ADDRESS>Sent: Tuesday, June 13, 2017 11:34:34 AM
To: Azure/acs-engine
Cc: Brendan Burns; Comment
Subject: Re: [Azure/acs-engine] Kubernetes Deployment failing with CNI "networkPolicy": "azure" (#752)
Spoke too soon :-(
Although deployment is not failing; Kubernetes is not getting installed either.
root@k8s-master-41119652-0:/var/lib/waagent/custom-script/download/0# kubectl version
Client Version: version.Info{Major:"1", Minor:"6", GitVersion:"v1.6.2", GitCommit:"477efc3cbe6a7effca06bd1452fa356e2201e1ee", GitTreeState:"clean", BuildDate:"2017-04-19T20:22:08Z", GoVersion:"go1.7.5", Compiler:"gc", Platform:"linux/amd64"}
The connection to the server localhost:8080 was refused - did you specify the right host or port?
root@k8s-master-41119652-0:/var/lib/waagent/custom-script/download/0# ls -alh
total 8.0K
drwx------ 2 root root 4.0K Jun 13 17:43 .
drwx------ 3 root root 4.0K Jun 13 17:43 ..
-rw------- 1 root root 0 Jun 13 17:43 stderr
-rw------- 1 root root 0 Jun 13 17:43 stdout
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Facs-engine%2Fissues%2F752%23issuecomment-308208291&data=02|01|bburns%40microsoft.com|c134c7ac114a406afaa908d4b28ad846|72f988bf86f141af91ab2d7cd011db47|1|0|636329756792510098&sdata=UgV74Ao4qiefv1VLwX8e784FnCXE1BJ%2B7Yi%2BIusBiBU%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFfDglVGLlMxKd4ebREMRa0Q9dX_ebVPks5sDtY6gaJpZM4N3BZt&data=02|01|bburns%40microsoft.com|c134c7ac114a406afaa908d4b28ad846|72f988bf86f141af91ab2d7cd011db47|1|0|636329756792510098&sdata=fdDW%2ByI8bQ08yxFm7zmZQ1yfhH%2BwwSvNgBs2VbWFgOY%3D&reserved=0.

I have deleted resource group but redeployment worked fine. Thanks for the help everyone!

i am facing this issue where provisioning state is successful but kubernetes is not installed

deleted resource group multple times and redeployed kubernetes with different versions as well but same result. Any help is appreciated.


Fischl burst is hitting twice

https://gcsim.app/v3/viewer/share/54b73216-3300-4365-8406-6eb64b14976b

the second hit has a much higher talent multiplier

Not a Bug. Thats her C4. Its just not properly named.

very well


Currently examples are not linked to the wordnets

I propose we add a macro or two:
Linked to omw 1.0 for now, but can change to omw 2.0 soon:
{%- macro pwn(name, key) -%}
{{ name }}
{%- endmacro %}
And maybe: for named ili links:
{%- macro ilin(name, symbol) -%}
⟪{{ name }}⟫
{%- endmacro %}
We could also think of trying to get the name with a language parameter from OMW in the future, not quite sure how, ...
@goodmami  does this look good to you?   I have some examples and would like to get a student to add them in, with links, ...

In general this looks good. We had some issue before with choosing a macro name that doesn't clash with other variables, etc. in the templates. As long as we're careful about that these should be fine.
And, forgive my ignorance, but are named ili links fundamentally different than non-named links, or is the name just optional? If the latter, then I think we can just use the current ili() macro but give it a name parameter with a default value.

I think this issue has been resolved?


zqd pcap post: delete cancel error message

Steps to reproduce:

Start a pcap post (zapi -s myspace pcappost -f /pcapfile)- preferably some pcapfile large enough to take zeek sometime to churn through
Wait till the api starts returning stats on the ingest process (this means that pcap index is complete and zeek has started)
Issue a delete command on the space (zapi rm myspace)

Observe that the return error message is "zeek exited with error code: -1". The error code is probably because the cancel operation tells zeek to shutdown. We should be ignoring the zeek error code in this case and instead return an error message like "pcap post operation canceled".

Verified in commit b7023d5 of zqd & zapi.
Repeating the original repro steps, now we see the improved error message:
$ zapi -s myspace pcappost -f ./all.pcap
 11.9% 520.7MB/4.38GB
pcap post operation canceled

Thanks @mattnibs!


42784 correct encoding of database path

Some refactoring to ensure the user passes in a correctly encoded URL for remote databases. This includes removing the 'default DB' anti-pattern in the Mazha library.
This way, we don't try and second-guess the path structure which breaks reverse proxies/forwarding etc.
Documentation needs to be updated explaining that users need to do their own URL escaping and documenting some of the withdrawn APIs.

I think once we test the slashed-path versions by creating a subclass (if I'm not suggesting something that won't work) we're good here.


[tech]: rename .travis.yaml -> .travis.yml, add python 3.8, drop

python 3.6 for tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@22b52b4). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master      #1   +/-   ##
========================================
  Coverage          ?   0.00%
========================================
  Files             ?      14
  Lines             ?     186
  Branches          ?       0
========================================
  Hits              ?       0
  Misses            ?     186
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22b52b4...65ed108. Read the comment docs.


Ensure buffer indicates backpressure to writing clients

Part of the configuration of the buffer will be to indicate how much memory it should use at most to ensure the server doesn't get OOM killed. If the buffer is filling up faster than it can compact data into Parquet and persist, then it must be able to indicate that it is overloaded.
There should be some number that is tracked that indicates how backed up the buffer is with compaction and persisting tables. This should be a metric exposed in /metrics. The server should have access to this number to determine if it should reject writes or hold them for some small period of time to slow down the writers.

This is no longer relevant given the new architecture.


TextFieldInputConfiguration

Hii   There is an error
If  User start texting on  newline then send icons are given  it not Append on Bubble  and also on _onSendTap

Hi @sivasankar2221, can you please describe the issue in detail with an image or video, also please share the code snippet so we can reproduce the issue to investigate it further.

https://github.com/SimformSolutionsPvtLtd/flutter_chatview/assets/102312686/1c6c0728-fbcd-4006-a66a-0c4314c8c853

See Here if the User Start Texting on the newline it could not send on the _onsendTap() also

ThankYou  @apurva010 it works


openafs build broken

There's an unclosed " in the preconfigure phase: https://github.com/NixOS/nixpkgs/blob/master/pkgs/servers/openafs-client/default.nix#L38, which causes this to fail.
I still can't get it to build, due, I believe (though I cannot find the mailing list post to confirm this) that this is due to a buggy version of openafs. Version 1.6.11 with kernel 4.0 works fine for me, however.

After fixing the unclosed quote it fails for me in configure phase with
configure: error: Couldn't guess your Linux version 2

works now


Implementation of Intellisense for CSS Properties in Stylex

Is your feature request related to a problem? Please describe.
I'm currently experiencing a lack of a significant feature in Stylex within VS Code, which is available in tools like Vanilla Extract. Specifically, it's the ability of Intellisense to display CSS properties while I am styling. This absence hinders efficiency and accuracy in writing CSS code.
Describe the solution you'd like
I would like Stylex to be enhanced to integrate Intellisense within VS Code, enabling developers to view available CSS properties while coding. This functionality would significantly boost productivity and help avoid common mistakes, making the CSS writing process more intuitive and efficient.
Describe alternatives you've considered
An alternative would be to continue using tools like Vanilla Extract or other plugins that offer this feature. However, this does not solve the issue for those who prefer or need to use Stylex for its unique features and integration with other systems.
Additional context
This enhancement would not only benefit my workflow but also be valuable for many other developers using Stylex in VS Code. The addition of this feature would put Stylex on par with other market tools, increasing its attractiveness and usability.

Obs: The only way that I found to do what I wanted was importing this CSSPropertiesWithExtras type

This issue has already been fixed and will be in the next release.


Gulp Browserify + Reactify (JSX)

Would be incredibly useful to see an extension of your browserify vanilla example that included a JSX transform (reactify).
Something along the lines of this gulp-browserify based sample:
gulp.task('javascripts', function() {
  gulp.src('src/javascripts/app.jsx')
    .pipe(browserify({
      insertGlobals: true,
      transform: ['reactify'],
      extensions: ['.jsx']
    }))
    .pipe(gulp.dest('build/javascripts'));
});

you may find solution in this repo https://github.com/Granze/react-starterify.


unavailable shared library com.google.android.maps

Is the 'com.google.android.maps' included? If so, how can I debug the Problem?
Tested on customized CM12.1 build with signature patch.
I used 'Öffi' (http://oeffi.schildbach.de/download.html) for testing.
D/PackageManager(  607): Renaming /data/app/vmdl1666102432.tmp to /data/app/de.schildbach.oeffi-1
E/installd(  202): Couldn't opendir /data/data/de.schildbach.oeffi: No such file or directory
W/PackageManager(  607): Package couldn't be installed in /data/app/de.schildbach.oeffi-1
W/PackageManager(  607): com.android.server.pm.PackageManagerException: Package de.schildbach.oeffi requires unavailable shared library com.google.android.maps; failing!
W/PackageManager(  607):    at com.android.server.pm.PackageManagerService.updateSharedLibrariesLPw(PackageManagerService.java:5390)
W/PackageManager(  607):    at com.android.server.pm.PackageManagerService.scanPackageDirtyLI(PackageManagerService.java:5741)
W/PackageManager(  607):    at com.android.server.pm.PackageManagerService.scanPackageLI(PackageManagerService.java:5482)
W/PackageManager(  607):    at com.android.server.pm.PackageManagerService.installNewPackageLI(PackageManagerService.java:10940)
W/PackageManager(  607):    at com.android.server.pm.PackageManagerService.installPackageLI(PackageManagerService.java:11485)
W/PackageManager(  607):    at com.android.server.pm.PackageManagerService.access$2500(PackageManagerService.java:271)
W/PackageManager(  607):    at com.android.server.pm.PackageManagerService$5.run(PackageManagerService.java:9384)
W/PackageManager(  607):    at android.os.Handler.handleCallback(Handler.java:739)
W/PackageManager(  607):    at android.os.Handler.dispatchMessage(Handler.java:95)
W/PackageManager(  607):    at android.os.Looper.loop(Looper.java:135)
W/PackageManager(  607):    at android.os.HandlerThread.run(HandlerThread.java:61)
W/PackageManager(  607):    at com.android.server.ServiceThread.run(ServiceThread.java:46)
D/fdroid.AppDetails( 5175): Getting application details for de.schildbach.oeffi
E/fdroid.AppDetails( 5175): Installer aborted with errorCode: 2

Use https://github.com/microg/android_frameworks_mapsv1 or https://github.com/mar-v-in/MapsAPI for apps using legacy maps. MapsAPI is older, but more stable and easier to build and also comes precompiled as a flashable zip.

Is there another, probably simpler way to install and setup this (e.g. using an apk)? I now how to do but I really don't like messing around with recovery images or adb.

@drtrigon
It isn't an app, it is a library; so there isn't an apk and there isn't any other way to install it other than place the file in the proper folder.
PS: My microG unofficial installer (an OTA zip) automatically setup GmsCore, Maps API and other microG components.

@ale5000-git: Can it also be done using e.g. Ghost Commander? Or by converting from user to system app by e.g. Link2SD?

You can't convert it since it is NOT an app but you can place the ".jar" file manually in the right place if you have root.

Would it be possible to make a (dummy) app that does install this library into the system? E.g. "mapsapiv1 installer"? I guess it would need root.

@drtrigon
It should be easy to put it on the system if you have adb (with adb root enabled), but it probably still require a restart of Android (I'm not 100% sure).


Parameter usage vulnerable to workflow injection

Pre-requisites

[X] I have double-checked my configuration
[ ] I can confirm the issue exists when I tested with :latest
[X] I have searched existing issues and could not find a match for this bug
[ ] I'd like to contribute the fix myself (see contributing guide)

What happened/what did you expect to happen?
Not sure if this is a bug or user error, please advise.
When using input parameters in bash script (within script source), the parameter is used unescaped.
For example:
      script:
        image: debian:9.4
        command:
          - bash
        source: |
          echo '{{inputs.parameters.message}}'

This results in code vulnerable to any input containing ' quote mark.
For example, we could inject a command by passing in hello argo'; ls -la /; echo 'finished injection (tested this, and indeed the ls -la executes).
Same thing happens if echo "{{inputs.parameters.message}}" is used and a double quote " is passed.
This does not happen if using container and args:
      container:
        image: argoproj/argosay:v2
        command:
          - /argosay
        args:
          - echo
          - '{{inputs.parameters.message}}'

For example, if using env variables, this would not be the case:
# MYVAR='foo"bar'
# echo "$MYVAR"
foo"bar

Am I using bash wrong in the context of argo workflows?
Version
v3.5.2 (sorry I'm not able to test with :latest)
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
apiVersion: argoproj.io/v1alpha1
kind: WorkflowTemplate
metadata:
  name: test-escaping
spec:
  templates:
    - name: argosay
      inputs:
        parameters:
          - name: message
            value: '{{workflow.parameters.message}}'
      outputs: {}
      metadata: {}
      script:
        name: ''
        image: debian:9.4
        command:
          - bash
        resources: {}
        source: |
          echo '{{inputs.parameters.message}}'
  entrypoint: argosay
  arguments:
    parameters:
      - name: message
        value: hello argo

Logs from the workflow controller
N/A

Logs from in your workflow's wait container
N/A

When using input parameters in bash script (within script source), the parameter is used unescaped.

Yea using template variables within script templates can definitely be a bit perilous. Env vars or args are definitely more consistent and safer as they are not specific to Argo.
As far as I know, there is no specific escaping for variables within script templates. I believe that this wouldn't be possible either, as Argo doesn't know what interpreter your script container is using, so there isn't really a way for it to know how it should escape it. Sanitization is different depending on the context and Argo doesn't know the context.
For instance, for Python scripts, #11131 is an example of some really confusing escaping where actually the Python interpreter is responsible for it.

As far as I know, there is no specific escaping for variables within script templates. I believe that this wouldn't be possible either, as Argo doesn't know what interpreter your script container is using, so there isn't really a way for it to know how it should escape it. Sanitization is different depending on the context and Argo doesn't know the context.

Fair enough, thank you for the clarification @agilgur5 🙏 It makes sense you can't sanitize if you don't know how it will be used. We'll have to rethink our usage patterns, and maybe switch to python instead or only use container with "args". 👍

While Argo don't have the context the workflow creator can add this context.
What mechanism Argo uses to expand parameters? Maybe we can add some go-template like sanitation functions when expanding the parameters? Like
{{ workflow.parameters.message | sanitizeBash }}
{{ workflow.parameters.message | sanitizeHTML }}
{{ workflow.parameters.message | sanitizePythonString }}

What mechanism Argo uses to expand parameters? Maybe we can add some sanitation functions using go-template pipeline style when expanding the parameters?

Per the docs, Argo uses expr for most templating, which has many functions available.

While Argo don't have the context the workflow creator can add this context.

More generally speaking, manual sanitization can be impacted by user error and that is a large reason why injection attacks are still prevalent.
Using env vars or args is a better & safer approach, so I would suggest using those.
Since that approach exists already as well, I don't think it would be wise to create & maintain new features that are both less safe and very special-case (would only be useful for certain script templates, which, per above, are confusing as-is). Please use env vars etc instead.

Stumbled upon #5114 today -- a feature request for a flag to disable templating on injectable fields. I think that'd be great. I'd probably even turn it on by default IMO


cuda-nvcc should support more than just the default gcc version on conda-forge

Currently cuda-nvcc has a dependency on gcc_linux-64 12.*, gxx_linux-64 12.*, because that's the default pinning it inherits from compiler('c') and compiler('cxx'). However, nvcc supports GCC 6 - 12.2. https://docs.nvidia.com/cuda/cuda-installation-guide-linux/index.html#host-compiler-support-policy
I would like cuda-nvcc to be usable alongside gcc 11.
Reproduce the conflict with:
mamba create -n test --dry-run -c conda-forge gcc=11 cuda-nvcc cuda-version=12.1

I have a proposed solution in mind and will file a PR.

Thanks Bradley! 🙏
Think this came up in a previous discussion ( https://github.com/conda-forge/cuda-nvcc-feedstock/pull/21#discussion_r1244460063 )
Likely we want to change this logic
https://github.com/conda-forge/cuda-nvcc-feedstock/blob/4b1da8a0cc782f19a165bdaf2bdf8dfb3a909958/recipe/meta.yaml#L23-L27
...to...
  requirements:
    run:
      - cuda-nvcc_{{ target_platform }} {{ version }}.*
-     - {{ compiler('c') }}
-     - {{ compiler('cxx') }}
+     - {{ c_compiler }}
+     - {{ cxx_compiler }}


Actually send state changes to websocket

This still needs to be done.
Each time a socket is opened, we need to track the pid with gproc.  When new events arrive, we will then send a message to each pid tracked.
Additionally, perhap will need to occasionally reap dead pids from gproc.

This is finished and in master.


SimpleMapTest is not working

When the the thread class changed it was forgotten to start the threads in the SimpleMapTest. This fixes it.

Windows test PASSed.

Linux test PASSed.


Upload rawdata from a variable instead of file

It would be much more convenient to also allow files->upload() to accept a rawdata string for upload rather than having to specify a file path, when generating content on the fly.
Or can you provide an uploadString() function as well?
Thanks

I'll add a way so that you can do either this weekend.

I pushed code changes to a new branch rawdata. If you're able to, can you test that code and see if it works for you?
For files->download(), I added an optional parameter defaulting to true that tells the function whether or not to download the data directly to a file path or not.
For files->upload(), I added a file_exists($file_data) check to see if the data is a valid file path. If it's not, then the function assumes that it is raw data and treats it as such, otherwise it works the same as before.
If this works for you I'll merge the branches. Thank you.

Thank you. I'll check it out this Thursday when I'm scheduled to work on
the related project. Thanks again!
On 18 Feb 2018 03:12, "Luke Baird"<EMAIL_ADDRESS>wrote:

I pushed code changes to a new branch rawdata. If you're able to, can you
test that code and see if it works for you?
For files->download(), I added an optional parameter defaulting to true
that tells the function whether or not to download the data directly to a
file path or not.
For files->upload(), I added a file_exists($file_data) check to see if
the data is a valid file path. If it's not, then the function assumes that
it is raw data and treats it as such, otherwise it works the same as before.
If this works for you I'll merge the branches. Thank you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lukeb2014/Dropbox-v2-PHP-SDK/issues/6#issuecomment-366489232,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC0-9-K2w5b-kDhkaPQBNfj7O5SoGkNJks5tV5UXgaJpZM4SG0pN
.

Confirmed works as expected and falls back to file upload with test script.
Please merge into master at your earliest convenience!
Thank you

$rawData = time();
$fileName = 'String.txt';
$storePath = '/Directory/' . $fileName;
$dropbox = new Dropbox(COMPANY_DROPBOX_ACCESS_TOKEN);
$dropbox->files->upload($storePath, $rawData, 'overwrite');

With regards to download()
public function download($path, $target, $output_as_file = true) {
Could $target double up as the check for whether to output as file? If $target === false then output as raw data else save to the path held in $target? Otherwise to output raw data I have to use it as such:
$data = $dropbox->files->download('/file/path', null, false);
Whereas it would be simpler to use as:
$data = $dropbox->files->download('/file/path', false);

Agreed, I will go ahead and change that.

All works fine downloading to raw data so good to proceed with merging into
master.
On 23 February 2018 at 15:58, Luke Baird<EMAIL_ADDRESS>wrote:

Agreed, I will go ahead and change that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lukeb2014/Dropbox-v2-PHP-SDK/issues/6#issuecomment-368050677,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC0-9zFIa7-NzRfgZG4YVIqH4MLJAB_wks5tXuAagaJpZM4SG0pN
.

Merged and published. Thank you for testing this.

No thank you!
On 23 February 2018 at 16:14, Luke Baird<EMAIL_ADDRESS>wrote:

Merged and published. Thank you for testing this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lukeb2014/Dropbox-v2-PHP-SDK/issues/6#issuecomment-368055832,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC0-9ybdeieeOPhfRPH-8e444LRKRWdoks5tXuPHgaJpZM4SG0pN
.