"bandwidth" attribute

I'm using iperf3 for testing VoIP quality, and would like to use iperf-lib, but can't set bandwidth in udp mode, script tests at the maximum speed that it can send.
for example:
#!/usr/bin/env python
# -*- coding: utf-8 -*-
import iperf3

client = iperf3.Client()
client.protocol = 'udp'
client.bandwidth = 1
client.duration = 5
client.server_hostname = '<IP_ADDRESS>'
client.port = 6969

result = client.run()

print('')
print('Test completed:')
print('  started at         {0}'.format(result.time))
print('  bytes transmitted  {0}'.format(result.bytes))
print('  jitter (ms)        {0}'.format(result.jitter_ms))
print('  avg cpu load       {0}%\n'.format(result.local_cpu_total))
print('  Megabits per second  (Mbps)  {0}'.format(result.Mbps))

where out are:

Test completed:
  started at         Sun, 25 Jun 2017 04:26:54 GMT
  bytes transmitted<PHONE_NUMBER>7
  jitter (ms)        0.00436181
  avg cpu load       87.6748%

  Megabits per second  (Mbps)  32899.4750977

In CLI version iperf work is fine
Debian GNU/Linux 8.8 (jessie)
Python 2.7.9

I am having the same issue. Bandwidth setting is just not taken into account. Not sure though it's an actual issue in iperf3 API instead of this python lib.
Did somebody take a look into this?

Hi @ChristofKaufmann
My intention is to follow the libiperf3 library as closely as possible which is why the default value of the library is used. If the libiperf3 defaults get updated, iperf3-python should follow automatically.
@Dron-Z can you confirm this is working for you, taking into account the bandwidth parameter is in bits/second?

@thiezn That's reasonable, but from the user perspective it would be nice to have quick access to the default settings as if using the CLI. Because now it is easy to make mistakes, when not aware of the source code of the CLI.

Hi @ChristofKaufmann
My intention is to follow the libiperf3 library as closely as possible which is why the default value of the library is used. If the libiperf3 defaults get updated, iperf3-python should follow automatically.
@Dron-Z can you confirm this is working for you, taking into account the bandwidth parameter is in bits/second?

Yes, it's works. I'm don't know why I'm didn't check this format before ) Thnx


Cannot read property 'alias' of undefined

Issue description
Error on sending iota from one profile wallet to another in same Firefly app.
Firefly version
1.2.0
OS details
10.0.19043
Can the issue be reliably reproduced?
No
Steps to reproduce the issue
I had six profiles with one wallet each.
Created a new profile with 6 wallets inside

created new profile 'X'
send iota from old profile 1 existing profile 'X' wallet 1
created new wallet 2 inside new profile 'X'
go to old profile 2
send iota from old profile 2 existing profile 'X' wallet 2
and so on
with last old profile 6 I wanted to send iota and after pressing the button "send" I got this error.

Nethertheless iota were sent from profile 6 to profile 'X' wallet 6
Expected behaviour
no error
Actual behaviour
error
Errors
App Version: 1.2.0
platform: win32
platformVersion: 10.0.19043
platformArchitecture: x64
cpuCount: 12
totalMem: 16228.7 MB
freeMem: 10398.1 MB
userPath: C:\Users\harni\AppData\Roaming\Firefly
Error Type: Preload Context Error
Error: Uncaught TypeError: Cannot read property 'alias' of undefined
at C:\Users\harni\AppData\Local\Programs\desktop\resources\app.asar\public\build\preload.js:2:548089
at C:\Users\harni\AppData\Local\Programs\desktop\resources\app.asar\public\build\preload.js:2:590377
at Array.forEach ()
at destroy (C:\Users\harni\AppData\Local\Programs\desktop\resources\app.asar\public\build\preload.js:2:590365)
at C:\Users\harni\AppData\Local\Programs\desktop\resources\app.asar\public\build\preload.js:2:582435

Where there any ux issues with the names of the profiles or wallets? Did you have any profiles or wallets with identical names?

Closing issue due to inactivity, please upgrade to the latest app version and reopen the issue if the problem persists 🌷


Assignee shown as [object Object]

Using Gitea 1.15.5
and a fresh installed gitea plugin in VSCode I get this error

Is this still a thing?

Hi,
Yes, still a thing :)
Treated as a string, API return an object.


Exec command weird behavior

Node version: 0.10.37
ShellJS version: 0.7.7
Operating system: Lubuntu
Description of the bug: exec command weird behavior
hi i want to run a shell script using shell.exec
but having weird behavior (kindly dont laugh on my node version i just cant update it)
but when i do
shell.exec('./build.sh');

it outputs as it running this command infinite time and when i try async method
as
shell.exec('./build.sh', function(code, stdout, stderr) {
		console.log('Exit code:', code);
		console.log('Program output:', stdout);
		console.log('Program stderr:', stderr);
	});

no output produced
so its a very weird condtion for me kindly help thanks

Hi @maqboolkhan. We dropped support for node v0.10 when we released ShellJS v0.7.0 (for the very reason you're seeing).
I strongly recommend upgrading to a more recent version, since v0.10 has been deprecated for quite some time. Take a look at this page for an idea of which versions of NodeJS are still supported.

thank you @nfischer i understand thats why i close this question thanks man for your co operation


ConvertTo-Xml fails with nested custom objects: omits closing  tag

See repro below.
As an aside (that will probably become a docs issue): What is the purpose of ConvertTo-Xml? The docs suggest that it is the in-memory counterpart to Export-Clixml, however:

It produces different XML representations,
which, if saved to a file, cannot be re-imported with Import-Clixml

Steps to reproduce
[pscustomobject] @{ a = [pscustomobject] @{ aa=11; bb=22 } } | ConvertTo-Xml

Expected behavior
Should output an [xml] instance that is the serialization of the custom object.
Actual behavior
The following error occurs:
ConvertTo-Xml : Unexpected end of file has occurred. The following elements are not closed: Objects.

If you use -As String, you don't get an error, but the XML string output too is missing the closing </Objects> tag.

Removing the 2nd property (bb) from the nested custom object makes the problem go away.

Using [hashtable] instances instead of [pscustomobject]s makes the problem go away.

Export-Clixml does not exhibit the problem.

Environment data
PowerShell Core 6.2.0-preview.1 on macOS 10.14.1
PowerShell Core 6.2.0-preview.1 on Ubuntu 16.04.5 LTS
PowerShell Core 6.2.0-preview.1 on Microsoft Windows 10 Pro (64-bit; Version 1803, OS Build: 17134.345)
Windows PowerShell v5.1.17134.228 on Microsoft Windows 10 Pro (64-bit; Version 1803, OS Build: 17134.345)

Fails with Windows PowerShell 5.1 so not a regression.  Seems specific to nested [PSCustomObject].  Other cases work
get-process | select -first 1 | convertto-xml

Thanks, @SteveL-MSFT. Generally, I only include a Windows PowerShell version in the Environment data section if it isn't a regression (and, conversely, point out if it is). Can you briefly explain the purpose of ConvertTo-Xml with respect to my comments at the top, so I can open docs issues, if/as needed?

@mklement0 I don't know the history of it, but I can make an educated guess.  ConvertTo-Xml uses a simplified format that makes it easier to use with other systems that accept XML although it's probably still a bit more abstract than a simple property bag format...  Export-CliXml is the same serialization format PowerShell uses for remoting so it's more complete to enable deserialization.  Ideally, it seems like we should have had ConvertTo-Xml take a -Format parameter that supported CliXml and other xml formats rather than having this confusion between ExportTo-CliXml and ConvertTo-Xml having incompatible xml formats.

Thanks, @SteveL-MSFT.

other systems that accept XML

So I can suggest improvements to the docs: can you give examples of such other systems?
Are there common real-world scenarios?

I've created a docs issue at https://github.com/PowerShell/PowerShell-Docs/issues/3310.

@mklement0 @SteveL-MSFT this does seem specific to pscustomobject. The following works:
[psobject] @{ a = [psobject] @{ aa=11; bb=22 } } | ConvertTo-Xml

@sdwheeler: Yes, but do note that casting to [psobject] is a virtual no-op, because only the [pscustombject] cast provides the custom-object construction syntactic sugar:
PS> ([psobject] @{ a = [psobject] @{ aa=11; bb=22 } }).GetType().Name
Hashtable # !! [psobject] was effectively ignored.

As an aside: I say virtual no-op, because you do get an extra [psobject] wrapper, though that is mostly invisible - except when it isn't.
In other words: your command is the same as the following, and therefore operates on a hashtable:
@{ a = @{ aa=11; bb=22 } } | ConvertTo-Xml

Looks like the serializer erroneously decreases the serialization depth when writing PSObject properties:
https://github.com/PowerShell/PowerShell/blob/5d03e1653a7d518715fa3f00587cad6b5c78cc89/src/Microsoft.PowerShell.Commands.Utility/commands/utility/CustomSerialization.cs#L735
This results in nested properties whenever there's more than one.
Removing --depth; seems to solve the problem completely

@IISResetMe perhaps you could submit a PR with tests :)


User collections

Features

url/users/:uid/collections

This route should have all collections which have been created by a user.

All good


Automatically create duplicates.events table from atomic.events

To ease the automation of the setup of de-duplication, we can automatically generate the duplicates.events table from the atomic.events table's schema. To do so without loading any data, we simple provide an always false conditional.

Thanks @sbonami - can you sign our CLA please: https://github.com/snowplow/snowplow/wiki/CLA

@alexanderdean: Signed the Corporate Contributor one.

Confirmed! Thanks so much

Thanks for the contribution @sbonami - this is a won't fix now as we are prioritising our DynamoDB-based Spark deduplication.


Get rid of jdk6

JDK 6 reached EOL can we get rid of it?

Thanks for the suggestions.
We are looking to drop JDK 6 some time in the future (probably early next year).
We still have clients that need the support for the time being so we can't get rid of JDK 6 just yet.

Sounds reasonable


csharp: fix closing brackets on sdk generator

Related to #26

Task linked: CU-86dtdamr5 Fix Csharp onchain code generation


Mass reset of issues

Hello
I have a lot of music that was been marked as with issues but its A LOT so clearing them out ONE by ONE is a hassle.
Please add a tick so they can all be removed and a upload can be retried.
Thanks

Hey,
Anything files marked with 'issue' will be retried after 24 hour, or if you restart the application... ?
That being said, there are certain music files that simply can't be uploaded you YouTube music, such as files over 300MB, and for some reason certain .flac files... These however should be just ignored...
I wonder why you have so many issues?
Also, you can mass reset all music states in the 'YT Manager' form.
Regards,
J

I will add the option though it's not a big thing to do.

Its my scenario. All the issues are normal.
The program is opened for more than 24 hours and I see issues dating back to Janurary

I will add the option though it's not a big thing to do.

Thank you very much.

Done: https://github.com/jamesbrindle/YTMusicUploader/releases/tag/v1.7.2


Node Manager Interface for NCM Registration

API to Register, Unregister, Query NCM partitions.
This API is subject to change depending on PR #584.
The API itself will be in the next PR but this one adds the necessary
infrastrure.

PR merged.


Angular 9.1.0 Fresh library project fails to build.

🐞 Bug report
Command (mark with an x)

[x] new
[x] build
[ ] serve
[ ] test
[ ] e2e
[x] generate
[ ] add
[ ] update
[ ] lint
[ ] xi18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
Happen'd first time. Existing libraries updated to 9.1.0 builds without a problem.
But Newly created after i update CLI to 9.1.0 shows me above error on building. Building regular application works thou.
Description
Unable to build library project for freshly generated library project using cli 9.1.0
🔬 Minimal Reproduction
ng new my-lib-project --create-application=false
cd my-lib-project
ng generate library my-lib
ng build my-lib <=== ERROR
Repo: https://github.com/niteshpurohit/angular-cli-error-example-repo
🔥 Exception or Error

ng build my-lib

An unhandled exception occurred: Package exports for '**/my-lib-project/node_modules/ng-packagr/node_modules/rollup' do not define a valid '.' target
See "/private/var/folders/ln/_gz8v98j4dx0sv4zvm38_sw80000gn/T/ng-4DqbHq/angular-errors.log" for further details.

[error] Error: Package exports for **/my-lib-project/node_modules/ng-packagr/node_modules/rollup' do not define a valid '.' target
    at resolveExportsTarget (internal/modules/cjs/loader.js:545:13)
    at applyExports (internal/modules/cjs/loader.js:459:14)
    at resolveExports (internal/modules/cjs/loader.js:508:12)
    at Function.Module._findPath (internal/modules/cjs/loader.js:577:20)
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:879:27)
    at Function.Module._load (internal/modules/cjs/loader.js:785:27)
    at Module.require (internal/modules/cjs/loader.js:956:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object. (/**/my-lib-project/node_modules/ng-packagr/lib/flatten/rollup.js:12:16)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)

🌍 Your Environment

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 9.1.0
Node: 13.1.0
OS: darwin x64

Angular: 9.1.0
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.901.0
@angular-devkit/build-angular      0.901.0
@angular-devkit/build-ng-packagr   0.901.0
@angular-devkit/build-optimizer    0.901.0
@angular-devkit/build-webpack      0.901.0
@angular-devkit/core               9.1.0
@angular-devkit/schematics         9.1.0
@ngtools/webpack                   9.1.0
@schematics/angular                9.1.0
@schematics/update                 0.901.0
ng-packagr                         9.1.0
rxjs                               6.5.5
typescript                         3.8.3
webpack                            4.42.0

Node.js 13.0 and 13.1 do not support the latest specification for the exports field.  Please consider updating to 13.2+ (13.12 is the latest).

Seems its working with 13.2.0. Thanks for your help.


"End job" function in order to create multiple jobs from the same python script

My use case is tracking every iteration of a hyperparameter optimization process. I've created a function that roughly looks like:
def model_score(hyperparameters):
    xtrain, ytrain, xtest, ytest = get_data()
    model = create_model(hyperparameters)
    model.fit(xtrain, ytrain)
    score = model.evaluate(xtest, ytest)
    return score

I am then passing this function to my favorite optimization algorithm (like skopt's gp_minimize, hyperopt's fmin and so on) but I also want to log the inputs and outputs in the process:
def model_score(hyperparameters):
    foundations.log_params(hyperparameters)
    xtrain, ytrain, xtest, ytest = get_data()
    model = create_model(hyperparameters)
    model.fit(xtrain, ytrain)
    score = model.evaluate(xtest, ytest)
    foundations.log_metric(score)
    return score

While this code doesn't raise any errors, it only logs the first parameter iteration as a "job" and assigns all the metric iterations to it. I'm wondering if it would be possible to have something like a foundations.end_job() function that I would call once I log my metrics so that the next time log_parameters is called, it creates a new job.

Hey @cbalaf , curious - can't you use the submit job method in the Python SDK to achieve this?
The SDK allows you to submit jobs programatically
https://docs.atlas.dessa.com/en/latest/sdk-reference/SDK/#job-submission

does the deployment object contain information about the job? If so, then yes, otherwise the issue is that I want the input to a subsequent job to depend on a previous one - which means that I would like to have output from a job returned to the program

It depends what information you need from the previous job.
If it's a metric from a previous job, can you try using .log_metric() on the upstream job, which should give access to that resulting metric using the deployment object

oh, that's great! I guess my question then becomes on whether the upstream job needs to be a in a separate script that needs to be invoked or whether it can be a function defined in the same script

The way we organize our code is usually having a main file like hyperparameter_serach.py that acts as the driver, and kicks off all jobs for the search.
Here's a tutorial that hopefully clarifies usage of foundations.submit via random walk logic: https://docs.atlas.dessa.com/en/latest/tutorials/auction_price_regression_tutorial/#random-walk-search
It uses get_metric along with some basic logic to randomly walk through a search space. Let me know if this helps!

hey @cbalaf , did the answer above help you get through the issue?

It helped seeing how I could do what I wanted within the current atlas logic. Didn't necessarily address the original reason why I opened this. In any case, this isn't a bug or a blocker, just my idea of an enhancement


fix missing char in RNIapModule.java

fix missing char in RNIapModule.java which causing build/run error on android

Please commit to dev branch instead master refering to Contributing guide.


java.lang.IllegalArgumentException: Vertex id can not be null

OrientDB Version, operating system, or hardware.

v2.2.13

Operating System

[ ] Linux
[ ] MacOSX
[x] Windows
[ ] Other Unix
[ ] Other, name?

Expected behavior and actual behavior
In version 2.2.0 and older, I can query for edge in Graph Editor. The Graph Editor can shows the edge with its in & out vertices. After upgrade to version 2.2.13, the Graph Editor pops up the error, java.lang.IllegalArgumentException: Vertex id can not be null and does not show anything on panel.
Steps to reproduce the problem
To execute SELECT FROM E

2.2.14 has the same problem.

hi @thirawato
do you have a dataset to reproduce the problem?

hi @maggiolo00
I have sent you the data.

hi @thirawato
in your dataset  the edge with recorid #22:0 has no in/out property. That is why you get
`Vertex id can not be null``
How did you create that edge?

I've removed that record and i do not get the exception anymore, but still i'm not able to see the result. I will provide a fix for this.
Thanks

Hi @maggiolo00
I don't know what I did on record id #22:0.
However I can simulate the case with below script.
create edge gw_test from #12:2 to #12:4 set scope='test'
update gw_test remove in
update gw_test remove out

Ok you shouldn't do that. You are removing the connection with vertex in/out

Btw i've fixed the visualization issue.
Thanks for reporting


Compatibility with v11

Hi! It looks like the current release isn't compatible with v11. When I try to install it it gives me this error: Unable to load valid module: Module validation errors: author 1:name may not be undefined 0: name: may not be undefined.
Is there an easy fix?
Thanks!

I would also love to see an update to this module!

This module seems to work just fine in v11, with a couple manifest tweaks:
change "authors": ["JeansenVaars", "Vance Cole"], to
"authors": [
    {
      "name": "JeansenVaars",
      "flags": {}
    },
    {
      "name": "Vance Cole",
      "flags": {}
    }
  ],

and change the compatibility maximum to 11, or remove it. trying to update will still make foundry complain, but you can just lock the module for now until it gets updated here. sidebar resizing works fine.

Hi @dggomes @esheyw @chaoticnote @nschoenwald
Updated for Foundry V11!
Enjoy and let me know if you notice anything weird

Thank you for the update, will let you know if I come across anything!
Saif Addin @.***> schrieb am Di., 20. Juni 2023, 19:26:

Hi @dggomes https://github.com/dggomes @esheyw
https://github.com/esheyw @chaoticnote https://github.com/chaoticnote
@nschoenwald https://github.com/nschoenwald
Updated for Foundry V11!
Enjoy and let me know if you notice anything weird
—
Reply to this email directly, view it on GitHub
https://github.com/saif-ellafi/foundryvtt-sidebar-resizer/issues/8#issuecomment-1599217346,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARIJNCAQBQTBWSYEJSDDSWTXMHMK5ANCNFSM6AAAAAAYOO42IQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Python Package set updates

Regular python-unstable run with major updates to libraries.
https://hydra.nixos.org/jobset/nixpkgs/python-unstable

[ ] Squashed fixup commits before merge

Hmm. On macos 10.15:
builder for '/nix/store/rmv0vw9p7ynb7avnsf1yjr57701ha68i-python3.8-pythran-0.9.12.drv' failed with exit code 1
...
OSError: dlopen(/nix/store/24pj2503xx3hspq0jxzfs315p545w8a1-clang-7.1.0-lib/lib/libgomp.dylib, 6): image not found


added sample of auth with aad

#31294

API change check
API changes are not detected in this pull request.


Option to prevent html entities in result

When displaying a truncated text from this library with Twig, it displaying html entities because Twig safely encodes &.
Actually I expected UTF-8 characters are returned as is:
truncateMarkup('
PHP éléphant
', 7)
Expected:
PHP élé...
Actually:
PHP élé
I understand this makes sense, but there should be a way to disable html entities, i.e by calling html_entity_decode on truncated text before returning it (which is what we are currently doing on our side).

Good point, I’ll take a look into it!

The latest version 3.0 handles UTF-8 characters (even Emoji) and does not convert them to entities.
I added some tests as well.
If you run into further problems feel free to re-open this issue.


Doesn't parse .uk.com domains

Hey,
Had an issue whereby it wouldn't work with my .uk.com domain.
Looks like when its trying to get the ZONENAME_REGEX, it returns uk\.com.
This occurs when the CERBOT_DOMAIN is *.domain.uk.com
I also had to add in a sleep as it wasn't picking it up within the short space of time. After this, it worked great.
Also to note, --manual-cleanup-hook was required to remove the record once complete, not sure if its worth updating the examples shown.

Indeed, the regex seems to only support second level domains.
I'm afraid I'll not be able to find time to fix it now. In the meantime, however, I recommend that you try acme.sh for which I also wrote a HE plugin. It's much more polished and I'm pretty sure I've tested domains of deeper levels (HE supports adding zones for subdomains). I actually plan to incorporate code from the acme.sh plugin back to this certbot plugin.
I've added the forgotten manual-cleanup-hook into examples, thanks.

Hey KevSex,
I've briefly tested and it seems to be working now, but let me know if there's still an issue.
Thanks for reporting.


Add or remove maps in real-time

Issue Type
[x] Question
Hi,
I'm wondering if there is possibility to add or remove maps in the real-time while the map is still visible (after initial constructor invocation and load of the maps) without reinitialization of complete map and redrawing whole content.
I can see that there is private MultiMapDataStore mapDatabase; variable in MapsForgeTileSource.java class but it is not accessible out of the class.
I'm currently using osmdorid with mapsforge provider with offline maps.
Any idea? Thanks.
Version of osmdroid the issue relates to:
osmdroid - 6.1.11
mapsforge - 0.10.0

Hi @bkekelic2!
I don't know that much about MapsForge, and my suggestion is that you copy MapsForgeTileSource into your own project and try to achieve what you want - for instance making field mapDatabase public or protected. Maybe you'll also need MapsForgeTileModuleProvider and MapsForgeTileProvider, but there are not that many MapsForge classes in osmdroid.
I hope you'll achieve what you want, and if you manage to do it please send a PR. Good luck!

Hi @monsieurtanuki,
Thanks for the idea but I eventually ended up with a workaround.
At first map initialization, I save loaded files into private variable private List<File> loadedFiles; and on each onResume() event I check if there are some differences (new file added or old one removed) between loadedFiles and actual files from the storage. If yes, I just reinit map with new files, update loadedFiles and redraw each marker on its last known position.
Thanks.


Fix: Volunteer access to link facility

Proposed Changes

Fixes #9420

@ohcnetwork/care-fe-code-reviewers
Merge Checklist

[ ] Add specs that demonstrate bug / test a new feature.
[ ] Update product documentation.
[ ] Ensure that UI text is kept in I18n files.
[ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
[ ] Request for Peer Reviews
[ ] Completion of QA

Summary by CodeRabbit

New Features

Conditional logic added to disable buttons for users with the "Volunteer" type.
Enhanced user experience through improved access control based on user roles.

I don’t think the Cypress tests failed due to the changes in this PR. Could someone confirm?

I don’t think the Cypress tests failed due to the changes in this PR. Could someone confirm?

yep

An admin is currently unable to unlink a facility for a volunteer user. The expected behavior is that an admin should have the ability to both link and unlink facilities for volunteer users. However, volunteer users should be restricted from unlinking their assigned facilities themselves.

An admin is currently unable to unlink a facility for a volunteer user. The expected behavior is that an admin should have the ability to both link and unlink facilities for volunteer users. However, volunteer users should be restricted from unlinking their assigned facilities themselves.

@nihal467, Fixed it, but restricted volunteer users from unlinking for all user types. Let me know if any changes are needed.

LGTM


[WIP] Refactor templates into core

Issue: #2240

Great to see progress slowly continuing on this front! I think we can get the framework-specific packages down really really small ;)

OK I have some ongoing related work on moving error and "no preview" views to core, but it'll need a separate review, so I'll just merge this one first


Feature Request AC Max

Hey, I was just curious if you could add system.attributes.ac.max or something like that to say the max dex ac of the armor being worn.

I have a PR that incorporates that, among other things, right here. :) https://github.com/foundryvtt/dnd5e/pull/2664


Observing Mumps Execution errors (Windows/IntelOneAPI Compiler/Ninja Build)

Mumps Version (5.3.5)
When I try to run the executable for the sample c code (simple.c) and enabling only 'd' - double precision, I observe the following errors:
Kindly help. Attached build log and simple.c used.
build.txt
simple.c.txt
Error Log:
**//
C:\Users\winuser2\vishy\repos\mumps\mumps_fixes\ninja_build_dir\tests>Csimple.exe
No of Processes = 1, My Rank = 0
Start Mumps Init
Done Mumps Init
Start Mumps Analyse/Fact/Solve
[PROC 0] Error Return in Test application, id.infog[0] = -16
[PROC 0] Error Return in Test application, id.infog[1] = 0
[PROC 0] id.infog[2] = 0
C:\Users\winuser2\vishy\repos\mumps\mumps_fixes\ninja_build_dir\tests>mpiexec -n 2 Csimple.exe
No of Processes = 2, My Rank = 0
Start Mumps Init
No of Processes = 2, My Rank = 1
Start Mumps Init
** ERROR RETURN ** FROM DMUMPS INFO(1)= -3
** INFO(2)= -1
** ERROR RETURN ** FROM DMUMPS INFO(1)= -3
** INFO(2)= -1
[PROC 0] Error Return in Test application, id.infog[0] = -3
[PROC 0] Error Return in Test application, id.infog[1] = -1
[PROC 1] Error Return in Test application, id.infog[0] = -3
[PROC 1] Error Return in Test application, id.infog[1] = -1
[PROC 1] id.infog[2] = 0
[PROC 0] id.infog[2] = 0
//**

Adding the below line in tests/CMakelists.txt to include Intel MPI Libraries explicitly helped solve the ILP64 issue for me. A specific Intel's ILP64 MPI library needs to be linked first ("libmpi_ilp64.lib")
Kindly check
...
target_link_libraries(Csimple PRIVATE ${IMPI_LIB_ILP64} ${MPI_C_LIBRARIES} MUMPS::MUMPS ${NUMERIC_LIBS})
...
where the new variables are as follows:

find_library(IMPI_LIB_ILP64
NAMES libmpi_ilp64
HINTS ${USER_PROVIDED_IMPILIB_ILP64_PATH})
    -----USER_PROVIDED_IMPILIB_ILP64_PATH="C:/Program Files (x86)/Intel/oneAPI/mpi/2021.3.0/lib"

MPI_C_LIBRARIES is populated by "find_package(MPI COMPONENTS C Fortran REQUIRED)"

Thank you, I also observe that the IntelMPI "mpi_ilp64" library is the vital missing piece to being able to run int64 MUMPS


[CI] Update Verilator in CI to 4.032

The minimum Verilator requirement remains unchanged.

There's maybe a policy question about updating our tool requirements. If we're not actively testing with older versions, it's not at all unlikely that we'd commit something that doesn't work with the version specified in tool_requirements.py and not know it.
This isn't something that should need to block this PR, but we do need to consider how we want to handle that. The obvious approaches would be either:

Set up our CI so it always matches the minimum tool requirements and no higher
Adding additional checks so we're testing with both our supported minimum tools and newer versions

Having the minimum-supported version in CI is certainly a good approach (and that's what we do for other tools as well). Doing that here and now is, however, quite a bit of work for no significant gain, given that we haven't diverged much between required and the used version, and verilator is quite stable. Updating the required version is annoying for users, as all contributors have to update verilator, and we have no precompiled binaries, broadcast announcement communication, or easy way to install updated versions available just yet.


TypeError: Cannot read property 'height' of undefined

When used with option { inversionAttempts: 'onlyInvert' }
an error is thrown => TypeError: Cannot read property 'height' of undefined

native code,
var shouldInvert = options.inversionAttempts === "attemptBoth" || options.inversionAttempts === "invertFirst";
var tryInvertedFirst = options.inversionAttempts === "onlyInvert" || options.inversionAttempts === "invertFirst";
should be edit as
var shouldInvert = options.inversionAttempts === "attemptBoth" || options.inversionAttempts === "invertFirst" || options.inversionAttempts === "onlyInvert";
var tryInvertedFirst = options.inversionAttempts === "invertFirst";
try this, it works

native code,
var shouldInvert = options.inversionAttempts === "attemptBoth" || options.inversionAttempts === "invertFirst";
var tryInvertedFirst = options.inversionAttempts === "onlyInvert" || options.inversionAttempts === "invertFirst";
should be edit as
var shouldInvert = options.inversionAttempts === "attemptBoth" || options.inversionAttempts === "invertFirst" || options.inversionAttempts === "onlyInvert";
var tryInvertedFirst = options.inversionAttempts === "invertFirst";
try this, it works

When used with option { inversionAttempts: 'onlyInvert' }
an error is thrown => TypeError: Cannot read property 'height' of undefined

When used with option { inversionAttempts: 'onlyInvert' }
an error is thrown => TypeError: Cannot read property 'height' of undefined

#118

This is being fixed in PR #148 which is however unfortunately not merged yet.
If you are interested, have a look at https://github.com/nimiq/qr-scanner which uses a jsQR fork that already merged this PR and a couple others, as this repo is unfortunately not being maintained much lately.


Further comments on 2022 assessment doc

Note comments from Allan Hick's posted on the postSRG 'final' version of the 2022 stock assessment (below) for consideration in 2023.
hake-assessment-2022-preSRG_HicksComments.pdf

Just had a look through. It will be easier to address them once we have the new model results, since some will be redundant. Some are just 'thoughts' I think, or comments, but the odd typos etc. that we can fix.

Thanks for doing these Kelli. Good to close?

I am done but @aaronmberger-nwfsc had some he was going to complete for me. So, I will leave it for @aaronmberger-nwfsc to close.

Mine are in there, so bam! closed


Where do I can edit page in my language?

I detect a grammar mistake in this page https://vi.reactjs.org/docs/hooks-effect.html and I want to edit this. So, where do I can edit and create pull request by what rule?

Hi! The repo you’re looking for is over at https://github.com/reactjs/vi.reactjs.org/. Check for existing issues or pull requests, and if you can’t find a fix, then go ahead and follow the Prerequisites and Contributing section of the README.md. 🙂


'Condition' class

Condition is ambiguous, and subclasses of 'condition' in AutonomousVehicles fall under different meanings:

an arrangement that must exist before something else can happen, prerequisite
the particular state that something or someone is in

I think it would better not be one class.

AutonomousVehicles ontology was removed.


[All] Clarify O365 platforms

Docs Build status updates of commit 4418f0b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/overview/office-add-in-availability.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[TCirc] Define and implement circuit description language for tcirc

We need a way to uniquely represent tcirc components (e.g. single/multi qubit gates, readout, etc).
Among other use cases, this is essential for properly decoding the a tcirc readout string.
Some potential resources include:

https://qiskit.github.io/openqasm/language/index.html
https://devblogs.microsoft.com/qsharp/introducing-quantum-intermediate-representation-qir/

I think we can store a list of tuples of type Tuple[qiskit.circuit.instruction.Instruction, List[qiskit.circuit.quantumregister.Qubit]] in self.gates, which can then be used for use cases such as drawing the logical circuit.


BayesSearchCV docs refer to surrogate parameter which doesn't exist

The BayesSearchCV docstring refers to a surrogate parameter, but the constructor does not actually have one.  I'm not really sure what it means, but it seems like it's trying to allow you to specify GP or random forests etc., which would be nice.  It would also be great if the docs specified the possible values.

surrogate : string or skopt surrogate, default='auto'
Surrogate to use for optimization of score of estimator.  By default skopt.learning.GaussianProcessRegressor() is used

Correct that docstring is out of date.
To change the behaviour of the optimiser used in the search you can pass in keyword arguments for skopt.Optimizer as optimizer_kwargs when constructing BayesSearchCV. However this isn't mentioned in the docstring :-(
Would you like to make a PR to remove the old and add a new docstring?

Fixed in #542


Prepare release 0.10.0

Time for version 1.0? 🤔

For me it's fine either way, but 1.0 to me implies stability and this has been very stable for a long time now.

For me it's fine either way, but 1.0 to me implies stability and this has been very stable for a long time now.

Indeed! Let's go for 1.0.
We're only missing one approval on this one!


Increase readability by refining the wording

Proposed change:
Increase readability by rephrasing the word from "This pod" to "The Pod above".
Supporting point:
For the newbie who read this document for the first time, it is hard to tell if the description in red blocks belongs to the above Pod or the below Pod in 5 seconds.

And this is the point of this PR. By changing the word from "This pod" to "The Pod above", it is clearly stating which part it belongs to.

/assign @katcosgrove
/assign @sjenning
(Using the command by following contributor guide: https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed)

This seems like a reasonable change to me.
/lgtm

/assign @sftim
Hi, this PR now has LGTM label, can you kindly check and approve the change?

Hi @sftim,
Can you help on merging this PR? Thanks.


Search on edited column not working properly

Edited column of status not working on search

I have status field on my users table. 1 => enabled, 2 => disabled
I don't wanted to display 1 on my table if the user is enabled or 2 if not
I created a Helper (setter and getter)
Code snippet of problem
return Datatables::of($salary_data)
    ->editColumn('status', function ($data) { return Helper::get_status($data->status); })
    ->make(true);

where the get_proper_data returns string
public static function set_status()
{
    return array(
        1 => 'Enabled',
        2 => 'Disabled'
    );
}

on my table I have now Enabled and Disabled but once I search using 'Enabled' or 'Disabled', it returns nothing..

System details

Operating System -Linux Hosting
PHP Version - 7.0
Laravel Version - 5.3
Laravel-Datatables Version - 6.x

You also need to transform the search on the query level. Try using filterColumn to modify how the package will search on the edited column.

I only have integer value on my table how could I concatenate it to be able to get the proper data? I try to use sql query replace but it did not work..


Remove deprecated terminal renderer APIs

Terminal renderers are becoming stable in https://github.com/Microsoft/vscode/pull/67923. TerminalRenderer.terminal and Terminal.onDidWriteData are remaining in proposed to give extensions a chance to migrate over by then.

Blocked on https://github.com/microsoft/vscode/issues/70978

Live share has already adopted vscode.Pseudoterminal so we can remove this in August. FYI @jrieken


Unable to scan barcodes rotated 90 degrees

I was wondering if you have capability to scan barcodes which are rotated 90 degrees(on their side). The other ionic scanner does allow it but does not allow continuous scanning like this one?

@interfacersa About which kind of codes are you talking?

Barcodes and QR Codes. Basically any type you currently support

All the 2D barcodes should not be a problem since they are designed for exactly this. With 1D barcodes and the current implementations used in this plugin it is not really possible unfortunately.

Not sure if you have seen this https://github.com/journeyapps/zxing-android-embedded/issues/211

ZXing cannot read rotated barcodes. You can try this capacitor plugin using Dynamsoft Barcode Reader which can read 1D barcodes in any angle.

Thanks ill try this

Thanks ill try this

This is my solution: Use RxJava or Coroutines to decode origin bitmap(vertical barcode), if result is null -> rotate bitmap and decode again

Just to let you know, I am currently working on a PoC to use Googles ML Kit in this plugin. With my current implementation I am able to read this code without any issues in any angle, this should resolve most of the issues regarding 1D codes.
I will let you know once I have a version ready to test, currently I am implementing the iOS part since I am more used to develop with swift than Java at the moment.

I will close this issue since the ml-kit version is now in its end-stages and I am cleaning up "old" issues. I have pretty good results scanning codes in any directions on this branch (on android it works great, there are some autofocus issues on ios I have to address)


Why?

In my book, the key benefits of TLS is confidentiality, authenticity, and integrity. However, sharing a private key (a public/public key pair, if you will) basically renders those benefits moot.
So why not simply just use HTTP?

This:

sslip.io is a means for developers to test against valid SSL certificates without the bother of purchasing them.

@ametheus : Yes, sharing a private key renders {confidentiality,authenticity,integrity} moot. It's for testing only.
Thanks @bclozel .


Provide NodeJS Buffer like APIs to Decoder and Encoder

The Decoder currently gets an Array, not a Buffer because the otto JS vm we use does not know the NodeJS Buffer API (see #299).
The NodeJS Buffer API has some really nice read/write* methods to read and write numbers of different formats from/to an offset in the buffer. This would remove the need for manual bit shifting, which puzzles many (new) users.
Before:
var myInt32 = (bytes[0] << 24) + (bytes[1] << 16) + (bytes[2] << 8) + (bytes[3]);
var myInt16 = (bytes[4] << 8) + (bytes[5]);
// var myFloat =  IMPOSSIBLE?

After:
var myInt32 = bytes.readInt32BE(0);
var myInt16 = bytes.readInt16BE(4);
var myFloat = bytes.readFloatBE(6);

What we should look into is loading a browser JS implementation of Buffer:
https://github.com/feross/buffer
It is quite big, but provides a lot of convenience to users. We could also wright a lighter wrapper around the underlying ieee754 with just the read/write methods.
Ideally we'd pass Buffer.from(bytes) to the Decoder so the user can work with it right away.
In the Encoder we could pass an empty buffer as 3rd argument which the user can fill (no need to return) using the write methods.

I prefer a lightweight implementation on top of ieee754 for reading and writing signed/unsigned 8/16/32 bit integers little/big endian, booleans, and bit sets and reads.

Me too, and we should then have the same API on the Arduino. Provides a nice level in between protobufs and bytes.

Yes. I would, however, not change the Encoder as it is for portability. Let it return a byte array, so simply return buffer.toArray();. People are not entirely stupid and it avoids a lot of magic in the Handler to add a custom parameter and check for return type.

@AntoineRondelet, @romeovs?

We can use Google Protocol Buffers or Cayenne Low Power Payload


Add applications limits

Issue
Closes #81.
Spire before 0.11.1 version have troubles with burstable class (https://github.com/networkservicemesh/networkservicemesh/issues/2183), so we need to update it.
Depends on #728.

Should we update the spire in separate PR to verify that we have not any issues with it on our integration-platform?

Should we update the spire in separate PR to verify that we have not any issues with it in our integration-platform repos?

OK, here it is #728.


Relationship between LineThickness, LineStyle and Width/Height

For GPML, how should LineThickness and LineStyle be related to Width and Height?
For simplicity and ease of use, I propose that we define GPML Width and Height to mean actual width and height (from outer edge of border on one side to outer edge of border on the opposite side). In CSS terms, this is equivalent to box-sizing: border-box;, and in SVG terms, this matches the proposed attribute stroke-position="inside".
In PathVisio-Java right now, actual width and height vary depending on zoom level, LineThickness and LineStyle (Double or not). For the following examples, the orange line represents the Width and Height specified in the GPML for the rectangles, and the pink lines are attached to the anchors of the rectangles. The equations for height are analogous to the ones for width. Note that for the Solid rectangles below, LineThickness="20", but for the Double rectangles below, LineThickness="3".
Zoomed Out

LineStyle="Solid" (or Dashed) and
actual width ≈ GPML Width + LineThickness
LineStyle="Double"
actual width ≈ GPML Width + 3 * LineThickness

Zoomed In
actual width ≈ GPML Width

LineStyle="Solid" (same for Dashed)

LineStyle="Double" (zoom level may not exactly match the one above)

Here's the GPML I used:
<?xml version="1.0" encoding="UTF-8"?>
<Pathway xmlns="http://pathvisio.org/GPML/2013a" Name="New Pathway" Version="20171009">
  <Graphics BoardWidth="683.2341642401634" BoardHeight="510.0" />
  <Interaction GraphId="d668d">
    <Graphics ZOrder="32815" LineThickness="1.0" Color="ff0099">
      <Point X="120.0" Y="30.0" GraphRef="e4375" RelX="0.0" RelY="-1.0" />
      <Point X="120.0" Y="130.0" GraphRef="e4375" RelX="0.0" RelY="1.0" />
    </Graphics>
    <Xref Database="" ID="" />
  </Interaction>
  <Interaction GraphId="bef15">
    <Graphics ZOrder="32816" LineThickness="1.0" Color="ff0099">
      <Point X="20.0" Y="80.0" GraphRef="e4375" RelX="-1.0" RelY="0.0" />
      <Point X="220.0" Y="80.0" GraphRef="e4375" RelX="1.0" RelY="0.0" />
    </Graphics>
    <Xref Database="" ID="" />
  </Interaction>
  <Interaction GraphId="dcd06">
    <Graphics ZOrder="32866" LineThickness="1.0" Color="ff0099">
      <Point X="120.0" Y="150.0" GraphRef="aec20" RelX="0.0" RelY="-1.0" />
      <Point X="120.0" Y="250.0" GraphRef="aec20" RelX="0.0" RelY="1.0" />
    </Graphics>
    <Xref Database="" ID="" />
  </Interaction>
  <Interaction GraphId="a8778">
    <Graphics ZOrder="32867" LineThickness="1.0" Color="ff0099">
      <Point X="20.0" Y="200.0" GraphRef="aec20" RelX="-1.0" RelY="0.0" />
      <Point X="220.0" Y="200.0" GraphRef="aec20" RelX="1.0" RelY="0.0" />
    </Graphics>
    <Xref Database="" ID="" />
  </Interaction>
  <Shape GraphId="aec20">
    <Attribute Key="org.pathvisio.CellularComponentProperty" Value="Cell" />
    <Attribute Key="org.pathvisio.DoubleLineProperty" Value="Double" />
    <Graphics CenterX="120.0" CenterY="200.0" Width="200.0" Height="100.0" ZOrder="16384" FontSize="10" Valign="Middle" ShapeType="RoundedRectangle" LineThickness="3.0" Color="c0c0c0" Rotation="0.0" />
  </Shape>
  <Shape GraphId="e4375">
    <Graphics CenterX="120.0" CenterY="80.0" Width="200.0" Height="100.0" ZOrder="32814" FontSize="10" Valign="Middle" ShapeType="Rectangle" LineThickness="20.0" Rotation="0.0" />
  </Shape>
  <Shape GraphId="e729a">
    <Graphics CenterX="120.0" CenterY="80.0" Width="200.0" Height="100.0" ZOrder="32864" FontSize="10" Valign="Middle" ShapeType="Rectangle" LineStyle="Broken" LineThickness="0.5" Color="ff9900" Rotation="0.0" />
  </Shape>
  <Shape GraphId="fd544">
    <Graphics CenterX="120.0" CenterY="200.0" Width="200.0" Height="100.0" ZOrder="32872" FontSize="10" Valign="Middle" ShapeType="RoundedRectangle" LineStyle="Broken" LineThickness="0.5" Color="ff6600" Rotation="0.0" />
  </Shape>
  <InfoBox CenterX="0.0" CenterY="0.0" />
  <Biopax />
</Pathway>

Does this also influence the display on WPs? (sometimes interactions are not displayed automatically, when they are below the DataNodes).


change console.log to console.info

In my code I use console.info for any logs that are meant to stick around. Would a change from console.log to console.info be helpful to anyone else?

https://github.com/facebook/create-react-app/search?q="console.log"&type=Code returns 32 results, while https://github.com/facebook/create-react-app/search?q="console.info"&type=Code returns 1
I'd rather keep this template consistent with what's commonly used in the main c-r-a project, given that there's not a substantial difference between the two.

Cool. The reason I suggested it here is because this is the code that ends up in projects. I don't have to worry about cra putting console.log in my projects outside of the templates. But I will suggest this there also. I appreciate the feedback.

Sure! Keeping this template in sync with what's doing in the main c-r-a project will be a bit of challenge, but that's the general philosophy.


Problem with undeploy linked to CWL

There appear to be a couple of problems with ADES undeploy that is related to the CWL from which the application-package was originally deployed - in particular when the linked CWL changes between the deploy and undeploy steps.
For an undeploy, it would not be expected that the original CWL would be relevant - since the http request path fully identifies the process to be undeployed.
PROBLEM #1 - The undeploy does not use the request path (e.g. /wps3/processes/app-0_0_2) to perform the undeploy, but instead appears to be using the original href, and undeploys whatever that now points to.
PROBLEM #2 - When a process is undeployed, if the original CWL href is no longer available, then an error occurs.

EOEPCA-755 has been closed.
The fix has been released in eoepca/proc-ades:2.0.7
The undeploy operation does not need to download the application package anymore.


Smart Deploy – Deploy without Setup

Just an idea, do we really need the setup step? Can't we just have deploy be smart and install new versions of node, mongo if the current meteor versions require that and all that?
I mean just do meteor up deploy and you're all set.

+1 Thats a good method indeed.

Yeah good idea... One issue I have is when I "mupx setup" on the same server all the other meteor apps loose their connection to the database... That will have to be fixed else every time you deploy you will have to restart all the other meteor apps on that server... Its a rather painful issue... Anyone know why that happens?


Improve development UX

Even on my home 4c/8t Xeon machine with 16GB of RAM webpack takes ages to build.
We should take a look at webpack docs and make sure we're getting comfortable build times and overall UX, otherwise report issues to webpack or babel.

a webpack build takes around me 5/10 seconds for me. With a quite powerful laptop.

I'm also getting this issue. It takes about 30 seconds per build on my machine (Macbook Pro from 2015, with 2.2GHz i7, 16GB ram).
Most of the time is spent on 78% additional chunk assets. I spent a little while trying to track down what is causing that. The only thing I found was this. One solution pointed to UglifyJS, which we're not using, but I'm not familiar enough with this project to know whether any of the other suggestions apply.
I wonder if it would make sense to not use the minified version of everything when running in development?

Thanks for the report of the upstream issue, I'll get a look at it more deeply soon.

Note: we might want to disable minification when running in dev mode

And build source maps too

@KeitIG when I started eion in js first, I used webpack-dev-server to serve assets (it is faster).
To do so, I did something like that in index.html file:
<script defer>
  (function() {
    const dev = process.env.ENV === 'dev';
    const script = document.createElement('script');
    script.src = dev ? 'http://localhost:9090/dist/app.js' : 'app.js';
    script.defer = true;
    document.head.appendChild(script);

    const styles = document.createElement('link');
    styles.rel = "stylesheet";
    styles.href = dev ? 'http://localhost:9090/dist/style.css' : 'style.css';
    document.head.appendChild(styles);
  }());
</script>

Are you ok with this for museeks?

@YurySolovyov Do we consider it as done or you want to talk about dev-server ?

I'd give it a try at least.

What does it change compared to the current build system ?

Adds publicPath: 'http://localhost:9090/dist/' to webpack.config.js
Need to somehow start dev server.'use strict';
const express = require('express');
const webpack = require('webpack');
const webpackDevMiddleware = require('webpack-dev-middleware');
const config = require('./webpack.config');
const compiler = webpack(config);
const app = express();
app.use(webpackDevMiddleware(compiler, {
 publicPath: config.output.publicPath,
 stats: {
   colors: true
 }
}));
app.listen(9090);

Snippet I posted above for index.html

Just writing this, I realized that this is for webpack-dev-middleware, webpack-dev-server might be much easier to set up.
I'll investigate and post results here.

I mean, what does it do ?

It keeps bundle in memory and recompiles it on change.
Can't say anything about how faster it feels, still need to investigate.

Ok, so the bundle is in memory and not in a file, I'll do some researches about how useful it can be.

Ok, it seems like it's useful only if we use react-hot-loader, I may be wrong though

It is required for react-hot-loader, but should be useful without it too.

I still see no difference between webpack --watch and dev-server, if you find any useful information, I'd be curious to know them.
Some refs:

https://webpack.github.io/docs/webpack-dev-server.html

@KeitIG See the list at the top https://webpack.github.io/docs/build-performance.html

I'm not 100% sure how webpack-dev-server fits into electron development, but the goal would be to get hot reloading to work. So, if you change any of the views, the main window is updated to reflect that, without restarting or anything.

That's my point, if we can get hot-loader working, why not, otherwise, perfs are good enough I have to say.

Build times are satisfying. HMR not there yet, maybe later in a separate issue.


Change the order of checks in applyRemoteEvent()

If there is a chance that a limbo resolution fails for a document that no longer exists, we could get into a state where we write a document into the RemoteDocumentCache with a snapshot version of zero. By re-ordering the statements, we make sure this does not happen
Port of firebase/firebase-android-sdk#802

@wu-hui FYI


Establishing new connections connections causes app to crash over time

We're having an issue which causes the application to crash after we've connected several times (say 50+) which causes the application to crash.
We are wondering if it's something to do with using WSS due to seeing this commit:
https://github.com/daltoniam/Starscream/commit/20285cce972762929a497abf616b1a460b499f32
Here is a link to the crash:
https://gist.github.com/darrenhaken/7a9c2adc772de12e9cd50a1ba725fb92

To add to this we're creating different Websocket instances as we switch between pointing to different providers.

There's a sample project which (sometimes) demonstrates this crash here: https://github.com/mchaffee1/StarscreamCrash

I just hit what I believe is the same crash. What I think happens:

pingOnce gets called twice in a very short time
The first time, it sees that socket.isConnected is false and it connects the socket
WebSocket.connect creates the request, and sets up the input and output streams. Once that's done it sets isConnecting = false
The second pingOnce arrives, the socket isn't connected yet, but it's also not connecting, so it connects again, replacing the input/output streams
...
The socket gets deallocated, the streams delegates are set to nil for the current streams, but not for those created by the first connect()
The old input stream receives some data and forwards it to a deallocated delegate.
Crash

I was surprised to see isConnecting = false before being connected, but maybe there's a reason for it. In any case, whenever inputStream/outputStream are replaced, their delegates should be set to nil.


SignalR extension not working with Groups

Hi, I was trying to migrate our functions to net5 worker, but I didn't manage to make the SignalR "groups" feature work.
Following is the function I use to register a user to a group.
Before:
        [FunctionName("Notifications_AddToGroup")]
        public async Task<IActionResult> AddToGroup(
            [HttpTrigger(AuthorizationLevel.Anonymous, "post", Route = "addToGroup")]HttpRequest req,
            [SignalR(HubName = "notifications")] IAsyncCollector<SignalRGroupAction> signalRGroupActions)
        {
                var userId = req.Query["userId"];
                var groupName = req.Query["groupName"];

                await signalRGroupActions.AddAsync(
                    new SignalRGroupAction
                    {
                        UserId = userId,
                        GroupName = groupName,
                        Action = GroupAction.Add
                    });
                return new OkResult();
        }

After:
        [Function("Notifications_AddToGroup")]
        public static async Task<NotificationOutput> AddToGroup(
            [HttpTrigger(AuthorizationLevel.Anonymous, "post", Route = "addToGroup")] HttpRequestData req,
            FunctionContext executionContext)
        {
            var output = new NotificationOutput();
                var query = HttpUtility.ParseQueryString(req.Url.Query);
                var userId = query["userId"];
                var groupName = query["groupName"];

                output.Notifications.Add(
                    new
                    {
                        userId = userId,
                        groupName = groupName,
                        action = "add"
                    });
                output.Response = req.CreateResponse(HttpStatusCode.OK);
            return output;
        }

The functions returns 200, no errors in the console (verbose).
Following is the function I used to send a message to a group.
Before:
        [FunctionName("Notifications_SendMessage")]
        public async Task<IActionResult> SendMessage(
            [HttpTrigger(AuthorizationLevel.Anonymous, "post", Route = "sendMessage")]HttpRequest req,
            [SignalR(HubName = "notifications")]IAsyncCollector<SignalRMessage> signalRMessages)
        {
                string userId = req.Query["userId"];
                string groupName = req.Query["groupName"];

                using var sr = new StreamReader(req.Body);
                using var jsonTextReader = new JsonTextReader(sr);
                var data = JObject.Load(jsonTextReader);

                await signalRMessages.AddAsync(new SignalRMessage()
                {
                    UserId = userId,
                    GroupName = groupName,
                    Target = "SendMessage",
                    Arguments = new[] { data }
                });
                return new OkResult();
        }

After:
        [Function("Notifications_SendMessage")]
        public static async Task<NotificationOutput> SendMessage(
            [HttpTrigger(AuthorizationLevel.Anonymous, "post", Route = "sendMessage")] HttpRequestData req,
            FunctionContext executionContext)
        {
                var output = new NotificationOutput();
                var query = HttpUtility.ParseQueryString(req.Url.Query);
                var userId = query["userId"];
                string groupName = query["groupName"];

                using var sr = new StreamReader(req.Body);
                using var jsonTextReader = new JsonTextReader(sr);
                var data = JObject.Load(jsonTextReader);

                output.Notifications.Add(new
                {
                    userId = userId,
                    groupName = groupName,
                    target = "SendMessage",
                    arguments = new[] { data }
                });
                output.Response = req.CreateResponse(HttpStatusCode.OK);
                return output;
        }
    }

The functions returns 200, no errors in the console, BUT no message is received on the client side.
The code on the client side works with the former version. And I managed to send messages without the "groups" feature.
The output object used for this sample is
    public class NotificationOutput
    {
        [SignalROutput(HubName = "notifications")]
        public List<object> Notifications { get; set; } = new List<object>();
        public HttpResponseData Response { get; set; }
    }

Is the SignalR groups feature supported?

This should work, so it requires some investigation (thank you for the repro code).
@anthonychu is this something you've tried?

Hard to tell what could be wrong here. I’d try the following:

Test that you can send and receive broadcast messages (no group or user id)
Confirm that the client is connecting using a user id (you might need to log the token that is returned and inspect it using something like https://jwt.ms
It’s not clear what your clients are. Recommend using JavaScript in the browser to test and check the browser dev tools to see if the negotiation and connection are done correctly and the http requests are made correctly to add user to group. Also check websocket traffic to see if there are any frames that are received.

Ok, it turned out it was partially my bad :-D
It seems you changed the internal default json serialization library in the SignalR extension, from Newtonsoft to System.Text.Json.
So, I've changed a few lines, from this
using var sr = new StreamReader(req.Body);
using var jsonTextReader = new JsonTextReader(sr);
var data = JObject.Load(jsonTextReader);

to this
var data = await req.ReadFromJsonAsync<object>();

and now it works again.
I know you shouldn't use JObject directly, but anyway this seems like a breaking change that should be documented.
Thank you for your support, I think you can close the issue.

@fabiocav is there a document to explain clearly what needs to be done to send a message to a group or a specific user in the group? We have employed the approach quite similar to @danielegiallonardo's to create a group of users to send out a message but no messages were received on the client side.
Also, the following code is supposed to send out a message to all connected users and it does but the message is null  on the client side:
	[Function("SendMessageToAllUsers")]
	[SignalROutput(HubName = "myhub")]
	public static async Task<object> SendMessageToUserAsync(
					[HttpTrigger(AuthorizationLevel.Anonymous, "get", "post")] HttpRequestData req,
					FunctionContext executionContext)
	{
		var logger = executionContext.GetLogger("Messages");
		logger.LogInformation("C# HTTP trigger function processed a request.");
		var message = await req.ReadFromJsonAsync<object>();
		return new
		{
			target = "newMessage",
			Arguments = new[] { message }
		};
	}

This is the client's code after a successful negotiation which receives null message from the function above while we are happy to see that "newMessage" was raised:
connection.On<object>("newMessage", message =>
{
	Console.WriteLine($"{DateTime.Now} - Received the following message: {message}");
});

Also, the following function never sends out a message to the group's user because the client code is not raised:
	[Function("SendMessageToUserInGroup")]
	[SignalROutput(HubName = "myhub")]
	public static async Task<MessageOutput> SendMessageToUserInGroupAsync(
		[HttpTrigger(AuthorizationLevel.Anonymous, "post", Route = "sendMessagetoUser/{group}/{userId}")] HttpRequestData req,
		string group,
		string userId,
		FunctionContext executionContext)
	{
		var output = new MessageOutput();
		var message = await req.ReadFromJsonAsync<object>();
		output.Notifications.Add(new()
		{
			userId = userId,
			groupName = group,
			target = "sendMessage",
			arguments = new[] { message }
		});
		output.Response = req.CreateResponse(HttpStatusCode.OK);
		return output;
	}

It is really frustrating to see that the entire signalR application used to work in the function app v3 in .net core 3.1 flawlessly but it cannot simply back to normal after migrating to dotnet-isolated functions> Following different posts on github and days of attempts did not get us anywhere.

@Y-Sindo can you follow up on this issue? Is this now supported, or soon to be supported?

@jviau SignalR extensions feature with Groups is now supported. For the case from Arash-Sabet, I believe it is because the Argument is PascalCase while only the camelCase is recognized.  Now we recommend using built-in types from SignalR extensions suh as SignalRMessageAction to avoid such kinds of problem. The build-in types guarantee to work for the default serialization settings. For more detail about SignalRMessageAction, see https://learn.microsoft.com/en-us/azure/azure-functions/functions-bindings-signalr-service-output?tabs=isolated-process&pivots=programming-language-csharp#send-to-a-user .

Closing as the original case is now supported.


aliasing union tag breaks case analysis

See this example: https://flowtype.org/try/#0C4TwDgpgBAglC8UDepIC4oCICGmA0U2GAzsAE4CWAdgOYC+AUKtAEILLMaYBG+U3JctXpNw0AKrs4AHygsGDAMYB7KqUICokxCjFdcBIllyMGFAGZQAFNm4A6ZgniIemAJTIGUKAHofUZkUACwhFAGtiKBUyMlDgABsQLw07bgZTFTVgDjE6dlszSytHZxdeDyRkvyjsKkBMAmzsYmIIMmzgIOxG7igKSPlvW1T0hUz1ZgAmfPtmQutJpzL3T29qxVqGwmbW9s7u3v6oCAoO1uShtLogA
Using if (ab.type) directly works, while binding it to a var like const {type} = ab; if (type) results in a type error

We are going to keep this behavior for now. If you want to add support for this we can discuss 👍


Not zoom in Basic Column Chart

Bug report
I don't know if it is a bug but there is no zoom on Basic columns chart ? I set zoom: {
enabled: true, }
But the option doesn't seem to be available on the map, the only thing I can do from the toolbar is to export the map.

https://codepen.io/davideffe/pen/jOBWqQd look at this, I set zoom true but it doesn't appear, why?

Ok, I set xaxis.tickPlacement: 'on' and it works, thank you so much

After zoom there is a option to enlarge rectangles? otherwise there is a lot of white space between them after zooming

In a category chart, the bars will not expand to fill the white space. It happens only in the numeric/datetime x-axis.
To change the toolbar position, try setting CSS
.apexcharts-toolbar {
  right: auto;
  left: 0
}


Bug 2060068: check securityGroupIDs for emptiness

Now we check securityGroups parameter, which contains a list of SG filters. Instead, we shoud check the list of IDs that we get from the server.

/bugzilla refresh

/retest

/retest


fix luasnip's snippet loading

the snippet is not loaded on this configuration. and there are bugs on windows.
see detail: https://github.com/L3MON4D3/LuaSnip/issues/1168
force specifying snippet path works on both windows and linux.

I never realized the plugin is not loaded! Thanks so much for this @atauzki . Fixed this in 218bf9b.


Dirty repo

Updating sexpr-wasm in a pre-built repo causes the following error:
sexpr directory already exists
subprocess.check_call(`git fetch`, cwd=`/b/build/slave/linux/build/src/src/work/sexpr-wasm-prototype`)
subprocess.check_call(`git checkout origin/master`, cwd=`/b/build/slave/linux/build/src/src/work/sexpr-wasm-prototype`)
error: Your local changes to the following files would be overwritten by checkout:
	src/wasm-flex-lexer.c
Please, commit your changes or stash them before you can switch branches.
Aborting

Are in-tree builds expected to be clean?

Hm, the version of flex you're using must be generating a different wasm-flex-lexer.c. I like having those generated files checked in, so you don't need flex/bison installed. But maybe I should be more clever in the build system about using pre-generated files.

That's from the waterfall :-)
I think it's on every change, the first time it happens. Subsequent ones
are OK.

This should be fixed when I land the cmake branch: https://github.com/WebAssembly/sexpr-wasm-prototype/tree/cmake. Holding off for now, while we push through the other binary format fixes.

The cmake branch landed, so this should be fixed.


[FEATURE REQUEST] Gonum integration

Is your feature request related to a problem? Please describe.
Currently math operations are really slow.
It's better just use battery included gonum
Describe the solution you'd like and provide pseudocode examples if you can

Update bunch of internal math operations
Operate with matrices (*mat.Dense), not [][][]float64. Stacked matrices is just []*mat.Dense
Update DoActivation() on layers.
Update BackPropagate() on layers.
Update constructors.

Describe alternatives you've considered and provide pseudocode examples if you can
...or just optimize Matrix operations (lot of time and reinvent the wheel)
Additional context
Need to add mention about gonum's authors and theirs license

Closed due #18
A lot of code was migrated from naive implementation to gonum's one.
It contains workarounds in graphivz, import, export and optimizations also.


Game Browsing UX

#493

Okay, so here's browsing right now. There's no filtering.
I'm thinking of adding a 2nd row for the filters, but visual wise 2 rows of dark icons wont be that great looking. So in this issue I'm looking for feedback how to make the 2 rows look decent and be useful.
My current thought is making the 1st row (the row you see right now), give it a light background, and use the dark style (what you see now) for the filtering options.
[All] [Jam] [Compo]

Currently the only filters that are supported (not visible to the user) are those above. I.e. show all games, all jam, all compo. Also, each of those is just listing all games in reverse order.
For now, once coolness calculating is working, I can just make those sort by coolness. But later on we need to give choices, to filter by coolness, popularity, date published, etc.
And the other important detail: filtering needs to be mobile friendly.
I'm thinking of a drop-down box, merging all, jam, compo in to a single drop down, and making the sorting order another one. I would imagine that's all the width used on Mobile.
In addition, we need to be able to filter by tags. That probably goes on the next line (one of those rows of (x) Tag Name things). That and a button to add a new filters.

Not sure how useful Steam is as reference, but it is an example of tag filtering.

One obvious thing, just to have it mentioned here is platform support / web as something to filter on.

Closing this, and moving to #867


Conduct accessibility review

Create GitHub Issues for each a11y failing found

I'll do a few of these :)


change gowin platform to use nextpnr-himbaechel

Over at Apicula we're migrating from nextpnr-gowin to nextpnr-himbaechel, and this updates Amaranth to use the new target.
The old target was based on nextpnr-generic and had longstanding problems such as long load times and occasional miscompiles. The new target is implemented as a microarchitecture in nextpnr-himbaechel and is significantly faster, robuster, and already has more features than the old target. Only timing-driven synthesis is still in the works, after which the new target will be pretty much a superset of features.
This PR is slightly breaking in that the end user needs to install the new nextpnr target, but should otherwise be largely compatible. The only change is that if you're passing custom Apicula-specific arguments they need to be changed from --option value to --vopt option=value.
I have confirmed that this successfully builds a blinky on Tang Nano 9K with python -m amaranth_boards.tang_nano_9k

If you rebase this branch it should work again.

Also, please update the commit message so that it follows our conventions (starts with vendor._gowin:  in this case).

Please add a changelog (docs/changes.rst) entry since it's a breaking-ish change.

I took an educated guess at the correct changelog formatting


Datepicker locale support and separator for locale "DE"

Select one ...  (check one with "x")
[x] bug
[ ] feature request
[ ] enhancement

Expected behavior
The application locale setting causes the clrDate picker to respects the correct separator for locale "DE" to be the correct format ("dd.mm.yyyy" instead of "dd/mm/yyyy")
I think one of the following solutions could be done

clrDate uses the correct separator for each locale
date format can be configured (using attribute like data-dateformat="dd.mm.yyyy")
separator can be configured (using attribute like data-separator=".")

The current implementation in clarity/src/clr-angular/forms/datepicker/providers/date-io.service.ts at toLocaleDisplayFormatString  uses "/"
Or is there any other possibility atm to have this "overwritten" from outside (tried to extend/overwrite the directive/service but did not work)
Actual behavior
The separator is still "/" instead of "."
Environment details

Angular version: 5.2.8

Clarity version: 0.11.8

OS and version: macOS latest

Browser: [all]

@marcojahn: We already have an issue filed for this. Please subscribe to https://github.com/vmware/clarity/issues/2072 for more info. Thanks!

which one is the duplicate ?
https://github.com/vmware/clarity/issues/2056 ?

@marcojahn: #2055


Namespace for Client model

I encountered some namespace conflicts when using the client class. I think it's desirable to specify the namespace for all the Client constant appearing in the code. Thanks.

i have a proposed change for this by using a rails 3.1 mountable engine which will isolate the models into the Devise::Oauth2Providable namespace and all database tables will be prefixed with oauth2.
the changes are available on the mountable-engine if you would care to review.

Looks like you deleted the Clients management, is that not something you like to be included out of the box ?

correct.  i don't forsee this gem supporting client management out of the box.  since client management is highly subject to the needs of each application, it does not seem like a general concern to be included in this gem and it is well outside the scope of the oauth2 spec.
see issue #17 for more discussion.

Makes sense. Thanks for your explanations.


Add Aggregator interface and implement fake aggregator

Builds upon #32, which in turn builds upon #34, so merge those first.

Thanks again! addressed the comment

@Kubuxu new commits in the PR removed code from previous commits. Probably much better to check files changed instead of reviewing commit by commit.


feat: 'always on top' for agility overlay

Adds a configuration toggle that forces the agility overlay to draw on ALWAYS_ON_TOP. This is useful for mouse alignment during black-out scenes.
Enabled:

Disabled:

Black Scene Example:

Feel free to close if it's not inline with the agility plugin -- can create a external plugin if need be!

As a feature this seems fine, though the use of saveOverlay to trick it into rebuilding the layers seems like a hack. If anything I would just remove+add the overlay since that would be enough and seems more straight forward.


Prometheus targets dont work

Targets as defined in the job are not working as they are described. Figure it out

You cannot start the server without either environment variables set to make the connection or a configuration file passed to it. If you can switch it to be able to start without those being passed you are golden.

Fixed in this commit https://github.com/frenchtoasters/vcd_exporter/commit/6de6743bfaf96eda5c1838a115ac398615db83ee


[FEATURE REQUEST - EDITOR] Project & Scene Management

Description
As per #112, I propose we develop a way to handle project and scene management with an editor.
Requirements

Project should have the ability to created, opened and saved within the editor.
Scenes should have the ability to created, opened and saved within the editor.
A project explorer tool window should show all resources within the projects folder.

This should sync up with changes made on disk, to ensure that the project explorer keeps up to date.
You should be able to open up scenes shown within the project explorer.
The project explorer should have a right click context menu to have the ability to

Create, open, cut, copy, paste, delete resources (cut, copy, paste and delete should be generic)

FluentValidation like so
public class CreateProjectRequest
{
    public string Name { get; init; }

    public string Location { get; init; }
}

Then just create validation for the request, which will be used in the view model
public class CreateProjectRequestValidator : AbstractValidator<CreateProjectRequest>
{
    public CreateProjectRequestValidator()
    {
        RuleFor(x => x.Name).NotNull();
        // etc
    }
}

Now the validator can be used in the view model AND the services layer, this ensures much less duplication of validation logic. The only downside is there might be a fair few validation classes, but as long as they're managed and reused wherever possible this should be okay.


Make email optional

I found that the SNS cloudformation stack errored if I tried to set email to be "". This makes it so the cloudformation stack can handle email being empty.
This also adds the topic ARN as an output, so you can link it up to whatever you choose.

@aknysh Rebased.


UrlObject full refactoring

Specifying/modifying on the fly. Currently only properties are used, and it's not always convenient to set params in place etc.
Additionally should be improved the logic:

[ ] host can contain all the following values: host, port, path, params and sharpy
[ ] path can contain all the following values: path, params and sharpy
[ ] params can contain all the following values: params and sharpy
- The priority is from top to bottom: host > port > path > params > sharpy
- All the values within the higher priorities must override/replace values of the lower ones
[ ] String versions of paths and params must be parsable (Only string values, strings in arrays must be encoded, not parsed)

Diagram explaining the HTTP(S) handling of urls

Code quality and lots of inconsistencies must be fixed.


netlify dev --port flag does nothing?

Describe the bug
I have a local go server running on port 8000 (<IP_ADDRESS>:8000) that I'm trying to interact with. I can't seem to change the Gatsby port to something other than 8000.
To Reproduce
Steps to reproduce the behavior:
If I run without a flag, it fails as expected:
$ netlify dev
◈ Netlify Dev ◈
◈ Injected build setting env var: CROWDIN_API_KEY
◈ Injected build setting env var: GITHUB_TOKEN
◈ Injected build setting env var: GATSBY_ALGOLIA_APP_ID
◈ Injected build setting env var: GATSBY_ALGOLIA_SEARCH_KEY
◈ Injected build setting env var: ALGOLIA_ADMIN_KEY
◈ Function builder netlify-lambda detected: Running npm script build:lambda
 ›   Warning: ◈ This is a beta feature, please give us feedback on how to improve at https://github.com/netlify/cli/
◈ Function builder netlify-lambda building functions from directory src/lambda
◈ Function builder netlify-lambda finished building functions from directory src/lambda
◈ Functions server is listening on 57437
◈ Starting Netlify Dev with gatsby

   ┌─────────────────────────────────────────────────┐
   │                                                 │
   │   ◈ Server now ready on http://localhost:8888   │
   │                                                 │
   └─────────────────────────────────────────────────┘

yarn run v1.22.5
$ gatsby develop

Something is already running at port 8000

If I run with a port specified, it fails in the same way (it just hangs on that last message):
$ netlify dev -p=6000
◈ Netlify Dev ◈
◈ Injected build setting env var: CROWDIN_API_KEY
◈ Injected build setting env var: GITHUB_TOKEN
◈ Injected build setting env var: GATSBY_ALGOLIA_APP_ID
◈ Injected build setting env var: GATSBY_ALGOLIA_SEARCH_KEY
◈ Injected build setting env var: ALGOLIA_ADMIN_KEY
◈ Function builder netlify-lambda detected: Running npm script build:lambda
 ›   Warning: ◈ This is a beta feature, please give us feedback on how to improve at https://github.com/netlify/cli/
◈ Function builder netlify-lambda building functions from directory src/lambda
◈ Function builder netlify-lambda finished building functions from directory src/lambda
◈ Functions server is listening on 57517
◈ Starting Netlify Dev with gatsby

   ┌─────────────────────────────────────────────────┐
   │                                                 │
   │   ◈ Server now ready on http://localhost:6000   │
   │                                                 │
   └─────────────────────────────────────────────────┘

yarn run v1.22.5
$ gatsby develop

Something is already running at port 8000

Configuration

If possible, please copy/paste below your netlify.toml.

[build]
  # Directory to change to before starting a build.
  # This is where we will look for package.json/.nvmrc/etc.
  # base = "project/"

  # Directory (relative to root of your repo) that contains the deploy-ready
  # HTML files and assets generated by the build. If a base directory has
  # been specified, include it in the publish directory path.
  publish = "public"

  # Default build command.
  command = "yarn build"

  # Directory with the serverless Lambda functions to deploy to AWS.
  functions = "public/lambda"

Please enter the following command in a terminal and copy/paste its output:

npx envinfo --system --binaries --npmPackages netlify-cli --npmGlobalPackages netlify-cli

$ npx envinfo --system --binaries --npmPackages netlify-cli --npmGlobalPackages netlify-cli

  System:
    OS: macOS 10.15.5
    CPU: (8) x64 Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz
    Memory: 88.65 MB / 16.00 GB
    Shell: 5.0.7 - /usr/local/bin/bash
  Binaries:
    Node: 10.19.0 - ~/.nvm/versions/node/v10.19.0/bin/node
    Yarn: 1.22.5 - /usr/local/bin/yarn
    npm: 6.14.8 - ~/.nvm/versions/node/v10.19.0/bin/npm
  npmGlobalPackages:
    netlify-cli: 2.65.6

Expected behavior
I expect the port flag to allow me to set a different port OR netlify dev should offer to run the app at another port instead, like running yarn start on a Gatsby app currently does:
$ yarn start
yarn run v1.22.5
$ gatsby develop

Something is already running at port 8000
? Would you like to run the app at another port instead? › (Y/n)

Is there a separate server running that we're not able to customize?

Hi @samajammin, netlify dev sets up a server in front on Gatsby's dev server and redirects relevant requests to it.
--port specifies the port for netlify dev, not for Gatsby's dev server.
You can use targetPort to let netlify dev know that Gatsby is not running on the default port:
https://cli.netlify.com/commands/dev
Adding the following to your netlify.toml file should work:
[dev]
  framework = "#custom"
  targetPort = 6000
  command = "gatsby develop -p 6000"

Thanks @erezrokah!


[fixed] background from Xresources is off

I'm using xresources to setup colors and the background color is totally off compared to vanilla st or urxvt.
I use the same base16 theme in vim and it works fine within vim, the moment I quit vim the color is off again.
Using gruvbox-light-medium

Fixed, it was related to the opacity, I just put it back to 1 and it fixed the problem


Remove the type catalog generator

The type catalog generator was written by @daxian-dbw because we do not have AppDomain.GetAssemblies(), which is tracked in dotnet/corefx#1784. If we can get this API exposed by .NET Core, then the entire type catalog generator can go away.

@andschwa : Is this still relevant

@HemantMahawar Yes; assigning to @daxian-dbw for any further follow-up.

Workaround in place, not ideal, but no pressing need to do this work yet.

@daxian-dbw Could you please add comment why we can not remove the type catalog and close the issue?

PowerShell Core allows the user to use any .NET Core framework built-in types without knowing whether the assembly containing that type is loaded. Also, tab completion for type names also depends on it.
If the assembly is not loaded, powershell load the assembly for you because it's able to figure out which assembly the type is in through the type catalog.
AppDomain.GetAssemblies cannot help us do that because it only returns loaded assemblies. Therefore, we need to keep the type catalog.


Users should be able to reference the right balances on blockscout

Expected Behavior
They should be the same
Current Behavior
for 0x0456e7B4B6A7E25f167f4EBEB17B7268E36af4F8 and 7059f5038a97cb70f37c73fadae11b83dca982a8 the balances fetched from RPC are different than the values from blockscout. They are my validator and validator group so these are my rewards
on baklavastaging

What I have been able to find out so far: all the token transfers are stored, but updating the current balances stopped working after block 13140.

So looks like the error that showed in the logs caused it
iex(1)> 2019-11-26T01:42:55.126 [error] Task #PID<0.3879.5> started from Indexer.Block.Realtime.Fetcher terminating
** (Postgrex.Error) ERROR 22023 (invalid_parameter_value) payload string too long
    (ecto_sql) lib/ecto/adapters/sql.ex:621: Ecto.Adapters.SQL.raise_sql_call_error/1
    (explorer) lib/explorer/chain/events/publisher.ex:13: anonymous fn/3 in Explorer.Chain.Events.Publisher.broadcast/2
    (stdlib) maps.erl:232: :maps.fold_1/3
    (explorer) lib/explorer/chain/events/publisher.ex:12: Explorer.Chain.Events.Publisher.broadcast/2
    (explorer) lib/explorer/chain/import.ex:128: Explorer.Chain.Import.all/1
    (indexer) lib/indexer/block/realtime/fetcher.ex:209: Indexer.Block.Realtime.Fetcher.import/2
    (indexer) lib/indexer/block/fetcher.ex:201: Indexer.Block.Fetcher.fetch_and_import_range/2
    (indexer) lib/indexer/block/realtime/fetcher.ex:292: Indexer.Block.Realtime.Fetcher.do_fetch_and_import_block/3
Function: &Indexer.Block.Realtime.Fetcher.fetch_and_import_block/3
    Args: [13346, %Indexer.Block.Fetcher{broadcast: :realtime, callback_module: Indexer.Block.Realtime.Fetcher, json_rpc_named_arguments: [transport: EthereumJSONRPC.HTTP, transport_options: [http: EthereumJSONRPC.HTTP.HTTPoison, url: "http://<IP_ADDRESS>:8545", http_options: [recv_timeout: 600000, timeout: 600000, hackney: [pool: :ethereum_jsonrpc]]], variant: EthereumJSONRPC.Geth], receipts_batch_size: 250, receipts_concurrency: 10}, false]

I'll try to find a way to just ignore it first, and then try to find out if we can get rid of it.


Unable to build with sources

Hi, I am really enjoy using the standalone tensorboard tool!
However, I found that the latest master branch of the tensorflow library does not contain "tensorflow/tensorboard", thus when I run "installer.sh", it fails to compile.
Since the master branch is quite unstable and prone to change, I suggest that cloning a specific stable version of tensorflow instead of the latest version.
Say the stable version is r1.2, it could be easily fixed by changing the line
git clone https://github.com/tensorflow/tensorflow
with
git clone -b r1.2 https://github.com/tensorflow/tensorflow.
Seeing the situation again, it seems that the separation of tensorboard from tensorflow is permanant, thus it'd be better fixing the installation script to run with the separated tensorboard repo.

@jihunchoi Thanks for your report. Please refer the code here https://github.com/zihaolucky/tensorboard-distro/blob/master/travis_installer.sh#L14-L18 to resolve your issue.
I'm going to change the backend to tensorflow/tensorboard and change our project name to tensorboard-lite once we finish the refactor, the interface won't change.

@jihunchoi I've updated the script yesterday, can you build it from source now?


Delete .travis.yml

After #12207, we are going to switch atom/atom to use CircleCI. The web hook remains in-place for existing pull-requests, but from now on we won't be building new PRs on Travis.

So long, pal...


New line formatting issue for right-to-left languages

There is a slight formatting issue for right-to-left languages when a newline is required.
Sample Arabic text with correct (expected) formatting:

How it looks in the exported PDF:

The text itself looks correct (direction and word order), but the shortest line comes first.
Expected behavior:
The last line should be the shortest.

Possibly, this is related to #538.

@seluianova is this the same problem as described and fixed in #620?

@timoludwig yes!

This was fixed by f51bf8721233d10adbd4935ec9b6daea5e7af422


Is there any way to use other engine than InnoDB?

For example, if I wanna use memory engine to manage users' session data,
can I use memory engine other than InnoDB or else for the table?

Hey @lifthus 👋
You can achieve this using the entgql.Annotation option. For example:
// Annotations of the User.
func (User) Annotations() []schema.Annotation {
    return []schema.Annotation{
        entsql.Annotation{
            Options: "ENGINE = INNODB",
        },
    }
}

A Mixin can be useful here to not repeat the same configuration for every entity definition.
Closing, but please feel free to reopen or join our Discord community in case you need more help with this 😎

Thanks! 👍


Change analytics port

Hey, easy question but i cant find information on this:
According to the doc (https://docs.cvat.ai/docs/contributing/development-environment/#cvat-analytics-ports) i need to open the ports 8282 and 8123 to access the analytics web ui.
How do i change the analytics ports?
I only found the clickhouse port in the docker-compose.dev.yml. Correct me if i am wrong but as long i dont use the dev version (i am using v2.12.0) this file gets ignored. So where are they defined?

In production analytics is not exposed outside as far as I remember.
To access it you just enter http://localhost:8080/analytics and nginx proxies you to the right container within the docker network.
So, the request is not really clear.


Navbar Design

do this one as a component

I am Interested this issue can I fix ?

can i fix this issue ?

Please assign me this.

@manojku1803 assigned, now you can work on this issue

can i implement this one

can i implement this one

yah sure


remove msgnum from the logger

We don't seem to be using msgnum, and this has method signatures that
are inconsistent with all other loggers, so it's getting in the way of
upgrading (I think because of tagged logging)

I agree with this change, but I'd like @chessbyte's input.  The usage of msgnum was something always planned for, but never actually written.  Since it's been literally 7 years, I think we can drop it.  I would take this a step further and point out that the majority of the VMDBLogger is not needed because it really was only written to support that msgnum.  Not sure what to do about the other helper methods, like log_hashes.  Really the only thing needed is the Formatter, which can still be used with a "normal" Logger.

Oh and this PR is pretty 1337

@Fryguy I think we could use tagging logging if we want to add stuff like this to the loggers.  I'm not sure how much of this code we can rm though (I'm only rming stuff to get it to work on Rails 4)

Oh and this PR is pretty 1337

TEE HEE. I chuckled at that too.

tagging logging

I've not heard of this before.  You mean this?

I'm only rming stuff to get it to work on Rails 4

Ah ok, yeah.  Thought it might help you in that endeavor if you could whack the whole thing, or at least more of it, like the debug, add, etc. methods.

I've not heard of this before. You mean this?

Yes.  It was a typo.  I blame my fancy keyboard. ;)

YAGNI on the msgnum... if we haven't needed it in several years, let's :scissors: it
We can add it the feature back when we know what we want.  :heart:

Agree on removal of msgnum, if that will simplify the code base.  It came from a desire to categorize expected exceptions - communications vs. database vs. automate errors et al.
Is there anyone who has log parsers that will need to change?  If so, how will their parser be able to differentiate between old version of ManageIQ log vs new ones?

There is one log parser in lib/util and I know @thennesy has a log parser.  However those will still work because this PR is leaving in the [----] at the beginning (for now).

does anyone have a sample set of logs yet implementing this change?  I'd like to take a peek and see how much havoc, if any, this is going to wreak on this log analyzer of mine....

I tried locally and they are identical since the [----] part is still at the front:
[----] I, [2015-01-13T16:35:44.608501 #73535:3fda44465bf0]  INFO -- : This is a cool message!
[----] E, [2015-01-13T16:35:46.888487 #73535:3fda44465bf0] ERROR -- : This is a cool message!
[----] W, [2015-01-13T16:35:48.296122 #73535:3fda44465bf0]  WARN -- : This is a cool message!
[----] D, [2015-01-13T16:35:49.723314 #73535:3fda44465bf0] DEBUG -- : This is a cool message!
[----] F, [2015-01-13T16:35:51.112506 #73535:3fda44465bf0] FATAL -- : This is a cool message!

Thanks.  So I'm safe for the time being!


Typo in file definition when defining collections

📚 Subject area/topic
collections
📋 Page(s) affected (or suggested, for new content)
https://docs.astro.build/en/guides/content-collections/#defining-the-collection-schema
📋 Description of content that is out-of-date or incorrect
I might be reading this wrong... but the example file for the config.ts is called /src/content.config.ts which was very confusing for me because I think it should be /src/content/config.ts
Furthermore, it also not clear why we should refer to other documents via src/pages/blogs and not via a relative path from config.ts.
🖥 Reproduction in StackBlitz (if reporting incorrect content or code samples)
No response

Hi! This is not a typo, this is new for v5! This config file is no longer required to be inside a folder called /content/ and instead is content.config.ts and should be located in the src directory itself.
You can see this in the first step of the instructions to update your collections for the new Content Layer API: https://docs.astro.build/en/guides/upgrade-to/v5/#updating-existing-collections
Hope that helps!


Release 3.21.0

Features

[EPIC] Feature discoverability - Beamer (#3515)
Feat: display threshold in the Safe header (#3604)

Fixes & improvements

fix: clarify nonce warning (#3617)
fix: enable detected wallet (#3612)
fix: Set safeTxGas to 0 when rejecting a tx (#3605)
fix: Only fetch fee history on safe creation if EIP-1559 supported on network (#3593)
Update safe-core-sdk version (#3598)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

21 of 141 (14.89%)  changed or added relevant lines in 18 files are covered.
17 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.4%) to 34.89%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/logic/cookies/store/selectors/index.ts
0
1
0.0%

src/components/List/index.tsx
0
2
0.0%

src/logic/cookies/store/reducer/cookies.ts
1
3
33.33%

src/logic/cookies/utils/index.ts
4
7
57.14%

src/utils/googleAnalytics.ts
4
7
57.14%

src/utils/storage/Storage.ts
1
4
25.0%

src/components/AppLayout/Sidebar/Threshold/index.tsx
0
5
0.0%

src/utils/intercom.ts
0
5
0.0%

src/components/AppLayout/Sidebar/index.tsx
0
11
0.0%

src/utils/beamer.ts
0
27
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/components/AppLayout/Footer/index.tsx
1
90.91%

src/components/CookiesBanner/index.tsx
3
0%

src/utils/intercom.ts
3
0%

src/components/AppLayout/Sidebar/index.tsx
4
0%

src/logic/hooks/useSafeAppUrl.tsx
6
0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
3366

Relevant Lines:
8719

💛  - Coveralls

Something curios that doesn't happen in prod. Check the left sidebar.

Besides those 2 minor things I thing the release branch looks good

The Safe Mobile showing up in the least should be fixed by enabling this wallet on all chains.


Building from the source is broken

Is this a bug report?
Yes
Have you read the Contributing Guidelines?
Yes
Environment
Environment:
OS: macOS Sierra 10.12.6
Node: 5.0.0
Yarn: 0.21.3
npm: 3.3.6
Watchman: 4.6.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4443003
Packages: (wanted => installed)
react: 16.0.0 => 16.0.0
react-native: master => master
Steps to Reproduce

run npm install
run ./scripts/packager.sh

Expected Behavior
❯ ./scripts/packager.sh
./scripts/packager.sh: line 11: ./scripts/.packager.env: No such file or directory
Scanning folders for symlinks in /Users/sandromachado/Desktop/temp/react-native/node_modules (15ms)
┌──────────────────────────────────────────────────────────────────────────────┐
│                                                                              │
│  Running Metro Bundler on port 8081.                                         │
│                                                                              │
│  Keep Metro running while developing on any JS projects. Feel free to        │
│  close this tab and run your own Metro instance if you prefer.               │
│                                                                              │
│  https://github.com/facebook/react-native                                    │
│                                                                              │
└──────────────────────────────────────────────────────────────────────────────┘

Looking for JS files in
   /Users/<user-directory>/Desktop/temp/react-native

Metro Bundler ready.

Loading dependency graph, done.
 BUNDLE  [android, dev] RNTester/js/RNTesterApp.android.js ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓ 100.0% (585/585), done.

I think that this commit introduced the issue.
Actual Behavior
Loading dependency graph, done.
warning: the transform cache was reset.
error: bundling failed: Error: Unable to resolve module `metro/src/lib/bundle-modules/HMRClient` from `/Users/<user-directory>/Desktop/temp/react-native/Libraries/Utilities/HMRClient.js`: Module does not exist in the module map

Reproducible Demo
To get a demo just clone the source code from the master and execute the repro steps.

Applying e048bf1 locally fixed the issue for me.

This is fixed in master.