fix: llama 3.1 405b fp8

Thank you for your contribution, we really appreciate it. The following instructions will help improve your pull request and make it easier to receive feedback. If there are any items you don't understand, don't worry. Just submit the pull request and ask the maintainers for help.
Motivation
Please explain the motivation behind this PR and the goal you aim to achieve with it.
Modification
Briefly describe the changes made in this PR.
Checklist

Ensure pre-commit pre-commit run --all-files or other linting tools are used to fix potential lint issues.
Confirm that modifications are covered by complete unit tests. If not, please add more unit tests for correctness.
Modify documentation as needed, such as docstrings or example tutorials.

# server
python -m sglang.launch_server --model-path meta-llama/Meta-Llama-3.1-405B-FP8 --disable-radix-cache --tp 8

# client
curl http://<IP_ADDRESS>:30000/v1/completions -H "Content-Type: application/json" -d '{"model": "meta-llama/Meta-Llama-3.1-405B-FP8", "prompt": "What the weather is like today?", "max_tokens": 100, "temperature": 0.7}'

before
{"id":"84a8d16010dd44e2b60f6423fe6624d0","object":"text_completion","created":1721835240,"model":"meta-llama/Meta-Llama-3.1-405B-FP8","choices":[{"index":0,"text":"!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!","logprobs":null,"finish_reason":"FINISH_LENGTH: 100"}],"usage":{"prompt_tokens":8,"total_tokens":108,"completion_tokens":100}}

after
{"id":"9257b9d53660410a8ce2f7ffe2c60478","object":"text_completion","created":1721835356,"model":"meta-llama/Meta-Llama-3.1-405B-FP8","choices":[{"index":0,"text":" If we want to know it, we have to look at the sky. If the sky is blue and the sun is shining, we can say that it is fine weather. If the sky is cloudy and it is raining, we can say that it is bad weather.\nIt is not always easy to say what the weather is like. Sometimes the sky is clear and the sun is shining, but the wind is blowing and it is cold. Then we can say that it is windy weather.\nIt is","logprobs":null,"finish_reason":"FINISH_LENGTH: 100"}],"usage":{"prompt_tokens":8,"total_tokens":108,"completion_tokens":100}}

This fix will not affect the output of previously normal models.
python3 playground/reference_hf.py --model  meta-llama/Meta-Llama-3.1-8B-Instruct

python3 -m sglang.bench_latency --model  meta-llama/Meta-Llama-3.1-8B-Instruct --correct --output-len 16 --trust-remote-code

prefill logits tensor([ 5.2266,  2.0352,  1.0605,  ..., -5.2344, -5.2344, -5.2344],
       device='cuda:0')
prefill logits tensor([ 4.9609,  3.5312,  2.2852,  ..., -3.7344, -3.7344, -3.7344],
       device='cuda:0')
prefill logits tensor([10.2500,  3.1348,  2.1699,  ..., -2.6797, -2.6797, -2.6797],
       device='cuda:0')

prefill logits (final) tensor([[ 5.2188,  2.0312,  1.0781,  ..., -5.2188, -5.2188, -5.2188],
        [ 5.0000,  3.5625,  2.3125,  ..., -3.7344, -3.7344, -3.7344],
        [10.1875,  3.1406,  2.1719,  ..., -2.6875, -2.6875, -2.6875]],
       device='cuda:0', dtype=torch.bfloat16)


Add pants-plugins/api_spec to streamline regenerating openapi.yaml

Background
This is another part of introducing pants, as discussed in various TSC meetings.
Related PRs can be found in:

pantsbuild milestone (which includes PRs since #5713)
https://github.com/StackStorm/st2/labels/pantsbuild label (which also includes preparatory PRs that came before adding pantsbuild)

Overview of this PR
This PR improves the DX (developer experience) by wiring up:

the fmt goal to generate st2common/st2common/openapi.yaml if needed (effectively runs st2-generate-api-spec), and
the lint goal to validate st2common/st2common/openapi.yaml to make sure the generated schema is valid (effectively runs st2-validate-api-spec)

This includes creating a api_spec plugin for pants that adds a api_spec target.
Developer Experience
Today, if someone changes one of the files/scripts used to generate our openapi spec, then CI might complain as part of the ci-checks Makefile target, with instructions to Please run "make generate-api-spec". This also gets regenerated any time someone runs the lint or tests Makefile targets, which might be surprising (tests generally shouldn't handle codegen).
In any case, this wires up pants to run st2-generate-api-spec and st2-validate-api-spec at times that are analogous to when the Makefile runs them.
With this PR, we add api spec generation into the fmt goal and validation to the lint goal. Anything that runs under fmt also runs under the lint goal, so we will get two signals about the api spec: (1) whether or not it needs to be regenerated, and (2) whether or not there are validation errors in the spec.
Our api spec is generated from a jinja template, which only does minimal interpolation (populating the values for some of the enums). There are actually quite a few inconsistencies between our models and the api spec, so we will have to refactor the spec, the spec generation, and possibly the models in the future. That refactoring work, however, is out-of-scope for this PR. After we get pants in, it would be excellent to revisit these issues.
In working on this plugin, I discovered that our api spec validation has been broken for awhile, which I fixed in #5709. Part of our custom validation is still disabled because there are so many things in the spec that are out of date. This PR also does not fix that, but it does leave a comment in the pants plugin on how to enable that later.
Fine grained results cache
After someone runs ./pants fmt :: once, they will benefit from the pants' results cache. For the api_spec plugin, here's what that means:
First, the api_spec target in st2common/st2common depends on the generate/validate binaries in st2common/bin:
https://github.com/StackStorm/st2/blob/1856f6108219ebb1a6886afb798fd0f6c97b184c/st2common/st2common/BUILD#L12-L21
If either script (st2-generate-api-spec or st2-validate-api-spec) changes, then pants now knows that openapi.yaml need to be regenerated. Or, in other words, the st2-generate-api-spec file is part of the cache key for st2common/st2common/openapi.yaml. If that file changes, then pants will re-run the generator.
st2-generate-api-spec is a python script, and we use pants' python dependency inference. So pants (effectively) also adds the python files imported by st2-generate-api-spec to the cache key. Stepping through the code, we can see what pants would infer:
https://github.com/StackStorm/st2/blob/1856f6108219ebb1a6886afb798fd0f6c97b184c/st2common/bin/st2-generate-api-spec#L18
https://github.com/StackStorm/st2/blob/1856f6108219ebb1a6886afb798fd0f6c97b184c/st2common/st2common/cmd/generate_api_spec.py#L22-L26
https://github.com/StackStorm/st2/blob/1856f6108219ebb1a6886afb798fd0f6c97b184c/st2common/st2common/util/spec_loader.py#L21-L26
Here we reach the few things that get interpolated into the Jinja Template:
https://github.com/StackStorm/st2/blob/1856f6108219ebb1a6886afb798fd0f6c97b184c/st2common/st2common/util/spec_loader.py#L30-L35
Now, if anyone changes any of these files, or any of the python bits that get imported to help define things in them, then the next time someone runs the lint goal (or in CI) they will find out that they need to run the fmt goal.
Developing pants plugins
Pants has extensive documentation on the plugin API, including how to create targets, how to write rules, and there are even mini tutorials about how to add a linter or a formatter (adding formatters/linters is a very common thing plugins to do).

Plugins overview
The Target API
The Rules API

Processes (running subprocesses in pants plugins)

Add a linter
Add a formatter
Testing Plugins

@amanda11 Thanks for the feedback. I think I've addressed your comments.


fix lua53Packages.lua

Motivation for this change
Recent reworking broke lua53Packages.*, root cause
being that lua53Packages.lua didn't have the overrides
needed for the build to succeed.
Instead of overrideAttrs, just plumb the needed additions
directly into the mkDerivation call.

Check lua53Packages.lua builds successfully
Check lua53Packages.lua and lua5_3 are same derivation

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I never use lua5XPackages and in fact I wonder if they shouldn't be removed since when overriding lua or python from overlays, they are not updated and need to be "re-set" via for instance :   python3Packages = python3.pkgs;. They don't bring anything to the table.
I like the idea of chaining override/overrideAttrs but I don't know enough of the details to know when it can break.
Anyway I'll merge this to prevent further problems.


Split Travis env variables onto separate lines via global config

I have tried to do this previously, which -- without the global option -- triggered Travis's "build matrix" functionality, which was not what I want. I just want to trigger a single build, which is what (I think) this accomplishes, while also allowing the variables to be split onto separate lines, for better clarity/readability.
I saw that this global config option is available when looking at these docs https://docs.travis-ci.com/user/speeding-up-the-build/#rspec-parallelization-example for an unrelated reason.

Part of the reason that I wanted to make this change is because it just touches one YAML file -- no Ruby, JavaScript, Vue, CSS, HAML, etc files -- and so we skip many of our tests/checks (per many PRs that I've made today).
The result is a really fast build time (relatively speaking to our historical build times):
https://travis-ci.org/github/davidrunger/david_runger/builds/697121209

About the first 90 seconds of that is just setting up the environment (Ruby, node, yarn, Postgres, npm packages, gems, Redis, Chrome, etc...); it's only the last 44 seconds or so that is actually spent running the test suite. Not bad, if you ask me!


[macOs] shortcut keys for Hide Others menu is not consistency

On the macOS by default, the keyboard shortcut for the Hide Others menu is option+cmd+h.
Currently, the Tauri app is using option+cmd+w, which does not seem consistent with other apps.

A good resource to check our shortcuts might be https://github.com/alacritty/alacritty/pull/4958

resolved in https://github.com/tauri-apps/tao/pull/447


Optimize stats collection

Right now it is linear and the more containers you have the longer it
will take to finish the stats collection loop.  We can do this
concurrently with some workers because the collection is still IO bound
for reading all the files.
This gives a small perf gain, 20%, for a lower number of containers but helps more noticeably with higher numbers of containers.
Signed-off-by: Michael Crosby<EMAIL_ADDRESS>

Hmm... It makes sense, but this also makes containerd go from 20% CPU utilization (with 100 containers running and calling stats on all) to 100% utilization and huge load averages.... but also my fans don't cause my laptop to float with this 100% utilization like it does without this change.

I'll close for now.


chore: downgrade semantic-release

Semantic release uses node 18
Can be reverted once we use Node 18 in CI

@kdamball For running tests in CI, I would use the minimum supported version of the library. If we use Node 18, we risk using features that are not available in older versions of node.
With this PR I just wanted to get the CI green again.
In general, we should be more explicit about the compatibility of this library, but that's out of scope for this.


Node built-in module functions are getting undefined under vue-cli

Version
3.5.1
Reproduction link
https://github.com/FabioOliveira1/minimal
Environment info
  System:
    OS: Linux 4.15 Ubuntu 18.04.2 LTS (Bionic Beaver)
    CPU: (8) x64 Intel(R) Core(TM) i7-4710HQ CPU @ 2.50GHz
  Binaries:
    Node: 10.15.0 - /usr/local/bin/node
    Yarn: Not Found
    npm: 6.4.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 71.0.3578.98
    Firefox: 65.0.1
  npmPackages:
    @vue/babel-helper-vue-jsx-merge-props:  1.0.0-beta.2
    @vue/babel-plugin-transform-vue-jsx:  1.0.0-beta.2
    @vue/babel-preset-app:  3.5.1
    @vue/babel-preset-jsx:  1.0.0-beta.2
    @vue/babel-sugar-functional-vue:  1.0.0-beta.2
    @vue/babel-sugar-inject-h:  1.0.0-beta.2
    @vue/babel-sugar-v-model:  1.0.0-beta.2
    @vue/babel-sugar-v-on:  1.0.0-beta.2
    @vue/cli-overlay:  3.5.1
    @vue/cli-plugin-babel: ^3.2.0 => 3.5.1
    @vue/cli-plugin-eslint: ^3.2.0 => 3.5.1
    @vue/cli-service: ^3.2.0 => 3.5.1
    @vue/cli-shared-utils:  3.5.1
    @vue/component-compiler-utils:  2.6.0
    @vue/eslint-config-standard: ^4.0.0 => 4.0.0
    @vue/preload-webpack-plugin:  1.1.0
    @vue/server-test-utils: ^1.0.0-beta.28 => 1.0.0-beta.29
    @vue/test-utils: ^1.0.0-beta.28 => 1.0.0-beta.29
    @vue/web-component-wrapper:  1.2.0
    eslint-plugin-vue: ^5.0.0-0 => 5.2.2
    vue: ^2.5.22 => 2.6.9
    vue-cli-plugin-vuetify: ^0.4.6 => 0.4.6
    vue-eslint-parser:  2.0.3
    vue-hot-reload-api:  2.3.3
    vue-loader:  15.7.0
    vue-router: ^3.0.1 => 3.0.2
    vue-style-loader:  4.1.2
    vue-sweetalert2: ^1.5.9 => 1.6.4
    vue-template-compiler: ^2.5.22 => 2.6.9
    vue-template-es2015-compiler:  1.9.1
    vuetify: ^1.3.0 => 1.5.6
    vuetify-loader: ^1.0.5 => 1.2.1
    vuex: ^3.0.1 => 3.1.0
    vuex-persistedstate: ^2.5.4 => 2.5.4
  npmGlobalPackages:
    @vue/cli: Not Found

Steps to reproduce
npm i
npm run serve
-- Open in browser
-- Open inspector,   there will be the logs of crypto as object and the scryptSync as undefined
What is expected?
scryptSync as a function, since it's a built in node module
What is actually happening?
scryptSync is undefined

I am not sure if this is caused by vue cli or by one of its dependencies, but at my searching I found something related here

Since you can't use native nice modules in the browser, those will always be undefined.

I can use crypto, except for some properties (e.g. scrypt, scryptSync). In the minimal project showed the crypto object. Now I even used other functions from it and pushed to the example repo.

What behaviour did you expect?
I expected to have all properties/functions present at crypto

Scrypt is written in native code, not JavaScript. It can not run in the browser. Webpack cannot bundle it with your JavaScript, and a browser can't run it.

My bad, thank you

Webpack can be provided with polyfills: https://webpack.js.org/configuration/node/
The specific case of scrypt is a little complicated though. There's a browserify shim that might need some adjustment: https://github.com/crypto-browserify/scrypt
Hope this helps someone.


⚠ Empornium has degraded performance

In 18822ec, Empornium ($EMP) experienced degraded performance:

HTTP code: 503
Response time: 1075 ms

Resolved: Empornium performance has improved in c253c39 after 6 minutes.


Support control which buckets specific pod can mount

/feature
Is your feature request related to a problem? Please describe.
According to this doc it means I need to authorize the S3 CSI addon which buckets it can mount to pods, the problem is I don't want different pods be able to mount limited set of buckets but not all buckets the addon can mount.
Assuming I have 3 distinct projects hosted in EKS, they have their own set of assets and config files stored in S3. Project B should not mount Project A's bucket and potentially touches or views what are inside.
Describe the solution you'd like in detail
Is it possible to use EKS Pod Identity or allowing us to specific which role to use on mounting S3 buckets annotating in PVC?
Describe alternatives you've considered
Additional context

Thank you for the request. I am going to close this as a duplicate in favor of these issues:
https://github.com/awslabs/mountpoint-s3-csi-driver/issues/136
https://github.com/awslabs/mountpoint-s3-csi-driver/issues/111
Please comment on those or open a new issue if they do not address your use case or there is additional detail you would like to add.


Help screen, Share app and Bluetooth

The PR is:

separating Help screen and update with latest designs and copy
adding share dialogue to share the app. (With link google.com because we don;t have share URL yet)
improving Bluetooth permission check to force the user give the app BT permission before registering
adding logic to present BT error screen when Bluetooth is turned off or the permission was disabled for the app.

Wrong GitHub user 🙄


probem when table is in a if condition

Hello I have some problem with the new @handsontable-angular: 4.0.0
my table is in a condition: *If
<ng-container  *ngIf="viewTable">
<hot-table [hotId]="2" [columns]="columns" [settings]="settings" [data]="persons">

the first time he's instantiating everything is fine,
But when my *if become false then true the setting is not set properly anymore
its principally on the contextMenu and on the afterOnCellMouseDown
At the original init my afterOnCellMouseDown work fine I receive the good value :
afterOnCellMouseDown: (core, events, coords, td)
Then my table disappears and reappears I receive
afterOnCellMouseDown: (undefined, core, events, coords)
The second time it disappears and reappears I receive
afterOnCellMouseDown: (undefined, undefined, core, events)
Third time it disappears and reappears I receive
afterOnCellMouseDown: (undefined, undefined, undefined, core)
for the contextMenu, it is only available on the first instance
Im trying to reproduce in stackblitz but on stackblitz it never reappears, only the first instance work
https://stackblitz.com/edit/angular-ugu92s?file=src%2Fapp%2Fapp.component.ts
navigator: chrome 73
handsontable: "7.0.0"
@handsontable/angular: "4.0.0"

Hey @brynnlow if it does not happen in the online example it usually is related to other libraries and frameworks in the project. Have you tried to detach them to tests?

its not the problem who never reappears in the exemple but the table, try to click hide button twice

preview-0b556b90ee0bcb987321b.js:1 ERROR TypeError: Cannot read property 'updateSettings' of undefined
at init (app.component.ts:34)
at eval (hot-settings-resolver.service.ts:48)
at ZoneDelegate.invoke (zone.js:391)
at Object.onInvoke (ng_zone.ts:273)
at ZoneDelegate.invoke (zone.js:390)
at Zone.run (zone.js:150)
at NgZone.run (ng_zone.ts:171)
at eval (hot-settings-resolver.service.ts:48)
at eval (hot-settings-resolver.service.ts:48)
at ZoneDelegate.invoke (zone.js:391)
console.(anonymous function) @ preview-0b556b90ee0bcb987321b.js:1
17:27:58.358 preview-0b556b90ee0bcb987321b.js:1 Unable to display error. Open your browser's console to view.
console.(anonymous function) @ preview-0b556b90ee0bcb987321b.js:1
17:27:58.358 preview-0b556b90ee0bcb987321b.js:1 ERROR CONTEXT DebugContext_
console.(anonymous function) @ preview-0b556b90ee0bcb987321b.js:1
17:27:58.841 preview-0b556b90ee0bcb987321b.js:1 ERROR TypeError: Cannot read property 'destroy' of undefined
at eval (hot-table.component.ts:360)
at ZoneDelegate.invoke (zone.js:391)
at Zone.run (zone.js:150)
at NgZone.runOutsideAngular (ng_zone.ts:218)
at HotTableComponent.ngOnDestroy (hot-table.component.ts:359)
at callProviderLifecycles (provider.ts:575)
at callElementProvidersLifecycles (provider.ts:541)
at callLifecycleHooksChildrenFirst (provider.ts:529)
at destroyView (view.ts:511)
at callWithDebugContext (services.ts:629)

You may want to use the change instead of init, but I do not guarantee it will work. We'd need to investigate this subject.

thanks you for looking, i will try to reproduce exactly my problem in a github exemple

Hi @brynnlow,
there are two connected issues:

I've solved a problem with the inconsistent arguments in hooks' callbacks - #123.
If hook's callback uses a reference to Handsontable instance before the end of this initialisation, then the reference is not defined. I'll solve it in PR.

Thank you for your involvement!

I've encountered this issue as well using wrapper 3.0, handsontable 6.2, and Angular 6.
I managed to reproduce it in a stackblitz: https://stackblitz.com/edit/handsontable-angular-rhospe

Hey @daleclements
@swistach is already doing a great job to fix this issue. I'll ping you up as soon as we fix it and have the changes pushed to the official version of Handsontable.

Hi @brynnlow and @daleclements,
We've just released v5.0.0. Please try the new version and let us know about a result.
Here is @daleclements' demo with upgraded dependencies: https://stackblitz.com/edit/handsontable-angular-opy5sp?file=app/app.component.ts


Add options button to config screen when in mobileview

What
Add options button beside
Note This will become DevicesButton in an upcoming PR with the gear icon
Why
Give mobile users a way to switch devices
How Tested

Desktop
Mobile

This looks awesome!
A thought came to mind at which level of granularity are we exposing isMobile that makes sense?
Does it make sense to expose it at
html? ❌ - solve with media queries and css
react? ❌ - similar to html you would solve this at the css level
component? - 🚧  - it could. Another way we could do this is have the composites pass down specific styles if it was isMobile. The component would always be responsive and the composite could pass down styles to make some of the items render/not render.
composite? ✔ - yes we need to differentiate for those that just need it to work on composites
Not blocking. If we think it makes sense then that sounds great. If we want to do something more complex that would require some changes we have more beta updates to do before we GA :) After GA it would be a breaking change.

This looks awesome!
A thought came to mind at which level of granularity are we exposing isMobile that makes sense? Does it make sense to expose it at
html? ❌ - solve with media queries and css
react? ❌ - similar to html you would solve this at the css level
component? - 🚧 - it could. Another way we could do this is have the composites pass down specific styles if it was isMobile. The component would always be responsive and the composite could pass down styles to make some of the items render/not render.
composite? ✔ - yes we need to differentiate for those that just need it to work on composites
Not blocking. If we think it makes sense then that sounds great. If we want to do something more complex that would require some changes we have more beta updates to do before we GA :) After GA it would be a breaking change.

Currently we only expose it at the composites layer; components should never have a global-style isMobile prop - they should always have specific props e.g. increasedTouchTargets or (as you say) allow styles to be set to make it mobile friendly


Use intmax for base of integral powers

I used int before, because it was simple, and I thought surely it
would be enough.
This brings us to the "Dalton", a unit whose ratio-magnitude numerator
is<PHONE_NUMBER>6050.  The prime factorization of<PHONE_NUMBER>6050 is
(2 * 5 * 5 * 53 *<PHONE_NUMBER>), and this last number is bigger than 2^31
by a factor of 3 or so.
Fortunately, we should have done this from the beginning anyway, because
otherwise there would be numbers we could represent in ratio which we
couldn't represent in Magnitude, and this should never be the case.
Helps #300.  As I work to integrate Magnitude into the various unit
templates, I'll make PRs to "pave the way" for fixing the errors I find.

The build failures are bewildering, and strike me as likely spurious.  For example: https://github.com/mpusz/units/runs/5312780099?check_suite_focus=true#step:12:292
They are complaining about a CMake error with a missing package for wg21-linear_algebra.  I didn't touch CMake, and didn't touch wg21-linear-algebra.  Anybody have any clue how to proceed here?


Highlighter objects remain highlighted if disabled when highlighted

Highlighted objects that are disabled while highlighted will appear highlighted when re-enabled even if they aren't actually being highlighted.
The simple solution to this is to drop this into VRTK_BaseHighlighter:
       void OnDisable()         {             Unhighlight();         }

Fixed with https://github.com/thestonefox/VRTK/commit/ad9f6b97bfc7db61e58ff189886e8cf6ff5eeeb1


Initialization of container "XXXX" failed in NAV 2018

While Creating 2018 Docker Container getting below error message
Script

Error Message

You need to specify -accept_outdated to the command.
And please note, that -licensefile and -shortcuts have a different color, indicating that you have a space after the grave symbol on the line before. See more here:
https://freddysblog.com/2019/08/04/powershell-for-non-experts/
https://freddysblog.com/2019/08/20/business-central-on-docker-for-non-experts/

Yes, their s same unwanted space on parameter list, after removing "space" still same error showed. Then I change the license file now it working.
Thank you Freddydk


[IOTDB-507] Add zeppelin-interpreter module

I love this module so much! I have only a few suggestions : )

I love this module so much! I have only a few suggestions : )

Thanks for your such careful review!


Improved tools: stegano-tools

Fixed symlinks to tools
Added uninstall file

This seems like it would only work when ctftools is installed as the ctf user?

Indeed. I can replace occurrences of /home/ctf with $HOME if you want...

I think that's a good initial solution, yep!

Thanks!


Bump bundled versions of bzip2 and zlib

Currently, the bundled version of bzip2 is 1.0.5, and the current version is 1.0.6. Similarly, the bundled version of zlib is 1.2.5 and the current version is 1.2.8.
I'd be happy to open PRs to bump these versions, assuming you're okay with it, @ladislav-zezula.
(Thanks for StormLib, btw!)

Any work done on that would bring absolutely zero value to anyone.

As is, bzip2 cannot be compiled using emcc, which is the only blocking issue for compiling StormLib with emscripten.
If you don't see any reason to maintain your bundled libs, why are you bundling them in the first place?

why are you bundling them in the first place?
Because they are needed to build the library. Not everyone uses Linux where all the libraries are part of the system.

So the newer bzip2 can be compiled with emcc?

Correct. bzip2 1.0.6 compiles fine with emcc.

Updated in commit 0e138c27d3086061671ca57d8bba62ab14050b5d.
Could you please check if it compiles OK with emcc?

@ladislav-zezula Thanks! I've verified it compiles without error now.


Option to keep chimeric reads after UMI deduplication

Description of feature
Following up on https://github.com/nf-core/rnaseq/pull/1369#discussion_r1744079079.
@MatthiasZepper Please take over this issue.

While reviewing #1369, I noticed that we have set the parameter --chimeric-pairs=discard for umi-tools and wondered if that is actually a good default choice. I planned to briefly discuss that in the #rnaseq_dev Slack channel, but since it is now an official issue, we can also track it here :-)
Purely from a biological view, particularly the transcriptome alignments may comprise a significant amount of chimeric read pairs, simply because of an unannotated splice variant or because of an antisense long non-coding RNA spanning several annotated transcripts. Also, many users use the pipeline on cancer data, where fusion genes or chromosomal rearrangements are to be expected.
However, I have in the meantime read in the UMI-tools FAQ that disabling the option significantly increases the memory demands, so the computational complexity clearly argues for disregarding this complexity by default and leave it to the users of the pipeline to look at chimeric transcripts specifically, if of interest.


[SPARK-49169][BUILD] Upgrade commons-compress to 1.27.0

What changes were proposed in this pull request?
The pr aims to upgrade commons-compress from 1.26.2 to 1.27.0.
Why are the changes needed?
The full release notes:
https://commons.apache.org/proper/commons-compress/changes-report.html#a1.27.0
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.

cc @dongjoon-hyun

Merged to master for Apache Spark 4.0.0-preview2.


Ensure environment map adheres to lazy loading semantics

As of #487 , we will have introduced progress bars, the notion of loading progress and the notion of new reveal semantics. However, we still need to ensure that environment maps are not aggressively loaded if the user has appropriately configured <model-viewer> to indicate that they would rather defer loading the environment map until the last possible moment.

This is something we just bumped into this morning. For our shops that initially have model-viewer elements hidden, the environment map still gets generated and eats up 200-300ms of time even if not viewer is visible.
IMO environment map generation should happen on viewer loading.

How detailed is the environment map that is being generated? If it doesn't contain high frequency details (think the "ambient" sort of light in Apple's QuickLook) then spherical harmonics / light probe could be an alternative to PMREM. Light probes are now supported in threejs https://github.com/mrdoob/three.js/pull/16223 An option could be to pre-compute the spherical harmonic coefficients offline and then store them in model viewer as the default. These coefficients comprise just a few vectors (think a few bytes at most) and easily embedded directly into the codebase.

@richardmonette 👋 I think you and @elalish could have an enriching (for the rest of us) discussion on this topic :)
@pushmatrix we can definitely defer generation of the environment map, we just don't right now. I scheduled it for v0.9.0, let's chat if you think it should land sooner!

0.9 works :)

@elalish we could just load the spherical harmonics coefficients https://github.com/mrdoob/three.js/blob/dev/src/lights/LightProbe.js#L10 directly If you have an example of the env map we want to use as the default I've got some command line tools we can use to generate the sh coef.

@pushmatrix Agreed, but was that timing for 0.7 or master? Since #856 landed the generation time should also be quicker. If you have a chance to test it, I'd like to see what result you get.

@richardmonette Thanks, however SH has enough resolution only for the diffuse portion of the reflection, not the specular (even for a blurry env-map like our generated one). Additionally, I'm actually not happy with SH even for diffuse light when it comes to HDR environments. More on this later when I've finished my current set of rendering improvements.

0.7, I'll test master

Thanks, however SH has enough resolution only for the diffuse portion of the reflection, not the specular (even for a blurry env-map like our generated one).

Agreed, one last thought before I drop it, what if you used it as a progressive loading intermediate step, so the user would see the model sooner, with some lighting while PMREM finished in the background?

Possible, but I think there are simpler solutions. I'd like to spend some time improving our startup performance, and I think there may be more significant gains simply by organizing the threads to do more work in parallel with the networking and such.

Just to offer a compromise view, at the limit we will want to wring out every last drop of time we can to get our TTFI down. In that world, I can definitely imagine us relying on lower-fidelity intermediate lighting from SH while we generate something that looks nicer.
That said, the devil is in the details: what is the practical consequence for fidelity? I suspect folks are just as likely to be annoyed by a "flash of low-fidelity lighting" as they are by an extra second (possibly more) of load time. It's something that warrants experimentation.
It's also worth mentioning that we don't have a great tooling story to help folks generate SH for their own environment lighting (yet).

@elalish Tested the speed difference between 0.7.2 and master in terms of env map rendering, and it seems like it shaves off 40ms.

@elalish I don't do anything fancy with perf testing. I just use the performance monitor in Chrome.
Here's a glitch running master: https://sugary-bathroom.glitch.me/

And then I compare it with one running 0.7.2: https://spurious-ringer.glitch.me/

Probably lots of factors coming into play here, so the results do have a +/- 20ms to them.

Thanks, that’s helpful, because I see a very different trace. What device /
GPU are you testing on?
On Mon, Nov 11, 2019 at 8:18 AM Daniel Beauchamp<EMAIL_ADDRESS>wrote:

@elalish https://github.com/elalish I don't do anything fancy with perf
testing. I just use the performance monitor in Chrome.
Here's a glitch running master: https://sugary-bathroom.glitch.me/
[image: Screen Shot 2019-11-11 at 11 15 32 AM]
https://user-images.githubusercontent.com/190692/68602635-b786be80-0474-11ea-990d-2c0cb9ae3b73.png
And then I compare it with one running 0.7.2:
https://spurious-ringer.glitch.me/
[image: Screen Shot 2019-11-11 at 11 17 41 AM]
https://user-images.githubusercontent.com/190692/68602768-f3218880-0474-11ea-8bfd-6fee835c8002.png
Probably lots of factors coming into play here, so the results do have a
+/- 20ms to them.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleWebComponents/model-viewer/issues/490?email_source=notifications&email_token=AAMS2LFI72BTWTHHBG7VOGLQTGAWFA5CNFSM4HGQ2MM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDXKJOA#issuecomment-552510648,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMS2LC2GL6Y5KCYGXMH2K3QTGAWFANCNFSM4HGQ2MMQ
.

Pretty sure this is working these days.


[FAB-17897] Document /version endpoint

Signed-off-by: Brett Logan<EMAIL_ADDRESS>

Not sure if you want to add a bullet point to the overview at the top of the file as well for supported capabilities of the operations API.

Not sure if you want to add a bullet point to the overview at the top of the file as well for supported capabilities of the operations API.

Yep, I'll edit to add it to the top, thanks

@caod123 Updated the top of the file as well


Question: What is the status of touch support for this plug-in?

[ ] I'm reporting a bug, not asking for help
[x ] I've looked at the documentation to make sure the behaviour is documented and expected
[x ] I'm sure this is a Leaflet Draw code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[ ] I've searched through the issues to make sure it's not yet reported

What is the status of touch support for this plug-in when used with Leaflet 1.0.x? What browsers/platforms are supported and what ones aren't? Based on reports made by others and my own experiences, the use of touch devices is not working properly on all platforms for Leaflet 1.0.x. Previous versions of this plugin used to work on all touch platforms under Leaflet 0.7.7 and my hope is that it will again for Leaflet 1.0.x (this is a GREAT tool!!)
Our desire is to port to Leaflet 1.0.3 but can't until the issues with this plug-in are resolved for touch environments, specifically Android/Chrome and iOS/Safari.
Thank you in advance,
Dave

Drawing squares doesn't work well on my Samsung S8 with the latest 1.0.3 version and leaflet.draw 0.4.9:
https://jsfiddle.net/yv1x9aay/1/
That works well with the older version:
leaflet 0.7.2 and leaflet.draw 0.2.4-dev
https://cdn.rawgit.com/michaelguild13/Leaflet.draw/master/examples/basic.html

I think a lot of the touch problems are due to one of the more recent
PRs... try one of the earlier 0.4.x releases, like 0.4.4 or 0.4.2, I seem
to remember it was working better then.
Joe
On Mon, May 8, 2017 at 10:48 PM, Andreas Adelsberger <
<EMAIL_ADDRESS>wrote:

Drawing squares doesn't work well on my Samsung S8 with the latest 1.0.3
version and leaflet.draw 0.4.9:
https://jsfiddle.net/yv1x9aay/1/
That works well with the older version:
leaflet 0.7.2 and leaflet.draw 0.2.4-dev
https://cdn.rawgit.com/michaelguild13/Leaflet.draw/
master/examples/basic.html
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Leaflet/Leaflet.draw/issues/713#issuecomment-300067613,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAzNEqgweHyRjHc56xYe1X-gJnUYxr8bks5r3_5DgaJpZM4M85iN
.

Just to add some more info, the most recent version I can get to work is 0.3.2 (but that doesn't support leaflet 1.x).
There's also more info about the problem (still not much though) in #679 and #709.

Can confirm that touch works for drawing rectangles with Leaflet 0.7.7 (https://jsfiddle.net/t0whecyx/) but is very buggy with Leaflet 1.0.3 (https://jsfiddle.net/j9L27bn3/) on both Google Chrome v. 60.0.3112.101 and Internet Explorer v. 11.0.44.  Both fiddles use Leaflet.draw 0.4.10 and the code from the main Leaflet.Draw github page.


examples: Remove unused microk8s DS YAMLs

The documentation refers to cilium-microk8s.yaml, so these are
unnecessary. Remove them.
Fixes: #8523

This change is

test-me-please


(maint) Update ruby build for windows

Ruby builds were linked against an updated version of openssl. Use those
for the windows builds.

:+1:

:+1:


Crash with OOM when getCroppedImage()

is there something to do if I want to fix this issue at Bitmap.createBitmap (293Line)

Resize bitmap before load to CropImageView ... In the below code I am resizing the image width to screen width based on aspect ratio
Bitmap mBitmap= BitmapFactory.decodeFile(path);
int width=context.getResources().getDisplayMetrics().widthPixels;
float factor = width / (float) mBitmap.getWidth();
mBitmap = Bitmap.createScaledBitmap(mBitmap, width, (int) (mBitmap.getHeight() * factor), true);
cropImageView.setImageBitmap(mBitmap);

hi @ghost thanks for your comment i tried your solution but its re sizing but losing quality. how can i resize without losing quality?

I am also see lots of this oom errors happened in my app.
Has there any fix just in CropImageView.java?

@tyson512 Have you get a solve about this?


Bug: Evaluation Emissions Data

Issue:
Received CRIT1 error on 2022 Q2 emissions.
Steps to Recreate:

Check out Limestone unit LIMI1
Import 2022 Q1 and Q2 emissions from historical data
Evaluate Q1 and Q2

Private Zenhub Image

Not able to reproduce the Error.

Confirm if still a bug on dev and stg.

On dev, evaluation of 2022 Q1, Q2 data was successful - only HOURGEN-13-B was generated for both quarters.

Verifying the issue is fixed.  Imported 2022 Q1 and Q2 emissions of Limestone LIMI1.  Ran EM evaluation on both quarters.  Received  'Informational Message' Eval Status.


[SPARK-29020][WIP][SQL] Improving array_sort behaviour

What changes were proposed in this pull request?
I've noticed that there are two functions to sort arrays sort_array and array_sort.
sort_array is from 1.5.0 and it has the possibility of ordering both ascending and descending
array_sort is from 2.4.0 and it only has the possibility of ordering in ascending.
Basically I just added the possibility of ordering either ascending or descending using array_sort.
I think it would be good to have unified behaviours and not having to user sort_array when you want to order in descending order.
Imagine that you are new to spark, I'd like to be able to sort array using the newest spark functions.
Why are the changes needed?
Basically to be able to sort the array in descending order using array_sort instead of using sort_array from 1.5.0
Does this PR introduce any user-facing change?
Yes, now you are able to sort the array in descending order. Note that it has the same behaviour with nulls than sort_array
How was this patch tested?
Test's added
This is the link to the jira

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Yes, I think we can't change the behavior here along the way. The null ordering would have to stay as it was

cc @ueshin

@srowen we couldn't make an alias between sort_array and array_sort because they don't have the same null policy, it would change the behaviour of array_sort.

@ueshin yeah I agree, the bigger question is, why do we have both array_sort and sort_array?
@kiszk looks like you added array_sort to match Presto in https://issues.apache.org/jira/browse/SPARK-23921 . Presto supports a comparator function rather than an ascending flag.
If sort_array does what we want already, and is the older method here, why not make array_sort an alias for it? We could deprecate one, but which one? sort_array has been around longer, but array_sort is at least the name in one other system.
Overall I'd just like to avoid duplicating the implementation, at least, even if both are supported as the function name.

@srowen we couldn't make an alias between sort_array and array_sort because they don't have the same null policy, it would change the behaviour of array_sort.

I see, is it that the ordering of nulls is different?
I think we'd at least want the doc of each to comment on the difference with the other very similar method, to make this clear. I suppose one day we may add control over null ordering and deprecate one in favor of the other.

I see, is it that the ordering of nulls is different?
I think we'd at least want the doc of each to comment on the difference with the other very similar method, to make this clear. I suppose one day we may add control over null ordering and deprecate one in favor of the other.

Okay @srowen , I'll explain the ordering of nulls for all as they are now:
sort_array in ascending order nulls are at the beginning
sort_array in descending order nulls are at the end
array_sort in ascending order nulls are at the end
And after the PR:
sort_array will remain the same
array_sort in ascending order nulls are at the end
array_sort in descending order nulls are at the end
So this way the actual behaviour of array_sort remains the same.

Yeah, I guess it's unfortunate that the existing null ordering semantics aren't the same, or else these could be unified. Later, maybe we can expose control over that too and then deprecate one in favor of fully specifying the desired ordering in the other.
But for now I'd just add a little bit of documentation pointing out that the behavior is different between array_sort and sort_array.

I think it would be good to have array_sort to be able to order in both ways, all the array function from 2.4.0 are "array_something" and it's kind of confusing to have sort_array.
I think it would be great to have that unified.

As the original motivation, we might want to support a comparator function rather than an ascending flag to follow Presto. I think the null ordering is also following Presto, btw.
How about adding the comparator function here instead? Then we can make sort_array as Unvaluable and replace it to array_sort with appropriate comparator in Analyzer in the following PRs. I'm not sure we should deprecate sort_array in that case, though.
WDYT?

I agree with @ueshin 's opinion about array_sort. It would be great to add the comparator function instead of a flag. The bigger picture of https://issues.apache.org/jira/browse/SPARK-23921 is to follow array_sort function as Presto implements.

+1 of @ueshin's

How does it translate for this PR @ueshin ?

Add a Lambda expression for comparator instead of another column asc in array_sort. See array_sort(array(T), function(T, T, int)) -> array(T) at https://prestodb.github.io/docs/current/functions/array.html
In order to expose it in functions.scala, you can refer https://github.com/apache/spark/pull/24232.

I've added some changes to add array_sort as HOF. I've followed https://prestodb.github.io/docs/current/functions/array.html for the tests. Actually 4 out of 6 cases are working. Sill have to figure the null handling out.
There's lot of things to improve still, this is a working version but not the best.
Some names are temporary.

@Gschiavon @ueshin Sorry for confusing you. What I wanted to say is @ueshin 's comment.

ok to test

Can one of the admins verify this patch?

ok to test

Jenkins, test this please.

Test build #110646 has started for PR 25728 at commit f7e7d39.

Test build #110646 has finished for PR 25728 at commit f7e7d39.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110646/
Test FAILed.

Test build #110661 has started for PR 25728 at commit e651094.

@ueshin can you retest please? It was an import, it is fixed.
I also added a test for null values.

Test build #110661 has finished for PR 25728 at commit e651094.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110661/
Test FAILed.

Test build #110662 has started for PR 25728 at commit b32a9fa.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15826/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15830/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15831/
Test PASSed.

@Gschiavon Jenkins will automatically test when you push the new commits from my previous comment.
Let's see what Jenkins says.

Test build #110662 has finished for PR 25728 at commit b32a9fa.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110662/
Test FAILed.

The problem here is the naming of the HOF array_sort.
In the registry  we have this :
 expression[ArraySort]("array_sort")
expression[ArraySorting]("array_sort")
I think names should be different, for example, this is array_zip (arrays_zip in the code)
  expression[ArraysZip]("arrays_zip")
  expression[ZipWith]("zip_with")
Maybe they don't do exactly the same, I'm not sure.
But other examples with the Array HOF would be:
   expression[ArrayFilter]("filter"),     expression[ArrayExists]("exists"),     expression[ArrayForAll]("forall")

Test build #110789 has started for PR 25728 at commit 1422980.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15923/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110789/
Test FAILed.

test this please

test this please

@Gschiavon I think we can remove the existing ArraySort and implement the new one to support both signatures here.
I mean, items from the beginning:

move ArraySort to higherOrderFunctions.scala.
add the new argument to the default constructor.
add a new constructor which has the previous signature and pass the default comparator work as asc to the default constructor.
fix the implementations.

Test build #110808 has started for PR 25728 at commit 1422980.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15940/
Test PASSed.

Test build #110808 has finished for PR 25728 at commit 1422980.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110808/
Test PASSed.

Test build #110909 has started for PR 25728 at commit ad04599.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16026/
Test PASSed.

Test build #110909 has finished for PR 25728 at commit ad04599.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110909/
Test FAILed.

Test build #110913 has started for PR 25728 at commit 7ad574a.

Merged build finished. Test PASSed.

I did this option

remove ArraySort (and rename ArraySorting to ArraySort).

add a new constructor which has the previous signature and pass the default comparator work as asc to the default constructor.

fix the implementations if needed.

Test build #110913 has finished for PR 25728 at commit 7ad574a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110913/
Test PASSed.

Test build #111240 has started for PR 25728 at commit 0c65ff8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16313/
Test PASSed.

Test build #111240 has finished for PR 25728 at commit 0c65ff8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111240/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16502/
Test PASSed.

Test build #111469 has started for PR 25728 at commit adf0e0e.

Test build #111469 has finished for PR 25728 at commit adf0e0e.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111469/
Test FAILed.

@Gschiavon Did you address multiple @ueshin 's comments?

Some of them yes @kiszk , but I was having some troubles with the tests. I'll try to do them soon.

@kiszk This is my problem while making tests for the new signature.
I want to test case class ArraySort(argument: Expression, function: Expression)
And I don't know how to pass the comparator function parameter without registering the UDF, like forexample:
val func: (Expression, Expression) => Expression = (x, y) => if(x > y) 1 ...

Test build #111536 has started for PR 25728 at commit 2224354.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16551/
Test PASSed.

Test build #111536 has finished for PR 25728 at commit 2224354.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111536/
Test FAILed.

ping @ueshin @kiszk

@Gschiavon Sorry for late reply. I am taking off half of this week.
Do you want to see this testcase?

No problem @kiszk .
Hmm I think is a different case. Im trying to do this:
 lazy val comparator: (Expression, Expression) => Expression = (x, y) => {       if (x < y) 1       else if (x == y) 0       else -1     }
and then:
 checkEvaluation(sort(a0, comparator), Seq(1, 2, 3))
But I can't compare 2 expressions, and I don't know how to do this part

@ueshin @kiszk How can we move forward with it? I think there's only that test missing, the rest is working and it is tested. Let me know!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17413/
Test PASSed.

Test build #112445 has started for PR 25728 at commit 92586cc.

Test build #112445 has finished for PR 25728 at commit 92586cc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112445/
Test FAILed.

Test build #112660 has started for PR 25728 at commit c836dae.

Merged build finished. Test PASSed.

Test build #112660 has finished for PR 25728 at commit c836dae.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112660/
Test FAILed.

Test build #113376 has started for PR 25728 at commit 6b08cdc.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18276/
Test PASSed.

Test build #113376 has finished for PR 25728 at commit 6b08cdc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113376/
Test FAILed.

Test build #113387 has started for PR 25728 at commit a345142.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18286/
Test PASSed.

Test build #113387 has finished for PR 25728 at commit a345142.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113387/
Test FAILed.

Test build #113440 has started for PR 25728 at commit 7879280.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18335/
Test PASSed.

Test build #113440 has finished for PR 25728 at commit 7879280.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #113450 has started for PR 25728 at commit 2600364.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18343/
Test PASSed.

Test build #113450 has finished for PR 25728 at commit 2600364.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113450/
Test FAILed.

Test build #113460 has started for PR 25728 at commit b031199.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18352/
Test PASSed.

Test build #113460 has finished for PR 25728 at commit b031199.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113460/
Test FAILed.

Test build #113598 has started for PR 25728 at commit 539a223.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18483/
Test PASSed.

Test build #113598 has finished for PR 25728 at commit 539a223.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113598/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18487/
Test PASSed.

Test build #113604 has started for PR 25728 at commit 0186def.

Test build #113604 has finished for PR 25728 at commit 0186def.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113604/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18497/
Test PASSed.

Test build #113613 has started for PR 25728 at commit 89653bc.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113613/
Test FAILed.

Test build #113620 has started for PR 25728 at commit 2d673f9.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18506/
Test PASSed.

Test build #113620 has finished for PR 25728 at commit 2d673f9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113620/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18513/
Test PASSed.

Test build #113630 has started for PR 25728 at commit e8ec00d.

Test build #113630 has finished for PR 25728 at commit e8ec00d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113630/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18521/
Test PASSed.

Test build #113639 has started for PR 25728 at commit 3fe059a.

Merged build finished. Test FAILed.

Test build #113680 has started for PR 25728 at commit 53b563e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18566/
Test PASSed.

Test build #113680 has finished for PR 25728 at commit 53b563e.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113680/
Test FAILed.

Jenkins, retest this please.

Test build #113721 has started for PR 25728 at commit 53b563e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18601/
Test PASSed.

Test build #113721 has finished for PR 25728 at commit 53b563e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113721/
Test PASSed.

Test build #113749 has started for PR 25728 at commit 7c38b8a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18627/
Test PASSed.

Test build #113749 has finished for PR 25728 at commit 7c38b8a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113749/
Test PASSed.

ping @kiszk

Test build #113964 has started for PR 25728 at commit ef28d4f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18830/
Test PASSed.

@Gschiavon Sorry for being late since I made a business trip. I left a few comments.

No problem @kiszk ! I just made some changes based on your comments!

Test build #113964 has finished for PR 25728 at commit ef28d4f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113964/
Test PASSed.

Merged to master.


Is there any guidance to use terraform IaC Codes with AzureDeployment environment ?

We were trying for  the GitOps flow for our developers  with ADE, so that we can make use of our existing terraform codes with GitOps method using AzureDevops Repos as catalogs repo. We followe the MS documents and which is not stating anything about how to use or configure terraform IaC codes with the AzureDeployment Environment.

Hi @vivuu1989
Terraform support is currently in private preview, as is Bicep Support. You must be registered with the preview for these features to work, and details on how to consume these features are provided as part of the preview onboarding process. If you are interested in signing up, please contact<EMAIL_ADDRESS>for further guidance on getting onboarded.


Fix Nix install instructions

Old instructions did not work.

Thanks for the fix. I believe nixpkgs still has the old version (v0.2.0). @MoritzBoehme could you please update it?

The latest release is a release candidate, so I don't know if this will be pr should be updated in nixpkgs. I will make a pull request regardless.


Add actual map size reporting.

Fixes issue #200

Why use "Final map size" in quiet mode. Also, the environment command line page needs to be updated.

Why use "Final map size" in quiet mode

Mostly it's no harder for the script to parse, easier for the human and doesn't add a conditional in the code.
Ah, didn't see the quiet mode description in the command line page. It's already wrong in a few different ways, but I'll give a pass at fixing it.

If users specify the seed and the actual map size (as reported here) in a new game, will they get the same map as when specifying the same seed and the original/requested map size?  Remember, halite environment can now choose a map size when not specified, so users might not even know what was requested.  Replay-ability is important.  If putting actual map size results in a different map, we probably also want to report the requested map size.  It's an oversight on my part that we haven't already been reporting requested map size.

From my reading of the code (and one test ;) ) the same map is guaranteed to result from using the actual map size or the initially requested map size (or any size in between).

I took out Final map size: for the time being for the sake of consistency.


Add static of accessor methods to ColorScheme and TextTheme

The most common use case to lookup a ThemeData instance using Theme.of(context) is to access either the ColorScheme, the TextTheme, or both.
Before this change:
final colors = Theme.of(context).colorScheme;
final textTheme = Theme.of(context).textTheme;

or
final ThemeData(
      :colorScheme,
      :textTheme,
    ) = Theme.of(context);

After this change:
final colors = ColorScheme.of(context);
final textTheme = TextTheme.of(context);

Primary Changes
This PR adds static of convenience methods to ColorScheme and TextTheme that delegate to the ThemeData's respective properties. The methods added are:

ColorScheme.of(context) that returns Theme.of(context).colorScheme.
TextTheme.of(context) that returns Theme.of(context).textTheme.
TextTheme.primaryOf(context) that returns Theme.of(context).primaryTextTheme.

Side-effects
To allow the above changes to function, this PR adds:

A theme.dart import to color_scheme.dart to access to Theme.
A theme.dart import to text_theme.dart to access to Theme.
A package:flutter/widgets.dart import to text_theme.dart to access BuildContext.
The above import allowed getting rid of the same @docImport from text_theme.dart.

Documentation updates
This PR also updates the following documentation elements:

Adds docs to the newly added members.
Updates TextTheme's docs to instruct using TextTheme.of(context) instead of Theme.of(context).textTheme.
Updates Theme.of to add a "See also" section to ColorScheme.of and TextTheme.of since these use cases are among the most common ones for Theme.of(context).

Fixes #72201.
Pre-launch Checklist

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[X] I signed the CLA.
[X] I listed at least one issue that this PR fixes in the description above.
[X] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] I followed the breaking change policy and added Data Driven Fixes where supported.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This looks like a phenomenal change—pulling the color scheme from the theme data is something I do on a regular basis, and the framework does it a lot as well.
But I do have a couple of concerns.
Testing
This pull request needs simple tests—otherwise, in the future somebody could make a change that breaks these new methods and it might go unnoticed.
Tech Debt
At some point, we might want to convert Theme.of(context) so it uses an InheritedModel and can optimize its notifications more effectively. By adding these static methods today, we might incur a "technical debt" in the form of restricting our future options for API design. For instance, if we expand on this concept to cover every aspect of the theme data, it could be more practical to organize them all under the same namespace, like what we do for MediaQuery (i.e. Theme.colorSchemeOf, Theme.textOf, etc).
Overall, I believe the APIs introduced in this PR probably would be the ideal long-term solution… but it's probably best to leave a window to explore all the potential options, rather than landing this one quickly.

I do agree that converting the Theme to an InheritedModel is the way to go here. But since the Theme is so big in scope, I wonder if we can convert the Theme to become an InheritedModel, but introduce the aspects gradually, over multiple PR's? To give some context, the aspect class for MediaQuery is private, so perhaps we could do the following? (if at all possible)

Provide a private aspect class (similar to how MediaQuery works), with only the color scheme aspect for now
Make Theme an inherited model, that uses the private aspect class for the Theme
Use the new aspect for the ColorScheme.of(context) implementation

One problem with this approach is "where do we define the Theme aspect class?", since its usages are probably in different files (i.e. color_scheme.dart). Perhaps using a regular class (so not prefixed with _ in the name) but not exporting it through the material library is a better option?

Perhaps using a regular class (so not prefixed with _ in the name) but not exporting it through the material library is a better option?

I don't think this has been done in the framework before, but I'm a fan!
I'm also toying with the idea of giving public access to the class…
// this PR
final colors = ColorScheme.of(context);
return FilledButton(
  style: FilledButton.styleFrom(
    background: colors.tertiaryContainer,
    foreground: colors.onTertiaryContainer,
  ),
  // ...
);

// eventually:
return FilledButton(
  style: ButtonStyle.aspect(
    surface: const MaterialSurface.tertiaryContainer(),
  ),
  // ...
);

If we had a public API that essentially just contained instructions for how to parse & apply the theme data, it could potentially lead to significant performance gains, as dependency-based rebuilds are pushed into the leaf widgets.
(I have a WIP design doc for this, though progress is on hold until I finish up some stuff in the animation library.)

Do we have an open issue anywhere about the Theme as InheritedModel idea? There's a lot of good discussion here that hopefully we can build on.

Yes indeed!
https://github.com/flutter/flutter/issues/154567


Bug on search bar

When I try to search the drop down list drops with a list of item along with the Keyboard is open. So when I try to select the item from the drop down list at first the Keyboard dismiss and then again I have to select again on the selected option. Why can't it be done in just one step. Like onSelect the item even when the Keyboard is open it should dismiss the Keyboard and at the same time the item should be selected.

Thanks for raising this issue, will be fixed in new version

Has this bug been fixed? I encountered it in version 2.0.5


Handling of %20

Am I right in thinking this library makes no attempt to convert My%20Documents to My Documents? Is that by design?

Yes, I guess this is by design. % is not a valid character, files can be named foo%20bar.txt without any problem.
Even though I see your point, that %20 could be normalized to a space, and other percent-enconded values could be converted as well... But since the goal of this library is simply to generate valid filenames, it does not have to do anything with %20.

Fair enough. What we need is something that approximates to round-tripping between filenames and URIs, and it seems this library isn't it. Yes, of course I know perfect round-tripping isn't possible for the reasons you give, we just have to do the best we can.

You can just run it through decodeURIComponent first, or use https://github.com/sindresorhus/filenamify-url


Question about payments

Hello dear @dveldhoen!
I have a question: When using the package itself, is there some rate limit imposed on my project or is it just being ran locally? So basically the question would come down to: Does using this package come with cost when it's running on my own server?
I hope not, I like using this package, I think it's probably a fair amount for an API but would be way to much for me for software running on my end.
Dear regards,
Snakysnake

Hi, thanks for contacting. It's indeed an API, all the logic and heavy lifting runs on our servers. Currently the rate limit is about 100 invoices/15 minutes, but will soon be aligned with what is posted on NPM 50 invoices/month. For $17,99 you can use it without limits. Please let me know if you need help setting up the apiKey with the paid version. We would greatly appreciate your use of our paid version, since it helps us fund new features. Some great ones are coming soon! Like adding discount and the option to set prices with tax either included or excluded. Kind regards!


Soft hyphens () are output as visible characters

We're character-splitting headlines containing  soft hyphens. Those are usually invisible and act as a hyphenation hint for the browser.
This is how California Dreaming is rendered, note the extra glyph (U+F8FF):

Different font, same issue (here  is rendered as a different glyph):

Is there a way to ignore the s when processing the DOM?
Edit: This is Chrome/macOS. Seems fine on Firefox.

Simply checking for and stripping the offending unicode character (00AD) from contents inside the splitText function works, but then of course the soft hyphen is thrown out completely as if it was never there.
Hm, the unprocessed  would need to be wedged back in between the generated <span class="char">s..


Did we figure out the issue with the expenditures table?

I remember during the code convening you (@palewire) mentioned we didn't have the Expenditure model table loaded because we were refactoring the model itself. Is this still the case?

The model we have is an early draft and, IMHO, needs a heavy rewrite before we do any serious analysis with it.

Got it. Same with contributions then?

I'm just trying to update SQL server here at CIR and I'm looking to figure out how to update some tables. No problem putting this on hold but the higher ups wanna know when I'm gonna update our database

Rewriting this at the moment: https://github.com/california-civic-data-coalition/django-calaccess-campaign-browser/blob/master/calaccess_campaign_browser/management/commands/exportcalaccesscampaignbrowser.py
Too premature you think @palewire?

The contributions model and its field definitions is in much better shape, but we still have some work to do vetting our totals and making sure what we output is 100% correct. Looks at the expenditure model's field names and you'll see what I mean.
If you want an exporter, I say go ahead and do it. Though we really need people who know the system pouring the acid of doubt on our numbers.

Well I can ignore expenditures now and focus on contributions. Though, the more I think about it, exporting the summary table would make more sense for high level summing right? Like, those values are more accurate than the itemized values anyway so we should just export that no?
—
Sent from Mailbox
On Mon, Jan 26, 2015 at 6:22 PM, Ben Welsh<EMAIL_ADDRESS>wrote:

The contributions model and its field definitions is in much better shape, but we still have some work to do vetting our totals and making sure what we output is 100% correct. Looks at the expenditure model's field names and you'll see what I mean.
If you want an exporter, I say go ahead and do it. Though we really need people who know the system pouring the acid of doubt on our numbers.
Reply to this email directly or view it on GitHub:
https://github.com/california-civic-data-coalition/django-calaccess-campaign-browser/issues/176#issuecomment-71579223

Depends what you're after, but for big totals you're only allowed to used
the summaries.
On Mon Jan 26 2015 at 6:34:27 PM Aaron Williams<EMAIL_ADDRESS>wrote:

Well I can ignore expenditures now and focus on contributions. Though, the
more I think about it, exporting the summary table would make more sense
for high level summing right? Like, those values are more accurate than the
itemized values anyway so we should just export that no?
—
Sent from Mailbox
On Mon, Jan 26, 2015 at 6:22 PM, Ben Welsh<EMAIL_ADDRESS>wrote:

The contributions model and its field definitions is in much better
shape, but we still have some work to do vetting our totals and making sure
what we output is 100% correct. Looks at the expenditure model's field
names and you'll see what I mean.
If you want an exporter, I say go ahead and do it. Though we really need
people who know the system pouring the acid of doubt on our numbers.
Reply to this email directly or view it on GitHub:

https://github.com/california-civic-data-coalition/django-calaccess-campaign-browser/issues/176#issuecomment-71579223
—
Reply to this email directly or view it on GitHub
https://github.com/california-civic-data-coalition/django-calaccess-campaign-browser/issues/176#issuecomment-71580191
.


change audio level of speakers individually

#34 Would be fixed by this too

This is technically a dupe of #34


create_on_data_dir is simply a public fn in zingolib

Fixes #21
Note the refactor of ZingoConfig will require refactor in mobile.. which I am looking into now.

I am delaying that refactor.   There're changes on dev in zingolib, unrelated to mving the config that effect mobile.  This should land as is.

Codecov Report

Merging #23 (38679cd) into dev (ddf8261) will increase coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev      #23      +/-   ##
==========================================
+ Coverage   58.22%   58.30%   +0.07%
==========================================
  Files          30       31       +1
  Lines        5838     5830       -8
==========================================
  Hits         3399     3399
+ Misses       2439     2431       -8

Impacted Files
Coverage Δ

cli/src/lib.rs
0.00% <0.00%> (ø)

lib/src/lib.rs
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddf8261...38679cd. Read the comment docs.

This has been open for 10 days.

ACK, sorry for the delay.

Looks good! I am going to test locally but plan to merge shortly!


fine-tunable?

I read in kaggle models specification (https://www.kaggle.com/models/shadiakiki1/birdnetlib) that this is a fine-tunable model
Can you please provide an example on how to do this?
Thanks

Hi!
I'm not sure where kaggle's fine-tunable attribute is coming from, but that applies to the larger BirdNET project. birdnetlib is just one of the libraries that utilizes the models.
You can find information on training the models here at the BirdNET project's repo.


Open edX - Course email subscription concern require confirmation

Although you mentioned that edX emails won't work if a user is unenrolled. Even if that's true we might end up with data inconsistency in case:

Enroll User, Both MITxOnline and edX would have email subscribed (This is fine)
Only unsubscribe from the email through MITxOnline Dashboard
Unenroll the course and then reenroll the course. In this case, we will have Email Subscription=True in MITxOnline but in Edx the email subscription would still be inactive. Let me know if this would not be the case.

Hey @briangrossman, I need your opinion here. Let's suppose a user unsubscribes from the emails against a course and then he unenrolls from the course. So it keeps the database entry against unsubscription. So on the next enrollment, a user will start with unsubscribe emails.
So is that flow acceptable or do we need to automate it? Like on every enrollment we should remove such entries so that users could start with emails subscribed.


Fix refresh_access_tokens documentation

Coverage remained the same at 91.086% when pulling eb4201aee623f742ab8397c64f4f4e318168dfe7 on elmkarami:patch-1 into 4cb2b6da46423bad8b32b85d87f9a97b698144fd on sidecars:master.


Looking for subfolders named "queries"

Not all projects have their queries in a separate repository but have the queries in a subfolder.

@DimitrisAlivas could you point to a repo with such structure? I'm trying to recreate the issue, thanks!

@albertmeronyo Hey Albert. Our trump repo used to have such a structure but Kathrin changed it.
In order to recreate the issue you just need a folder within a repository named "queries".
If you check https://github.com/TRUMP-project/documentation, apart from the folders named "data" etc I had a "queries" folder to store queries and that's when I encountered the issue!
Hope it helps :)

This feature seems to be in demand.

This type of request should be possible using the subdir option or in the worst case with a specification yaml file.
Closing this issue -- if this is still needed and cannot be addressed with these options, please reopen.


Create Mixin-Network.md

There is only incorrect filename

Does the filename correct? :x:
Does this article match Hugo SSG format? :white_check_mark:
Does this article has only allowed sections? :white_check_mark:


export Exact type only once

Is your feature request related to a problem? Please describe.
generates:
    preset: near-operation-file
    presetConfig:
      extension: .graphql.ts
      baseTypesPath: common/generated.ts
    plugins:
      - typescript-operations
      - typescript-react-apollo

I'm using near-operation-file plugin, After upgrading to 1.15.3, all generated files have
export type Exact<T extends { [key: string]: any }> = { [K in keyof T]: T[K] };.
I like to export all generated files in index.ts file, so other component can import it without nested import path.
// index.ts
export * from './a/a.generated.ts';
export * from './b/b.generated.ts';

But the problem is they all export type Exact.
Module './document.graphql' has already exported a member named 'Exact'.
Consider explicitly re-exporting to resolve the ambiguity.ts(2308)

Can we reuse this type instead of define it in every generated files?

Describe the solution you'd like

Define Exact type near Maybe Type, other plugins use this like how they use Maybe.
// generated by near-operation-type plugin

import * as Types from 'some_base_file_base';

export type SomeQueryVariables = Types.Exact<{
  listingId: Types.Maybe<Types.Scalars['Int']>;
}>;

Describe alternatives you've considered

Do not export it.
`type Exact<T extends { [key: string]: any }> = { [K in keyof T]: T[K] };`.

Additional context

You are right, @xiaoyu-tamu . Thank you for reporting this!

I guess the only way to avoid this, it to put the Exact type near Maybe (in typescript plugin).
I've changed it in this PR: https://github.com/dotansimha/graphql-code-generator/pull/4235
@xiaoyu-tamu can you please try the alpha version 1.15.4-alpha-622ea4d0.0?

@xiaoyu-tamu Yes, it works

Fixed in v1.15.4


Outdated pydata-sphinx-theme

Is there any reason for pining pydata-sphinx-theme??
https://github.com/ansys/ansys-sphinx-theme/blob/fd9122541a9fc9f339058a72343955549d755ae9/pyproject.toml#L29
they are already at 0.12 version:
https://github.com/pydata/pydata-sphinx-theme

Ohh... I see....
https://github.com/ansys/ansys-sphinx-theme/pull/155

Yep, that may take some time to resolve... Since there is an ongoing PR already, I'd propose to close this issue.

Issue tracking down this problem: #156
PR tracking down this problem: #155


#104 Task 3 and 4

We made task 4 and 5 (I've runned everything because i have ethernet)

Thank you. @alexanderquispe, Emily and Mariel worked on these tasks too.


Make the access url for services made available in UI.

Rancher server version - Build from master - jun 7
Steps to reproduce the problem:
Deploy a cluster and enable "Sevice Mesh".
Create a project - p1 and assign user1as project member. Log in asuser1. Go to project - p1` and Create workloads, gateway, and virtual service using
demobookservice.txt
Service is available at http://:/productpage .
Currently there is no way to find out what the gateway url is  - http://<gatewayurl>:<port> .
As project owner/project member,  who has no access to the 1cluster-istio` app deployed in "System" project where the gateway url is available as a endpoint.
We should be able to present this access end point in the associated workload/service page.

it means we need to make virtual service, gateway as first class resource in rancher like deployment. That is the first step. Still have a lot of other steps to fix it. It might take two months or even more. So we can not fix it in preview release.

Per @ibuildthecloud, this is not a path that users will use.
An admin or cluster owner/member will have to point a DNS to the gateway.
For the project member,  the virtual service will have the same DNS name and the virtual service will have a destination mapping to the kubernetes service.
We will not make the access URL available in the UI.


chore: Upgrade docusaurus to 2.0.1

@Selflocking plz fix netlify:

Replaced by: https://github.com/casnode/casnode-website/pull/59


More documentation updates

Fixup some sphinx warnings, add an example definition for the "Single Tag" payload, and add a demonstration to the README.

I'll add definitions of all of the Payload: and Returns: which aren't Scroll (which I don't know).

Ok, this is enough for me today.  I ended up doing some reorganization as well, and starting a page documenting application.properties keys (which I won't call "properties" to avoid confusion with, well, CF properties).  I also moved the introduction section to a separate page so that index.rst becomes a short list of links to other resources.


Add typeahead watch plugin

Summary
I love the typeahead so much and think Jest should use it internally too!

Codecov Report

Merging #6449 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6449   +/-   ##
=======================================
  Coverage   63.48%   63.48%
=======================================
  Files         227      227
  Lines        8697     8697
  Branches        4        4
=======================================
  Hits         5521     5521
  Misses       3175     3175
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c1c3b1...6605e4a. Read the comment docs.

sure


fix(enums): Increment enum initializer from previous constant

fixes #97

What did you think of my suggestion to just drop the definitions of these values?

I was suspicious. We do need the enums to be backward-mapped, don't we?
I'll try it and see if anythnig breaks.
On Mon, Mar 14, 2016 at 2:25 PM Evan Martin<EMAIL_ADDRESS>wrote:

What did you think of my suggestion to just drop the definitions of these
values?
—
Reply to this email directly or view it on GitHub
https://github.com/angular/sickle/pull/98#issuecomment-196527475.

We need the non-quoted property names to allow for code renaming, i.e. Closure wants to rename FooEnum.Bar to FooEnum.aahsdj. TypeScript only generates quoted assignments, which do not get renamed, so we have to insert a code snippet with a non-quoted symbol that gets the value assigned.

Ah, right.  This is correct then.

LGTM++, sorry for all the false directions.


Added remote paramater syntax

Added syntax for remote.

Also fixed signal, by making it not need a colon.


onSubmit turns  into

I have a "country" field defined like so:
+afQuickField name="country" options=countries firstOption="Please select"
"countries" is a map of {label, value} objects.
It looks like it should, i.e:

... until I add an onSubmit hook:
Autoform.addHooks('registerUserForm', {
    onSubmit: function() {
        alert('got here');
        console.log(arguments);
    }
});

Adding the hook turns the select box into a textbox field.
Result:

Please provide a MeteorPad or cloneable repo showing the issue. I can't reproduce this with the info you have here.


No module named 'biupsample_naive_cuda'

Hi, and thank you for making this code available!  i am trying to run it on windows, and i see this error when running demo.py:
Traceback (most recent call last):
File "demo.py", line 10, in
from resnet import resnetmat
File "D:\Deep\a2u_matting\a2u_matting-main\scripts\resnet.py", line 16, in
from decoder import *
File "D:\Deep\a2u_matting\a2u_matting-main\scripts\decoder.py", line 6, in
from BilinearModel import InterChannelOperation
File "D:\Deep\a2u_matting\a2u_matting-main\scripts\BilinearModel.py", line 6, in
from Biupdownsample import bidownsample_naive, biupsample_naive
File "D:\Deep\a2u_matting\a2u_matting-main\scripts\Biupdownsample_init_.py", line 1, in
from .biupdownsample import BiupsampleNaive, biupsample_naive, BidownsampleNaive, bidownsample_naive
File "D:\Deep\a2u_matting\a2u_matting-main\scripts\Biupdownsample\biupdownsample.py", line 7, in
import biupsample_naive_cuda, bidownsample_naive_cuda
ModuleNotFoundError: No module named 'biupsample_naive_cuda'
Am I missing a dependency?
Thank you!

hi, have you compiled the code before running demo?


License Auto Update

the LICENSE file should be updated every year.
There is a nice github action to automate it:
https://github.com/FantasticFiasco/action-update-license-year

fixed :)


Modernizes/Fixes main stats project

There were several issues with the main stats project. This project is only used for unit test execution and anyone out there in the world that wants to manually install our stats framework into their app (so, nobody). Originally the project had a static library target and it was updated to a dynamic library target a while back to support frameworks. We never updated the Podfile though to use frameworks. Surprisingly this hadn't broken anything until we added Swift to the project.

CocoaLumberjack gives you the ability to override the macro definition LOG_LEVEL_DEF in order to let you use your own static Int to define a logging level for the project. When enabling modules, however, these macros are scoped to the module (sort of) and overrides don't work right. Scrapped the custom definition and fell back to using ddLogLevel.
I deleted and re-added the framework and unit testing targets. This modernizes all of the build settings to be appropriate to a dynamic library rather than a static library. I'm a moron when it comes to compiler and linker configuration so this was the least stabby option.
Updated a few classes to use the more modern @import ModuleName; syntax in Objective-C because of some compiler warnings.

We'll have to most likely update the shared repo as well to fix the CocoaLumberjack issue.
Needs Review: @bummytime, @jleandroperez, @koke

I deleted and re-added the framework and unit testing targets. This modernizes all of the build settings to be appropriate to a dynamic library rather than a static library. I'm a moron when it comes to compiler and linker configuration so this was the least stabby option.

My kind of fix ;-) I also :+1: @koke's addition to this PR.
For grins, I tried integrating this branch into WPiOS. Looks like the new Common folder is not coming along for the ride:

Not sure if we actually need to create a new subspec in the stats podspec for Common since we ref this pod via its component specs in WPiOS or something else...

So much fun... I've tried a different thing in a0ec243. Now there's nothing to cause problems in the PCH other than Foundation. I've tested the test project, StatsDemo and the app with this and it seems to build and work as expected.

I like it @koke - lets roll with it.
Thanks everyone for the review!


expect statement changes results of downstream expect statements

Version
1.0.0-beta.25
Reproduction link
https://jsfiddle.net/chrisvfritz/50wL7mdz/#&togetherjs=rpijLU9whQ
Steps to reproduce

this code passes with some warnings:

it('should sort tags by id asc and desc', () => {
expect(wrapper.vm.sortType).toBe('sortByIdDesc')
expect(wrapper.findAll(Tag).wrappers[0].props().tag).toBe(tags[1])
wrapper.setData({ sortType: 'sortByIdAsc' })
wrapper.vm.sortType = 'sortByIdAsc'
expect(wrapper.vm.sortType).toBe('sortByIdAsc')
expect(wrapper.vm.filteredTags[0]).toBe(tags[0])
expect(wrapper.findAll(Tag).wrappers[0].props().tag).toBe(tags[0])
})

this code fails on the last expect:

it('should sort tags by id asc and desc', () => {
expect(wrapper.vm.sortType).toBe('sortByIdDesc')
// expect(wrapper.findAll(Tag).wrappers[0].props().tag).toBe(tags[1])
wrapper.setData({ sortType: 'sortByIdAsc' })
wrapper.vm.sortType = 'sortByIdAsc'
expect(wrapper.vm.sortType).toBe('sortByIdAsc')
expect(wrapper.vm.filteredTags[0]).toBe(tags[0])
expect(wrapper.findAll(Tag).wrappers[0].props().tag).toBe(tags[0])
})
What is expected?
one expect statement should not effect later expect statements, when there are no props set or changes made within the expect statement
What is actually happening?
when you comment out the first findAll, the DOM does is not reloaded after changing the sortType, causing the second findAll to fail.
when you uncomment the first findAll, the DOM is reactive to prop changes and the the Tags are reloaded in the correct sort order

though i have not provided a sandbox version, it should be obvious that running an expect statement with no side effects should not alter the behavior of later tests.
in this case, just running that first findAll causes the dom to become reactive in a way that it is not prior to running the expect(findall)

Although I can't verify, because you don't have a reproduction. It sounds like this issue is caused by how Vue Test Utils implements synchronous updates. It will be fixed after Vue 2.5.18 is released, which includes synchronous update mode in core.
A temporary workaround is to run your tests asynchronously:
it("renders", () => {
  let wrapper = shallowMount(demo, { sync: false });
  wrapper.setData({selectedDate: testDate})
  setTimeout(() => {
    wrapper.vm.selectedDate.should.be.equal(testDate)
  done()
  })
});

I'm going to close this issue since there isn't a reproduction, which means I can't verify that the issue is solved or not.

thanks for the confirmation.
using async has improved the reliability of our tests.
looking forward to the next iteration.


loading dataset

I am checking my pgvector database's loading capacity by inserting large-dimension vectors (SIFT100K vectors, 128 dimensions) ...it is taking long time even for 100k vectors and why current max load counts showing 1M even though i am checking with 100K Vectors only

1,910,000 -> 1M


Fixed Archive configuration for iOS

Remove React target from Pods xcproject.
As seen in https://github.com/facebook/react-native/issues/12814

Thanks @christophedro 👍


[osg] Remove broken feature

cc @BillyONeal since you were the person to try patching boost-asio into osg.

cc @BillyONeal since you were the person to try patching boost-asio into osg.

Can you explain what is 'broken' about it?

Can you explain what is 'broken' about it?

a) It does not compile if correctly activated. E.g. the namespace is wrong. The code looks for asio:: stuff and not boost::asio. Patching in a namespace asio = boost::assio is not enough since some symbols are in different boost libraries like error_code etc.
b) it is only activated if it finds boost but it fails to find boost since it does not find boost-asio
It was detected in #32309 since there boost-asio is suddenly found

:sigh: OK


Server Icons are duplicated in sidebar

My Setup

Operating System: Windows 10 Version 1703
App Version: 2.11.0

[x] I have tested with the latest version
[x] I can simulate the issue easily

Description

Since I updated to 2.11.0 the sidebar shows the server icons multiple times (see screenshot). When I hover my mouse pointer over the icons, the additional icons disappear till I move the mouse back. The issue remains even after a reboot, restart or reinstall of the app.

Current Behavior
The server icons in the sidebar are duplicated. The duplicates are not functional. They disapear when the mouse pointer hovers over the original icons.
Expected Behavior
The icons should be displayed only one time on the top of the sidebar.

Duplicate of #744

Duplicate of #744 indeed


Common Clients and Scopes Definitions

Objective is to get as many client-host combinations working as possible. Previously, an update to a client ID, redirect URI, flow type, etc needed to be made in every sample host project. Likewise with scopes. This change DRYs the Clients ans Scopes definitions.

Hi @dkaminski, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

Thanks for the PR. You certainly have brought to light that our config for the samples is not ideal, but we decided that a shared library wasn't the approach we wanted to take. As such, we're reject the PR.
But given your prod, we've taken another approach and hopefully the samples are less painful to keep in sync with the main core config.
Thanks!

Ok sounds good; I realize I should have opened an issue for discussion before submitting that giant PR. I'lI take a look at the changes you guys made.