New+ not working on Windows 11 (French Canada version)

Microsoft PowerToys version
0.85.0
Installation method
PowerToys auto-update
Running as admin
None
Area(s) with issue?
New+
Steps to reproduce
Right-clicking on any folder doesn't bring up the New+ menu
✔ Expected Behavior
New+ menu should be there (as saw in a video about this feature).
❌ Actual Behavior
Contextual menus are the same if New+ feature is turned ON and OFF
Other Software
No response

Does it help if you restart Explorer? /needinfo

Same issue for me.
Windows 10, en-US, used powershell to completely reboot explorer

@GarThor , New+ doesn't work on Windows 10. There should be an infobar in Settings on Windows 10 informing of this. It's not appearing to you?

I see it now.

Doesn't work for me either. Windows 11 Pro 23H2

I use Win 11 23H2 (22631.4169) enUS with PT-BR ABNT2 keyboard. Not sure if it has something to do with language support, though...

Windows 11 23H2, not appearing in full context menu.

#35420  is dup

@jaimecbernardo Does this issue still need Author feedback after what @klueman said?

Windows 11 23H2, not appearing in full context menu.
Restarting the Explorer process does not help. This occurred on both 85.0 and 85.1, and has persisted through many reboots.

New+ is not showing in the contextual menu on Windows 11 23H2 on my side either. Unlike PowerRename by example. Restarts and reboots of Explorer already done.

It's now visible through the context menu after upgrading to v0.85.1. It's a separate 'New +' menu, not an extension of a system 'New' menu.

It's now visible through the context menu after upgrading to v0.85.1. It's a separate 'New +' menu, not an extension of a system 'New' menu.
I personally can't see it. I checked every submenu of the contextual menu after right clicking in an empty directory.

Still not working for me, even on updated Windows 11 24H2

It's now visible through the context menu after upgrading to v0.85.1. It's a separate 'New +' menu, not an extension of a system 'New' menu.

Please see the attached images to #35323
Can you tell us what is your windows language settings? Still trying to pin down if this bug has something to do with it.

This is not needing feedback. We're having many threads opened on the issue closed as dup in favor of this one.
Can some mod stop this auto closing?

@jaimecbernardo Could you please remove the "Needs-author-feedback" tag from this issue. It is getting annoying having to keep coming back here just because this tag is applied.
There have been a constant influx of reports of this issue since the release of 0.85.x
If the topic gets auto-closed due to the OP not giving an answer, the bug might get harder to track, since so many reports were closed as dup in favor of this one.
#35664, #35531 are examples. Dup. Recently reported. Will probably get closed in favor of this one.
#35357 seems to point to a solution only for hebrew, for some reason. Is this a general solution?
Finally, thank you a lot for all the hard work in this amazing program.

It's now visible through the context menu after upgrading to v0.85.1. It's a separate 'New +' menu, not an extension of a system 'New' menu.

It's not

Still not working here, even all updated today:
Windows 11 24H2 - Portuguese (Brazilian)
PowerToys 0.86.0
All drivers updated

Unfortunately, the solution proposed by @cgaarden and approved into 0.86.0 after testing by @stefansjfw in #35357 and #35465 did not solve the issue.
After installing and fully rebooting, no signs of the new+ context menu. Other PowerToys extensions, such as PowerRename show up normally.
Please note that my Windows uses en-US as the default language, but pt-BT (ABNT2) as the keyboard default. Most of the reports I've been collecting here also point to using non-en-US

New+ is only present in Win11 Tier 1 menu (i.e. new context menu):

Is New+ present in Tier1 context menu?
/needinfo

@stefansjfw it is not. Tier 1 is the same as in my original post #35323

@pbargiona Can you run  Get-AppxPackage -Name *powertoys*newplus* from powershell? What is the output?

@pbargiona Can you run  Get-AppxPackage -Name *powertoys*newplus* from powershell? What is the output?

i have the same issue its not showing up in centext menu here is the output
 Get-AppxPackage -Name powertoysnewplus*
RunspaceId             : eb7e8dd0-d071-4d43-b62a-efaf1141c777
Name                   : Microsoft.PowerToys.NewPlusContextMenu
Publisher              : CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US
PublisherId            : 8wekyb3d8bbwe
Architecture           : Neutral
ResourceId             :
Version                : <IP_ADDRESS>
PackageFamilyName      : Microsoft.PowerToys.NewPlusContextMenu_8wekyb3d8bbwe
PackageFullName        : Microsoft.PowerToys.NewPlusContextMenu_<IP_ADDRESS>_neutral__8wekyb3d8bbwe
InstallLocation        : C:\Program
Files\WindowsApps\Microsoft.PowerToys.NewPlusContextMenu_<IP_ADDRESS>_neutral__8wekyb3d8bbwe
IsFramework            : False
PackageUserInformation : {}
IsResourcePackage      : False
IsBundle               : False
IsDevelopmentMode      : False
NonRemovable           : False
Dependencies           : {}
IsPartiallyStaged      : False
SignatureKind          : Developer
Status                 : Ok

@nahid6970 Can you do the following:

disable New+ from PowerToys settings
run Remove-AppxPackage Microsoft.PowerToys.NewPlusContextMenu_<IP_ADDRESS>_neutral__8wekyb3d8bbwe
make sure it's removed - run Get-AppxPackage -Name *powertoys*newplus*
enable New+ from Powertoys settings
open task manager and restart Windows Explorer process
right click several times and see if New+ is there

Thanks In advance

@stefansjfw
 Remove-AppxPackage Microsoft.PowerToys.NewPlusContextMenu_<IP_ADDRESS>_neutral__8wekyb3d8bbwe
 Get-AppxPackage -Name powertoysnewplus*
 nahid on Wednesday at 3:13 PM                                                              0.062s  MEM: 63% (8/13GB)
 {  home } 
there is no output now

@stefansjfw  ok now if i enable it in powertoys it appeared

@stefansjfw  i didnt even needed to kill explorer it just worked after running those commands and then enabling it in powertoys thanks  a lot brother ❤

@nahid6970 You're welcome!
@SirClickALot Could you attach /bugreport here ? Thanks

@SirClickALot  i am also on v0.86 and its working after so long like 1 month ago it worked somehow and then stopped working and now running those commands probably fixed them but still i am thinking it will again not work after i restart the pc i am afraid of restarting my pc

@stefansjfw
PowerToysReport_2024-11-06-15-25-46.zip

@nahid6970 Once you restart your pc eventually, let me know if it still works or not :) It might point out where the issue can be if it's not there after restart

@stefansjfw  ok restarted and its working ❤

@nahid6970 Can you do the following:

disable New+ from PowerToys settings
run Remove-AppxPackage Microsoft.PowerToys.NewPlusContextMenu_<IP_ADDRESS>_neutral__8wekyb3d8bbwe
make sure it's removed - run Get-AppxPackage -Name *powertoys*newplus*
enable New+ from Powertoys settings
open task manager and restart Windows Explorer process
right click several times and see if New+ is there

Thanks In advance

Working now after these steps 👍

@pbargiona Can you run  Get-AppxPackage -Name *powertoys*newplus* from powershell? What is the output?

No output.

run Remove-AppxPackage Microsoft.PowerToys.NewPlusContextMenu_<IP_ADDRESS>_neutral__8wekyb3d8bbwe

Remove-AppxPackage: Deployment failed with HRESULT: 0x80073CF1, Package was not found.
Windows cannot remove Microsoft.PowerToys.NewPlusContextMenu_<IP_ADDRESS>_neutral__8wekyb3d8bbwe because the current user does not have that package installed. Use Get-AppxPackage to see the list of packages installed.
NOTE: For additional information, look for [ActivityId] 355a0321-257a-0009-e3f2-30367a25db01 in the Event Log or use the command line Get-AppPackageLog -ActivityID 355a0321-257a-0009-e3f2-30367a25db01

I noticed 0.85.0 in the command, but I'm using 0.86.0 now.
Decided to fully uninstall and reinstall powertoys through winget.
Still no output to Get-AppxPackage -Name *powertoys*newplus* and the same fail with Remove-AppxPackage Microsoft.PowerToys.NewPlusContextMenu_<IP_ADDRESS>_neutral__8wekyb3d8bbwe
I restarted the PC and the explorer.exe several times.
Still no menu. For some reason, I'm unable to take a Screenshot with the tier1 context menu with Win+shift+s tool

We need a bit more information to really debug this issue. Can you add a "Report Bug" zip file here?  Then drag the zipfile from your desktop onto the GitHub comment box in this issue. Thanks!

Sure, here you are.
PowerToysReport_2024-11-06-14-32-06.zip

@pbargiona Can you try enabling Developer mode from OS Settings -> For developers. After that disable/enable NewPlus, run Get-AppxPackage command again and let me know if you get any output? Thanks in advance!

Also, do you have PowerRename, ImageResizer and FileLocksmith in Tier1 ctx menu?

New+ is only present in Win11 Tier 1 menu (i.e. new context menu):

Why? All other powertoys tools that exist in the right context menu also appear in the full context menu. File Renamer, Locksmith, Image Resizer, etc.
Combined with the fact there's no keyboard activation shortcut, this seems to imply the one and only way to use this tool is from the Windows 11, "tier 1" menu? This makes the tool unusable for users that bypass the Tier 1 menu entirely for the far more useful full one.
But regardless, both this and the Windows 11 restriction should have been put somewhere in the documentation and/or release notes. There was no indication this tool was more restricted than the standard Powertoys tools, and there's no reason for a user to assume it would be any different.

@pbargiona Can you try enabling Developer mode from OS Settings -> For developers. After that disable/enable NewPlus, run Get-AppxPackage command again and let me know if you get any output? Thanks in advance!

Now do I get an output

RunspaceId             : 85aa4159-50b6-450f-b265-9ba99809411d
Name                   : Microsoft.PowerToys.NewPlusContextMenu
Publisher              : CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US
PublisherId            : 8wekyb3d8bbwe
Architecture           : Neutral
ResourceId             :
Version                : <IP_ADDRESS>
PackageFamilyName      : Microsoft.PowerToys.NewPlusContextMenu_8wekyb3d8bbwe
PackageFullName        : Microsoft.PowerToys.NewPlusContextMenu_<IP_ADDRESS>_neutral__8wekyb3d8bbwe
InstallLocation        : C:\Program
Files\WindowsApps\Microsoft.PowerToys.NewPlusContextMenu_<IP_ADDRESS>_neutral__8wekyb3d8bbwe
IsFramework            : False
PackageUserInformation : {}
IsResourcePackage      : False
IsBundle               : False
IsDevelopmentMode      : False
NonRemovable           : False
Dependencies           : {}
IsPartiallyStaged      : False
SignatureKind          : Developer
Status                 : Ok

Also, and more importantly, New+ appears in the Tier 1 context menu now! I disabled Dev Mode and it kept appearing. I'm yet to restart the PC to see if it sticks.

Also, do you have PowerRename, ImageResizer and FileLocksmith in Tier1 ctx menu?

No. Only in Tier 2. Also, I can't get any other program, as Winrar, to show on Tier 1. I kind of hate this in Win 11, just like @klueman
I noticed you do have many programs showing at Tier 1, @stefansjfw. Do I have to Get-AppxPackage context menus for every program I want in Tier1 with Dev Mode on?
Any clue on what might be happening or how could this be linked to language settings in windows, since most (if not all) people reporting this bug had other than enUS languages installed?

New+ is only present in Win11 Tier 1 menu (i.e. new context menu):
Is New+ present in Tier1 context menu?
edit: screenshot attached in previous comment shows old-style ctx menu
/needinfo

New+ is only present in Win11 Tier 1 menu (i.e. new context menu):

Why? All other powertoys tools that exist in the right context menu also appear in the full context menu. File Renamer, Locksmith, Image Resizer, etc.
Combined with the fact there's no keyboard activation shortcut, this seems to imply the one and only way to use this tool is from the Windows 11, "tier 1" menu? This makes the tool unusable for users that bypass the Tier 1 menu entirely for the far more useful full one.
But regardless, both this and the Windows 11 restriction should have been put somewhere in the documentation and/or release notes. There was no indication this tool was more restricted than the standard Powertoys tools, and there's no reason for a user to assume it would be any different.

New+ now appears in Tier 2 for me also. Is this unwarranted?

https://github.com/microsoft/PowerToys/issues/35210#issuecomment-2458269004 @stefansjfw. Do I have to Get-AppxPackage context menus for every program I want in Tier1 with Dev Mode on?

Yes, those packages are basically what bring context menu items for specific tools. So you should have a separate package for New+, PowerRename, ImageResizer, and FileLockmsith.

Any clue on what might be happening or how could this be linked to language settings in windows, since most (if not all) people reporting this bug had other than enUS languages installed?

I'm not sure at the moment how it's linked to OS language. Will keep an eye on this.

New+ now appears in Tier 2 for me also. Is this unwarranted?

No, this is expected.

I am having the same issue and have tried the steps listed in this thread. It appears the package is failing to install at all. I am getting this error when I opened the logs from "Report a bug":
[2024-11-14 16:27:50.866894] [p-13100] [t-13104] [error] Register C:\Users\userid\AppData\Local\PowerToys\WinUI3Apps\NewPlusPackage.msix package failed.
ErrorCode: -2147024891, ErrorText:

Windows 11 Enterprise 23H2 Powertoys v0.86.0
I am having the same issue and have tried the steps listed in this thread. It appears the package is failing to install at all. I am getting this error when I opened the logs from "Report a bug":
[2024-11-14 16:27:50.866894] [p-13100] [t-13104] [error] Register C:\Users\userid\AppData\Local\PowerToys\WinUI3Apps\NewPlusPackage.msix package failed. ErrorCode: -2147024891, ErrorText:

Same Issue here, I use PowerToys on company laptop with pretty strict privacy settings. But other features like File Locksmith or PowerRename are appearing regardless.
[2024-11-19 10:01:27.077839] [p-16076] [t-15588] [error] Register C:\Program Files\PowerToys\WinUI3Apps\NewPlusPackage.msix package failed. ErrorCode: -2147024891, ErrorText: Access is denied.

@nahid6970 Can you do the following:

disable New+ from PowerToys settings
run Remove-AppxPackage Microsoft.PowerToys.NewPlusContextMenu_<IP_ADDRESS>_neutral__8wekyb3d8bbwe
make sure it's removed - run Get-AppxPackage -Name *powertoys*newplus*
enable New+ from Powertoys settings
open task manager and restart Windows Explorer process
right click several times and see if New+ is there

Thanks In advance

Working now after these steps 👍

This worked for me as well.

@nahid6970 Can you do the following:
* disable New+ from PowerToys settings

* run `Remove-AppxPackage Microsoft.PowerToys.NewPlusContextMenu_<IP_ADDRESS>_neutral__8wekyb3d8bbwe`

* make sure it's removed - run `Get-AppxPackage -Name *powertoys*newplus*`

* enable New+ from Powertoys settings

* open task manager and restart Windows Explorer process

* right click several times and see if New+ is there

Thanks In advance

I'm not using the French Canada version, but I had to change Windows display language from English (Australia) to English (United States) for these steps to work. I also had to change the version number to <IP_ADDRESS>. I was having the issue on Win11 Home 24H2 Release Preview. I am also using a PC with Win11 Pro 24H2 Release Preview which already had the display language set to English US, and there was no issue. I'd also previously tried reinstalling PowerToys through winget with no change.


Uart as a transport layer

Hi,
Is is possible to use the json-rpc with uart as a transporter. Do you have any example where transport layer and protocol are separated.
Thank you

Hi, @ahmadwaqaskhilji
Are you referring to this uart? Please provide a link to it.
Transport/protocol separation is following:

Protocol is responsible for a message format, e.g. it defines JSON object with method and args. This is what json-rpc library does, it is not aware of how you transfer the message.
Transport is a way to pass your message to the server and back. It could be either API call (with Django, Flask, Asyncio, etc.) or you could communicate via messaging queue (RabbitMQ, Kafka).


Add Portable PDB check to short circuit Source Indexing (#4617)

Cherry-Pick of Mukul's portable pdb support to releases/m120

@arunkm,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Update third party libraries

Describe the issue:
We need to update following libraries.
net.minidev.accessors-smart_1.2.0.jar -> net.minidev.accessors-smart_2.4.7.jar
yubico-webauthn_1.3.0.wso2v4.jar -> yubico-webauthn_1.10.1.wso2v1.jar
net.minidev.json-smart_2.3.0.jar -> net.minidev.json-smart_2.4.7.jar
org.objectweb.asm.all_5.2.0.jar  -> org.objectweb.asm_9.2.jar
net.sf.ehcache_2.10.4.jar -> net.sf.ehcache_<IP_ADDRESS>.jar
When we updating yubico we are going to use the existing httpclient available in the pack rather than packing a seperate httpclient in to yubico [1]. But yubico 1.10.1 needs latest httpclient-4.5.13. Therefore we need to update the product httpclient version from 4.3.6 to 4.5.13. In order to do that following changes needs to be done as below dependencies depending on each other.
httpclient 4.3.6.wso2v2>4.5.13.wso2v1
http core 4.3.3.wso2v1 -> 4.4.14.wso2v1
httpmime 4.3.1.wso2v2 -> 4.5.13.wso2v1
openid4java  1.0.0.wso2v4->1.0.0.wso2v5
Following details explaining the places where we are packing each libraries and the PRs to update the dependency version.
httpclient
When we update httpclient we need to update following places since httpclient is packed from below places.

repository/components/features/org.wso2.carbon.registry.contentsearch.server_4.7.33/feature.xml:15:
Fixed with https://github.com/wso2/carbon-registry/pull/369

repository/components/features/org.wso2.carbon.event.output.adapter.http.server_5.2.27/feature.xml:7:   -
Fix is already done need to update the analytics-common version 5.2.35 in the product.

repository/components/features/org.wso2.carbon.identity.sso.saml.ui_5.8.19/feature.xml:11:  <plugin id="httpclient" unpack="false" version="4.3.6.wso2v2"/
Fixed with https://github.com/wso2-extensions/identity-inbound-auth-saml/pull/343

repository/components/features/org.wso2.carbon.databridge.agent.server_5.2.27/feature.xml:9:
Fix is already done need to update the analytics-common version 5.2.35 in the product.

httpcore

repository/components/features/org.wso2.carbon.databridge.agent.server_5.2.27/feature.xml:10:
Fix is already done need to update the analytics-common version 5.2.35 in the product.

repository/components/features/org.wso2.carbon.registry.contentsearch.server_4.7.33/feature.xml:16:
Fixed with https://github.com/wso2/carbon-registry/pull/369

repository/components/features/org.wso2.carbon.core.common_4.6.1/feature.xml:44:
Fixed with https://github.com/wso2/carbon-kernel/pull/3056

httpmime
repository/components/features/org.wso2.carbon.registry.contentsearch.server_4.7.33/feature.xml:6:
Fixed with https://github.com/wso2/carbon-registry/pull/369
openid4java
repository/components/features/org.wso2.carbon.identity.provider.server_5.6.0/feature.xml:10:
Fixed with https://github.com/wso2-extensions/identity-inbound-auth-openid/pull/74
ehcache
repository/components/features/org.wso2.carbon.ldap.server.server_6.2.5/feature.xml:6:
Fixed with https://github.com/wso2-extensions/identity-userstore-ldap/pull/49
json-smart, accessort-smart

repository/components/features/org.wso2.carbon.identity.provider.server_5.6.0/feature.xml:11:
Fixed with https://github.com/wso2-extensions/identity-inbound-auth-openid/pull/74

repository/components/features/org.wso2.carbon.identity.provider.server_5.6.0/feature.xml:12:
Fixed with https://github.com/wso2-extensions/identity-inbound-auth-openid/pull/74

repository/components/features/org.wso2.carbon.identity.oauth.server_6.4.111/feature.xml:12:
Fixed with https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/1672

repository/components/features/org.wso2.carbon.identity.oauth.server_6.4.111/feature.xml:23:
Fixed with https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/1672

asm

repository/components/features/org.wso2.identity.utils_5.11.0/feature.xml:6:

repository/components/features/org.wso2.carbon.identity.oauth.server_6.4.111/feature.xml:7:
Fixed with https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/1672

repository/components/features/org.wso2.carbon.humantask.server_4.5.37/feature.xml:13:
Fixed with https://github.com/wso2/carbon-business-process/pull/635

repository/components/features/org.wso2.carbon.bpel.server_4.5.37/feature.xml:12:
Fixed with https://github.com/wso2/carbon-business-process/pull/635

repository/components/features/org.wso2.carbon.identity.provider.server_5.6.0/feature.xml:6:
Fixed with https://github.com/wso2-extensions/identity-inbound-auth-openid/pull/74

Need to change version range of asm in https://github.com/wso2/orbit/blob/master/membrane-soa-model/1.6.0.wso2v2/pom.xml#L60
Fixed with  https://github.com/wso2/orbit/pull/480
Fixed with https://github.com/wso2/carbon-business-process/pull/637

yubico
repository/components/features/org.wso2.carbon.identity.application.authenticator.fido2.server_5.2.8/feature.xml:7:
Fixed with https://github.com/wso2-extensions/identity-local-auth-fido/pull/70
[1] https://github.com/wso2/orbit/blob/master/yubico-webauthn/1.10.1.wso2v1/pom.xml#L88-L91
Component versions update with https://github.com/wso2/product-is/pull/12480

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Support for serviceMonitor

Signed-off-by: Manjunath Shivanna<EMAIL_ADDRESS>

@ErmakovDmitriy Would you mind review this and merge this ? Thank you

Hi @mshivanna,
I am not a maintainer, I can make a review with "Approve" but I am not sure that it will work.
Have you taken a look at the ServiceMonitor match labels, in the "app" label's value?


[Package Issue]: Microsoft.PowerBI Hash mismatch error when attempting to install Microsoft.PowerBI from "winget" public repository

Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue
Installer hash mismatch.
Brief description of your issue
Installer hash does not match
Steps to reproduce
winget install Microsoft.PowerBI
or winget upgrade Microsoft.PowerBI
Actual behavior
Found Microsoft PowerBI Desktop [Microsoft.PowerBI] Version 2.119.666.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://download.microsoft.com/download/8/8/0/880BCA75-79DD-466A-927D-1ABF1F5454B0/PBIDesktopSetup_x64.exe
7.00 MB /  480 MB

19.0 MB /  480 MB
32.0 MB /  480 MB
41.0 MB /  480 MB
52.0 MB /  480 MB
62.0 MB /  480 MB
73.0 MB /  480 MB
82.0 MB /  480 MB
93.0 MB /  480 MB
102 MB /  480 MB
110 MB /  480 MB
118 MB /  480 MB
127 MB /  480 MB
133 MB /  480 MB
141 MB /  480 MB
149 MB /  480 MB
156 MB /  480 MB
163 MB /  480 MB
171 MB /  480 MB
179 MB /  480 MB
186 MB /  480 MB
195 MB /  480 MB
203 MB /  480 MB
211 MB /  480 MB
220 MB /  480 MB
226 MB /  480 MB
235 MB /  480 MB
244 MB /  480 MB
253 MB /  480 MB
261 MB /  480 MB
269 MB /  480 MB
280 MB /  480 MB
288 MB /  480 MB
298 MB /  480 MB
306 MB /  480 MB
314 MB /  480 MB
324 MB /  480 MB
335 MB /  480 MB
343 MB /  480 MB
353 MB /  480 MB
361 MB /  480 MB
370 MB /  480 MB
377 MB /  480 MB
385 MB /  480 MB
392 MB /  480 MB
399 MB /  480 MB
407 MB /  480 MB
414 MB /  480 MB
424 MB /  480 MB
435 MB /  480 MB
442 MB /  480 MB
450 MB /  480 MB
456 MB /  480 MB
463 MB /  480 MB
470 MB /  480 MB
480 MB /  480 MB
Installer hash does not match; this cannot be overridden when running as admin
Expected behavior
Package installation without error (This seems to be happening frequently for this app)
Environment
Windows Package Manager v1.5.1881
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22621.1992
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.20.1881.0

Winget Directories
-----------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Diag…
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\sett…
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled

Screenshots and Logs
No response

Hi @squeekymouse89
The URL always points to the latest version. Because this software has published new version, it case this issue.
I am going to open PR to resolve your issue


Getting MQTT client messages repeatedly on Andrew's robot

While on Doug's network using his MQTT broker ANdrew sees these messages in his console every 30 seconds.
[I][AsyncMqttClient.cpp:674] _sendPing(): PING
[I][AsyncMqttClient.cpp:382] _addBack(): new back #12
[I][AsyncMqttClient.cpp:414] _handleQueue(): snd #12: 2/2
[I][AsyncMqttClient.cpp:424] _handleQueue(): p #12 rel
[I][AsyncMqttClient.cpp:244] _onAck(): ack 2
[I][AsyncMqttClient.cpp:249] _onData(): data rcv (2)
[I][AsyncMqttClient.cpp:267] _onData(): rcv PINGRESP
[I][AsyncMqttClient.cpp:497] _onPingResp(): PINGRESP
Andrew to take things home to see if the messages happen there. If they do not then there is an environment investigation to do at Doug's place.

Confirmed that this is NOT happening on my home network so there must be some environmental difference at Doug's house that causes this.

Now back at Doug's place and the messages are back. This does not appear to be error messages so much as pings going between the robot and something else like maybe the broker. No clue why those only happens to Andrews robot on Doug's network. Doug never sees this message on either network. Not a super pressing issue but needs to be figured out at some point.

Just checked on Andrew's home network and I see the same errors as on Doug's network. This suggests that this error has been introduced into the code somehow. I feel like at one point I saw this on Doug's network and not mine but perhaps there was a code change in between observations. At present this issue happens on both networks. Why it only affects Andrew's robot is unclear. We will need to figure out what is happening then work our way back to why.


Add documentation for parallel FFT algorithm

Description
Renames variables and documents the parallel FFT. I was going to start work on #83 , but then realized I didn't actually understand our paralell FFT algorithm, so didn't know how to best adapt it to this setting. The implemented algorithm seems like it was a direct translation of the C++ parallel FFT algorithm in libfqfft, which is also completely undocumented.
I'm still not sure what the underlying algorithm is. (Its not quite Cooley Tukey, since both the FFT's being done are of the same size) Its definitely slower than it ought to be at the moment.
I left comments in the code pointing out how to reduce its arithmetic complexity at least from 2N + |coset size| FFT to 2 * |coset size| FFT per thread. However that is still higher than Cooley Tukey (but perhaps Cooley Tukey is less clear to parallelize or will have less cache locality).

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (main)
[ ] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work. - N/A, functionality unchanged at the moment
[ ] Wrote unit tests - N/A
[x] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md - N/A
[x] Re-reviewed Files changed in the Github PR explorer

Amazing, thanks for this! this might explain the slowdown here: https://github.com/arkworks-rs/groth16/issues/11

Oh cool! Glad theres something to validate that this is bad (I was a bit worried that noone had flagged this, since it seemed like a parallelism blocker). I think this does explain that slowdown. I can work on trying to go from 2N -> 2 coset size FFT work per thread after this.
At some later time, we probably need to have a broader consideration of the parallel FFT algorithm. Its possible to parallelize evenly with no arithmetic overhead, but this is bad for data locality and one would expect would slow things down. But theres a ton of different trade-offs to go for in the "increase arithmetic complexity, improve data locality / parallel speed" that we need to be explicit about. (I'm pretty confident that the current method is what we will end with!)

So far this LGTM! I can't say that I fully understand the details of the algorithm; I mostly ported it over from the original Bellman implementation 😅

(I can't wait to update my benchmark results)


[OpenApi 3.0.0] requestBody.content map gets ignored for x-www-form-urlencoded

OpenAPI 3.0.0 doesn't support consumes anymore, but the template is still checking for it when deciding which request type to use.
https://github.com/RSuter/NSwag/blob/a132ba7adaeeefaebd53f68851a7c11e9ad933df/src/NSwag.CodeGeneration.CSharp/Templates/Client.Class.liquid#L159
OpenAPI in theory does support multiple different kinds of request types. So only setting ConsumesFormUrlEncoded  at the appropriate location probably won't be a long term solution.
openapi: 3.0.0
paths:
  /pets:
    post:
      summary: Add a new pet
      requestBody:
        description: Optional description in *Markdown*
        required: true
        content:
          application/x-www-form-urlencoded:
            schema:
              type: object
              properties:
                name:
                  type: string
                year:
                  type: integer

      responses:
        '201':
          description: Created

+1 for this feature.


PHOENIX-5470 Tool to find view corruption

After 4.14, we enabled CHILD_LINK and changed the behavior of SYSCAT, so 4.15 branches have a different implementation. The logic as following:

get all tables to a list.
iterate all tables and find direct child/children from CHILD_LINK table.
for each child view, we compare SELECT COUNT column from SYSCAT + parent.COLUMN_COUNT with child view COLUMN_COUNT.

This groud buildup logic can help us find a view of corruption with pruning. If we have a corrupted global view with 1000 view on top of it, this algorithm will not waste of time to iterate 1000 views. Instead, it stops immediately and adds a corrupted view to the result list.

close this PR since I plan to implement this tool as part of phck.


[dv] Add code coverage waivers

Code coverage waivers are required for Ibex, in particular to hit our 90% coverage goal for OpenTitan V2.

estimate 2

Now we've advanced DV work code coverage waivers aren't required to hit our V2 code coverage goals.


Nothing will be logged

It seems that i missed some settings because nothing will be logged. I thought that your package log alle activities on all resources?!

Add LogsActivity trait to your model file will be fine.

Because backend we use the spatie/laravel-activitylog package, so your may enable the model event manual, see this link for detail:
https://docs.spatie.be/laravel-activitylog/v3/advanced-usage/logging-model-events

Thank you, works good


Support "app lock" mode

When setting the app in "app lock" mode, the app becomes basically read-only.  :)

Thx, i will check progress here.


Create guilt-tripper

Guilt Tripper is a Runelite plugin designed for Old School Runescape, adding a unique twist to the gaming experience. This plugin periodically sends messages to players, humorously "accusing" them of playing too much and suggesting they take a break. And much more!

When the player starts the game, the plugin sends a welcome message in the chat.

Every 15 minutes, the plugin humorously reprimands the player for playing too much.

The plugin features 7 different sound effects, which can be turned off if desired. There is also a volume control for these sounds.

When the player dies, the plugin plays a custom sound effect.

Epic feature:
The plugin includes "pet" drop rates from bosses, such as the "Pet Kraken" which can be obtained with a 1/3000 chance upon defeating the Kraken boss. This meme feature displays the message "You have a funny feeling like you're being followed" in the chat, similar to what would happen if you were actually about to receive a pet. However, about 5 seconds later, a new message appears in the chat saying "Turns out it was just a lost kitten."

Please don't close and reopen prs. You can push updated commit hashes to your current branch and the runner will pickup the changes.

Please don't close and reopen prs. You can push updated commit hashes to your current branch and the runner will pickup the changes.

Yeah, I realized it a after, mb.

Please use a unique ConfigGroup, not "example".
Please change your Installation instructions. How did you come up with these? It almost sounds like some cheat client. Download the Guilt Tripper Plugin from the Runelite GitHub page. is incorrect, I very much doubt it's called Plugins and not Plugin Hub, there is very likely no Browse plugins button, there should not be a downloaded folder.
Could you make it clear in the chat messages (specifically of the "epic feature") that it's the guilt tripper plugin?
I also doubt that we can distribute these sounds, but I'm not a copyright expert. You cannot sell or distribute Content (either in digital or physical form) on a Standalone basis. Standalone means where no creative effort has been applied to the Content and it remains in substantially the same form as it exists on our website.

As stated in the README file "(Installation not available at the moment)", installation is not yet possible. The installation instructions are thus incomplete, as the plugin has not yet been approved. Therefore, the installation instructions are not precise, but let's correct them as well.
If I mention in the chat that the "epic feature" is from the Guilt-Tripper plugin, it might spoil the whole idea. On the other hand, I could present it in the chat as: "Turns out it was just a lost kitten. - Guilt Tripper".
As for the sound effects, they are all royalty-free sound effects that have not been modified. However, I can try some other solutions regarding these.

If I mention in the chat that the "epic feature" is from the Guilt-Tripper plugin, it might spoil the whole idea. On the other hand, I could present it in the chat as: "Turns out it was just a lost kitten. - Guilt Tripper".

Not marking the fake pet drop messages themselves as being from the plugin is almost certainly going to cause confusion and likely support traffic that we'd have to deal with.
Plugins having secret "surprise" features that users aren't aware of when installing is something I would broadly categorize as being something that's undesired, and that sort of thing again generally ends up showing up in the support channel a fair bit.

Please use a unique ConfigGroup, not "example".
Please change your Installation instructions. How did you come up with these? It almost sounds like some cheat client. Download the Guilt Tripper Plugin from the Runelite GitHub page. is incorrect, I very much doubt it's called Plugins and not Plugin Hub, there is very likely no Browse plugins button, there should not be a downloaded folder.
Could you make it clear in the chat messages (specifically of the "epic feature") that it's the guilt tripper plugin?
I also doubt that we can distribute these sounds, but I'm not a copyright expert. You cannot sell or distribute Content (either in digital or physical form) on a Standalone basis. Standalone means where no creative effort has been applied to the Content and it remains in substantially the same form as it exists on our website.

As stated in the README file "(Installation not available at the moment)", installation is not yet possible. The installation instructions are thus incomplete, as the plugin has not yet been approved. Therefore, the installation instructions are not precise, but let's correct them as well.
If I mention in the chat that the "epic feature" is from the Guilt-Tripper plugin, it might spoil the whole idea. On the other hand, I could present it in the chat as: "Turns out it was just a lost kitten. - Guilt Tripper".
As for the sound effects, they are all royalty-free sound effects that have not been modified. However, I can try some other solutions regarding these.

Either way, you'd want the changes to your README as part of the PR before it's actually merged, because changing the README would require another PR to update the text shown on the RL website. The website uses the README file state of the commit in your PR as opposed to just grabbing the latest version from your plugin's repo.

Please use a unique ConfigGroup, not "example".
Please change your Installation instructions. How did you come up with these? It almost sounds like some cheat client. Download the Guilt Tripper Plugin from the Runelite GitHub page. is incorrect, I very much doubt it's called Plugins and not Plugin Hub, there is very likely no Browse plugins button, there should not be a downloaded folder.
Could you make it clear in the chat messages (specifically of the "epic feature") that it's the guilt tripper plugin?
I also doubt that we can distribute these sounds, but I'm not a copyright expert. You cannot sell or distribute Content (either in digital or physical form) on a Standalone basis. Standalone means where no creative effort has been applied to the Content and it remains in substantially the same form as it exists on our website.

As stated in the README file "(Installation not available at the moment)", installation is not yet possible. The installation instructions are thus incomplete, as the plugin has not yet been approved. Therefore, the installation instructions are not precise, but let's correct them as well.
If I mention in the chat that the "epic feature" is from the Guilt-Tripper plugin, it might spoil the whole idea. On the other hand, I could present it in the chat as: "Turns out it was just a lost kitten. - Guilt Tripper".
As for the sound effects, they are all royalty-free sound effects that have not been modified. However, I can try some other solutions regarding these.

Either way, you'd want the changes to your README as part of the PR before it's actually merged, because changing the README would require another PR to update the text shown on the RL website. The website uses the README file state of the commit in your PR as opposed to just grabbing the latest version from your plugin's repo.

They already have changed their README but need to update the commit hash in the plugin-hub repo. THe latest commit in their plugin's repo is 68f929a0c2d49dd11efab08e267d4da7cec35bce


<EMAIL_ADDRESS>

Release: https://github.com/google/cctz/releases/tag/v2.4
Used by:

https://github.com/google/jwt_verify_lib

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (cctz) have been updated in this PR. Please review the changes.


Test: Evolution

[ ] Evolution chains (all scenarios)
[x] Evolution triggers

Crashing on parsing many evolution chains.
Can't fix until https://github.com/phalt/pokeapi/issues/188 is fixed.


Extended widget support for showOnInventory

This adds widget overlay support for inventory in both trading screen and duelarena screen for plugins such as [Inventory Tags] and [Item Charges].

Fixes: #12584

Needs rebase


Refactor/login

Kinda jank....

Login and Register work.

Login method will change in the near future, be ready to rework this.

Just kidding, we're making it better


Search api

Ability to perform search queries

Codecov Report

Merging #105 (1da9a34) into main (9719ae2) will decrease coverage by 2.97%.
The diff coverage is 49.41%.

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   79.62%   76.65%   -2.98%
==========================================
  Files          19       20       +1
  Lines        1556     1726     +170
==========================================
+ Hits         1239     1323      +84
- Misses        245      329      +84
- Partials       72       74       +2

Impacted Files
Coverage Δ

driver/internal.go
100.00% <ø> (ø)

driver/types.go
0.00% <ø> (ø)

tigris/collection.go
68.38% <0.00%> (-7.23%)
:arrow_down:

tigris/iterator.go
41.17% <0.00%> (-39.60%)
:arrow_down:

driver/iterator.go
42.30% <26.92%> (-7.70%)
:arrow_down:

driver/grpc.go
80.76% <61.76%> (-2.57%)
:arrow_down:

driver/http.go
73.25% <69.04%> (-0.44%)
:arrow_down:

search/request.go
88.88% <88.88%> (ø)

driver/driver.go
91.42% <100.00%> (+0.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9719ae2...1da9a34. Read the comment docs.

Codecov Report

Merging #105 (ea8ed5e) into main (9719ae2) will increase coverage by 1.19%.
The diff coverage is 86.07%.

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   79.62%   80.81%   +1.19%
==========================================
  Files          19       21       +2
  Lines        1556     1908     +352
==========================================
+ Hits         1239     1542     +303
- Misses        245      285      +40
- Partials       72       81       +9

Impacted Files
Coverage Δ

driver/internal.go
100.00% <ø> (ø)

driver/types.go
0.00% <ø> (ø)

tigris/iterator.go
72.34% <61.90%> (-8.43%)
:arrow_down:

tigris/collection.go
75.00% <73.33%> (-0.61%)
:arrow_down:

driver/iterator.go
58.97% <76.92%> (+8.97%)
:arrow_up:

search/request.go
81.05% <81.05%> (ø)

driver/grpc.go
83.87% <88.88%> (+0.53%)
:arrow_up:

search/response.go
97.67% <97.67%> (ø)

driver/driver.go
91.58% <100.00%> (+0.41%)
:arrow_up:

driver/http.go
76.44% <100.00%> (+2.74%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9719ae2...ea8ed5e. Read the comment docs.


Check with ngcc compiler

@stevermeister is there any chance that you have checked the library with the ngcc compiler https://github.com/angular/ngcc-validation?

oh, wow, not yet

added - https://github.com/angular/ngcc-validation/pull/1164

looks like we have some problems :(

@stevermeister I can see the progress of the PR and it looks good! We are close! If you any help just ping me 😄

I hope I can manage it :)
fighting with yarn.lock conflicts

done :)


ImGui::Image shows white rectangle

sf::Sprite sprite = LevelDesignerUtilities::imLoadTexture("example.png");

ImGui::Image(sprite, sf::Vector2f(500, 200));

imLoadTexture
static sf::Sprite imLoadTexture(std::string path) {
    sf::Texture texture;

    if(!texture.loadFromFile(path)) {
        std::cout << "failed to load";
    }

    sf::Sprite sprite(texture);

    return sprite;
}

Result:

There is no messages that sf::Texture failed to load from file.

sf::Texture sprite = LevelDesignerUtilities::imLoadTexture("example.png");

ImGui::Image(sprite, sf::Vector2f(500, 200));

    static sf::Texture imLoadTexture(std::string path) {
        sf::Texture texture;

        if(!texture.loadFromFile(path)) {}

        return texture;
    }

somehow fixed

You are deleting the texture right after creating the sprite. That indeed doesn't work, as described in SFML.
https://www.sfml-dev.org/documentation/2.6.0/classsf_1_1Sprite.php#a3729c88d88ac38c19317c18e87242560

Hey, I've really tried to research this all the time, but I still haven't found the solution.
// Sprite.
if(ImGui::CollapsingHeader("Sprite.")) {
    // Preview texture allocations.
    sf::Texture texture;

    // ...

    static char spritePath[MAX_OBJECTS_TEXT_SIZE / 2]; // (512 / 2)

    // ...

    if(ImGui::InputText("Sprite path.##sprite", spritePath, IM_ARRAYSIZE(spritePath))) {
        texture.loadFromFile(spritePath); // <-
    }

    // ...

    // Preview. (150, 150).
    ImGui::Image(texture, sf::Vector2f(DEFAULT_TEXTURE_PREVIEW_WIDTH, DEFAULT_TEXTURE_PREVIEW_HEIGHT), sf::Color::Transparent, sf::Color::White);
}

I tried assigning texture before the if block, before the while loop, making texture static, making shared, but nothing helped. Still white rectangle.

Added:
if(!texture.loadFromFile(spritePath)) {
    LevelDesignerLog::consoleLog("Failed to show sprite preview.");
} else {
    LevelDesignerLog::consoleLog("Loaded sprite preview successfully.");
}

After typing text, it shows that it has failed to load texture, but that's OK because it tries to load texture on new character typed, so if full and correct path to texture is written, there are no more errors.
e.g
Failed to load image "e". Reason: Unable to open file
SFML.LD2D: Failed to show sprite preview.
Failed to load image "ex". Reason: Unable to open file
SFML.LD2D: Failed to show sprite preview.
Failed to load image "exa". Reason: Unable to open file
SFML.LD2D: Failed to show sprite preview.
Failed to load image "exam". Reason: Unable to open file
SFML.LD2D: Failed to show sprite preview.
Failed to load image "examp". Reason: Unable to open file
SFML.LD2D: Failed to show sprite preview.
Failed to load image "exampl". Reason: Unable to open file
SFML.LD2D: Failed to show sprite preview.
Failed to load image "example". Reason: Unable to open file
SFML.LD2D: Failed to show sprite preview.
Failed to load image "example.". Reason: Unable to open file
SFML.LD2D: Failed to show sprite preview.
Failed to load image "example.p". Reason: Unable to open file
SFML.LD2D: Failed to show sprite preview.
Failed to load image "example.pn". Reason: Unable to open file
SFML.LD2D: Failed to show sprite preview.
SFML.LD2D: Loaded sprite preview successfully.

e (fail) -> ex (fail) -> exa (fail) -> exam (fail) -> examp (fail) -> exampl (fail) -> example (fail) -> example. (fail) -> example.p (fail) -> example.pn (fail) -> example.png (success)

ImGui::Image(texture doesn't actually do any drawing, it just remembers to draw this thing later in the frame. The texture gets deleted right afterwards though. That's probably the problem. Turn the texture into a global variable and that's certain to work. Then if you don't like that, you can try to reduce the scope

Sorry, but what do you mean by making the texture a global variable? i.e initialize sf::Texture before the loop, and after loading texture into this class? Sorry, I don't understand

@oprypin

@oprypin ???

fixed


Loading state for buttons

Describe what feature you'd like. Pseudo-code, mockups, or screenshots of similar solutions are encouraged!
Adding a loading (spinner) for buttons with custom text (please wait...)
What type of pull request would this be?
Enhancement
Any links to similar examples or other references we should review?
No response

This is already possible @omar2205, just combine any button element with a Progress Radial set to indeterminate mode.

https://www.skeleton.dev/elements/buttons
https://www.skeleton.dev/components/progress-radials

The result would be something like this:
https://tailwindcss.com/docs/animation#spin
All you would need to do is use Svelte #if conditions to modify the contents of the button during the loading/complete states


[SP-2208] - Repair failed test

backport changes from 32d8256a6d5331983ca5cf982ba65c189a24f355

this is a partial backport of https://github.com/pentaho/pentaho-kettle/pull/1855
@brosander, review it please

Build Commands:
Build:

rm -r ~/.kettle; rm -r ~/.pentaho; echo removed hidden folders
ant -Djunit.jvmargs=-XX:PermSize=256m -f engine/build.xml clean-all resolve jacoco jacoco-integration checkstyle publish-local

Cleanup:
rm -r ~/.ivy2/local || echo no publish local to remove
Changed files:
engine/test-src/org/pentaho/di/job/JobMetaTest.java
Checkstyle violations:
File engine/test-src/org/pentaho/di/job/JobMetaTest.java

Message: ')' is not preceded with whitespace. at Line: 113 Column: 93
Message: ')' is not preceded with whitespace. at Line: 119 Column: 58
Message: ')' is not preceded with whitespace. at Line: 120 Column: 48
Message: ')' is not preceded with whitespace. at Line: 122 Column: 64
Message: ')' is not preceded with whitespace. at Line: 123 Column: 54
Message: ')' is not preceded with whitespace. at Line: 147 Column: 34
Message: ')' is not preceded with whitespace. at Line: 147 Column: 87

License header violations:
No violations found
Newly Fixed Tests:
org.pentaho.di.job.JobMetaTest.testLookupRepositoryReferences: java.lang.RuntimeException
java.lang.RuntimeException
	at org.pentaho.di.job.JobMetaTest.testLookupRepositoryReferences(JobMetaTest.java:136)

Unit test coverage change:
org.pentaho.di.trans.steps.excelwriter.ExcelWriterStepMeta:

instructionPercentCoverageChange :-0.08%

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta:

instructionPercentCoverageChange : +0.28%
branchPercentCoverageChange : +3.33%
complexityPercentCoverageChange : +1.85%

org.pentaho.di.job.JobMeta:

instructionPercentCoverageChange : +0.69%
branchPercentCoverageChange : +0.66%
linePercentCoverageChange : +0.82%
complexityPercentCoverageChange : +0.22%

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta:

instructionPercentCoverageChange :-0.07%

org.pentaho.di.trans.step.StepMeta:

instructionPercentCoverageChange : +0.19%
linePercentCoverageChange : +0.27%

org.pentaho.di.job.entries.sql.JobEntrySQL:

instructionPercentCoverageChange : +1.64%
linePercentCoverageChange : +1.97%


How to run dynamic analysis successfully

I used steady's maven scan by adding configuration in the project's pom file.
In use, app and a2c program analysis can succeed and obtain results, but upload, instr, t2c, etc. cannot run successfully. There is a running problem with Dynamic instrumentation (JUnit). At the same time, t2c needs to run during JUnit, so the results cannot be obtained. I would like to ask whether the configuration information in the pom needs to be improved or the source code format and configuration of the project need to be modified, or how to successfully perform t2c program analysis.
The github address of the steady test sample is https://github.com/11111821/steady_proj, this includes test sample source code and related command logs.
Here is the command execution history.

Here is the front-end interface.

I checked the log of the a2c command and found that the successfully executed project should have a class file here, and the unsuccessful one will be "Found [0] files"

At the same time, the callgraph of the unsuccessful project cannot be built. The reason for the failure is as follows. Do I need to get the compiled class file before I analyze it?
steady.cg.ReachabilityAnalyzer - Call graph cannot be constructed or analyzed, reachability analysis will be interrupted: No entry points could be set, which will not allow to build the callgraph
Many failed projects are "No sources to compile", as shown in the figure below, is this the cause of the project or the reason for the configuration?


About Light head Errro

@terrychenism when I'm training get this erro,
Epoch[0] Batch [16100]	Speed: 4.03 samples/sec	Train-RPNAcc=0.925120,	RPNLogLoss=0.242852,	RPNL1Loss=0.065234,	RCNNAcc=0.804096,	RCNNLogLoss=0.977945,	RCNNL1Loss=0.587750,
Epoch[0] Batch [16200]	Speed: 4.03 samples/sec	Train-RPNAcc=0.925266,	RPNLogLoss=0.242467,	RPNL1Loss=0.065175,	RCNNAcc=0.803835,	RCNNLogLoss=0.978509,	RCNNL1Loss=0.588405,
Epoch[0] Batch [16300]	Speed: 4.03 samples/sec	Train-RPNAcc=0.925351,	RPNLogLoss=0.242249,	RPNL1Loss=0.065088,	RCNNAcc=0.803694,	RCNNLogLoss=0.978893,	RCNNL1Loss=0.588792,
Epoch[0] Batch [16400]	Speed: 4.05 samples/sec	Train-RPNAcc=0.925493,	RPNLogLoss=0.241871,	RPNL1Loss=0.064978,	RCNNAcc=0.803601,	RCNNLogLoss=0.978824,	RCNNL1Loss=0.588956,
Epoch[0] Batch [16500]	Speed: 4.03 samples/sec	Train-RPNAcc=0.925555,	RPNLogLoss=0.241684,	RPNL1Loss=0.064945,	RCNNAcc=0.803539,	RCNNLogLoss=0.978706,	RCNNL1Loss=0.588927,
Traceback (most recent call last):
File "experiments/rfcn/rfcn_end2end_train_test.py", line 19, in
train_end2end.main()
File "experiments/rfcn/../../rfcn/train_end2end.py", line 167, in main
config.TRAIN.begin_epoch, config.TRAIN.end_epoch, config.TRAIN.lr, config.TRAIN.lr_step)
File "experiments/rfcn/../../rfcn/train_end2end.py", line 160, in train_net
arg_params=arg_params, aux_params=aux_params, begin_epoch=begin_epoch, num_epoch=end_epoch)
File "experiments/rfcn/../../rfcn/core/module.py", line 996, in fit
callback(epoch, self.symbol, arg_params, aux_params)
File "experiments/rfcn/../../rfcn/core/callback.py", line 51, in _callback
weight = arg['rfcn_bbox_weight']
KeyError: 'rfcn_bbox_weight'

replace the _callback function in do_checkpoint by following code
arg['bbox_pred_weight_test'] = (arg['bbox_pred_weight'].T * mx.nd.array(stds)).T         arg['bbox_pred_bias_test'] = arg['bbox_pred_bias'] * mx.nd.array(stds) + mx.nd.array(means)         mx.model.save_checkpoint(prefix, iter_no + 1, sym, arg, aux)         arg.pop('bbox_pred_weight_test')         arg.pop('bbox_pred_bias_test')

@moyans Does Light-head work for you?

@Tveek hello,excuse me ,i don't understand the operation of 'arg['bbox_pred_weight_test']',
maybe arg['bbox_pred_weight_test']  for test? Could I comment them?


[CIAM-9118] idp integration route id fix

Hello team,
Tickets tries to solve https://issues.redhat.com/browse/CIAM-8796
Our primary goal is to understand and enable the 'Identity Provider Integration' menu, which is also part of the 'Authentication Policy' menu that already includes the existing searchable item 'authFactors.' We’ve noticed that this item isn’t yet available in the staging or prod environments, and I’m not entirely sure if this unique change will fix and enable it since all searchable content is created through parse-services and generate-search-index GO tasks.

That said, I did a search for both ids and got:
iam.authFactors references:
api/chrome-service/v1/static/stable/prod/search/search-index.json
api/chrome-service/v1/static/stable/prod/services/links-storage.json
api/chrome-service/v1/static/stable/prod/services/services.json

api/chrome-service/v1/static/stable/stage/search/search-index.json
api/chrome-service/v1/static/stable/stage/services/links-storage.json
api/chrome-service/v1/static/stable/stage/services/services.json

api/chrome-service/v1/static/beta/prod/search/search-index.json
api/chrome-service/v1/static/beta/prod/services/links-storage.json
api/chrome-service/v1/static/beta/prod/services/services.json
api/chrome-service/v1/static/beta/prod/services/services.json
api/chrome-service/v1/static/beta/stage/services/links-storage.json
api/chrome-service/v1/static/beta/stage/services/services.json

static/stable/prod/services/services.json
static/stable/prod/search/search-index.json
static/stable/prod/services/links-storage.json
static/stable/stage/search/search-index.json
static/stable/stage/services/links-storage.json
static/stable/stage/services/services.json

static/beta/prod/search/search-index.json
static/beta/prod/services/links-storage.json
static/beta/prod/services/services.json
static/beta/stage/search/search-index.json
static/beta/stage/services/links-storage.json
static/beta/stage/services/services.json

iam.idpIntegration references:
api/chrome-service/v1/static/stable/prod/search/search-index.json
api/chrome-service/v1/static/stable/prod/services/links-storage.json
api/chrome-service/v1/static/stable/prod/services/services.json

-- (missing) --> api/chrome-service/v1/static/stable/stage/search/search-index.json
api/chrome-service/v1/static/stable/stage/services/links-storage.json
-- (missing) --> api/chrome-service/v1/static/stable/stage/services/services.json

api/chrome-service/v1/static/beta/prod/services/links-storage.json
api/chrome-service/v1/static/beta/stage/services/links-storage.json

static/stable/prod/search/search-index.json
static/stable/prod/services/links-storage.json
static/stable/prod/services/services.json

-- (missing) --> static/stable/stage/search/search-index.json
static/stable/stage/services/links-storage.json
-- (missing) --> static/stable/stage/services/services.json

static/beta/prod/services/links-storage.json
static/beta/stage/services/links-storage.json

Why
The CIAM-S AuthN is currently working to provide a self-service 3rd party Identity Provider solution for Red Hat external customers.
our team channel:
team-ciam-s-authn
Appreciate all support in advance

related PRs:
https://github.com/RedHatInsights/chrome-service-backend/pull/80
https://github.com/RedHatInsights/chrome-service-backend/pull/673
https://github.com/RedHatInsights/chrome-service-backend/pull/672
https://github.com/RedHatInsights/chrome-service-backend/pull/654


Events in drive cycles in experiments

It would be good to be able to e.g. run a drive cycle in an experiment until a given voltage, like so:
import pybamm
import pandas as pd
import os

os.chdir(pybamm.__path__[0] + "/..")

pybamm.set_logging_level("INFO")

drive_cycle_current = pd.read_csv(
    "pybamm/input/drive_cycles/US06.csv", comment="#", header=None
).to_numpy()

experiment = pybamm.Experiment(
    [
        "Run US06_A (A) until 3.7 V",
    ],
    drive_cycles={
        "US06_A": drive_cycle_current,
    },
)

model = pybamm.lithium_ion.SPMe()
sim = pybamm.Simulation(model, experiment=experiment, solver=pybamm.CasadiSolver())
sim.solve()

sim.plot()

You can do this by changing the min/max voltage parameters, but maybe you want a different stopping condition for the drive cycle. This was prompted by this discussion.

As pointed out by @tinosulzer , this is an issue with how casadi handles events during cycles. See
import pybamm
import pandas as pd
import os

os.chdir(pybamm.__path__[0] + "/..")

model = pybamm.lithium_ion.SPM()
param = model.default_parameter_values

drive_cycle = pd.read_csv(
    "pybamm/input/drive_cycles/US06.csv", comment="#", header=None
).to_numpy()

timescale = param.evaluate(model.timescale)
current_interpolant = pybamm.Interpolant(
    drive_cycle[:, 0], drive_cycle[:, 1], timescale * pybamm.t
)

param["Current function [A]"] = current_interpolant
param["Lower voltage cut-off [V]"] = 3.6

sim = pybamm.Simulation(model, parameter_values=param)

solvers = [pybamm.ScipySolver(), pybamm.CasadiSolver()]
sols = []
for solver in solvers:
    sol = sim.solve(solver=solver)
    sols.append(sol)

pybamm.dynamic_plot(sols, labels=["scipy", "casadi"])

Yes, that’s a good workaround for now

Might be possible to do this with IDAKLU solver now/soon


Flattening optimizer for set operations

Purpose
Migrate legacy SetFlatteningOptimizer to new rule.
See: https://github.com/prestosql/presto/issues/811
Overview

Add MergeUnion
Add MergeIntersect
Add MergeExcept

@Lewuathe , there are some test failures in TestTpcdsCostBasedPlan. Can you take a look?

The cause of failure seems to be pruning off the aggregation node. I'm not sure why the rule is implemented in SetFlatteningOptimizer. Anyway, I'll add a rule to prune a distinct aggregation node.

@martint The original SetFlatteningOptimizer removes the AggregationNode when it works as just a distinct. But the rule is implemented in a recursive manner so that we can easily remove the intermediate distinct AggregationNode.
But this type of pattern is difficult to write with Pattern because any number of set operations can exist in the middle of AggregationNodes. The following rule only detects the AggregationNode under the one UnionNode, not two or more.
    private static final Pattern<AggregationNode> PATTERN = aggregation()
            .matching(PruneDistinctAggregation::isDistinctOperator)
            .with(source().matching(union()
                    .with(source().matching(aggregation().capturedAs(CHILD)))));

Could you give me any advice to write a pattern to remove distinct AggregationNode?

@Lewuathe, can you rebase? I'll go ahead and merge it after that.

@martint Thank you for checking. I rebased the PR on the latest master branch.


Bug Report: Sound does not play.

Please check for duplicates, similar issues or closed issues with the same problem, as well performing simple troubleshooting steps (such as deleting the export folder if it's an issue with compiling, reinstalling Kade Engine) before submitting an issue.
If you are playing a downloaded version of the game, what operating system are you using?
Windows (x86), Windows (x86_64), Linux, or macOS? Specify below.
What version of the game are you using? Look in the bottom left corner of the main menu.
Have you identified any steps to reproduce the bug? If so, please describe them below. Use images if possible.
Please describe your issue. Provide extensive detail and images if possible.

theres a wierd problem in kade engine evrey mod i play in kade engine the sound does not work i have my volume at max at kade engine and i cant hear anything any song menu nothing i have asked my friends about it and they dont have the issue i have tried out alot of stuff to get the sound to work can you somehow help me kade? thanks.

youd have to press the plus and minus key on your keyboard to increase/descrese/mute the volume of the game. otherwise check your volume mixer (Right-Click Sound icon>Click Volume Mixer>Find Kade EXE > and increase it from there). please close this once resolved

I have tried evreything it still dosent Work
KlutchDj @.***> schrieb am Do., 12. Aug. 2021, 20:00:

youd have to press the plus and minus key on your keyboard to
increase/descrese/mute the volume of the game. otherwise check your volume
mixer (Right-Click Sound icon>Click Volume Mixer>Find Kade EXE > and
increase it from there). please close this once resolved
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/KadeDev/Kade-Engine/issues/1718#issuecomment-897853689,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVFWINCNPFXBU7GAFC7TALDT4QD37ANCNFSM5CAV3RLA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.


feat: container retention policy

https://github.com/snok/container-retention-policy

Handled by cleanup in bcgov/action-builder-ghcr.


refactor: fix linter errors

Description
As in the title of PR: fix linter errors. Also update the scripts in the package.json.

@derberg Thanks!


Enable ^, << & >> and add  "Andorable" trait.

Previously, we had an impl self( impl u64 ) where the binary_and, binary_or and binary_xor functions were defined.
This PR improves on this by:

adding a pub trait Andorable (name up for suggestions... maybe "Andorxor" ?)
refactoring to use impl Andorable for u64
I've also enabled the ^, << and >> operators and added tests for them.

This sets us up nicely to impl Andorable, Shiftable for b256, and reenables the u64_ops tests which were recently disabled.

Andorable is very close to the word adorable, which is comedic.
It might be tedious but it could be worth it to split these out into separate traits: BitwiseAnd, BitwiseOr, and BitwiseXor?

it could be worth it to split these out into separate traits

Yeah, I can do that, not that tedious really.


Rewritten, fixed a few glitches

I made the algorithm precise to the second, and made the command-line output input zenith and output in a slightly more extractable format. I also rewritten the main calculation to become a lot smaller.
While it's now a tiny bit slower because it must re-do a few calculations, considering the only difference in the sunrise and sunset is in two lines, I'd say this algorithm is a wee bit easier on the eye.

Hi,
I believe you might have my commits confused for someone else's – if you check the diff, I didn't touch the ZENITH value, fix any imports, or use .tm_yday. The attribute error was easily fixed — a simple typo.
However, as far as I can tell after a few careful reads, there is no mathematical difference between the formula I used and the previous versions – only a change in precision. Debugging and printing values seems to show consistency, so as far as I can tell any errors are due to previous commits, apologies.

Odd. I could've swore I saw that in the diff somewhere. I must have messed up the comparison somehow. Sorry.


Feature Request: Global search.

querio is the most beautiful graphql  extension. I think the only thing not better than  is lack global search ability.

@zsytssk the global search could prove to be slow and might impact the extension


Highlighting takes a while

Highlighting
After opening a file highlighting doesn't start

After pressing enter (last line) it starts highlighting

This just happens when opening a *.swift file right?

We might need to show "Loading X language features" this in the CodeEdit activity bar while this completes. We'd need to somehow pull that state out of this view.

@thecoolwinter is this fixed with #59 ?

Yes, closed with incremental highlighting #59. CodeEdit will now only try to highlight the visible text which greatly improves the initial highlight time


Spanish Translations

Translated content of "name" fields to Spanish.

@JanLenoch could you please give @beemtz some guidance? thx


[ADAM-1057] Remove workaround for gzip/BGZF compressed VCF headers

Fixes #1057
Requires https://github.com/HadoopGenomics/Hadoop-BAM/pull/106 to be merged and deployed as version 7.5.1-SNAPSHOT.  Will need to be updated to 7.6.0 when that release is made.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1289/Build result: FAILUREGitHub pull request #1060 of commit b6e8d3cee5018512b89323a86df4475bee4c3bdc automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > /home/jenkins/git2/bin/git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git -c core.askpass=true fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1060/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a --contains 1b4111fec822b4840b82843a90e6915b0023b8c7 # timeout=10 > /home/jenkins/git2/bin/git rev-parse remotes/origin/pr/1060/merge^{commit} # timeout=10Checking out Revision 1b4111fec822b4840b82843a90e6915b0023b8c7 (origin/pr/1060/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f 1b4111fec822b4840b82843a90e6915b0023b8c7First time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.10,1.5.2,centosTriggering ADAM-prb ? 2.6.0,2.11,1.5.2,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Jenkins, test this please.
Issue https://github.com/HadoopGenomics/Hadoop-BAM/pull/106 has been closed and a new shanpshot should have been deployed.

Jenkins, retest this please.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1293/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1294/
Test PASSed.

LGTM, modulo one import nit. Let me know when you've updated it, and I can merge. I'm looking forward to having this in, @heuermh!

Hmm, I'm having bad times running this on the cluster on the 1KG .vcf.gz files.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1299/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1349/
Test PASSed.

Rebased!

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1352/
Test PASSed.

+1 This works fine for me on a compressed vcf
I'll merge tomorrow unless someone suggests otherwise

Merged 308cc586fb28367df3
Thanks for the PR @heuermh!


Bubble bench new api

Description
This PR adds two new implementations of bubble bench.

Using Shared Tree with cursors
Using Shared Tree with the Editable Tree implementation

READ BEFORE LOOKING AT THE FILES CHANGED
File Paths:

Cursor based implementation file path: experimental/examples/bubblebench/shared-tree
Editable Tree based implementation file path: experimental/examples/bubblebench/shared-tree
Legacy shared tree implementation  experimental/examples/bubblebench/legacy-shared-tree
The actual front end app for BubbleBench: /workspaces/FluidFramework/experimental/examples/bubblebench/common/src/view/app.tsx (not edited in this PR)

Files to ignore

Everything under packages/dds/tree/src/test This is all for me to easily test stuff and will be removed
Legacy shared tree implementation (experimental/examples/bubblebench/legacy-shared-tree)  This is the old implementation, I just renamed the folder and package for clarity.

Breaking Changes

See the new imports from packages/dds/tree/src/index.ts and  packages/dds/tree/src/core/index.ts, These new imports should all be  used in bubble bench.

Reviewer Guidance
Understanding the logical structure of cursor based bubble bench
1. BubbleBench.ts
Every new instance of bubble bench begins with BubbleBench.ts (experimental/examples/bubblebench/shared-tree/src/BubbleBench.ts). This class extends DataObject which is the common object used to connect DDS's with the front end application. After class instantiation and/or connection to an existing or creation of the Shared Tree, BubbleBench will create a local instance of AppState. AppState is the interface through which the actual front end application sends all commands.

Please confirm that the implementation of the DataObject method looks correct.
You can peer at the initial state of the tree structure used in the method initializeTree

2. AppState.ts
AppState is the front most interface through which each front end application sends all commands to interact with the shared tree. Upon instantiation,
AppState creates a local client (Client.ts) and inserts the client as a node into a field containing the sequence of connected clients, 'clients', which exists at the root node of the SharedTree. Each AppState can identify its local client using a uuid (this.localClientId).
applyEdits is a method run at the end of each frame render by the front end application. It could be used to apply many changes at once, or in the default case here, its used to forget ephemeral anchors.
As you'll notice from get clients(), there is a the use of SharedTreeSequenceHelper.ts, which can obtain all the anchors from a given sequence node. These anchors are then used to build instances of Client.ts. The front end will use this method to iterate through the available clients and do various operations. Under the hood for each Client.ts, an anchor is used with SharedTreeNodeHelper.ts  to associate the class with a specific node in the SharedTree. As each iteration provided by get clients(), occurs we have class instances created on demand that are automatically garbage collected by javascript after being used. BUT, there are no-longer needed anchors created that are left behind on the shared tree. That is where the anchor garbage collection method of  applyEdits comes into play
Most of the other methods in this class pass through to its local client instance, Client.ts.
3. Client.ts
Each instance of Client.ts represents a "client" node in the Shared Tree. It serves as a proxy to the Shared Tree such that people using this class get to simply use it like a JavaScript object, and under the hood you're getting and setting values on the SharedTree node. Upon instantiation, each Client creates its own SharedTreeNodeHelper.ts (this.treeHelper). This class takes an anchor and a shared tree and provides a simple interface for interacting with a single node, hiding the use of cursors and transactions with the SharedTree.
You'll see that all of its getters and setters are overridden within Client.ts and utilize its SharedTreeNodeHelper to interact with its respective Shared Tree node.
Notice that get bubbles(), similarly to AppState.clients() builds an array of anchors and casts them into Bubble class instances. There is more anchor stashing here since after a since iteration, the anchors will no longer be needed.
this.shouldStashTransactions is a method to essentially defer transactions to be executed in bulk within the method AppState.applyEdits(). The array AppState uses to hold deferred transactions and execute them is passed down to to each Client.ts as this.editBuilderCallbacks. this.shouldStashTransactions and this.editBuilderCallbacks are in turn passed down to  SharedTreeNodeHelper.ts which will stash transactions in an array provided to it rather than execute it immediately if this.shouldStashTransactions is true.
Note that this.shouldStashTransactions is false by default and not used. I'm not sure if this feature is necessary.
4. Bubble.ts
Similarly to Client.ts, this acts as a javascript object proxy to a node in the SharedTree representing a respective bubble. Each client has its own sequence of bubbles. This class also overrides its setters and getters with logic from its SharedTreeNodeHelper.ts
5. SharedTreeNodeHelper.ts
This class takes an anchor and a shared tree and provides a simple interface for interacting with a single node, hiding the use of cursors and transactions with the SharedTree.

Please take a careful look at the implementation details here

6. SharedTreeSequenceHelper.ts
This class takes an anchor and a shared tree and provides a simple interface for interacting with a sequence of nodes, hiding the use of cursors and transactions with the SharedTree.

Please take a careful look at the implementation details here

The names of the different packages/directories seems a bit odd to me.
"SharedTree" is the name of a class (in the @fluid-internal/tree package), which exposes access to the tree via the EditableTree Api.
Maybe we should have:

fluid-legacy-tree
fluid-tree-high-level (Uses the EditableTree API)
fluid-tree-low-level (Uses the Cursors)


Use Kahan summation for Float and Double

see: https://en.wikipedia.org/wiki/Kahan_summation_algorithm
@sritchie reminded me of this recently, which I had seen years ago but forgotten when we implemented this code.
This improves the accuracy of long sums, which will make the results different, but floating point is already not associative or commutative, so I think this is an acceptable risk.
I had to change the tests a bit because scalas .sum does not use this kind of approach and it results in larger error.
Thanks Sam!

Codecov Report

Merging #880 into develop will decrease coverage by 0.20%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop     #880      +/-   ##
===========================================
- Coverage    89.29%   89.08%   -0.21%
===========================================
  Files          117      117
  Lines         9348     9354       +6
  Branches       371      354      -17
===========================================
- Hits          8347     8333      -14
- Misses        1001     1021      +20

Impacted Files
Coverage Δ

...ore/src/main/scala/com/twitter/algebird/Ring.scala
65.62% <50.00%> (-0.77%)
:arrow_down:

.../main/scala/com/twitter/algebird/Successible.scala
83.33% <0.00%> (-8.34%)
:arrow_down:

...scala/com/twitter/algebird/CorrelationMonoid.scala
86.76% <0.00%> (-7.36%)
:arrow_down:

...src/main/scala/com/twitter/algebird/Interval.scala
78.26% <0.00%> (-6.96%)
:arrow_down:

...in/scala/com/twitter/algebird/scalacheck/Gen.scala
95.34% <0.00%> (-4.66%)
:arrow_down:

.../main/scala/com/twitter/algebird/BloomFilter.scala
93.36% <0.00%> (-1.33%)
:arrow_down:

...main/scala/com/twitter/algebird/monad/Reader.scala
58.82% <0.00%> (+5.88%)
:arrow_up:

...n/scala/com/twitter/algebird/SuccessibleLaws.scala
92.30% <0.00%> (+15.38%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16b91ac...91d5200. Read the comment docs.

:shipit: looks good to me


Math Magician - Functional Component Description

Math Magician - Description of How I used Functional Component

Firsly, I created an arrow function named Components and inside it I passed the following objects {total: 0, next: null, operation: null} to the useState(), which is the initial value for the state. I used the array destructuring returned by useState() and get the two elements: state and setState(). I use value to access the state and setState() to update the state.

Secondly, I created a handleClick function and resultDisplay function. In the handleClick function, I used the imported calculate,js file to calculate the state which was updated using setState() in the component.

Thirdly, the handleClick function is then passed inside the returned button element during an onClick event.

Lastly, the created functional components is then exported as default.

It is easy to create and update the state in functional components using the useState() hook. React Hooks enable us to use state in React Function Components using arrow functions.

STATUS: APPROVED ✔ 🍾 🍾 🍾 🥳 🥳 🥳
Hi @Johnadibe,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights
✅ Well explained
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


(FM-5349) Update changelog for release

Update the changelog with the updates for the 3.0.0 release

Good call on 3.0.0. Why not stable?


Runtime.ToValue provides specific behavior for reflect.Func

Is it possible to provide an interface so that users can customize the Runtime.ToValue function to handle the behavior of reflect.Func? For example, in New() *Runtime, set a function to specify how ToValue handles reflect.Func.
The reason for this is: all the native functions (case reflect.Func) are called by ToValue provides a default calling rule, I need a way to change this default calling rule. For global functions, I can implement a function to convert reflect.Func to case func(FunctionCall) Value to ToValue, but I cannot provide this wrapper for member functions because member functions are automatically passed in objectGoReflect._get To ToValue cannot call the wrapper I provided.
In fact, I implemented a Promise. I hope that if a certain token is passed in when calling the Go native function directly in js, I will create a Promise and return it to js and execute the native function in the new goroutine for the function to use the Promise after completion Notify js. So I can't use the default call method provided by goja, I need to be able to customize the call implementation to quickly expand all native functions to support Promise.

See #332


Utilize request pieces from common.proto in PactConsumerTest request

This illustrates a situation where a proto file (area_calculator.proto) imports another proto (common.proto) which is used in the request specified by PactConsumerTest
        "request", Map.of(
          "device_context", Map.of(
              "device_id", "matching(number, 4)",
              "carrier_name", "matching(type, 'foo')"
          )),
          "listener_context", Map.of(
              "listener_id", "matching(number, 1)"
          ),

Hey, thanks for the example however it may be best as a separate example, or possible an extension of the test_enums example
https://github.com/pact-foundation/pact-plugins/tree/main/examples/gRPC/test_enums
as the area_calculator example is canonical and used in multiple languages, changing only one example has negative implications.
We would certainly be interested in more complex examples, as I appreciate some of these are somewhat naive.


BB runs great on localhost:8080 but not behind haproxy+ssl

I'm having great success using bb on localhost:8080. But, when I put it on a server with haproxy in front, it will not let me see video. I cannot tell if the issue is with the publish or the playback. I see an webrtc error in the JS console, but that seems to appear when I'm using localhost as well. Is there a way to enable verbose logging on the server and get more information on the full flow?

I'm using the docker container but perhaps I'm better off using the binary?

Hey @xrd
I will work on making the logging better on the client + server. You need two things for this to work I bet.

Run your docker container with --net=host
Broadcast Box needs to know an IP that you are reachable. Try setting INCLUDE_PUBLIC_IP_IN_NAT_1_TO_1_IP=true the env variable

This is the docker-compose.yml I am using on siobud.com. Should we include this in the repo itself?
  broadcast-box:
    environment:
    - INCLUDE_PUBLIC_IP_IN_NAT_1_TO_1_IP=yes
    - INTERFACE_FILTER=eth0
    image: seaduboi/broadcast-box
    hostname: broadcast-box
    domainname: siobud.com
    container_name: broadcast-box
    network_mode: "host"
    privileged: true
    restart: always

That's great. Thanks so much. I'll experiment with that myself. I wasn't aware of the Ethernet device filter variable.
Are you using any kind of http proxy in front of that? How do you do SSL termination may I ask?

I use Caddy. Here is the configuration
siobud.com {
    tls<EMAIL_ADDRESS>    root * /srv
    file_server
}

franklinfacts.com {
    tls<EMAIL_ADDRESS>    root * /srv/franklin
    file_server
}

b.siobud.com, broadcast-box.siobud.com {
    reverse_proxy <IP_ADDRESS>:8080
}

http://whip.siobud.com {
    reverse_proxy <IP_ADDRESS>:8080
}

mail.siobud.com {
    tls<EMAIL_ADDRESS>}


Incomplete documentation on campaign events

This page is somewhat missing of other events such as clicks etc. Parking here as an issue to remind me to come back to it: https://mautic.org/docs/en/campaigns/campaign_events.html

Added documentation for all the Campaign Decisions, as well as some missing actions which I found important! :)


Build issue

Thanks for your earlier reply. I tried to build but ran into this issue:
../go/pkg/mod/github.com/!shopify/sarama@v1.22.1/compress.go:9:2: unknown import path "github.com/eapache/go-xerial-snappy": git -c core.autocrlf=input -c core.eol=lf archive --format=zip --prefix=prefix/ 776d5712da21bc4762676d614db1d8a64f4238b0 in
Admittedly, i'm not well versed with go but it failed with the above error. Any help would be greatly appreciated!

After cleaning up and trying again, was able to build. However, running into issues - it is not able to connect to kafka brokers. I've a kafka_exporter on the same server which is running fine. Here's what I did:

TELEMETRY_HOST=localhost
TELEMETRY_PORT=9310 (default is 8080 but that didn't work so changed it)
KAFKA_BROKERS= (comma separated list of 3 brokers)
Started ./kafka-minion

{"level":"info","msg":"Starting kafka minion version1.0.0","time":"2019-08-15T15:22:57Z"}
{"level":"debug","msg":"Sarama client config has been created successfully","time":"2019-08-15T15:22:57Z"}
{"address":":9092,:9092,:9092","level":"info","module":"cluster","msg":"connecting to kafka cluster","time":"2019-08-15T15:22:57Z"}
And errors out with this:
{"address":":9092","level":"panic","module":"cluster","msg":"failed to start client","reason":"kafka: client has run out of available brokers to talk to (Is your cluster reachable?)","time":"2019-08-15T14:58:58Z"}
panic: (*logrus.Entry) (0x9b1b80,0xc0001031f0)
goroutine 1 [running]:
github.com/sirupsen/logrus.Entry.log(0xc00006a3c0, 0xc00016afc0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
The server is reachable (and kafka_exporter returns the metrics)
telnet  9092
Trying <IP_ADDRESS>...
Connected to
Escape character is '^]'.
Thanks for the help

What does your KAFKA_BROKERS environment variable value look like? In the log you can see it has got this for the address which definetely looks wrong:
":9092,:9092,<server3:9092"

sorry, I took the actual server list out. The server list is correct. Log look likes this:
{"level":"info","msg":"Starting kafka minion version1.0.0","time":"2019-08-15T15:33:48Z"}
{"level":"debug","msg":"Sarama client config has been created successfully","time":"2019-08-15T15:33:48Z"}
{"address":":9092, :9092, :9092","level":"info","module":"cluster","msg":"connecting to kafka cluster","time":"2019-08-15T15:33:48Z"}
{"address":":9092, :9092, :9092","level":"panic","module":"cluster","msg":"failed to start client","reason":"kafka: client has run out of available brokers to talk to (Is your cluster reachable?)","time":"2019-08-15T15:35:49Z"}
panic: (*logrus.Entry) (0x90d240,0xc00018c150)
goroutine 1 [running]:
github.com/sirupsen/logrus.Entry.log(0xc0000623c0, 0xc000184630, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
/home//go/pkg/mod/github.com/sirupsen/logrus@v1.4.2/entry.go:239 +0x2cf
github.com/sirupsen/logrus.(*Entry).Log(0xc00018c0e0, 0xc000000000, 0xc00013f860, 0x1, 0x1)
/home//go/pkg/mod/github.com/sirupsen/logrus@v1.4.2/entry.go:268 +0xc8

Unless you redacted the address again this does still look wrong. I don't believe sarama understands :9092 as localhost:9092 if it was that what you were trying. Also these connection errors directly come from Sarama, so I'd definetely investigate whether your provided address string was wrong or whether the Cluster is actually accessible

i'm leaving out the actual server names for security reasons but here's how the env looks:
echo $KAFKA_BROKERS
:9092, :9092, :9092
Comma separated list of brokers.
The same servers are scraped successfully by kafka_exporter (which is not as comprehensive as this one)
Again, thanks for taking a look at this!

Sorry, I think adding "<>" is not working so this time, I took those chars out. :)

I am sorry I have no clue why this would fail as this is only being parsed as string array and then it's passed to sarama which tries to connect to the Kafka cluster.
You redacted the original input and your previous post indicate that you put a space after your commas. Maybe that's something you want to take a look at again? Other than that I don't have any ideas. I could probably change the log output so that it prints the parsed kafka brokers (string slice) instead of the raw input

@pvyaka01 Were you able to resolve the issue?

No, tried a couple of times and gave up. Perhaps some extra logging might help.
Thanks
On Saturday, September 14, 2019 Weeco<EMAIL_ADDRESS>wrote:
@pvyaka01 Were you able to resolve the issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Composer 404

placed this in my composer
"sproutvideo/sproutvideo": "1.0.3"
got back the following.
Problem 1
- The requested package sproutvideo/sproutvideo could not be found in any version, there may be a typo in the package name.
I am using it with laravel, but it shouldn't be an issue for composer to install it.

It should be there: https://packagist.org/packages/sproutvideo/sproutvideo
Perhaps it was a temporary issue with composer?
Are you still having problems?

Must have been, its working now.

Glad it's working now! Marking this as closed.


exe built on computer A can't run on computer B due to compatibility issue

So the symptom is simple, I compile an exe on computer A and run it on computer B, it would pop up a window saying:

Unsupported 16-Bit Application
The program or feature {exe name} cannot start or run due to in compatibility with 64-bit versions of windows.

I tried to compile it on computer B and run on A, still the same. I can confirm both computers are 64-Bit os and x64 processor.

Can you give us some true examples and details? It's not the way you pull a issue.

My apps built by nuitka are being downloaded and used by several hundred users daily, yet I have never received a report of this issue before. To investigate the problem, please provide at least the minimum information requested in the issue template, along with a minimal reproducer.

In the template, we have made it clear, that not filling out the issue template is not acceptable. I am closing this kind of report as invalid. The main reason is that we do not want to be left guessing. For you it's easy to erase the issue template and expect us to ask you questions only as necessary, but we cannot do that. We would much rather wait for you to create a new report, fill out the template, or wait for somebody with the necessary skill to do it.
In short: No issue template, no fun. Therefore we are  likely just deleting the issue, as it serves as a bad example and detraction for searches.  And even worse, it might keep good reporters from reporting as is this "already known."


[Bug]: The error script prompt is in English

ODC version
odc432
OB version

What happened?

What did you expect to happen?
Prompt in Chinese
How can we reproduce it (as minimally and precisely as possible)?
Save script in SQL window
Anything else we need to know?
No response

Fixed In Commit e0f83d9ddcee2e643fefb6e57636fe4883888345
------
xiaokang
Thu Sep 5 10:13:34 2024 +0800

pass


Kafka0.9 compatibility.

Kafka0.9 compatibility.

Sorry, i didnt mean to submit it for this project.


Memory leakage in integration tests

Hello again!
After running several integration tests in a springboot application using the cachecollection annotation, i get OutOfMemory exceptions. If I run the tests one by one they all pass so I guess there is something accumulating with each test.
Do you know of any possible memory leakage of the library or how tests deal with caches. I get the error even when "disabling" caching for tests!
Thank you very much!

Nevermind! It was my fault. I'm using it now properly and its giving great performance!!


I18n integration

This is my intent (choose one)

[ ] I want to report a bug
[x] I want to request a feature or change
[ ] I want to provide or change a feature

The problem
At the moment users of Hops (outside of XING) have to implement their own i18n solutions if they want to internationalize their applications.
Proposed solution
I would like to see a hops-i18n package, that takes care of setting up react-intl for server- and client-side rendering and also makes use of the react-intl babel plugin to automatically extract the default messages and writes them into a file, to be used for translators/translations.
Internally we already have something similar, maybe we can clean that package up and publish it here in the external Hops repository.

We are tracking this on our internal backlog and will provide a solution for it in the future.


DNS Zone import Unable to parse @ in RDATA

Describe the bug
DNS Zone import fails on records containing @ in RDATA
Command Name
az network dns zone import
Errors:
Unable to parse: ftp 3600 IN CNAME '@'

To Reproduce:
Import a DNS Zone file containing one or more records with @ in RDATA.  For example:
ftp	3600	 IN 	CNAME	@
Expected Behavior
Where an @ appears in RDATA, it should be replaced by $ORIGIN.  For example, the record:
ftp	3600	 IN 	CNAME	@
should be imported as ftp.<$ORIGIN>
Environment Summary
Aure Cloud Shell
Linux-4.15.0-1061-azure-x86_64-with-debian-stretch-sid
Python 3.6.5
Shell: bash

azure-cli 2.0.75

Additional Context

@NeighborGeek  Hello. Could you please share me with a tiny example file which will cause this error?

I've encountered this as well.
@MyronFanQiu please find attached a file that throws this error.
testdomainrsk.hosts.txt

@ioan-agopian Thanks for adding that.  I must have overlooked the reply, and never submitted the sample they requested.

Was there any resolution to this. Encountering the same error

@navarro-chamberlain, Could you replace @ with $ORIGIN in RDATA in DNS Zone file to workaround this issue?

I am also getting this error when importing a zone file:
Unable to parse: @ 3600 MX idctelemed-com.mail.protection.outlook.com. 0
Does anyone know of a solution to this problem?

@haroldrandom to help with.


change secret to secrets

@kahootali Chart: grafana Dry Run successful

@kahootali Chart: grafana-storage Dry Run successful


ORTEC # Job listed on peviitor is not displayed on the company's site

ENVIROMENT: production
URL: https://peviitor.ro/
Browser: Chrome
Device: laptop
OS: Windows 11
STEPS TO REPRODUCE:
1. Open URL in browser
2. Type "Ortec" in the search bar
3.  Click on the "Implementation Consultant" job title
4. Verify if the job is displayed on the company site

EXPECTED RESULTS:
Job listed on peviitor platform should also be accessible and consistent on the company's site
ACTUAL RESULTS:
"Implementation Cunsultant " job title does not appear on the company's official website. It appears that the page containing the job listings on the company's site may not be optimized or synchronized with the peviitor platform.

Job is no longer available