Support for starwars.com

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a new site support request
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that none of provided URLs violate any copyrights or contain any DRM to the best of my knowledge
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and am willing to share it if required

Region
Worldwide
Example URLs

Single video: https://www.starwars.com/video/trailer-the-bad-batch

Provide a description that is worded well enough to be understood
In March 2024 I was able to download any video from https://www.starwars.com/video/ with yt-dlp even though it is not on the supported sites list. Recently I found out it no longer works, I get an error:
ERROR: [Disney] Unable to download webpage: HTTPSConnectionPool(host='www.starwars.com', port=443): Read timed out. (read timeout=20.0) (caused by TransportError("HTTPSConnectionPool(host='www.starwars.com', port=443): Read timed out. (read timeout=20.0)"))
I am still able to download videos from Disney however ( https://ondisneyplus.disney.com )
As far as I can see, starwars.com does in fact use Disney servers.
Here's a link to a video that I can download with yt-dlp from Disney (second from last on https://ondisneyplus.disney.com/show/star-wars-the-bad-batch ):
https://video.disney.com/watch/star-wars-the-bad-batch-official-trailer-disney-5bec30e18976cebd6b4f2a72
The same video is on starwars.com, but I get the above mentioned error when I try to download it (second from last when you click on "The Bad Batch" on https://www.starwars.com/video ):
https://www.starwars.com/video/trailer-the-bad-batch
Videos can be successfully downloaded from starwars.com using the Firefox extension Video DownloadHelper, but I prefer and need to use yt-dlp.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
yt-dlp.exe https://www.starwars.com/video/trailer-the-bad-batch -vU
[debug] Command-line config: ['https://www.starwars.com/video/trailer-the-bad-batch', '-vU']
[debug] Encodings: locale cp1251, fs utf-8, pref cp1251, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [1a176d874] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg 6.1-full_build-www.gyan.dev (setts), ffprobe 6.1-full_build-www.gyan.dev, rtmpdump 2.4
[debug] Optional libraries: Cryptodome-3.21.0, brotli-1.1.0, certifi-2024.08.30, curl_cffi-0.5.10, mutagen-1.47.0, requests-2.32.3, sqlite3-3.35.5, urllib3-2.2.3, websockets-13.1
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets, curl_cffi
[debug] Loaded 1838 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)
[Disney] Extracting URL: https://www.starwars.com/video/trailer-the-bad-batch
[Disney] trailer-the-bad-batch: Downloading webpage
ERROR: [Disney] Unable to download webpage: HTTPSConnectionPool(host='www.starwars.com', port=443): Read timed out. (read timeout=20.0) (caused by TransportError("HTTPSConnectionPool(host='www.starwars.com', port=443): Read timed out. (read timeout=20.0)"))
  File "yt_dlp\extractor\common.py", line 741, in extract
  File "yt_dlp\extractor\disney.py", line 79, in _real_extract
  File "yt_dlp\extractor\common.py", line 1200, in _download_webpage
  File "yt_dlp\extractor\common.py", line 1151, in download_content
  File "yt_dlp\extractor\common.py", line 961, in _download_webpage_handle
  File "yt_dlp\extractor\common.py", line 910, in _request_webpage

  File "urllib3\connectionpool.py", line 536, in _make_request
  File "urllib3\connection.py", line 507, in getresponse
  File "http\client.py", line 1344, in getresponse
  File "http\client.py", line 307, in begin
  File "http\client.py", line 268, in _read_status
  File "socket.py", line 669, in readinto
  File "ssl.py", line 1241, in recv_into
  File "ssl.py", line 1099, in read
socket.timeout: The read operation timed out

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "requests\adapters.py", line 667, in send
  File "urllib3\connectionpool.py", line 843, in urlopen
  File "urllib3\util\retry.py", line 449, in increment
  File "urllib3\util\util.py", line 39, in reraise
  File "urllib3\connectionpool.py", line 789, in urlopen
  File "urllib3\connectionpool.py", line 538, in _make_request
  File "urllib3\connectionpool.py", line 369, in _raise_timeout
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='www.starwars.com', port=443): Read timed out. (read timeout=20.0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "yt_dlp\networking\_requests.py", line 328, in _send
  File "requests\sessions.py", line 589, in request
  File "requests\sessions.py", line 703, in send
  File "requests\adapters.py", line 713, in send
requests.exceptions.ReadTimeout: HTTPSConnectionPool(host='www.starwars.com', port=443): Read timed out. (read timeout=20.0)

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "yt_dlp\extractor\common.py", line 897, in _request_webpage
  File "yt_dlp\YoutubeDL.py", line 4172, in urlopen
  File "yt_dlp\networking\common.py", line 117, in send
  File "yt_dlp\networking\_helper.py", line 208, in wrapper
  File "yt_dlp\networking\common.py", line 340, in send
  File "yt_dlp\networking\_requests.py", line 352, in _send
yt_dlp.networking.exceptions.TransportError: HTTPSConnectionPool(host='www.starwars.com', port=443): Read timed out. (read timeout=20.0)

The Disney extractor handles starwars.com so it should be supported
https://github.com/yt-dlp/yt-dlp/blob/master/yt_dlp%2Fextractor%2Fdisney.py#L13-L44
This is most probably an extractor bug

Seems like an anti bot measure to me. Passing --impersonate chrome works.

Seems like an anti bot measure to me. Passing --impersonate chrome works.

So does --user-agent "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36"


Overlay image contains ruby in the glass

Do we want to have it there?

I think the idea is to use the image from here:
https://github.com/pyvec/resources/blob/master/Design/Pyvo Facebook Event Header/fb-source-brno.png


(Asserts) Tool Compatibility Issues

Hi all!
As you may know, we are currently using your USB FS device implementation, to which I've also contributed some of our changes. @vogelpi and I have also been looking for a good way for us to track your (upstream) repository. Unfortunately some of your recent changes (mostly to the assertion primitives) have caused a lot of issues for me, because the used constructs are not supported by our tools. I can fix this with patches/differences to your code, but this makes merging any changes extra difficult. I wanted to start a discussion on whether you'd be willing to tune your code in order to improve compatibility with a larger set of tools.
On our side, we currently need to support: Incisive 15, RTL Compiler 14 (old), Genus 15 (old), QuestaSim 10.7 and Design Compiler.
Observed Issues
Default Arguments for Defines
// From prim_assert.sv

// Assert a concurrent property directly.
// It can be called as a module (or interface) body item.
`define ASSERT(__name, __prop, __clk = `ASSERT_DEFAULT_CLK, __rst = `ASSERT_DEFAULT_RST) \
`ifdef INC_ASSERT                                                                        \
 __name: assert property (@(posedge __clk) disable iff (__rst !== '0) (__prop))         \
   else `ASSERT_RPT(`PRIM_STRINGIFY(__name), `PRIM_STRINGIFY(__prop))                   \
`endif
// Note: Above we use (__rst !== '0) in the disable iff statements instead of
// (__rst == '1).  This properly disables the assertion in cases when reset is X at
// the beginning of a simulation. For that case, (reset == '1) does not disable the
// assertion.

This is currently my main issue. Genus 15 does not support default parameters for defines, which means I can only have a single version of each macro. The only thing I could come up with is disabling all the assertions (during synthesis) and thus maintaining a separate version of all the primitives.
Multi-line Assertions
// From: tlul_assert.sv

  `ASSERT_VALID_DATA(aKnown_A, h2d.a_valid, {h2d.a_size, h2d.a_source, h2d.a_address,
      h2d.a_mask, h2d.a_user}, clk_i, !rst_ni)

This kind of expression caused issues with the elaboration in QuestaSim 10.7, which considered it unterminated. To work around it, we had to disable these assertions. I've also seen similar issues with Genus, but I was to remove the primitives, since they're not used in the USB peripheral.
Localparams
// From: usb_fs_nb_pe.sv
module ... #( // ...
  localparam int unsigned PktW = $clog2(MaxPktSizeByte) // derived parameter
);

Localparams within the port declaration are not supported by Incisive 15. So far I've manually replaced them with params in our repository.
Possible Solutions
As I can't do anything about these tools, I have to find a way to get this to work on our side and then keep it working with your frequent updates. I can maintain patches to apply to your codebase to make it work in our setup, probably disabling all the assertions. This essentially turns every update from your repository into a lot of work. Perhaps this could be partially automated, but I still don't think this is sustainable from my side. It would also not help any other people with similar tools and issues.
Alternatively, it might be nicer to implement some workarounds on your side. One idea would be disabling the assertions outside the macros, i.e. using
`ifdef INC_ASSERT
  // Flush and Write Enable cannot be asserted same time
  `ASSUME(ExFlushValid_M, flush_i |-> !valid_i, clk_i, !rst_ni)

  // While in flush state, new request shouldn't come
  `ASSUME(ValidIDeassertedOnFlush_M,
          flush_st == FlushWait |-> $stable(valid_i),
          clk_i, !rst_ni)

  // ...
`endif

instead of having the same switch inside the assert macros. This way parsing the assert macro can be completely avoided for the tools that have problems with it. Assertions would still not work with those tools, but at least they could run the code with a limited set of changes.
What do you think? Would you be willing to make some changes to your assertions to ease support for older/worse tools? Or do you have better ideas?

Thanks for opening this issue. While we try to support recent versions of the most frequently used tools, supporting older versions is effectively a race to the bottom. That being said, we're willing to compromise as long as it doesn't affect productivity or correctness too much.

On localparam: we went in circles with that one already a couple times. (lowRISC/opentitan#50, https://github.com/lowRISC/style-guides/pull/15). All current tools we've tested support it. Can you check if the current version of Genus supports it?
On the assert macros: I'm not sure we can find a good solution for that, other than removing the defaults again. Also on this one: does the current version of Genus supports it?

So overall:

If there's something that doesn't work in the most recent version of Genus, we have a strong incentive to find a workaround. So please double-check that if possible.
If not, I propose you give tools like sv2v a try, which should also help you with more incompatibilities you might run into in the future.

On localparam: That was actually a mistake on my side, Genus 15 does support it, but the Incisive simulator does not support it. It sounds like it's supported in newer (Xcelium) versions.
On the macros: The newest version of Genus seems to support it, even though the documentation states otherwise.
Unfortunately it is not really possible for us to upgrade to the newer tool versions due to licensing issues (it's just too expensive).
I understand that you have to draw the line somewhere and don't necessarily want to support old tools. The mish mash of SystemVerilog support in tools is really annoying. I'll think about using sv2v.

@stefanlippuner you can have a look at Ibex here and here for some experimental examples of sv2v usage.

@stefanlippuner thanks for raising this, and as @imphil mentioned it
is an unfortunate race to the bottom that we want to avoid. One split-the-baby
proposal we could consider is for the ASSERT macros in this area (I only count
12 in the USB code base) we define assertion macros just for USB that are
"dumbed down" (keeping the definition of these isolated into the USB code
space). This could work for those 12, but still doesn't solve the tlul_assert
inclusion files. We really would prefer us not revert the whole database back to
pre-default-era assertions. Let us know your thoughts on sv2v

I've played around with sv2v a bit. It seems to have similar issues with assertions. First I had to disable your assertions (with defining SYNTHESIS) and then I had to remove some of my local assertions too. After this the tool generated an output, but this was unfortunately not valid Verilog. I would also prefer to not add such an experimental tool to our workflow. I would actually prefer having a script that removes the assertions over using sv2v.
I understand that you don't want to change things in your codebase to account for older tools. I will therefore close this issue. On our side I will not track the changes to your primitives for now. If this becomes a problem I will probably use a script to remove the assertions.


npm Module

Package manage w/ npm.packages w/ optional dir arg (ie non-global install)

https://github.com/Fizzadar/pyinfra/commit/840653dea85231ac4b6699872f5a18d787419cc9


Demo App myapp is loading with scrambled screen.

Steps to Reproduce
Please tell us what you were doing and what went wrong. If you are running flutter tools from the command line, please try adding the -v or --verbose option to gather more information.
If the problem is with your application's rendering, please attach a screenshot and any relevant source code.
If you are getting an exception in the logs, and your code is implicated in the first few frames, then please include the source code for the functions involved.
Logs
Run your application with flutter run and attach all the log output.
Run flutter analyze and attach any output of that command also.
Flutter Doctor
Paste the output of running flutter doctor -v here.

For more information about diagnosing and reporting Flutter bugs, please see https://flutter.io/bug-reports/.

Hi @sutara-aayush this seems to be a rendering issue with the emulator, it should be resolved by running in software rendering mode by passing the enable-software-rendering flag to flutter:
flutter run --enable-software-rendering

Hello, thanks for help @xqwzts  i tried this but got something as below.

But i am able to see the devices using flutter devices

I'm not really sure what would be causing that, you're right that the device is detected, from the output we can see that the flutter tool detects the device, builds the apk, and segfaults either while pushing the files to the device or right after that while trying to run the app.
You might try to run in verbose mode:
flutter run --enable-software-rendering -v
Hopefully this will give us a more detailed error log that points to the cause.

Still its not working sir @xqwzts

@xqwzts  .. sir it started working as I updated to windows 10. Thanks for giving time sir.

I'm going to close this since it's not blocking you any more and we don't have enough information to fix it.


Using ActiveModelSerializer for Ember Data parsing

Add all attributes to format
Corrected my migration files
Corrected the structure.sql
Applied the class constant to the includes variable

Already merged!


gNOI-3.2: Adding wait time to avoid false failures

Adding 10s sleep after linecard reboot is issued, to ensure that the linecards reboot process has kicked in, before we pull the linecard status and the list of 'up' interfaces. This is to avoid false failures owing to timing differences.

Pull Request Functional Test Report for #2356 / 2c40ed729ffbc0800d6c65e980518e96ae3e967d
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

gNOI-3.2: Per-Component Reboot

Cisco 8000E

gNOI-3.2: Per-Component Reboot

Cisco XRd

gNOI-3.2: Per-Component Reboot

Juniper cPTX

gNOI-3.2: Per-Component Reboot

Juniper ncPTX

gNOI-3.2: Per-Component Reboot

Nokia SR Linux

gNOI-3.2: Per-Component Reboot

Openconfig Lemming

gNOI-3.2: Per-Component Reboot

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

gNOI-3.2: Per-Component Reboot

Cisco 8808

gNOI-3.2: Per-Component Reboot

Juniper PTX10008

gNOI-3.2: Per-Component Reboot

Nokia 7250 IXR-10e

gNOI-3.2: Per-Component Reboot

Help

There's already 10s sleep (in a loop) just below the one you added
https://github.com/openconfig/featureprofiles/blob/1d26646337e0fdecf7d0da8bb43cb4e98d230427/feature/gnoi/system/tests/per_component_reboot_test/per_component_reboot_test.go#L200
Any specific reason to duplicate it?

There's already 10s sleep (in a loop) just below the one you added
https://github.com/openconfig/featureprofiles/blob/1d26646337e0fdecf7d0da8bb43cb4e98d230427/feature/gnoi/system/tests/per_component_reboot_test/per_component_reboot_test.go#L200
Any specific reason to duplicate it?

Yes, in some corner cases we have seen the reboot process take around 10s to kick-in which leads to false failures. Didn't want to change the 10s thats within the loop. Hence added this one just before that. Thanks!

Didn't want to change the 10s thats within the loop

Why not? LC boot time limit is set to ~10 minutes, doesn't look like we need a frequent polling there. Having two sleep timers next to each other is confusing IMO :)
Having said that, it also feels strange that gNOI.system.RebootStatus() returns misleading active=false result flag for more than 10 seconds after receiving a rebootRequest RPC. Wouldn't you agree?

@sezhang2, just to confirm,
is it considered to be expected/valid behavior that an implementation may not return an active=true status in RebootStatusResponse (validated on L285-L291): https://github.com/openconfig/featureprofiles/blob/30a9fc77274d11a80a9d52a37ab43458d4338c90/feature/gnoi/system/tests/per_component_reboot_test/per_component_reboot_test.go#L285-L291) for more than 10 seconds after receiving a RebootRequest?

@sezhang2, just to confirm, is it considered to be expected/valid behavior that an implementation may not return an active=true status in RebootStatusResponse (validated on L285-L291):
https://github.com/openconfig/featureprofiles/blob/30a9fc77274d11a80a9d52a37ab43458d4338c90/feature/gnoi/system/tests/per_component_reboot_test/per_component_reboot_test.go#L285-L291
for more than 10 seconds after receiving a RebootRequest?

This PR only addresses the timing issue for line card reboot. Your question is  about fabric card rebooting from

https://github.com/openconfig/featureprofiles/pull/1701

Can you open an issue if there is a change needed for fabric card reboot test?

Your question is about fabric card rebooting from

My bad, I quoted the wrong line numbers. I meant L208-L213. But the same code blob is used for linecards.
https://github.com/openconfig/featureprofiles/blob/e0bea24146e94a1eaad2de2e656ffad5f04e1782/feature/gnoi/system/tests/per_component_reboot_test/per_component_reboot_test.go#L208-L213
And no, I don't think there should be an issue in either case even with the previous code, if implementation properly responds with an active status; i.e. I think the extra sleep shouldn't be required at all.
Just wanted to clarify what are the expectations for this code block, if any.
By making this change we are saying that a) implementation can implicitly delay the reboot of a component for more than 10 seconds (which is ok, probably), and b) at the same time it is not responding with an active=true (which is more questionable IMO).
But anyway.

Your question is about fabric card rebooting from

My bad, I quoted the wrong line numbers. I meant L208-L213. But the same code blob is used for linecards.
https://github.com/openconfig/featureprofiles/blob/e0bea24146e94a1eaad2de2e656ffad5f04e1782/feature/gnoi/system/tests/per_component_reboot_test/per_component_reboot_test.go#L208-L213
And no, I don't think there should be an issue in either case even with the previous code, if implementation properly responds with an active status; i.e. I think the extra sleep shouldn't be required at all.
Just wanted to clarify what are the expectations for this code block, if any. By making this change we are saying that a) implementation can implicitly delay the reboot of a component for more than 10 seconds (which is ok, probably), and b) at the same time it is not responding with an active=true (which is more questionable IMO). But anyway.

err check from fabric test case is missing. Basically, there are 3 possible return from resp.GetActive()

err is not nil (err returned). no retrun result for resp.GetActive()
true (err is nil)
false (err is nil)

I think for LC this code block will retry for every non-nil error except codes.Unimplemented (which will trigger t.Fatal), since retry var is initialized as true and is not modified. But I don't think the error check is relevant here.
The sequence of the events (pre-PR) was:

send rebootRequest
wait for 10 seconds
query RebootStatus
successfully exit only for nil error & active==false or after 10 minutes of waiting; or t.Fatal in case of unimplemented err

I.e. it appears that the OP encountered p.4 with nil error and active==false after 10 seconds of initial wait, and before the linecard began the reboot so the another condition at
https://github.com/openconfig/featureprofiles/blob/e0bea24146e94a1eaad2de2e656ffad5f04e1782/feature/gnoi/system/tests/per_component_reboot_test/per_component_reboot_test.go#L220
was instantly validated as well, and this led to a failure in the results. But if the implementation is able to set reboot status as active=true within 10 seconds after receiving the request, then this early exit won't happen.

Looks like we are talking about different things. err== nil needs to checked before evaluating resp.GetActive().
		case err == nil:
			retry = resp.GetActive()

That is why i say err check from fabric test case is missing.


API changes: particlefile.py and other touchups

Contributes to #1695
Changes

API changes

This PR makes many of the names in particlefile.py (and some other files):

private - in the case where users are not expected to use them (attributes and methods),
read only where edits to said variables would provide unexpected behaviour/side effects (attributes), or
removed (where they are either legacy code, or there are better mechanisms to achieve the same result)

All privatisations/removals are done in a non-breaking way, raising a deprecation warning.
The method/attributes affected are:

Class
Method/Attribute
Action

ParticleSet
iterator()
remove

ParticleData
iterator()
remove

ParticleFile
add_metadata()
remove

ParticleFile
write_once()
make_private

ParticleFile
create_new_zarrfile
read_only

ParticleFile
outputdt
read_only

ParticleFile
chunks
read_only

ParticleFile
particleset
read_only

ParticleFile
fname
read_only

ParticleFile
vars_to_write
read_only

ParticleFile
time_origin
read_only

ParticleFile
parcels_mesh
make_private

ParticleFile
maxids
make_private

ParticleFile
pids_written
make_private

ParticleFile
mpi_rank
make_private

ParticleFile
fill_value_map
make_private

ParticleFile
analytical
make_private

Grid
lon_grid_to_target()
remove

Grid
lon_remapping
remove

Grid
lon_grid_to_source()
remove

Grid
lon_particle_to_target()
remove

Variable
name
read_only

Once this is merged, I'll do some testing with the team, and then we can do a release


Add hover and click events to leaflet map elements

Hi,
according to the dash leaflet documentation the only events (to my knowledge) that are currently supported are

click_lat_lng: where you get the lat lon coordinates of the clicked point on the map
click_feature: where you can get the feature from a geojson data structure

What I'm missing are optional hover and click events for all elements placed on the map, where elements could be part of UI layers or Vector layers. The react leaflet documentation shows that such elements have an eventHandlers property where mouse events can be added.
Would it be possible to add an attribute to the dash leaflet components, like circle, polygon, line, marker, etc., that take a list of requested mouse events, such as 'click', 'hover', and then the dash callback would return the type of event (click or hover) and a) the reference to the element, if client-side callback, or b) the ID of this component, if server-side callback.

You can see what events have been mapped from the docs strings, when are generated based on the proptype definitions. For the Map component itself, the following properties represent events
    /**
     * Dash callback property. Receives [lat, lng] upon click.
     */
    click_lat_lng: PropTypes.arrayOf(PropTypes.number),

    /**
     * Dash callback property. Receives [lat, lng] upon double click.
     */
    dbl_click_lat_lng: PropTypes.arrayOf(PropTypes.number),

    /**
     * Dash callback property. Receives [lat, lng, accuracy] when user location is found.
     */
    location_lat_lon_acc: PropTypes.arrayOf(PropTypes.number)

In addition to these events, some component have properties that expose events related to the component itself. The Circle, Polygon, PolyLine, and Marker components that you mention all support click events already.
If you would like to monitor multiple components via a single callback, I would suggest using the GeoJSON component instead. In addition to click events, it  exposes the feature clicked as well as the feature hovered,
    /**
     * Dash callback property. Number of times the object has been clicked.
     */
    n_clicks: PropTypes.number,

    /**
     * Last feature clicked.
     */
    click_feature: PropTypes.object,

    /**
     * Last feature hovered.
     */
    hover_feature: PropTypes.object,

Thanks for your feedback.
I have two questions:

Is there a reason why only the Circle component has the n_clicks property and the others only the click_lat_lng and dbl_click_lat_lng properties?

Since I don't know how many Circle and Polyline elements I have on my map upfront I could use the GeoJSON component, according to your suggestion, but then I have to manually create circles, which is certainly possible.

Not going down the GeoJSON path would mean I have to create either n callbacks dynamically, or a single callback with an Input array of size n, like: [Input(str(i), "click_lat_lng") for i in range(n)]. But I don't know n upfront.
Now to my question:
The dash library supports Pattern-Matching Callbacks. But the examples only talk about dropdown components.
Would it be an idea to add support for Pattern-Matching Callbacks to leaflet components, to have one callback for a-priori unknown map components and return a specific value from the map component?

Pattern matching callbacks are supported. I didn't use them in examples to avoid unnecessary complicity. However, the GeoJSON component will yield better performance, especially if you have many features.


Use loop.connect_read_pipe and loop.connect_write_pipe

https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.loop.connect_read_pipe
Currently, the parent process uses blocking IO and asyncio.run_in_executor to read/write to the pipes used to communicate with the child process.  It appears that we can use the loop.connect_read_pipe to construct the appropriate StreamReader and StreamWriter instances to make this IO non-blocking and remove the need for a thread based executor.

Yes, you are correct. In order to make the I/O operations non-blocking and eliminate the need for a thread-based executor, you can use the loop.connect_read_pipe and loop.connect_write_pipe methods provided by the asyncio library.
By using loop.connect_read_pipe, you can establish a non-blocking read pipe and obtain a StreamReader instance.
These methods are useful when you want to communicate with a child process asynchronously, without blocking the event loop. By utilizing these methods, you can achieve efficient and non-blocking I/O operations within your asyncio-based application.
Please let me know if you have any further questions or need additional clarification!


Added configuration file support

All website IDs and secrets were moved to an external file called 'user_config.yaml'. Also a new saveddit.configuration module was created for parsing thic configuration file.
This module is searching for a file and, if does not find one, creates an empty configuration file, prompts user to place his valid credentials into this file and exits the script.
New dependency was added: pyyaml==5.4.1
'user_config.yaml' file was added to .gitignore to prevent sensetive data leak.

Seems to work nicely. Thanks!


Awesome

Hey there,
Just wanted to say that this is awesome. I'm so glad someone started this up. I was waiting on the Big Split :tm: to settle before starting this up so I'm glad you took the initiative to kick this off. I'm assuming since I'm running from master on all the Jupyter repos that this isn't quite in the state to work with the coming release of the split off Jupyter and IPython packages. Currently I'm seeing the display waiting on output:

Since you're down the same path, I might as well mention a few bits of interest. The comms channels for IPython widgets are going to be wonderful to use though we'll end up needing them decoupled from the Notebook:
https://github.com/ipython/ipywidgets/issues/13
We'll likely need zmq to bring in the latest nan to stay up to date with iojs. I ran into this while tinkering with an Electron app to display output alongside a console.
https://github.com/JustinTulloss/zeromq.node/pull/420 / https://github.com/JustinTulloss/zeromq.node/pull/421
I've noticed a couple deprecations, but I'll ship a PR your way shortly.

Forgot to mention, I poked the IJavascript developer to extract the messaging protocol into a separate package as jmp (Jupyter Messaging Protocol). It would be nice to share some common ground there.

Well, not surprisingly I was in a weird state from master that I figured out by dumping errors from when the kernel is booted. Now I get at least a check mark but no output.

Thanks! I really appreciate the support.
This is tested against the release builds of everything, not the upcoming Big Split versions. Like you, I'm waiting for the dust to settle a little before making those changes :) Hydrogen will need to keep supporting the pre-Split versions for a while, but it would be great to get a branch going to get ready for it.
Widgets are going to be great — I haven't looked into implementation for them at all yet.
io.js is getting merged back into node, so that may make things easier.
Totally on board with the idea of a shared codebase with jmp — I'll look into switching over to it. It would be great to have other people helping cover all the weird edge cases and faulty implementations of various kernels.

Oops! I should have reported back that it now works beautifully after getting everything setup with current master. Hydrogen does work with IPython 3.1.x and the future release (at the moment).

Awesome! Thanks for the report.
On Mon, May 18, 2015 at 1:11 PM Kyle Kelley<EMAIL_ADDRESS>wrote:

Oops! I should have reported back that it now works beautifully after
getting everything setup with current master. Hydrogen does work with
IPython 3.1.x and the future release (at the moment).
—
Reply to this email directly or view it on GitHub
https://github.com/willwhitney/hydrogen/issues/1#issuecomment-103137244.


Mithuns enable local administrator accounts on custom, sysprepped Windows Client VHDs.

Artifact to enable local administrator accounts.

The sysprep process disables local administrator accounts on Windows Client VHDs (Win 8.1, Win 10 etc).

Running this artifact during VM creation enables the disabled local admin accounts.

This will allow us to consume custom, sysprepped Windows Client VHDs in DevTestLab (e.g. VHDs exported from XLab).

Hi @mithunshanbhag, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (mithuns). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


some gifs not rendering properly on hub75 panel using ESP32-HUB75-MatrixPanel-I2S-DMA library

hello, trying to figure out why some of the gifs i attempt to display on my hub75 64x32 rbg matrix panel are coming up oddly. see the attached files. first is a working gif. second is a non-working test gif and third is video showing how it is rendering on my panel. i have not tested these tho on any other display yet (such as a pyportal as the original animatedGIF library examples seem to be based upon).

https://user-images.githubusercontent.com/22822528/159082362-cacdc553-879a-45f2-8feb-886e4800ac94.mov
i'm using code based on https://github.com/mrfaptastic/ESP32-HUB75-MatrixPanel-I2S-DMA/blob/master/examples/AnimatedGIFPanel/AnimatedGIFPanel.ino

Thanks for providing a sample image. I'll get back to you shortly.

I tested it and it works fine. The error is in the way that your GIFDraw callback is rendering each line. It appears to not be respecting the iX offset of each delta frame. See the example code in my library for how to do it correctly.

I'm having a very similar issue.  I suspect that it's this same thing... however I tried copying your GIFDraw method directly from the ESP32_LEDMatrix_I2S example and it does the same thing.  is there a specific example I should be pulling from for this type of gif?

GifPlayer.zip
Here's my applicaton

I didn't write the LEDMatrix example. I suggest you try a simpler setup with an LCD to understand how the library works. Then you can modify the code for your LED matrix.


Documentation code for monitoring.Empty is not well aligned

The documented code for monitoring.Empty is not well aligned (see [1], [2]). I do not know whether this is problem with the code itself or with the tool that generated it.
I believe that the whole example code should be indented once more.
Regards,
Ivan
[1] https://godoc.org/google.golang.org/api/monitoring/v3#Empty
[2] https://github.com/google/google-api-go-client/blob/master/monitoring/v3/monitoring-gen.go#L488-L491

Thanks for the report. It's an issue with the code generator. It needs to do a better job of scrubbing the descriptions it gets from the discovery doc.

@pongad, assigning this to you so it can be dealt with in the new code generator.

These clients are in maintenance mode. We don't plan to address this issue.
@pongad for the next generation of clients.


Automated cherry pick of #5054: fix: createdAt should not be synced when update

Cherry pick of #5054 on release/2.11.
#5054: fix: createdAt should not be synced when update

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@d9fc2ea). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.11   #5059   +/-   ##
==============================================
  Coverage                ?   7.07%
==============================================
  Files                   ?     482
  Lines                   ?   78393
  Branches                ?       0
==============================================
  Hits                    ?    5550
  Misses                  ?   72376
  Partials                ?     467

Flag
Coverage Δ

#aFlag
7.07% <ø> (?)

Impacted Files
Coverage Δ

pkg/compute/models/guests.go
0.63% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9fc2ea...eddc544. Read the comment docs.

/lgtm
/approve


thisgrsi.csh PATH not set correctly

ErrorReport.sh
HOSTNAME     = npb
SYSTEM       = Linux
OS           = Debian GNU/Linux
VER          = 9
GRSISYS      = /export/linux/local/GRSISort
ROOTSYS      = /export/linux/local/root6.14_debian9
ROOT Version = 6.14/04
Computer and Path to File that failed:
GRSISort Branch = master
commit badb21c2055699bcdfa0f65d8388b22973f281de
Merge: 3831583c 9075ad97
Author: Vinzenz Bildstein<EMAIL_ADDRESS>Date:   Sun Feb 6 18:27:04 2022 -0500
Merge pull request #1225 from VinzenzBildstein/master

Added binning label and preserving range when rebinning

Describe the bug
PATH variable not set correctly when running 'source thisgrsi.csh'. It works fine in bash when running 'source thisgrsi.sh'. It is missing the ':' between the paths that are added (which is the same path twice, too!).
Output from bash (correct):
msc2@npb:/export/linux/local/GRSISort$ echo $PATH
/export/linux/local/GRSISort/GRSIData/bin:/export/linux/local/GRSISort/bin:<etc, etc>
Output from csh (not correct):
msc2@npb:/export/linux/local/GRSISort$ echo $PATH
/export/linux/local/GRSISort/GRSIData/bin/export/linux/local/GRSISort/bin:<etc, etc>

I'll leave this to someone who actually uses csh to fix, but it seems rather simple if it's just missing a colon. Also I don't see the same path twice, just the path to $GRSISYS/GRSIData/bin and $GRSISYS/bin. The first directory actually does not exist, so it could be removed, which I have just done. I also changed the makefiles of ILLData and iThembaData to use $GRSISYS/bin (PR UoG-Nuclear-Physics-Group/ILLData#20 and UoG-Nuclear-Physics-Group/iThembaData#13) and removed the *Data/bin directories from the PATH variable (PR #1227) which might solve this issue?

Quote from Dan:
"On lines 172, 177 and 182 it sets the $PATH value but there are typos on each line. For example, on line 172 it says
setenv PATH &GRSIDATA/bin/$PATH which should be
setenv PATH &GRSIDATA/bin:$PATH
ie there is a / before the $PATH rather then a :
I changed this in the network installs in a file called thisgrsi_dsj.csh and if I source this, it seems to work.
Obviously, I have not ran anything beyond starting the program so I don’t if that fixes everything but the PATH is now correct."

Thanks for sending this, turns out I had only noticed the part where the /bin directory was added when $GRSISYS had already been set, but not when this is the first time the script is run. So now PR #1229 fixes that too.
I think with that we can close this issue. Thanks for bringing this to my attention Liam and Dan!


💬 RFC: New Catalog UI Plugin

🔖 Need
We would like to enhance the catalog view to better support the user experience of users who utilize their developer portal for both discovery of your organization's reusable solutions as well as operating and developing against a portfolio of components.
Pain Points addressed:
🤯 Our users found the current filters to be a bit confusing and the table to be overwhelming.
🤔 As a new user, it's difficult distinguish between reusable solutions and MY stuff.
🤑 When modifications are necessary, it required duplicating the catalog code, making it difficult to maintain and justify the small enhancements desired
🎉 Proposal

We are proposing an alternate Catalog UI for adopters with similar use cases and pain points. We want to make this available to others as a plugin and want feedback from the community on the layout, features, and applicability to other’s use cases.
✅ We updated the catalog view with a focus on usability and configurability.
✅ We created two layouts that users can toggle to support an explorative workflow where users are interested in the descriptions and tags and a more detailed view where users can see additional meta data.
✅ We updated how the tags visualize to provide more information and grouped categories and filters together
We believe this design will enhance the user experience of the catalog. This design was positively received during our user testing.
Usability

Full width table: Making the table full width allows users to see more information without scrolling horizontally
List and detail views: Two views to allow users to control the amount of information they want to see
Kind tabs: Utilized tabs for switching between entity kinds and extended it to allow multiple kinds at once
Quick filters: Updated the filters to show a series of quick filters with additional filters in an expandable panel. Use of a quick filter with custom filter implementation to identify reusable solutions.
Slide out drawer: Each table element has a drawer for quickly viewing more details without having to go to a component page. Great for people just exploring the catalog.

Configurability
Allow users to pass in customization to the page component as props without having to copy and recreate it.

Tabs - Developers can provide an array of tab objects to customize their table. For each tab the user provides an array of strings for the kinds that should be included on that tab (ex. ['component', 'template']). Next, an array of column elements for that tab. The default columns are exported from the plugin so they can be easily referenced and extended. Finally, an array of filters that should be available for the tab. There is a default tab configuration that comes with the plugin but developers can also customize each aspect.
Initial tab - Ability to select an initial tab on page load
Custom button title - Change the label for the create button
Page title - Change the page title

〽 Alternatives
When needing to make minor changes the catalog view we had to recreate it as a whole. When we decided to create an updated version based on several iterations of user feedback, we determined we had to recreate the table from scratch. We thought a better solution would be to make it easier to configure the table, reducing the need to duplicate Backstage code.
❌ Risks
No response
👀 Have you spent some time to check if this RFC has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

I love this design anything I can do to help?

@jrwpatterson Thanks so much! As of right now we are working with our organization to make the code available. In the meantime, we would love any general feedback you have or any pain points you experience that this would solve.
Also we could include you on future technical RFCs if you're up for it.

First: YAY! 🥳
On the question of pain points:

I hope this happens to use the new paginating endpoint of the catalog (/entities/by-query) and doesn't load the entire catalog in the background even though only the first page is seen. This would instantly resolve some issues that have been around for a long time, which would be wildly popular!
I hope the filter sets are a bit more robust than the current ones, with fewer spurious repaints and stuff like that.
Plus it looks GREAT! Can't claim that the old one does :)

Random thoughts:

Make sure that it fully supports custom / extended entity models and doesn't make assumptions about what kinds or fields exist etc. But it seems you probably have that covered, from the description!
You mention the name of the create button and page title.  It may be the case that those could be covered by the recent i18n efforts rather than as props?
Custom filter controls, custom cell renderers, custom tile renderers (in the expanded mode), and the ability to customize what goes in the flyout "quick peek" pane could come into play here.

Hi @morganmspencer!
Thank you for this amazing write up and proposal. In addition to feedback from the rest of the community, we're going to bring this to our internal design team to critique and come back with feedback. Hopefully we should get back within 2 weeks.

Just wanted to say I really like this as well and I think it's cool to see a few things here:

This wider style with tabs for Kinds is also something that Roadie just release so clearly this is a pattern other have been independently thinking about so another confirmation of the research done for this design: https://roadie.io/blog/august-2023-product-updates/#new-catalog-page-preview
This is a bit on the fun side but what is old is new again, back in the early days of Backstage it did have tabs for the Kinds. You can see that in this PR from August 2020: https://github.com/backstage/backstage/pull/2076

I have to agree the filters at the top are better because of the wasted space under the filters. I'm a maybe on the kind tabs. Someone might have more custom kinds which can make the tabs unwieldy. Maybe you can turn it into a drop-down or a carousel if there are more than standard 8 or so kinds

Hey, thanks for presenting this proposal!
After taking a quick look it seems to be a solution catered to a specific need and may clash with a larger set of needs across Backstage adopters.
Some points that jumped out to us, going over this for the first time

Icons without labels are less accessible, perhaps try to clarify the intentions to help guide user's expectations.
Is the side drawer overlay necessary? It's a little hard to tell from the video because it is showing so quickly. But it seems as though it offers a new view of what's already displayed in the rows.
In general, the UI uses lots of icons, some interactive, some for orientation and others for state. The UX could benefit from using them more consistently.
The initial table view is highly complex and quite dense, it may be beneficial to save the user some processing by instead displaying some of the information in their respective detail views.
Horizontal tabs have been problematic for us, if there are more tabs, what will happen? What if the browser window is narrow?

It appears to us as if this solution tries to do everything at once, which seemingly helps those users who built it and are already familiar with it. For first time users, it's complicated to get going and may break for a different set of data/requirements.

@morganmspencer we will be considering some holistic improvements to the catalog page in the upcoming year and would love to involve your ideas and feedback.
For now I'm going to close this out but we'll hope to re-open once we re-approach this topic next year. Thank you for contributing your ideas!


Unable to create the Bot with Composer.. Always throwing this error

Describe the bug
Bot composer doesn't create the project with the 'Enterprise Assistant Bot'
Version
Version:  2.1.2
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0
Browser

[ ] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[X ] Edge

OS

[ ] macOS
[X ] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Go to 'Composer'
Click on 'Create a new bot to get started'
Select 'Enterprise Assistant Bot'
Select the destination path
Click on Create

Expected behavior
Project should be created
Screenshots
Error Message:
Error hit when instantiating remote template: C:\Users\ABCD\AppData\Roaming\BotFrameworkComposer.yo-repository\node_modules@microsoft\generator-bot-enterprise-assistant\generators\app\templates\botName.sln:6 4| VisualStudioVersion = 16.0.30503.244 5| MinimumVisualStudioVersion = 10.0.40219.1 >> 6| Project("{<%= projectType %>}") = "<%= botName %>", "<%= botName %><%= botName %>.csproj", "{<%= botProjectGuid %>}" 7| EndProject 8| Project("{<%= projectType %>}") = "Calendar", "Calendar\Calendar.csproj", "{<%= calendarProjectGuid %>}" 9| EndProject projectType is not defined
Additional context

Hi @subhashkotu this is a known issue and we are working to publish the fix ASAP. I will update this when it is in.

Version 1.2.2 of the Enterprise Assistant template has been published and is available in Composer. Please try again and let us know if this resolves your issue!

Sorry to hijack the issue: I encounter the same issue "Error hit when instantiating remote template: Trying to copy from a source that does not exist: \projects\Bots\CoreWithQnA\CoreWithQnA\botName.csproj" when trying to create any kind of bot. Using Release:2.1.1-nightly.289819.d04ceae

closing this as resolved please reopen if this is not the case


Manually close tabs when they're closed while dragging them

Summary of the Pull Request
When we're dragging the tab around, if you execute a ClosePane/CloseTab, then we should make sure to actually activate a new tab, so that focus doesn't just fall into the void.
References

This is almost exactly #5799, but with rearranging tabs

PR Checklist

[x] Closes #5559
[x] I work here
[ ] Tests added/passed
[n/a] Requires documentation to be updated

Detailed Description of the Pull Request / Additional comments
We suppress _OnTabItemsChanged events during a rearrange, so if a tab is closed while we're rearranging tabs, the we don't fire the SelectionChanged event that we usually do during a close that would select the new tab.
Validation Steps Performed

Tested manually

Confirmed that tragging a tab out, closing it, then dragging it back in does nothing.

the currently dragging tab gets removed from the list, and everything is just.. okay?

Shockingly, yea. I bet the whole drag-drop is managed by something like sihost or OLE, and the "tab view item" that's being dragged gets cloned to that process, and then when we remove it on our side, it just, doesn't exist anymore. It worked better than I expected.


Get parent Model inside Attr_json nested model.

I'm trying to implement an relation to parent model, like belongs_to behavior inside an 'AttrJson::Model', there's an "gem Way" to do that?
My current solution is to pass the parent model to the method I'm calling, but this leads to others questions and more complexity. Like: AttrJsonModel.new().called_method(parent, *other_args)
But it's in some way possible to do inside method:
class Model
  include AttrJson::Model

  def called_method args
    ...
    self.parent_model
    ...
  end

Could you share some thoughts about this need?
Thanks for all.

Thanks for trying out attr_json and asking a question!
Ah, I see what you mean. The parent naturally has access to it's embedded children, but the children don't have access back up to the parent.
There isn't any supported way to do that at present. I haven't been able to figure out a good way to implement it. So currently it's not supported.  I myself have not needed it.
If you can figure out a simple and maintainable way to PR this to be built-in, I'd be willing to consider it -- but it might be tricky, not sure it's feasible. I am cautious of making this code any more complex or harder to maintain. The way we use the ActiveModel type serialization/deserialization system to implement... I'm not sure how feasible it is.

Thanks for trying out attr_json and asking a question!
Ah, I see what you mean. The parent naturally has access to it's embedded children, but the children don't have access back up to the parent.
There isn't any supported way to do that at present. I haven't been able to figure out a good way to implement it. So currently it's not supported.  I myself have not needed it.
If you can figure out a simple and maintainable way to PR this to be built-in, I'd be willing to consider it -- but it might be tricky, not sure it's feasible. I am cautious of making this code any more complex or harder to maintain. The way we use the ActiveModel type serialization/deserialization system to implement... I'm not sure how feasible it is.

Thanks for your reply @jrochkind !
I'll take a look at this feature and try to find a maintainable way.

Thanks for your reply @jrochkind !
I'll take a look at this feature and try to find a maintainable way.


Upgrade TargetFramework in TestServer from 4.5 to 4.6.1

Aligns with the rest of ASP.NET Core and removes the dependency on .NET 4.5 to build the WebSockets repo
Addresses https://github.com/aspnet/WebSockets/issues/185

@mikeharder,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Just realized I probably need to update https://github.com/aspnet/WebSockets/blob/dev/samples/TestServer/App.config to 4.6.1 as well.  Though AppVeyor and Travis are passing with the current app.config.


portico: Align homepage header text with paragraphs.

These screenshots were taken using Chrome inspector's device toolbar at 375px width:

This might be fixable in conjunction with #10726.
@zulipbot add "area: portico"

@zulipbot add "bug"

I've made a PR for #10726. Can I claim this? :smile:

@zulipbot claim


Rename global badges navigation menu entry from Badges to Global Badges

Link names should match page titles, change Badges link in navigation menu on /administrator view to be Global Badges to match the destination page title.

:+1:


adaptions for open access

Addressing some bugs with dataset class when loading csvs from openaccess version.

Thanks for the spot @RichardP-tt. I have updated gitignore and removed from cache.


Add Morpion Solitaire

Adding a new game Morpion Solitaire (or Join Five).  Morpion Solitaire is typically a paper and pencil game for one or two players, played on a plus-shaped grid of dots. For this specific implementation, this is only for one player, and uses a simplified variation "4D" (4 dots per line, disjoint variation). This game has been subject to a variety of theoretical studies, and it would be interesting to see more modern RL techniques applied in the future.
Not sure how much of the spiel.h interface needs to be implemented but happy to iterate on the PR.
Thanks for this awesome repo!

Nice, thanks!! I am on vscation now until after the holidays, so I will take a look in January.

Meanwhile, I started the tests.

Can you also add it to the games list in docs/games.md?


Handle GH links natively

Extension to #146
When a user inputs a full GitHub URL, we should modify the text to it's shorthand counter-part (where appropriate) and also handle it natively rather than opening in a Safari VC
Examples:

[ ] https://github.com/rnystrom/GitHawk/issues/441
https://github.com/rnystrom/GitHawk/issues/441 (Should go to the issue)

[x] https://github.com/rnystromtest/Githawk-Playground/issues/2
https://github.com/rnystromtest/Githawk-Playground/issues/2 (Should go to the issue)

[ ] https://github.com/rnystrom/GitHawk
https://github.com/rnystrom/GitHawk (No shorthand; Should navigate to the repository view)

The first one does not work (anymore) as the repository has been moved to the organization. GitHub itself reroutes it. Can we do that too?

Also these links aren’t shortened anymore 🤔
Sent with GitHawk

Oh I think that might be because I put them in a list
Sent with GitHawk

https://github.com/rnystrom/GitHawk/issues/441
https://github.com/rnystrom/GitHawk/issues/441 (Should go to the issue)
https://github.com/rnystromtest/Githawk-Playground/issues/2
https://github.com/rnystromtest/Githawk-Playground/issues/2 (Should go to the issue)
https://github.com/rnystrom/GitHawk
https://github.com/rnystrom/GitHawk (No shorthand; Should navigate to the repository view)
Sent with GitHawk

Looking here, the shorlinkInfo method works fine; the context.inLink flag is false tho on all of them.
They also all have leading spaces: " https://github.com/rnystromtest/Githawk-Playground/issues/2"  when you print them?


chore(release): v4.30.0

Release v4.30.0

Running tests on main (triggered it before I thought of a release).


openbsd/mips64: x/sys incompatible with main repo

CL 459497 was submitted to x/sys with the result that x/sys cannot be imported into the main repo without breaking GOOS=openbsd GOARCH=mips64 ./make.bash. This blocks all non-openbsd development from importing a new x/sys, which in turns blocks importing a new x/tools and x/net. This is of course not a viable development state.
Deferring to the openbsd-mips64 maintainers' decision on that CL that this breakage is the best possible state of affairs, the response for the main repo should be to remove openbsd-mips64 from the misc-compile-openbsd builder, which I will do.

Reopening, since the underlying issue was never fixed as far as I can tell. I'm going to mark this port as broken per https://go.dev/wiki/PortingPolicy#broken-ports: the build is completely broken.
cc @golang/openbsd


Python ALU Ops Dtypes

Adds:

Consideration of dtypes when performing alu ops in ops_python emu.
Necessary helper functions for this and modified exec_alu.
Consideration of vectorized operands/result was not made but maintains old behaviors.
Rounding of floats in limited scenarios (can be disabled) which assumes IEEE standard precision.
Overflow checking on non-floats.

Is the uops tests timing out? Locally the tests take ages and seems like it times out after 20mins, there are like 3 tests that take the majority of the time. I might be able to speed it up if I don't copy where inputs.

Closing again, probably not going to pick this back up. There are a couple oddities that make strict type enforcement difficult. Maybe just the cast at the end is possible for now. Also uops test slow.


nixos/looking-glass: init module

Motivation for this change
A module for looking-glass-client that automatically creates the tmpfiles rule for the shared memory file and manages the config.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This is a module for a regular desktop user, not a system user, so maybe this module belongs in home-manager instead... 🤔

I think I made a mistake when force pushing that caused this to be automatically closed


Unconventional sunrise sunset times

Rebased this branch https://github.com/basnijholt/adaptive-lighting/pull/535 addressing https://github.com/basnijholt/adaptive-lighting/issues/105 given the updates since it was created. It works fine adding it to my homeassistant integration but I can't get the tests to run correctly (Triggering pytest-socket somehow and causing every one to instantly stop, not an actual test failure) so it would help if someone who has had success running those before could make sure something else wasn't unintentionally broken.

I'm confused. So you forked over my existing PR at #535, then you modified it, then you submitted a new pull request for us asking to merge this. But more importantly, why is your PR showing that I committed here two days ago?

Is this a github bug?

This is standard behavior of Git and not related to GitHub. @b-rad15 rebased your branch, which created copies of your original commits. Git automatically assigned you as original author of these commits, and @b-rad15 as the committer. He ran the rebase operation two days ago (from the time of your post), hence the date. So this is basically Git's way of crediting your past work to you, even when copied by someone else.


fix: Bug when displaying hours in french in Item Stat

In french, in item stat, the number of hours is wrong, e.g:

Hey @Benio-B , this bug was already pointed and fixed on unstable. It will make its way to stable in the coming month. I really appreciate any and all contributions but

Hello @CyferShepard  thank you for your quick reply! Indeed, I had not seen that it was already fixed, I close the PR 🙂


Render issue and CSS positions

Hello,
This is a follow up to my comments on https://github.com/martinlaxenaire/curtainsjs/issues/74.
Good news, the CSS did fix my issue! The effect is being applied to the image. But now that I have it working, I have ~two issues~ one issue I'm struggling to solve.
~For the first issue, I've put an element on top of the curtains image. The element is a card containing text and an image. On hover, the card will translate up by a few pixels and change its box-shadow. When this hover transition occurs in Google Chrome Version 87, the element flickers. This flicker is not present when curtains is disabled.~ Unrelated.
For the second issue, I've tried using curtains with an absolute position applied to .curtains-canvas. The result is that scrolling causes the image to translate upwards at a faster rate than the scroll. With a fixed position, this issue doesn't occur. But, instead the image has a delayed scroll which feels mushy.
The filters I am using can be found on this post:
https://css-tricks.com/animate-images-and-videos-with-curtains-js/
My project is running on Gatsby Version 2.22. You can see the curtains.js image running as the hero banner here: https://dev.ceiphr.com/
~Weird sidenote: Curtains fails to run in my project on Firefox 84. But it's working in Chrome and Firefox Developer Edition (85b). I'm going to investigate this further. I'm assuming it's something I've done with Firefox.~ Unrelated. Fixed.

Hey @ceiphr,
in this case, you could indeed set the curtains container position to absolute and set it watchScroll prop to false. This should do the trick.
Cheers,

Hey @ceiphr,
in this case, you could indeed set the curtains container position to absolute and set it watchScroll prop to false. This should do the trick.
Cheers,

That worked perfectly, thank you!

That worked perfectly, thank you!


data for time series example

is this available somewhere to work with the notebook tutorial?
https://github.com/vsmolyakov/experiments_with_python/blob/master/chp01/keras_lstm_seqclass.ipynb

Yes! The data for the time-series notebook can be downloaded from:
http://www.cs.ucr.edu/~eamonn/time_series_data/
As the notebook mentions, the specific dataset used is: ECG5000.


[BUG] Options in Firefox are not saved

When changes an option in Firefox this is not saved, I don't know if it's so in chrome

uninstall translate-man extension and reinstall


Losing Money + Added Item Gone

Seems that purchasing items only loses main balance. Haven't had a item that made me money so far.
Also, there seems to be a bug that after 30 seconds, it stops actually buying the items since the "Added Item" notification is gone. This is on Windows 10 ver 1909
[LOG:] Bought 5c1e2a1e86f77431ea0ea84c [ item_lab_glass_office ] at 88000 / 93465
Waited 0.4769145178794861 Seconds before purchase
Purchase Success ... ADDED ITEM
| Stonks: + 5,465 ₽ |
[19:54:25] Balance: 2,765,343 ₽
[LOG:] Bought 5c1e2a1e86f77431ea0ea84c [ item_lab_glass_office ] at 89500 / 93465
Purchase Success ... ADDED ITEM
| Stonks: + 3,965 ₽ |
[19:54:26] Balance: 2,675,843 ₽
[LOG:] Bought 5c1e2a1e86f77431ea0ea84c [ item_lab_glass_office ] at 90000 / 93465
Purchase Success ... ADDED ITEM
| Stonks: + 3,465 ₽ |
[19:54:26] Balance: 2,735,387 ₽
[LOG:] Bought 5a1452ee86f7746f33111763 [ San 222 Key ] at 77700 / 79222
Purchase Success ... ADDED ITEM
| Stonks: + 1,522 ₽ |
[19:54:27] Balance: 2,721,065 ₽

dublicate of https://github.com/Avnsx/EFT_Flea_Market_Bot/issues/4


Broken image link in design.md

Design.md has a link to : https://github.com/google/key-transparency/blob/master/docs/images/arch1.svg which does not exist.

Closed in #461.


Add token to checkout action

The Versioning workflow creates a PR but the Kubernetes build/test/publish workflow doesn't run when the PR is created.
We think this is because it's using the GITHUB_TOKEN to authenticate.
I believe updating the checkout action to use the changeset token should make all subsequent usages of git use the same token which should fix the problem. Hard to say if it will work until after it's merged though.

No changeset required because there is no change to the helm chart.


add openblock wallet support

Hello there,
Dev from OpenBlock wallet team,
We have recently published OpenBlock plugin for aptos-wallet-adapter.
This plugin is an implementation of AdapterPlugin from '@aptos-labs/wallet-adapter-core' for OpenBlock wallet.
We'd like to add some code examples correspondingly in this repo and list our plugin name in the wallet list section of README.md.
We've tried following the guidance from the CONTIRBUTION.md as mush as possible.
Please kindly let us know if anything in this PR is not looking right.
Thank you.

@nikli2009 I approved and merged, but https://aptos-labs.github.io/aptos-wallet-adapter/ outputs a console error regeneratorRuntime is not defined - that breaks openblock support. You might want to add it to the openblock npm plugin package...?

@nikli2009 I approved and merged, but https://aptos-labs.github.io/aptos-wallet-adapter/ outputs a console error regeneratorRuntime is not defined - that breaks openblock support. You might want to add it to the openblock npm plugin package...?

🤔 that's a good idea, I guess will have to submit another pr to pump the version of the plugin later.


add PTAL status info, reviews

Adds embed status colors, status field, and review tracker to the /ptal command.
Significant changes:

Added a GITHUB_TOKEN env variable to avoid rate limits with octokit.
Removed the changesets field. Wasn't always relevant and seemed like a lot of noise.
Tracks reviews per user and uses them to determine the PR status.
Removes the Update button when a PR is closed or merged (since you would no longer need to update the /ptal).
Changes the embed author to the GitHub PR author rather than the PTAL requester.
Adds PTAL requester (or updater) to the embed footer and includes a timestamp of the last update.

I tested this on the bot server and it all seems to work smoothly!

I had a look at the changes, but without testing it's hard to confirm. I think exposing our test platform (e.g. discord dummy bot and server) among our Team could help test each other's PR easily.

Yeah definitely @wassfila! I am in the bot server now and tried this out locally. Seems to work nicely!

Why do we need a GitHub token?

@mandar1jn There is a token for the GitHub org but I don't think I have access to it, let me try to track that down.

@mandar1jn There is a token for the GitHub org but I don't think I have access to it, let me try to track that down.

Please don't send that here

I have also seen some positive feedback to the changeset field (specifically from @sarah11918 ). Are we sure we want to remove it?

Good point! I'm happy to add it back, probably best to keep it.

I have also seen some positive feedback to the changeset field (specifically from @sarah11918 ). Are we sure we want to remove it?

Good point! I'm happy to add it back, probably best to keep it.

I feel like that's best


UI/button generator tooltips

Related to #

Description
Adding some tooptips to the button generator fields based on copy from the docs page
Test plan
Run the app and check the button generator. Try the tool tips on the form

Sure, guess I lean towards brief for tooltips, how about these?
Also note, I added one on random satoshis, but it was making the label too long, so I abbreviated the label...let me know if any issues/suggestions there


Error with rebar in .tool-versions

Hello,
With this in my github workflow:
[...]
    - uses: erlef/setup-beam@v1
      with:
        version-type: strict
        version-file: .tool-versions
[...]

and this in my .tool-versions:
erlang 25.1.2
elixir 1.13.4-otp-25
direnv 2.28.0
nodejs 18.12.0
rebar 3.15.0

The setup-beam action fails like so :
Run erlef/setup-beam@v1
Parsing version file at .tool-versions
Installing Erlang/OTP OTP-25.1.2 - built on ubuntu-22.04
Using Elixir v1.13.4 (built for Erlang/OTP 25)
Installing Elixir v1.13.4-otp-25
Running mix local.rebar,--force
Running mix local.hex,--force
Installing rebar3 3.15.0
  /home/runner/work/_actions/erlef/setup-beam/v1/dist/install-rebar3.sh 3.15.0
  Installed rebar3 version follows
  escript: exception error: undefined function rebar3:main/1
    in function  escript:run/2 (escript.erl, line 750)
    in call from escript:start/1 (escript.erl, line 277)
    in call from init:start_em/1
    in call from init:do_boot/3
  Error: The process '/home/runner/work/_actions/erlef/setup-beam/v1/dist/install-rebar3.sh' failed with exit code 127

I removed it to get everything to work as expected, as it is not useful in my usecase, since mix will install it locally.
But I thought I ll report here anyway, in case it helps to track down the actual issue...
Cheers

I removed it

What is "it" in this context? The .tool-versions line pertaining to rebar3 (a.k.a. as rebar by asdf)?
I should add this to the test suite, if it's not already there, to have a starting point for the fix.
Thanks for the report.

I'm gonna start checking this now, but I'd like to know if rebar3 3.15.0 runs on OTP 25 with no issue, out-of-the-box.

As per the linked pull request (just above), and my test results, I conclude that rebar3 3.15.0 is just not compatible with OTP 25, as can be seen in the result we obtain when bumping the test to use 3.16.0. I'll still leave the test there, since I feel it's important, but I'm closing this issue. Feel free to re-open after you test, locally, that rebar3 3.15.0 doesn't react the same in the folder where you have it be managed by asdf alongside Erlang/OTP 25.1.2.


Add rootStack types to override helper package

Description of changes
Add rootStack types to override helper package

Description of how you validated changes
-Manually tested
Checklist

[x] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #8298 (299b015) into extOverrides (ee1c49e) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           extOverrides    #8298   +/-   ##
=============================================
  Coverage         55.57%   55.57%
=============================================
  Files               706      706
  Lines             38996    38996
  Branches           7865     7865
=============================================
  Hits              21671    21671
  Misses            16535    16535
  Partials            790      790

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee1c49e...299b015. Read the comment docs.


Convert with annotations

This is a great tool.
I have an idea that although annotations are not included in the Json standard, they have been widely implemented; Can our tool also place the corresponding comments after the converted fields while parsing Json?

That's probably okay to support, but hmm, that might be complicated since we just traverse the parsed JSON structure as a JS value, so the comments would have to be reconstructed from manual parsing somehow. I'm not sure it's worth the complexity...


Added 2checkout improved gateway

Added 2checkout improved driver.

Thanks for the update.

Hi, is it possible to add Superlogica gateway?
http://superlogica.com/developers/


Reason for do { ... } while(0) in macros?

I've seen that in the C version they are without this: https://dunkels.com/adam/pt/expansion.html
Is there a reason for the existence of do { ... } while(0) in the macros?
I quicky changed them in simcpp and at least the examples seem to work the same.

Probably it's for more complex cases (loops where {} are missing).
I think I'll be using c++ coroutines instead of this, it's a way too nasty hack for my taste.

Thanks. Yeah, this is a very common pattern in C macros. See https://stackoverflow.com/a/2687595/68707


feat: added an OpenLDAP testcontainer module

I noticed that there currently is not LDAP testcontainer.
Similar to the go testontainer modules, I chose the bitnami/openldap containers.
Similar to https://github.com/testcontainers/testcontainers-rs-modules-community/pull/178, this PR includes the mongodb-example-fix.

The testcase failour seems to be because https://github.com/paupino/rust-decimal/issues/669
We could solve this by adding  --locked to the cargo-hack command.
With that flag, the PR tests were to be green

Thank you for quick changes! ❤


How to set the 'count' parameter

https://github.com/RoyZhengGao/edge2vec/blob/e6637e638919b364ac081826c68879daf182ae73/transition.py#L108
Hi Zheng Gao:
I applied edge2vec to @dhimmel hetionet, it has more than 2 million edges. When the 'count' is 1000  em_iter = 5 walk_numbers = 10,  the results (auroc of validation sets) are not improved compared to node2vec.
Why you set it as 1000 and do you have any suggestion for me ?
Thank you!
Lingling

hi have you solved  the problem after that？


Multiple CSS Classes with CSS Modules.

I have a simple list item menu, each with its own unique icon which I have styled using background-image. At any given time one of these items is the 'active' item and has additional styles to indicate this state however I cannot seem to get css modules to include both styles at the same time.
example JSX
`import React, {PropTypes} from 'react'
import styles from './portfolioitem.scss'
export class PortfolioItem extends React.Component {
render () {
const stylee = styles[this.props.label]

if (this.props.activeItem == this.props.label){
  const stylee = styles[this.props.label] + ' ' + styles.activeitem
}else{
  const stylee = styles[this.props.label]
}

return (
  <li className={stylee}>
    {this.props.title}
  </li>
)

}
}
export default PortfolioItem`
example SCSS
li {   &.tdcbitworks { background:url('some/url/image.png') no-repeat;   }   &.activeitem {     background: mediumpurple;   } }
EDIT: Sorry I cant seem to get jsx to work with the code tool on github

I think your problem maybe that your are redefining const stylee again inside the if statements. Try:
let stylee = styles[this.props.label]

if (this.props.activeItem == this.props.label){
  stylee = stylee +' ' + styles.activeitem
}

Alternatively, look at the classnames package for a more common way of solving these kinds of things: https://www.npmjs.com/package/classnames

Thanks for getting back to me. Your suggestion on using let instead of const didnt work but I'll try the classNames module tomorrow and see how that works out. Thanks you.
Keep up the great work. Cheers.

What if you try just using the classes themselves without prefixing them with the li tag name?
.tdcbitworks {
  background:url('some/url/image.png') no-repeat;
}
.activeitem {
  background: mediumpurple;
}

render () {
  const classes = styles[this.props.label]

  // ...
}

Yes, I was using CSS modules incorrectly. I've been using nested sass so long it was a illogical step back, in my mind, to make each class modular. I have a working solution now and can see the benefit of working this way. Thanks for your help.

🎉


fix save image/video on mobile

It still shows as red thus refuses to actually save stuff into Photos library. I think this'll be completely fixed after @jzila 's fix for the promise resolve (KBFS-2925) is in.

@songgao: I think the promise resolve thing is only happening on intent === 'none'

@zanderz Not really 😂 sorry bad title.

Ah renaming my .mp4 file into .mov worked. So it's probably an iOS thing.


First window on first workspace is closed after swithcing to another workspace

This is problem is a bit odd. I will try to explain as best as I can.
When I open any window on the first workspace after fresh Xorg startup it gets closed after I move to any other workspace.
But If I switch to workspace 2 (or any other) and open window there, this bug does not occure.

And I have minor suggestion: cycle_focus should raise the newly focused window. I personally solved this with a script that just runs window_raise after cycle_focus.
PS: This wm is really nice, I like that it has window snapping by default so that I don't have to use wmutils, it's not as minimal as sowm, which is my wm of choice, but it runs perfectly (apart from this bug).

can you post your autostart?

Here you go:
#!/bin/sh

# Start sxhkd
sxhkd &

# Colors
berryc focus_color 282A36
berryc unfocus_color 282A36
berryc inner_focus_color 9AEDFE
berryc inner_unfocus_color 282A36
berryc text_focus_color 282A36
berryc text_unfocus_color F8F8F2

# Decorations
berryc border_width 4
berryc inner_border_width 2
berryc title_height 20
berryc set_font "IBM Plex Mono-11"

# Behavior
berryc smart_place "true"
berryc draw_text "true"
berryc decorate_new "true"
berryc top_gap 0
berryc edge_gap 12 12 12 12
berryc json_status "false"

Note: It doesn't matter if I start sxhkd from the autostart or .xinitrc this bug happens regardless of that

Oh, can you also post your sxhkdrc (I should have asked for this originally)

Don't worry about it. Sorry for the late reply
#
# Programs
#

# Terminal emulator
super + Return
    urxvt

# Launch slock
super + shift + x
    slock

#
# dmenu scripts
#

# Program launcher
super + space
    dprogs

# Power menu
super + shift + q
    dpower

# Search
super + s
    dsearch

# Notes
super + n
    dnotes

# NetworkManager menu
super + shift + n
    dwifi

#
# Herbe Scripts
#

# Info
super + shift + space
    hinf

# Volume
super + v
    hvol

#
# Other
#

# Wallpaper setter
super + shift + b
    cwlp

# Launch scrot on whole screen or the focused window
super + {_,shift + }p
    screenshot -{a,f}

# Reload sxhkd configuration
super + shift + r
    pkill -USR1 -x sxhkd

#
# Berry wm specific
#

# close and kill
super + q
    berryc window_close

# Center window
super + c
    berryc window_center

# Make window fullscreen
super + f
    berryc fullscreen

# Snap to left or right
super + shift + {h,l}
    berryc {snap_left,snap_right}

# Focus the node in the given direction
super + {h,j,k,l}
    berryc window_move {-50 0, 0 50, 0 -50, 50 0}

# Rotate focus and raise newly focused window
super + Tab
    bfr

# Focus given workspace, or send focused window to workspace
super + {_,shift + } {0-9}
    berryc {switch_workspace,send_to_workspace} {0-9}

# Pointer focus
~button1
    berryc pointer_focus

# Volume\brightness control keys
XF86AudioMute
    pamixer -t
XF86AudioRaiseVolume
    pamixer -i 2
XF86AudioLowerVolume
    pamixer -d 2
XF86MonBrightnessUp
    xbacklight -inc 10
XF86MonBrightnessDown
    xbacklight -dec 10

Give this a try (this change has since been added to master).
Instead of
super + {_,shift + } {0-9}
    berryc {switch_workspace,send_to_workspace} {0-9}

use
super + {_,shift + } {1-9}
    berryc {switch_workspace,send_to_workspace} {0-8}

My guess is that berry is spawning you on workspace 0, and you have workspace 0 mixed up with workspace 1. When I press super + 1, I'm assuming this is the "first" workspace or the "left-most" workspace (i.e. workspace 0). But in reality you're switching to workspace 1 (that is what your sxhkd says at least). If you just shift the mapping down one you should get the expected behavior.

That was it! I was looking at the examples, idk how I didn't see this


Add option maxBarSpacing for controlling max zoom level

Type of PR: enhancement
PR checklist:

[ ] Addresses an existing issue: fixes #1279 #1312
[ ] Includes tests
[ ] Documentation update

@signatenkov could you also add a coverage test for the new option

v5 #1740


Can types be used to ensure path comparisons are correct?

It seems like we paths floating around in different states of canonicalization.  It might be good to give them different types so that we don't accidentally file comparisons.  For example, a raw path C:\src\a.js is slash-normalized to C:/src/a.js and canonicalized to c:/src/a.js.  None of these are equivalent using string ===, which may not be what the caller intended.

FYI @mhegazy

Closing due to lack of activity


Release diagnostics libraries version 4.3.0-beta05

Changes in Google.Cloud.Diagnostics.AspNetCore version 4.3.0-beta05:
Version 4.3.0-beta04 was not released because of a CI error. This version contains all changes described for the unreleased version 4.3.0-beta04.
Changes in Google.Cloud.Diagnostics.AspNetCore3 version 4.3.0-beta05:
Version 4.3.0-beta04 was not released because of a CI error. This version contains all changes described for the unreleased version 4.3.0-beta04.
Changes in Google.Cloud.Diagnostics.Common version 4.3.0-beta05:
Version 4.3.0-beta04 was not released because of a CI error. This version contains all changes described for the unreleased version 4.3.0-beta04.
Packages in this release:

Release Google.Cloud.Diagnostics.AspNetCore version 4.3.0-beta05
Release Google.Cloud.Diagnostics.AspNetCore3 version 4.3.0-beta05
Release Google.Cloud.Diagnostics.Common version 4.3.0-beta05

Yes, an error in docs. Trying again...


Update latency test for integration in test framework

Calculate median, average and stddev latency
Add writing statistics to file
Modify test system to copy created output file from container to log dir
Add timout to stabilize speed
Use FastGenerator
Remove latency-stub.go as unnecessary (perf_light and others should be
used as part2)
Add more tests to latency.json
Add noscheduler flag

#291

Approved, however you should connect with Gregory about test system changes.

Updated

That update is good, you got everything right, except that there is no report for latency tests. It is necessary to add a new section to HTML report in report.go and a report_test with a latency test type which you can use to debug the html output.
If you think that is too complex for you, you can commit the current change, and I will add the report part later myself.

@gshimansky thanks for tips!

@gshimansky is last commit ok?


HSEARCH-2909 Prevent NPE for annotation w/out package

See HSEARCH-2909

Can one of the admins add this person to the trusted builders? (reply with: "add to whitelist" or "ok to test")

ok to test

Nice, thanks @sbeigel ! @yrodiere let's backport this to 5.8 too?

@sbeigel Thanks!
@Sanne Sure, I'll add a test, merge everything and backport.

@Sanne I thought about adding a test but I don't know how to get an annotation w/out a (loaded) package...

@sbeigel No problem, I'm doing it, it'll be quick :) You only need to create an annotation in the top-level (default) package.

@yrodiere Great, thanks!

Merged and backported to 5.8. Thanks!


Keep track of nick auto completion order on the server

We currently sort it on the client when messages are received, which means the order is lost on page (re)loads.
We will need this to reduce traffic (e.g. #1194), and consistent sorting across devices and page loads.
This probably can be implemented by adding lastMessage timestamp on user object in channel, and updating it when a message is received on the server. Later this timestamp can be used to fix the order on the client.

As a feature, I'm already not a fan of this ordering. It's nice to have the last 2-3 "talking nicks" available when hitting Tab, but it's frankly niche that we have to keep a precise order of everything. I do believe that the new autocomplete dropup helps a lot answering the underlying usability concern, and IMO #1086 will make this even nicer.
That being said, since people do apparently like this feature: as for keeping this on the server, I'd really really avoid doing that. It's a lot of effort and superfluous code for a tiny extension to this feature. There are a ton of edge cases and I really don't want to go there.
Instead, what I think we should be doing is that, on the client, when loading a channel (like when page is reloaded), use the messages to be rendered to order the nick autocompletion values. Yes, this will not be 100% precise like keeping track of them on the server since the beginning of time, but it doesn't have to be. Using the last 100 messages (minus number of joins/parts/etc.) would give enough precision to be indistinguishable for humans 😅.

That being said, since people do apparently like this feature: as for keeping this on the server, I'd really really avoid doing that. It's a lot of effort and superfluous code for a tiny extension to this feature.

This should be accomplished in about 2 lines of code on the server (1 variable definition on user object, and 1 to update it in message event).

Okay so maybe I misunderstood your original issue: with lastMessage, are you trying to only store the most recent message/nick? So if nicks are a, b, c, d, and b is saying something, order will be "b, a, c, d"; after that, if d says something, b gets "forgotten" and order is "d, a, b, c"?

It would store when each user sent their last message.

Just realized this is a dupe of #289


@inbucket is displayed instead of actual domain

Hi! Nice app!

Thanks!  The @inbucket (next the View button is what I'm assuming you are referring to) is intentional.  Inbucket actually accepts mail for any domain, so I didn't want people to think they had to send mail to just the configured smtp greeting domain.
The idea is that if you were testing your application with production data, inbucket would happily accept mail for an @gmail.com user or a @hotmail.com user.
Perhaps I should edit the default homepage (greeting.html) to make all this more clear.

Ok I get it :), but the ui suggest that is for one domain only

there is @inbucket right by search box,
you cant search for<EMAIL_ADDRESS>mailbox is identified only by username, but not domain,
so mail to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>will go to one mailbox 'user'

So i think it would be better to identify mailbox by complete email, and get rid of '@inbucket'  by the 'View' button.

Definitely gonna need more docs on it.  :)  Inbucket completely ignores the domain -<EMAIL_ADDRESS>and<EMAIL_ADDRESS>are both "james" as far Inbucket is concerned, and the mail goes into the same mailbox.
The reason I added the @inbucket UI element was people were confused what to type into the box at all, they thought it was a search feature.

@jhillyerd we went a little off topic, making this '@inbucket' element configurable would be great. :)


SCons: Pass env to modules can_build method

This allows to disable modules based on the environment, in particular env[tools] which tells us if we are building the editor or not.
I've added some try... except logic to SConstruct to preserve compatibility with existing 3.0 modules.

Now that Godot 3.1 has been released, we don't plan to cherry-pick new features and enhancements to the 3.0 branch, unless there is very strong support in favor of it. Removing cherrypick label for 3.0.


Requesting Additional Information for Working With Simulator

I have been attempting to use the VRX simulator as part of my research in optimal trajectory generation. Unfortunately, I am unable to locate any information that can aid in my work. For example, I would love to see how others have localized the robot using either custom code or a ROS package such as robot_localization. In addition to that, I am curious about the vehicle's specs such as the amount of thrust the thrusters can provide, what the maximum thrust value is, and the noise characteristics of the GPS and IMU. Any pointers, code, or other resources would be very much appreciated.
Thank you for your time!

Hi, thanks for using VRX! If you are just getting started, a good place to begin is the Wiki: https://github.com/osrf/vrx/wiki

Thanks for your quick reply! I have taken a look at the wiki and I probably overlooked something. Is there any material with regards to localization (I am personally interested in GPS/IMU sensor fusion, but SLAM information could be interesting as well)?
I will go ahead and make a specific request for a tutorial if I am unable to find what I am looking for. Depending on how my work goes, I may even create a PR to include the steps I took.
Thanks again!

@magicbycalvin if you are still looking for an example of using robot_localization, you can check out Georgia Tech's localization. We use GPS and IMU for localization, and it has been tested in VRX.


<EMAIL_ADDRESS>decompress error

Related to issues #1556 and #1555
> scoop install versions/spark-scala2.13
WARN  Purging previous failed installation of spark-scala2.13.
ERROR 'spark-scala2.13' isn't installed correctly.
'spark-scala2.13' was uninstalled.
Installing 'spark-scala2.13' (3.5.0) [64bit] from versions bucket
Loading spark-3.5.0-bin-hadoop3-scala2.13.tgz from cache
Checking hash of spark-3.5.0-bin-hadoop3-scala2.13.tgz ... ok.
Extracting spark-3.5.0-bin-hadoop3-scala2.13.tgz ... ERROR Exit code was 2!
Failed to extract files from C:\Develop\02_tools\Scoop\apps\spark-scala2.13\3.5.0\spark-3.5.0-bin-hadoop3-scala2.13.tgz.
Log file:
  C:\Develop\02_tools\Scoop\apps\spark-scala2.13\3.5.0\7zip.log

I'm already working on this issue and I'm gonna submit a PR soon.


StructuredDataView has lingering members

_members in StructureDataView is a class level variable that is instantiated with an OrderedDict. When one tries to use StructuredDataView with a different type _members is never re-instantiated and the dictionary ends up with stale values. Moving _members to the __init__.
>>> var_type, _ = bv.parse_type_string("""struct {
...     uint32_t *blah;
...     uint32_t *blah1;
...     uint32_t *blah2;
...     uint32_t *blah3;
... } Apple""")
>>> bv.define_user_type('Apple', var_type)
>>> x = StructuredDataView(bv, 'Apple', here)
>>> print(x)
struct Apple 0x140018b90 {
	    +0 uint32_t* blah                           =<PHONE_NUMBER>000001
	    +8 uint32_t* blah1                          = 0001f48800000000
	   +10 uint32_t* blah2                          = 00018b9000018ee0
	   +18 uint32_t* blah3                          =<PHONE_NUMBER>000000
}
>>> StructuredDataView._members
OrderedDict([('blah', <uint32_t* blah, offset 0x0>), ('blah1', <uint32_t* blah1, offset 0x8>), ('blah2', <uint32_t* blah2, offset 0x10>), ('blah3', <uint32_t* blah3, offset 0x18>)])

Thanks, looks good.


kubernetes environment initialize error

my host OS is centos 7-1511,docker 1.11,after I create a kubernnetes environment ,I try to add a host to it, host type is custom,public ip is specified,then I use the command below to start the agent,and here comes the problem:the kubernetes stack can not be fully start.kubelet container keep run into error state with msg:'time="2016-04-28T05:29:16Z" level=fatal msg="Failed to find state.json"' while the other container are all started as normal,any leads?

Useful
Info

Versions
Rancher v1.0.1 Cattle: v0.159.7 UI: v1.0.5

Access
Disabled

Route
authenticated.project.help

I run into the same issue today. How did you solve it?

@logicigam I am running into the same issue.

@bnusunny @usmanismail what OS is your host? Also Rancher and docker version?

https://github.com/rancher/rancher/issues/5290

OS is AWS Standard AMI
Docker version 1.11.2, build b9f10c9/1.11.2
Rancher v1.1.2

I run into the same issue today...
Trying to install Kubernetes in Rancher environment.
The image "r-Kubernetes_kubelet_1" doesn't start.
Setting up Kubernetes

Add at least one host
Waiting for a host to be active
Creating Kubernetes system stack
Starting services (7 of 9) (loop...)

The kubelet container logs show this info:
Archive:  certs.zip
inflating: ca.pem
inflating: cert.pem
inflating: key.pem
time="2016-08-17T18:20:34Z" level=fatal msg="Failed to find state.json"

Down grading the docker version on the machines running rancher-agents to docker 1.9 fixed the issue for me.


Remove "lts" / "latest" definitions in favor of version, add eslint to TS definitions

There have been a few cases where an update to a "latest" or "lts" tag has broken a definition.  Instead of using these tags, we can keep dev containers for current versions of runtimes and deprecate those that are no longer in support.
This change will also be required to implement #140.
We will need to adjust comments that are added to devcontainer.json files to that points to the README in the release tag tree instead of master so that people can still get to READMEs for deprecated containers.
This update also adds eslint to the TypeScript definitions now that tslint has been deprecated.

Makes sense. 👍


Fixed notebooks (and updated symlinks)

Picking off work on #411: fixed symlinks in the docs directory (don't have write access to pyfolio, so this is on a branch). This is a merge into a branch; the branch itself will need to be merged to master.
cc @twiecki

Thanks @eigenfoo!

@twiecki you only merged the PR to the fix_nbs branch of pyfolio, not to master

Oh, weird.

https://github.com/quantopian/pyfolio/pull/424


Create temporary release environments

Looks Good otherwise. My comment on the PR is not a blocking one, but a nice to adhere