occasionally getting "authenticity of host 'github.com...' can't be established prompt

Report
What did you do?
I currently have a Buildkite build that performs Danger tasks. One of the Buildkite steps run this command
bundle exec danger --dangerfile=build-configuration/danger/DangerfileReportDiffuse --danger_id=${DANGER_PREFIX}_diffuse
What did you expect to happen?
Expect the build to swiftly perform the tasks with no user prompts or failures.
What happened instead?
A user prompt of such pops up instead and causes the build to hang
The authenticity of host 'github.com (<IP_ADDRESS>)' can't be established.
--
  | RSA key fingerprint is SHA256:nThbg6kXUpJWGl7E1IGOCspRomTxdCARLviKw6E5SY8.
  | Are you sure you want to continue connecting (yes/no)?

which eventually leads to the build to time out after being stuck here.
The weird thing is after a few retries, the build would actually work and and the prompt wouldn't show up anymore. If something is wrong with the git ssh connection, I would expect it to fail consistently but this only happens sometime.
Your Environment
The build is performed in Docker container running on the image cimg/android:2021.10.2

Which CI are you running on?
Buildkite
Are you running the latest version of Danger?
unsure - will update it here when I find out
What is your Dangerfile?

diffuseFile = File.open("diffuse_report", "r+").read
dependencyTreeDiffFile = File.open("dependency_tree_diff_report", "r+")
textToReport = diffuseFile.split("=================")

markdown "```diff"

if File.size(dependencyTreeDiffFile) > 0
  markdown "Dependency Tree Diff"
  markdown dependencyTreeDiffFile.read
  markdown ""
end

markdown "Apk Diffuse"
markdown textToReport[0]
markdown "```"

The git pull under the hood is literally a git pull I believe, perhaps there's a git flag you can add to force accepting something like this?

Hmm what confounds me is the part where the first couple times would show that prompt but then eventually with enough retries we would get past that prompt. This doesn't happen all the time but occasionally so I am wondering if there is some underlying implementation of the way danger system performs git ssh connections that I need to be aware of?

Nope, nothing special, it's just using git commands based on the remotes your CI set up

Perhaps something is off with the environment/image the builds are running in. Will investigate further. Closing issue. Thank you.


Rewrite DataTable test due to scalafmt error (close #100)

The sbt test was failing on compilation with Search state exploded around line ..., which is probably due to scalafmt formatting the code. We don't like the DataTable approach, so I took this opportunity to fix this place.

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   88.88%   88.88%
=======================================
  Files           3        3
  Lines          90       90
  Branches        2        2
=======================================
  Hits           80       80
  Misses         10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3c5457...04355a8. Read the comment docs.


Use full name of config as value of 'Name' key in metafile

This is modified to make mim worked correctly.


PowerRename context menu position

Much like issue #1110 for image resizer, we should have PowerRename below rename in context menus.

AFIAK, this is not possible, the area in read is off-limits for third party applications

@chrdavis
can you confirm if my previous comment is correct?
Thanks.


Android Tool starts blank.

I'm not sure what's happening. I uninstalled and re-installed multiple times. Removed references from Library also.
I even tried re-installing using brew cask. Same issue.

Me too

Me too. I've re-installed and have the same issue.

I solved this by unplugging the connected device and then opening AndroidTool.

https://github.com/mortenjust/androidtool-mac/pull/142 resolves this


How to disable swipe dismiss

i set the
SideMenuManager.menuEnableSwipeGestures = false
but it's not working

You can use this property:
Not sure about your scenario, but in my case when user logs out and reach on login screen i wanted to disable gesture from left to right.
At th etime user clicks on logout i set below property to 0.0 and that's it.
SideMenuManager.default.menuWidth = 0.0
Now again reset it to 85% after user re-login.


Question: Atomic transfers

Greetings,
I'd like to ask if cosmosjs supports: Atomic transfers
I've experience with Algorand. Algorand supports Atomic transfers

Documentation:
https://developer.algorand.org/docs/get-details/atomic_transfers/
SDK method:
https://developer.algorand.org/docs/get-details/atomic_transfers/
I'd like to receive more details about this subject.

This is possible in Cosmos SDK using so called messages. Each message is an instruction for an action. A basic example is MsgSend for sending tokens. You can have 3 of those in a transaction that is then signed by 3 signers where each signer is the sender of some coins.
This was implemented before the Stargate upgrade in CosmJS. We currently don't have an implementation for that due to the lack of interest from users.

@webmaster128: nice to meet you!
Thank you very much for the answer! Your answer gave me insperation to try a new approach and the final result is: https://cosmoshub-testnet.mintscan.io/cosmoshub-testnet/txs/4BC832DA2C364FEF8A75C6D94002588A428BD7F26253FA601BF08E737F0B4BF0
What's the benefit if we group the transactions ?

The transaction looks good. That's the Cosmos way to do this: one transaction with multiple messages.
Now as long as all 3 message have the same "From Address", only this account has to sign the transaction. If you have different Froms, all need to sign the transaction.

What's the benefit if we group the transactions ?

Could you elaborate what you mean by that?

Greetings,

If you have different Froms, all need to sign the transaction.
I've a question: How to sign the transaction for each different address ?

What's the benefit if we group the transactions ?
What's is the difference if we make three different transactions or one transaaction like: https://cosmoshub-testnet.mintscan.io/cosmoshub-testnet/txs/4BC832DA2C364FEF8A75C6D94002588A428BD7F26253FA601BF08E737F0B4BF0

The benefit is generally a UX improvement, applications might want to perform multiple actions and only have the wallet owner sign one transaction instead of multiple ones.
The atomic transaction you have listed above isn't supported in CosmJS at the moment because currently there aren't clearly defined uses cases that require us to prioritize this feature.

Is there anything else we can do here? Seems like good to close if you don't have follow-up questions or want to convince us that atomic transactions with multiple signers are needed.


Crossbow

the crossbows in 1.10 sky factory 3 only level on melee hit and not on actual shots of the crossbow

#19


Ability to specify WHICH size of instances to flex down.

It would be helpful to be able to specify to scale down X instances of Y size rather then just X instances.  For example if I had a small cluster of different sized nodes, and could run 1 Large, 2 medium, and 2 small instances. I may want to scale down only my two small instances, rather then just 2 instances.  Similar to flexup, where you specify the size.

+1 - much needed ability.
Santosh
On Tue, Apr 7, 2015 at 11:33 AM, WalterDalton<EMAIL_ADDRESS>wrote:

It would be helpful to be able to specify to scale down X instances of Y
size rather then just X instances. For example if I had a small cluster of
different sized nodes, and could run 1 Large, 2 medium, and 2 small
instances. I may want to scale down only my two small instances, rather
then just 2 instances. Similar to flexup, where you specify the size.
—
Reply to this email directly or view it on GitHub
https://github.com/mesos/myriad/issues/89.

I'll start in on this. I'll post something to the email list to discuss what the API should be.


Update Stable to v2.23.0 on dev

Description

v2.23.0 was released on 11/26/2020
update stable on dev

Issues:
https://github.com/vulk/cncf_ci/issues/71
How has this been tested:

[ ]  Covered by existing integration testing
[ ]  Added integration testing to cover
[ ]  Tested with trigger client against

[ ]  cidev.cncf.ci
[ ]  dev.cncf.ci
[ ]  staging.cncf.ci
[ ]  cncf.ci (production)

[ ]  Browser tested on staging.cncf.ci
[x]  Have not tested

Types of changes:

[ ]  Bug fix (non-breaking change which fixes an issue)
[ ]  New feature (non-breaking change which adds functionality)
[ ]  Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Version update

Checklist:

[ ]  My change requires a change to the documentation
[ ]  I have updated the documentation accordingly
[x]  No updates required

Passed manual pipeline build: https://gitlab.dev.cncf.ci/prometheus/prometheus/pipelines/50623


Public game

Issues
Add reconnection feature for disconnected players. Add public game feature.
Proposed Changes

Added reconnection feature.
Appropriately handles joining in and leaving from a game. Destroy the game if there are no active players.
Fixed problem that selected neutral cards display incorrect color.
Changed gradient color of cards to make it more visible.

Looks good to me! As Sina said in the standup it could probably use some better styling but it's not top priority.
While I was clicking around frantically during testing a game, I did end up crashing something with this error:
    const activePlayers = gameController.globalState[gameID].activePlayers
                                                             ^

TypeError: Cannot read property 'activePlayers' of undefined     at Socket.socket.on (. . .\server\socket\socket.js:17:66)
Might have to keep an eye out when we do some more testing later.


Add support for AMDGCN bitcode (.bc) files.

This PR implements support for linking to AMDGCN bitcode files.
Some unit tests will link directly to this to use the contained math functions.
There is however another item that this PR does not cover: namely specifying the AMDGCN math counterparts in:
https://github.com/ROCmSoftwarePlatform/triton/blob/triton-mlir-phase-2/python/triton/language/libdevice.py
Other unit tests use the functionality in this file and this will be updated to include AMDGCN support in a forthcoming PR.

Please supply a description to the PR to summarize what's realized in this PR, and what's known to be realized moving forward.

Done.


[Windows][A11y] Screen Reader not announcing the state of Switch

Minimal repro:
Scaffold(
  appBar: AppBar(
    // Here we take the value from the MyHomePage object that was created by
    // the App.build method, and use it to set our appbar title.
    // We also apply a custom font, ProductSans.
    title: Text(widget.title, style: TextStyle(fontFamily: 'ProductSans')),
  ),
  body: Column(
    children: [
      Switch(
        value: value,
        onChanged: onChanged,
      ),
    ],
  ),
);

Run NVDA or any other screen reader on the windows machine.
Press tab to move the focus to Switch
Actual: Reading as button and not tell the state of the switch
Expected : Should tell the state of the switch.

@yaakovschectman and @loic-sharma may have some leads on this.

The Switch has semantics marking its role as a push button. Which role listed on https://docs.microsoft.com/en-us/windows/win32/winauto/user-interface-element-reference do we actually want switches to have? I do not think there is a dedicated role for switches like this, and I also do not think push buttons are supposed to have a toggleable state like our switches do. Functionally, they seem similar to checkboxes, even though they are different visually.

Using the same role as a checkbox seems reasonable, the Material design guidelines describe switches as a checkbox for mobile & tablets:

Use switches to turn an item on or off, especially on mobile instead of a checkbox.

Agreed checkbox seems like the right semantics. On the web these are treated as having similar behaviour to checkboxes but with on/off status rather than checked/unchecked.  It seems reasonable to implement this as having checkbox semantics and then, if we need to fine-tune later, we can look at what chrome does for the switch role if necessary.

Closing for flutter/engine#36177


why3 prove ... Library file not found: archetype

Hi,
I try to launch why3 prover against generated mlw.
why3 complains as he doesn't find archtype library
why3 prove erc20.mlw
File "erc20.mlw", line 2, characters 2-19:
Library file not found: archetype

I guess it is related to passing the right --library value.
Can you point me in the right direction ?

Hi,
the archetype.mlw lib is in the mlw/ directory of archetype, hence you should use the why3 -L option to point to this dir; for example assuming you run the command from the archetype dir, it should be something like
why3 prove -L ./mlw erc20.mlw

Thanks !
as it might help someone,  using opam installation, mlw directory is located at  $HOME/.opam/ocaml_version/share/archetype/mlw/


Setup SSR

Set up Server Side Rendering within Laravel/Inertia/Vite

The initial SSR setup breaks on the server because of a few things:

[ ] Server requires node

Installed via nvm, need to add additional information to the server provisioning documentation
Also need to add service file to server provisioning documentation

[ ]node_modules not available

will need to remove exclude from the deploy-application workflow that doesn't give node_modules

[ ] Ziggy helper blade directive is never loaded and route is undefined (not on window, there is no window)

Adjust app.js and ssr.js to include ziggy routes on compile time
Figure out how to pass route method globally with the ziggy routes wrapped in on hook

WIP commit is currently on branch 17-SSR with the first two problems resolved. Ziggy routes and route method issue still remains.


Django 1.7 is insecure out of the box, make sure you use a VM for your safety

Hey all,
If you are working through this technical test please be aware that starting the app and exposing your system to the internet via something like ngrok could lead to a security breach of your machine.
The easiest way forward is to use Vagrant or just do your developing in a VM. A better fix would be to upgrade to the latest version of Django with security patches installed.
Just a heads up, good luck with the test!
Edit: on closer inspection the worst you should be looking at is a DoS but it's still better to be safe than sorry, more info: https://www.cvedetails.com/vulnerability-list/vendor_id-10199/product_id-18211/version_id-179005/Djangoproject-Django-1.7.1.html

Test baseline has been update to 1.8.


Fix flake.nix definition to work with more recent nixpkgs snapshots

Hello, thanks for all your work on Monomer. It has been fun to read this project.
I modified the flake.nix definition so it is easier to work on a recent nixpkgs snapshot.
Changes

The virtualisation options don't go by that name anymore. I commented those lines so nix flake show would work. I was not able to make it work.
Added a devShell section, so running the haskell language server is easier.
I removed a superflous GLEW dependency on nanovg.
Updated the flake.lock file.

Tests
I am using this on my local environment. So far I can run cabal v2-build and use the language server with emacs.

@RubenAstudillo thanks for the updates!


DB Sync snapshots not getting updated anymore

Hi,
the latest snapshot in https://update-cardano-mainnet.iohk.io/cardano-db-sync/index.html#13/ is https://update-cardano-mainnet.iohk.io/cardano-db-sync/13/db-sync-snapshot-schema-13-block-7981218-x86_64.tgz and listed as "2 days" ago.
But block 7981218 was already minted 12 days ago on 2022/11/06 21:44:46 UTC https://explorer.cardano.org/de/block?id=9d755bf51c6e618439fcfd749656490a1ddb25950fc0ee38b37c08de0b103bb0
I just setup a new db sync server with this snapshot and it is really 12 days behind, instead of just 2 days.
Please fix the upload of current snapshots.

@jbgi Can you please look into that ?

Any news on this? The newest db-sync snapshot is still https://update-cardano-mainnet.iohk.io/cardano-db-sync/13/db-sync-snapshot-schema-13-block-7981218-x86_64.tgz which is now 22 days old. That's 5 epochs already.

I think the problem is fixed. Should we close this?

This lookgs fixed


[macOS Sonoma] ObrStack not linking to existing tooling on machine.

Describe the bug
I had Docker Desktop installed as well as kubectl but OrbStack isn't linking to the existing tooling.  It's creating links to its tooling.
To Reproduce

Install OrbStack
creates links in both ~/bin and ~/.orbstack/bin directories.

Expected behavior
I would expect that OrbStack would link to the existing tooling.  For example,

docker
docker-deskyop
docker-credential-osxkeychain
kubectl

Diagnostic report (REQUIRED)
orbstack-diagreport_2024-06-21T19-45-30.649415Z.zip
Screenshots and additional context (optional)
~/.orbstack/bin:

~/bin

This is intended behavior because people often switch from Docker Desktop and leave the app behind (with no updates) for a long time, eventually resulting in hard-to-debug problems due to version drift.
OrbStack won't replace existing tools if they were installed with Homebrew or other package managers.


automate-backend-deployment movement to automate repo

Description
A2ha- terraform code (inside automate)
Remaining folders as well:
Docs, tests, inspec, certs, script (into respective automate folder)
Then based on relative paths, update and move below component:
automate-backend-deployment


Debugger Refactor #2: DebbugerArgs

Second and last part of https://github.com/foundry-rs/foundry/pull/5547 (sorry, cannot do smoller)
Adding the new DebuggerArgs struct that all part of the code should comply with,
Removing the run_debugger function that is ran from forge script
Simpler way of mapping contract sources, see ui::debugger::ContractSources type

yep doing that now sorry sir

did a self review, looks good to me @Evalir
there are less changes than it seems in the diff, git is not smart enough to show the correct diffs for lib.rs and make it look like there are many.

Since we're refactoring this to make it better, I'm being extra nitpicky here

This is good

Friendly ping @Evalir

No it's all G, thanks for the thorough review !


[AMBARI-22937] Deactivate unsupported stack definitions in Ambari

What changes were proposed in this pull request?
Deactivate unsupported stack definitions in Ambari. This includes HDP versions before 2.6.
Active Stacks
./3.0/metainfo.xml:    <active>true</active>
./2.6/metainfo.xml:    <active>true</active>
./2.5/metainfo.xml:    <active>true</active>
./2.4/metainfo.xml:    <active>true</active>
./2.3/metainfo.xml:    <active>true</active>

There is no enforcement of minimum stack level during the upgrade process. The user is expected to have performed the necessary actions to meet the documented minimum stack level.
NOTE: .../ambari-server/src/main/resources/stacks/HDP/2.3/metainfo.xml was already disabled.
How was this patch tested?
Manually viewed unsupported stacks were not presented in the UI.
Please review Ambari Contributing Guide before opening a pull request.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/830/
Test FAILed.
Test FAILured.

@dlysnichenko ,  HDP 2.3 has already been disabled in trunk.  See https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.3/metainfo.xml#L20
<metainfo>
    <versions>
	  <active>false</active>
    </versions>
    <extends>2.2</extends>
    <minJdk>1.7</minJdk>
    <maxJdk>1.8</maxJdk>
</metainfo>

please retest this

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/849/
Test FAILed.
Test FAILured.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/886/
Test FAILed.
Test FAILured.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/906/
Test FAILed.
Test FAILured.

Unit failures are unrelated:
[ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 29.068 s <<< FAILURE! - in org.apache.ambari.server.state.stack.ConfigUpgradeValidityTest
[ERROR] testConfigurationDefinitionsExist(org.apache.ambari.server.state.stack.ConfigUpgradeValidityTest)  Time elapsed: 25.427 s  <<< FAILURE!
junit.framework.AssertionFailedError
	at org.apache.ambari.server.state.stack.ConfigUpgradeValidityTest.testConfigurationDefinitionsExist(ConfigUpgradeValidityTest.java:221)

Ugh.. unit test failures were related... my apologies. See #529


Address missed changes from earlier PR for watsonx data module.

Mentioned below are some of the findings , which were overlooked in earlier PR :
(a) Minor Adjustments

Description in settings.yaml file is not updated
Check grammar of the description here and here
Can be consistent like - [Learn More](url here) - Check here
Can make use of either watsonx data or watsonx.data but should be consistent - here (Mostly seen as watsonx.data)
Do we really need region here as this is about an existing instance which is already provisioned in a region? If not, the region variable too can be removed. I am not using in my existing example.

(b) Options/Cases not present in the code :

If the enterprise plan is selected, the option to include KMS key is also reflected in UI -

If the lite plan is selected, option to choose use case is shown to the user -

Also consider the following -
The existing resource test should actually explicitly check for the outputs to ensure they are getting returned with values. Approach can be like this.

Can we also add support to output the account ID (same way we did in https://github.com/terraform-ibm-modules/terraform-ibm-watsonx-assistant/pull/5)


Can't run project with env dev

💬 Question
when I run start:dev command I get a lot of these errors

transform[stderr]: Could not resolve "/Projects/open-sources/react-native-ui-kitten/src/components" in file Projects/open-sources/kittenTricks/src/app/app.component.tsx.

I have react-native-ui-kitten, eva and kittenTricks in a same directory. I did everything said inside dev_docs, but I can't run in dev mode, prod mode is fine.
Am I missing something??
UI Kitten and Eva version

Package
Version

@eva-design/eva

@ui-kitten/components

👋
The code used to configure paths to both Eva and UI Kitten modules is here. Please make sure you have exact that structure of directories or modify env.dev.js with paths to the local modules.
Also, using Yarn is important.


API feature request: allow to specify focused item/index in window.showQuickPick

vscode.window.showQuickPick
By default, it focuses on the first item. Is there any plan to allow to pre-focus on a certain item. E.g.
window.showQuickPick( original params ... , focused_index?: number)

There is scenario that we don't want to change the order of the items, but do want to pre-focus on a certain item, so most of time users can directly hit  to continue.
e.g.
In following scenario, we let users to select a version number of some libs, listed by the order of releasing date. And we want to focus on the latest stable version.
---------------------
choose the version
---------------------
2.1.0-beta
2.0.0-beta
1.5.3    <------------
1.4.8
1.3.9

https://github.com/Microsoft/vscode-java-debug/issues/275

See #11483 and #27352.


BGE: Grid FLS check

Critical Changes
Changes

If a user does not have FLS permissions (view, create, edit) on all Data Import and target fields in a BGE Batch, all batch information is hidden and an error message appears.

Issues Closed
New Metadata
Deleted Metadata

**lurch: attach W-030162

Tracking W-030162


BG-19296 Enable lint test for KRSv2

JIRA Ticket
https://bitgoinc.atlassian.net/browse/BG-19296
Change Description
@cooncesean, @tylerlevine, and @marktoda, as a follow-up to our past conversations, I have enabled lint test as part of the CI pipeline. Unfortunately, there are errors and warnings from the test based on the current .eslintrc.json. What would you like to do as far as fixing the lint errors / warnings? Do you someone to do so?
Tests
Please refer to the lint test errors and warnings here.
https://drone.bitgo-dev.com/BitGo/key-recovery-service-v2/26/1/4

Cool, this is a good step, now just need to get the unit tests working and we should have a green build. Thanks for working on this @james8nguyen and @marktoda

Thank you, @tylerlevine and @marktoda.
Regarding the failing unit tests, who can fix them or should I disable unit tests temporarily?

Hey @tylerlevine mind rereviewing? I decided to finish the job so this doesn't sit and rot any longer

broken tests were mostly just unyielded functions

Replaced by https://github.com/BitGo/key-recovery-service-v2/pull/73


Unable to connect to my ESC/POS Printer through USB

The hostname has been hardcoded in the example where we require to know the IP address in advance, is there not a way to discover Existing printers and then connect with the device to execute the print commands?
Also is there not a method to detect ESC/POS printers with USB/Bluetooth?

Hi,
To discover existing printers in your subnet you can use ping_discover_network package. It's under active development and will be improved.
Note that most of ESC/POS printers by default listen on port 9100.
I will add USB/Bluetooth support a later but it's not my priority right now. Feel free to make a pull request if you wish to develop it ;)
Hope it helps!


Update to use extension-websocket

The use of Defold's new websocket extension will reduce the executable size a lot, as well as improve the speed of the socket communications.
https://github.com/defold/extension-websocket

@JCash It would be great to switch over to the native socket especially as I see it has support for TCP QUICK ACK. I handled realized it was officially released yet. I'll work with @britzl to see how best to integrate it.

Hi @novabyte!
Although we haven't technically announced the official release of the new extension, I thought I should add it as a ticket here, so that someone (possibly @britzl) can make the update, and possibly report any issues detected.
There is currently no outstanding issues reported by the beta testers
We will announce it as "released" (we're already on version 1.4) when we release Defold 1.2.175.
As for support for TCP_QUICKACK, we do have an issue to add support for it in the extension:
https://github.com/defold/extension-websocket/issues/3
Our problem here is that there seem to be no clear, documented way on how to use it, and it's not supported on macOS/Windows. We'd be happy to receive advice on how to add the functionality.
We've already added dmSocket::SetQuickAck(bool) to our Defold SDK, so the only thing remaining is the changes in the extension.

Yes, I have it on my list of things to do already! I think I'll start looking into this next week.

I think I'll start looking into this next week.

 Doing it now!

I think I'll start looking into this next week.

 Doing it now!

First version here: https://github.com/heroiclabs/nakama-defold/tree/dev-use-websocket-extension
Works with the example in this repo and a basic server setup.

First version here: https://github.com/heroiclabs/nakama-defold/tree/dev-use-websocket-extension
Works with the example in this repo and a basic server setup.

That was very fast @britzl ! Thanks 🙏 I can take a look at a pull request.

That was very fast @britzl ! Thanks 🙏 I can take a look at a pull request.

@novabyte PR is ready

@novabyte PR is ready


fix fix wrong disk usage of spill

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run performance

run buildall

run performance


change id type to string failed

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
type IDMixin struct {
	mixin.Schema
}

func (IDMixin) Fields() []ent.Field {
	return []ent.Field{
		field.String("id").DefaultFunc(func() string {
			return stdx.Must(ulids.New()).String()
		}).Unique().Immutable().Annotations(
			&entsql.Annotation{
				Default: "public.generate_ulid()",
			},
		),
	}
}

migration failed with
ERROR: invalid input syntax for type bigint: "public.generate_ulid()"

the executed sql
ERROR:  invalid input syntax for type bigint: "public.generate_ulid()" at character 55
STATEMENT:  SELECT nextval('service_accounts_id_seq'::regclass) = 'public.generate_ulid()'

the column become bigint

Expected Behavior 🤔

Steps to Reproduce 🕹

Your Environment 🌎

Tech
Version

Go
1.18.?

Ent
latest - v0.10.2-0.20220620053230-311d76067960

Database
postgres

Driver
pgx

Hey @wenerme and great to see you here again 👋
Can you elaborate on what do you mean by "changing the id type"? What was the id type (SQL type) before the migration? Also, how do you run the migration, do you use the WithAtlas option or the old migration engine? Thanks

Hi @a8m the migration is
err = client.Schema.Create(ctx,
		schema.WithAtlas(true),
		schema.WithDir(dir),
		schema.WithSumFile(),
	)

the migrations only contain a generate_ulid function.
"change id type to string" I mean with the with the IDMixin, I can make a repro tomorrow.

sorry, my mistake, the gorm code is not cleaned up.


FOMA replacements

https://fomafst.github.io
How much needs to be done to support FOMA features?

I briefly looked at the foma below, and I think it can be divided into two parts:

Interactive part (REPL), using typed-fsm is good.
converting regular expressions to finite automata, this seems to be a purely algorithmic problem. I'm not sure if I should use typed-fsm.


React app renders wihtin a width of a page

What
React app now renders within the full width of the page.
How to review
Run it locally from within the stack on http://localhost:2000
Who can review
Anyone by me. @Crispioso @jondewijones

It will be done from a separate commit.


fix: resizing selection band

:tada: This PR is included in version 1.1.0-alpha.62 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


PR Fix/hover dict

Description of Changes

[ ] Wrote at least one-line docstrings (for any new functions)
[ ] Added unit test(s) covering the changes (if testable)

[ ] Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

Hello @goanpeca! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/widgets/mixins.py:

Line 341:32: E203 whitespace before ':'
Line 371:50: E128 continuation line under-indented for visual indent
Line 377:1: W293 blank line contains whitespace

@ccordoba12 could you check if you find any other issues?

could you check if you find any other issues?

I think it's time to add some tests for hovers. Perhaps by calling request_hover of CodeEditor, then waiting for sig_display_signature to be emitted and passing its arg to show_tooltip?

I think it's time to add some tests for hovers. Perhaps by calling request_hover of CodeEditor, then waiting for sig_display_signature to be emitted and passing its arg to show_tooltip

Sure, I will try to add checks for these methods

@goanpeca, let's leave tests for later. I have one important remark though: the hover and tooltip for dict is too wide. Could you wrap its text with textwrap so all hovers/calltips have the same width?

Yes, I noticed I will make the changes

Great, thanks!

Fixed issues and added tests @ccordoba12 (I marked them as slow and second, but they are actually not that slow)

I noticed the calltip test is currently being performed on the main window, so maybe we could remove that one (when these ones are more complete, as they will run faster on the code editor fixture alone)

Trying to run these tests on my Kubuntu vm is yielding:

Yeiii checks passed. So mouse move events are too flaky on CI. They worked locally though 🤷🏻♂

@goanpeca, sorry for the multiple comments, I forgot to start this as a proper review.

@goanpeca, sorry for the multiple comments, I forgot to start this as a proper review.

No problem. Will make the fixes now 👍


Adding common sign_blob() service account types.

Also adding service_account_email() property.
See https://github.com/GoogleCloudPlatform/gcloud-python/issues/922 for some details on why sign_blob won't work on GCE.
I'm a bit worried about service_account_id on the GAE credentials class. In the implementation it seems to be almost synonymous with the svc. account email / name, but not quite (i.e. there may be some legacy behavior). ISTM the reason it's in the constructor is so that it could be passed to app_identity. Anyhow, our service_account_name could either shadow or conflict with service_account_id if a user passed one in. Though I don't imagine anyone in the history of this library has passed in a value for service_account_id.
Context: We use these utilities in a haphazard way in gcloud-python when creating a signed URL (for cloud storage objects). This just puts the auth utils in the auth library in a unified way.
/cc @tseaver @jgeewax @jonparrott

@nathanielmanistaatgoogle Removed the abstract service_account_email property. What remains to be reviewed?

(Completed a full review pass.)

Looks good except for the copied-and-pasted doc strings.

@nathanielmanistaatgoogle See the 4th commit for the "implements" note.

All looks great; squash and merge. Thanks for the conversation.

:+1: Will wait to merge until Travis is done in 10 hours.


Rework for updated "connected to blockchain" status

Relates to https://github.com/NebraLtd/hm-diag/issues/74
See the last 3 commits in https://github.com/NebraLtd/hm-config/tree/fix_handler_typeerror for a (quick and dirty) fix

Before fix shows no inbound connections, blockchain sync NaN, NAT type of "yes"...

After fix it shows the correct data...


fprintd fails to start if /var/lib/fprint doesn't exist

Issue description
● fprintd.service - Fingerprint Authentication Daemon
   Loaded: loaded (/nix/store/ypvxva9bkk8b4g09r0jilzjkqd292yw2-fprintd-thinkpad-0.8.1/lib/systemd/system/fprintd.service; linked; vendor preset: enabled)
   Active: failed (Result: exit-code) since Sun 2019-05-26 13:29:11 BST; 7s ago
     Docs: man:fprintd(1)
  Process: 20686 ExecStart=/nix/store/ypvxva9bkk8b4g09r0jilzjkqd292yw2-fprintd-thinkpad-0.8.1/libexec/fprintd (code=exited, status=226/NAMESPACE)
 Main PID: 20686 (code=exited, status=226/NAMESPACE)

May 26 13:29:11 clipper systemd[1]: Starting Fingerprint Authentication Daemon...
May 26 13:29:11 clipper systemd[20686]: fprintd.service: Failed to set up mount namespacing: No such file or directory
May 26 13:29:11 clipper systemd[20686]: fprintd.service: Failed at step NAMESPACE spawning /nix/store/ypvxva9bkk8b4g09r0jilzjkqd292yw2-fprintd-thinkpad-0.8.1/libexec/fprintd: No such file or directory
May 26 13:29:11 clipper systemd[1]: fprintd.service: Main process exited, code=exited, status=226/NAMESPACE
May 26 13:29:11 clipper systemd[1]: fprintd.service: Failed with result 'exit-code'.
May 26 13:29:11 clipper systemd[1]: Failed to start Fingerprint Authentication Daemon.

Creating /var/lib/fprint fixes this.
Steps to reproduce
Remove /var/lib/fprint and restart fprintd.
Technical details

system: "x86_64-linux"
host os: Linux 4.19.45, NixOS, 19.09pre180814.28b4f7b6ace (Loris)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.2.2
channels(michael): ""
channels(root): "nixos-19.09pre180814.28b4f7b6ace, nixos-hardware"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maybe we need to add something to the systemd service to ensure this is created?

See https://gitlab.freedesktop.org/libfprint/fprintd/merge_requests/5


Fix clean subcommand

The find -depth option is a boolean, and as such accepts no arguments.
-maxdepth is probably what was wanted here.

Thank you for your pull-req!
Well...if your change merge, it must be as follows:
diff --git a/zplug b/zplug
index a65e20e..3a8d2ef 100644
--- a/zplug
+++ b/zplug
@@ -1334,7 +1334,7 @@ __zplug::clean()

     else
         # directory structure level 2
-        repos=("${(@f)$(find "$ZPLUG_HOME/repos" -maxdepth 2)}")
+        repos=("${(@f)$(find "$ZPLUG_HOME/repos" -maxdepth 2 -mindepth 2)}")

         # Remove the repository which is used from the candidates
         for v in "${(@v)plugs}"

This is because of removing the shallow directory.
e.g.,)

-maxdepth 2

/Users/b4b4r07/.zplug/repos
/Users/b4b4r07/.zplug/repos/b4b4r07
/Users/b4b4r07/.zplug/repos/b4b4r07/emoji-cli
/Users/b4b4r07/.zplug/repos/b4b4r07/enhancd
/Users/b4b4r07/.zplug/repos/b4b4r07/fe1c8d370f26393c0f75
/Users/b4b4r07/.zplug/repos/b4b4r07/http_code

- `-maxdepth 2 -mindepth 2`

    ```
/Users/b4b4r07/.zplug/repos/b4b4r07/emoji-cli
/Users/b4b4r07/.zplug/repos/b4b4r07/enhancd
/Users/b4b4r07/.zplug/repos/b4b4r07/fe1c8d370f26393c0f75
/Users/b4b4r07/.zplug/repos/b4b4r07/http_code

Good point! Should I fix the PR or will you do it before merging?

Would you fix the PR please?

Done!

I appreciate it :+1:


[Feature] Clear all notifications shortcut

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
A CLI command to clear all notifications.
My intention would be to bind it to right-clicking the notification icon, but could be bound to a keyboard shortcut, etc.
Describe alternatives you've considered
A clear-all button exists in the notification menu already, I am just looking for a shortcut to trigger this
Additional context
N/A

https://aylur.github.io/ags-docs/config/cli/
Since ags lets you run arbitary code, you can create a custom ts file that lops over the notification similar to how the clear all button does things. And then call the file with how its shown on the screenshot .

@chucklefart Implemented, feel free to use:
ags -r "clearAllNotifications()"


Added TS types for Manifold and WorldManifold

Here are some more Typescript types.
I did not put the constructors such as:
export let Manifold: {
  new(): Manifold;
};

as Manifold is an internal member.
In case it interests anyone: on our fork I will make Manifold public and add the constructors because I want to create a Manifold on my user code side to bypass Box2D's limitation of not getting an exact collision point for sensors.

I do not want to expose our internal hack, making a new PR.


FATAL: Failed to create tunnel.

The problem
Setup the first time worked fine, but after changing to a new domain/hostname, I'm getting errors
What version of Cloudflared has the issue?
4.0.5
What was the last working version of Cloudflared?
4.0.5
What type of installation are you running?
Home Assistant OS
Add-on YAML Configuration
additional_hosts: []
external_hostname: 2363.tk

Anything in the logs that might be useful for us?
s6-rc: info: service s6rc-oneshot-runner: starting
s6-rc: info: service s6rc-oneshot-runner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service init-banner: starting
s6-rc: info: service fix-attrs successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
-----------------------------------------------------------
 Add-on: Cloudflared
 Use a Cloudflare Tunnel to remotely connect to Home Assistant without opening any ports
-----------------------------------------------------------
 Add-on version: 4.0.5
 You are running the latest version of this add-on.
 System: Home Assistant OS 9.4  (aarch64 / raspberrypi4-64)
 Home Assistant Core: 2022.12.7
 Home Assistant Supervisor: 2022.11.2
-----------------------------------------------------------
 Please, share the above information when looking for help
 or support in, e.g., GitHub or forums.
-----------------------------------------------------------
s6-rc: info: service init-banner successfully started
s6-rc: info: service init-log-level: starting
s6-rc: info: service init-log-level successfully started
s6-rc: info: service init-cloudflared-config: starting
[21:33:00] INFO: Checking config for legacy options...
[21:33:00] INFO: Checking add-on config...
[21:33:02] INFO: Checking for existing certificate...
[21:33:02] INFO: Existing certificate found
[21:33:02] INFO: Checking for existing tunnel...
[21:33:02] NOTICE: No tunnel file found
[21:33:02] INFO: Creating new tunnel...
2022-12-20T13:33:02Z WRN Your version 2022.11.1 is outdated. We recommend upgrading it to 2022.12.1
failed to create tunnel: Create Tunnel API call failed: tunnel with name already exists
[21:33:02] FATAL: Failed to create tunnel.
    Please check the Cloudflare Teams Dashboard for an existing tunnel with the name homeassistant and delete it:
    https://dash.teams.cloudflare.com/ Access / Tunnels
s6-rc: warning: unable to start service init-cloudflared-config: command exited 1
/run/s6/basedir/scripts/rc.init: warning: s6-rc failed to properly bring all the services up! Check your logs (in /run/uncaught-logs/current if you have in-container logging) for more information.
prog: fatal: stopping the container.
s6-rc: info: service legacy-cont-init: stopping
s6-rc: info: service init-log-level: stopping
s6-rc: info: service init-log-level successfully stopped
s6-rc: info: service init-banner: stopping
s6-rc: info: service init-banner successfully stopped
s6-rc: info: service legacy-cont-init successfully stopped
s6-rc: info: service fix-attrs: stopping
s6-rc: info: service fix-attrs successfully stopped
s6-rc: info: service s6rc-oneshot-runner: stopping
s6-rc: info: service s6rc-oneshot-runner successfully stopped

Steps to reproduce the issue

change hostname
errors, won't start

Additional information
No response

https://github.com/brenner-tobias/addon-cloudflared/issues/99#issuecomment-1133876937


ionic 2 doc, can't scroll menu with touchpad

It is not possible to scoll the menu on the ionic v2 doc site, with a laptop only using the touchpad.
There is no scroll bar, and the main page scroll bar do nothing to the menu.
It is only possible with a mouse scroll or touch screen.

I'm able to scroll when the cursor is over the menu, but this may be confusing. I'm trying to think of a way to make that more obvious or not an issue. Thoughts? CC @bensperry

I'm not seeing this issue at all. I can easily scroll the whole page while my cursor is over the menu on the left.


Update Meshery project site with listing of NSM adapter (alpha)

Preemptively, let's ensure that the NSM adapter effort is listed under Supported Service Meshes here - https://github.com/layer5io/layer5/blob/master/_includes/meshery.html#L108

Quick work!


Custom instance defaults can't be set as documented

https://github.com/mzabriskie/axios#custom-instance-defaults
Because the defaults from defaults.js are not merged in here: https://github.com/mzabriskie/axios/blob/master/lib/axios.js#L88, instance.defaults.headers will be undefined.
I'll try to make a PR some time soon.

+1  Any movement on this?

This is an issue I'm dealing with too, forced to use global defaults instead, which is far from optimal.

This has been fixed with 46eee26


Allows specifying "global namespaces" when using namespace isolation

When using namespaceIsolation -- we have only allowed for referring to the default namespace from any given namespace. This enhancement adds a configuration option globalNamespaces which allows one to specify any additional namespaces which they would like to refer to "globally" -- that is, from any given namespace (as opposed to "locally" -- from the same namespace in which a pod resides, which is the core functionality of namespaceIsolation).
The globalNamespaces parameter works only when namespaceIsolation is set to true. When globalNamespaces is unset, it is implied that default will still be allowed globally.
cc: @rohan47
Fixes #567

Pull Request Test Coverage Report for Build 336362521

0 of 0   changed or added relevant lines in 0 files are covered.
84 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.3%) to 71.317%

Files with Coverage Reduction
New Missed Lines
%

k8sclient/k8sclient.go
22
70.84%

types/conf.go
62
77.84%

Totals

Change from base Build 332121316:
0.3%

Covered Lines:
1099

Relevant Lines:
1541

💛  - Coveralls

@dougbtv If I understand correct, globalNamespaces needs to be specified in the multus config and can't be specified through net-attach-defs right?

@matrohon that's correct -- so in the case of OpenShift, we'll specify the globalNamespaces using the cluster-network-operator.
I want to allow some flexibility of configuration to allow using some namespaces globally, but, if we allowed it in net-attach-defs then it opens the door for unprivileged users to be able to specify it (the namespace isolation feature is intended to disallow some class of user from accessing networks that are considered "more privileged").

you probably meant @rohan47 ?

(sorry for the bad autocomplete Mathieu!) Yes, @rohan47 above ^^^ :)


Add name to the contributor.md

Your pull request seems good, but must be checked by a human maintainer for the following reason(s):

This PR modifies one or more pre-existing files.

Please be patient until a maintainer has time to look over your contribution.
This is an automated response, beep boop.
if you think there is a mistake, contact a maintainer

cac08c81303ce7e15f37f075e67fcc410b10f376


Test driver and/or the tool should be resilient to gradle dependency download failures

These flake issues were filed due to gradle failing to download dependencies. Ideally, these tests should be preceded by a step that ensures they won't need to hit the network while running. If that isn't possible (or as an additional defense against flakes), the tool should be more resilient against gradle network flakes in some way.
https://github.com/flutter/flutter/issues/125543
https://github.com/flutter/flutter/issues/125542
cc @christopherfujino @reidbaker

Also https://github.com/flutter/flutter/issues/125547

Feature request filed here https://github.com/flutter/flutter/issues/120119 (by you :))

Duplicate of #https://github.com/flutter/flutter/issues/120119


footer-html key doesn't works in setOptions

Hi, I was trying to generate footer in the PDF by setting footer-html key provided by wkhtmltopdf library. I am using a code similar to given below
$pdf->setOptions(array('footer-html' =>
Hello

world
'));
but the problem is the html footer is not being rendered in the final PDF generated. Can you tell me what am I doing wrong? Can this key be set in the wrapper. Thanks.

It should work. Sometimes the footer is not visible due to HTML / CSS layout issues. Apart from that I can't really do much here. You could show me the generated final wkhtmltopdf command:
$pdf->saveAs(...);
echo (string) $pdf->getCommand();

@mikehaertl  sorry I was gave wrong information regarding generated PDF. PDF is being generated but with no content. Also when I am simply writing:
$pdf->setOptions(array('footer-html' => Hello world')); the code works and PDF  is being generated successfully.

What is the output of $pdf->getError() after you generated the PDF?

I'm closing this for now as there was no further feedback. If you still feel there's something to fix, please provide a full simplified example to reproduce the problem.


CIF-1466 - Add support for GraphQL named fragments in Magento GraphQL…

… library
This is generated by https://github.com/adobe/graphql-java-generator/pull/7
Description
This PR is pretty large so for the review I recommend to look at the following files to understand what has basically been generated for all GraphQL types:

Fragment.java : the basic class to define a fragment. It's generic because a GraphQL fragment is by nature defined for a given GraphQL type, like fragment price on ProductPrice. Having this also generic in Java will ensure one cannot use a certain fragment at at wrong location in the query.
ProductInterfaceQuery.java : shows the methods added to all query types to add support for fragments.
SimpleProductQuery.java : because this implements multiple GraphQL interfaces, we add multiple methods to reference fragments for all the GraphQL interfaces implemented by this type.
QueryQuery.java and MutationQuery.java : the two root types have an extra method to add fragments to the GraphQL request.
QueryBuilderTest.java : I added a very large example to write the GraphQL request of the CIF Product component with fragments. The expected request is available in product-query-with-fragments.txt.

Motivation and Context
The GraphQL queries of some components like the CIF Product component are getting extremely large and complex. Being able to use fragments avoids repeating parts that are needed multiple times, like for prices and media gallery.
How Has This Been Tested?
Extended unit tests and tested with a Magento instance that the query works as expected.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes and the overall coverage did not decrease.
[x] All unit tests pass on CircleCi.
[x] I ran all tests locally and they pass.

Verified that the CIF components bundle compiles with the new library and that all tests pass. There isn't much more to test, this is an extra feature that we can use later to write GraphQL queries with named fragments.


tests: test with the latest ansible stable-2.2 branch from github

Signed-off-by: Andrew Schoen<EMAIL_ADDRESS>

The purge_cluster_collocated test is known to fail until https://github.com/ceph/ceph-ansible/pull/1214/commits/1de78d710116dec08b8da2f5ba816915728edd47 is merged.
Everything else is looking good here with this branch of ansible.

I've disabled the purge_cluster_collocated tests. I've found more issues with the purge-cluster.yml playbook and will follow up in a different PR to fix those.


Update Maven deployment Action

Hello! We had to make a few changes to our community's Maven deployment Action. Specifically, we updated the secret names and deployment credentials.
Please update to the latest release, v. 1.2.1, to make sure your Action works. Thank you!

Updated with release v1.2.1.


Should use the same thread-pool

While investigating the performance regression of Monix 2.1.x, I discovered that ForkJoinPool (which is backing Scala's own global execution context) has been migrated in the implementation of Scala 2.12 to java.util.concurrent.ForkJoinPool and that this implementation has lower throughput than the one in Scala 2.11.
The difference is quite significant and at this point I'm actually considering introducing my own implementation of ForkJoinPool in Monix, because unless I'm not horribly mistaken, this isn't a problem that the Scala developers can fix in the standard library, unless they bring back scala.concurrent.forkjoin.ForkJoinPool. Anyway, I've started this issue on my own end:
https://github.com/monix/monix/issues/281#issuecomment-269349331
That said, when benchmarking, it's important to not measure the wrong thing. At least the tests that are forking threads should be backed by the same thread-pool implementation, otherwise you end up measuring the performance of the underlying thread-pools. For example I don't know what FS2 does, but Scalaz definitely doesn't use by default a ForkJoinPool for its Task.fork or Task.apply.

As far as I know, none of our benchmarks are using any parallelism in scalaz-stream or fs2.  Monix may be running things in parallel outside of our control (I honestly don't know), but our scalaz-stream and fs2 benchmarks are sequential and do not use any thread pools, fork/join or otherwise.

@djspiewak it's not about parallelism, but about executing things in parallel.
And FS2 has a specified Strategy that's basically about usage of a thread-pool, taken as a parameter in Task.apply. You couldn't execute your AsyncT without blocking threads otherwise.
Can't figure out what the default for the JVM is, but it seems that in your tests the used strategy is:
val cores: Int = Runtime.getRuntime().availableProcessors
lazy val scaledStrategy: Strategy = Strategy.fromFixedDaemonPool(cores)

Which is then backed by a Java Executors.newFixedThreadPool, returning a fixed size java.util.concurrent.ThreadPoolExecutor.

@alexandru I think you're operating under a misunderstanding of how fs2's execution model works.  The only use of a thread pool with fs2 in any capacity whatsoever in this project is here.  Note that flatMap doesn't take an executor, and so there isn't any thread shifting beyond the initial apply.
Monix may make more aggressive use of thread shifting, and given its default-push architecture I would expect it to do so, but fs2 does not.  All of the fs2 stream tests in this repository are sequential and do not involve thread pools in any fashion.


apollo4p_evb: samples/drivers/flash_shell/sample.drivers.flash.shell   Build failed in CI

building the samples/drivers/flash_shell for the apollo4p_evb target fails :
twister -p mpfs_icicle -T  samples/drivers/flash_shell/
or
wb -p auto -b apollo4p_evb samples/drivers/flash_shell/
SHA1 : d18fd46e991134ea29c8b52a52f2e4960327dfa4
To Reproduce
Steps to reproduce the behavior:

mkdir build; cd build
cmake -DBOARD=board_xyz
make
See error

Impact
CI failure blocking several PR
Logs and console output
./build/zephyr/include/generated/zephyr/devicetree_generated.h:7039:34: error: 'DT_N_S_soc_S_flash_controller_18000_S_flash_18000_P_write_block_size' undeclared here (not in a function); did you mean 'DT_N_S_soc_S_flash_controller_18000_S_flash_18000_P_reg_IDX_1'?
 7039 | #define DT_N_INST_0_soc_nv_flash DT_N_S_soc_S_flash_controller_18000_S_flash_18000

Environment (please complete the following information):

OS: Ubuntu)
Toolchain 0.16.0
Commit SHA d18fd46e991134ea29c8b52a52f2e4960327dfa4

Additional context
Add any other context that could be relevant to your issue, such as pin setting,
target configuration, ...

It looks like write-block-size and erase-block-size properties are missing for the flash-controller
&flash0 {
	write-block-size = <16>;
	erase-block-size = <8192>;
};

Issue introduced by 008efecf5dddd1d54fb0726c4db5c3447bad5308
@RichardSWheatley

Full log:
./build/zephyr/include/generated/devicetree_generated.h:6453:34: error: 'DT_N_S_soc_S_flash_controller_18000_S_flash_18000_P_write_block_size' undeclared here (not in a function); did you mean 'DT_N_S_soc_S_flash_controller_18000_S_flash_18000_P_reg_IDX_1'?
 6453 | #define DT_N_INST_0_soc_nv_flash DT_N_S_soc_S_flash_controller_18000_S_flash_18000
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./include/zephyr/toolchain/gcc.h:87:51: note: in definition of macro 'BUILD_ASSERT'
   87 | #define BUILD_ASSERT(EXPR, MSG...) _Static_assert(EXPR, "" MSG)
      |                                                   ^~~~
./drivers/flash/flash_ambiq.c:22:32: note: in expansion of macro 'MAX'
   22 | #define FLASH_WRITE_BLOCK_SIZE MAX(DT_PROP(SOC_NV_FLASH_NODE, write_block_size), MIN_WRITE_SIZE)
      |                                ^~~
./include/zephyr/devicetree.h:636:32: note: in expansion of macro 'DT_CAT3'
  636 | #define DT_PROP(node_id, prop) DT_CAT3(node_id, _P_, prop)
      |                                ^~~~~~~
./drivers/flash/flash_ambiq.c:22:36: note: in expansion of macro 'DT_PROP'
   22 | #define FLASH_WRITE_BLOCK_SIZE MAX(DT_PROP(SOC_NV_FLASH_NODE, write_block_size), MIN_WRITE_SIZE)
      |                                    ^~~~~~~
./include/zephyr/sys/util_internal.h:105:36: note: in expansion of macro 'DT_N_INST_0_soc_nv_flash'
  105 | #define UTIL_PRIMITIVE_CAT(a, ...) a##__VA_ARGS__
      |                                    ^
./include/zephyr/sys/util_internal.h:104:26: note: in expansion of macro 'UTIL_PRIMITIVE_CAT'
  104 | #define UTIL_CAT(a, ...) UTIL_PRIMITIVE_CAT(a, __VA_ARGS__)
      |                          ^~~~~~~~~~~~~~~~~~
./include/zephyr/devicetree.h:336:31: note: in expansion of macro 'UTIL_CAT'
  336 | #define DT_INST(inst, compat) UTIL_CAT(DT_N_INST, DT_DASH(inst, compat))
      |                               ^~~~~~~~
./drivers/flash/flash_ambiq.c:18:32: note: in expansion of macro 'DT_INST'
   18 | #define SOC_NV_FLASH_NODE      DT_INST(0, soc_nv_flash)
      |                                ^~~~~~~
./drivers/flash/flash_ambiq.c:22:44: note: in expansion of macro 'SOC_NV_FLASH_NODE'
   22 | #define FLASH_WRITE_BLOCK_SIZE MAX(DT_PROP(SOC_NV_FLASH_NODE, write_block_size), MIN_WRITE_SIZE)
      |                                            ^~~~~~~~~~~~~~~~~
./drivers/flash/flash_ambiq.c:25:15: note: in expansion of macro 'FLASH_WRITE_BLOCK_SIZE'
   25 | BUILD_ASSERT((FLASH_WRITE_BLOCK_SIZE & (MIN_WRITE_SIZE - 1)) == 0,
      |               ^~~~~~~~~~~~~~~~~~~~~~
./drivers/flash/flash_ambiq.c:25:14: error: expression in static assertion is not an integer
   25 | BUILD_ASSERT((FLASH_WRITE_BLOCK_SIZE & (MIN_WRITE_SIZE - 1)) == 0,
      |              ^
./include/zephyr/toolchain/gcc.h:87:51: note: in definition of macro 'BUILD_ASSERT'
   87 | #define BUILD_ASSERT(EXPR, MSG...) _Static_assert(EXPR, "" MSG)
      |                                                   ^~~~
./drivers/flash/flash_ambiq.c: In function 'flash_ambiq_write':
./drivers/flash/flash_ambiq.c:81:18: warning: unused variable 'aligned' [-Wunused-variable]
   81 |         uint32_t aligned[FLASH_WRITE_BLOCK_SIZE / sizeof(uint32_t)] = {0};
      |                  ^~~~~~~
In file included from ./include/zephyr/arch/arm/arch.h:20,
                 from ./include/zephyr/arch/cpu.h:19,
                 from ./include/zephyr/kernel_includes.h:36:
./drivers/flash/flash_ambiq.c: At top level:
./build/zephyr/include/generated/devicetree_generated.h:6453:34: error: 'DT_N_S_soc_S_flash_controller_18000_S_flash_18000_P_erase_block_size' undeclared here (not in a function); did you mean 'DT_N_S_soc_S_flash_controller_18000_S_flash_18000_P_reg_IDX_1'?
 6453 | #define DT_N_INST_0_soc_nv_flash DT_N_S_soc_S_flash_controller_18000_S_flash_18000
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./include/zephyr/devicetree.h:4534:29: note: in definition of macro 'DT_CAT3'
 4534 | #define DT_CAT3(a1, a2, a3) a1 ## a2 ## a3
      |                             ^~
./drivers/flash/flash_ambiq.c:23:32: note: in expansion of macro 'DT_PROP'
   23 | #define FLASH_ERASE_BLOCK_SIZE DT_PROP(SOC_NV_FLASH_NODE, erase_block_size)
      |                                ^~~~~~~
./include/zephyr/sys/util_internal.h:105:36: note: in expansion of macro 'DT_N_INST_0_soc_nv_flash'
  105 | #define UTIL_PRIMITIVE_CAT(a, ...) a##__VA_ARGS__
      |                                    ^
./include/zephyr/sys/util_internal.h:104:26: note: in expansion of macro 'UTIL_PRIMITIVE_CAT'
  104 | #define UTIL_CAT(a, ...) UTIL_PRIMITIVE_CAT(a, __VA_ARGS__)
      |                          ^~~~~~~~~~~~~~~~~~
./include/zephyr/devicetree.h:336:31: note: in expansion of macro 'UTIL_CAT'
  336 | #define DT_INST(inst, compat) UTIL_CAT(DT_N_INST, DT_DASH(inst, compat))
      |                               ^~~~~~~~
./drivers/flash/flash_ambiq.c:18:32: note: in expansion of macro 'DT_INST'
   18 | #define SOC_NV_FLASH_NODE      DT_INST(0, soc_nv_flash)
      |                                ^~~~~~~
./drivers/flash/flash_ambiq.c:23:40: note: in expansion of macro 'SOC_NV_FLASH_NODE'
   23 | #define FLASH_ERASE_BLOCK_SIZE DT_PROP(SOC_NV_FLASH_NODE, erase_block_size)
      |                                        ^~~~~~~~~~~~~~~~~
./drivers/flash/flash_ambiq.c:157:44: note: in expansion of macro 'FLASH_ERASE_BLOCK_SIZE'
  157 |         .pages_count = SOC_NV_FLASH_SIZE / FLASH_ERASE_BLOCK_SIZE,
      |                                            ^~~~~~~~~~~~~~~~~~~~~~

Lowering priority after the board has been disabled in CI


Check MAALI_TOOL_NAME is what we want

Please add an environment variable into the cygnet file, such as MAALI_TOOL_NAME_CHECK, where if it is set then to compare it to MAALI_TOOL_NAME that is given on the command line.  This would give a simple concise error message stating that maali was called with the wrong tool name, rather than waiting to cd into the build directory to complain that a directory was not found (which we then work out is because we got the capitalisation wrong).

Daniel mentioned it, Daniel did it ;)


Screenshots

Visual defect. These exist when looking directly up (north, 90 degrees) and down (south, 270 degrees). I believe it's because of the un-optimized used to determine the distance of the rays. When looking straight up or down, the "slope" of the line may have so much delta-Y that the ray skips past the wall.

New gif with ceiling and floor.


windows javascript error on right click to paste

Thx! Yep it’s happening on all platforms.
It’s set to be patched in next build.
On Nov 7, 2018, 8:51 PM -0500, Bugsy<EMAIL_ADDRESS>wrote:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Fixed in 69a4638c4c36eeeff1f0911e3c12c939d47a1f61


Add support to create Federated repositories using CLI

Is your feature request related to a problem? Please describe.
We can not create Federate repositories using JFrog CLI, while creating the repository as part of the template creation process, I don’t see the Federated repository option at all, please find the below screenshot for the same.

When creating the Federated repository bypassing the complete json we will get "unsupported rclass: federated" error as below:

Describe the solution you'd like to see
I would like to create Federated repositories using JFrog CLI.
Describe alternatives you've considered
As an alternative, we can create it using REST API or through Artifactory UI.

Please add this feature. If the CLI tool is meant to automate management of Artifactory, then it needs to be kept in sync with all features in the enterprise version of Artifactory.

Hi, @xjg6yzl @pavanvikas We've released a new version that would support this issue.
Please let us know if you have any more issues or questions.
And thank you for your feedback! 🐸

Hi, thank you for adding federated repository support. However, the CLI doesn't allow you to add member clusters to the federated repo, and even when editing the template and adding the members manually, does it work.
# test-repo.json
{
  "key": "test-generic-fed",
  "packageType": "generic",
  "rclass": "federated",
  "members": [
    {
      "url": "https://cluster1.example.com/artifactory/gce-mbergman-generic-fed",
      "enabled": true
    },
    {
      "url": "https://cluster2.example.ea.com/artifactory/gce-mbergman-generic-fed",
      "enabled": true
    }
  ]
}

jf rt ru test-repo.json
[🚨Error] template syntax error: unknown key: "members".


Fatal error handling

We need to give developers a way to gracefully handle 500 errors.

handled pr #347


Merged Development To Master

Tested code, all seems well.

Merged development into master after extensive testing as stable.


[RFC] Deprecate auto_select_gpus from Trainer constructor

Proposed refactoring or deprecation
Deprecate auto_select_gpus from Trainer constructor:
https://github.com/PyTorchLightning/pytorch-lightning/blob/7a9a08c5d3ca4699fb439f691c40e1320b37507a/pytorch_lightning/trainer/trainer.py#L209-L212
Motivation
Users can achieve the same functionality by setting the accelerator and devices flags - we can simplify by only having one way of doing this.

@daniellepintz We do have users using it. For instance, https://github.com/PyTorchLightning/pytorch-lightning/issues/10456.
It could be pretty convenient when users are running multiple experiments on bunch of GPUs.

@kaushikb11 can this same functionality not be achieved with accelerator and devices flags?

@daniellepintz Currently, I think that if we want 3 available GPUs, then we need to specify devices=3 and accelerator='gpu'. However, this means that GPUs [0, 1, 2] are selected, even if one of them is fully used by another process:
https://github.com/PyTorchLightning/pytorch-lightning/blob/ffb1a754af5301608c71955c12468216e920af51/pytorch_lightning/utilities/device_parser.py#L76
However, with auto_select_gpus, it chooses 3 GPUs that are available. This will be [0, 1, 2] if all three are available, else it will also check GPUs 3, 4, etc. until it finds 3 available GPUs.


[SPARK-47315][SQL][TEST] Clean up tempView for createTempView UT

What changes were proposed in this pull request?

Clean up tempView for createTempView UT
Why are the changes needed?

tempView created in createTempView UT is not cleaned up.
https://github.com/apache/spark/blob/3ec79a9df06f3b5bd28347238a8dfad616ce42d9/sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala#L1433
Does this PR introduce any user-facing change?

No
How was this patch tested?

no need
Was this patch authored or co-authored using generative AI tooling?

No

Merged to master.
Thank you @wForget and @HyukjinKwon.


AppBar doesn't apply overriden Theme

I have a very simple AppBar outside of a Scaffold, like:
class MyScreen extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Column(
        children: <Widget>[
          AppBar(
            title: Text('hi'),
            flexibleSpace: Container(color: Colors.purple, height: 200,),
          ),
          Expanded(
            child: Center(
              child: Text('hi again'),
            ),
          ),
        ],
      ),
    );
  }
}

Which renders like:

The MaterialApp theme primaryColorBrightness is Brightness.light.
Now, if I change the MaterialApp theme primaryColorBrightness to Brightness.dark the status bar color AND the AppBar icons and text change to white:

But if I just want to change the Theme for  MyScreen and not the whole app, the status bar changes color to white, but the AppBar doesn't:
class MyScreen extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Theme(
      data: Theme.of(context).copyWith(primaryColorBrightness: Brightness.dark),
      child: Scaffold(
        body: Column(
          children: <Widget>[
            AppBar(
              title: Text('hi'),
              flexibleSpace: Container(color: Colors.purple, height: 200,),
            ),
            Expanded(
              child: Center(
                child: Text('hi again'),
              ),
            ),
          ],
        ),
      ),
    );
  }
}

As can be seen here:

This inconsistency seems like a bug to me.

Issue exist
flutter doctor -v
[✓] Flutter (Channel dev, v1.18.0, on Mac OS X 10.15.4 19E266, locale en-GB)
    • Flutter version 1.18.0 at /Users/taha/Code/flutter_dev
    • Framework revision 8f7327f83a (31 hours ago), 2020-04-06 22:11:01 -0400
    • Engine revision 49891e0653
    • Dart version 2.8.0 (build 2.8.0-dev.20.0 1210d27678)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4, Build version 11E146
    • CocoaPods version 1.9.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.0.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.43.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.9.1

[✓] Connected device (4 available)
    • SM M305F   • 32003c30dc19668f • android-arm64  • Android 10 (API 29)
    • macOS      • macOS            • darwin-x64     • Mac OS X 10.15.4 19E266
    • Chrome     • chrome           • web-javascript • Google Chrome
      80.0.3987.149
    • Web Server • web-server       • web-javascript • Flutter Tools

• No issues found!

AppBar Theme Issue
I would like to add that the issues with the AppBar theme go a bit further than just the issue with its brightness being tied to the brightness of the primaryColor of the overall theme. Here are my findings:

AppBar Brightness has no function.
Difficult to create a light AppBar theme when primaryColor is of Brightness.dark.

Applies to:
All Flutter platform versions and channels, going back at least 1.5 years.
Workaround
EDIT: While making this issue comment I towards the end figured out that nr 2 above is just a consequence of no geometry being available at the point when the app bar text theme is being made. More about this in the conclusion at the end.
I left all the written reasoning of how I got there intact, as I think it might help others struggling with the AppBarTheme understand what is going on.
1. AppBar Brightness has no function
The AppBar theme's brightness property has no function or relevance, it has never done anything useful.
I agree with the finding in the related issue https://github.com/flutter/flutter/issues/61618 that if you do a
theme: ThemeData(
  appBarTheme: const AppBarTheme(
    brightness: Brightness.light),
  ),

It is then a fair assumption that it would force dark text and and dark icon theme if you set brightness: Brightness.light, if icon and text properties are not specified by the appbar theme itself, and vise versa for Brightness.dark. However, it does not do anything useful, other than carry the info if set correctly in relation to the color property of the AppBarTheme.
2. Difficult to create a light AppBar theme when primaryColor is of Brightness.dark
The header is a bit short and needs elaboration. The coupling of the AppBar's text theme to the overall primaryTextColor theme is so tight that it is actually very difficult to get around it. It's bond is so strongly that it is currently impossible to create an AppBarTheme that goes against this coupling without breaking some parts of it.
For example it is impossible to create an AppBar theme that is light (usually then the popular white appbar) and need black typography, when the overall theme is light and its primaryColor is of Brightness.dark, thus creating an overall theme where the primaryTextTheme gets white typography.
Below some examples of what one might try when trying to make a light or often white app bar. I'm just using grey in the examples so both white and black text can be seen on the appbar.
2.1 Demo of AppBar's coupling to primaryColor and primaryTextTheme
Lets start with:
theme: ThemeData(
  appBarTheme: AppBarTheme(
    color: Colors.grey[300],
    brightness: Brightness.light,
    textTheme: const TextTheme(),
    iconTheme: const IconThemeData(color: Colors.black87),
    actionsIconTheme: const IconThemeData(color: Colors.black87),
    elevation: 0),
  ),

It will result in an appbar like this, which is the correct result:

Now let's try to make the text dark by changing the AppBar's TextTheme, first we try this:
theme: ThemeData(
  appBarTheme: AppBarTheme(
    color: Colors.grey[300],
    brightness: Brightness.light,
    textTheme: Typography.material2018().black,
    iconTheme: const IconThemeData(color: Colors.black87),
    actionsIconTheme: const IconThemeData(color: Colors.black87),
    elevation: 0),
  ),

and second try this this variant:
theme: ThemeData(
  appBarTheme: AppBarTheme(
    color: Colors.grey[300],
    brightness: Brightness.light,
    textTheme: const TextTheme()
        .merge(Typography.material2014(platform: TargetPlatform.android).black),
    iconTheme: const IconThemeData(color: Colors.black87),
    actionsIconTheme: const IconThemeData(color: Colors.black87),
    elevation: 0),
  ),

In both above cases we got black text, but the correct text styles are missing, all we get is a small default text style.
Let's try one more with the apply method.
theme: ThemeData(
  appBarTheme: AppBarTheme(
    color: Colors.grey[300],
    brightness: Brightness.light,
    textTheme: const TextTheme()
        .apply(bodyColor: Colors.black, displayColor: Colors.black87),
    iconTheme: const IconThemeData(color: Colors.black87),
    actionsIconTheme: const IconThemeData(color: Colors.black87),
    elevation: 0),
  ),

Well the style is OK, but the apply black color specification did not have any impact at all, which was surprising.

The above examples can be found in this CodePen: https://codepen.io/rydmike/pen/RwrEodX
You just have to swap comment lines for the AppBarTheme's textTheme property to try them all.
Seem tricky, but let's dig deeper and try this. We create a ThemeData object first, apply its default text theme to the AppBar's text theme.
// Create a default light theme
final ThemeData themeBase = ThemeData();
// Store it's default text theme, it is already black for the light surface
final TextTheme blackTextTheme = themeBase.textTheme;
// Let's try to use this in a ThemeData Object and use it as a Theme
final ThemeData theme = ThemeData(
  appBarTheme: AppBarTheme(
    color: Colors.grey[300],
    brightness: Brightness.light,
    textTheme: blackTextTheme,
    iconTheme: const IconThemeData(color: Colors.black87),
    actionsIconTheme: const IconThemeData(color: Colors.black87),
    elevation: 0),
);

Result is this:

That was surprising and seemed odd, I also printed out a text with the copied blackTextTheme and that gave me the clue that there is no geometry yet when we copy the theme, that is applied in the localize process in the MaterialApp and apparently that is what is wrong with the text theme in all the other cases too.
In this last case it obvious that it does not know about the geometry yet via Typography localisations, but it was a bit less obvious in the first CodePen when the ThemeData was constructed in the MaterialApp's theme property. It is easy to assume it will get correct geometry at this point, but the situation is of course the same, it does not yet have any geometry here either and when you make an AppBar theme yourself, it never gets any geometry applied during the localize process, it does not get applied to the custom AppBarTheme.
I did not dig deep enough to figure out which text theme's will get geometry in the localize proecess, is it eg only the themes Flutter knows about in ThemeData, like textTeme, primaryTextTheme and accentTextTheme or does it get applied to any supplied none null text theme in any of the other themes in ThemeData and it only happens to be missing for AppBar's text theme?
In any case, now that we figured this out, let's try to apply some geometry to see if we can get it to look right, first we test to fix the above example:
// Create a default light theme
final ThemeData themeBase = ThemeData();
// Store it's default text theme, it is already black for the light surface
final TextTheme blackTextTheme = themeBase.textTheme.merge(Typography.englishLike2018);
final ThemeData theme = ThemeData(
  appBarTheme: AppBarTheme(
    color: Colors.grey[300],
    brightness: Brightness.light,
    textTheme: blackTextTheme,
    iconTheme: const IconThemeData(color: Colors.black87),
    actionsIconTheme: const IconThemeData(color: Colors.black87),
    elevation: 0),
);

And finally we get it with the correct style.

The CodePen for the above example can be found here: https://codepen.io/rydmike/pen/PoZVNxr

Now we can make a workaround solution for the original challenge to make a white AppBar for a light theme with a dark primary color.
MaterialApp(
      debugShowCheckedModeBanner: false,
      title: 'Flutter Demo',
      theme: ThemeData(
        primaryColor: Colors.indigo[800],
        scaffoldBackgroundColor: Colors.white,
        appBarTheme: AppBarTheme(
          color: Colors.white,
          brightness: Brightness.light,
          textTheme:
              Typography.material2018().black.merge(Typography.englishLike2018),
          iconTheme: const IconThemeData(color: Colors.black87),
          actionsIconTheme: const IconThemeData(color: Colors.black87),
          elevation: 0,
        ),
      ),
      home: MyHomePage(title: 'Light AppBar Theme Issue #50606'),
    );

The result:

Conclusion: Remaining issue and why I gave it a "Workaround" status
Apart from being very complex to figure out how to get the end result, the only way to do it was to create an AppBar theme that will not get typography localization's applied to it as a apart of the localization process, so now you have to deal with that part yourself in the app, not really a working solution for an international app.
A white app bar in a light theme is a very popular design, focus remains better on the content. It started in iOS, but has spread to Android and Material too, when done right it looks very nice.
Currently it is very complicated to make such a design that is theme based in Flutter.
I could not figure out how to do it while retaining localization functionality of its Typography. You can of course forget about a theme for your white appbar and just make a custom appbar widget that checks if its color is light and then sets its icon theme and text color to black or black87, then you can keep your Typography localization functionality. But imo theming an app should really be made using themes and not via widgets in the app, to be easier to maintain and change from a central point.
Clearly a better way to make light or white appbar theme is needed.

Would you consider submitting a pull request to fix this, @rydmike? I suspect you've followed this rabbit hole far enough to have a good idea of the fix... Also /cc @HansMuller for interest.

IIRC @HansMuller was changing several themes, starting for the new Buttons theme that's about to be released... I memory doesn't fails the AppBar's theme system was in the same roadmap, so this issue might be a part of a bigger future change in the framework entirely.

@feinstein I agree it is indeed quite an involved topic and I am aware of the redesign/improvements going on with the entire Theme design. I think I read a design doc on it a while ago, but can't find it of the top of my head. I have also noticed that @HansMuller has been doing a lot of work on themes lately. I hope he has a chance to look at the challenges with the AppBar theme too. It might actually be a bit tricky solve due to legacy reasons without breaking things, well maybe easier if you add some new features, probably the new targeted way of handling all sub-themes can handle the needed scenario if done so in the app bar theme.
@timsneath My exploration was more of a discovery and learning what is is going on it.
I dug into after noticing how difficult it was to create a white app bar theme for an overall "light" theme where the primary color is dark, which it mostly is for a light theme. I asked around in a few communities and everybody that tried it ended up either with a white app bar text theme (invisible on the white app bar) or an app bar text theme that was black, but without geometry (small default font). This when the constraint was that you have to do it with just the Theme factory, create a ThemeData class (and its context free helpers) without any context that you can then later apply to your app or anywhere.
Considering how popular the white app bar look is on iOS and that it gets copied a lot also on Android now, I think it does need to be easier to do this correctly with a theme.
Also I still have no idea how I should do it (given the above constraints) in away that would allow me to keep any typography localisations applied to the app bar text theme later. The above workaround example ignores that for now and actually breaks the localization since it no longer uses any of the 3 standard built in text theme's in ThemeData (textTheme, primaryTextTheme, accentTextTheme), but it works for my use case since I don't yet need those localisations, the english like is fine.
Generally I think it can sometimes be a bit problematic that we cannot get a ThemeData object with geometry before we have a context that can be used to localize it. But I understand why it is like this. I guess as long as we can create ThemeData object, including all of its sub theme buy just using textTheme() when sub themes need a text theme and it then also gets correct black/white text theme for the surrounding theme conditions, that then get localized correctly, it can go pretty far as is. I think this actually worked for some sub themes I tried it on, but for some you get a null error if you try it.
On a concept level many of the issues with the default color of the text theme is imo rooted in it all being based on textTheme, primaryTextTheme and accentTextTheme in ThemeData, instead of just having one dark and light text, that would get used when the surface that the text is on, needs dark or light text for optimal contrast, but like I hinted that is much bigger topic and this issue can certainly be fixed somehow within the current constraints.

@HansMuller A bit of topic, but on the topic of theme issues and their development. Regarding the new way of theming, starting from a ColorScheme and using ThemeData.from(colorScheme). Is there a plan to include onColors for primaryVariant and secondaryVariant in a future revised version of ColorScheme?
If you make a theme where the variant colors actually need another onColor than its corresponding primary (the example dark theme in the Material design guide is actually an example of this), there is no way of getting that info from the ColorScheme. You now have to check brightness separately when you want to use the variant colors, e.g. ThemeData.estimateBrightnessForColor(Theme.of(context).colorScheme.primaryVariant)  just to know what text/icon brightness you should put on it, seems a bit tedious.
If this is something that to your knowledge is not yet on the road-map, let me know and I can post an enhancement issue for it.
I have also noticed that if you currently create a theme using ThemeData.from(colorScheme) that the theme for some sub-themes are not in-line with the supplied colorScheme, some widgets still get their defaults from the Theme factory defaults, which will not match the supplied colorScheme. I'll make a separate issue of which ones I have noticed that still have minor issues, perhaps they are also already being addressed. It was maybe only 2 or 3 cases that I have noticed recently. I will follow-up on this in another issue later.

@feinstein - if you have time to look, I hope you'll provide a little feedback about https://github.com/flutter/flutter/pull/71184 which updates AppBar with the overall goal of making color and text style customizations easier.
In terms of your example, the text/icons foreground color can be specified explicitly with the changes from #71184:
AppBar(
  backwardsCompatibility: false, // temporary
  foregroundColor: Colors.white,
  ...
)

The overall theme's AppBarTheme can be used to configure the foreground and background colors for all AppBars via its foregroundColor and backgroundColor properties.

@HansMuller I had a very long day but couldn't miss this update. I really enjoyed it! Specially the systemOverlayStyle, thank you.

@HansMuller just reading colorScheme.onPrimary if the theme's brightness is light for foregroundColor brings a lot of joy.

This is a really nice and welcome improvement. I added a comment here https://github.com/flutter/flutter/pull/71184#issuecomment-737190105
Basically just saying it look really good and that when this lands in master I will test it by trying the things I tried above in comment https://github.com/flutter/flutter/issues/50606#issuecomment-662216140. Just to see and demonstrate how it works in practice with the new features. When I have tried it I will add my findings as a comment to this thread.

Thanks again @HansMuller, I just tried it, and it works beautifully, just like you mentioned here too https://github.com/flutter/flutter/pull/71184#issuecomment-737429052 and of course also when using just the old default ThemeData() factory as well, instead of the simpler and newer ThemeData.from ColorScheme based factories that you showed.
Here just as a confirmation demo of this as well, since I mentioned above that I was going to show it for reference as an additional comment heer.
An app with ThemeData like this using the new AppBarTheme() features, just applied to the default counter app:
void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'AppBar Theme Test',
      theme: ThemeData(
        brightness: Brightness.light,
        primarySwatch: Colors.blue,
        appBarTheme: AppBarTheme(
          backgroundColor: Colors.white,
          foregroundColor: Colors.black87,
          elevation: 0,
        ),
      ),
      home: MyHomePage(title: 'AppBar Theme Test'),
      debugShowCheckedModeBanner: false,
    );
  }
}

Easily now gives us a white app bar with dark text, even though the primary color is of brightness dark and in older version would have forced the text theme to white for the app bar. Nice! It also works if you switch the brighntess to Brightness..dark, the app bar keeps it colors as sepcified.

Practical usability issue during the migration period
I think the only thing I would have wished for to make the migration easier and to get it to apply to all AppBars in an app, would be a way to toggle the desired default behavior via a flag in the overall ThemeData or in the AppBarTheme, kind of like you can with the useTextSelectionTheme.
To have the temporary setting for the backwardsCompatibility flag either in the overall ThemeData or even just in the AppBarTheme, that then gives the default for the AppBar's own setting for it, that might as now have its own setting just in case there is a need to override the theme based setting on an AppBar level, perhaps for some migration use cases.
As it is now, you have to go and set the backwardsCompatibility to false for every AppBar in your app where you want to use the new AppBar theming features. This actually makes opting in to use it difficult, or to migrate to it, since you have to go and set the backwardsCompatibility to false for every AppBar that you create/have in your app, and there might be quite a large number of them. Later when the flag is deprecated you have to remove it again from all instances.
If it would be possible to set the flag also via a parameter in the AppBarTheme() in the example above, it would not be necessary to opt in again when you actually create the AppBars in your app, like below for this example. You can then omit it there since you already opted in via the AppBarTheme, which you probably just define just one place, or much fewer places than the AppBars at least.
Maybe I missed something, but I tried looking in AppBarTheme and ThemeData, but I did not see any opt in option before the actual AppBar creation, it is as described above a bit impractical to only have the opt in option there. If that really is the case that is, maybe I missed something?
class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
        backwardsCompatibility: false,
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Text(
              'You have pushed the button this many times:',
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.headline4,
            ),
          ],
        ),
      ),
      drawer: Drawer(),
      endDrawer: Drawer(),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: Icon(Icons.add),
      ),
    );
  }
}

Step By Step Guide to how to change text color of appbar, icon color of fab universally using theme?

Step By Step Guide to how to change text color of appbar, icon color of fab universally using theme?


plugin directory path

What should we do?
getPluginsDirectory method is no working because it is deprecated . how can we get plugin directory ?
Why should we do it?
to be able to give more freedom for open source support

The global plug-in helper getPluginsDirectory() did not work reliably and got deprecated. You can use paths prefixed with app-plugins:// (e.g. app-plugins://{pluginName}/{pathToResource}) to reference static plug-in assets.


Update Wait-RSJob and Receive-RSJob to support pipeline streaming

Here are the edits to allow both these cmdlets to stream job objects and output more effectively.
Wait-RSJob now finds the jobs that have just finished that loop, removes them from the collection of jobs it's still waiting for, then outputs them. I updated the progress logic and looping control to reflect this small structure change.
Receive-RSJob was rather easy to update. All it needed was an extra condition to check for an incoming job on the pipeline in the process block, then output it if true. Should retain all original functionality.
I tested these enough to make sure they work the way I intended, but I didn't test extensively. So I'd suggest testing it a bit more during your review.

Can you pull back Wait-RSJob and just submit a PR for Receive-RSJob? I haven't had time to really make a good decision on the direction of Wait-RSJob (your proposed change vs. a switch parameter) but would like to at least get the Receive-RSJob update added to the module. You can then open a new Pull request for Wait-RSJob specifically.

I closed it, but I have no idea how to update my fork with all of your updates and resubmit. I can't find it anywhere on here. Do I actually need to download git onto my system to do this? Also i'll be gone for a few days so it might be a bit before I resubmit.

I use the desktop client for GitHub to manage my repos. I'm not quite sure of the best way to update your files based on my changes. I think you could maybe saving those files off and then remove your PoshRSJob repo and re-fork it and add the file in and submit another PR.


Update color-tokens.js

Does not match current Carbon source code for overlay color.
The current Carbon source code uses different colors for overlay. This does not add AI overlay.

Hey @lee-chase !
The color values on the website for $overlay are the correct specs. We actually need to be updating the code with what the website currently states.

$overlay

White theme
Gray 10 theme
Gray 90 theme
Gray 100 theme

Gray 100 at 50%
Gray 100 at 50%
Gray 100 at 70%
Gray 100 at 70%

Going to close this since we need to update the code not the website. 😅


referrer: tune implementation details of referrer

Refine implementation of referrer by:

avoid retry if error is not network related
limit maximum size of manifest index blob
remove partially downloaded meta blob

Codecov Report

Merging #469 (250ed8c) into main (81765b5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #469   +/-   ##
=======================================
  Coverage   37.05%   37.05%
=======================================
  Files          60       60
  Lines        6904     6904
=======================================
  Hits         2558     2558
  Misses       4046     4046
  Partials      300      300


Support multiple deployments

For tools like Terragrunt we can have multiple deployments inside a single directory. Thus, we need an easy way to detect individual deployments and handle them in the policy generator and importer.
One potential solution:
tfimport --terraform_path=terragrunt --recursive

No longer needed. Just run the tool in every root module.


Clear groups in reset method

Fixes #336.
And make sure an option is added to a group only once.
First commit contains failing tests to demonstrate the problems.
Second commit fixes the failing tests.

@nexdrew awesome :shipit: -- I'm hoping to publish a @next branch of yargs tonight perhaps.


Make auth_token writable so that we can reuse them in seperate processes.

I've got several itty-bitty utility scripts that let me do things in Jira. As it stands, I have to re-authenticate each time I run a script, which is quite annoying. Rather than supply my credentials over and over again, or store my credentials in a file, I'd prefer to just reuse the auth_token I get from logging in the first time. All that this pull request changes is making auth_token writable so that I can supply the token in lieu of a call to login().
I did not create unit tests as I don't have a test instance of Jira set up in the fashion that is used in your unit tests. Hopefully the change is small enough that its use is obvious. I did not see a point in making :user writable, as it appears that the only place where it is accessed is from the unit tests.

I'm not sure I understand your use case. Would a new constructor for JIRA::JIRAService that takes an auth_token be sufficient?
I don't like the idea of suddenly making the auth_token so easily writable.

I'm not sure I understand your use case. Would a new constructor for JIRA::JIRAService that takes an auth_token be sufficient?
I don't like the idea of suddenly making the auth_token so easily writable.

That would be more than sufficient. I was just trying to illustrate the option.
As far as use-cases go, I'm looking to make some command-line tools that leverage jiraSOAP.

$ jira_login.rb
User: justfalter
Pass: **********
Token: Ablk231234jg

Maybe a script to comment on an issue:

$ jira_comment.rb Ablk231234jg PROJ-1234 "So I was looking into this and bla bla bla"

Attach a file to an issue:

$ jira_attach.rb Ablk231234jg PROJ-1234 patch1.diff patch2.diff

And finally logout:

$ jira_logout.rb Ablk231234jg
Goodbye!

Obviously, I could stash the token in a local file to make things easier on myself. Regardless, hopefully this better illustrates what I'm looking to do.

Ok, so I'll just close this and add the constructor.

Version 0.10.6 has been tagged and pushed to rubygems

Awesome! Thanks!


Edit the  section

Currently, I can't find a way to edit the  section in generated HTML. Am I missing something?

@thangnoc89 i am closing it as a dup of #51, please reopen if I am missing something


Create a Flutter SDK packages allowlist and use it to prevent accidentally adding new dependencies

As discussed with several members of the Dart team today, they'd like to avoid us introducing new pinned dependencies without first getting approval from their authors. Similarly, the Flutter team would like to avoid accidentally introducing new dependencies in user-facing packages within the SDK.
To accomplish this goal, I will create an allow-list of the current package set (post integration_test reverts) and change flutter update-packages --force-upgrade to fail if the set of core package dependencies grows beyond this. As a separate process, we will also review this allow-list with the Dart team to highlight any problematic packages.

SGTM. Make sure to add a big comment in the code near where you would need to change it to allow more things to say that the list shouldn't be changed without following this or that protocol and getting review from this or that person (that can be me if you would like, or can be whomever else you think is appropriate, e.g. you). You may want to consider also adding a test that verifies that the list itself hasn't been changed... that way it's even more obvious that the list shouldn't change.