Feature/redis

This closes #437 and might also help with #526.
I have tested this with multiple configurations, both single and multi-session, and hope it works as intended. I suspect my documentation isn't extensive enough yet - let me know if any questions remain.
If wanted, I can extend this further to make it more configurable - currently, it works for me, and I am not sure whether anyone else is going to use it.
Hope this PR goes to the correct branch.

No, should be an easy task, I will add a few more after having a look at
what additional parameters might be useful.
niklub<EMAIL_ADDRESS>schrieb am Di., 5. Jan. 2021, 22:58:

@niklub commented on this pull request.
In label_studio/storage/redis.py
https://github.com/heartexlabs/label-studio/pull/529#discussion_r552223838
:

All keys are integers, but redis saves them as strings, so we sometimes

need to convert. The redis key is our prefix (e.g. "my_project/") + the
labelstudio key as string (e.g. "3").

Example: If path is defined as "my_project", calling set(1, my_val) will
write to
my_project/1 (the "/" is added if not already in path)

Values are python dicts encoded as utf-8 strings.
"""

description = 'Redis database connection'

form = RedisStorageForm

def init(self, project_path, path=None, db=1, **kwargs):

do we have some roadblocks for adding other crucial connection parameters
at once, like host, port, and password? that would allow using more general
Redis connections besides the default localhost
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/heartexlabs/label-studio/pull/529#pullrequestreview-562167104,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD4KWBERBWVXIK4YLD6WD23SYODQ3ANCNFSM4VVNEWIA
.

I updated the PR. Please let me know whether there are still any issues with the new PR.

I updated the PR. Please let me know whether there are still any issues with the new PR.

@kasuteru Could you fix tests here?

@kasuteru Could you fix tests here?

@kasuteru Could you fix tests here?

@kasuteru Could you fix tests here?

And it will be great if you resolve conflicts, I switched the main branch to 0.9.0.post6.

And it will be great if you resolve conflicts, I switched the main branch to 0.9.0.post6.

@kasuteru any updates here? we think of including this PR in the upcoming release, your help will be very appreciated :)

Sorry for the delay. I will try to fix this until Monday.

I found some time to do it right away. I fixed the conflicts and merge error, checks seem to pass now. Let me know if anything else is needed.


feature/3 0 4

OAS 3.0.4 is on the almost here! https://github.com/OAI/OpenAPI-Specification/milestone/16
This PR:

bumps the emitted version when serializing OAS descriptions.
ajusts how types are handled for integer since it's technically not a valid type.

Holding until the version officially comes out.

depends on https://github.com/OAI/OpenAPI-Specification/pull/4080


Update rd-teams.md

@jaydeland, you'll also want to update the core committers, I think: see https://github.com/mattermost/mattermost-developer-documentation/pull/462 for an example.

@jaydeland, you'll also want to update the core committers, I think: see #462 for an example.

@lieut-data - Looks like somebody already added us to the core committers page.


"Run Python File in Terminal" missing from context menu on initial load

If a module is imported, the option to "Run Python File in Terminal" will not appear in the right-click menu. Accessing or viewing another file that does not have an imported module will cause the "Run Python File in Terminal" option to reappear in the file that has the import. You do not need to right click or run the non-import file - all you need to do is access the file.

Environment data

VS Code version: 1.30.0
Extension version (available under the Extensions sidebar): 2018.12.0
OS and version: macOS 10.13.6
Python version (& distribution if applicable, e.g. Anaconda): 3.7
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
Relevant/affected Python packages and their versions: XXX

Expected behaviour
Right-clicking in code will offer 'Run Python in Terminal'
Actual behaviour
Option is not present if a module is imported.
Steps to reproduce:

New file
Type 'import this' or 'import math'
Save w/ .py
Close editor
Open editor
Option is not present.

Observation:
7. Access a separate file that does not have an import.
8. Go back to import file.
9. Right click - "Run Python in Terminal" is now present.
Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
XXX

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)
XXX

The problem seems to resolve itself if you just navigate away from the file and having an import makes no difference (I can replicate with just 1+2). This might be a bug from VS Code since they pushed their new release just yesterday and I don't think we touched this code since the last release.

This might be a bug from VS Code since they pushed their new release just yesterday and I don't think we touched this code since the last release.

Agreed, we don't do anything here. We merely tell VS Code what commands exist when a Python file is open.

Closing as an upstream bug https://github.com/Microsoft/vscode/issues/65041


Add 'TAG' instruction of Dockerfile.

Signed-off-by: xuxinkun<EMAIL_ADDRESS>

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "buildtag20150504" git@github.com:xuxinkun/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

This will update the existing PR, so DO NOT open a new one.

Replaced by https://github.com/docker/docker/pull/12983


enhancement add exception check in page builder to avoid be oom during flush memtable

Proposed changes
faststring may allocate a lot of memory, should terminate load process when BE is at low memory level.
BE should never OOM.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Add the sort functionality of All Activities.

Add the sort functionality of All Activities.
Test needs to be updated.

Merged.


Support for reset in Z3 solver

Message is null.
Solver was Z3.

We should either implement it, or give a more informative error message (e.g., "Z3 solver does not support reset, please use push/pop"). I started implementing it to see if it works: c4e3ad0a278dfe3c8866d3c6723443448d5e90e0
@as3810t what do you think? It is not as trivial as it might seem. Basically, in the Z3Solver, we have:

com.microsoft.z3.Solver: this has a reset method, we can call it.
Stack<Expr<BoolType>> assertions: we can clear this.
Map<String, Expr<BoolType>> assumptions: we can clear this.
Z3SymbolTable: we can clear this.
Z3TransformationManager: I think we also have to clear caches here, because if the symbol table is cleared, the cached expressions might be invalid. I haven't done this yet, but the simple test works.
Z3TermTransformer: this is the back-transformation, but there does not seem to be any caching so I think we can just leave this.
com.microsoft.z3.Context: I have no idea what to do with this.

Update: in b35c5590c757e76689f2d3ada35fc275792c48c3 I added reset to 2 members of Z3TransformationManager: Z3TypeTransformer and Z3ExprTransformer. As far as I see, Z3DeclTransformer does not need reset.

I was also thinking about completely removing it from the interface, but if it seems to work, we can leave it there for quick prototyping. I added some comments that push/pop should be preferred.

As far I can see, the Solver API in Z3 has a reset method: https://github.com/Z3Prover/z3/blob/master/src/api/java/Solver.java#L105
So it should not be difficult to reset it through z3Solver: https://github.com/ftsrg/theta/blob/c48087ae29b63887edcc2d16482a8925faf55143/subprojects/solver-z3/src/main/java/hu/bme/mit/theta/solver/z3/Z3Solver.java#L57

Is that enough? Because in Z3Solver we have additional stuff, as outlined in my previous comments.

Yes of course, what you described is needed :) My earlier remark was for:

com.microsoft.z3.Context: I have no idea what to do with this.

I see. I'll create a PR then


Henchman should exit based on exit code and not just STDERR.

The shell module is set to an error state if a stderr message is received or if the return code is non zero. It will be changed to exit out only if the return code is a non zero.


Collab rebase fix

Fix for rebase functionality, which seem to read from a property that was always undefined. Also, the version that was returned from the call to getChanges was missing in the callback

Thank you!


Compatibility with PHP 8.2

when i run the script on php 8.2, i get the following error
Deprecated: Creation of dynamic property Securimage::$gdnoisecolor is deprecated.
Could anyone help with this.

@augustusbuckman Can you please add more details ?


ensuring that dependent dll's are not included in the package when us…

…ing include-referenced-projects
as per requested in (https://github.com/fsprojects/Paket/pull/1540).  Separate PR in order to keep the history clean.

I'm having a great deal of trouble running any tests locally at present.  Probably just a work thing.  I'll keep an eye on the build progress.

Is that a relevant failure on Travis?

nope. that's unrelated

@kolektiv @inosik would this still work for you?

I haven't been using this parameter anyways, so I think it should be fine.

ok let's try it and see what happens.


Fix permissions org direct collab check to error when no evidence found

[x] Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1

What
Fix permissions org direct collab check to error when no evidence found.
Why
When no direct collaborator evidence is found by the check, it should error rather than pass with "no issues found" (current behavior).
How
Add logic to raise an EvidenceNotFoundError exception when no evidence is found by the check.
Test

Current functionality preserved when evidence is found
Check errors when no evidence is found

Context
Fixes #61

Fixing this in the framework instead.  See: https://github.com/ComplianceAsCode/auditree-framework/pull/114.  Closing...


are you guys interested in sass css version of this project?

hey guys, are you interested in a sass css version of this project? thank you.

There's no real advantage of either on a project of this size so I'm not too fussed about it to be honest; the CSS is so small, I'd rather not maintain both.


Fixing #1627

Warning
Info
Issues
Fixes #1627

I'm forcing the build to run on this branch to make sure it passes tests.

@davidhabib ready for merge


fix: add .subscribe / async support to wasm client

This picks up where #222 left off implementing Subscribe in the wasm/grpc-gateway client.

This looks much better, thanks for cleaning it up! Just left some nooby questions about Streams


promql: delete redundant return value.

The return value of the method initTime in Head has no reference.
https://github.com/prometheus/prometheus/blob/e6d7cc5fa43716281bdf5d1cf40415f99a0e9623/tsdb/head.go#L896-L898
https://github.com/prometheus/prometheus/blob/e6d7cc5fa43716281bdf5d1cf40415f99a0e9623/tsdb/head.go#L904
The relative PR is https://github.com/prometheus/prometheus/commit/4f037da4620f417c842f53dbf579e2357c43bdd7. The condition is no used in this pr.

Thanks!


Move @types/googlemaps to dependencies

Currently @types/googlemaps are in peerDependencies of @agm/core, but as @agm/core reexports some types from @types/googlemaps they should be in dependencies. See for example official google-map component from angular/components at https://github.com/angular/components/blob/master/src/google-maps/package.json
created from #1869 as it was auto-closed by stale-bot

bump to keep this from closing by stale-bot

bump

bump to keep this from closing by stale-bot

bump to keep this from closing by stale-bot

bump


Starrocks caching strategies seem flawed for regular duplicate queries

Enhancement
We're using Iceberg as a backing store, and looking at Starrocks for compute (i.e. ingestion into iceberg outside of SR, but using a SR external iceberg catalog for read-only compute/query).
It appears that SR is utilizing caching at multiple levels (i.e. at the iceberg level, with metadata caching, and then again with query caching).  This is fine, except........
It also appears that SR has opted for LRU caching at one/both these levels, with no absolute time-based eviction mechanism (i.e. if you keep hitting SR with the same query then the same data is returned, the eviction timer is reset, and the query result is NEVER evicted).
Our use-case is click-stream data, and our users are looking for near-real-time insights into their website traffic (meaning they'll keep trying to refresh their view into their data at short intervals) - think page-refreshing in google analytics.
To simulate this, if we query the catalog at relatively short intervals (say every 15-30 seconds), with something simple like:
SELECT * from <table-name> WHERE <some-conditions>;
then the cached version of the result is NEVER evicted.  Pure LRU caching is generally not a great idea for DB applications unless there's also some way to evict entries after some (configurable) absolute time from when the cached slot is initially populated.
Unfortunately, unless there's a mechanism to override this (without simply turning caching off), then this makes SR a non-starter for ours and a multitude of similar use-cases.
It would be great to see an enhancement to SR's caching that adds absolute-time-based eviction.

can be fixed by https://github.com/StarRocks/starrocks/pull/47948

if your problem is fixed by refresh external table then you are hitting the same problem as me
when SR caches iceberg metadata and no longer refreshes it and you don't see new commits to the data

@eshishki - The query cache seems to work the same way, and I'm presuming that's another independent cache level that exists on top of iceberg metadata caching, meaning just addressing the iceberg metadata cache won't fix the problem by itself (i.e. query cache will need the same treatment).  Also, looking at the Iceberg codebase (Java code at least) - the same problem exists there as well.  Their underlying metadata caching mechanism is identical in nature (i.e. LRU with time from last query eviction - no absolute-time-based eviction)...... so that might need to be addressed as well.
In terms of Starrocks, that's why I opened this enhancement request in addition to your original PR, which I was aware of.

it doesn't matter that you use rest catalog and me using glue catalog, the iceberg caching mechanism gets latest snapshot from catalog, caches it and later have trouble to refresh it.
do you see fresh data after refresh external table?

I'm also wondering if someone like @ss892714028 might weigh in on this?


为什么是videogpt，不应该是dit这种扩散模型吗，videogpt这种是自回归模型吧。

We use Video-VQVAE (although it comes from VideoGPT), which is a auto-encoder model that encodes video from the pixel domain to the latent, and then decodes the latent to the pixel domain.

数据模型有考虑3D Gaussian Splatting方面的应用吗？ 我理解3d在物理规律，视频一致性方面表现良好。如https://github.com/GaussianObject/GaussianObject 4张不同角度的图通过粗糙模型+再加扩散模型修补数据后可成细化的3dgs.

We agree that video created by a powerful generator will be useful for NeRF/3DGS-based 3D content generation. However, we mainly adopt realistic videos for training in the preliminary stage. Synthetic video created by game engines or 3D representations might be concerned in the future.

Is there any public open-source “Synthetic video created by game engines or 3D representations” data or related research works?

Is there any public open-source “Synthetic video created by game engines or 3D representations” data or related research works?

Take it into todo list, we are working for this type dataset.


Add equals/hashcode for Destination

Backlog item: https://github.com/SAP/cloud-sdk-java-backlog/issues/403
Context

A destination can be enhanced with keyStore and trustStore properties; both of Java type KeyStore. Useful in mTLS scenarios or when having a custom root certificate for TLS/SSL.
Java KeyStore API does not offer a custom implementation for equals and hashCode. This is why we exclude it from evaluation in the DefaultHttpDestination class.
We primarily use hashCode to isolate destination-related cache entries, e.g. for resolving stored HttpClient instances.

Currently on main.
Destinations are evaluated as equal with same hash-code:

Trivial case

Destination1(name=foo, staticHeaders={sap-client:100})
Destination2(name=foo, staticHeaders={sap-client:100})

Assigned KeyStore or TrustStore

Destination1(name=foo, staticHeaders={sap-client:100}, keyStore={fizz})
Destination2(name=foo, staticHeaders={sap-client:100})

Assigned KeyStore mixed TrustStore

Destination1(name=foo, staticHeaders={sap-client:100}, keyStore={fizz})
Destination2(name=foo, staticHeaders={sap-client:100}, trustStore={buzz})

With this PR
Destinations are evaluated as equal with same hash-code:

Trivial case

Destination1(name=foo, staticHeaders={sap-client:100})
Destination2(name=foo, staticHeaders={sap-client:100})

~Assigned KeyStore or TrustStore~

~Destination1(name=foo, staticHeaders={sap-client:100}, keyStore={fizz})~
~Destination2(name=foo, staticHeaders={sap-client:100})~

~Assigned KeyStore mixed TrustStore~

~Destination1(name=foo, staticHeaders={sap-client:100}, keyStore={fizz})~
~Destination2(name=foo, staticHeaders={sap-client:100}, trustStore={buzz})~

Limitation
This behavior change only applies to KeyStore instances that have certificate based entries only.
E.g. if a KeyStore with only a secret-key would be added - it will be ignored from equals/hashCode, i.e. the previous behavior of main applies again.

Good find, @CharlesDuboisSAP. I haven't noticed that I removed the alias comparison :/
This was indeed unintended change during my commits.
@MatKuhr is right, the aliases are not important at runtime.
However not comparing them might be add to the confusion 🤔 On the other hand adding new logic now to compare Enumeration<String> aliases  (does not implement equals/hashCode natively) would add unnecessary code complexity and potential edge cases that we don't want to cover explicitly (yet).
Therefore I'll leave it as is.


mat2

It seems that mat2 is using a row-major layout for the matrices while mat3/mat4 are column-major. Is that expected?

@richardwolny Since the PR has been merged, I can close this issue, right?


Some Scripted Policies are Flaky

While manually running the tests, I noticed that some environments have some variance in their average success rate, especially with running scripted policies with gaussian noise.
The variance is never high ~1-5 percent. I suggest that we allow for a tolerance of 5 percent, in order to avoid flaky tests.

Simply lowering the success rate until it's not flaky is a much clearer way of specifying the test. It tells you the minimum success rate given variance.

Will do. Instead of lowering by 5%, we'll lower by by 1% increments

We haven't had any failures recently as far as I know, so I think it's safe to close this


Fail to download. File not Found.

Failed to download even though the file can find with ls.
Maybe this problem began to occur after update within one month.
leus@cygnus:/media/leus/Murooka_1TB/compressed$ gshell ls
gazebo_object_motion_small_manip_10000.tgz
gazebo_object_motion_small_10000_split.tgz
gazebo_object_motion_small_10000.tgz
gazebo_object_motion_scalable_cube_2722.tgz
gazebo_object_motion_cf2_10000.tgz
gazebo_object_motion_10000_split.tgz
gazebo_object_motion_cf_10000.tgz
gazebo_object_motion_f_10000.tgz
gazebo_object_motion_c_10000.tgz
movie
gazebo_object_motion_v_10000.tgz
gazebo_object_motion_70000.tgz
gazebo_object_motion_10000.tgz
gazebo_object_motion_1
gazebo_object_motion_2000_20161025
gazebo_object_motion_2000
gazebo_object_motion_100
leus@cygnus:/media/leus/Murooka_1TB/compressed$ gshell download gazebo_object_motion_small_manip_10000.tgz
Failed to get file: googleapi: Error 404: File not found: None., notFound

find id of the file with web browser, and
gshell download --with-id ****

is working.

What version?
2016年12月27日(火) 11:37 Masaki Murooka<EMAIL_ADDRESS>
find id of the file with web browser, and
gshell download --with-id ****
is working.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/wkentaro/gshell/issues/9#issuecomment-269260337, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEHFk4iiUWq_b0X_vAlRtxidvetTOXJNks5rMHnlgaJpZM4LV_Kk
.

leus@murooka-dlbox:~$ gshell --version
gshell, version 5.0.1

I reproduced that symptom. Maybe caused by the long name. fixing...

Should be fixed now by #10.

Thank you!


Json: cannot unmarshal string into Go struct field ChangesWithLineNums.changes of type []*shared.StreamedChangeWithLineNums

Getting this any time I try to do a plandex tell:
🚨 Server error
  → Error unmarshalling build response
    → Json: cannot unmarshal string into Go struct field ChangesWithLineNums.changes of type []*shared.StreamedChangeWithLineNums

It gets through the planning process, starts making changes, and then at some point while/shortly after making changes, it gives this error.
I'm using openrouter with anthropic-claude-3.5-sonnet.

Just switched to gpt-4o-latest and didn't get the error, so it might have to do with model selection.

This error means that the model couldn’t generate valid JSON for a function call despite multiple retries. Unfortunately Claude Sonnet, despite its generally impressive capabilities, still has this issue quite frequently.
For now I’d recommend using the built-in mixed Claude/OpenAI model pack (anthropic-claude-3.5-sonnet-gpt-4o that uses Claude for planning and summaries, and gpt-4o for everything else. This gives you the benefits of sonnet’s reasoning and coding abilities plus the better function calling reliability of the OpenAI models.

OK good to know, thanks!


Sc-4760 : Make phone number required for legal/compliance contact

Scope of changes
Sc-4760 : Make phone number required for legal/compliance contact
Type of change

[ ] bug fix
[ ] new feature
[ ] documentation
[x] other (describe)

Acceptance criteria

Author checklist

[x] I have manually tested the change and/or added automation in the form of unit tests or integration tests
[ ]  I have updated the dependencies list
[ ]  I have recompiled and included new protocol buffers to reflect changes I made
[x]  I have added new test fixtures as needed to support added tests
[x]   Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
[ ]  I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

[ ] Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Codecov Report

Merging #553 (4656c03) into main (f574083) will increase coverage by 7.71%.
The diff coverage is 100.00%.

:exclamation: Current head 4656c03 differs from pull request most recent head 940c91b. Consider uploading reports for the commit 940c91b to get more accurate results

@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
+ Coverage   37.47%   45.18%   +7.71%
==========================================
  Files         152      480     +328
  Lines        2391    13943   +11552
  Branches      608     1085     +477
==========================================
+ Hits          896     6300    +5404
- Misses       1320     6663    +5343
- Partials      175      980     +805

Impacted Files
Coverage Δ

...i/src/components/CertificateReview/TrixoReview.tsx
77.77% <ø> (ø)

...ules/dashboard/certificate/lib/validationSchema.ts
64.86% <ø> (ø)

...b/gds-user-ui/src/components/ContactForm/index.tsx
92.30% <100.00%> (ø)

web/gds-user-ui/src/components/NotFound/index.tsx
0.00% <0.00%> (ø)

...ds-user-ui/src/components/CustomerNumber/index.tsx
0.00% <0.00%> (ø)

...-ui/src/components/ui/PhoneNumberInput.stories.tsx
0.00% <0.00%> (ø)

...-ui/src/components/CountryOfRegistration/index.tsx
85.71% <0.00%> (ø)

...i/src/modules/auth/register/register.validation.ts
100.00% <0.00%> (ø)

web/gds-user-ui/src/hoc/withRHF.tsx
0.00% <0.00%> (ø)

.../github.com/trisacrypto/directory/pkg/trtl/util.go
0.00% <0.00%> (ø)

... and 321 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f574083...940c91b. Read the comment docs.


Extend and ehance caching, add profiling

Caching enhancements:

Cache read values on get
Cache the absence of a value when it is deleted/replaced
On write, check cache to see if the type/value pair already exists in the database before writing
Similar optimizations for replace, delete

Add opt-in profiling.  This can be used to see where an app is spending its time when using Vessel.
Add ability to pre-load all Vessel data into the cache.  This can have significant performance improvements depending on data access patterns (see profiling, above).
In general, many random reads are slower than one large read up-front. Re-writing the same data is also slower than reading everything up-front and using caching to elide unnecessary writes.
Update Robolectric dependency to 4.7 so that it works on Arm Macs (https://github.com/robolectric/robolectric/issues/6311)
Note that the caching is still not atomic with respect to the database operations.  This matches the existing implementation, and to limit scope this will be addressed in a follow-up PR.

Overall im ok with these changes. However I do have concerns around unchecked memory usage by loading the entire database at once. I dont see our internal use of vessel shrinking anytime soon and we would need some way to make sure reading everything at once doesnt spin out of control into another memory useage/db usage problem.

Good point.
Current numbers are something like 16ms for a full load, on a low-end UMX phone, which currently saves about 10x the I/O time at startup by avoiding unnecessary reads/writes to disk.
So while I think we have a fair amount of headroom (for our current use case), I'm open to discussing how we can monitor this.  I have some ideas and I'm curious on your thoughts - let's sync offline.

Looks good to me and replacing our app's Vessel dependency with this branch works fine.
I threw in a preloadBlocking() call right after we instantiate Vessel and didn't notice any issues on startup. I also dumped the profile summary into logs at a few places — pretty neat!

That's exactly what I did!  Saw a pretty big speedup in some cases


[W-8857319] - Remove hardcoded strings

Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata
Definition of Done
Refer to Definition of Done to see any additional details for the items below:

[ ] Any net new LWC work has JEST test coverage 50% or above
[ ] Default Sa11y tests pass for all LWC components
[ ] 🔒 Secure both Front-end (LWC) & back-end (Apex) as necessary
[ ] 🔑 Grant users access in Permission Sets (Object, Field, Apex Class) as necessary
[ ] Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name
[ ] Make sure that ACs are updated (if any gaps)
[ ] All acceptance criteria have been met

[ ] Developer
[ ] Code Reviewer

[ ] Pull Request contains draft release notes
[ ] Labels, help text, and customer facing messages are reviewed by Docs
[ ] QE story level testing completed

W-8857319

@sella24 , if this change looks good to pass the string label audit, can you merge this into the parent branch?
cc: @jdavilasf


i14 remember settings state

Remember the collapsed/expanded state of all groups individually for steps so they can be restored upon selecting the same step again.
Based on #31
Closes #22 and #14

I have added a commit to fix a minor bug. What do you think?

Looks good, cant approve though cause i am the author


Android Release v7.3.1

Ticket: https://new-relic.atlassian.net/browse/NR-260056
What's changed:

Bug fixes, see ticket for details

Testing:

Testing
Documentations

As discussed, please evaluate the current supported AGP and Gradle versions in BuildHelper.groovy (in the plugin source).


Remove asciinema ext from sphinx

Removed console "videos", which were added with asciinema. Related scripts and support removed.
These videos appeared in two sections: user-guide/fioctl and reference-manual/qemu. In the fioctl section, examples were replaced with code blocks. The qemu examples were not possible to copy over: the scripts which created them were not available, and the content lengthy.
QA steps: checked rendered html locally.
This commit addresses FFTK-2467
Readiness

[x] Merge (pending reviews)
[ ] Merge after date or event
[ ] Draft

Overview
Sphinx needs to be cleaned up and simplified; even if we move away from sphinx, this will help that process.
Checklist
Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."

[x] Run spelling and grammar check, preferably with linter.
[x] Avoid changing any header associated with a link/reference.
[] Step through instructions (or ask someone to do so).
[ ] Review for wordiness
[x] Match tone and style of page/section.
[x] Run make linkcheck.
[x] View HTML in a browser to check rendering.
[x] Use semantic newlines.
[x] follow best practices for commits.

[x] Descriptive title written in the imperative.
[x] Include brief overview of QA steps taken.
[x] Mention any related issues numbers.
[x] End message with sign off/DCO line (-s, --signoff).
[x] Sign commit with your gpg key (-S, --gpg-sign).
[x] Squash commits if needed.

[x] Request PR review by a technical writer and at least one peer.

Comments
The biggest change is removing the qemu demos. In the future, links to video can be considered, but I don't think they are high value as they are.

Docs for f9984ca3599ce7df70acf45c7261f0e6694af65f are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2139/docs/artifacts/html/index.html

nice, thanks for cleaning this up!


topic: following / unfollowing

hey guys,
before implementing this feature, we should discuss it a little bit.
implementing following is kinda easy but you dont wanna end up with 1000 accounts you have to manually unfollow.
so the question here is not the following, but the unfollowing!
what is your idea on how to implement the following / unfollowing feature??
my idea:

creating a small file in the workspace folder which contains all accounts which the bot follows and the date when they get followed
also exporting an rxjs stream with followed accounts for advanced usage
setting an unfollowing after time (for example 3 weeks) in the config file
when starting, read in the followed list and filter out all users which need to be unfollowed
while scrolling the timeline, search for users which need to be unfollowed
simulate a request on their profile
unfollow them
delete them from the list

problem:
how and when to unfollow someone who doesnt post smth in your timeline ?
question: how would you as a user do this in instagram ?
because i wanna simulate all requests that needed to be done to unfollow someone as if you would do it in the normal app.

if i know who i want to unfollow, i usually look for them through the explore page, click them and remove them

I also believe the explore page (search bar) would be more viable than having the bot scroll the timeline, especially since followed users would all post at different frequencies. If it can grab the name from the list, paste it in the search bar, select the correct user then unfollow from there that would be ideal

I unfollow people who dont follow me back after 3-4 days and sometimes i unfollow people like this:

Go to my followers
Click on profiles without stories (sinc they arem ore likely to be inactive)
See when the account had its last post
If its over a threshold date, unfollow.

Its not so efficient, but it gets me nice amount of inactive people to unfollow.

Hi @breuerfelix, congrats for this new project, and thank you!
On Instapy, I was unfollowing non-mutal followers after 3 days and mutual after 4 days, excluding users that have liked one of my last 3 posts. It was also excluding a given list of friends with who the bot should never interract ; no likes and no unfollow.
Do you think something like this could be possible?

FYI, I only unfollow non-followers. If they don't follow me, I don't want to follow them. That's an MVP for me.

I think the best solution is to automatic unfollow users who didnt follow me after N days. Put it to the config please. Another option should be "unfollow everybody" (even those who follow me).
And it would be nice if you will put all followings to the file.
Also, it would be nice if you can implement some mysql driver connection, for those who collect followings to the MYSQL db. It will be perfect.

@apaticmusic well i wont be integrating mysql right from the start. i will just insert the followed people as json format into a file in the workspace.
but i will fire an event so that you are able to subscribe to this event in the advanced configuration and insert them in a mysql database just as you wish :)
that way everybody will be happy because some people want sql some want mongodb ... it would be dumb to create drivers for every single database :D so the best option i see here is providing hooks in the first step :) if some people (like you) programmed some good mysql integration with the help of these hooks, we can see if we will be integrating it into the lib itself. but in the first step i wanna keep it as basic as i can but provide as much functionality as possible with the advanced configuration :)
hope this seems fair to you

here's what I used to do on InstaPy:

Follow a bunch of people.
Ensure they engage in my last 2 posts like leave a comment or like the post.
If they don't engage then unfollow them after 96 hours.

I like your idea. You can check if the user posts stuff before following him. After this you can fallback to something like: every rand(5, 10 days) go through following list and unfollow users that you have been following for more than rand(x, y days) and have not been posting or meet a specific criteria

I usually make this fair more simple:

Go to my following list
Order by oldest
Skip a list of users that i don't want to unfollow
Skip a list of users that had interacted with me (likes, comments, dm, etc) within last few days
Start unfollowing untill i have the pre-determined number of unfollows.

Hope it helps.

The most awaited feature! :)


Bean renderer: Use content-driven configuration

NEBA's velocity support for rendering arbitrary objects allows configuring renderers via the NEBA bean renderer factory configuration (http://neba.io/userguide.html#using-velocity). In a multi-tenant scenario, this thus forms a central piece of configuration, which means potential conflict between non-hierarchical tenants. This conflict can be resolved by defining a content location (e.g., /etc/neba/config/beanrenderer) below which arbitary configurations can be defined, e.g. nt:unstructured nodes defining the key / value pairs that otherwise have to be specified in the felix console.

Won't fix: We intend to drop velocity support in 4.0.0. The corresponding implemenetation is thus not worth enhancing - this might only encourage user to adapt deprecated technology.


⚠ WSINGRESOS - OXXO has degraded performance

In f6e1618, WSINGRESOS - OXXO (https://srvshyweb.yucatan.gob.mx/cgi-bin/wspd_cgi.sh/WService=wsingresos/internet/compartido/wspagosoxxo.r) experienced degraded performance:

HTTP code: 200
Response time: 2383 ms

Resolved: WSINGRESOS - OXXO performance has improved in 4b717c2 after 1 hour, 2 minutes.


Widget problems because of long component names

With component names of RobotFramework AIO the graphics are scaled very unfavorable.
Long component names exceed available widget space.
Long component names influence the positions of frames: Widgets are cut because of moved frames.
TestResultWebApp.pdf

There is no way to display long names. This takes only space for graphics away.
Instead we need a mapping (with our mapping file) of component-names to short-names.

Closed. Mapping table is used to aggregate components and to use short names.


oidc-client-ts with apple provider

Does oidc-client-ts support login with apple? I have configured to use it with Apple but I get CORS error while invoking token endpoint.

OAuth and OIDC are standard independent of your OS. The browser however must have support for some features. I see no reason why Apples webkit should not be functional.
CORS error usually mean a configuration error on the server side of your application. You typically must configure your application uri and redirect uri to an allow list...

Sorry, I wrote it wrongly. My question is whether oidc-client-ts supports login to Apple Identity provider.  I got the CORS error when the oidc-client-ts invoked the token end point.

This issue (question) staled some time ago, closing it for now.


Batches with only 1 request

Describe the bug
I wrote a Python client script to submit multiple requests in a single batch to the migraphx worker, using the method inferAsyncOrdered() but the worker received multiple batches each containing 1 request, even when the request timeout was set to a very loose limit of 10 seconds or more.  Investigation showed the method  Batch::addRequest() was always called from the same thread, apparently making it impossible for concurrent requests to be added to the same batch before the batcher cycled on to the next batch.
I need working multi-request batches in order to develop/test the migraphx worker feature that processes them.
To Reproduce
Steps to reproduce the behavior:

Run a Proteus Docker container built from forked branch https://github.com/bpickrel/inference-server/tree/Yolo_bert_models_without_history
Run the following commands from Proteus prompt:

proteus build --debug
pip3 install Pillow
pip3 install scipy
pip3 install onnxruntime
# tokenizers v0.13.0 won't build
pip3 install tokenizers==0.12.1

Get the data and utility scripts for the Bert-squad10 model from the Migraphx repository.
Start the Inference Server in gdb.
Run the attached script

migraphx_bert.py.txt
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
OS/Versions:
Provide any relevant tools/system information (version, compiler, OS etc.)
Additional context
Add any other context about the problem here.

I didn't try your specific instructions but I was unable to reproduce this using a simpler test. Could you test it instead and see what you get? In the dev container:
git checkout main
# add an arbitrarily long batcher timeout to guarantee batching
sed -i '79i \    parameters.put("timeout", 10000)' ./examples/python/pt_zendnn.py
# run the example
python3 ./examples/python/pt_zendnn.py

This example is also using inferAsyncOrdered() and my server.log for this example shows that it's batching to 32.

I believe this issue has been resolved. Closing for now but please raise a new issue if you see it again


DO NOT MERGE - Use Next.js 15 in Dashboard

Problem solved
Short description of the bug fixed or feature added

PR-Codex overview
This PR focuses on enhancing the handling of dynamic imports and asynchronous parameters across various components in the application. It ensures that cookie retrieval and parameter handling are done asynchronously, improving the overall performance and reliability of the code.
Detailed summary

Updated dynamic imports to return default exports for List and ShareFreeWalletsModal.
Changed params type from { team_slug: string } to Promise<{ team_slug: string }> in several components.
Ensured cookies() is awaited in various API routes and components.
Adjusted return statements in components to handle asynchronous data properly.
Modified UI components to wrap JSX elements in parentheses for consistency.

The following files were skipped due to too many changes: apps/dashboard/src/components/contract-components/contract-table-v2/index.tsx, apps/dashboard/src/app/(dashboard)/contracts/deploy/[compiler_uri]/page.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/components/table.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/token-id.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/(marketplace)/components/marketplace-table.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/(chainPage)/layout.tsx, apps/dashboard/src/app/(dashboard)/dashboard/connect/account-abstraction/[clientId]/page.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/page.tsx, apps/dashboard/package.json, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/components/airdrop-upload.tsx, apps/dashboard/src/app/(dashboard)/(chain)/chainlist/page.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/_components/claim-conditions/snapshot-upload.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/(chainPage)/popular/page.tsx, apps/dashboard/src/app/(dashboard)/published-contract/[publisher]/[contract_id]/page.tsx, apps/dashboard/src/app/(dashboard)/published-contract/[publisher]/[contract_id]/utils/publishedContractOGImageTemplate.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/tokens/components/airdrop-upload-erc20.tsx, apps/dashboard/src/components/engine/overview/create-backend-wallet-button.tsx, packages/thirdweb/src/react/web/ui/components/QRCode/QRCodeRenderer.tsx, apps/dashboard/src/app/(dashboard)/(chain)/chainlist/[chain_type]/page.tsx, pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#5131  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on  Graphite


Fix Opinionspeople uniques

The latest update deprecated and rendered nonfunctional the old uniques that were being used, rendering the Reactorland Great General replacement utterly worthless outside of combat.

Did it for you. Thanks, will add you to the thank you section.


[Bug] Table Image doesn't scale on expanding row size

Description
When we increase the row size of the table, the image size doesn't scale. Ideally, the image should also get bigger based on the row size.
Steps to reproduce the behaviour:
Add steps to reproduce this behaviour, include console / network logs & screenshots

Create a table and populate it with data that has an image URL
Increase the row size of the table
The size of the image remains the same

Important Details

Version: Cloud / Self-Hosted
OS: e.g.MacOSX
Browser: Firefox

To clarify, this should be a property of the image widget whether to center, fit or repeat it's image

@Nikhil-Nandagopal But this is not an image widget inside the table. It's just a property of the column. Ideally, the size of the image inside the cell should increase & decrease according to the row height.

@mohanarpit sorry my bad the image confused me with an image widget. Missed that it's inside the table

Reopening the issue as the image does not get expanded on expanding the row size


Remove packagesByNameWithVersionsFromBeforePreModeIfInPreMode and releasesFromUnfilteredChangesets

cc @mitchellhamilton 😱
it's super weird because I would totally expect for tests added here to fail: https://github.com/atlassian/changesets/pull/263 , need to investigate why they pass

This simplifies the code quite a bit and makes it easier to understand overall. There is only a small behavior change for @changesets/assemble-release-plan which after discussing with @mitchellhamilton is acceptable if we make this a major bump.


Documentation for spica_top.json / .top to .pdb ?

(1) Where can i find documentation for what CHL1, ASM, LSM, BSM, BENA, ... are in spica_top.json  ? Some of them can be seen at https://www.spica-ff.org/forcefield.html but i cant find anything else at the spica-ff.org website or the journal publications even in supplementary materials.
(2) Also in lipid tutorial, it says to use a PDB file for lipids in Packmol but only .top files are available (except for the only one 1DOPC.pdb). I dont see a top2pdb.py script in spica-tools. Should i write one to contribute ?

Initial configuration of a DOPC bilayer using packmol
Packmol is a tool to place molecules in a simulation box with a desired geometry such as lipid bilayer and vesicle. A molecular structure of a single molecule should be given as an input. In this example, we make a DOPC bilayer in aqueous solution, for which we prepare the PDB files for a single DOPC molecule and a single CG water particle. A sample input script for packmol is attached here, which generate a membrane of 128 DOPC with 1300 water particles.

@alphataubio
Thank you for your trying spica-tools and the lipid tutorial.
(1) We are sorry for not mentioning what those residue names correspond to.
"CHL1" corresponds to an normal cholesterol molecule whose resname comes from an atomistic force field, CHARMM.
"*SM"s are sphingomyelin molecules and the prefix of the resnames shows the length of the tail chain connecting to the amide bond of the molecules.
For "BENA", it might be a fatty acid used before SPICA was called SDK but not available with the current SPICA. So I should have removed it from the json.
I will arrange the json file add some information so that users can understand what the molecules are, and try to remove the unavailable molecules from it.
(2) Unfortunately, we do not have any tools to generate PDB files from .top files.
As you know for .top files, all information in the files are in the json file so it is easy to extract one molecule information for generating them.
For now, CG PDBs in SPICA simulations are always prepared through "cg_spica map2cg", namely, AA-to-CG mapping.
It would be useful if we have some PDB libraries for single molecules (typical lipids) and a tool to get their PDB files on a console (e.g. "cg_spica top2pdb").
As I am almost the only developer of this spica-tools and cannot devote enough time to its development, such contribution in support of SPICA are welcome .

im trying to create a spica 400nm spherical lipid bilayer system using PACKMOL with cholesterol 60%, SM 20%, cardiolipin 16%, PC 3% and PG 1%.
was it you or someone else that created the lipid tutorial ? do you know how the file 1DOPC.pdb was created ?
https://www.spica-ff.org/tutorial_lipid/packmol/1DOPC.pdb

@alphataubio
S. Seo, an author of the SPICA FF paper, initially created the tutorial.
I guess he prepared an atomic DOPC lipid bilayer system with CHARMM-GUI first.
Then he extracted a single DOPC lipid from the bilayer PDB file and mapped it to the SPICA coarse-grain level.
When generating such single CG lipid pdb for PACKMOL, we basically use CHARMM-GUI for obtaining AA lipid PDB, having a good molecular shape to form bilayer structure, to be mapped to CG.
Or use Jmol, Discovery Studio if CHARMM-GUI does not have the lipid we want to simulate.

I had two problems:

When I use the “ENM” command, I get a fig1 error. How can I fix this?
I found a problem when I use Small Molecule Protein (PDB ID:2k8x), there seems to be a problem with the topology file generated by the “ENM” command. The generated topology file seems to generate key information that should not be there. see fig2

Has anyone else encountered this problem? What is the solution?

These problems have nothing with the documentation for spica_top.json.
So please open another issue to separate the problems after checking my first answers.

Could you share your input files used in the ENM command with us? Finding out the problem from the command-line without any inputs is a bit difficult for me.
Please apply the ENM command for a single protein structure in PDB format prepared by separating each of the peptides (chain A and B) from the original PDB file. The last paragraph at https://www.spica-ff.org/tutorial_protein2.html can be related to what you find.


Update identifier example type

This change updates the example definition for the Identifier datatype to use a String type, rather than URI. This should address an issue that we're facing when creating profiles on top of this definition:
StructureDefinition.snapshot.element[16].example.valueUri,message=URI values cannot have whitespace
I'm sure there are other changes that I'm missing, happy to expand the PR to address them.
Thanks for the excellent work!

Hi Nick,
Thanks for the PR- merging it now.


fix(lru-cache, memory, mongodb, redis): return falsy values when set in storage

🔗 Linked issue

no related issue, just created fix when discovered it

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

I have noticed, that values resolved as Falsy were returned as null.
This PR is adding test for the driver to check if it returns values like 0 or false and not null and replaced some of the drivers that were returning incorrect results.
As the result null is returned only when:

there is no value in storage
value in storage is null
value in storage is undefined

cheers :)
📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

thanks, @pi0, I updated the missing snapshot which was skipped locally :)
After you'll merge this one I'll resolve the conflict in #321 and prepare it for merging as well!

hey @pi0  could we merge this? If something's missing just let me know :)

Sorry for delay. CI seemd to be failing i guess should be fixed now i will include this next minor version 👍🏼


Enroll for a TLS Server Authentication Certificate Additional Information Needed

The 'Enroll for a TLS Server Authentication Certificate' section is missing critical information.
There is only a brief mention of 'enterpriseregistration.contoso.com' which is critical for ADFS Device Registration. This needs to be touched on way more in the documentation, it was a stumbling block for me in the beginning.
Secondly, there is absolutely no mention of 'certauth.fs.contoso.com' as a Subject Alternative Name which is something the ADFS configuration during setup looks for. This needs to be touched on in the documentation.
It needs to be said that 'Subject Name' can be a wildcard, along with including a wildcard 'Subject Alternative Name'.
It should also be noted that 'certauth.fs.contoso.com' and 'enterpriseregistration.contoso.com' need to be explicitly defined as Subject Alternative Names even if a wildcard is present or the configuration will complain and throw a warning.
Finally it needs to be mentioned that BEFORE moving into the next step in the server configuration wizard the user needs to open up DNS and create their A records and CNAME records. It needs to be explicitly stated that the 'fs.contoso.com' HAS to be an A record, it CANNOT be a CNAME...
I think that about covers it...
Oh yes.. This section:

You can; however, issue one certificate for all hosts in the farm. If you chose this option, then leave the subject name blank, and include all the names in the subject alternate name when creating the certificate request. All names should include the FQDN of each host in the farm and the federation service name.

What?? Optionally use the same certificate across all hosts in your farm? How do all my hosts automatically renew the same certificate from my AD Certificate Authority? Do I need to manually copy the certificate to all hosts when the cert is renewed? That sucks.. What about the other option? The wording/verbiage implies that there is an alternate method of using a separate certificate for each individual host, this sounds a lot better since certs can automatically renew from AD CS. Why does the documentation mention nothing of how to set this up???

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b063e00b-84e5-9da7-2229-e0e24da3b877
Version Independent ID: da9f4867-2aa3-aefa-1603-ddb2ab1ed624
Content: Prepare and Deploy Windows AD FS certificate trust (Windows Hello for Business) - Windows security
Content Source: windows/security/identity-protection/hello-for-business/hello-cert-trust-adfs.md
Product: m365-security
GitHub Login: @mapalko
Microsoft Alias: mapalko

@paolomatarazzo Please help us in resolving this issue. Thanks

Thank you for the feedback @kklouzal. I made some changes to the documentation to address these asks.


[Godot 4] The editor crashes when reloading any project or closing the editor

Godot version
v4.0.alpha.mono.custom_build (f805ecf)
System information
Windows11, Vulkan, NVIDIA GT 1050 Ti
Issue description
Here is the log.

Steps to reproduce

Open any project.
close the editor or reload project.

Minimal reproduction project
(No need)

The backtrace is unfortunately not useful, as it was generated from a build that doesn't contain debug symbols. Try building the editor from source with MSVC (not MinGW) to get an useful crash backtrace.


[objc][generator] Update type/pointer spacing to follow ObjC conventions

The convention is that there's a space between the type and the pointer character (*) in Objective-C.
See: https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/NamingMethods.html#//apple_ref/doc/uid/20001282-BCIGIJJF
Note: Apple's frameworks are using this convention too.

Build failed

Build and tests passed.


Undefined Behaviour: Integer overflow on Sequence increment

Disruptor/EventPoller.h:57:37: runtime error: signed integer overflow:<PHONE_NUMBER>854775807 + 1 cannot be represented in type 'long
Java guarantees deterministic overflow behavior for signed integers but C++ doesn't resulting in undefined behaviour in various locations throughout the code - the above is only one example.

Hello,
You are right, signed integer overflow is undefined behavior in C++.
However, I'm curious about Java and the JLS, does it guarantee a 2-complement representation for signed integers, thus shifting the sign bit when overflowing ?

I'm not a jls expert so I can't see anything in the standard that
explicitly states what happens. However, everything I can find on
stackoverflow etc. states that java gaurantees to wrap around to the
minimum value.
On Tue, 11 Aug 2020, 6:06 pm Mathieu Stefani<EMAIL_ADDRESS>wrote:

Hello,
You are right, signed integer overflow is undefined behavior in C++.
However, I'm curious about Java and the JLS, does it guarantee a
2-complement representation for signed integers, thus shifting the sign bit
when overflowing ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Abc-Arbitrage/Disruptor-cpp/issues/11#issuecomment-671967993,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AL5LS3GX764Z5PUG4X6RANTSAFF57ANCNFSM4PZDASSQ
.


Allow chaining of any http.Handler, not just http.HandlerFunc.

This allows router chaining, which had been mentioned in the README. HandlerFunc implements the Handler interface, so no existing code will break, but this allows for greater flexibility.

I slightly modified the commit: 70708e46004c7bcb09b70e685a8b74a690135387

Good catch on the NotFound handler – thanks for merging this in!

And thanks for the PR!


use Syntax highlighting in nextjs

sorry,I don't know, Where are SyntaxHighlighter  from,How do  SyntaxHighlighter  know my language.
this is js code

this is vuecode

Can you provide the Syntax highlighting in nextjs demo?
Many thanks!!!!😭😭😭

https://www.npmjs.com/package/react-syntax-highlighter


Cannot start OracleDB image

Hi,
I have create a docker image for Oracle DB <IP_ADDRESS> EE.
When I run the following command
docker run \
-p 1521:1521 -p 5500:5500 \
-e ORACLE_SID=sequelize \
-e ORACLE_PDB=test_sequelize \
-v /home/kimgit/oracle:/opt/oracle/oradata \
oracle/database:<IP_ADDRESS>-ee

I got the following logs :
ORACLE AUTO GENERATED PASSWORD FOR SYS, SYSTEM AND PDBAMIN: LuZvF9abF3U=1

LSNRCTL for Linux: Version <IP_ADDRESS>.0 - Production on 30-DEC-2016 09:51:28

Copyright (c) 1991, 2014, Oracle.  All rights reserved.

Starting /opt/oracle/product/<IP_ADDRESS>/dbhome_1/bin/tnslsnr: please wait...

TNSLSNR for Linux: Version <IP_ADDRESS>.0 - Production
System parameter file is /opt/oracle/product/<IP_ADDRESS>/dbhome_1/network/admin/listener.ora
Log messages written to /opt/oracle/diag/tnslsnr/e786bd61093f/listener/alert/log.xml
Listening on: (DESCRIPTION=(ADDRESS=(PROTOCOL=ipc)(KEY=EXTPROC1)))
Listening on: (DESCRIPTION=(ADDRESS=(PROTOCOL=tcp)(HOST=<IP_ADDRESS>)(PORT=1521)))

Connecting to (DESCRIPTION=(ADDRESS=(PROTOCOL=IPC)(KEY=EXTPROC1)))
STATUS of the LISTENER
------------------------
Alias                     LISTENER
Version                   TNSLSNR for Linux: Version <IP_ADDRESS>.0 - Production
Start Date                30-DEC-2016 09:51:28
Uptime                    0 days 0 hr. 0 min. 0 sec
Trace Level               off
Security                  ON: Local OS Authentication
SNMP                      OFF
Listener Parameter File   /opt/oracle/product/<IP_ADDRESS>/dbhome_1/network/admin/listener.ora
Listener Log File         /opt/oracle/diag/tnslsnr/e786bd61093f/listener/alert/log.xml
Listening Endpoints Summary...
  (DESCRIPTION=(ADDRESS=(PROTOCOL=ipc)(KEY=EXTPROC1)))
  (DESCRIPTION=(ADDRESS=(PROTOCOL=tcp)(HOST=<IP_ADDRESS>)(PORT=1521)))
The listener supports no services
The command completed successfully
Look at the log file "/opt/oracle/cfgtoollogs/dbca/test_seq.log" for further details.
cat: /opt/oracle/cfgtoollogs/dbca/test_sequelize/test_sequelize.log: No such file or directory
cat: /opt/oracle/cfgtoollogs/dbca/test_sequelize.log: No such file or directory

SQL*Plus: Release <IP_ADDRESS>.0 Production on Fri Dec 30 09:51:44 2016

Copyright (c) 1982, 2014, Oracle.  All rights reserved.

Connected to an idle instance.

SQL>    ALTER SYSTEM SET control_files='/opt/oracle/oradata/test_sequelize/control01.ctl' scope=spfile
*
ERROR at line 1:
ORA-01034: ORACLE not available
Process ID: 0
Session ID: 0 Serial number: 0

SQL>    ALTER PLUGGABLE DATABASE test_sequelize SAVE STATE
*
ERROR at line 1:
ORA-01034: ORACLE not available
Process ID: 0
Session ID: 0 Serial number: 0

SQL> Disconnected
mv: cannot stat '/opt/oracle/product/<IP_ADDRESS>/dbhome_1/dbs/spfiletest_sequelize.ora': No such file or directory
mv: cannot stat '/opt/oracle/product/<IP_ADDRESS>/dbhome_1/dbs/orapwtest_sequelize': No such file or directory
#########################
DATABASE IS READY TO USE!
#########################
tail: cannot open '/opt/oracle/diag/rdbms/*/*/trace/alert*.log' for reading: No such file or directory
tail: no files remaining

And the container is down.
After some researches, i defined the ORACLE_HOME to : /opt/oracle/product/<IP_ADDRESS>/dbhome_1
Now I have the following :
ORACLE AUTO GENERATED PASSWORD FOR SYS, SYSTEM AND PDBAMIN: wJ8UFdnvhZE=1

LSNRCTL for Linux: Version <IP_ADDRESS>.0 - Production on 30-DEC-2016 10:03:01

Copyright (c) 1991, 2014, Oracle.  All rights reserved.

Starting /opt/oracle/product/<IP_ADDRESS>/dbhome_1/bin/tnslsnr: please wait...

TNSLSNR for Linux: Version <IP_ADDRESS>.0 - Production
System parameter file is /opt/oracle/product/<IP_ADDRESS>/dbhome_1/network/admin/listener.ora
Log messages written to /opt/oracle/diag/tnslsnr/b5176ab3d961/listener/alert/log.xml
Listening on: (DESCRIPTION=(ADDRESS=(PROTOCOL=ipc)(KEY=EXTPROC1)))
Listening on: (DESCRIPTION=(ADDRESS=(PROTOCOL=tcp)(HOST=<IP_ADDRESS>)(PORT=1521)))

Connecting to (DESCRIPTION=(ADDRESS=(PROTOCOL=IPC)(KEY=EXTPROC1)))
STATUS of the LISTENER
------------------------
Alias                     LISTENER
Version                   TNSLSNR for Linux: Version <IP_ADDRESS>.0 - Production
Start Date                30-DEC-2016 10:03:01
Uptime                    0 days 0 hr. 0 min. 0 sec
Trace Level               off
Security                  ON: Local OS Authentication
SNMP                      OFF
Listener Parameter File   /opt/oracle/product/<IP_ADDRESS>/dbhome_1/network/admin/listener.ora
Listener Log File         /opt/oracle/diag/tnslsnr/b5176ab3d961/listener/alert/log.xml
Listening Endpoints Summary...
  (DESCRIPTION=(ADDRESS=(PROTOCOL=ipc)(KEY=EXTPROC1)))
  (DESCRIPTION=(ADDRESS=(PROTOCOL=tcp)(HOST=<IP_ADDRESS>)(PORT=1521)))
The listener supports no services
The command completed successfully
Copying database files
1% complete
DBCA Operation failed.
Look at the log file "/opt/oracle/cfgtoollogs/dbca/sequelize/sequeliz.log" for further details.
cat: /opt/oracle/cfgtoollogs/dbca/sequelize/sequelize.log: No such file or directory
cat: /opt/oracle/cfgtoollogs/dbca/sequelize.log: No such file or directory

SQL*Plus: Release <IP_ADDRESS>.0 Production on Fri Dec 30 10:03:41 2016

Copyright (c) 1982, 2014, Oracle.  All rights reserved.

Connected to an idle instance.

SQL>    ALTER SYSTEM SET control_files='/opt/oracle/oradata/sequelize/control01.ctl' scope=spfile
*
ERROR at line 1:
ORA-01034: ORACLE not available
Process ID: 0
Session ID: 0 Serial number: 0

SQL>    ALTER PLUGGABLE DATABASE test_sequelize SAVE STATE
*
ERROR at line 1:
ORA-01034: ORACLE not available
Process ID: 0
Session ID: 0 Serial number: 0

SQL> Disconnected
mv: cannot stat '/opt/oracle/product/<IP_ADDRESS>/dbhome_1/dbs/spfilesequelize.ora': No such file or directory
mv: cannot stat '/opt/oracle/product/<IP_ADDRESS>/dbhome_1/dbs/orapwsequelize': No such file or directory
#########################
DATABASE IS READY TO USE!
#########################
PMON (ospid: 143): terminating the instance due to error 12752
Fri Dec 30 10:03:31 2016
System state dump requested by (instance=1, osid=143 (PMON)), summary=[abnormal instance termination].
System State dumped to trace file /opt/oracle/diag/rdbms/sequelize/sequelize/trace/sequelize_diag_157_20161230100331.trc
Fri Dec 30 10:03:32 2016
Dumping diagnostic data in directory=[cdmp_20161230100331], requested by (instance=1, osid=143 (PMON)), summary=[abnormal instance termination].
Fri Dec 30 10:03:32 2016
ORA-1092 : opitsk aborting process
Fri Dec 30 10:03:32 2016
Instance terminated by PMON, pid = 143

The container is now running.
But when I try to connect with SqlPlus I get :  ORA-12162: TNS:net service name is incorrectly specified
And I can't connect with sqldeveloper on the DB ORA-12505 TNS:listener does not currently know of SID given in connect descriptor

Your database is not created correctly during the startup of the container as indicated by:

The command completed successfully
Copying database files
1% complete
DBCA Operation failed.
Look at the log file "/opt/oracle/cfgtoollogs/dbca/sequelize/sequeliz.log" for further details.

Does the container start successfully if you omit the following and use the default?

-e ORACLE_SID=sequelize
-e ORACLE_PDB=test_sequelize \

After reinstalling / pulling everything and without the -e parameters, it works.

I think the error is related to the length of the ORACLE_SID, in your example it exceeded 8 bytes which would work if those first 8 bytes would be unique. I'll do additional testing and see whether I'm right and if so whether I can add a check to prevent this.

I leave this open for now for tracking purposes.

Ok, the error is actually the _ of the ORACLE_SID. The first 12 characters of the ORACLE_SID must be alphanumeric. I've added a check that will only allow alphanumeric characters for the ORACLE_SID

Fixed.


Add instructions about required "setup" function on cog extensions

As I was getting myself acquainted with cogwatch (and Cogs themselves), unfortunately, I lost quite some time dealing with extension-related errors upon trying to reload a cog file; until finding out I needed to add the following function at the bottom of it:
def setup(bot: commands.Bot):
    '''Add cog every time extension (module) is (re)loaded.'''
    bot.add_cog(MyCog(bot))

However, there is no explicit reference to the Extension concept in cogwatch tutorial, even though discord.py extensions page mentions hot-reloading. Since it seems to be a lower-level concept that many users that arrive here aren't aware of (myself included), I think it might be interesting to add tutorial instructions regarding these points (especially the needed setup function). :slightly_smiling_face:

Thanks for the feedback!
I've added a complete example to the examples directory that should help guide developers unfamiliar with the cog concept in the future!


Add config for trusted networks auth provider

Description:
Add config for trusted networks auth provider.
Breaking changes
It is a breaking changes for user who manual configured trusted network auth provider. An invalid config error will be thrown and HA won't be able to fully started.
It is NOT a breaking changes for user who didn't manual configured trusted network auth provider.
If trusted_networks configured in http component, and no auth_provider configured in core config, http.trusted_networks value will be used for default loaded trusted network auth provider.
Related issue (if applicable): fixes #16149
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8605
Example entry for configuration.yaml (if applicable):
homeassistant:
  auth_providers:
   - type: trusted_networks
     trusted_networks:
      - <IP_ADDRESS>
      - ::1
      - <IP_ADDRESS>/24
      - fd00::/8

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

May I suggest a different syntax now that  this is changed? May not be required, but id like to mention it.
It would be nice to be able to map a range to a user. Also allow X-Forwarded-User header from some ip:s to map to hass user.
So we'd need config options on each ip entry.
Simplest might be to just make it a dict instead of list.

IP / user mapping could be done in separate pull request. I want to keep PR small.
I won't add X-Forwarded-User support, that should be done by another "trusted proxy" auth provider, not trusted networks auth provider

I understand that. But I just meant change config structure to dict instead
of list.
Den lör 16 feb. 2019 18:51 skrev Jason Hu<EMAIL_ADDRESS>
IP / user mapping could be done in separate pull request. I want to keep
PR small.
I won't add X-Forwarded-User support, that should be done by another
"trusted proxy" auth provider, not trusted networks auth provider
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/pull/21111#issuecomment-464366871,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdeoEGZXP-hbVWtWj4r2R_jIutRdaMpks5vOETwgaJpZM4a-zlu
.

@elupus I think it's fine. We can always add a new key user_trusted_networks.

My idea was just to be able to do:
'''
<IP_ADDRESS>/32:
mapped_user: pete
<IP_ADDRESS>/32:
mapped_user: dave
<IP_ADDRESS>/32:
mapped_user_from_proxy: true
'''
But sure it's no problem to handle this in a different format.

@elupus that feature will change several places in the login flow, not only in the config of trusted networks auth provider. A separate pull request is need.


fix #304

Resolved NSInternalInconsistencyException when capture photo

thanks @codezero-jp ✌
i'd like to merge this in but your branch is failing travis-ci with the try/catch commit. if you can update the PR to just the first commit, that'd be helpful.


feat(LinkPopover): copy link href to clipboard

Signed-off-by: elit-altum<EMAIL_ADDRESS>Issue #213
Continues on https://github.com/accordproject/markdown-editor/pull/246 and adds a feature to copy the link text to the clipboard by providing a 'copy' button.
Only displayed while editing the link.
Changes

Adds a new button to copy the link text to the clipboard.

ScreenShot

Flags

The UI looks bad. Really need @Michael-Grover's help to fix the layout, as three buttons will take lots of space. (Maybe use icons only?)
We need to alert the user that the link is copied maybe through a tooltip or a Popup from Semantic-UI. Need suggestions about it

Related Issues

Pull Request #246

@irmerk @DianaLease @Michael-Grover Please review!

@Michael-Grover any thoughts on this?

I will work on an improved hyperlink UI and share that when it's ready

@Michael-Grover and @irmerk I have implemented the designs. Please review.
Some points:

The Button from Semantic-UI allows very less modification therefore the button colors are not changed. Should I remove and write the CSS for a button from scratch ?
Addition of tooltips would require the addition of state as well. A workaround could be found if we use the hover property in a different CSS file. Currently, the <title> of the SVG's is providing a tootlip. Please tell me if it's good enough, if not, which approach should I prefer?

@DianaLease may be able to help with point 1 as she has made some similar buttons in a different product

The Button from Semantic-UI allows very less modification therefore the hover button colors are not changed. Should I remove and write the CSS for a button from scratch ?

I would suggest either creating a new styled-component for buttons instead of using the semantic ui button, OR extending the semantic-ui button with styled components using the styled(Button) syntax, so something like...
import { Button } from semantic-ui-react;
const StyledButton = styled(Button)`
  &:hover {
    // add your styles here
  }
`;

The Button from Semantic-UI allows very less modification therefore the hover button colors are not changed. Should I remove and write the CSS for a button from scratch ?

I would suggest either creating a new styled-component for buttons instead of using the semantic ui button, OR extending the semantic-ui button with styled components using the styled(Button) syntax, so something like...
import { Button } from semantic-ui-react;
const StyledButton = styled(Button)`
  &:hover {
    // add your styles here
  }
`;

@DianaLease I have tried this approach. It's not working. I'll make a new styled div. Thank you for the help!

Closing this to move to development branch.


[BUG] --list-strategies provides no output

When running fw-fanctrl --list-strategies, no output is provided. This behavior is consistent, provides no error message, and persists after reinstalling. I have confirmed that the configuration file exists in the default location.
Environment

OS: EndeavourOS (Arch Based)
Version: r46.d4b45c6-1
Installation method: fw-fanctrl-git AUR package

Do you get an output with the "-q" option?


MNT: rerender

Hi! This is the friendly automated conda-forge-webservice.
I've rerendered the recipe as instructed in #11.
Here's a checklist to do before merging.

[ ] Bump the build number if needed.

Fixes #11

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin rerender


fix: add history log to track bacenta status changes

fix: add history log to track bacenta status changes
Description

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Screenshots/Videos (if appropriate):

@AsiakN  I've looked at it and my concerns are as follows,
I think you mixed two different functionalities. You made the changes for the bacenta weeks that I requested, but you also mixed it with the history log.
I Can see that you have created some new relationships but I don't think that is necessary. We can have a call later tonight around 9:30 if you are available so we can go through the code.
Also your PR description leaves a lot to be desired. You didn't let us have any information whatsoever.


Add accessibility

Insert URLs to the project here: https://github.com/ipeaGIT/accessibility

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

All issues labeled as Good First Issue of the project listed on OpenSustain.tech will be visible on ClimateTriage.com. This is a great way to welcome new community members to your project.
All projects listed will be posted on our Mastodon channel

@dhersz @rafapereirabr


New package: YOLO v0.1.0

Registering package: YOLO
Repository: https://github.com/ianshmean/YOLO.jl
Created by: @ianshmean
Version: v0.1.0
Commit: 791d7b4082ee46b3e1098d2d30c5c1a05cce5d04
Reviewed by: @ianshmean
Reference: https://github.com/ianshmean/YOLO.jl/commit/791d7b4082ee46b3e1098d2d30c5c1a05cce5d04#commitcomment-35172818

TagBot tag


Huggingface demo output error, please check

Hi, Thanks for your work.
When I using demo in huggingface, it just has error info.
Could you please check that?

Hi @ymzlygw, thanks for your interest in our work and for bringing this to our attention.
The demo is up and working again now. Please try it on your end too.

Thanks! It works!

Hi @ymzlygw, thanks for your interest in our work and for bringing this to our attention.
The demo is up and working again now. Please try it on your end too.

Thanks! It works!


Failed to create CoreCLR, HRESULT: 0x8007000E

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
Issue
When running pwsh under UserLAnd in Android, it returns the following message:
Failed to create CoreCLR, HRESULT: 0x8007000E

Workaround
If I retry a few times, it eventually runs.

UserLAnd
The UserLAnd app is available here:
https://play.google.com/store/apps/details?id=tech.ula&hl=en_US&gl=US&pli=1
In UserLAnd, I'm running pwsh in Ubuntu:

PowerShell binary
I'm using the pwsh from the following package:
https://github.com/PowerShell/PowerShell/releases/download/v7.3.1/powershell-7.3.1-linux-arm64.tar.gz
Expected behavior
`pwsh` should run without needing to retry multiple times.

Actual behavior
See screenshot above.

Error details
See screenshot above.

Environment data
PS /home/userland> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.3.1
PSEdition                      Core
GitCommitId                    7.3.1
OS                             Linux 5.10.81-android12-9-25490797-abS908U1UEU2BVL1 #1 SMP PREEMPT Thu Dec 1 09:34:25 UTC 2022
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

PS /home/userland>

### Visuals

_No response_

See https://github.com/dotnet/runtime/issues/13027, the error indicates out of memory.


[FEATURE] Add a Position menu parameter

Hello good Diego make a change in the package that is being that you can put the menu position (left or right).

Sure, do you want to implement that feature?

Yes, I'm sure

ok, sounds good. Don't forget to execute dartfmt . -w before you send the Pull request.

thank you, yes, I did perform the dartfmt before making the pr

Fixed on #5


Rearranged Run SwiftLint phase before Compile sources phase

Closes #3451

Another thought: Is it actually better to run SwiftLint before compilation? Seems more efficient to catch compilation errors first and stop the build (if it does) rather than wait to solve mostly stylistic issues?

[ ]  it's a clean build

Yes. I cleaned the Xcode project and modified the .swiftlint.yml file to show warnings with files greater than 100 lines. Building the project showed the warnings.

[ ]  if an incremental build is triggered from a change that affects R.swift

The R.generated.swift file is excluded from SwiftLint. Any changes that trigger a change in the R.generated.swift file will only affect the swift files that use the strings in the source code when compiling. I added an entry "appTestingMonkey5" = "2"; in all the strings file and a line print(R.string.localizable.testErrorAppMonkeys5) in one of the source files and compiled. There was no reported build error but I did see an intermittent error where R.string.localizable.testErrorAppMonkeys5 is marked as non-existent after a successful build. This has happened before in my previous pull request and restarting Xcode fixed it.

[ ]  if an incremental build is triggered from a change that doesn't affects R.swift

Yes, I added a new line of code and recompiled. The warnings remained consistent.

[ ]  Podfile changes?
[ ]  Podfile.lock changes?

The Podfile, Podfile.lock, and Pod directory are excluded from SwiftLint. I added a new pod and recompiled. The warnings remain consistent.

Another thought: Is it actually better to run SwiftLint before compilation? Seems more efficient to catch compilation errors first and stop the build (if it does) rather than wait to solve mostly stylistic issues?

It should be before because if the compile works and then you have to change the code to satisfy a stylistic requirement, you will have to compile the file again.
I also noticed that SwiftLint is not applied to the targets AlphaWalletShare and AlphaWalletSafariExtension.

It should be before because if the compile works and then you have to change the code to satisfy a stylistic requirement, you will have to compile the file again.

Yes. What I mean was, it seems more common to build and get a compilation error rather than a SwiftLint warning as we code. If SwiftLint goes after compilation and there's a compilation error, SwiftLint will (might?) be skipped, so we can fix the compilation error and then repeatedly re-compile until we finally get to fixing any SwiftLint warnings.
If SwiftLint goes first, we'll always run it even if we end up with a compilation error.
Either way, we'll end up with fixing SwiftLint warnings at the end (unless we choose to skip it in the PR and do a follow up for various reasons). I don't how big is the difference in build time when we skip SwiftLint, but it seems like doing it first doesn't have any advantage. What do you think?

The Podfile, Podfile.lock, and Pod directory are excluded from SwiftLint. I added a new pod and recompiled. The warnings remain consistent.
The R.generated.swift file is excluded from SwiftLint.

SwiftLint don't run on those, but they do run on code that use those, eg. importing and using new code pods, calling R.string.localizable.xxx() which might be missing etc, so I thought they could be affected. But maybe it just goes back to the point of build speeds above?

I also noticed that SwiftLint is not applied to the targets AlphaWalletShare and AlphaWalletSafariExtension.

Good catch. See if you can fix it separately .

If it boils down to speed then just do what you think is best. I don’t know enough about the Xcode compilation process to guess which is the most optimal way. The only reason I raised the point was that it was recommended in the SwiftLint home page. I will file an issue regarding the two other targets (unless you want them as two issues?).

If it boils down to speed then just do what you think is best. I don’t know enough about the Xcode compilation process to guess which is the most optimal way. The only reason I raised the point was that it was recommended in the SwiftLint home page.

Ok. Let's close this PR then. No change is the  best PR :)

I will file an issue regarding the two other targets (unless you want them as two issues?).

One sounds fine unless there are problems. Thanks.


Add WIP support for returning top tokens

What does this PR do?
This PR add support for return the log probabilities of the top N tokens (besides the chosen model).
The token selection code is loaned from the IBM's fork (much thanks @njhill) and I merged into the current main branch. I chose to name the input parameter top_n_tokens and it can be any (positive) integer. If it's set, a top_tokens field in the result details will contain a LxN list of tokens where L is the sequence length and N is the amount of requested tokens.
Note that it is currently very much WIP.

It is currently only implemented for seq-to-seq models (though it's modular and should be easy to implement for other models as well).
I haven't implemented this functionality for the prefill. Do we want to?
I sort the tokens based on their logprobs, because IBM's implementation had the functionality. However, it may cause unnecessary overhead.
IBM's code doesn't just return the "top n" tokens. It actually (explicitly) returns more tokens when there are tokens with equal probabilities. I am not sure if this is desired.
I have not yet implemented input validation of the top_n_tokens field.
I have also done no benchmarking to test the impact on performance.

I haven't given the benchmarking tool the capability to benchmark this feature.

Fixes #604
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[x] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed.
Specifically @OlivierDehaene and @njhill

Could this be used to "shorten" a generation (i.e. only use the first N tokens)? If so, how would one use the logprobs to calculate a threshold for throwing out all or a portion of a generation?

This PR only adds the ability to not just return the sampled token, but also the most likely alternative tokens. This can be useful mostly when building applications that require the logprobs of multiple tokens, like ranking and classification
What you are referring to, sounds like a custom stopping criterium.

This is very cool. Thanks for the work!
Are you ok with me maye merging this to a dev branch to add my modifications directly before merging it to the main branch?
Cheers!

It currently only works (properly) for FlashCausalLM models. Perhaps it'd be good to wait until I implement it everywhere

@OlivierDehaene I think it's mergable now!
Haven't edited the Python Client yet, but all server functionalities should work now. For some reason, my latest commit (95d0fba7de062840dde979c043581085d4a7ac9d) doesn't show up yet in this PR, however.

@Vinno97, I will be off in August but @Narsil will be available to review the PR.
For your info, we updated the license of this repo to HFOIL. You can review the reasons behind this license change here.

Thank you for notifying me on the licencing change. Luckily, as far as I understand it, this has no effect on our operations for now

Hi @Narsil. Could you review this PR? It touches a lot of different files though most changes are only about passing parameters and results have to be passed through every communication phase. The token logic is contained in tokens.py#batch_top_tokens . Additionally, I added top_n_token support separately to CausalLM, FlashCausalLM and Seq2SeqLM .

Thanks for the PR.
I'm pretty stretched atm and this PR looks like it requires a lot of attention.
I intend to look at it early next week. Don't hesitate to ping if I didn't.

Understandable.
In the meantime, we started running it in our testing/experimentation enviroment and a colleague of mine is integrating it with a private fork of lm-eval. If we find any issues there, I'll of course update the PR.

Just fixed a small oversight in the batch concatenation for flash attention models

I intend to look at it early next week. Don't hesitate to ping if I didn't.

@Narsil ping 🙂
Since it's my PR, I obviously can't review myself. But let me know if I can be of any help.

Ok I looked at the code. On the surface the code looks really nice !
I need to invest a bit of time investigating the performance changes on various models/platforms.
At least making sure there's no huge regression.

Are you OK if I do the rebase to be up-to-date too ?

Ok here are the results from the bench:
https://github.com/Narsil/tmp_bench/blob/main/README.md
Performance is affected mostly for smaller models without TP.
It kind of makes sense since the less compute on the model, the more compute actually happens during logits processing. I'm still surprised by the 25%.
At least there doesn't seem to be any degradation without using top_p_tokens, so it should be good for most users (and users can deactivate the option)
Overall I find everything proposed in the PR acceptable.
Default to top_k=5 tokens seems reasonable (bench used 10).

Here is my rebased version: https://github.com/huggingface/text-generation-inference/pull/868

Closing since @Narsil's merge via https://github.com/huggingface/text-generation-inference/pull/868


Generate Description from @schema/desc annotation

As a Configuration Author
I want to generate an Openapi description key from my configuration annotations
so that Configuration Consumers see what the key's purpose is.

:green_circle: Scenario 1: @schema/desc annotation creates a description key for an map
Given the following schema exists
#! schema.yml
#@data/values-schema
---
#@schema/desc "Your beverage of choice"
beverage: juice

When I execute ytt -f schema.yml --data-values-schema-inspect -o openapi-v3
Then I should see on my screen
openapi: 3.0.0
info:
  version: 0.1.0
  title: Openapi schema generated from ytt Data Values Schema
paths: {}
components:
  schemas:
    dataValues:
      type: object
      additionalProperties: false
      properties:
        beverage:
          description: "Your beverage of choice"
          type: string
          default: juice

:green_circle: Scenario 2: @schema/desc annotation creates a description key for an  array
Given the following schema exists
#! schema.yml
#@data/values-schema
---
#@schema/desc "Your beverage of choice"
- beverage: juice

When I execute ytt -f schema.yml --data-values-schema-inspect -o openapi-v3
Then I should see a description on the ARRAY
openapi: 3.0.0
info:
  version: 0.1.0
  title: Schema for data values, generated by ytt
paths: {}
components:
  schemas:
    dataValues:
      description: Your beverage of choice  # <-
      type: array
      items:
        type: object
        additionalProperties: false
        properties:
          beverage:
            type: string
            default: juice

:green_circle: Scenario 3: @schema/desc annotation creates a description key for an array item
Given the following schema exists
#! schema.yml
#@data/values-schema
---
choice:
-
  #@schema/desc "Your beverage of choice"
  beverage: juice

When I execute ytt -f schema.yml --data-values-schema-inspect -o openapi-v3
Then I should see a description on the MAP
openapi: 3.0.0
info:
  version: 0.1.0
  title: Schema for data values, generated by ytt
paths: {}
components:
  schemas:
    dataValues:
      type: array
      items:
        type: object
        additionalProperties: false
        properties:
          beverage:
            description: Your beverage of choice # <-
            type: string
            default: juice

💚  Scenario 4: @schema/desc annotation is added to the top level description of the schema
Given the following schema exists
#! schema.yml
#@data/values-schema
#@schema/desc "Schema for beverage choices"
---
beverage: juice

When I execute ytt -f schema.yml --data-values-schema-inspect -o openapi-v3
Then no description is added
openapi: 3.0.0
info:
  version: 0.1.0
  title: Openapi schema generated from ytt Data Values Schema
  description: Schema for beverage choices   # <-
paths: {}
components:
  schemas:
    dataValues:
      type: object
      additionalProperties: false
      properties:
        beverage:
          type: string
          default: juice

🔴  Scenario 5: When value is any type other than a string
Given the following schema exists
#! schema.yml
#@data/values-schema
---
#@schema/desc 1   # <- integer
beverage: juice

When I execute ytt -f schema.yml --data-values-schema-inspect -o openapi-v3
Then I see an error (similar to overlay errors) that the value must be a string
Map item on line schema.yml:4: Expected 'schema/desc' annotation to have one keyword argument of type string
    in <toplevel>
      schema.yml:4 | beverage: juice

🔴  Scenario 6: When value is any type other than a string
Given the following schema exists
#! schema.yml
#@data/values-schema
---
#@schema/desc "" ""  # <- two string arguments
entree: ham

When I execute ytt -f schema.yml --data-values-schema-inspect -o openapi-v3
Then I see an error (similar to overlay errors) that the value must be one string
Map item on line schema.yml:4: Expected 'schema/desc' annotation to have one keyword argument of type string
    in <toplevel>
      schema.yml:4 | beverage: juice

Excerpt from the proposed Schema documentation
@schema/desc documentation

Sets the text describing the purpose of the node.

documentation (string) — a more thorough description of the node or section that shares the context
of the node, enumerates the range of possible values, explaining the effects of certain value ranges.

often these strings include formatting typography (e.g. HTML or Markdown) to support display of these
values in documentation settings.
per OpenAPI spec, the downstream tooling is likely the responsible party for sanitizing such strings for security.

Links:

OpenAPI spec

re: @schema/desc on a Document Node
Observations:

other @schema/... annotations on the document map to the properties of components.schema.dataValues.
the title and description properties are also support/allowed in that set of properties.

Suggestion:

direct the this metadata to the components.schema.dataValues
introduce a separate annotation for setting the info section of values (e.g. @schema/info?)

That is a great idea, I created an issue to talk through your suggestion more https://github.com/vmware-tanzu/carvel-ytt/issues/539

Updated the acceptance criteria to change if a data values schema is annotated at the document level:
#@schema/desc ""
---

then it applies to the section immediately following the component.schemas.dataValues section.

Available in v0.38.0


App not installed as package conflicts with an existing package

Trying to install OdinTools 1.3.1. Odin 2 Pro with software version <IP_ADDRESS>6.  As far as I know, I've never installed OdinTools before.  When I try to install the APK, it asks me 'Do you want to update this app'?  Then it fails on 'App not installed as package conflicts with an existing package.  I don't see it in the Play Store, or anywhere in the app drawer/desktop.
The compatibility section on this page suggests that it will only work up to <IP_ADDRESS>8.  Is this a conflict with the latest version of the OS?  I see that some of the features listed on OdinTools seem to be available in the latest updates.  I would love to have the app overrides available still for some automation.

I don't think I've seen this issue before. Can you check in Settings -> Apps -> See all apps if you find OdinTools there somewhere? You could also try adding OdinTools to Obtanium and check if it detects it as installed or can install it.

Turns out I did have Odin tools 1.0 installed somehow. Found it under
settings -> apps -> see all apps like your suggested. Uninstalled, then the
newest version installed just fine. Thanks for your help!
On Mon, Jun 3, 2024, 1:03 PM Max K. @.***> wrote:

I don't think I've seen this issue before. Can you check in Settings ->
Apps -> See all apps if you find OdinTools there somewhere? You could also
try adding OdinTools to Obtanium and check if it detects it as installed or
can install it.
—
Reply to this email directly, view it on GitHub
https://github.com/langerhans/OdinTools/issues/43#issuecomment-2146018305,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE45EINT5W24XCGKRMIL27TZFTDYHAVCNFSM6AAAAABIVJDGB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBWGAYTQMZQGU
.
You are receiving this because you authored the thread.Message ID:
@.***>


Bluetooth: Host: Downstream 21.10.2024

FYI: had to revert and re-revert https://github.com/nrfconnect/sdk-zephyr/commit/b0ce7fe23a0c83ce3038baf2b8899e0e6b1497fc and https://github.com/nrfconnect/sdk-zephyr/commit/687cefae54d14d19010ec95b6a6a89eedb6da5b0 to bypass Commit tags job for this commit:
https://github.com/nrfconnect/sdk-zephyr/pull/2139/commits/9d126504603648241e421d9608402d8bd5ca1cd2

@carlescufi , can we skip the compliance check failure since it is probably because the upstream was not checking formatting when the failing commits were merged?


Cursor change to indicate module clickability

Potential fix for: https://github.com/Alexays/Waybar/issues/1610
For clickable modules change the cursor type when entering/leaving listening on the AModule::event_box_.
This seems to work for me but I'm not sure if there are edge cases or a better way to achieve this with GTK so open to suggestions.

Sorry for unnecessary comment, but this is kind of funny. You already added the hover events and fixed the propagation bug prior to my: https://github.com/Alexays/Waybar/pull/3165/files and now I fix a bug in your code: https://github.com/Alexays/Waybar/pull/3195.


Update base/build.sh to support custom building

This change updates the base/build.sh script and adds command
line options that can be used to easily build the base image and
store the result in a specific Google Cloud Platform project's
Container Registry.

PTAL


Inadequate explanation of purpose property

The "purpose" property as described in the latest draft may be included to explain the presentation definition inputs being requested. From a privacy perspective (GDPR) the level of transparency is not sufficient and more work needs to explain the privacy considerations if that was the intent of having a property "purpose". A new work item is being started data agreement that will be working in adding clarity to the notice to an individual when requesting to process personal personal data.
To put the data agreement in context the core profile stack should reflect that a new layer 3/4 for "data agreement" will be introduced which the presentation exchange can bind to at a future point. Included is a diagram shown at the recent DIFConn F2F of the binding can look like. Note the attributes will be bound ID not shown in the diagram.
Thank you for your consideration of this issue.

Recommending an additional paragraph to the explanation of the property:
"Note: guidance in the usage of purpose will be expanded in a future release of presentation exchange in order to satisfy privacy requirements for full transparency by a verifier on the processing of personal data."

@bumblefudge  My understanding of purpose is that this is a string that is meant to be displayed to the wallet user to tell the user the RP's purpose for requesting this VC e.g. We need your credit card details for the payment, or, We need your address to prove your residency etc. So I don't understand how pointing to an external object containing an ontology will actually help the user in deciding which VC to choose.
@JanLin I don't understand the privacy implications of the RP sending this string to the user. The RP is not revealing any PII of the user in this string. The RP probably does not know who the user is at this point in time. Whilst it is true that the RP is requesting PII from the user, the purpose property is telling the user what the purpose of the requested PII is, which seems to be in conformance to GDPR.

Here is a proposed change to the text discussed in the data agreement working group. Please consider for inclusion. The roadmap statement is optional.
Current text
purpose - The Presentation Definition MAY contain a purpose property. If present, its value MUST be a string that describes the purpose for which the Presentation Definition's inputs are being requested.
NEW Proposed text
purpose - The Presentation Definition MAY contain a purpose property. If present, its value MUST be a string that describes the purpose for which the Presentation Definition's inputs are being used for. By including purpose is not consent but is only informative to the user.
In certain regulatory jurisdictions the usage of the purpose field may be in conflict with the privacy regulatory requirements. The field should not be included if prior data sharing agreements are not in place for transferring personal data using presentation exchange.
Roadmap: DIF Claims & Credentials data agreement work group is developing an addition for privacy regulator compliance (GDPR, CCPA, other) and method for creating immutable records of consent records (data agreements) for using personal data.

link https://github.com/decentralized-identity/presentation-exchange/pull/325

This issue can be closed given #325 has been merged right?


Sometimes trying to load new feed items doesn’t work...

Sometimes trying to load new feed items doesn’t work. I can see newer posts in other apps and interfaces.
from Horpeys feedback

fixed