Swaylock not getting through pam check, when installed through home-manager

Describe the bug
My swaylock is unable to unlock my password/sway DE.
Steps To Reproduce

sudo nixos-rebuild switch --flake https://git.sr.ht/~x10an14/nixos-config/commit/60d5555977ebc0cd1e6a52b1394fd362f5ba245b#
home-manager switch --flake https://git.sr.ht/~x10an14/home-manager-config/commit/7d0fcfe9922a7772422d697fc2d70f79901c8c30
Log into sway
swaylock

Expected behavior
Correct password input into swaylock to unlock and return user to sway.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
I install swaylock/swaylock-effects through home-manager.
Due to https://github.com/NixOS/nixpkgs/issues/143365 I have the below enabled in my flaked nixos configuration (separate/independent flake from my hm config).
security.pam.services.swaylock = {};

This is what appears in the output of sway itself (1x per attempted unlock):
[pam.c:101] pam_authenticate failed: invalid credentials

As mentioned in this issue thread (https://github.com/NixOS/nixpkgs/issues/157112#issuecomment-1024250758), I had a similar issue 6 days ago.
But back then that fix referenced worked for me. And has worked until today/yesterday.
It doesn't work, even after updating to latest releases of nixos-unstable as shown in above flakes, and explained here: https://github.com/NixOS/nixpkgs/issues/157112#issuecomment-1029282194
Notify maintainers
@gnxlxnxx @primeos
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.16.4, NixOS, 22.05 (Quokka)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.6.0`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Ran into the same issue. My temporary fix is to hold swaylock back to the commit before sway 1.7 was introduced, 2e719d1cdab9e81750c19425a1f5c7678b5e73ad (I also use 1.6 because of the chromium regression.)

Wrote a test (#158027), but turns out it's more specific than I thought (that just runs on master). More investigation needed.

Let me know if and how I can help!

I'm just gonna let a bisect run overnight, see what we find. I'll report back in the morning with the result.

Bisect isolated 62e6374d5e1cecfdedd702592f09bdbb87249e5d as the first bad commit, which seems plausible. Currently testing that hypothesis.

Nope that was unrelated build failure... Sadly nix-bisect --failure-line is also broken... 🙃

Oh well x) Still here if I can assist in any way!

Missclick...

I cannot reproduce this (tested via commit 554d2d8aa25b6e583575459c297ec23750adb6cb / nixos-unstable). Maybe it is related to Home Manager? It seems like you install Swaylock via NixOS but Sway via Home Manager? That should be fine but maybe there are some impurities (we usually have those mainly through /run/opengl-driver/ though but it could theoretically cause unrelated issues).
On an unrelated note: IMO Home Manager users should set programs.sway.enable = true; (the rest can still be configured through Home Manager). Unfortunately that probably still isn't documented (IIRC I requested that once)...
@Synthetica9 are you by any chance using that Home Manager approach too?

No I use configuration.nix
On Fri, 4 Feb 2022, 22:27 Michael Weiss, @.***> wrote:

I cannot reproduce this (tested via commit 554d2d8
https://github.com/NixOS/nixpkgs/commit/554d2d8aa25b6e583575459c297ec23750adb6cb
/ nixos-unstable). Maybe it is related to Home Manager? It seems like you
install Swaylock via NixOS but Sway via Home Manager? That should be fine
but maybe there are some impurities (we usually have those mainly through
/run/opengl-driver/ though but it could theoretically cause unrelated
issues).
On an unrelated note: IMO Home Manager users should set programs.sway.enable
= true; (the rest can still be configured through Home Manager).
Unfortunately that probably still isn't documented (IIRC I requested that
once)...
@Synthetica9 https://github.com/Synthetica9 are you by any chance using
that Home Manager approach too?
—
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/issues/158025#issuecomment-1030362760,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABV7PJYKGRYR42B67CPNUB3UZRAFTANCNFSM5NPZCDIA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Any suggestions (however temporary) of how to remediate this?
If its enough to use an older version of Swaylock (for now) I'd happily do that.
(Need to learn how to use overlays like that first though).

I may be betraying my lack of knowledge about PAM, but is this down to running the wrong unix_chkpwd?
Ran strace -f --trace=execve swaylock -d, entered my password, then waited (for an oddly long time) for verification to fail. Output includes the line:
[pid  1850] execve("/nix/store/g55rkqdbnq1rfmfcg2ldp29m55answ31-linux-pam-1.5.1/sbin/unix_chkpwd", ["/nix/store/g55rkqdbnq1rfmfcg2ldp"..., "<username removed>", "nonull"], 0x7f8803159040 /* 0 vars */) = 0
Shouldn't this execve() be passed the setuid wrapper in /run/wrappers/bin/unix_chkpwd, rather than the non-setuid binary in /nix/store?

@jamesluke good catch, that should indeed be a problem. However, when using strace that part should unfortunately always fail. I forgot about the details but IIRC the tl;dr is that strace is based on the ptrace syscall which allows for much more than just tracing (e.g., reading from and writing to memory of the traced program). Therefore one isn't allowed to trace privileged programs as that would allow for easy privilege escalation. Anyway, I gave this a quick test on my system and when I launch Swaylock via strace it also doesn't work and doesn't use /run/wrappers/bin/unix_chkpwd (which comes first in $PATH). But without strace it works as expected.

@primeos But without strace it works as expected.

Am I understanding you correctly that with
programs.sway.enable = true;

It works for you?
I've tried with that setting too now(in addition to my home-manager settings), and I still can't log in =(

Yes, it works on both my main system and my test/old system. The new VM test (https://github.com/NixOS/nixpkgs/pull/158027) does also work.
It seems like there must be some other settings that can break things.

I've tried with that setting too now(in addition to my home-manager settings), and I still can't log in =(

Thanks, it was worth a try and good to know that this doesn't fix this particular issue either.

I think I may have narrowed it down, though not 100% sure.
I can lock (and unlock) with Swaylock installed from NixOS (/nix/store/3dhs4kbd15z4ngxnacrx99kfcywnjgc1-swaylock-1.5/bin/swaylock).
But I cannot do so with Swaylock effects installed via home-manager.
I've tried both by just executing their /nix/store binaries manually.
Does anyone here (besides @gnxlxnxx who hasn't responded yet) use Swaylock effects?
How could one make a test for this, like the one you mentioned @primeos?

I think I may have narrowed it down, though not 100% sure.
I can lock (and unlock) with Swaylock installed with my nixos-config, as long as this config exists on my system:
programs.sway.enable = true;

I know it is this one when I test because I use /run/current-system/sw/bin/swaylock to when I run/test it.
Doesn't seem to matter if it's swaylock-effects or default swaylock.
I tested that supposition like so:
# nixos config:
  programs.sway = {
    enable = true;
    extraPackages = with pkgs; [swaylock-effects];
  };
# bash output (`--clock` option doesn't exist in normal swaylock):
 $ /run/current-system/sw/bin/swaylock --help 2>&1 | grep clock
  --clock                          Show time and date.

If I only keep the abovementioned programs.sway.enable = true; config, and I use the home-manager installed ~/.nix-profile/bin/swaylock, it doesn't work.
So my research has given me two questions:

How could one make a test for this, like the one you mentioned @primeos?
Should I close this issue and re-open it with Home-Manager?

I have no idea where to go from here.

How could one make a test for this, like the https://github.com/NixOS/nixpkgs/pull/158027 @primeos?

Home Manager is separate from Nixpkgs / NixOS so I don't see that happening (technically/theoretically, it should be possible with enough effort).

Should I close this issue and re-open it with Home-Manager?

Yes, IMO it's an Home Manager issue then. Or at least it should be first further analyzed/debugged there (I'm not familiar with it so I cannot help with that anyway).

I have no idea where to go from here.

Someone who's affected by this issue needs to figure out what's going wrong (and if Nixpkgs changes are required).

with c7d68f57c842d56046d31688dee4e0956bc90438, I also ran into this problem, but I globally installed swaylock (e.g. programs.sway.enable=true;); a caveat however is that I use swaylock via swayidle, which gets started via user' systemd, and messes with the PATH variable...

I haven't read this thread closely but I suspect this has to do with how we're importing the environment. Since either in the default config and/or the HM module, we use systemctl --user import-environment instead of dbus-update-activation-environment --systemd.
(Also, one would want to ensure that they either the nixos program option, or that if they use the HM module directly, they somehow also enable the pam wrapper for swaylock so it can properly do its job).

I'm running into this as well ( https://github.com/coreyoconnor/sway-gnome )
@colemickens should systemctl --user import-evnrionment or dbus-update-activation-environment be used? Or are both needed for specific imports? I'm entirely ignorant of both. sway-gnome uses both (copy-pasted without much thought) throughout.

I still don't understand dbus. However, I fixed the issue I was encountering. My config was missing the following:
security.pam.services.swaylock = {};

Which, once added, corrected the issue of swaylock rejecting a valid password.

I'm running into this.  With nixos config, I have "programs.sway.enable = true", but I don't get a "/etc/pam.d/swaylock" configuration.  I am also using home manager, with "wayland.windowManager.sway".
I attempted to add "security.pam.services.swaylock = {}" to nixos configuration as mentioned above, but I do not see a change in /etc/pam.d nor swaylock.  Copying /etc/pam.d/login to /etc/pam.d/swaylock allows success.  I believe this is because swaylock ends up using "other", which is just set to "warn and deny"

I ran into this too and setting security.pam.services.swaylock = {} like @coreyoconnor suggested worked :tada:
Should this be introduced to the security,pam module? I see something similar is already being done for a few other programs https://github.com/NixOS/nixpkgs/blob/d10e69c86bcd415f5c4347d3c6b981241e913465/nixos/modules/security/pam.nix#L1281-L1286 but there's a comment which makes me feel like we don't want to keep doing that.
This works when enabling programs.sway because this is set in the nix file https://github.com/NixOS/nixpkgs/blob/d10e69c86bcd415f5c4347d3c6b981241e913465/nixos/modules/programs/sway.nix#L151
Should there instead be a new programs.swaylock module that creates the pam service?
I'm happy to create a PR for this, but I'm not sure what the best way to handle this might be.

Thanks! I had the same issue because i use hyprland but still use swaylock for locking my system. I'm pretty new to nix but is this something that the swaylock nixos package maintainer should be notified of to fix in the package or does this have to remain a security.pam setting?

Here is a fix for non-NixOS hosts.
You probably need to install a PAM configuration at /etc/pam.d/swaylock and setup the /run/wrappers/bin/unix_chkpwd suid binary.
One solution for the PAM configuration could be to copy the default configuration from the nixpkgs:
cp $(nix path-info nixpkgs#swaylock.out)/etc/pam.d/swaylock /etc/pam.d/swaylock

Some distributions will mount /run with the nosuid flag. You should probably simply mount a tmpfs at /run/wrappers without the nosuid option, with eg.:
echo "tmpfs /run/wrappers tmpfs defaults,nodev,noatime,mode=755 0 0" >> /etc/fstab

Then you can create a oneshot systemd unit to create a symlink from the /sbin/unix_chkpwd binary to /run/wrappers/bin:
cat <<EOF > /usr/local/lib/systemd/system/install-unix_chkpwd-wrapper.service
[Unit]
After=run-wrappers.mount
Wants=run-wrappers.mount

[Service]
Type=oneshot
ExecStart=/usr/bin/ln -sf /sbin/unix_chkpwd /run/wrappers/bin/unix_chkpwd

[Install]
WantedBy=multi-user.target
EOF


Path support and security improvements

Fixes a security issue where the password is sent as plaintext in the URL query parameters when methods from libsonic_extas are used. Also adds Subsonic hex encoding when using legacy auth.

Adds support for URL paths like https://hostname.com/subsonic as requested in #17 and also encountered in some of the reports in #14 and #5

Fixes an error when the password only contains digits, which simpleplugin converts to a Long, which later fails when libsonic tries to salt the password expecting a string.

Hey, when I tested this without legacy auth it seemed like the salt password and username was always set in the url already, so I'm not really sure what situation one would need to update the username and password that way.
If you feel like it's too risky and might break something unexpected feel free to remove that part, just keep in mind that it means passwords will be sent in plaintext again until a better solution is found.

Mhh... Not sure what I have to do here, even if I would like to merge your changes.
Can anyone help on this ?


Always fetch version info from NPM, rather than the versions.json blob.

Like fetch, we can run this with nAtATime(100, ...) and it takes under a minute.
This PR doesn't stop us from uploading the data directory along with logs, although we could stop since we no longer download anything from there.
If this is merged into production, it will cause most packages to be republished since we only recently started storing "typesPublisherContentHash" on NPM.

:+1:


grpc 0.11.1 gem release not published to rubygems

I was hitting a build error while installing grpc gem version 0.11.0.  Building from gemspec and installing gem version 0.11.1 fixed the build error for me.
However, version 0.11.1 is not published to rubygems.org, which causes issues when trying to install grpc via bundler.

Version 0.12.0 has now been published to rubygems. It has all of the changes in 0.11.1, plus several others (see release notes for details).

Version 0.13.0 has also been published now. At this point, I think this issue is obsolete. Feel free to reopen if it's still a problem.


Fixup/remove rack timeout

fixes https://github.com/philosophie/suspenders/issues/70

:shipit:

@jdwolk :eggplant:


Description of Construction Helper Job

Saving it here for future reference. Please review it so I can post it on Group.

Can you give me more context for it? Should I delete it or something else?

Rephrase, Who are we a good fit for?

Got you and here is the rephrased version "Our Ideal Candidate."


chore: upgrade go, jwx and aws sdk v2

I am looking to use this and wanted to pitch in and update the dependencies.
Thanks for developing this.

Sorry, I really need to turn on notifications


js files are not excluded from explorer view in Mac OS X 10.9

VSCode Version: 1.0.0
OS Version: Mac OS X 10.9

Steps to Reproduce:

open settings.json
add following settings

{
    "files.exclude": {
        "**/*.js": {"when": "$(basename).ts"}
    }
}

*.js files still apears in Explorer.

@tarurar this will only hide *.js files if there are *.ts files with the same name. Otherwise just say "true" instead of using the when condition.

Ok, @bpasero, please have a look at the screenshot attached. *.js and *.map files didn't dissapear from the explorer.

@tarurar you missed the "" in ".js"?

Haven't got it. What is the questions, actually?

@tarurar somehow github escaped my comment in a weird way. I said, you seem to have missed the * in *.js in your settings. I only see .js

Yes, you are right. Sorry. You can close the issue.


Implement fallible OutputPin/InputPin traits

See https://github.com/rust-embedded/embedded-hal/issues/95 and https://github.com/rust-embedded/embedded-hal/pull/108

This has been solved in release 0.3.0.


fix: use of case-anything instead of change-case

Use of case-anything

small footprint (it's 12+ times smaller than the next popular case changing package!!)
tree-shakable — only import what you need
awesome JSDocs popup documentation on hover
fully typed with TypeScript
complete coverage with unit testing
0 dependencies

Case-anything has some weird behaviours that are different, closing this PR and keep change-case


Route state to be managed with Redux along with typical application state via Redux-First-Router

https://www.dailydrip.com/topics/react/drips/redux-first-router-first-impressions

Another library to consider
https://github.com/reactjs/react-router-redux

Will be handled in different issue. Closing


feat: support partial errors and multiple errors per field resolver

EDIT: this has been updated to no longer use an extension, but to provide native support instead
Create a new PartialResultsExtension to allow adding exceptions to info.context.partial_errors to get added to the result after execution, allowing users to add errors to the errors array from a field resolver while still resolving that field.
Description
NOTE: It's entirely possible/likely that I misunderstand how partial/multi-error handling works in graphql-python and that there is a simpler, already supported way to do this.
One powerful feature of GraphQL is returning both data AND errors. The typical way to return an error in python graphql is to simply raise it, and let the graphql library catch it and add to the Execution Context errors that ultimately map to the errors array in the response.
So this means in a field resolver we can either return data OR raise an error. But we can't raise multiple errors (possibly incorrect) and we can't return data AND "raise" an error (also possibly incorrect). I have not been able to find documentation or examples supporting either case.
To work around this, this extension creates an interface so developers can manually populate errors from resolvers that get added to the result after execution.
Caveats
I'll admit a couple things here:

As noted above, my understanding may be lacking and there is already support for this kind of behavior
Even if my understanding is correct and this extension works, this may not be the way this library would want to support this kind of thing
There's a little hackiness as noted in the copied block of the extension code that I don't love
Unclear how best to get the nodes arg for creating your own GraphQLErrors to ensure location and path fields exist in the error object in the response. See https://github.com/strawberry-graphql/strawberry/pull/874 for information around not exposing Nodes directly, in favor of strawberry's own wrapper type Selection.

Usage example:
import strawberry
from strawberry.extensions import PartialResultsExtension

schema = strawberry.Schema(Query, extensions=[PartialResultsExtension])

# ...

@strawberry.field
def query(self, info) -> bool:
    info.context.partial_errors.append(Exception("Partial failure"))
    return True

Results:
{
  "data": {
    "query": true
  },
  "errors": [
    {
      "message": "Partial failure"
    }
  ]
}

Types of Changes

[ ] Core
[ ] Bugfix
[x] New feature
[ ] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

None

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Hi, thanks for contributing to Strawberry 🍓!
We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!
So as soon as this PR is merged, a release will be made 🚀.
Here's an example of RELEASE.md:
Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)
Here's the tweet text:
🆕 Release (next) is out! Thanks to Bradley Oesch for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

Some example use cases:

Query for data matching ids [0, 1, 2] and there's no id 1, so you return data: [data0, null, data2] with errors array with some message and the path pointing to the index of the missing data
Plural mutation where some fail and some don't, similar kind of response
Operation with multiple business-logic-like validation errors, e.g. user tries to do some action on "item id 123" but gets multiple errors, e.g. "User does not have enough coins for this action", whatever, something that is not like a graphql-schema-validation type of error

I'll take a proper look at this probably next week, but some notes that pop into my mind:

I wonder if we could somehow use exception groups, granted we find a way to backport them (or maybe we can allow returning exceptions in resolvers? I wonder if other frameworks do this
can you add a test with the exact use case you have? that should make it easier to understand
Do you think it is important to make sure we return the right path for the error?

also, thank you so much for working on this!

@patrick91

I wonder if we could somehow use exception groups, granted we find a way to backport them (or maybe we can allow returning exceptions in resolvers? I wonder if other frameworks do this

I think this could be cool. I'm not sure what would happen since the graphql-core library only catches exceptions, not groups. Note that if we got this to work (with no other changes), this would enable multiple errors per resolver, but not an error and data in a resolver.
I think having the option of the resolver returning either the data type OR something like an ExecutionResult (that models data and errors) would be cool, and then that context type could add any errors to the errors array, mapping any to GraphQL errors with path/location data, etc (which as I describe down in #3), I think should be more easily accessible per resolver. DGS (netflix java graphql library) defines a DataFetcherResult that you can return.

can you add a test with the exact use case you have? that should make it easier to understand

I think this test_partial_errors_yes_data_yes_errors test is pretty straightforward, but if you're asking for a less contrived test, yeah I can add a test e.g. resolving a list and some are null and you want some errors to point to the null ones

Do you think it is important to make sure we return the right path for the error?

I think it's important to give the users the ability to easily add the right path/location for the error (and if we can do it automatically, great). I'll note that this example with a located error test shows that the easiest way (that I could find) to get the nodes for a resolver is to use info.field_nodes, which was deprecated in https://github.com/strawberry-graphql/strawberry/pull/874 when abstracting out some of the raw types.
I think it could be worth a separate issue to add in some functionality for easily getting the current resolver's located node and path, and then accessing that in here.

@patrick91 Updated with an example use case, a mutation with a partial failure
https://github.com/strawberry-graphql/strawberry/pull/3055/commits/948dc657f682e2b419abdb0dfb6664c8667a9efb

Hello @patrick91 Hello - do you plan to merge this PR soon ?
That would be very useful for my use case too (market data partially missing)

I have some time off friday, so I should be able to review and merge! thanks for the ping!

@patrick91 bump on this for review whenever you have time

@patrick91 I totally lost this one! Rebased main and tried to be a little more generically supportive of context types, but tbh I don't love the approach too much atm. Curious if you have any thoughts coming back to this now?


[TEST PR]Testing TFS integration, do not merge!!

Testing TFS integration, do not merge!!
References #518

@riarenas,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


[3.8.x] Manage software.amazon.awssdk:endpoints-spi

Not sure why none of the CI workflows have run...


Report Portal throws error related to status code when using RP V5

What are you trying to achieve?
Trying to run tests and push output to Reportportal V5.
What do you get instead?
(node:35244) UnhandledPromiseRejectionWarning: Error: Request failed with status code 400: {"errorCode":4001,"message":"Incorrect Request. [Value is not allowed for field 'status'.] "}
    at /Users/****/***************/**********************************************/node_modules/reportportal-client/lib/rest.js:27:23
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

Details

CodeceptJS version: 2.3.5
NodeJS Version: 12.11.0
Operating System: MacOS Catalina 10.15
WebDriverIO: 5.15.2
Configuration file:

NOTE

The issue does not affect the tests or test runtime
The issue caused is inside ReportPortal where the tests don't know when they ended thus the test run duration is inaccurate and it forces the user to manually stop the test sessions inside reportportal Launches section.

This is unrelated to CodeceptJS core, please close the issue here.

@GSasu @pablopaul in my updated version, the launch is now closed. You can still see those ugly strings, but it's not from codeceptjs. Stay with it then.
(node:79255) UnhandledPromiseRejectionWarning: Error: Request failed with status code 400: {"timestamp":1573206957065,"status":400,"error":"Bad Request","message":"Failed to convert value of type 'java.lang.String' to required type 'java.lang.Long'; nested exception is java.lang.NumberFormatException: For input string: \"182487b9-6de8-49be-8763-ba799ae5dfad\"","path":"/v1/peterngtr_personal/launch/182487b9-6de8-49be-8763-ba799ae5dfad/update"}

@GSasu did you found a fix for this problem?


[Bug]: Cannot initiate multi database changes within the structure tree

ODC version
odc432
OB version

What happened?

What did you expect to happen?

How can we reproduce it (as minimally and precisely as possible)?
Initiate multi database changes within the structural tree
Anything else we need to know?
No response

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

Fixed In Commit 0dc21b8a3304a1e5d9aa77869a05b1fbd80e377e
------
畅晚
Tue Aug 27 17:47:24 2024 +0800

pass


Update walkthrough

Fixes #6972

app name plan should be lower-cased and globally unique
use home dir instead of temp for creating new bicep files if no workspace open

Microsoft Reviewers: Open in CodeFlow

Great job! Looks good!


Indeterminate progress bars during deployment make debugging difficult

So alright, some tasks are stuck in staging. I see which groups are effected.

Now I entered the group. But I don't see the task states in the progress bar anymore:

I would simply like to have the same info on app level as I have on group level in the progress bar.
Funny enough, the information is shown in the tooltip but not in the bar:

I remember that this was done on purpose but I really think that we made the wrong choice here.
/cc @leemunroe

Is it the color that is confusing? i.e. we're using stripes to indicate staged in one view, and yellow in another
Would you expect something more like this (quickly mocked up)?

I am not quite sure that I get your point.
Yes, it is strange to use different colors in different views. And, as you can see in the screenshot, at the app list level there was no visual distinction between staged tasks and "unknown health" tasks in the bar at all.

(and the yellow color looks much more distinct than gray stripes vs opaquely gray. That might be different for color blind people though, so you might want to distinguish by color and by pattern.)

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-1939. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


Add update sequence by sample and type end point

FYI @violetbrina

Codecov Report

Merging #227 (64fd0ec) into dev (96649a7) will increase coverage by 2.39%.
The diff coverage is 88.37%.

@@            Coverage Diff             @@
##              dev     #227      +/-   ##
==========================================
+ Coverage   55.71%   58.11%   +2.39%
==========================================
  Files          59       60       +1
  Lines        4284     4364      +80
==========================================
+ Hits         2387     2536     +149
+ Misses       1897     1828      -69

Impacted Files
Coverage Δ

api/routes/sequence.py
45.45% <38.46%> (-1.52%)
:arrow_down:

db/python/tables/sequence.py
58.33% <66.66%> (+35.18%)
:arrow_up:

db/python/layers/sequence.py
64.22% <91.66%> (+18.30%)
:arrow_up:

test/test_sequence.py
100.00% <100.00%> (ø)

db/python/tables/project.py
33.33% <0.00%> (+1.23%)
:arrow_up:

db/python/tables/sample.py
20.57% <0.00%> (+2.28%)
:arrow_up:

db/python/layers/sample.py
55.00% <0.00%> (+6.00%)
:arrow_up:

models/models/sequence.py
92.59% <0.00%> (+44.44%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96649a7...64fd0ec. Read the comment docs.


Physics Acceleration Values

The physics acceleration values do not appear to be correct. You would expect to be able to hold the throttle down, see a sustained change in one of the acceleration values, and then see the value change the other direction when braking. This does not occur.

I've done extensive data mining on driving behaviour and never experienced any problems.
I would suggest to look at acceleration Z. The units are m/s^2.

I think I may be misunderstanding these values. Every other game I've ever interfaced with facilitates a quick conversion from acceleration in m/s 2 to G-Forces.
If you watch this video and select 1440p in the YouTube player, you can see this is not the case: https://www.youtube.com/watch?v=ORhtcBchP64

I see. I have tested it myself now, and I see that linear acceleration Z  looks like it is working correctly.
As for the other channel, I'm not sure why the game SDK is outputting these values.
When I view the angular velocity Y they look more accurate.
Unfortunately these fields are not in the current plug-in, and haven't had the time this week so far to implement it properly.


feat: add explicit and implicit getAppArgs functions

I question the utility of these functions. What are they being used for?

I use .getExplicitArgs in congrm to match the pattern. I have no strong feelings about these, I just they might come in handy.

I'm going to close this, we can revisit if another use case arises. (Elaborating applications is complicated, this is at best an approximation.)


Remove vendor cairo

Can we leave the cairo-lang zip file somewhere? It makes following the ERC20 demo much easier because it's all in one place in this repo.

But isn't it just as easy to call pip install cairo-lang==0.3.1? If you don't think so, I can leave the file around

Can we leave the cairo-lang zip file somewhere? It makes following the ERC20 demo much easier because it's all in one place in this repo.

But isn't it just as easy to call pip install cairo-lang==0.3.1? If you don't think so, I can leave the file around

Yeah that works. Make sure to update the readme for installation, and test it works.


Added troubleshooting of rke

Customer requested the following changes in the docs for rke.

@bmdepesa let me know of any suggestions or fixes that I need to include.

@MBishop17 let me know of any suggestions or fixes that I need to include.

@galal-hussein & @deniseschannon let me know if its good.


FCMEvent.Notification not firing on android after successful click_action

Using rn 0.43.2 and "react-native-fcm": "^6.1.0"
iOS is perfectly fine, absolutely no issues.
Android, however, has been incredibly mysterious.
Using the proper click_action, I am able to launch the app.
      "notification"=>{
        "title"=> "Simple FCM Client",
        "body"=> "This is a notification with NOTIFICATION and DATA (NOTIF).",
        "sound"=> "default",
        "click_action"=> "fcm.ACTION.HELLO"
      },

Any combination of notification and data and this click action will successfully open our app when you press the item in the tray.  Same goes for when I pass a custom_notification within the data itself.
But although touching the notification banner opens the app, it NEVER fires off the notification event, so I can't hook into it to do anything useful.
app.notificationListener = FCM.on(FCMEvent.Notification, async (notif) => {
    console.log('ahhhhh notif', notif)

That console log literally never fires when opening the app from a banner when the app is in the background or the foreground.  I know getInitialNotification is its own beast for when the app has not been launched at all, but I haven't even worried about that yet because when the app is in the background, touching the banner will open it: it just doesn't get inside of this callback, rendering all the data I'm passing back in the notification useless.  Here's the relevant part of my android manifest:
<activity
        android:name=".MainActivity"
        android:launchMode="singleTop"
        android:label="@string/app_name"
        android:configChanges="keyboard|keyboardHidden|orientation|screenSize"
        android:screenOrientation="portrait"
        android:windowSoftInputMode="adjustResize">
        <intent-filter>
            <action android:name="android.intent.action.MAIN" />
            <category android:name="android.intent.category.LAUNCHER" />
        </intent-filter>
       <intent-filter>
         <action android:name="fcm.ACTION.HELLO" />
         <category android:name="android.intent.category.DEFAULT" />
       </intent-filter>

Why isn't the callback being fired off if the click_action is launching the main activity?  Am I missing a step here?
EDIT: To be super clear, even with data and custom notif, this still doesn't work correctly for me.
        'to': user.fcm_token,
        'data' => {
          "custom_notification": {
            'title'  => 'Test title',
            'body'  => 'Test body',
            'color' => '#00ACD4',
            'priority' => 'high',
            'show_in_foreground' => true,
            'click_action' => "fcm.ACTION.HELLO"
          },
        },

i.e. this code also 1. opens the app on click but 2. does not fire off the notification call back, whether opened from background OR foreground.

UGH, please close this!
    @Override
    public void onNewIntent(Intent intent) {
        super.onNewIntent(intent);
        this.setIntent(intent);
    }

Make sure you super here if another library asks you to manually override onNewIntent in MainActivity.java!

How did you manage to get that working I tried to add onNewIntent and I did everything you did, but i just can't get it to fire off the notification event from the background (on_click).


Error Extracting Measures in SSDT 14.0.61704.140 in SQL 2014 (1103) models

I've used DAX Editor to extract measures with no problems on SQL 2014 (1103) models using SSDT 14.0.61021.0 but I receive an error when extracting measures from the BIM file when using SSDT 14.0.61704.140 which currently is the latest version.
Using the latest SSDT, I have the same model created twice, one in compatibility level SQL 2014 (1103) and the other in SQL 2016 (1200). Only the SQL 2016 (1200) model will extract measures from the BIM and the SQL 2014 version fails when trying to extract measures.
Attached is the error I receive when trying to extract measures from the SQL 2014 version BIM.
DAX Editor Error.txt

I will fix it on Monday. Need to update used libraries to latest version

HavenDV, I'm not sure if you're still planning on applying a fix to this issue.  I noticed SQL Server Data Tools build 14.0.61705.170 has the same issue.  Thanks.

I updated the SSDT, updated the dependencies of the package, all the tests pass:
https://github.com/DaxEditor/DaxEditor/commit/60006e7cfccc72c2fecb8cf4138618465f46fadb

HavenDV, I've downloaded the latest version of Dax Editor and am experiencing what I think is the same problem.
Error while reading measures from file
Exception stack:
at DaxEditor.BimFileIntegration.GetMeasuresFromBimFile(String bimFilePath)
at DaxEditor.DaxEditorPackage.EditAdvancedGetBimFileContentCommandExecute(Object sender, EventArgs e)
--- Inner exception
Exception message:
Error while parsing Xmla.
Message: Method not found: 'Microsoft.AnalysisServices.MajorObject Microsoft.AnalysisServices.Utils.Deserialize(System.Xml.XmlReader, Microsoft.AnalysisServices.MajorObject)'.

How did you download the Dax Editor? We still didn't publish the new version, yet.

I first downloaded version from Visual Studio Market Place:
https://marketplace.visualstudio.com/items?itemName=DAXEditor.DAXEditor
And then downloaded and compiled the repo from github
---- On Sun, 11 Jun 2017 17:22:17 +0200 Marco Russo<EMAIL_ADDRESS>wrote ----
How did you download the Dax Editor? We still didn't publish the new version, yet.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Are you sure that you compiled the desired branch? (Need dev - https://github.com/DaxEditor/DaxEditor/tree/dev)

Version 2.0.1703.2601

Hi
I have the latest version of SSDT 17.1 installed and latest update of Dax Editor from VS tool/extensions, and am getting a similar error:
10/07/2017 5:19:28 PM
DAX Editor version: 2.0.1703.2601
Exception message:
Error while reading measures from file 'C:\Users\a.gilmore\Documents\Git\Money3\M3_Tabular\Model.bim'
Exception stack:
at DaxEditor.BimFileIntegration.GetMeasuresFromBimFile(String bimFilePath)
at DaxEditor.DaxEditorPackage.EditAdvancedGetBimFileContentCommandExecute(Object sender, EventArgs e)
--- Inner exception
Exception message:
Error while parsing Xmla.
Message: Method not found: 'Microsoft.AnalysisServices.MajorObject Microsoft.AnalysisServices.Utils.Deserialize(System.Xml.XmlReader, Microsoft.AnalysisServices.MajorObject)'.

Is it happening only for models in 1103 compatibility level, or also for 1200 compatibility level?

The issue is occurring with a model on compatibility level 1103. I'm not in a position to test 1200, as I don't have an SQL Server 2016 instance to deploy too.

If you use the integrated workspace you can create a model in 1200. Knowing this would be helpful to diagnose the issue. Thanks!

Hi Marci
Apologies for taking so long to verify this. I can confirm that after
switching to 1200 compatibility mode with integrated workspace, the 'Get
Measures from BIM File' worked.
Interestingly though the syntax highlighting no longer appears. e.g.
thanks - Adam Gilmore
Adam Gilmore
Dimodelo Solutions
w: www.dimodelo.com
m: 0407 698 591
e<EMAIL_ADDRESS>On Mon, Jul 10, 2017 at 5:51 PM, Marco Russo<EMAIL_ADDRESS>wrote:

If you use the integrated workspace you can create a model in 1200.
Knowing this would be helpful to diagnose the issue. Thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/DaxEditor/DaxEditor/issues/8#issuecomment-314031757,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMWDUOTgvO656u6mPbfkagg2IywPFBP7ks5sMdgPgaJpZM4NZsGs
.

Can you provide a .dax script for testing/patching? If you can, the most abbreviated non-working version

I have the sample problem with Visual Studio 2015, latest SSDT, when working with an 1103 compatibility model.  Stuck at SSAS 2012 BI edition since 14/16 did away with it.


Tests: Improve PHPUnit Forward Compatibility

PHPUnit 8.x and 9.x compatibility
tl;dr: we need to update our PHP integration tests running against core so that they function properly (again) as needed.
WordPress core has moved to adopt PHPUnit polyfills for running its tests and at the same time runs tests using the latest possible PHPUnit version.
To make our test suite compatible, we need to:

Update assertions so we don't use deprecated ones
Define WP_TESTS_PHPUNIT_POLYFILLS_PATH
Update PHPUnit to latest possible version on CI
Update PHPUnit configuration to improve forward compatibility
Update Yoast/wp-test-utils package

The PR also includes one small change related to PHP 8.1 compatibility, see #8520.
See https://core.trac.wordpress.org/ticket/46149 and some of the early individual commit messages for details.
See also https://core.trac.wordpress.org/ticket/53911 for when the PHPUnit changes were backported to older branches

This PR needs to be rebased.
There seems to be lots of places where you have converted to use a single instance of the class. This bad for unit testing and should be reverted. What was the reasoning behind this change in the first place?
Also, all the instance where users can deleted after tests are deleted, why were these removed?


Inline Chunk injection

Hi guys, I am trying to inline inject one of the chunk files instead of making a network call to fetch it whenever my application runs.
I have separated my chunks as needed but am unable to inline inject a chunk file.

inlining known chunk is not a problem - just read it and inline content.

loadable-stats may help you here

if you know it - you can also remove it from preload generated by loadable
the rest is webpack's problem

So which particular step is causing friction?


Support monorepo

Issue :
At the moment, ts-jest doesn't support well monorepo (typescript composite, yarn workspace, lerna etc..). This issue contains all related issues to monorepo:
#1341 : Cannot use rootMode upward for babel config (fixed via #1370)
#1336 : Error Unable to require d.ts for yarn workspace and typescript composite. (fixed via #1385)
#1333: Use wrong version of typescript in yarn workspace (fixed via #1377)
#1277 : Cannot collect coverage with custom compiler e.g ttypescript for lerna workspace.
#1134 : Compatibility with yarn workspaces pnp
#1109 : Cannot import mixin in yarn workspace and typescript compsite
Expected behavior :
Support monorepo out of the box or at least for common ones like yarn workspace, typescript composite, lerna.
Minimal repo :
Example repos are in those above issues
Problem
At the moment ts-jest is lack of helps. We would need community's help in tackling this issue. Feel free to contribute PRs if you have good ideas related to this issue.
cc @kulshekhar

It would be good to add this support. That said, I personally only use ts-jest actively in non-monorepos so this will need help from others (the code and the related tests)

🐛 Bug Report

[x] Not working coverage collection for symbolic links.
[x] Typescript setup not working with symbolic links but JS works.

To Reproduce
I made example project: https://github.com/nomadzetetic/monorepo.
Project contains 2 folders: /account and /shared. /account/src/shared -> symbolic link to /shared folder.
Steps to reproduce the behavior:

Pull this example project https://github.com/nomadzetetic/monorepo
cd account
npm install
npm run test

Expected behavior
In coverage report should be files from account/src/shared.
Link to repl or repo (highly encouraged)
repl.it demo
envinfo
System:
    OS: macOS 10.15.4
    CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
  Binaries:
    Node: 12.13.0 - ~/.nvm/versions/node/v12.13.0/bin/node
    Yarn: 1.21.1 - ~/.yarn/bin/yarn
    npm: 6.14.5 - ~/.nvm/versions/node/v12.13.0/bin/npm
  npmPackages:
    jest: ^26.0.1 => 26.0.1

@quadgod coverage collection isn’t taken care by ts-jest. We would solve only the 2nd issue which is about TypeScript

Heft is an interesting alternative for integrating Jest+TypeScript in a monorepo scenario.


fix: Flash displayed in the update email flow doesn't have a background color

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #53899

It looks like some of the automated tests are failing.
Can you please look into those and make adjustments so they pass the tests?
thanks 👍

ok let me see.


Bug Fix functions for array type with nested decimalv3

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.23 seconds
stream load tsv:          443 seconds loaded<PHONE_NUMBER>9 Bytes, about 161 MB/s
stream load json:         22 seconds loaded<PHONE_NUMBER> Bytes, about 102 MB/s
stream load orc:          59 seconds loaded<PHONE_NUMBER> Bytes, about 17 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          76.8 seconds inserted 10000000 Rows, about 130K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230524081002_clickbench_pr_149596.html


Unable to start terminal process: CreateProcess failed

When I use the menu or hotkey to open a Terminal, nothing happens and I get the following error message displayed in the lower right of the editor:
Unable to start terminal process: CreateProcess failed
I'm on an enterprise Windows 10 machine.  I recently installed/upgraded to the "non-admin" version of VS Code (as it was constantly harassing me to do so).
I have tried "Run As Administrator" with no luck.

Can you share your VS Code version, Windows 10 version number and settings.json file? Also are you on the 64-bit version of VS Code?

Visual Studio Code
Version: 1.26.1
Commit: 493869ee8e8aU6b085S873886fc79d480d342de
Date: 2018-08
Electron: 2.0.5
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

settings.json.txt

I suspect this is related to restrictions placed by your IT support, can you reach out to them and ask them about this? Specifically this is the call that's failing:
https://github.com/Microsoft/node-pty/blob/2c1c0e78c8f110b4e3da87a3f9b88ebc9e7b33b8/deps/winpty/src/libwinpty/winpty.cc#L499
The executable that is being launched should be: %windir%\System32\WindowsPowerShell\v1.0\powershell.exe
We can verify what is being launched by closing VS Code, enabling debug logging by launching code --log debug, opening a terminal and then consulting the log (F1, "log file", enter). Search the log for "Terminal process launching".

Thank you for your help Tyriar.  You got me pointed in the right direction, but it turns out it was simpler(?) than that.  If I tried to launch Powershell from the Start menu, nothing happened.  When I tried running it from cmd, I got "The application has failed to start because its side-by-side configuration is incorrect. Please see the application event log or use the command-line sxstrace.exe tool for more detail."  There are numerous suggestions on how to fix this, including reinstalling C libraries, etc.
Fortunately, I found one post where a user said that their config file was corrupted.  Accordingly, I tried to look at my powershell.exe.config file and found exactly that!  It was nothing but binary NULL characters.
I deleted the config file (after checking with a coworker with a similar setup and didn't have one) and everything seems to be working fine now.  :)  I can launch Powershell from Start and the Terminal window works in VS Code.
Thanks again!

@joshcsmith13 interesting case, glad you got it fixed! 😃


CNDIT-1248 :  Debezium container deployment script to Azure ecosystem.

Debezium docker Container deployment script to Azure Ecosystem with the following assumptions:

Availability zone - EASTUS2
EventHub - rtr-debezium
Database host to configured

Not relevant anymore. Taken over by other developments.


Section header view below navigation bar after on appearance

Hi,
I have a UITableView in a UINavigationController. My tableView contains sections headers.
When I click on the cell, I push another viewController. I call
hidingNavBarManager?.viewWillDisappear(animated)

When the user goes back, the section header is hidden below the navigationBar, as if the tableView had not scrolled. Any idea how to scroll the tableview so the header section is not below the navigation bar on appearance?
Thanks

This should be resolved now, thanks to the PR above


Price adjustment

About the PR
Added or corrected the prices of a variety of things. The cost of some things was just weird, and some things were missing. Covered not everything, but I think some changes in the game Cargo will appear.
If any prices seem strange or incorrect, be sure to report them. Also let us know if anything is worth adding a price.
Corrected the price of atmospheric structures #15559
Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

:cl: Nimfar11

add: Added cost to some tools and boxes.
tweak: Changed the cost of boards, weapons, some atmospheric structures.

Chemicals can 100% not have prices until chem dispenser is removed.

Chemicals can 100% not have prices until chem dispenser is removed.

Creating drugs is quite a time-consuming process. Especially those that have a high price. The player must spend a large amount of time to create an acceptable amount of drugs, and then somehow implement it in Cargo, without attracting the attention of the Security Service. This will bring some gameplay variety for chemists and Cargos. Exactly remove the price?

Removing.

you can still get 100 potency sugarcane crossed with cannabis for god tier thc farm

It would be fun to look at a cannabis-laden Cargo. You'd be surprised, but it's not very economical. Much better to grow apples or other fruits or vegetables, the income would be much higher. And I haven't changed the cost of fruits and vegetables.

This was a trial PR on the subject, I was going to go through all the subjects later and add or adjust the prices. I will keep the comments above in mind.

Arbitrage still needs fixing.

Arbitrage still needs fixing.

I'm not quite sure what you mean

Arbitrage still needs fixing.

I'm not quite sure what you mean

you can buy crates for less than you can sell them for.


added valid link to visit main website

this should hopefully fix #244

Yup, Good job @Pervolarakis
Congrats 🎉, your PR got merged. To be eligible for the swags from iNeuron X ClueLess. Follow this steps.

SignIn / SignUp in ClueLess Website.

Go to profile section from the top right hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard !
And don’t forget to share your achievement with your friends.


Some check_project actions are failing

What is the current behavior?
These action runs have failed:

https://github.com/qiskit-community/ecosystem/actions/runs/5924785194/job/16062982146#step:7:80
https://github.com/qiskit-community/ecosystem/actions/runs/5924783399/job/16062976600#step:6:80
https://github.com/qiskit-community/ecosystem/actions/runs/5924781948/job/16062972378#step:6:80

What is the expected behavior?
Action runs correctly
Any ideas?
Earlier error code is 128, which is probably Git's "git did not exit cleanly". This may just be something that happens every now and again; we should keep an eye out to see if the same repos fail next time, and maybe re-try failed jobs once.

2 of the three are because the repo moved and so the link is 404 now.
The other one, is just a network problem, already happen and rerun it make it pass

dense-ev is passed in the scheduled check_project of this morning


✨ feat(VSecM Safe): 460 manual root key update k8s secret option

Manual Root Key Updates K8s Secret
Description
VSECM_MANUAL_ROOT_KEY_UPDATES_K8S_SECRET env variable added for giving an option to updating internal k8s secrets when manual root key provided
Changes

Renamed app/safe/internalprivates.go to app/safe/internal/bootstrap/persist.go since we use this function in the app/safe/internal/server/route/receive.go to persist keys with the manual root key. Therefore, it's not private to bootstrap anymore.
Added VSECM_MANUAL_ROOT_KEY_UPDATES_K8S_SECRET to core/safe.go with its unit tests.
Although they belong to the v0.23.0, I assumed that this is the main branch and the changes should reflected in the next version, so I added the VSECM_MANUAL_ROOT_KEY_UPDATES_K8S_SECRET env variable to the following yaml files:

k8s/0.23.0/local/vsecm-distroless.yaml
k8s/0.23.0/local/vsecm-distroless-fips.yaml
k8s/0.23.0/local/vsecm-photon.yaml
k8s/0.23.0/local/vsecm-photon-fips.yaml
k8s/0.23.0/remote/vsecm-distroless.yaml
k8s/0.23.0/remote/vsecm-distroless-fips.yaml
k8s/0.23.0/remote/vsecm-photon-fips.yaml
helm-charts/0.23.0/charts/safe/values.yaml

Added VSECM_MANUAL_ROOT_KEY_UPDATES_K8S_SECRET information details to docs/_pages/0110-configuration.md file

Test Policy Compliance

[x] I have added or updated unit tests for my changes.
[x] I have included integration tests where applicable.
[x] All new and existing tests pass successfully.

Code Quality

[x] I have followed the coding standards for this project.
[x] I have performed a self-review of my code.
[x] My code is well-commented, particularly in areas that may be difficult
to understand.

Documentation

[x] I have made corresponding changes to the documentation (if applicable).
[x] I have updated any relevant READMEs or wiki pages.

Checklist
Before you submit this PR, please make sure:

[x] You have read the contributing guidelines and
especially the test policy.
[x] You have thoroughly tested your changes.
[x] You have followed all the contributing guidelines for this project.
[x] You understand and agree that your contributions will be publicly available
under the project’s license.

By submitting this pull request, you confirm that my contribution is made under
the terms of the project’s license and that you have the authority to grant
these rights.

Thank you for your contribution to VMware Secrets Manager
🐢⚡!

Approved; however, there are merge conflicts.

I’m intentionally holding this merge (and all other risky merges) until Friday.

Closing this pull request due to the many conflicts. The new PR can be found at https://github.com/vmware-tanzu/secrets-manager/pull/725


Leave a comment if CI on the release branch fails

If CI on the release branch fails, the package won’t be able to be published. In most cases, it’s a flake, so it just needs to be re-rerun. It would be helpful if the bot could leave a comment in the publish issue every time the CI fails on the release branch, and point users to either remake the branch, re-run CI or fix the tests.

I played around with it, and at the time of failure, complete logs are not available yet, thus we don't have an easy access to them :(

IMO even just a simple comment is a good start - like hey look at the check runs as there is something wrong.

How is that any different from what we have now? When it fails, the comment says:
Failed to publish. ([error logs](https://github.com/getsentry/publish/actions/runs/2029660149?check_suite_focus=true#step:8))

Bad branch? You can [delete with ease](https://github.com/getsentry/sentry-java/branches/all?query=6.0.0-alpha.4) and start over.

And then when you click on it, the logs say:

Build(s) for revision 4f8b0ef679a7f06233e8685abe4ed7af60b104b4 have not succeeded. Please check the revision's status.

Without accepted, there is no action in progress, so we'd have to somehow pool it using cron, which would go through every open issue and get it's related repo status. I don't think its feasible tbh  :3

Fair, I'll close for now then, thanks for taking a look!


Split error with eslint-plugin-import

Hi all,
I'm trying by any mean to add to CRA v4 the airbnb config. It seems it is calling eslint-plugin-import (v2.23.4) and I run into this error:
>eslint --ext ts,tsx .

Oops! Something went wrong! :(

ESLint: 7.28.0

TypeError: Cannot read property 'split' of undefined
Occurred while linting .../src/Platform/theme.ts:2
    at checkDependencyDeclaration (.../node_modules/eslint-plugin-import/lib/rules/no-extraneous-dependencies.js:133:40)
    at reportIfMissing (.../node_modules/eslint-plugin-import/lib/rules/no-extraneous-dependencies.js:187:38)
    at commonjs (.../node_modules/eslint-plugin-import/lib/rules/no-extraneous-dependencies.js:264:7)
    at checkSourceValue (.../node_modules/eslint-module-utils/moduleVisitor.js:29:5)
    at checkSource (.../node_modules/eslint-module-utils/moduleVisitor.js:34:5)
    at .../node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (.../node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (.../node_modules/eslint/lib/linter/node-event-generator.js:293:26)
    at NodeEventGenerator.applySelectors (.../node_modules/eslint/lib/linter/node-event-generator.js:322:22)

What seems to trigger this is the following lines from theme.ts:
import { Styles } from '@material-ui/styles/withStyles'
Which seems valid to me...
Here is my config:
"devDependencies": {
        "@testing-library/jest-dom": "^5.12.0",
        "@testing-library/react": "^11.2.7",
        "@types/history": "^4.7.8",
        "@types/jest": "^26.0.23",
        "@types/react": "^17.0.8",
        "@types/react-dom": "^17.0.5",
        "@types/react-dropzone": "^5.1.0",
        "@types/react-imageloader": "^2.1.10",
        "@types/superagent": "^4.1.11",
        "escodegen": "^1.14.1",
        "eslint-config-airbnb": "^18.2.1",
        "eslint-config-prettier": "^8.3.0",
        "eslint-plugin-import": "^2.23.4",
        "eslint-plugin-jsx-a11y": "^6.4.1",
        "eslint-plugin-react": "^7.24.0",
        "eslint-plugin-react-hooks": "^1.7.0",
        "eslint-plugin-prettier": "^3.4.0",
        "esprima": "^4.0.1",
        "estraverse": "^5.0.0",
        "husky": "^6.0.0",
        "prettier": "2.3.0",
        "typescript": "^4.3.2"
    },
    "dependencies": {
        "@date-io/moment": "^2.10.11",
        "@material-ui/core": "^4.11.4",
        "@material-ui/icons": "^4.11.2",
        "@material-ui/lab": "^4.0.0-alpha.58",
        "@material-ui/pickers": "^3.3.10",
        "clsx": "^1.1.1",
        "fuse.js": "^6.4.6",
        "google-map-react": "^1.1.5",
        "history": "^5.0.0",
        "lint-staged": "^11.0.0",
        "lodash": "^4.17.21",
        "mobx": "^4.13.0",
        "mobx-react": "^6.1.3",
        "moment": "^2.29.1",
        "qrious": "^4.0.2",
        "quill": "^1.3.7",
        "quill-magic-url": "^3.0.2",
        "react": "^17.0.2",
        "react-beautiful-dnd": "^13.1.0",
        "react-big-calendar": "^0.33.5",
        "react-dimensions": "^1.3.1",
        "react-dom": "^17.0.2",
        "react-dropzone": "^11.3.2",
        "react-measure": "^2.5.2",
        "react-meta-tags": "^1.0.1",
        "react-scripts": "4.0.3",
        "react-select": "^4.3.1",
        "react-webcam": "^5.2.4",
        "smoothscroll": "^0.4.0",
        "superagent": "^6.1.0",
        "throttle-debounce": "^3.0.1",
        "urijs": "^1.19.6"
    },
    "eslintConfig": {
        "extends": [
            "react-app",
            "airbnb",
            "prettier"
        ],
        "rules": {
            "no-unused-vars": "off",
            "@typescript-eslint/no-unused-vars": [
                "error"
            ],
            "no-extraneous-dependencies": "off"
        }
    },

Important to know :

I do not have an .esllintrc
I setup the eslint config with init from eslint

Any help is welcome!
Thanks

Same here, with an import like this:
import mapboxGl, { GeoJSONSource } from 'mapbox-gl';

Downgrading to 2.23.3 fixes it.
Seems like the issue may be related to this commit. https://github.com/benmosher/eslint-plugin-import/commit/da8d584fc22495a10e04206619c117baa2760898

Just to confirm - is the dependency being imported actually installed?

Just to confirm - is the dependency being imported actually installed?

Yes, in my case, I am using typescript, and I have mapbox-gl and @types/mapbox-gl installed.
In VSCode, mapboxGl is showing as a namespace and GeoJSONSource is showing as a class, both found in index.d.ts in @types/mapbox-gl

altho this is unrelated to the crash here, dev deps are only for things needed to develop the package - things that are needed at runtime must be runtime dependencies.

altho this is unrelated to the crash here, dev deps are only for things needed to develop the package - things that are needed at runtime must be runtime dependencies.

That's a good point. I need to revisit my dependency strategy, but in the meantime all of my runtime dependencies are treated like peerDependencies/external and are installed on my repos that use the (private) library, and I moved them to devDependencies to mitigate some conflicts I was having.

@uturnr it's fine if they're both peerDeps and devDeps - that's correct, it's just imposing a lot of unnecessary burden on consuming projects - they just can't be only devDeps.

I'm trying to reproduce it without success.
What is the resolver you're using ?

I can add a NPE to avoid the crash on split part in case of

here is the PR: #2121

@paztis Can I provide you with more info?

PS: I can back @uturnr as downgrading to 2.23.3 fixes it.

If you can add a log in the no-extraneous-dependenxies.js file at line 186
I'd like to see the value of variable 'resolved' and 'realPackageName'

@paztis, hmm, this is strange. package.json is there in node_modules/mapbox-gl. It matches the package.json on github for the version I have installed: https://github.com/mapbox/mapbox-gl-js/blob/v2.2.0/package.json.
However there is an empty package.json (contains only {}) in mapbox-gl/dist (https://github.com/mapbox/mapbox-gl-js/blob/main/dist/package.json), and that is the file that is read by readPkgUp.  Deleting that package.json file locally makes the error go away.

Better understand this problem now. We need to inspect the package.jsob to lookup on parents level of it didn't fit to the real package

I will try to do it this evening

I created the repro repo https://github.com/ertrzyiks/extraneous-dependencies-demo

after looking the content of @material-ui/core and mapbox-gl, I notice all the intermediate package.json have no name field.
Can I consider until I found a name file I look the parent level, recursively ?

Correct fix now (and unit test) done in #2121
The trick is ti survey if a name is provided in the package.json, what is not the case for ESM modules.
if not I continue to recurse until I found the correct package.json

Hey, I'm also experiencing this - going to float the patch in the meantime. Just sharing in case you need help isolating this issue though it looks like Paztis already has a grip on the issue.

Hi. Fix is done in PR #2121.
Not sure it is merge now

(I was more saying that I am able to help with reproducing/debugging if that's needed - I'm fine with waiting for the fix a few weeks I'm in no rush - but thanks!)

I can confirm that this can be reproduced by this also
import { HomeIcon } from '@heroicons/vue/solid'

I ran into this exact same error today when I was running NextJS's new eslint-config-next, and it turned out to be that I had a bad packageDir value in the array calculated from my monorepo
this is how I calculate packageDir in my .eslintrc.js config now
const {sync} = require('glob');
// ... rest of config
'import/no-extraneous-dependencies': [
  'error',
  {
    packageDir: ['.', ...sync(`./packages/*`)],
  },
],


Channel picker too wide

I've been trying to get familiar with this plugin and have been trying to get it to work on some mother machine data from my lab. I haven't been able to get past the TIFFConverter and Compile steps though. They run fine but then I get to the channel picker and it gives me huge sections to choose from that cover many channels rather than just one. I've tried using my own tiffs, starting over the whole process with a .nd2 file, changing the channel width and separation values but nothing seems to be changing the outcome for me. How can I fix this?
I've attached a screenshot of the channel picker and the contents of what was in the analysis folder.
Sorry if this is a dumb question, I've new to this kind of software.
Thanks in advance!

channel_masks.txt
crosscorrs.txt
TIFF_metadata.txt

Hi,
Not a dumb question! The channel picker struggles sometimes when there are large regions without any channels in the image. Can you try cropping out the empty right hand region and running it again?

Hello!
Is there a simple way to crop in the x-axis for all the TIFFs created from the TIFFconverter?
Thank you!

Glad you got it working! In any case, this got me to add the option to crop along the x axis in TIFFconverter - if you pull the current version and relaunch napari (no need to reinstall the plugin) it should show up.

Added x-axis cropping in TIFFConverter (still needs interactivity though)


Adding metallb crd to bundle

Signed-off-by: jonahjon<EMAIL_ADDRESS>Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve
/lgtm


2.6.1 rc

Pull Request Etiquette
There are several guidelines you should follow in order for your Pull Request to be merged.
Replace [ ] with [x] to cross the checkbox.

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the contributing guidelines.

It is sometimes better to include more related changes in a single commit.
If you find yourself having an overwhelming amount of commits, you
can rebase your branch.

Changes
2.6.1 with Comparison changes removed to be added later.

tagging for self-close #155


[Question/Feedback]: Using Custom tags to enable/disable monitoring

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Description
In the documentation for Disabling Policies there is a part about MonitorDisable parameter that says the following:

This is easily adjusted to use existing tags, for example you could configure the parameter with the tag name “Environment” and tell it to deploy only if the tag value equals “prod”, or when the tag isnt equal to “dev”.

However, looking at the source code in the repo it is not clear to me how to change this, as the MonitorDisable is hardcoded in each Deploy file and 282 times in the policies.json file. It might be easy to customize, but as someone who's just starting with using AMBA it's not clear to me by just reading the documentation.

Hello @MarcoJanse,
thanks for your feedback. At the moment the parameter is not exposed in the Param file and so it must be changed in the code. As a quick workaround you can create that tag on the resource you want to disable the monitoring for. In the meantime we will work on your feedback to either make the parameter name a choice or to align the documentation.
Thanks,
Bruno.

It would be really useful if we could specify multiple tags - Azure Databricks compute clusters spin up their own resources, and with a Deny policy so we can't change the tags on them. But it does add its own tags such as ClusterID, ClusterName, databricks-instance-name, DatabricksEnvironment etc. As these clusters can have short lifetimes, we get a heap of Resource Unhealthy alerts when they are down or deleted. Being able to check for MonitorDisable or (custom tag) would solve this problem, we could simply add databricks-instance-name to the list of tags to exclude alerting on.

Hello @lansalot ,
sorry for replying late. We added this feature request to our backlog. However, we cannot an ETA for the release at the moment.
Thanks!


Please add "# encoding: utf-8" to the top of footnotes.rb

Line 54 of footnotes.rb contains a unicode character and the plugin crashes with this error
   .../jekyll-footnotes-0.6.1/lib/jekyll/footnotes.rb:54:
  syntax error, unexpected $end, expecting keyword_end
  ..., @id)}\" class=\"backlink\">⏎
"

It can be fixed by specifying the encoding in the file.

Which version of Ruby are you using? My understanding is that UTF-8 has been the default encoding for quite some time (I think all of 2.x, but correct me if I'm wrong). I'd love to learn more if you have good resources to point to. Maybe it's a problem on only certain platforms?

 My understanding is that UTF-8 has been the default encoding for quite some time (I think all of 2.x, but correct me if I'm wrong). I'd love to learn more if you have good resources to point to. Maybe it's a problem on only certain platforms?
—
Reply to this email directly or view it on GitHub.


Fix some lint warnings

This commit improves lint score from 9.55 to 9.63.

@googlebot I signed it!

Codecov Report

Merging #58 into master will decrease coverage by 41.24%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #58       +/-   ##
==========================================
- Coverage   41.24%   0.00%   -41.25%
==========================================
  Files          37      37
  Lines        3860    3743      -117
==========================================
- Hits         1592       0     -1592
- Misses       2268    3743     +1475

Impacted Files
Coverage Δ

silk/hw/hw_resource.py
0.00% <0.00%> (-60.53%)
:arrow_down:

silk/node/base_node.py
0.00% <0.00%> (-52.67%)
:arrow_down:

silk/node/fifteen_four_dev_board.py
0.00% <0.00%> (-28.82%)
:arrow_down:

silk/node/sniffer_base.py
0.00% <0.00%> (ø)

silk/node/wpan_node.py
0.00% <0.00%> (-65.25%)
:arrow_down:

silk/node/wpantund_base.py
0.00% <0.00%> (-27.23%)
:arrow_down:

silk/postprocessing/util.py
0.00% <0.00%> (-100.00%)
:arrow_down:

silk/tests/silk_replay.py
0.00% <0.00%> (-87.43%)
:arrow_down:

silk/tests/silk_run.py
0.00% <0.00%> (ø)

silk/tests/testcase.py
0.00% <0.00%> (ø)

... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73b1e57...7242f84. Read the comment docs.

Thanks for contributing, Colin!
-- Colin


fix(version): update ngx-base to 2.2.7

@fabric8cd fabric8/fabric8-ui:SNAPSHOT-PR-2221-1 is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-2221-fabric8-planner.badger.fabric8.io


Please update the source code for iOS

The latest iOS code in Github seems to be extremely out of date (version 1.1.4), will it ever get updated to the latest version (2.3.0)?

My understanding is "no".


added higher resolution assets

I've added a higher-res set of leauge tier assets for paladins.
Where:
.assets/paladins/league-tier/high-res/
I chose to create a new folder instead of adding a HD or HQ suffix. I will change if requested.
Note:
The new images are not square images!
Assets From: https://github.com/DevilXD/PaladinsAssets
Thanks @DevilXD!

@Likqez I've add you as Collaborator, so you can create new folder if you want to

@Likqez I've add you as Collaborator, so you can create new folder if you want to

Thank you! If theres anything to discuss, feel free to contact me thru any of the given platforms on my profile.


[MetaSchedule] Enhance Database Validation Script

Following up on #12948, this PR further enhances the validation script by

[x] Reusing same TIR results for speed up
[x] Reusing RPCRunner for benchmarking & validation at the same time
[x] Consolidate output interface and output maximum difference if wrong answer
[x] Support Top-K validation (superfast for relay compilation validation)
[x] Skip failed tuning records
[ ] Support Tensorized records (to be tested)
[x] Allow batch build

Sample output looks like this:
Python Environment
  TVM version    = 0.11.dev0
  Python version = 3.8.13 (default, Mar 28 2022, 11:38:47)  [GCC 7.5.0] (64 bit)
  os.uname()     = Linux 5.18.10-76051810-generic #202207071639~1657252310~21.10~7d5e891 SMP PREEMPT_DYNAMIC Fri J x86_64
CMake Options:
  {
    "BACKTRACE_ON_SEGFAULT": "OFF",
    "BUILD_STATIC_RUNTIME": "OFF",
    "COMPILER_RT_PATH": "3rdparty/compiler-rt",
    "CUDA_VERSION": "NOT-FOUND",
    "DLPACK_PATH": "3rdparty/dlpack/include",
    "DMLC_PATH": "3rdparty/dmlc-core/include",
    "GIT_COMMIT_HASH": "490e0e3120f304a98607770502b5700ec6ab9d55",
    "GIT_COMMIT_TIME": "2022-11-18 10:02:55 -0800",
    "HIDE_PRIVATE_SYMBOLS": "ON",
    "INDEX_DEFAULT_I64": "ON",
    "INSTALL_DEV": "OFF",
    "LLVM_VERSION": "12.0.1",
    "PICOJSON_PATH": "3rdparty/picojson",
    "RANG_PATH": "3rdparty/rang/include",
    "ROCM_PATH": "/opt/rocm",
    "SUMMARIZE": "OFF",
    "TVM_CXX_COMPILER_PATH": "/usr/bin/c++",
    "USE_ALTERNATIVE_LINKER": "AUTO",
    "USE_AOT_EXECUTOR": "ON",
    "USE_ARM_COMPUTE_LIB": "OFF",
    "USE_ARM_COMPUTE_LIB_GRAPH_EXECUTOR": "OFF",
    "USE_BLAS": "none",
    "USE_BNNS": "OFF",
    "USE_BYODT_POSIT": "OFF",
    "USE_CCACHE": "AUTO",
    "USE_CLML": "OFF",
    "USE_CLML_GRAPH_EXECUTOR": "OFF",
    "USE_CMSISNN": "OFF",
    "USE_COREML": "OFF",
    "USE_CPP_RPC": "OFF",
    "USE_CUBLAS": "OFF",
    "USE_CUDA": "/usr/local/cuda-11.8/",
    "USE_CUDNN": "ON",
    "USE_CURAND": "ON",
    "USE_CUSTOM_LOGGING": "OFF",
    "USE_CUTLASS": "OFF",
    "USE_DNNL": "OFF",
    "USE_ETHOSN": "OFF",
    "USE_FALLBACK_STL_MAP": "OFF",
    "USE_GRAPH_EXECUTOR": "ON",
    "USE_GRAPH_EXECUTOR_CUDA_GRAPH": "OFF",
    "USE_GTEST": "AUTO",
    "USE_HEXAGON": "OFF",
    "USE_HEXAGON_EXTERNAL_LIBS": "OFF",
    "USE_HEXAGON_GTEST": "/path/to/hexagon/gtest",
    "USE_HEXAGON_RPC": "OFF",
    "USE_HEXAGON_SDK": "/path/to/sdk",
    "USE_IOS_RPC": "OFF",
    "USE_KHRONOS_SPIRV": "OFF",
    "USE_LIBBACKTRACE": "ON",
    "USE_LIBTORCH": "OFF",
    "USE_LLVM": "llvm-config-12 --link-static",
    "USE_METAL": "OFF",
    "USE_MICRO": "OFF",
    "USE_MICRO_STANDALONE_RUNTIME": "OFF",
    "USE_MIOPEN": "OFF",
    "USE_MKL": "OFF",
    "USE_MSVC_MT": "OFF",
    "USE_NNPACK": "OFF",
    "USE_OPENCL": "OFF",
    "USE_OPENCL_GTEST": "/path/to/opencl/gtest",
    "USE_OPENMP": "none",
    "USE_PAPI": "OFF",
    "USE_PROFILER": "ON",
    "USE_PT_TVMDSOOP": "OFF",
    "USE_RANDOM": "ON",
    "USE_RELAY_DEBUG": "OFF",
    "USE_ROCBLAS": "OFF",
    "USE_ROCM": "OFF",
    "USE_RPC": "ON",
    "USE_RTTI": "ON",
    "USE_RUST_EXT": "OFF",
    "USE_SORT": "ON",
    "USE_SPIRV_KHR_INTEGER_DOT_PRODUCT": "OFF",
    "USE_STACKVM_RUNTIME": "OFF",
    "USE_TARGET_ONNX": "OFF",
    "USE_TENSORFLOW_PATH": "none",
    "USE_TENSORRT_CODEGEN": "OFF",
    "USE_TENSORRT_RUNTIME": "OFF",
    "USE_TFLITE": "OFF",
    "USE_TF_TVMDSOOP": "OFF",
    "USE_THREADS": "ON",
    "USE_THRUST": "OFF",
    "USE_UMA": "OFF",
    "USE_VITIS_AI": "OFF",
    "USE_VULKAN": "OFF"
  }
2022-11-21 16:19:36.788 INFO LocalBuilder: max_workers = 24
Total 1221 records to be validated. Collected in  0.000 sec.
Total 20 unique original TIR to validate. Deduplicated in  0.358 sec.
Top 10 records for each original TIR will be validated.

 Total time spent:  168.474 sec.


7_14 to 7_21 to do list

A list to adjust the figures and the manuscript:

[ ] 1. Figure 1 (using figure 2 to build the two sets of population Dr. Meyer mentioned.)

A population where there is only one state and at the end, the cell number reaches ~ N
A population with two states where one state is almost quiescent and the other grows fast, so at the end, cell number reaches ~N. @jclagarde @Farnazmdi

[ ] 2. Increasing cell number by depth + breadth in figure 3 @Farnazmdi

[ ] 3. Increasing cell number in figure 3 to smooth the sharp edges of sd ribbon @shak360

[ ] 4. Rearranging figure 4 into 2 x 2 figures, in the top row there is the cartoon, and in the bottom, we have the accuracy and the distribution plot.

[ ] 5. Rearranging figure 5 into 2 x 2 figures, in the top row there is the cartoon, and in the bottom, we have the accuracy. Also, the scaling problem of the cartoon (one tree is removed)

[ ] 6. Checking the accuracy @shak360

[ ] 7. Writing captions for figures and editing the result subtitles. @Farnazmdi

[ ] 8. Simulating the model with the raw data for control conditions, maybe doing AIC.

[ ] 9. Writing some content for figure 3.

[ ] 10. Writing some content for figure 4. @Farnazmdi

[ ] 11. Writing some content for figure 5.

[ ] 12. Writing some content for figure 6.

Let's take one or two tasks from this so we won't work on the same issue at a time.
And please modify if I have forgotten something.

Wait sorry @Farnazmdi, is something happening on the 17th that requires this list to be completed?

sorry my bad! for some reason I thought today is 10th!!

Don't want to make this very long, so I close this and open another one.


[Enquiry] directory partition

Hi man, how are you.
I would like to ask how to put all the front-end in the app directory, i.e. on the same level as the server.
Is it necessary to depend on this package, @nuxthub/core

Hi,
it is because I set the compatibility version of this project to Nuxt 4 and it has a new directory structure.
https://nuxt.com/docs/getting-started/upgrade#testing-nuxt-4


Restore functionality of max_depth=0 in hist

Closes #7543

Tried to backport this PR but there's a conflict.  Will keep it to next major release.


Change str representation of bfloat16 NDArray from uints to floats.

print(mx.nd.arange(1, 5, dtype=[('bfloat16', np.uint16)]))
Before: [(16256,) (16384,) (16448,) (16512,)]
After: [1. 2. 3. 4.]
Resolves #18788

@mxnet-bot run ci [greeting]

@mxnet-bot run ci [all]

Yes, sorry, here is part of our discussion on this:

I was looking for a solution that doesn't require copying, and Andrzej's solution of setting numpy's formatter seems to be the only way to achieve this, but there are 2 problems.
The first one is that the user cannot change the way floats are printed, as numpy does not format scalars (the lambda we provide to the formatter takes scalar as argument). There is a hack to overcome this problem: putting each element into a 1-element ndarray and removing '[' and ']' from its string representation, but because now each element is treated separately, each may be displayed in a different form (chosen by numpy), which differs from the way numpy prints ndarrays - using only one notation.
The second problem is the performance. Printing bigger arrays is significantly slower using this solution, as we are doing computation on the python side (changing from bfloat16 to float32).
In the end, I chose Bartłomiej's solution, as it was easy to understand, consistent with numpy and fast.

Where Bartłomiej's solution is the one proposed in this PR, and here is the code of the other solution (without copying):
    def __str__(self):
        if self.dtype == np.dtype([('bfloat16', np.uint16)]):
            def castToBFloat16(value):
                return struct.unpack("@f", struct.pack("@I", np.uint32(value) << 16))[0]
            po = np.get_printoptions()
            po['formatter'] = {}
            po['formatter']['int_kind'] = lambda x: str(np.array([castToBFloat16(x)]))[1:-1]
            with np.printoptions(**po):
                return super(NDArray, self).__str__()
        else:
            return super(NDArray, self).__str__()

@mxnet-bot run ci [centos-gpu, edge]


Support Rider as external editor for Godot mono version

Allows to select Rider as external editor.
On attempt to open file Rider executable would be located and stored to a setting.
Setting can be manually edited to use different Rider installation.
Next time on attempt to open file path from that setting would be used if it still exists.
related to https://github.com/godotengine/godot/issues/15913

It would be great if Rider made use of the IdeConnection library for debugging and also for quicker file opening (command line seems to have a noticeable delay). I wanted to make a plugin for Rider as it's the IDE I use, but I can't tell when I will have time to (most likely not before June of next year).

It would be great if Rider made use of the IdeConnection library for debugging and also for quicker file opening (command line seems to have a noticeable delay). I wanted to make a plugin for Rider as it's the IDE I use, but I can't tell when I will have time to (most likely not before June of next year).

After New Year I would definitely try to add something more (in a separate PRs).

Could you squash commits into one? See PR workflow.

I wonder why for this repo squashing/merging/rebasing is not available directly in the github UI. Normally it should be. However I am on it.

It is available, but we don't use it, as it doesn't fit well in our workflow and requirements for a clean, self-documenting Git history.

Thanks!


fix, refactor(sequencer): refactor ics20 logic

Summary
Refactors sequencer ics20 logic to improve clarity and to fix incorrect withdrawal targets and bridge locks.
Background
This PR started with the goal of using Ics20WithdrawalFromRollup.rollup_return_address when emitting ics20 deposit events instead of the rollup's bridge address (which for the rollup was quite meaningless).
However, because the original logic was difficult to follow this patch clears up the logic significantly so that the fix can be understood more easily within that context.
Changes

Refactor ics20 logic: split up execute_ics20_transfer into two functions receive_tokens and refund_tokens
Use Ics20WithdrawalFromRollup.rollup_return_address instead of bridge address when emitting deposit events for withdrawals that originated on a rollup
Fix bridge lock events of source tokens being emitted with an extra (port, channel) pair added instead of having its leading (port, channel) pair stripped (the resulting token is likely completely meaningless and not understood by the rollup).

Testing
Renamed and expanded tests to also check for the correct asset being emitted in bridge lock events, and the correct rollup return address being emitted in refunds. Specifically these tests:

receive_source_asset_on_bridge_account_and_emit_to_rollup
receive_sink_asset_on_bridge_account_and_emit_to_rollup
refund_rollup_with_sink_asset
refund_rollup_with_source_asset
refund_rollup_with_compat_prefix

Related Issues
Closes https://github.com/astriaorg/astria/issues/1439
Closes https://github.com/astriaorg/astria/issues/1496

Rebased on top of recent main.
In addition I instrumented all code that's called during ics20 execution, injecting address information, assets, amounts, etc into the generated spans. Function calls using eyre Reports as errors also generates an event in error cases.


Develop stencil component

TODO

[ ] Develop basic functionality of component based on model and style requirements documentation

Outcomes

Basic JS component

Deliverables

Functional JS component with limited styling

Estimated Effort

[ ] XS: 1 to 2 hours
[ ] S: half a day
[ ] M: 1-2 day
[x] L: 1 week
[ ] XL: Move to an epic

Out of scope

First version is up on site-menu branch.
Things that still need to be done:

Fix split variant
Add toolbar mobile-task
Optimize CSS loading
Add data states
Add i18n

Scoped to our use case on the alpha documentation site. Will revisit after MVP.


generate router

I'm playing around with the router in a plain vanilla k8s cluster. When I do the helm generate router, it says that it ran 0 generators. Is this normal?
When I do deploy I get a permission denied error related to the service account. I'm trying to figure out if I'm not getting the template built correctly or if I've got more SELinux issues.

@stevesloka it appears that the router chart itself does not contain any templates, so helm generate will not run any generators.

Ok sweet, sorry for the confusion, just my noobness to helm. Thanks!

When I do deploy I get a permission denied error related to the service account.

Can you see if the deis-router service account exists and whether it has any secrets associated with it?
It's a known issue (which we can't do anything about) that service accounts and their secrets don't work if SSL isn't set up correctly within your k8s cluster.  i.e. the controller manager must have a CA for signing API tokens, and the apiserver must trust that CA.
See #101 for more details.

Thanks @krancour, I think SSL might be my issue. My cluster in question is using tokens to auth. My other cluster which does have certs deployed just fine.


[iOS] Extensibility to override/add/remove action renderers

Automatically generated task. Any updates to the title and body will be overwritten. Do NOT modify the labels.
iOS implementation of #1671

Closing, was already supported


how to set or get metadata?

PutObjectOptions.UserMetadata
StatObject -> ObjectInfo.UserMetadata (comment is only true for listing).

i want to use http put to to it


Broken docs-gen GHA workflow on pushes to main

Do you have a suggestion for code improvement or tracking existing technical debt? Please describe.
The docs-gen workflow appears to be broken on pushes to main. See https://github.com/k8sgateway/k8sgateway/actions/runs/12321634754/job/34393478118 for a recent main branch commit that failed that check.
Looking at the linked GHA run logs:
HEAD is now at f4c4dea Merge pull request #70 from solo-io/version-link-fix
go run cmd/generate_docs.go gen-releases -r gloo > opensource.out
go run cmd/generate_docs.go gen-releases -r glooe > enterprise.out
go run cmd/generate_docs.go gen-changelog-md -r gloo > content/static/content/gloo-changelog.docgen
Error: GET https://api.github.com/repos/k8sgateway/k8sgateway/releases?page=1&per_page=100: 401 Bad credentials []
Usage:
   gen-changelog-md [flags]

Flags:
  -h, --help   help for gen-changelog-md

Global Flags:
  -r, --TargetRepo string   specify one of 'gloo' or 'glooe' (default "gloo")

2024/12/13 19:16:11 unable to run: GET https://api.github.com/repos/k8sgateway/k8sgateway/releases?page=1&per_page=100: 401 Bad credentials []

The issue appears to be centered around having to update authentication to hit the GH API.
Describe the solution you'd like
Fix the docs-gen GHA workflow or remove that workflow if it's no longer required.
Additional Context
N/A.

See https://github.com/k8sgateway/k8sgateway/issues/10363 for the high-level tracker.


Modify checkpoint/restore metadata location

As a follow-up to #22049, @mlaventure made a request to move the metadata location for criu checkpoints to a non-single-container specific directory, such as /var/lib/containers/checkpoints.
This issue will track that work and the request that this happen prior to the 1.13 release.
cc: @boucher

@crosbymichael: any thoughts on this?

We need a way to ensure that the checkpoint is atleast compatible with the image/container that people want to use it with.

Right.
What I like about the current setup is that the defaults seem sane -- if you're working with one container, things should generally work and be pretty easy to do.
What I'd like to add is simply the ability to specify a different storage location. It's kind of an escape hatch for people who want to do more complicated things, but with sort of an implicit "hey this is now your responsibility to figure out".

I'm happy to keep the checkpoint tied to the container lifecycle to start even though it'd be in a different location (i.e. remove them once the container disappear).
It will make it easier to implement the other feature later at our own leisure

why not tie it to an image?

@crosbymichael It's more than the image. You also need to make a copy of the RWLayer of the container when the checkpoint is created among other things.
We can start by moving the checkpoints folder outside of the container's one while still leaving it under /var/lib/docker.
The rest can be added in another PR. That will be easier (and faster) than doing everything at once.

@mlaventure , to @boucher's point, let's keep it simple for now and just store the checkpoint as an "escape hatch" without validation.

Is there any way that the persistent volumes used by the container are snapshot-ed as well. If not then how does the container-app restored to an earlier checkpoint deal with its data. Sorry if I'm spamming the wrong thread, but don't see a place to post this question and didn't want to make an issue just to ask.

@mlaventure Are you imagining storage like this:
/var/lib/docker/checkpoints/<checkpoint_id>/

or like
/var/lib/docker/checkpoints/<container_id>/<checkpoint_id>/

If the former, how do you propose tracking the relationship between container and checkpoint (since it seems like we weren't talking about removing that at this point)?

@boucher more like the former (/var/lib/docker/checkpoints/<checkpoint_id>/)
I don't want to remove the relationship with the container initially. Adding the container id as a metadata file initially could serve as a link between the checkpoint and the container.
Removing this relationship can be done later as this involve a lot more code to be changed.
I just want to avoid having to create a migration routine later on, once we get ready to cut that link.

Seems like we'd need to store the metadata in the container folder still,
not in the checkpoint -- otherwise we'd have to scan every checkpoint to
perform any operation.
On Mon, Sep 19, 2016 at 12:19 PM Kenfe-Mickaël Laventure <
<EMAIL_ADDRESS>wrote:

@boucher https://github.com/boucher more like the former (
/var/lib/docker/checkpoints/<checkpoint_id>/)
I don't want to remove the relationship with the container initially.
Adding the container id as a metadata file initially could serve as a
link between the checkpoint and the container.
Removing this relationship can be done later as this involve a lot more
code to be changed.
I just want to avoid having to create a migration routine later on, once
we get ready to cut that link.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/docker/issues/26451#issuecomment-248040577,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABWMSy59E7dSZ3fzU7MP7JOEPc3O1lLks5qrrYOgaJpZM4J5Srj
.

We could build and keep a checkpoint map in memory on daemon start or have a list of associated checkpoints within the container folder.
Later on, the checkpoint folder should become be self sufficient

Another concern I'm having is that checkpoint IDs will need to be unique across all containers if we store them in a flat directory -- which seems not ideal.

I was thinking of handling them the same as for containers: a unique idea with a name associated with them, wdyt?

@mlaventure Is maintaining the association between checkpoints and containers, for now, purely for the purpose of tying the checkpoint to the container's lifecycle, or will it also continue to prevent the "cloning" use case of 1 checkpoint to N containers? I was hoping that supporting the cloning use case would be part of this work, or will this be follow up work? For me, supporting cloning in some way (in the short term) is much more important than completely decoupling checkpoints and containers and their lifecycles.

@tswift242 purely to keep tying the checkpoint to the container's lifecycle.
I rather decouple it in a follow up PR so we can fully consider what we will need to save alongside the checkpoint to make them as resilient as possible. I don't want the feature to just be a "know what you're doing" kind of command.

@mlaventure I completely understand wanting to come up with a solid design and plan for expanding the feature. I just wanted to point out that, from my perspective, if Docker is looking for checkpoints in a container-agnostic location (e.g. /var/lib/docker/checkpoints/), then it should be able to fulfill requests like docker start --checkpoint checkpoint1 container2, even if container2 wasn't the originally checkpointed container. That is, unless Docker specifically denies that operation because container2 wasn't the source of the checkpoint. It'd be great if Docker didn't go out of its way to do that validation while this is experimental, or at least provided an easy workaround to it in the short term (e.g. some override flag). Otherwise, it seems like cloning should work "for free" once the checkpoint storage location is moved.
Then again, I'm not familiar with the implementation, so I could be totally wrong.

experimental doesn't mean "unstable" anymore. It just means that the API/Interface may change, but the functionalities provided ought to be working as if they were part of the stable release.
And just having docker trying to start a container other than the original with a checkpoint could lead to random/weird failure that the error message would definitely not explain and leads to extra issues here on github since the checkpoint in question is managed by the daemon.
It just wouldn't do for a nice user experience yet.
What you want is something akin for docker to accept an arbitrary path for the checkpoint (and hence handing over the responsibility of the sanity of said checkpoint to the user), but I'd say it's out of scope of this particular issue which purpose is just to move the checkpoint storage location.

Any updates on this?

Looks like this is the PR implementing this https://github.com/docker/docker/pull/26709

@thaJeztah https://github.com/docker/docker/pull/26709 is related and would be great to get in, but I think this issue is about something slightly different. I believe it was about move the default checkpoint storage location to start moving towards the vision of decoupling checkpoints and containers, in order to support more use cases out of the box, such as cloning. @mlaventure is this correct?

@thaJeztah yes, the 2 issues are different.
This one is about the metadata location for checkpoints managed by docker.
#26709 basically allow for checkpoint to live outside of docker.

Apologies, didn't read carefully :blush:


Crash when trying to start a container with devices

I'm trying to make nvidia-docker work with Rancher.  One workaround to make Rancher start a container w/out using the nvidia-docker executable is to just specify the devices and volumes needed to make things work, as described here: https://github.com/NVIDIA/nvidia-docker/wiki/nvidia-docker-plugin ( docker run -ti curl -s http://localhost:3476/v1.0/docker/cli?dev=0&vol=nvidia_driver nvidia/cuda)
So, e.g. my devices entries are:

/dev/nvidiactl -> /dev/nvidiactl

and so on.  For me, that curl results in the string --volume-driver=nvidia-docker --volume=nvidia_driver_352.63:/usr/local/nvidia:ro --device=/dev/nvidiactl --device=/dev/nvidia-uvm --device=/dev/nvidia0
So I created a standalone container in Rancher, but specifying devices under the Device Binding tab appears to cause a crash in the Rancher agent:
Traceback (most recent call last):
  File "/var/lib/cattle/pyagent/cattle/agent/event.py", line 95, in _worker_main
    resp = agent.execute(req)
  File "/var/lib/cattle/pyagent/cattle/agent/__init__.py", line 15, in execute
    return self._router.route(req)
  File "/var/lib/cattle/pyagent/cattle/plugins/core/event_router.py", line 13, in route
    resp = handler.execute(req)
  File "/var/lib/cattle/pyagent/cattle/agent/handler.py", line 34, in execute
    return method(req=req, **req.data.__dict__)
  File "/var/lib/cattle/pyagent/cattle/plugins/docker/compute.py", line 529, in instance_activate
    self._do_instance_activate(instance, host, progress)
  File "/var/lib/cattle/pyagent/cattle/plugins/docker/compute.py", line 600, in _do_instance_activate
    self._setup_device_options(create_config['host_config'], instance)
  File "/var/lib/cattle/pyagent/cattle/plugins/docker/compute.py", line 781, in _setup_device_options
    for dev, options in device_options.iteritems():
AttributeError: 'NoneType' object has no attribute 'iteritems'

I went into the container and added a simple None check to avoid the crash and the container launched just fine.  (i.e. set device_options to {} if it's None).  So this looks like a simple python bug that hopefully can get patched up easily.
Rancher Version:
rancher/agent:v1.0.2
Docker Version:
Docker version 1.9.1, build a34a1d5
OS and where are the hosts located? (cloud, bare metal, etc):
bare metal,  Ubuntu 14.04.4 LTS
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
single node rancher
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
cattle
Steps to Reproduce:
Create a container with devices under the Device Binding tab (as described above).
Results:
Container crashes due to stack trace cited.
Expected:
Container should start (as it does when the agent code is patched and agent container restarted).

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.