TypeScript implementation

This should represent all the main features for the implementation, to eventually resolve datafoodconsortium/connector-typescript#4, except for a few outstanding issues:

Failing to import several interfaces, such as IPerson, ISocialMedia, and IPhoneNumber, into classes Agent, Enterprise, etc. These seem to coincide with the features added in 2.1.0, or maybe that's just a red herring.
Misaligned types for getters in DefinedProducts, specifically getters for multiple properties that implement subclasses of ICharacteristic, such as getPhysicalCharacteristics, getAllergenCharacteristics. I haven't identified any others. Possibly something to do with the ISKOSConcept, which also seems to be having some issues getting imported correctly for the interface definitions.
No tests yet, and also need to find a good way to test the prefix mappings to the semantic IRI's (e.g., "dfc-b:Catalog").

Regarding those prefix mappings, I see that the PHP semantizer does have a setPrefix method that sets it for the connector:
https://github.com/datafoodconsortium/connector-codegen/blob/c177f39c80f6f7e3c71566e65caabd52afa175d5/src/org/datafoodconsortium/connector/codegen/php/static/src/Connector.php#L17-L21
But as far as I can tell, there's no such analog yet in the TypeScript semantizer.
I'm leaving this as a draft for now until those issues are resolved or worked around, but if easier to address them in the meantime by marking it for review, @lecoqlibre or @RaggedStaff, please go ahead!

2. Misaligned types for getters in DefinedProducts, specifically getters for multiple properties that implement subclasses of ICharacteristic, such as getPhysicalCharacteristics, getAllergenCharacteristics. I haven't identified any others. Possibly something to do with the ISKOSConcept, which also seems to be having some issues getting imported correctly for the interface definitions.

I fixed the underlying issues here, which I believe did stem from changes in 2.0.0. This leads me to think if first issue listed above, regarding imports for interfaces like ISocialMedia and IMainContactOwner, may indeed be related to the changes in 2.1.0.
I found that a similar issue, where ISKOSConcept failed to be imported and SKOSConcept was imported instead. I was able to remedy this in product.uml, where I changed the href from the id for SKOSConcept to ISKOSConcept (jgaehring/data-model-uml@2e78e7e):
-      <elementImport xmi:id="_SQ0AwOqNEeyCo6a7S9M9vA">
-        <importedElement xmi:type="uml:Class" href="skos.uml#_XhC24E2LEe2Pq5gmFYw1MQ"/>
+      <elementImport xmi:id="_6HIqYE76Ee2TpoYuSsmzTA">
+        <importedElement xmi:type="uml:Interface" href="skos.uml#_r06YgE1mEe2Pq5gmFYw1MQ"/>

I feel I'm starting to exceed my proper understanding of the UML model and don't want to be introducing changes like this without additional feedback. I'll see what headway I can make with the last issue, regarding tests, but will mark this ready for review so that others can suggest improvements.

Oh great, all those points make sense. Thanks, @lecoqlibre! :pray:

would need push access to your fork in order to add my commits to this PR, could you allow me?

I believe this is enabled now? If you have difficulty pushing to it let me know.

Old references to static context should be replaced with https://www.datafoodconsortium.org (in the Connector class and in tests)

Ah, yes I saw this in the original TS codegen when I tried to run the tests there too and wondered. I can do a quick search and replace easily enough and push that up first.

Abstract sub classes should not re-implement methods already implemented in parents (like some methods in Agent sub classes).

Got it, I think I can fix that easily enough.

Here's the commit with the substitutions I made for static.datafoodconsortium.org: jgaehring/connector-codegen@92f8218

I'm having a devil of a time with the tests. There are likely other issues (see * below), but a major hindrance seems to be related to the Jest test runner itself and using ECMAScript Modules instead of CommonJS, which seems linked to use of the NODE_OPTIONS=--experimental-vm-modules environment variable. This seems to be blocked by an open issue in Node itself. It's been open for a few years and there are some workarounds, but I'm still not sure I see what would work for our case, if that even is the problem. Here are the relevant issues:

https://github.com/jestjs/jest/issues/11434
https://github.com/nodejs/node/issues/37648
https://github.com/oas-tools/oas-tools/pull/366

Here's what the error message looks for one of the tests. Note it refers to a line 698, which is line 533 in the source, from the jest-runtime library.
 FAIL  test/Address.test.js
  ● Test suite failed to run

    request for './body.js' is not yet fulfilled

      at Runtime.linkAndEvaluateModule (node_modules/jest-runtime/build/index.js:698:5)

ReferenceError: You are trying to `import` a file after the Jest environment has been torn down. From test/Address.test.js.

Have you encountered anything like this, @lecoqlibre?
* = The other issue I referred to is an error that reads "IRIs can not be mapped to other IRIs", which I suspect is related to some of our previous discussions around IRIs, but I'm hesitant to begin diagnosing that problem until the issues with Jest are resolved. As it is, the IRIs error only appears sporadically, depending on whether the issue with Node ESM imports throws an exception or not, which is not ideal for debugging.

Have you encountered anything like this, @lecoqlibre?

Yes absolutely, same here. I encountered this issue in the previous version of the TS connector. I think I found a workaround but don't know if it can work for the new version and the evolution of Jest. Are you familiar with other test framework that we might use instead of Jest?

The other issue I referred to is an error that reads "IRIs can not be mapped to other IRIs"

I think it's related to the prefixes we are now using in the connector. I'm working on the Semantizer to add a setContext method like you suggested (instead of setPrefix).

Are you familiar with other test framework that we might use instead of Jest?

Actually, I've just about got the native Node.js test runner working. It was introduced with Node v.18 (LTS) back in 2022, so it's stable.
I was about ready to say I fixed it, but I wanted to try it out with a clean build of the generated code, and now I'm seeing some weird syntax errors in the generated TypeScript. I haven't changed anything on the Acceleo side, just the static files in typescript/static/test/ and the static package.json file. I'll report back when I figure it out, hopefully soon! :crossed_fingers:

Oh, and I've got one more commit I'm not pushing onto this branch just yet, b/c I didn't want to muddy the waters any further, but I removed some unnecessary async keywords, since they might interfere with the test runner or cause it to time out or something unexpected. Probably a best practice for either Jest or the Node test runner. Here are the diffs:
https://github.com/jgaehring/connector-codegen/compare/typescript...jgaehring:connector-codegen:async-tests

My last commit edaf89f integrates the dev (alpha.3) version of Semantizer. I changed the Semantizer dependency type to a GitHub repo, this way we can run npm update @virtual-assembly/semantizer every time changes are made.
@jgaehring I also updated dependencies of rdf-ext.
Also, note that we should use the UML model from the next branch of the data-model-uml repo when generating.
I merged your commits about using node:test and without some unnecessary async. I got all the tests passing except the ones for the import feature and the remover methods. For now we should comment the remover tests and expect Exceptions. I'm looking at how to fix the import tests. I think it's related to the context.
As the Semantizer has now a dedicated class which act like an environment, we should move in the future some components from the connector to the Semantizer (like I did for the PHP version). Especially import/export, store, factories.

I've got a start at the test generation (2c8507a). So far I'm just testing the constructor. There are a total of 109 tests with 99 passing and 10 failing. I've put the relevant tests and the full results up on this gist:
https://gist.github.com/jgaehring/bde27fe6991a289cc7016ed77bc1120e
There seem to be three kinds of errors that I'm not yet sure how to resolve:

Duplicate import statements, as in Enterprise.test.js, or missing imports, as in QuantitativeValue.test.js
Unknown ontology type in PlannedConsumptionFlow.test.js, which may be related to the Flow superclass or the ConnectorFactory, based on the stacktrace.
A weird issue where a plain string ends up as the test value for images in SuppliedProduct.test.js, which results in a images.forEach is not a function error b/c it should expect an array of strings. The generated PHP tests also has a plain string for the imates property, so maybe this is something to do with how the test values are generated?

I have to put this down for now, might not be able to pick it back up til later this week. It's taken me a bit longer than anticipated (what else is new), but if these issues can be knocked out, hopefully the getters and setters will follow in short order. :crossed_fingers:

@lecoqlibre / @jgaehring is this ready to merge ?

Yep I did not get a response from Jamie so I fixed the Changelog. I think we will have to add other details in the Changelog when we will be releasing the next version to really track all the work that have been done with this PR.

Oh hey! Sorry, I was tracking down where those updates to the CHANGELOG got lost. The branching history got a little wonky with some squashed commits and then when I introduced 50f48ee56fdd0d72e3e2e78141188150aad98cf9, but I think I'd resolved it from my fork. I wasn't 💯 sure it addressed the missing updates you were referring to, @lecoqlibre, so thanks for fixing and merging! And copy that w/r/t updating the CHANGELOG more fully before the next version gets tagged.
Otherwise, there is still the lingering issue of incomplete test generation. This was incompletely addressed with datafoodconsortium/connector-typescript#13. Apart from resolving the errors in the constructor tests, as mentioned above in https://github.com/datafoodconsortium/connector-codegen/pull/20#issuecomment-2030820144 and documented in this gist, the tests for getters and setters are also lacking.
Perhaps it's worth opening two new issues, then: 1) fix the errors in the constructor tests, and 2) generate tests for getters and setters. What say ye, @RaggedStaff, @lecoqlibre, @RachL? Can discuss tmw, too, at datafoodconsortium/datafoodconsortium#5.


Microsoft.AspNet.WebApi.Client package removed from shared framework

Document the impact and update code as necessary. Docs affected:

[x] Migrate from ASP.NET Core 2.2 to 3.0
[x] Make HTTP requests using IHttpClientFactory in ASP.NET Core
[ ] Integration tests in ASP.NET Core

@scottaddie is anything else left here?

The remaining work is being tracked in https://github.com/aspnet/AspNetCore.Docs/issues/13353.


Fix loading js and css from collections

Calling add() lose information on

CSS: $group
JS: $loading, $group

Refs https://getgrav.org/forum#!/getgrav/general:loading-jquery-async

WIP - Recreated an issue in calling with an array of values {% do assets.addJs('jquery', {'loading':'async'}) %} introduced in https://github.com/getgrav/grav/commit/d5bd99b363ec955a90bf50f9f8856a819bec31bf
Checks for func_num_args() == 2 but func_num_args() is now 3 as argument # 3 defaults to true.
Still looking to make it 100% fine

Finally got to the root of the problem, supported by a bunch of tests in the testing branch https://github.com/getgrav/grav/commit/27af9432e0fa9a7abb2b6a2e3f3a6f6d155a37e9

So to confirm, adding an array to addCss, will force all items to be added 'as' css, and same for JS? This fixed the issue reported?

Actually it's 2 fixes, they both solve the issue.
First we check if (func_num_args() > 1) { instead of if (func_num_args() == 2) { otherwise the array is never merged and loading and group are never applied when using the syntax {% do assets.addJs('jquery', {'priority':101, 'loading':'async'}) %}
Then we force to use addCss() or addJs() because otherwise the information on $loading and $group is lost as add() does not accept them as parameters


Github bridge not working ?

Hey guys,
I can't get the Github bridge to do anything. Is it just me ?
And many thanks for this wonderfull piece of software.

Ok thanks, now I can see the parameters.
Still, when I try to add a project name (say "sebsauvage/rss-bridge"), I get an empty page.

Username: sebsauvage
project: rss-bridge
issue number: 288 (i.e.,for this issue )

My bad, I read too fast and was thinking that I could have an RSS feed for all issues of a repository.
Closing this issue.

@Jucgshu I modified the bridge so that you can have all issues when you do not fill the issue field. It just gives you issue titles though, not all the comments of all the issues.

Oh great, I will give ot a try. Although, havong titles & comments would be a nice addition.
Anyway, thanks for this !


Allow Discussion Prompts Elsewhere But Put On Timekeeper Timer

We may want to be able to configure blocks of different commands to be all on the same timer, so /tuvix, /fmk and /dustbuster for example would all be on a ~3 minute timeout together (maybe for these longer timeouts also provide a time til allowed message) rather than separately to prevent folks from overrunning each other with similar prompts in the meantime. 🤔

We decided not to do this and move everything into the new #after-dinner-conversation instead.


Respond with correct content-type header

I updated grpc_server to always insert the content-type used by the request (or application/grpc by default) into the response's HTTP headers.
Without this, I couldn't get it to communicate with https://github.com/grpc/grpc-java, since the latter just rejected every message with undefined content-type headers and setting them manually for every single response seemed very inefficient.

It's right ！


Add proposal for TreeView SelectionChanged event

Proposal for the SelectionChanged event that we added recently as preview in the WinUI repo: https://github.com/microsoft/microsoft-ui-xaml/pull/2063

Closing this PR for now because of lack of interest.

Closing this PR for now because of lack of interest.

How is interest measured?
What does this being closed mean for this proposal going forward? Will it never happen? Is it just moved to a low-priority backlog task?

I'm a bit surprised there has been no progress here. @ranjeshj @MikeHillberg FYI.

How is interest measured?

Actually this was probably poorly written, sorry about that.
What I meant is that there was no traction on this proposal and that i cannot commit more time on this at the moment.

Adding @predavid-zz to see if she can help with the spec. @japf Thanks for adding the API to preview.


Bug fix for watermine

Added default change_pitch_time when it is nil.

@Tribisha you've still got the kiln and pottery hotkey macros included. You'll need to remove those on your branch (or back out those commits on your branch, but that's more complicated git-fu)


Unable to launch chroot in Xorg

Greetings!
I've recently reinstalled my chroot to add the xiwi functionality (I'm late to the party, I know).
Having Xubuntu applications running in windowed mode on Chrome OS is amazing! However, since there's no GPU acceleration on xiwi, and I do want to be able to play Warcraft 3 (:D), I need to be able to run my chroot the old way with Xorg.
I tried running "Sudo startxfce4 -X xorg", but that didn't work, I got:
/mnt/stateful_partition/crouton/chroots/Mycroft does not contain XMETHOD 'xorg'
(Mycroft is the name I chose for my chroot)
Any advice would be much appreciated.
Daniel

You can add 'xorg' to your chroot with an update, using something like:
sudo sh ~/Downloads/crouton -t xorg -u [-n Mycroft]
This method will also make 'xorg' your default xmethod so to use 'xiwi' you'll have to use the '-X xiwi' method when starting your DE, using something like:
sudo startxfce4 -X xiwi [-n Mycroft]

It worked! Thanks a bunch :).

Cool, cool, cool!
( You can close this issue now if you like... )


Add digitalmarketplace-contained to DMp repos

Also add Daniele to the list of team members

Thanks @alex9smith


Ability to nest the-grid into another element

with more robust styles computation.
Fixes #2

Yup, it looks like this fixes my issue!  Thank you!


[BUG] InventoryVector should not inherit from Payload

Hello everyone!
I am working with NBitcoin, it is good library, but i found something, that i think is bug:
public class InventoryVector : Payload, IBitcoinSerializable
ref: https://github.com/MetacoSA/NBitcoin/blob/602dea5ed312e5a7e3bca639f39690cf185b3590/NBitcoin/Protocol/InventoryVector.cs#L25
Why class InventoryVector inherit from Payload? I think that InventoryVector is not stand alone Bitcoin message, it is only part of the message (e.g. InventoryPayload) - so I think that InventoryVector is  not Payload - it is only IBitcoinSerializable - it doesn't have Command (which Payload expect).
The reason I found that is, it isn't json serializable:
code:
var invVector = new InventoryVector(InventoryType.MSG_TX, uint256.One);
Console.WriteLine(JsonSerializer.Serialize(invVector));

Exception:
Unhandled exception. System.ArgumentException: NBitcoin.Protocol.InventoryVector is not a payload
   at NBitcoin.Protocol.PayloadAttribute.GetCommandName(Type type)
   at NBitcoin.Protocol.Payload.get_Command()
   at System.Text.Json.Serialization.Metadata.JsonPropertyInfo`1.GetMemberAndWriteJson(Object obj, WriteStack& state, Utf8JsonWriter writer)
   at System.Text.Json.Serialization.Converters.ObjectDefaultConverter`1.OnTryWrite(Utf8JsonWriter writer, T value, JsonSerializerOptions options, WriteStack& state)
   at System.Text.Json.Serialization.JsonConverter`1.TryWrite(Utf8JsonWriter writer, T& value, JsonSerializerOptions options, WriteStack& state)
   at System.Text.Json.Serialization.JsonConverter`1.WriteCore(Utf8JsonWriter writer, T& value, JsonSerializerOptions options, WriteStack& state)
   at System.Text.Json.JsonSerializer.WriteUsingSerializer[TValue](Utf8JsonWriter writer, TValue& value, JsonTypeInfo jsonTypeInfo)
   at System.Text.Json.JsonSerializer.WriteStringUsingSerializer[TValue](TValue& value, JsonTypeInfo jsonTypeInfo)
   at System.Text.Json.JsonSerializer.Serialize[TValue](TValue value, JsonSerializerOptions options)

Thank you for helping me! :)

I think you are right, can you make a PR? tests will fail if we are wrong.


fix: query config value must be converted to dict

to be usable by URL.create()
Describe your changes
The fix mainly isolates the parsing of a configuration section in a separate function, so that in can be reused at the points where  URL.create(**section) is called.
The parsing mainly ensure that a query attributed is also correctly converted to a dictionary or something else by parsing the value as a python string.
This seemed the least impactful change, while fixing the bugs related to the query parameter.
Issue number
Closes #1015
Checklist before requesting a review

[x] Performed a self-review of my code
[x] Formatted my code with pkgmt format
[x] Added tests (when necessary).
[x] Added docstring documentation and update the changelog (when needed)

📚 Documentation preview 📚: https://jupysql--1016.org.readthedocs.build/en/1016/

@neelasha23, please review this and check the CI
I took a brief look and it seems like it's an issue with the DuckDB version (an update probably broke things)

OK for me to help fix things with some guidance, but prbly better on a separate branch?

I get this error:
File [~/miniforge3/envs/jupysql/lib/python3.10/site-packages/IPython/core/extensions.py:129](http://localhost:8889/~/miniforge3/envs/jupysql/lib/python3.10/site-packages/IPython/core/extensions.py#line=128), in ExtensionManager._call_load_ipython_extension(self, mod)
    127 def _call_load_ipython_extension(self, mod):
    128     if hasattr(mod, 'load_ipython_extension'):
--> 129         mod.load_ipython_extension(self.shell)
    130         return True

File [~/miniforge3/envs/jupysql/lib/python3.10/site-packages/sql/magic.py:783](http://localhost:8889/~/miniforge3/envs/jupysql/lib/python3.10/site-packages/sql/magic.py#line=782), in load_ipython_extension(ip)
    780 load_SqlMagic_configs(ip)
    782 # start the default connection if the user has one in their config file
--> 783 sql.connection.ConnectionManager.load_default_connection_from_file_if_any(
    784     config=sql_magic
    785 )
    787 ip.register_magics(RenderMagic)
    788 ip.register_magics(SqlPlotMagic)

File [~/miniforge3/envs/jupysql/lib/python3.10/site-packages/sql/connection/connection.py:452](http://localhost:8889/~/miniforge3/envs/jupysql/lib/python3.10/site-packages/sql/connection/connection.py#line=451), in ConnectionManager.load_default_connection_from_file_if_any(cls, config)
    449 except FileNotFoundError:
    450     return
--> 452 default_url = connections_file.get_default_connection_url()
    454 if default_url is not None:
    455     try:

File [~/miniforge3/envs/jupysql/lib/python3.10/site-packages/sql/parse.py:66](http://localhost:8889/~/miniforge3/envs/jupysql/lib/python3.10/site-packages/sql/parse.py#line=65), in ConnectionsFile.get_default_connection_url(self)
     63 except configparser.NoSectionError:
     64     return None
---> 66 url = URL.create(**_section_as_url_dict(section))
     67 return str(url.render_as_string(hide_password=False))

TypeError: URL.create() missing 1 required positional argument: 'drivername'

I have fixed most of the CI issues except one. Please take a look at the changes here:

Unpin the DuckDB version
Change the MySQL image
The JSON arrow operator related tests are failing because for single operators output returned is no more in the string format. So I fixed the related tests in test_magic.py.

I still see this test failing: src/tests/integration/test_generic_db_operations.py::test_query_snippet_invalid_function_error_message[with-typo-oracle] . I'm not sure why this test is failing. @wimvanleuven Please check if you can fix it else maybe we can mark it as xfail for now and open an issue to solve it? Ensure your tests also pass in the CI. I think we should also add an example in the docs
Thoughts? @edublancas

@neelasha23 I've merged your PR to fix the CI
@wimvanleuven feel free to rebase so you get the CI fixes

I still see this test failing: src/tests/integration/test_generic_db_operations.py::test_query_snippet_invalid_function_error_message[with-typo-oracle] . I'm not sure why this test is failing. @wimvanleuven Please check if you can fix it else maybe we can mark it as xfail for now and open an issue to solve it? Ensure your tests also pass in the CI. I think we should also add an example in the docs

yeah we can add an xfail and open an issue, we can tackle it later
yes, I think we should add an example to the docs

@edublancas

all tests pass,
the parse function was renamed as per @neelasha23 request and
an example configuration with query parameters is in the docs.

I noticed the read the docs action failed ... how to retrigger?

I re-ran the CI, all passing now!
@neelasha23 please give a final check

@wimvanleuven thanks so much! I'll do a release shortly!

@edublancas I don't want to rush you, but could you give an time horizon for the release, so we can plan our work accordingly? Thank you so much for the productive collab!

@edublancas I don't want to rush you, but could you give an time horizon for the release

It's released @wimvanleuven


Explorations: rewire legacy bucket backend

BucketV2 and Bucket underlying schemata are still very close and almost identical, since they have a common ancestry, with BucketV2 continuing to evolve and Bucket lagging behind. This experiment attempts to exploit this by redirecting the implementation details of handling Bucket CRUD to the BucketV2 implementation.
This change is ideally a refactor invisible to the user but given a substantial API surface need to be careful not to regress.

removed s3legacy and recreated the legacy bucket against v2 code
encountering some bugs, we might need to remove default: "private" from "acl"

* putting S3 Bucket (my-bucket-eb276e3) ACL: operation error S3: PutBucketAcl, https response error StatusCode:
       400, RequestID: GMTPEW43STHM9DWM, HostID:
       /NJMasmaMuMN64OXgC+h58N1ozOYowaC0dP2I9rb2z7NPRZ83BWrabjNk0SIqYniyPCJe/iD/oI=, api error
       AccessControlListNotSupported: The bucket does not allow ACLs

logging (loggings?) has changed from Set to List with MaxItems=1 there might be a slight change to compensate for
there were a lot of custom TypeSet Set functions specified in the legacy, why were they removed in BucketV2, is it OK to match or we can roll without them
generally might need to add lifecycle and provider upgrade tests targeting each attribute like "loggings"
removes a fair bit of Pulumi-maintained custom code, need to itemize and ensure that was redundant

Opting against this route.


Manual installation does not work in Magento 2.3.1

Magento: 2.3.1
php: 7.2.28
I have followed the instructions from README.md, but the extension is not showing in Stores > Configuration > Sales > Payment Methods.
No errors!
I have also done:

./bin/magento setup:upgrade
./bin/magento cache:clean
./bin/magento setup:di:compile
./bin/magento setup:static-content:deploy en_US el_GR -f
./bin/magento cache:clean

Still nothing.

Faced same issue. Installed extension under app/code/ and was able to fetch payment method under admin.
However on enabling it, unable to get any payment methods on frontend

Same issue when installing via composer for magento 2.2.11

Hi @ioweb-gr, I just wanna ask if you have manage to solve the problem in the front-end? Thanks!

Nope unfortunately. You wouldn't expect such issues being unreplied for so long. Our customer is still using another bank's gateway instead of this one because of this issue.

Hey @ioweb-gr, I have raised this issue with the developers. Could you also raise this through the banks support team so that it can be tracked correctly? This issue tab is not being actively monitored and will be closed soon so that we can properly monitor support tickets through the support queue.

I actually have done so months ago for both issues I've mentioned here. The current one and the frame options header. I regret to inform you that we've been totally ignored and a few months later  we only received a canned response with the links to the repositories for magento and the docs to implement ourselves.

@ioweb-gr , can you give me the support ticket number that was raised with this? Should be in the email header of the response they sent to you.

The issue was raised via phone support so there's no ticket number unfortunately.
A repeat to use the plugins found in github or to code it via the API docs.
As you can understand we've pretty much hit a dead end with NBG regarding this which only seems to be the continuation of their previous ideas of technical support.

This is the answer (sorry it's in Greek) from the IT e-Commerce Support Team (Tue 23/06/2020 12:48):

Καλησπέρα σας,
Αναφορικά με το Simplify και το magento 2 που υποστηρίζει θα θέλαμε να σας ενημερώσουμε ότι το 2.1 δεν υποστηρίζεται και το 2.3 δεν υποστηρίζεται (τουλάχιστον οχι ακόμη). Το version 2.2 υποστηρίζεται κανονικά. Απολογούμαστε για όλη την καθυστέρηση.
Η ΕΤΕ σας προτείνει να χρησιμοποιήσετε τη μέθοδο hosted payments (μόνο χωρίς SDK ώστε να συμβαδίζει με την σύμβασή σας), πληροφορίες θα βρείτε παρακάτω:
https://github.com/myNBGcode/E-commerceSimplify#Hosted-checkout.
https://ibanknbg.simplify.com/commerce/docs/tools/hosted-payments.
Στη διάθεσή σας,
IT e-Commerce Support Team | Εθνική Τράπεζα της Ελλάδος |
e-mail<EMAIL_ADDRESS>  | web: www.nbg.gr

go figure!

The message says basically that Magento 2.1 / 2.3 is not supported and it only works in 2.2 which is EOL now and that NBG suggest to use hosted payments without sdk.
The thing is that we tried on 2.2 and we faced the same issues as in 2.3.1. And currently 2.2 is EOL so this module should be made compatible with at least 2.3.5-p1 if not 2.4.
2.4 contains a CSP which will definitely break this module.

Hey @kanenas @ioweb-gr @kevinsh25 Please test the new version with the issues you are encountering and let me know if it has been resolved.

@JohnbConneely unfortunately I can't test the new version because right now I am not managing any Magento installation.


[WIP] Refactor jsonapi

Please don't merge at this time. Will be working in additional refactorings.
Addressing these issues
List of changes:

Refactored GETModerators
Refactored ServeHTTP
Refactored GETListing

Coverage decreased (-0.007%) to 33.563% when pulling 3c3324da1d411e7572691cadc326692ece1e08b3 on refactor-jsonapi into 99e559ba5aacebc2117c3a4e9728af3beb2fa664 on master.


Test

@bishalgoswami Is this just a test commit that you are going to throw away. Looks like you just added "Testupdate" to the doc.

@bishalgoswami Closing this PR as it does not look like a valid change.


Add-Modal-Dialog-Razor-Template

Description

This update contains a new OpenContent template "Modal-Dialog". This template has the functionality to launch a modal to the user when entering the page or when called from a button.
How Has This Been Tested?

DNN 9.13.6
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

@WillStrohl I have updated the template, now the texts are obtained from the module settings, if they are empty they will not be displayed.


Create block storage dependency for mutable storage

Description of the Change
In-memory block storage was hard-coded in mutable storage. A block storage interface was created to make it replaceable.
BlockStorage interface was made compatible with current KeyValueStorage interface so that it can be removed since it is too low-level.

Benefits
Less hard-coded storage behavior.

Possible Drawbacks
None?

Usage Examples or Tests [optional]
test/module/irohad/ametsuchi/in_memory_block_storage_test.cpp

Let's merge that!

@neewy waiting for CI to pass


Random-Password-maker.py

this will create a random password of the given length which is to hard to crack.

@priyanshkulshrestha  contribute to https://github.com/Ishaan28malik/Get-Dev-Resources instead


DnD 5e Races: Extensive Testing

Elf (Hight Elf)
(Note) Race matches "Elf (Hight)" race stats with multiple exceptions. (PHB p23)
(Bug) Race has 12m "Dark Vision" instead of 18m.
(Missing Feature) Race special feature "Trance" has no mechanical function.
(Missing Feature) Race special feature "Extra Language" has no mechanical function.
(Half Feature) Race knows two Languages "Common "and "Elvish", only "Common" is implemented.
Elf (Wood Elf)
(Note) Race matches "Elf (Wood)" race stats with multiple exceptions. (PHB p24)
(Bug) Race has 12m "Dark Vision" instead of 18m.
(Missing Feature) Race special feature "Trance" has no mechanical function.
(Half Feature) Race knows two Languages "Common "and "Elvish", only "Common" is implemented.
(Larian feature) Race special feature "Mask of the Wild" has different effect.
Elf (Lolth-Sworn Drow)
(Note) Race matches "Elf (Drow)" race stats with multiple exceptions. (PHB p24)
(Bug) Race has 24m "Dark Vision" instead of 36.5m.
(UI Oversight) Race special feature "Drow Magic" does not display future bonuses such as "Faerie Fire" received at level 3.
(Missing Feature) Race special feature "Trance" has no mechanical function.
(Missing Feature) Race special feature "Sunlight Sensitivity" is not implemented.
(Half Feature) Race knows two Languages "Common "and "Elvish", only "Common" is implemented.
Elf (Seldarine Drow)
(Note) Race matches "Elf (Eladrin)" race stats with multiple exceptions. (DMG p286)
(Bug) Race has 12m "Dark Vision" instead of 18m.
(Missing Feature) Race special feature "Trance" has no mechanical function.
(Missing Feature) Race special feature "Fey Step" is not implemented.
(Half Feature) Race knows two Languages "Common "and "Elvish", only "Common" is implemented.
Tiefling (Asmodeus)
(Note) Race matches "Tiefling (Asmodeus)" race stats with multiple exceptions. (MTF p21)
(Bug) Race has 12m "Dark Vision" instead of 18m.
(UI Oversight) Race special feature "Infernal Legacy" does not display future bonuses such as "Hellish Rebuke" received at level 3.
(Half Feature) Race knows two Languages "Common "and "Infernal", only "Common" is implemented.
Tiefling (Mephistopheles)
(Note) Race matches "Tiefling (Mephistopheles)" race stats with multiple exceptions. (MTF p23)
(Bug) Race has 12m "Dark Vision" instead of 18m.
(UI Oversight) Race special feature "Infernal Legacy" does not display future bonuses such as "Burning Hands" received at level 3.
(Half Feature) Race knows two Languages "Common "and "Infernal", only "Common" is implemented.
Tiefling (Zariel)
(Note) Race matches "Tiefling (Zariel)" race stats with multiple exceptions. (MTF p23)
(UI Oversight) Race special feature "Infernal Legacy" does not display future bonuses such as "Searing Smite" received at level 3.
(Half Feature) Race knows two Languages "Common "and "Infernal", only "Common" is implemented.
Human
(Note) Race matches "Human" race stats with multiple exceptions. (PHB p29)
(Half Feature) Race knows two Languages "Common "and another one of your chose, only "Common" is implemented.
Githyanki
(Note) Race matches "Gith (Githyanki)" race stats with multiple exceptions. (MTF p96)
(UI Oversight) Race special feature "Githyanki Psionics" does not display future bonuses such as "Jump" received at level 3.
(Missing Feature) Race special feature "Decadent Mastery" is not implemented.
(Half Feature) Race knows two Languages "Common "and "Gith", only "Common" is implemented.
Dwarf (Gold)
(Note) Race matches "Dwarf (Hill)" race stats with multiple exceptions. (PHB p20)
(Bug) Race has 12m "Dark Vision" instead of 18m.
(Missing Feature) Race special feature "Tool Proficiency" is not implemented.
(Missing Feature) Race special feature "Stonecunning" is not implemented.
(Half Feature) Race knows two Languages "Common "and "Dwarvish", only "Common" is implemented.
Dwarf (Shield)
(Note) Race matches "Dwarf (Mountain)" race stats with multiple exceptions. (PHB p20)
(Bug) Race has 12m "Dark Vision" instead of 18m.
(Missing Feature) Race special feature "Tool Proficiency" is not implemented.
(Missing Feature) Race special feature "Stonecunning" is not implemented.
(Half Feature) Race knows two Languages "Common "and "Dwarvish", only "Common" is implemented.
High Half-Elf
(Note) Race matches "Half-Elf (Variant; Moon Elf or Sun Elf Descent)" race stats with multiple exceptions. (SCAG p116)
(Bug) Race has 12m "Dark Vision" instead of 18m.
(Missing Feature) Race special feature "Variant Feature" is fixed to "Cantrip" instead of letting you chose.
(Half Feature) Race knows three Languages "Common ", "Elvish" and one more of your choice, only "Common" is implemented.
Wood Half-Elf
(Note) Race matches "Half-Elf (Variant; Wood Elf Descent)" race stats with multiple exceptions.  (SCAG p116)
(Bug) Race has 12m "Dark Vision" instead of 18m.
(Missing Feature) Race special feature "Variant Feature" is not implemented, race is granted changed versions of "Fleet of Foot" and "Mask of the Wild" instead.
(Half Feature) Race knows three Languages "Common ", "Elvish" and one more of your choice, only "Common" is implemented.
Drow Half-Elf
(Note) Race matches "Half-Elf (Variant; Drow Descent)" race stats with multiple exceptions. (SCAG p116)
(Bug) Race has 12m "Dark Vision" instead of 18m.
(Missing Feature) Race special feature "Variant Feature" is fixed to "Drow Magic" instead of letting you chose.
(Half Feature) Race knows three Languages "Common ", "Elvish" and one more of your choice, only "Common" is implemented.
Lightfoot Halfling
(Note) Race matches "Halfling (Lightfoot)" race stats with multiple exceptions. (PHB p28)
(Missing Feature) Race special feature "Halfling Nimbleness" is not implemented.
(Half Feature) Race knows two Languages "Common "and "Halfling", only "Common" is implemented.
(Larian feature) Race special feature "Naturally Stealthy" has different effect.
Strongheart Halfling
(Note) Race matches "Halfling (Stout)" race stats with multiple exceptions. (PHB p28)
(Missing Feature) Race special feature "Halfling Nimbleness" is not implemented.
(Half Feature) Race knows two Languages "Common "and "Halfling", only "Common" is implemented.
(Larian feature) Race special feature "Naturally Stealthy" has different effect.

btw the darkvision ranges are easily fixed mechanically. adjusting the ranges will allow you to ignore darkness conditions to the appropriate range, but i believe there are player light sources attached to the passives for that specific distance, so that might be slightly awkward visually.


56 backend generates book recommendations

looks good! took about 35 seconds to load recommendations for me.

awesome!! thanks muskan :)


admin sign in not working

I set my password (yes, i'm sure its correct), and the admin sign in page just refreshes when entering correct password and does nothing! I am in need of help. Thank you.
Here is my settings.php:
http://pastebin.com/9cJpSrLU

can you create a file (on the server) with the content <?phpinfo(); ?> in it and share what it returns on screen as it sounds like sessions isn't enabled on your server

What file type?

php

I think I got it - I created the file and went to the website I am hosting it with, and at the end of the URL I typed /test.php (the name of my file) and this is what it showed me:
http://pastebin.com/VzXwb3PX


Update Slack action to support current API

Feature Request
Motivation Behind Feature

The current implementation of the Slack action is using an outdated gem.
This is causing issues like #15362 and doesn't support the new layout blocks.
Feature Description

Replace the Slack action with an HTTP wrapper which allows for more customisation.
Alternatives or Workarounds

It is currently only possible to send basic messages to a webhook (which doesn't allow the use of a dynamic channel).

We should definitely make sure that the new Slack action is backwards compatible with the current one so that users keep getting their messages.
@janpio I found a gem which is very extensive but IMHO that seems overkill.
The Fastlane action only needs to post messages.
That can be accomplished with the chat.postMessage API endpoint.
I propose we create an HTTP wrapper with options that match the top arguments for the JSON request.
We would also keep the default_payloads option to easily add common info.
We should also keep any other options which we can map to the "new" Slack API arguments.

Sounds like a plan - and as you mentioned yourself full backwards compatibility to the existing action is kind of a requirement.

@fastlane-bot nope isn't fixed.

@fastlane-bot I would still like to have this.

@rickclephas is it going to be updated any time soon?

@kamvoick hi sorry I am currently quite busy with work. I am afraid I won't be able to update the Slack action anytime soon 😔

I'm trying to match that basic-but-cool looking of the tests results on slack notifications but it seems that output_style doesn't change that. Is this related to what you said "...doesn't support the new layout blocks." @rickclephas ?

Hi @rickclephas @brunomunizaf @kamvoick
You can send a direct message now:) Please let me know if you need any help! 😍
https://github.com/crazymanish/fastlane-plugin-slack_bot
Thanks, @joshdholtz for unlocking the issue! 🙏🏻


Build fail due to crisp_chat dependency

Hello! My app functions well in debug mode on both iOS and Android when using this package. However, the build fails on both iOS and Android.
Here is the related Android error:
ERROR: Missing classes detected while running R8. Please add the missing classes or apply additional keep rules that are generated in /<app_path>/build/app/outputs/mapping/prodRelease/missing_rules.txt.
ERROR: R8: Missing class com.caverock.androidsvg.SVG (referenced from: android.graphics.drawable.Drawable io.noties.markwon.image.svg.SvgMediaDecoder.decode(java.lang.String, java.io.InputStream))
Missing class com.caverock.androidsvg.SVGParseException (referenced from: android.graphics.drawable.Drawable io.noties.markwon.image.svg.SvgMediaDecoder.decode(java.lang.String, java.io.InputStream))
Missing class org.bouncycastle.jsse.BCSSLParameters (referenced from: void okhttp3.internal.platform.BouncyCastlePlatform.configureTlsExtensions(javax.net.ssl.SSLSocket, java.lang.String, java.util.List) and 1 other context)
Missing class org.bouncycastle.jsse.BCSSLSocket (referenced from: void okhttp3.internal.platform.BouncyCastlePlatform.configureTlsExtensions(javax.net.ssl.SSLSocket, java.lang.String, java.util.List) and 5 other contexts)
Missing class org.bouncycastle.jsse.provider.BouncyCastleJsseProvider (referenced from: void okhttp3.internal.platform.BouncyCastlePlatform.<init>())
Missing class org.conscrypt.Conscrypt$Version (referenced from: boolean okhttp3.internal.platform.ConscryptPlatform$Companion.atLeastVersion(int, int, int))
Missing class org.conscrypt.Conscrypt (referenced from: boolean okhttp3.internal.platform.ConscryptPlatform$Companion.atLeastVersion(int, int, int) and 4 other contexts)
Missing class org.conscrypt.ConscryptHostnameVerifier (referenced from: okhttp3.internal.platform.ConscryptPlatform$DisabledHostnameVerifier)
Missing class org.openjsse.javax.net.ssl.SSLParameters (referenced from: void okhttp3.internal.platform.OpenJSSEPlatform.configureTlsExtensions(javax.net.ssl.SSLSocket, java.lang.String, java.util.List))
Missing class org.openjsse.javax.net.ssl.SSLSocket (referenced from: void okhttp3.internal.platform.OpenJSSEPlatform.configureTlsExtensions(javax.net.ssl.SSLSocket, java.lang.String, java.util.List) and 1 other context)
Missing class org.openjsse.net.ssl.OpenJSSE (referenced from: void okhttp3.internal.platform.OpenJSSEPlatform.<init>())

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:minifyProdReleaseWithR8'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.R8Task$R8Runnable
   > Compilation failed to complete

I have updated the package today. Hope this problem is solved. @BghinC

Thanks for the quick update! However, I'm still encountering the same error as above on both Android and iOS.
Find below the error message during the iOS build:
Encountered error while creating the IPA:
error: exportArchive: ipatool failed

Flutter doctor:
[✓] Flutter (Channel stable, 3.19.2, on macOS 14.1.2 23B92 darwin-arm64, locale fr-FR)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.1)
[✓] VS Code (version 1.87.0)
[✓] Connected device (3 available)
[✓] Network resources

I don't know why your project is not creating release build. I'm also using this package for my project, and it is working fine for me to build iOS and Android.


⚖ Register Validator: BccNodes

Network Choice
dentrite-1
Who are you?
Founded in early 2022, BccNodes is a trusted Proof-of-Stake infrastructure provider and validator. Continues to secure user funds with its secure validation infrastructure and team members with high experience in Cosmos networks. BccNodes is focusing in secure their infrastructure with the highest standards and build a strong community to accelerate the adoption and help projects growth.
Delegator address
axone1l7tt47vsnft85gkv2m9yfryhs4xwa8l3n0pv86
gentx
{
  "body": {
    "messages": [
      {
        "@type": "/cosmos.staking.v1beta1.MsgCreateValidator",
        "description": {
          "moniker": "BccNodes",
          "identity": "C5337EB8B55DFA0C",
          "website": "https://bccnodes.com",
          "security_contact"<EMAIL_ADDRESS>          "details": "Professionally managed institutional grade blockchain infrastructure provider ⚛ Discord: bccnodes"
        },
        "commission": {
          "rate": "0.050000000000000000",
          "max_rate": "0.200000000000000000",
          "max_change_rate": "0.010000000000000000"
        },
        "min_self_delegation": "1",
        "delegator_address": "",
        "validator_address": "axonevaloper1l7tt47vsnft85gkv2m9yfryhs4xwa8l3r6d7ac",
        "pubkey": {
          "@type": "/cosmos.crypto.ed25519.PubKey",
          "key": "CjxSwFj6tuPT0Zt1OjraAM7c4ZON+L06uGF6KE+uO50="
        },
        "value": {
          "denom": "uaxone",
          "amount": "1000000000000"
        }
      }
    ],
    "memo": "af2e171a540d97eeea1b08d87babbcbbeb34f81b@<IP_ADDRESS>:26656",
    "timeout_height": "0",
    "extension_options": [],
    "non_critical_extension_options": []
  },
  "auth_info": {
    "signer_infos": [
      {
        "public_key": {
          "@type": "/cosmos.crypto.secp256k1.PubKey",
          "key": "A9mBemX6wtYevZqxkyI0t7dbgbpDlQ0i1Lhpusa6LHNf"
        },
        "mode_info": {
          "single": {
            "mode": "SIGN_MODE_DIRECT"
          }
        },
        "sequence": "0"
      }
    ],
    "fee": {
      "amount": [],
      "gas_limit": "200000",
      "payer": "",
      "granter": ""
    },
    "tip": null
  },
  "signatures": [
    "l24h6Ib9VVnwqzt/M2zPyAVaCIWi5qkDceY/Ndvvio0Q5gYOw3m2ao0uf2s9HbRPXKO7GYU6i0UTNrMAfkptVg=="
  ]
}

😉 Here is the corresponding PR: https://github.com/axone-protocol/networks/pull/817


Cache autogenerated Search key values for dropdowns in database

Right now it takes too long for the autogenerated search tool parameters to appear when the page loads. These values are generated here https://github.com/cltk/cltk_frontend/blob/develop/server/methods/searchTools.js need to be cached in the database somewhere so that they're not recreated on each user session.

Hi @lukehollis, is this issue free? I had a spare moment and resolved it locally with a collection in Mongo:
import Authors from '/imports/collections/authors';
import Works from '/imports/collections/works';

SearchToolsCache = new Mongo.Collection('searchTools_cache');

SearchToolsCache._ensureIndex({ key: 1 });
SearchToolsCache._ensureIndex({ createdAt: 1 }, { expireAfterSeconds: 3600 });

function get() {
	const result = SearchToolsCache.findOne({
		key: 'searchTools_cache'
	}, {
		_id: false,
		value: true
	}) || {};

	return result.value;
}

function set(value) {
	SearchToolsCache.insert({
		key: 'searchTools_cache',
		value,
		createdAt: new Date()
	});
}

Meteor.methods({
	searchTools() {
		const cachedResult = get();

		if (cachedResult) {
			return cachedResult;
		}

                // etc...

		const result = {
			languages,
			corpora,
			authors,
		};

		set(result);

		return result;
	},

});

This is clearly a hack, but I wanted to pause to get feedback since this'd be my first contribution to the project.
A couple of questions:

Is it okay to use MongoDB for caching like this, or should I set up something like Redis in the PR?
Does the CLTK want a general-purpose cache (i.e., one that, unlike the above example, isn't tied specifically to searchTool())? If so, where should that live?

Please feel free to let me know if I've totally gone off into the woods with respect to what you were expecting! Thanks!

@pletcher, this solution looks optimal for the search tools right now. I was having trouble getting the languages to work locally, and I realized that we had to augment the schema slightly in recent iterations of the project because Mongo was using the 'language' field for text indexes (https://docs.mongodb.com/manual/tutorial/specify-language-for-text-index/). The new database is now in the README and available here: https://storage.googleapis.com/archimedes-data--regional/cltk/dump-without-users.tgz
Specifically to your question, we might need other sorts of caching in the future, but I'm afraid of over-optimizing before we need to. I think this is the perfect level of caching for the application search tools and can be extended in the future when we hit other bottlenecks. Caching the IDs is a great idea and seems to be working well.
Otherwise, I've merged back to master with this integrated and will build and release. Awesome work, and thanks again.

@lukehollis Thanks, I'll update my local copy of the database.
And I'm with you on avoiding over-optimizing at the moment. Thanks for reviewing my PRs so quickly!
I also wanted to ask (although maybe extending this thread is the wrong way to go about it -- happy to open another issue if you'd prefer): I needed to update a few packages to get things working locally (specifically, I bumped material-ui to 0.16.4 (because of its dependency on react-tap-event-plugin, if I remember right), react and react-dom to 15.4.1, and react-tap-event-plugin to 2.0.1. I also needed to bump Meteor itself to <IP_ADDRESS> for the project to build. I didn't commit these changes, since they seemed to be outside the scope of this issue, but I wanted to mention them before I forgot.
Thanks again, and please feel free to let me know if there are other issues that I could take a look at! (Or if there's something, like the languages issue, that I should fix in any of the changes that I made.)

Thanks for mentioning that, @pletcher, I believe those were on older versions for compatibility with packages bridging some Blaze resources to React that we might be able to remove now. If everything's working for you after bumping those packages, seems like it'd be really useful to include those changes as well. As far as the other issues, all are still open and relevant--I'm waiting a little right now as @ashiful-haque finalizes the templates, but it appears that they are getting close to being finalized, and if you have any feedback/ideas for them please feel free to voice it on Gitter #ux channel or in an issue on this repo. Thanks for your patience with my following up to your email--will do that now.


When translating, the error E877 is marked as obsolete

Steps to reproduce
When updating PO files, the error E877 (e_nfa_regexp_invalid_character_class_nr) is marked with a comment #~, i.e. as obsolete.
https://github.com/vim/vim/blob/ad493ef3ea9ef7f2b0badcd2298883b5ab6e4ef4/src/regexp_nfa.c#L1400
https://github.com/vim/vim/blob/ad493ef3ea9ef7f2b0badcd2298883b5ab6e4ef4/src/regexp_nfa.c#L5153
The gettext macro is missing in the second error assignment.
Most likely due to the fact that the error assignment is used as an internal error.
Expected behaviour
It should not be marked as obsolete.
Version of Vim
Vim 9.1.225
Environment
All
Logs and stack traces
No response

Hm, I don't see #~ marked for the few po files that define E877. For some reason, E877 is not in all po files. For example, it's not in de.po (even when I create a completely new de.po file)
So where do you see the #~ marker?

For reproduction #~ marker:
nmake.exe -f Make_mvc.mak ca da eo es fi fr ko ko.UTF-8 pt_br zh_cn.UTF-8 zh_cn.cp936

For example, da.po:

#, c-format
#~ msgid "E877: (NFA regexp) Invalid character class: %ld"
#~ msgstr "E877: (NFA regexp) Ugyldig tegnklasse: %ld"

For some reason, E877 is not in all po files.

That's the point. And this should be in all PO files.
Apparently, according to my translations, there was still this error in version 9.0.1583. And in version 9.0.1596 it is no longer there.
Try to do nmake.exe -f Make_mvc.mak vim.pot
This error will not be in Vim.pot.
When the PO files are updated, the lines are marked as obsolete and when the files are cleaned, "cleanup.vim" deletes these lines.
As I said above, this error does not get into Vim.pot due to the fact that the gettext macro is missing when assigning this error in line 5153 the "regexp.nfa.c" file.


Clarification Needed on Handling Duplicate anchor Definitions Across JSON Schema Tests

Description:
There seems to be a discrepancy in how duplicate $anchor definitions are handled across different tests in the JSON Schema Test Suite. Specifically, the tests present conflicting interpretations of whether a subsequent $anchor with the same name should override an earlier definition or whether the first occurrence should be retained.
Relevant Test Files and Observations:

Ref Test (ref.json#L632) - In this test, when $anchor is defined multiple times, the reference points to the first occurrence of the $anchor.

ref.json#L632

Anchor Test (anchor.json#L84) - This test appears to indicate that the latest $anchor definition overrides earlier ones.

anchor.json#L84

Concern:
The handling of duplicate $anchor names varies between tests, which may lead to inconsistent behavior in schema processing across different implementations. This inconsistency could impact the predictability and reliability of JSON Schema validation.
Questions and Suggested Actions:

Clarification Request: Could the JSON Schema specification provide clearer guidance on how duplicate $anchor names should be handled? Specifically, should a later $anchor override an earlier one, or should the first defined $anchor be the one that is referenced?
Specification Update Proposal: I propose considering an update to the JSON Schema specification to explicitly address this scenario, ensuring that all implementations handle duplicate $anchor names consistently.
Test Suite Adjustment: Depending on the clarification, adjustments may be necessary in the JSON Schema Test Suite to align with the clarified behavior, either by modifying existing tests or by adding new tests to explicitly verify the expected handling of duplicate $anchors.

Thank you for considering this issue. Addressing this ambiguity will help in enhancing the robustness and interoperability of JSON Schema implementations and tools.

In both of the tests you reference, one of the $anchor keywords has a different base URI, provided by an adjacent $id keyword.
These aren't duplicate anchors, just similarly-named anchors in different resources.

Truly duplicate $anchors should be an error.
At the end of Core 8.2.2:

The effect of specifying the same fragment name multiple times within the same resource, using any combination of "$anchor" and/or "$dynamicAnchor", is undefined. Implementations MAY raise an error if such usage is detected.

thanks


Minor code cleanup

This PR has 2 main cleanup items:

Several internal classes have been moved into a new colossus.core.server package, and a few larger files were split up.  This was mainly done to avoid a conflict when importing both colossus.core and colossus.protocols.http.server, since both have an Initializer type.  The one in core.server is no longer needed by users.
Constructor parameters were accidentally switched on RequestHandler, putting them back in the right order.

Current coverage is 84.91% (diff: 81.81%)

Merging #493 into develop will not change coverage

@@            develop       #493   diff @@
==========================================
  Files            95         98     +3
  Lines          4257       4257
  Methods        3893       3905    +12
  Messages          0          0
  Branches        364        352    -12
==========================================
  Hits           3615       3615
  Misses          642        642
  Partials          0          0

Powered by Codecov. Last update ea128cf...3bf2af5


Simpler generator

Proposed changes:

keras policy now fits entire dialogue sequences simultaneously, rather than slices of history to a single action
let the Featurizer class do the featurization
generate() just returns a list of finished trackers
max_history now an attribute of the featurizer
separate method for featurizing labels in Featurizer class

TODO:

implement rest of TrainingData methods (or drop them)
possibly compose Featurizer from both an InputFeaturizer and LabelFeaturizer to allow mixing and matching
add backwards compatible mode for sklearn & other policies

Status (please check what you already did):

[ ] made PR ready for code review
[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog

Could you please add a bit more details on what's going wrong with keras policy training?

sure - when I train for a large number of epochs, accuracy quickly goes up to e.g. 0.9, then steadily drops to ~0.6 while loss continues to decrease.
Also my longest dialogue is 9 actions, I train with max_history = 10 vs 13. With 13 the same behaviour occurs but more slowly. These extra steps should be ignored anyway and not affect the optimisation at all

Right now, policy receives training_data for training, but tracker for prediction. Let's change that.
We are going to pass training trackers to train method of the policy. The train method will call featurizer as it is done in predict method.

Status: @Ghostvv will push his local changes and we'll do a first review of this tomorrow.

@tmbo I pushed the last changes. On my computer, training and prediction of memoization and keras policies work

@tmbo @amn41 I updated all main methods to the new system

Are there any other todos in your mind @Ghostvv ? I went through the code ones and they look good.

The policy isn't covered in the documentation yet is it? Should get a section and a short explanation.

No, I didn't write anything about it

Mind writing something, I mean it is only of so much use if nobody knows that it exists why it is cool and when it should be used.

I think for now a small amount of documentation will suffice (just to say it exists) - the "how and when to use it" will probably get wrapped into docs on generalisation

I was planning to do docs right before merging, to not waste time rewriting them every time I change smth

@tmbo we also need new docs for featurization

@tmbo what about checking in the train method of keras_policy if model==None then call self.model_architecture(..) else use passed model?

What's the use case for passing in a model through the train function?

no, not through train function. Right now, in principle fresh keras_policy can be initialized with some keras model (we use it for persistence):
https://github.com/RasaHQ/rasa_core/blob/5616d3332ad22c5a29fb08b87e1dca3cfd101343/rasa_core/policies/keras_policy.py#L37
Why don't we check in train if it is not None?

Sure, feel free to change that.


Add Docker HUB automated build

Creating a docker automated build on the Hub in the Zenika organisation

Done, need to add image tag links in the readme.


Don't special-case sitemap

Originally sitemap was in site/main.ts and special-cased so that it could access all the files after they were processed.
But my simplistic sitemap implementation should by no means be forced on anyone else, it's only suitable for my site. It would also enable getting rid of the otherwise-unnecessary IMLIB_SITEBASE env var.
The main difficulty is that it needs access to all the files after they've been processed, and that the file itself should be run after the rest are processed. That's what the special-casing used to be.
One solution is to export some kind of promise or function, and if a default export is one of these, then it's called after the rest. But I can't imagine any other use-case for that, and it's therefore unclear what should happen if multiple files have such a default export. It also potentially ruins the potential for exporting promises/functions that could otherwise potentially have much potential.
A second solution is to export a well-known variable name like processLast: boolean and if this is present and true, then process it after the rest. But this would still require exporting a function.
A third solution, one I'm leaning towards, is to do nothing special, and simply import allFiles from '/' to get all the raw file contents, and then build the sitemap manually from these. The main difficulty is that array-exports produce filenames that aren't known until the file is processed. The sitemap file could just require them, but that brings up questions about the dependency graph and rebuild efficiency.

Fixed. The last solution worked fine.
Not a fan of the code duplication though. Maybe this can export logic to process an array of files into filenames?

Resolved.


Fix race condition when using goroutines (+ some maintenance)

It is not uncommon to want one goroutine to turn some events `On`/`Off`
and to trigger those events, regardless of their current status,
from another goroutine.
This triggered the race detector, as synchronization for the map read/writes
was incomplete.
This adds a test which would fail before this changeset, and the fix to it.

I believe this fixes #4 (CC @lockp111)
To run the test case:
% git checkout master
Switched to branch 'master'
Your branch is up to date with 'upstream/master'.
% git checkout fix-race -- observable_test.go # Provided you have the branch locally
% go test ./... -race -timeout=2m
==================
WARNING: DATA RACE
Write at 0x00c0000967e0 by goroutine 23:
  runtime.mapassign_faststr()
      /usr/local/Cellar/go/1.11/libexec/src/runtime/map_faststr.go:190 +0x0
  github.com/GianlucaGuarini/go-observable.(*Observable).addCallback()
      /Users/geod24/go/src/github.com/GianlucaGuarini/go-observable/helpers.go:21 +0x492
  github.com/GianlucaGuarini/go-observable.(*Observable).On()
      /Users/geod24/go/src/github.com/GianlucaGuarini/go-observable/observable.go:39 +0x65
  github.com/GianlucaGuarini/go-observable_test.TestOnOffTriggerConcurrency.func2()
      /Users/geod24/go/src/github.com/GianlucaGuarini/go-observable/observable_test.go:264 +0x8a

Previous read at 0x00c0000967e0 by goroutine 22:
  runtime.mapaccess2_faststr()
      /usr/local/Cellar/go/1.11/libexec/src/runtime/map_faststr.go:101 +0x0
  github.com/GianlucaGuarini/go-observable.(*Observable).Trigger()
      /Users/geod24/go/src/github.com/GianlucaGuarini/go-observable/helpers.go:101 +0x249
  github.com/GianlucaGuarini/go-observable_test.TestOnOffTriggerConcurrency()
      /Users/geod24/go/src/github.com/GianlucaGuarini/go-observable/observable_test.go:274 +0x1c4
  testing.tRunner()
      /usr/local/Cellar/go/1.11/libexec/src/testing/testing.go:827 +0x162

Goroutine 23 (running) created at:
  github.com/GianlucaGuarini/go-observable_test.TestOnOffTriggerConcurrency()
      /Users/geod24/go/src/github.com/GianlucaGuarini/go-observable/observable_test.go:261 +0x13b
  testing.tRunner()
      /usr/local/Cellar/go/1.11/libexec/src/testing/testing.go:827 +0x162

Goroutine 22 (running) created at:
  testing.(*T).Run()
      /usr/local/Cellar/go/1.11/libexec/src/testing/testing.go:878 +0x650
  testing.runTests.func1()
      /usr/local/Cellar/go/1.11/libexec/src/testing/testing.go:1119 +0xa8
  testing.tRunner()
      /usr/local/Cellar/go/1.11/libexec/src/testing/testing.go:827 +0x162
  testing.runTests()
      /usr/local/Cellar/go/1.11/libexec/src/testing/testing.go:1117 +0x4ee
  testing.(*M).Run()
      /usr/local/Cellar/go/1.11/libexec/src/testing/testing.go:1034 +0x2ee
  main.main()
      _testmain.go:66 +0x221
==================
--- FAIL: TestOnOffTriggerConcurrency (43.16s)
    testing.go:771: race detected during execution of test
FAIL
FAIL	github.com/GianlucaGuarini/go-observable	43.173s

Coverage increased (+0.9%) to 99.099% when pulling 6a43608c0a0f25d97c3c9d540944441802f6b24c on Geod24:fix-race into e39e699e0a002c560bdff16804c81ac1cd12fac2 on GianlucaGuarini:master.

Thanks for your pull request. Could you please avoid to change the files indentation in all the files?
In that way I will be able then to check only the code you have updated

@GianlucaGuarini : You can review commit by commit or ignore whitespace changes.
Regardless, I removed the gofmt commit.

thank you for your patch and your improvements

Weird, it definitely pass on mine (OSX) and on Travis. What OS do you run ?
I ran git remote update -p; git checkout upstream/dev; GOCACHE=off go test -a ./... -race and everything seems fine.
An async event queue would be sweet, though.


feat(cli): Add --with-prune option for diff command

Fixes https://github.com/grafana/tanka/issues/416 in line with what @malcolmholmes suggested.
Adds --with-prune option to diff command. This makes it possible to see a full diff of both added and deleted resources.
I'm not sure if it's okay to add --ignore-not-found to GetByState() or if it should be passed as argument to it. I have left a TODO in the code.
Let me know if I should change anything.

Thanks for your quick reaction!
I have implemented requested changes.
One side-effect of this PR is that tk prune no longer fails if there are new k8s objects in tanka code that were not applied yet. I think this is an improvement but it is a change in behavior so it shouldn't go unacknowledged/undiscussed. It didn't cause any issues during my testing but I felt like I should bring this up anyway.

Thanks for your quick reaction!
I have implemented requested changes.
One side-effect of this PR is that tk prune no longer fails if there are new k8s objects in tanka code that were not applied yet. I think this is an improvement but it is a change in behavior so it shouldn't go unacknowledged/undiscussed. It didn't cause any issues during my testing but I felt like I should bring this up anyway.

I was about to open an issue to discuss adding "ignore not found" behaviour to prune, so that we can see prune diffs when unapplied changes exist in the rendered manifests - but putting that behind the same command as diff is even better!
I look forward to being able to use this - any chance of a release soon? 🙏


Add -n monitoring flag to helm uninstall command

In this PR, I added the -n monitoring flag to helm uninstall command.
In the Getting Started Guide with Monitoring (Prometheus Operator), we deploy kube-prometheus-stack into the monitoring namespace. So, we need to specify the namespace monitoring, when we delete it.
If we don't specify it, the helm uninstall command returns error.

Without -n monitoring$ helm uninstall scalar-monitoring
Error: uninstall: Release not loaded: scalar-monitoring: release: not found

With -n monitoring$ helm uninstall scalar-monitoring -n monitoring
release "scalar-monitoring" uninstalled

Thank you for your review!

It would be nice if you can add a label from the next time.

I will add a label from the next time.


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

Sorry, wrong repo.


Can't create environment on Linux because of appnope

Hi @JustinChavez,
I am trying to follow your README.md instructions to create the environment. I am encountering the issue described there.
By looking here, it seems that appnope is an OS X only package...
Removing appnope from the environment.yml file seems to work. Will this generate any problems down the line?

Hi @aernesto
I am sorry you had to deal with that problem. I totally forgot to look into if any of my OSX packages might conflict with your Linux environment.
I looked into the problem and removing appnope was the right move. It should not generate any problems down the line as it was created to deal with a problem that is only relevant to OSX operating systems.
I will create two environment.yml files now. One for osx machines and one for linux machines so future users will not encounter this problem. Look out for this in a future push.


Getting error 'security_update_dependency_not_found' on security update of v2

I have recently run Dependabot to check for security updates and reported another related issue on https://github.com/tinglesoftware/dependabot-azure-devops/issues/1490. My configuration specifies multiple directories for npm and pip package managers. During a recent build, Dependabot identified numexpr as a vulnerable security package but failed to locate the exact requirements.txt file path within the multiple directories, resulting in the error 'security_update_dependency_not_found'. However, it successfully created a PR when I specified a single directory containing the numexpr package. Please let me know if I should specify a single directory exclusively for security updates or if I can proceed with the following Dependabot configuration as it is.
Please find the attached detailed logs here,
5_Run Dependabot.txt
dependabot.yml
version: 2
updates:
  - package-ecosystem: "nuget"
    directories:
      - /Engine/
    labels:
      - "nuget"
      - "dependencies"
    open-pull-requests-limit: 0
    commit-message:
      prefix: "nuget"
      prefix-development: "nuget"
      include: "scope-and-version"
      separator: "-"
    groups:
      nuget:
        patterns:
          - "*"

  - package-ecosystem: "npm"
    directories:
      - /common/**/*
      - /Frontend/
      - /sdk/
      - /Shared/
    labels:
      - "npm"
      - "dependencies"
    open-pull-requests-limit: 0
    commit-message:
      prefix: "npm"
      prefix-development: "npm"
      include: "scope-and-version"
      separator: "-"
    groups:
      npm:
        patterns:
          - "*"

  - package-ecosystem: "pip"
    directories:
      - /.azure/db-deploy-script
      - /Forecasting
      - /Utility/*
    labels:
      - "pip"
      - "dependencies"
    open-pull-requests-limit: 0
    commit-message:
      prefix: "pip"
      prefix-development: "pip"
      include: "scope-and-version"
      separator: "-"
    groups:
      pip:
        patterns:
          - "*"

@SatheeshS-optym thanks for the report. My understanding is that multiple directories should work and your configuration appears to be sane. I'm not very familiar with python or pip but when I have some free time I will attempt to reproduce the issue using your config and see  if I can find out what is going wrong.


Support nested aggregate metrics in MetricsTestCase

Add the ability to nest List[MetricsTestCase] inside a MetricsTestCase object, supporting e.g. per-class metrics reported for multiple classes within a test case.


Failed to activate the tool-bar-atom package

[Enter steps to reproduce:]

...
...

Atom: 1.49.0 x64
Electron: 5.0.13
OS: Microsoft Windows 10 Enterprise
Thrown From: tool-bar-atom package 1.7.1
Stack Trace
Failed to activate the tool-bar-atom package
At Cannot read property 'addItem' of null

TypeError: Cannot read property 'addItem' of null
    at ToolBarManager.addButton (/packages/tool-bar/lib/tool-bar-manager.js:22:22)
    at Object.consumeToolBar (/packages/tool-bar-atom/lib/tool-bar-atom.coffee:8:14)
    at Provider.provide (~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:14:1060527)
    at ServiceHub.consume (~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:11:3291876)
    at Package.activateServices (~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:11:3300108)
    at Package.activateNow (~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:11:3296863)
    at ~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:11:3296187
    at Package.measure (~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:11:3293797)
    at ~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:11:3296047
    at new Promise (<anonymous>)
    at Package.activate (~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:11:3295990)
    at PackageManager.activatePackage (~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:11:382943)
    at ~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:11:378109
    at Array.forEach (<anonymous>)
    at ~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:11:378093
    at ~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:11:335144
    at Function.simpleDispatch (~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:11:1201500)
    at Emitter.emit (~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:11:1202941)
    at Config.emitChangeEvent (~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:11:337632)
    at Config.setRawValue (~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:11:334872)
    at Config.set (~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:11:330666)
    at Config.removeAtKeyPath (~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:11:332689)
    at Package.enable (~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:11:3293582)
    at PackageManager.enablePackage (~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:11:375807)
    at HTMLButtonElement.enablementButtonClickHandler (~/AppData/Local/atom/app-1.49.0/resources/app/static/<embedded>:14:2531944)

Commands
     -7:41.1.0 grammar-selector:show (atom-text-editor.editor.is-focused)
     -7:38.3.0 core:confirm (input.hidden-input)
     -7:15 command-palette:toggle (input.hidden-input)
     -7:03.3.0 settings-view:open (input.hidden-input)
     -2:55.9.0 command-palette:toggle (input.hidden-input)
  3x -2:47 core:backspace (input.hidden-input)
     -2:36.9.0 core:confirm (input.hidden-input)
     -2:36.9.0 settings-view:uninstall-packages (input.hidden-input)
  2x -2:26.6.0 core:backspace (input.hidden-input)

Non-Core Packages
indent-detective 0.4.0
ink 0.12.4
julia-client undefined
language-julia 0.19.3
latex-completions 0.3.6
platformio-ide-terminal 2.10.0
tool-bar-atom 1.7.1
tool-bar-mfj 2.1.0
uber-juno 0.3.0

I don't use Atom anymore, I have reinstalled it to test this, but seems to be an issue with Atom (https://github.com/atom/atom/issues/21155) and I can't install any packages.
Do you have tool-bar package installed, right?
apm install tool-bar


diffoscope: 172 -> 175

Motivation for this change
New upstream release.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 123002 at 77b27f5a run on x86_64-linux 1

1 package built successfully:

diffoscope

1 suggestion:

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/tools/misc/diffoscope/default.nix:29:5:
   |
29 |     ./ignore_links.patch
   |     ^


Update testing matrix.

Codecov Report

Merging #277 (b30a7de) into master (7a39305) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #277   +/-   ##
=======================================
  Coverage   83.36%   83.36%
=======================================
  Files          26       26
  Lines        1653     1653
  Branches      374      374
=======================================
  Hits         1378     1378
  Misses        163      163
  Partials      112      112

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a39305...b30a7de. Read the comment docs.


Json schema summary

Closes #19

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2720edc). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #155   +/-   ##
=========================================
  Coverage          ?   79.38%
=========================================
  Files             ?       22
  Lines             ?     1625
  Branches          ?      288
=========================================
  Hits              ?     1290
  Misses            ?      289
  Partials          ?       46

Impacted Files
Coverage Δ

src/arche/rules/others.py
100% <ø> (ø)

src/arche/rules/duplicates.py
100% <ø> (ø)

src/arche/rules/price.py
60% <ø> (ø)

src/arche/rules/result.py
88.31% <100%> (ø)

src/arche/rules/json_schema.py
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2720edc...cf7463d. Read the comment docs.


Tables are not displayed correctly in the details view

From facebook.com:
"Hi there. This Sunday I explored the most recent update out in the field and I like it! But I experienced a problem: tables are not displayed correctly. The text of cells next to each other is displayed without any separator. This caused me to miscalculate the final coords of a cache since I read it as if the three parts have to be multiplied instead of calculated each and every one by itself.
To get an idea, what I am talking about, see the table on this cache here: http://coord.info/GC346G9
So tables should be displayed correctly on the description, and anything is fine. :)"

I've modified the code of @campbeb to use box drawing characters and to avoid unnecessary insertions. If you are not satisfied with how tables look like now, both commits must be reverted.

Works.


Add option to turn connect refs on and off

An alternative way to deal with #141
Add prop connectOptions to Provider (put in context). Default connect options are {useRefs: true}, and options can be overwritten on each connect instance (so refs can be turned on or off globally and locally). If refs are used for testing purposes only, then it gives the ability to not have them in production.
useRefs is by default true to avoid introducing a breaking change, but IMO it would be best if it is false by default (and turned on for testing and debugging purposes).

This still doesn't feel like a right solution.

I cannot think of another way right now if detecting stateless functional components is not bullet proof :persevere:

I don't think we need to detect them. Maybe we should instead offer some other API for accessing refs. For example, we could accept instanceRef prop that would act as a callback ref. If user doesn't specify it, it would be undefined.

Thanks for the PR.
In the end I decided on a simpler approach: refs are now opt-in at the connect() call site.
Closed via https://github.com/rackt/react-redux/commit/2d3d0beade55477b3af65534ceb793db18b25705.

:+1:


Sent 1 LTC to Blockcard - It disappeared from by blockcard balance

Describe the bug
5 days ago, I sent 1 LTC to my blockcard.  It appeared in the balance shortly afterwards, but then disappeared.
To Reproduce
Send 1 LTC from Litewallet to Blockcard using QR code
Expected behavior
Transactions should not diappear
Screenshots

Desktop (please complete the following information):
IOS 14.3
Windows 10
Smartphone (please complete the following information):
Iphone 11
PC
Additional context

close due to inaction


Non-default export child_process bug

I believe that there is a bug where functions that get extracted from the exports and not from the default export object don't get wrapped by Hagana.
e.g: This works:
import { execSync } from 'child_process';

export function run () {
  const result = execSync('node -v').toString();
  console.log('RESULT=', result);
}

This doesn't:
import childProcess from 'child_process';

export function run () {
  const result = childProcess.execSync('node -v').toString();
  console.log('RESULT=', result);
}

I'll take a look at this. It should work

Interesting, I tested for a similar case where I checked if:
const {execSync} = require("child_process")
bypasses the protection (it doesn't), but seems that using import bypasses the protection.

This is weird, it's only happening to me occasionally. Do you mind upload a repo with your project structure?


Add note about git hooks to contributing docs

Looks like we have another travis test stalling. Here's the raw logs : https://api.travis-ci.org/v3/job/356533671/log.txt


clipboard integration always uses X11 clipboard on Linux

flutter-winit/src/handler.rs unconditionally uses copypasta::ClipboardContext which on Linux is always a type alias for copypasta::x11_clipboard::X11ClipboardContext. As a result, even when running on Wayland, the X11 clipboard is used.
WinitPlatformHandler::new fails if the clipboard can't be initialised. As a result, it's not possible to run on Wayland without XWayland running.
I think WinitPlatformHandler should handle failure to initialise the clipboard gracefully; perhaps have clipboard: Option<ClipboardContext> and turn the set/get clipboard data methods into no-ops if it's None. If this sounds OK then I'm happy to send a pull request.
I'm not sure about the best strategy for a complete fix (using copypasta::wayland_clipboard::Clipboard on Wayland) because at the moment it doesn't seem like flutter-winit needs to care whether it's running on X11 or Wayland.

Copypasta already has a nop clipboard context that does exactly that. I think transparently selecting the right context might be something the copypasta crate should handle.

[0] https://github.com/alacritty/alacritty/blob/729eef0c933831bccfeac6a355bdb410787fbe5f/alacritty_terminal/src/clipboard.rs
[1] https://docs.rs/winit/0.21.0/winit/window/struct.Window.html#method.wayland_display

Thanks for that, I'll try to improve this in the coming days and send a pull request.


something something something dark side: full screen browser window

"Maximizing Tor Browser can allow websites to determine your monitor size, which can be used to track you. We recommend that you leave Tor Browser windows in their original default size."

http://whatsmy.browsersize.com/
http://browserspy.dk/screen.php
If you run browser in full screen mode, then you are giving away your monitor resolution.

/* 2418: disable full-screen API
 * This setting WAS under about:permissions>All Sites>Fullscreen
 * [NOTE] about:permissions is no longer available since FF46 but you can still override
 * individual domains: use info icon in urlbar etc or right click on a web page>view page info
 * set to false=block, set to true=ask ***/
user_pref("full-screen-api.enabled", false);

This stops sites you switch to full screen.
We also have (2203) dom.disable_window_move_resize->true
And, commented out, we have (2204) forcing new windows (which can specify a size) to open in a new tab
Unfortunately, there is no preference for human.do.not.use.fullscreen. It's also problematic in that the application has resize handles, and maximize buttons - both of which screw up the inner screen measurements. Add to this, users can toggle on and off toolbars, sidebars .. which also affect the result.

Maximizing and full-screen aren't the same thing.
re: 2204 - I have browser.link.open_newwindow.restriction;0 for a long time and never had a problem.
Why is it commented out?

Maximizing and full-screen aren't the same thing.

Indeed. I didn't say they were just in case you meant that. That's why I said "It's ALSO problematic in that the application has resize handles, and maximize buttons" - meaning three methods: fullscreen, maximize, resize.
2204: because I use a few popup windows :) We can revisit if you want. No big deal to me. Actually the tor resize resistFingerprinting is covering this right now with snapping window sizes. But that won't land for a while.

because I use a few popup windows

oh, ok, may I ask why you prefer that over a new tab? I'm just curious, because I'm quite happy with opening everything in a new tab by default

We can revisit if you want. No big deal to me.

nah, I don't care, was just wondering

Sure you can ask. As for the pref I already flipped it 15 minutes ago

Your choice of browser.link.open_newwindow.restriction does not bother me, but it is very user specific choice. ;)
Maybe I wouldn't force it.

@crssi It's a borderline choice. First of all, the site actually specifics the pop window size (so it's not like it wasn't expecting those results back). Remember we have resistFingerprinting which will only return inner values, but some difference may be inferred/calculated (I would have to check) that gives away external widths/heights (again I would have to check)

warn users not to maximize their window

Bugzilla

I'm already tracking that, but weirdly enough it wasn't in the RFP sticky - added it now


Conflict with Microsoft.Azure.DocumentDB

After adding a reference to NuGet package Microsoft.Azure.DocumentDB 1.17.0 to my test project, and using it in a test, tests stop showing up with the error 'Exception has been thrown by the target of an invocation.' Tests still show up using the ReSharper test runner extension.

Can you please share a small repro project to allow us to debug the issue?
Get Outlook for iOShttps://aka.ms/o0ukef

From: UniSnake<EMAIL_ADDRESS>Sent: Monday, October 16, 2017 3:14:21 PM
To: machine/machine.vstestadapter
Cc: Subscribed
Subject: [machine/machine.vstestadapter] Conflict with Microsoft.Azure.DocumentDB (#72)
After adding a reference to NuGet package Microsoft.Azure.DocumentDB 1.17.0 to my test project, and using it in a test, tests stop showing up with the error 'Exception has been thrown by the target of an invocation.' Tests still show up using the ReSharper test runner extension.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/machine/machine.vstestadapter/issues/72, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAE3fhALhQOpcmQR1OOI3bnXo1OQvAvsks5ss2S9gaJpZM4P6sPD.

In the process of creating the repro project I discovered it was an error on our end (putting initialization code in a test class constructor instead of using Establish).


Theme is not being applied.

Hello there,
I'm trying to apply this theme to my terminal but I can't.
I'm using Ubuntu WSL(Windows Subsystem for Linux)
I've already fixed the .zshrc that is not getting the correct directory to the powerlevel10k-zsh-theme and the reference from zsh_theme.
Is there anything else that I need to fix ??
The colors changed but not to the Dracula pattern, please check evidence below:

I have the same problem here... :(

Worked after I installed the Dracula theme for Terminal (I am on mac os)
https://draculatheme.com/terminal

Was running into the same issue. The fix is to install Dracula theme for Windows Terminal: https://draculatheme.com/windows-terminal
Then select the theme in your Profile.

It should activate after.


(partly) cross-platform build specs via cmd (sh:true) for windows

(partly) because arguments might still depend on the platform (windows path separators). Since this is less an issue with node processes, this enhancement can still be valuable.

You gotta fix the lint errors travis complains about.
I think this looks nice, but I'm not much of a windows user.

Should be fixed in https://github.com/dreamair/atom-build/pull/2

Thanks!


Remaining responsiveness issues (#2)

When there is a  icon in the main nav bar next to Recent Announcements, and you shrink the browser horizontally so that it goes into the hamburger, the vertical size of the nav bar changes.
On the search tab, when you shrink the browser so that the search field names start to wrap, the wrapped lines don't maintain the same level of indent as the first line - they are further to the left. They should remain lined up with the text (and to the right of the (i)).
In widget titles, as the browser shrinks and the title wraps, the text should remain lined up with itself and to the right of (i).

The (i) tooltip next to the qtype dropdown (for any/all/only) should stay with the dropdown box when the browser narrows. Right now the (i) moves to the second line by itself, and then the dropdown joins it, as the browser gets narrower.

The Min: [input] and Max: [input] should stay together as a unit (i.e. Max: [input] should go to the next line together, not say Max: on one line and then [input] on the next).

On the detail page, the magnifying glass should always stay with the value.

The Help menu is too tall with a short browser, and runs off the bottom of the screen so that various entries aren't visible and can't be selected. Probably best to change the vertical spacing in the help menu in this case.


remove unused nickname, image from user object

I want to remove the nickname and image from the user object as I don't need them.
I tried to override the assign_provider_attrs methods from the OmniauthCallbacks controller
config/routes.rb
mount_devise_token_auth_for 'User', at: 'auth', controllers: {
                              omniauth_callbacks: 'overrides/omniauth_callbacks',
  }

controllers/overrides/omniauth_callbacks_controller.rb
module Overrides
  class OmniauthCallbacksController < DeviseTokenAuth::OmniauthCallbacksController

    # break out provider attribute assignment for easy method extension
    def assign_provider_attrs(user, auth_hash)

      user.assign_attributes({
                                 email:    auth_hash['info']['email']
                             })
    end
  end
end

Did I missed something ? :) thanks

You can just write a Rails migration to remove those columns and you should be good. The default generator supports them as they tend to be common fields for new projects. Hope this helps!

what do rails migrations have to do with it? they are already not in my model and I'm getting
ActiveRecord::UnknownAttributeError (unknown attribute 'nickname' for User.):
errors correspondingly.
what is the usual way to use other column names (:name instead of :nickname) eg? overriding assign_provider_attrs?

bump! I do not understand why an assumption could be made that everyone has a nickname and image fields? And how is it that only 3 people on earth have that problem :D

If someone feels passionately about this, then I'll accept a PR to that effect, so long as tests still pass.

The reason those fields are used is because that's what's returned by OmniAuth. We could create an initializer setting for this, but it's also really easy to override the controller method to not use those fields, and to remove the columns from the db migration. The amount of code written would be about the same, and the override is more flexible.
But I don't feel that strongly about it either way.

Hi, I'm trying to remove the columns from the database but failing to do so. Is there something else needed to let me remove the columns?


Multiple languages?

I have a document written in French and English. Is this possible to have something like:
spelling_lang=['en_US', 'fr_CH']

That isn't supported today, but should be possible to implement.
The SpellingChecker would need to support loading several dictionaries and only reporting an error if the token cannot be found in any of them. It would also have to track suggestions across all dictionaries and include them all.
The configuration options would need to support specifying multiple languages, as you suggest.
And it might be useful to have a directive to control the dictionaries in use for individual files, although that isn't strictly necessary.
Are you interested in contributing those changes?

I don't know how much I am interested. I am writing a quite long documentation (in french with some english) using sphinx and it is very important for me to have a CI roughly doing a check spell. However I didn't find any good package do to this and I am not really convinced by enchant which doesn't have any good tokenizer...
For example words such as Backus-Naur should be written with a dash and supported in the dictionary as is. Currently I have two words in my dictionary: Backus and Naur because the tokenizer don't understand compound words. Also some words cannot be written with a capital letter such as C keywords (while, for, return). sphinxcontrib.spelling should therefore support the text in the code-block directives and it should support the language keywords by default. Another very annoying/important issue with the spelling is the way the user-dictionaries works. I would much prefer having a support for regex patterns. Such as for the verb eat:  [Ee]at(s?|en)|ate or manger in french [Mm]ange(s|ons|z|nt|ai[st])...
It seems sphinxcontrib.spelling is the best candidate for now, but not a good one for French :(

Yes, I suppose the quality of support for French terms depends on the underlying library for tokenizing and the dictionary for various conjugated forms of words.
It would probably be possible to support a tokenizer that recognizes technical terms like Backus-Naur, but I haven't looked into that because I haven't needed it myself, yet.
Language-specific terms within code-blocks are interesting. Perhaps the tokenizer for the syntax highlighter could be reused for that.

I should also say that most of the code base for sphinxcontrib-spelling doesn't care about which underlying spelling checker is used, so if there is a different library that works better for other languages we could make that pluggable (either based on the language or based on a new configuration option) and hide the differences in the SpellingChecker class.

I vote for this feature. Now I use a workaround - merged dictionary (en+ru).


Failed prop type: Invalid prop primary of type string supplied to RaisedButton, expected boolean.

I'm getting the following message Failed prop type: Invalid prop 'primary' of type 'string' supplied to 'RaisedButton', expected 'boolean' ...When using
  <RaisedButton primary={type == 'submit' ? 'true' : ''} >
Same if I'm using className= instead of primary=
Am I doing something wrong or is this a bug? Thx

I don't get it, why not doing the following?
<RaisedButton primary={type == 'submit' ? true : false} />

wow sorry, thx I need a break


Vite virtual imports not recognized by Knip

When using vite virual imports "virtual" appears as an unused dependency when running knip.
Example:
import { registerSW } from 'virtual:pwa-register'

Knip output:
Unlisted dependencies (1)
virtual  src/index.tsx

Actual package name: vite-plugin-pwa

I can we translate virtual:pwa-register to vite-plugin-pwa?

I am not saying we necessarily need to translate it, but maybe knip should not mark these as unused since it is very confusing for users. Either we should ignore them by default when using vite or at least make it clear when using the vite plugin (in the docs perhaps).

:rocket: This issue has been resolved in v3.3.3. See Release 3.3.3 for release notes.

Knip no longer sanitizes virtual:* specifiers, so you seem them unaltered in the report, and you can then add them to ignoreDependencies.
Another option could be to ignore them altogether, but that would be harder to implement and it may lead to confusion (not sure as I know virtually nothing about this technique).


grabbit-related updates

This PR updates pybids to reflect changes to the grabbit API introduced in version 0.2.0 (see grabbles/grabbit#69). Although the grabbit changes are backward incompatible, pybids should maintain compatibility with existing code in the vast majority of cases (the exception being cases where the user is passing multiple paths and/or domain configurations). Also, since the name of the first argument has changed from path to paths, code using named args will need a trivial fix.

Codecov Report

Merging #200 into master will increase coverage by 0.06%.
The diff coverage is 60.86%.

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   74.32%   74.39%   +0.06%
==========================================
  Files          23       23
  Lines        2193     2187       -6
  Branches      519      517       -2
==========================================
- Hits         1630     1627       -3
+ Misses        416      413       -3
  Partials      147      147

Flag
Coverage Δ

#unittests
74.39% <60.86%> (+0.06%)
:arrow_up:

Impacted Files
Coverage Δ

bids/version.py
0% <0%> (ø)
:arrow_up:

bids/grabbids/bids_layout.py
62.65% <63.63%> (+0.44%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 835a4c2...46c400c. Read the comment docs.