sap.m.DatePicker: Validation issue

OpenUI5 version: latest
Browser/version (+device/version): All
Any other tested browsers/devices(OK/FAIL):
URL (minimal example if possible): https://openui5.hana.ondemand.com/explored.html#/sample/sap.m.sample.DatePicker/preview
User/password (if required and possible - do not post any confidential information here):
Steps to reproduce the problem:

In "DatePicker with given DateValue and Formatter" field, enter 10/190/16, then tab
Note the red border appears as expected due to invalid date
Open calendar picker and select 19th day
Note red border is gone
Change date to 10/190/16 again, then tab
Note red border appears again
Open calendar picker and select 19th day
Note red border is gone
Change date to 10/190/16 again, then tab
Note no red border appears this time

What is the expected result? Expected that validation always works
What happens instead? After 3rd time entering an invalid date, the validation no longer works
Any other information? (attach screenshot if possible)  The problem appears to be in the _selectDate() function of the DatePicker.  In the block of code where wrong input before open calendar, this._lastValue is not being reset to the value that is selected from the calendar.  Since this._lastValue is not being reset, when the onchange() gets called with the same bad value, the fireChangeEvent is not
getting fired because the sValue is equal to this._lastValue. The fix is to set this._lastValue to the value selected in the calendar in the _selectDate() function.

@cmastrandrea thanks for reporting this. I could reproduce the issue. Internally tracked as<PHONE_NUMBER>.


Fix nav order jb59444

I will fix the nav_order of the Bluetooth pairing doc in https://github.com/sailfishos/docs.sailfishos.org/pull/186 as soon as this (188) PR is merged.


about the dataset

Hi, could you please provide some instrution about how to use the onepose dataset? My question is how to compute projected box corners of each frame with the given poses. I tried to use camera pose in poses_ba folder and intrinsics in intrin_ba folder to compute the projected corners, however the projected locations are slightly different from those provided in reproj_box folder. Are the intrinsic parameters from intrin_ba corresponds to the cropped images in color folder?

Thanks for the request. We will make up for this part soon

@DeriZSY , any updates on this?
Or @JenningsL , could you share what your understanding is? So that I can confirm that what I am understanding is correct

Any updates on this? Thank you!


WFLY-14706 Distributed JSF applications should auto-disable "com.sun.faces.enableLazyBeanValidation" by default

https://issues.redhat.com/browse/WFLY-14706

@fjuma Please review.


Qa

Coverage increased (+0.02%) to 84.29% when pulling ceea0bad06d4cb25aba922259b01441ec3e7f03d on qa into 08e10791507a8c2205b39cc8ebd5ea8f3d2cbfdb on master.


SQL database abstraction layer

Not an abstraction layer, but I've been using a SQLite3 interface successfully (it's more or less in sync with Kitura's main branch for test purposes, although I use PREVIEW4 rather than the dated variant), maybe that could be a first step, or a stopgap on the road to epicness.
https://github.com/krugazor/swiftydb
Unfortunately, the lack of reflection capabilities in Swift 3 seriously hampers any attempt at column <-> property mapping, but hey... it works.


Figure in Base.scss

I just wanted to use the figure tag and got a weird margin, due to base.scss:
  figure {
    margin: 1em 40px;
  }

Can we fix this and set margin: 0?

I would tend to agree.  This is aligned with what @ncoden has been advocating in terms of removing all styling on elements themselves and moving it all into class styles. cssreset tends to do margin 0 for figures... does anyone know why we had this instead? (cc @rafibomb @andycochran @brettsmason @gakimball)

@kball Normalize uses those margin values but to be honest I have no idea why. I'd agree with setting it to 0.

Agreed. Nix the figure margin.

Fixed in #9416


Inference with Angiogram image

I want to inference MedSam with my data. my data is a list of angiogram images in png format extracted from a DCM file. I tried testing with the google colab medsam.ipynb link you provided, however i got the error:
"RuntimeError: Given groups=1, weight of size [768, 3, 16, 16], expected input[1, 4, 1024, 1024] to have 3 channels, but got 4 channels instead"
below is my image, my purpose is to perform vessel segmentation and classify it as LAD, LCX or RCA vessel. Is it possible with MedSam or not. Thank you very much !!

Hi ,I got same issue, Have you solve this?

Hi @antoniaaaaaaaa ,
MedSAM may not be able to segment the vessels because the bounding box is not a proper prompt.
Training a fully automatic model based on existing dataset would be a better choice.
https://www.nature.com/articles/s41597-023-02871-z


feat: update golang-github-abbot-go-http-auth to 0.4.0

Basic and Digest HTTP Authentication for golang http
Issue: https://github.com/deepin-community/sig-deepin-sysdev-team/issues/552
Log: update repo

/lgtm
/approve


Update CODEOWNERS to add jeremyfrosti to SQL

Updating the CODEOWNERS file to add @jeremyfrosti to list of SQL code owners

Does this need anyone review?

@jeremyfrosti I think this pr needs to be reviewed by anyone on the services team first

LGTM
@kazrael2119, please help to merge it thansk~


Find out if the Android Device supports AR before displaying the icon

Currently, the AR icon and custom AR icons show up on all Android Devices regardless of their support for AR. I was wondering if there was a method/CSS or similar to detect if a device supports AR and then hide the AR icon if it's unsupported.
I'm aware that there's a fallback i.e where the Scene Viewer just shows the 3D viewer and not the AR on these devices but this works sometimes and bugs out the most of the time.
Is there a solution for this that I'm missing. Thanks for reading

@charpstar unfortunately, it's currently impossible for a script running in a browser to know if an Android phone has a specific app installed. Since Android AR is currently achieved using an external app called Scene Viewer, the only way to determine if AR is available is to try to launch the app. To make matters more complicated, the only time we are allowed to try to launch the app is when the user presses the button.
Eventually, WebXR will allow us to launch AR via the web, without relying on a native app. When this happens (and I'm told it will happen soon for Chrome), we will make it possible to hide the button when WebXR-based AR is not available.

Thanks @cdata
For now, we've found a (not so good) workaround where we sniff the user agent of the browser and then hide the badge if it does not correspond to the model number of an ARCore supported device.
Unfortunately it's manual work and we have to continuously update the list as more ARCore supported devices are launched. But this seems better than the alternative of having a non responsive button on older devices.
Hoping for a more seamless connection to Sceneviewer through html
Thanks again

Note that even though a phone doesn't have ARCore, it might have Scene Viewer. Scene Viewer has a non-AR 3D turntable mode that works on devices without ARCore. The only technical requirement for a device to have Scene Viewer (that I know of) is that it has the Google Search app installed.

Hmm not sure about that. A few of my lower end Android test phones and also my Nvidia Shield all have the Google Search app and scene viewer does not start up in those. They all seem to simply fullscreen the model viewer model.
However, when i force installed "Google Play Services for AR" on an unsupported device with an external APK, scene viewer started working. Although it crashes a lot as expected.
Regarding the issue at hand, the main usecase for our clients is the AR feature so I think our solution is the best workaround for now.

Actually, you are right. I forgot that we are using a special version of the intent that will only launch Scene Viewer if ARCore is enabled (because it triggers Scene Viewer via ARCore). However, it is possible (and even likely) that these devices could launch Scene Viewer without AR.


createClassApplier creates multiple nested elements.

This could very well be user error, but here is the scenario. I have the following function:
var theRangyClass = rangy.createClassApplier(font.filename, {
	applyToEditableOnly: true,
	normalize: true,
	tagNames: ['span', 'p'],
	elementProperties: {
		style: {
			fontFamily: font.filename,
			fontWeight: 100 || font.weight,
			fontSize: 42,
			fontStyle: font.style
		}
	}
});
theRangyClass.toggleSelection();

It works wonderfully on the first application. I select some text and run the function and it wraps the text accordingly:
I am Basil Elton, keeper of the North Point light that my father and grandfather kept before me.

But if I leave the text selected and run the function again with different parameters it just adds a nested span tag with the same attributes:

	I am Basil Elton, keeper of the North Point light that my father and grandfather kept before me.

Is there a way to instruct Rangy to reuse the current element (in my case, a ) if all of its contents are currently selected?

A Rangy class applier will reuse an existing element, so long as:

the useExistingElements option is true (which it is by default)
the element tag name is in the list of allowed tag names
the element's attributes match all the attributes in the elementAttributes option
the element's properties match all the attributes in the elementProperties option

It's the final point that is the problem here, since the style properties you're setting differ between the two class appliers. If possible, I'd suggest putting all those style properties in the class, but I imagine there's a good reason you're not already doing that.

Yeah, this is part of a Webpack/React app. I may be able to create classes with styles on-the-fly, which is suppose would solve this problem? In that case it sounds like it'll just switch out the className on the span. I'll give that a shot and report back.

Alrighty, using the smart-css package to create classes on-the-fly and it's working wonderfully, with one exception: It's adding the classes instead of replacing them.
Basil Elton

I suspect I’ll need to clear out the previous class myself?

I was able to solve for this by doing the following:
var theRangyClass = null;

// If theRangyClass exists, clear it
if (theRangyClass) { theRangyClass.undoToSelection(); }

// Create the CSS class and inline styles based on the font
// parameters passed in from the JSON
theRangyClass = rangy.createClassApplier(css.getClass(font.filename), {
	applyToEditableOnly: true,
	tagNames: ['span']
});

// Apply the class and styles to the selected text
theRangyClass.applyToSelection();


improve transparency of simulation download script

As suggested by @parejkoj, the download script should notify the user the download directory of the catalog.
Also, the Getting Started section should have the following usage example that can be used to verify that you did indeed download it and that it's located in the download location:
halocat = HaloCatalog(simname = 'something', redshift = z)

Put the download location in the "-h" help option

Actually, scripts/download_initial_halocat.py doesn't even allow -h. You should probably use ArgParse for these...

 Look up ArgParse, be amazed.

This is resolved by #297


template for creating an catalog descriptor file

Hi,
Since we have unified place for storing all the catalog yaml file, could we use template for creating a catalog descriptor file(do not need to include any code) and then push to the our repo?  If have, this would be the most convenient way for users to onboard their service via frontend.
For example, after the user submit the form,  the scaffolder can create the path based on the form content and push to github repo.

For this I think you want on piecing together existing actions. There's catalog:write that can create the catalog-info.yaml for you, and then publish:github:pull-request for publishing a PR. Right now it's only GitHub that has support for publishing via a PR.

Hi @Rugvip, could we customized our owned repoUrl?  Cause now seems accept the format github.com?repo=reponame&owner=owner.  For example, I hope it can push to github.com/<Org>/<Repo>/<team-name>/<service-name>/catalog.yaml , and team-name and service-name are from the user entered.

@chuliang014 Yep, you should be able to template that using the templating syntax

@Rugvip Perfect!  I was trying to use catalog:write and publish:github:pull-request, but how to get the catalog-info.yaml after executed? I saw the PR, and the catalog-info file is empty.

@chuliang014 You'll want to lowercase the entity under the input in that yaml

Can we close this?

Sure. Please close it.
On Mon, Sep 13, 2021 at 08:05 Ben Lambert @.***> wrote:

Can we close this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/backstage/backstage/issues/7111#issuecomment-918286839,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANMJTMX6BDGWIOOQR5ZWX3TUBYHLXANCNFSM5DV4MCQA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Godot 4?

Can this be done in Godot 4, or is it unfeasible/impossible?
I checked a few of the functions and classes used, like move_and_slide_with_snap, but they are not available in Godot 4. Which leads me to believe that porting this project was not done, because of limitations.
I suppose there is new and better stuff now in the engine for doing this, just don't know how.
I wish we had a way to simply replicate Quake movement accurately once and for all.

You can find a port here that made by someone else: https://github.com/mrezai/GodotStairs/issues/4
I made a port myself but I should test it more before release it, maybe one or two month later because I'm busy now by remaking first level of DUSK for learning purpose!

Project ported to Godot 4.


Survival mode

i suggest that there should be a command toggling survival mode, meaning that when u select a song with $play, it will show an overlay of what blocks should be placen as instruments and then the mod, provided noteblocks from the hotbar, would place the noteblocks on top of the blocks, and then tune them in survival mode, essentially turning this mod into survival compatible so u dont need creative to play epic songs

Not possible with the tuning method used

agree

Added a "survival only" mode that requires you to place the required instruments for a song within reach distance manually, then tunes them automatically when you play the song.


⚠ MineVN Maven & Resource Pack has degraded performance

In b108ad8, MineVN Maven & Resource Pack (http://app.minevn.net/pack) experienced degraded performance:

HTTP code: 404
Response time: 23261 ms

Resolved: MineVN Maven & Resource Pack performance has improved in 85049d5.


Use useNav composable of Slidev 0.48

There have been some breaking changes in v0.48, this makes it work with the current version: https://github.com/slidevjs/slidev/releases/tag/v0.48.0

Thanks for your contribution


Storybook API: use useAddonState from manager-api

I removed the custom implementation of useSharedState.
I replaced it's usage with useAddonState from manager-api
I tested if it works, and in my preliminary testing all seems to work fine.

📦 Published PR as canary version: 0.0.46--canary.54.514196a.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

@ndelangen do you think we could land this fix fairly soon https://github.com/storybookjs/storybook/pull/23991?
Curious how soon we'll need to remove the workaround.


fix(last): emit value matches with predicate instead of result of pre…

…dicate
Minor correction to last operator to emit actual values instead of emitting result of predicate if predicate matches. Also added small test case to verify behavior.

Haha. Don't code tired. Good catch!

:)

merged with 0f635ee
again, thanks for finding that for me, @kwonoj. Probably should have added more tests.


[Dropdown] Th dropdown set position

Reopening this pr for feedback because 6.1 branch was deleted.
https://github.com/zurb/foundation-sites/pull/7479

In terms of changes, this seems reasonable (other than the removed check that you mentioned wanting to reinstate.
I see 3 next steps:

Reinstate the removed check
Bring this back up to date with the current state of develop so it can be merged
Provide a visual regression test to reproduce the issue this is fixing in isolation to make it easy to test this change and make sure there are not other regressions.

Thanks!

@tjhiggins closing this in lieu of a response to the previous comment.  Please reopen with those changes


Feature/strand class

:tada: This PR is included in version 0.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix bounding box for ID PASS Lite

When scanning ID PASS Lite QR Code, the bounding box does not correspond to where the QR code should be

Tests run on 08 January 2021 at 5:50 PM PH timezone
VERIFICATION:

Able to install the App with the test build idpass-smartscanner-debug-2000_01082021_1640.apk

Able to open or use the ID PASS Lite feature

Able to capture the QR Code in the sample image /florence_idpass.svg and results with data were loaded in the page.

Tried placing the device's camera closer to the sample QR Code Image.

Sample of the Scan Results Page shown in the image below:

Run minor stress testing by repeating step 4 for 5 times only.

VALIDATION:
The feature consistently works even when the device's camera which is used to capture the code or for scanning is placed closer or very close to the QR Code image.

Tests run on 08 January 2021 at 5:50 PM PH timezone
VERIFICATION:

Able to install the App with the test build idpass-smartscanner-debug-2000_01082021_1640.apk

Able to open or use the ID PASS Lite feature

Able to capture the QR Code in the sample image /florence_idpass.svg and results with data were loaded in the page.

Tried placing the device's camera closer to the sample QR Code Image.

Sample of the Scan Results Page shown in the image below:

Run minor stress testing by repeating step 4 for 5 times only.

VALIDATION:
The feature consistently works even when the device's camera which is used to capture the code or for scanning is placed closer or very close to the QR Code image.


Enable ppc64le build

Build fails on ppc64le, with this minor change build is successful. Tested with following environment variables:
export TF_NEED_CUDA="1"
export TF_CUDA_VERSION="10.2"
export TF_CUDNN_VERSION="7"
export CUDA_TOOLKIT_PATH="/usr/local/cuda"
export CUDNN_INSTALL_PATH="/usr/lib/powerpc64le-linux-gnu"

Ari Juntunen, CTO, Elinar Oy LtdElinar, Expertise Centre Bepop, Isolinnankatu 21 E, 4th floor, FIN-28100 Poritel:+358-2-634 22 00 gsm:+358-40-52 44 482 fax:+358-2-634 22<EMAIL_ADDRESS>http://www.elinar.com Business ID:1026714-7-----"googlebot"<EMAIL_ADDRESS>wrote: -----To: "tensorflow/addons"<EMAIL_ADDRESS>"googlebot"<EMAIL_ADDRESS>04/15/2020 07:48AMCc: "Dagamies"<EMAIL_ADDRESS>"Author"<EMAIL_ADDRESS>Re: [tensorflow/addons] Enable ppc64le build (#1672)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ Googlers: Go here for more info.
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.

For your information, I believe it's possible to test in the CI, with docker buildx (it emulates different architectures during the docker build step). See https://github.com/docker/buildx/issues/115
After that, if we want to have another build just for ppc64le in github actions, well that's another subject entirely.


[FEATURE] Add custom-headers to the Azure Open AI Spring Boot Starter

Is your feature request related to a problem? Please describe.
In a Spring Boot application using the Azure Open AI starter, I need to pass a special HTTP header to access the OpenAI instance provided by my company.
The dev.langchain4j.azure.openai.spring.ChatModelProperties doest not provide a customHeaders property.
Describe the solution you'd like
In the dev.langchain4j.azure.openai.spring.ChatModelProperties class, add a customHeaders property:
    private Map<String, String> customHeaders = new HashMap();

then bind it in the AutoConfigclass.
Describe alternatives you've considered
In the meantime, I've declared a ChatLanguageModel bean and comment all the langchain4j.azure-open-ai.* properties:
	@Bean
	ChatLanguageModel chatLanguageModel() {
		return AzureOpenAiChatModel.builder()
			.deploymentName("gpt-4o")
			.endpoint(System.getenv("AZURE_OPENAI_ENDPOINT"))
			.apiKey(System.getenv("AZURE_OPENAI_KEY"))
			.customHeaders(Map.of("custom-key", System.getenv("CUSTOM_AZURE_KEY")))
			.logRequestsAndResponses(true)
			.build();
	}

Additional context
I can contribute on this feature if you want.

@arey it would be great if you could contribute this, thank you!

Hi @langchain4j I submit this PR: https://github.com/langchain4j/langchain4j-spring/pull/50

@langchain4j  as the PR https://github.com/langchain4j/langchain4j-spring/pull/50 has been merged, can this issue be closed ?


Make strings translatable in Pending Changes dialog

This PR updates the Pending Changes dialog so that the strings can be translated.

It works for me. Failed test is not related with this PR.


Just getting errors whatever I try and do...?

Hi there. I'd really love to use this but I'm just getting errors when trying to read items or authenticate (this is using Directus 11.1.1).
Both the requests below work successfully in Postman so I know everything is setup correctly on the Directus side.
Initialising and requesting some data like this:
final sdk = await Directus("https://mydirectus.com").init();
final results = await sdk.items('Test_Flutter_Collection').readMany();

Just gives me this error:
DartError: Instance of 'DirectusError'
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 296:3  throw_
packages/directus_core/src/data_classes/directus_list_response.dart 56:7     fromRequest
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 60:31           <fn>
dart-sdk/lib/async/zone.dart 1666:54                                         runBinary
dart-sdk/lib/async/future_impl.dart 178:22                                   handleError
dart-sdk/lib/async/future_impl.dart 873:46                                   handleError
dart-sdk/lib/async/future_impl.dart 894:13                                   _propagateToListeners
dart-sdk/lib/async/future_impl.dart 674:5                                    [_completeError]
dart-sdk/lib/async/future_impl.dart 760:7                                    callback
dart-sdk/lib/async/schedule_microtask.dart 40:11                             _microtaskLoop
dart-sdk/lib/async/schedule_microtask.dart 49:5                              _startMicrotaskLoop
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 181:7           <fn>

And trying to authenticate a user like this:
final sdk = await Directus("https://mydirectus.com").init();
await sdk.auth.login(email<EMAIL_ADDRESS>password: '123456789');

Gives this:
DartError: Instance of 'DirectusError'
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 296:3  throw_
packages/directus_core/src/modules/auth/auth_handler.dart 121:7              login
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 60:31           <fn>
dart-sdk/lib/async/zone.dart 1666:54                                         runBinary
dart-sdk/lib/async/future_impl.dart 178:22                                   handleError
dart-sdk/lib/async/future_impl.dart 873:46                                   handleError
dart-sdk/lib/async/future_impl.dart 894:13                                   _propagateToListeners
dart-sdk/lib/async/future_impl.dart 674:5                                    [_completeError]
dart-sdk/lib/async/future_impl.dart 760:7                                    callback
dart-sdk/lib/async/schedule_microtask.dart 40:11                             _microtaskLoop
dart-sdk/lib/async/schedule_microtask.dart 49:5                              _startMicrotaskLoop
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 181:7           <fn>

Any ideas what I could be doing wrong?

Ignore! It was a CORS misconfiguration. 🤦♂
All working now. Thanks!


Swipe issue

Swipe left and right not work in recyclerview..abstract method not implemented
at com.hudomju.swipe.SwipeableItemClickListener.onRequestDisallowInterceptTouchEvent(SwipeableItemClickListener.java)

When this happens? i have a tabbed activity when it happens is it about that?

I fixed it with a nooby approach it will hold until next update hopefully...
Create a class like this and use it. You are good to go
public class SwipeableItemClickListener extends com.hudomju.swipe.SwipeableItemClickListener {
public SwipeableItemClickListener(Context context, OnItemClickListener listener) {
super(context, listener);
}
@Override
public void onRequestDisallowInterceptTouchEvent(boolean disallowIntercept) {

}

}

There is an easier solution. Simply override the Method at instanciation time. You don't need to write a own class.
recyclerView.addOnItemTouchListener(
new SwipeableItemClickListener(getActivity(),
new OnItemClickListener() {
      @Override
      public void onItemClick(View view, int i) {
        //do stuff
      }
    }) {
      @Override
      public void onRequestDisallowInterceptTouchEvent(boolean disallowIntercept)
      {
    }
});

ugly but effective.

I loved your solution but i use this class in 4 different places rather than rewrite own class looked more effective to me. You thought me something today thanks :)


Fix OOB read with sctp_getopt(SCTP_STATUS) and AF_CONN

The code was assuming the address was either AF_INET or AF_INET6, resulting in an out of bounds read if it's actually AF_CONN.
I'm pretty confident this will just be reading some extra zeros, since new sctp_netss are always memset to 0. But still, might as well fix it to err on the safe side.

If we would reach the else error path, it is not a user error, but something very strange, because the address family of the primary path would be one we don't support. So panic()ing would make more sense than indicating a user that there is a problem.
leaving here with break would leave the stcb lock locked.
I committed a fix, which uses switch/case, in https://github.com/sctplab/usrsctp/commit/0390f325a39b067d2177b7fc4f2a08ae94a0ac6d.
Thanks for reporting the issue!

Thanks!

My bad for making the incorrect break statement, wasn't super familiar with the code. Originally reported over here if you'd like more context: https://bugs.chromium.org/p/chromium/issues/detail?id=1065253


This page does not work

Hi,
I tried several times to follow the instructions and it failed every time.  When I repeated the commands verbatim it is still failing.  The error message is
<user>@<domain>@<vm-ip-address>: Permission denied (publickey).
I replaced the user, domain and IP address only.
When I try with --debug flag:
...  <skipping verbose output> ...
cli.azext_ssh.ssh_utils: Running ssh command ssh <user>@<domain>@<vm-ip-address> -i /tmp/aadsshcertam2xmar5/id_rsa -o CertificateFile="/tmp/aadsshcertam2xmar5/id_rsa.pub-aadcert.pub" -v
OpenSSH_7.6p1 Ubuntu-4ubuntu0.6, OpenSSL 1.0.2n  7 Dec 2017
debug1: Reading configuration data /home/rantonov/.ssh/config
debug1: /home/rantonov/.ssh/config line 66: Applying options for *
debug1: Reading configuration data /etc/ssh/ssh_config
debug1: /etc/ssh/ssh_config line 19: Applying options for *
debug1: Connecting to <IP_ADDRESS> [<IP_ADDRESS>] port 22.
debug1: Connection established.
debug1: identity file /tmp/aadsshcertam2xmar5/id_rsa type 0
debug1: identity file /home/rantonov/.ssh/id_rsa type 0
debug1: certificate file /tmp/aadsshcertam2xmar5/id_rsa.pub-aadcert.pub type 4
debug1: Local version string SSH-2.0-OpenSSH_7.6p1 Ubuntu-4ubuntu0.6
debug1: Remote protocol version 2.0, remote software version OpenSSH_7.6p1 Ubuntu-4ubuntu0.6
debug1: match: OpenSSH_7.6p1 Ubuntu-4ubuntu0.6 pat OpenSSH* compat 0x04000000
debug1: Authenticating to <IP_ADDRESS>:22 as '<user>@<domain>'
debug1: SSH2_MSG_KEXINIT sent
debug1: SSH2_MSG_KEXINIT received
debug1: kex: algorithm: curve25519-sha256
debug1: kex: host key algorithm: ecdsa-sha2-nistp256
debug1: kex: server->client cipher<EMAIL_ADDRESS>MAC: <implicit> compression: none
debug1: kex: client->server cipher<EMAIL_ADDRESS>MAC: <implicit> compression: none
debug1: expecting SSH2_MSG_KEX_ECDH_REPLY
debug1: Server host key: ecdsa-sha2-nistp256 SHA256:aQ/ShfOfO2O6bwjZvxFYerku2eIPP2YJo5ZJPn3V9u4
debug1: Host '<IP_ADDRESS>' is known and matches the ECDSA host key.
debug1: Found key in /home/rantonov/.ssh/known_hosts:145
debug1: rekey after 134217728 blocks
debug1: SSH2_MSG_NEWKEYS sent
debug1: expecting SSH2_MSG_NEWKEYS
debug1: SSH2_MSG_NEWKEYS received
debug1: rekey after 134217728 blocks
debug1: SSH2_MSG_EXT_INFO received
debug1: kex_input_ext_info: server-sig-algs=<ssh-ed25519,ssh-rsa,rsa-sha2-256,rsa-sha2-512,ssh-dss,ecdsa-sha2-nistp256,ecdsa-sha2-nistp384,ecdsa-sha2-nistp521>
debug1: SSH2_MSG_SERVICE_ACCEPT received
debug1: Authentications that can continue: publickey
debug1: Next authentication method: publickey
debug1: Offering public key: RSA-CERT SHA256:181+lo+9tP7kvw4rehHbUGbdvbROshXX+8/HKMZ7Y3E /tmp/aadsshcertam2xmar5/id_rsa.pub-aadcert.pub
debug1: Authentications that can continue: publickey
debug1: Offering public key: RSA SHA256:181+lo+9tP7kvw4rehHbUGbdvbROshXX+8/HKMZ7Y3E /tmp/aadsshcertam2xmar5/id_rsa
debug1: Authentications that can continue: publickey
debug1: Offering public key: RSA SHA256:uRuTlEnZEgXVC7eA+/gzRrJ24v/YzhKOXv1ApKjkpO4 /home/rantonov/.ssh/id_rsa
debug1: Authentications that can continue: publickey
debug1: No more authentication methods to try.
<user>@<domain>@<vm-ip-address>: Permission denied (publickey).

Please help understand what is going on.  Thanks!
My environment:
Windows 10 with Ubuntu 18.04LTS Linux subsystem.
az CLI version 2.34.1
Python 3.8.12

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a2ede563-b873-0bc3-959f-69e555f0efcc
Version Independent ID: 8471d9e4-6c79-0cf1-c5ed-50c58e1b92aa
Content: Login in to Linux virtual machine in Azure using Azure Active Directory and openSSH certificate-based authentication
Content Source: articles/active-directory/devices/howto-vm-sign-in-azure-ad-linux.md
Service: active-directory
Sub-service: devices
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@rantonov
Thanks for your feedback! We will investigate and update as appropriate.

Any news/updates please?

Yes, there was a mixup in the back end of AAD with my credentials.  Microsoft support helped me fix it.  Thanks!


Great input but could do with a little more

Love this feature, however it would be extremely helpful if the analysis could be broken down by channels within the teams as well.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b915f0b3-9522-c54f-99a1-a5b4e3e9b3fa
Version Independent ID: ab0ec929-ce56-b9f1-90a7-623b2ead4119
Content: Analyze Teams usage in the Power BI app for Teams - Power BI
Content Source: powerbi-docs/collaborate-share/service-teams-analytics.md
Service: powerbi
Sub-service: pbi-collaborate-share
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Thanks for your comment, @CBurton87. This issue has been assigned to the doc author for review.

Hi @CBurton87, thanks for your feedback. You've reached the channel for docs feedback to the content writers, and it seems like your feedback is more about a feature enhancement. If that's the case, then I suggest you make the suggestion at https://ideas.fabric.microsoft.com/. Hope this helps!


using downloadable font instead of local font resource

Issue

close #230

Overview (Required)

add Google Font plugin
change font resource in Type.kt

Links

Downloadαble Font Reference

Screenshot
Nothing to difference in view

Before
After

Thanks! I didn't know about compose's downloadable font!
Could you run ./gradlew spotlessKotlinApply?

@takahirom I run the ./gradlew spotlessKotlinApply and commit the diff.

Thank you!


Error: MPMD detected but reload is not supported yet for neuron distributed environment with EAGER DEBUG MODE

Hi, I found the error MPMD detected but reload is not supported yet will occur if I open Eager Debug Mode for a model trained in neuron distributed environment where dp=1, tp=8, pp=4. Could you help check this issue? Thanks so much!

I attach related scripts here and you can simply run ./run_simple_model_tp_pp.sh  after download them.
scripts.zip
Environment information:
EC2 Instance: trn1.32.xlarge
OS: Ubuntu 20.04
Neuron Pytorch: Latest 2.18

Thank you for reporting the issue. MPMD detected error means that 1 worker is trying to load a new graph vs the other worker is waiting to perform inference, and hence the graphs that have collectives are not able to communicate with each other. Here the assumption is that each worker performs the same set of operations and hence all workers would be in SPMD mode. This assumption is broken and hence you see the above error.
We are looking into the scripts now to identify which worker is producing a new graph (and why) and if we can modify the scripts such that graphs with collectives do not change from iteration to another. Will report back once we have an update.

Thank you for reporting the issue. MPMD detected error means that 1 worker is trying to load a new graph vs the other worker is waiting to perform inference, and hence the graphs that have collectives are not able to communicate with each other. Here the assumption is that each worker performs the same set of operations and hence all workers would be in SPMD mode. This assumption is broken and hence you see the above error. We are looking into the scripts now to identify which worker is producing a new graph (and why) and if we can modify the scripts such that graphs with collectives do not change from iteration to another. Will report back once we have an update.

Thanks for your detailed explain! And I'd like to know that: Will this error interrupt the process of generating hlo graphs?
I mean, my assumption is that I can't get all hlo graphs because the graph generation process will be shut down due to this error. Is my assumption right?

So at a time, only one graph can be executed. In this case, since the run errored out at this graph, you can generate only graphs upto this point. If you want to generate all the graphs without worrying about execution, you can run with neuron_parallel_compile . The utility should help to extract all the HLOs, compile them and save them in the cache.

@wfckl789 just want to check in to see if you were you able to make forward progress?

@wfckl789 just want to check in to see if you were you able to make forward progress?

In this case as I obeserved, the cc compiler raised this compilation fault before the forward progress was executed, because I didn't see the loss value.

Any particular reason for trying eager mode in mutli-worker case? Note: Eager debug mode is only for debugging and is not the most performant mode of execution


Samsung Internet for Android 4 should support Webpush (Can someone verify it?)

According to http://developer.samsung.com/technical-doc/view.do?v=T000000202 Samsung Internet 4 should support webpush.
Because I don't have a compatible device, I cannot test it, and therefore aren't creating a pull request yet, but if there is anyone who could verify that it works that would be great :)

I visited a store today where I could successfully test this with an exhibition unit, and yes push notifications work fine under Samsung Internet 4. Pull request follows shortly :)


[Collector] fix the collector cannot started

Please answer these questions before submitting pull request

Why submit this pull request?
[x] Bug fix
[ ] New feature provided
[ ] Improve performance

Coverage remained the same at 19.237% when pulling 3c24de2f9c9fec48966e962996d774a9f269c508 on ascrutae:fix/collector-start-failed into 87a49597252f73eb057297bb820be9be63991353 on apache:master.

@peng-yongsheng please recheck this.


Fix worker_pid handling by replacing old pid with new one. fix #1723

Old implementation includes dead process pid in worker_pid list even if the process is restarted.
This patch replaces dead process pid with new process pid.

@mururu @abicky Could you check this patch?

@mururu If there is no problem, I will merge this.


Adds a k_pipe_flush() API

Fixes #21512
This set of commits adds two pipe flush APIs: k_pipe_buffer_flush() and k_pipe_flush().
k_pipe_buffer_flush() clears out just the specified pipe's ring buffer. If there were threads pending to write into this buffer, then they will attempt write into the buffer just as if another thread had issued a k_pipe_get() call and read those same bytes from the pipe. Thus, it is analogous to reading buffer size bytes into a temporary and then discarding the buffer (but without using a temporary buffer).
k_pipe_flush() builds upon this idea and flushes not just all the data in the pipe's ring buffer, but also all the data waiting to be written to the pipe.
To this end, k_pipe_get(), k_pipe_flush() and k_pipe_buffer_flush() now become wrappers to a common internal interface--pipe_get_internal(). It is expected that when users/developers call k_pipe_get() they specify a valid buffer into which to read the data, which in turn passes that buffer to pipe_get_internal(). The two new flush routines pass NULL instead of a valid buffer to pipe_get_internal(). This allows the bulk of the pipe logic to remain unchanged and minimize the addition of code to support this enhancement.
Along with this, there are a few other minor items cleaned up in the pipe code as this seemed like a good opportunity to do so.

Some build warnings related to void pointer arithmetic have been resolved.
References to asynchronous writes to the pipe have been removed as their support was removed months ago.
k_pipe_cleanup() has been beefed up to fix a race condition.

@andyross ping


PUT and DELETE do not work when route has more than 3 "/"'s

[x] I have written a descriptive issue title
[x] I have verified that I am running the latest version of Nancy
[X] I have verified if the problem exist in both DEBUG and RELEASE mode
[X] I have searched open and closed issues to ensure it has not already been reported

Description
If i have a route in my application called e.g.
https://localhost/api/Foo/Bar/ then GET, POST, DELETE and PUT work.
But if i have
https://localhost/api/Foo/Bar/Something then GET, POST work**, DELETE and PUT does not work.**
If i look at teh "ROUTES" property, all the routes are correct...
Is this expected behaviour = ?
 Buut get and post will.
System Configuration
ASP.NET MVC5, with OWIN and Cookies auth.

Nancy version: 1.4.4
Nancy host

[ ] Nancy.Hosting.Aspnet
[ ] Nancy.Hosting.Self
[x] Nancy.Owin (System.Web)
[ ] Other:

Other Nancy packages and versions: Nancy.Bootstrappers.Autofac(1.4.1), Nancy.MSOwinSecurity(2.0.0)
Environment (Operating system, version and so on): Win 10
.NET Framework version: 4.7

Great xt0rted... i was missing builder.UseStageMarker(PipelineStage.MapHandler); !!!

In my project this works with the same packages and .NET 4.6.2.
Nancy is set up like so
app.Map("/api", builder =>
{
    builder.UseNancy(options =>
    {
        // ...
    });
    builder.UseStageMarker(PipelineStage.MapHandler);
});

One of my async DELETE routes is
/api/transaction/123/horseprofile/videolink/456

/api is from the owin mapping
/transaction/{id:int}/horseprofile is the module path
/videolink/{videoId:int} is the route itself

Dammit. The "builder.UseStageMarker(PipelineStage.MapHandler);" did help the routing. But then it messes up the session for the http context.
I am using redis session based cache, and adding:
app.Use((context, next) =>             {                 var httpContext = context.Get<HttpContextBase>(typeof(HttpContextBase).FullName);                 httpContext.SetSessionStateBehavior(SessionStateBehavior.Required);                 return next();             });
Allowed the session to be available in Nancy HttpContextBase from the GetOwinEnviroement.
But this no longer works after adding the UseStageMarker to the Map.
Before i had the UseStageMarker on the App and this works fine., but the PUT and DELETE do not work with paths that have more than 3 "/"'s.
Any ideas?

Have you tried adding a second stage marker after Nancy to make sure it runs after the session state has been aquired?
See https://docs.microsoft.com/en-us/aspnet/aspnet/overview/owin-and-katana/owin-middleware-in-the-iis-integrated-pipeline
Something like this:
app.Use((context, next) =>
{
    var httpContext = context.Get<HttpContextBase>(typeof(HttpContextBase).FullName);
    httpContext.SetSessionStateBehavior(SessionStateBehavior.Required);
    return next();
});

app.UseStageMarker(PipelineStage.MapHandler);

app.UseNancy();

app.UseStageMarker(PipelineStage.PostAcquireState);

Hi k
Thats really great, thanks!
I will try first thing tomorrow. The interesting thing is the “UseNancy()” and stage is in the Map. It needs to be otherwise the mvc site doesn’t work.
Still I will see if it helps :-)

Hi Again
I have now tried all the combinations i could think off.
I have had the SetSessionStateBehavior inside of the branch and out side of it.
The rule is always this. If i do not have:
branch.UseStageMarker(PipelineStage.MapHandler); then the PUT and DELETE do not work when there is .e.g api/foo/bar/something. But do work when the address is api/foo/bar., The GET and POST always work. However the Session does resolve.
If i do have branch.UseStageMarker(PipelineStage.MapHandler);  then the PUT and DELETE alone with GET and POST work for all paths,  However the Session does not resolve.
I have even tried to specify this mush (inluding combinations with and without the UseStageMarker.
The Barnch MUST have a branch.UseStageMarker(PipelineStage.MapHandler); otherwise it does note resolve for the 3 "/"'s in PUT and DELETE:
It is very weird that the GET and POST work, but not the PUT and DELETE!...
app.Use((context, next) =>             {                 var httpContext = context.Get<HttpContextBase>(typeof(HttpContextBase).FullName);                 httpContext.SetSessionStateBehavior(SessionStateBehavior.Required);                 return next();             });             app.UseStageMarker(PipelineStage.MapHandler);             app.Map("/api", branch =>             {                 branch.UseStageMarker(PipelineStage.MapHandler);                 branch.UseNancy(options =>                 {                     options.Bootstrapper  = new ApiBootstrapper(container);                     options.PerformPassThrough = context => context.Response.StatusCode == HttpStatusCode.NotFound;                 });                 branch.UseStageMarker(PipelineStage.PostAcquireState);             });             app.UseStageMarker(PipelineStage.PostAcquireState );

Funny. I have even tried with and all paths work, but not httpcontextbase session:
`app.Use((context, next) =>
{
var httpContext = context.Get(typeof(HttpContextBase).FullName);
httpContext.SetSessionStateBehavior(SessionStateBehavior.Required);
return next();
});
app.Map("/api", branch =>
{
branch.UseNancy(options =>
{
options.Bootstrapper  = new ApiBootstrapper(container);
options.PerformPassThrough = context => context.Response.StatusCode == HttpStatusCode.NotFound;
});
app.UseStageMarker(PipelineStage.MapHandler);
        });`

However the sessions work here, but not the PUT and DELETE paths api/foo/bar/something
app.Use((context, next) =>             {                 var httpContext = context.Get<HttpContextBase>(typeof(HttpContextBase).FullName);                 httpContext.SetSessionStateBehavior(SessionStateBehavior.Required);                 return next();             });             app.Map("/api", branch =>             {                 branch.UseNancy(options =>                 {                     options.Bootstrapper  = new ApiBootstrapper(container);                     options.PerformPassThrough = context => context.Response.StatusCode == HttpStatusCode.NotFound;                 });             });             app.UseStageMarker(PipelineStage.MapHandler);

Hmm. This sounds like an IIS issue. PUT and DELETE not working is a classic WebDAV issue. See https://stackoverflow.com/a/29885790/682105:
<modules>
  <remove name="WebDAVModule"/>
</modules>
<handlers>
  <remove name="WebDAV" />
</handlers>

I can try it, but WebDAV is not enabled.
And the DELETE and PUT do work. Only not with to many ´ssgments in the route. GET and POST do not have the Segment issue...

Sorry.
No cigar. No luck.
This is still the only way the session works but the POST and DELETE with "many" segments do not work.

The question is would then be. Why does GET and POST work, but not PUT and DELETE.
It there a bug in this.
Or is there a issue in the httpcontext session resolving with the branch owin context.
I think the next step is for me to make a bare minimum project that replicates.

I think the next step is for me to make a bare minimum project that replicates.

Yes, that would be awesome.

The question is would then be. Why does GET and POST work, but not PUT and DELETE.
It there a bug in this.

There should be absolutely no limit to how many "segments" you can have, or any connection between the route's segments and the HTTP method. At least not in Nancy.
You mentioned

and they will not be called. Buut get and post will.

Does that mean you've set breakpoints and verified that they're not called? What's the response you get back?
It sounds an awful lot like IIS is snatching the requests before they reach Nancy, because there's no special handling of PUT or DELETE in Nancy.

Hi
I have put breakpoints in the Module with the route. The get, post, put and delete are in the same module. This is where i can see that the get and post gets called, but not the put/delete.
I can also see in the browser console that a 404 is returned..
I can’t see that the IIS is snatching the app has a map for /api/ goes to Nancy and I think the Nancy passthrough on the app mapping is returning the 404.
I will make sure when I make the test solution.
Please give me to the weekend... I have to finish some other stuff first....

Hej Kristian. Håber alt er vel :-)
I have made a very simple autofac, nancy mvc5 project with OWIN. I began adding a inproc session, but when i span the application up the get and post work, but not the delete and put.
Maybe this should be the focus, and then the session stuff as part 2.? Tehh nancy module is in the class Module1.
I have used the chrome arc app for rest testing.
As stated all the GET and POSTs work, buit none of the DELETE and PUT work.
Have i done something completely silly/wrong?
Thanks for your time
AutofacOwinNancy.zip

Nancy does not handle DELETE or PUT any differently than GET or POST. There's especially no artificial limitations imposed by Nancy on the number of route segments you can use with those two verbs.
Like @khellang mentioned https://github.com/NancyFx/Nancy/issues/2820#issuecomment-342415875 this is a web server thing (evident by the fact that you are getting an IIS error page and not a Nancy error page)
I took your sample, added this solution https://forums.asp.net/t/1961593.aspx?DELETE+PUT+verbs+result+in+404+Not+Found+in+WebAPI+only+when+running+locally and I can run the DELETE and PUT routes without any problems

I'll close this now. I consider this to be done and not related to Nancy
Thanks

Thanks. It did the trick!
<system.webServer>

</system.webServer>


Single click support

What feature or improvement do you think would benefit Files?
Possibly not too noticable but over time the Windows 11 UI has evolved to single click support.
Windows File Explorer in many ways is the exception and while it does provide support for single click, this is not the default option. If the option is selected then a single click will open a folder or launch a file (through association). To allow differtiation between this behaviour and a simple select (e.g. to select items to copy), check boxes appear next to files/folders.
Can this option be added to the Files App? Not only does it provide consistency is workflow but it's also very useful for people who suffer from RSI as a single click is less stress on the hands than a double click.
Thanks,
Leonard
Requirements

This proposal will accomplish X
This proposal will accomplish Y
This proposal will accomplish Z

Files Version
<IP_ADDRESS>
Windows Version
10.0.22631.2861
Comments
No response

Thanks for the feedback, single click is already supported. You can enable the option via the "Folders" settings page.


doc: Compatibility details

This adds some clarifications in the Readme regarding Erlang compatibility, auto-installed version requirements, include_erts, etc.
First commit includes clarifications in the Readme.

Much clearer.


Add --in-exportdb, --not-in-exportdb, and --missing-from-export query options

These would allow for comparing a Photos library against an osxphotos export export database to find photos that were previously exported, those that were not previously exported, and those that were previously exported but are now missing from the export (e.g. they were moved or deleted).
All would take the export path: --in-exportdb EXPORT_PATH which could be an export location or the actual database if --exportdb option was used at export.
--in-exportdb EXPORT_PATH: find all photos that are in the Photos library and were previously exported to EXPORT_PATH.
--not-in-exportdb EXPORT_PATH: find all photos that are in the Photos library and were not previously exported to EXPORT_PATH.
--missing-from-export EXPORT_PATH: find all photos that are in the Photos library that were previously exported to EXPORT_PATH but are no longer there. (UUID is in export database but file is missing from EXPORT_PATH).

thank you! waiting for this feature


fix/all: always unlock the file, even on errors

Also fix Clippy warnings and don't export ScopedUserAppDirRemover anymore.

This change is

r? @Fraser999
(maidsafe_highfive has picked a reviewer for you, use r? to override)

r? @dirvine

Reviewed 1 of 3 files at r1.
Review status: 1 of 3 files reviewed at latest revision, 1 unresolved discussion.

src/file_handler.rs, line 112 [r1] (raw file):

                let write_result = f.write_all(&contents);
                try!(f.unlock());
                try!(write_result);

Ah nice catch, sneaky move, so result enum will evaluate to return error after the unlock(), never spotted that one.

Comments from Reviewable

Reviewed 2 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Use target mode as task dependency discriminator

Checks the Kotlin executable target mode against the webpack target mode, and only adds the Zipline compile task as a task dependancy if they both match. This prevents the issue where running development webpack causes both compile Zipline production and compile Kotlin production to run.
This approach is slightly fragile as it depends on both modes having the same name, but that's pretty unlikely to change.

NICE


Model into Block

I just wrote the model class in order to retrieve data but I'm not so sure about how I injected the model class into the CustomBlock. I mean, in the constructor I specified Tym17\AdminSample\Model\AdminSample and even if this looks correct at first, I don't like it.
In this way the constructor depends on a specific model class (AdminSample) instead of depending on a generic interface.
What do You think?

It looks fine in my opinion, I remember having troubles getting my models injected in my blocks,  controllers and other places. I had to use ObjectManager like so to get any of my models:
$this->_config = $objectManager->create('Tym17\Sample\Model\Config');
Injecting it this way in the constructor:
\Magento\Framework\ObjectManagerInterface $objectManager
However depending on what you are looking to make, I think you can have different approaches, injecting it this way implies it is a sort of singleton. This is probably why you don't like it the way you injected it.

Some classes (if I recall correctly most controllers do) should already have this ObjectManager injected by default as private.

Thank You for your suggestions, You helped me to understand better this topic.
I spent some time reading about DI in Magento2 in this days because I really didn't know what to think. The official documentation, as always, doesn't explain all the things a developer would need to know. I'm still studying Magento2, that's why I'm so full of dubts.
Anyway in this particular case, just because nobody will probably need to override/replace this model I think that yes, I injected it in the "right way", or at least not in the worse possible way :D (and if someone need to modify methods behaviour, he would use a plugin).
About the way You showed me how to use the Object Manager, it would be very handy and easy to use but it is considered a bad practice. If We pull out something (in this case a model) from the object manager, We are using it as a service locator in the wrong way. We should instead inject the object.
In order to do this correctly way we should:

create a file in Tym17/etc/adminhtml/di.xml
modify the CustomBlock.php constructor

More in dept:
Tym17/etc/adminhtml/di.xml should be something like this
<?xml version="1.0" ?>

<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
    <preference for="\Tym17\AdminSample\Api\Data\AdminSampleInterface" type="Tym17\AdminSample\Model\AdminSample" />
    <type name="Tym17\AdminSample\Block\Adminhtml\CustomBlock">
        <arguments>
            <argument name="adminSampleModel" xsi:type="object">Tym17\AdminSample\Model\AdminSample</argument>
        </arguments>
        <!--<arguments>
            <argument name="adminSampleModel" xsi:type="object">Tym17\AdminSample\Model\AdminSampleTwo</argument>
        </arguments>-->
    </type>
</config>

In preference tag we specify that everytime the Object Manager tries to instantiate an AdminSampleInterface, it has to instantiate an AdminSample model:
<preference for="\Tym17\AdminSample\Api\Data\AdminSampleInterface" type="Tym17\AdminSample\Model\AdminSample" />

If we need more in dept configuration, we can specify that only in Tym17\AdminSample\Block\Adminhtml\CustomBlock constructor, AdminSampleInterface must be an AdminSampleModel:
<type name="Tym17\AdminSample\Block\Adminhtml\CustomBlock">
        <arguments>
            <argument name="adminSampleModel" xsi:type="object">Tym17\AdminSample\Model\AdminSample</argument>
        </arguments>
        <!-- if we need to instantiate another model (...\Model\AdminSampleTwo), this should be the way to override the previous one -->
        <!--
        <arguments>
            <argument name="adminSampleModel" xsi:type="object">Tym17\AdminSample\Model\AdminSampleTwo</argument>
        </arguments>-->
    </type>

Thus, in the CustomBlock constructor we pass AdminSampleInterface as dependency and the ObjectManager will instantiate the right object, avoiding in this way the service locator problem.
public function __construct(
        Template\Context $context,
        AdminSampleInterface $adminSampleModel,
        array $data = []
    ) {
        parent::__construct($context, $data);
        $this->_adminSampleModel = $adminSampleModel;
    }

In this way, any other developer should be able to configure and to change our settings, and You should easily solve that problems You had when You tried to inject models into blocks and controllers.
This is what I've learned so far about DI in Magento2, I'm still confused about injectable and non-injectable types and rules.

Yes the official documentation isn't clear sometimes (often in my opinion :P )
You are right, the usage of objectManager isn't recommended however it is one of the only ways i found to get a model. I've seen accross Github, samples of plugins that were using it only to get an instance of their model and then would have a sort of secondary __construct() function where the model populates itself with the values it have in the database from a given Id value in the URL or returns an error.
Thanks for the explaination on DI, i had trouble while understanding how Magento2's XML files works since the doc is not that populated. And about those injectables and non-injectables i guess that every model that relies on doing general operations (such as a singleton or the model you created) could be injectables otherwise models requiring special values in order to work or representing values such as an order or so should not be injectable which sounds normal since you can't really pass a particular parameter while creating it.
This goes back to the process i seen on Github using the objectManager to get the model structure then populating it but this rely on the objectManager which in theory should not be used.


Clean up Front Page styling

Cleaned up many unnecessary css classes
The Search bar (Along the h2 and Alert) are now inside a container resulting to more consistent layout

Search Bar

Now uses max-w-screen-md for max width
Fixed sort button text wrapping causing inconsistent search bar height
Changed the custom drop shadow to a tailwind provided one.
Should behave less wonky overall

Before:

After:

Sidebar

Adjusted some padding for better readability and more compact layout
Removed the <hr /> elements for more cleaner look.

Before:

After:

gonna merge this as is, we can tackle the minecraft versions stuff (see discussion in #design) later
thanks


Include exception in error hit

Added a failRequest method that fails a request and ticks the error metric and is called from everywhere that was previously just calling s.handler(Failure(_)).
Differentiation between the NotConnectedException and ConnectionLostException in the connectionLost method.
purgeBuffers method uses the exception passed to fail the request instead of wrapping the exception in a ConnectionLostException.

This ignores requests that are pending.
Some things I could also do:

Get rid of the droppedRequests, disconnects and connectionFailures metrics since this information is now captured by the errors metric.
Extend RootDisconnectCause by Exception so that we can hit the error metric with a more detailed reason instead of the somewhat generic NotConnectedException/ConnectionLostException exceptions.

Current coverage is 82.70%

Merging #270 into master will increase coverage by +0.11% as of ac2d632

@@            master   #270   diff @@
=====================================
  Files           54     54
  Stmts         2971   2972     +1
  Branches         0      0
  Methods
=====================================
+ Hit           2454   2458     +4
  Partial          0      0
+ Missed         517    514     -3

Review entire Coverage Diff as of ac2d632

Powered by Codecov. Updated on successful CI builds.

:+1:


Create Redline for OIPC Review

As an IAO analyst
I want to create a new review layer
so that I can download a redlined copy and send records to the Office of the Information and Privacy Commissioner (OIPC)
and be able to add or remove redactions as needed.

Assumptions & Scope
Redactions have been applied, and a response package has been sent to the applicant.
What is IN scope?
What is NOT in scope?
OIPC complaints such as:

A failure to make a reasonable effort to assist.
A failure to respond on time (deemed refusal).
An inadequate search for records in response to a request for records.
An inappropriate fee assessment.
A refusal to waive an assessed fee.
An unauthorised extension of the public body's time to respond to an access request.

Acceptance Criteria
Scenario 1: Creating an OIPC Review Layer

GIVEN An IAO analyst is on a request where a request for review of severing has been received from the OIPC
WHEN They select the review layer drop-down option
THEN there will be an option named "OIPC Review."

Scenario 2: Adding an OIPC Review Layer

GIVEN An IAO analyst is on a request where a request for review of severing has been received from the OIPC
WHEN They select the review layer "OIPC Review" from the drop-down option
THEN a new review layer will be applied called "OIPC Review."

Scenario 3: Not adding an OIPC Review Layer

GIVEN An IAO analyst is on a request where a request for review of severing has been received from the OIPC
WHEN They select the review layer "OIPC Review" from the drop-down option
AND then click out of the menu option
THEN the review layer menu options will close
AND no review layer will have been applied.

Scenario 4: Copying severing from Redline to OIPC Review Layer

GIVEN An IAO analyst is on a request where a request for review of severing has been received from the OIPC
WHEN They select the review layer "OIPC Review" from the drop-down option
AND choose to apply the "OIPC Review" layer
THEN the "OIPC Review" layer will show
AND all redaction boxes drawn on the redline will be available in the new layer.

Scenario 5: Changing severing on OIPC Review Layer

GIVEN An IAO analyst is on a request where a request for review of severing has been received from the OIPC
WHEN An "OIPC Review" layer has been applied
THEN the redaction boxes from the redline will be active
AND the redaction boxes can be edited, resized, changed by another user, etc.
AND the redaction boxes can be deleted
AND new redaction boxes can be added

Scenario 6: Preparing an OIPC Review Layer to send to the OIPC

GIVEN An IAO analyst is on a request where a request for review of severing has been received from the OIPC
WHEN An "OIPC Review" layer has been applied
AND the option to create "OIPC Package" has been selected
THEN the analyst will be able to download a redline from the OIPC review layer
AND all previous redaction boxes and FOIPPA sections will appear unredacted.

Scenario 7: Choosing not to prepare an OIPC Review Layer to send to the OIPC

GIVEN An IAO analyst is on a request where a request for review of severing has been received from the OIPC
WHEN the option to create "OIPC Package" has been selected
AND the analyst chooses not to create an "OIPC Package"
THEN the menu option will close
AND no redline will be produced to download.

Scenario 8: Preparing an OIPC Review Layer to send to the OIPC that contains s.14

GIVEN An IAO analyst is on a request where a request for review of severing has been received from the OIPC
WHEN An "OIPC Review" layer has been applied
AND the option to create "OIPC Package" has been selected
AND the original redline contained information withheld under s. 14
THEN a modal will be displayed asking the analyst to confirm they want to apply the section 14
AND the default of this modal will be "YES".

Scenario 9: Choosing not to prepare an OIPC Review Layer to send to the OIPC that contains s.14

GIVEN An IAO analyst is on a request where a request for review of severing has been received from the OIPC
WHEN the option to create "OIPC Package" has been selected
AND the modal asking the analyst to confirm they want to apply the section 14 is available
AND the analyst chooses not to create the "OIPC Package"
THEN the modal will close and no "OIPC Package" will be created.

Scenario 10: Applying section 14 to an OIPC Review Package

GIVEN An IAO analyst is on a request where a request for review of severing has been received from the OIPC
WHEN An IAO analyst has selected to create a redline
AND They have confirmed that s. 14 is to be applied
THEN the analyst will be able to download a redline from the OIPC review layer
AND all previous redaction boxes with s. 14 will appear as redacted
all other previous redaction boxes and FOIPPA sections will appear unredacted.

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)
Validation Rules? (If yes, list here)
Design
@xxx - please link the Design here
Definition of Ready

[ ] Is there a well articulated User Story?
[ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
[ ] If there is a user interface, is there a design?
[ ] Does the user story need user research/validation?
[ ] Does this User Story needs stakeholder approval?
[ ] Design / Solution accepted by Product Owner
[ ] Is this user story small enough to be completed in a Sprint? Should it be split?
[ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
[ ] Has the story been estimated?

Definition of Done

[ ] Passes developer unit tests
[ ] Passes peer code review
[ ] If there's a user interface, passes UX assurance
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Confirm Test cases built and succeeding
[ ] No regression test failures
[ ] Test coverage acceptable by Product Owner
[ ] Ticket ready to be merged to master or story branch
[ ] Developer to list Config changes/ Update documents and designs
[ ] Can be demoed in Sprint Review
[ ] Tagged as part of a Release
[ ] Feature flagged if required
[ ] Change Management activities done?

Developing the AC

@m-prodan @KyEggleston Feedback please lads! Starting to go down the rabbit hole on this one... Some of the language will need changing/updating depending on designs and how FOI Mod App will trigger OIPC review layers in the redaction app (once we get to that stage). Also, I am wondering if we need the OIPC layer at all? Thinking in more simple terms, not all requests have an OIPC review, and an analyst will be required to download a what was sent to the applicant anyway. Could that record of decision not be saved and the analyst can use the same redline layer? If that was the case then we would really only need the section 14 stories - an option that could be triggered once the file was flagged as "OIC" in Mod.

After giving this a quick review - I think scenarios 1-5 are captured in #4191 - currently in progress. Really all we need for this story is to focus specifically on creating a redline to send to the OIPC, which unlike Ministry sign-off, needs an option (defaulted to yes) where any redlines that have s. 14 will be redacted. Scenarios 6-10 should cover this for the most part

Refinement Questions for 4169 and 4170

Request to Business -> Clarification and revision of tickets 4169 and 4170. Based on current behavior of docreviewer the ACS were a bit confusing (ie. both tickets seem very similar, ACS use old lingo/features etc)
Confirm with business whether the OIPC redline is one document or one document for each division

FE and BE changes needed. Dev team will come up with better estimates and refinement after the above.

Follow up notes:

Business to revise and refine ticket and ACS...
Workflow: OIPC selected as layer (shows all annotations/redactions and s.14) -> A new option under Create Response PDF is added to download this layer (with redactions to s.14) -> Once option selected, Download for OIPC Layer Excluding S.14 is availalbe for users in records tab. See image below for output:

@JHarrietha-AOT Hey! Do these updates match your new flow/language?

testing

No designs - this is validations for what should and should not happen appear for Redline - UI will be the same as precious redline processes

Refinement Comments:
when can IAO download the redline? is there any extra validation needed? -  Not needed. Default validation is enough.
New dropdown value for the stitching - Redline for OIPC Review

This has an open question on when to copy the redactions from redline to OIPC.
Listed are the options

Click on the button component "+ oipc"
When the reopened request has OIPC Review flag added with review type as "Review".
When the reopened request has been moved to state "Records Review".

In correspondence to discussion on 04 Dec with @JHarrietha-AOT

Suggestion : Can we make this option font color little darker. It looks like disabled; whereas it is not.
@JHarrietha-AOT @KyEggleston

System allows changing of page flags for "Redline" after moving to "OIPC redactions". This should not be allowed.

System does not allow selection on sections at the top of modal due to UX issues. I believe this is introduced as part of OIPC.

Suggestion : Can we make this option font color little darker. It looks like disabled; whereas it is not. @JHarrietha-AOT @KyEggleston

I don't see why this couldn't be darker font. Provided all the conditions are met to produce an OIPC redline, it can share the colour/HEX as other active options (e.g., same as the active 'Redline for Sign Off' option in the image below):

Scenario 10 is failing . Able to edit when we switch to 'Redline' layer after OIPC layer is created. @sumathi-thirumani-aot
could you please check?


feat(ui-common): add GroupedDataTable

fix #1513

I think the compatibility.yml workflow is dead code…
Anyway, good job!

I can remove it if not used anymore, please let me know

I think the compatibility.yml workflow is dead code…
Anyway, good job!

I can remove it if not used anymore, please let me know

Bof! Ce n'est pas important.


fix istio versioning

Proposed changes
Update UI for istio to match the version that the catalog will be

Types of changes

Linked Issues

Further comments

LGTM


Nit: tests for pointers in structs

There are tests for structs here. It might be good to see some tests for structs which contain pointer fields.

Hi @Miles-Garnsey, in fact TestCoalesce is not meant to cover all possible cases extensively – if it were, it would become insanely huge.
Instead, I chose to only put a few smoke tests there.
In struct_test.go, you have many tests exercising pointer fields, see here.
I will add a comment to TestCoalesce – in fact I should have done that from the beginning.

Ah, I see, that does make sense.
I think it might be worth thinking about where the tests are placed, since I got a bit confused over them being split between atomic_test.go and pointer_test.go and had to go hunting for some particular cases.
It might be worth thinking about having a layered approach where we move some of the existing unit tests out into integration tests (especially where the tested behaviour relies on a fallback coalescer that sits outside the unit).
I don't know if that's a task for right now though, seems like a low priority.


Sails client never connects if client opens when server is down (and then online).

Node version: 10.9
Sails version (sails):1.2.2
ORM hook version (sails-hook-orm): irrelevant
Sockets hook version (sails-hook-sockets): unknown
Organics hook version (sails-hook-organics): unknown
Grunt hook version (sails-hook-grunt): unused
Uploads hook version (sails-hook-uploads): unknown
DB adapter & version (e.g. sails-mysql@5.55.5): irrelevant
Skipper adapter & version (e.g. skipper-s3@5.55.5): unknown

The title pretty much says it all.
If I open my web app when the server is down, and then turn the server on, sails client will never succeed to connect.
Meaning that io.socket.on('connect'... will never trigger.
Any idea why? Sounds like a bug to fix.

Hey, @glemiere! Are you getting an error in the terminal that you could paste here? It might help me narrow down where things are failing. Thanks!

Hey @madisonhicks thanks for that fast reply!
I do not get any error per se, however:

io.socket.disconnect() produces Cannot disconnect- socket is already disconnected
io.socket.reconnect() produces ERROR Error: Cannot connect- socket is already connecting

So I guess it gets stuck into trying to connect and never fails for or something like that.
My code is within the constructor of a (service) class of an Angular app.
Here it is, maybe it'll help:
    this.isServerDown           = true;
    this.isServerDownChange     = new Subject<boolean>();

    if (this.utils.isBrowser()) {
      this.io                     = sailsIOClient(socketIOClient);
      this.io.sails.url           = this.config.apiUrl;
      this.io.sails.autoConnect   = true;
      this.io.sails.reconnection  = true;
      this.io.sails.initialConnectionHeaders = {
        nosession: true
      };

      this.io.socket.on('disconnect', () => {
        this.isServerDownChange.next(this.isServerDown = true);
      });

      this.io.socket.on('connect', () => {
        this.isServerDownChange.next(this.isServerDown = false);
      });
    }

    this.window.addEventListener('online', () => {
      this.io.socket.reconnect();
    });

    this.window.addEventListener('offline', () => {
      this.io.socket.disconnect();
      this.isServerDownChange.next(this.isServerDown = true);
    });

@glemiere, is it the case that your front end is in a separate Angular application? I haven't been able to reproduce this error on my side, and we don't have a test situation set up that dissociates the front and back end like that. Is it possible for you to create a repository reproducing the error? Thanks!

@madisonhicks doing this right now, sorry for late reply I've been busier than expected

@madisonhicks here you go: https://github.com/glemiere/repro-angular-sails-rt-bug
Let me know if you have any question.

@madisonhicks let me know when you've checked this out

Hey @glemiere! Thanks for the repo and the information. I'll start looking into this as soon as I can, and I should have something for you by the end of my shift tomorrow.

Thank you very much @madisonhicks!

Hey, @glemiere. It seems like perhaps you want to enable io.sails.reconnection onthe Sails side of things? I created a repo of an empty Sails app, and a pull request setting io.sails.reconnection = true here. Is this helpful?

Hi @madisonhicks! (Happy July 4th :D)
Unfortunately it's not helping, if you look at the repo I made for you, I already enabled it doing:
this.io.sails.reconnection  = true; in https://github.com/glemiere/repro-angular-sails-rt-bug/blob/master/src/app/services/api-call.service.ts
As I said, the problem is that if you open your app while the server is down, sails won't make the attempt to reconnect until the server is back online.
The current behavior will only attempt to reconnect to the server if you opened the app while the server was on, and then only the server went down, not if the server was down since the beginning.
So I guess there is something wrong in the sails client, where if the initial connection fails, the attempt to reconnect never happens.

Hi, @glemiere! Ah, okay. Yeah, the documented behavior of reconnect() is to attempt to reconnect if the server has been disconnected, not when the server starts out down. Is this primarily an issue in development, or do you have a case in production where this is giving you trouble?

Hi @madisonhicks!
Still in development/staging for now, soon in production.
Here are the things I believe are wrong with the current sails client:

When it tries to connect for the first time to a down server, it never ends in a case where it definitely failed. It does get stuck in a "connecting" state. Cf second comment above:

io.socket.disconnect() produces Cannot disconnect- socket is already disconnected
io.socket.reconnect() produces ERROR Error: Cannot connect- socket is already connecting

Being stuck in "connecting" doesn't keep trying to connect to the server.

From that, I think we can work something out. I believe the cleanest solution would be to:

create a io.sails.persistantConnecting option (boolean, default to false).

If set to true it would attempt to connect as long as necessary when connecting for the first time, behaving like io.sails.reconnection.
If set to false it would not insist further when it can't connect with a first attempt. It would instead go back to the "disconnected" state.

Sounds good? I'm not familiar with that code, but if you send me the repo where the sails client exists I can try to PR something.

@madisonhicks ?

@glemiere Hey, sorry we’ve been a bit busy over the past few days, thanks a ton for all the information and repo so far. We just discussed this as a team and are curious if this is because you’re running into an edge case where: the socket server sails app is offline but then back online before the user has a chance to load a different page or reload the native app?
Also, if it's ok to discuss, what kind of app are you building and what does the traffic look like?
Thanks, we look forward to your response 👍

Hi @johnabrams7! Thanks for the reply, no big deal we all have a life beside open-source hah! Thanks to you guys for showing interest into this issue.
It's totally okay to discuss in the limit of what's reasonable. I'm building a software meant to be use internally by the company I'm working at right now, so the traffic will be far from crazy, however if it works as expected for us we may open it to other organizations which will increase the traffic. It's a progressive web app and is using two nodes, one for the front (angular) and one for the back (sails).
However it's a tool meant to help us monitor our sprints better, so having it real-time ready is definitely a must. As you can see in the repo I gave you, there is only a single page so it's not coming from a from the user navigating too soon.
I don't think I'm running into any edge case here because I do put the server offline on purpose to simulate a case where the user opens the app when the sails server is down. When back online the sails client does not automatically connect unless I'm refreshing the page.

@madisonhicks ?
@johnabrams7 ?

Hey @glemiere! - just sent you a text - the team is curious to chat with you further on this one.  You can also reach Rachael on her twitter at: https://twitter.com/fancydoilies 👍

@johnabrams7 Okay just got your text! Thanks for reaching out!

@glemiere Have you found a solution to this issue?

HI @JaspervRijbroek! Unfortunately not. There is no option to support this in Sails as of today and I don't think there will be any for a while (or ever). So that sucks... I'm not using Sails at the time, but you can check https://nestjs.com/. NestJS is a backend framework definitely inspired by Angular. It looks pretty cool and supports micro-services (no built in support for SNS/SQS though).


[Sponsor] Select consent type: the select is blocked on Mandatory even if I already have a mandatory consent added

just to be tested. it might be already implemented in other task

all good


Update app.go.tmpl

Should we use more complex naming conventions here? camel case etc like is present in tutorials?

on the update to 0.38 yes we should go through and make things handle more complex naming


Update budgeting-overview.md

Management Reporter renamed to Financial reporting.

:white_check_mark: Organization membership check passed
Requester is not a member of the MicrosoftDocs organization.


Wireless charging issue

I'm trying to charge Wyvern Pickaxe from Draconic Evolution using wireless charging, but that doesn't work. Wireless charging is enabled for everything expect inventory (because it's unavaliable)
Flux Networks version: 4.0.14-31
Draconic Evolution version: <IP_ADDRESS>

ound that it works only using controller


Investigate throwing errors or warnings when components do not get required inputs

Ideally our components would loudly complain if they're supplied with bad inputs.
This currently isn't trivial with our current Nunjucks setup.
Related comment:
https://github.com/alphagov/govuk-frontend/issues/558#issuecomment-369239872
See this skipped test:
https://github.com/alphagov/govuk-frontend/blob/master/src/back-link/template.test.js#L17

tricky, as the easiest options (putting an error on the page, or writing an error to the console) are end-user facing. End users (the public) can't do anything about invalid usage of our macros, so we really should avoid them getting errors if possible.

This has worked really well for GOV.UK Publishing Components by the way.
It's much better to have loud warnings that can be picked up before deploying as part of tests and monitoring than to have silent failures that are picked up by end-users.
Example test: https://github.com/alphagov/govuk_publishing_components/blob/master/spec/components/input_spec.rb#L9

good point. I can't see what the code in that link is doing? Does it write a big red message to the page or something?

@joelanman that test is making sure when a component doesn't get the right input it fails.

In development this would be a big loud error
In pre-deployment scenarios (for example, GOV.UK has traffic replay from live to 'staging') it'd turn up in your logs

In Ruby land you can raise an exception, but Nunjucks has no such equivalent so (as far as I know).

At least in the Ruby ERB templates, they will raise an exception if something is not passed through by default. We have an empty object passed through to our templates that may mask a default behaviour if Nunjucks has it, would be worth investigating that.

Closing this as this isn't something Nunjucks supports which makes this very difficult to do. It could be a good thing to look into in the next firebreak.


[rancher-dns] Alias name for services in dns update

Hi,
Is there any way to configure the rancher external dns updater (rfc2136dns) to use an alias for a service, for example with a lable like io.rancher.service.external_dns.alias. so we have general dns records based on default template name and specific one for services with given label?
it is available in traefik loadbalancer and it use user defined alias or fqdn ( if exists ) for routing. but it is missing in dns updating.
thanks
Rancher versions:
rancher/server: 1.6.5
rancher/agent: 1.2.5
rancher/external-dns: v0.6.2

I dont know golang, but search in the source code and find io.rancher.service.external_dns_name_template in it. I set it on a service and voila its update the dns with desired alias.
so I will update the community catalog to document it!

i close this issue in favor of https://github.com/rancher/community-catalog/pull/589/


Remove dependency 'jshint' from run dependencies

npm WARN package.json Dependency 'jshint' exists in both dependencies and devDependencies, using<EMAIL_ADDRESS>from dependencies

whoops, thanks!

;)


Can't show disqus

Hi,
I tried to enable comments on my site, followed the instructions and updated my _config.yml:
provider: disqus
disqus:
  shortname: my_disqus_site_name

However, comment area still won't show up on my site. Is there anything else I need to change?

Sorry, it showed up after a while.


Toothpick 2 to 3 migration issue: No factory could be found for class android.app.Activity

Hi,
First of all thank you for this great library. We've been using it since the first release (after migrating from Roboguice).
We wanted to migrate from Toothpick 2 to 3 and we encountered the "No factory could be found for class android.app.Activity" error. We are using the SmoothieAndroidXActivityModule class. The usage is simple. In our "base" activity (onCreate) we are calling:
Scope scope = Toothpick.openScopes(application, this);
scope.installModules(new SmoothieAndroidXActivityModule(this));
Toothpick.inject(activity, scope);

One of the activity's collaborators has a dependency to android.app.Activity.
toothpick.locators.NoFactoryFoundException: No factory could be found for class android.app.Activity. Check that the class has either a @Inject annotated constructor or contains @Inject annotated members.
        at toothpick.locators.FactoryLocator.getFactory(FactoryLocator.java:37)
        at toothpick.ScopeImpl.lookupProvider(ScopeImpl.java:359)
        at toothpick.ScopeImpl.getInstance(ScopeImpl.java:93)
        at toothpick.ScopeImpl.getInstance(ScopeImpl.java:84)
        at ActivityCollaborator__Factory.createInstance(ActivityCollaborator__Factory.java:12)
        at ActivityCollaborator__Factory.createInstance(ActivityCollaborator__Factory.java:8)
        at toothpick.InternalProvider.get(InternalProvider.java:174)
        at toothpick.InternalScopedProvider.get(InternalScopedProvider.java:80)
        at toothpick.ScopeImpl.getInstance(ScopeImpl.java:93)
        at toothpick.ScopeImpl.getInstance(ScopeImpl.java:84)
...

I don't understand why the binding from SmoothieAndroidXActivityModule (bind(Activity.class).toInstance(activity)) does not work.
I could not find any indication in the current issues, so please provide some hints in which direction I should look into.
Thank you.
Alex

It should definitely work. Are you sure you use the activity scope you created to inject your collaborator ? How is it injected from within the activity?

After some debugging I've noticed that the Activity instance lookup reaches the parent scope (app scope) instead of the activity scope (if I invoke scope.getInstance(Activity.class), in the above code, it returns the proper instance of the activity). This seems to happen because the ActivityCollaborator's provider is bound at the app level module which is installed in the app scope. We did some modularization and some classes have remained at the app level. However, is this the intended behavior of TP3?


face changed

The generated result differs greatly from the input image's facial features. How should we handle the facial features?

Hi, could you share the reference image and the driven video?

https://github.com/user-attachments/assets/b6d88170-e60e-45ad-9700-fd18951f1bca

I used this video and this picture to create a pose image for Mr., and then added pose images to this image to generate a video

Hi, could you share the reference image and the driven video?

It's OK to see the skeleton image generated through DWPose alone. Finally, call reference_basic, and the generated face is very different from the original image.


Remove double HomeCtrl, clean HomeCtrl to vm

HomeCtrl was inserted twice, making extra API calls.
This PR also replace the last $scope values to vm.

Ready to Merge


Automated cherry pick of #2952: fix: Table 'yunionlogger.users_cache_tbl' doesn't exist

Cherry pick of #2952 on release/2.10.0.
#2952: fix: Table 'yunionlogger.users_cache_tbl' doesn't exist

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.10.0@c2da048). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/2.10.0   #2953   +/-   ##
================================================
  Coverage                  ?   7.47%
================================================
  Files                     ?     414
  Lines                     ?   66008
  Branches                  ?       0
================================================
  Hits                      ?    4931
  Misses                    ?   60654
  Partials                  ?     423

Flag
Coverage Δ

#aFlag
7.47% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2da048...c63ef27. Read the comment docs.

/approve
/lgtm


Feature/calico role

This is the new PR to add Calico role to M-I. I have synced with the latest master and tested deployments on OpenStack, GCE and DigitalOcean.

this is working well for me on gce

seems solid to me. tested without problems on gce, aws, do, and openstack platforms.

This PR breaks Marathon support.
Marathon doesn't work with Mesos 0.23 yet, it only works with Mesos 0.22.1.

@eirslett thanks for reporting this issue.

Any details about what is not working? I did not run into any marathon issues with mesos 0.23.0. mesos-consul and marathon-consul run ok in marathon and I was also able to run some sample jobs (with and without enabling Calico networking). We might need to add more testing coverage if something is broken. @loshkovskyi did you see any problems with marathon on mesos 0.23.0?
oh and btw, did you enable the calico and etcd roles in terraform.yml (see terraform.sample.yml)? If not, you likely would see problems. I did just notice that our vagrant.yml is missing those roles so I created #661 for that

In fact, we've been deploying Mesos 0.23.0 for months and I didn't encounter any issues with it. Remember, we used to set latest when installing Mesos from Mesosphere repositories which implies installation of Mesos 0.23.0. This PR https://github.com/CiscoCloud/microservices-infrastructure/pull/618 is more about to start using versioning, not about any problems in Mesos. In addition, Calico can happily work with both Mesos 0.22.1 and 0.23.0 (with some configuration changes). I didn't include Calico in vagrant.yml on purpose, as for me it's a bit of overkill to use BGP in a single VM. Though, I'm always open to discussions.

Right.
RE: vagrant. I went ahead and added those roles b/c the vagrant build is
definitely broken without them right now. Any idea what needs to change so
that those roles are truly optional?
Ryan Eschinger | http://ryaneschinger.com
Phone:<PHONE_NUMBER>
Skype: ryanesch
On Sat, Aug 22, 2015 at 4:34 PM, Andrii Loshkovskyi <
<EMAIL_ADDRESS>wrote:

In fact, we've been deploying Mesos 0.23.0 for months and I didn't
encounter any issues with it. Remember, we used to set latest when
installing Mesos from Mesosphere repositories which implies installation of
Mesos 0.23.0. This PR #618
https://github.com/CiscoCloud/microservices-infrastructure/pull/618 is
more about to start using versioning, not about any problems in Mesos. In
addition, Calico can happily work with both Mesos 0.22.1 and 0.23.0 (with
some configuration changes). I didn't include Calico in vagrant.yml on
purpose, as for me it's a bit of overkill to use BGP in a single VM.
Though, I'm always open to discussions.
—
Reply to this email directly or view it on GitHub
https://github.com/CiscoCloud/microservices-infrastructure/pull/658#issuecomment-133752245
.

Looks like we shouldn't drop the /etc/mesos-slave/executor_environment_variables file when calico is not included. I suspect that might be the issue

I disabled the calico stuff (hadn't tried it out yet) maybe that's the problem? I blamed it on Mesos 0.23 since there are some issues out there about Marathon not working with the latest Mesos version.
The strange thing is that both mesos-consul and marathon-consul ran fine on the cluster, but everything failed when I tried to deploy other Docker apps. And I was not able to restart or scale mesos-consul or marathon-consul (just testing to see what would happen), I suspect something with the executor failed. Marathon started the tasks, but they immediately failed; mesos showed no output in the stdout or stderr logs.
Just for testing, I started a new Marathon task with a uris: ["http://www.example.com/index.html"] setting to see what would happen. The mesos logs showed that Maration did indeed start the task (the file was downloaded) but then failed to run the docker container.
On problem I encountered with /etc/mesos-slave/executor_environment_variables is that Mesos 0.22.1 didn't recognize the option, and failed to start.
I'll try starting up everything again, with default settings and the Calico role enabled!

I tried with Calico now + faking SoftLayer so it doesn't use private IPs. Now I'm at least able to deploy Docker containers. Looks like the problem is limited to docker container from private registries, that's maybe why you couldn't reproduce it! My failure was with private containers. Sorry! I'll look into why my previous PR for private docker hub support doesn't work from inside Mesos; looks like it's an issue with $HOME being set.


dashboard: Updating env always uses latest release

#1389

LGTM

Updated to copy SLUG_URL env from latest release.

Neat, LGTM!