Raw Binding String parameter always empty

Hi,
Maybe I'm doing something wrong but I'm unable to get a raw query properly work with parameter binding.
.table('Product')
.whereRaw("ProductName LIKE(:ProductName_1)", {ProductName_1 : '%foo%'})
.select('ID', 'ProductName')
.then(function (rows) {
    // rows is always an empty array
});

In the debug console :
{ method: 'select',
  options: {},
  bindings: [],
  sql: 'select "ID", "ProductName" from "Product" where ProductName LIKE (:Prod
uctName_1)' }

As you can see, the bindings is EMPTY. Why ?
I've also tried with :
.where( knex.raw("ProductName LIKE(:ProductName_1)", {ProductName_1 : '%foo%'}) )

But same problem.
If I use SQL equal operator it seem to work, but as soon as I use one of the following operators "LIKE, IN, NOT IN", knex discard my binding.
My configuration :
knex 0.10.0
sqlite.
Node .0.12.0

On the other hand if I use the "question mark" parameter binding instead of "named" binding it works properly. So could it be a bug ?

@purell Hi, perhaps this is related to #1251 which is currently merged but not yet published?
The sum of the issue is that (:ProductName_1) would not work while ( :ProductName_1) would work. The pull request fixes this by changing the regular expression so that a space is not required.
Testing this locally I'm almost certain that's the issue. Can you verify?

Yes, it seem to work. I already tried what was propose in the #1251 but I did put the space in the wrong place.
I was trying :
.whereRaw("ProductName LIKE (:ProductName_1)", {ProductName_1 : '%foo%'})

Instead of :
.whereRaw("ProductName LIKE( :ProductName_1)", {ProductName_1 : '%foo%'})

Do you know WHEN the fix will be published (npm) ? I really need this to be working now :(
By the way, thank you for your help. It is greatly appreciated.

We have a few pull requests to get through before publishing, but it will hopefully be soon.


Error running command cblite.explorer.getDocument

Using this sample app, I wrote data to the CBLite database on my iPhone simulator running on my Mac:
https://developer.couchbase.com/tutorial-quickstart-xamarin-forms-basic
I'm able to install the CBLite extension into my VSCode, open a cblite2 database, and the data appears in the left pane in VSCode (but only after re-opening the folder and database).  However, when I right-click the DB file and select GetDocument, I get the following error:

@tele-bird is this issue resolved, I am facing this same issue

I tried again in this other sample app, and it still happens with the "user-profile" database.
https://developer.couchbase.com/tutorial-quickstart-xamarin-forms-query
However, I notice that the issue does not happen for documents in the "universities" database in this sample app.  Probably there is something materially different in the "user-profile" database that is causing the issue.  There may be a problem in those example apps, but I think that the cblite extension could handle the problem more gracefully.

This is actually the result of upgrading the database to 3.2.0 format.  There was a breaking change in the binary format that makes it unreadable on 3.1.x.  This should get resolved with an update to use the 3.2.0 SDK via the plugin.

@borrrden  I am currently using version 3.2.0 of the Couchbase.Lite library but I'm still seeing this issue.  I delete the data file, and it gets created using version 3.2.0, so there should be no legacy issues, correct?
here's my VS Code version
Version: 1.95.1 (Universal)
Commit: 65edc4939843c90c34d61f4ce11704f09d3e5cb6
Date: 2024-10-31T05:14:54.222Z
Electron: 32.2.1
ElectronBuildId: 10427718
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Darwin arm64 24.1.0
And my version of the plugin is v0.2.0

That's exactly WHY you see the issue.  The latest version of the plugin does NOT use 3.2.0.  I guess I could have been clearer about that (the plugin is still on an older version and there was a break that causes newer versions to be unable to be read).  I think this was actually fixed in 3.2.1 which is on its way out the door so if you use that let me know what happens in lieu of this plugin getting updated.

@borrrden  Thanks for clarifying.  I'll upgrade our SDK to 3.2.1 as soon as it is released and re-test the VS Code plugin.


Setup Peribolos for baloise main orga

what is Peribolos?

https://github.com/kubernetes/test-infra/tree/master/prow/cmd/peribolos

Peribolos allows the org settings, teams and memberships to be declared in a yaml file. GitHub is then updated to match the declared configuration.

see also evaluation in #169

https://github.com/baloise/org


cargo: problem with CA certificates

using 15.06pre65267.6ad8fab (Dingo) and cargo 0.3.0 (a2dd2ac 2015-06-24) (built 2015-07-17) leads to this error:
cargo test --verbose
 Downloading libc v0.1.8
Unable to get packages from source

Caused by:
  Failed to download package `libc v0.1.8` from https://crates.io/api/v1/crates/libc/0.1.8/download

Caused by:
  Peer certificate cannot be authenticated with given CA certificates

What can I do?

Find how it searches for certificates. Curl with our CA accepts the URL.

I see. It seems to be related to https://github.com/rust-lang/cargo/issues/976.
@sjmackenzie & @telotortium  are you able to run cargo v0.3.0 with rustc v1.1.0?

using cargo 0.3.0-nightly (14e8ed9 2015-06-15) (built 2015-06-16) works fine.
But I still have no idea if this problem is nixos or cargo related :-\

A "simple" fix would be to rebuild cargo against openssl 1.0.2b or superior.

This might be another work around. We do have that version in nixpkgs, only it isn't the default one yet.

We do have that version in nixpkgs, only it isn't the default one yet.

so we cold write this:
  cargo = callPackage ../development/tools/build-managers/cargo {
    rustPlatform = rustCargoPlatform;
    openssl = openssl_1_0_2;
  };

Or what would be the problem with that?

None that I know of.

A preliminary run of git bisect between git bisect start 6eab106 71c1644 (6eab106 was the master as of yesterday, 71c1644 is the merge commit for #8668) found 333f145 to possibly be the first bad commit (I ran git bisect run sh -c "nix-env -f $PWD -qa 'cargo-0.3.0' >/dev/null 2>&1 || exit 125; nix-build $PWD -A cargo" to attempt building cargo at each commit while skipping commits for which cargo hadn't been updated to 0.3.0, which was merged from #8668).

I haven't experienced this for quite a while, can be closed.

Reopen if you experience again.


show email attachments

Overview

[x] show email attachments

Notes

This would be great for my team as well!

@denis90 btw how did you get the tests running? I am having issues locally with jest - SyntaxError: Cannot use import statement outside a module

@denis90 btw how did you get the tests running? I am having issues locally with jest - SyntaxError: Cannot use import statement outside a module

you need to enable experimental-vm-modules:
NODE_OPTIONS="$NODE_OPTIONS --experimental-vm-modules" npm test


Try to help people that forget to quote their upload globs

I did this in a script, to upload some JUnit xml files:
buildkite-agent artifact upload *.xml

and it failed with this error message:

This had me very confused for a few hours, until I realised that there was a second argument to upload called "upload destination" — I had assumed that the error message on upload destination was that I had misconfigured my agent, or it was a backend problem.
What I needed to do was:
buildkite-agent artifact upload "*.xml"

This PR tries to provide a less confusing error message if people accidentally provide a second argument to the artifact upload command.

Yay, thanks @lox! 🙌🏼


twister: adapt toolchain test

We now get toolchain from cmake and can operate even if the toolchain
variant is not set in the envrionment, this test was verifying the old
behavior, so remove.
Signed-off-by: Anas Nashif<EMAIL_ADDRESS>

It seems that the test are failing due to twisterlib.py itself, get_toolchain() method.

It seems that the test are failing due to twisterlib.py itself, get_toolchain() method.

no, this is the CI environment and the cmake script, this now will be mocked.


Support isize and NonZeroIsize

We support all primitive types except isize. Probably doesnt' matter, but feels odd.

@nearmax @evgenykuzyakov was it intentional that we omit isize while still supporting usize?

Closed by https://github.com/near/borsh-rs/pull/99


Link from Trac tickets to new GitHub issues

After the migration run a script to update the ticket on trac and and link to GitHub issue.
And close the tickets?...I don't know about the last part

I think that we leave it as low priority and decide if we really need it... it was just brainstorming :)

For Twisted, we are implementing this via a redirect.


[WFCORE-5464] Upgrade JBoss DMR and test expressions resolved fro…

…m env vars
Opening as a draft PR just to get it out there
This needs a release of DMR including https://github.com/jbossas/jboss-dmr/pull/38. Once that happens I will update the current SNAPSHOT dependency.
https://issues.redhat.com/browse/WFCORE-5464

Core - Full Integration Build 10650 outcome was FAILURE using a merge of c0d66d9a2f1b2af218729d6bfc2e6c57e7ef1278
Summary: Exit code 1 (Step: Build & test core (Maven)) (new) Build time: 00:01:53

Core - Full Integration Build 10727 outcome was FAILURE using a merge of c0d66d9a2f1b2af218729d6bfc2e6c57e7ef1278
Summary: Exit code 1 (Step: Build & test core (Maven)) (new) Build time: 00:00:51

Code looks good to me.
The commit message mentions JBoss Modules instead of JBoss DMR.

Oops - fixed

Core - Full Integration Build 10728 outcome was FAILURE using a merge of 529932b214647f1e9b57f24f9691eb31536a091c
Summary: Exit code 1 (Step: Build & test core (Maven)) Build time: 00:01:16

Core - Full Integration Build 10653 outcome was FAILURE using a merge of 529932b214647f1e9b57f24f9691eb31536a091c
Summary: Exit code 1 (Step: Build & test core (Maven)) Build time: 00:00:35

Core - Full Integration Build 10802 outcome was FAILURE using a merge of fd023db0875d58ba22e4dfb2b349f0d34aa5fa9d
Summary: Exit code 1 (Step: Build & test core (Maven)) Build time: 00:01:28

Core - Full Integration Build 10898 outcome was FAILURE using a merge of fd023db0875d58ba22e4dfb2b349f0d34aa5fa9d
Summary: Exit code 1 (Step: Build & test core (Maven)) Build time: 00:01:28

Core - Full Integration Build 10899 outcome was FAILURE using a merge of 0e8398dab0f9ef65bd649c5d2ca99acdb3b2d4f7
Summary: Exit code 1 (Step: Build & test core (Maven)) Build time: 00:00:46

Core - Full Integration Build 10803 outcome was FAILURE using a merge of 0e8398dab0f9ef65bd649c5d2ca99acdb3b2d4f7
Summary: Exit code 1 (Step: Build & test core (Maven)) Build time: 00:01:26

Core - Full Integration Build 10900 outcome was FAILURE using a merge of 0e8398dab0f9ef65bd649c5d2ca99acdb3b2d4f7
Summary: Exit code 1 (Step: Build & test core (Maven)) Build time: 00:01:31


Add SmeLU activation

For a while, I've been looking for an activation to replace ReLU.
I want a smoothed version that can be computed fast and in-place. SiLU, Mish, GELU don't fit the bill in some of those points.
Today, I found about SmeLU (paper) (it has a really weird name). And I've implemented it as an in-place operation, so it will use the same amount of memory as a ReLU layer when training and inferring.
I've also updated some tests to actually check for negative values, i.e., replacing rnd.fill_uniform with rnd.fill_gaussian.

Nice, thanks for another great PR :)

Oh, I've noticed you're not squashing the PRs anymore. Any reason? Just curious :)


Add libretro netplay support

adds a new commandline switch : -host/-client
expects 4 new recalbox.conf vars :

netplay.nick
netplay.frames
netplay.server.ip
netplay.server.port

Needs a nice ES UI now

nice.
It would be nice to add a switch for client spectator mode, no ?

You have to know how a rom is launched : host or client (or spectator)
That is something that is not constant, wheras the nick, the frames or the server ip have less chances to change.
The frames depends on the ping between machines
The port, most of times, should be constant
The server ip will change, but that only mayters for client(and spectator)
The idea behin is to add a dew options ins ES:

start a rom as server or client (or spectator)
make the server ip, frames and nick configirable inside ES

I don't mind changing anything, just make proposals.

I have some other bigger ideas for spectator mode, but that is in a distant future ^^

Its working?


Add ECI handling to Data Matrix

Adds ECI handling to Data Matrix decoder. Non-character set ECIs (i.e. those > 899) are just ignored.
Note uses State struct with only one member but future PRs for DMRE and structured append will add further fields.

Awesome.
Question: is there some code you used as inspiration for the ParseECIValue function or do you have a copy of the specification at hand? The two sample images are your creation?
Note: I also have some initial DMRE support based on the recent changes in the Java code base lying around.

Hi thanks! I have the spec and the code is based on that. The 2 samples were created by Zint (modified unreleased version).
Re DMRE I looked at the recent Java base code changes but unfortunately it's based on an old spec, the stuff I've done is based on ISO/IEC 21471:2020. (I have vague intentions to upstream any changes to Java ZXing at some stage but my Java's weak so may be a while...)

Ahh, someone with coding skills and the spec. Nice :-).
DMRE: I'll look into pushing my changes (which are based on upstream/outdated spec) and you could then maybe extend the few missing lines based on the ISO documents? See also this discussion: https://github.com/zxing/zxing/issues/1346

Ha a dangerous combination maybe.
Re DMRE ah I missed that discussion. Please go ahead as you say and I'll base the PR on that.

(P.S. If you'd rather not bother doing your changes let us know and I'll do the PR directly.)

I checked and the only thing I have is the (outdated) extension of the table in the DMVersion.cpp. That alone will not cut it, though. There are going to be changes required in the DMDetector.cpp. Either I lost them or I only imagined them... Please go ahead with your PR and we'll continue the discussion there.


misc: group key testing

Spun out of #549 . Adds a few test cases related to group key handling following the group key derivation algorithm changes and storage changes that were included in 0.3.0. We also remove some clearly-redunant error checking in proof validation.
Coverage for asset increases by 3.6% to 70.8%, for tapdb an increase of 0.2% to 66.1%, and for proof an increase of 0.4% to 56.1%.

Looks like I caused an issue in unrelated tapdb tests:
--- FAIL: TestAssetExportLog (0.71s)
    test_sqlite.go:11: Creating new SQLite DB for testing
    assets_store_test.go:1455:
        	Error Trace:	/home/runner/work/taproot-assets/taproot-assets/tapdb/assets_store_test.go:1455
        	Error:      	Not equal:
        	            	expected: 0x1
        	            	actual  : 0x0
        	Test:       	TestAssetExportLog
FAIL
FAIL	github.com/lightninglabs/taproot-assets/tapdb	9.782s
FAIL

Fixed unit flake, asset version wasn't being passed properly.
Not sure why go.mod has a change.


Increase JSON depth on save/restore to maximums

Describe the Bug
A mildly complex state exceeds the hard-coded depth of 10 in the convert-to/from JSON calls in the save/restore state cmdlets. This makes it impossible to save/restore such state. Please increase the depth for these commands to the maximums (1024/100 for from/to in PS core).
Steps To Reproduce
Create a state variable with a depth > 10 and then save/restore of state fails.
Expected Behavior
Maximum depth for JSON should be supported or perhaps settable via the save/restore cmdlets.

Resolved in #1094


external integration tests with a Demo Server for Subscriptions

https://sourceforge.net/projects/yetanotherbacnetexplorer/

Ive also found this to be pretty good for compliance testing
https://www.bac-test.com/bacnet-test-client-download/


Tilemaps made in 3.x are lost when opening in 4.x

Godot version
3.5-rc8, 4.0.dev
System information
ArchLinux
Issue description
Tileset data as well as tilemap itself loses all tile configurations and renders a blank tilemap when using Godot 4.x to open project with tilemap made in 3.x.
Steps to reproduce

Create project with tilemap in Godot 3.5-rc8
Open project in Godot 4.0.dev
Observe blank tilemap. Textures are still in the list, but no configured tiles are visible.

3.x:

4.x:

(nothing in "Patterns" and "Terrains" as well)
Minimal reproduction project
test.zip

Is there any tilemap converter in place yet? cc @qarmin

@qarmin Is this something I could help with? Tilemap migrations are probably the only thing that prevents us from fully witnessing all the beauty of 4.0.

I checked tilemaps in both 3.x and 4.0 version, but looks for me that converter cannot really handle such differences between this two versions.
I think that better and easier would be to add compatibility mode when loading tilemaps.

@qarmin Would that be doable? I think there are really many games that use 3.x TileMap (including our ongoing projects) and it would be a real blocker to migrate to 4.x. Another solution would be to port entire 3.x's TileMap as some sort of LegacyTileMap to preserve full backward compatibility since TileMaps in 4.x seem very incompatible with 3.x.

The conversion should be more or less automatic already, I implemented a few things to make sure at least atlases gets converted correctly.
Though to make it clear, don't expect full retro-compatibility from 3 to 4. There will be a lot of situations where automatic conversion is not possible.

@groud Sounds awesome! Are autotiles converted as well?

I checked the MRP, and it seems like the only tile present is an autotile one. Sadly, autotiles cannot be converted automatically from 3.x to 4.x, and thus require manual work. Could you confirm the tiles in your original project were using autotiles too ?
Otherwise, I think we can close this issue with #72173.


Allow project keys to be ALPHA numerical

TL;DR
Project keys can be alphanumerical, and I have some that aren't being picked up due to this regex!
So lets relax the project key regex to include ALPHA numerical project keys - i.e

FOO-123
F12-123

https://confluence.atlassian.com/adminjiraserver073/changing-the-project-key-format-861253229.html

Hey @gerald-skydio,
thanks for raising this. We'll have a look at this shortly.

For sure @thombergs. Any updates on your end? Just making sure this doesn't fall through the cracks.

Hey @gerald-skydio. We're happy to get this merged in for you but need a couple additions from you first:

in addition to the file you've modified, you'll need to also update the regex in the jira client . If this isn't updated issues in jira util will return null and your change will never take affect.
please add a test for alphanumeric keys to ensure your changes are working.


fix(pdk/request): support overriding the limit for get_query()

Summary
Currently, get_query() method in pdk.request can't support to override the limitation for getting all query parameter. This pr is to support it by allowing max_args=0 to be passed to ngx.req.get_uri_args for some special cases.
Checklist

[x] The Pull Request has tests
[x] There's an entry in the CHANGELOG
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

[Implement ...]

Issue reference
FTI-2525

Do you have a use case for this feature request?

@StarlightIbuki As per to FTI-2525, I believe some users want it, and I understand even there is, it's not really common. It's cool for me not to merge if this may introduce potential risks. But from my perspective, at least it seems we restrict the original ability from openresty or whatever. The callers who intend to use it with max_args=0 should have some knowledge about what they are doing.

To avoid potential risk and there's no feature request for now, won't do at this momnet.


Declare core.iterators package public API

This is something that is long overdue but has been put off for good reasons.  Some refactoring was done in 2.0 for classes in this package to not use internal types.  SortedKeyValueIterator should be declared public API and I think this package is close to this goal where it could be done for 2.1

Classes under core.iterators with impl imports:
LongCombiner.java:import org.apache.accumulo.core.clientImpl.lexicoder.AbstractLexicoder;
system/MapFileIterator.java:import org.apache.accumulo.core.sample.impl.SamplerConfigurationImpl;
system/SequenceFileIterator.java:import org.apache.accumulo.core.sample.impl.SamplerConfigurationImpl;
system/MultiIterator.java:import org.apache.accumulo.core.dataImpl.KeyExtent;
user/TimestampFilter.java:import java.text.SimpleDateFormat;
user/BigDecimalCombiner.java:import org.apache.accumulo.core.clientImpl.lexicoder.AbstractLexicoder;
user/SummingArrayCombiner.java:import org.apache.accumulo.core.clientImpl.lexicoder.AbstractLexicoder;

It's okay to have impl imports. It's just not okay for them to expose those types in their public/protected members. apilyzer-maven-plugin should catch violations of this.

We should probably move system iterators out of the way, because those should not be public API, but otherwise, I think this is fine.

Based on some discussion in #1415, iterators should be treated as SPI instead.

This is dependent on #1426

I made a few changes to #1426 and moved it from draft to ready for review.

I think the work that needed to be done in the code for this is done.  So closing.  There is a separate ticket for documentation that is still open #1416


env() returning null variables after "php artisan config:cache" -> NOT CACHING

Laravel Version: 6.18.1
PHP Version: 7.3.10
Database Driver & Version: MySQL 14.14 distrib. 5.7.30

Description:
I would create this issue on repo https://github.com/laravel/laravel but I cannot create issues there, don't know why.
The problem is: after execute php artisan config:cache when I enter my app via Tinker, the env() variables are returning null!
I understand  php artisan config:cache is to CACHE the configuration, and not the other way around!
Steps To Reproduce:
as an example:
$ php artisan config:cache
$ php artisan tinker
>>> env('DB_DATABASE')
=> null

It's expected. Once you call the config:cache command, you can no longer use the env() helper.
Check here https://laravel.com/docs/7.x/configuration#configuration-caching

@brunogaspar thanks for explaining.

So is just "right" typing a command to cache that does not caches at all?
I discovered this problem in production when my Schedule routines were running connecting another server via API.
The documentation says clearly:

You should typically run the php artisan config:cache command as part of your production deployment routine

My routines running in production and yet happens.

@brunogaspar even in production, in my controllers or models, if I call env() after running config:cache it would not work?

@terremoth as said before: don't use the env helper outside your config files.

@driesvints @brunogaspar
So, if env() does not work, nor Config::get() in these cases (I've tested here now in controller), what would be the solution to get env variables in my controllers/routes etc after run config:cache?
Or so, should I never use config:cache if I need env()?

Sorry to ask you guys all this doubts. This "problem" seems to be (or was) a lot of people problem, take a look:
https://www.google.com/search?q=env+variables+after+config%3Acache+returning+null+laravel

Going to try to explain, but the majority of it is on the documentation, specially on how to access config values: https://laravel.com/docs/7.x/configuration#accessing-configuration-values
In your example above, you seem to want to access the database table name, so that's a tad more "tricky" since the path of the configuration value can vary due to the different drivers being used, but here's an example:
Config::get('database.connections.mysql.database')

You can make this somewhat dynamic based on the selected driver if you so desire.
But either way, that's how you should use it.

Here's an example:
On your ".env" file
FOO=bar

Create a "config/somefile.php" file
<?php

return [
    'foo' => env('FOO'),
];

Access the values elsewhere on your application
dump(Config::get('somefile.foo')); // should return "bar"

This "problem" seems to be (or was) a lot of people problem, take a look:
https://www.google.com/search?q=env+variables+after+config%3Acache+returning+null+laravel

The majority of those posts are either lack of reading the documentation or misunderstanding how the Laravel configuration works.

Hope it helps and that i haven't mentioned anything wrong or at least not super wrong lol

I understood, thank you for explain.


chore(diff): add esm import diff case

Summary

Test Plan

Require Documentation?

[ ] No
[ ] Yes, the corresponding rspack-website PR is __

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #5290

PR #5300

PR #5302   👈

This stack of pull requests is managed by Graphite.


Fix DoF's dependency on resolution

fixes #56911
This has no impact on how the glow effect scales with the resolution, but I couldn't be bothered to do a different recording.
https://user-images.githubusercontent.com/9743949/151022884-b3a9d490-066e-44aa-a377-ca5f74a59236.mp4

This looks fine to me, but I am worried about the performance impact, especially when using the circular bokeh mode.
Can you test circular bokeh on both low res, HD, and 4K?
Or maybe @Calinou is able to test on HD and 4K?

I tested with Circular Bokeh and High Quality.
With this patch:

Scaling
FPS

0.5 scaling (960x540)
480

1.0 scaling (1920x1080)
195

2.0 scaling (3840x2160):
18

Without this patch:

Scaling
FPS

0.5 scaling (960x540)
395

1.0 scaling (1920x1080)
195

2.0 scaling (3840x2160):
55

Picking a higher reference resolution would most likely improve the situation for 4k as well.

Picking a higher reference resolution would most likely improve the situation for 4k as well, but I'm not sure that's the solution or if one is required. Any suggestions?

Picking a higher reference resolution is the same as decreasing the fixed 64.0 multiplier or reducing the default bokeh size (which was likely chosen for artistic reasons rather than performance reasons).
I see two solutions and I am torn between the two:

Go with this PR and have a warning in the documentation that performance will scale with resolution, so at high resolutions, you may want to reduce bokeh size proportionately.
Don't merge this PR and have a warning saying that Bokeh size is fixed at 64 pixels * user_specified_size and users should scale this with resolution if they want consistent results.

Number 1 is nice, because we want the default to be "just works". That being said the performance cost is pretty hard to swallow. The end result would be "it just works*" (* but runs too slow to use).
Number 2 is better for performance and for users who don't care about blur amount as much.
Can you do another table like the above, but for Box blur and hexagon blur? They both should scale much better with resolution. If the difference isn't as bad with them, then I lean towards 1.

Can you do another table like the above, but for Box blur and hexagon blur? They both should scale much better with resolution. If the difference isn't as bad with them, then I lean towards 1.

I feel we should change the circle bokeh shape to not have performance that depends on resolution, even if this means it'll look worse at higher resolutions. The caveat is just too bothersome for developers to handle, especially if they want to expose circle bokeh as an opt-in setting for those with fast GPUs.

I wrote a little Python function to understand how many iterations are being made for the circular bokeh inside this for loop:
def a(blur_scale, blur_size):
  radius = blur_scale
  c = 0
  while radius < blur_size:
    radius += blur_scale / radius
    # print(radius)
    c += 1
  return c

blur_scale = one of [8.0, 4.0, 1.0, 0.5] - it represents the blur quality setting, from very low quality to high quality
blur_size = dof_blur_amount (from the camera) * 64.0 (hardcoded multiplier) * resolution_factor (from this PR)

And here's some results:

blur_scale
blur_size
iterations

8 (VLQ)
0.2 * 64 * 1.0
6

4 (LQ)
0.2 * 64 * 1.0
18

1 (MQ)
0.2 * 64 * 1.0
80

0.5 (HQ)
0.2 * 64 * 1.0
162

-
-
-

8 (VLQ)
0.2 * 64 * 2.0
37

4 (LQ)
0.2 * 64 * 2.0
79

1 (MQ)
0.2 * 64 * 2.0
326

0.5 (HQ)
0.2 * 64 * 2.0
653

-
-
-

0.5 (HQ)
0.1 * 64 * 1.0
39

0.5 (HQ)
0.2 * 64 * 1.0
162

0.5 (HQ)
0.3 * 64 * 1.0
367

0.5 (HQ)
0.4 * 64 * 1.0
653

0.5 (HQ)
0.5 * 64 * 1.0
1022

The increase in iterations looks pretty steep when cycling between DoF amount and qualities.
As far as I can tell these numbers (also) don't depend on the resolution, and maybe they should?

The increase in iterations looks pretty steep when cycling between DoF amount and qualities.
As far as I can tell these numbers (also) don't depend on the viewport's resolution, and maybe they should?

Your resolution multiplier would make this dependent on resolution. You can see the default setting is to blur over 64 pixels * dof_amount.
If we wanted to keep the cost the same as screen size changed we could scale both the blur_scale and blur_size This would keep the size and performance constant, but quality would suffer with a change in resolution.

Your resolution multiplier would make this dependent on resolution. You can see the default setting is to blur over 64 pixels * dof_amount.

Yes, I was thinking about blur_scale, but wasn't obvious from what I wrote.

If we wanted to keep the cost the same as screen size changed we could scale both the blur_scale and blur_size This would keep the size and performance constant, but quality would suffer with a change in resolution.

I'll try to find a sweet spot where quality doesn't visibly change much.

As promised, I've been working on improving the performance of the circle blur. Here's some screenshots to compare performance and looks:

master
optimised

I've still got a few things to sort out, like improving the quality and performance of the near blur, maybe see if I can make the whole thing resemble the unoptimised effect better... and tidy up the code, although it's mostly just some changes inside the shader code.
I'm thinking of introducing these tweaks as a new DoF mode and call it "Circle Optimised" (?). So whoever wants to use the high quality, uncompromising classic "Circle" mode can still do so, but I think that one is more suitable for offline rendering as it stands.

Even if the optimized blur performs well regardless of blur_size, scaling up the resolution increases both the pixel count and the blur_size (as of this PR)... so performance will degrade quicker when scaling, no matter how optimized the effect is.
That means I might still have to add a setting, for a finer control of the decrease in quality as resolution goes up.
I could also just pick a default resolution-quality factor that's good enough, and call it a day.

So whoever wants to use the high quality, uncompromising classic "Circle" mode can still do so, but I think that one is more suitable for offline rendering as it stands.

I think your new mode can replace the existing Circle mode, as offline rendering is considered a corner case. It probably doesn't warrant having entire rendering modes on its own.

@ceLoFaN Could you push your changes with the optimized circle DoF?

Sorry for the long silence, but I've been dealing with various health issues for the past 5 weeks or so.
Here's the branch if anybody wants to tidy it up or give it a spin: https://github.com/godotengine/godot/compare/master...ceLoFaN:improve-dof?expand=1
Some numbers might need more tweaking to get the before advertised FPS, but the good news is I fixed 2 bugs that resulted in visual artifacts at various DOF settings, and it resembles the original DOF better.
I was also messing with a denoising step at the time, which you guys might not like as much, but to me looked somewhat promising.
Unfortunately, I don't think I'll be able to resume work on this for the forseable future, but I pushed what I had at the time on my working branch.


Use coroutines in place of Java Futures

This needs to be prioritised along with the conversion of the last few straggler classes to Kotlin (See issue #50).
The coroutines-rewrite branch implements a very basic wrapper around the API which can be built upon and then be utilised to get rid of the AsyncWorker class as well as the Java Futures in one go.

While my lack of focus with regards to what I'm doing with a project is legendary, I'm going to actually try getting a move on this and only this until I make satisfactory progress or just finish it altogether. Elizarov's KotlinConf talk helped a lot in gaining clarity as to how to apply the theoretical knowledge I've been picking up through the documentation to a real scenario like this so massive thanks for that Roman :smiley:.

No need for an open issue for this, the PR serves the purpose well.


Include description and help text in JSDoc comments?

Thank you for a very useful library! Would you consider adding support for including content type descriptions and field help texts in the JSDoc comments generated when using the --jsdoc option. For example:
/**
 * Article page.
 * @name Article
 * @type {TypeArticleFields}
 * @memberof TypeArticle
 */
export interface TypeArticleFields {
  /**
   * Page title, shown at the top of the browser window and in search results.
   * @name Title
   * @localized false
   */
  title: EntryFieldTypes.Symbol
}

I think this would be more useful than the current implementation:
/**
 * Fields type definition for content type 'TypeArticle'
 * @name Article
 * @type {TypeArticleFields}
 * @memberof TypeArticle
 */
export interface TypeArticleFields {
  /**
   * Field type definition for field 'title' (Title)
   * @name Title
   * @localized false
   */
  title: EntryFieldTypes.Symbol
}

Hey @joakimgunst,
Thanks for sharing your ideas 🙏
I think using the helpText information from the EditorInterface entity is a great idea.
Would you be interested in opening a pull request for it?

Created a draft PR for adding the help texts here: https://github.com/contentful-userland/cf-content-types-generator/pull/293
Probably needs some updates before it's ready to merge, but you can check at this point if you agree with the general idea and if it is worthwhile to continue with it.

closing due to inactivity


FormAction

In the "Slot Filling" sectionSlot Filling,
'''
happy path

request_restaurant

restaurant_form
form{"name": "restaurant_form"}
form{"name": null}
'''

what does the last two lines(- form{"name": "restaurant_form"} and  - form{"name": null}) mean?

this is usage question, please ask this type of question on our forum


Option to limit OAuth permissions?

Hi, I am using a free / non-admin Google account, I followed your initial setup instructions listed here. However, when performing the "First-time authentication" step, I was a bit concerned about the permissions that your module requests.
I am sure your module is legitimate, but would it be possible to only grant specific permissions related to my use case? For example, I literally only want to read data from Google Sheets, so for the OAuth consent screen part of the instructions, I only added spreadsheets readonly rather than everything. However, for the "first-time authentication" step, I don't see an option to only grant said permission (it's not even in the list).
edit: Manually editing the generated url scope to "&scope=https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fspreadsheets.readonly" worked.

Those are all the permissions the project has, the link in that guide will
enable all those APIs by default.  If you go to the Dashboard for that
project, at the bottom will be a list of APIs, you can click through to
those and disable them.  Otherwise you can make a new project from the
console and only enable the APIs you want.
On Wed, Apr 15, 2020 at 2:10 PM Jeffrey McClain<EMAIL_ADDRESS>wrote:

Hi, I am using a free / non-admin Google account, I followed your initial
setup https://psgsuite.io/Initial Setup instructions listed here.
However, when performing the "First-time authentication" step, I was a bit
concerned about the permissions https://i.imgur.com/cwFweYC.png that
your module requests.
I am sure your module is legitimate, but would it be possible to only
grant specific permissions related to my use case? For example, I literally
only want to read data from Google Sheets, so for the OAuth consent screen
part of the instructions, I only added spreadsheets readonly
https://www.googleapis.com/auth/spreadsheets.readonly rather than
everything. However, for the "first-time authentication" step, I don't see
an option to only grant said permission (it's not even in the list).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SCRT-HQ/PSGSuite/issues/277, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3SYZZZ556ZPV25NER7HELRMYBBHANCNFSM4MI2QMKQ
.

Thanks for the tip, I'll remove the other APIs manually for now and create a clean project later.


Unable to take a screenshot - too much JS maybe???

I'm trying to use percy to take a screenshot of our web page and I get 413 error code. You can see the full response in the following screenshot.

I use Java and this is the line I have added to my test to take the screenshot
percy.snapshot("Test screenshot", Arrays.asList(1920), 2000, true)
I came across this issue  and I realised that we may have too much JavaScript as well.
Our bundle was too big (around 7MB) and we managed to limit it to around 1.2MB, but I still get the same error.
Can you guide me on how to solve this issue? What's the limit (in KB/MB) for JS?

Hi @taniapil!
Does the error go away when you leave JavaScript disabled for the snapshot? If so, then it could be a different JS bundle than one you're expecting. If it doesn't go away then it's likely some other asset is too large, such as an image.
If you add the environment variable LOG_LEVEL=debug, that will print out more detailed debug logs. That will help determine which request might be causing this error.

Hi @wwilsman!
Sorry for the late reply but I didn't have the time to try this until now.
It seems that the environment variable LOG_LEVEL=debug did the trick either the enableJavascript param is used or not.
Without this env var it still fails with the error I mentioned in my first comment.

Very interesting. That environment variable only controls what get's logged to the console output. It shouldn't have any bearing on file sizes 🤔


Improve std.regex wordMatcher build times by delaying its work from CT to RT if possible

This will improve std.regex build times by about ~500ms if used. It delays initialization of the wordMatcher tables till runtime if possible. This should mean it won't work at CTFE, but we'll see if we need to fix that later (it can be cached where it's used and computed each time).
Tracking issue (does not close): https://issues.dlang.org/show_bug.cgi?id=23737

Gonna ping @rainers to see if you have any suggestions here. @WalterBright it would be nice if we could solve this some other way that doesn't require violating pure (even if it's opt-in via a attribute).

Here is my time-trace of std.regex with std.uni:

This is pre-fix of this PR, wordMatcher is taking up quite a significant portion of that.

Gonna ping @rainers to see if you have any suggestions here.

Not sure if you meant someone else, I'm not contributor or expert on std.regex. Prebuilding unnecessary compile time evaluation sounds reasonable to me, but why don't you just annotate the function as inferred when converting the template to a regular function?

Gonna ping @rainers to see if you have any suggestions here.

Not sure if you meant someone else, I'm not contributor or expert on std.regex. Prebuilding unnecessary compile time evaluation sounds reasonable to me, but why don't you just annotate the function as inferred when converting the template to a regular function?

I thought you were involved in the original work. I may have got the wrong idea based on some work with std.uni, my apologies.
I'm not convinced about switching it from templated to non-templated. I think I'll revert it, just because it'll force std.uni to be pulled in even if it wasn't used.

cc @DmitryOlshansky

Would it be possible to push this in the other direction instead (Phobos build time)? I.e. we ship a generated D file with the output from this computation, or, we hide the result of the computation in a D file which is not importable but accessed only by linking.

This must be usable at CTFE and must be memorized if used there (it's not stored and only used by ref).
That kills off extern function/global route. Even if we assume I want to touch the build scripts to add that capability into Phobos.
We can't throw a module constructor at it, that'll create a performance regression at RT if you import std.regex (assuming linker will elide it, and that ignores shared library builds).
Any other approach I've forgotten about?

this makes the return type mutable, if you want to delay the initialisation from CT to RT, then use a shared module constructor and keep it immutable.

See above, that's a regression.

Any other approach I've forgotten about?

Well, is the result of this computation representable as an immutable global? Would it be possible to create a .d file which contains this result at Phobos build time?

Any other approach I've forgotten about?

Well, is the result of this computation representable as an immutable global? Would it be possible to create a .d file which contains this result at Phobos build time?

The naive approach won't work of course thanks to CTFE, but in theory if somebody went to the trouble of figuring out how to make all the uncompressed tables get data in&out and modified Phobos build scripts then perhaps yes we could do this. However, it is work on std.uni rather than just std.regex.
My main concern here is keeping CTFE intact and not bloating binaries when it isn't used. The only alternative I've thought up that keeps the existing tradeoffs very close to intact is to make the compiler do the memorization for us instead, opt-in. But perhaps there is another solution that doesn't require a ton of work?
https://github.com/dlang/phobos/blob/0d4334f6be21238ff787487d75cd32bf4d25e316/std/regex/internal/ir.d#L984

The next RC is due to be cut - does this still need to be targeting stable, or can it be switched to master?

The next RC is due to be cut - does this still need to be targeting stable, or can it be switched to master?

I switched it but it seems not all of CI has been triggered which is weird.

Looks like CI is red due to stuff like:

+/private/var/folders/76/zy5ktkns50v6gt5g8r0sf6sc0000gn/T/dmd/compiler/test/../../../phobos/std/format/internal/write.d-mixin-1993(1993): Deprecation: using in ref is deprecated, use -preview=in and in instead

Which isn't related to this PR.

I rebased this to latest master. @thewilsonator anything blocking this PR?

Ok CI still failing due to unrelated changes.

std/concurrency.d(2273): Deprecation: cannot throw object of qualified type shared(Throwable)

It would still be nice to have this be immutable. If you're going to hack in pure you may as well hack in immutable too.

After adding immutable, looks like CI is in the same state. @thewilsonator, so done that.

Heyyyyy @RazvanN7 CI is green :)


Validate with specific BC-version

For use with customers on on-prem, we would like to force validation with a specific BC version. In this case BC21.
Is there a setting to force this?
Regards
Håkan

If you set the artifact setting in the project settings file, you control which artifacts are used for building.
https://aka.ms/algosettings#artifact

Great! Just to be sure:
I set the "artifact"-parameter to "21.3" in order to expect the 21.3-version of BC. I have already set the country to "se" in the file.
But that resultet in a "not found"-exception.
Is there a sertain format for the wildcard?

Examples of:
<storageaccount>/<type>/<version>/<country>/<select>

would be
//21.3/us/latest

or
/sandbox/21.5.1234.1234/dk/closest

etc.


Add CaseSensitiveInfo to NtQueryFileInformation

Include the help for FileCaseSensitiveInformation and
FileCaseSensitiveInformationForceAccessCheck along
with NtQueryInformationFile.

Hi @ChandKV, thanks for the PR. I tweaked the Windows version name to Windows 10, version 1803, but other than that everything looks good so I'll go ahead and merge this for you. The changes will probably be live Monday morning.


Multisig. Create multisig. EVM addresses is available for not evm networks

Description
While create a multisig account - signatory list should be sorted by network. Otherwise user can create a multisig with evm address.
Example:
https://github.com/user-attachments/assets/b91cbbf0-0fdc-435d-bced-5d2ff82cf4a4
Steps to Reproduce

Add evm wallet
Go to multisig creation
Try to create Polkadot multisig with EVM

Expected Behavior
Can't select EVM addresses while create Polkadot multisig.
The list of available addresses must be sorted, based on network
Actual Behavior
Available to use all addresses
Environment
https://github.com/novasamatech/nova-spektr/commit/1b29836ffc7ca408a44df236bae6f0d8b98bf087

Status verification: ✅


Storage system like?

Implement storage system :like method considering we should not compare the credentials

Fixed by #100


Fix the initializing of stack in Numbas.Error

Bug summary: on some browsers, an exception was being thrown when trying
to access the stack property on instances of Numbas.Error.

The statement
Error.call(this);

is effectively a no-op, since:

when Error is called as a function rather than as a constructor, it
creates and initializes a new Error object.

Source: http://es5.github.io/#x15.11.1
Thus properties of Numbas.Error instances had to be set manually. In
particular, the stack (non-standard) property was being initialized
with Error.captureStackTrace (non-standard) which isn't available in
all browser (eg, Safari/ Firefox?).
However, all major browsers provide a Error.stack property on Error
instances (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/Stack).
This commit provides a fix by having Numbas.Error return a new
instance of Error that is monkey-patched in order to have the
localized message. The fix has the following caveat:
(new Numbas.Error() instanceof Numbas.Error) === false

NOTE: If it is prefered, I can provide a patch that cirvumvents this issue.

Thanks for this. I recently switched to Firefox and have been meaning to look at why stack traces didn't work!
Numbas.Error really exists to automatically localise error messages; I'm not really bothered about preserving instanceof since type checking is pretty useless in ES5.
A better solution might be to change new Numbas.Error(key,options) everywhere to Numbas.error(key,options), and make it explicit that it's just a function, not a constructor, that returns a normal Error object.

I've finally merged this in, manually. Thanks for this suggestion, and sorry I left it for so long!


Improvementation do not sync filter size when rf has local target

Proposed changes
do not sync filter size when rf has local target

run buildall


Bump

Issue
na
Description
some refactoring and dependency bump
Additional context

📚  View the storybook of this branch here

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

:tada: This PR is included in version 1.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Support for Docker Hub registry mirror for rate-limited pulls

While running some automation jobs in bulk on my Gitlab projects, I got hit today by the infamous new Docker Hub Rate Limiting...
Waiting for services to be up and running...
Pulling docker image docker:latest ...
ERROR: Preparation failed: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit (docker.go:142:0s)

There are some solutions to this problem:

Authenticate to docker hub. Anonymously you get 100 container image requests per 6 hours, with an authenticated account you get 200 container image requests per 6 hours.
Pay for Docker Hub. There's a Pro account already for only $5/month. Requires you to authenticate. For a company, this is the easiest solution and makes the most sense to pay for such a critical service. In my case, it's a personal project for fun so worth looking for other (cheaper) ways.
Cache on GitLab container registry: tag and push the docker hub image you use (e.g. php:8) to your Gitlab repository container registry to "cache", and simply pull from that one to decrease pulls from docker hub. Bit tedious...
Use the free Gitlab Dependency Proxy

Requires you to add a docker login statement and to prefix every docker image with $CI_DEPENDENCY_PROXY_GROUP_IMAGE_PREFIX. Currently, I tried this but get a 500 error back on docker pull...

Self-Hosted Docker Registry As Pull-Through Cache:  Docker Hub Registry Mirror and let the runner use this as a registry as a pull-through cache. A similar thing can be done with JFrog Artifactory/Container Registry. Because distribution uses HEAD manifest requests to check if cached content has changed, it will not count towards the rate limit. Note that initial requests for Hub images that are not yet in cache will be counted.
Google and AWS have both launched a solution: https://cloud.google.com/container-registry/docs/pulling-cached-images and https://aws.amazon.com/blogs/containers/advice-for-customers-dealing-with-docker-hub-rate-limits-and-a-coming-soon-announcement/ and https://aws.amazon.com/blogs/aws/amazon-ecr-public-a-new-public-container-registry/

Does anyone have experience with any of these solutions? Did anyone try the self-hosted Docker registry mirror? Would it make sense to spin it up in this repo, or provide config options in this repo to add it?

Hey,
it could be great to setup a Docker registry proxy and configure the runner to point on it. But sure +1 for this killer feature.
So far, I have my own workaround, I have a repository of all my base docker images (my-org/docker-env) and I use this simple .gitlab-ci.yaml script to build the images and publish them to the Gitlab registry.
stages:
    - build

# Define variables
variables:
    CONTAINER_IMAGE: $CI_REGISTRY_IMAGE:$CI_COMMIT_REF_NAME
    DOCKER_HOST: tcp://docker:2375
    DOCKER_DRIVER: overlay2

# Build docker image
build-image:
    stage: build
    image: docker:1.12-dind
    services:
        - docker:dind
    script:
        - cat /etc/resolv.conf
        - cat /etc/hosts
        - echo $CI_REGISTRY
        - docker info
        - docker login -u gitlab-ci-token -p $CI_BUILD_TOKEN $CI_REGISTRY
        - docker build -t $CONTAINER_IMAGE .
        - docker push $CONTAINER_IMAGE

I build one image per branch:

And publish the branch name as a tag for the image repository registry.
Finally use my base images in my other projects in .gitlab-ci.yml or Dockerfile.
For example:
registry.gitlab.com/my-org/docker-env:node14-nx
Source: https://about.gitlab.com/blog/2020/10/30/mitigating-the-impact-of-docker-hub-pull-requests-limits

Hey,
it could be great to setup a Docker registry proxy and configure the runner to point on it. But sure +1 for this killer feature.
So far, I have my own workaround, I have a repository of all my base docker images (my-org/docker-env) and I use this simple .gitlab-ci.yaml script to build the images and publish them to the Gitlab registry.
stages:
    - build

# Define variables
variables:
    CONTAINER_IMAGE: $CI_REGISTRY_IMAGE:$CI_COMMIT_REF_NAME
    DOCKER_HOST: tcp://docker:2375
    DOCKER_DRIVER: overlay2

# Build docker image
build-image:
    stage: build
    image: docker:1.12-dind
    services:
        - docker:dind
    script:
        - cat /etc/resolv.conf
        - cat /etc/hosts
        - echo $CI_REGISTRY
        - docker info
        - docker login -u gitlab-ci-token -p $CI_BUILD_TOKEN $CI_REGISTRY
        - docker build -t $CONTAINER_IMAGE .
        - docker push $CONTAINER_IMAGE

I build one image per branch:

And publish the branch name as a tag for the image repository registry.
Finally use my base images in my other projects in .gitlab-ci.yml or Dockerfile.
For example:
registry.gitlab.com/my-org/docker-env:node14-nx
Source: https://about.gitlab.com/blog/2020/10/30/mitigating-the-impact-of-docker-hub-pull-requests-limits

We use a proxy like artifactory, post of the builds points directly to the mirror. But on the runners we configure on system level the mirror for docker via --registry-mirror. Not ideal but it works all quite well

We use a proxy like artifactory, post of the builds points directly to the mirror. But on the runners we configure on system level the mirror for docker via --registry-mirror. Not ideal but it works all quite well

Ran into this issue today, looking to setup pointing at the ECR. I was hoping it'd be as easy as passing IAM permissions to either the runner, or the machine, but I haven't had any luck with that, so I'm investigating installing ecr credential helper.
How are you pointing directly at the mirror?

@npalm Could you please share your solution? Where to put the "--registry-mirror" option?

@alexout Yeah, that's the configuration I am using too.

Launching a Docker registry mirror is out of scope. But making the configuration explicit would be nice. See #400


Re-add skip license creation in extended generators

This code will re-add the option to skip license creation.
My reasoning is that license:app doesn't meet my company's needs. The rest of node:app meets my needs, or has options to turn off what I don't want/need.
I also altered the documentation because stating that there is a node:license but not having a generators/license seems like an oversight since node:license was outsourced to license:app.

Thanks

Anytime


Add user defined snippets

By default there are some snippets like the program skeleton and the module skeleton. It would be interesting if users could also add or change snippets, for example by putting fortran90.json in .vscode/fortran90.json .

This can already be done see: https://code.visualstudio.com/docs/editor/userdefinedsnippets#_create-your-own-snippets
Duplicate of #230


Added descriptions for all Particles2D.xml methods

I rewrote my contribution to follow the guidelines and the suggestions made in the former PR.

@WorkShoft thanks for contributing, i have some advice that might help you with this and future contributions. It seems that in most cases you are just stating the same thing as the method name, in some cases this is absolutely fine, since the method name is very clear already, but in others you need to formulate and explain things in more detail, dont forget that the help will be viewed by users that might not know the terminology, having said that, it is also ok to not document the methods you dont know or dont understand, someone more experienced will fill them out.
an example is this

A material which will be validated and processed.

this description does not tell me much about what that is, you could for example point to other documentation that explain how materials work, or try to explaining it there.

Thanks for the insight. Some of my mistakes are probably obvious to some of you since this is the first time I collaborate on a big project like this.
Some of the methods seem to have no use at the moment and some other methods are obscure, like the one you cited. For cases like those I looked through the code with grep and checked briefly what they did, which as you say isn't enough if you can't explain thoroughly what they do.

Contents LGTM. Please fix all spaces to tabs and remove trailing newlines, then git commit --amend.

I am currently working on Particles and ParticlesMaterial, so go ahead and merge (after the formatting fixes) and I'll amend with the content that overlaps.

 If you're still working on your PR, we should standardize them. Please take whatever looks helpful (I know you were stuck on the process_material description), or let me know and I can finish it up.

Really busy with work and school lately, please feel free to do any further changes that you consider necessary here.

Closed and combined with #11820


Use database.update in FeaturesMixin.save method

Codecov Report

Merging #268 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
- Coverage   59.94%   59.91%   -0.04%
==========================================
  Files          40       40
  Lines        3253     3253
  Branches      391      391
==========================================
- Hits         1950     1949       -1
- Misses       1197     1198       +1
  Partials      106      106

Impacted Files
Coverage Δ

core/db/models.py
81.92% <100%> (ø)
:arrow_up:

core/video.py
35.78% <0%> (-1.06%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34250fc...307be10. Read the comment docs.

!test

!test

!test


Feature Request: ACA environment support referencing certificates in Azure Keyvault

Is your feature request related to a problem? Please describe.
Today if a ACA user wants to use a custom certificate they need to manually upload the cert in the azure portal or cli. it would be preferable to reference a certificate in a centrally managed vault like Azure KEyvault
Describe the solution you'd like.
Users have the option to reference a key vault certificate  much like is possible in app services today
https://learn.microsoft.com/en-us/azure/app-service/configure-ssl-certificate?tabs=apex#import-a-certificate-from-key-vault
Describe alternatives you've considered.
no alternative available for bio certs

Imho this feature is one of the missing parts to providing an overall smooth experience around ACA. Especially within a hub and spoke architecture where the same cert is used within the Application Gateway and ACA ingress. Are there any infos available on the timeline for this feature? At my current employer, which is a larger Microsoft customer, we are really looking forward to the availability of this feature.

here's the roadmap item
https://github.com/microsoft/azure-container-apps/issues/888

This should also include auto-rotation

there was a recent preview that allows you to import/upload certs from kv. but thats where it seems to end there, it does not update any reference or auto rotate.
https://azure.microsoft.com/en-us/updates/public-preview-support-for-key-vault-certificates/


Clean up global context cache use

I recently was using this code snippet to run one of my energy validation tests:
    from perses.tests.utils import validate_endstate_energies_point

    outdir = "/data/chodera/zhangi/perses_benchmark/repex/33/0/"

    for endstate in [0, 1]:
        with open(os.path.join(outdir, f"0_apo.pickle"), "rb") as f:
            htf = pickle.load(f)
            validate_endstate_energies_point(htf, endstate=endstate, minimize=True)

However, I'm getting this error:
Input In [2], in run_rest_factory_test(name)
     45 with open(os.path.join(outdir, f"0_{phase}.pickle"), "rb") as f:
     46     htf = pickle.load(f)
---> 48 validate_endstate_energies_point(htf, endstate=endstate, minimize=True)

File ~/miniconda3/envs/openmm-dev/lib/python3.9/site-packages/perses-0.9.5+94.g0fb13173.dirty-py3.9.egg/perses/tests/utils.py:950, in validate_endstate_energies_point(htf, endstate, minimize)
    948     hybrid_positions = sampler_state.positions
    949 context_hybrid.setPositions(hybrid_positions)
--> 950 components_hybrid = compute_potential_components(context_hybrid, beta=beta)
    952 # Get energy components of original system
    953 thermostate_other = states.ThermodynamicState(system=system, temperature=temperature)

File ~/miniconda3/envs/openmm-dev/lib/python3.9/site-packages/perses-0.9.5+94.g0fb13173.dirty-py3.9.egg/perses/tests/utils.py:307, in compute_potential_components(context, beta, platform)
    304 # Make a deep copy of the system.
    305 import copy
--> 307 from perses.dispersed.utils import configure_platform
    308 platform = configure_platform(platform.getName(), fallback_platform_name='Reference', precision='double')
    310 system = context.getSystem()

File ~/miniconda3/envs/openmm-dev/lib/python3.9/site-packages/perses-0.9.5+94.g0fb13173.dirty-py3.9.egg/perses/dispersed/utils.py:90, in <module>
     87     return platform
     89 #########
---> 90 cache.global_context_cache.platform = configure_platform(utils.get_fastest_platform().getName())
     91 #########
     92
     93 #smc functions
     94 def compute_survival_rate(sMC_particle_ancestries):

File ~/miniconda3/envs/openmm-dev/lib/python3.9/site-packages/openmmtools-0.21.1+14.g025fc04-py3.9.egg/openmmtools/cache.py:335, in ContextCache.platform(self, new_platform)
    332 @platform.setter
    333 def platform(self, new_platform):
    334     if len(self._lru) > 0:
--> 335         raise RuntimeError('Cannot change platform of a non-empty ContextCache')
    336     if new_platform is None:
    337         self._platform_properties = None

RuntimeError: Cannot change platform of a non-empty ContextCache

This is because this line tries to set the platform of the global context cache, but was already set when this line was called, because feptasks.py has import openmmtools.cache as cache, which creates a global context cache here.
If I comment out this line, the problem goes away.
I think we need to go through the all the files in this repo and make sure that global context caches are being used properly.

@zhang-ivy Thanks for reporting this. I agree we need to monitor and clean things up to match the current context cache behavior from openmmtools. Can you share the pickled file so I can test and check this?
I believe the issue is not because the global context cache is created but instead, as the error says, it is because it's trying to change its platform after being used (non-empty), but I'd like to confirm this is indeed what's happening.

0_apo.pickle.zip

I believe the issue is not because the global context cache is created but instead, as the error says, it is because it's trying to change its platform after being used (non-empty), but I'd like to confirm this is indeed what's happening.

The error about changing the platform arises because the context cache was created somewhere else first, so the problem is either 1) the global context cache is being created somewhere else first (where it should not be created) or 2) the global context cache platform is attempting to be changed (where it should not be changed). We will have to discuss this further to identify which one is the problem, as it depends on what we want the desired behavior to be.

We should remove the manual global context cache configuration in perses. It should happen automatically in openmmtools. CC https://github.com/choderalab/openmmtools/issues/558

@zhang-ivy I'm getting the following error while trying to load your serialized objects
Warning: importing 'simtk.openmm' is deprecated.  Import 'openmm' instead.
INFO:numexpr.utils:NumExpr defaulting to 8 threads.
Traceback (most recent call last):
  File "/home/user/workdir/debugging/perses-968/test.py", line 10, in <module>
    htf = pickle.load(f)
  File "/home/user/miniconda3/envs/perses-dev/lib/python3.9/site-packages/openmm/openmm.py", line 1916, in __setstate__
    system = XmlSerializer.deserialize(serializationString)
  File "/home/user/miniconda3/envs/perses-dev/lib/python3.9/site-packages/openmm/openmm.py", line 6928, in deserialize
    return XmlSerializer._deserializeForce(inputString)
  File "/home/user/miniconda3/envs/perses-dev/lib/python3.9/site-packages/openmm/openmm.py", line 6850, in _deserializeForce
    return _openmm.XmlSerializer__deserializeForce(inputString)
openmm.OpenMMException: Unsupported version number

Which I presume is because you are probably using a dev version of openmm or similar. Can you share the openmm version you are using? Just to be able to reproduce and test the solution to this issue. Thanks.

Yes its the nightly dev version. Here is the commit hash: bbd751bf1a8db98c65d856c1159bf79c8bec2e15
You can also use this test: https://github.com/choderalab/perses/blob/rest-over-protocol/perses/tests/test_relative.py#L1025 in the rest-over-protocol branch. I haven't tried reproducing the error using the test though, so I'm not sure what the behavior will be.

related to: https://github.com/choderalab/openmmtools/issues/558


Update package to php7

Hi @dhrrgn,
we've been using this lib for many years (thanks for that by the way).
I will be happy to help you update the codebase for being php7 compatible and fix league/flysystem dependecy version

friendly ping @dhrrgn :)


0.38.3 Broke Broadlink Switch - Failed to connect to device

Home Assistant release (hass --version):
0.38.3
Python release (python3 --version):
Python 3.5.0
Component/platform:
Broadlink Switch
Description of problem:
After upgrade to 0.38.3 Broadlink switch fails to work. From the logs:
17-02-17 07:56:58 ERROR (Thread-6) [homeassistant.components.switch.broadlink] Failed to connect to device.
As a result, turn off/on switches don't work.
I don't know what was the installed version before 0.38.3 (I think it was 0.37)
I'm using Broadlink rm pro
switch:
  - platform: broadlink
    host: <IP_ADDRESS>
    mac: 'B4:43:0D:EF:91:C5'
    switches:
      robot:
        friendly_name: robot
        command_on: 'XXX'
        command_off: 'XXX'

There are no changes in the Broadlink component since 0.37 that should cause this.
The error indicates that it is a network issue, since HA does not get any response from your switch.
You can try to increase the timeout.

Thanks.
After reboot I can now control again my switches but I still get this error on hass boot.
Tried to increase the timeout to 60s but it is still the same.
Is it possible that timeout value is not being used properly?
see:
https://github.com/mjg59/python-broadlink/blob/master/broadlink/__init__.py#L253
      while True:
        try:
          self.cs.sendto(packet, self.host)
          self.cs.settimeout(1)
          response = self.cs.recvfrom(1024)
          break
        except socket.timeout:
          if (time.time() - starttime) < self.timeout:
            pass
          raise

I'd expect it to be continue instead of pass but I guess I'm missing something.

Ok, then I can close this issue?
For the other question. I think pass  is correct. You can try to change it, or open an issue in the broadlink library.

Check this: https://github.com/mjg59/python-broadlink/issues/45#issuecomment-272631782
So you can try add an else


Slower sidecar proxy startup time on larger kubernetes cluster

Istio Details
Istio Version: 0.4.0
Cluster Detail: GKE with Container-Optimized OS (cos)
Description
Hi,
I've just installed Istio 0.4.0 on a cluster with the default settings as in istio.yaml and noticed that there is a timeframe after pod startup when application could not make any connection to other services (http, database, etc). The problem is, that timeframe is larger and unacceptable for larger clusters.
I used this small connection checker program that tries to connect to mysql and http service every second. When running it on a cluster of 4 nodes, and 11 pods (basically, it's a fresh cluster with Istio and Bookinfo app installed), I saw a period of 3 second where the app could not make any connection outside (indicated by ECONNREFUSED).
Three seconds would still be acceptable for production use cases, but when running the exact same application on a larger cluster that consist of 111 nodes, and ~2100 pods, the period when apps could not make any connection outside was increased to around ~5mins and more.
I noticed that on larger clusters, starting main dispatch loop in istio sidecar took much longer time than the one on smaller cluster:
larger cluster, start 07:16:35, end 07:19:52:
}ERROR: logging before flag.Parse: I0111 07:16:34.393299       1 watcher.go:270] Envoy command: [-c /etc/istio/proxy/envoy-rev0.json --restart-epoch 0 --drain-time-s 45 --parent-shutdown-time-s 60 --service-cluster api-istio-coba --service-node sidecar~<IP_ADDRESS>~api-istio-coba-1836146160-7rq5j.default~default.svc.cluster.local --max-obj-name-len 189 --service-zone AvailabilityZone couldn't find the given cluster node]
[2018-01-11 07:16:35.537][18][warning][main] external/envoy/source/server/server.cc:157] initializing epoch 0 (hot restart version=9.200.16384.256)
[2018-01-11 07:16:35.753][18][warning][main] external/envoy/source/server/server.cc:344] starting main dispatch loop
[2018-01-11 07:19:52.149][18][warning][main] external/envoy/source/server/server.cc:328] all clusters initialized. initializing init manager
[2018-01-11 07:19:53.518][18][warning][config] external/envoy/source/server/listener_manager_impl.cc:448] all dependencies initialized. starting workers
[2018-01-11 07:20:56.177][18][warning][main] external/envoy/source/server/drain_manager_impl.cc:62] shutting down parent after drain
[libprotobuf INFO external/mixerclient_git/src/check_cache.cc:155] Add a new Referenced for check cache: Absence-keys: source.uid, Exact-keys: context.protocol, destination.ip, destination.service, destination.uid, source.ip,

smaller cluster, start 06:50:10, end 06:50:12:
}ERROR: logging before flag.Parse: I0111 06:50:10.595332       1 watcher.go:270] Envoy command: [-c /etc/istio/proxy/envoy-rev0.json --restart-epoch 0 --drain-time-s 45 --parent-shutdown-time-s 60 --service-cluster api-istio-coba --service-node sidecar~<IP_ADDRESS>~api-istio-coba-2549837242-j3b08.default~default.svc.cluster.local --max-obj-name-len 189]
[2018-01-11 06:50:10.620][10][warning][main] external/envoy/source/server/server.cc:157] initializing epoch 0 (hot restart version=9.200.16384.256)
[2018-01-11 06:50:10.846][10][warning][main] external/envoy/source/server/server.cc:344] starting main dispatch loop
[2018-01-11 06:50:12.393][10][warning][main] external/envoy/source/server/server.cc:328] all clusters initialized. initializing init manager
[2018-01-11 06:50:12.932][10][warning][config] external/envoy/source/server/listener_manager_impl.cc:448] all dependencies initialized. starting workers
[libprotobuf INFO external/mixerclient_git/src/check_cache.cc:155] Add a new Referenced for check cache: Absence-keys: source.uid, Exact-keys: context.protocol, destination.ip, destination.service, destination.uid, source.ip,

Is this an expected behaviour? Is there anything we could do to speed up the "start up"?
Thanks
Andre

Hi guys,
I have tried the latest Istio 0.5.0 (pre-release) and latest vanilla envoy. From my end, It was very clear that the latest vanilla envoy was much much faster than the envoy used by istio-proxy.
 The output of server_info for istio-proxy and vanilla envoy are
envoy 0/1.6.0-dev//DEBUG live 1317 1317 0
and
envoy 6a2781e3c50a4d8049426fda186cdf1cdd0ed860/1.6.0-dev/Clean/RELEASE live 118 118 0 respectively.
@andraxylia Is it because Proxy 0.5.0 did not include 6a2781e3c50a4d8049426fda186cdf1cdd0ed860 ? Or is it because of something else?
Thanks
/cc @jmarantz

OOT question, @jmarantz would the regex enhancement bring down the cds init time even more?

Do you still see issues with release 0.8?

@andresusanto gentle ping. Did you get chance to test with release 0.8?

We're still seeing slow startup sometimes on 0.8 with proxyv2, depending on cluster size and pilot? load.
Here's an example, but this is on the better side. We've seen way worse with liveness checks restarting the app containers 10-30 times because it was taking so long to initialize. I'm trying to track down those logs.
[2018-06-22 15:19:02.407][29][info][main] external/envoy/source/server/server.cc:396] starting main dispatch loop
[2018-06-22 15:19:02.409][29][info][upstream] external/envoy/source/common/upstream/cluster_manager_impl.cc:128] cm init: initializing cds
...<snip>...
[2018-06-22 15:19:07.865][29][info][upstream] external/envoy/source/common/upstream/cluster_manager_impl.cc:109] cm init: initializing secondary clusters
[2018-06-22 15:19:08.005][29][info][upstream] external/envoy/source/common/upstream/cluster_manager_impl.cc:132] cm init: all clusters initialized
[2018-06-22 15:19:08.005][29][info][main] external/envoy/source/server/server.cc:376] all clusters initialized. initializing init manager
...<snip>...
[2018-06-22 15:19:20.258][29][info][upstream] external/envoy/source/common/upstream/cluster_manager_impl.cc:390] add/update cluster inbound|8000||xxx-dev.v2.svc.cluster.local starting warming
[2018-06-22 15:19:20.258][29][info][upstream] external/envoy/source/common/upstream/cluster_manager_impl.cc:397] warming cluster inbound|8000||xxx-dev.v2.svc.cluster.local complete
[2018-06-22 15:19:20.862][29][info][upstream] external/envoy/source/server/lds_api.cc:62] lds: add/update listener '<IP_ADDRESS>_8000'
[2018-06-22 15:19:20.865][29][info][upstream] external/envoy/source/server/lds_api.cc:62] lds: add/update listener '<IP_ADDRESS>_9090'
[2018-06-22 15:19:20.867][29][info][upstream] external/envoy/source/server/lds_api.cc:62] lds: add/update listener '<IP_ADDRESS>_15003'
[2018-06-22 15:19:20.869][29][info][upstream] external/envoy/source/server/lds_api.cc:62] lds: add/update listener '<IP_ADDRESS>_8088'
[2018-06-22 15:19:20.871][29][info][upstream] external/envoy/source/server/lds_api.cc:62] lds: add/update listener '<IP_ADDRESS>_5000'
[2018-06-22 15:19:20.873][29][info][upstream] external/envoy/source/server/lds_api.cc:62] lds: add/update listener '<IP_ADDRESS>_9200'
[2018-06-22 15:19:20.877][29][info][upstream] external/envoy/source/server/lds_api.cc:62] lds: add/update listener '<IP_ADDRESS>_8000'
[2018-06-22 15:19:20.879][29][info][upstream] external/envoy/source/server/lds_api.cc:62] lds: add/update listener '<IP_ADDRESS>_15010'
[2018-06-22 15:19:20.881][29][info][upstream] external/envoy/source/server/lds_api.cc:62] lds: add/update listener '<IP_ADDRESS>_9093'
[2018-06-22 15:19:20.884][29][info][upstream] external/envoy/source/server/lds_api.cc:62] lds: add/update listener '<IP_ADDRESS>_80'
[2018-06-22 15:19:20.886][29][info][upstream] external/envoy/source/server/lds_api.cc:62] lds: add/update listener '<IP_ADDRESS>_15004'
[2018-06-22 15:19:20.887][29][info][upstream] external/envoy/source/server/lds_api.cc:62] lds: add/update listener '<IP_ADDRESS>_9091'
[2018-06-22 15:19:20.891][29][info][upstream] external/envoy/source/server/lds_api.cc:62] lds: add/update listener '<IP_ADDRESS>_9000'
[2018-06-22 15:19:20.892][29][info][upstream] external/envoy/source/server/lds_api.cc:62] lds: add/update listener '<IP_ADDRESS>_8060'
[2018-06-22 15:19:20.895][29][info][upstream] external/envoy/source/server/lds_api.cc:62] lds: add/update listener '<IP_ADDRESS>_15007'
[2018-06-22 15:19:20.896][29][info][upstream] external/envoy/source/server/lds_api.cc:62] lds: add/update listener '<IP_ADDRESS>_8080'

@hrishin hi, sorry for late response, we decided to leave Istio and allocate our effort to go with vanilla Envoy instead, so we have not tested the 0.8 right now.
CC @novendriono

I expect we'll continue to work on this in the 1.1 timeframe as an ongoing process of optimizing Pilot and how it serves Envoy.

@andresusanto having moved to vanilla Envoy, did that resolve your startup speed issues fully?


Add new help command with all available commands

I would suggest to add a new help command which shows all commands of the bot and what they do.
I'm not sure if !help would be the best suggestion because many bots use a ! as prefix. You could use the current !info command and show all available commands below the info with explanation.

I added a !help command in v2.0.1. I might also make it work with !commands.


[S] title

can you add my version into yours?

If you'd like to edit the website, feel free to open a pull request

#11


dnu restore does not have beta 8 available

When performing dnu restore of Microsoft.Framework.Configuration package is only has beta 1 - 4 published.  Shouldn't beta 8 be available here?

It was renamed to Microsoft.Extensions.*. See https://github.com/aspnet/Announcements/issues/77 for more info.

But this is not available in the feed either?
On Mon, Nov 2, 2015 at 10:30 AM, Eilon Lipton<EMAIL_ADDRESS>wrote:

Closed #326 https://github.com/aspnet/Configuration/issues/326.
—
Reply to this email directly or view it on GitHub
https://github.com/aspnet/Configuration/issues/326#event-452239234.

@johnmeilleur exactly which packages are you looking for? Can you show the error(s) you're getting?

Also, which feeds are you using?

I've tried:
Microsoft.Framework.ConfigurationModel: "1.0.0-beta8" and
Microsoft.Extensions.ConfigurationModel: "1.0.0-beta8" and 1.0.0-rc1
Feeds:
https://api.nuget.org/v3/index.json
https://www.nuget.org/api/v2/

I found it at https://www.myget.org/F/aspnetrelease/api/v3/index.json
Perhaps it would be good to note this in the README.md for the git project?

There was an earlier announcement regarding an earlier rename: https://github.com/aspnet/Announcements/issues/25
So Microsoft.Framework.ConfigurationModel became Microsoft.Framework.Configuration, which is now Microsoft.Extensions.Configuration.


Seg fault with set data on missing DODS datasets (Linux)

Reported by sirott on 3 Aug 2000 22:41 UTC
On Linux RedHat 6.1 Ferret dies with a seg fault on three consecutive attempts
to open DODS datasets that don't exist.
Here's an example that causes a core dump:
yes? go dods_pmel ocean_atlas_monthly
yes? go dods_pmel ocean_atlas_monthly
yes? go dods_pmel ocean_atlas_monthly
Segmentation fault
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/105

Comment by<EMAIL_ADDRESS>on 13 Nov 2002 21:58 UTC
This bug fixed long ago with update to newer versions of DODS libraries

Comment by<EMAIL_ADDRESS>on 21 Oct 2003 20:16 UTC
Moving from the<EMAIL_ADDRESS>user to the<EMAIL_ADDRESS>user.


Deserialization Null Values

NEST/Elasticsearch.Net version:
7.3.1
Elasticsearch version:
7.3.2
Description of the problem including expected versus actual behavior:
I have a document POCO model made up of properties that include basic primitive types and some of my own object types. The mappings  generated from this model within elasticsearch are as expected, and searching by these properties appears to generate the expected query and resulting documents. However the documents only seem to have the basic type properties set and my own object types are all null.
Example:
I am searching for Cases with the following POCO mapping:
public abstract class DocumentBase
{
        public dynamic Id { get; set; }
        public JoinField JoinField { get; set; }

        public const uint Version = 1;
}

public class Case : DocumentBase
{
        public string AccessInstructions { get; set; }
        public string AddressLine1 { get; set; }
        public string AddressLine2 { get; set; }
        public User Customer { get; set; }
        public string CaseNumber { get; set; }
        public string City { get; set; }
        public string Country { get; set; }
        public DateTime? CreatedOn { get; set; }
}

public class User
{
        public Guid? Id { get; set; }
        public string FirstName { get; set; }
        public string LastName { get; set; }
        public string FullName { get; set; }
        public string Phone { get; set; }
        public PhoneType? PhoneType { get; set; }
}

I am able to search, for example, using a filter specifying Customer.FirstName matches "Mike" and will see Cases come back where the customer's first name is indeed "Mike" (I can check against the CaseNumber properties, or see the resulting JSON has the "customer.firstName" prop set to Mike in all records), with other results filtered out. However, the only properties that will have values in the mapped POCO object will be things like Case.AccessInstructions , Case.CaseNumber, Case.CreatedOn... but Case.Customer will be null.
Steps to reproduce:

Create mapping POCO as shown above.

Seed elasticsearch with objects such as:
{
"addressLine1" : "123, Fake Str",
"addressLine2": "15th floor",
"customer.id": "53B9A209-3F39-4859-87C2-6AB1E6795C81"
"customer.firstName": "Mike",
"customer.lastName": "Snow",
"customer.fullName": "Mike Snow",
"customer.phone": "123-342-4323",
"customer.phoneType": 2
"caseNumber": "12314231",
"city": "Chicago",
"country": "US",
"createdOn" : "2019-06-11T15:59:20.040Z"
}

See that the returned result even when searching for Customer.FirstName, will have a null customer object.

Maybe I'm expecting this deserialization to happen automatically, but something needs to be specifically configured? Any help is appreciated here.

The JSON object in your example is flattened. For example,
{
"addressLine1" : "123, Fake Str",
"addressLine2": "15th floor",

"customer.id": "53B9A209-3F39-4859-87C2-6AB1E6795C81",
"customer.firstName": "Mike",
"customer.lastName": "Snow",
"customer.fullName": "Mike Snow",
"customer.phone": "123-342-4323",
"customer.phoneType": 2,

"caseNumber": "12314231",
"city": "Chicago",
"country": "US",
"createdOn" : "2019-06-11T15:59:20.040Z"
}

should be the following, for the client to be able to deserialize correctly.
{
"addressLine1" : "123, Fake Str",
"addressLine2": "15th floor",
"customer": {
  "id": "53B9A209-3F39-4859-87C2-6AB1E6795C81",
  "firstName": "Mike",
  "lastName": "Snow",
  "fullName": "Mike Snow",
  "phone": "123-342-4323",
  "phoneType": 2,
},
"caseNumber": "12314231",
"city": "Chicago",
"country": "US",
"createdOn" : "2019-06-11T15:59:20.040Z"
}


258 Require only title and status for problem-json

Closes #258

Codecov Report

Merging #264 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #264   +/-   ##
=======================================
  Coverage   87.73%   87.73%
=======================================
  Files          27       27
  Lines         269      269
  Branches        7        7
=======================================
  Hits          236      236
  Misses         32       32
  Partials        1        1

Flag
Coverage Δ

#webui
87.73% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d33fce...d2fad47. Read the comment docs.

:+1:

Codacy hangs, so I merge it manually.


Fix building warning/failure with gcc 7.3.0 and 8.2.0

By including sys/sysmacros.h, I fixed this warning with gcc 7.3.0 in Ubuntu
18.04.1:
src/sys_info.cc:267:13: warning: In the GNU C Library, "major" is defined
by <sys/sysmacros.h>. For historical compatibility, it is
currently defined by <sys/types.h> as well, but we plan to
remove this soon. To use "major", include <sys/sysmacros.h>
directly. If you did not intend to use a system-defined macro
"major", you should undefine it after including <sys/types.h>.
major(device_id),
By changing readdir_r() to readdir(), I fixed:
src/sys_info.cc:149:55: warning: ‘int readdir_r(DIR*, dirent*, dirent**)’ is deprecated [-Wdeprecated-declarations]
This patch should be able to fix the building failure with gcc 8.2.0, which
can't tolerate the deprecated usages above.
Also added a closedir() call.
Signed-off-by: Dexuan Cui<EMAIL_ADDRESS>

Thanks!


No documentation on how to increase quota

By default, webrecorder sets the user quota to 1GB. There is no documentation on where this quota can be set or modified, on a per-user or global basis.
It appears webrecorder/webrecorder/config/wr.yaml has default_max_size and default_max_anon_size variables, but changing them does not do anything on the front-end, even if running docker-compose build; docker-compose up -d or ./rebuild.sh. The foregoing is just my guessing on what to do.
Documentation on how to edit quotas would be very helpful. Thanks!

I thought I'd add an update based on what I've found, just in case it helps others. I haven't figured out the original issue, though.
webrecorder has an admin panel on the front-end! This doesn't appear to be documented anywhere except other GitHub issues, but it's located by visiting /admin. However, you won't see it unless you set your user's role to an administrator.
I was running into errors using python admin.py, but the following command worked:
docker exec -it webrecorder_app_1 python -m webrecorder.admin -m
After doing that, logging in as that user will enable access to admin. There's a setting for max size and max anon size but they do not appear to do anything once changed; the account still has a 1GB max.

I still haven't figured out how to make global quota changes work, but I did figure it out for individual users. If you visit /admin/users after following the above instructions, there's a user list. It doesn't appear clickable, but if you hover directly over the username, it's a link to /admin/users/[username] and there's an Increase button. Setting that solves the issue for that user.
The original issue, changing the 1GB default quota, I haven't solved.
(Sorry for being extra verbose walking through all these steps, I'm doing so in hopes it might help others.)

Yes, you are correct, the admin interface provides a UI for increasing the quota for an existing user.
The default should be updatable via both the console and wr.yaml config property, will take a look to see if that's not the case.
The per-user settings are best updated through the admin interface currently.
You can change all of the settings by using the redis command line tool:
The defaults are stored in the h:defaults key
docker exec -it webrecorder_redis_1 redis-cli -n 1 hgetall h:defaults
To change the default max to <value>, you can do:
docker exec -it webrecorder_redis_1 redis-cli -n 1 hset h:defaults max_size <value>
Per-user max_size can be accessed via:
docker exec -it webrecorder_redis_1 redis-cli -n 1 hget u:<user>:info max_size
To set max size for <user> to <value>:
docker exec -it webrecorder_redis_1 redis-cli -n 1 hset u:<user>:info max_size <value>
Hope this help for now! Thanks for reminding about the need for better docs on this.

I'm glad I found this thread -- the problem of being able to set the default size still seems to be there.  I changed the default_max_size and ran recreate.sh, and it didn't affect anything.  I was only able to increase user storage quota limits by making myself an admin using the webrecorder.admin -m mentioned in the above comments, then going to //_settings and changing the "allot space" value.  The "/admin/users" page doesn't appear to exist anymore.  The above steps for getting and setting user configuration values and setting roles should REALLY be in a section of the documentation in README.md.


Analytics pane

We should have an analytics pane where we can put all of our visualizations of debate and feedback data.
Should go under an analytics supertab (#37) and incorporate analyses of the feedback data (#59).
Can start with something small and simple; worth having an issue here just to get it started, at which point we can think about all of the analyses we want to include.
I'll tentatively list some Qs here that we may be interested in:

[ ] Does evidence get used more or less as the debate goes on?

From draft paper (David):

Line graph showing the average judge accuracy across turns of the debate (on the same plot, maybe we can also plot average confidence in the correct answer, to show that we start out underconfident and end up ???)
Offline vs. online accuracy
How should we show/communicate about the variance between judgements on the same debate?
Depending on our overall accuracy, if we have enough accuracy bins we can maybe show a calibration plot
Bar chart showing accuracy when debater A is honest vs. debater B
Bar chart showing accuracy on the first debate you've judged on a particular story, versus the second debate you've judged on that story
Total quote length revealed after 1-2 turns is only 500-1000 chars, which is « than the total story length (how long on avg?) and total arguments+quotes is 2000-4000 chars which is only like 1-2 mins of reading. If we have » 50% accuracy, then this is some info about efficiency


can nvm be used to created a sort of sandboxed npm install?

I'm new but it seems nvm keeps the global environment of npm installs separate.  So it seems like it would be a short jump to
have a couple different nvm installs of the same version with different names and different environments.  I didn't see options
to do this, is it possible?
Operating system and version:
nvm debug output:

nvm ls output:

How did you install nvm?

What steps did you perform?
What happened?
What did you expect to happen?
Is there anything in any of your profile files that modifies the PATH?

If you are having installation issues, or getting "N/A", what does curl -I --compressed -v https://nodejs.org/dist/ print out?

No, this isn't something that's currently supported.


scrollIntoView not working on android

Pls Help!
function scrollIntoView(myRef) working perfect on iOS. But on Android, scrollview always scroll to Top.
react-native v0.59.9

ahh I fixed it according to
https://github.com/facebook/react-native/issues/12966

ahh I fixed it according to
facebook/react-native#12966

Hi, I am running into the exact same issue as you. Could you please share how you fix it? In the issue you mentioned there are multiple ways to address this, but none of them work in my case.

I see the same issue w/ React native 0.64.2


docs(roadmap): update Cactus roadmap to describe breakdown by each release

Resolve #2133
Signed-off-by: Takuma TAKEUCHI<EMAIL_ADDRESS>

@takeutak @jagpreetsinghsasan I'm removing my LGTM just so we don't accidentally merge this before someone else also approves it.
Right now, both approvers are from the same organization (Jagpreet and myself) so we need someone from some other organization like Fujitsu or IBM to approve as well according to the rules.

@petermetz Sure. I agree with you so we should merge this pull-request after Rama's approval.  So, it is not needed to merge it before his approval.

@petermetz Sure. I agree with you so we should merge this pull-request after Rama's approval. So, it is not needed to merge it before his approval.

@takeutak Yes, please also note: Either Rama or Izuru or Sandeep could approve as well. If either one of those people approve then we'll have 2 approving orgs in total.

@petermetz @takeutak I have no problem approving this on its own, but we have several items in the Weaver roadmap that we'd like to add to this too. Should we do that in this PR or in a subsequent one?

@petermetz @takeutak I have no problem approving this on its own, but we have several items in the Weaver roadmap that we'd like to add to this too. Should we do that in this PR or in a subsequent one?

@VRamakrishna It's fine to submit as many pull requests for the roadmap as we want. Also, it's good to have one author with one commit per PR in the sense that this keeps the data in the git log about who added what and when. So, yeah, I'd just approve this one as it is and send another one whenever you are ready.

@takeutak Why did you end up splitting it into 2 commits last minute after the reviews?


Fixing issue where replies do not work for messages like '@bot hello'.

The bot will reply to direct messages, but mentions in group chat cause problems where there is no reply or the reply is blank. Stuff like '@bot: ' at the beginning of the message apparently prevents a match in bot.reply().
Fixed an issue on line 81 that looks like it was introduced when 'reply' was changed from a string to an object. The channel was not being set either. At that point in the code it was undefined. Finally, there was a missing break wasn't really an issue, but I added it so it doesn't become a problem later.

Thank you for the pull request!