Edges with output have wrong status line after #1405

#1405 updates the status line to show the oldest running edge instead of the most recently finished edge, but does so before the edge output has been printed.  For example, this file:
rule echo
  command = sleep $delay && echo $out
  description = echo $out

build a: echo
  delay = 3
build b: echo
  delay = 2
build c: echo
  delay = 1

Produces:
[1/3] echo a
c
[2/3] echo a
b
[3/3] echo a
a

When it should produce:
[1/3] echo c
c
[2/3] echo b
b
[3/3] echo a
a

Thanks for the detailed description! I've used your test case to add an automated test for this to Travis CI: https://github.com/ninja-build/ninja/blob/3841023a44621e8d8133e9eb6e79e26481dc0bc3/misc/output_test.py#L34


added support for en-gb and en-us

DeepL API Supports en-gb and en-us

Hi Markus,
thank you very much for your contribution. Before I accept your pull request, can you please add yourself to the CONTRIBUTORS.md?

Oh, I just noticed one thing: the generic English can not be removed, because DeepL only accepts generic English as a source language.

Hi Markus,
are you still interested in this pull request? If not, then I would finish it for you. I would add you to the CONTRIBUTORS.md if that is okay with you.


FIX #232 Mudando para o link da API

Nesse pull request foi feito:
Issue #232

Pull Request Test Coverage Report for Build 543

3 of 7 (42.86%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 56.938%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Screens/EditScreen.js
1
2
50.0%

src/Screens/LoginScreen.js
0
1
0.0%

src/Screens/NewManager.js
0
1
0.0%

src/Screens/ProfileScreen.js
0
1
0.0%

Totals

Change from base Build 541:
0.0%

Covered Lines:
98

Relevant Lines:
163

💛  - Coveralls


Global Dock Target?

Will the current version support the Global Dock Target?

I think it is possible to implement.


[Frontend][Misc] Don't Repeat Yourself (DRY) Sampling

FIX #8581
This PR adds support for the DRY sampler, a modern repetition penalty to prevent repetitive outputs at a sequence-level, and performs much better than older penalty methods.
Showcase:
Prompt:
All work and no play makes Jack a dull boy. All work and no play makes Jack a dull boy. All work and no play makes Jack a dull boy. All work and no play makes Jack a dull boy. All work and no play makes Jack a dull boy. All work and no play makes Jack a dull boy. All work

No DRY output:
 and no play makes Jack a dull boy. All work and no play makes Jack a dull boy. All work and no play makes Jack a dull boy. All work and no play makes Jack a dull boy. All work and no play makes Jack a dull boy. All work and no play makes Jack a dull boy. All work and no play makes Jack a dull boy. All work and no play makes Jack a dull boy. All work and no play makes Jack a dull boy.\n\nSomewhere between the repetition and the mundane task of George Orwell’s 1984 and the evocative yet disturbing image of a mess of typewriter keys

dry_multiplier=1.0
... (more)\nIn a remote part of town there once lived a lonely young boy named Danny who wrote the phrase \"All work and no p(l)ay makes Jack a d(u)ll boy.\" on a typewriter for what he would shortly come to realize was the remainder of his life. Danny, who was 8 years old at the time (1984), had not yet learned how to turn off his own typed phrase.\nAs I, a good six years older (1990), like many others who experienced The Shining, witnessed the two year and two month documented torment that befell this isolated young soul. A remote"

Currently, using DRY can incur an overhead of up to ~25%. We can probably optimize this.

/ready


yaks-html: render checked="checked", not checked="true"

Quick fix because this just bit me while trying to test-drive an API through Capybara/Rack::Test. Correct HTML is of course checked="checked".
There might be other "boolean" fields that need to be fixed like that. And Yaks::HTML could use tests, which will likely also be through Capybara/Rack::Test so at least I'm getting some feeling for that.

We might also need to consider using another driver for javascript tests (https://github.com/jnicklas/capybara#selecting-the-driver), especially if someone starts working on #58.


Proposal - Remove index.d.ts and consolidate @types/react-native-maps

Is this a bug report?
No. This is a proposal.
@types/react-native contains multiple types that conflict with this module.
There are types in your own index.d.ts that don't match their own definitions in the react-native definition; the property initialRegion, for example, doesn't exist in the @types/react-native, but a definition for MapView does, yet doesn't match your own definitions.
As @types/react-native is practically required to use TS properly with RN, this results in your index.d.ts being overridden and causes a conflict. Rather than update both @types/react-native with definitions that no longer apply to the core RN module and match them to your types, consolidation seems appropriate.
My proposal is to remove the index.d.ts from this module and consolidate it's definitions into an @types module instead.
The PR @types is to remove MapView content entirely as it's not part of the core react-native module any longer and conflicts with this (your) module types definitions.
The default recommendation from the react-native team is to use @types for TS definitions. Having an index.d.ts in your module has the potential to cross name spaces (such as your generic use of the word "Camera") in other type definitions. When moving into the @types module, I would rename this to something like MapCamera.
Consolidating this @types would prevent this from happening as, since they are developed under the same repo, it is easy to identify namespace conflicts. Consolidation also has the benefit of maintaining congruence with react-native types where your individually maintained type definitions do not.
You can compare the conflicting types here:
https://github.com/methodbox/DefinitelyTyped/blob/master/types/react-native/index.d.ts
The PR I'm working on is here:
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/35239

@alvelig @christopherdro any thoughts on this?

Sounds like a great idea.

I have reviewed the types on this companion module for react-native-maps module ...directions: https://github.com/bramus/react-native-maps-directions/blob/master/index.d.ts and they've merged my fix  there; this in part how I discovered the conflict.
If you guys are good with this, I can submit a PR, but I would hope it wasn't merged until I'm able to complete the PR to create the new @types/react-native-maps-directions module.
You should know that effort is pending the approval of another PR with @types:  https://github.com/DefinitelyTyped/DefinitelyTyped/pull/35274 - this due to effectively the same issue, because @types/styled-components contains a reference to the deprecated version of MapView types here:  https://github.com/methodbox/DefinitelyTyped/commit/78685600044ecee8d8bdc98426829affdf72ff0a

Just an update that a related PR has since been merged (react-native-maps-directions), another, which is a dependency on the change to @types/react-native (@types/styled-components) has been approved and pending merge.
Once that is complete I will reattempt the original PR for removal of these types from @types/react-native.
At that point I will create a new @types for react-native-maps.  Assuming that is approved, then would probably be the best time for the PR here.

FYI: all my checks just passed, so this will probably be merged into @types soon:
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/35239
I will submit the PR to remove the index.d.ts here as soon as I see it merged.
@rborn @christopherdro
I did not include attributions due to a potential conflict, but this can be updated after it's merged. Apparently, thought, the way the *.d.ts header works is this results in notifications on that repo when changes occur.
Let me know if you'd like me to attribute types to specific author(s) and I'll do a PR if needed once it's merged.

@methodbox honestly I don't really care about attribution. If that is a potential deal breaker I'd just publish without and then (if needed/people complaining/etc maybe try to fix it)
my 2c.
In other line of thoughts, will the new types package be made a dep of this one or how will people know they need to install it?
🤗

@rborn It’s merged now, so I can test how it works, which I’ve started doing, but I wouldn’t make changes here quite yet.
I think adding it as a devDep is best or you could add a npm warning but I think those suck and really should be for breaking deps.

@methodbox devDep I also think works the best, the easier for the user, the better 😊

@methodbox devDep I also think works the best, the easier for the user, the better 😊

Ok, well I've tested the new @types definitions which work fine (as they should since they're effectively identical to the ones here) in a number of projects I'm working on and test projects I created for this purpose.
I'm going to put in the PR then to add the devDependency and remove index.d.ts.
I'm reviewing if we also need to add "resolutions" to operate correctly per this:
https://github.com/DefinitelyTyped/DefinitelyTyped/issues/20350
If anyone has any insight on this, let me know. Testing this atm.

@rborn Sorry, I haven't published an NPM module before, so I'm a bit confused.
If I add @types/react-native-maps as a devDep, of course it will install for those working on this module, but it doesn't advise any user that it exists.
I could add it as a peerDependency but it's not explicitly required for the package.
Just want to be sure the route you want to take with this. I'm going to submit the PR with what we discussed already, and I guess I can add the peerDep if that's the way to go.

@methodbox nice job 😻
I'm not versed in this either, but I think that if it's added indevDependencies it will be installed with the package so the types will be available to the users. I'm afraid that if we add it to peerDependencies on install the users might get a warning but they won't bother to install and this will create a new rain of issues "types don't work"
@christopherdro @kelset can you guys please give us some little advice? 🤗

I don't have experience on this, sorry - but looking at react-navigation, it seems that they add it to devDeps -> https://github.com/react-navigation/react-navigation/blob/master/package.json

Will this require every consumer of rn-maps to also yarn add --dev @types/react-native-maps manually?

There's a discussion happening on the PR related to this issue: https://github.com/react-native-community/react-native-maps/pull/2877
I think I've explained how there's nothing to be gained from moving the types from here to @types/react-native-maps. DefinitelyTyped appears to recommend against this and even recommends deleting the DT module once types are added to the main repo. https://github.com/DefinitelyTyped/DefinitelyTyped#removing-a-package
The OP's original issue was simply related to the expo package and an error in how they re-export types from this library. It has nothing to do with react-native-maps and will not be solved by moving the types to @types/react-native-maps

There's a discussion happening on the PR related to this issue: #2877
I think I've explained how there's nothing to be gained from moving the types from here to @types/react-native-maps. DefinitelyTyped appears to recommend against this and even recommends deleting the DT module once types are added to the main repo. https://github.com/DefinitelyTyped/DefinitelyTyped#removing-a-package
The OP's original issue was simply related to the expo package and an error in how they re-export types from this library. It has nothing to do with react-native-maps and will not be solved by moving the types to @types/react-native-maps

It will actually be solved by doing this because Expo relies on this repo for their react-native-maps (version 0.24 will be in the next Expo release).
However, as you seem unwilling to back down on this, maybe you have a suggestion that also considers the testing that occurs with @types and Travis testing against (I dunno - hundreds?) of react-native-x modules?

It will actually be solved by doing this because Expo relies on this repo for their react-native-maps (version 0.24 will be in the next Expo release). But as I've already explained multiple times, this was tested, not just with Expo.

How expo imports the typedefs for react-native-maps, whether thats from react-native-maps/index.d.ts or @types/react-native-maps doesn't affect the order that they export it in.

@mcmar seems to keep stating it's just Expo, but I produced the error with plain 'ol React Native, too. Ultimately, this isn't up to me - it's up to the people who maintain this repo.

Dear maintainers: please do not merge the PR. It doesn't fix any issue and only makes life harder for developers who consume this library.

However, as you seem unwilling to back down on this, maybe you have a suggestion that also considers the testing that occurs with @types and Travis testing against (I dunno - hundreds?) of react-native-x modules?

The DefinitelyTyped repo just uses plain old dtslint for testing. We can use that too in this repo and it will do the exact same thing here that it does there. They don't test your modules "against other react-native-x modules" because there's no reason to. They're under separate module namespaces.

I want to clarify my suggestion here wasn't just to solve my problem - it was also to find a better long-term solution. Rather than attack any mistakes I may have made, maybe make a suggestion that fulfills that goal?

I'm not attacking you or your mistakes. There is no solution needed for this repo because there's no problem in this repo. The solution is to open an issue on the expo repo.

I tested this on my own with the old @types/react-native and react-native-maps. This is the exact setup that I've been using in a production app for several months with no conflicts.
I did not see any conflicts and in no case did it pull the types from @types/react-native when I do import { X } from 'react-native-maps';.
Typescript does not pull typedefs from the react-native module namespace when you do import { X } from 'react-native-maps';. They're under separate module namespaces. This is documented here: https://www.typescriptlang.org/docs/handbook/namespaces-and-modules.html

The DefinitelyTyped repo just uses plain old dtslint for testing. We can use that too in this repo and it will do the exact same thing here that it does there. They don't test your modules "against other react-native-x modules" because there's no reason to. They're under separate module namespaces.

This is incorrect. The Travis tests install a ton of modules (@types definitions for a slew of RN modules) and check for conflicts.
As I linked to in the PR, here is an example from my merged PR to remove the deprecated types: https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/534054337?utm_source=github_status&utm_medium=notification
I also want to restate some misinformation you've posted multiple times here: react-native-maps was separated into it's own module but MapView was deprectated long ago and removed from RN quite a while ago, too.
There's no reason those definitions needed to be in there. However, I think it's worth restating here (as in the PR - this is silly) that had the types for this module been in @types before any potential conflicts (like those in Expo, if we want to use that example we both agree on) would have been found.
As to what the solution would have been in that case, we can certainly debate but knowing the cause certainly would have been valuable.

Closing in favor of PR https://github.com/react-native-community/react-native-maps/pull/2877


Parable views not working for developers with Windows systems

Expected Behavior

A fresh installation of Parable on a Windows system should show the default view (View/Home/index.phtml).
Current Behavior

The default Parable view (View/Home/index.phtml) shows the following output:
<!DOCTYPE HTML>

        <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />

        <title>

Fatal error:  Uncaught ReflectionException: Class ParableC:\MAMP\htdocs\cgi_whereabouts_dashboard\vendor\devvoh\parable\src\Auth\Authentication does not exist in C:\MAMP\htdocs\cgi_whereabouts_dashboard\vendor\devvoh\parable\src\Framework\Toolkit.php:71
Stack trace:
#0 C:\MAMP\htdocs\cgi_whereabouts_dashboard\vendor\devvoh\parable\src\Framework\Toolkit.php(71): ReflectionClass->__construct('ParableC:\\MAMP\\...')
#1 C:\MAMP\htdocs\cgi_whereabouts_dashboard\vendor\devvoh\parable\src\Framework\Toolkit.php(90): Parable\Framework\Toolkit->loadResourceMap()
#2 C:\MAMP\htdocs\cgi_whereabouts_dashboard\vendor\devvoh\parable\src\Framework\View.php(123): Parable\Framework\Toolkit->getResourceMapping('Config')
#3 C:\MAMP\htdocs\cgi_whereabouts_dashboard\app\View\Home\index.phtml(7): Parable\Framework\View->__get('config')
#4 C:\MAMP\htdocs\cgi_whereabouts_dashboard\vendor\devvoh\parable\src\Framework\View.php(110): require('C:\\MAMP\\htdocs\\...')
#5 C:\MAMP\htdocs\cgi_whereabouts_dashboard\vendor\devvoh\parable\src\Framework\View.p in C:\MAMP\htdocs\cgi_whereabouts_dashboard\vendor\devvoh\parable\src\Framework\Toolkit.php on line 71

Possible Solution

Our temporary fix in Parable\Framework\Toolkit:
// $fullClassName = str_replace($this->path->getDir('vendor/devvoh/parable/src'), '', $file->getRealPath());
$fullClassName = str_replace($this->path->getDir('vendor\\devvoh\\parable\\src'), '', $file->getRealPath());

You might want to identify the development machine?
Context

As a Mac user I had to code the whole project all by myself.
My team members (Windows users) couldn't do anything for a very very long time, because Windows.
Joke.
Your Environment

Version used: Parable 0.8.14+
Environment name and version (e.g. Chrome 39, node.js 5.4): Chrome 54
Operating System and version (desktop or mobile): Windows 10 (x64)
Link to your project: -

Confirming. Have Windows machine,

Above is the error being thrown.

Alright, that's something to fix. Will look into it tonight!

0.8.18 fixes this - see 5b88477
I'm not currently able to verify the fix, but it should work. When the fix is verified I'll close this issue. If it doesn't work, first off - shame on me, second off, I'll have to set up a windows env to fix it on.
So let me know!

If this still doesn't work, let me know. For now I'm closing this :)


spinners in notebooks when executing the command and the output is still not ready

currently for notebooks on clicking the play button, the play button disappears while the command is getting executed and the output is not ready.
an enhancement to this behavior can be a spinner that is displayed while the command is getting executed but the output is still not ready.

Currently, I think notebooks never show spinners. We should change this so that we only avoid showing spinners for blocks that haven't be re-executed. The original intent was to avoid showing e.g. the duration of the original command when displaying the notebook author's pre-recorded output. But when the user of the notebook re-executes that command, I agree we should show spinners and duration.

Reopening to allow for full solution (actually add spinners, as requested!)

There are a number of bugs in this area. For example,

when editing and re-executing with a different command line, the command line transiently reverts to the initial command line, then pongs back to the updated command line when the re-execution completes.
no spinners at all for blocks being re-executed
also no duration count-up for blocks being re-executed
old Output continues to be shown while block is being re-executed


Adjust actions button class names to be more generic for re-use across other components

This allows the styles to be re-used in authenticator modules without re-using irrelevant BEM names like "select method tile".

Re-triggering Scrutinizer


(WIP)(GH-476)(GH-477) Add Bolt Feature Support

I don't think we need the Yaml language configuration or sytnax highlighting


implement backup/restore for persisted content

We have to backup editable env files and archive postgres DB content for all instances (postgres and iam as of now)

done and merged to master.
backup/restore better to verify in scope of global qps-infra backup/restore procedure

Verified on develop branch.


DFCxx -> SystemVerilog pipeline parametrization

Mentioned in #23 .
DFCxx now supports different output paths for different artifacts.
Now an output path for SystemVerilog has to be set explicitly (option --out <PATH>)

When applying this PR, I receive a segmentation fault upon the following usage of the tool:
build/src/umain hls --config examples/polynomial2/polynomial2.json -l

I mentioned this in the PR's description: Now an output path for SystemVerilog has to be set explicitly (option --out <PATH>).
I didn't include this in README.md, because this PR is intermediate and README.md will change in #22 .


Skip connection candidates that have no endpoint information

As we now no longer keep ENRs with no endpoint info (#1553),
this is just a safety net and I'm not that thrilled about
writing a test for it. Hope you'll forgive me ;-)

()&#$% EOFError


Dialogflow intent prompt message not set correctly

Environment details

OS: Windows 10 Pro
.NET version: .Net Core 2.1
Package name and version: Google.Cloud.Dialogflow.V2 1.0.0-beta02

Steps to reproduce

Define Intent with a required parameter and Prompt in case parameter is not provided
When calling method SessionsResource.DetectIntent the fulfillment text is not prompt defined in previous step, but rather weird text "What is the 'parameter_name' ?"

Example:
Dialogflow web console - try it now input (how it should work)
User: I would like to order t-shirt
Agent: Please specify color of t-shirt.
Dialogflow api
User: I would like to order t-shirt
Agent: What is the '@tshirt_size' ?

I'll look into this tomorrow. If you could give a concrete code example along with any other intent details that might be relevant, that would be really helpful.

Thank you for fast response, i will provide more detail tomorrow.

This is how we query for given fulfillment text
var service = new Google.Apis.Dialogflow.v2.DialogflowService(new Google.Apis.Services.BaseClientService.Initializer()
                {
                    HttpClientInitializer = GoogleCredential.FromJson(_dialogFlowSettings.Credentials ?? "").CreateScoped(Google.Apis.Dialogflow.v2.DialogflowService.Scope.CloudPlatform),
                    ApplicationName = "XXX"
                });

 var kb = service.Projects.Agent.Sessions.DetectIntent(getIntentRequestPayload(), $"projects/{_dialogFlowSettings.ProjectId}/agent/sessions/{conversationId.ToString()}");
 var response = kb.Execute();

This is response serialized to JSON from the given call
{
    "action": null,
    "allRequiredParamsPresent": null,
    "diagnosticInfo": null,
    "fulfillmentMessages": [
        {
            "basicCard": null,
            "card": null,
            "carouselSelect": null,
            "image": null,
            "linkOutSuggestion": null,
            "listSelect": null,
            "payload": null,
            "platform": null,
            "quickReplies": null,
            "simpleResponses": null,
            "suggestions": null,
            "text": {
                "text": [
                    "What is the geo-city?"
                ],
                "ETag": null
            },
            "ETag": null
        }
    ],
    "fulfillmentText": "What is the geo-city?",
    "intent": {
        "action": null,
        "defaultResponsePlatforms": null,
        "displayName": "faq.office.Location",
        "events": null,
        "followupIntentInfo": null,
        "inputContextNames": null,
        "isFallback": null,
        "messages": null,
        "mlDisabled": null,
        "name": "projects/newagent-cb210/agent/intents/b1e7080d-9faa-493f-b9ce-c07be16d7e41",
        "outputContexts": null,
        "parameters": null,
        "parentFollowupIntentName": null,
        "priority": null,
        "resetContexts": null,
        "rootFollowupIntentName": null,
        "trainingPhrases": null,
        "webhookState": null,
        "ETag": null
    },
    "intentDetectionConfidence": 0.58,
    "languageCode": "en-gb",
    "outputContexts": [
        {
            "lifespanCount": 2,
            "name": "projects/newagent-cb210/agent/sessions/cb6a18fe-c3b1-4c31-6146-08d6a3d67bfb/contexts/b1e7080d-9faa-493f-b9ce-c07be16d7e41_id_dialog_context",
            "parameters": {
                "geo-city.original": "",
                "geo-city": ""
            },
            "ETag": null
        },
        {
            "lifespanCount": 2,
            "name": "projects/newagent-cb210/agent/sessions/cb6a18fe-c3b1-4c31-6146-08d6a3d67bfb/contexts/faq_office_location_dialog_context",
            "parameters": {
                "geo-city.original": "",
                "geo-city": ""
            },
            "ETag": null
        },
        {
            "lifespanCount": 1,
            "name": "projects/newagent-cb210/agent/sessions/cb6a18fe-c3b1-4c31-6146-08d6a3d67bfb/contexts/faq_office_location_dialog_params_geo-city",
            "parameters": {
                "geo-city.original": "",
                "geo-city": ""
            },
            "ETag": null
        }
    ],
    "parameters": {
        "geo-city": ""
    },
    "queryText": "Where is your office located?",
    "speechRecognitionConfidence": null,
    "webhookPayload": null,
    "webhookSource": null,
    "ETag": null
}

This is diagnostic info form dialogflow web portal for given call. queryText property is same as in our API call but fulfillmentText property is correctly set to Prompt message.
{
    "responseId": "3f0cac07-f08c-4e51-888a-44a0df7f3946",
    "queryResult": {
      "queryText": "Where is your office located?",
      "parameters": {
        "geo-city": ""
      },
      "fulfillmentText": "Can you please specify a city where would you like to visit our office?",
      "fulfillmentMessages": [
        {
          "text": {
            "text": [
              "Can you please specify a city where would you like to visit our office?"
            ]
          }
        }
      ],
      "outputContexts": [
        {
          "name": "projects/newagent-cb210/agent/sessions/32fd00d0-f578-f5d5-6eb6-5360ff434ee8/contexts/b1e7080d-9faa-493f-b9ce-c07be16d7e41_id_dialog_context",
          "lifespanCount": 2,
          "parameters": {
            "geo-city.original": "",
            "geo-city": ""
          }
        },
        {
          "name": "projects/newagent-cb210/agent/sessions/32fd00d0-f578-f5d5-6eb6-5360ff434ee8/contexts/faq_office_location_dialog_context",
          "lifespanCount": 2,
          "parameters": {
            "geo-city": "",
            "geo-city.original": ""
          }
        },
        {
          "name": "projects/newagent-cb210/agent/sessions/32fd00d0-f578-f5d5-6eb6-5360ff434ee8/contexts/faq_office_location_dialog_params_geo-city",
          "lifespanCount": 1,
          "parameters": {
            "geo-city.original": "",
            "geo-city": ""
          }
        }
      ],
      "intent": {
        "name": "projects/newagent-cb210/agent/intents/b1e7080d-9faa-493f-b9ce-c07be16d7e41",
        "displayName": "faq.office.Location"
      },
      "intentDetectionConfidence": 0.67,
      "languageCode": "en"
    },
    "alternativeQueryResults": [
      {
        "queryText": "Where is your office located?",
        "outputContexts": [
          {
            "name": "projects/newagent-cb210/agent/sessions/32fd00d0-f578-f5d5-6eb6-5360ff434ee8/contexts/b1e7080d-9faa-493f-b9ce-c07be16d7e41_id_dialog_context",
            "lifespanCount": 2,
            "parameters": {
              "geo-city.original": "",
              "geo-city": ""
            }
          },
          {
            "name": "projects/newagent-cb210/agent/sessions/32fd00d0-f578-f5d5-6eb6-5360ff434ee8/contexts/faq_office_location_dialog_context",
            "lifespanCount": 2,
            "parameters": {
              "geo-city": "",
              "geo-city.original": ""
            }
          },
          {
            "name": "projects/newagent-cb210/agent/sessions/32fd00d0-f578-f5d5-6eb6-5360ff434ee8/contexts/faq_office_location_dialog_params_geo-city",
            "lifespanCount": 1,
            "parameters": {
              "geo-city": "",
              "geo-city.original": ""
            }
          }
        ],
        "languageCode": "en"
      }
    ]
  }

This is how intent is defined in dialogflow

That code doesn't use the Google.Cloud.Dialogflow.V2 package that was mentioned in the first comment - could you clarify which package you're actually using?
(Note that both libraries are entirely autogenerated, so I suspect this is an API issue rather than a library issue, but I still want to try to reproduce it...)

I've just tried to reproduce this (before seeing your geocity example):

I created an entity of shirtsize with values large, medium, small
I created an intent with a training phrase of "I would like to order a t-shirt"
I added a required with name tshirt_size, entity @shirtsize, value $tshirt_size, prompt "Please specify a T-shirt size"

I then tried the following code:
using Google.Cloud.Dialogflow.V2;
using System;

namespace Issue3009
{
    class Program
    {
        static void Main(string[] args)
        {
            string projectId = "...";
            var client = SessionsClient.Create();
            SessionName session = new SessionName(projectId, Guid.NewGuid().ToString().Replace("-", ""));
            var input = new QueryInput
            {
                Text = new TextInput
                {
                    LanguageCode = "en",
                    Text = "I would like to order a T-shirt"
                }
            };
            var response = client.DetectIntent(session, input);
            Console.WriteLine(response);
        }
    }
}

The output (formatted) was:
{
  "responseId":"cce850d1-d366-43e0-975c-14f750aec39d",
  "queryResult":{
    "queryText":"I would like to order a T-shirt",
    "parameters":{
      "tshirt_size":""
    },
    "fulfillmentText":"Please specify a T-shirt size",
    "fulfillmentMessages":[
      {
        "text":{
          "text":[
            "Please specify a T-shirt size"
          ]
        }
      }
    ],
    "outputContexts":[
      {
        "name":"projects/.../agent/sessions/50ec9f7eb9e34548b83f04cd255eb732/contexts/order_a_t-shirt_dialog_params_tshirt_size",
        "lifespanCount":1,
        "parameters":{
          "tshirt_size.original":"",
          "tshirt_size":""
        }
      },
      {
        "name":"projects/jonskeet-integration-tests/agent/sessions/50ec9f7eb9e34548b83f04cd255eb732/contexts/order_a_t-shirt_dialog_context",
        "lifespanCount":2,
        "parameters":{
          "tshirt_size.original":"",
          "tshirt_size":""
        }
      },
      {
        "name":"projects/.../agent/sessions/50ec9f7eb9e34548b83f04cd255eb732/contexts/5408aeb1-ddac-4d44-b4d5-0a4307a0767f_id_dialog_context",
        "lifespanCount":2,
        "parameters":{
          "tshirt_size.original":"",
          "tshirt_size":""
        }
      }
    ],
    "intent":{
      "name":"projects/.../agent/intents/5408aeb1-ddac-4d44-b4d5-0a4307a0767f",
      "displayName":"Order a t-shirt"
    },
    "intentDetectionConfidence":1,
    "languageCode":"en"
  }
}

That looks correct to me. I'll try following your repro now...

I've just tried it with your city example, and again it worked fine:
"fulfillmentText":"Can you specify a city where you would like to visit our office?",
    "fulfillmentMessages":[
      {
        "text":{
          "text":[
            "Can you specify a city where you would like to visit our office?"
          ]
        }
      }
    ],

Could you check that you're definitely ending up with the right intent? I wonder whether you've got an old intent somewhere that you're triggering, which has the wrong prompt.

Thank you for confirming that API is indeed working correctly. You are right we have reference to both Google.Apis.Dialogflow.v2 and Google.Cloud.Dialogflow.V2 and we are using Apis instead of Cloud. I will adapt the code.

Do you think it is correct approach to go from package "Google.Apis.Dialogflow.v2" to "Google.Cloud.Dialogflow.V2"
I see that last release of cloud package was 8 months ago, meanwhile development on apis package is still active.
Maybe it would be better if i reopen the issue for API package instead ?

It is even good for this libraries to coexist in one project ? maybe i am missing something important.
What is package is preferred to communicate with dialogflow ? or is there any documentation i could follow ?
Thank you,

While it shouldn't be a problem to use both packages in the same project, I'd personally recommend using the Google.Cloud.Dialogflow.V2 one - that uses new code generation which is simpler to use in my view. Although the package hasn't been updated in a while, that shouldn't be a problem unless there are things it doesn't support that you need. (We can do another beta release if necessary; the code in github reflects the latest V2 API in the googleapis repo.)
In terms of reporting an issue, it's definitely not worth reporting an issue in the repository for Google.Apis.Dialogflow.v2 until you've checked that it really is a client library problem - if you make the same request using API explorer you'll see the JSON that comes back; if that looks correct but the library shows the wrong thing, then that's a library problem, but otherwise it would be an API problem, and you'd probably want to check for issues in the Dialogflow issue tracker and raise a new one if necessary.

I tried suggested approach with comparing output of API explorer and my code that is using cloud package with same inputs.
Same thing is happening, the fulfillment text differs. This is how I call detectIntent method now
var query = new QueryInput
{
    Text = new TextInput
    {
        Text = "Where is your office located?",
        LanguageCode = "en-GB"
    }
};

var sessionId = "cb6a18fe-c3b1-4c31-6146-08d6a3d67bfb";
var projectId = "newagent-cb210";
var creds = GoogleCredential.FromJson(_dialogFlowSettings.Credentials ?? "").CreateScoped(
    Google.Apis.Dialogflow.v2.DialogflowService.Scope.CloudPlatform);
var channel = new Grpc.Core.Channel(SessionsClient.DefaultEndpoint.Host, creds.ToChannelCredentials());
var client = SessionsClient.Create(channel);

var response = client.DetectIntent(
    new SessionName(projectId, sessionId),
    query
);

channel.ShutdownAsync();

var serialized = _jsonService.Serialize(response.QueryResult);

Value of property "serialized" is
{
    "QueryText": "Where is your office located?",
    "LanguageCode": "en-gb",
    "SpeechRecognitionConfidence": 0.0,
    "Action": "",
    "Parameters": {
        "Fields": {
            "geo-city": {
                "NullValue": 0,
                "NumberValue": 0.0,
                "StringValue": "",
                "BoolValue": false,
                "StructValue": null,
                "ListValue": null,
                "KindCase": 3
            }
        }
    },
    "AllRequiredParamsPresent": false,
    "FulfillmentText": "What is the geo-city?",
    "FulfillmentMessages": [
        {
            "Text": {
                "Text_": [
                    "What is the geo-city?"
                ]
            },
            "Image": null,
            "QuickReplies": null,
            "Card": null,
            "Payload": null,
            "SimpleResponses": null,
            "BasicCard": null,
            "Suggestions": null,
            "LinkOutSuggestion": null,
            "ListSelect": null,
            "CarouselSelect": null,
            "Platform": 0,
            "MessageCase": 1
        }
    ],
    "WebhookSource": "",
    "WebhookPayload": null,
    "OutputContexts": [ ... ],
    "Intent": {
        "Name": "projects/newagent-cb210/agent/intents/b1e7080d-9faa-493f-b9ce-c07be16d7e41",
        "DisplayName": "faq.office.Location",
        "WebhookState": 0,
        "Priority": 0,
        "IsFallback": false,
        "MlDisabled": false,
        "InputContextNames": [],
        "Events": [],
        "TrainingPhrases": [],
        "Action": "",
        "OutputContexts": [],
        "ResetContexts": false,
        "Parameters": [],
        "Messages": [],
        "DefaultResponsePlatforms": [],
        "RootFollowupIntentName": "",
        "ParentFollowupIntentName": "",
        "FollowupIntentInfo": [],
        "IntentName": {
            "ProjectId": "newagent-cb210",
            "IntentId": "b1e7080d-9faa-493f-b9ce-c07be16d7e41",
            "Kind": 0
        }
    },
    "IntentDetectionConfidence": 1.0,
    "DiagnosticInfo": null
}

Cloud explorer
REQUEST:
POST https://dialogflow.googleapis.com/v2/projects/newagent-cb210/agent/sessions/cb6a18fe-c3b1-4c31-6146-08d6a3d67bfb:detectIntent?key={YOUR_API_KEY}

{
 "queryInput": {
  "text": {
   "text": "Where is your office located?\"",
   "languageCode": "en-GB\""
  }
 }
}

RESPONSE:

{
 "responseId": "d98f6c45-456a-474a-86c4-5bc5c39d5678",
 "queryResult": {
  "queryText": "Where is your office located?\"",
  "parameters": {
   "geo-city": ""
  },
  "fulfillmentText": "Can you please specify a city where would you like to visit our office?",
  "fulfillmentMessages": [
   {
    "text": {
     "text": [
      "Can you please specify a city where would you like to visit our office?"
     ]
    }
   }
  ],
.....................

Because you verified in your previous answer that detectIntent method works correctly, best bet is that I either

have misconfigured something but I can not figure out what...
my code is not correct, there are not much examples for given libary so i am not sure here as well.

OK, so the problem was that prompt was defined only for en language. So when i queried with LanguageCode = "en-GB" it returned weird "what is parameter_name"?" sentence.
HOWEVER, when i queried through API explorer with LanguageCode = "en-GB" it returned given prompt, even when it should not.

Excellent - I'm glad you got to the bottom of it :)


Bind RPC to localhost by default, add to sample config

Bind the RPC port to localhost by default so it is not potentially exposed to the public internet.
Add toplevel bind-address to the sample config because it was missing, and fix a couple typos in the config.

[x] Rebased/mergable
[x] Tests pass
[x] CHANGELOG.md updated

Actually, just realized this is the 8088 port and not the 8086 one.  This might be ok.

We should also reevaluate whether we need to use a separate port 8088 at some point, since it only handles backup and restore (I think).

Finally updated the changelog and rebased, @jwilder.


added support for AvailableFeatures API

added a very simple class based on your previous ones to interact with AvailableFeatures API https://docs.microsoft.com/en-us/rest/api/power-bi/availablefeatures.

cheers mate nice


Adding Magnum support to 'deploy.sh'

Adding Magnum support to 'deploy.sh'. This code is NOT idempotent.
Connects #1574
Formerly  #1573

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

recheck_all
I think this is looking okay so far. I'll read through the code and provide some feedback inline

test please

test this please

test this please

ok to test

recheck_ceph

add to whitelist

recheck_all

"ok to test"

ok to test

Closing because tests.


Refactor provider user permissions forms

Context
There was a bug on the provider user invitation wizard whereby the error summary did not link to the correct place.
There is lots of duplication between the wizard there and in the single provider user permission editing form.
Changes proposed in this pull request
Move the edit provider user permission form to use fields_for
Move the wizard so it uses the same form html and ruby model
This commonises the erb and the validations
To test:
In the review app:
Invite a new provider user (Your account > Users > Invite User). Go through the flow and ensure checking different things has the desired effect.
Edit a provider user's permissions. Go to Your account> Users > click a user > click Change next to one of their permissions for a provider. Make sure that checking different boxes and submitting has the desired effect
Guidance to review
Per commit
Are there any edge cases I've missed from the specs?
(Note that this should result in no change in behaviour apart from that the error is correctly linked to when selecting "Extra permissions" and then not checking any boxes)
Link to Trello card
https://trello.com/c/EW62DVmA/3421-dac-change-no-errors-when-selecting-permissions
Things to check

[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

This is because we removed the view_applications_only attribute from the wizard, but the last saved state for a user is restoring this value. Is this something we should worry about or do we usually reset the states on deploy?
That's a good spot, I don't think we do clear the caches on deploy.

I think the easiest way around that is to change the cache key to ensure the old caches are not loaded


Dynamic change router view with function/condition

I want to change the view after a condition match (function):
base route -> /home
In "/home" i want to select a view after a condition. This is currently not possible, right?
It's only possible to define a view component for a route. Or should one solve this differently?

You should either redirect from your home route, or put a dynamic component in your home route's view.

Thanks. I don't know what you exactly mean. The "router.redirect" is static. The route's view is already dynamic. Or do you mean a dynamic view in a dynamic view?

Correct. A dynamic component in the dynamic view.
As for redirecting: I meant to use the router.go() method to send the user to a different route.

Ok, but when I had defined a route I can't call router.go(). It only switch the component:
router.map({
    '/r1': {
      component: 'view1'
    },

Where you mean can one insert the go() method? With click-event? I don't want do use it.

I'm not sure this is a part of it:
https://github.com/vuejs/vue-router/blob/master/example/routes.js#L64
It should be possible to hook a route to make a decision with application state?

I restructed my code and solved it differently. @JosephSilber thanks anyway.


FAQ improvements

Several edits to the FAQs, mostly minor, a few not. Includes bmoconno's edit, which I'd missed.

:+1: well done


[Feature Request] Move to Tauri framework

Electron framework is notorious for consuming too much resources, especially RAM. As an app that will run in background all the time, Muezzin shouldn't increase ram usage. And looks like you are aware of the issue, the existence of Salawat app is its proof. Aside to that, constantly moving to a newer Electron build is a hassle.
So, my suggestion is to move Muezzin to Tauri from Electron. It's lighter, faster and way less complicated than Electron; which is showing its age like an old beat up car.
Hope you consider.

Here are a few resources on migration to Tauri.

https://www.umlboard.com/blog/moving-from-electron-to-tauri-1/
https://umlboard.com/blog/moving-from-electron-to-tauri-2/
https://www.youtube.com/watch?v=fMTtMRLUnIY

Hope you find these helpful.


feat(examples): add VueJS 2.0 example with checkboxes.

Add basic VueJS components for Checkbox, CheckboxLabel,
and CheckboxWrapper.
Add a simple app that shows usage, binding props, events, etc.

Wow! You rock! Thanks so much for taking the time to put this together. LGTM

Holy 🐮 , this is amazing, @petejohanson! Thanks so much for putting this together!
I'd love to hear if you had any problems with either the docs or the code, or any suggestions you might have. We didn't really expect anyone digging in as deep as this before alpha :D
LGTM for merge :)

In general, the object composition approach seems nice to me. Having the default adapter as an 'API guide ' was nice, but obviously some more docs on the adapter APIs as V2 matures will be beneficial.
I really want to work on updating this with the latest VueJS 2.0 SSR integration, since that is the one area that isn't clear yet to me what tweaks to the current code would be needed (and seems like with the nice V2 design here will work, once done right).
Looking forward to seeing this progress!

Thanks for the comments, @petejohanson!
Yep, we definitely have plans to document things a bit more thoroughly. @traviskaufman has given it a good start on this thread, but we need to move it somewhere less ephemeral.
I'm really looking forward to your future experiments!


sizeer

hi, it will take 48 hours. I will complete it on 07-12-24.

https://vercel.com/ali-razas-projects-bdba9888/sizeer-6d2w
hi check it


include ssm-agent by default in the image

Will this new AMI include ssm-agent package by default? I see from the files in this repo that you're currently including the newer EC2 Instance Connect but nothing on ssm-agent. Will there be a choice to choose which one?
I'm coming from this issue: https://github.com/NixOS/nixpkgs/issues/222637

So for initial release I am just uploading the existing  image  build from Hydra as is.  This will neither contain SSM-agent nor EC2 Instance Connect.
The NixOS configurations in this repo are NOT being used by the upload process yet  at the moment.  I'll try to make this clear in the README as it's a bit confusing.
However I am planning to move to the image builder in this repo and I want to have  both EIC and ssm-agent support.

noted. thank you for the reply.

The 24.05 AMIs contain ssm-agent


Dev/ros tcp plugin test

Depends on #36.

Adds the ROS-TCP-Connector Unity package and ROS-TCP-Endpoint ROS node.
Replaces manual TCP sockets with ROS-TCP-Connector publishers/subscriptions on the headset.
Adds ros/cpp/src/image_converter node to convert NV12 images published by the headset to RGB8 images.
Restructures the ros/cpp and ros/python packages. ros/cpp/src/ptg_datahub moved to ros/angel_datahub and ros/python/py_pubsub moved to ros/angel_system_nodes.

Notes:

ros/ROS-TCP-Endpoint is copied from https://github.com/Unity-Technologies/ROS-TCP-Endpoint. Wasn't sure if that should be a submodule or if just copying the files directly is OK.
Did not update the audio or research mode TCP connections, since they aren't being used yet. They are disabled for now.

Unless we are modifying the ROS-TCP-Endpoint repo, it might be more appropriate to use a git submodule instead of copying all files.

The First time build/deploy instructions in the README.md should probably be updated for the additional steps this (transpiling the message files). I'm currently debating internally the inclusion of transpiled message files.

I found a couple parts of the angel_debug package that need updating when attempting a fresh build:

ros/angel_debug/package.xml still has a reference to py_pubsub
ros/angel_debug/launch/offline_debug_demo.py and ros/angel_debug/launch/online_debug_demo.py still have references to py_pubsub. We don't currently use these, so a valid response may be to just remove them, since at this point we have actualized on the tmuxinator stuff.

Unless we are modifying the ROS-TCP-Endpoint repo, it might be more appropriate to use a git submodule instead of copying all files.

Went ahead and made it a submodule. I switched it to the main-ros2 branch on my machine but unsure of if it will be on that branch or the main branch when you checkout the code.

After performing a git submodule update --init --recursive, the checkout ros/ROS-TCP-Endpoint/ was on branch ROS2v0.7.0 which I think is the correct state.

@Purg, I cleaned up the git history a bit so the copy of ROS-TCP-Endpoint should be gone. Let me know if that looks OK.


Lifecycle hook to modify / upgrade data.

It would be nice to have a way to hook into the persisted store to upgrade data when it's first read from the store / synced across tabs. Providing a new serializer really doesn't work for this use case.
For example, let's say I have persisted('test', [defaults]).. And I upgrade or add additional defaults in my code. I want to ensure the data always contains the default data; I'd expect to be able to pass a func to apply on top of the parsed data. But I only need to migrate this once. It doesn't make sense to do this more than once via a subscribe.
I guess one alternative is to just do the action immediately, but this doesn't help if the store is modified across tabs. One could also version the key and upgrade the old but doesn't really scale unless you scan a ton of keys. What are your thoughts?

Hi @niemyjski,
Yes, migration is something that would be good to support, provided their is a clean way.
I agree that syncing across tabs complicates things, as you can have different versions of the code running in each tab.
I believe this means versioning the key name would be best.
One way is to a version number as an option and support migration functions:
// default is version 1
persisted('myKey', initial, { version: 1 })

Then later, if you want to create a new version:
// default is version 1
persisted('myKey', initial, {
  version: 2,
  migrate: {
    2: (state) => {
      // add state
      state.newField = 123

      // remove state
      delete state.oldField

      // update state
      state.otherField = computeNewValue(state)

      return state
   }
  }
})

But the version metadata would need to be stored somewhere, not sure if it's safe to mutate the existing local storage data, for example by adding a new field __version. Or a maybe version metadata could be a stored under a separate local storage key?

Also, this would take lot of work to do, and it's not something I personally need right now. So the work would probably need to be sponsored.

Hello, @joshnuss.  This is the same I asked some time ago:  I called it a validator function, exactly for upgrade scenarios.  It would be a callback to the function specified by the consumer of the package.  The end "initial result" would be the return of the function.
If you approve, I can make this.  We would proceed to discuss the design, then I'll code and PR.  Let me know.  Thanks.

Thanks Jose!
Can you share some examples of API your thinking about, just so we're on the same page.
I'm all for this provided it's simple.

I've been thinking on this for the past two days and I agree. I think we should just provide a simple function that gets the value before it's returned. Then it can do anything, and it can be responsible for versioning and upgrading etc.. We keep this library really simple. I think only a post hook is needed because I feel like you should implement your own serializer if you need a pre hook. Only question I have is if we should provide some kind of context with options and storage value. I'd almost say no.

Also thinking on key versioning. Perhaps if you had an alias list/pattern of old keys, one could fall back to that if the current key isn't available, and you could call this function with that (with one or more values matching key/key patterns) and it could be responsible for returning the correct value. This may need to be a pre serialization decision BUT I feel like it's out of scope of this issue and can be solved in other ways outside of this lib.

This is how I'm going to be using this function we build (to ensure default filters are always present)
https://github.com/exceptionless/Exceptionless/blob/b5591a5d1fb10bbf9d10dd78f72568e12142893b/src/Exceptionless.Web/ClientApp/src/routes/(app)/issues/%2Bpage.svelte#L33-L35

I think we should just provide a simple function that gets the value and returns a value before the writable is returned

That makes sense, @webJose thoughts? Does this cover what you were thinking too?
So does API like this make sense?
writable('myKey', initial, {
  preprocess(value) {
    // to add new default
    value.newField = ...

    // to modify
    value.existing = f(value.existing)

    // to remove a field
    delete value.deprecatedField

    // return value
    return value
  }
})

I think only a post hook is needed because I feel like you should implement your own serializer if you need a pre hook

Though serializer should be about format, ie returning a string.
I like the "orthoginalness" of have a preprocess/postprocess
For example, adding a version before writing:
writable('myKey', initial, {
  postprocess(value) {
    value.version = 41

    return value
  },
  preprocess(value) {
    if (value.version == 40) {
      // do migration
    }
    return value
  }
})

Feel free to suggest different names and/or disagree of course 😅

Hello, everyone.  I'll explain my original motivation back then and my idea.
The problem I envisioned was related to data changes through the course of time.  Example:  Value is an object like { optA: true }.  So optA has 2 choices.  Over time, the application grows and there are now more options to cover.  So now optA is upgraded to string to use an enumeration of string values.  The problem, you probably guessed, is existing users having the Boolean version.  The solution:  The persisted() function accepts as option a function.  This function, written by the consumer of the library (us developers), take the deserialized value as input, validates it in any way, shape or form needed (for example, upgrading the Boolean value of optA to the new string value), and returns the result.  This result is immediately written to the store and is immediately returned to subscribers.
That's it.  No concept of version key or anything.  This is why I called it a "validation function".  Perhaps a better name is a "normalizer function" because it is allowed to mutate the data.

@webJose the API I proposed above, doesn't require a version number. So it should handle the scenario you've outlined.
I think the name validator sounds a bit too specific, because the function can validate or mutate or replace.

Agree 100% that a migration function is not the way to go. Migration is fundamentally a different challenge than what this library is designed for, and is better left up to a proper migration layer.
With that said though a post-processing function would be awesome! (and it's actually currently something I abuse the serialization functionality to accomplish - specifically for migration). I do not however see what use a pre-processing functionality would be of? In my mind, serialization should always be the first step (as this is the steps we take to transform the data into something we can work with), and the only thing that should come before serialization should be some kind of formatting of the input to enable proper serialization, which in my mind would be a serialization step.
I also think that we should rethink the naming scheme a little bit. Both because I don't believe a pre-processing function is necessary (in which case we don't need the otherwise nicely "orthoginal" naming, and because post-processing (in my mind at least) could mean a lot of things besides step between serialization and data-loading.
If we can agree on something here, I would love to write up a proper PR with tests.

So was working on this PR (using the names preRead and preWrite to be consistent with the error handler naming), but noticed something weird in the codebase. The store is set up such that if the storage event is fired, but the event.newValue is null, the store contents is set to null. I think this is a really bad idea for a couple of reasons:

It doesn't align with user expectations. Neither the documentation nor the type systems (which I have no clue why they don't complain) even indicate that the store that a potential user is depending on could suddenly change content type to null, which - I could imagine - could potentially break applications.
I do not see the use of this. First of, users of this library seems unlikely to interact directly with the local storage api (as they are using this library to avoid that) and as such this functionality seems like something that can only cause confusion. Secondly, I just don't see the reason for doing this instead of just setting the store to null.
If the intention with this was to solve a problem like https://github.com/joshnuss/svelte-persisted-store/issues/217, then I really think we should add a specific method for doing this.

Unless I missed something @joshnuss, I propose that I remove this functionality in the coming PR aimed at this issue, and then we can add in a more though-through and most importantly type-compliant version of it later if needed.

Thanks @bertmad3400
For the naming: what do you think about beforeRead and beforeWrite?
About the null check, could it be to check for undefined? It might be a type thing

Everything in here should be addressed by https://github.com/joshnuss/svelte-persisted-store/pull/250.

#250 has been merged, so there is now a beforeRead() & beforeWrite() which is designed to handle upgrading/migrating shape of state.


Fix expiring keys in tests

Some keys used for testing had expiration date. This PR is a result of using current date of year 2055 and running the tests, and then fixing all failures by making them use now argument wherever needed with the date when keys are still valid. The dates were determined by git blame.
By-products of that are fixes to few code-paths where now argument was not properly respected or not there at all:

clear/detached signatures verification/signing
import and unlock p3skb (although it supported time_travel)
merge_pgp_private - but it's not tested enough

thank you doing this! seems like all the keys expired at the same time

It was just a few that were expiring yesterday, but I went ahead and fixed all of them by making unix_timestamp return date far ahead

ok thank you!

Thank you for +1, I'll have a fresh look tomorrow or day after to make sure it doesn't break anything and then merge.


GH-2051 Update javalin-swagger-plugin to version 6.0.1

Tested on my local and remote reposilite instance. 😃

Thanks!


Adding basic package manager

I figured since this package manager exists, we might as well use it to help standardize our package building process.  Note that this makes NO CHANGES to our stance on how packages are presented to the user.  All it does is give us a big button we can use to build our packages automatically :)
I'd still like a number of eyes on this though, just to be sure
To test:

[ ] Make sure you can still build EXE's and that there are no errors
[ ] Make sure that the build menu appears up in the menu bar and allows you to build packages
[ ] Make sure you can build all packages.  The first time you build it will prompt you to select a build destination for each package.
[ ] Make sure you are able to build a single package by the build menu
[ ] Make sure you are able to build a single package via the build button on the package itself
[ ] Make sure you are able to create new packages, and that the inspector interface functions as expected
[ ] Make sure that the dependencies defined by the packages are correct

Does the package manager belong in the LeapMotionModules folder or in the root Assets folder?

I guess it could go in either location, but I like to think of it still as a module of functionality that could theoretically be exported to other locations (even though I'm guessing we won't have any plans to release this)

Building InteractionEngine as a module worked and I assumed everything was fine, but I noticed the .unitypackage failed to contain IE.ldat (which was specified as a dependency in the package), so the resulting IE Example project (+ Core module) didn't work and the unitymodule would have been a dud. I think this is bad behavior for a magic button, so I propose that if any files don't exist that are marked as dependencies, it should fail to build the unitypackage and raise a red Error message in the Console.

Nice catch!  I added in a check, if any dependent files are missing, it will pop up an error to alert the user and it will fail to produce a .unitypackage.  I opted for a popup-dialog instead of a console error to make it more visible to the user that something bad has happened.  If the user didn't notice that a build failed, they might go to the build folder like normal and use an old build.

Alright, ran it through its paces here.  Merging.


Typos fixed in index.md [spanish]

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

This PR still needs to be reviewed by a translation mod.

Congrats @AldoGatica123 on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


Have scheduled flow's job diabled/enabled status be picked up by next execution.

When manually start a flow, the initial job disabled/enabled state ( if a job is disabled or not ) should come from the last ( and only ) schedule of the flow if any modification to job states are made. The current behavior is that the initial state will be the state when the flow is uploaded. However when a job state is changed in a manual execution, the state is not persisted.

@kunkun-tang updated

I don't see an automated test included. Is it possible to do?


chore: update wa-lang logo

Pre-submission checklist:
Due to the incorrect display of wa-lang's logo in landscape, it was found that there was a missing SVG attribute during troubleshooting, so the wa-lang logo was updated.
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you added your SVG to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[x] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[x] ~30 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

LGTM

LGTM

LGTM


feat(entity-store): track entity id updates

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/datorama/akita/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?
Add rxjs operator to track entity id updates and automatically re-evaluate the query.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Let's also add it to the QueryConfig as optional. Most of the users will not need it so we can make the functionality lazy.
trackEntityIdChanges: boolean

If no one uses this operator, then there are no subscribers to the entityIdChanges$ observable and thus is pretty lazy without explicitly disabling functionality through the config.

You're right; it'll anyway only run if someone changes the id.

Added a first draft for the docs.


color attribute for FloatingActionButton conflicts with an attribute defined in android.support.v7.appcompat

I suggest renaming color to colorBackground.

Just rename the color attribute to whatever else, alse make sure to rename the FloatingActionButton_color in FloatingActionButton class. That was my solution.

That fixes the problem. You might want to consider changing it in the
future.
On Jan 14, 2015 12:11 PM, "Aimen7"<EMAIL_ADDRESS>wrote:

Just rename the color attribute to whatever else, alse make sure to rename
the FloatingActionButton_color in FloatingActionButton class. That was my
solution.
—
Reply to this email directly or view it on GitHub
https://github.com/FaizMalkani/FloatingActionButton/issues/26#issuecomment-69951999
.

Agreed with bvr, every other person using the library shouldn't have to always change it in their own copy. FAB as a library right now doesn't play nice with the compatibility lib.


Maintenance: Add unit test coverage

Summary
Add unit test coverage to get a better visibility on where we can have issues, and improve the coverage where needed.
Why is this needed?
Lambda Powertools for Java has a decent amount of unit tests but we don't have a clear view on what is well-tested and more important where we can improve. Having the coverage reports will help driving the effort and make sure we minimize the risk of issues.
Which area does this relate to?
Tests
Solution
We could use one of the standard frameworks (Jacoco, Cobertura) and deploy the reports to codecov.io just like the Python version does (see https://github.com/awslabs/aws-lambda-powertools-python/blob/79e7b4392a1a0f69bcf627b137c81be45867c587/.github/workflows/python_build.yml#L55)
Acknowledgment

[X] This request meets Lambda Powertools Tenets
[X] Should this be considered in other Lambda Powertools languages? i.e. Python, TypeScript

The powertools for python dashboard

closed with #1094


docs: Install with conan doc pages

Documentation for conan support.

Added conan install documentation and modified section to include it.

Documentation change checklist

[ X] My documentation changes follow the docs style guide and any code examples follow the coding style guide.
[X] I tested that my change works before raising the PR (via running doxygen, and testing examples).
[X] I have not moved any existing pages or changed any existing URLs without strong justification as to why.
[X] I have not generated content using AI or a desktop utility such as grammarly.

reopened and targeted at dev

Renamed PR to correctly align with our conventions

Renamed this PR to correctly align with our conventions.


Add support to Adaptiope dataset for cross domain ssl

What does this PR do?
This pull request adds support to Adaptiope [^fn2] dataset, in order to train and evaluate semi-supervised learning algorithms in a scenario where labeled and unlabeled data belong to different data distributions.
This SSL scenario is known to be challenging since "When the distributions of labeled and unlabeled data do not belong to the same one [...], the more unlabeled data is utilized, the worse the performance will be." (Yang et al, 2021)[^fn1].
Adaptiope is a domain adaptation dataset for image classification composed of three domains (product images, real life images, and synthetic renders). For each domain, there are 123 classes with 100 samples per class.
I do not have enough computational resources to perform extensive experiments, however, I managed to perform some preliminary ones with the configs added in this pull request. These result are purely indicative since I didn't perform any hyperparameter search and trained for very few iterations.
More specifically, I finetuned a pre-trained ViT Small for 20480 iterations with 615 labels (5% supervision) on product domain as supervised set and 12300 unlabeled samples from real life domain.

Method
Accuracy

Supervised lower bound (615 labels)
78.17 %

Fully Supervised upper bound (9840 labels)
93.01%

FixMatch
78.78 %

ReMixMatch
87.24 %

From these results we can notice that ReMixMatch does not suffer the domain shift, probably thanks to the distribution alignment module on the guessed labels, while FixMatch is not able to exploit the unlabeled data to increase its accuracy over the baseline.
More research is needed in SSL scenario, so I think it could be useful to integrate this feature in the USB  benchmarking library.
[^fn1]: Yang, X., Song, Z., King, I., & Xu, Z.. (2021). A Survey on Deep Semi-supervised Learning.
[^fn2]: Ringwald, T., & Stiefelhagen, R. (2021). Adaptiope: A Modern Benchmark for Unsupervised Domain Adaptation. In Proceedings of the IEEE/CVF Winter Conference on Applications of Computer Vision (WACV) (pp. 101-110).
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you list all the breaking changes introduced by this pull request?

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

@microsoft-github-policy-service agree

Hello, thanks a lot for your PR. We will have an update recently (For imbalanced SSL, Classical settings with training logs, etc.). After that, we will check your code and rerun it for providing training logs. If you have any suggestion/question, feel free to contact.

@Momofil31 Thanks for this PR! Since the change is related to domain adaption and we will be working on openset ssl algorithms and other robust semi-supervised learning perspectives for the next update, this PR will be updated and merged after we decide the whole pipeline.


FF 73 override services.settings.server pref

Almost 1.5 years ago, with the release of the new version, I noticed that firefox connects one time every 24 hours with firefox.settings.services.mozilla.com. Not finding then a solution to the problem, I just disabled it globally with killswitch user_pref("services.settings.server", "");. But today I realized that it doesn’t work anymore. Mozilla set me up again. I "play" with every new prefs from https://github.com/ghacksuserjs/ghacks-user.js/issues/883, but it did not help. What's going on? Why killswitch not work anymore? When they stop taking control from users?
Step to reproduce:
1: Open about:config
2: Find services.settings.server pref and remove everything.
3: Find app.update.lastUpdateTime.services-settings-poll-changes and remove everything. This is pref where the time of the last connection attempt is marked (in order not to wait 24 hours).
4: Close browser and open again.
5: After 30 sec. there will be an attempt to connect to firefox.settings.services.mozilla.com
I need to disable this. What do you advise?

The ghacks user.js does not have the pref services.settings.server in it, as it is not a privacy, security or fingerprinting issue. If you want to disable update checks, then use Enterprise Policies

Are you kidding? The browser "calls home" for no reason, but you don't care? OMG.
Update check disabled long time ago.

Prove to me that there is a privacy, tracking, security or fingerprinting issue instead of just seeing things in black and white

@Asukaromba you are overreacting without any proof.
Did you do any analysis of that traffic or you are grunting "just in case"?
I am even against telemetry, since it helps to improve the product (FF in this case).

They lock it:
https://bugzilla.mozilla.org/show_bug.cgi?id=1598562


v0.0.6

Change location of the downloaded debugger
Location of the download version of the debugger will be inside of $HOME/daffodil-debug

If the folder $HOME/daffodil-debug does not exist it will be created

This works for both Mac and Windows, should work for Linux since it does on Mac but I didn't get to test that one.

NOTE: If a different directory is preferred I can try to edit that for the best directory. Unless it would be preferred to create a flag that can be set for where the files will get stored, when not set if just defaults $HOME/daffodil-debug
closes #5

Take a look at os.tmpdir mentioned here https://github.com/jw3/example-daffodil-vscode/issues/5#issuecomment-854226040 and see if it makes things cleaner.
The trend is to keep things out of $HOME and put them under another dir, such as $HOME/.local on linux, to prevent pollution of $HOME.  Not critical for this PR, as this is an improvement over keeping them in the project dir, but worth taking a look at.

Take a look at os.tmpdir mentioned here #5 (comment) and see if it makes things cleaner.

D'oh! You cant use /tmp or you will lose the installation dir on reboot.

How about https://www.npmjs.com/package/xdg-app-paths or similar?

Download the artifact to os.tmpdir and then unpack to the xdg data-dir?

The root path is /home/wassj/.local/share/bootstrap-fork/daffodil-debugger-0.0.5/
Looks like you need to set Options.name...

Looks better ~/.local/share/dapodil/daffodil-debugger-0.0.5/


[Improve] [Engine] Enables engine to configure GC parameters Xms and Xmx

Purpose of this pull request
https://github.com/apache/incubator-seatunnel/issues/3155
Enables engine to configure GC parameters Xms and Xmx
Start the engine directly and view the heap using jmap：

Configure Xms and Xmx for seatunnel-env.sh：

Start the engine again and view the heap using jmap

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

How about use $@ to instead of it? Currently only heap memory size can be set, other jvm parameters are not supported, such as garbage collection. CC @Hisoka-X

How about use $@ to instead of it? Currently only heap memory size can be set, other jvm parameters are not supported, such as garbage collection. CC @Hisoka-X

Yes, not only heap memory size, we should can use it to set any jvm parameter.

How about use $@ to instead of it? Currently only heap memory size can be set, other jvm parameters are not supported, such as garbage collection. CC @Hisoka-X

Yes, not only heap memory size, we should can use it to set any jvm parameter.

Thanks.I have modified the code and can set all gc parameters via JvmOption.

You should support config parameters in seatunne-env.sh too. Thanks!

You should support config parameters in seatunnel-env.sh too. Thanks!

Thanks for your advice,i have fixed it.
set JvmOption in seatunnel-env.sh config:

command input:

Start the engine and view the heap using jmap:

@Hisoka-X @EricJoy2048 @TyrantLucifer PTAL


Delivery service request can be assigned to a user of different tenancy

I'm submitting a ...

[X] bug report
[ ] new feature / enhancement request
[ ] improvement request (usability, performance, tech debt, etc.)
[ ] other

Traffic Control components affected ...

[ ] CDN in a Box
[ ] Documentation
[ ] Grove
[ ] Traffic Control Client
[ ] Traffic Monitor
[X] Traffic Ops
[ ] Traffic Ops ORT
[ ] Traffic Portal
[ ] Traffic Router
[ ] Traffic Stats
[ ] Traffic Vault
[ ] unknown

Current behavior:

A PUT request to deliveryservice_requests/{{id}}/assign can be assigned to a user with different tenancy than the user which originally created the request.
Where Request Body contains:
{
    "assigneeId": {{id}}
}

And the assigneeId is the Id of a user with different tenancy than the creator of the delivery service request.
Returns:
HTTP/1.1 200 OK
{
    "alerts": [
        {
            "text": "deliveryservice_request was updated.",
            "level": "success"
        }
    ],
   "response": {
          .
          .
          .
   "status": "submitted"
   }
}

Expected / new behavior:

Should not be able to assign to a user with a different tenancy.
Minimal reproduction of the problem with instructions:

Anything else:

According to the documentation here: https://traffic-control-cdn.readthedocs.io/en/latest/admin/quick_howto/ds_requests.html
Assignment is currently limited to current user. This is optional as fulfillment will auto-assign the request to the user doing the fulfillment.
Which works on Traffic Portal, but the API allows for ANY user to be assigned.

A DSR wraps a DS. That DS has a tenant. Let's imagine the following tenant tree:

root
-- tenant 1
--- tenant 1.1
-- tenant 2
--- tenant 2.2

If the DSR is for DS A and DS A belongs to tenant 1.1, then the DSR can be only be assigned to users that belong to tenant 1.1 or higher (tenant 1 and root).
This bug allows the DSR to be assigned to tenant 2 or tenant 2.2.
This is problematic because you can assign DSRs to users and they won't be able to see that DSR due to tenancy.

Duplicate of #4167


Design data processing in qubrabench

We should define how we want to include the relevant benchmarks for each example problem.
One could for example provide data read folders that contain prominent SAT instances found in research and industry benchmarks.
This would be instead of generating random instances, which for some problems are insufficient in capturing the complexity of a problem. For instance, the hardest SAT problems for current solvers do not necessarily get harder to solve by increasing the number of literals or clauses.
This will likely be an issue for the high-level users of qubrabench that want to see a quantum speedup factor for their problem instances.

I don't currently see this as part of qubrabench core.

usecase dependent, not part of core.


Hand Pose Sequence has very low quality.

Hi, I tried to visualize the provided hand pose, the quality of MANO Sequence is in very low quality an can barely be used. Here is some visualizations I managed to get. Can you check and let me know whether this is expected from the fitting result of the paper?
ZY20210800002/H2/C4/N10/S105/s02/T1
do you have some visualization on some sequence you get for validating the visualization of the same result?

I also face this issue in multiple video sequences. The 3D hand mesh GTs seem to be very jittery and inaccurate.


[HANDS-ON BUG] Unit 6: Issue with push_to_hub

In Unit 6, I trained and evaluated the A2C model for the AntBulletEnv and everything looked good. However, when I try to push my model to the hub I get the following error: AssertionError: The render_mode must be 'rgb_array', not None
Here is the link for my notebook. I appreciate it if you could help.

Same problem here! =/

+1

Experienced the same issue, but I can work it around by add a line of code before push_to_hub:
eval_env.render_mode='rgb_array'
Hope it help.


Refactor ActivitiesHandlerMixin

Problem
Right now, for every service using the ActivitiesHandlerMixin, a matching is made for all activities received or sent. The more services are doing this, the worst the performance become.
Solution
Create a ActivitiesWatcherService which is activated by default with the ActivityPub service.
This service as a watch action which takes a matcher (object or function), an actionName and a key.
On start, the ActivitiesHandlerMixin calls the watch function for all defined activities. The actionName is a processActivity action of this mixin.
The process action receives a key, a boxType (inbox/outbox), a dereferencedActivity and actorUri.
It thens calls the onEmit and onReceive methods of the corresponding activity.

Ideas:

Add a priority parameter
Sort matchers by number of levels
When comparing an activity between matchers, remember derefenced items
Later: use JSON Schema and AVJ to match more complex activities without needing functions

Done here #1240 but performances could be improved


HttpError: You have exceeded a secondary rate limit. Please wait a few minutes before you try again.

Action is failing consistently for the past few weeks, regardless of when it's ran or what other tasks are ongoing.
Skipping recent artifact (id: 216039564, name: uberjar).
Error: HttpError: You have exceeded a secondary rate limit. Please wait a few minutes before you try again.
(node:1556) UnhandledPromiseRejectionWarning: HttpError: You have exceeded a secondary rate limit. Please wait a few minutes before you try again.
    at /home/runner/work/_actions/c-hive/gha-remove-artifacts/v1/dist/index.js:11413:23
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Job.doExecute (/home/runner/work/_actions/c-hive/gha-remove-artifacts/v1/dist/index.js:14169:18)

The specific workflow we're using:
name: Remove old artifacts
on:
  schedule:
    - cron: '0 22 * * *'
jobs:
  remove-old-artifacts:
    runs-on: ubuntu-latest
    timeout-minutes: 10

    steps:
      - name: Remove old artifacts
        uses: c-hive/gha-remove-artifacts@v1
        with:
          age: '1 day'
          skip-tags: true
          skip-recent: 5

Perhaps there has been a change to secondary rate limits?

Having this issue, a year later. Anyone had this fixed?

It would be good to fix it. Thanks

Same here

I finally used this script:
https://gist.github.com/DPatrickBoyd/afb54165df0f51903be3f0edea77f9cb


No way to change password on website?

Really? I couldn't find a way.

https://kerbalstuff.com/forgot-password


Use latest version instead of the specific one

Github has a useful URL shortcut to download the latest version of a file:
https://github.com/<user>/<repo>/releases/latest/download/<file>

This could be used to link to the latest release, instead of always linking to the old one.  The only (big) limitation is that it will not work if the filename itself contains the version number, but it will work for projects like sqlite-compressions. For projects that publish releases without the version, you may want to add a auto_latest: true or some other magical JSON key to use this pattern.

The sqlpkg CLI tool supports the latest version, but the website does not — so I don't use latest in the package specs. Unfortunately, I don't see an easy way to support latest on the website, so I'll pass for now.


Update ci.yml

Codecov Report

:exclamation: No coverage uploaded for pull request base (galactic@35b1212). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             galactic     #35   +/-   ##
==========================================
  Coverage            ?   0.00%
==========================================
  Files               ?       1
  Lines               ?       9
  Branches            ?       2
==========================================
  Hits                ?       0
  Misses              ?       9
  Partials            ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35b1212...5509ba1. Read the comment docs.


Use SLM for depthwise3x3 for OpenCL

Enable the shared local memory for kernel weights for opencl on Intel Platform. There were about 40% compute time saving for the DepthwiseConv3x3 kernels of segmentation_benchmark_512x512.f32.tflite from the model zoo
BUG: N/A

Hi, @roserg, saw you contributed a lot to these codes. Could you help review this?

Hi @junjiang-lab, Can you please review this PR? Thank you !


Sync

Misc. changes

Synched the branch.
Reverted 2 totally wrong commits on my branch.
Added bug, license and repository attribute to package.json.

That also fixed the warning that was throwed by npm install.

Clean up the use statements.
Improved several docblocks.
Added laravel debugbar.

Any idea why the travis-ci doesn't work?

Not now. I'm investigating this

@pietercolpaert TravisCi is now working correctly.

Before merging:

1 file contains USE in capitals (see in line comments)
Doc block says stationTo is an integer, but it's a string

@pietercolpaert This is now fixed with the fix commit


fix: properly type toJSON methods

Please describe the changes this PR makes and why it should be merged:
Adds return types for toJSON that correspond with discord-api-types
Status and versioning classification:

Code changes have been tested against the Discord API, or there are no code changes
I know how to update typings and have done so, or typings don't need updating

Codecov Report

Merging #34 (3695209) into main (2aecbe4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           15        18    +3
  Lines          144       233   +89
  Branches        21        33   +12
=========================================
+ Hits           144       233   +89

Impacted Files
Coverage Δ

.../interactions/slashCommands/SlashCommandBuilder.ts
100.00% <ø> (ø)

...eractions/slashCommands/SlashCommandSubcommands.ts
100.00% <ø> (ø)

src/interactions/slashCommands/Assertions.ts
100.00% <0.00%> (ø)

...nteractions/slashCommands/mixins/CommandOptions.ts
100.00% <0.00%> (ø)

...s/slashCommands/mixins/CommandOptionWithChoices.ts
100.00% <0.00%> (ø)

src/messages/embed/Embed.ts
100.00% <0.00%> (ø)

src/messages/embed/Assertions.ts
100.00% <0.00%> (ø)

src/interactions/slashCommands/options/number.ts
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aecbe4...3695209. Read the comment docs.


How to select what branch to connect to

Hi, it seems that my connection points to the production database. How can I point to a development branch instead?
I'm using separate host/username/password. There is no option to select a branch. Am I supposed to switch to a URL string and connect via a pscale proxy locally?
Thanks

Hi @DominicTobias,
To grab your development branch connection string. Go to the Branches tab. Then click your development branch. Click connect on the top right to get credentials for that branch.


Review README for Cosmos DB components.

@samsp-msft wasn't able to pull enough from the READMEs for the Cosmos DB app model/component packages to write the P3 blog post. For P4 we should review the READMEs for these just to make sure they are giving developers what they need.

Yep

The CosmosDB READMEs follow the same pattern as the other components and hosting resources. Closing since the other READMEs have been deemed acceptable.


Bugfix for #420 Lost IntelliSense after killing host process

@EricMSFT @Microsoft/poshtools

looks good.