request: Keyword and Required Keyword arguments.

Coming from Ruby, one of the best recent features has been keyword arguments in ruby2.0, and especially the required keyword arguments in ruby2.1. Being able to know at the call site what each arg is helps comprehension, and in the method knowing that everything has been passed in, and nothing extra helps maintainability.

I'd love to see this as well. Ruby has conventions for working around this (pass in a Hash, delete keys corresponding to expected arguments, ensure Hash is empty at the end), but that's really cumbersome and verbose.

Take a look at this: http://crystal-lang.org/docs/syntax_and_semantics/default_and_named_arguments.html

ie. they're already supported but translate to arguments with defaults in the method definition, ending up with a compile code with no overhead: it just calls the method with the arguments in the correct order.
def x(a, b = nil, c = 3)
end

x(1, c: 4, b: 2)

It sounds like the only part that isn't implemented is the "required" part?
In Ruby 2.1+ you can say something like:
def x(foo: )
end
x() # ArgumentError
x(foo: 1) # OK.

I've used required named arguments in Ruby a few times already, it would be cool to have the same in Crystal.

Yes, this isn't possible, because kwargs only match arguments with a default value:
def x(foo)
end

x(foo: 1)  # => wrong number of arguments for 'x' (0 for 1)

We might want to be able to do what @ysbaddaden commented last. In particular some classes have long initializers, for example OAuth::Consumer, so in those cases it makes the code more readable and understandable.

The readability is the win when it comes to keyword args. With too many arguments into a function, having them named makes it easier to understand what is being passed into the function.
A side-effect is also DSL readability.
For example, let's say I have a function copy that can copy a file or directory to new location.
# this is a readable if the variables are named correctly
file, target_dir = "README", "/tmp"
copy(file, target_dir)

# this is readable without having to allocate variabled
copy(file: "README", target_dir: "/tmp")

@jtarchie I can't help but feel like that's a weird examples, since 99% of copy functions take the target followed by the source...
A better example, IMO, is with GUI libraries (yes, this example's in Python):
x = MyLibrary.SomeLabel(
    name='xyz',
    x='123',
    label='blah',
    offset=21321321,
    ...
)

which currently would have to be written like this:
x = MyLibrary.SomeLabel()
x.name = 'xyz'
x.label = ...

@kirbyfan64 In your example, what is the signature of MyLibrary.SomeLabel, and what happens if you don't provide name/x/label/offset? Do these have default values?

@asterite They normally do. I just made that off the top of my head based on my experience with using PyGObject and PySide.
I just found another interesting example of the usefulness of keyword arguments. Try to figure out what this does:
Gtk.render_layout(obj.get_style_context(), cairo, 2,
                          -obj.window_to_buffer_coords(
                                    Gtk.TextWindowType.RIGHT, 2, 0)[1],
                          layout)

This is more readable:
Gtk.render_layout(context=obj.get_style_context(), cr=cairo, x=2,
                          y=-obj.window_to_buffer_coords(
                                    win=Gtk.TextWindowType.RIGHT, window_x=2, window_y=0)[1],
                          layout=layout)

Good example of what @asterite was saying about functions with a complex signature: matching arguments without defaults looks like a great addition to the language!

Would love to see named arguments without defaults.

+1 here)

+1 being able to pass named args whether default valued or not in functions param-declaration.

Does anybody still feel strong about required keyword arguments? The general tone in #2537 was against them, so I'd like to close this.

I only just came across #2537 just now. I'm still hoping for required keyword arguments, but let me read that other issue think it over.

Yeah, I think the real goal of this issue was to be able to name arguments at call sites for compression there. One way is this way by having optional keyword arguments and required arguments. However #2537 has the same result of call-site readability through a different means, and that's ok.
Losing the ability to force callees to name is a bit of a loss, but not enough to have both ways, so I'm in favor of closing this.

Let's close then.

We could have a way to force named args to be used, or to disallow named args. The idea would be to allow an external name for an argument:
def foo(external internal)
  # here use internal
end

# At the call site use the external name
foo(external: 1)

foo(1) # Error, can't use positional argument here

To disallow the usage of a named argument you'd use an underscore for the external name:
def foo(_ internal)
  # here use internal
end

# At the call site we must use a positional argument
foo(internal: 1) # Error
foo(1) # OK

Of course you can use the same name for the internal and external name.
This would be almost exactly as in Swift. The difference is that in Swift the external names are part of the method signature, so you can have multiple overloads with the same number of arguments, and even the same types, but with different argument names:
# These are two different overloads in Swift
foo(with: 1)
foo(without: 1)

I personally wouldn't mind adding the external argument feature to make mandatory, or disallow, named arguments for a particular argument. Changing how overloading works, and specially bringing a whole new way to define methods: I'm not sure about that (should we rethink the whole standard library to make use of this feature?).
However, all of this will inevitably make the language more complex, so I personally would leave arguments as they are now, but of course this is open to discussion :-)


Create a reference to http.createServer

Could you make a reference to the created server?
https://github.com/adonisjs/adonis-framework/blob/9a9f3d45147740d6a0ff908efb5f23a0862e9151/src/Server/index.js#L280
I wanted to use this for my game but need to be able to do something like:
var server = http.createServer(app);

/**
 * Listen on provided port, on all network interfaces.
 */

server.listen(port);
server.on('error', onError);
server.on('listening', onListening);

/**
 * SocketIO Connection
 */
var io = app.io
io.attach(server)

There's already a pull-request who add that to the core.
https://github.com/adonisjs/adonis-framework/pull/165

Closed, merged in #165


[Bug] Llama-2-7b-chat-hf-q4f16_1-MLC output incorrectly on Andorid(Dimensity 9300)

🐛 Bug
To Reproduce
Steps to reproduce the behavior:
1.download from apk from https://llm.mlc.ai/docs/     [Android tab ]
2.install apk
3.click download button, download base model Llama-2-7b-chat-hf-q4f16_0
Whatever my prompt is, the model outputs a string of "めめめめめめ..."
This problem only occurred on the Dimensity 9300(vivo x100 pro), which worked well on the 8 Gen 2 chip, Dimensity 9200 chip.

not sure if it is due to out ot memory issue as llama can be too big for lower end phones. closing for now, maybe it is good to try smaller models

Good day.
@tqchen X100 Pro is a Flagship with 12GB Ram in the minimum version.
@LingsiDS
Said "This problem only occurred on the Dimensity 9300(vivo x100 pro), which worked well on the 8 Gen 2 chip, Dimensity 9200 chip."
can you please compare the previous and new version of the Mlc Chat. It appears that changes have been made that affect the app's working on Android.
On device with Mediatek 1080 latest version does not running Gemma 2v, but if i install back Mlc Chat version which downloaded 29.03.2024 Gemma 2b working.
@LingsiDS
is the amount of operative memory the same for both devices with mediatek?."


Fix a misspelled setting

They also dropped an s from randomize_weapon_level.

Of course they did. Fixed that too.


'Check your email' message on test site-too small

Noticing that the alert to check one's email for a validation code is quite small, and the gray coloring inside the text box is difficult to read- on top of that, the message itself disappears if someone clicks inside that text box. Suggest a prompt with more visibility.

I suggest it appears to the right of the login button on desktop, or below on mobile. How the error messages currently appear.

Added a message below the box, in black.


Fix typo in EVP_MD-BLAKE2(7)

Accidental reference to SHA2 in the manpage.

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests.  Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

but this PR has failing CI tests.

No idea what the bot is on about....all CIs have passed?? Adding the label manually.

but this PR has failing CI tests.

No idea what the bot is on about....all CIs have passed?? Adding the label manually.

The clacheck did not run or failed silently apparently. It might be related.

Pushed. Thanks.


[EventEngine] PosixEventEngine: Replace InternalErrors with more appropriate types

I've replaced all use of InternalError here because none of these scenarios would necessarily merit a bug or outage report.
Identified in the fuchsia test suite: calling the Listener's on_shutdown method with anything other than absl::OkStatus() would fail some assertions in the Posix-specialized client test suite if the Oracle were implemented similarly. It should fail the same way in the listener test suite, but the statuses are ignored. I've fixed that.

cc @tamird

This needs to be combined with an audit of all endpoint consuming code
likely: there are likely places we forward endpoint errors into the request
path, and we have strict rules about what errors grpc is allowed to
generate on a request.
We'll likely need to build a status code firewall and convert some of these
back to internal along those paths.
On Thu, Feb 23, 2023, 6:02 PM AJ Heller @.***> wrote:

I've replaced all use of InternalError here because none of these
scenarios would necessarily merit a bug or outage report.
Identified in the fuchsia test suite: calling the Listener's on_shutdown
method with anything other than absl::OkStatus() fails some assertions in
the client test suite if the Oracle were implemented similarly. It
should fail the same way in the listener test suite, but the statuses
are ignored. I've fixed that.
You can view, comment on, or merge this pull request online at:
https://github.com/grpc/grpc/pull/32468
Commit Summary

bf0488d
https://github.com/grpc/grpc/pull/32468/commits/bf0488d3c656055c2f08c43afcbfa67fc7c760c2
[EventEngine] PosixEventEngine: Replace InternalErrors with more
appropriate types

File Changes
(4 files https://github.com/grpc/grpc/pull/32468/files)

M src/core/lib/event_engine/posix_engine/posix_endpoint.cc
https://github.com/grpc/grpc/pull/32468/files#diff-480c81a437473d5161dac9218be290d75ce42b686c1405a88e756c9fa8084a0a
(9)
M src/core/lib/event_engine/posix_engine/posix_engine_listener.cc
https://github.com/grpc/grpc/pull/32468/files#diff-f92e550276db4f50d1fe9a1bd25e9f97297569b7003a3b95658ce15a5e33c16e
(4)
M src/core/lib/event_engine/posix_engine/tcp_socket_utils.cc
https://github.com/grpc/grpc/pull/32468/files#diff-478f31ae377b01f54ab373de6bd9915cc8e26bebd68c228278b36fa7ce9ed1dd
(4)
M test/core/event_engine/test_suite/tests/server_test.cc
https://github.com/grpc/grpc/pull/32468/files#diff-36d4aa76d5721b7c6945e3d0372c94604e3ddc48dec3a76381df1f39c7552221
(6)

Patch Links:

https://github.com/grpc/grpc/pull/32468.patch
https://github.com/grpc/grpc/pull/32468.diff

—
Reply to this email directly, view it on GitHub
https://github.com/grpc/grpc/pull/32468, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACNG45MEKUQW4BMHYBUTGKDWZAJCLANCNFSM6AAAAAAVGLAC4U
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

This needs to be combined with an audit of all endpoint consuming code

That is out of scope for this PR. The InternalErrors here are fundamentally incorrect, the PosixEventEngine would not pass the test suite as its own oracle. Some of this PR is necessary to get the tests to pass.
I ran this PR through our CI with the event_engine_client and event_engine_listener experiments enabled, and no new breakages were identified. Hopefully that is sufficient for now.

I have reduced this PR to just the parts that are needed to get the EventEngine to pass tests as its own oracle, and move on with Fuchsia. This affects the listener's on_shutdown callback alone, which in iomgr is only ever called with absl::OkStatus anyhow. I believe that to be a safe change.


HBASE-28317: Expose client TLS certificate on RpcCallContext

At my employer we plan on using a coprocessor to log information about some requests to HBase. For this to be useful to us, we need to know who each request is coming from. We use HBase's TLS support with mutual authentication to authenticate clients. I'd like a way to expose the client certificate used on a request to coprocessors. For setups using Kerberos authentication, RpcCall exposes the Kerberos principal shortname via getRequestUser(), so this would be the TLS equivalent to that. I've tested this patch applied to 2.5.x in my company's infrastructure.
I found that in order for this patch to be useful to me, I also need netty to fix a related bug which I reported as https://github.com/netty/netty/issues/13796. This doesn't need to block this PR.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 21s
Docker mode activated.

Test failures appear unrelated to this PR

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 51s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 24s
the patch passed

+1 :green_heart:
compile
0m 48s
the patch passed

+1 :green_heart:
javac
0m 48s
the patch passed

+1 :green_heart:
shadedjars
6m 11s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 29s
hbase-server generated 22 new + 0 unchanged - 0 fixed = 22 total (was 0)

_ Other Tests _

-1 :x:
unit
241m 20s
hbase-server in the patch failed.

265m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5644

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux de35d1f833cd 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3b2e981920

Default Java
Temurin-1.8.0_352-b08

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/4/artifact/yetus-jdk8-hadoop3-check/output/branch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/4/artifact/yetus-jdk8-hadoop3-check/output/branch-compile-hbase-server.txt

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/4/artifact/yetus-jdk8-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/4/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/4/testReport/

Max. process+thread count
4830 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5644/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 46s
Docker mode activated.


Experiment: Improve batch sizing?

The batch size should ideally scale to the number of files, at least in the beginning of training the first models.
For example in the first flow the number of files will be very small when training the experiment models, as this is before any noise generation or incremental training has been performed. reducing the batch sizes here is better.
However once the noise files have been generated in flow 2 and before the first training occurs, the batch size can be slightly increased to account for all of the additional files.
Perhaps it is better to simple set the batch size slightly lower and accommodate for the small number of files in the beginning and it should statically be set to the same batch size and the number of epochs can simply be scaled.
Experiment
Perform several runs with scaled batch sizes and with fixed lower batch size and increased epochs to determine which method yields better models.

The scaling leads to model issues like over fitting. Therefore, the batch size will be kept as a constant.


fix(curriculum): remove CSS block to match next step

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #56258

The end state of a successful step 25 now matches the starting state of step 26.
Before:

After:

Oops, didn't notice before. Sure, I'll do it.

Hi @goliardus. Congrats on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 📝


Cleanup of the Repository

Remove Volley lib JAR file
Remove gradlew files from app module

Thanks, @TheCodingWarlock good job cleaning the codebase.


Added configmap for logger (fluentd) configuration.

Added configmap for logger (fluentd) configuration.
Signed-off-by: Azeem Sajid<EMAIL_ADDRESS>

although it's usually a best practice to have small PRs I think in this case it's best if you send for review a single PR with all changes from all the currently open issues together


Additional Options for showing log output panel

Summary
Currently the SAS Log output window is shown for any call made to LogFn during execution. While editor focus remains, if a user is interacting with tabs on the bottom panel (terminal for example), the active bottom panel will be forcibly moved to the SAS Log output for every call to LogFn. This PR exposes two new options that will allow the user to specify when the SAS Log Output is shown to tailor the experience:
onExecutionStart - boolean - show Log Output Window when code starts executing? Default: true
onExecutionFinish- boolean - show Log Output Window when code has finished executing? Default: true
User Settings JSON structure:
"SAS.log.showOnExecutionFinish": true,
"SAS.log.showOnExecutionStart": true,

Additionally, I think that it's time to start considering a more formalized structure for how we manage state in the extension. As such, part of this PR proposes to introduce zustand as the state management library. It's lightweight, easy to setup, and we can leverage it for both the react webviews and the non-react components of the extension. The previous running state that we're tracking in the run command is moved to a zustand store so that we can update and react to changes to it in a simple manner using observers.
Tasks

[x] introduce zustand store
[x] create store for run state
[x] switch run variable state over to store
[x] subscribe to running state to conditionally show log on execution state changes
[x] add new fields to profile
[ ] doc updates with example profile json

Testing
Using the following program:
data _NULL_;
    slept = sleep(30,1);
run;

Set SAS.log.showOnExecutionFinish to false.
Click on Terminal.
Run the example program.
Verify that the SAS Log Output Panel is not focused at the end of execution.
Set Set SAS.log.showOnExecutionFinish to true.
Click on Terminal
Run the example program.
Verify that the SAS Log Output Panel is focused at the end of execution.
Set SAS.log.showOnExecutionStart to false.
Click on Terminal.
Run the example program.
Verify that the SAS Log Output Panel is not focused on start of execution.
Set SAS.log.showOnExecutionStart to true.
Run the example program.
Verify that the SAS Log Output Panel is focused on start of execution.

Just noticed that the variable isRunning thats retrieved from the store is not bound, meaning that updates to it via setting store state do not update the locally scoped variable value. Need to look into that. It's entirely possible that we might need to subscribe to state updates for that.

Just noticed that the variable isRunning thats retrieved from the store is not bound, meaning that updates to it via setting store state do not update the locally scoped variable value. Need to look into that. It's entirely possible that we might need to subscribe to state updates for that.

Fixed in https://github.com/sassoftware/vscode-sas-extension/pull/713/commits/7471bd95d1573c6f3df2616289de4081fea9aea9. For the non-react components, if we want to have reactive behavior then we'll need to subscribe to state changes.

Thanks for review feedback. In the latest push I reorganized the store to split back out into a log and run store. As a result, the log viewer now reacts to running state and uses actions to update stores accordingly.

@scnwwu any comments on latest approach?

Output panel is shown unexpectedly in certain case.
 "SAS.log.showOnExecutionStart": true,
 "SAS.log.showOnExecutionFinish": true

Reproduce step:

Sign in with a valid profile with Viya connection to show Explorer and Library
Switch to a profile with Viya connection, but the endpoint is not available and fail to connect. It will show error prompt as expect.
Stay in Terminal panel
Run some SAS code

Result: It will show Output panel unexpectedly, however there is no log text written on it.

Output panel is shown unexpectedly in certain case.
 "SAS.log.showOnExecutionStart": true,
 "SAS.log.showOnExecutionFinish": true

Reproduce step:

Sign in with a valid profile with Viya connection to show Explorer and Library
Switch to a profile with Viya connection, but the endpoint is not available and fail to connect. It will show error prompt as expect.
Stay in Terminal panel
Run some SAS code

Result: It will show Output panel unexpectedly, however there is no log text written on it.

For step number 2 are you switching to the bad profile and then pressing the run button?

Output panel is shown unexpectedly in certain case.
 "SAS.log.showOnExecutionStart": true,
 "SAS.log.showOnExecutionFinish": true

Reproduce step:

Sign in with a valid profile with Viya connection to show Explorer and Library
Switch to a profile with Viya connection, but the endpoint is not available and fail to connect. It will show error prompt as expect.
Stay in Terminal panel
Run some SAS code

Result: It will show Output panel unexpectedly, however there is no log text written on it.

Thanks @Zhirong2022. Fixed in latest push https://github.com/sassoftware/vscode-sas-extension/pull/713/commits/fb31638a05bfce0b80f543ee3db7f0cf39aff7b6.

The raised issue has been fixed.  No other concerns.


Cinder CSI general update: update csi external container version

What this PR does / why we need it:
update CSI external container version
make manifest/charts consistent
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:

Release note:

NONE

/lgtm
I've checked that all the tags exist.

/retest


feat: enhance distrib

Summary
Check elements necessary for starlake and download missing elements if necessary. Add linting to the dockerfile.
Checking current state avoid to download two version of an artifact by accident if it was set by the user himself.
PR Type: Bug Fix
Status: Ready to review
Breaking change? No
Description
Solution
Check current state based on the different variables set.
Align as much as possible windows installation with unix one.
How has this been tested?
This has been tested manually :

on a windows machine inside powershell
on wsl with ubuntu
with docker

Other changes
Linting of the dockerfile has been added with hadolint. Dockerfile becomes a two-phase build.
Contributor checklist:
Go over all the following points, and put an x in all the boxes that apply.
If you're unsure about any of these, don't hesitate to ask. We're here to help!

[x] My code follows the code style of this project.
[x] I have updated the Release notes.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.

LGTM


HTML block handling in Admonitions doesn't work properly

The following example shows that raw HTML that has empty newlines in the content are not handled properly, and are instead treated as incomplete HTML fragments.
import markdown

print(f"Markdown: {markdown.__version__}")

print("\n------ Results ------\n")

content = r'''
!!! note "Admonition"

    Some text

    Some more text

'''

print(markdown.markdown(content, extensions=['markdown.extensions.admonition']))

Output
Markdown: 3.3.3

------ Results ------

Admonition

Some text

Some more text

Updated results using the latest released Markdown.

Updated results using the latest released Markdown.

So, I based the current behavior on the rules, which state:

The only restrictions are that ...  the start and end tags of the block should not be indented with tabs or spaces.

Of course, the reference implementation does not support admonitions, but nested lists are indented. And according to Babelmark, the reference implementation parses indented raw HTML blocks as raw HTML blocks. ☹ Not what I was expecting. I really thought the reference implementation matched our behavior here. In fact I even added tests for our behavior. 😠
In any event, so long as we are parsing raw HTML in a preprocessor, this is what we will get. The parser is very strict about requiring to indentation. We would need to switch to a blockprocessor, which would strip the indentation in the appropriate cases before parsing as raw HTML. In the early commits to the original PR I was using a block processor but reverted to a preprocessor as I was encountering to many obstacles with the way the block parser splits the source on blank lines.

So, I based the current behavior on the rules, which state:

The only restrictions are that ...  the start and end tags of the block should not be indented with tabs or spaces.

Of course, the reference implementation does not support admonitions, but nested lists are indented. And according to Babelmark, the reference implementation parses indented raw HTML blocks as raw HTML blocks. ☹ Not what I was expecting. I really thought the reference implementation matched our behavior here. In fact I even added tests for our behavior. 😠
In any event, so long as we are parsing raw HTML in a preprocessor, this is what we will get. The parser is very strict about requiring to indentation. We would need to switch to a blockprocessor, which would strip the indentation in the appropriate cases before parsing as raw HTML. In the early commits to the original PR I was using a block processor but reverted to a preprocessor as I was encountering to many obstacles with the way the block parser splits the source on blank lines.

Ugh, I see this is broken in lists as well. For some reason, I was assuming this to be an Admonition specific issue 😦. And I guess, even before the rewrite this was the behavior of Python Markdown. I guess I just never stumbled on this until now.

Ugh, I see this is broken in lists as well. For some reason, I was assuming this to be an Admonition specific issue 😦. And I guess, even before the rewrite this was the behavior of Python Markdown. I guess I just never stumbled on this until now.


Hyperline makes switching between tabs really slow

I think this is because whenever I switch between the tabs, Hyperline recalculates all of the values such as RAM being used (and how much there is, for that matter) so that it can display itself.
I had to remove the extension. But maybe instead I'll try and hack on a fix for it.

Hmm I'll check it out. Currently rewriting hyperline. So if you could Wait for that <3

Sounds good, and I'll hold off on any further investigations for now 😄


Feature Suggestion - Debian based distros

Add the following to the postinst file to automate repo and key installation:
echo "deb https://dl.bintray.com/resin-io/debian stable etcher" | sudo tee /etc/apt/sources.list.d/etcher.list

sudo apt-key adv --keyserver hkp://pgp.mit.edu:80 --recv-keys 379CE192D401AB61

of course you'll need to include checks to ensure the information has not already been added in previous versions.
Add the following to the postrm file to automate repo and key removal:
sudo rm /etc/apt/sources.list.d/etcher.list

sudo apt-key del 379CE192D401AB61

I guess that works if you're downloading the .deb file and installing it directly with dpkg, but the instructions we provide here are designed so that you don't download the .deb directly, but instead install it with apt-get.
AFAIK if we did what you suggest above, and then a user followed the instructions we provide, they'd end up with duplicate entries in their /etc/apt/sources.list.d/etcher.list ? Is it possible to make it conditional so that it doesn't update /etc/apt/sources.list.d/etcher.list if it already exists?
And I guess there's the 'subtle wrinkle' that if a user installs a snapshot .deb file rather than a production .deb file, does that mean we'd need to add the snapshot repo to /etc/apt/sources.list.d/etcher.list instead of the production repo? (see #1767 for more of an overview)
And I've no idea what standard Debian policy is regarding postrm steps (ping @dlech ) but I know I'd be pretty annoyed if I manually created /etc/apt/sources.list.d/etcher.list and then uninstalling etcher-electron automatically deleted it?
As a separate question, is it worth adding that apt-key del command to here ?

@lurch I'll write both of the scripts for you to test under all possible scenarios.

Ok this is fairly simple in Ubuntu.
I've tested this multiple times, works like a charm.
Explanation - you can't add duplicates of the same key so there is no issue there. I've put a check in to see if an existing /etc/apt/sources.list.d/etcher.list file exists, if it does, do nothing, if it doesn't, add it:
Modified postinst:
#!/bin/bash

# Link to the binary
ln -sf '/opt/Etcher/etcher-electron' '/usr/local/bin/etcher-electron'

# Add the Etcher key
apt-key adv --keyserver hkp://pgp.mit.edu:80 --recv-keys 379CE192D401AB61 > /dev/null 2>&1

# Check if the /etc/apt/sources.list.d/etcher.list file exists
if [ -f "/etc/apt/sources.list.d/etcher.list" ]; then exit; else echo "deb https://dl.bintray.com/resin-io/debian stable etcher" | sudo tee /etc/apt/sources.list.d/etcher.list :; fi

Modified postrm (best practice is to clean up, don't leave anything behind if you're not going to use it):
#!/bin/bash

# Delete the link to the binary
rm -f '/usr/local/bin/etcher-electron'

# Remove the Etcher repo
rm /etc/apt/sources.list.d/etcher.list

# Remove the Etcher key
apt-key del 379CE192D401AB61 > /dev/null 2>&1

If you are really worried about Debian policy, look at the current Lintain output in the existing .deb files Etcher is currently serving.
This now negates the need for any 'instructions' other than download the deb, install, drink beer.
Please give this serious consideration. It would make everyones lives including Etchers, so much easier.
Cheers :)

I don't understand why you would set up the remote repository after installing the package. The point of setting up the repository is so that you can install the package with apt. Also having a package that removes an apt source when it is uninstalled is unprecedented, so I suspect it would catch a lot of people off guard.

As a separate question, is it worth adding that apt-key del command to here ?

Actually, I wouldn't use apt-key at all. The "right" way (according to some Debian maintainers I talked to) is to just put the key in /etc/apt/trusted.gpg.d. (apt-key is no longer a required package in Debian since Stretch, so as time goes on, I expect fewer people to have it installed.) So, in the README, I would replace
sudo apt-key adv --keyserver hkp://pgp.mit.edu:80 --recv-keys 379CE192D401AB61

with
curl https://bintray.com/user/downloadSubjectPublicKey?username=bintray | sudo gpg --dearmor --output /etc/apt/trusted.gpg.d/bintray.gpg

This way, if people want to inspect the key first instead of piping directly to gpg, they can.
curl https://bintray.com/user/downloadSubjectPublicKey?username=bintray -O -J
# inspect bintray-public.key.asc
sudo gpg --dearmor --output /etc/apt/trusted.gpg.d/bintray.gpg bintray-public.key.asc
rm bintray-public.key.asc

Then you just have to add this line to the unintall steps:
sudo rm /etc/apt/trusted.gpg.d/bintray.gpg

As per the latest instructions:
sudo apt-key adv --keyserver hkp://pgp.mit.edu:80 --recv-keys 379CE192D401AB61
Executing: /tmp/apt-key-gpghome.ed8DcRlOKk/gpg.1.sh --keyserver hkp://pgp.mit.edu:80 --recv-keys 379CE192D401AB61
gpg: keyserver receive failed: No data

What to do now?

What to do now?

See https://github.com/resin-io/etcher/issues/1930#issuecomment-352845004

We've had a few sporadic reports of the pgp.mit.edu keyserver being temporarily unavailable, but luckily it usually seems to be a fairly short outage.


JFXButton triggers action on shadow click

Create a RAISED Button and click with the mouse on the shadow outside of the "visible button area".
The button action will be triggered.
Simply test it with main demo application (Dialogs).
It's not a big problem, but it's unusual to use/click the shadow.

I think its because the input-eventhandlers are registered on the complete node (+shadow effect) - not the actual panel of the node.

This isn't a problem on mobile devices, because fingers aren't as small as mouse pointers.

Fixed.


Don't post-process result of field_fun

field_fun_json_term should not call conv (or encode) recursively. field_fun will call conversion recursively instead.

Since I introduced field opt list I imagine this:
-json({person, {field_fun_json_term, "complexData", EncFun, DecFun, [raw]}}).

raw means that the result won't be converted. But how should this work in case of decoding? The DecFun decoding function will get an jsx attr list and it needs to create a valid Erlang term (so the decoding work should be implemented there).


When using cub::DeviceRadixSort::SortKeys the device linker reports too much shared memory is used

A host-code linking to a CUDA-enabled Axom encountered the following linker error:
@E@nvlink error   : Entry function '_ZN3cub23RadixSortScanBinsKernelINS_21DeviceRadixSortPolicyIjiiE9Policy700EiEEvPT0_i' uses too much shared data (0xc150 bytes, 0xc000 max)
@E@nvlink error   : Entry function '_ZN3cub30DeviceRadixSortDownsweepKernelINS_21DeviceRadixSortPolicyIjiiE9Policy700ELb0ELb0EjiiEEvPKT2_PS4_PKT3_PS8_PT4_SC_iiNS_13GridEvenShareISC_EE' uses too much shared data (0xc640 bytes, 0xc000 max)
gmake: *** [Makefile:873: dolinkafteropt] Error 255

This is a known issue with the device linker (nvcc 9 & 10), where nvcc reports excess shared memory usage in kernels compiled with relocatable device code, which pushes the max amount over the limit.
This specifically has been observed with using cub::DeviceRadixSort::SortKeys, which, is used in constructing the spin::BVH
NVIDIA has been notified about the issue, but there is no known timeline for a fix.
In the interim, we should have an option to conditionally use cub::DeviceRadixSort for sorting on the device.

This was addressed in cd52db5cae5a20028c8824893fdf6ac22535e3f1


Decouple candidate generation from the offer cycle

This is a pure refactor with no functional changes expected.

Cassandra test failed when deleting cluster.  All tests passed.


[SPARK-41959][SQL] Improve v1 writes with empty2null

What changes were proposed in this pull request?

Cleanup some unnecessary Empty2Null related code
Why are the changes needed?

V1Writes checked idempotency using WriteFiles, so it's unnecessary to check if empty2null if exists again.
Does this PR introduce any user-facing change?

no
How was this patch tested?

pass CI

cc @cloud-fan @EnricoMi

can you update the test added in https://github.com/apache/spark/pull/39431 ?

can you update the test added in https://github.com/apache/spark/pull/39431 ?

sure, updated

!WriteFiles
+- *(1) Project [id#10, sort_col#11, empty2null(p#12) AS p#19]
   +- *(1) Sort [p#12 ASC NULLS FIRST, sort_col#11 ASC NULLS FIRST], false, 0
      +- ShuffleQueryStage 0
         +- Exchange SinglePartition, REPARTITION_BY_NUM, [plan_id=18]
            +- LocalTableScan [id#10, sort_col#11, p#12]

!WriteFiles means something is wrong. @ulysses-you can you check if the expr id is correctly rewritten?

!WriteFiles means something is wrong. @ulysses-you can you check if the expr id is correctly rewritten?

@cloud-fan  fix in https://github.com/apache/spark/pull/39468

@cloud-fan @ulysses-you I can confirm with #39468, the plan for the example now looks like
WriteFiles
+- *(1) Project [id#30, sort_col#31, empty2null(p#32) AS p#39]
   +- *(1) Sort [p#32 ASC NULLS FIRST, sort_col#31 ASC NULLS FIRST], false, 0
      +- ShuffleQueryStage 0
         +- Exchange SinglePartition, REPARTITION_BY_NUM, [plan_id=68]
            +- LocalTableScan [id#30, sort_col#31, p#32]

@ulysses-you can you please rebase with master or merge master into this branch
@cloud-fan can this go ahead then?

@EnricoMi thank you for the confirm ! I send a new approach for this issue see https://github.com/apache/spark/pull/39556

@cloud-fan any comments ? thank you

thanks, merging to master/3.4 (code cleanup for planned write)


Run Shell Script with optional arguments via Quicksilver Trigger

Hello,
I am attempting to craft a trigger that accepts keyboard input and passes the input to a shell script.
I have a python script that runs without issue from the commandline and accepts input. It acts upon the parameters passed on the commandline; it works as expected.
I would like to linkup this script to a QS trigger.
I have configured a trigger:

However, when I trigger this command, I am not presented with the QS input dialog.
I have searched the QS Manual and the Github Issues for a description of a similar user issue but came up empty-handed.
Can anyone provide some help?

Manipulating a program's stdin is (I think, haven't tried) a really hard thing to get right from a GUI application. So unless someone steps up to do it, I fear it's not going to happen.
You might at the very least be able to get QS to launch a Terminal for you (which looks like what you're doing in the screenshot), with your shell command running inside, but not much else.

When you create (or edit) the trigger, just hit ⌘X in the third pane to remove any selection.
The closest we’ve come to documenting that is in an example web search. You can be forgiven for not finding it.
Give it a try, but I’m afraid it might not work in this case because the third pane is allowed to be empty for that action. If it doesn’t work, we’d need to add yet another “Run” action identical to the existing one, but with indirectOptional set to false.

@skurfer I tried to edit my trigger using the approach you suggested: "hit ⌘X in the third pane to remove any selection."
But unfortunately, the trigger continues to behave the same way and simply runs the python script without capturing user input.

I was afraid of that. You can add a new action to the Terminal plug-in and submit a pull request if you want. The required changes should be confined entirely to the Info.plist.
Otherwise, the closest you can probably get for now is to create a trigger for
searchJira ⇥ Select In Command Window

If you make Run […] the default action for executables, that should mean you just need to Tab to the third pane to enter the text. If you use the “Smart” spacebar behavior, it can be shortened to

Trigger
Spacebar
Text
Return


Add Seiya to Contributors list

I'm Seiya taking software engineering.
Please add  me to the list.

Thank you for your contribution Seiya. Enjoy GitHub ;)


🚀 Feature: Json as datatype of attributes

🔖 Feature description
I believe JSON should be an option when creating an attribute.
🎤 Pitch
I find myself often to create an array of String and storing jsons and parsing them in flutter and when saving also to convert them to string and so on.
Json is amazing in my point of view and I often use it to store data.
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

@DobreRadu, thanks for creating this issue! 🙏🏼 Is this a duplicate of https://github.com/appwrite/appwrite/issues/2735? If so, would you please 👍🏼 that issue and close this one as a duplicate?


The MI version of 23 october seem to freeze while trying to open any media

At least on Windows XP SP3 32-bit.

Share Full memory dump MI + src + pdb files?
Dump for XP:
https://blogs.msdn.microsoft.com/junfeng/2008/06/19/getting-a-full-memory-dump-for-a-process/
process explorer https://docs.microsoft.com/en-us/sysinternals/downloads/process-explorer

@pavel-pimenov Thanks for the tips, but Process Explorer doesn't seem to run for me, i suspect that my CPU is too old and that i find where is the old version that i did used some years ago...
I have no trace of ntsd.exe excecutable...

try http://processhacker.sourceforge.net/
Support: Windows XP (SP2)/Vista/7/8/10, 32-bit or 64-bit.

I didn't knew that one so i have downloded it, just in case ;). Cool, thanks.
Anyway, i used the Process Explorer 15.30 version. Here is the dump file:
MediaInfo.7z.txt

@Sami32  share "MI version of 23 october" ?

source code
mediainfo*.exe
*.pdb

Wouah, you are fast guys ;)
Yes, @JeromeMartinez is correct, that were i get the 23 october snapshot.

Should be fixed with https://github.com/MediaArea/MediaInfoLib/pull/639.
Snapshot during the night :).

Solved :+1:


Demo still loads pre 0.4.x architecture?

http://clappr.io/demo/ loads
<EMAIL_ADDRESS>and not
https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>

Certainly the scripts differ which can lead to confusion ;-)

Wow! I forgot to update when I made the release 0.4.0, my fault. 🤦
It's updated now. Thank you!


GLSLLS build failed on neovim

Im installing glslls with mason but it show me this on the end:
◍ glslls
▼ Displaying full log
Cloning git repository "https://github.com/svenstaro/glsl-language-server.git"…
Cloning into '.'...
From https://github.com/svenstaro/glsl-language-server
* tag               0.5.0      -> FETCH_HEAD
Submodule 'externals/CLI11' (https://github.com/CLIUtils/CLI11.git) registered for path 'externals/CLI11'
Submodule 'externals/fmt' (https://github.com/fmtlib/fmt.git) registered for path 'externals/fmt'
Submodule 'externals/glslang' (https://github.com/KhronosGroup/glslang.git) registered for path 'externals/glslang'
Submodule 'externals/json' (https://github.com/nlohmann/json.git) registered for path 'externals/json'
Submodule 'externals/mongoose' (https://github.com/cesanta/mongoose.git) registered for path 'externals/mongoose'
Cloning into 'C:/Users/ucer/AppData/Local/nvim-data/mason/staging/glslls/externals/CLI11'...
Cloning into 'C:/Users/ucer/AppData/Local/nvim-data/mason/staging/glslls/externals/fmt'...
Cloning into 'C:/Users/ucer/AppData/Local/nvim-data/mason/staging/glslls/externals/glslang'...
Cloning into 'C:/Users/ucer/AppData/Local/nvim-data/mason/staging/glslls/externals/json'...
Cloning into 'C:/Users/ucer/AppData/Local/nvim-data/mason/staging/glslls/externals/mongoose'...
Submodule path 'externals/CLI11': checked out '291c58789c031208f08f4f261a858b5b7083e8e2'
Submodule path 'externals/fmt': checked out 'cd4af11efc9c622896a3e4cb599fa28668ca3d05'
Submodule path 'externals/glslang': checked out 'f1cb8608b390a7f51b4ae0d62cd415ba47a59b86'
Submodule path 'externals/json': checked out 'db78ac1d7716f56fc9f1b030b715f872f93964e4'
Submodule path 'externals/mongoose': checked out '62c896a8725ed94681a1cc58314078b4b4309815'
CMake Error: Absolute paths are required for --install-prefix
CMake Error: Run 'cmake --help' for all supported options.
ninja: fatal: chdir to 'build' - No such file or directory
ninja: Entering directory build'         ninja: Entering directory build'
ninja: fatal: chdir to 'build' - No such file or directory
spawn: powershell failed with exit code 1 and signal 0.

As you can see from the error:  CMake Error: Absolute paths are required for --install-prefix you're calling the compilation wrong. Can you show exactly how you're building it?

this is Mason.nvim log

I try to build it by hand but it give me:
Microsoft Windows [version 10.0.19045.5011]
(c) Microsoft Corporation. Tous droits réservés.
C:\Users\ucer\Documents\C++\LSP\glsl-language-server>git submodule update --init
C:\Users\ucer\Documents\C++\LSP\glsl-language-server>cmake -Bbuild -GNinja
CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
Compatibility with CMake < 3.5 will be removed from a future version of
CMake.
Update the VERSION argument  value or use a ... suffix to tell
CMake that the project does not need compatibility with older versions.
-- No build type selected, default to Debug
-- Google Mock was not found - tests based on that will not build
-- spirv-tools not linked - illegal SPIRV may be generated for HLSL
CMake Deprecation Warning at externals/fmt/CMakeLists.txt:1 (cmake_minimum_required):
Compatibility with CMake < 3.5 will be removed from a future version of
CMake.
Update the VERSION argument  value or use a ... suffix to tell
CMake that the project does not need compatibility with older versions.
-- Version: 7.0.3
-- Build type:
-- CXX_STANDARD: 11
-- Required features: cxx_variadic_templates
CMake Deprecation Warning at externals/json/CMakeLists.txt:1 (cmake_minimum_required):
Compatibility with CMake < 3.5 will be removed from a future version of
CMake.
Update the VERSION argument  value or use a ... suffix to tell
CMake that the project does not need compatibility with older versions.
-- Using the single-header code from C:/Users/ucer/Documents/C++/LSP/glsl-language-server/externals/json/single_include/
-- Operating system: Windows-10.0.19045
-- Compiler: c++.exe (x86_64-win32-seh-rev0, Built by MinGW-W64 project) 8.1.0; Copyright (C) 2018 Free Software Foundation, Inc.; This is free software; see the source for copying conditions.  There is NO; warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
-- Configuring done (4.9s)
-- Generating done (1.1s)
-- Build files have been written to: C:/Users/ucer/Documents/C++/LSP/glsl-language-server/build
C:\Users\ucer\Documents\C++\LSP\glsl-language-server>ninja -Cbuild
ninja: error: 'externals/glslang/glslang/libglslang.a', needed by 'glslls.exe', missing and no known rule to make it
ninja: Entering directory `build'
C:\Users\ucer\Documents\C++\LSP\glsl-language-server>

I'll be honest, I never built this on Windows. It should work, I don't see why not. However, I don't know why the lib isn't getting built. Can you check whether maybe it has a different name on Windows? Check for the glslang lib.

you test it on neovim?. If it works with you, maybe i should switch to WSL

properly, just the opengl lib has the different names in different OSs but glsl maybe steel the same for all


Add Nong Song: Tidal Wave (Cat Edition)

Song Name
Shiawase (VIP - Cat Edition)
Artist Name
SupaCLUCK
Source
Youtube
Youtube Link
https://www.youtube.com/watch?v=FlaPfkW7DjE
Direct File Link
No response
Song ID
1266014
Extra
Used in Tidal Wave

song offset is wrong. if you can, reupload the song please


Feat: Yelp web scraper

Describe the feature
Yelp is one of the most popular websites in the world which offer food delivery, household daily-chore and construction jobs, and so on.
I'd create a web scraper of the aforementioned website. The users would be able to view the latest deals based on their location preferences and other inputs proided to get the desired results.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC 23 contributor
[X] I want to work on this issue

@nikhil25803 please assign me this

I do not think this will add much value.


Export unawaited from meta.

I think we're going to want to revert this change given the impact to the ecosystem.


Is there a way to change the download/run directory?

On Linux, I want to download/run it from a directory with more space than /usr/share/

It's just using $HOME as seen here:
https://github.com/search?q=repo%3Ajmorganca%2Follama+.ollama&type=code
The /usr/share is coming from Environment="HOME=/usr/share/ollama"
https://github.com/search?q=repo%3Ajmorganca%2Follama usr%2Fshare&type=code

@improvethings I think #897, which will be in the next release may resolve your issue. It allows setting the directory where the model files are stored.

Do you know approximately when the next release will be deployed?

This is solved by using the OLLAMA_MODELS environment variable. Once you set that for the account that runs ollama, then models will go wherever you want. I will go ahead and close this issue now. If you think there is anything we left out, reopen and we can address. Thanks for being part of this great community.

This is solved by using the OLLAMA_MODELS environment variable.

@technovangelist Great addition - works well with WSL using another drive (otherwise defaults to C:) Should probably be added to the README.md

Could it be possible to set this download path from the ollama command line? Like ollama set-model-path /my/path or something like this...

I second this, I'm unable to get the OLLAMA_MODELS to make any difference to where models are stored. Having the ability to directly set the model path would be great.

same issue. OLLAMA_MODELS variable does not work for me

It works for me, in the service by adding Environment="OLLAMA_MODELS=/srv/models" as well as (in one line):  OLLAMA_MODELS=/srv/models ollama run mixtral

Sorry for confusion, it works now. In my case I had to start first ollama serve and only then ollama run .... So inititally I've passed OLLAMA_MODELS to ollama run command but it turned out that I need to pass it to ollama serve.
Now everything works fine for me.

For users of the newly released Windows version of Ollama, you need to add your new directory to both the "System variables" in the "Environment Variables" and in the "Path" under the "User variables for ***"

For users of the newly released Windows version of Ollama, you need to add your new directory to both the "System variables" in the "Environment Variables" and in the "Path" under the "User variables for ***"

How did u install model in other directory then c? I don't have enough storage in windows on drive c and I'm not able to download it to other directory

Similar concern on how do I install or download models to a different directory then C which seems to be the default for both installing ollama and run model.

This does not work for me. I second the feature of a command line to formally set the path. I am on a linux instance and the installer creates /usr/share/ollama as the home directory without a shell which contains .bashrc and .profile. I tried adding the OLLAMA_MODELS=... and nothing is written to the new location. :(

On windows, it worked perfectly. setx OLLAMA_MODELS "D:\ollama_model"

Can we have a way to store the model at custom paths for each model, like specifying the path when its being downloaded for first time.
If the model is not there already then download and run, else directly run.
In this way we can even maintain different versions of same model in different directories.
I am really hoping this would work for windows too :)

It’s so counter-intuitive that ollama pull cannot set the location of the downloaded model through an optional parameters, actually all ollama commands basically have no flag.
I believe most linux user does not use /usr/share to store data as large as LLM.
Please consider something like adding a --out for pull and --in for run, it would be perfect.

How To Change Ollama Model Default Directory
https://www.youtube.com/watch?v=uj1VnDPR9xo

On windows, it worked perfectly. setx OLLAMA_MODELS "D:\ollama_model"

it worked for me on windows

For everyone who say it does not work OLLAMA_MODELS - kill ollama instances first, then run it again

Just a new idea,  i have attached a m.2 PCIe NVME SSD to my Raspberry Pi 5 and it run Raspberry Pi OS 64bit (bookworm),
I found that ollama user's home directory is /usr/share/ollama ,  so I've tried this :

stop ollama service

sudo systemctl stop ollama.service

patitioning my SSD and format it, mount it direct to /usr/share/ollama folder .

sudo fdisk /dev/nvme0n1
> d
> p
> n
> p
> 1
> enter -->enter
> w

sudo mkfs.ext4  /dev/nvme0n1p1
sudo mount -t ext4 /dev/nvme0n1p1  /usr/share/ollama -v
sudo chown -R ollama:ollama /usr/share/ollama
sudo systemctl daemon-reload
sudo systemctl restart ollama.service

Pull models

for  model in llama3 llama2  mistral phi3  qwen:4b  qwen:7b  codegema
do
     ollama pull $model
done

and it works perfect. hope it can help you out.


Feature Request: Flexible Grab Points

Hey all, The summary of the feature is this, instead of having to add individual grab points for both left and right hands, a simpler, from the dev perspective, and more immersive way to do this would be to have a scene that marks an object as interactive/interactable and allows the hands/XRToolsFunctionPickup to attach where the hands collide with/touch the object. An example and use case of this would be being able to hold an object and looking at all faces by rotating it by grabbing different areas of the object without needing to individually define those grab points. Let me know what y'all think!

like weapon handling in blade and sorcery, that will be a nice feature

Hey all, The summary of the feature is this, instead of having to add individual grab points for both left and right hands, a simpler, from the dev perspective, and more immersive way to do this would be to have a scene that marks an object as interactive/interactable and allows the hands/XRToolsFunctionPickup to attach where the hands collide with/touch the object. An example and use case of this would be being able to hold an object and looking at all faces by rotating it by grabbing different areas of the object without needing to individually define those grab points. Let me know what y'all think!

not sure were you are comin from (engine wise) but even in unity and in its thirdparty toolkits (except autohand) this is not present. Your hand would need to autoadjust its fingers upon grabing the collision shape of the object, it would need to autobend and curl the fingers so that they are were they should be but the current implementation doesnt allow for this and at the same time you need way more complex collision shapes for such a solution to work properly.
mux might have something in the future regarding the hands/fingers to curl/bend around surfaces that you grab but that is a big "maybe"


Modified the registry configs to use nip.io based dns

Signed-off-by: Valen Mascarenhas<EMAIL_ADDRESS>
Which issue(s) this PR fixes:
This PR modified the registry configs on ppc64le to use nip.io based dns

@kvmware any issue with the PR ?


Fermyon, Spin: Uncaught Error: PrismaClient is unable to run in this browser environment, or has been bundled for the browser (running in 'unknown'). for @prisma/client

Spin is a framework to build serverless apps (deployed via Wasm) that can for example be run on Fermyon Cloud.
When trying to use Prisma Client via "Spin Components in Javascript", I get the following error when I call the running app (via spin up):
Handler returned an error: Uncaught Error: PrismaClient is unable to run in this browser environment, or has been bundled for the browser (running in `unknown`).
If this is unexpected, please open an issue: https://github.com/prisma/prisma/issues
    at get (script.js:160)
    at <anonymous> (script.js:331)
    at call (native)
    at step (script.js:313)
    at <anonymous> (script.js)
    at <anonymous> (script.js:288)
    at Promise (native)
    at <anonymous> (script.js:289)
    at handleRequest (script.js:333)
    at <anonymous> (sdk.js:4089)
    at call (native)
    at step (sdk.js:4006)
    at <anonymous> (sdk.js)
    at <anonymous> (sdk.js:3981)
    at Promise (native)
    at <anonymous> (sdk.js:3982)
    at _handleRequest (sdk.js:4100)

Reproduction repository: https://github.com/janpio/spin-prisma

Switching to @prisma/client/edge allows us to proceed further:
Uncaught PrismaClientKnownRequestError:
Invalid `prisma.user.findFirst()` invocation:

Error validating datasource `db`: the URL must start with the protocol `prisma://`
    at PrismaClientKnownRequestError (script.js)
    at handleRequestError (script.js)
    at handleAndLogRequestError (script.js)
    at request (script.js)

I guess that is expected in this case (I was using a SQLite connection string).

With the URL changed and in an env var, I get this:
Uncaught TypeError: not a function
    at PrismaClientInitializationError (script.js)
    at Dn (script.js:235)
    at extractHostAndApiKey (script.js)
    at <anonymous> (script.js)
    at start (script.js)
    at url (script.js)
    at callback (script.js)
    at withRetry (script.js)
    at requestInternal (script.js)
    at request (script.js)
    at singleLoader (script.js)
    at request (script.js)
    at request (script.js)
    at _executeRequest (script.js:250)
    at Na (script.js)
    at u (script.js)
    at <anonymous> (script.js)
    at runInChildSpan (script.js)
    at _request (script.js)
    at s (script.js)
    at <anonymous> (script.js)
    at o (script.js)
    at then (script.js)

🤷

This error is caused when calling Error.captureStackTrace(e) which does not seem to be implemented in QuickJS, the runtime that is being used here. I would need to shim/polyfill that somehow to proceed further.

Turns out Fermyon/Spin is using QuickJS under the hood.
We just got a related issue about this at https://github.com/prisma/prisma/issues/21128 - and there we have some JS only code that reproduces the same problem we are getting in Fermyon/Spin as well. Iteration speed is much faster there - but now also stuck at missing Node/JS APIs that would need to be polyfilled (after being identified).


Fix super call in various get_configuration_warnings methods

Discovered one of these while working on https://github.com/godotengine/godot/pull/93351 and decided to make further fixes
If any of these are intentional I'll restore them and add a comment to that effect, but assuming since no comment was added here that this was not intended to work around any inheritance
I haven't noticed any issues from these but haven't tested it myself, but it will ignore the intervening classes, which might ignore stuff we want

Thanks!

Thank you!

Cherry-picked for 4.3.1.


improved debug logging

Describe the solution you'd like
We have several cases like this in s3api/controllers/base.go:
	contentLength, err := strconv.ParseInt(contentLengthStr, 10, 64)
	if err != nil {
		return SendResponse(ctx, s3err.GetAPIError(s3err.ErrInvalidRequest),
			&MetaOpts{
				Logger:      c.logger,
				Action:      "PutObject",
				BucketOwner: parsedAcl.Owner,
			})
	}

And we lose the error since this isn't logged anywhere. This is probably what we want for non-debug enabled since its not really the gateway's job to log details of all bad user requests. But when the gateway has an bug in some of these cases, it would be good to enable logging of the various errors that are being lost.

debug logging PR went in. this will probably be an ongoing thing to keep adding more debug logs. no need for an issue for this though unless there are specific missing logging.


Segmentation fault when running micro-ros-agent as snap package

Hi! I saw the announcement that micro-ros-agent has been released as a snap package (here). I am really happy to try this release. The problem is, I got a segmentation fault error when running it.
Setup

Ubuntu 20.04 / ROS2 Foxy
Teensy 3.1

Steps to reproduce
I first removed micro-ros-agent installation from source that I already had on my computer. I also removed all other micro-ROS submodules installation from source. Then I installed micro-ros-agent as snap package following this example:
sudo systemctl enable --now snapd.socket
sudo ln -s /var/lib/snapd/snap /snap
sudo snap install micro-ros-agent
And then I run it:
micro-ros-agent serial --dev /dev/path/to/board
I also tried this while keeping micro-ROS submodules installation from source, or having micro-xrce-dds-agent installed from snap too. The results are the same.
I can precise that running micro-ros-agent with installation from source works, with the exact same computer and board.
Expected behavior
The agent is launched, waiting for the board or detecting it (depending on whether the board is plugged).
Actual behavior
The agent crashes with segmentation fault error. Complete log is:
/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
[1607423318.496277] error    | TermiosAgentLinux.cpp | init                     | open device error      | device: /dev/path/to/board, errno: 13. Please re-run with superuser privileges.
Error while starting serial agent!
Segmentation fault

I tried to run the agent when the board is plugged and when it is not. Either way, the result is the same.
I also tried to follow the log recommendation (: Please re-run with superuser privileges.), and logged in as root with sudo -i command. The result is the same.
Could you tell me if some other micro-ROS packages are required to be installed from source, in order to be able to run micro-ros-agent as a snap package? Is micro-xrce-dds-agent required to be install as a snap package too?
Thanks a lot for support!

Good morning @anaelle-sw,
Certainly, this should not be happening. This is probably related to the permissions given to the micro-ROS-Agent snap executable during compile time. Let me dig into this issue and I will report back ASAP.
Thank you!

Good morning,
I've been digging into this and found out some interesting facts that we didn't notice, primarily because we did all our test with the snap versions of the Micro XRCE-DDS Agent and the Micro-ROS Agent using network connections:

By default, the snapd daemon is not prepared to detect hotplug connections to serial ports. This is one of the reasons why snap is not properly detecting your device.
Because of the first point, the device won't be automatically connected to the snap image.

I was able to run the micro-ros-agent snap using a serial device by following these steps:

Resfresh your local installation of the snap core package

$ sudo snap refresh core --edge

Enable the hotplug feature, and restart the snapd daemon

$ sudo snap set core experimental.hotplug=true
$ sudo systemctl restart snapd

Plug in your microcontroller to the USB port, and then execute snap interface serial-port. You should see there a list of all the snap images in your machine that use the serial-port plug, and if the device is connected, a slot section. Mine looks like this:

name:    serial-port
summary: allows accessing a specific serial port
plugs:
  - micro-ros-agent
  - micro-xrce-dds-agent
slots:
  - snapd:cp2102cp2109uartbrid (allows accessing a specific serial port)

Connect your snap image to the desired serial port (replace accordingly)

snap connect micro-ros-agent:serial-port snapd:cp2102cp2109uartbrid

After this, sudo micro-ros-agent serial --dev /dev/ttyUSB0 works for me.

The whole process seems to be a little bit tricky, but I believe this hotplug feature is currently under the final stages of its development and probably might be released in the next stable version of the snap core package. Maybe @kyrofa can say something about this, or even about the steps I described in order to simplify them :slightly_smiling_face:

Hello!
Thanks for all of these explanations. This method works really well for me, the agent detects the board, and I can perfectly run our ROS2/micro-ros application with micro-ros-agent installed from the snap release!
I can just precise two things:

In order to have the agent and ROS2 communicate, I don't need any micro-ros submodules (I mean the submodules that are installed when following the micro-ros tutorial here. I used to have these installed from source, when using micro-ros-agent installed from source too). However, I do need to install micro-xrce-dds-agent as a snap package. Otherwise the agent detects the board and opens the session, but no messages are passing between ROS2 and the board.

If micro-ros-agent is launched when logged in as root (as you suggested: sudo micro-ros-agent serial --dev /dev/ttyUSB0), the process is not ended when closing the terminal where it was launched, neither with Ctrl+C command. So when running a new micro-ros-agent, there is actually a second agent running. And having several agents running for the same board just makes a mess with our application behavior (and I guess this is normal, and not only related to our application)... Anyway, launching the agent without using sudo doesn't make any problem, everything works properly.

I will let this issue opened, as you colleague might want to add something as you said. But it is all good for me, you can close the issue if you want to. Thank you!

Maybe @kyrofa can say something about this, or even about the steps I described in order to simplify them

No you're spot on, thanks for the ping. I have a meeting on Monday to discuss its experimental nature, I'll get back to you on this.

Hello!
Thanks for all of these explanations. This method works really well for me, the agent detects the board, and I can perfectly run our ROS2/micro-ros application with micro-ros-agent installed from the snap release!
I can just precise two things:

In order to have the agent and ROS2 communicate, I don't need any micro-ros submodules (I mean the submodules that are installed when following the micro-ros tutorial here. I used to have these installed from source, when using micro-ros-agent installed from source too). However, I do need to install micro-xrce-dds-agent as a snap package. Otherwise the agent detects the board and opens the session, but no messages are passing between ROS2 and the board.
If micro-ros-agent is launched when logged in as root (as you suggested: sudo micro-ros-agent serial --dev /dev/ttyUSB0), the process is not ended when closing the terminal where it was launched, neither with Ctrl+C command. So when running a new micro-ros-agent, there is actually a second agent running. And having several agents running for the same board just makes a mess with our application behavior (and I guess this is normal, and not only related to our application)... Anyway, launching the agent without using sudo doesn't make any problem, everything works properly.

I will let this issue opened, as you colleague might want to add something as you said. But it is all good for me, you can close the issue if you want to. Thank you!

Good morning @anaelle-sw ,
Sorry for the delay in answering. As micro-ROS is an european project, I've been very busy writing deliverable documents and wasn't able to check Github until now.
Regarding the two points you have mentioned:

Yes, if you install the micro-ROS Agent as a snap package, you won't need any of the modules described in the tutorial. This is inferred from snap architecture itself: it provides you with a self-contained environment, where al the necessary dependencies required to launch a certain process are already available and properly source within the snap filesystem. This also leads to answering the next observation: I do not think it is necessary that you have installed the micro-xrce-dds-agent snap previously to using the micro-ros-agent snap. The micro-ros-agent snap itself should take care of downloading first the Micro XRCE-DDS Agent library, compiling it and using it as a base to compile the micro-ROS Agent. Actually, I uninstalled the micro-xrce-dds-agent snap, and the micro-ros-agent snap is still working as expected. Could you please confirm this?
Ok with the sudo part. I thought that it was necessary due to the fact that, whithout the snap, you actually need to prepend sudo to the micro-ROS Agent executable to use serial devices. I will remove it from the instruction set. Thanks!

Hello @jamoralp! No problem, thanks for your answer!
I removed  the micro-xrce-dds-agent snap installation. I am still able to launch the agent and to correctly run our application. Sorry about it, I might have missed something last time... This issue can be closed then. Thank you!


nixos/gnupg: add agent.extraConfig option

Description of changes
Add new programs.gnupg.agent.extraConfig option for specifying verbatim config values in /etc/gnupg/gpg-agent.conf.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[x] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

We should avoid introducing extraConfig options after RFC42, unless it's unfeasible to generate the file from Nix.
In this case the format of gpg-agent.conf is very straightforward: it's just <option> <value> per line.
So, instead I would make a programs.gnupg.agent.config with a type like attrsOf  str.

@GrahamcOfBorg test gnupg


Some icons miss fill weight when using Phosphor font

Describe the bug
There is a problem when I try to use fill weight for some icons.
To Reproduce

Import Phosphor using the script .
Some icons would not render, for example:

Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome
Version: 98.0.4758.102

Additional context
I didn't try to render all the icons. Extensive research and debugging may be needed to find all the icons that don't render when using the Phosphor by the font.

Thanks for the report. I've done some digging, and it looks like we are overflowing the Unicode Private Use Area range in our icon font, and the broken glyphs all happen to align with the codepoints for diacritics, non-printing characters, and other special characters that are not displayed correctly. For visibility, the broken icons as best I can tell are:
Invisible or non-printing
ph-television-simple-fill
ph-tennis-ball-fill
ph-terminal-fill
ph-terminal-window-fill
ph-test-tube-fill
ph-text-aa-fill
ph-text-align-center-fill
ph-text-align-justify-fill
ph-text-align-left-fill
ph-text-align-right-fill
ph-text-bolder-fill
ph-text-h-fill
ph-text-h-five-fill
ph-text-h-four-fill
ph-text-h-one-fill
ph-text-h-six-fill

Offset
ph-tiktok-logo-fill
ph-timer-fill
ph-toggle-left-fill
ph-toggle-right-fill
ph-toilet-fill
ph-toilet-paper-fill
ph-tote-fill
ph-tote-simple-fill
ph-trademark-registered-fill
ph-traffic-cone-fill
ph-traffic-sign-fill
ph-traffic-signal-fill
ph-train-fill

We'll work on a fix, probably by shifting the entire fill weight to another Unicode region.

That's great, thank you for the response. As a designer myself I love your work with Phosphor!

This is fixed with #221 and is live in<EMAIL_ADDRESS>the new vanilla JS package 👍


Version 0.2.15 introduces breaking changes

After upgrading from version 0.2.3 to 0.2.15 we noticed that the database was recreated. Our entire Keycloak configuration was wiped. After some trial and error I am almost certain that this was introduced in version 0.2.15 by the addition of defaultDatabaseName: 'keycloak'. This forces CloudFormation to create a new physical resource.
Steps to recreate

Create NPM project
Install<EMAIL_ADDRESS>Deploy
Make some modifications in Keycloak
Upgrade to<EMAIL_ADDRESS>Deploy
Check the Keycloak instance, it should be now be a fresh install again

After upgrading from version 0.2.3 to 0.2.15 we noticed that the database was recreated. Our entire Keycloak configuration was wiped. After some trial and error I am almost certain that this was introduced in version 0.2.15 by the addition of defaultDatabaseName: 'keycloak'. This forces CloudFormation to create a new physical resource.
Steps to recreate
* Create NPM project

* Install<EMAIL_ADDRESS>
* Deploy

* Make some modifications in Keycloak

* Upgrade to<EMAIL_ADDRESS>
* Deploy

* Check the Keycloak instance, it should be now be a fresh install again

My apology not calling out the breaking changes. We will make sure all major changes subject to resource replacement will be highlighted in the breaking changes notice in the release note. Thank you for the bug report.

@pahud I think we need to change all database removalPolicy: cdk.RemovalPolicy.RETAIN
https://github.com/aws-samples/cdk-keycloak/blob/11d2b47e6a0293c12b2b1aa40dec850177d7f033/src/keycloak.ts#L333
https://github.com/aws-samples/cdk-keycloak/blob/11d2b47e6a0293c12b2b1aa40dec850177d7f033/src/keycloak.ts#L360
https://github.com/aws-samples/cdk-keycloak/blob/11d2b47e6a0293c12b2b1aa40dec850177d7f033/src/keycloak.ts#L377


Vocal emote menu icon should be white

Description

It bothers me that the other two options are white and then one is blue for the main categories.
Screenshots

It's hard to even notice the items in all the clutter. I think the circle should have a dark background or something.

It's hard to even notice the items in all the clutter. I think the circle should have a dark background or something.

it should probably be toggleable in accessibility settings instead, its fine for me personally


Replace deprecated sym_pos and tree_multimap

jax.tree_multimap was deprecated in JAX version 0.3.5, and removed in JAX version 0.3.16.

Hi @J4nn1K ,
Thanks for your PR. Internally, we rewrote the tvlqr code a bit so it does not rely on sp.linalg.solve, instead using np.linalg.lstsq, and hence this change is no longer necessary. I am going to close this PR now.


Cloud URLs page, etc. are missing AWS us-east-1

On our Cloud URLs page, the URL for AWS us-east-1 is missing. Please add it.
Also, the "Where are you running InfluxDB" configuration setting is missing AWS Virginia:

Relevant URLs
https://docs.influxdata.com/influxdb/v2.0/reference/urls/
What products and version are you using?

This is fixed in our upcoming OSS GA/separate cloud branch. Closing.


Explicitly state when to compute confidence intervals

Today confidence intervals are computed by default for the main_score.
This PR adds the capability of computing confidence intervals for additional scores.
We would like to change the confidence interval default, such that is is not computed by default, but rather it is only computed when explicitly stated in the metric.

Today we have a mechanism for disabling confidence interval calculation, by setting n_resamples to None. That mechanism is used as the implementation of a command line parameter in FM-Eval.
There is also a mechanism for specifying a list of confidence interval scores, on which the confidence intervals are computed. This is implemented for instance metrics.
The suggestion is that the enable/disable mechanism of the confidence interval computation will be implemented only with the list of score names, with an empty list to indicate no computation. The n_resamples flag will no longer support a value of None.

for which metrics CI is disabled? and why?

I can see why latency can become an issue, but this is the case only for global metrics. For instance metrics, the CI computation should be very fast.

for which metrics CI is disabled? and why?

Is was disabled for the default version of rouge (here). The reason is runtime. There are other cases of users that asked to turn it off. I think indeed the runtime issue is mainly for global metrics.


Fix CI

Codecov Report

Merging #288 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #288      +/-   ##
=========================================
- Coverage    87.1%   87.1%   -0.01%
=========================================
  Files         102     102
  Lines       14502   14506       +4
=========================================
+ Hits        12632   12635       +3
- Misses       1870    1871       +1

Impacted Files
Coverage Δ

juniper/src/schema/meta.rs
87.71% <0%> (-0.26%)
:arrow_down:

juniper_warp/src/lib.rs
92.09% <0%> (+0.04%)
:arrow_up:

juniper/src/tests/model.rs
91.3% <0%> (+0.06%)
:arrow_up:

juniper/src/validation/rules/no_fragment_cycles.rs
89.8% <0%> (+0.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bb62ff...abeece3. Read the comment docs.


Update mm-get-started.md

https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/issues/2045
Added info.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@JoanneHendrickson PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


spring, springWithCompletion, springEaseOut etc not available Swift 2.0

Those methods are not available.

now you have to specify animations and SpringAnimation class
ex:
SpringAnimation.springWithCompletion(0.8, animations: {


ERROR: Failed to connect to localhost port 8090: Connection Refused

Gets this error when trying to fetch the docker-compose from file delivery api when trying to deploy a project to a server

Might be something related to configuration. Assuming the APIs are running on the same server, are you sure file delivery API is running?
Going to close this issue for now, but can later be reopened if the issue is preset across all instances of the API(s).

Might be something related to configuration. Assuming the APIs are running on the same server, are you sure file delivery API is running?
Going to close this issue for now, but can later be reopened if the issue is preset across all instances of the API(s).


Set a default value for setFirmwareClassPath in the worker config.

When firmware is added to the driver-cotnainer there are 2 actions that were taken:

Copy the firmware files onto the node at /var/lib/firmware
Add /var/lib/firmware to /sys/module/firmware_class/parameters/path in order to update the kernel lookup directories for firmware files.

In order to make this feature configurable, we will allow the user to choose the path on the nodes to write the firmware files to.
In order to make it work with no additional changes, when firmware files are added to the driver-container, we added a default directory to add the firmware files to on the nodes.
To keep it simple, we will also always add this path to the kernel lookup directories.

/assign @yevgeny-shnaidman
unit-tests are still failing but the code should stay the same.

Codecov Report
Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.03%. Comparing base (fa23a9b) to head (569a26f).
Report is 98 commits behind head on main.

Files
Patch %
Lines

internal/controllers/nmc_reconciler.go
75.00%
1 Missing and 3 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
- Coverage   79.09%   72.03%   -7.07%
==========================================
  Files          51       66      +15
  Lines        5109     4527     -582
==========================================
- Hits         4041     3261     -780
- Misses        882     1072     +190
- Partials      186      194       +8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/hold

/unhold

/lgtm


chore: migrate AnalyticsData to owlbot

v1alpha doesn't exist in googleapis-gen repository.

@bshaffer PTAL

I actually don't know.

Looking at https://github.com/googleapis/googleapis/tree/master/google/analytics/data
There's only v1beta directory, so I assume now we only publish v1beta.

@bshaffer I also made a change for a beta library. PTAL


Libre 3 support

Is Libre 3 support (direct) going to be introduced soon, with the Libre 3 being approved and launched in more countries with time?

support for libre 3 is non-trivial. so no unless someone steps up and figures out how to do so


Setting window.location.hash breaks client-side navigation

Update (2024-11-03)
Seems like it's broken in Firefox only.
Tested With<EMAIL_ADDRESS>
❎ Firefox 132.0 (aarch64)
✅ Chrome 130.0.6723.92
✅ Safari 18.0.1(206<IP_ADDRESS>.7)

Describe the bug
I know, window.location should not be set directly, but hope hash is an exception.
Client-side navigation to /a#hash does not show :target styling on the id="hash" element.
This is expected in client-side rendering as documented below:

https://github.com/sveltejs/kit/issues/10550#issuecomment-1751967486

$effect(() => {
  if ($page.url.hash) window.location.hash = $page.url.hash;
});

But the above workaround is broken as documented below:
Reproduction

Load /
Click on the anchor → /a#hash
Press browser back → /
Press browser forward

browser URL does change to /a#hash as expected
but page stays the same (no client-side navigation)

Click this link to goto A

Click the browser's forward button

You are on A!

Now click the browser's back button

Logs
No response
System Info
System:
  OS: macOS 15.0.1
  CPU: (10) arm64 Apple M1 Pro
  Memory: 24.80 MB / 16.00 GB
  Shell: 5.9 - /bin/zsh
Binaries:
  Node: 22.10.0 - ~/.local/state/fnm_multishells/86959_1730372499881/bin/node
  npm: 10.9.0 - ~/.local/state/fnm_multishells/86959_1730372499881/bin/npm
  pnpm: 9.12.3 - ~/.local/state/fnm_multishells/86959_1730372499881/bin/pnpm
Browsers:
  Chrome: 130.0.6723.70
  Edge: 130.0.2849.56
  Safari: 18.0.1
npmPackages:
  @sveltejs/adapter-auto: ^3.0.0 => 3.3.1
  @sveltejs/kit: ^2.0.0 => 2.7.3
  @sveltejs/vite-plugin-svelte: ^4.0.0 => 4.0.0
  svelte: ^5.0.0 => 5.1.6
  vite: ^5.0.3 => 5.4.10

Severity
annoyance
Additional Information
I still hope SvelteKit replicates the browser behavior and does this automatically..

Please provide a minimal reproduction in the form of a repository.

Sure, it is still reproducible in Firefox:

https://github.com/hyunbinseo/svelte-kit-12922


[WIP] Update data source for Fingal, Ireland

Issue:
The original download: "http://data.fingal.ie/datasets/csv/Trees.csv", link returns a 301 error when running npm run download, as reported in #35.
Fix:
The fix is to update the download to the source of the dataset and to update the link.
Testing:
I tested this by running the pipepline (npm run download, npm run convert and npm run normalize). This yielded data in each of the respective directories (data/raw, data/geojeon and data/normalized).

Hi @zoobot , can you advise on the correct way to update the source for a city?
The good news is, we have a new link to update for Fingal, Ireland which will fix the broken response issue. The challenge is that after the normalized file is created, the download field still has the URL to the csv file mapped to it, which is wrong.
From investigating this, we are creating two sources for Fingal, Ireland in core/sources.js after I've updated it to the new geojson file.
Thank you!
Source 1 (with the original csv file):
{
  "country": "Ireland",
  "city": "Fingal",
  "short": "Fingal",
  "long": "Fingal County",
  "id": "fingal",
  "id_city_name": "fingal",
  "primary": "fingal",
  "center": null,
  "latitude": null,
  "longitude": null,
  "info": "https://data.smartdublin.ie/dataset/tableview/ebf9151e-fd30-442e-93cb-fa88c2affc93",
  "srs": null,
  "brokenDownload": false,
  "download": "http://data.fingal.ie/datasets/csv/Trees.csv",
  "format": "csv",
  "filename": null,
  "gdal_options": null,
  "license": null,
  "email": null,
  "contact": null,
  "crosswalk": {
    "ref": "(x) => Math.round(x.TREE_ID)",
    "scientific": "Species_Desc",
    "common": "Common_Name",
    "maturity": "Age_Desc",
    "height": "Height",
    "spread": "Spread",
    "dbh": "(x) => (x.Actual_Trunk || \"\").replace(\"cm\", \"\")",
    "health": "Condition"
  }
}

Source 2 (with the updated geojson file):
{
  "country": "Ireland",
  "city": "Fingal",
  "short": "Fingal",
  "long": "Fingal County",
  "id": "fingal",
  "id_city_name": "fingal",
  "primary": "fingal",
  "center": null,
  "latitude": null,
  "longitude": null,
  "info": "https://data.fingal.ie/datasets/FingalCoCo::trees-fcc-1/explore",
  "srs": null,
  "brokenDownload": false,
  "download": "https://opendata.arcgis.com/api/v3/datasets/1e5f9db62e53443d946c15a1a06fd98b_0/downloads/data?format=geojson&spatialRefId=4326&where=1%3D1",
  "format": "geojson",
  "filename": null,
  "gdal_options": null,
  "license": null,
  "email": null,
  "contact": null,
  "crosswalk": {
    "ref": "(x) => Math.round(x.TREE_ID)",
    "scientific": "Species_Desc",
    "common": "Common_Name",
    "maturity": "Age_Desc",
    "height": "Height",
    "spread": "Spread",
    "dbh": "(x) => (x.Actual_Trunk || \"\").replace(\"cm\", \"\")",
    "health": "Condition"
  }
}

Did you delete the raw, normalized, and converted file from the old version in data?
I am slightly confused what the issue is, can you rephrase?

Yes I can rephrase -

Updated the Ireland.js file with the new download link for Fingal, changing the file type from csv to geojson.
Deleted any existing datasets for Fingal from data/raw, data/geojson and data/normalized
Ran npm run download, npm run convert and npm run normalized. This generated all of the files in each folder.

The problem is, in the final normalized file, Fingal still shows the previous csv file as the download instead of the geojson file:
(base) camillele @ Camilles-MBP ~/Desktop/waterthetrees/wtt_area/data/normalized
└─ $ ▶ gj fingal.geojsons
{
  "type": "Feature",
  "properties": {
    "scientific": "Acer platanoides",
    "common": "Norway Maple",
    "height": "5.1-10 metres",
    "spread": "3 to 6 metres",
    "health": "Good",
    "id":<PHONE_NUMBER>428474,
    "sourceId": "fingal",
    "city": "Fingal",
    "country": "Ireland",
    "email": null,
    "download": "http://data.fingal.ie/datasets/csv/Trees.csv",
    "info": "https://data.smartdublin.ie/dataset/tableview/ebf9151e-fd30-442e-93cb-fa88c2affc93",
    "lat": 53.48700715,
    "lng": -6.155595148,
    "count": 1
  },
  "geometry": {
    "type": "Point",
    "coordinates": [
      -6.155595148,
      53.48700715
    ]
  },
  "id":<PHONE_NUMBER>428474
}

Thanks for taking a look and for the suggestion! That fixed the issue 😸 I re-ran the scripts and the output has the correct download file.
(base) camillele @ Camilles-MBP ~/Desktop/waterthetrees/wtt_area/data/normalized
└─ $ ▶ gj fingal.geojsons
{
  "type": "Feature",
  "properties": {
    "scientific": "Acer platanoides",
    "common": "Norway Maple",
    "height": "5.1-10 metres",
    "spread": "3 to 6 metres",
    "health": "Good",
    "id":<PHONE_NUMBER>428474,
    "sourceId": "fingal",
    "city": "Fingal",
    "country": "Ireland",
    "email": null,
    "download": "https://opendata.arcgis.com/api/v3/datasets/1e5f9db62e53443d946c15a1a06fd98b_0/downloads/data?format=geojson&spatialRefId=4326&where=1%3D1",
    "info": "https://data.fingal.ie/datasets/FingalCoCo::trees-fcc-1/explore",
    "lat": 53.48700715,
    "lng": -6.155595148,
    "count": 1
  },
  "geometry": {
    "type": "Point",
    "coordinates": [
      -6.155595148,
      53.48700715
    ]
  },
  "id":<PHONE_NUMBER>428474
}


How many unique icons can jdenticon generate?

Put another way, how much entropy is in the image? 32 bits? 64 bits? etc.
Thanks!

See this approximation of the number of possible icons generated by Jdenticon.
This should represent approximately 20 bits of information per icon.

See this approximation of the number of possible icons generated by Jdenticon.
This should represent approximately 20 bits of information per icon.


feat(macos, windows, linux): Add is_always_on_top method to check if a window is always on top

I couldn't find a way to get the "keep above" property through GTK, so the is_always_on_top method is not implemented for Linux.
Relate: https://github.com/tauri-apps/tauri/issues/11078

you can check https://docs.rs/gdk/0.18.0/gdk/struct.Window.html#method.state and check if it has https://docs.rs/gdk/0.18.0/gdk/struct.WindowState.html#associatedconstant.ABOVE flag

Why use placeholder functions instead of using compile-time conditions to control platform-specific interfaces?

Why use placeholder functions instead of using compile-time conditions to control platform-specific interfaces?

This was something inherited from winit crate when we forked it.

Thank you


Deployment failure with minikube v1.19

Similar to https://github.com/trustbloc/k8s/issues/9

https://github.com/trustbloc/k8s/issues/9#issuecomment-840566836


More docs fixes

Preview: https://deploy-preview-39741--twbs-bootstrap.netlify.app/
Split from #39724

We use linkinator for internal links only right now. We could use it for external links too, but it results to many false positives.
So, I mostly use https://validator.w3.org/checklink and https://www.drlinkcheck.com/ ignoring robots.txt on the main branch's Netlify preview.


Refactor web components

Use context manager like protocol for RestApi objects too

Current coverage is 100.00%

Merging #14 into master will not affect coverage as of 4bdfcb1

@@            master     #14   diff @@
======================================
  Files           14      14
  Stmts          450     470    +20
  Branches         0       0
  Methods          0       0
======================================
+ Hit            450     470    +20
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of 4bdfcb1

Powered by Codecov. Updated on successful CI builds.


Add Line Number Attribute to Every Div Rendered from pdf.js

Hello All,
Can Anybody plz guide how can we mark the line number of every line while rendering the pdf in coordination with that of Original pdf lines.
To elaborate, [<div data-canvas-width="439.021448245499" ] is given by pdf.js, i want to get the similar attribute for each line for ex.[<div data-canvas-LINE_NUMBER=1] and so on in the continued manner.

You will have to modify the text layer builder component (https://github.com/mozilla/pdf.js/blob/master/web/text_layer_builder.js) and keep line counts yourself, however that is not a trivial task as PDFs do not contain line numbers as far as I know, so you would have to determine where the end of a line is (for example by checking the drawing coordinates). Closing as out of scope for the PDF.js library itself though: for assistance with this, please use IRC or the mailing list, as this issue tracker is only used for tracking bugs in PDF.js.

Thanks for the reply,
Actually Basic issue which i am facing is, while rendering the pdf in different screen resolutions, the top Style of every div changes, as it is based on pixel based, can it be changed on percentage basis, or can we render the pdf in some default screen resolution. ex.1440*900, Plz let   me  know if there is any alternative solution.

Everything is done in pixels, so switching to percentages will be hard. However, there is https://github.com/mozilla/pdf.js/blob/master/web/text_layer_builder.js#L181-L182 you might need for your change.

Hi, Thanks again for reply, will look into this line of code in-depth.
i want also to restrict the search (ctrl+F) [find bar] functionality to single page. or else provide page number while searching. any suggestion will be welcome.
Thanks in advance.

There is https://github.com/mozilla/pdf.js/blob/master/web/pdf_find_controller.js. Please look into the /web folder as most code you will need is there. Since we're getting off-topic here, please use IRC or the mailing list for new questions.


Include schema name when checking for the existence of a hypertable

In addition to django-timescaledb I'm using the django-tenants library which creates a separate schema for each tenant where the tables of that tenant will live.
If I have a hypertable model that should be created for each tenant, I'll run into an error when I create my second tenant, because a hypertable for that model already exists but in a different schema, and the sql statement to check for the existence of a hypertable ignores the "hypertable_schema" column. See image:

Notice how there are two hypertables with the same name, but they're in different schemas, which should be totally fine. They won't affect each other at all.
So I included the hypertable_schema column in the sql statements that check for the existence of hypertable.

This issue is not directly related to the django-timescaledb library since it only applies for someone who also uses the other library django-tenants. I don't know how you'd feel about merging this code in, but I thought I'd create the PR anyway and leave it up to you to decide.

Thanks @bluegrounds for the merge request, I'll a deeper look one of these days, but looks good!

What's the status of this? I would also like to see this merged :)

Merged and a new version has been released to pypi

Awesome! Thank you so much.


crash Exception in server tick loop ATM6

There seems to be a key bind that's causing a crash anytime i hold to shift and try to place a block 3 or 4 blocks away. i tried to change key binds in the config with no change. any help would be appreciated.
crash-2024-09-01_10.36.14-server.txt

---- Minecraft Crash Report ----
// Shall we play a game?
  Please do not report bugs to them!


Honor/Memorial Fields for Recurring Donations/Opportunities

This is a simple customization request, but working with Luminate again reminds me that they actually have thought this through a bit.  This same set of fields existing on both the Recurring Donation and Opportunity Objects (with pre-existing custom mapping, if this is even possible) would enable this quickly for folks without consulting partners needing to spend time building them.

**lurch: attach W-007190

Tracking W-007190

Included in beta release version 3.61 (Beta 3) and higher

Included in production release version 3.61


Honeywell Thermostat Module Broken

Hello,
I'm getting this error when using the Honeywell module.
16-01-25 21:03:06 homeassistant.components.thermostat: Error while setting up platform honeywell
Traceback (most recent call last):
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/helpers/entity_component.py", line 145, in _setup_platform
    self.hass, platform_config, self.add_entities, discovery_info)
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/components/thermostat/honeywell.py", line 44, in setup_platform
    for i, zone in enumerate(zones):
  File "/root/.homeassistant/lib/evohomeclient/__init__.py", line 73, in temperatures
    self._populate_full_data(force_refresh)
  File "/root/.homeassistant/lib/evohomeclient/__init__.py", line 33, in _populate_full_data
    userId = self.user_data['userInfo']['userID']
TypeError: list indices must be integers, not str

@watchforstock do you have any idea?

I thought I saw a post on this a few days ago but I couldn't find it.

I'll have a look too. I have a Honeywell round connected. Right now I'm pretty busy though...

Yes I do. The problem is that underlying Honeywell library is using a token to access the Honeywell servers. The token is only right for EMEA users, not any in the US (as I'm presuming is the issue here). The error is because the return value is saying the username/password are invalid.
I've been given access to the US API by Honeywell, but that's complicated because it's completely different to the one being used (it uses OAuth for authentication for a start). The easy fix would be for someone to sniff the comms between the US version of the App and the servers and extract the application ID which is passed along. I don't have the US version of the app or an account to connect to so I can't do this.
See this thread on the API github for the thread where we tracked down the issue: https://github.com/watchforstock/evohome-client/issues/21

So I'm willing to share my creds or do a TCP dump from the server.  Want me to start with the TCPDUMP?

I might actually be able to fix this, I don't know python --- but it might be worth a try.

So the challenge is that it's all over HTTPS  so just a tcpdump won't help unfortunately. When I did the original reverse engineering, I forced my device (actually an android emulated device) to use a proxy server and then ran a mitm proxy on my machine (https://mitmproxy.org/). This then listed all of the requests and responses. If you were able to do this and capture the initial authentication flow then you should be able to find the ApplicationId (the EMEA ones appears here: https://github.com/watchforstock/evohome-client/blob/master/evohomeclient/init.py#L64)

Another option for running a proxy to capture HTTPS packets is Charles Proxy. It's got a free trial and it's pretty easy to use. https://www.charlesproxy.com/

Here is the custom_component code I'm using to access the Honeywell US api. It works, but it's not pretty, but may be a good starting point. http://pastebin.com/uqAWccH4

This is fixed now in #1142


diff-remove-timestamps: Use sed -E directly

On any sufficiently modern Linux distro, sed -E will work.

On any sufficiently modern Linux distro, sed -E will work.

Evidence for this is that CI for zeek/zeek#3578 passed on all supported platforms with a similar change.


[Bug] exercise "en/python/booleans/9.md" has an issue

Hi,
the solution is:
power=True

"True" is not a Boolean, but a String.