// Copyright (C) 2013 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package com.google.gerrit.server.group;

import static com.google.common.base.Strings.nullToEmpty;

import com.google.gerrit.common.errors.NoSuchGroupException;
import com.google.gerrit.extensions.common.GroupInfo;
import com.google.gerrit.extensions.restapi.MethodNotAllowedException;
import com.google.gerrit.extensions.restapi.RestReadView;
import com.google.gerrit.reviewdb.client.AccountGroupById;
import com.google.gerrit.reviewdb.server.ReviewDb;
import com.google.gerrit.server.account.GroupControl;
import com.google.gwtorm.server.OrmException;
import com.google.inject.Inject;
import com.google.inject.Provider;
import com.google.inject.Singleton;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Comparator;
import java.util.List;
import org.slf4j.Logger;

@Singleton
public class ListIncludedGroups implements RestReadView<GroupResource> {
  private static final Logger log = org.slf4j.LoggerFactory.getLogger(ListIncludedGroups.class);

  private final GroupControl.Factory controlFactory;
  private final Provider<ReviewDb> dbProvider;
  private final GroupJson json;

  @Inject
  ListIncludedGroups(
      GroupControl.Factory controlFactory, Provider<ReviewDb> dbProvider, GroupJson json) {
    this.controlFactory = controlFactory;
    this.dbProvider = dbProvider;
    this.json = json;
  }

  @Override
  public List<GroupInfo> apply(GroupResource rsrc) throws MethodNotAllowedException, OrmException {
    if (rsrc.toAccountGroup() == null) {
      throw new MethodNotAllowedException();
    }

    boolean ownerOfParent = rsrc.getControl().isOwner();
    List<GroupInfo> included = new ArrayList<>();
    for (AccountGroupById u :
        dbProvider.get().accountGroupById().byGroup(rsrc.toAccountGroup().getId())) {
      try {
        GroupControl i = controlFactory.controlFor(u.getIncludeUUID());
        if (ownerOfParent || i.isVisible()) {
          included.add(json.format(i.getGroup()));
        }
      } catch (NoSuchGroupException notFound) {
        log.warn(
            String.format(
                "Group %s no longer available, included into %s",
                u.getIncludeUUID(), rsrc.getGroup().getName()));
        continue;
      }
    }
    Collections.sort(
        included,
        new Comparator<GroupInfo>() {
          @Override
          public int compare(GroupInfo a, GroupInfo b) {
            int cmp = nullToEmpty(a.name).compareTo(nullToEmpty(b.name));
            if (cmp != 0) {
              return cmp;
            }
            return nullToEmpty(a.id).compareTo(nullToEmpty(b.id));
          }
        });
    return included;
  }
}

@@ -701,16 +701,135 @@
 oEmpty;%0A
+import static com.google.common.collect.ImmutableList.toImmutableList;%0A%0Aimport com.google.common.collect.ImmutableList;
 %0Aimport 
@@ -1118,20 +1118,16 @@
 untGroup
-ById
 ;%0Aimport
@@ -1793,16 +1793,47 @@
 ovider;%0A
+  private final Groups groups;%0A
   privat
@@ -1931,16 +1931,22 @@
 Factory,
+%0A     
  Provide
@@ -1968,16 +1968,43 @@
 rovider,
+%0A      Groups groups,%0A     
  GroupJs
@@ -2090,16 +2090,42 @@
 ovider;%0A
+    this.groups = groups;%0A
     this
@@ -2463,42 +2463,102 @@
     
-for (AccountGroupById u :%0A        
+ImmutableList%3CAccountGroup.UUID%3E includedGroupUuids =%0A        groups%0A            .getIncludes(
 dbPr
@@ -2569,18 +2569,26 @@
 er.get()
-.a
+, rsrc.toA
 ccountGr
@@ -2594,53 +2594,126 @@
 roup
-ById().byGroup(rsrc.toAccountGroup().getId())
+().getId())%0A            .collect(toImmutableList());%0A    for (AccountGroup.UUID includedGroupUuid : includedGroupUuids
 ) %7B%0A
@@ -2775,34 +2775,33 @@
 trolFor(
-u.getIncludeUUID()
+includedGroupUuid
 );%0A     
@@ -3081,26 +3081,25 @@
     
-u.getIncludeUUID()
+includedGroupUuid
 , rs

Remove access of groups related db tables from ListIncludedGroups