/*
 * Copyright 2002-2006 the original author or authors.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package org.springframework.aop.framework;

import java.lang.reflect.Method;
import java.util.List;
import java.util.Map;

import org.springframework.core.CollectionFactory;

/**
 * AdvisorChainFactory implementation that caches by method.
 *
 * <p>Uses IdentityHashMap on JDK >= 1.4 or Commons Collections 3.x' IdentityMap
 * (if available), which skip expensive <code>Method.hashCode()</code> calls.
 * Falls back to standard HashMap on plain JDK 1.3.
 *
 * @author Rod Johnson
 * @author Juergen Hoeller
 * @see org.springframework.core.CollectionFactory#createIdentityMapIfPossible
 * @see java.lang.reflect.Method#hashCode
 */
public final class HashMapCachingAdvisorChainFactory implements AdvisorChainFactory {

	/** Cache with Method key and List value */
	private final Map methodCache = CollectionFactory.createIdentityMapIfPossible(32);


	public List getInterceptorsAndDynamicInterceptionAdvice(
			Advised config, Object proxy, Method method, Class targetClass) {

		List cached = (List) this.methodCache.get(method);
		if (cached == null) {
			// recalculate
			cached = AdvisorChainFactoryUtils.calculateInterceptorsAndDynamicInterceptionAdvice(
					config, proxy, method, targetClass);
			this.methodCache.put(method, cached);
		}
		return cached;
	}

	public void activated(AdvisedSupport advisedSupport) {
	}

	public void adviceChanged(AdvisedSupport advisedSupport) {
		this.methodCache.clear();
	}

}

@@ -1242,16 +1242,18 @@
 hashCode
+()
 %0A */%0Apub
@@ -1595,16 +1595,53 @@
 ass) %7B%0A%0A
+%09%09synchronized (this.methodCache) %7B%0A%09
 %09%09List c
@@ -1687,16 +1687,17 @@
 hod);%0A%09%09
+%09
 if (cach
@@ -1715,25 +1715,8 @@
  %7B%0A%09
-%09%09// recalculate%0A
 %09%09%09c
@@ -1799,16 +1799,17 @@
 Advice(%0A
+%09
 %09%09%09%09%09con
@@ -1845,16 +1845,17 @@
 ss);%0A%09%09%09
+%09
 this.met
@@ -1886,18 +1886,20 @@
 hed);%0A%09%09
+%09
 %7D%0A
+%09
 %09%09return
@@ -1907,16 +1907,20 @@
 cached;%0A
+%09%09%7D%0A
 %09%7D%0A%0A%09pub
@@ -2035,16 +2035,53 @@
 port) %7B%0A
+%09%09synchronized (this.methodCache) %7B%0A%09
 %09%09this.m
@@ -2100,14 +2100,18 @@
 lear();%0A
+%09%09%7D%0A
 %09%7D%0A%0A%7D%0A

use synchronized access to methodCache Map