/*
 * Zorbage: an algebraic data hierarchy for use in numeric processing.
 *
 * Copyright (C) 2016-2019 Barry DeZonia
 * 
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions are met:
 * 
 * 1. Redistributions of source code must retain the above copyright notice,
 *    this list of conditions and the following disclaimer.
 * 2. Redistributions in binary form must reproduce the above copyright notice,
 *    this list of conditions and the following disclaimer in the documentation
 *    and/or other materials provided with the distribution.
 * 
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
 * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
 * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
 * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 * POSSIBILITY OF SUCH DAMAGE.
 */
package nom.bdezonia.zorbage.procedure.impl;

import nom.bdezonia.zorbage.procedure.Procedure2;
import nom.bdezonia.zorbage.type.algebra.Algebra;
import nom.bdezonia.zorbage.type.algebra.Ordered;
import nom.bdezonia.zorbage.type.algebra.Unity;

/**
 * 
 * @author Barry DeZonia
 *
 */
public class Step<T extends Algebra<T,U> & Ordered<U> & Unity<U>, U>
	implements Procedure2<U,U>
{
	private final T algebra;
	private final U zero;
	private final U h0;
	
	/**
	 * Heaviside step function. 
	 * 
	 * @param algebra
	 * @param h0 The value to return if the input is 0. Common values
	 *   are 0, 1/2, and 1.
	 */
	public Step(T algebra, U h0) {
		this.algebra = algebra;
		this.zero = algebra.construct();
		this.h0 = algebra.construct();
		algebra.assign().call(h0, this.h0);
		U one = algebra.construct();
		algebra.unity().call(one);
		if (algebra.isLess().call(h0, zero) || algebra.isGreater().call(h0, one))
			throw new IllegalArgumentException("step: h0 out of sensible range");
	}
	
	@Override
	public void call(U a, U b) {
		int s = algebra.signum().call(a);
		if (s < 0)
			algebra.assign().call(zero, b);
		else if (s > 0)
			algebra.unity().call(b);
		else
			algebra.assign().call(h0, b);
	}

}

@@ -1857,16 +1857,38 @@
 U zero;%0A
+%09private final U one;%0A
 %09private
@@ -1900,16 +1900,16 @@
 l U h0;%0A
-
 %09%0A%09/**%0A%09
@@ -2224,18 +2224,21 @@
 .h0);%0A%09%09
-U 
+this.
 one = al
@@ -2593,29 +2593,30 @@
 algebra.
-unity
+assign
 ().call(
 b);%0A%09%09el
@@ -2607,16 +2607,21 @@
 ().call(
+one, 
 b);%0A%09%09el

Make some code more internally consistent