/*
 * Copyright (c) 2015 Spotify AB.
 *
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
 * to you under the Apache License, Version 2.0 (the
 * "License"); you may not use this file except in compliance
 * with the License.  You may obtain a copy of the License at
 *
 *   http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing,
 * software distributed under the License is distributed on an
 * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 * KIND, either express or implied.  See the License for the
 * specific language governing permissions and limitations
 * under the License.
 */

package com.spotify.heroic.aggregation.simple;

import static com.spotify.heroic.common.Optionals.firstPresent;

import java.util.ArrayList;
import java.util.List;
import java.util.Optional;
import java.util.concurrent.TimeUnit;

import com.google.common.base.Joiner;
import com.google.common.collect.ImmutableList;
import com.spotify.heroic.aggregation.Aggregation;
import com.spotify.heroic.aggregation.AggregationContext;
import com.spotify.heroic.aggregation.AggregationInstance;
import com.spotify.heroic.aggregation.SamplingQuery;
import com.spotify.heroic.common.Duration;

import lombok.Data;

@Data
public abstract class SamplingAggregation implements Aggregation {
    public static final Joiner params = Joiner.on(", ");

    private final Optional<Duration> size;
    private final Optional<Duration> extent;

    @Override
    public AggregationInstance apply(final AggregationContext context) {
        final Duration s = firstPresent(size, context.size()).orElseGet(context::defaultSize);
        final Duration e = firstPresent(extent, context.extent()).orElseGet(context::defaultExtent);
        return apply(context, s.convert(TimeUnit.MILLISECONDS), e.convert(TimeUnit.MILLISECONDS));
    }

    @Override
    public Optional<Long> size() {
        return size.map(Duration::toMilliseconds);
    }

    @Override
    public Optional<Long> extent() {
        return extent.map(Duration::toMilliseconds);
    }

    protected String samplingDSL(final String name) {
        return samplingDSL(name, ImmutableList.of());
    }

    protected String samplingDSL(final String name, final List<String> extra) {
        final List<String> arguments = new ArrayList<>();
        size.map(Duration::toDSL).ifPresent(arguments::add);
        extent.map(Duration::toDSL).ifPresent(arguments::add);
        arguments.addAll(extra);

        if (arguments.isEmpty()) {
            return name;
        }

        return String.format("%s(%s)", name, params.join(arguments));
    }

    protected abstract AggregationInstance apply(AggregationContext context, long size,
            long extent);
}

@@ -1327,61 +1327,8 @@
 ce;%0A
-import com.spotify.heroic.aggregation.SamplingQuery;%0A
 impo

fix checkstyle failure