#!/usr/bin/env python
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License.  You may obtain a copy of the License at
#
#   http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied.  See the License for the
# specific language governing permissions and limitations
# under the License.
"""
Check things about newsfragments:
  - Only a single line, except for `significant` changes which can have a blank line, then the body
"""

import sys

files = sys.argv[1:]

failed = False
for filename in files:
    with open(filename) as f:
        lines = [line.strip() for line in f.readlines()]
    num_lines = len(lines)

    if "significant" not in filename:
        if num_lines != 1:
            print(f"Newsfragement {filename} can only have a single line.")
            failed = True
    else:
        # significant newsfragment
        if num_lines == 1:
            continue
        if num_lines == 2:
            print(f"Newsfragement {filename} can have 1, or 3+ lines.")
            failed = True
            continue
        if lines[1] != "":
            print(f"Newsfragement {filename} must have an empty second line.")
            failed = True
            continue

if failed:
    sys.exit(1)

@@ -955,16 +955,130 @@
 port sys
+%0Afrom pathlib import Path%0A%0AVALID_CHANGE_TYPES = %7B%22significant%22, %22feature%22, %22improvement%22, %22bugfix%22, %22doc%22, %22misc%22%7D
 %0A%0Afiles 
@@ -1254,40 +1254,487 @@
     
-if %22significant%22 not in filename
+name_parts = Path(filename).name.split('.')%0A    if len(name_parts) != 3:%0A        print(f%22Newsfragment %7Bfilename%7D has an unexpected filename. Should be %7B%7Bpr_number%7D%7D.%7B%7Btype%7D%7D.rst.%22)%0A        failed = True%0A        continue%0A%0A    change_type = name_parts%5B1%5D%0A    if change_type not in VALID_CHANGE_TYPES:%0A        print(f%22Newsfragment %7Bfilename%7D has an unexpected type. Should be one of %7BVALID_CHANGE_TYPES%7D.%22)%0A        failed = True%0A        continue%0A%0A    if change_type != %22significant%22
 :%0A  
@@ -1778,33 +1778,32 @@
 print(f%22Newsfrag
-e
 ment %7Bfilename%7D 
@@ -1999,33 +1999,32 @@
 print(f%22Newsfrag
-e
 ment %7Bfilename%7D 
@@ -2152,17 +2152,16 @@
 Newsfrag
-e
 ment %7Bfi

Validate newsfragment types (#25536)