# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
#      http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.

import binascii
import os.path
import random
import subprocess

from reno import defaults


def get_notes_dir(args):
    """Return the path to the release notes directory."""
    return os.path.join(args.relnotesdir, defaults.NOTES_SUBDIR)


def get_random_string(nbytes=8):
    """Return a fixed-length random string

    :rtype: six.text_type
    """
    try:
        # NOTE(dhellmann): Not all systems support urandom().
        # hexlify returns six.binary_type, decode to convert to six.text_type.
        val = binascii.hexlify(os.urandom(nbytes)).decode('utf-8')
    except Exception as e:
        print('ERROR, perhaps urandom is not supported: %s' % e)
        val = u''.join(u'%02x' % random.randrange(256)
                       for i in range(nbytes))
    return val


def check_output(*args, **kwds):
    """Unicode-aware wrapper for subprocess.check_output"""
    raw = subprocess.check_output(*args, **kwds)
    return raw.decode('utf-8')

@@ -555,16 +555,41 @@
 inascii%0A
+import logging%0Aimport os%0A
 import o
@@ -655,16 +655,51 @@
 faults%0A%0A
+LOG = logging.getLogger(__name__)%0A%0A
 %0Adef get
@@ -1477,19 +1477,23 @@
 %22%22%22%0A    
-raw
+process
  = subpr
@@ -1502,50 +1502,451 @@
 ess.
-check_output(*args, **kwds)%0A    return raw
+Popen(stdout=subprocess.PIPE,%0A                               stderr=subprocess.PIPE,%0A                               *args, **kwds)%0A    output, errors = process.communicate()%0A    retcode = process.poll()%0A    if errors:%0A        LOG.debug('error output from (%25s): %25s',%0A                  ' '.join(*args),%0A                  errors.rstrip())%0A    if retcode:%0A        raise subprocess.CalledProcessError(retcode, args, output=output)%0A    return output
 .dec

manage stderr output from external commands