net/mlx5: fix suffix flow creation in metadata split
net/mlx5: fix suffix flow creation in metadata split

The variable cleanup was erroneously done before pointer usage.
The cleanup is moved to appropriate place, comment is clarified.

Fixes: 8d72fa668964 ("net/mlx5: share tag between meter and metadata")

Reported-by: Eli Britstein <c54ad588c3167261842bc40039d7bd4571322ce1@mellanox.com>
Signed-off-by: Viacheslav Ovsiienko <5b8db9bb93a9a9aefc8828f79604d1fe963a53dd@mellanox.com>
Acked-by: Matan Azrad <6969f5f553ad7652679a585a85d7321babc90464@mellanox.com>

john-mcnamara-intel/dpdk,john-mcnamara-intel/dpdk,john-mcnamara-intel/dpdk,john-mcnamara-intel/dpdk