heat engine : Autoscaling reload Loadbalancer correctly
heat engine : Autoscaling reload Loadbalancer correctly

Since the change implemented as part of bug #1136148 we no longer
wait for nova to create the instance before reloading the loadbalancer
which means we race nova assigning an IP to the instance and typically
the loadbalancer config ends up with the 0.0.0.0 default value
which the loadbalancer implementation uses when nova returns no IP.

This patch moves the LB reload into a separate function, which is called
after instances are active on group creation or adjustment

Since our loadbalancer is broken without this fix, this is a candidate
for backporting to grizzly milestone-proposed.

fixes bug #1160407

Change-Id: I50423883dead9a615aa79b8765d5480a9345686d

steveb/heat,maestro-hybrid-cloud/heat,steveb/heat,rdo-management/heat,jasondunsmore/heat,pratikmallya/heat,miguelgrinberg/heat,ntt-sic/heat,dims/heat,cwolferh/heat-scratch,gonzolino/heat,gonzolino/heat,redhat-openstack/heat,dragorosson/heat,dragorosson/heat,takeshineshiro/heat,jasondunsmore/heat,cryptickp/heat,pshchelo/heat,NeCTAR-RC/heat,cwolferh/heat-scratch,citrix-openstack-build/heat,miguelgrinberg/heat,JioCloud/heat,maestro-hybrid-cloud/heat,rickerc/heat_audit,srznew/heat,srznew/heat,pratikmallya/heat,openstack/heat,NeCTAR-RC/heat,rh-s/heat,varunarya10/heat,JioCloud/heat,rdo-management/heat,noironetworks/heat,pshchelo/heat,openstack/heat,citrix-openstack-build/heat,noironetworks/heat,rickerc/heat_audit,takeshineshiro/heat,rh-s/heat,cryptickp/heat,redhat-openstack/heat,ntt-sic/heat,varunarya10/heat,dims/heat