collectd: Don't use the network stack before it is set up
collectd: Don't use the network stack before it is set up

The current code (this will change soon with my reactor patches)
constructs a default (Posix) network stack before reactore::configure()
reassigns it to the requested network stack.

It turns out there is one place we use the network stack before calling
reactore::configure(), which ends up using the Posix stack even though
we want the native stack - this is both silly and plainly doesn't work on
the OSv setup.

The problem is that app_template.hh tries to configure scollectd before
the engine is started. This calls scollectd::impl::start() which calls
engine.net().make_udp_channel(). When this happens this early, it creates
a Posix socket...

This patch moves the scollectd configuration to after the engine is
started. It makes sense to me: As far as I understand, scollectd is all
about sending packets (diagnostic packets), and it's kind of silly to
start sending packets before starting the machinary which allows us to
send packets.

Signed-off-by: Nadav Har'El <625169824b719df98706d88646d0aae6f368ae4d@cloudius-systems.com>
[avi: use customary indentation, remove unneeded make_ready_future()]

anzihenry/seastar,chunshengster/seastar,wildinto/seastar,bzero/seastar,guiquanz/scylla,stamhe/scylla,scylladb/seastar,xtao/seastar,phonkee/scylla,bzero/seastar,phonkee/scylla,koolhazz/seastar,sjperkins/seastar,raphaelsc/seastar,scylladb/seastar,syuu1228/seastar,kjniemi/scylla,capturePointer/scylla,gwicke/scylla,aruanruan/scylla,shaunstanislaus/scylla,sjperkins/seastar,gwicke/scylla,wildinto/scylla,kjniemi/seastar,tempbottle/seastar,stamhe/scylla,norcimo5/seastar,duarten/scylla,scylladb/scylla,flashbuckets/seastar,glommer/scylla,acbellini/scylla,chunshengster/seastar,bowlofstew/seastar,shaunstanislaus/scylla,syuu1228/seastar,acbellini/seastar,bzero/seastar,acbellini/scylla,avikivity/seastar,eklitzke/scylla,wildinto/seastar,linearregression/seastar,bowlofstew/scylla,rluta/scylla,scylladb/scylla,linearregression/scylla,tempbottle/scylla,slivne/seastar,chunshengster/seastar,guiquanz/scylla,senseb/scylla,norcimo5/seastar,hongliangzhao/seastar,duarten/scylla,avikivity/seastar,joerg84/seastar,raphaelsc/seastar,scylladb/seastar,cloudius-systems/seastar,justintung/scylla,kjniemi/seastar,linearregression/scylla,anzihenry/seastar,koolhazz/seastar,scylladb/scylla,asias/scylla,hongliangzhao/seastar,eklitzke/scylla,raphaelsc/scylla,respu/scylla,kjniemi/seastar,printedheart/seastar,scylladb/scylla,ducthangho/imdb,raphaelsc/scylla,bowlofstew/seastar,victorbriz/scylla,joerg84/seastar,acbellini/seastar,shyamalschandra/seastar,avikivity/seastar,victorbriz/scylla,koolhazz/seastar,shyamalschandra/seastar,ducthangho/imdb,scylladb/scylla-seastar,scylladb/scylla-seastar,acbellini/seastar,leejir/seastar,gwicke/scylla,senseb/scylla,avikivity/scylla,aruanruan/scylla,jonathanleang/seastar,leejir/seastar,bowlofstew/seastar,tempbottle/seastar,syuu1228/seastar,respu/scylla,flashbuckets/seastar,dwdm/seastar,anzihenry/seastar,dwdm/seastar,rluta/scylla,kangkot/scylla,stamhe/scylla,linearregression/scylla,acbellini/scylla,victorbriz/scylla,guiquanz/scylla,shaunstanislaus/scylla,shyamalschandra/seastar,dwdm/scylla,glommer/scylla,scylladb/scylla-seastar,leejir/seastar,flashbuckets/seastar,tempbottle/scylla,linearregression/seastar,rentongzhang/scylla,asias/scylla,dwdm/scylla,rluta/scylla,avikivity/scylla,phonkee/scylla,bowlofstew/scylla,printedheart/seastar,stamhe/seastar,kangkot/scylla,dwdm/seastar,raphaelsc/scylla,jonathanleang/seastar,dwdm/scylla,duarten/scylla,norcimo5/seastar,raphaelsc/seastar,respu/scylla,stamhe/seastar,xtao/seastar,cloudius-systems/seastar,avikivity/scylla,ducthangho/imdb,wildinto/scylla,kjniemi/scylla,senseb/scylla,hongliangzhao/seastar,asias/scylla,dreamsxin/seastar,slivne/seastar,printedheart/seastar,bowlofstew/scylla,tempbottle/scylla,linearregression/seastar,dreamsxin/seastar,kangkot/scylla,jonathanleang/seastar,wildinto/seastar,rentongzhang/scylla,joerg84/seastar,sjperkins/seastar,rentongzhang/scylla,cloudius-systems/seastar,eklitzke/scylla,xtao/seastar,stamhe/seastar,tempbottle/seastar,mixja/seastar,capturePointer/scylla,justintung/scylla,dreamsxin/seastar,slivne/seastar,justintung/scylla,mixja/seastar,mixja/seastar,aruanruan/scylla,capturePointer/scylla,glommer/scylla,wildinto/scylla,kjniemi/scylla