[infer][ondemnad] remove the call to `Summary.write_summary` in BufferOverrun which is no longer necessary
[infer][ondemnad] remove the call to `Summary.write_summary` in BufferOverrun which is no longer necessary

Summary: Writing the summaries to disk now happens automatically during the on-demand analysis calls. So, individual checkers do not need to worry anymore about when should the analysis summaries be written to disk for the interprocedural analysis to do the right thing.

Reviewed By: sblackshear

Differential Revision: D4764337

fbshipit-source-id: 63870db

ropas/infer,facebook/infer,jsachs/infer,jsachs/infer,ryoon/infer,jvillard/infer,blzq/infer,blzq/infer,facebook/infer,jsachs/infer,facebook/infer,blzq/infer,ryoon/infer,jsachs/infer,jvillard/infer,jvillard/infer,jsachs/infer,facebook/infer,ropas/infer,jvillard/infer,blzq/infer,jvillard/infer,ryoon/infer,facebook/infer,ryoon/infer,facebook/infer,jvillard/infer,ryoon/infer,ropas/infer,ryoon/infer,blzq/infer,ropas/infer,ropas/infer,ropas/infer,jvillard/infer,facebook/infer,blzq/infer,jsachs/infer