[sil] Catch if we are creating ABI incompatible convert_function instructions when constructing the inst.
[sil] Catch if we are creating ABI incompatible convert_function instructions when constructing the inst.

I ran into this earlier today. It is a pretty annoying error to track down in
SILGen since the verifier doesn't run until the full function is emitted. With
this change, we get a check immediately when the value is constructed by
SILBuilder making it a very easy problem to track down.

apple/swift,alblue/swift,harlanhaskins/swift,sschiau/swift,rudkx/swift,jmgc/swift,danielmartin/swift,lorentey/swift,harlanhaskins/swift,ahoppen/swift,benlangmuir/swift,harlanhaskins/swift,natecook1000/swift,allevato/swift,danielmartin/swift,huonw/swift,jckarter/swift,apple/swift,jckarter/swift,shahmishal/swift,huonw/swift,jckarter/swift,stephentyrone/swift,shajrawi/swift,practicalswift/swift,lorentey/swift,frootloops/swift,shajrawi/swift,tjw/swift,karwa/swift,zisko/swift,amraboelela/swift,gribozavr/swift,karwa/swift,alblue/swift,tjw/swift,roambotics/swift,amraboelela/swift,shahmishal/swift,lorentey/swift,jopamer/swift,roambotics/swift,huonw/swift,stephentyrone/swift,allevato/swift,zisko/swift,xwu/swift,zisko/swift,jckarter/swift,sschiau/swift,rudkx/swift,xedin/swift,alblue/swift,gregomni/swift,jckarter/swift,amraboelela/swift,rudkx/swift,brentdax/swift,natecook1000/swift,brentdax/swift,jopamer/swift,devincoughlin/swift,xedin/swift,gribozavr/swift,roambotics/swift,alblue/swift,hooman/swift,tkremenek/swift,hooman/swift,hooman/swift,stephentyrone/swift,shajrawi/swift,gregomni/swift,CodaFi/swift,roambotics/swift,austinzheng/swift,parkera/swift,CodaFi/swift,ahoppen/swift,alblue/swift,practicalswift/swift,nathawes/swift,shajrawi/swift,harlanhaskins/swift,shajrawi/swift,brentdax/swift,practicalswift/swift,brentdax/swift,allevato/swift,jopamer/swift,CodaFi/swift,aschwaighofer/swift,tjw/swift,amraboelela/swift,zisko/swift,jckarter/swift,practicalswift/swift,frootloops/swift,glessard/swift,airspeedswift/swift,karwa/swift,nathawes/swift,gribozavr/swift,tkremenek/swift,CodaFi/swift,atrick/swift,alblue/swift,lorentey/swift,devincoughlin/swift,benlangmuir/swift,apple/swift,devincoughlin/swift,zisko/swift,shahmishal/swift,rudkx/swift,austinzheng/swift,shahmishal/swift,ahoppen/swift,sschiau/swift,JGiola/swift,devincoughlin/swift,allevato/swift,atrick/swift,xwu/swift,xedin/swift,frootloops/swift,natecook1000/swift,harlanhaskins/swift,jopamer/swift,natecook1000/swift,atrick/swift,lorentey/swift,jmgc/swift,glessard/swift,sschiau/swift,airspeedswift/swift,apple/swift,tkremenek/swift,ahoppen/swift,austinzheng/swift,sschiau/swift,ahoppen/swift,jopamer/swift,gregomni/swift,austinzheng/swift,jckarter/swift,sschiau/swift,practicalswift/swift,nathawes/swift,benlangmuir/swift,karwa/swift,huonw/swift,amraboelela/swift,airspeedswift/swift,stephentyrone/swift,karwa/swift,atrick/swift,karwa/swift,atrick/swift,JGiola/swift,danielmartin/swift,JGiola/swift,harlanhaskins/swift,tjw/swift,rudkx/swift,nathawes/swift,allevato/swift,jmgc/swift,gregomni/swift,jmgc/swift,karwa/swift,lorentey/swift,ahoppen/swift,austinzheng/swift,brentdax/swift,devincoughlin/swift,shahmishal/swift,parkera/swift,aschwaighofer/swift,shahmishal/swift,xedin/swift,karwa/swift,huonw/swift,tjw/swift,CodaFi/swift,aschwaighofer/swift,gregomni/swift,stephentyrone/swift,benlangmuir/swift,shahmishal/swift,frootloops/swift,airspeedswift/swift,lorentey/swift,aschwaighofer/swift,glessard/swift,benlangmuir/swift,hooman/swift,austinzheng/swift,CodaFi/swift,jmgc/swift,shajrawi/swift,tkremenek/swift,tkremenek/swift,devincoughlin/swift,practicalswift/swift,danielmartin/swift,benlangmuir/swift,JGiola/swift,frootloops/swift,hooman/swift,apple/swift,xwu/swift,nathawes/swift,aschwaighofer/swift,aschwaighofer/swift,zisko/swift,danielmartin/swift,jopamer/swift,tkremenek/swift,danielmartin/swift,roambotics/swift,shahmishal/swift,xwu/swift,CodaFi/swift,gribozavr/swift,brentdax/swift,airspeedswift/swift,glessard/swift,xedin/swift,gribozavr/swift,tkremenek/swift,shajrawi/swift,xedin/swift,xwu/swift,aschwaighofer/swift,stephentyrone/swift,JGiola/swift,parkera/swift,stephentyrone/swift,airspeedswift/swift,parkera/swift,danielmartin/swift,tjw/swift,natecook1000/swift,huonw/swift,parkera/swift,rudkx/swift,shajrawi/swift,parkera/swift,amraboelela/swift,glessard/swift,amraboelela/swift,devincoughlin/swift,hooman/swift,jmgc/swift,sschiau/swift,sschiau/swift,practicalswift/swift,gribozavr/swift,JGiola/swift,tjw/swift,allevato/swift,apple/swift,xwu/swift,glessard/swift,parkera/swift,allevato/swift,gregomni/swift,xedin/swift,jmgc/swift,airspeedswift/swift,huonw/swift,atrick/swift,nathawes/swift,frootloops/swift,frootloops/swift,practicalswift/swift,zisko/swift,natecook1000/swift,brentdax/swift,lorentey/swift,parkera/swift,nathawes/swift,gribozavr/swift,gribozavr/swift,xedin/swift,austinzheng/swift,harlanhaskins/swift,roambotics/swift,hooman/swift,natecook1000/swift,alblue/swift,devincoughlin/swift,jopamer/swift,xwu/swift