Changes goog.ui.Dialog's decorateInternal() to not read back its content element's .innerHTML.
Changes goog.ui.Dialog's decorateInternal() to not read back its content
element's .innerHTML.

Doing so appears to have been unnecessary: The read only took place if the
dialog had a content element at the time decorateInternal was called.  In that
case, the element's innerHTML was saved in Dialog's content_ field; however the
value is then never used again (content_ is used in createDom, but that
wouldn't be sensibly called after decorateInternal()).

It is possible for client code to observe the change introduced by this CL:
Client code that uses decorate/decorateInternal to initialize a dialog, and
then reads getContent(). However, this wouldn't seem to make much sense
(except perhaps in tests). A review of (the few) calls to getContent from
production code indicates this pattern is not used in practice, and there were
no test failures on global presubmit.

Why make this change?
* Reading .innerHTML can result in security (XSS) vulnerabilities due to bugs
in browser implementations of HTML reserialization (see
http://dl.acm.org/citation.cfm?id=2516723). This change removes the
possibilty of such bugs due in Dialog's implementation.
* It simplifies a planned refactoring of goog.ui.Dialog to use
goog.html.SafeHtml as the type of its content_ field.
Removing the read of innerHTML avoids the need for an unsafe conversion from
string to HTML in Dialog's implementation.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=56869273

gterzian/closure-library,AlastairTaft/closure-library,moagrius/closure-library,jvu/closure-library,teppeis/closure-library,ChadKillingsworth/closure-library,neraliu/closure-library,vlkous/closure-library,gterzian/closure-library,gfredericks/closure-library,manakor/closure-library,lewistg/closure-library,rikuayanokozy/closure-library,ChadKillingsworth/closure-library,igrep/closure-library,ducklord/closure-library,AlexanderZon/closure-library,neraliu/closure-library,jvu/closure-library,manakor/closure-library,moagrius/closure-library,jupeter/composer-closure-library,real/closure-library,maureknob/blockly-maure,AlexanderZon/closure-library,JasOXIII/closure-library,gingerik/closure-library,ralic/closure-library,jhiswin/idiil-closure-library,jupeter/composer-closure-library,chone/closure-library,Prinhotels/closure-library,Medium/closure-library,lewistg/closure-library,Ju2ender/closure-library,vincenta/closure-library,mrourke/closure-library,Luzzifa/closure-library,fivetran/closure-library,teppeis/closure-library.old,fivetran/closure-library,yathit/closure-library,jbnicolai/closure-library,igrep/closure-library,Ju2ender/closure-library,igrep/closure-library,google/closure-library,manakor/closure-library,chone/closure-library,Luzzifa/closure-library,chone/closure-library,sevaseva/closure-library,sevaseva/closure-library,AlexanderZon/closure-library,grpbwl/closure-library,grpbwl/closure-library,Luzzifa/closure-library,mrourke/closure-library,jeffbcross/closure-library,kangkot/closure-library,teppeis/closure-library,ChadKillingsworth/closure-library,ominux/closure-library,lewistg/closure-library,redforks/closure-library,jhiswin/idiil-closure-library,ikabirov/closure-library,JasOXIII/closure-library,JasOXIII/closure-library,real/closure-library,jeffbcross/closure-library,gfredericks/closure-library,federkasten/closure-library,jooking/closure-library,gterzian/closure-library,jupeter/composer-closure-library,jhiswin/idiil-closure-library,jbnicolai/closure-library,teppeis/closure-library,Medium/closure-library,JasOXIII/closure-library,sunilkumargit/closure-library,AlastairTaft/closure-library,AlastairTaft/closure-library,Tinkerforge/tvpl-closure-library,jooking/closure-library,nicks/closure-library,redforks/closure-library,nanaze/closure-rhino-fork,vlkous/closure-library,mail-apps/closure-library,Anish2/closure-library,codyebberson/closure-library,yathit/closure-library,Medium/closure-library,concavelenz/closure-library,Dominator008/closure-library,codyebberson/closure-library,Ju2ender/closure-library,kangkot/closure-library,sunilkumargit/closure-library,nicks/closure-library,Anish2/closure-library,bebbi/closure-library,nicks/closure-library,igrep/closure-library,valerysamovich/closure-library,valerysamovich/closure-library,vincenta/closure-library,jeffbcross/closure-library,ChadKillingsworth/closure-library,nanaze/closure-rhino-fork,google/closure-library,maureknob/blockly-maure,maureknob/blockly-maure,sevaseva/closure-library,moagrius/closure-library,nanaze/closure-rhino-fork,Tinkerforge/tvpl-closure-library,lucidsoftware/closure-library,codyebberson/closure-library,Tinkerforge/tvpl-closure-library,jhiswin/idiil-closure-library,Prinhotels/closure-library,wenzowski/closure-library,mail-apps/closure-library,Dominator008/closure-library,vlkous/closure-library,lewistg/closure-library,platinumpixs/google-closure-library,manakor/closure-library,chrisprice/closure-library,joeltine/closure-library,Anish2/closure-library,real/closure-library,jooking/closure-library,ominux/closure-library,joeltine/closure-library,kencheung/closure-library,AlastairTaft/closure-library,jbnicolai/closure-library,ikabirov/closure-library,lucidsoftware/closure-library,federkasten/closure-library,jbnicolai/closure-library,vincenta/closure-library,redforks/closure-library,wenzowski/closure-library,bebbi/closure-library,kencheung/closure-library,kangkot/closure-library,rikuayanokozy/closure-library,joeltine/closure-library,beni55/closure-library,beni55/closure-library,neraliu/closure-library,Medium/closure-library,kencheung/closure-library,grpbwl/closure-library,federkasten/closure-library,jvu/closure-library,ikabirov/closure-library,chone/closure-library,AlexanderZon/closure-library,fivetran/closure-library,ralic/closure-library,grpbwl/closure-library,valerysamovich/closure-library,platinumpixs/google-closure-library,Tinkerforge/tvpl-closure-library,chrisprice/closure-library,ominux/closure-library,vlkous/closure-library,Dominator008/closure-library,gingerik/closure-library,rikuayanokozy/closure-library,Prinhotels/closure-library,yathit/closure-library,Dominator008/closure-library,ducklord/closure-library,ducklord/closure-library,concavelenz/closure-library,gterzian/closure-library,gingerik/closure-library,chrisprice/closure-library,neraliu/closure-library,google/closure-library,ikabirov/closure-library,gingerik/closure-library,plu83/closure-library,vincenta/closure-library,nicks/closure-library,sunilkumargit/closure-library,lucidsoftware/closure-library,Ju2ender/closure-library,mail-apps/closure-library,maureknob/blockly-maure,beni55/closure-library,Luzzifa/closure-library,mrourke/closure-library,moagrius/closure-library,kangkot/closure-library,google/closure-library,teppeis/closure-library.old,teppeis/closure-library,ralic/closure-library,bebbi/closure-library,plu83/closure-library,jeffbcross/closure-library,bebbi/closure-library,real/closure-library,lucidsoftware/closure-library,google/closure-library,alexg-dev/closure-library,wenzowski/closure-library,concavelenz/closure-library,redforks/closure-library,rikuayanokozy/closure-library,gfredericks/closure-library,Anish2/closure-library,mrourke/closure-library,teppeis/closure-library.old,mail-apps/closure-library,jvu/closure-library,alexg-dev/closure-library,plu83/closure-library,sunilkumargit/closure-library,federkasten/closure-library,ducklord/closure-library,valerysamovich/closure-library,joeltine/closure-library,platinumpixs/google-closure-library,ominux/closure-library,yathit/closure-library,gfredericks/closure-library,codyebberson/closure-library,concavelenz/closure-library,beni55/closure-library,chrisprice/closure-library,Prinhotels/closure-library,plu83/closure-library,sevaseva/closure-library,alexg-dev/closure-library,ralic/closure-library,jooking/closure-library,kencheung/closure-library,platinumpixs/google-closure-library,alexg-dev/closure-library