Fix lld detection if both gold and lld are found
Fix lld detection if both gold and lld are found

If you have ld.gold and ld.lld, then ld.gold will be selected by the
detection logic. This patch prioritizes lld by changing the order. The
rationale for checking lld first is that it's (right now) not part of,
say, a default Linux distro installation and if it's available, it's
very likely that it was installed explicitly and should be seen as a
sign of preference. On FreeBSD LLVM is the (default) base toolchain and
the changed order makes sense there as well, since ld.gold can be
available in /usr/local via ports/pkg. I don't have access to macOS and
can't say anything about their LLVM toolchain.

At some point we could add a check for LD=ld.lld or LD=ld.gold as an
optional override to explicitly select a linker.

Since I cannot really remove gcc on Linux, this was the only way to
configure GHC to use ld.lld.

Reviewers: austin, hvr, bgamari

Reviewed By: bgamari

Subscribers: rwbarton, thomie, erikd

Tags: PHID-PROJ-5azim3sqhsf7wzvlvaag

Differential Revision: https://phabricator.haskell.org/D3790

sdiehl/ghc,ezyang/ghc,sdiehl/ghc,shlevy/ghc,ezyang/ghc,shlevy/ghc,ezyang/ghc,ezyang/ghc,ezyang/ghc,sdiehl/ghc,sdiehl/ghc,shlevy/ghc,shlevy/ghc,shlevy/ghc,shlevy/ghc,ezyang/ghc,sdiehl/ghc,ezyang/ghc,shlevy/ghc,sdiehl/ghc,sdiehl/ghc