erl_child_setup.c: fix Android breakage
erl_child_setup.c: fix Android breakage

The Android support in erl_child_setup.c is broken:

1. The close fd loop compares an fd (integer i) with the address of the function
   __system_properties_fd rather than the value of calling that function.
2. This function is locally defined, but its name starts with two underscores
   which is reserved for the implementation.
3. This function is not used outside of this file, so should be static.
4. This function performs a fair amount of work (calls getenv and atoi), which
   would be repeated for each and every fd in the [from,to] range.
5. This function contains an unsed local variable 's'.

Fixed by dropping the __ prefix, making the function static, dropping the unused
local variable, and rewriting the close fd loop to call the function at most once.

derek121/otp,ahmedshafeeq/otp,matwey/otp,g-andrade/otp,lianghaivv/otp,jinshana/otp,bjorng/otp,basho/otp,c-rack/otp,dgud/otp,GinjaNinja32/otp,electricimp/otp,benoitc/otp-1,saleyn/otp,g-andrade/otp,sitexa/otp,krishnakumar4a4/otp,jemsbhai/otp,theom/otp,sdebnath/otp,electricimp/otp,emile/otp,basho/otp,riverrun/otp,jamesruan/otp,klarna/otp,release-project/otp,jemsbhai/otp,lantti/otp,sitexa/otp,bsmr-erlang/otp,massemanet/otp,legoscia/otp,msantos/otp,lianghaivv/otp,krishnakumar4a4/otp,entropiae/otp,RoadRunnr/otp,yangchengjian/otp,ader1990/otp,emacsmirror/erlang,ader1990/otp,lightcyphers/otp,dumbbell/otp,neeraj9/otp,bsmr-erlang/otp,marquisthunder/otp,ader1990/otp,theom/otp,johanclaesson/otp,RGafiyatullin/otp,beni55/otp,erlang/otp,mikpe/otp,ahmedshafeeq/otp,cobusc/otp,erlang/otp,paladim/otp,isvilen/otp,falkevik/otp,RJ/otp,rlipscombe/otp,jj1bdx/otp,basho/otp,vinoski/otp,jemsbhai/otp,vic/otp,mujiatong/otp,jinshana/otp,marquisthunder/otp,gjaldon/otp,lantti/otp,lhslll/otp,derek121/otp,dgud/otp,vic/otp,emile/otp,paulcager/otp,bsmr-erlang/otp,krishnakumar4a4/otp,krishnakumar4a4/otp,lianghaivv/otp,cnbin/otp,stolen/otp,lucafavatella/otp,klarna/otp,c-rack/otp,mikpe/otp,uabboli/otp,c-rack/otp,theom/otp,schlagert/otp,paladim/otp,c-rack/otp,RichMorin/otp,cobusc/otp,release-project/otp,NOMORECOFFEE/otp,getong/otp,potatosalad/otp,massemanet/otp,psyeugenic/otp,krishnakumar4a4/otp,lucafavatella/otp,lantti/otp,saleyn/otp,haguenau/otp,matwey/otp,isvilen/otp,lightcyphers/otp,stolen/otp,bsmr-erlang/otp,sammoth-wazoku/otp,yangchengjian/otp,release-project/otp,neeraj9/otp,lrascao/otp,cnbin/otp,sammoth-wazoku/otp,beni55/otp,weisslj/otp,klarna/otp,lemenkov/otp,paladim/otp,bernardd/otp,platinumthinker/otp,sdebnath/otp,platinumthinker/otp,lrascao/otp,massemanet/otp,cnbin/otp,isvilen/otp,hairyhum/otp,vinoski/otp,palas/otp,RGafiyatullin/otp,ferd/otp,benoitc/otp-1,klarna/otp,vladdu/otp,VincentHHL/otp,tuncer/otp,RichMorin/otp,schlagert/otp,bjorng/otp,msantos/otp,release-project/otp,theom/otp,awetzel/otp,massemanet/otp,jamesruan/otp,emacsmirror/erlang,aboroska/otp,RGafiyatullin/otp,krishnakumar4a4/otp,entropiae/otp,c-rack/otp,msantos/otp,RGafiyatullin/otp,benoitc/otp-1,jinshana/otp,hairyhum/otp,Teino1978-Corp/otp,sitexa/otp,falkevik/otp,lrascao/otp,jj1bdx/otp,RaimoNiskanen/otp,hairyhum/otp,legoscia/otp,VincentHHL/otp,gjaldon/otp,msantos/otp,bernardd/otp,palas/otp,hairyhum/otp,weisslj/otp,RichMorin/otp,theom/otp,bjorng/otp,aboroska/otp,getong/otp,tuncer/otp,psyeugenic/otp,RaimoNiskanen/otp,RJ/otp,psyeugenic/otp,enikki/otp,msantos/otp,paulcager/otp,vladdu/otp,lemenkov/otp,bugs-erlang-org/otp,Teino1978-Corp/erlang-otp,psyeugenic/otp,rlipscombe/otp,jj1bdx/otp,ferd/otp,jj1bdx/otp,dumbbell/otp,legoscia/otp,goertzenator/otp,sitexa/otp,emile/otp,gjaldon/otp,GinjaNinja32/otp,RichMorin/otp,bernardd/otp,saleyn/otp,lrascao/otp,lantti/otp,cobusc/otp,johanclaesson/otp,riverrun/otp,palas/otp,rlipscombe/otp,lantti/otp,ahmedshafeeq/otp,johanclaesson/otp,vladdu/otp,jemsbhai/otp,isvilen/otp,palas/otp,enikki/otp,ahmedshafeeq/otp,neeraj9/otp,erlang/otp,lemenkov/otp,aboroska/otp,theom/otp,lucafavatella/otp,mujiatong/otp,bsmr-erlang/otp,ader1990/otp,NOMORECOFFEE/otp,lightcyphers/otp,Teino1978-Corp/otp,mujiatong/otp,RichMorin/otp,sdebnath/otp,sdebnath/otp,paladim/otp,beni55/otp,emile/otp,haguenau/otp,haguenau/otp,ahmedshafeeq/otp,lightcyphers/otp,rlipscombe/otp,Teino1978-Corp/otp,RJ/otp,Teino1978-Corp/otp,getong/otp,lemenkov/otp,ahmedshafeeq/otp,emacsmirror/erlang,fenollp/otp,benoitc/otp-1,psyeugenic/otp,potatosalad/otp,rlipscombe/otp,fenollp/otp,msantos/otp,release-project/otp,goertzenator/otp,falkevik/otp,emile/otp,lrascao/otp,lantti/otp,bernardd/otp,marquisthunder/otp,falkevik/otp,NOMORECOFFEE/otp,jj1bdx/otp,sdebnath/otp,Teino1978-Corp/erlang-otp,basho/otp,sitexa/otp,c-rack/otp,falkevik/otp,weisslj/otp,schlagert/otp,krishnakumar4a4/otp,marquisthunder/otp,potatosalad/otp,mujiatong/otp,saleyn/otp,RaimoNiskanen/otp,emile/otp,kvakvs/otp,tuncer/otp,sdebnath/otp,dumbbell/otp,paladim/otp,haguenau/otp,vladdu/otp,potatosalad/otp,getong/otp,saleyn/otp,RichMorin/otp,bjorng/otp,mikpe/otp,sitexa/otp,RGafiyatullin/otp,jj1bdx/otp,lhslll/otp,jemsbhai/otp,ferd/otp,bsmr-erlang/otp,stolen/otp,gjaldon/otp,emacsmirror/erlang,massemanet/otp,sammoth-wazoku/otp,saleyn/otp,vinoski/otp,sitexa/otp,erlang/otp,ader1990/otp,klarna/otp,jinshana/otp,basho/otp,riverrun/otp,riverrun/otp,isvilen/otp,dgud/otp,ferd/otp,platinumthinker/otp,legoscia/otp,jinshana/otp,RoadRunnr/otp,lemenkov/otp,GinjaNinja32/otp,derek121/otp,bugs-erlang-org/otp,jamesruan/otp,matwey/otp,awetzel/otp,derek121/otp,RJ/otp,haguenau/otp,ferd/otp,sammoth-wazoku/otp,lightcyphers/otp,basho/otp,gjaldon/otp,uabboli/otp,vic/otp,Teino1978-Corp/erlang-otp,jj1bdx/otp,haguenau/otp,johanclaesson/otp,lianghaivv/otp,goertzenator/otp,vinoski/otp,vic/otp,aboroska/otp,sdebnath/otp,yangchengjian/otp,hairyhum/otp,stolen/otp,fenollp/otp,bjorng/otp,dgud/otp,sammoth-wazoku/otp,lightcyphers/otp,stolen/otp,lemenkov/otp,VincentHHL/otp,falkevik/otp,bernardd/otp,schlagert/otp,tuncer/otp,yangchengjian/otp,palas/otp,tuncer/otp,vic/otp,electricimp/otp,schlagert/otp,g-andrade/otp,fenollp/otp,awetzel/otp,platinumthinker/otp,bugs-erlang-org/otp,entropiae/otp,hairyhum/otp,isvilen/otp,kvakvs/otp,jemsbhai/otp,tuncer/otp,cobusc/otp,goertzenator/otp,goertzenator/otp,ferd/otp,lightcyphers/otp,bjorng/otp,dumbbell/otp,saleyn/otp,ferd/otp,msantos/otp,johanclaesson/otp,RoadRunnr/otp,mujiatong/otp,riverrun/otp,jamesruan/otp,sammoth-wazoku/otp,enikki/otp,potatosalad/otp,hairyhum/otp,vic/otp,jemsbhai/otp,bugs-erlang-org/otp,yangchengjian/otp,lhslll/otp,rlipscombe/otp,electricimp/otp,paulcager/otp,palas/otp,potatosalad/otp,lightcyphers/otp,entropiae/otp,psyeugenic/otp,Teino1978-Corp/erlang-otp,RichMorin/otp,ader1990/otp,stolen/otp,legoscia/otp,ader1990/otp,weisslj/otp,lianghaivv/otp,mikpe/otp,sammoth-wazoku/otp,vic/otp,vinoski/otp,paulcager/otp,platinumthinker/otp,paladim/otp,emacsmirror/erlang,bjorng/otp,RGafiyatullin/otp,jamesruan/otp,massemanet/otp,NOMORECOFFEE/otp,johanclaesson/otp,release-project/otp,cobusc/otp,haguenau/otp,uabboli/otp,vic/otp,lhslll/otp,aboroska/otp,GinjaNinja32/otp,mikpe/otp,Teino1978-Corp/otp,tuncer/otp,bjorng/otp,rlipscombe/otp,benoitc/otp-1,mikpe/otp,emacsmirror/erlang,mikpe/otp,neeraj9/otp,fenollp/otp,enikki/otp,fenollp/otp,dumbbell/otp,emacsmirror/erlang,dgud/otp,matwey/otp,lrascao/otp,emacsmirror/erlang,johanclaesson/otp,dgud/otp,jj1bdx/otp,matwey/otp,psyeugenic/otp,uabboli/otp,RJ/otp,msantos/otp,basho/otp,schlagert/otp,gjaldon/otp,entropiae/otp,g-andrade/otp,jamesruan/otp,vinoski/otp,mujiatong/otp,release-project/otp,enikki/otp,GinjaNinja32/otp,isvilen/otp,paulcager/otp,benoitc/otp-1,legoscia/otp,sitexa/otp,VincentHHL/otp,sammoth-wazoku/otp,jinshana/otp,basho/otp,dgud/otp,ahmedshafeeq/otp,RichMorin/otp,bernardd/otp,bsmr-erlang/otp,kvakvs/otp,emile/otp,jamesruan/otp,RaimoNiskanen/otp,cnbin/otp,lrascao/otp,RoadRunnr/otp,goertzenator/otp,jinshana/otp,lantti/otp,Teino1978-Corp/otp,dumbbell/otp,matwey/otp,palas/otp,bernardd/otp,getong/otp,krishnakumar4a4/otp,VincentHHL/otp,stolen/otp,cnbin/otp,psyeugenic/otp,lucafavatella/otp,bugs-erlang-org/otp,getong/otp,uabboli/otp,ader1990/otp,saleyn/otp,Teino1978-Corp/erlang-otp,emacsmirror/erlang,beni55/otp,RJ/otp,derek121/otp,RoadRunnr/otp,rlipscombe/otp,falkevik/otp,theom/otp,NOMORECOFFEE/otp,vladdu/otp,falkevik/otp,ferd/otp,neeraj9/otp,RaimoNiskanen/otp,neeraj9/otp,bjorng/otp,GinjaNinja32/otp,g-andrade/otp,goertzenator/otp,GinjaNinja32/otp,kvakvs/otp,fenollp/otp,g-andrade/otp,sdebnath/otp,gjaldon/otp,VincentHHL/otp,theom/otp,benoitc/otp-1,schlagert/otp,weisslj/otp,jemsbhai/otp,cobusc/otp,lantti/otp,vinoski/otp,vinoski/otp,fenollp/otp,beni55/otp,vladdu/otp,getong/otp,marquisthunder/otp,weisslj/otp,cnbin/otp,awetzel/otp,paulcager/otp,beni55/otp,derek121/otp,lucafavatella/otp,vinoski/otp,RoadRunnr/otp,enikki/otp,lucafavatella/otp,dgud/otp,lianghaivv/otp,electricimp/otp,paladim/otp,Teino1978-Corp/otp,entropiae/otp,jj1bdx/otp,lemenkov/otp,cobusc/otp,legoscia/otp,g-andrade/otp,bernardd/otp,saleyn/otp,c-rack/otp,marquisthunder/otp,matwey/otp,RGafiyatullin/otp,RaimoNiskanen/otp,rlipscombe/otp,weisslj/otp,lemenkov/otp,paulcager/otp,kvakvs/otp,g-andrade/otp,getong/otp,basho/otp,bsmr-erlang/otp,massemanet/otp,platinumthinker/otp,neeraj9/otp,emile/otp,awetzel/otp,haguenau/otp,johanclaesson/otp,isvilen/otp,yangchengjian/otp,jamesruan/otp,schlagert/otp,neeraj9/otp,vladdu/otp,entropiae/otp,electricimp/otp,derek121/otp,vladdu/otp,kvakvs/otp,legoscia/otp,enikki/otp,jj1bdx/otp,uabboli/otp,g-andrade/otp,emacsmirror/erlang,erlang/otp,potatosalad/otp,aboroska/otp,erlang/otp,lhslll/otp,enikki/otp,VincentHHL/otp,RoadRunnr/otp,lianghaivv/otp,ahmedshafeeq/otp,paladim/otp,riverrun/otp,uabboli/otp,emile/otp,rlipscombe/otp,paulcager/otp,erlang/otp,electricimp/otp,Teino1978-Corp/otp,massemanet/otp,klarna/otp,ferd/otp,platinumthinker/otp,derek121/otp,isvilen/otp,potatosalad/otp,erlang/otp,vladdu/otp,awetzel/otp,dumbbell/otp,klarna/otp,falkevik/otp,potatosalad/otp,bugs-erlang-org/otp,RJ/otp,dumbbell/otp,beni55/otp,fenollp/otp,Teino1978-Corp/erlang-otp,kvakvs/otp,dgud/otp,c-rack/otp,stolen/otp,klarna/otp,tuncer/otp,gjaldon/otp,marquisthunder/otp,bernardd/otp,massemanet/otp,RaimoNiskanen/otp,bugs-erlang-org/otp,lhslll/otp,dumbbell/otp,RGafiyatullin/otp,lhslll/otp,mikpe/otp,RoadRunnr/otp,ahmedshafeeq/otp,Teino1978-Corp/erlang-otp,NOMORECOFFEE/otp,benoitc/otp-1,riverrun/otp,matwey/otp,aboroska/otp,NOMORECOFFEE/otp,beni55/otp,lhslll/otp,release-project/otp,dumbbell/otp,aboroska/otp,mikpe/otp,lrascao/otp,Teino1978-Corp/erlang-otp,release-project/otp,potatosalad/otp,mujiatong/otp,legoscia/otp,cnbin/otp,matwey/otp,tuncer/otp,hairyhum/otp,awetzel/otp,electricimp/otp,mujiatong/otp,aboroska/otp,uabboli/otp,erlang/otp,lianghaivv/otp,weisslj/otp,bjorng/otp,GinjaNinja32/otp,marquisthunder/otp,NOMORECOFFEE/otp,VincentHHL/otp,jinshana/otp,entropiae/otp,kvakvs/otp,RaimoNiskanen/otp,cnbin/otp,kvakvs/otp,cobusc/otp,RaimoNiskanen/otp,yangchengjian/otp,RoadRunnr/otp,getong/otp,goertzenator/otp,palas/otp,uabboli/otp,goertzenator/otp,awetzel/otp,getong/otp,lrascao/otp,weisslj/otp,vinoski/otp,lucafavatella/otp,bugs-erlang-org/otp,erlang/otp,dgud/otp,bsmr-erlang/otp,mikpe/otp,riverrun/otp,electricimp/otp,g-andrade/otp,yangchengjian/otp,isvilen/otp,lucafavatella/otp,RJ/otp,platinumthinker/otp