retention: Remove realm_id check when archiving attachments.
retention: Remove realm_id check when archiving attachments.

Since we archive attachments and attachment_messages tied to a list of
ids of Messages that we just archived (so from the current realm), it's
unnecessary to check their realm in the queries. This could potentially
cause archiving of an attachment with realm_id of another realm, but
this isn't an issue, as long as we make sure we don't end up deleting
the original Attachment object incorrectly - but realm_id check is
included in delete_expired_attachments() to ensure that.

shubhamdhama/zulip,hackerkid/zulip,rishig/zulip,eeshangarg/zulip,rishig/zulip,zulip/zulip,andersk/zulip,shubhamdhama/zulip,timabbott/zulip,kou/zulip,rishig/zulip,eeshangarg/zulip,shubhamdhama/zulip,kou/zulip,hackerkid/zulip,hackerkid/zulip,punchagan/zulip,brainwane/zulip,brainwane/zulip,rishig/zulip,rishig/zulip,zulip/zulip,hackerkid/zulip,timabbott/zulip,kou/zulip,synicalsyntax/zulip,shubhamdhama/zulip,tommyip/zulip,zulip/zulip,synicalsyntax/zulip,hackerkid/zulip,tommyip/zulip,rishig/zulip,brainwane/zulip,eeshangarg/zulip,rht/zulip,synicalsyntax/zulip,rht/zulip,punchagan/zulip,timabbott/zulip,showell/zulip,rht/zulip,zulip/zulip,timabbott/zulip,punchagan/zulip,showell/zulip,showell/zulip,punchagan/zulip,hackerkid/zulip,brainwane/zulip,andersk/zulip,hackerkid/zulip,punchagan/zulip,andersk/zulip,shubhamdhama/zulip,andersk/zulip,kou/zulip,shubhamdhama/zulip,timabbott/zulip,synicalsyntax/zulip,kou/zulip,timabbott/zulip,zulip/zulip,tommyip/zulip,tommyip/zulip,brainwane/zulip,synicalsyntax/zulip,andersk/zulip,eeshangarg/zulip,zulip/zulip,eeshangarg/zulip,andersk/zulip,tommyip/zulip,eeshangarg/zulip,rht/zulip,rht/zulip,zulip/zulip,showell/zulip,shubhamdhama/zulip,synicalsyntax/zulip,rht/zulip,rht/zulip,tommyip/zulip,tommyip/zulip,rishig/zulip,eeshangarg/zulip,punchagan/zulip,showell/zulip,brainwane/zulip,showell/zulip,andersk/zulip,timabbott/zulip,showell/zulip,kou/zulip,synicalsyntax/zulip,punchagan/zulip,kou/zulip,brainwane/zulip