Make functional index copy attstorage from the column data type, rather than forcing 'plain'.  This probably does not matter right now, but I think it needs to be consistent with the regular (not-functional) index case, where attstorage is copied from the underlying table.  Clean up some other dead and infelicitous code too.
Make functional index copy attstorage from the column data type, rather
than forcing 'plain'.  This probably does not matter right now, but I
think it needs to be consistent with the regular (not-functional) index
case, where attstorage is copied from the underlying table.  Clean up
some other dead and infelicitous code too.

Chibin/gpdb,lintzc/gpdb,lisakowen/gpdb,royc1/gpdb,snaga/postgres-xl,ashwinstar/gpdb,zaksoup/gpdb,edespino/gpdb,tangp3/gpdb,50wu/gpdb,kmjungersen/PostgresXL,postmind-net/postgres-xl,xinzweb/gpdb,lpetrov-pivotal/gpdb,lisakowen/gpdb,edespino/gpdb,rubikloud/gpdb,0x0FFF/gpdb,ahachete/gpdb,kaknikhil/gpdb,janebeckman/gpdb,CraigHarris/gpdb,yuanzhao/gpdb,kaknikhil/gpdb,zaksoup/gpdb,cjcjameson/gpdb,lintzc/gpdb,Quikling/gpdb,chrishajas/gpdb,xinzweb/gpdb,jmcatamney/gpdb,rubikloud/gpdb,yuanzhao/gpdb,rvs/gpdb,foyzur/gpdb,adam8157/gpdb,ashwinstar/gpdb,rvs/gpdb,cjcjameson/gpdb,pavanvd/postgres-xl,50wu/gpdb,atris/gpdb,ahachete/gpdb,ahachete/gpdb,greenplum-db/gpdb,lpetrov-pivotal/gpdb,Quikling/gpdb,yazun/postgres-xl,greenplum-db/gpdb,lintzc/gpdb,50wu/gpdb,Quikling/gpdb,arcivanov/postgres-xl,adam8157/gpdb,lpetrov-pivotal/gpdb,foyzur/gpdb,kaknikhil/gpdb,Chibin/gpdb,yuanzhao/gpdb,arcivanov/postgres-xl,yazun/postgres-xl,chrishajas/gpdb,arcivanov/postgres-xl,Quikling/gpdb,kaknikhil/gpdb,edespino/gpdb,foyzur/gpdb,adam8157/gpdb,atris/gpdb,atris/gpdb,rubikloud/gpdb,tpostgres-projects/tPostgres,rvs/gpdb,rvs/gpdb,lisakowen/gpdb,ovr/postgres-xl,jmcatamney/gpdb,cjcjameson/gpdb,foyzur/gpdb,edespino/gpdb,arcivanov/postgres-xl,yuanzhao/gpdb,rvs/gpdb,techdragon/Postgres-XL,atris/gpdb,ahachete/gpdb,greenplum-db/gpdb,rubikloud/gpdb,oberstet/postgres-xl,0x0FFF/gpdb,tangp3/gpdb,Quikling/gpdb,ashwinstar/gpdb,chrishajas/gpdb,janebeckman/gpdb,xuegang/gpdb,zaksoup/gpdb,rvs/gpdb,xuegang/gpdb,ahachete/gpdb,lintzc/gpdb,techdragon/Postgres-XL,techdragon/Postgres-XL,foyzur/gpdb,royc1/gpdb,CraigHarris/gpdb,janebeckman/gpdb,greenplum-db/gpdb,zaksoup/gpdb,CraigHarris/gpdb,pavanvd/postgres-xl,lintzc/gpdb,jmcatamney/gpdb,xinzweb/gpdb,ashwinstar/gpdb,pavanvd/postgres-xl,0x0FFF/gpdb,yuanzhao/gpdb,xuegang/gpdb,xuegang/gpdb,kaknikhil/gpdb,cjcjameson/gpdb,rvs/gpdb,jmcatamney/gpdb,xinzweb/gpdb,lintzc/gpdb,adam8157/gpdb,foyzur/gpdb,0x0FFF/gpdb,atris/gpdb,Chibin/gpdb,50wu/gpdb,Postgres-XL/Postgres-XL,rubikloud/gpdb,foyzur/gpdb,lintzc/gpdb,chrishajas/gpdb,postmind-net/postgres-xl,tangp3/gpdb,jmcatamney/gpdb,cjcjameson/gpdb,janebeckman/gpdb,pavanvd/postgres-xl,kmjungersen/PostgresXL,rubikloud/gpdb,randomtask1155/gpdb,zaksoup/gpdb,xuegang/gpdb,oberstet/postgres-xl,rvs/gpdb,lisakowen/gpdb,kaknikhil/gpdb,Postgres-XL/Postgres-XL,royc1/gpdb,xuegang/gpdb,techdragon/Postgres-XL,zeroae/postgres-xl,ahachete/gpdb,randomtask1155/gpdb,yazun/postgres-xl,ovr/postgres-xl,xuegang/gpdb,tpostgres-projects/tPostgres,tangp3/gpdb,postmind-net/postgres-xl,tangp3/gpdb,ashwinstar/gpdb,CraigHarris/gpdb,foyzur/gpdb,kaknikhil/gpdb,snaga/postgres-xl,0x0FFF/gpdb,atris/gpdb,kmjungersen/PostgresXL,Chibin/gpdb,lisakowen/gpdb,xinzweb/gpdb,xinzweb/gpdb,cjcjameson/gpdb,royc1/gpdb,50wu/gpdb,oberstet/postgres-xl,randomtask1155/gpdb,cjcjameson/gpdb,0x0FFF/gpdb,yazun/postgres-xl,yuanzhao/gpdb,rubikloud/gpdb,pavanvd/postgres-xl,Quikling/gpdb,postmind-net/postgres-xl,greenplum-db/gpdb,ahachete/gpdb,yuanzhao/gpdb,randomtask1155/gpdb,oberstet/postgres-xl,kaknikhil/gpdb,50wu/gpdb,edespino/gpdb,yuanzhao/gpdb,Chibin/gpdb,CraigHarris/gpdb,cjcjameson/gpdb,ovr/postgres-xl,atris/gpdb,zaksoup/gpdb,kmjungersen/PostgresXL,Chibin/gpdb,adam8157/gpdb,lisakowen/gpdb,edespino/gpdb,Chibin/gpdb,Postgres-XL/Postgres-XL,ahachete/gpdb,xuegang/gpdb,greenplum-db/gpdb,randomtask1155/gpdb,janebeckman/gpdb,techdragon/Postgres-XL,Postgres-XL/Postgres-XL,ashwinstar/gpdb,Postgres-XL/Postgres-XL,snaga/postgres-xl,janebeckman/gpdb,royc1/gpdb,randomtask1155/gpdb,ovr/postgres-xl,lisakowen/gpdb,tpostgres-projects/tPostgres,ashwinstar/gpdb,postmind-net/postgres-xl,zaksoup/gpdb,Quikling/gpdb,snaga/postgres-xl,arcivanov/postgres-xl,lpetrov-pivotal/gpdb,chrishajas/gpdb,tangp3/gpdb,ashwinstar/gpdb,royc1/gpdb,zeroae/postgres-xl,zeroae/postgres-xl,greenplum-db/gpdb,oberstet/postgres-xl,Chibin/gpdb,yazun/postgres-xl,randomtask1155/gpdb,CraigHarris/gpdb,janebeckman/gpdb,rvs/gpdb,janebeckman/gpdb,Chibin/gpdb,tangp3/gpdb,zaksoup/gpdb,greenplum-db/gpdb,Quikling/gpdb,rubikloud/gpdb,yuanzhao/gpdb,chrishajas/gpdb,CraigHarris/gpdb,kaknikhil/gpdb,arcivanov/postgres-xl,CraigHarris/gpdb,chrishajas/gpdb,lpetrov-pivotal/gpdb,kaknikhil/gpdb,50wu/gpdb,cjcjameson/gpdb,edespino/gpdb,jmcatamney/gpdb,xuegang/gpdb,royc1/gpdb,CraigHarris/gpdb,snaga/postgres-xl,Chibin/gpdb,xinzweb/gpdb,50wu/gpdb,lintzc/gpdb,tangp3/gpdb,jmcatamney/gpdb,0x0FFF/gpdb,zeroae/postgres-xl,lpetrov-pivotal/gpdb,edespino/gpdb,adam8157/gpdb,atris/gpdb,chrishajas/gpdb,royc1/gpdb,yuanzhao/gpdb,ovr/postgres-xl,jmcatamney/gpdb,randomtask1155/gpdb,kmjungersen/PostgresXL,lisakowen/gpdb,xinzweb/gpdb,lintzc/gpdb,janebeckman/gpdb,adam8157/gpdb,tpostgres-projects/tPostgres,adam8157/gpdb,lpetrov-pivotal/gpdb,Quikling/gpdb,tpostgres-projects/tPostgres,janebeckman/gpdb,lpetrov-pivotal/gpdb,edespino/gpdb,edespino/gpdb,cjcjameson/gpdb,Quikling/gpdb,0x0FFF/gpdb,zeroae/postgres-xl,rvs/gpdb