Allow domain disk images on root-squash NFS to coexist with security driver.
Allow domain disk images on root-squash NFS to coexist with security driver.

(suggested by Daniel Berrange, tested by Dan Kenigsberg)

virStorageFileGetMetadata will fail for disk images that are stored on
a root-squash NFS share that isn't world-readable.
SELinuxSetSecurityImageLabel is called during the startup of every
domain (as long as security_driver != "none"), and it will propogate
the error from virStorageFileGetMetadata, causing the domain startup
to fail. This is, however, a common scenario when qemu is run as a
non-root user and the disk image is stored on NFS.

Ignoring this failure (which doesn't matter in this case, since the
next thing done by SELinuxSetSecurityImageLabel - setting the file
context - will also fail (and that function already ignores failures
due to root-squash NFS) will allow us to continue bringing up the
domain. The result is that we don't need to disable the entire
security driver just because a domain's disk image is stored on
root-squashed NFS.

andreabolognani/libvirt,novel/fbsd-libvirt,leilihh/libvirt,jeckersb/libvirt,jardasgit/libvirt,leilihh/libvirt,kantai/libvirt-vfork,warewolf/libvirt,novel/fbsd-libvirt,cbosdo/libvirt,rmarwaha/libvirt1,zippy2/libvirt,trainstack/libvirt,sshah-solarflare/Libvirt-PCI-passthrough-,jfehlig/libvirt,datto/libvirt,jeckersb/libvirt,zhlcindy/libvirt-1.1.4-maintain,siboulet/libvirt-openvz,bjzhang/libvirt,eskultety/libvirt,agx/libvirt,eskultety/libvirt,rbu/libvirt,bjzhang/libvirt,andreabolognani/libvirt,danwent/libvirt-ovs,novel/fbsd-libvirt,rmarwaha/libvirt,taget/libvirt,trainstack/libvirt,rmarwaha/libvirt1,rmarwaha/libvirt1,crobinso/libvirt,usc-isi/libvirt,trainstack/libvirt,foomango/libvirt,leilihh/libvirt,leilihh/libvirt,novel/fbsd-libvirt,wiedi/libvirt,foomango/libvirt,eskultety/libvirt,olafhering/libvirt,zippy2/libvirt,fabianfreyer/libvirt,rmarwaha/libvirt,eskultety/libvirt,rlaager/libvirt,usc-isi/libvirt,jfehlig/libvirt,elmarco/libvirt,iam-TJ/libvirt,amery/libvirt-vserver,iam-TJ/libvirt,jfehlig/libvirt,crobinso/libvirt,emaste/libvirt,VenkatDatta/libvirt,jardasgit/libvirt,amery/libvirt-vserver,taget/libvirt,datto/libvirt,sshah-solarflare/Libvirt-PCI-passthrough-,cbosdo/libvirt,agx/libvirt,novel/fbsd-libvirt,siboulet/libvirt-openvz,jfehlig/libvirt,soulxu/libvirt-xuhj,jeckersb/libvirt,usc-isi/libvirt,soulxu/libvirt-xuhj,nertpinx/libvirt,emaste/libvirt,amery/libvirt-vserver,zhlcindy/libvirt-1.1.4-maintain,kantai/libvirt-vfork,taget/libvirt,fabianfreyer/libvirt,rmarwaha/libvirt1,crobinso/libvirt,iam-TJ/libvirt,foomango/libvirt,zippy2/libvirt,taget/libvirt,danwent/libvirt-ovs,zhlcindy/libvirt-1.1.4-maintain,foomango/libvirt,emaste/libvirt,wiedi/libvirt,rmarwaha/libvirt1,olafhering/libvirt,kantai/libvirt-vfork,rlaager/libvirt,cbosdo/libvirt,danwent/libvirt-ovs,zhlcindy/libvirt-1.1.4-maintain,dumbbell/libvirt,jeckersb/libvirt,amery/libvirt-vserver,iam-TJ/libvirt,olafhering/libvirt,VenkatDatta/libvirt,usc-isi/libvirt,zhlcindy/libvirt-1.1.4-maintain,warewolf/libvirt,elmarco/libvirt,dumbbell/libvirt,nertpinx/libvirt,warewolf/libvirt,rmarwaha/libvirt,warewolf/libvirt,libvirt/libvirt,jeckersb/libvirt,dumbbell/libvirt,soulxu/libvirt-xuhj,VenkatDatta/libvirt,rbu/libvirt,jardasgit/libvirt,agx/libvirt,rlaager/libvirt,rbu/libvirt,novel/fbsd-libvirt,wiedi/libvirt,dumbbell/libvirt,rmarwaha/libvirt1,usc-isi/libvirt,sshah-solarflare/Libvirt-PCI-passthrough-,wiedi/libvirt,jardasgit/libvirt,agx/libvirt,andreabolognani/libvirt,emaste/libvirt,amery/libvirt-vserver,rbu/libvirt,crobinso/libvirt,iam-TJ/libvirt,soulxu/libvirt-xuhj,VenkatDatta/libvirt,kantai/libvirt-vfork,rbu/libvirt,emaste/libvirt,warewolf/libvirt,olafhering/libvirt,trainstack/libvirt,novel/fbsd-libvirt,trainstack/libvirt,cbosdo/libvirt,rmarwaha/libvirt,elmarco/libvirt,VenkatDatta/libvirt,elmarco/libvirt,soulxu/libvirt-xuhj,jeckersb/libvirt,siboulet/libvirt-openvz,cbosdo/libvirt,shugaoye/libvirt,nertpinx/libvirt,jardasgit/libvirt,elmarco/libvirt,novel/fbsd-libvirt,bjzhang/libvirt,iam-TJ/libvirt,shugaoye/libvirt,rlaager/libvirt,rmarwaha/libvirt,wiedi/libvirt,rmarwaha/libvirt,eskultety/libvirt,wiedi/libvirt,fabianfreyer/libvirt,kantai/libvirt-vfork,rlaager/libvirt,shugaoye/libvirt,zippy2/libvirt,nertpinx/libvirt,dumbbell/libvirt,shugaoye/libvirt,fabianfreyer/libvirt,libvirt/libvirt,siboulet/libvirt-openvz,datto/libvirt,sshah-solarflare/Libvirt-PCI-passthrough-,shugaoye/libvirt,fabianfreyer/libvirt,novel/fbsd-libvirt,trainstack/libvirt,iam-TJ/libvirt,warewolf/libvirt,leilihh/libvirt,danwent/libvirt-ovs,wiedi/libvirt,datto/libvirt,trainstack/libvirt,sshah-solarflare/Libvirt-PCI-passthrough-,foomango/libvirt,nertpinx/libvirt,warewolf/libvirt,emaste/libvirt,andreabolognani/libvirt,danwent/libvirt-ovs,taget/libvirt,leilihh/libvirt,emaste/libvirt,libvirt/libvirt,bjzhang/libvirt,siboulet/libvirt-openvz,libvirt/libvirt,dumbbell/libvirt,datto/libvirt,jeckersb/libvirt,agx/libvirt,bjzhang/libvirt,andreabolognani/libvirt