Actually Eclipse was telling us something useful. The point of that code was to issue a warning if someone created a reader method or a writer method but not both. Eclipse's static analysis helpfully pointed out that we'll never know if someone fails to declare a reader but does declare a writer because of the way method lookup fails. Since we want to actually detect that situation and generate a helpful warnings, we restructure the code so that the static analyzer is happy and developers asses are covered.
Actually Eclipse was telling us something useful. The point of that code was to
issue a warning if someone created a reader method or a writer method but not
both. Eclipse's static analysis helpfully pointed out that we'll never know if
someone fails to declare a reader but does declare a writer because of the way
method lookup fails. Since we want to actually detect that situation and
generate a helpful warnings, we restructure the code so that the static
analyzer is happy and developers asses are covered.


git-svn-id: a1a4b28b82a3276cc491891159dd9963a0a72fae@5286 542714f4-19e9-0310-aa3c-eee0fc999fb1

threerings/narya,threerings/narya,threerings/narya,threerings/narya,threerings/narya