Common approach for IllegalArgumentException on subscribe methods
Common approach for IllegalArgumentException on subscribe methods

As brought up in https://github.com/Netflix/RxJava/issues/278 there were inconsistencies in how arguments were being validated on subscribe methods.

All arguments to subscribe are now validated correctly at the beginning of method invocation and IllegalArgumentException thrown if null arguments are injected.

According to Rx Guideline 6.5 a null argument is considered "a catastrophic error occurs that should bring down the whole program anyway" and thus we immediately throw. A null argument should be caught immediately in development and has nothing to do with subscribe invocation which is what guideline 6.5 is talking about (since a null Observer can't have onError called on it anyways).

rabbitcount/RxJava,Godchin1990/RxJava,xfumihiro/RxJava,benjchristensen/RxJava,ChenWenHuan/RxJava,sunfei/RxJava,aditya-chaturvedi/RxJava,ppiech/RxJava,davidmoten/RxJava,eduardotrandafilov/RxJava,stevegury/RxJava,ppiech/RxJava,sanxieryu/RxJava,abersnaze/RxJava,wlrhnh-David/RxJava,vqvu/RxJava,simonbasle/RxJava,xfumihiro/RxJava,bboyfeiyu/RxJava,fjg1989/RxJava,suclike/RxJava,hzysoft/RxJava,Shedings/RxJava,ronenhamias/RxJava,weikipeng/RxJava,runt18/RxJava,eduardotrandafilov/RxJava,southwolf/RxJava,wehjin/RxJava,wrightm/RxJava,ibaca/RxJava,jtulach/RxJava,AmberWhiteSky/RxJava,java02014/RxJava,HuangWenhuan0/RxJava,akarnokd/RxJava,abersnaze/RxJava,davidmoten/RxJava,TracyLu/RxJava,ashwary/RxJava,ayushnvijay/RxJava,jbripley/RxJava,zjrstar/RxJava,vqvu/RxJava,Ribeiro/RxJava,shekarrex/RxJava,AttwellBrian/RxJava,msdgwzhy6/RxJava,Siddartha07/RxJava,jbripley/RxJava,devisnik/RxJava,puniverse/RxJava,artem-zinnatullin/RxJava,randall-mo/RxJava,ReactiveX/RxJava,sanxieryu/RxJava,nkhuyu/RxJava,abersnaze/RxJava,wehjin/RxJava,hyarlagadda/RxJava,dromato/RxJava,java02014/RxJava,mttkay/RxJava,tombujok/RxJava,nurkiewicz/RxJava,srayhunter/RxJava,mattrjacobs/RxJava,YlJava110/RxJava,jacek-rzrz/RxJava,sposam/RxJava,androidyue/RxJava,runt18/RxJava,YlJava110/RxJava,ypresto/RxJava,devisnik/RxJava,wehjin/RxJava,nkhuyu/RxJava,weikipeng/RxJava,mobilist/RxJava,gjesse/RxJava,ppiech/RxJava,ibaca/RxJava,devisnik/RxJava,KevinTCoughlin/RxJava,southwolf/RxJava,cloudbearings/RxJava,tilal6991/RxJava,cloudbearings/RxJava,KevinTCoughlin/RxJava,tombujok/RxJava,onepavel/RxJava,marcogarcia23/RxJava,eduardotrandafilov/RxJava,java02014/RxJava,cgpllx/RxJava,kuanghao/RxJava,forsail/RxJava,elijah513/RxJava,mttkay/RxJava,A-w-K/RxJava,forsail/RxJava,duqiao/RxJava,AmberWhiteSky/RxJava,sposam/RxJava,Turbo87/RxJava,suclike/RxJava,devisnik/RxJava,lncosie/RxJava,takecy/RxJava,HuangWenhuan0/RxJava,xfumihiro/RxJava,AttwellBrian/RxJava,rabbitcount/RxJava,lncosie/RxJava,Eagles2F/RxJava,vqvu/RxJava,ypresto/RxJava,wrightm/RxJava,maugomez77/RxJava,hyleung/RxJava,shekarrex/RxJava,Bobjoy/RxJava,picnic106/RxJava,androidyue/RxJava,ypresto/RxJava,markrietveld/RxJava,nvoron23/RxJava,cloudbearings/RxJava,dromato/RxJava,reactivex/rxjava,kuanghao/RxJava,Godchin1990/RxJava,sanxieryu/RxJava,Bobjoy/RxJava,dromato/RxJava,b-cuts/RxJava,ronenhamias/RxJava,Shedings/RxJava,Ryan800/RxJava,markrietveld/RxJava,Turbo87/RxJava,HuangWenhuan0/RxJava,srayhunter/RxJava,suclike/RxJava,lijunhuayc/RxJava,nurkiewicz/RxJava,ayushnvijay/RxJava,ruhkopf/RxJava,mobilist/RxJava,sunfei/RxJava,NiteshKant/RxJava,rabbitcount/RxJava,klemzy/RxJava,mattrjacobs/RxJava,weikipeng/RxJava,onepavel/RxJava,frodoking/RxJava,ibaca/RxJava,zhongdj/RxJava,hzysoft/RxJava,KevinTCoughlin/RxJava,shekarrex/RxJava,klemzy/RxJava,elijah513/RxJava,msdgwzhy6/RxJava,wrightm/RxJava,simonbasle/RxJava,ronenhamias/RxJava,runt18/RxJava,ruhkopf/RxJava,YlJava110/RxJava,Eagles2F/RxJava,gjesse/RxJava,hyleung/RxJava,devagul93/RxJava,lijunhuayc/RxJava,maugomez77/RxJava,b-cuts/RxJava,davidmoten/RxJava,hzysoft/RxJava,tombujok/RxJava,forsail/RxJava,spoon-bot/RxJava,spoon-bot/RxJava,androidgilbert/RxJava,southwolf/RxJava,sitexa/RxJava,marcogarcia23/RxJava,A-w-K/RxJava,maugomez77/RxJava,tilal6991/RxJava,jacek-rzrz/RxJava,Shedings/RxJava,hyarlagadda/RxJava,zsxwing/RxJava,zhongdj/RxJava,ayushnvijay/RxJava,duqiao/RxJava,ruhkopf/RxJava,akarnokd/RxJava,zjrstar/RxJava,devagul93/RxJava,zjrstar/RxJava,pitatensai/RxJava,takecy/RxJava,gjesse/RxJava,nkhuyu/RxJava,hyleung/RxJava,klemzy/RxJava,sitexa/RxJava,devagul93/RxJava,aditya-chaturvedi/RxJava,nvoron23/RxJava,ChenWenHuan/RxJava,mattrjacobs/RxJava,Ryan800/RxJava,nvoron23/RxJava,randall-mo/RxJava,ChenWenHuan/RxJava,pitatensai/RxJava,aditya-chaturvedi/RxJava,yuhuayi/RxJava,A-w-K/RxJava,Eagles2F/RxJava,ReactiveX/RxJava,TracyLu/RxJava,zsxwing/RxJava,androidyue/RxJava,fjg1989/RxJava,stevegury/RxJava,simonbasle/RxJava,jbripley/RxJava,cgpllx/RxJava,TracyLu/RxJava,Siddartha07/RxJava,androidgilbert/RxJava,nurkiewicz/RxJava,kuanghao/RxJava,puniverse/RxJava,wlrhnh-David/RxJava,artem-zinnatullin/RxJava,Godchin1990/RxJava,elijah513/RxJava,takecy/RxJava,lncosie/RxJava,androidgilbert/RxJava,pitatensai/RxJava,AmberWhiteSky/RxJava,mttkay/RxJava,duqiao/RxJava,reactivex/rxjava,marcogarcia23/RxJava,onepavel/RxJava,sitexa/RxJava,jacek-rzrz/RxJava,frodoking/RxJava,Turbo87/RxJava,picnic106/RxJava,NiteshKant/RxJava,bboyfeiyu/RxJava,tilal6991/RxJava,yuhuayi/RxJava,cgpllx/RxJava,sunfei/RxJava,zsxwing/RxJava,picnic106/RxJava,yuhuayi/RxJava,Ribeiro/RxJava,ashwary/RxJava,ashwary/RxJava,lijunhuayc/RxJava,puniverse/RxJava,frodoking/RxJava,jtulach/RxJava,Siddartha07/RxJava,b-cuts/RxJava,randall-mo/RxJava,hyarlagadda/RxJava,Ribeiro/RxJava,Bobjoy/RxJava,fjg1989/RxJava,srayhunter/RxJava,sposam/RxJava,stevegury/RxJava,abersnaze/RxJava,Ryan800/RxJava,wlrhnh-David/RxJava,zhongdj/RxJava,msdgwzhy6/RxJava,markrietveld/RxJava