Minor: Reformat and refactor addViewDetailsLink()
Minor: Reformat and refactor addViewDetailsLink()

- WordPress escapes the site URL when building the "Visit plugin site" link, so we need to look for the escaped URL instead of the raw string.
- Using regexps is probably overkill. A simple string search will do.
- Add a default case to the switch in case a plugin returns an invalid link position.
- Move the "view_details_link_position" filter inside the foreach loop to eliminate an if().
- Move the slug check closer to the top. There's no point in running the "view_details_link" filter if the link isn't going to be shown anyway.
YahnisElsts/plugin-update-checker,YahnisElsts/plugin-update-checker