Fix an open file descriptor leak in pmdaapache connect error paths
Fix an open file descriptor leak in pmdaapache connect error paths

The libpcp_http library which performs simple http requests for PMDAs
fails to close socket file descriptors on the connect error path.

The problem was observed when the Apache PMDA was failing to show
metrics.  Ended up stracing the process and saw that pam_limits was
denying any new files to be opened.  Checked /proc/$pid/fd and found
~1000 sockets.

Reproduced this behaviour by stopping Apache and then attempting to
fetch all the apache metrics. Each time I'd do a fetch, the amount of
FDs would jump up by 20 each time.

Tracked it to http_fetcher.c in the makeSocket routine.  Fix reviewed
by mgoodwin and nathans on #pcp.

prasincs/pcp,aeg-aeg/pcpfans,tjanez/pcp,wuliming/pcp,edwardt/pcp,prasincs/pcp,edwardt/pcp,wuliming/pcp,aeg-aeg/pcpfans,mbaldessari/pcp,tjanez/pcp,tjanez/pcp,edwardt/pcp,andyvand/cygpcpfans,edwardt/pcp,prasincs/pcp,mbaldessari/pcp,andyvand/cygpcpfans,edwardt/pcp,andyvand/cygpcpfans,edwardt/pcp,adfernandes/pcp,andyvand/cygpcpfans,andyvand/cygpcpfans,prasincs/pcp,edwardt/pcp,adfernandes/pcp,ryandoyle/pcp_original,mbaldessari/pcp,ryandoyle/pcp_original,ryandoyle/pcp_original,ryandoyle/pcp_original,prasincs/pcp,ryandoyle/pcp_original,prasincs/pcp,andyvand/cygpcpfans,wuliming/pcp,tjanez/pcp,edwardt/pcp,mbaldessari/pcp,aeg-aeg/pcpfans,aeg-aeg/pcpfans,aeg-aeg/pcpfans,mbaldessari/pcp,prasincs/pcp,ryandoyle/pcp_original,tjanez/pcp,wuliming/pcp,andyvand/cygpcpfans,aeg-aeg/pcpfans,adfernandes/pcp,mbaldessari/pcp,wuliming/pcp,aeg-aeg/pcpfans,tjanez/pcp,wuliming/pcp,tjanez/pcp,wuliming/pcp,adfernandes/pcp,adfernandes/pcp,wuliming/pcp,ryandoyle/pcp_original,adfernandes/pcp,aeg-aeg/pcpfans,ryandoyle/pcp_original,prasincs/pcp,andyvand/cygpcpfans,adfernandes/pcp,tjanez/pcp,adfernandes/pcp