- Fix a bad typo (FreeBSD specific) in pfsync_bulk_update(). Instead   of scheduling next run pfsync_bulk_update(), pfsync_bulk_fail()   was scheduled.   This lead to instant 100% state leak after first bulk update   request. - After above fix, it appeared that pfsync_bulk_update() lacks   locking. To fix this, sc_bulk_tmo callout was converted to an   mtx one. Eventually, all pf/pfsync callouts should be converted   to mtx version, since it isn't possible to stop or drain a   non-mtx callout without risk of race. - Add comment that callout_stop() in pfsync_clone_destroy() lacks   locking. Since pfsync0 can't be destroyed (yet), let it be here.
- Fix a bad typo (FreeBSD specific) in pfsync_bulk_update(). Instead
  of scheduling next run pfsync_bulk_update(), pfsync_bulk_fail()
  was scheduled.
  This lead to instant 100% state leak after first bulk update
  request.
- After above fix, it appeared that pfsync_bulk_update() lacks
  locking. To fix this, sc_bulk_tmo callout was converted to an
  mtx one. Eventually, all pf/pfsync callouts should be converted
  to mtx version, since it isn't possible to stop or drain a
  non-mtx callout without risk of race.
- Add comment that callout_stop() in pfsync_clone_destroy() lacks
  locking. Since pfsync0 can't be destroyed (yet), let it be here.

jrobhoward/SCADAbase,jrobhoward/SCADAbase,jrobhoward/SCADAbase,jrobhoward/SCADAbase,jrobhoward/SCADAbase,jrobhoward/SCADAbase,jrobhoward/SCADAbase,jrobhoward/SCADAbase,jrobhoward/SCADAbase,jrobhoward/SCADAbase,jrobhoward/SCADAbase