If the junit output file doesn't exist, it should still count as an error on the target
If the junit output file doesn't exist, it should still count as an error on the target

We have some junit tests in our repo that fail outside of an actual testmethod, so the junit xml output file doesn't get created. If that file doesn't get created, it's a failure of the target, so that target should still be in TestFailedTaskError even though we don't have a testmethod and testclass.

Testing Done:
build-support/bin/unit-tests.sh

The tests that fail in our repo are quite inscrutable so I can't tell how to create a simple unit test for this. Would it be ok to submit this as-is?

It works on the degenerate tests in our repo.

Reviewed at https://rbcommons.com/s/twitter/r/3407/

baroquebobcat/pants,dbentley/pants,ericzundel/pants,foursquare/pants,tdyas/pants,landism/pants,mateor/pants,manasapte/pants,pantsbuild/pants,cevaris/pants,peiyuwang/pants,benjyw/pants,kwlzn/pants,lahosken/pants,cevaris/pants,fkorotkov/pants,landism/pants,gmalmquist/pants,lahosken/pants,gmalmquist/pants,UnrememberMe/pants,wisechengyi/pants,fkorotkov/pants,foursquare/pants,benjyw/pants,pombredanne/pants,fkorotkov/pants,15Dkatz/pants,kwlzn/pants,UnrememberMe/pants,baroquebobcat/pants,tdyas/pants,pombredanne/pants,foursquare/pants,jsirois/pants,mateor/pants,mateor/pants,fkorotkov/pants,landism/pants,cevaris/pants,lahosken/pants,jsirois/pants,twitter/pants,manasapte/pants,UnrememberMe/pants,foursquare/pants,UnrememberMe/pants,wisechengyi/pants,benjyw/pants,ity/pants,pantsbuild/pants,landism/pants,15Dkatz/pants,kwlzn/pants,foursquare/pants,baroquebobcat/pants,15Dkatz/pants,15Dkatz/pants,foursquare/pants,UnrememberMe/pants,mateor/pants,peiyuwang/pants,15Dkatz/pants,tdyas/pants,pombredanne/pants,ericzundel/pants,peiyuwang/pants,tdyas/pants,benjyw/pants,lahosken/pants,ity/pants,ericzundel/pants,baroquebobcat/pants,dbentley/pants,cevaris/pants,15Dkatz/pants,gmalmquist/pants,lahosken/pants,ity/pants,peiyuwang/pants,twitter/pants,pantsbuild/pants,wisechengyi/pants,foursquare/pants,UnrememberMe/pants,kwlzn/pants,gmalmquist/pants,wisechengyi/pants,pantsbuild/pants,twitter/pants,mateor/pants,jsirois/pants,ericzundel/pants,foursquare/pants,wisechengyi/pants,pantsbuild/pants,baroquebobcat/pants,peiyuwang/pants,ity/pants,tdyas/pants,wisechengyi/pants,ity/pants,manasapte/pants,landism/pants,wisechengyi/pants,kwlzn/pants,benjyw/pants,dbentley/pants,landism/pants,baroquebobcat/pants,pombredanne/pants,twitter/pants,fkorotkov/pants,twitter/pants,gmalmquist/pants,fkorotkov/pants,tdyas/pants,tdyas/pants,pantsbuild/pants,fkorotkov/pants,baroquebobcat/pants,twitter/pants,manasapte/pants,foursquare/pants,ericzundel/pants,UnrememberMe/pants,dbentley/pants,UnrememberMe/pants,landism/pants,lahosken/pants,ity/pants,ericzundel/pants,cevaris/pants,fkorotkov/pants,lahosken/pants,benjyw/pants,ericzundel/pants,dbentley/pants,kwlzn/pants,pantsbuild/pants,wisechengyi/pants,tdyas/pants,mateor/pants,ity/pants,15Dkatz/pants,twitter/pants,twitter/pants,manasapte/pants,baroquebobcat/pants,twitter/pants,dbentley/pants,benjyw/pants,wisechengyi/pants,UnrememberMe/pants,manasapte/pants,peiyuwang/pants,baroquebobcat/pants,cevaris/pants,manasapte/pants,pombredanne/pants,peiyuwang/pants,tdyas/pants,kwlzn/pants,lahosken/pants,mateor/pants,cevaris/pants,ericzundel/pants,pombredanne/pants,pombredanne/pants,landism/pants,peiyuwang/pants,dbentley/pants,15Dkatz/pants,mateor/pants,gmalmquist/pants,gmalmquist/pants