Revert 163511 - drive: Fix a crash in gdata::DriveUploader::ResumeUpload()
Revert 163511 - drive: Fix a crash in gdata::DriveUploader::ResumeUpload()

Reason: "return" was missing after a call to UploadFailed()

The crash reported at crbug.com/157057 can occur if the 2nd parameter to
std::string constructor is negative here:

  bool ResumeUploadOperation::GetContentData(std::string* upload_content_type,
                                           std::string* upload_content) {
    *upload_content_type = params_.content_type;
    *upload_content = std::string(params_.buf->data(),
                                  params_.end_range - params_.start_range + 1);
    return true;
  }

Looking at the code, this can occur if reading of a file failed in
DriveUploader::ReadCompletionCallback().

BUG=157057
TEST=none. This crash is hard to reproduce

Review URL: https://codereview.chromium.org/11238028

TBR=satorux@chromium.org
Review URL: https://codereview.chromium.org/11228047

git-svn-id: de016e52bd170d2d4f2344f9bf92d50478b649e0@163515 0039d316-1c4b-4281-b951-d872f2087c98

timopulkkinen/BubbleFish,littlstar/chromium.src,chuan9/chromium-crosswalk,dednal/chromium.src,PeterWangIntel/chromium-crosswalk,bright-sparks/chromium-spacewalk,fujunwei/chromium-crosswalk,TheTypoMaster/chromium-crosswalk,hujiajie/pa-chromium,mohamed--abdel-maksoud/chromium.src,axinging/chromium-crosswalk,mohamed--abdel-maksoud/chromium.src,pozdnyakov/chromium-crosswalk,ChromiumWebApps/chromium,Pluto-tv/chromium-crosswalk,bright-sparks/chromium-spacewalk,anirudhSK/chromium,M4sse/chromium.src,bright-sparks/chromium-spacewalk,mohamed--abdel-maksoud/chromium.src,crosswalk-project/chromium-crosswalk-efl,ondra-novak/chromium.src,ondra-novak/chromium.src,hgl888/chromium-crosswalk-efl,dednal/chromium.src,ChromiumWebApps/chromium,ChromiumWebApps/chromium,chuan9/chromium-crosswalk,crosswalk-project/chromium-crosswalk-efl,patrickm/chromium.src,ondra-novak/chromium.src,bright-sparks/chromium-spacewalk,axinging/chromium-crosswalk,nacl-webkit/chrome_deps,nacl-webkit/chrome_deps,patrickm/chromium.src,mohamed--abdel-maksoud/chromium.src,Pluto-tv/chromium-crosswalk,crosswalk-project/chromium-crosswalk-efl,ChromiumWebApps/chromium,ondra-novak/chromium.src,timopulkkinen/BubbleFish,crosswalk-project/chromium-crosswalk-efl,dednal/chromium.src,Fireblend/chromium-crosswalk,ondra-novak/chromium.src,mohamed--abdel-maksoud/chromium.src,M4sse/chromium.src,junmin-zhu/chromium-rivertrail,dednal/chromium.src,hgl888/chromium-crosswalk-efl,pozdnyakov/chromium-crosswalk,krieger-od/nwjs_chromium.src,timopulkkinen/BubbleFish,axinging/chromium-crosswalk,markYoungH/chromium.src,ltilve/chromium,ChromiumWebApps/chromium,hgl888/chromium-crosswalk-efl,pozdnyakov/chromium-crosswalk,Chilledheart/chromium,junmin-zhu/chromium-rivertrail,Jonekee/chromium.src,anirudhSK/chromium,Pluto-tv/chromium-crosswalk,crosswalk-project/chromium-crosswalk-efl,markYoungH/chromium.src,Fireblend/chromium-crosswalk,mogoweb/chromium-crosswalk,mohamed--abdel-maksoud/chromium.src,Fireblend/chromium-crosswalk,anirudhSK/chromium,junmin-zhu/chromium-rivertrail,crosswalk-project/chromium-crosswalk-efl,mogoweb/chromium-crosswalk,junmin-zhu/chromium-rivertrail,ltilve/chromium,zcbenz/cefode-chromium,anirudhSK/chromium,patrickm/chromium.src,chuan9/chromium-crosswalk,Jonekee/chromium.src,zcbenz/cefode-chromium,patrickm/chromium.src,M4sse/chromium.src,markYoungH/chromium.src,Fireblend/chromium-crosswalk,junmin-zhu/chromium-rivertrail,dednal/chromium.src,Jonekee/chromium.src,krieger-od/nwjs_chromium.src,Jonekee/chromium.src,nacl-webkit/chrome_deps,ChromiumWebApps/chromium,dushu1203/chromium.src,anirudhSK/chromium,PeterWangIntel/chromium-crosswalk,mohamed--abdel-maksoud/chromium.src,TheTypoMaster/chromium-crosswalk,nacl-webkit/chrome_deps,ondra-novak/chromium.src,mogoweb/chromium-crosswalk,anirudhSK/chromium,TheTypoMaster/chromium-crosswalk,hgl888/chromium-crosswalk-efl,dednal/chromium.src,PeterWangIntel/chromium-crosswalk,timopulkkinen/BubbleFish,M4sse/chromium.src,anirudhSK/chromium,junmin-zhu/chromium-rivertrail,axinging/chromium-crosswalk,junmin-zhu/chromium-rivertrail,dushu1203/chromium.src,fujunwei/chromium-crosswalk,crosswalk-project/chromium-crosswalk-efl,bright-sparks/chromium-spacewalk,PeterWangIntel/chromium-crosswalk,dushu1203/chromium.src,fujunwei/chromium-crosswalk,Chilledheart/chromium,axinging/chromium-crosswalk,Just-D/chromium-1,Fireblend/chromium-crosswalk,hujiajie/pa-chromium,jaruba/chromium.src,dushu1203/chromium.src,markYoungH/chromium.src,bright-sparks/chromium-spacewalk,Jonekee/chromium.src,chuan9/chromium-crosswalk,ChromiumWebApps/chromium,ltilve/chromium,mogoweb/chromium-crosswalk,hujiajie/pa-chromium,PeterWangIntel/chromium-crosswalk,jaruba/chromium.src,pozdnyakov/chromium-crosswalk,junmin-zhu/chromium-rivertrail,hgl888/chromium-crosswalk,TheTypoMaster/chromium-crosswalk,timopulkkinen/BubbleFish,krieger-od/nwjs_chromium.src,dushu1203/chromium.src,chuan9/chromium-crosswalk,pozdnyakov/chromium-crosswalk,littlstar/chromium.src,fujunwei/chromium-crosswalk,Jonekee/chromium.src,ondra-novak/chromium.src,mogoweb/chromium-crosswalk,hgl888/chromium-crosswalk,M4sse/chromium.src,timopulkkinen/BubbleFish,patrickm/chromium.src,krieger-od/nwjs_chromium.src,mogoweb/chromium-crosswalk,Just-D/chromium-1,hujiajie/pa-chromium,hgl888/chromium-crosswalk,Chilledheart/chromium,timopulkkinen/BubbleFish,M4sse/chromium.src,pozdnyakov/chromium-crosswalk,dednal/chromium.src,mohamed--abdel-maksoud/chromium.src,anirudhSK/chromium,krieger-od/nwjs_chromium.src,fujunwei/chromium-crosswalk,zcbenz/cefode-chromium,nacl-webkit/chrome_deps,Just-D/chromium-1,ltilve/chromium,hgl888/chromium-crosswalk-efl,ondra-novak/chromium.src,fujunwei/chromium-crosswalk,hujiajie/pa-chromium,nacl-webkit/chrome_deps,axinging/chromium-crosswalk,M4sse/chromium.src,hgl888/chromium-crosswalk,ltilve/chromium,chuan9/chromium-crosswalk,nacl-webkit/chrome_deps,krieger-od/nwjs_chromium.src,zcbenz/cefode-chromium,TheTypoMaster/chromium-crosswalk,jaruba/chromium.src,Just-D/chromium-1,axinging/chromium-crosswalk,krieger-od/nwjs_chromium.src,dushu1203/chromium.src,markYoungH/chromium.src,ChromiumWebApps/chromium,krieger-od/nwjs_chromium.src,hgl888/chromium-crosswalk,littlstar/chromium.src,mogoweb/chromium-crosswalk,zcbenz/cefode-chromium,hujiajie/pa-chromium,M4sse/chromium.src,axinging/chromium-crosswalk,markYoungH/chromium.src,anirudhSK/chromium,zcbenz/cefode-chromium,hujiajie/pa-chromium,Pluto-tv/chromium-crosswalk,chuan9/chromium-crosswalk,PeterWangIntel/chromium-crosswalk,ltilve/chromium,timopulkkinen/BubbleFish,littlstar/chromium.src,TheTypoMaster/chromium-crosswalk,mogoweb/chromium-crosswalk,pozdnyakov/chromium-crosswalk,dushu1203/chromium.src,anirudhSK/chromium,Chilledheart/chromium,Pluto-tv/chromium-crosswalk,pozdnyakov/chromium-crosswalk,mohamed--abdel-maksoud/chromium.src,Chilledheart/chromium,Jonekee/chromium.src,PeterWangIntel/chromium-crosswalk,Just-D/chromium-1,patrickm/chromium.src,patrickm/chromium.src,bright-sparks/chromium-spacewalk,ChromiumWebApps/chromium,hgl888/chromium-crosswalk-efl,markYoungH/chromium.src,fujunwei/chromium-crosswalk,ondra-novak/chromium.src,junmin-zhu/chromium-rivertrail,fujunwei/chromium-crosswalk,jaruba/chromium.src,jaruba/chromium.src,Just-D/chromium-1,Chilledheart/chromium,axinging/chromium-crosswalk,chuan9/chromium-crosswalk,zcbenz/cefode-chromium,hgl888/chromium-crosswalk,ltilve/chromium,mohamed--abdel-maksoud/chromium.src,hgl888/chromium-crosswalk,zcbenz/cefode-chromium,timopulkkinen/BubbleFish,hgl888/chromium-crosswalk-efl,littlstar/chromium.src,nacl-webkit/chrome_deps,hgl888/chromium-crosswalk-efl,mogoweb/chromium-crosswalk,patrickm/chromium.src,littlstar/chromium.src,Just-D/chromium-1,Pluto-tv/chromium-crosswalk,M4sse/chromium.src,PeterWangIntel/chromium-crosswalk,anirudhSK/chromium,chuan9/chromium-crosswalk,jaruba/chromium.src,hujiajie/pa-chromium,axinging/chromium-crosswalk,markYoungH/chromium.src,Fireblend/chromium-crosswalk,Jonekee/chromium.src,TheTypoMaster/chromium-crosswalk,M4sse/chromium.src,axinging/chromium-crosswalk,jaruba/chromium.src,junmin-zhu/chromium-rivertrail,markYoungH/chromium.src,Pluto-tv/chromium-crosswalk,junmin-zhu/chromium-rivertrail,hujiajie/pa-chromium,nacl-webkit/chrome_deps,Just-D/chromium-1,timopulkkinen/BubbleFish,dednal/chromium.src,M4sse/chromium.src,nacl-webkit/chrome_deps,Jonekee/chromium.src,dushu1203/chromium.src,crosswalk-project/chromium-crosswalk-efl,bright-sparks/chromium-spacewalk,hujiajie/pa-chromium,mogoweb/chromium-crosswalk,Pluto-tv/chromium-crosswalk,ChromiumWebApps/chromium,Pluto-tv/chromium-crosswalk,Jonekee/chromium.src,Jonekee/chromium.src,Fireblend/chromium-crosswalk,hgl888/chromium-crosswalk-efl,Chilledheart/chromium,patrickm/chromium.src,littlstar/chromium.src,PeterWangIntel/chromium-crosswalk,jaruba/chromium.src,ltilve/chromium,markYoungH/chromium.src,dednal/chromium.src,fujunwei/chromium-crosswalk,hgl888/chromium-crosswalk-efl,pozdnyakov/chromium-crosswalk,dushu1203/chromium.src,jaruba/chromium.src,dednal/chromium.src,TheTypoMaster/chromium-crosswalk,anirudhSK/chromium,krieger-od/nwjs_chromium.src,hgl888/chromium-crosswalk,markYoungH/chromium.src,dushu1203/chromium.src,dednal/chromium.src,Fireblend/chromium-crosswalk,dushu1203/chromium.src,ltilve/chromium,ChromiumWebApps/chromium,TheTypoMaster/chromium-crosswalk,krieger-od/nwjs_chromium.src,hujiajie/pa-chromium,crosswalk-project/chromium-crosswalk-efl,timopulkkinen/BubbleFish,krieger-od/nwjs_chromium.src,Fireblend/chromium-crosswalk,Just-D/chromium-1,littlstar/chromium.src,jaruba/chromium.src,Chilledheart/chromium,mohamed--abdel-maksoud/chromium.src,pozdnyakov/chromium-crosswalk,pozdnyakov/chromium-crosswalk,Chilledheart/chromium,nacl-webkit/chrome_deps,ChromiumWebApps/chromium,bright-sparks/chromium-spacewalk,hgl888/chromium-crosswalk,zcbenz/cefode-chromium,zcbenz/cefode-chromium,jaruba/chromium.src,zcbenz/cefode-chromium