Rewrite the SMP filedesc locking in knote_attach() in order to   1.  eliminate unnecessary loop which frees and re-allocates 	the just allocated array   2.  eliminate the newsize recomputation   3.  eliminate unnecessary unlock and relock around free   4.  correctly match the free with the malloc into M_KQUEUE instead of M_TEMP   5.  eliminate conditional assignment of oldlist, which is equivalent to a 	simple assignment   6.  eliminate the oldlist temporary variable completely
Rewrite the SMP filedesc locking in knote_attach() in order to
  1.  eliminate unnecessary loop which frees and re-allocates
	the just allocated array
  2.  eliminate the newsize recomputation
  3.  eliminate unnecessary unlock and relock around free
  4.  correctly match the free with the malloc into M_KQUEUE instead of M_TEMP
  5.  eliminate conditional assignment of oldlist, which is equivalent to a
	simple assignment
  6.  eliminate the oldlist temporary variable completely

Reviewed by:    jhb

jrobhoward/SCADAbase,jrobhoward/SCADAbase,jrobhoward/SCADAbase,jrobhoward/SCADAbase,jrobhoward/SCADAbase,jrobhoward/SCADAbase,jrobhoward/SCADAbase,jrobhoward/SCADAbase,jrobhoward/SCADAbase,jrobhoward/SCADAbase,jrobhoward/SCADAbase