Some verify statements were wrapped in DEBUG() in PassManager.cpp that did not need to be. The reason why is the SILModule::verify is #ifndef NDEBUG out in no-assert builds. Thus the only thing these DEBUG() wrappers do is cause the user to need to pass in -Xllvm -debug-only=sil-passmanager to trigger the verifier. This also causes confusion for people not familiar with this property since they pass in -sil-verify-all and don't hit assertions in the verifier giving the mistaken impression that their code is verified when it is not.
Some verify statements were wrapped in DEBUG() in PassManager.cpp that did not need to be. The reason why is the SILModule::verify is #ifndef NDEBUG out in no-assert builds. Thus the only thing these DEBUG() wrappers do is cause the user to need to pass in -Xllvm -debug-only=sil-passmanager to trigger the verifier. This also causes confusion for people not familiar with this property since they pass in -sil-verify-all and don't hit assertions in the verifier giving the mistaken impression that their code is verified when it is not.

Swift SVN r16263

parkera/swift,jmgc/swift,lorentey/swift,swiftix/swift.old,tkremenek/swift,gottesmm/swift,kusl/swift,huonw/swift,mightydeveloper/swift,danielmartin/swift,modocache/swift,roambotics/swift,practicalswift/swift,modocache/swift,gregomni/swift,return/swift,mightydeveloper/swift,karwa/swift,gregomni/swift,dduan/swift,austinzheng/swift,uasys/swift,mightydeveloper/swift,IngmarStein/swift,arvedviehweger/swift,alblue/swift,milseman/swift,LeoShimonaka/swift,dreamsxin/swift,frootloops/swift,hooman/swift,allevato/swift,milseman/swift,amraboelela/swift,amraboelela/swift,tinysun212/swift-windows,ben-ng/swift,atrick/swift,shahmishal/swift,mightydeveloper/swift,kperryua/swift,therealbnut/swift,ahoppen/swift,gottesmm/swift,kusl/swift,jtbandes/swift,brentdax/swift,sdulal/swift,Jnosh/swift,bitjammer/swift,lorentey/swift,kusl/swift,atrick/swift,jopamer/swift,ahoppen/swift,swiftix/swift.old,ben-ng/swift,emilstahl/swift,huonw/swift,Jnosh/swift,shahmishal/swift,lorentey/swift,bitjammer/swift,alblue/swift,gmilos/swift,glessard/swift,natecook1000/swift,slavapestov/swift,swiftix/swift,shajrawi/swift,tkremenek/swift,hooman/swift,slavapestov/swift,cbrentharris/swift,ken0nek/swift,OscarSwanros/swift,modocache/swift,Ivacker/swift,JaSpa/swift,JGiola/swift,swiftix/swift.old,ben-ng/swift,tkremenek/swift,uasys/swift,xedin/swift,rudkx/swift,hughbe/swift,adrfer/swift,sdulal/swift,alblue/swift,aschwaighofer/swift,LeoShimonaka/swift,gregomni/swift,brentdax/swift,johnno1962d/swift,zisko/swift,devincoughlin/swift,arvedviehweger/swift,KrishMunot/swift,manavgabhawala/swift,rudkx/swift,modocache/swift,kusl/swift,codestergit/swift,shahmishal/swift,Ivacker/swift,kentya6/swift,glessard/swift,practicalswift/swift,milseman/swift,Jnosh/swift,kstaring/swift,kentya6/swift,austinzheng/swift,kentya6/swift,rudkx/swift,practicalswift/swift,sdulal/swift,swiftix/swift.old,gribozavr/swift,kstaring/swift,karwa/swift,karwa/swift,dduan/swift,harlanhaskins/swift,jmgc/swift,huonw/swift,gribozavr/swift,huonw/swift,natecook1000/swift,cbrentharris/swift,therealbnut/swift,xedin/swift,JGiola/swift,deyton/swift,jopamer/swift,djwbrown/swift,shajrawi/swift,sschiau/swift,adrfer/swift,manavgabhawala/swift,dreamsxin/swift,MukeshKumarS/Swift,gregomni/swift,tardieu/swift,tjw/swift,jopamer/swift,LeoShimonaka/swift,frootloops/swift,kstaring/swift,johnno1962d/swift,gribozavr/swift,aschwaighofer/swift,frootloops/swift,kperryua/swift,kperryua/swift,practicalswift/swift,hughbe/swift,KrishMunot/swift,benlangmuir/swift,LeoShimonaka/swift,kentya6/swift,russbishop/swift,allevato/swift,tjw/swift,johnno1962d/swift,cbrentharris/swift,dduan/swift,tardieu/swift,SwiftAndroid/swift,nathawes/swift,emilstahl/swift,felix91gr/swift,therealbnut/swift,johnno1962d/swift,ken0nek/swift,kperryua/swift,russbishop/swift,therealbnut/swift,apple/swift,apple/swift,aschwaighofer/swift,codestergit/swift,gmilos/swift,zisko/swift,djwbrown/swift,hooman/swift,modocache/swift,natecook1000/swift,frootloops/swift,gribozavr/swift,airspeedswift/swift,karwa/swift,tinysun212/swift-windows,nathawes/swift,parkera/swift,allevato/swift,kusl/swift,gmilos/swift,calebd/swift,tkremenek/swift,kusl/swift,swiftix/swift,gribozavr/swift,emilstahl/swift,amraboelela/swift,sschiau/swift,roambotics/swift,nathawes/swift,SwiftAndroid/swift,JaSpa/swift,jtbandes/swift,danielmartin/swift,amraboelela/swift,calebd/swift,alblue/swift,gmilos/swift,Ivacker/swift,slavapestov/swift,uasys/swift,kstaring/swift,adrfer/swift,KrishMunot/swift,felix91gr/swift,felix91gr/swift,LeoShimonaka/swift,jmgc/swift,austinzheng/swift,atrick/swift,slavapestov/swift,kstaring/swift,JaSpa/swift,manavgabhawala/swift,JGiola/swift,Ivacker/swift,tardieu/swift,slavapestov/swift,harlanhaskins/swift,kentya6/swift,xwu/swift,gregomni/swift,ken0nek/swift,gribozavr/swift,cbrentharris/swift,gmilos/swift,amraboelela/swift,johnno1962d/swift,apple/swift,natecook1000/swift,aschwaighofer/swift,xwu/swift,kentya6/swift,glessard/swift,return/swift,tinysun212/swift-windows,tardieu/swift,tkremenek/swift,mightydeveloper/swift,jtbandes/swift,alblue/swift,tjw/swift,stephentyrone/swift,austinzheng/swift,khizkhiz/swift,jmgc/swift,codestergit/swift,jckarter/swift,gmilos/swift,roambotics/swift,harlanhaskins/swift,devincoughlin/swift,SwiftAndroid/swift,calebd/swift,sdulal/swift,return/swift,uasys/swift,gmilos/swift,MukeshKumarS/Swift,parkera/swift,devincoughlin/swift,CodaFi/swift,jckarter/swift,xedin/swift,milseman/swift,harlanhaskins/swift,glessard/swift,swiftix/swift.old,hughbe/swift,deyton/swift,MukeshKumarS/Swift,aschwaighofer/swift,jmgc/swift,uasys/swift,kperryua/swift,shajrawi/swift,arvedviehweger/swift,xedin/swift,brentdax/swift,allevato/swift,gribozavr/swift,sschiau/swift,djwbrown/swift,benlangmuir/swift,tjw/swift,russbishop/swift,roambotics/swift,airspeedswift/swift,KrishMunot/swift,xwu/swift,tardieu/swift,modocache/swift,kentya6/swift,harlanhaskins/swift,ken0nek/swift,khizkhiz/swift,jckarter/swift,manavgabhawala/swift,sdulal/swift,ahoppen/swift,shahmishal/swift,lorentey/swift,ahoppen/swift,stephentyrone/swift,aschwaighofer/swift,KrishMunot/swift,calebd/swift,sschiau/swift,tinysun212/swift-windows,allevato/swift,stephentyrone/swift,hooman/swift,LeoShimonaka/swift,swiftix/swift,OscarSwanros/swift,ken0nek/swift,devincoughlin/swift,CodaFi/swift,atrick/swift,OscarSwanros/swift,johnno1962d/swift,allevato/swift,sdulal/swift,dduan/swift,manavgabhawala/swift,deyton/swift,tinysun212/swift-windows,airspeedswift/swift,huonw/swift,lorentey/swift,swiftix/swift,adrfer/swift,Ivacker/swift,swiftix/swift.old,apple/swift,frootloops/swift,IngmarStein/swift,jckarter/swift,emilstahl/swift,cbrentharris/swift,khizkhiz/swift,cbrentharris/swift,uasys/swift,nathawes/swift,modocache/swift,ben-ng/swift,emilstahl/swift,shajrawi/swift,djwbrown/swift,arvedviehweger/swift,xwu/swift,mightydeveloper/swift,JaSpa/swift,OscarSwanros/swift,xedin/swift,stephentyrone/swift,cbrentharris/swift,IngmarStein/swift,JaSpa/swift,uasys/swift,mightydeveloper/swift,glessard/swift,sschiau/swift,khizkhiz/swift,karwa/swift,xwu/swift,swiftix/swift,gottesmm/swift,gottesmm/swift,ben-ng/swift,roambotics/swift,cbrentharris/swift,tkremenek/swift,deyton/swift,SwiftAndroid/swift,shahmishal/swift,felix91gr/swift,kperryua/swift,hughbe/swift,shahmishal/swift,arvedviehweger/swift,stephentyrone/swift,devincoughlin/swift,atrick/swift,djwbrown/swift,natecook1000/swift,hughbe/swift,emilstahl/swift,karwa/swift,MukeshKumarS/Swift,stephentyrone/swift,xedin/swift,bitjammer/swift,gottesmm/swift,swiftix/swift,apple/swift,deyton/swift,johnno1962d/swift,shahmishal/swift,airspeedswift/swift,jmgc/swift,russbishop/swift,dduan/swift,huonw/swift,calebd/swift,tkremenek/swift,nathawes/swift,aschwaighofer/swift,deyton/swift,alblue/swift,manavgabhawala/swift,shajrawi/swift,gregomni/swift,Jnosh/swift,allevato/swift,natecook1000/swift,gottesmm/swift,milseman/swift,SwiftAndroid/swift,rudkx/swift,JGiola/swift,amraboelela/swift,brentdax/swift,khizkhiz/swift,kstaring/swift,rudkx/swift,JaSpa/swift,sschiau/swift,calebd/swift,zisko/swift,austinzheng/swift,lorentey/swift,danielmartin/swift,adrfer/swift,bitjammer/swift,adrfer/swift,CodaFi/swift,return/swift,CodaFi/swift,MukeshKumarS/Swift,roambotics/swift,sdulal/swift,KrishMunot/swift,Jnosh/swift,codestergit/swift,adrfer/swift,return/swift,MukeshKumarS/Swift,felix91gr/swift,arvedviehweger/swift,therealbnut/swift,zisko/swift,kusl/swift,LeoShimonaka/swift,kusl/swift,devincoughlin/swift,tardieu/swift,brentdax/swift,CodaFi/swift,nathawes/swift,zisko/swift,devincoughlin/swift,jtbandes/swift,codestergit/swift,stephentyrone/swift,Ivacker/swift,ken0nek/swift,OscarSwanros/swift,alblue/swift,milseman/swift,dduan/swift,OscarSwanros/swift,return/swift,jtbandes/swift,sschiau/swift,OscarSwanros/swift,parkera/swift,swiftix/swift.old,parkera/swift,kentya6/swift,ben-ng/swift,jopamer/swift,sschiau/swift,kstaring/swift,glessard/swift,Jnosh/swift,brentdax/swift,xwu/swift,karwa/swift,harlanhaskins/swift,lorentey/swift,khizkhiz/swift,amraboelela/swift,ahoppen/swift,danielmartin/swift,codestergit/swift,russbishop/swift,calebd/swift,jtbandes/swift,gribozavr/swift,parkera/swift,SwiftAndroid/swift,tinysun212/swift-windows,SwiftAndroid/swift,airspeedswift/swift,MukeshKumarS/Swift,practicalswift/swift,bitjammer/swift,jckarter/swift,kperryua/swift,devincoughlin/swift,austinzheng/swift,codestergit/swift,dduan/swift,jopamer/swift,danielmartin/swift,jckarter/swift,mightydeveloper/swift,parkera/swift,parkera/swift,emilstahl/swift,shahmishal/swift,emilstahl/swift,felix91gr/swift,LeoShimonaka/swift,shajrawi/swift,jopamer/swift,tinysun212/swift-windows,Jnosh/swift,IngmarStein/swift,shajrawi/swift,zisko/swift,KrishMunot/swift,JGiola/swift,slavapestov/swift,natecook1000/swift,atrick/swift,sdulal/swift,arvedviehweger/swift,hughbe/swift,return/swift,benlangmuir/swift,huonw/swift,slavapestov/swift,IngmarStein/swift,practicalswift/swift,bitjammer/swift,JaSpa/swift,xedin/swift,ahoppen/swift,deyton/swift,djwbrown/swift,xwu/swift,practicalswift/swift,CodaFi/swift,frootloops/swift,IngmarStein/swift,hooman/swift,Ivacker/swift,djwbrown/swift,swiftix/swift,JGiola/swift,rudkx/swift,jtbandes/swift,tardieu/swift,airspeedswift/swift,IngmarStein/swift,xedin/swift,benlangmuir/swift,nathawes/swift,danielmartin/swift,karwa/swift,ben-ng/swift,austinzheng/swift,hooman/swift,hughbe/swift,tjw/swift,swiftix/swift.old,danielmartin/swift,lorentey/swift,felix91gr/swift,gottesmm/swift,manavgabhawala/swift,airspeedswift/swift,tjw/swift,practicalswift/swift,shajrawi/swift,tjw/swift,russbishop/swift,Ivacker/swift,bitjammer/swift,benlangmuir/swift,jopamer/swift,jmgc/swift,hooman/swift,brentdax/swift,CodaFi/swift,russbishop/swift,harlanhaskins/swift,apple/swift,benlangmuir/swift,milseman/swift,frootloops/swift,jckarter/swift,khizkhiz/swift,ken0nek/swift,therealbnut/swift,therealbnut/swift,zisko/swift