Revert "domain_conf: check device address before attach"
Revert "domain_conf: check device address before attach"

This reverts commit f1d6585300001c7b23b8796a0faa4411c3531996.

Turns out, this caused a regression. There is this (perhaps less
known) semantic of virDomainAttachDevice() where if the device
the API is trying to attach is a CDROM/floppy that is already in
the domain the attach request is handled as 'change the media in
the drive'.

We have a better fix anyways.

Signed-off-by: Michal Privoznik <83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com>
Tested-by: Daniel Henrique Barboza <627b089ad62deae9aaf06ccfa2c9056df28927e0@gmail.com>
Reviewed-by: Jim Fehlig <39929b5b86d72d51fceac59b52303e3fe8a3083e@suse.com>

andreabolognani/libvirt,jfehlig/libvirt,zippy2/libvirt,fabianfreyer/libvirt,andreabolognani/libvirt,olafhering/libvirt,jardasgit/libvirt,zippy2/libvirt,jfehlig/libvirt,libvirt/libvirt,fabianfreyer/libvirt,nertpinx/libvirt,jfehlig/libvirt,libvirt/libvirt,zippy2/libvirt,olafhering/libvirt,eskultety/libvirt,fabianfreyer/libvirt,nertpinx/libvirt,andreabolognani/libvirt,eskultety/libvirt,crobinso/libvirt,jardasgit/libvirt,fabianfreyer/libvirt,libvirt/libvirt,crobinso/libvirt,jfehlig/libvirt,jardasgit/libvirt,libvirt/libvirt,andreabolognani/libvirt,crobinso/libvirt,nertpinx/libvirt,jardasgit/libvirt,eskultety/libvirt,eskultety/libvirt,nertpinx/libvirt,andreabolognani/libvirt,olafhering/libvirt,olafhering/libvirt,fabianfreyer/libvirt,nertpinx/libvirt,crobinso/libvirt,eskultety/libvirt,jardasgit/libvirt,zippy2/libvirt