Clean up ScopedVectorTest's LifeCycleObject.
Clean up ScopedVectorTest's LifeCycleObject.

The scoped_ptr<LifeCycleObject> was unncessary and confusing. The LifeCycleWatcher safely owns its LifeCycleObject and deletes it. The scoped_ptr made things a bit confusing even, since the only reason we weren't getting a double delete was because the scoped_ptr had an (ever so) slightly narrower scope than watcher.

Making the LifeCycleObject mostly private should encourage future callers not to add scary aliases. 

R=willchan@chromium.org
BUG=None


Review URL: https://chromiumcodereview.appspot.com/11416166

git-svn-id: de016e52bd170d2d4f2344f9bf92d50478b649e0@171058 0039d316-1c4b-4281-b951-d872f2087c98

Just-D/chromium-1,Pluto-tv/chromium-crosswalk,hujiajie/pa-chromium,hgl888/chromium-crosswalk,pozdnyakov/chromium-crosswalk,nacl-webkit/chrome_deps,timopulkkinen/BubbleFish,mohamed--abdel-maksoud/chromium.src,ltilve/chromium,Just-D/chromium-1,Chilledheart/chromium,hujiajie/pa-chromium,M4sse/chromium.src,nacl-webkit/chrome_deps,krieger-od/nwjs_chromium.src,fujunwei/chromium-crosswalk,axinging/chromium-crosswalk,hgl888/chromium-crosswalk-efl,TheTypoMaster/chromium-crosswalk,markYoungH/chromium.src,chuan9/chromium-crosswalk,markYoungH/chromium.src,patrickm/chromium.src,ondra-novak/chromium.src,zcbenz/cefode-chromium,hgl888/chromium-crosswalk-efl,krieger-od/nwjs_chromium.src,Jonekee/chromium.src,anirudhSK/chromium,zcbenz/cefode-chromium,pozdnyakov/chromium-crosswalk,pozdnyakov/chromium-crosswalk,krieger-od/nwjs_chromium.src,hgl888/chromium-crosswalk-efl,jaruba/chromium.src,TheTypoMaster/chromium-crosswalk,M4sse/chromium.src,fujunwei/chromium-crosswalk,jaruba/chromium.src,ChromiumWebApps/chromium,nacl-webkit/chrome_deps,krieger-od/nwjs_chromium.src,nacl-webkit/chrome_deps,ChromiumWebApps/chromium,markYoungH/chromium.src,bright-sparks/chromium-spacewalk,markYoungH/chromium.src,hgl888/chromium-crosswalk,Pluto-tv/chromium-crosswalk,Fireblend/chromium-crosswalk,dednal/chromium.src,timopulkkinen/BubbleFish,pozdnyakov/chromium-crosswalk,chuan9/chromium-crosswalk,zcbenz/cefode-chromium,PeterWangIntel/chromium-crosswalk,bright-sparks/chromium-spacewalk,dednal/chromium.src,fujunwei/chromium-crosswalk,ondra-novak/chromium.src,dushu1203/chromium.src,axinging/chromium-crosswalk,nacl-webkit/chrome_deps,zcbenz/cefode-chromium,mogoweb/chromium-crosswalk,ltilve/chromium,dushu1203/chromium.src,dednal/chromium.src,dednal/chromium.src,mohamed--abdel-maksoud/chromium.src,PeterWangIntel/chromium-crosswalk,Pluto-tv/chromium-crosswalk,hgl888/chromium-crosswalk-efl,dushu1203/chromium.src,hujiajie/pa-chromium,mogoweb/chromium-crosswalk,fujunwei/chromium-crosswalk,ChromiumWebApps/chromium,zcbenz/cefode-chromium,mogoweb/chromium-crosswalk,hujiajie/pa-chromium,mohamed--abdel-maksoud/chromium.src,timopulkkinen/BubbleFish,dednal/chromium.src,Chilledheart/chromium,markYoungH/chromium.src,zcbenz/cefode-chromium,hujiajie/pa-chromium,krieger-od/nwjs_chromium.src,Just-D/chromium-1,hgl888/chromium-crosswalk,bright-sparks/chromium-spacewalk,anirudhSK/chromium,hujiajie/pa-chromium,Jonekee/chromium.src,dushu1203/chromium.src,PeterWangIntel/chromium-crosswalk,ltilve/chromium,mohamed--abdel-maksoud/chromium.src,zcbenz/cefode-chromium,anirudhSK/chromium,anirudhSK/chromium,hgl888/chromium-crosswalk-efl,krieger-od/nwjs_chromium.src,dushu1203/chromium.src,Jonekee/chromium.src,hujiajie/pa-chromium,M4sse/chromium.src,hgl888/chromium-crosswalk,Fireblend/chromium-crosswalk,mohamed--abdel-maksoud/chromium.src,markYoungH/chromium.src,TheTypoMaster/chromium-crosswalk,littlstar/chromium.src,anirudhSK/chromium,pozdnyakov/chromium-crosswalk,ondra-novak/chromium.src,anirudhSK/chromium,pozdnyakov/chromium-crosswalk,patrickm/chromium.src,TheTypoMaster/chromium-crosswalk,hujiajie/pa-chromium,Jonekee/chromium.src,Jonekee/chromium.src,littlstar/chromium.src,axinging/chromium-crosswalk,nacl-webkit/chrome_deps,bright-sparks/chromium-spacewalk,crosswalk-project/chromium-crosswalk-efl,axinging/chromium-crosswalk,M4sse/chromium.src,Chilledheart/chromium,Jonekee/chromium.src,mohamed--abdel-maksoud/chromium.src,Fireblend/chromium-crosswalk,Pluto-tv/chromium-crosswalk,mogoweb/chromium-crosswalk,anirudhSK/chromium,Just-D/chromium-1,axinging/chromium-crosswalk,Jonekee/chromium.src,timopulkkinen/BubbleFish,jaruba/chromium.src,mohamed--abdel-maksoud/chromium.src,mohamed--abdel-maksoud/chromium.src,timopulkkinen/BubbleFish,chuan9/chromium-crosswalk,mogoweb/chromium-crosswalk,ondra-novak/chromium.src,ondra-novak/chromium.src,zcbenz/cefode-chromium,dushu1203/chromium.src,Just-D/chromium-1,Pluto-tv/chromium-crosswalk,ChromiumWebApps/chromium,timopulkkinen/BubbleFish,axinging/chromium-crosswalk,mohamed--abdel-maksoud/chromium.src,dednal/chromium.src,dushu1203/chromium.src,TheTypoMaster/chromium-crosswalk,axinging/chromium-crosswalk,crosswalk-project/chromium-crosswalk-efl,Pluto-tv/chromium-crosswalk,timopulkkinen/BubbleFish,hgl888/chromium-crosswalk-efl,dednal/chromium.src,ChromiumWebApps/chromium,hgl888/chromium-crosswalk,M4sse/chromium.src,ltilve/chromium,nacl-webkit/chrome_deps,chuan9/chromium-crosswalk,littlstar/chromium.src,timopulkkinen/BubbleFish,M4sse/chromium.src,nacl-webkit/chrome_deps,Just-D/chromium-1,timopulkkinen/BubbleFish,Fireblend/chromium-crosswalk,Chilledheart/chromium,ondra-novak/chromium.src,crosswalk-project/chromium-crosswalk-efl,jaruba/chromium.src,dushu1203/chromium.src,ltilve/chromium,Pluto-tv/chromium-crosswalk,ondra-novak/chromium.src,M4sse/chromium.src,ChromiumWebApps/chromium,markYoungH/chromium.src,ltilve/chromium,PeterWangIntel/chromium-crosswalk,chuan9/chromium-crosswalk,chuan9/chromium-crosswalk,jaruba/chromium.src,bright-sparks/chromium-spacewalk,littlstar/chromium.src,hujiajie/pa-chromium,nacl-webkit/chrome_deps,crosswalk-project/chromium-crosswalk-efl,bright-sparks/chromium-spacewalk,markYoungH/chromium.src,dednal/chromium.src,pozdnyakov/chromium-crosswalk,zcbenz/cefode-chromium,crosswalk-project/chromium-crosswalk-efl,Fireblend/chromium-crosswalk,crosswalk-project/chromium-crosswalk-efl,axinging/chromium-crosswalk,axinging/chromium-crosswalk,dednal/chromium.src,nacl-webkit/chrome_deps,krieger-od/nwjs_chromium.src,pozdnyakov/chromium-crosswalk,hgl888/chromium-crosswalk-efl,crosswalk-project/chromium-crosswalk-efl,hujiajie/pa-chromium,dushu1203/chromium.src,ChromiumWebApps/chromium,fujunwei/chromium-crosswalk,M4sse/chromium.src,dednal/chromium.src,Chilledheart/chromium,chuan9/chromium-crosswalk,PeterWangIntel/chromium-crosswalk,patrickm/chromium.src,anirudhSK/chromium,mogoweb/chromium-crosswalk,jaruba/chromium.src,fujunwei/chromium-crosswalk,ChromiumWebApps/chromium,pozdnyakov/chromium-crosswalk,jaruba/chromium.src,ltilve/chromium,TheTypoMaster/chromium-crosswalk,TheTypoMaster/chromium-crosswalk,mohamed--abdel-maksoud/chromium.src,Just-D/chromium-1,dushu1203/chromium.src,markYoungH/chromium.src,hgl888/chromium-crosswalk-efl,jaruba/chromium.src,ltilve/chromium,Chilledheart/chromium,bright-sparks/chromium-spacewalk,dednal/chromium.src,ChromiumWebApps/chromium,Just-D/chromium-1,pozdnyakov/chromium-crosswalk,ondra-novak/chromium.src,dushu1203/chromium.src,patrickm/chromium.src,anirudhSK/chromium,ltilve/chromium,Jonekee/chromium.src,Pluto-tv/chromium-crosswalk,littlstar/chromium.src,hgl888/chromium-crosswalk,ondra-novak/chromium.src,littlstar/chromium.src,chuan9/chromium-crosswalk,ChromiumWebApps/chromium,patrickm/chromium.src,fujunwei/chromium-crosswalk,Fireblend/chromium-crosswalk,patrickm/chromium.src,anirudhSK/chromium,PeterWangIntel/chromium-crosswalk,PeterWangIntel/chromium-crosswalk,anirudhSK/chromium,jaruba/chromium.src,krieger-od/nwjs_chromium.src,nacl-webkit/chrome_deps,Fireblend/chromium-crosswalk,Jonekee/chromium.src,markYoungH/chromium.src,timopulkkinen/BubbleFish,hgl888/chromium-crosswalk,Jonekee/chromium.src,fujunwei/chromium-crosswalk,PeterWangIntel/chromium-crosswalk,jaruba/chromium.src,hgl888/chromium-crosswalk,chuan9/chromium-crosswalk,PeterWangIntel/chromium-crosswalk,jaruba/chromium.src,bright-sparks/chromium-spacewalk,pozdnyakov/chromium-crosswalk,fujunwei/chromium-crosswalk,timopulkkinen/BubbleFish,zcbenz/cefode-chromium,ChromiumWebApps/chromium,hgl888/chromium-crosswalk-efl,Chilledheart/chromium,hujiajie/pa-chromium,M4sse/chromium.src,TheTypoMaster/chromium-crosswalk,TheTypoMaster/chromium-crosswalk,markYoungH/chromium.src,bright-sparks/chromium-spacewalk,littlstar/chromium.src,mogoweb/chromium-crosswalk,Fireblend/chromium-crosswalk,mogoweb/chromium-crosswalk,mogoweb/chromium-crosswalk,M4sse/chromium.src,hgl888/chromium-crosswalk-efl,Chilledheart/chromium,axinging/chromium-crosswalk,Jonekee/chromium.src,littlstar/chromium.src,krieger-od/nwjs_chromium.src,zcbenz/cefode-chromium,crosswalk-project/chromium-crosswalk-efl,krieger-od/nwjs_chromium.src,Chilledheart/chromium,patrickm/chromium.src,Just-D/chromium-1,M4sse/chromium.src,mohamed--abdel-maksoud/chromium.src,hgl888/chromium-crosswalk,anirudhSK/chromium,axinging/chromium-crosswalk,patrickm/chromium.src,Fireblend/chromium-crosswalk,Pluto-tv/chromium-crosswalk,patrickm/chromium.src,ChromiumWebApps/chromium,crosswalk-project/chromium-crosswalk-efl,mogoweb/chromium-crosswalk,krieger-od/nwjs_chromium.src