compositor: fix uniform handling for fade_output()
compositor: fix uniform handling for fade_output()

fade_output() is strange in that it manufactures a wlsc_surface object
by hand, and then calls wlsc_surface_draw() on it.

Valgrind complained, that wlsc_surface_draw() accesses uninitialised
data: wlsc_surface::alpha. fade_output() forgets to set it.

Initialise surface.alpha in fade_output(). Specifically, set it to
compositor->current_alpha to deliberatly avoid the gluniform1f() call in
wlsc_surface_draw().

fade_output() binds a different GL shader program than
wlsc_surface_draw() expects. This program does not have a uniform called
"alpha", and the uniform location given in glUniform1f() is not for
this program anyway. A hint of that is the runtime error:
Mesa: User error: GL_INVALID_OPERATION in glUniform(type mismatch)

Fixing this seems to get rid of half a thousand of Valgrind errors, and
of course the Mesa user error.

Signed-off-by: Pekka Paalanen <6c0263d81461c956d504307112a4ce25eaacc3d1@gmail.com>

Fantu/compositor-spice,udoprog/weston,eyolfson/weston,Fantu/compositor-spice,Gnurou/weston,mchalupa/weston,giucam/weston,sir-murray/weston,eyolfson/weston,xorgy/weston,mchalupa/weston,Tarnyko/weston-xdg_surface_present,krezovic/weston,giucam/weston,Tarnyko/weston-xdg_surface_present,Gnurou/weston,jonnylamb/weston,krezovic/weston,jonnylamb/weston,kwm81/weston,udoprog/weston,sir-murray/weston,kwm81/weston,Fantu/compositor-spice,xorgy/weston