refactor: Remove brittle check for !select_first_unread.
refactor: Remove brittle check for !select_first_unread.

When we are deciding whether to preserve scroll position, we
mainly care that then_select_offset is set to a value.  If
we had no intention of preserving scroll offset, we would have
never bothered to set it.  The check for !select_first_unread
is always redundant, as verified by lots of clicking around
with some print debugging.  And it's a brittle check,
because it couples the decision of scrolling destination to
the mechanism by which we decide our selection.  While those
things are closely related, it's possible in the future that
we'll decide to advance to an unread message and still want
to set then_select_offset, but we might forget to mutate
select_first_unread.

Long story short, the code is simpler and safer now.

brainwane/zulip,timabbott/zulip,kou/zulip,kou/zulip,dhcrzf/zulip,shubhamdhama/zulip,eeshangarg/zulip,rishig/zulip,hackerkid/zulip,rishig/zulip,rht/zulip,andersk/zulip,eeshangarg/zulip,showell/zulip,kou/zulip,timabbott/zulip,brainwane/zulip,showell/zulip,synicalsyntax/zulip,rishig/zulip,zulip/zulip,tommyip/zulip,zulip/zulip,punchagan/zulip,punchagan/zulip,showell/zulip,dhcrzf/zulip,eeshangarg/zulip,jackrzhang/zulip,andersk/zulip,showell/zulip,dhcrzf/zulip,tommyip/zulip,rht/zulip,rht/zulip,eeshangarg/zulip,zulip/zulip,jackrzhang/zulip,zulip/zulip,rishig/zulip,andersk/zulip,punchagan/zulip,brainwane/zulip,synicalsyntax/zulip,punchagan/zulip,showell/zulip,timabbott/zulip,jackrzhang/zulip,rht/zulip,kou/zulip,timabbott/zulip,eeshangarg/zulip,zulip/zulip,rishig/zulip,rht/zulip,timabbott/zulip,dhcrzf/zulip,hackerkid/zulip,jackrzhang/zulip,eeshangarg/zulip,hackerkid/zulip,punchagan/zulip,andersk/zulip,jackrzhang/zulip,dhcrzf/zulip,timabbott/zulip,rishig/zulip,brainwane/zulip,showell/zulip,tommyip/zulip,kou/zulip,punchagan/zulip,showell/zulip,dhcrzf/zulip,synicalsyntax/zulip,synicalsyntax/zulip,shubhamdhama/zulip,hackerkid/zulip,brainwane/zulip,shubhamdhama/zulip,synicalsyntax/zulip,shubhamdhama/zulip,andersk/zulip,andersk/zulip,shubhamdhama/zulip,hackerkid/zulip,kou/zulip,brainwane/zulip,brainwane/zulip,timabbott/zulip,shubhamdhama/zulip,kou/zulip,rht/zulip,punchagan/zulip,jackrzhang/zulip,tommyip/zulip,synicalsyntax/zulip,synicalsyntax/zulip,zulip/zulip,eeshangarg/zulip,hackerkid/zulip,jackrzhang/zulip,shubhamdhama/zulip,zulip/zulip,tommyip/zulip,andersk/zulip,rht/zulip,tommyip/zulip,tommyip/zulip,hackerkid/zulip,rishig/zulip,dhcrzf/zulip