ui/base/models: Reverse the DCHECKs of index.
ui/base/models: Reverse the DCHECKs of index.

The way it's written until now is counter-intuitive. This makes it intuitive.

1 - To make sure an int index is in the array range when we are adding we should check for:
index >= 0 && index <= child_count().

So use DCHECK_GE for '>=' and DCHECK_LE for '<=' respectively.

2 - To make sure an int index is in the array range when we are retrieving it from vector we should check for:
index >= 0 && index < child_count().

So use DCHECK_GE for '>=' and DCHECK_LT for '<' respectively.

BUG=None
TEST=app_unittests --gtest_filter=TreeNodeModelTest.*

R=sky@chromium.org

Review URL: http://codereview.chromium.org/7058030

git-svn-id: de016e52bd170d2d4f2344f9bf92d50478b649e0@87716 0039d316-1c4b-4281-b951-d872f2087c98

hgl888/chromium-crosswalk,ondra-novak/chromium.src,keishi/chromium,jaruba/chromium.src,markYoungH/chromium.src,anirudhSK/chromium,ChromiumWebApps/chromium,fujunwei/chromium-crosswalk,Jonekee/chromium.src,mogoweb/chromium-crosswalk,anirudhSK/chromium,mohamed--abdel-maksoud/chromium.src,zcbenz/cefode-chromium,M4sse/chromium.src,anirudhSK/chromium,junmin-zhu/chromium-rivertrail,chuan9/chromium-crosswalk,fujunwei/chromium-crosswalk,pozdnyakov/chromium-crosswalk,Pluto-tv/chromium-crosswalk,chuan9/chromium-crosswalk,keishi/chromium,bright-sparks/chromium-spacewalk,hgl888/chromium-crosswalk-efl,robclark/chromium,Pluto-tv/chromium-crosswalk,mogoweb/chromium-crosswalk,patrickm/chromium.src,Chilledheart/chromium,mogoweb/chromium-crosswalk,robclark/chromium,dednal/chromium.src,mohamed--abdel-maksoud/chromium.src,TheTypoMaster/chromium-crosswalk,Just-D/chromium-1,Fireblend/chromium-crosswalk,hujiajie/pa-chromium,chuan9/chromium-crosswalk,anirudhSK/chromium,ChromiumWebApps/chromium,dushu1203/chromium.src,bright-sparks/chromium-spacewalk,dushu1203/chromium.src,ondra-novak/chromium.src,hujiajie/pa-chromium,anirudhSK/chromium,bright-sparks/chromium-spacewalk,hujiajie/pa-chromium,junmin-zhu/chromium-rivertrail,mogoweb/chromium-crosswalk,ondra-novak/chromium.src,Pluto-tv/chromium-crosswalk,ltilve/chromium,ChromiumWebApps/chromium,M4sse/chromium.src,hgl888/chromium-crosswalk,jaruba/chromium.src,rogerwang/chromium,Jonekee/chromium.src,jaruba/chromium.src,dushu1203/chromium.src,ltilve/chromium,Jonekee/chromium.src,TheTypoMaster/chromium-crosswalk,junmin-zhu/chromium-rivertrail,rogerwang/chromium,M4sse/chromium.src,hgl888/chromium-crosswalk,Just-D/chromium-1,krieger-od/nwjs_chromium.src,littlstar/chromium.src,markYoungH/chromium.src,markYoungH/chromium.src,rogerwang/chromium,keishi/chromium,keishi/chromium,Just-D/chromium-1,pozdnyakov/chromium-crosswalk,axinging/chromium-crosswalk,M4sse/chromium.src,hgl888/chromium-crosswalk-efl,Just-D/chromium-1,junmin-zhu/chromium-rivertrail,TheTypoMaster/chromium-crosswalk,fujunwei/chromium-crosswalk,mohamed--abdel-maksoud/chromium.src,junmin-zhu/chromium-rivertrail,timopulkkinen/BubbleFish,chuan9/chromium-crosswalk,littlstar/chromium.src,Fireblend/chromium-crosswalk,Fireblend/chromium-crosswalk,krieger-od/nwjs_chromium.src,dushu1203/chromium.src,zcbenz/cefode-chromium,ondra-novak/chromium.src,markYoungH/chromium.src,ondra-novak/chromium.src,nacl-webkit/chrome_deps,ChromiumWebApps/chromium,anirudhSK/chromium,dednal/chromium.src,Chilledheart/chromium,jaruba/chromium.src,mogoweb/chromium-crosswalk,hgl888/chromium-crosswalk,hgl888/chromium-crosswalk,Chilledheart/chromium,axinging/chromium-crosswalk,chuan9/chromium-crosswalk,chuan9/chromium-crosswalk,timopulkkinen/BubbleFish,Just-D/chromium-1,markYoungH/chromium.src,TheTypoMaster/chromium-crosswalk,hujiajie/pa-chromium,robclark/chromium,Jonekee/chromium.src,robclark/chromium,nacl-webkit/chrome_deps,crosswalk-project/chromium-crosswalk-efl,M4sse/chromium.src,pozdnyakov/chromium-crosswalk,ltilve/chromium,ondra-novak/chromium.src,dushu1203/chromium.src,zcbenz/cefode-chromium,timopulkkinen/BubbleFish,Pluto-tv/chromium-crosswalk,hgl888/chromium-crosswalk-efl,krieger-od/nwjs_chromium.src,keishi/chromium,timopulkkinen/BubbleFish,dednal/chromium.src,Pluto-tv/chromium-crosswalk,TheTypoMaster/chromium-crosswalk,M4sse/chromium.src,junmin-zhu/chromium-rivertrail,littlstar/chromium.src,Chilledheart/chromium,M4sse/chromium.src,M4sse/chromium.src,krieger-od/nwjs_chromium.src,Just-D/chromium-1,axinging/chromium-crosswalk,nacl-webkit/chrome_deps,anirudhSK/chromium,dushu1203/chromium.src,dednal/chromium.src,chuan9/chromium-crosswalk,rogerwang/chromium,Fireblend/chromium-crosswalk,anirudhSK/chromium,Pluto-tv/chromium-crosswalk,timopulkkinen/BubbleFish,Jonekee/chromium.src,ChromiumWebApps/chromium,nacl-webkit/chrome_deps,patrickm/chromium.src,axinging/chromium-crosswalk,fujunwei/chromium-crosswalk,Fireblend/chromium-crosswalk,Jonekee/chromium.src,dednal/chromium.src,ltilve/chromium,ChromiumWebApps/chromium,junmin-zhu/chromium-rivertrail,patrickm/chromium.src,nacl-webkit/chrome_deps,Pluto-tv/chromium-crosswalk,krieger-od/nwjs_chromium.src,Chilledheart/chromium,littlstar/chromium.src,patrickm/chromium.src,dushu1203/chromium.src,keishi/chromium,krieger-od/nwjs_chromium.src,hgl888/chromium-crosswalk,Fireblend/chromium-crosswalk,bright-sparks/chromium-spacewalk,zcbenz/cefode-chromium,dednal/chromium.src,dushu1203/chromium.src,dednal/chromium.src,mohamed--abdel-maksoud/chromium.src,hgl888/chromium-crosswalk,mohamed--abdel-maksoud/chromium.src,jaruba/chromium.src,ondra-novak/chromium.src,keishi/chromium,timopulkkinen/BubbleFish,zcbenz/cefode-chromium,Chilledheart/chromium,anirudhSK/chromium,crosswalk-project/chromium-crosswalk-efl,Jonekee/chromium.src,hujiajie/pa-chromium,littlstar/chromium.src,ChromiumWebApps/chromium,nacl-webkit/chrome_deps,axinging/chromium-crosswalk,patrickm/chromium.src,timopulkkinen/BubbleFish,patrickm/chromium.src,zcbenz/cefode-chromium,keishi/chromium,keishi/chromium,krieger-od/nwjs_chromium.src,M4sse/chromium.src,Just-D/chromium-1,ChromiumWebApps/chromium,rogerwang/chromium,axinging/chromium-crosswalk,hgl888/chromium-crosswalk-efl,mohamed--abdel-maksoud/chromium.src,hgl888/chromium-crosswalk-efl,littlstar/chromium.src,Jonekee/chromium.src,axinging/chromium-crosswalk,jaruba/chromium.src,pozdnyakov/chromium-crosswalk,M4sse/chromium.src,PeterWangIntel/chromium-crosswalk,dednal/chromium.src,hujiajie/pa-chromium,dednal/chromium.src,Jonekee/chromium.src,hujiajie/pa-chromium,crosswalk-project/chromium-crosswalk-efl,robclark/chromium,crosswalk-project/chromium-crosswalk-efl,jaruba/chromium.src,ondra-novak/chromium.src,fujunwei/chromium-crosswalk,timopulkkinen/BubbleFish,Pluto-tv/chromium-crosswalk,dushu1203/chromium.src,pozdnyakov/chromium-crosswalk,axinging/chromium-crosswalk,Fireblend/chromium-crosswalk,hujiajie/pa-chromium,markYoungH/chromium.src,rogerwang/chromium,ltilve/chromium,nacl-webkit/chrome_deps,Just-D/chromium-1,crosswalk-project/chromium-crosswalk-efl,dushu1203/chromium.src,mogoweb/chromium-crosswalk,crosswalk-project/chromium-crosswalk-efl,crosswalk-project/chromium-crosswalk-efl,ltilve/chromium,Chilledheart/chromium,anirudhSK/chromium,PeterWangIntel/chromium-crosswalk,mohamed--abdel-maksoud/chromium.src,PeterWangIntel/chromium-crosswalk,TheTypoMaster/chromium-crosswalk,Jonekee/chromium.src,timopulkkinen/BubbleFish,markYoungH/chromium.src,markYoungH/chromium.src,rogerwang/chromium,hgl888/chromium-crosswalk-efl,mogoweb/chromium-crosswalk,hgl888/chromium-crosswalk-efl,PeterWangIntel/chromium-crosswalk,pozdnyakov/chromium-crosswalk,jaruba/chromium.src,fujunwei/chromium-crosswalk,Chilledheart/chromium,krieger-od/nwjs_chromium.src,nacl-webkit/chrome_deps,timopulkkinen/BubbleFish,littlstar/chromium.src,markYoungH/chromium.src,bright-sparks/chromium-spacewalk,Pluto-tv/chromium-crosswalk,hgl888/chromium-crosswalk-efl,littlstar/chromium.src,krieger-od/nwjs_chromium.src,patrickm/chromium.src,axinging/chromium-crosswalk,PeterWangIntel/chromium-crosswalk,ChromiumWebApps/chromium,TheTypoMaster/chromium-crosswalk,anirudhSK/chromium,zcbenz/cefode-chromium,zcbenz/cefode-chromium,mogoweb/chromium-crosswalk,hgl888/chromium-crosswalk,axinging/chromium-crosswalk,jaruba/chromium.src,Chilledheart/chromium,robclark/chromium,fujunwei/chromium-crosswalk,ltilve/chromium,TheTypoMaster/chromium-crosswalk,crosswalk-project/chromium-crosswalk-efl,nacl-webkit/chrome_deps,nacl-webkit/chrome_deps,ltilve/chromium,crosswalk-project/chromium-crosswalk-efl,bright-sparks/chromium-spacewalk,PeterWangIntel/chromium-crosswalk,mohamed--abdel-maksoud/chromium.src,ChromiumWebApps/chromium,PeterWangIntel/chromium-crosswalk,junmin-zhu/chromium-rivertrail,patrickm/chromium.src,zcbenz/cefode-chromium,markYoungH/chromium.src,hujiajie/pa-chromium,hujiajie/pa-chromium,ondra-novak/chromium.src,keishi/chromium,rogerwang/chromium,pozdnyakov/chromium-crosswalk,dednal/chromium.src,mogoweb/chromium-crosswalk,pozdnyakov/chromium-crosswalk,chuan9/chromium-crosswalk,hgl888/chromium-crosswalk-efl,M4sse/chromium.src,hgl888/chromium-crosswalk,robclark/chromium,timopulkkinen/BubbleFish,pozdnyakov/chromium-crosswalk,markYoungH/chromium.src,keishi/chromium,bright-sparks/chromium-spacewalk,mogoweb/chromium-crosswalk,robclark/chromium,Fireblend/chromium-crosswalk,ChromiumWebApps/chromium,zcbenz/cefode-chromium,pozdnyakov/chromium-crosswalk,rogerwang/chromium,Jonekee/chromium.src,anirudhSK/chromium,Fireblend/chromium-crosswalk,dednal/chromium.src,junmin-zhu/chromium-rivertrail,mohamed--abdel-maksoud/chromium.src,junmin-zhu/chromium-rivertrail,junmin-zhu/chromium-rivertrail,axinging/chromium-crosswalk,PeterWangIntel/chromium-crosswalk,ltilve/chromium,krieger-od/nwjs_chromium.src,hujiajie/pa-chromium,PeterWangIntel/chromium-crosswalk,mohamed--abdel-maksoud/chromium.src,krieger-od/nwjs_chromium.src,patrickm/chromium.src,Just-D/chromium-1,zcbenz/cefode-chromium,fujunwei/chromium-crosswalk,TheTypoMaster/chromium-crosswalk,nacl-webkit/chrome_deps,pozdnyakov/chromium-crosswalk,ChromiumWebApps/chromium,jaruba/chromium.src,fujunwei/chromium-crosswalk,bright-sparks/chromium-spacewalk,mohamed--abdel-maksoud/chromium.src,rogerwang/chromium,dushu1203/chromium.src,bright-sparks/chromium-spacewalk,jaruba/chromium.src,chuan9/chromium-crosswalk,hgl888/chromium-crosswalk-efl,robclark/chromium,robclark/chromium