Mark x86's memory barrier inline assembly as clobbering the cpu flags.
Mark x86's memory barrier inline assembly as clobbering the cpu flags.

x86's memory barrier assembly was marked as clobbering "memory" but
not "cc" even though 'addl' sets various flags. As it turns out gcc on
x86 implicitly assumes "cc" on every inline assembler statement, so
it's not a bug. But as that's poorly documented and might get copied
to architectures or compilers where that's not the case, it seems
better to be precise.

Discussion: 20140919100016.GH4277@alap3.anarazel.de

To keep the code common, backpatch to 9.2 where explicit memory
barriers were introduced.

Postgres-XL/Postgres-XL,ashwinstar/gpdb,xinzweb/gpdb,jmcatamney/gpdb,lisakowen/gpdb,greenplum-db/gpdb,ovr/postgres-xl,ashwinstar/gpdb,greenplum-db/gpdb,ovr/postgres-xl,ashwinstar/gpdb,50wu/gpdb,xinzweb/gpdb,lisakowen/gpdb,ovr/postgres-xl,zeroae/postgres-xl,zeroae/postgres-xl,oberstet/postgres-xl,50wu/gpdb,lisakowen/gpdb,greenplum-db/gpdb,ovr/postgres-xl,ovr/postgres-xl,techdragon/Postgres-XL,techdragon/Postgres-XL,lisakowen/gpdb,jmcatamney/gpdb,adam8157/gpdb,yazun/postgres-xl,techdragon/Postgres-XL,xinzweb/gpdb,adam8157/gpdb,oberstet/postgres-xl,50wu/gpdb,adam8157/gpdb,50wu/gpdb,greenplum-db/gpdb,xinzweb/gpdb,greenplum-db/gpdb,greenplum-db/gpdb,Postgres-XL/Postgres-XL,ashwinstar/gpdb,xinzweb/gpdb,pavanvd/postgres-xl,jmcatamney/gpdb,lisakowen/gpdb,ashwinstar/gpdb,pavanvd/postgres-xl,yazun/postgres-xl,Postgres-XL/Postgres-XL,yazun/postgres-xl,pavanvd/postgres-xl,adam8157/gpdb,adam8157/gpdb,Postgres-XL/Postgres-XL,50wu/gpdb,adam8157/gpdb,greenplum-db/gpdb,50wu/gpdb,50wu/gpdb,xinzweb/gpdb,pavanvd/postgres-xl,ashwinstar/gpdb,jmcatamney/gpdb,oberstet/postgres-xl,jmcatamney/gpdb,adam8157/gpdb,ashwinstar/gpdb,yazun/postgres-xl,yazun/postgres-xl,oberstet/postgres-xl,oberstet/postgres-xl,lisakowen/gpdb,zeroae/postgres-xl,zeroae/postgres-xl,xinzweb/gpdb,lisakowen/gpdb,jmcatamney/gpdb,50wu/gpdb,jmcatamney/gpdb,techdragon/Postgres-XL,pavanvd/postgres-xl,adam8157/gpdb,ashwinstar/gpdb,lisakowen/gpdb,jmcatamney/gpdb,Postgres-XL/Postgres-XL,techdragon/Postgres-XL,zeroae/postgres-xl,xinzweb/gpdb,greenplum-db/gpdb