chip/stm32: Avoid out of bounds array access on TCPCI_MSG_TX_BIST_MODE_2
chip/stm32: Avoid out of bounds array access on TCPCI_MSG_TX_BIST_MODE_2

clang warns:

chip/stm32/ucpd-stm32gx.c:797:5: error: array index 582424 is past the
end of the array (which contains 7 elements) [-Werror,-Warray-bounds]
                                ucpd_txorderset[TX_ORDERSET_SOP];
                                ^               ~~~~~~~~~~~~~~~
chip/stm32/ucpd-stm32gx.c:127:1: note: array 'ucpd_txorderset' declared
here
static int ucpd_txorderset[] = {

The if clause handles SOP -> Cable Reset and the only type that does not
handle is TCPCI_MSG_TX_BIST_MODE_2. That case is a "don't care" for sync
packets as it's just a continuous 1/0 bit pattern.

BRANCH=none
BUG=b:172020503
TEST=make CC=arm-none-eabi-clang BOARD=baklava

Signed-off-by: Tom Hughes <fc5c12f30a5ed2baa0581f44ee14ad1eb7b20d83@chromium.org>
Change-Id: Ia2b73bcbf7eabe2de480633d4e65b8df55137e2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3198206
Reviewed-by: Daisuke Nojiri <fd5f93af191bf7e8f73ea71cc3c0f66b41b1dd49@chromium.org>
Reviewed-by: Scott Collyer <7d40b3eb9e17bf55d972074a5e77a7ea4159f9dd@chromium.org>

coreboot/chrome-ec,coreboot/chrome-ec,coreboot/chrome-ec,coreboot/chrome-ec,coreboot/chrome-ec,coreboot/chrome-ec