[Type checker] Use typeCheckCondition() rather than fake it.
[Type checker] Use typeCheckCondition() rather than fake it.

Type checking an expression pattern had a hack to work around some diagnostics
issues with conditions. These issues have been addressed by the new
diagnostic infrastructure, so remove this unnecessary use of
ExprTypeCheckListener and check the expression pattern condition using…
typeCheckCondition().
CodaFi/swift,harlanhaskins/swift,rudkx/swift,tkremenek/swift,jmgc/swift,parkera/swift,glessard/swift,ahoppen/swift,CodaFi/swift,airspeedswift/swift,allevato/swift,nathawes/swift,apple/swift,tkremenek/swift,rudkx/swift,JGiola/swift,stephentyrone/swift,CodaFi/swift,rudkx/swift,xwu/swift,hooman/swift,CodaFi/swift,benlangmuir/swift,atrick/swift,parkera/swift,hooman/swift,nathawes/swift,nathawes/swift,roambotics/swift,gregomni/swift,jmgc/swift,aschwaighofer/swift,ahoppen/swift,allevato/swift,roambotics/swift,harlanhaskins/swift,ahoppen/swift,tkremenek/swift,jckarter/swift,allevato/swift,rudkx/swift,allevato/swift,parkera/swift,apple/swift,aschwaighofer/swift,tkremenek/swift,CodaFi/swift,tkremenek/swift,xwu/swift,parkera/swift,nathawes/swift,jckarter/swift,rudkx/swift,jckarter/swift,stephentyrone/swift,atrick/swift,glessard/swift,harlanhaskins/swift,benlangmuir/swift,aschwaighofer/swift,harlanhaskins/swift,airspeedswift/swift,atrick/swift,ahoppen/swift,atrick/swift,harlanhaskins/swift,xwu/swift,CodaFi/swift,JGiola/swift,rudkx/swift,allevato/swift,airspeedswift/swift,roambotics/swift,jmgc/swift,glessard/swift,JGiola/swift,atrick/swift,xwu/swift,parkera/swift,apple/swift,glessard/swift,jckarter/swift,hooman/swift,jckarter/swift,nathawes/swift,xwu/swift,apple/swift,parkera/swift,tkremenek/swift,stephentyrone/swift,harlanhaskins/swift,JGiola/swift,stephentyrone/swift,airspeedswift/swift,CodaFi/swift,benlangmuir/swift,benlangmuir/swift,atrick/swift,benlangmuir/swift,gregomni/swift,aschwaighofer/swift,jmgc/swift,jmgc/swift,aschwaighofer/swift,parkera/swift,hooman/swift,hooman/swift,harlanhaskins/swift,jckarter/swift,benlangmuir/swift,JGiola/swift,ahoppen/swift,aschwaighofer/swift,ahoppen/swift,jckarter/swift,nathawes/swift,tkremenek/swift,roambotics/swift,stephentyrone/swift,apple/swift,jmgc/swift,stephentyrone/swift,jmgc/swift,hooman/swift,gregomni/swift,gregomni/swift,allevato/swift,roambotics/swift,glessard/swift,roambotics/swift,airspeedswift/swift,parkera/swift,hooman/swift,glessard/swift,gregomni/swift,airspeedswift/swift,xwu/swift,JGiola/swift,airspeedswift/swift,nathawes/swift,apple/swift,aschwaighofer/swift,stephentyrone/swift,gregomni/swift,allevato/swift,xwu/swift