Forget about targeting catalog cache invalidations by tuple TID.
Forget about targeting catalog cache invalidations by tuple TID.

The TID isn't stable enough: we might queue an sinval event before a VACUUM
FULL, and then process it afterwards, when the target tuple no longer has
the same TID.  So we must invalidate entries on the basis of hash value
only.  The old coding can be shown to result in various bizarre,
hard-to-reproduce errors in the presence of concurrent VACUUM FULLs on
system catalogs, and could easily result in permanent catalog corruption,
up to and including complete loss of tables.

This commit is just a minimal fix that removes the unsafe comparison.
We should remove transmission of the tuple TID from sinval messages
altogether, and then arrange to suppress the extra message in the common
case of a heap_update that doesn't change the key hashvalue.  But that's
going to be much more invasive, and will only produce a probably-marginal
performance gain, so it doesn't seem like material for a back-patch.

Back-patch to 9.0.  Before that, VACUUM FULL refused to do any tuple moving
if it found any INSERT_IN_PROGRESS or DELETE_IN_PROGRESS tuples (and
CLUSTER would give up altogether), so there was no risk of moving a tuple
that might be the subject of an unsent sinval message.

50wu/gpdb,jmcatamney/gpdb,yazun/postgres-xl,postmind-net/postgres-xl,50wu/gpdb,techdragon/Postgres-XL,ovr/postgres-xl,yazun/postgres-xl,kmjungersen/PostgresXL,xinzweb/gpdb,50wu/gpdb,adam8157/gpdb,kmjungersen/PostgresXL,arcivanov/postgres-xl,greenplum-db/gpdb,ashwinstar/gpdb,xinzweb/gpdb,jmcatamney/gpdb,lisakowen/gpdb,techdragon/Postgres-XL,techdragon/Postgres-XL,lisakowen/gpdb,adam8157/gpdb,lisakowen/gpdb,Postgres-XL/Postgres-XL,zeroae/postgres-xl,snaga/postgres-xl,pavanvd/postgres-xl,zeroae/postgres-xl,postmind-net/postgres-xl,lisakowen/gpdb,lisakowen/gpdb,tpostgres-projects/tPostgres,pavanvd/postgres-xl,ovr/postgres-xl,zeroae/postgres-xl,adam8157/gpdb,jmcatamney/gpdb,tpostgres-projects/tPostgres,techdragon/Postgres-XL,ashwinstar/gpdb,snaga/postgres-xl,xinzweb/gpdb,postmind-net/postgres-xl,ashwinstar/gpdb,ashwinstar/gpdb,greenplum-db/gpdb,jmcatamney/gpdb,ovr/postgres-xl,arcivanov/postgres-xl,adam8157/gpdb,xinzweb/gpdb,oberstet/postgres-xl,greenplum-db/gpdb,greenplum-db/gpdb,Postgres-XL/Postgres-XL,snaga/postgres-xl,lisakowen/gpdb,arcivanov/postgres-xl,Postgres-XL/Postgres-XL,xinzweb/gpdb,kmjungersen/PostgresXL,oberstet/postgres-xl,50wu/gpdb,50wu/gpdb,zeroae/postgres-xl,tpostgres-projects/tPostgres,adam8157/gpdb,adam8157/gpdb,kmjungersen/PostgresXL,zeroae/postgres-xl,techdragon/Postgres-XL,yazun/postgres-xl,xinzweb/gpdb,postmind-net/postgres-xl,greenplum-db/gpdb,arcivanov/postgres-xl,pavanvd/postgres-xl,50wu/gpdb,greenplum-db/gpdb,xinzweb/gpdb,greenplum-db/gpdb,jmcatamney/gpdb,oberstet/postgres-xl,Postgres-XL/Postgres-XL,arcivanov/postgres-xl,pavanvd/postgres-xl,arcivanov/postgres-xl,xinzweb/gpdb,Postgres-XL/Postgres-XL,ashwinstar/gpdb,ovr/postgres-xl,tpostgres-projects/tPostgres,jmcatamney/gpdb,yazun/postgres-xl,postmind-net/postgres-xl,pavanvd/postgres-xl,tpostgres-projects/tPostgres,lisakowen/gpdb,jmcatamney/gpdb,50wu/gpdb,greenplum-db/gpdb,snaga/postgres-xl,kmjungersen/PostgresXL,oberstet/postgres-xl,jmcatamney/gpdb,ashwinstar/gpdb,snaga/postgres-xl,adam8157/gpdb,adam8157/gpdb,50wu/gpdb,lisakowen/gpdb,ovr/postgres-xl,oberstet/postgres-xl,yazun/postgres-xl,ashwinstar/gpdb,ashwinstar/gpdb