merged branch hollodk/master (PR #335)
merged branch hollodk/master (PR #335)

Commits
-------

c0183b0 Only check if version is above required for running symfony2.
e16f52b Improved the locale check to a one-liner.
60b25f0 Found a problem with form framework using a deprecated timezone: US/Central.

Discussion
----------

bug with deprecated timezone in form framework

I found a problem with form framework when using a deprecated timezone.

I used deprecated timezone US/Central, and could not validate the date
fields. Got the error "invalid date", eventho i could not choose different in the select box of dates..

Havent tested all deprecated timezones, but think it gives sence to give
the user an error un deprecated usage of php.

---------------------------------------------------------------------------

by neilferreira at 2012-05-17T12:04:59Z

This permalink provides you with a slightly better solution, rather than having a large array of time stamps that are to be maintained outside of PHP itself:
http://stackoverflow.com/questions/5703359/validating-timezone-name-coming-in-from-different-site/5703565#5703565

---------------------------------------------------------------------------

by hollodk at 2012-05-17T15:24:42Z

neil it was some good points.. i have made it to a oneliner instead of:

(in_array(date_default_timezone_get(), \DateTimeZone::listIdentifiers())),

but i dont know if that is good enought, a requirement is php 5.2 or bigger.. i can do following:

1.
only make as a requirement if version is greater than 5.2 else ignore the check since this static variable is only available in versions above 5.2.

2.
if php version is smaller, make a manual list of allowed timezones... but you properly dont look at symfony if you use versions below.. so i dont know if that is important.

any thoughts, i think no #1 should be good enough..

---------------------------------------------------------------------------

by hollodk at 2012-05-17T15:34:15Z

hmm.. if you dont have the required version of php, you cannot run symfony2 anyway and have to fix this first..

When you have fixed the php version, you will get this error if you run a deprecated version.. So i think to skip the check if you dont have the required version is the best solution, the other fix would just create a long ugly array.. so please let me know if im wrong.

---------------------------------------------------------------------------

by stof at 2012-05-17T15:41:25Z

Making the requirement pass on PHP 5.2 (and so not using namespaces and closures) was needed to be able to ensure you really have 5.3+. However, making them pass on PHP 5.1 is totally useless (if someone still uses PHP 5.1, we don't care about him as even 5.2 is EOL now). So just use the DateTimeZone class for the requirement.

---------------------------------------------------------------------------

by hollodk at 2012-05-17T15:45:02Z

okay, i actually added the requirement check, because the check script would break if the variable does not exists.. :/ if that is okay, you can make the pull else i can remove the if statement?

formapro-forks/api-basic,glavweb/symfony-standard,kmelia/fresh-symfony,damedia/culture.ru,csarrazi/AppKernelGenerator,cordoval/symfony-bootstrap,shcloudservices/agiletourreg,GulDmitry/music-diff,Rvanlaak/symfony-standard,rommsen/plesynd,JMSBot/CSBill,joferzs/firewall,yelmontaser/symfony-standard,JMSBot/CSBill,b00giZm/symfony-boilerplate-app,lukaszgi/operowo,symfony-cmf/standard-edition,proteichik/testApp,kosintwong/symfony_test,vincentaubert/symfony-standard,oustaban/eurotax,tomat/symfony-standard,flevour/symfony-issue-3889,den2134/itdTest,sulu-io/sulu-standard,beyondkeysystem/psc-symfony-angularjs,2085020/first-symfony-project,MatthieuCutin/ligue-squash,peterkokot/symfony-standard,dkarvounaris/symfony-standard,gnugat/symfony-empty,joferzs/firewall,webignition/app.simplytestable.com,the-software-factory/superhero-api,simonjcarr/symfony_rest,GulDmitry/music-diff,bshaffer/symfony-standard,1ed/symfony-standard,symfony-cmf/standard-edition,papaavola/symfony-standard,VolCh/test-rethis.ru,Baachi/symfony-standard,egeloen/symfony-standard,lukaszgi/operowo,shcloudservices/agiletourreg,vincentchalamon/phpunit-bridge,chebetos/SymfonyTest,wachterjohannes/sulu-standard,ucay/Skeleton,damedia/culture.ru,jakzal/symfony-standard,lukaszgi/operowo,tdd-php/football,mukulu/hris,Musak/firstsymfony2project,simonjcarr/symfony_rest,meonkeys/symfony2-dual-auth,fabpot/symfony-standard,gencer/symfony-standard,phiamo/symfony-bootstrap,phiamo/symfony-bootstrap,amalv/cupon,cordoval/symfony-bootstrap,jmather/symfony-sonata-distribution,unewochialat/symfony-standard,adrienbrault/symfony-silex-edition,Spea/symfony-standard,fcerezo/famaluz,jbdelhommeau/symfony-standard,Tobion/symfony-standard,alihalabyah/symfony-rest-edition,cordoval/symfony-gae,rainbowcode/spanvoice-standard,phiamo/symfony-bootstrap,ctrl-f5/symfony-standard,cordoval/spike-edition,the-software-factory/superhero-api,cordoval/symfony-gae,yohang/non-obstrusive-form-sf2,tiagobrito/ds1.sfdaypt14,orodsem/trout,markitosgv/DevOps,uttam-vi/pardawala,dunglas/symfony-standard,b00giZm/symfony-boilerplate-app,gimler/symfony-rest-edition,mattvaadi/hris,javiereguiluz/symfony-standard,zanderbaldwin/symfony-layers,mweimerskirch/symfony-standard,bshaffer/symfony-standard,dziamid/lunch-time-composer,makasim/LiipImagineBundleSandbox,GulDmitry/music-diff,SymfonyId/Skeleton,pjcdawkins/tmp-symfony-demo,tristanbes/symfony-standard,jbdelhommeau/symfony-standard,Cartesia/01,mukulu/hris,shadowtje1990/symfony_todo_api,cordoval/symfony-gae,twisted-socket/stage-plots,jmather/pagoda-symfony-sonata-distribution,hrisproject/hris,webignition/worker.simplytestable.com,Clastic/StandardEdition,chebetos/SymfonyTest,jakzal/symfony-standard,symfony2-od-podstaw/26-01-sf21,by-examples/symfony-standard,fahadonline/sulu,FLM/uberstrap,basdek/SymfonyFireWall,irro/MastoAlliance,javiereguiluz/symfony-standard,kmelia/fresh-symfony,gimler/symfony-rest-edition,theodo/theodo-kata,alihalabyah/symfony-rest-edition,tdd-php/football,mykehsd/jobeet,debruyne0/symfony,papaavola/symfony-standard,continuousphp/symfony-skeleton,Musak/firstsymfony2project,HumanBooster/Symfony,ewgRa/symfony-standard,sandello-alkr/symfony,mqmtech/show-app,jmather/pagoda-symfony-sonata-distribution,OskarStark/symfony-standard,platformsh/platformsh-example-symfony,ovelasquez/ussi,delorenj/elleol_legacy,skafandri/blog,VolCh/test-rethis.ru,webignition/simplytestable.com,joferzs/firewall,myroshnychenko/SymfonyCMF,umpirsky/symfony-standard,yelmontaser/symfony-standard,taylankasap/symfony-standard,buddhikajay/symfony-sonata-distribution,hrisproject/hris,VolCh/test-rethis.ru,chebetos/SymfonyTest,tdd-php/angaze,HasClass0/standard-edition,webmozart/symfony-standard,Tobion/symfony-standard,aerrasti/iemedebe,shamcode/symfony-testing,phiamo/symfony-bootstrap,tederkkila/snapshot_server,theodo/theodo-kata,tarasinio/weather-remainder.com,basdek/SymfonyFireWall,OskarStark/symfony-standard,ybutb/videotask,buddhika-jay/symfony-sonata-distribution,pjcdawkins/tmp-symfony-demo,black-project/black-standard,continuousphp/symfony-skeleton,aerrasti/iemedebe,dziamid/lunch-time-composer,mukulu/hris,stof/symfony-standard,Cartesia/01,IgorTimoshenko/symfony-standard-requirejs,Soullivaneuh/symfony-standard,xiaobudongzhang/symfony-standard,rommsen/plesynd,Chill-project/Standard,NoUseFreak/StandardEdition,JMSBot/CSBill,WouterJ/symfony-standard,debruyne0/symfony,ucay/Skeleton,MatthieuCutin/ligue-squash,liip-forks/symfony-standard,npotier/sf2Showcase,hrisproject/hris,Clastic/StandardEdition,bamarni/symfony-docker,dziamid/lunch-time-composer,bocharsky-bw/symfony-standard,GulDmitry/music-diff,chebetos/SymfonyTest,kmelia/fresh-symfony,fahadonline/sulu,fduch/symfony-standard-workflow,Metabor/Start-App,SymfonyId/Skeleton,fcerezo/famaluz,SymfonyId/api-platform,tederkkila/snapshot_server,gnugat-legacy/symfony-empty,marcoleong/musictube,havvg/symfony-propel-edition,stof/symfony-standard,UxorialRook/symfony-standard,rajkamalganeshvivid/symfony-standard,fduch/symfony-standard-workflow,webignition/worker.simplytestable.com,baukaman/NeedYou,continuousphp/symfony-skeleton,mattvaadi/hris,yohang/non-obstrusive-form-sf2,fahadonline/sulu,WolfMicrosystems/symfony-wms,lyrixx/symfony-standard,oustaban/eurotax,lyrixx/symfony-standard,Cartesia/01,flyboarder/AirOS,xiaobudongzhang/symfony-standard,checat/symfony-minimal,cordoval/demo-symfony2-argentina,ovelasquez/ussi,umpirsky/symfony-standard,symfony/symfony-standard,NoUseFreak/StandardEdition,lanthaler/sfHydraDemoApp,elcodi/symfonycon-demo,Spea/symfony-standard,tdd-php/literatura,webignition/simplytestable.com,AlexeyKupershtokh/symfony-standard,Ocramius/symfony-standard,damienalexandre/symfony-standard,mattvaadi/hris,shamcode/symfony-testing,damedia/culture.ru,phiamo/symfony-bootstrap,symfony/symfony-standard,hrisproject/hris,shadowtje1990/symfony_todo_api,uttam-vi/pardawala,marcoleong/musictube,meonkeys/symfony2-dual-auth,ybutb/videotask,InkApplications/barenaked-symfony,b00giZm/symfony-boilerplate-app,mukulu/hris,drufony/drufony,tarasinio/weather-remainder.com,martinmike2/website-study,aprezcuba24/symfony-standard,dkarvounaris/symfony-standard,ewgRa/symfony-standard,apnet/symfony-standard-edition,WouterJ/symfony-standard,0mars/symfony-standard-issue-13291,oustaban/eurotax,underq/symfony-rest-edition-experiment,tiagobrito/ds1.sfdaypt14,egeloen/symfony-standard,chregu/symfony-standard,ucay/Skeleton,tPl0ch/symfony-phpqatools,webignition/worker.simplytestable.com,Koc/symfony-standard,amalv/cupon,mqmtech/show-app,UxorialRook/symfony-standard,RuntyCybin/symfony-standard,orodsem/trout,gencer/symfony-standard,WolfMicrosystems/symfony-wms,webignition/worker.simplytestable.com,fahadonline/sulu,webignition/app.simplytestable.com,phospr/symfony-starter,wachterjohannes/sulu-standard,hrisproject/hris,platformsh/platformsh-example-symfony,tristanbes/symfony-standard,JMSBot/CSBill,propelorm/symfony-propel-edition,cordoval/symfony-bootstrap,achrafYne/restaurants-guide,isidromerayo/symfony2-jobeet,den2134/itdTest,NoUseFreak/StandardEdition,taylankasap/symfony-standard,propelorm/symfony-propel-edition,damedia/culture.ru,dantleech/symfony-doctrine-phpcr-edition,IgorTimoshenko/symfony-standard-requirejs,mykehsd/jobeet,flevour/symfony-issue-3889,JMSBot/CSBill,ucsf-ckm/symfony-emberjs-edition,tarasinio/weather-remainder.com,phiamo/symfony-bootstrap,kucherevskyA/kucherevskiy-test-task,isidromerayo/symfony2-jobeet,mweimerskirch/symfony-standard,vincentchalamon/phpunit-bridge,Soullivaneuh/symfony-standard,locastic/psc-symfony-angularjs,ovelasquez/ussi,twisted-socket/stage-plots,Thiktak/Jordo,unewochialat/symfony-standard,lsmith77/symfony-standard,mattvaadi/hris,trsteel88/symfony-standard,wachterjohannes/sulu-standard,shcloudservices/agiletourreg,delorenj/elleol_legacy,webignition/simplytestable.com,buddhikajay/symfony-sonata-distribution,damedia/culture.ru,mayeco/symfony-standard-pagodabox,apnet/symfony-standard-edition,havvg/symfony-propel-edition,lmaslowski/sf2,Chill-project/Standard,mhlavac/symfony-skeleton,tdd-php/literatura,dunglas/symfony-standard,outlandishideas/symfony-standard,symfony2-od-podstaw/knp-menu-example,AlexeyKupershtokh/symfony-standard,singingstars/flydb,sulu-io/sulu-standard,flyboarder/AirOS,sulu-io/sulu-standard,irro/MastoAlliance,tdd-php/angaze,mkrauser/symfony-dump-demo,yohang/non-obstrusive-form-sf2,yhoiseth/notelite.net,spolischook/standard-edition,havvg/symfony-standard-propel,vincentaubert/symfony-standard,xabbuh/symfony-standard,mnapoli/symfony-standard,oustaban/eurotax,lyrixx/symfony-rest-edition,havvg/symfony-standard-propel,pocit/ExpoApiBundle,phospr/symfony-starter,zanderbaldwin/symfony-layers,HasClass0/standard-edition,bamarni/symfony-docker,glavweb/symfony-standard,tdd-php/angaze,liip-forks/symfony-standard,proteichik/testApp,orodsem/trout,Thiktak/Jordo,mikekamornikov/remmart.ru,Thiktak/Jordo,ucsf-ckm/symfony-emberjs-edition,buddhika-jay/symfony-sonata-distribution,black-project/black-standard,Baachi/symfony-standard,rajkamalganeshvivid/symfony-standard,cordoval/symfony-bootstrap,RuntyCybin/symfony-standard,webignition/worker.simplytestable.com,apnet/symfony-standard-edition,continuousphp/symfony-skeleton,spolischook/standard-edition,bionic-university/alexander-pobereznichenko,baukaman/NeedYou,skafandri/blog,fabpot/symfony-standard,beyondkeysystem/psc-symfony-angularjs,Knouki/Jobeet-Symfony,uttam-vi/pardawala,tdd-php/angaze,yhoiseth/notelite.net,bocharsky-bw/symfony-standard,tarasinio/weather-remainder.com,fcerezo/famaluz,ctrl-f5/symfony-standard,trsteel88/symfony-standard,we-bridge/symfony-admin,chrisciampoli/cleats,formapro-forks/api-basic,Clastic/StandardEdition