Bugfix: don’t remove SubstructureRedirect event mask temporarily
Bugfix: don’t remove SubstructureRedirect event mask temporarily

This fixes race conditions, for example when i3bar gets reconfigured
after the available outputs change. In that specific case, i3bar sends a
ConfigureWindow request (see
https://github.com/i3/i3/blob/b5693d6fb33ad29337e4187a2db4a2618ea8fb4c/i3bar/src/xcb.c#L376)
which normally is turned into a ConfigureRequest that i3 largely
ignores, only the dock client’s height is considered (see
https://github.com/i3/i3/blob/b5693d6fb33ad29337e4187a2db4a2618ea8fb4c/src/handlers.c#L390).

Turning ConfigureWindow into ConfigureRequest is only done when the
SubstructureRedirect event mask is set, and because we temporarily
removed _all_ events from our mask, the ConfigureWindow request went
through unmodified.

This in turn lead to the i3bar client window (not its decoration frame)
being positioned at e.g. y=1304, whereas dock client windows should
always end up at x=0 y=0 within their decoration frame. The result of
the i3bar client window being out of the visible space was either a
black i3bar or graphics corruption.

This also fixes issue #1904, I think. I couldn’t reproduce issue #1904
specifically, but when i3bar is in the misconfigured state, it will
receive a VisibilityNotify event, telling i3bar that it is obscured.
This would explain why i3bar sent a SIGSTOP in issue #1904.

fixes #1904

stapelberg/i3,MForster/i3,shdown/i3,cornerman/i3,avrelaun/i3,strake/i3,i3/i3,stapelberg/i3,MForster/i3,Airblader/i3,Matmusia/i3,Airblader/i3,Airblader/i3,cornerman/i3,acrisci/i3,Matmusia/i3,acrisci/i3,MForster/i3,cornerman/i3,acrisci/i3,strake/i3,Airblader/i3-original,avrelaun/i3,avrelaun/i3,shdown/i3,Chr1stoph/i3,EvilPudding/i3,Airblader/i3,Airblader/i3-original,Airblader/i3-original,EvilPudding/i3,Airblader/i3-original,stapelberg/i3,strake/i3,strake/i3,stapelberg/i3,Matmusia/i3,EvilPudding/i3,i3/i3,i3/i3,acrisci/i3,EvilPudding/i3,Chr1stoph/i3,avrelaun/i3,MForster/i3,cornerman/i3,Airblader/i3-original,acrisci/i3,Matmusia/i3,strake/i3,Chr1stoph/i3,shdown/i3,i3/i3,Chr1stoph/i3,shdown/i3