[SILOpt] Use getEffectiveAccess instead of getFormalAccess.
[SILOpt] Use getEffectiveAccess instead of getFormalAccess.

Since this code has an isAvailableExternally check, this probably makes
no difference, but it's still more correct: SIL-level code should
always use a declaration's effective access.

aschwaighofer/swift,tardieu/swift,austinzheng/swift,huonw/swift,IngmarStein/swift,parkera/swift,deyton/swift,tinysun212/swift-windows,rudkx/swift,jckarter/swift,shahmishal/swift,jopamer/swift,sschiau/swift,djwbrown/swift,tinysun212/swift-windows,sschiau/swift,milseman/swift,zisko/swift,JGiola/swift,allevato/swift,austinzheng/swift,shahmishal/swift,gribozavr/swift,calebd/swift,karwa/swift,practicalswift/swift,huonw/swift,gregomni/swift,JaSpa/swift,hooman/swift,tinysun212/swift-windows,natecook1000/swift,jmgc/swift,jmgc/swift,arvedviehweger/swift,hughbe/swift,return/swift,Jnosh/swift,huonw/swift,tardieu/swift,apple/swift,aschwaighofer/swift,gmilos/swift,IngmarStein/swift,aschwaighofer/swift,JGiola/swift,brentdax/swift,tkremenek/swift,bitjammer/swift,amraboelela/swift,lorentey/swift,hughbe/swift,tjw/swift,therealbnut/swift,alblue/swift,gregomni/swift,huonw/swift,gregomni/swift,danielmartin/swift,rudkx/swift,kstaring/swift,djwbrown/swift,alblue/swift,hughbe/swift,djwbrown/swift,bitjammer/swift,lorentey/swift,gottesmm/swift,tardieu/swift,kstaring/swift,manavgabhawala/swift,ahoppen/swift,gregomni/swift,modocache/swift,amraboelela/swift,therealbnut/swift,jckarter/swift,parkera/swift,jckarter/swift,tkremenek/swift,ben-ng/swift,tardieu/swift,tjw/swift,gregomni/swift,rudkx/swift,frootloops/swift,tardieu/swift,codestergit/swift,devincoughlin/swift,shahmishal/swift,ahoppen/swift,zisko/swift,felix91gr/swift,zisko/swift,jckarter/swift,lorentey/swift,jtbandes/swift,codestergit/swift,devincoughlin/swift,djwbrown/swift,aschwaighofer/swift,calebd/swift,kstaring/swift,xwu/swift,apple/swift,danielmartin/swift,natecook1000/swift,jopamer/swift,calebd/swift,therealbnut/swift,uasys/swift,manavgabhawala/swift,glessard/swift,gregomni/swift,djwbrown/swift,harlanhaskins/swift,kstaring/swift,felix91gr/swift,nathawes/swift,gmilos/swift,kstaring/swift,codestergit/swift,xedin/swift,xwu/swift,xedin/swift,ben-ng/swift,austinzheng/swift,bitjammer/swift,hooman/swift,swiftix/swift,roambotics/swift,therealbnut/swift,deyton/swift,airspeedswift/swift,calebd/swift,sschiau/swift,zisko/swift,hughbe/swift,tinysun212/swift-windows,OscarSwanros/swift,manavgabhawala/swift,tjw/swift,kperryua/swift,nathawes/swift,gribozavr/swift,felix91gr/swift,calebd/swift,jopamer/swift,benlangmuir/swift,sschiau/swift,tjw/swift,uasys/swift,danielmartin/swift,lorentey/swift,xedin/swift,xwu/swift,tkremenek/swift,apple/swift,benlangmuir/swift,airspeedswift/swift,IngmarStein/swift,gribozavr/swift,karwa/swift,deyton/swift,shajrawi/swift,JaSpa/swift,atrick/swift,parkera/swift,practicalswift/swift,bitjammer/swift,devincoughlin/swift,rudkx/swift,kstaring/swift,gribozavr/swift,shajrawi/swift,rudkx/swift,xwu/swift,lorentey/swift,arvedviehweger/swift,felix91gr/swift,jmgc/swift,Jnosh/swift,zisko/swift,airspeedswift/swift,manavgabhawala/swift,stephentyrone/swift,glessard/swift,kstaring/swift,roambotics/swift,nathawes/swift,lorentey/swift,arvedviehweger/swift,practicalswift/swift,xedin/swift,atrick/swift,glessard/swift,shahmishal/swift,devincoughlin/swift,nathawes/swift,xwu/swift,aschwaighofer/swift,shajrawi/swift,bitjammer/swift,milseman/swift,ben-ng/swift,ahoppen/swift,jckarter/swift,Jnosh/swift,roambotics/swift,alblue/swift,sschiau/swift,jopamer/swift,codestergit/swift,amraboelela/swift,glessard/swift,glessard/swift,frootloops/swift,gmilos/swift,jopamer/swift,tjw/swift,devincoughlin/swift,jopamer/swift,apple/swift,xedin/swift,shahmishal/swift,return/swift,gottesmm/swift,harlanhaskins/swift,kperryua/swift,jtbandes/swift,uasys/swift,tjw/swift,hooman/swift,roambotics/swift,IngmarStein/swift,roambotics/swift,manavgabhawala/swift,IngmarStein/swift,djwbrown/swift,modocache/swift,gmilos/swift,kperryua/swift,kperryua/swift,sschiau/swift,benlangmuir/swift,practicalswift/swift,practicalswift/swift,nathawes/swift,stephentyrone/swift,gottesmm/swift,parkera/swift,gottesmm/swift,modocache/swift,JaSpa/swift,zisko/swift,brentdax/swift,practicalswift/swift,jckarter/swift,natecook1000/swift,alblue/swift,manavgabhawala/swift,milseman/swift,therealbnut/swift,gmilos/swift,allevato/swift,airspeedswift/swift,devincoughlin/swift,stephentyrone/swift,alblue/swift,CodaFi/swift,swiftix/swift,airspeedswift/swift,CodaFi/swift,danielmartin/swift,xwu/swift,gribozavr/swift,aschwaighofer/swift,jtbandes/swift,modocache/swift,benlangmuir/swift,OscarSwanros/swift,karwa/swift,gribozavr/swift,felix91gr/swift,harlanhaskins/swift,uasys/swift,deyton/swift,allevato/swift,huonw/swift,gmilos/swift,calebd/swift,frootloops/swift,airspeedswift/swift,tardieu/swift,OscarSwanros/swift,JaSpa/swift,lorentey/swift,bitjammer/swift,natecook1000/swift,parkera/swift,kperryua/swift,JGiola/swift,ahoppen/swift,apple/swift,natecook1000/swift,tkremenek/swift,arvedviehweger/swift,austinzheng/swift,tkremenek/swift,allevato/swift,karwa/swift,IngmarStein/swift,JGiola/swift,roambotics/swift,codestergit/swift,allevato/swift,atrick/swift,airspeedswift/swift,djwbrown/swift,allevato/swift,kperryua/swift,Jnosh/swift,JGiola/swift,austinzheng/swift,arvedviehweger/swift,OscarSwanros/swift,huonw/swift,return/swift,frootloops/swift,felix91gr/swift,IngmarStein/swift,harlanhaskins/swift,parkera/swift,stephentyrone/swift,brentdax/swift,stephentyrone/swift,swiftix/swift,jckarter/swift,CodaFi/swift,gottesmm/swift,zisko/swift,natecook1000/swift,allevato/swift,natecook1000/swift,tjw/swift,arvedviehweger/swift,ben-ng/swift,milseman/swift,therealbnut/swift,bitjammer/swift,practicalswift/swift,CodaFi/swift,tinysun212/swift-windows,CodaFi/swift,jtbandes/swift,hughbe/swift,brentdax/swift,uasys/swift,amraboelela/swift,CodaFi/swift,xedin/swift,danielmartin/swift,shajrawi/swift,practicalswift/swift,benlangmuir/swift,ben-ng/swift,shajrawi/swift,aschwaighofer/swift,milseman/swift,sschiau/swift,return/swift,ahoppen/swift,deyton/swift,return/swift,hooman/swift,hooman/swift,JaSpa/swift,harlanhaskins/swift,hooman/swift,deyton/swift,tardieu/swift,shajrawi/swift,xedin/swift,hooman/swift,danielmartin/swift,Jnosh/swift,swiftix/swift,jtbandes/swift,uasys/swift,parkera/swift,glessard/swift,devincoughlin/swift,stephentyrone/swift,deyton/swift,swiftix/swift,ben-ng/swift,modocache/swift,Jnosh/swift,CodaFi/swift,hughbe/swift,jmgc/swift,parkera/swift,brentdax/swift,stephentyrone/swift,codestergit/swift,frootloops/swift,sschiau/swift,shajrawi/swift,calebd/swift,manavgabhawala/swift,apple/swift,xedin/swift,atrick/swift,return/swift,shajrawi/swift,nathawes/swift,codestergit/swift,amraboelela/swift,modocache/swift,amraboelela/swift,danielmartin/swift,ahoppen/swift,gribozavr/swift,gottesmm/swift,frootloops/swift,alblue/swift,Jnosh/swift,jtbandes/swift,austinzheng/swift,gmilos/swift,atrick/swift,JaSpa/swift,jmgc/swift,shahmishal/swift,jmgc/swift,tinysun212/swift-windows,tkremenek/swift,modocache/swift,brentdax/swift,JGiola/swift,devincoughlin/swift,rudkx/swift,lorentey/swift,atrick/swift,gribozavr/swift,uasys/swift,harlanhaskins/swift,alblue/swift,gottesmm/swift,benlangmuir/swift,brentdax/swift,austinzheng/swift,karwa/swift,OscarSwanros/swift,xwu/swift,milseman/swift,kperryua/swift,karwa/swift,milseman/swift,OscarSwanros/swift,swiftix/swift,hughbe/swift,amraboelela/swift,ben-ng/swift,arvedviehweger/swift,tinysun212/swift-windows,tkremenek/swift,swiftix/swift,karwa/swift,return/swift,jtbandes/swift,OscarSwanros/swift,therealbnut/swift,huonw/swift,frootloops/swift,karwa/swift,nathawes/swift,JaSpa/swift,felix91gr/swift,shahmishal/swift,jmgc/swift,jopamer/swift,shahmishal/swift,harlanhaskins/swift