always trigger the new_teacher notifications for plugins
always trigger the new_teacher notifications for plugins

Previously we were only sending it if registration approval was required. Now
we send it no matter what.

Change-Id: I64aed1b7132555ffa73fd94194a1c4afe9dd63c9
Reviewed-on: https://gerrit.instructure.com/2103
Reviewed-by: Brian Palmer <3cb4e1df5ec4da2c7c4af7c52cec8cf340a55a10@instructure.com>
Reviewed-by: Brian Whitmer <760e7dab2836853c63805033e514668301fa9c47@instructure.com>
Tested-by: Hudson <dfb64870173313a9a7b56f814c8e3b33e268497a@instructure.com>

sli7246/canvas_branch,tgroshon/canvas-lms,kyroskoh/canvas-lms,utkarshx/canvas-lms,matematikk-mooc/canvas-lms,va7map/canvas-lms,samuels410/greatlakes-lms,arrivu/hiring-site,juoni/canvas-lms,SwinburneOnline/canvas-lms,greyhwndz/canvas-lms,jay3126/canvas-lms,skmezanul/canvas-lms,merichar/canvas-lms,efrj/canvas-lms,rup/Tarrax,wimemx/Canvas,sfu/canvas-lms,matematikk-mooc/canvas-lms,wye0220/shindig-canvas,efrj/canvas-lms,AndranikMarkosyan/lms,roxolan/canvas-lms,rup/Tarrax,Unow/canvas-lms,ottenhoff/canvas-lms,nditech/red-innovadores-lms,instructure/canvas-lms,wrdsb/canvas-lms,eCNAP/CANVAS,venturehive/canvas-lms,Unow/ins,nditech/red-innovadores-lms,sfu/canvas-lms,fronteerio/canvas-lms,snehakachroo1/LSI_replica,ankithbti/canvas_lms,kyroskoh/canvas-lms,fronteerio/canvas-lms,djbender/canvas-lms,arrivu/hiring-site,efrj/canvas-lms,Jyaasa/canvas-lms,ShreniiNepal/shrenii_lmp,SwinburneOnline/canvas-lms,em2/canvas-lms,antoniuslin/canvas-lms,ankithbti/canvas_lms,instructure/canvas-lms,arrivu/arrivu-lms,arrivu/jigsaw-lms,landonwilkins/canvas-lms,dgynn/canvas-lms,leftplusrightllc/canvas-lms,HotChalk/canvas-lms,sdeleon28/canvas-lms,leftplusrightllc/canvas-lms,instructure/canvas-lms,shidao-fm/canvas-lms,ankithbti/canvas_lms,Unow/ins,icelab/canvas,HotChalk/canvas-lms,arrivu/hoodemo,arrivu/hoodemo,sdeleon28/canvas-lms,leftplusrightllc/canvas-lms,instructure/canvas-lms,grahamb/canvas-lms,landonwilkins/canvas-lms,skmezanul/canvas-lms,arrivu/qibla-ecampus,arrivu/qibla-ecampus,roxolan/canvas-lms,loganrun/pincan,whalejasmine/canvas-lms,venturehive/canvas-lms,wimemx/Canvas,kyroskoh/canvas-lms,snehakachroo1/LSI_replica,venturehive/canvas-lms,grahamb/canvas-lms,AndranikMarkosyan/lms,fronteerio/canvas-lms,HotChalk/canvas-lms,sfu/canvas-lms,jay3126/canvas-lms,usmschuck/canvas,instructure/canvas-lms,wrdsb/canvas-lms,AndranikMarkosyan/lms,merichar/canvas-lms,arrivu/jigsaw-lms,tgroshon/canvas-lms,skmezanul/canvas-lms,sfu/canvas-lms,eCNAP/CANVAS,em2/canvas-lms,nditech/red-innovadores-lms,antoniuslin/canvas-lms,matematikk-mooc/canvas-lms,sli7246/canvas_branch,sfu/canvas-lms,snehakachroo1/LSI_replica,va7map/canvas-lms,redconfetti/canvas-lms,gbleydon/canvas-lms,usmschuck/canvas,arrivu/jigsaw-lms,samuels410/greatlakes-lms,djbender/canvas-lms,narigone/canvas,skmezanul/canvas-lms,HotChalk/canvas-lms,va7map/canvas-lms,loganrun/pincan,djbender/canvas-lms,redconfetti/canvas-lms,greyhwndz/canvas-lms,SwinburneOnline/canvas-lms,samuels410/greatlakes-lms,greyhwndz/canvas-lms,djbender/canvas-lms,faraazkhan/canvas,juoni/canvas-lms,sdeleon28/canvas-lms,Rvor/canvas-lms,arrivu/hiring-site,whalejasmine/canvas-lms,wye0220/shindig-canvas,jay3126/canvas-lms,matematikk-mooc/canvas-lms,em2/canvas-lms,faraazkhan/canvas,leftplusrightllc/canvas-lms,icelab/canvas,Unow/canvas-lms,roxolan/canvas-lms,Rvor/canvas-lms,utkarshx/canvas-lms,wimemx/Canvas,tgroshon/canvas-lms,fronteerio/canvas-lms,AndranikMarkosyan/lms,parbros/red-innovadores-lms,usmschuck/canvas,ShreniiNepal/shrenii_lmp,Jyaasa/canvas-lms,narigone/canvas,ShreniiNepal/shrenii_lmp,loganrun/pincan,antoniuslin/canvas-lms,redconfetti/canvas-lms,dgynn/canvas-lms,arrivu/qibla-ecampus,juoni/canvas-lms,landonwilkins/canvas-lms,juoni/canvas-lms,sdeleon28/canvas-lms,ottenhoff/canvas-lms,shidao-fm/canvas-lms,Jyaasa/canvas-lms,grahamb/canvas-lms,kyroskoh/canvas-lms,ShreniiNepal/shrenii_lmp,jay3126/canvas-lms,gbleydon/canvas-lms,greyhwndz/canvas-lms,eCNAP/CANVAS,narigone/canvas,Unow/canvas-lms,sfu/canvas-lms,grahamb/canvas-lms,venturehive/canvas-lms,wye0220/shindig-canvas,efrj/canvas-lms,utkarshx/canvas-lms,arrivu/arrivu-lms,parbros/red-innovadores-lms,Rvor/canvas-lms,rup/Tarrax,ottenhoff/canvas-lms,gbleydon/canvas-lms,faraazkhan/canvas,instructure/canvas-lms,narigone/canvas,redconfetti/canvas-lms,instructure/canvas-lms,Jyaasa/canvas-lms,merichar/canvas-lms,antoniuslin/canvas-lms,dgynn/canvas-lms,wrdsb/canvas-lms,shidao-fm/canvas-lms,tgroshon/canvas-lms,samuels410/greatlakes-lms,shidao-fm/canvas-lms,dgynn/canvas-lms,parbros/red-innovadores-lms,arrivu/arrivu-lms,Unow/ins,utkarshx/canvas-lms,landonwilkins/canvas-lms,icelab/canvas,SwinburneOnline/canvas-lms,whalejasmine/canvas-lms,grahamb/canvas-lms,sli7246/canvas_branch,arrivu/hoodemo,usmschuck/canvas,sfu/canvas-lms,whalejasmine/canvas-lms,roxolan/canvas-lms,wrdsb/canvas-lms,snehakachroo1/LSI_replica,nditech/red-innovadores-lms,eCNAP/CANVAS,va7map/canvas-lms,Rvor/canvas-lms