Use `def before_setup` instead of `setup do`
Use `def before_setup` instead of `setup do`

`setup do` creates unnecessary allocations of proc objects in test
callbacks. This prevents that from happening and results in faster code.

Originally I had done this as `def setup` and all Railties tests passed.
See 044f9ab. Later it was reported there was an issue with this that
caused routes in tests to be nil because devs don't generally call
`super` in their test setups. Because of that I reverted the commit
until I could find a suitble replacement.

`before_setup` esentially does the same thing but without the
requirement that applications call `super` in their test setups.

Edouard-chin/rails,riseshia/railsguides.kr,yawboakye/rails,Spin42/rails,arunagw/rails,BlakeWilliams/rails,yhirano55/rails,kamipo/rails,aditya-kapoor/rails,notapatch/rails,repinel/rails,untidy-hair/rails,assain/rails,sealocal/rails,illacceptanything/illacceptanything,bolek/rails,rbhitchcock/rails,elfassy/rails,stefanmb/rails,bradleypriest/rails,flanger001/rails,betesh/rails,gcourtemanche/rails,bogdanvlviv/rails,bradleypriest/rails,richseviora/rails,Edouard-chin/rails,illacceptanything/illacceptanything,Spin42/rails,samphilipd/rails,illacceptanything/illacceptanything,tgxworld/rails,Stellenticket/rails,mathieujobin/reduced-rails-for-travis,Erol/rails,mtsmfm/rails,odedniv/rails,kddeisz/rails,yalab/rails,rossta/rails,xlymian/rails,mtsmfm/railstest,yalab/rails,ttanimichi/rails,bogdanvlviv/rails,maicher/rails,illacceptanything/illacceptanything,aditya-kapoor/rails,tjschuck/rails,Stellenticket/rails,bogdanvlviv/rails,illacceptanything/illacceptanything,utilum/rails,stefanmb/rails,schuetzm/rails,riseshia/railsguides.kr,sergey-alekseev/rails,assain/rails,mijoharas/rails,untidy-hair/rails,schuetzm/rails,tijwelch/rails,starknx/rails,samphilipd/rails,kmcphillips/rails,gfvcastro/rails,rails/rails,illacceptanything/illacceptanything,deraru/rails,betesh/rails,marklocklear/rails,pvalena/rails,coreyward/rails,odedniv/rails,Erol/rails,flanger001/rails,ngpestelos/rails,esparta/rails,palkan/rails,koic/rails,hanystudy/rails,eileencodes/rails,rbhitchcock/rails,assain/rails,ledestin/rails,flanger001/rails,yasslab/railsguides.jp,yalab/rails,gfvcastro/rails,bolek/rails,repinel/rails,arjes/rails,georgeclaghorn/rails,shioyama/rails,yahonda/rails,utilum/rails,joonyou/rails,rafaelfranca/omg-rails,yawboakye/rails,mathieujobin/reduced-rails-for-travis,Vasfed/rails,untidy-hair/rails,voray/rails,Sen-Zhang/rails,koic/rails,jeremy/rails,illacceptanything/illacceptanything,samphilipd/rails,ttanimichi/rails,georgeclaghorn/rails,kachick/rails,jeremy/rails,kirs/rails-1,kmayer/rails,palkan/rails,deraru/rails,lcreid/rails,fabianoleittes/rails,felipecvo/rails,richseviora/rails,prathamesh-sonpatki/rails,illacceptanything/illacceptanything,gavingmiller/rails,ngpestelos/rails,lcreid/rails,lucasmazza/rails,rails/rails,sergey-alekseev/rails,illacceptanything/illacceptanything,gauravtiwari/rails,mechanicles/rails,arunagw/rails,voray/rails,arunagw/rails,kmcphillips/rails,iainbeeston/rails,aditya-kapoor/rails,pvalena/rails,pvalena/rails,kirs/rails-1,pschambacher/rails,starknx/rails,yahonda/rails,mtsmfm/railstest,vassilevsky/rails,lucasmazza/rails,kmcphillips/rails,prathamesh-sonpatki/rails,tgxworld/rails,kaspth/rails,Sen-Zhang/rails,brchristian/rails,joonyou/rails,esparta/rails,vipulnsward/rails,gcourtemanche/rails,eileencodes/rails,fabianoleittes/rails,Erol/rails,maicher/rails,vassilevsky/rails,Edouard-chin/rails,MSP-Greg/rails,georgeclaghorn/rails,richseviora/rails,kenta-s/rails,Stellenticket/rails,shioyama/rails,notapatch/rails,ngpestelos/rails,kenta-s/rails,Stellenticket/rails,alecspopa/rails,Sen-Zhang/rails,illacceptanything/illacceptanything,rossta/rails,stefanmb/rails,mtsmfm/railstest,jeremy/rails,vassilevsky/rails,tjschuck/rails,prathamesh-sonpatki/rails,tijwelch/rails,printercu/rails,EmmaB/rails-1,shioyama/rails,gfvcastro/rails,baerjam/rails,amoody2108/TechForJustice,Edouard-chin/rails,sealocal/rails,88rabbit/newRails,kachick/rails,riseshia/railsguides.kr,deraru/rails,kachick/rails,pvalena/rails,gauravtiwari/rails,mechanicles/rails,88rabbit/newRails,palkan/rails,utilum/rails,marklocklear/rails,jeremy/rails,illacceptanything/illacceptanything,illacceptanything/illacceptanything,fabianoleittes/rails,hanystudy/rails,Erol/rails,palkan/rails,joonyou/rails,illacceptanything/illacceptanything,illacceptanything/illacceptanything,iainbeeston/rails,arjes/rails,mechanicles/rails,kmayer/rails,kenta-s/rails,schuetzm/rails,MSP-Greg/rails,Envek/rails,mijoharas/rails,Spin42/rails,printercu/rails,matrinox/rails,Vasfed/rails,kddeisz/rails,baerjam/rails,MSP-Greg/rails,amoody2108/TechForJustice,matrinox/rails,rails/rails,yasslab/railsguides.jp,deraru/rails,mohitnatoo/rails,gavingmiller/rails,tijwelch/rails,yalab/rails,iainbeeston/rails,kirs/rails-1,printercu/rails,fabianoleittes/rails,eileencodes/rails,gcourtemanche/rails,sergey-alekseev/rails,tgxworld/rails,Envek/rails,MichaelSp/rails,rails/rails,lucasmazza/rails,tgxworld/rails,yahonda/rails,brchristian/rails,gauravtiwari/rails,lcreid/rails,shioyama/rails,mohitnatoo/rails,voray/rails,kddeisz/rails,utilum/rails,MichaelSp/rails,rossta/rails,flanger001/rails,eileencodes/rails,yasslab/railsguides.jp,mtsmfm/rails,elfassy/rails,pschambacher/rails,Envek/rails,aditya-kapoor/rails,travisofthenorth/rails,Vasfed/rails,BlakeWilliams/rails,iainbeeston/rails,felipecvo/rails,gfvcastro/rails,yasslab/railsguides.jp,marklocklear/rails,vipulnsward/rails,kamipo/rails,alecspopa/rails,coreyward/rails,notapatch/rails,kamipo/rails,travisofthenorth/rails,arjes/rails,baerjam/rails,travisofthenorth/rails,BlakeWilliams/rails,betesh/rails,bogdanvlviv/rails,untidy-hair/rails,kmcphillips/rails,rafaelfranca/omg-rails,mtsmfm/rails,bolek/rails,ttanimichi/rails,EmmaB/rails-1,arunagw/rails,notapatch/rails,Envek/rails,coreyward/rails,mijoharas/rails,printercu/rails,xlymian/rails,georgeclaghorn/rails,rafaelfranca/omg-rails,kddeisz/rails,hanystudy/rails,mohitnatoo/rails,koic/rails,bradleypriest/rails,BlakeWilliams/rails,prathamesh-sonpatki/rails,mohitnatoo/rails,esparta/rails,esparta/rails,mathieujobin/reduced-rails-for-travis,yhirano55/rails,yhirano55/rails,yhirano55/rails,alecspopa/rails,pschambacher/rails,MichaelSp/rails,betesh/rails,travisofthenorth/rails,ledestin/rails,illacceptanything/illacceptanything,joonyou/rails,felipecvo/rails,baerjam/rails,tjschuck/rails,maicher/rails,kmayer/rails,MSP-Greg/rails,tjschuck/rails,kaspth/rails,repinel/rails,yahonda/rails,vipulnsward/rails,repinel/rails,xlymian/rails,starknx/rails,rbhitchcock/rails,vipulnsward/rails,88rabbit/newRails,brchristian/rails,assain/rails,riseshia/railsguides.kr,yawboakye/rails,elfassy/rails,matrinox/rails,yawboakye/rails,Vasfed/rails,ledestin/rails,amoody2108/TechForJustice,kaspth/rails,schuetzm/rails,sealocal/rails,EmmaB/rails-1,gavingmiller/rails,odedniv/rails,mechanicles/rails,lcreid/rails