Ensure use of stored properties in actions
Ensure use of stored properties in actions

This patch gives effect to the change intended to be implemented in
6bc25ef0e02ee6b04b49901d5c292038e4c8be58.

The Resource._do_action() method is a co-routine, but in a number of
less common resource actions, we simply return the result of calling it
rather than turning the action into a wrappertask and yielding it. This
works fine (the action returns a generator; the caller doesn't care
where it came from) and reduces the amount of wrapper frames on the
stack.

However, in most cases we want the stored properties to be used while
calling _do_action(). However, to ensure that they are actually in place
when the co-routine is running, we must yield rather than return the
generator. In the suspend, resume, snapshot, and chekc actions we were
not doing that. It is not known whether any resource types are actually
accessing properties during any of these actions.

Change-Id: I2b2a87ccf1988821a250373fea261c1850e5c51b

openstack/heat,openstack/heat