Fix latent(?) race condition in LockReleaseAll.
Fix latent(?) race condition in LockReleaseAll.

We have for a long time checked the head pointer of each of the backend's
proclock lists and skipped acquiring the corresponding locktable partition
lock if the head pointer was NULL.  This was safe enough in the days when
proclock lists were changed only by the owning backend, but it is pretty
questionable now that the fast-path patch added cases where backends add
entries to other backends' proclock lists.  However, we don't really wish
to revert to locking each partition lock every time, because in simple
transactions that would add a lot of useless lock/unlock cycles on
already-heavily-contended LWLocks.  Fortunately, the only way that another
backend could be modifying our proclock list at this point would be if it
was promoting a formerly fast-path lock of ours; and any such lock must be
one that we'd decided not to delete in the previous loop over the locallock
table.  So it's okay if we miss seeing it in this loop; we'd just decide
not to delete it again.  However, once we've detected a non-empty list,
we'd better re-fetch the list head pointer after acquiring the partition
lock.  This guards against possibly fetching a corrupt-but-non-null pointer
if pointer fetch/store isn't atomic.  It's not clear if any practical
architectures are like that, but we've never assumed that before and don't
wish to start here.  In any case, the situation certainly deserves a code
comment.

While at it, refactor the partition traversal loop to use a for() construct
instead of a while() loop with goto's.

Back-patch, just in case the risk is real and not hypothetical.

pavanvd/postgres-xl,Postgres-XL/Postgres-XL,greenplum-db/gpdb,greenplum-db/gpdb,50wu/gpdb,greenplum-db/gpdb,lisakowen/gpdb,lisakowen/gpdb,pavanvd/postgres-xl,ashwinstar/gpdb,jmcatamney/gpdb,ashwinstar/gpdb,jmcatamney/gpdb,pavanvd/postgres-xl,oberstet/postgres-xl,jmcatamney/gpdb,ovr/postgres-xl,techdragon/Postgres-XL,ashwinstar/gpdb,yazun/postgres-xl,50wu/gpdb,ovr/postgres-xl,greenplum-db/gpdb,ashwinstar/gpdb,greenplum-db/gpdb,zeroae/postgres-xl,ovr/postgres-xl,yazun/postgres-xl,greenplum-db/gpdb,ashwinstar/gpdb,zeroae/postgres-xl,ashwinstar/gpdb,techdragon/Postgres-XL,Postgres-XL/Postgres-XL,jmcatamney/gpdb,zeroae/postgres-xl,techdragon/Postgres-XL,oberstet/postgres-xl,zeroae/postgres-xl,xinzweb/gpdb,yazun/postgres-xl,jmcatamney/gpdb,Postgres-XL/Postgres-XL,jmcatamney/gpdb,50wu/gpdb,xinzweb/gpdb,adam8157/gpdb,50wu/gpdb,ovr/postgres-xl,greenplum-db/gpdb,techdragon/Postgres-XL,oberstet/postgres-xl,ashwinstar/gpdb,Postgres-XL/Postgres-XL,adam8157/gpdb,greenplum-db/gpdb,adam8157/gpdb,lisakowen/gpdb,lisakowen/gpdb,pavanvd/postgres-xl,50wu/gpdb,jmcatamney/gpdb,lisakowen/gpdb,adam8157/gpdb,adam8157/gpdb,techdragon/Postgres-XL,xinzweb/gpdb,yazun/postgres-xl,50wu/gpdb,ovr/postgres-xl,pavanvd/postgres-xl,zeroae/postgres-xl,adam8157/gpdb,lisakowen/gpdb,adam8157/gpdb,yazun/postgres-xl,xinzweb/gpdb,oberstet/postgres-xl,xinzweb/gpdb,xinzweb/gpdb,lisakowen/gpdb,xinzweb/gpdb,Postgres-XL/Postgres-XL,xinzweb/gpdb,50wu/gpdb,50wu/gpdb,oberstet/postgres-xl,lisakowen/gpdb,jmcatamney/gpdb,ashwinstar/gpdb,adam8157/gpdb