scorch persistSnapshot() consistently uses err to commit vs abort
scorch persistSnapshot() consistently uses err to commit vs abort

Some codepaths in persistSnapshot() were saving errors into an err2
local variable, which might lead incorrectly to commit during an error
situation rather than abort.

blevesearch/bleve,blevesearch/bleve,steveyen/bleve,steveyen/bleve