Improve how params from controller are permitted in filter helper (#3129)
Improve how params from controller are permitted in filter helper (#3129)

The `params` variable here was quite overloaded.

It exists via the controller to hold the request params, and was sometimes being
used in this helper as that object, but other times was being used as a local
variable, or to pass to another method, and this was confusing.

This change renames the args for a method away from `params` for more clarity,
and extracts the actual usage of the controller-provided `params` to a
better-named method for clarity.
sylph-sin-tyaku/mastodon,summoners-riftodon/mastodon,vahnj/mastodon,unarist/mastodon,tootsuite/mastodon,ykzts/mastodon,gol-cha/mastodon,rainyday/mastodon,PlantsNetwork/mastodon,pso2club/mastodon,Kirishima21/mastodon,yi0713/mastodon,hugogameiro/mastodon,imomix/mastodon,mimumemo/mastodon,res-ac/mstdn.res.ac,RobertRence/Mastodon,primenumber/mastodon,5thfloor/ichiji-social,mecab/mastodon,hyuki0000/mastodon,increments/mastodon,mstdn-jp/mastodon,im-in-space/mastodon,sylph-sin-tyaku/mastodon,SerCom-KC/mastodon,Nyoho/mastodon,d6rkaiz/mastodon,imas/mastodon,Craftodon/Craftodon,palon7/mastodon,haleyashleypraesent/ProjectPrionosuchus,lynlynlynx/mastodon,rekif/mastodon,im-in-space/mastodon,ebihara99999/mastodon,h-izumi/mastodon,ambition-vietnam/mastodon,maa123/mastodon,KnzkDev/mastodon,Arukas/mastodon,imas/mastodon,pso2club/mastodon,salvadorpla/mastodon,PlantsNetwork/mastodon,5thfloor/ichiji-social,MastodonCloud/mastodon,tootsuite/mastodon,blackle/mastodon,TheInventrix/mastodon,NS-Kazuki/mastodon,pfm-eyesightjp/mastodon,masarakki/mastodon,rutan/mastodon,mosaxiv/mastodon,pinfort/mastodon,anon5r/mastonon,abcang/mastodon,anon5r/mastonon,TootCat/mastodon,esetomo/mastodon,salvadorpla/mastodon,theoria24/mastodon,dwango/mastodon,Arukas/mastodon,increments/mastodon,palon7/mastodon,PlantsNetwork/mastodon,glitch-soc/mastodon,ykzts/mastodon,3846masa/mastodon,h-izumi/mastodon,rutan/mastodon,vahnj/mastodon,tootsuite/mastodon,d6rkaiz/mastodon,nonoz/mastodon,unarist/mastodon,dunn/mastodon,narabo/mastodon,Toootim/mastodon,KnzkDev/mastodon,cybrespace/mastodon,SerCom-KC/mastodon,pointlessone/mastodon,mecab/mastodon,amazedkoumei/mastodon,WitchesTown/mastodon,nonoz/mastodon,tootsuite/mastodon,rekif/mastodon,lynlynlynx/mastodon,tootcafe/mastodon,TheInventrix/mastodon,theoria24/mastodon,yi0713/mastodon,corzntin/mastodon,TootCat/mastodon,tri-star/mastodon,pixiv/mastodon,pinfort/mastodon,honpya/taketodon,cobodo/mastodon,kagucho/mastodon,foozmeat/mastodon,Ryanaka/mastodon,rainyday/mastodon,alarky/mastodon,pixiv/mastodon,dunn/mastodon,cobodo/mastodon,RobertRence/Mastodon,kagucho/mastodon,RobertRence/Mastodon,summoners-riftodon/mastodon,masto-donte-com-br/mastodon,h3zjp/mastodon,anon5r/mastonon,alarky/mastodon,blackle/mastodon,rainyday/mastodon,res-ac/mstdn.res.ac,sylph-sin-tyaku/mastodon,Chronister/mastodon,amazedkoumei/mastodon,WitchesTown/mastodon,TheInventrix/mastodon,kirakiratter/mastodon,Kirishima21/mastodon,h3zjp/mastodon,Ryanaka/mastodon,ikuradon/mastodon,riku6460/chikuwagoddon,increments/mastodon,h3zjp/mastodon,maa123/mastodon,primenumber/mastodon,gol-cha/mastodon,tateisu/mastodon,alarky/mastodon,vahnj/mastodon,Nyoho/mastodon,verniy6462/mastodon,theoria24/mastodon,ikuradon/mastodon,clworld/mastodon,TootCat/mastodon,glitch-soc/mastodon,corzntin/mastodon,NS-Kazuki/mastodon,h-izumi/mastodon,imomix/mastodon,pointlessone/mastodon,Ryanaka/mastodon,imas/mastodon,dunn/mastodon,Kirishima21/mastodon,nonoz/mastodon,NS-Kazuki/mastodon,tootcafe/mastodon,gol-cha/mastodon,KnzkDev/mastodon,Craftodon/Craftodon,musashino205/mastodon,TheInventrix/mastodon,ebihara99999/mastodon,ikuradon/mastodon,Nyoho/mastodon,amazedkoumei/mastodon,WitchesTown/mastodon,mosaxiv/mastodon,maa123/mastodon,ebihara99999/mastodon,lindwurm/mastodon,haleyashleypraesent/ProjectPrionosuchus,tateisu/mastodon,mimumemo/mastodon,MastodonCloud/mastodon,codl/mastodon,yi0713/mastodon,Toootim/mastodon,masarakki/mastodon,ambition-vietnam/mastodon,cybrespace/mastodon,cobodo/mastodon,mimumemo/mastodon,esetomo/mastodon,danhunsaker/mastodon,clworld/mastodon,kazh98/social.arnip.org,verniy6462/mastodon,sylph-sin-tyaku/mastodon,mstdn-jp/mastodon,SerCom-KC/mastodon,amazedkoumei/mastodon,h-izumi/mastodon,Craftodon/Craftodon,pfm-eyesightjp/mastodon,verniy6462/mastodon,koba-lab/mastodon,mhffdq/mastodon,vahnj/mastodon,haleyashleypraesent/ProjectPrionosuchus,kazh98/social.arnip.org,3846masa/mastodon,kazh98/social.arnip.org,narabo/mastodon,hugogameiro/mastodon,musashino205/mastodon,koba-lab/mastodon,Arukas/mastodon,hyuki0000/mastodon,hyuki0000/mastodon,lynlynlynx/mastodon,tootcafe/mastodon,dwango/mastodon,ikuradon/mastodon,mstdn-jp/mastodon,tri-star/mastodon,imomix/mastodon,palon7/mastodon,rainyday/mastodon,pixiv/mastodon,MitarashiDango/mastodon,riku6460/chikuwagoddon,yukimochi/mastodon,ambition-vietnam/mastodon,yi0713/mastodon,Ryanaka/mastodon,masto-donte-com-br/mastodon,cybrespace/mastodon,rekif/mastodon,tri-star/mastodon,imas/mastodon,Nyoho/mastodon,nonoz/mastodon,salvadorpla/mastodon,mosaxiv/mastodon,h3zjp/mastodon,d6rkaiz/mastodon,kirakiratter/mastodon,SerCom-KC/mastodon,koba-lab/mastodon,maa123/mastodon,WitchesTown/mastodon,hugogameiro/mastodon,honpya/taketodon,MitarashiDango/mastodon,Craftodon/Craftodon,glitch-soc/mastodon,cobodo/mastodon,foozmeat/mastodon,unarist/mastodon,masto-donte-com-br/mastodon,TheInventrix/mastodon,yukimochi/mastodon,lynlynlynx/mastodon,Arukas/mastodon,ykzts/mastodon,musashino205/mastodon,corzntin/mastodon,koba-lab/mastodon,clworld/mastodon,riku6460/chikuwagoddon,mecab/mastodon,rekif/mastodon,corzntin/mastodon,mhffdq/mastodon,mimumemo/mastodon,TootCat/mastodon,kagucho/mastodon,theoria24/mastodon,lindwurm/mastodon,im-in-space/mastodon,masarakki/mastodon,kirakiratter/mastodon,unarist/mastodon,pixiv/mastodon,MitarashiDango/mastodon,pointlessone/mastodon,tootcafe/mastodon,mosaxiv/mastodon,kagucho/mastodon,RobertRence/Mastodon,hyuki0000/mastodon,Chronister/mastodon,esetomo/mastodon,rutan/mastodon,foozmeat/mastodon,codl/mastodon,glitch-soc/mastodon,mhffdq/mastodon,Chronister/mastodon,summoners-riftodon/mastodon,foozmeat/mastodon,3846masa/mastodon,d6rkaiz/mastodon,ebihara99999/mastodon,narabo/mastodon,anon5r/mastonon,tateisu/mastodon,lindwurm/mastodon,verniy6462/mastodon,Chronister/mastodon,kazh98/social.arnip.org,blackle/mastodon,masarakki/mastodon,cybrespace/mastodon,mecab/mastodon,imomix/mastodon,increments/mastodon,summoners-riftodon/mastodon,tri-star/mastodon,5thfloor/ichiji-social,MastodonCloud/mastodon,yukimochi/mastodon,Toootim/mastodon,3846masa/mastodon,pso2club/mastodon,ykzts/mastodon,mstdn-jp/mastodon,musashino205/mastodon,riku6460/chikuwagoddon,primenumber/mastodon,codl/mastodon,dwango/mastodon,abcang/mastodon,clworld/mastodon,danhunsaker/mastodon,gol-cha/mastodon,PlantsNetwork/mastodon,vahnj/mastodon,primenumber/mastodon,im-in-space/mastodon,dunn/mastodon,5thfloor/ichiji-social,danhunsaker/mastodon,res-ac/mstdn.res.ac,haleyashleypraesent/ProjectPrionosuchus,yukimochi/mastodon,res-ac/mstdn.res.ac,pointlessone/mastodon,lindwurm/mastodon,dwango/mastodon,tateisu/mastodon,KnzkDev/mastodon,MastodonCloud/mastodon,kirakiratter/mastodon,Kirishima21/mastodon,pinfort/mastodon,abcang/mastodon,pso2club/mastodon,blackle/mastodon,honpya/taketodon,narabo/mastodon,pinfort/mastodon,MitarashiDango/mastodon,hugogameiro/mastodon,esetomo/mastodon,palon7/mastodon,salvadorpla/mastodon,pfm-eyesightjp/mastodon,honpya/taketodon,alarky/mastodon,codl/mastodon,pfm-eyesightjp/mastodon,rutan/mastodon,mhffdq/mastodon,danhunsaker/mastodon,NS-Kazuki/mastodon,abcang/mastodon,ambition-vietnam/mastodon,masto-donte-com-br/mastodon,Toootim/mastodon