Fix an oversight in my patch of a couple weeks ago that ensured a snapshot is available during datatype input in Bind message processing.  I put the PopActiveSnapshot() or equivalent just before PortalDefineQuery, which is an unsafe spot for it (in 8.3 and later) because we are carrying a plancache refcount that hasn't yet been assigned to the portal.  Any error thrown there would result in leaking the refcount.  It's not exactly likely that PopActiveSnapshot would throw an elog, perhaps, but it could happen. Reorder the code and add another comment warning not to do that.
Fix an oversight in my patch of a couple weeks ago that ensured a snapshot
is available during datatype input in Bind message processing.  I put the
PopActiveSnapshot() or equivalent just before PortalDefineQuery, which is
an unsafe spot for it (in 8.3 and later) because we are carrying a plancache
refcount that hasn't yet been assigned to the portal.  Any error thrown there
would result in leaking the refcount.  It's not exactly likely that
PopActiveSnapshot would throw an elog, perhaps, but it could happen.
Reorder the code and add another comment warning not to do that.

janebeckman/gpdb,50wu/gpdb,yuanzhao/gpdb,Chibin/gpdb,ahachete/gpdb,edespino/gpdb,0x0FFF/gpdb,0x0FFF/gpdb,jmcatamney/gpdb,royc1/gpdb,janebeckman/gpdb,Quikling/gpdb,lisakowen/gpdb,ashwinstar/gpdb,Chibin/gpdb,rvs/gpdb,zaksoup/gpdb,adam8157/gpdb,cjcjameson/gpdb,cjcjameson/gpdb,rvs/gpdb,rvs/gpdb,royc1/gpdb,xinzweb/gpdb,Chibin/gpdb,lintzc/gpdb,zaksoup/gpdb,lintzc/gpdb,xuegang/gpdb,royc1/gpdb,janebeckman/gpdb,ahachete/gpdb,50wu/gpdb,xuegang/gpdb,zaksoup/gpdb,yuanzhao/gpdb,adam8157/gpdb,chrishajas/gpdb,greenplum-db/gpdb,greenplum-db/gpdb,Quikling/gpdb,royc1/gpdb,ahachete/gpdb,janebeckman/gpdb,ashwinstar/gpdb,yuanzhao/gpdb,lisakowen/gpdb,Quikling/gpdb,ahachete/gpdb,CraigHarris/gpdb,jmcatamney/gpdb,CraigHarris/gpdb,janebeckman/gpdb,zaksoup/gpdb,Quikling/gpdb,edespino/gpdb,jmcatamney/gpdb,CraigHarris/gpdb,50wu/gpdb,50wu/gpdb,0x0FFF/gpdb,chrishajas/gpdb,adam8157/gpdb,kaknikhil/gpdb,cjcjameson/gpdb,xuegang/gpdb,yuanzhao/gpdb,lisakowen/gpdb,Quikling/gpdb,xuegang/gpdb,rvs/gpdb,edespino/gpdb,greenplum-db/gpdb,rvs/gpdb,lintzc/gpdb,xinzweb/gpdb,lintzc/gpdb,edespino/gpdb,xinzweb/gpdb,CraigHarris/gpdb,rvs/gpdb,kaknikhil/gpdb,Quikling/gpdb,cjcjameson/gpdb,royc1/gpdb,jmcatamney/gpdb,edespino/gpdb,CraigHarris/gpdb,xuegang/gpdb,greenplum-db/gpdb,CraigHarris/gpdb,lisakowen/gpdb,yuanzhao/gpdb,ashwinstar/gpdb,xinzweb/gpdb,adam8157/gpdb,lintzc/gpdb,edespino/gpdb,ashwinstar/gpdb,kaknikhil/gpdb,CraigHarris/gpdb,adam8157/gpdb,yuanzhao/gpdb,0x0FFF/gpdb,Quikling/gpdb,0x0FFF/gpdb,cjcjameson/gpdb,rvs/gpdb,adam8157/gpdb,jmcatamney/gpdb,cjcjameson/gpdb,50wu/gpdb,janebeckman/gpdb,kaknikhil/gpdb,adam8157/gpdb,adam8157/gpdb,yuanzhao/gpdb,0x0FFF/gpdb,Quikling/gpdb,xinzweb/gpdb,Quikling/gpdb,kaknikhil/gpdb,edespino/gpdb,ashwinstar/gpdb,jmcatamney/gpdb,xinzweb/gpdb,greenplum-db/gpdb,rvs/gpdb,edespino/gpdb,zaksoup/gpdb,ahachete/gpdb,xuegang/gpdb,Chibin/gpdb,chrishajas/gpdb,lisakowen/gpdb,janebeckman/gpdb,Quikling/gpdb,greenplum-db/gpdb,Chibin/gpdb,50wu/gpdb,jmcatamney/gpdb,rvs/gpdb,royc1/gpdb,chrishajas/gpdb,Chibin/gpdb,ahachete/gpdb,rvs/gpdb,yuanzhao/gpdb,jmcatamney/gpdb,0x0FFF/gpdb,zaksoup/gpdb,royc1/gpdb,ashwinstar/gpdb,ashwinstar/gpdb,greenplum-db/gpdb,lintzc/gpdb,CraigHarris/gpdb,xuegang/gpdb,kaknikhil/gpdb,kaknikhil/gpdb,xuegang/gpdb,janebeckman/gpdb,kaknikhil/gpdb,Chibin/gpdb,ahachete/gpdb,lintzc/gpdb,chrishajas/gpdb,lisakowen/gpdb,edespino/gpdb,50wu/gpdb,cjcjameson/gpdb,kaknikhil/gpdb,Chibin/gpdb,chrishajas/gpdb,ahachete/gpdb,cjcjameson/gpdb,Chibin/gpdb,chrishajas/gpdb,yuanzhao/gpdb,xinzweb/gpdb,0x0FFF/gpdb,lintzc/gpdb,cjcjameson/gpdb,Chibin/gpdb,janebeckman/gpdb,zaksoup/gpdb,kaknikhil/gpdb,lintzc/gpdb,50wu/gpdb,greenplum-db/gpdb,cjcjameson/gpdb,yuanzhao/gpdb,janebeckman/gpdb,lisakowen/gpdb,xuegang/gpdb,CraigHarris/gpdb,zaksoup/gpdb,chrishajas/gpdb,edespino/gpdb,royc1/gpdb,xinzweb/gpdb,ashwinstar/gpdb,lisakowen/gpdb