add test to verify that redundant gossip clients are dropped
add test to verify that redundant gossip clients are dropped

Summary: looked at this because the simulation sometimes shows a persistent connection loop between two gossip nodes (i.e. a connects to b and b connects to a). It seems that the detection for this is working alright though. Also the breakup is definitely triggered at times during the simulation. So I'm not wiser than before but we have one more test for this sort of thing.

Test Plan: make test

Reviewers: andybons, spencerkimball

Reviewed By: spencerkimball

Differential Revision: http://phabricator.cockroachdb.org/D81

loucash/cockroach,mbertschler/cockroach,yananzhi/cockroach,hassyma/cockroach,mbertschler/cockroach,fengshao0907/cockroach,Abioy/cockroach,abhishekgahlot/cockroach,loucash/cockroach,es-chow/cockroach,il9ue/cockroach,Abioy/cockroach,mbertschler/cockroach,glycerine/cockroach,arypurnomoz/cockroach,mbertschler/cockroach,Kevin-GuanJian/cockroach,yananzhi/cockroach,loucash/cockroach,arypurnomoz/cockroach,chrisseto/cockroach,petermattis/cockroach,maxlang/cockroach,alunarbeach/cockroach,es-chow/cockroach,marcuswestin/cockroach,loucash/cockroach,jgautheron/cockroach,iqstack/cockroach,XisiHuang/cockroach,nieyy/cockroach,jmank88/cockroach,jgautheron/cockroach,slavau/cockroach,yananzhi/cockroach,Kevin-GuanJian/cockroach,hassyma/cockroach,XuWanHong/cockroach-1,linearb/cockroach,jmank88/cockroach,linearb/cockroach,briceburg/cockroach,paperstreet/cockroach,ajayaa/cockroach,yiixiansheng/cockroach,briceburg/cockroach,yosiat/cockroach,ajayaa/cockroach,yananzhi/cockroach,alunarbeach/cockroach,nieyy/cockroach,petermattis/cockroach,slavau/cockroach,jess-edwards/cockroach,vaibhavarora/cockroach,vivekmenezes/cockroach,arypurnomoz/cockroach,veteranlu/cockroach,marcuswestin/cockroach,iqstack/cockroach,linearb/cockroach,freakynit/cockroach,vivekmenezes/cockroach,arjun4084346/cockroach,sunya123/cockroach,abhishekgahlot/cockroach,alex/cockroach,sunya123/cockroach,hassyma/cockroach,XisiHuang/cockroach,veteranlu/cockroach,hassyma/cockroach,nkhuyu/cockroach,il9ue/cockroach,mbonaci/cockroach,il9ue/cockroach,linearb/cockroach,yosiat/cockroach,nkhuyu/cockroach,jamesgraves/cockroach,fengshao0907/cockroach,alex/cockroach,ngaut/cockroach,nieyy/cockroach,freakynit/cockroach,jess-edwards/cockroach,iqstack/cockroach,marcuswestin/cockroach,SustainFund/cockroach,nieyy/cockroach,iqstack/cockroach,alex/cockroach,yiixiansheng/cockroach,nkhuyu/cockroach,jmank88/cockroach,freakynit/cockroach,petermattis/cockroach,nieyy/cockroach,paperstreet/cockroach,hassyma/cockroach,alunarbeach/cockroach,cuongdo/cockroach,XuWanHong/cockroach-1,chrisseto/cockroach,c4pt0r/cockroach,glycerine/cockroach,domluna/cockroach,mbonaci/cockroach,GokulSrinivas/cockroach,mbonaci/cockroach,GokulSrinivas/cockroach,arypurnomoz/cockroach,maxlang/cockroach,Kevin-GuanJian/cockroach,arjun4084346/cockroach,SustainFund/cockroach,bg451/cockroach,arypurnomoz/cockroach,es-chow/cockroach,maxlang/cockroach,nieyy/cockroach,jess-edwards/cockroach,cockroachdb/cockroach,linearb/cockroach,mbertschler/cockroach,cockroachdb/cockroach,vaibhavarora/cockroach,vivekmenezes/cockroach,iqstack/cockroach,mbonaci/cockroach,petermattis/cockroach,domluna/cockroach,ngaut/cockroach,veteranlu/cockroach,bg451/cockroach,mbonaci/cockroach,marcuswestin/cockroach,veteranlu/cockroach,sunya123/cockroach,arjun4084346/cockroach,ngaut/cockroach,glycerine/cockroach,cockroachdb/cockroach,paperstreet/cockroach,briceburg/cockroach,ajayaa/cockroach,jgautheron/cockroach,Abioy/cockroach,linearb/cockroach,glycerine/cockroach,alex/cockroach,nkhuyu/cockroach,yosiat/cockroach,abhishekgahlot/cockroach,XisiHuang/cockroach,vaibhavarora/cockroach,GokulSrinivas/cockroach,briceburg/cockroach,maxlang/cockroach,XisiHuang/cockroach,yananzhi/cockroach,slavau/cockroach,XuWanHong/cockroach-1,ajayaa/cockroach,yiixiansheng/cockroach,marcuswestin/cockroach,Abioy/cockroach,jamesgraves/cockroach,Kevin-GuanJian/cockroach,XuWanHong/cockroach-1,sunya123/cockroach,GokulSrinivas/cockroach,nkhuyu/cockroach,es-chow/cockroach,sunya123/cockroach,cuongdo/cockroach,vivekmenezes/cockroach,c4pt0r/cockroach,vaibhavarora/cockroach,c4pt0r/cockroach,linearb/cockroach,cockroachdb/cockroach,domluna/cockroach,domluna/cockroach,marcuswestin/cockroach,vivekmenezes/cockroach,cuongdo/cockroach,vaibhavarora/cockroach,jamesgraves/cockroach,alunarbeach/cockroach,glycerine/cockroach,briceburg/cockroach,alex/cockroach,ngaut/cockroach,iqstack/cockroach,vaibhavarora/cockroach,bg451/cockroach,bg451/cockroach,nkhuyu/cockroach,loucash/cockroach,hassyma/cockroach,petermattis/cockroach,chrisseto/cockroach,paperstreet/cockroach,domluna/cockroach,glycerine/cockroach,chrisseto/cockroach,c4pt0r/cockroach,vivekmenezes/cockroach,glycerine/cockroach,paperstreet/cockroach,alunarbeach/cockroach,il9ue/cockroach,maxlang/cockroach,bg451/cockroach,mbertschler/cockroach,arjun4084346/cockroach,freakynit/cockroach,Kevin-GuanJian/cockroach,arypurnomoz/cockroach,SustainFund/cockroach,yiixiansheng/cockroach,jmank88/cockroach,SustainFund/cockroach,fengshao0907/cockroach,slavau/cockroach,es-chow/cockroach,vaibhavarora/cockroach,petermattis/cockroach,jmank88/cockroach,maxlang/cockroach,arjun4084346/cockroach,es-chow/cockroach,paperstreet/cockroach,petermattis/cockroach,mbertschler/cockroach,jgautheron/cockroach,paperstreet/cockroach,arjun4084346/cockroach,jess-edwards/cockroach,chrisseto/cockroach,slavau/cockroach,slavau/cockroach,veteranlu/cockroach,loucash/cockroach,GokulSrinivas/cockroach,ajayaa/cockroach,fengshao0907/cockroach,fengshao0907/cockroach,chrisseto/cockroach,jgautheron/cockroach,domluna/cockroach,Abioy/cockroach,cuongdo/cockroach,vivekmenezes/cockroach,glycerine/cockroach,veteranlu/cockroach,fengshao0907/cockroach,jgautheron/cockroach,Abioy/cockroach,abhishekgahlot/cockroach,nieyy/cockroach,il9ue/cockroach,cuongdo/cockroach,Kevin-GuanJian/cockroach,bg451/cockroach,cockroachdb/cockroach,cockroachdb/cockroach,arjun4084346/cockroach,jess-edwards/cockroach,jamesgraves/cockroach,iqstack/cockroach,vivekmenezes/cockroach,XisiHuang/cockroach,maxlang/cockroach,veteranlu/cockroach,ngaut/cockroach,cuongdo/cockroach,arjun4084346/cockroach,il9ue/cockroach,sunya123/cockroach,yosiat/cockroach,cuongdo/cockroach,freakynit/cockroach,alunarbeach/cockroach,SustainFund/cockroach,veteranlu/cockroach,yosiat/cockroach,freakynit/cockroach,ngaut/cockroach,jamesgraves/cockroach,Kevin-GuanJian/cockroach,mbonaci/cockroach,marcuswestin/cockroach,yiixiansheng/cockroach,vaibhavarora/cockroach,ngaut/cockroach,abhishekgahlot/cockroach,cuongdo/cockroach,nieyy/cockroach,sunya123/cockroach,ajayaa/cockroach,domluna/cockroach,jamesgraves/cockroach,yananzhi/cockroach,XisiHuang/cockroach,GokulSrinivas/cockroach,bg451/cockroach,paperstreet/cockroach,XuWanHong/cockroach-1,jess-edwards/cockroach,jamesgraves/cockroach,yosiat/cockroach,c4pt0r/cockroach,XuWanHong/cockroach-1,yiixiansheng/cockroach,c4pt0r/cockroach,jmank88/cockroach,il9ue/cockroach,cockroachdb/cockroach,XuWanHong/cockroach-1,SustainFund/cockroach,yananzhi/cockroach,es-chow/cockroach,marcuswestin/cockroach,abhishekgahlot/cockroach,sunya123/cockroach,maxlang/cockroach,il9ue/cockroach,briceburg/cockroach,cockroachdb/cockroach,alex/cockroach,jess-edwards/cockroach,petermattis/cockroach,jmank88/cockroach