storage: Don't update pool available/allocation if buildVol fails
storage: Don't update pool available/allocation if buildVol fails

https://bugzilla.redhat.com/show_bug.cgi?id=1024159

If adding a volume to a storage pool fails during the CreateXML or
CreateXMLFrom API's, we don't want to adjust the available and
allocation values for the storage pool during storageVolDelete
since we haven't adjusted the values for the create.

Refactor storageVolDelete() a bit to create a storageVolDeleteInternal()
which will handle the primary deletion activities.  Add a parameter
updateMeta which will signify whether to update the values or not.

Adjust the calls from CreateXML and CreateXMLFrom to directly call the
DeleteInternal with the pool lock held.  This does bypass the call
to virStorageVolDeleteEnsureACL().

nertpinx/libvirt,andreabolognani/libvirt,VenkatDatta/libvirt,jardasgit/libvirt,shugaoye/libvirt,taget/libvirt,zippy2/libvirt,datto/libvirt,libvirt/libvirt,datto/libvirt,crobinso/libvirt,VenkatDatta/libvirt,olafhering/libvirt,datto/libvirt,eskultety/libvirt,andreabolognani/libvirt,nertpinx/libvirt,crobinso/libvirt,rlaager/libvirt,libvirt/libvirt,libvirt/libvirt,elmarco/libvirt,zippy2/libvirt,olafhering/libvirt,crobinso/libvirt,jardasgit/libvirt,fabianfreyer/libvirt,eskultety/libvirt,shugaoye/libvirt,nertpinx/libvirt,libvirt/libvirt,VenkatDatta/libvirt,jfehlig/libvirt,agx/libvirt,jardasgit/libvirt,fabianfreyer/libvirt,olafhering/libvirt,shugaoye/libvirt,taget/libvirt,rlaager/libvirt,elmarco/libvirt,rlaager/libvirt,andreabolognani/libvirt,rlaager/libvirt,jfehlig/libvirt,crobinso/libvirt,VenkatDatta/libvirt,nertpinx/libvirt,nertpinx/libvirt,taget/libvirt,jardasgit/libvirt,agx/libvirt,jardasgit/libvirt,shugaoye/libvirt,eskultety/libvirt,agx/libvirt,elmarco/libvirt,elmarco/libvirt,VenkatDatta/libvirt,eskultety/libvirt,eskultety/libvirt,rlaager/libvirt,taget/libvirt,andreabolognani/libvirt,shugaoye/libvirt,agx/libvirt,andreabolognani/libvirt,zippy2/libvirt,agx/libvirt,fabianfreyer/libvirt,zippy2/libvirt,olafhering/libvirt,fabianfreyer/libvirt,fabianfreyer/libvirt,jfehlig/libvirt,elmarco/libvirt,jfehlig/libvirt,datto/libvirt,taget/libvirt,datto/libvirt