Check if notification is disabled
Check if notification is disabled

in send_smtp_message()
Other packages like arpwatch sm.php and cron job output as reported in forum https://forum.pfsense.org/index.php?topic=88347.0 call send_smtp_message() directly, currently bypassing notification disabled checks. I think those packages [are intended to | should be] respecting the notifications disabled setting. People in the forum certainly expect them to respect this setting.
If we add the $force parameter here, passing it through from notify_via_smtp() then the default behavior of send_smtp_message() can be to respect the "disable" setting. That should stop other package callers from spamming people who have disabled SMTP notifications.
If a package really wants/needs to send regardless, then it can set $force, just like the "Test SMTP" button does.
ch1c4um/pfsense,dennypage/pfsense,phil-davis/pfsense,ch1c4um/pfsense,phil-davis/pfsense,phil-davis/pfsense,BlackstarGroup/pfsense,ptorsten/pfsense,BlackstarGroup/pfsense,jxmx/pfsense,dennypage/pfsense,brunostein/pfsense,dennypage/pfsense,pfsense/pfsense,NewEraCracker/pfsense,dennypage/pfsense,NewEraCracker/pfsense,pfsense/pfsense,pfsense/pfsense,phil-davis/pfsense,jxmx/pfsense,NOYB/pfsense,brunostein/pfsense,NewEraCracker/pfsense,ch1c4um/pfsense,NewEraCracker/pfsense,jxmx/pfsense,NOYB/pfsense,BlackstarGroup/pfsense,ptorsten/pfsense,BlackstarGroup/pfsense,ptorsten/pfsense,NOYB/pfsense,brunostein/pfsense,pfsense/pfsense,ch1c4um/pfsense