Don't try to customize transceivers on startup
Don't try to customize transceivers on startup

Summary:
When we update qsfp_service, we end up unconditionally
calling customizeTransceiverLocked.

Call path is WedgeManager::init() --> initTransceiverMap() -> (foreach
tcvr) detectTransceiver() -> customizeTransceiverLocked().

This is very dangerous because customization can certainly cause port
flaps and it is written under the assumption that any transceiver
operation is safe to do (i.e port is inactive).

What currently saves us from flapping every misprogrammed port on
qsfp-service push is that the initial customize call does not know the
speed of the port. This means we don't correct CDR or rateselect
issues, which would cause port flaps in prod right now.

Even though we are ok right now, this is quite fragile to future
changes to customize logic, so I am getting rid of the customize
call from detectTransceiver.

Reviewed By: boryas

Differential Revision: D5659244

fbshipit-source-id: a4102b61928906311a871fdcb068aedf16ed1024

peterlei/fboss,peterlei/fboss,peterlei/fboss,peterlei/fboss