Split up caches in status_chooser (#847)
Split up caches in status_chooser (#847)

* Split up caches in status_chooser

The status_chooser is a performance hotpoint in this application.
Split the caches into multiple caches, so its results are more
likely to be shared, and completely eliminate the use of
the justification text as a cache key
(this text can be long, making it less than ideal as a cache key).

* Style tweak assignment in app/views/projects/_status_chooser.html.erb

Tweak style for assignment to passing_class per suggestion by Dan Kohn.
This hopefully makes it more obvious that a variable is being
assigned one of two values, based on a condition.

Signed-off-by: David A. Wheeler <9ae72d22d8b894b865a7a496af4fab6320e6abb2@dwheeler.com>

coreinfrastructure/best-practices-badge,linuxfoundation/cii-best-practices-badge,linuxfoundation/cii-best-practices-badge,taylorcoursey/cii-best-practices-badge,yannickmoy/cii-best-practices-badge,coreinfrastructure/best-practices-badge,taylorcoursey/cii-best-practices-badge,taylorcoursey/cii-best-practices-badge,yannickmoy/cii-best-practices-badge,linuxfoundation/cii-best-practices-badge,yannickmoy/cii-best-practices-badge,taylorcoursey/cii-best-practices-badge,coreinfrastructure/best-practices-badge,coreinfrastructure/best-practices-badge,yannickmoy/cii-best-practices-badge,linuxfoundation/cii-best-practices-badge