In -enable-new-objc-properties mode, compute the "StoredObjC" classification during the analysis of the VarDecl (which happens in the PBD walk) so that it happens earlier.  I was previously worried about invalidating the CD->getMembers() walk in DeclChecker::visitClassDecl, but adding to Members doesn't invalidate that walk: the memory isn't deallocated since it is in the bumppointer for the astcontext.
In -enable-new-objc-properties mode, compute the "StoredObjC" classification
during the analysis of the VarDecl (which happens in the PBD walk) so that
it happens earlier.  I was previously worried about invalidating the
CD->getMembers() walk in DeclChecker::visitClassDecl, but adding to Members
doesn't invalidate that walk: the memory isn't deallocated since it is in the
bumppointer for the astcontext.


Swift SVN r12968

tjw/swift,adrfer/swift,MukeshKumarS/Swift,dduan/swift,jopamer/swift,devincoughlin/swift,therealbnut/swift,kusl/swift,jopamer/swift,allevato/swift,huonw/swift,uasys/swift,kperryua/swift,mightydeveloper/swift,gmilos/swift,kperryua/swift,aschwaighofer/swift,stephentyrone/swift,brentdax/swift,KrishMunot/swift,codestergit/swift,harlanhaskins/swift,codestergit/swift,therealbnut/swift,cbrentharris/swift,xwu/swift,gottesmm/swift,gregomni/swift,karwa/swift,kstaring/swift,felix91gr/swift,allevato/swift,glessard/swift,sdulal/swift,jckarter/swift,djwbrown/swift,calebd/swift,IngmarStein/swift,return/swift,Jnosh/swift,danielmartin/swift,shahmishal/swift,roambotics/swift,uasys/swift,JaSpa/swift,karwa/swift,SwiftAndroid/swift,benlangmuir/swift,bitjammer/swift,ben-ng/swift,dreamsxin/swift,natecook1000/swift,zisko/swift,xedin/swift,shahmishal/swift,atrick/swift,jmgc/swift,khizkhiz/swift,glessard/swift,tkremenek/swift,shajrawi/swift,codestergit/swift,tjw/swift,return/swift,benlangmuir/swift,sdulal/swift,practicalswift/swift,CodaFi/swift,nathawes/swift,sdulal/swift,frootloops/swift,LeoShimonaka/swift,gottesmm/swift,kentya6/swift,austinzheng/swift,airspeedswift/swift,adrfer/swift,djwbrown/swift,parkera/swift,alblue/swift,IngmarStein/swift,milseman/swift,ken0nek/swift,adrfer/swift,johnno1962d/swift,jckarter/swift,slavapestov/swift,slavapestov/swift,atrick/swift,kentya6/swift,hooman/swift,austinzheng/swift,brentdax/swift,gregomni/swift,jmgc/swift,stephentyrone/swift,return/swift,brentdax/swift,xwu/swift,khizkhiz/swift,parkera/swift,dduan/swift,glessard/swift,tkremenek/swift,deyton/swift,atrick/swift,hooman/swift,huonw/swift,swiftix/swift.old,sdulal/swift,stephentyrone/swift,IngmarStein/swift,SwiftAndroid/swift,hooman/swift,kstaring/swift,practicalswift/swift,khizkhiz/swift,hooman/swift,rudkx/swift,manavgabhawala/swift,SwiftAndroid/swift,parkera/swift,LeoShimonaka/swift,sdulal/swift,amraboelela/swift,felix91gr/swift,cbrentharris/swift,mightydeveloper/swift,tkremenek/swift,bitjammer/swift,khizkhiz/swift,rudkx/swift,shajrawi/swift,ahoppen/swift,arvedviehweger/swift,gmilos/swift,modocache/swift,ken0nek/swift,gribozavr/swift,apple/swift,jmgc/swift,MukeshKumarS/Swift,austinzheng/swift,nathawes/swift,russbishop/swift,Ivacker/swift,brentdax/swift,MukeshKumarS/Swift,danielmartin/swift,OscarSwanros/swift,lorentey/swift,jtbandes/swift,roambotics/swift,tjw/swift,hughbe/swift,JaSpa/swift,amraboelela/swift,shajrawi/swift,deyton/swift,swiftix/swift.old,slavapestov/swift,danielmartin/swift,gribozavr/swift,cbrentharris/swift,KrishMunot/swift,Jnosh/swift,ben-ng/swift,natecook1000/swift,modocache/swift,CodaFi/swift,arvedviehweger/swift,airspeedswift/swift,slavapestov/swift,therealbnut/swift,calebd/swift,Jnosh/swift,shahmishal/swift,SwiftAndroid/swift,tinysun212/swift-windows,aschwaighofer/swift,allevato/swift,jmgc/swift,Ivacker/swift,jtbandes/swift,manavgabhawala/swift,brentdax/swift,practicalswift/swift,austinzheng/swift,alblue/swift,kstaring/swift,glessard/swift,dduan/swift,alblue/swift,natecook1000/swift,codestergit/swift,modocache/swift,brentdax/swift,johnno1962d/swift,therealbnut/swift,rudkx/swift,djwbrown/swift,swiftix/swift.old,nathawes/swift,ben-ng/swift,parkera/swift,russbishop/swift,shahmishal/swift,allevato/swift,khizkhiz/swift,shajrawi/swift,jckarter/swift,xwu/swift,lorentey/swift,airspeedswift/swift,devincoughlin/swift,OscarSwanros/swift,harlanhaskins/swift,therealbnut/swift,LeoShimonaka/swift,hooman/swift,KrishMunot/swift,slavapestov/swift,codestergit/swift,manavgabhawala/swift,deyton/swift,milseman/swift,parkera/swift,JGiola/swift,arvedviehweger/swift,harlanhaskins/swift,xedin/swift,glessard/swift,tardieu/swift,gribozavr/swift,kusl/swift,hughbe/swift,lorentey/swift,emilstahl/swift,benlangmuir/swift,devincoughlin/swift,gribozavr/swift,harlanhaskins/swift,tardieu/swift,OscarSwanros/swift,amraboelela/swift,adrfer/swift,practicalswift/swift,harlanhaskins/swift,bitjammer/swift,swiftix/swift.old,mightydeveloper/swift,shajrawi/swift,modocache/swift,xwu/swift,khizkhiz/swift,ahoppen/swift,amraboelela/swift,ben-ng/swift,JGiola/swift,karwa/swift,uasys/swift,SwiftAndroid/swift,ben-ng/swift,allevato/swift,airspeedswift/swift,karwa/swift,benlangmuir/swift,bitjammer/swift,jopamer/swift,JGiola/swift,IngmarStein/swift,kentya6/swift,swiftix/swift,apple/swift,ken0nek/swift,dduan/swift,Ivacker/swift,kentya6/swift,sschiau/swift,gottesmm/swift,atrick/swift,ken0nek/swift,swiftix/swift.old,ahoppen/swift,mightydeveloper/swift,gmilos/swift,zisko/swift,KrishMunot/swift,MukeshKumarS/Swift,JaSpa/swift,manavgabhawala/swift,bitjammer/swift,OscarSwanros/swift,IngmarStein/swift,emilstahl/swift,kperryua/swift,atrick/swift,xedin/swift,tardieu/swift,felix91gr/swift,natecook1000/swift,devincoughlin/swift,huonw/swift,tinysun212/swift-windows,cbrentharris/swift,huonw/swift,milseman/swift,ben-ng/swift,return/swift,ken0nek/swift,karwa/swift,russbishop/swift,jtbandes/swift,lorentey/swift,rudkx/swift,OscarSwanros/swift,huonw/swift,LeoShimonaka/swift,kusl/swift,zisko/swift,sschiau/swift,practicalswift/swift,roambotics/swift,JaSpa/swift,cbrentharris/swift,kstaring/swift,ken0nek/swift,russbishop/swift,russbishop/swift,tardieu/swift,gregomni/swift,swiftix/swift,djwbrown/swift,CodaFi/swift,kusl/swift,Jnosh/swift,gribozavr/swift,gottesmm/swift,kentya6/swift,arvedviehweger/swift,benlangmuir/swift,jckarter/swift,uasys/swift,uasys/swift,calebd/swift,jckarter/swift,xedin/swift,rudkx/swift,johnno1962d/swift,huonw/swift,therealbnut/swift,return/swift,lorentey/swift,manavgabhawala/swift,gregomni/swift,swiftix/swift,tjw/swift,jtbandes/swift,cbrentharris/swift,devincoughlin/swift,LeoShimonaka/swift,frootloops/swift,gregomni/swift,Jnosh/swift,djwbrown/swift,mightydeveloper/swift,SwiftAndroid/swift,benlangmuir/swift,dduan/swift,apple/swift,amraboelela/swift,amraboelela/swift,stephentyrone/swift,sdulal/swift,kperryua/swift,CodaFi/swift,kperryua/swift,roambotics/swift,arvedviehweger/swift,modocache/swift,Ivacker/swift,parkera/swift,KrishMunot/swift,shahmishal/swift,jopamer/swift,alblue/swift,tinysun212/swift-windows,cbrentharris/swift,jopamer/swift,kusl/swift,sdulal/swift,atrick/swift,amraboelela/swift,MukeshKumarS/Swift,brentdax/swift,frootloops/swift,IngmarStein/swift,sschiau/swift,shahmishal/swift,russbishop/swift,hughbe/swift,gottesmm/swift,swiftix/swift.old,jckarter/swift,mightydeveloper/swift,CodaFi/swift,devincoughlin/swift,stephentyrone/swift,calebd/swift,ben-ng/swift,xedin/swift,austinzheng/swift,arvedviehweger/swift,jckarter/swift,uasys/swift,kstaring/swift,kusl/swift,calebd/swift,danielmartin/swift,MukeshKumarS/Swift,swiftix/swift,Ivacker/swift,return/swift,LeoShimonaka/swift,karwa/swift,allevato/swift,emilstahl/swift,sschiau/swift,emilstahl/swift,glessard/swift,kusl/swift,zisko/swift,return/swift,IngmarStein/swift,uasys/swift,xedin/swift,devincoughlin/swift,OscarSwanros/swift,lorentey/swift,KrishMunot/swift,deyton/swift,aschwaighofer/swift,deyton/swift,gmilos/swift,kusl/swift,stephentyrone/swift,swiftix/swift.old,nathawes/swift,frootloops/swift,djwbrown/swift,felix91gr/swift,tinysun212/swift-windows,JGiola/swift,modocache/swift,stephentyrone/swift,natecook1000/swift,natecook1000/swift,practicalswift/swift,hughbe/swift,austinzheng/swift,shajrawi/swift,JGiola/swift,jtbandes/swift,felix91gr/swift,tjw/swift,calebd/swift,jmgc/swift,Jnosh/swift,kentya6/swift,LeoShimonaka/swift,lorentey/swift,manavgabhawala/swift,kstaring/swift,ahoppen/swift,slavapestov/swift,ken0nek/swift,shajrawi/swift,milseman/swift,Ivacker/swift,rudkx/swift,OscarSwanros/swift,practicalswift/swift,harlanhaskins/swift,Ivacker/swift,calebd/swift,jmgc/swift,zisko/swift,djwbrown/swift,gribozavr/swift,Jnosh/swift,jmgc/swift,lorentey/swift,gmilos/swift,gregomni/swift,swiftix/swift,emilstahl/swift,sdulal/swift,codestergit/swift,CodaFi/swift,adrfer/swift,nathawes/swift,aschwaighofer/swift,aschwaighofer/swift,roambotics/swift,tjw/swift,sschiau/swift,MukeshKumarS/Swift,harlanhaskins/swift,huonw/swift,apple/swift,emilstahl/swift,felix91gr/swift,jtbandes/swift,kentya6/swift,jopamer/swift,tjw/swift,gribozavr/swift,kstaring/swift,mightydeveloper/swift,manavgabhawala/swift,dduan/swift,mightydeveloper/swift,parkera/swift,karwa/swift,dduan/swift,tkremenek/swift,slavapestov/swift,johnno1962d/swift,gribozavr/swift,gottesmm/swift,therealbnut/swift,zisko/swift,arvedviehweger/swift,nathawes/swift,JaSpa/swift,deyton/swift,emilstahl/swift,khizkhiz/swift,frootloops/swift,hughbe/swift,roambotics/swift,xedin/swift,felix91gr/swift,milseman/swift,adrfer/swift,shajrawi/swift,sschiau/swift,tinysun212/swift-windows,jopamer/swift,kperryua/swift,JaSpa/swift,aschwaighofer/swift,parkera/swift,gmilos/swift,tinysun212/swift-windows,tinysun212/swift-windows,xwu/swift,adrfer/swift,SwiftAndroid/swift,milseman/swift,tardieu/swift,gmilos/swift,cbrentharris/swift,danielmartin/swift,bitjammer/swift,airspeedswift/swift,swiftix/swift.old,austinzheng/swift,codestergit/swift,Ivacker/swift,ahoppen/swift,shahmishal/swift,CodaFi/swift,gottesmm/swift,JGiola/swift,swiftix/swift,tkremenek/swift,LeoShimonaka/swift,frootloops/swift,johnno1962d/swift,xedin/swift,alblue/swift,johnno1962d/swift,tkremenek/swift,sschiau/swift,airspeedswift/swift,deyton/swift,apple/swift,practicalswift/swift,kentya6/swift,xwu/swift,JaSpa/swift,kperryua/swift,hooman/swift,swiftix/swift,danielmartin/swift,johnno1962d/swift,xwu/swift,devincoughlin/swift,ahoppen/swift,natecook1000/swift,aschwaighofer/swift,bitjammer/swift,KrishMunot/swift,karwa/swift,hooman/swift,modocache/swift,tardieu/swift,russbishop/swift,apple/swift,hughbe/swift,alblue/swift,nathawes/swift,alblue/swift,tardieu/swift,dreamsxin/swift,shahmishal/swift,jtbandes/swift,emilstahl/swift,zisko/swift,airspeedswift/swift,allevato/swift,tkremenek/swift,sschiau/swift,hughbe/swift,danielmartin/swift,milseman/swift,frootloops/swift