pg_recvlogical.c code review.
pg_recvlogical.c code review.

Several comments still referred to 'initiating', 'freeing', 'stopping'
replication slots. These were terms used during different phases of
the development of logical decoding, but are no long accurate.

Also rename StreamLog() to StreamLogicalLog() and add 'void' to the
prototype.

Author: Michael Paquier, with some editing by me.

Backpatch to 9.4 where pg_recvlogical was introduced.

yazun/postgres-xl,lisakowen/gpdb,ovr/postgres-xl,pavanvd/postgres-xl,Postgres-XL/Postgres-XL,oberstet/postgres-xl,xinzweb/gpdb,ovr/postgres-xl,Postgres-XL/Postgres-XL,zeroae/postgres-xl,50wu/gpdb,ovr/postgres-xl,ashwinstar/gpdb,techdragon/Postgres-XL,lisakowen/gpdb,techdragon/Postgres-XL,techdragon/Postgres-XL,50wu/gpdb,jmcatamney/gpdb,greenplum-db/gpdb,greenplum-db/gpdb,greenplum-db/gpdb,yazun/postgres-xl,zeroae/postgres-xl,50wu/gpdb,zeroae/postgres-xl,Postgres-XL/Postgres-XL,xinzweb/gpdb,pavanvd/postgres-xl,oberstet/postgres-xl,50wu/gpdb,oberstet/postgres-xl,oberstet/postgres-xl,xinzweb/gpdb,zeroae/postgres-xl,adam8157/gpdb,yazun/postgres-xl,yazun/postgres-xl,jmcatamney/gpdb,Postgres-XL/Postgres-XL,50wu/gpdb,jmcatamney/gpdb,ashwinstar/gpdb,ashwinstar/gpdb,50wu/gpdb,adam8157/gpdb,xinzweb/gpdb,greenplum-db/gpdb,adam8157/gpdb,pavanvd/postgres-xl,50wu/gpdb,ovr/postgres-xl,lisakowen/gpdb,techdragon/Postgres-XL,adam8157/gpdb,xinzweb/gpdb,lisakowen/gpdb,jmcatamney/gpdb,adam8157/gpdb,xinzweb/gpdb,ashwinstar/gpdb,ashwinstar/gpdb,lisakowen/gpdb,xinzweb/gpdb,oberstet/postgres-xl,yazun/postgres-xl,adam8157/gpdb,Postgres-XL/Postgres-XL,ashwinstar/gpdb,greenplum-db/gpdb,jmcatamney/gpdb,ashwinstar/gpdb,adam8157/gpdb,pavanvd/postgres-xl,xinzweb/gpdb,techdragon/Postgres-XL,lisakowen/gpdb,jmcatamney/gpdb,jmcatamney/gpdb,ovr/postgres-xl,lisakowen/gpdb,adam8157/gpdb,zeroae/postgres-xl,greenplum-db/gpdb,greenplum-db/gpdb,greenplum-db/gpdb,pavanvd/postgres-xl,lisakowen/gpdb,50wu/gpdb,jmcatamney/gpdb,ashwinstar/gpdb