Alternate way to improve suggestions after a failed build
Alternate way to improve suggestions after a failed build

Summary:
A previous patch got this effect by removing `.*?class file for ([\\w\\.\\*]*) not found` from the list of regexes used to scrape `stderr`. This could have broken suggestions on some legitimate "cases where you get class file not found messages that will be genuine build breaks. (I think one such case is if you depend on class Foo from module A, where Foo is a subclass of Bar in module B, and you remove the dep on module B.)"

Instead, this diff just ignores compiler warnings and only scrapes compiler error lines.

Test Plan:
Commented out a target in a `BUCK` file.

 * //With// this change, `buck` just suggests that I put back what I zapped.
 * //Without// it (but with the revert copy-and-pasted in), `buck` also makes a spurious suggestion.

Reviewed By: Coneko

fbshipit-source-id: dc29102

rmaz/buck,zhan-xiong/buck,illicitonion/buck,brettwooldridge/buck,justinmuller/buck,grumpyjames/buck,ilya-klyuchnikov/buck,sdwilsh/buck,nguyentruongtho/buck,clonetwin26/buck,vschs007/buck,grumpyjames/buck,marcinkwiatkowski/buck,Addepar/buck,romanoid/buck,grumpyjames/buck,zpao/buck,illicitonion/buck,shs96c/buck,JoelMarcey/buck,rmaz/buck,grumpyjames/buck,rmaz/buck,romanoid/buck,ilya-klyuchnikov/buck,shs96c/buck,brettwooldridge/buck,robbertvanginkel/buck,dsyang/buck,Addepar/buck,shs96c/buck,ilya-klyuchnikov/buck,brettwooldridge/buck,zhan-xiong/buck,sdwilsh/buck,JoelMarcey/buck,k21/buck,sdwilsh/buck,LegNeato/buck,romanoid/buck,robbertvanginkel/buck,grumpyjames/buck,ilya-klyuchnikov/buck,shybovycha/buck,davido/buck,k21/buck,sdwilsh/buck,rmaz/buck,shybovycha/buck,zhan-xiong/buck,robbertvanginkel/buck,k21/buck,rmaz/buck,Addepar/buck,grumpyjames/buck,daedric/buck,rmaz/buck,zpao/buck,ilya-klyuchnikov/buck,justinmuller/buck,ilya-klyuchnikov/buck,davido/buck,darkforestzero/buck,SeleniumHQ/buck,rmaz/buck,clonetwin26/buck,SeleniumHQ/buck,clonetwin26/buck,brettwooldridge/buck,zhan-xiong/buck,vschs007/buck,shybovycha/buck,davido/buck,justinmuller/buck,JoelMarcey/buck,davido/buck,marcinkwiatkowski/buck,marcinkwiatkowski/buck,zhan-xiong/buck,SeleniumHQ/buck,shs96c/buck,robbertvanginkel/buck,zhan-xiong/buck,robbertvanginkel/buck,darkforestzero/buck,LegNeato/buck,brettwooldridge/buck,k21/buck,LegNeato/buck,kageiit/buck,davido/buck,romanoid/buck,sdwilsh/buck,kageiit/buck,rmaz/buck,JoelMarcey/buck,Addepar/buck,marcinkwiatkowski/buck,nguyentruongtho/buck,clonetwin26/buck,rmaz/buck,justinmuller/buck,ilya-klyuchnikov/buck,grumpyjames/buck,vschs007/buck,shybovycha/buck,k21/buck,vschs007/buck,romanoid/buck,facebook/buck,facebook/buck,shs96c/buck,zhan-xiong/buck,dsyang/buck,k21/buck,LegNeato/buck,LegNeato/buck,zpao/buck,dsyang/buck,sdwilsh/buck,kageiit/buck,SeleniumHQ/buck,romanoid/buck,shs96c/buck,marcinkwiatkowski/buck,shybovycha/buck,vschs007/buck,vschs007/buck,illicitonion/buck,darkforestzero/buck,dsyang/buck,vschs007/buck,brettwooldridge/buck,marcinkwiatkowski/buck,zhan-xiong/buck,daedric/buck,sdwilsh/buck,davido/buck,LegNeato/buck,shybovycha/buck,shs96c/buck,clonetwin26/buck,justinmuller/buck,davido/buck,kageiit/buck,justinmuller/buck,justinmuller/buck,shybovycha/buck,justinmuller/buck,illicitonion/buck,ilya-klyuchnikov/buck,justinmuller/buck,zpao/buck,brettwooldridge/buck,justinmuller/buck,illicitonion/buck,k21/buck,darkforestzero/buck,k21/buck,k21/buck,daedric/buck,brettwooldridge/buck,darkforestzero/buck,romanoid/buck,robbertvanginkel/buck,facebook/buck,marcinkwiatkowski/buck,daedric/buck,shybovycha/buck,SeleniumHQ/buck,marcinkwiatkowski/buck,facebook/buck,facebook/buck,JoelMarcey/buck,vschs007/buck,LegNeato/buck,daedric/buck,dsyang/buck,kageiit/buck,clonetwin26/buck,SeleniumHQ/buck,sdwilsh/buck,daedric/buck,shs96c/buck,dsyang/buck,dsyang/buck,romanoid/buck,JoelMarcey/buck,illicitonion/buck,davido/buck,Addepar/buck,clonetwin26/buck,illicitonion/buck,kageiit/buck,zhan-xiong/buck,shs96c/buck,SeleniumHQ/buck,illicitonion/buck,zpao/buck,romanoid/buck,k21/buck,dsyang/buck,darkforestzero/buck,clonetwin26/buck,Addepar/buck,daedric/buck,JoelMarcey/buck,justinmuller/buck,sdwilsh/buck,marcinkwiatkowski/buck,sdwilsh/buck,sdwilsh/buck,brettwooldridge/buck,LegNeato/buck,illicitonion/buck,Addepar/buck,facebook/buck,dsyang/buck,nguyentruongtho/buck,darkforestzero/buck,robbertvanginkel/buck,robbertvanginkel/buck,justinmuller/buck,zhan-xiong/buck,shs96c/buck,clonetwin26/buck,zpao/buck,dsyang/buck,rmaz/buck,Addepar/buck,rmaz/buck,SeleniumHQ/buck,k21/buck,daedric/buck,SeleniumHQ/buck,Addepar/buck,zpao/buck,dsyang/buck,clonetwin26/buck,k21/buck,brettwooldridge/buck,vschs007/buck,illicitonion/buck,robbertvanginkel/buck,SeleniumHQ/buck,shs96c/buck,grumpyjames/buck,robbertvanginkel/buck,darkforestzero/buck,shybovycha/buck,grumpyjames/buck,justinmuller/buck,darkforestzero/buck,daedric/buck,darkforestzero/buck,marcinkwiatkowski/buck,darkforestzero/buck,clonetwin26/buck,darkforestzero/buck,grumpyjames/buck,SeleniumHQ/buck,shybovycha/buck,shs96c/buck,marcinkwiatkowski/buck,sdwilsh/buck,zhan-xiong/buck,LegNeato/buck,vschs007/buck,nguyentruongtho/buck,SeleniumHQ/buck,JoelMarcey/buck,grumpyjames/buck,ilya-klyuchnikov/buck,shybovycha/buck,zhan-xiong/buck,facebook/buck,nguyentruongtho/buck,zhan-xiong/buck,JoelMarcey/buck,daedric/buck,romanoid/buck,LegNeato/buck,illicitonion/buck,marcinkwiatkowski/buck,vschs007/buck,Addepar/buck,rmaz/buck,k21/buck,romanoid/buck,LegNeato/buck,davido/buck,vschs007/buck,rmaz/buck,kageiit/buck,romanoid/buck,daedric/buck,clonetwin26/buck,grumpyjames/buck,robbertvanginkel/buck,davido/buck,dsyang/buck,JoelMarcey/buck,ilya-klyuchnikov/buck,Addepar/buck,Addepar/buck,robbertvanginkel/buck,nguyentruongtho/buck,ilya-klyuchnikov/buck,shybovycha/buck,brettwooldridge/buck,daedric/buck,vschs007/buck,ilya-klyuchnikov/buck,davido/buck,LegNeato/buck,nguyentruongtho/buck,clonetwin26/buck,dsyang/buck,JoelMarcey/buck,JoelMarcey/buck,romanoid/buck,robbertvanginkel/buck,daedric/buck,ilya-klyuchnikov/buck,marcinkwiatkowski/buck,illicitonion/buck,brettwooldridge/buck,illicitonion/buck,brettwooldridge/buck,LegNeato/buck,sdwilsh/buck,shybovycha/buck,davido/buck,SeleniumHQ/buck,JoelMarcey/buck,darkforestzero/buck,davido/buck,Addepar/buck,shs96c/buck