tests/resource/aws_security_group: Add attribute checks for all static rule TypeSet and some minor refactoring
tests/resource/aws_security_group: Add attribute checks for all static rule TypeSet and some minor refactoring

* Add resource attribute checks for all static rules (e.g. non `prefix_list`/`security_groups`) to help ensure upgrade compatibility
* Parameterize `testAccAWSSecurityGroupConfigRuleDescription` to reduce duplication
* Remove extraneous rule configurations from `testAccAWSSecurityGroupConfig_generatedName`
* Remove extraneous rule configurations from `testAccAWSSecurityGroupConfigTags`
* Remove extraneous ingress rule configuration from `testAccAWSSecurityGroupConfigIpv4andIpv6Egress`
* Remove `TestAccAWSSecurityGroup_tagsCreatedFirst` and its configuration (`testAccAWSSecurityGroupConfigForTagsOrdering`) as the `TestStep` with both `ExpectError` and `Check` was invalid -- we don't really need to check that the EC2 API returns `InvalidParameterValue` when you set a port to 80000
* Remove `TestAccAWSSecurityGroup_emptyRuleDescription` and move its configuration into `TestAccAWSSecurityGroup_RuleDescription` (equivalent testing)
* Ensure `TestAccAWSSecurityGroup_DefaultEgress_Classic` is properly setup for us-east-1 EC2 Classic testing and skipping when EC2 Classic is not available
* Ensure `TestAccAWSSecurityGroup_ingressWithCidrAndSGs_classic` is properly setup for us-east-1 EC2 Classic testing and skipping when EC2 Classic is not available

make testacc TEST=./aws TESTARGS='-run=TestAccAWSSecurityGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSecurityGroup_ -timeout 120m
=== RUN   TestAccAWSSecurityGroup_importBasic
--- PASS: TestAccAWSSecurityGroup_importBasic (30.33s)
=== RUN   TestAccAWSSecurityGroup_importIpv6
--- PASS: TestAccAWSSecurityGroup_importIpv6 (29.08s)
=== RUN   TestAccAWSSecurityGroup_importSelf
--- PASS: TestAccAWSSecurityGroup_importSelf (33.26s)
=== RUN   TestAccAWSSecurityGroup_importSourceSecurityGroup
--- PASS: TestAccAWSSecurityGroup_importSourceSecurityGroup (31.35s)
=== RUN   TestAccAWSSecurityGroup_importIPRangeAndSecurityGroupWithSameRules
--- PASS: TestAccAWSSecurityGroup_importIPRangeAndSecurityGroupWithSameRules (36.13s)
=== RUN   TestAccAWSSecurityGroup_importIPRangesWithSameRules
--- PASS: TestAccAWSSecurityGroup_importIPRangesWithSameRules (33.34s)
=== RUN   TestAccAWSSecurityGroup_importPrefixList
--- PASS: TestAccAWSSecurityGroup_importPrefixList (46.93s)
=== RUN   TestAccAWSSecurityGroup_basic
--- PASS: TestAccAWSSecurityGroup_basic (27.46s)
=== RUN   TestAccAWSSecurityGroup_ruleGathering
--- PASS: TestAccAWSSecurityGroup_ruleGathering (48.97s)
=== RUN   TestAccAWSSecurityGroup_forceRevokeRules_true
--- PASS: TestAccAWSSecurityGroup_forceRevokeRules_true (698.66s)
=== RUN   TestAccAWSSecurityGroup_forceRevokeRules_false
--- PASS: TestAccAWSSecurityGroup_forceRevokeRules_false (666.67s)
=== RUN   TestAccAWSSecurityGroup_ipv6
--- PASS: TestAccAWSSecurityGroup_ipv6 (27.73s)
=== RUN   TestAccAWSSecurityGroup_namePrefix
--- PASS: TestAccAWSSecurityGroup_namePrefix (7.49s)
=== RUN   TestAccAWSSecurityGroup_self
--- PASS: TestAccAWSSecurityGroup_self (27.18s)
=== RUN   TestAccAWSSecurityGroup_vpc
--- PASS: TestAccAWSSecurityGroup_vpc (28.61s)
=== RUN   TestAccAWSSecurityGroup_vpcNegOneIngress
--- PASS: TestAccAWSSecurityGroup_vpcNegOneIngress (26.51s)
=== RUN   TestAccAWSSecurityGroup_vpcProtoNumIngress
--- PASS: TestAccAWSSecurityGroup_vpcProtoNumIngress (26.93s)
=== RUN   TestAccAWSSecurityGroup_MultiIngress
--- PASS: TestAccAWSSecurityGroup_MultiIngress (33.40s)
=== RUN   TestAccAWSSecurityGroup_Change
--- PASS: TestAccAWSSecurityGroup_Change (49.74s)
=== RUN   TestAccAWSSecurityGroup_RuleDescription
--- PASS: TestAccAWSSecurityGroup_RuleDescription (68.86s)
=== RUN   TestAccAWSSecurityGroup_generatedName
--- PASS: TestAccAWSSecurityGroup_generatedName (28.78s)
=== RUN   TestAccAWSSecurityGroup_DefaultEgress_VPC
--- PASS: TestAccAWSSecurityGroup_DefaultEgress_VPC (27.02s)
=== RUN   TestAccAWSSecurityGroup_DefaultEgress_Classic
--- PASS: TestAccAWSSecurityGroup_DefaultEgress_Classic (5.44s)
=== RUN   TestAccAWSSecurityGroup_drift
--- PASS: TestAccAWSSecurityGroup_drift (13.76s)
=== RUN   TestAccAWSSecurityGroup_drift_complex
--- PASS: TestAccAWSSecurityGroup_drift_complex (33.12s)
=== RUN   TestAccAWSSecurityGroup_invalidCIDRBlock
--- PASS: TestAccAWSSecurityGroup_invalidCIDRBlock (0.94s)
=== RUN   TestAccAWSSecurityGroup_tags
--- PASS: TestAccAWSSecurityGroup_tags (41.58s)
=== RUN   TestAccAWSSecurityGroup_CIDRandGroups
--- PASS: TestAccAWSSecurityGroup_CIDRandGroups (33.62s)
=== RUN   TestAccAWSSecurityGroup_ingressWithCidrAndSGs
--- PASS: TestAccAWSSecurityGroup_ingressWithCidrAndSGs (32.58s)
=== RUN   TestAccAWSSecurityGroup_ingressWithCidrAndSGs_classic
--- PASS: TestAccAWSSecurityGroup_ingressWithCidrAndSGs_classic (14.68s)
=== RUN   TestAccAWSSecurityGroup_egressWithPrefixList
--- PASS: TestAccAWSSecurityGroup_egressWithPrefixList (52.57s)
=== RUN   TestAccAWSSecurityGroup_ipv4andipv6Egress
--- PASS: TestAccAWSSecurityGroup_ipv4andipv6Egress (28.46s)
=== RUN   TestAccAWSSecurityGroup_failWithDiffMismatch
--- PASS: TestAccAWSSecurityGroup_failWithDiffMismatch (32.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2323.283s

Ninir/terraform-provider-aws,kjmkznr/terraform-provider-aws,terraform-providers/terraform-provider-aws,terraform-providers/terraform-provider-aws,kjmkznr/terraform-provider-aws,terraform-providers/terraform-provider-aws,Ninir/terraform-provider-aws,nbaztec/terraform-provider-aws,nbaztec/terraform-provider-aws,terraform-providers/terraform-provider-aws,Ninir/terraform-provider-aws,kjmkznr/terraform-provider-aws,nbaztec/terraform-provider-aws,Ninir/terraform-provider-aws,nbaztec/terraform-provider-aws,kjmkznr/terraform-provider-aws