improve our computation of 'let'ness of self decls to know that 'self' on a value type should be immutable when it isn't lowered to an lvalue.  Right now, it is always lowered to an lvalue, so NFC.
improve our computation of 'let'ness of self decls to know that
'self' on a value type should be immutable when it isn't lowered
to an lvalue.  Right now, it is always lowered to an lvalue, so
NFC.


Swift SVN r11287

practicalswift/swift,parkera/swift,emilstahl/swift,benlangmuir/swift,russbishop/swift,jmgc/swift,sschiau/swift,rudkx/swift,shahmishal/swift,felix91gr/swift,JaSpa/swift,cbrentharris/swift,shajrawi/swift,allevato/swift,emilstahl/swift,khizkhiz/swift,tjw/swift,JGiola/swift,ken0nek/swift,xwu/swift,JGiola/swift,kstaring/swift,parkera/swift,dduan/swift,hughbe/swift,emilstahl/swift,rudkx/swift,LeoShimonaka/swift,zisko/swift,LeoShimonaka/swift,kentya6/swift,uasys/swift,xedin/swift,therealbnut/swift,hughbe/swift,parkera/swift,OscarSwanros/swift,tardieu/swift,CodaFi/swift,devincoughlin/swift,jtbandes/swift,brentdax/swift,dduan/swift,gmilos/swift,hughbe/swift,aschwaighofer/swift,nathawes/swift,ahoppen/swift,atrick/swift,JGiola/swift,karwa/swift,xwu/swift,gregomni/swift,hughbe/swift,LeoShimonaka/swift,frootloops/swift,Jnosh/swift,dduan/swift,kentya6/swift,russbishop/swift,sschiau/swift,hughbe/swift,SwiftAndroid/swift,arvedviehweger/swift,codestergit/swift,tjw/swift,slavapestov/swift,natecook1000/swift,gribozavr/swift,shajrawi/swift,nathawes/swift,therealbnut/swift,slavapestov/swift,tardieu/swift,jtbandes/swift,MukeshKumarS/Swift,OscarSwanros/swift,xwu/swift,alblue/swift,jtbandes/swift,Jnosh/swift,parkera/swift,codestergit/swift,ken0nek/swift,johnno1962d/swift,shahmishal/swift,amraboelela/swift,benlangmuir/swift,djwbrown/swift,sschiau/swift,JGiola/swift,tinysun212/swift-windows,MukeshKumarS/Swift,kstaring/swift,tardieu/swift,adrfer/swift,ben-ng/swift,gottesmm/swift,lorentey/swift,tjw/swift,harlanhaskins/swift,allevato/swift,huonw/swift,shahmishal/swift,calebd/swift,deyton/swift,jtbandes/swift,roambotics/swift,amraboelela/swift,parkera/swift,nathawes/swift,glessard/swift,natecook1000/swift,johnno1962d/swift,harlanhaskins/swift,ben-ng/swift,tjw/swift,manavgabhawala/swift,jmgc/swift,JaSpa/swift,karwa/swift,modocache/swift,CodaFi/swift,emilstahl/swift,glessard/swift,airspeedswift/swift,brentdax/swift,felix91gr/swift,deyton/swift,frootloops/swift,sdulal/swift,sdulal/swift,ben-ng/swift,OscarSwanros/swift,adrfer/swift,SwiftAndroid/swift,karwa/swift,ken0nek/swift,johnno1962d/swift,MukeshKumarS/Swift,KrishMunot/swift,JaSpa/swift,arvedviehweger/swift,kusl/swift,nathawes/swift,benlangmuir/swift,jopamer/swift,aschwaighofer/swift,dduan/swift,jtbandes/swift,huonw/swift,xedin/swift,SwiftAndroid/swift,danielmartin/swift,manavgabhawala/swift,tinysun212/swift-windows,bitjammer/swift,codestergit/swift,therealbnut/swift,devincoughlin/swift,apple/swift,gribozavr/swift,harlanhaskins/swift,jmgc/swift,KrishMunot/swift,practicalswift/swift,russbishop/swift,lorentey/swift,kusl/swift,lorentey/swift,uasys/swift,kusl/swift,codestergit/swift,roambotics/swift,LeoShimonaka/swift,jckarter/swift,brentdax/swift,modocache/swift,gottesmm/swift,MukeshKumarS/Swift,milseman/swift,kstaring/swift,return/swift,xedin/swift,sschiau/swift,arvedviehweger/swift,arvedviehweger/swift,tkremenek/swift,adrfer/swift,dreamsxin/swift,dduan/swift,practicalswift/swift,bitjammer/swift,ken0nek/swift,shajrawi/swift,KrishMunot/swift,ken0nek/swift,return/swift,devincoughlin/swift,modocache/swift,bitjammer/swift,austinzheng/swift,alblue/swift,Ivacker/swift,shahmishal/swift,atrick/swift,lorentey/swift,jopamer/swift,ahoppen/swift,apple/swift,jmgc/swift,zisko/swift,natecook1000/swift,tardieu/swift,KrishMunot/swift,MukeshKumarS/Swift,CodaFi/swift,tardieu/swift,SwiftAndroid/swift,xwu/swift,milseman/swift,karwa/swift,airspeedswift/swift,khizkhiz/swift,harlanhaskins/swift,emilstahl/swift,aschwaighofer/swift,ben-ng/swift,hooman/swift,mightydeveloper/swift,tjw/swift,jmgc/swift,Jnosh/swift,shajrawi/swift,xwu/swift,alblue/swift,milseman/swift,uasys/swift,amraboelela/swift,djwbrown/swift,huonw/swift,LeoShimonaka/swift,swiftix/swift.old,devincoughlin/swift,kstaring/swift,therealbnut/swift,cbrentharris/swift,frootloops/swift,gregomni/swift,glessard/swift,zisko/swift,practicalswift/swift,glessard/swift,kentya6/swift,return/swift,khizkhiz/swift,calebd/swift,amraboelela/swift,swiftix/swift,harlanhaskins/swift,sschiau/swift,calebd/swift,jopamer/swift,therealbnut/swift,lorentey/swift,felix91gr/swift,djwbrown/swift,dduan/swift,rudkx/swift,gregomni/swift,gregomni/swift,swiftix/swift,allevato/swift,hughbe/swift,gregomni/swift,tkremenek/swift,roambotics/swift,russbishop/swift,xwu/swift,mightydeveloper/swift,SwiftAndroid/swift,khizkhiz/swift,airspeedswift/swift,amraboelela/swift,Jnosh/swift,therealbnut/swift,swiftix/swift.old,swiftix/swift,mightydeveloper/swift,Jnosh/swift,zisko/swift,codestergit/swift,kentya6/swift,IngmarStein/swift,glessard/swift,swiftix/swift.old,brentdax/swift,milseman/swift,OscarSwanros/swift,djwbrown/swift,lorentey/swift,calebd/swift,apple/swift,nathawes/swift,mightydeveloper/swift,kperryua/swift,brentdax/swift,jopamer/swift,huonw/swift,austinzheng/swift,kentya6/swift,gmilos/swift,practicalswift/swift,devincoughlin/swift,slavapestov/swift,alblue/swift,cbrentharris/swift,SwiftAndroid/swift,danielmartin/swift,Ivacker/swift,tkremenek/swift,IngmarStein/swift,allevato/swift,ben-ng/swift,codestergit/swift,stephentyrone/swift,bitjammer/swift,tinysun212/swift-windows,devincoughlin/swift,airspeedswift/swift,felix91gr/swift,manavgabhawala/swift,karwa/swift,dreamsxin/swift,huonw/swift,kusl/swift,JaSpa/swift,stephentyrone/swift,tkremenek/swift,jmgc/swift,frootloops/swift,tjw/swift,therealbnut/swift,shajrawi/swift,russbishop/swift,gottesmm/swift,IngmarStein/swift,milseman/swift,LeoShimonaka/swift,uasys/swift,CodaFi/swift,kusl/swift,cbrentharris/swift,LeoShimonaka/swift,KrishMunot/swift,aschwaighofer/swift,Jnosh/swift,Ivacker/swift,gmilos/swift,aschwaighofer/swift,jtbandes/swift,rudkx/swift,kusl/swift,stephentyrone/swift,kentya6/swift,Jnosh/swift,stephentyrone/swift,shahmishal/swift,russbishop/swift,kstaring/swift,apple/swift,arvedviehweger/swift,natecook1000/swift,cbrentharris/swift,lorentey/swift,nathawes/swift,sdulal/swift,ben-ng/swift,sdulal/swift,Ivacker/swift,sschiau/swift,nathawes/swift,IngmarStein/swift,austinzheng/swift,swiftix/swift,tinysun212/swift-windows,milseman/swift,allevato/swift,OscarSwanros/swift,aschwaighofer/swift,hooman/swift,tkremenek/swift,kperryua/swift,emilstahl/swift,adrfer/swift,johnno1962d/swift,danielmartin/swift,khizkhiz/swift,atrick/swift,swiftix/swift.old,deyton/swift,russbishop/swift,modocache/swift,tinysun212/swift-windows,arvedviehweger/swift,amraboelela/swift,rudkx/swift,tardieu/swift,atrick/swift,roambotics/swift,shahmishal/swift,hooman/swift,IngmarStein/swift,jckarter/swift,JaSpa/swift,Ivacker/swift,ahoppen/swift,airspeedswift/swift,benlangmuir/swift,arvedviehweger/swift,harlanhaskins/swift,jckarter/swift,mightydeveloper/swift,adrfer/swift,gribozavr/swift,johnno1962d/swift,MukeshKumarS/Swift,benlangmuir/swift,mightydeveloper/swift,practicalswift/swift,return/swift,deyton/swift,gmilos/swift,emilstahl/swift,roambotics/swift,airspeedswift/swift,practicalswift/swift,kentya6/swift,codestergit/swift,amraboelela/swift,CodaFi/swift,allevato/swift,sschiau/swift,slavapestov/swift,gmilos/swift,Ivacker/swift,allevato/swift,kperryua/swift,gribozavr/swift,brentdax/swift,gribozavr/swift,calebd/swift,austinzheng/swift,kentya6/swift,bitjammer/swift,frootloops/swift,aschwaighofer/swift,huonw/swift,alblue/swift,return/swift,swiftix/swift,cbrentharris/swift,tkremenek/swift,sdulal/swift,johnno1962d/swift,kstaring/swift,ken0nek/swift,kperryua/swift,adrfer/swift,lorentey/swift,zisko/swift,danielmartin/swift,gottesmm/swift,zisko/swift,hooman/swift,manavgabhawala/swift,manavgabhawala/swift,kstaring/swift,OscarSwanros/swift,jckarter/swift,jopamer/swift,jopamer/swift,gribozavr/swift,shahmishal/swift,JaSpa/swift,hooman/swift,khizkhiz/swift,tkremenek/swift,IngmarStein/swift,ben-ng/swift,manavgabhawala/swift,SwiftAndroid/swift,manavgabhawala/swift,apple/swift,parkera/swift,bitjammer/swift,jopamer/swift,slavapestov/swift,KrishMunot/swift,kusl/swift,tjw/swift,johnno1962d/swift,shahmishal/swift,tardieu/swift,atrick/swift,xedin/swift,karwa/swift,IngmarStein/swift,milseman/swift,kperryua/swift,kusl/swift,benlangmuir/swift,karwa/swift,jckarter/swift,swiftix/swift,tinysun212/swift-windows,tinysun212/swift-windows,jckarter/swift,stephentyrone/swift,felix91gr/swift,swiftix/swift,uasys/swift,shajrawi/swift,hughbe/swift,danielmartin/swift,frootloops/swift,modocache/swift,deyton/swift,ahoppen/swift,gregomni/swift,OscarSwanros/swift,gottesmm/swift,kperryua/swift,parkera/swift,hooman/swift,sdulal/swift,gmilos/swift,devincoughlin/swift,gribozavr/swift,deyton/swift,slavapestov/swift,swiftix/swift.old,gmilos/swift,uasys/swift,xedin/swift,swiftix/swift.old,xedin/swift,CodaFi/swift,austinzheng/swift,sdulal/swift,gottesmm/swift,ken0nek/swift,zisko/swift,sdulal/swift,natecook1000/swift,CodaFi/swift,devincoughlin/swift,austinzheng/swift,jckarter/swift,natecook1000/swift,brentdax/swift,cbrentharris/swift,huonw/swift,emilstahl/swift,return/swift,danielmartin/swift,stephentyrone/swift,karwa/swift,djwbrown/swift,austinzheng/swift,sschiau/swift,MukeshKumarS/Swift,parkera/swift,LeoShimonaka/swift,atrick/swift,xedin/swift,rudkx/swift,bitjammer/swift,jtbandes/swift,calebd/swift,kperryua/swift,dduan/swift,calebd/swift,modocache/swift,harlanhaskins/swift,return/swift,shajrawi/swift,xwu/swift,shajrawi/swift,danielmartin/swift,stephentyrone/swift,hooman/swift,mightydeveloper/swift,frootloops/swift,xedin/swift,roambotics/swift,JGiola/swift,deyton/swift,ahoppen/swift,alblue/swift,khizkhiz/swift,practicalswift/swift,JGiola/swift,cbrentharris/swift,JaSpa/swift,slavapestov/swift,modocache/swift,uasys/swift,Ivacker/swift,glessard/swift,airspeedswift/swift,ahoppen/swift,Ivacker/swift,gottesmm/swift,swiftix/swift.old,felix91gr/swift,felix91gr/swift,djwbrown/swift,natecook1000/swift,jmgc/swift,apple/swift,alblue/swift,adrfer/swift,swiftix/swift.old,gribozavr/swift,mightydeveloper/swift,KrishMunot/swift,djwbrown/swift