Simplify AssemblyName creation (#7578)
Simplify AssemblyName creation (#7578)

The S.R.M version didn't include PublicKeyToken, apparently because it isn't part of the metadata.

Fixes internally reported issue

Context
PublicKey was being added to an AssemblyName but not PublicKeyToken. When cloning the AssemblyName, it tried to access the token and failed, throwing an error. The particular case was in trying to figure out an appropriate binding redirect. An assembly had version x and y with x > y. y was primary, and it decided to make x primary after deciding it should unify on x. That led it to clone the AssemblyName, but the PublicKeyToken was missing.

Changes Made
Create full AssemblyName.

Testing
Reran the repro with this version of MSBuild, and the issue no longer reproduces.
sean-gilliam/msbuild,AndyGerlicher/msbuild,rainersigwald/msbuild,AndyGerlicher/msbuild,AndyGerlicher/msbuild,sean-gilliam/msbuild,rainersigwald/msbuild,rainersigwald/msbuild,rainersigwald/msbuild,AndyGerlicher/msbuild,sean-gilliam/msbuild,sean-gilliam/msbuild