Coverity fixes for primary_mirror_mode.c
Coverity fixes for primary_mirror_mode.c

CID 129287 Buffer not null terminated. In primaryMirrorCheckNICFailure: The
string buffers `localHost` and `peerHost` may not have a null terminator if the
source string's length is equal to the buffer size. Hence use strlcpy instead to
be same.

CID 130101 Dereference before null check. In isFilespaceInfoConsistent: All
paths that lead to `primaryFilespaceLocation` null pointer comparison already
dereference the pointer earlier. Since `primaryFilespaceLocation` cannot be null
else PersistentFilespace_GetPrimaryAndMirror() will error out itself, removing
the check for null.

CID 130130 Copy into fixed size buffer. In primaryMirrorPopulateFilespaceInfo: A
source buffer `pch` of statically unknown size is copied into a fixed-size
destination buffer `peerFilespacePath`. Hence replace strcpy with strlcpy.

CID 159071 Uninitialized scalar variable. In primaryMirrorPopulateFilespaceInfo:
Use of an uninitialized variable filespacePath. Hence initialing it in else path
to empty string.

rvs/gpdb,jmcatamney/gpdb,xinzweb/gpdb,edespino/gpdb,cjcjameson/gpdb,kaknikhil/gpdb,janebeckman/gpdb,yuanzhao/gpdb,Chibin/gpdb,rvs/gpdb,yuanzhao/gpdb,ashwinstar/gpdb,lisakowen/gpdb,cjcjameson/gpdb,Quikling/gpdb,cjcjameson/gpdb,Chibin/gpdb,50wu/gpdb,lisakowen/gpdb,Quikling/gpdb,xinzweb/gpdb,edespino/gpdb,jmcatamney/gpdb,ashwinstar/gpdb,kaknikhil/gpdb,Chibin/gpdb,adam8157/gpdb,yuanzhao/gpdb,yuanzhao/gpdb,kaknikhil/gpdb,jmcatamney/gpdb,Quikling/gpdb,50wu/gpdb,rvs/gpdb,Quikling/gpdb,kaknikhil/gpdb,kaknikhil/gpdb,cjcjameson/gpdb,Chibin/gpdb,Quikling/gpdb,jmcatamney/gpdb,rvs/gpdb,yuanzhao/gpdb,rvs/gpdb,Chibin/gpdb,janebeckman/gpdb,jmcatamney/gpdb,edespino/gpdb,lisakowen/gpdb,lisakowen/gpdb,adam8157/gpdb,Chibin/gpdb,Quikling/gpdb,janebeckman/gpdb,kaknikhil/gpdb,adam8157/gpdb,rvs/gpdb,cjcjameson/gpdb,50wu/gpdb,rvs/gpdb,lisakowen/gpdb,adam8157/gpdb,janebeckman/gpdb,kaknikhil/gpdb,xinzweb/gpdb,rvs/gpdb,50wu/gpdb,xinzweb/gpdb,cjcjameson/gpdb,edespino/gpdb,jmcatamney/gpdb,yuanzhao/gpdb,xinzweb/gpdb,edespino/gpdb,edespino/gpdb,Quikling/gpdb,kaknikhil/gpdb,janebeckman/gpdb,Quikling/gpdb,ashwinstar/gpdb,ashwinstar/gpdb,edespino/gpdb,rvs/gpdb,adam8157/gpdb,adam8157/gpdb,ashwinstar/gpdb,adam8157/gpdb,edespino/gpdb,lisakowen/gpdb,Chibin/gpdb,ashwinstar/gpdb,Chibin/gpdb,xinzweb/gpdb,50wu/gpdb,lisakowen/gpdb,jmcatamney/gpdb,yuanzhao/gpdb,rvs/gpdb,edespino/gpdb,janebeckman/gpdb,50wu/gpdb,janebeckman/gpdb,janebeckman/gpdb,xinzweb/gpdb,jmcatamney/gpdb,yuanzhao/gpdb,cjcjameson/gpdb,ashwinstar/gpdb,Chibin/gpdb,greenplum-db/gpdb,yuanzhao/gpdb,greenplum-db/gpdb,kaknikhil/gpdb,greenplum-db/gpdb,Quikling/gpdb,greenplum-db/gpdb,Quikling/gpdb,cjcjameson/gpdb,janebeckman/gpdb,adam8157/gpdb,greenplum-db/gpdb,kaknikhil/gpdb,50wu/gpdb,edespino/gpdb,lisakowen/gpdb,ashwinstar/gpdb,greenplum-db/gpdb,greenplum-db/gpdb,Chibin/gpdb,cjcjameson/gpdb,greenplum-db/gpdb,50wu/gpdb,cjcjameson/gpdb,yuanzhao/gpdb,janebeckman/gpdb,xinzweb/gpdb