Here's some changes I made last night to psql's common.c (as found in 7.3.2).  It removes some code duplication and #ifdeffing, and some unstructured ugliness such as tacky breaks and an unneeded continue. Breaks up a large function into smaller functions and reduces required nesting levels, and kills a variable or two.
Here's some changes I made last night to psql's common.c (as found in
7.3.2).  It removes some code duplication and #ifdeffing, and some
unstructured ugliness such as tacky breaks and an unneeded continue.
Breaks up a large function into smaller functions and reduces required
nesting levels, and kills a variable or two.

Jeroen T. Vermeulen

ovr/postgres-xl,rvs/gpdb,0x0FFF/gpdb,rubikloud/gpdb,xinzweb/gpdb,zeroae/postgres-xl,janebeckman/gpdb,CraigHarris/gpdb,zeroae/postgres-xl,kaknikhil/gpdb,rubikloud/gpdb,chrishajas/gpdb,adam8157/gpdb,Chibin/gpdb,greenplum-db/gpdb,yuanzhao/gpdb,edespino/gpdb,lisakowen/gpdb,tangp3/gpdb,kaknikhil/gpdb,lintzc/gpdb,oberstet/postgres-xl,janebeckman/gpdb,kaknikhil/gpdb,Chibin/gpdb,techdragon/Postgres-XL,rvs/gpdb,rvs/gpdb,rvs/gpdb,ahachete/gpdb,lpetrov-pivotal/gpdb,ovr/postgres-xl,Chibin/gpdb,xinzweb/gpdb,CraigHarris/gpdb,yazun/postgres-xl,janebeckman/gpdb,atris/gpdb,Quikling/gpdb,jmcatamney/gpdb,kaknikhil/gpdb,lpetrov-pivotal/gpdb,rvs/gpdb,Quikling/gpdb,yuanzhao/gpdb,foyzur/gpdb,yuanzhao/gpdb,tangp3/gpdb,ashwinstar/gpdb,0x0FFF/gpdb,royc1/gpdb,adam8157/gpdb,randomtask1155/gpdb,cjcjameson/gpdb,CraigHarris/gpdb,Postgres-XL/Postgres-XL,techdragon/Postgres-XL,adam8157/gpdb,ahachete/gpdb,Postgres-XL/Postgres-XL,randomtask1155/gpdb,lintzc/gpdb,pavanvd/postgres-xl,edespino/gpdb,edespino/gpdb,randomtask1155/gpdb,tpostgres-projects/tPostgres,yuanzhao/gpdb,xuegang/gpdb,rvs/gpdb,yuanzhao/gpdb,lpetrov-pivotal/gpdb,janebeckman/gpdb,lisakowen/gpdb,Chibin/gpdb,snaga/postgres-xl,pavanvd/postgres-xl,edespino/gpdb,edespino/gpdb,0x0FFF/gpdb,50wu/gpdb,Quikling/gpdb,kmjungersen/PostgresXL,CraigHarris/gpdb,royc1/gpdb,xuegang/gpdb,postmind-net/postgres-xl,ashwinstar/gpdb,0x0FFF/gpdb,lpetrov-pivotal/gpdb,chrishajas/gpdb,snaga/postgres-xl,0x0FFF/gpdb,zaksoup/gpdb,rvs/gpdb,ashwinstar/gpdb,rubikloud/gpdb,0x0FFF/gpdb,kmjungersen/PostgresXL,cjcjameson/gpdb,adam8157/gpdb,oberstet/postgres-xl,arcivanov/postgres-xl,ahachete/gpdb,techdragon/Postgres-XL,arcivanov/postgres-xl,chrishajas/gpdb,lintzc/gpdb,50wu/gpdb,yazun/postgres-xl,atris/gpdb,atris/gpdb,jmcatamney/gpdb,chrishajas/gpdb,zeroae/postgres-xl,greenplum-db/gpdb,lpetrov-pivotal/gpdb,jmcatamney/gpdb,royc1/gpdb,rubikloud/gpdb,chrishajas/gpdb,CraigHarris/gpdb,Chibin/gpdb,tangp3/gpdb,cjcjameson/gpdb,xuegang/gpdb,Quikling/gpdb,Quikling/gpdb,janebeckman/gpdb,lisakowen/gpdb,lisakowen/gpdb,arcivanov/postgres-xl,pavanvd/postgres-xl,yazun/postgres-xl,CraigHarris/gpdb,50wu/gpdb,Postgres-XL/Postgres-XL,kmjungersen/PostgresXL,50wu/gpdb,greenplum-db/gpdb,techdragon/Postgres-XL,tpostgres-projects/tPostgres,zaksoup/gpdb,randomtask1155/gpdb,yuanzhao/gpdb,kmjungersen/PostgresXL,50wu/gpdb,postmind-net/postgres-xl,rubikloud/gpdb,oberstet/postgres-xl,pavanvd/postgres-xl,atris/gpdb,lisakowen/gpdb,Postgres-XL/Postgres-XL,royc1/gpdb,rubikloud/gpdb,cjcjameson/gpdb,foyzur/gpdb,rvs/gpdb,yuanzhao/gpdb,xuegang/gpdb,rvs/gpdb,ashwinstar/gpdb,xuegang/gpdb,janebeckman/gpdb,xinzweb/gpdb,xuegang/gpdb,edespino/gpdb,CraigHarris/gpdb,janebeckman/gpdb,greenplum-db/gpdb,Chibin/gpdb,Postgres-XL/Postgres-XL,Chibin/gpdb,rvs/gpdb,atris/gpdb,zeroae/postgres-xl,rubikloud/gpdb,arcivanov/postgres-xl,lpetrov-pivotal/gpdb,snaga/postgres-xl,xinzweb/gpdb,Quikling/gpdb,snaga/postgres-xl,chrishajas/gpdb,lintzc/gpdb,kmjungersen/PostgresXL,CraigHarris/gpdb,0x0FFF/gpdb,techdragon/Postgres-XL,lintzc/gpdb,tpostgres-projects/tPostgres,chrishajas/gpdb,ovr/postgres-xl,randomtask1155/gpdb,50wu/gpdb,xinzweb/gpdb,edespino/gpdb,tangp3/gpdb,tangp3/gpdb,randomtask1155/gpdb,foyzur/gpdb,cjcjameson/gpdb,foyzur/gpdb,Chibin/gpdb,lpetrov-pivotal/gpdb,ovr/postgres-xl,royc1/gpdb,CraigHarris/gpdb,ahachete/gpdb,postmind-net/postgres-xl,jmcatamney/gpdb,pavanvd/postgres-xl,50wu/gpdb,kaknikhil/gpdb,zaksoup/gpdb,tangp3/gpdb,adam8157/gpdb,kaknikhil/gpdb,snaga/postgres-xl,ashwinstar/gpdb,randomtask1155/gpdb,zeroae/postgres-xl,yazun/postgres-xl,edespino/gpdb,edespino/gpdb,lintzc/gpdb,chrishajas/gpdb,kaknikhil/gpdb,edespino/gpdb,arcivanov/postgres-xl,foyzur/gpdb,xuegang/gpdb,ashwinstar/gpdb,kaknikhil/gpdb,greenplum-db/gpdb,greenplum-db/gpdb,ahachete/gpdb,kaknikhil/gpdb,Quikling/gpdb,Quikling/gpdb,adam8157/gpdb,zaksoup/gpdb,janebeckman/gpdb,kaknikhil/gpdb,janebeckman/gpdb,postmind-net/postgres-xl,ahachete/gpdb,xinzweb/gpdb,ahachete/gpdb,oberstet/postgres-xl,Chibin/gpdb,xinzweb/gpdb,lpetrov-pivotal/gpdb,zaksoup/gpdb,0x0FFF/gpdb,rubikloud/gpdb,royc1/gpdb,foyzur/gpdb,yuanzhao/gpdb,jmcatamney/gpdb,50wu/gpdb,zaksoup/gpdb,royc1/gpdb,xinzweb/gpdb,arcivanov/postgres-xl,greenplum-db/gpdb,Quikling/gpdb,janebeckman/gpdb,tangp3/gpdb,atris/gpdb,lisakowen/gpdb,lisakowen/gpdb,yuanzhao/gpdb,lisakowen/gpdb,cjcjameson/gpdb,lintzc/gpdb,tangp3/gpdb,cjcjameson/gpdb,xuegang/gpdb,cjcjameson/gpdb,jmcatamney/gpdb,jmcatamney/gpdb,lintzc/gpdb,yuanzhao/gpdb,zaksoup/gpdb,ovr/postgres-xl,yazun/postgres-xl,jmcatamney/gpdb,Quikling/gpdb,xuegang/gpdb,greenplum-db/gpdb,Chibin/gpdb,cjcjameson/gpdb,lintzc/gpdb,tpostgres-projects/tPostgres,ashwinstar/gpdb,cjcjameson/gpdb,atris/gpdb,ashwinstar/gpdb,ahachete/gpdb,adam8157/gpdb,foyzur/gpdb,zaksoup/gpdb,adam8157/gpdb,postmind-net/postgres-xl,atris/gpdb,royc1/gpdb,foyzur/gpdb,oberstet/postgres-xl,randomtask1155/gpdb,tpostgres-projects/tPostgres