rework validation of the use list of a box in the allocboxtostack pass to avoid confusing uses of the box with uses of the allocation in partial apply instructions.  This resolves rdar://15595118.
rework validation of the use list of a box in the allocboxtostack pass
to avoid confusing uses of the box with uses of the allocation in partial
apply instructions.  This resolves rdar://15595118.

Unfortunately, the testcase cannot be reduced into something that the
silparser handles, since it goes away when non-generic.


Swift SVN r11408

danielmartin/swift,arvedviehweger/swift,manavgabhawala/swift,uasys/swift,tinysun212/swift-windows,sschiau/swift,rudkx/swift,JGiola/swift,IngmarStein/swift,stephentyrone/swift,kusl/swift,bitjammer/swift,jopamer/swift,KrishMunot/swift,kentya6/swift,arvedviehweger/swift,aschwaighofer/swift,huonw/swift,IngmarStein/swift,russbishop/swift,devincoughlin/swift,ben-ng/swift,benlangmuir/swift,swiftix/swift.old,kusl/swift,LeoShimonaka/swift,brentdax/swift,dreamsxin/swift,parkera/swift,SwiftAndroid/swift,huonw/swift,xedin/swift,xedin/swift,nathawes/swift,arvedviehweger/swift,cbrentharris/swift,djwbrown/swift,hooman/swift,russbishop/swift,gribozavr/swift,modocache/swift,jckarter/swift,parkera/swift,alblue/swift,lorentey/swift,zisko/swift,huonw/swift,milseman/swift,ken0nek/swift,roambotics/swift,swiftix/swift.old,alblue/swift,jckarter/swift,russbishop/swift,practicalswift/swift,gribozavr/swift,gribozavr/swift,allevato/swift,karwa/swift,ben-ng/swift,austinzheng/swift,shajrawi/swift,amraboelela/swift,xedin/swift,kperryua/swift,hooman/swift,MukeshKumarS/Swift,LeoShimonaka/swift,nathawes/swift,OscarSwanros/swift,austinzheng/swift,Ivacker/swift,SwiftAndroid/swift,hooman/swift,karwa/swift,KrishMunot/swift,CodaFi/swift,return/swift,practicalswift/swift,calebd/swift,frootloops/swift,OscarSwanros/swift,ahoppen/swift,gmilos/swift,emilstahl/swift,JaSpa/swift,stephentyrone/swift,gottesmm/swift,airspeedswift/swift,mightydeveloper/swift,cbrentharris/swift,milseman/swift,milseman/swift,Jnosh/swift,zisko/swift,gregomni/swift,slavapestov/swift,tardieu/swift,uasys/swift,Jnosh/swift,roambotics/swift,arvedviehweger/swift,xwu/swift,gmilos/swift,allevato/swift,johnno1962d/swift,karwa/swift,milseman/swift,shahmishal/swift,aschwaighofer/swift,gmilos/swift,swiftix/swift,jmgc/swift,xwu/swift,kperryua/swift,IngmarStein/swift,swiftix/swift.old,CodaFi/swift,gottesmm/swift,practicalswift/swift,LeoShimonaka/swift,uasys/swift,jckarter/swift,Ivacker/swift,kentya6/swift,xedin/swift,CodaFi/swift,nathawes/swift,harlanhaskins/swift,lorentey/swift,tardieu/swift,shajrawi/swift,cbrentharris/swift,CodaFi/swift,return/swift,gribozavr/swift,tjw/swift,devincoughlin/swift,Ivacker/swift,xedin/swift,ben-ng/swift,atrick/swift,danielmartin/swift,JGiola/swift,dreamsxin/swift,manavgabhawala/swift,hooman/swift,amraboelela/swift,swiftix/swift.old,gottesmm/swift,amraboelela/swift,JGiola/swift,swiftix/swift.old,milseman/swift,shahmishal/swift,practicalswift/swift,xwu/swift,allevato/swift,xwu/swift,jmgc/swift,atrick/swift,tkremenek/swift,mightydeveloper/swift,kentya6/swift,cbrentharris/swift,bitjammer/swift,practicalswift/swift,airspeedswift/swift,karwa/swift,slavapestov/swift,parkera/swift,atrick/swift,hughbe/swift,slavapestov/swift,arvedviehweger/swift,nathawes/swift,Jnosh/swift,gottesmm/swift,slavapestov/swift,mightydeveloper/swift,shahmishal/swift,devincoughlin/swift,johnno1962d/swift,OscarSwanros/swift,khizkhiz/swift,jtbandes/swift,ken0nek/swift,xedin/swift,LeoShimonaka/swift,cbrentharris/swift,apple/swift,adrfer/swift,KrishMunot/swift,lorentey/swift,felix91gr/swift,therealbnut/swift,huonw/swift,Jnosh/swift,harlanhaskins/swift,lorentey/swift,djwbrown/swift,modocache/swift,kstaring/swift,johnno1962d/swift,djwbrown/swift,parkera/swift,codestergit/swift,jopamer/swift,calebd/swift,cbrentharris/swift,CodaFi/swift,manavgabhawala/swift,codestergit/swift,SwiftAndroid/swift,devincoughlin/swift,JaSpa/swift,felix91gr/swift,hughbe/swift,jckarter/swift,shahmishal/swift,karwa/swift,jopamer/swift,sdulal/swift,djwbrown/swift,zisko/swift,gregomni/swift,lorentey/swift,gottesmm/swift,gregomni/swift,adrfer/swift,jopamer/swift,mightydeveloper/swift,manavgabhawala/swift,harlanhaskins/swift,nathawes/swift,glessard/swift,sschiau/swift,jtbandes/swift,kstaring/swift,huonw/swift,benlangmuir/swift,khizkhiz/swift,LeoShimonaka/swift,ahoppen/swift,JaSpa/swift,return/swift,felix91gr/swift,russbishop/swift,sdulal/swift,emilstahl/swift,apple/swift,benlangmuir/swift,kentya6/swift,hughbe/swift,gribozavr/swift,johnno1962d/swift,IngmarStein/swift,hooman/swift,jmgc/swift,JGiola/swift,rudkx/swift,modocache/swift,natecook1000/swift,stephentyrone/swift,tjw/swift,sschiau/swift,sdulal/swift,djwbrown/swift,mightydeveloper/swift,swiftix/swift,therealbnut/swift,sdulal/swift,parkera/swift,xwu/swift,deyton/swift,adrfer/swift,brentdax/swift,sdulal/swift,swiftix/swift.old,brentdax/swift,SwiftAndroid/swift,KrishMunot/swift,MukeshKumarS/Swift,return/swift,CodaFi/swift,swiftix/swift,alblue/swift,tinysun212/swift-windows,therealbnut/swift,glessard/swift,shajrawi/swift,dduan/swift,deyton/swift,kentya6/swift,OscarSwanros/swift,natecook1000/swift,lorentey/swift,xedin/swift,ken0nek/swift,atrick/swift,hughbe/swift,frootloops/swift,JGiola/swift,stephentyrone/swift,tinysun212/swift-windows,johnno1962d/swift,hughbe/swift,dduan/swift,gottesmm/swift,stephentyrone/swift,jckarter/swift,shahmishal/swift,CodaFi/swift,tjw/swift,modocache/swift,danielmartin/swift,emilstahl/swift,atrick/swift,felix91gr/swift,hooman/swift,MukeshKumarS/Swift,kentya6/swift,ben-ng/swift,Ivacker/swift,JaSpa/swift,tjw/swift,uasys/swift,khizkhiz/swift,practicalswift/swift,aschwaighofer/swift,khizkhiz/swift,cbrentharris/swift,bitjammer/swift,apple/swift,gmilos/swift,rudkx/swift,SwiftAndroid/swift,airspeedswift/swift,stephentyrone/swift,Jnosh/swift,gmilos/swift,swiftix/swift.old,LeoShimonaka/swift,JaSpa/swift,roambotics/swift,LeoShimonaka/swift,emilstahl/swift,calebd/swift,JGiola/swift,calebd/swift,tardieu/swift,alblue/swift,JaSpa/swift,jopamer/swift,airspeedswift/swift,harlanhaskins/swift,shajrawi/swift,modocache/swift,therealbnut/swift,benlangmuir/swift,Jnosh/swift,aschwaighofer/swift,kstaring/swift,OscarSwanros/swift,jckarter/swift,modocache/swift,karwa/swift,felix91gr/swift,zisko/swift,glessard/swift,tjw/swift,sschiau/swift,brentdax/swift,kperryua/swift,jmgc/swift,tardieu/swift,LeoShimonaka/swift,bitjammer/swift,khizkhiz/swift,shajrawi/swift,apple/swift,alblue/swift,ahoppen/swift,alblue/swift,tinysun212/swift-windows,jmgc/swift,russbishop/swift,tkremenek/swift,xwu/swift,deyton/swift,shahmishal/swift,frootloops/swift,zisko/swift,tkremenek/swift,modocache/swift,KrishMunot/swift,manavgabhawala/swift,swiftix/swift,danielmartin/swift,SwiftAndroid/swift,jmgc/swift,ken0nek/swift,devincoughlin/swift,sdulal/swift,shajrawi/swift,apple/swift,ben-ng/swift,practicalswift/swift,gmilos/swift,MukeshKumarS/Swift,bitjammer/swift,therealbnut/swift,adrfer/swift,kusl/swift,gregomni/swift,amraboelela/swift,uasys/swift,nathawes/swift,kusl/swift,tardieu/swift,JaSpa/swift,cbrentharris/swift,codestergit/swift,brentdax/swift,nathawes/swift,lorentey/swift,johnno1962d/swift,brentdax/swift,deyton/swift,alblue/swift,jopamer/swift,zisko/swift,natecook1000/swift,khizkhiz/swift,Ivacker/swift,emilstahl/swift,ahoppen/swift,manavgabhawala/swift,Ivacker/swift,huonw/swift,hooman/swift,codestergit/swift,aschwaighofer/swift,ben-ng/swift,kperryua/swift,kstaring/swift,frootloops/swift,arvedviehweger/swift,kperryua/swift,parkera/swift,tinysun212/swift-windows,felix91gr/swift,danielmartin/swift,bitjammer/swift,djwbrown/swift,xedin/swift,gottesmm/swift,sschiau/swift,MukeshKumarS/Swift,karwa/swift,emilstahl/swift,calebd/swift,uasys/swift,brentdax/swift,allevato/swift,hughbe/swift,ken0nek/swift,stephentyrone/swift,ken0nek/swift,OscarSwanros/swift,SwiftAndroid/swift,tinysun212/swift-windows,parkera/swift,austinzheng/swift,adrfer/swift,gribozavr/swift,swiftix/swift.old,felix91gr/swift,swiftix/swift,therealbnut/swift,austinzheng/swift,shajrawi/swift,frootloops/swift,kperryua/swift,kusl/swift,mightydeveloper/swift,ahoppen/swift,dduan/swift,glessard/swift,KrishMunot/swift,arvedviehweger/swift,rudkx/swift,aschwaighofer/swift,harlanhaskins/swift,adrfer/swift,emilstahl/swift,ben-ng/swift,calebd/swift,shahmishal/swift,tinysun212/swift-windows,codestergit/swift,roambotics/swift,austinzheng/swift,emilstahl/swift,uasys/swift,return/swift,adrfer/swift,tardieu/swift,austinzheng/swift,deyton/swift,airspeedswift/swift,glessard/swift,deyton/swift,jtbandes/swift,frootloops/swift,jtbandes/swift,slavapestov/swift,kstaring/swift,shajrawi/swift,kperryua/swift,atrick/swift,danielmartin/swift,OscarSwanros/swift,devincoughlin/swift,MukeshKumarS/Swift,apple/swift,djwbrown/swift,therealbnut/swift,Ivacker/swift,practicalswift/swift,swiftix/swift,codestergit/swift,sschiau/swift,natecook1000/swift,codestergit/swift,tkremenek/swift,MukeshKumarS/Swift,dduan/swift,IngmarStein/swift,tkremenek/swift,danielmartin/swift,calebd/swift,kentya6/swift,airspeedswift/swift,kstaring/swift,rudkx/swift,kentya6/swift,milseman/swift,roambotics/swift,Jnosh/swift,lorentey/swift,austinzheng/swift,jmgc/swift,airspeedswift/swift,amraboelela/swift,shahmishal/swift,gregomni/swift,natecook1000/swift,tjw/swift,glessard/swift,russbishop/swift,milseman/swift,ahoppen/swift,allevato/swift,mightydeveloper/swift,tkremenek/swift,natecook1000/swift,harlanhaskins/swift,jtbandes/swift,xwu/swift,KrishMunot/swift,dduan/swift,aschwaighofer/swift,gribozavr/swift,harlanhaskins/swift,return/swift,gregomni/swift,bitjammer/swift,IngmarStein/swift,roambotics/swift,jckarter/swift,huonw/swift,deyton/swift,devincoughlin/swift,amraboelela/swift,allevato/swift,rudkx/swift,Ivacker/swift,sdulal/swift,parkera/swift,gmilos/swift,return/swift,russbishop/swift,natecook1000/swift,hughbe/swift,khizkhiz/swift,devincoughlin/swift,swiftix/swift,gribozavr/swift,sschiau/swift,kusl/swift,jtbandes/swift,mightydeveloper/swift,zisko/swift,slavapestov/swift,amraboelela/swift,benlangmuir/swift,sdulal/swift,tkremenek/swift,jtbandes/swift,tardieu/swift,tjw/swift,slavapestov/swift,IngmarStein/swift,johnno1962d/swift,frootloops/swift,kusl/swift,karwa/swift,dduan/swift,dduan/swift,jopamer/swift,allevato/swift,kstaring/swift,ken0nek/swift,manavgabhawala/swift,kusl/swift,benlangmuir/swift,sschiau/swift