Make serfs authorization callbacks capable of returning error codes from more places, by adding svn_error_t * wrappers around them that store the pending error in the session.
Make serfs authorization callbacks capable of returning error codes from
more places, by adding svn_error_t * wrappers around them that store the
pending error in the session.

* subversion/libsvn_ra_serf/util.c
  (ssl_server_cert): Make this function return svn_error_t *. Add
    scratch_pool argument as it is easier to handle this in the wrapper.
  (ssl_server_cert_cb): New function, wrapping ssl_server_cert for error
    and pool handling.
  (svn_ra_serf__conn_setup): Make static and rename to ...
  (conn_setup): ... this, simplifying the error handling by doing
    that in a wrapper function. Register ssl_server_cert_cb instead of
    ssl_server_cert. Return some previously always cleared errors.
  (svn_ra_serf__conn_setup): New function, wrapping conn_setup for
    error, pool and bucket handling.

  (svn_ra_serf__handle_client_cert): Make this function static, return
    svn_error_t* and rename to ...
  (handle_client_cert): ... this. Move storing the error to wrapper.
  (svn_ra_serf__handle_client_cert): New function, wrapping
    handle_client_cert.

  (svn_ra_serf__handle_client_cert_pw): Make this function static, return
    svn_error_t* and rename to ...
  (handle_client_cert_pw): ... this. Move storing the error to wrapper.
  (svn_ra_serf__handle_client_cert_pw): New function, wrapping
    handle_client_cert_pw.

  (handle_response_cb): Prefer pending errors over internal serf_status,
    like in the other callbacks.

jmckaskill/subversion,jmckaskill/subversion,jmckaskill/subversion,jmckaskill/subversion,jmckaskill/subversion,jmckaskill/subversion,jmckaskill/subversion,jmckaskill/subversion