From: "D'Arcy J.M. Cain" <darcy@druid.net> Subject: [HACKERS] backend/optimizer/geqo/geqo_erx.c
From: "D'Arcy J.M. Cain" <darcy@druid.net>
Subject: [HACKERS] backend/optimizer/geqo/geqo_erx.c

I sent these changes in with a bunch of others.  Some were folded in but
others, like these, were not.  I am not sure why so I am resending this
to the developers list by itself for discussion.

The readon why I suggest these changes is that the compiler can't tell
that minimum_count is initialized before it is used.  The tests that I
add in here will cause an immediate error if it doesn't.  As the comments
below suggest, if it is 100% guaranteed that the variable will always
be initialized then how this is so should be commented here.  I don't
know how much strain the actual test puts on the performance but if it
isn't too much then maybe leave it in for absolute safety anyway.

There are also a few returns just to stop warnings.

foyzur/gpdb,lpetrov-pivotal/gpdb,lisakowen/gpdb,snaga/postgres-xl,cjcjameson/gpdb,CraigHarris/gpdb,kaknikhil/gpdb,pavanvd/postgres-xl,randomtask1155/gpdb,xinzweb/gpdb,royc1/gpdb,rvs/gpdb,kaknikhil/gpdb,adam8157/gpdb,50wu/gpdb,Postgres-XL/Postgres-XL,yazun/postgres-xl,greenplum-db/gpdb,janebeckman/gpdb,edespino/gpdb,CraigHarris/gpdb,adam8157/gpdb,atris/gpdb,arcivanov/postgres-xl,lisakowen/gpdb,yazun/postgres-xl,zaksoup/gpdb,royc1/gpdb,atris/gpdb,cjcjameson/gpdb,edespino/gpdb,cjcjameson/gpdb,foyzur/gpdb,Quikling/gpdb,snaga/postgres-xl,Chibin/gpdb,postmind-net/postgres-xl,Quikling/gpdb,kaknikhil/gpdb,pavanvd/postgres-xl,arcivanov/postgres-xl,atris/gpdb,yuanzhao/gpdb,Postgres-XL/Postgres-XL,xuegang/gpdb,zaksoup/gpdb,ahachete/gpdb,janebeckman/gpdb,tangp3/gpdb,Chibin/gpdb,tangp3/gpdb,lintzc/gpdb,randomtask1155/gpdb,adam8157/gpdb,Chibin/gpdb,ashwinstar/gpdb,lintzc/gpdb,tpostgres-projects/tPostgres,tpostgres-projects/tPostgres,Chibin/gpdb,CraigHarris/gpdb,randomtask1155/gpdb,randomtask1155/gpdb,randomtask1155/gpdb,Quikling/gpdb,cjcjameson/gpdb,zaksoup/gpdb,chrishajas/gpdb,atris/gpdb,Chibin/gpdb,rvs/gpdb,Chibin/gpdb,rvs/gpdb,ovr/postgres-xl,kaknikhil/gpdb,arcivanov/postgres-xl,jmcatamney/gpdb,greenplum-db/gpdb,royc1/gpdb,foyzur/gpdb,zeroae/postgres-xl,lisakowen/gpdb,janebeckman/gpdb,yuanzhao/gpdb,yuanzhao/gpdb,adam8157/gpdb,rubikloud/gpdb,chrishajas/gpdb,janebeckman/gpdb,kmjungersen/PostgresXL,xinzweb/gpdb,ashwinstar/gpdb,yuanzhao/gpdb,arcivanov/postgres-xl,Postgres-XL/Postgres-XL,rvs/gpdb,ashwinstar/gpdb,ovr/postgres-xl,foyzur/gpdb,50wu/gpdb,greenplum-db/gpdb,zaksoup/gpdb,lintzc/gpdb,randomtask1155/gpdb,greenplum-db/gpdb,zeroae/postgres-xl,ashwinstar/gpdb,greenplum-db/gpdb,foyzur/gpdb,rubikloud/gpdb,CraigHarris/gpdb,cjcjameson/gpdb,jmcatamney/gpdb,chrishajas/gpdb,Chibin/gpdb,tpostgres-projects/tPostgres,xuegang/gpdb,zaksoup/gpdb,edespino/gpdb,0x0FFF/gpdb,cjcjameson/gpdb,Quikling/gpdb,Chibin/gpdb,xuegang/gpdb,lisakowen/gpdb,kmjungersen/PostgresXL,greenplum-db/gpdb,lintzc/gpdb,yuanzhao/gpdb,lintzc/gpdb,royc1/gpdb,techdragon/Postgres-XL,rubikloud/gpdb,foyzur/gpdb,50wu/gpdb,edespino/gpdb,Quikling/gpdb,zeroae/postgres-xl,janebeckman/gpdb,0x0FFF/gpdb,rubikloud/gpdb,janebeckman/gpdb,kaknikhil/gpdb,CraigHarris/gpdb,lisakowen/gpdb,yuanzhao/gpdb,Postgres-XL/Postgres-XL,randomtask1155/gpdb,edespino/gpdb,yuanzhao/gpdb,chrishajas/gpdb,rubikloud/gpdb,rubikloud/gpdb,oberstet/postgres-xl,ahachete/gpdb,Quikling/gpdb,xuegang/gpdb,jmcatamney/gpdb,xinzweb/gpdb,jmcatamney/gpdb,xinzweb/gpdb,royc1/gpdb,arcivanov/postgres-xl,lintzc/gpdb,postmind-net/postgres-xl,jmcatamney/gpdb,adam8157/gpdb,zaksoup/gpdb,yuanzhao/gpdb,ovr/postgres-xl,atris/gpdb,ashwinstar/gpdb,ahachete/gpdb,rvs/gpdb,xinzweb/gpdb,cjcjameson/gpdb,lpetrov-pivotal/gpdb,0x0FFF/gpdb,royc1/gpdb,kmjungersen/PostgresXL,lpetrov-pivotal/gpdb,chrishajas/gpdb,0x0FFF/gpdb,lpetrov-pivotal/gpdb,rvs/gpdb,adam8157/gpdb,royc1/gpdb,lisakowen/gpdb,lintzc/gpdb,ashwinstar/gpdb,ahachete/gpdb,xuegang/gpdb,oberstet/postgres-xl,xuegang/gpdb,janebeckman/gpdb,chrishajas/gpdb,50wu/gpdb,edespino/gpdb,ashwinstar/gpdb,edespino/gpdb,ahachete/gpdb,postmind-net/postgres-xl,tangp3/gpdb,rubikloud/gpdb,rvs/gpdb,cjcjameson/gpdb,techdragon/Postgres-XL,CraigHarris/gpdb,edespino/gpdb,Quikling/gpdb,greenplum-db/gpdb,tpostgres-projects/tPostgres,50wu/gpdb,Quikling/gpdb,xinzweb/gpdb,lisakowen/gpdb,CraigHarris/gpdb,yazun/postgres-xl,randomtask1155/gpdb,tangp3/gpdb,pavanvd/postgres-xl,rvs/gpdb,greenplum-db/gpdb,lintzc/gpdb,chrishajas/gpdb,xinzweb/gpdb,ashwinstar/gpdb,jmcatamney/gpdb,janebeckman/gpdb,ahachete/gpdb,atris/gpdb,chrishajas/gpdb,yuanzhao/gpdb,atris/gpdb,50wu/gpdb,adam8157/gpdb,xinzweb/gpdb,oberstet/postgres-xl,zaksoup/gpdb,kmjungersen/PostgresXL,0x0FFF/gpdb,pavanvd/postgres-xl,rvs/gpdb,0x0FFF/gpdb,kaknikhil/gpdb,techdragon/Postgres-XL,rvs/gpdb,arcivanov/postgres-xl,ahachete/gpdb,postmind-net/postgres-xl,ovr/postgres-xl,jmcatamney/gpdb,tangp3/gpdb,Quikling/gpdb,Chibin/gpdb,Chibin/gpdb,edespino/gpdb,snaga/postgres-xl,50wu/gpdb,edespino/gpdb,yazun/postgres-xl,snaga/postgres-xl,tangp3/gpdb,lintzc/gpdb,janebeckman/gpdb,kaknikhil/gpdb,ahachete/gpdb,royc1/gpdb,50wu/gpdb,0x0FFF/gpdb,cjcjameson/gpdb,kaknikhil/gpdb,lisakowen/gpdb,atris/gpdb,lpetrov-pivotal/gpdb,yazun/postgres-xl,Postgres-XL/Postgres-XL,oberstet/postgres-xl,zeroae/postgres-xl,adam8157/gpdb,techdragon/Postgres-XL,kaknikhil/gpdb,yuanzhao/gpdb,xuegang/gpdb,ovr/postgres-xl,jmcatamney/gpdb,CraigHarris/gpdb,postmind-net/postgres-xl,xuegang/gpdb,lpetrov-pivotal/gpdb,snaga/postgres-xl,kmjungersen/PostgresXL,oberstet/postgres-xl,cjcjameson/gpdb,zaksoup/gpdb,foyzur/gpdb,zeroae/postgres-xl,janebeckman/gpdb,foyzur/gpdb,rubikloud/gpdb,0x0FFF/gpdb,tangp3/gpdb,xuegang/gpdb,tangp3/gpdb,pavanvd/postgres-xl,Quikling/gpdb,tpostgres-projects/tPostgres,kaknikhil/gpdb,CraigHarris/gpdb,lpetrov-pivotal/gpdb,lpetrov-pivotal/gpdb,techdragon/Postgres-XL