Fix VoteSite caching
Fix VoteSite caching

Codacy identified an unused local variable `$allSites` in the function
`VoteSite::getAllSites`. This was supposed to be `$ALL_SITES`, and so
the intended caching was not working.

The effect of not caching here is very minimal, since there are no
database queries involved.

hemberger/smr,hemberger/smr,hemberger/smr,smrealms/smr,hemberger/smr,smrealms/smr,smrealms/smr