Fix cdd package definition, dotted is a property (#2054)
Fix cdd package definition, dotted is a property (#2054)

Things that accessed the cdd package, such as `spack info cdd run
tripped over a buglet in the *cdd* package, causing them to exit with
something like this:

```
Caused by:
TypeError: 'str' object is not callable
  File "/rss/spack/lib/spack/spack/repository.py", line 584, in get
    self._instances[key] = package_class(copy)
  File "/rss/spack/lib/spack/spack/package.py", line 398, in __init__
    f = fs.for_package_version(self, self.version)
  File "/rss/spack/lib/spack/spack/fetch_strategy.py", line 852, in for_package_version
    attrs['url'] = pkg.url_for_version(version)
  File "/rss/spack/var/spack/repos/builtin/packages/cdd/package.py", line 40, in url_for_version
    str(version.dotted()).replace('.', ''))
```

@tgamblin pointed out that `dotted` is a property, not a functin call
and that the parentheses are therefor inappropriate.

This deletes the parentheses.  `spack info cdd` now works for me.
matthiasdiener/spack,tmerrick1/spack,matthiasdiener/spack,LLNL/spack,matthiasdiener/spack,LLNL/spack,krafczyk/spack,krafczyk/spack,lgarren/spack,lgarren/spack,matthiasdiener/spack,LLNL/spack,iulian787/spack,mfherbst/spack,TheTimmy/spack,EmreAtes/spack,krafczyk/spack,TheTimmy/spack,TheTimmy/spack,skosukhin/spack,EmreAtes/spack,mfherbst/spack,TheTimmy/spack,EmreAtes/spack,iulian787/spack,tmerrick1/spack,skosukhin/spack,iulian787/spack,mfherbst/spack,tmerrick1/spack,EmreAtes/spack,krafczyk/spack,mfherbst/spack,EmreAtes/spack,skosukhin/spack,LLNL/spack,mfherbst/spack,skosukhin/spack,iulian787/spack,tmerrick1/spack,LLNL/spack,tmerrick1/spack,lgarren/spack,krafczyk/spack,lgarren/spack,iulian787/spack,matthiasdiener/spack,lgarren/spack,skosukhin/spack,TheTimmy/spack