Fix bug reported by bobson: aclinsert3 would delete the 'world' entry from an ACL list if it had no permissions remaining, which confused aclcheck terribly.  Also clean up code a little.
Fix bug reported by bobson: aclinsert3 would delete the 'world' entry
from an ACL list if it had no permissions remaining, which confused
aclcheck terribly.  Also clean up code a little.

Chibin/gpdb,yazun/postgres-xl,rubikloud/gpdb,edespino/gpdb,cjcjameson/gpdb,lisakowen/gpdb,foyzur/gpdb,xuegang/gpdb,zaksoup/gpdb,lintzc/gpdb,lisakowen/gpdb,atris/gpdb,lpetrov-pivotal/gpdb,50wu/gpdb,kmjungersen/PostgresXL,techdragon/Postgres-XL,chrishajas/gpdb,lintzc/gpdb,yuanzhao/gpdb,techdragon/Postgres-XL,techdragon/Postgres-XL,rubikloud/gpdb,0x0FFF/gpdb,atris/gpdb,tpostgres-projects/tPostgres,xinzweb/gpdb,tpostgres-projects/tPostgres,Quikling/gpdb,rvs/gpdb,ashwinstar/gpdb,pavanvd/postgres-xl,0x0FFF/gpdb,Chibin/gpdb,Quikling/gpdb,atris/gpdb,zeroae/postgres-xl,kaknikhil/gpdb,ovr/postgres-xl,foyzur/gpdb,rvs/gpdb,Chibin/gpdb,0x0FFF/gpdb,atris/gpdb,atris/gpdb,xinzweb/gpdb,postmind-net/postgres-xl,yazun/postgres-xl,janebeckman/gpdb,yuanzhao/gpdb,Chibin/gpdb,cjcjameson/gpdb,adam8157/gpdb,lpetrov-pivotal/gpdb,randomtask1155/gpdb,lisakowen/gpdb,lpetrov-pivotal/gpdb,randomtask1155/gpdb,foyzur/gpdb,lisakowen/gpdb,arcivanov/postgres-xl,atris/gpdb,royc1/gpdb,postmind-net/postgres-xl,jmcatamney/gpdb,randomtask1155/gpdb,lpetrov-pivotal/gpdb,greenplum-db/gpdb,Chibin/gpdb,edespino/gpdb,xinzweb/gpdb,janebeckman/gpdb,chrishajas/gpdb,rubikloud/gpdb,CraigHarris/gpdb,janebeckman/gpdb,ovr/postgres-xl,ovr/postgres-xl,ashwinstar/gpdb,ahachete/gpdb,lintzc/gpdb,chrishajas/gpdb,0x0FFF/gpdb,janebeckman/gpdb,oberstet/postgres-xl,lisakowen/gpdb,ashwinstar/gpdb,yuanzhao/gpdb,foyzur/gpdb,xuegang/gpdb,lpetrov-pivotal/gpdb,chrishajas/gpdb,royc1/gpdb,rvs/gpdb,jmcatamney/gpdb,lintzc/gpdb,rubikloud/gpdb,snaga/postgres-xl,edespino/gpdb,lpetrov-pivotal/gpdb,50wu/gpdb,jmcatamney/gpdb,ovr/postgres-xl,arcivanov/postgres-xl,ahachete/gpdb,kaknikhil/gpdb,50wu/gpdb,cjcjameson/gpdb,arcivanov/postgres-xl,CraigHarris/gpdb,kmjungersen/PostgresXL,0x0FFF/gpdb,randomtask1155/gpdb,tangp3/gpdb,Chibin/gpdb,kaknikhil/gpdb,royc1/gpdb,rvs/gpdb,cjcjameson/gpdb,chrishajas/gpdb,janebeckman/gpdb,xuegang/gpdb,zaksoup/gpdb,pavanvd/postgres-xl,greenplum-db/gpdb,edespino/gpdb,yuanzhao/gpdb,techdragon/Postgres-XL,yuanzhao/gpdb,zeroae/postgres-xl,kaknikhil/gpdb,rubikloud/gpdb,CraigHarris/gpdb,Quikling/gpdb,ahachete/gpdb,cjcjameson/gpdb,royc1/gpdb,royc1/gpdb,adam8157/gpdb,rubikloud/gpdb,Postgres-XL/Postgres-XL,royc1/gpdb,royc1/gpdb,zeroae/postgres-xl,CraigHarris/gpdb,yazun/postgres-xl,rvs/gpdb,arcivanov/postgres-xl,snaga/postgres-xl,zaksoup/gpdb,ovr/postgres-xl,janebeckman/gpdb,rvs/gpdb,xuegang/gpdb,jmcatamney/gpdb,yuanzhao/gpdb,yuanzhao/gpdb,lisakowen/gpdb,tangp3/gpdb,janebeckman/gpdb,greenplum-db/gpdb,yuanzhao/gpdb,zaksoup/gpdb,Chibin/gpdb,lpetrov-pivotal/gpdb,ashwinstar/gpdb,xuegang/gpdb,xinzweb/gpdb,snaga/postgres-xl,Quikling/gpdb,adam8157/gpdb,zaksoup/gpdb,pavanvd/postgres-xl,kmjungersen/PostgresXL,arcivanov/postgres-xl,ahachete/gpdb,atris/gpdb,kaknikhil/gpdb,lintzc/gpdb,chrishajas/gpdb,adam8157/gpdb,tangp3/gpdb,rvs/gpdb,Quikling/gpdb,greenplum-db/gpdb,foyzur/gpdb,yuanzhao/gpdb,edespino/gpdb,janebeckman/gpdb,tpostgres-projects/tPostgres,lintzc/gpdb,tangp3/gpdb,Chibin/gpdb,zeroae/postgres-xl,zaksoup/gpdb,yazun/postgres-xl,oberstet/postgres-xl,ahachete/gpdb,janebeckman/gpdb,CraigHarris/gpdb,jmcatamney/gpdb,ahachete/gpdb,Quikling/gpdb,rubikloud/gpdb,zaksoup/gpdb,lintzc/gpdb,Quikling/gpdb,foyzur/gpdb,edespino/gpdb,edespino/gpdb,xuegang/gpdb,adam8157/gpdb,adam8157/gpdb,kmjungersen/PostgresXL,tangp3/gpdb,zaksoup/gpdb,techdragon/Postgres-XL,ashwinstar/gpdb,tangp3/gpdb,kaknikhil/gpdb,lintzc/gpdb,50wu/gpdb,Quikling/gpdb,ashwinstar/gpdb,edespino/gpdb,xinzweb/gpdb,50wu/gpdb,postmind-net/postgres-xl,Chibin/gpdb,edespino/gpdb,snaga/postgres-xl,rvs/gpdb,oberstet/postgres-xl,ashwinstar/gpdb,cjcjameson/gpdb,arcivanov/postgres-xl,lisakowen/gpdb,cjcjameson/gpdb,tpostgres-projects/tPostgres,pavanvd/postgres-xl,ashwinstar/gpdb,0x0FFF/gpdb,adam8157/gpdb,CraigHarris/gpdb,edespino/gpdb,royc1/gpdb,greenplum-db/gpdb,kmjungersen/PostgresXL,xinzweb/gpdb,Quikling/gpdb,foyzur/gpdb,0x0FFF/gpdb,janebeckman/gpdb,Postgres-XL/Postgres-XL,xuegang/gpdb,yuanzhao/gpdb,greenplum-db/gpdb,chrishajas/gpdb,oberstet/postgres-xl,randomtask1155/gpdb,CraigHarris/gpdb,rvs/gpdb,randomtask1155/gpdb,0x0FFF/gpdb,cjcjameson/gpdb,postmind-net/postgres-xl,cjcjameson/gpdb,greenplum-db/gpdb,xuegang/gpdb,adam8157/gpdb,rvs/gpdb,chrishajas/gpdb,greenplum-db/gpdb,Postgres-XL/Postgres-XL,tangp3/gpdb,ahachete/gpdb,jmcatamney/gpdb,kaknikhil/gpdb,xinzweb/gpdb,snaga/postgres-xl,tpostgres-projects/tPostgres,xuegang/gpdb,kaknikhil/gpdb,50wu/gpdb,foyzur/gpdb,oberstet/postgres-xl,jmcatamney/gpdb,kaknikhil/gpdb,CraigHarris/gpdb,pavanvd/postgres-xl,tangp3/gpdb,randomtask1155/gpdb,Postgres-XL/Postgres-XL,randomtask1155/gpdb,ahachete/gpdb,jmcatamney/gpdb,lpetrov-pivotal/gpdb,lisakowen/gpdb,Postgres-XL/Postgres-XL,zeroae/postgres-xl,xinzweb/gpdb,rubikloud/gpdb,CraigHarris/gpdb,Chibin/gpdb,kaknikhil/gpdb,atris/gpdb,50wu/gpdb,postmind-net/postgres-xl,lintzc/gpdb,yazun/postgres-xl,50wu/gpdb,cjcjameson/gpdb,Quikling/gpdb