673 - fix broken basket updates
673 - fix broken basket updates

This was due to a reload in update_totals wiping any changes from
form updates etc.

I've opted for the simplest fix for now - remove the reload
AND fixed the need for the reload. update_line_items was
deleting records but leaving the line_items list unchanged.
It now removes the defunct records from the list, thus removing
the need for a reload.

Dropping the reload should only cause problems if line items
get changed independently of the parent order, and I don't
believe this occurs in the code.

However: rethinking the upload vs save situation is needed, to
make this more robust. (Eg can we rely on the order of filters?)

sideci-sample/sideci-sample-spree,siddharth28/spree,yomishra/pce,moneyspyder/spree,Senjai/solidus,pervino/solidus,tomash/spree,sfcgeorge/spree,DarkoP/spree,tomash/spree,volpejoaquin/spree,moneyspyder/spree,codesavvy/sandbox,lsirivong/solidus,abhishekjain16/spree,net2b/spree,patdec/spree,caiqinghua/spree,codesavvy/sandbox,Migweld/spree,StemboltHQ/spree,volpejoaquin/spree,firman/spree,alvinjean/spree,joanblake/spree,archSeer/spree,tesserakt/clean_spree,volpejoaquin/spree,Nevensoft/spree,reinaris/spree,jparr/spree,quentinuys/spree,locomotivapro/spree,grzlus/spree,woboinc/spree,SadTreeFriends/spree,sunny2601/spree,keatonrow/spree,Engeltj/spree,StemboltHQ/spree,gregoryrikson/spree-sample,calvinl/spree,AgilTec/spree,maybii/spree,omarsar/spree,alepore/spree,radarseesradar/spree,surfdome/spree,knuepwebdev/FloatTubeRodHolders,Kagetsuki/spree,tancnle/spree,jeffboulet/spree,project-eutopia/spree,odk211/spree,vcavallo/spree,radarseesradar/spree,mindvolt/spree,Arpsara/solidus,kitwalker12/spree,tancnle/spree,vivekamn/spree,priyank-gupta/spree,madetech/spree,APohio/spree,vmatekole/spree,derekluo/spree,DynamoMTL/spree,TimurTarasenko/spree,jhawthorn/spree,Lostmyname/spree,adaddeo/spree,biagidp/spree,biagidp/spree,judaro13/spree-fork,priyank-gupta/spree,pronix/kenigtorg,piousbox/spree,camelmasa/spree,Machpowersystems/spree_mach,njerrywerry/spree,reidblomquist/spree,watg/spree,pervino/spree,nooysters/spree,delphsoft/spree-store-ballchair,DynamoMTL/spree,AgilTec/spree,CiscoCloud/spree,bjornlinder/Spree,hoanghiep90/spree,piousbox/spree,adaddeo/spree,firman/spree,alvinjean/spree,omarsar/spree,raow/spree,calvinl/spree,CiscoCloud/spree,Hawaiideveloper/shoppingcart,KMikhaylovCTG/spree,urimikhli/spree,Senjai/spree,bonobos/solidus,devilcoders/solidus,HealthWave/spree,azclick/spree,pronix/kenigtorg,Hates/spree,Migweld/spree,quentinuys/spree,xuewenfei/solidus,surfdome/spree,pervino/spree,Lostmyname/spree,athal7/solidus,robodisco/spree,alejandromangione/spree,Mayvenn/spree,progsri/spree,zaeznet/spree,berkes/spree,forkata/solidus,lyzxsc/spree,Hates/spree,rakibulislam/spree,rakibulislam/spree,TimurTarasenko/spree,net2b/spree,jspizziri/spree,ujai/spree,judaro13/spree-fork,Kagetsuki/spree,raow/spree,yiqing95/spree,hifly/spree,raow/spree,calvinl/spree,TimurTarasenko/spree,patdec/spree,keatonrow/spree,wolfieorama/spree,imella/spree,sideci-sample/sideci-sample-spree,jasonfb/spree,camelmasa/spree,odk211/spree,sfcgeorge/spree,lzcabrera/spree-1-3-stable,jordan-brough/spree,bryanmtl/spree_clear2pay,priyank-gupta/spree,shaywood2/spree,PhoenixTeam/spree_phoenix,tancnle/spree,cutefrank/spree,JDutil/spree,Engeltj/spree,hifly/spree,brchristian/spree,alejandromangione/spree,jeffboulet/spree,rbngzlv/spree,orenf/spree,jsurdilla/solidus,pulkit21/spree,quentinuys/spree,sanjay1185/mystore,miyazawatomoka/spree,shaywood2/spree,rajeevriitm/spree,patdec/spree,xuewenfei/solidus,lzcabrera/spree-1-3-stable,miyazawatomoka/spree,moneyspyder/spree,njerrywerry/spree,jhawthorn/spree,richardnuno/solidus,hoanghiep90/spree,ramkumar-kr/spree,HealthWave/spree,orenf/spree,urimikhli/spree,useiichi/spree,NerdsvilleCEO/spree,jasonfb/spree,scottcrawford03/solidus,vinsol/spree,carlesjove/spree,sliaquat/spree,degica/spree,karlitxo/spree,shekibobo/spree,jspizziri/spree,LBRapid/spree,imella/spree,vivekamn/spree,FadliKun/spree,azranel/spree,vinsol/spree,AgilTec/spree,alejandromangione/spree,robodisco/spree,Senjai/spree,moneyspyder/spree,sideci-sample/sideci-sample-spree,lsirivong/spree,reidblomquist/spree,assembledbrands/spree,jhnsntmthy/tgs_store,gautamsawhney/spree,kitwalker12/spree,progsri/spree,miyazawatomoka/spree,fahidnasir/spree,dafontaine/spree,ayb/spree,zamiang/spree,derekluo/spree,joanblake/spree,tailic/spree,thogg4/spree,jimblesm/spree,grzlus/solidus,Nevensoft/spree,zamiang/spree,mleglise/spree,TrialGuides/spree,lsirivong/spree,Engeltj/spree,calvinl/spree,NerdsvilleCEO/spree,softr8/spree,lyzxsc/spree,tancnle/spree,yushine/spree,vinayvinsol/spree,FadliKun/spree,gautamsawhney/spree,CJMrozek/spree,shekibobo/spree,assembledbrands/spree,mleglise/spree,Ropeney/spree,grzlus/spree,alvinjean/spree,jeffboulet/spree,Kagetsuki/spree,dotandbo/spree,codesavvy/sandbox,azclick/spree,jaspreet21anand/spree,edgward/spree,vmatekole/spree,adaddeo/spree,sunny2601/spree,dafontaine/spree,agient/agientstorefront,orenf/spree,LBRapid/spree,caiqinghua/spree,ahmetabdi/spree,archSeer/spree,JDutil/spree,lyzxsc/spree,gautamsawhney/spree,dandanwei/spree,APohio/spree,yushine/spree,jordan-brough/solidus,thogg4/spree,AgilTec/spree,KMikhaylovCTG/spree,fahidnasir/spree,shaywood2/spree,gotoAndBliss/True-Jersey,shaywood2/spree,siddharth28/spree,edgward/spree,groundctrl/spree,jparr/spree,azranel/spree,jsurdilla/solidus,grzlus/solidus,camelmasa/spree,ayb/spree,DarkoP/spree,jordan-brough/spree,zaeznet/spree,Ropeney/spree,degica/spree,softr8/spree,net2b/spree,karlitxo/spree,jhnsntmthy/tgs_store,woboinc/spree,biagidp/spree,pervino/spree,grzlus/solidus,dandanwei/spree,brchristian/spree,keatonrow/spree,camelmasa/spree,PhoenixTeam/spree_phoenix,assembledbrands/spree,beni55/spree,woboinc/spree,derekluo/spree,jasonfb/spree,alvinjean/spree,quentinuys/spree,Engeltj/spree,beni55/spree,PhoenixTeam/spree_phoenix,zamiang/spree,builtbybuffalo/spree,yushine/spree,LBRapid/spree,wolfieorama/spree,tesserakt/clean_spree,derekluo/spree,jhnsntmthy/tgs_store,Arpsara/solidus,carlesjove/spree,vcavallo/spree,freerunningtech/spree,vulk/spree,josephholsten/plain-sight,HealthWave/spree,APohio/spree,omarsar/spree,Mayvenn/spree,Nevensoft/spree,ramkumar-kr/spree,beni55/spree,berkes/spree,dafontaine/spree,vinayvinsol/spree,Senjai/solidus,bjornlinder/Spree,DynamoMTL/spree,siddharth28/spree,Boomkat/spree,lzcabrera/spree-1-3-stable,reinaris/spree,delphsoft/spree-store-ballchair,forkata/solidus,devilcoders/solidus,athal7/solidus,FadliKun/spree,jsurdilla/solidus,bonobos/solidus,forkata/solidus,pervino/spree,bricesanchez/spree,abhishekjain16/spree,shioyama/spree,vinayvinsol/spree,odk211/spree,CJMrozek/spree,Lostmyname/spree,softr8/spree,xuewenfei/solidus,bjornlinder/Spree,ahmetabdi/spree,imella/spree,TrialGuides/spree,builtbybuffalo/spree,yomishra/pce,preston-scott/spree,grzlus/solidus,pjmj777/spree,vmatekole/spree,DynamoMTL/spree,ahmetabdi/spree,gregoryrikson/spree-sample,beni55/spree,ramkumar-kr/spree,reidblomquist/spree,radarseesradar/spree,robodisco/spree,maybii/spree,trigrass2/spree,jaspreet21anand/spree,rbngzlv/spree,cutefrank/spree,berkes/spree,athal7/solidus,nooysters/spree,freerunningtech/spree,urimikhli/spree,groundctrl/spree,nooysters/spree,dandanwei/spree,brchristian/spree,azranel/spree,tomash/spree,lsirivong/spree,JuandGirald/spree,thogg4/spree,useiichi/spree,dotandbo/spree,sfcgeorge/spree,TrialGuides/spree,Lostmyname/spree,wolfieorama/spree,bonobos/solidus,karlitxo/spree,joanblake/spree,jaspreet21anand/spree,devilcoders/solidus,scottcrawford03/solidus,alejandromangione/spree,agient/agientstorefront,keatonrow/spree,bricesanchez/spree,kewaunited/spree,robodisco/spree,jparr/spree,rajeevriitm/spree,madetech/spree,rajeevriitm/spree,lyzxsc/spree,karlitxo/spree,Arpsara/solidus,lsirivong/solidus,madetech/spree,mindvolt/spree,useiichi/spree,xuewenfei/solidus,caiqinghua/spree,agient/agientstorefront,Senjai/spree,pervino/solidus,omarsar/spree,jordan-brough/spree,grzlus/spree,knuepwebdev/FloatTubeRodHolders,Boomkat/spree,vcavallo/spree,Mayvenn/spree,ckk-scratch/solidus,CiscoCloud/spree,yiqing95/spree,Kagetsuki/spree,radarseesradar/spree,Antdesk/karpal-spree,scottcrawford03/solidus,edgward/spree,sunny2601/spree,JuandGirald/spree,RatioClothing/spree,lsirivong/solidus,rajeevriitm/spree,sliaquat/spree,zaeznet/spree,thogg4/spree,yiqing95/spree,KMikhaylovCTG/spree,welitonfreitas/spree,odk211/spree,DarkoP/spree,carlesjove/spree,Antdesk/karpal-spree,Ropeney/spree,gregoryrikson/spree-sample,ahmetabdi/spree,orenf/spree,adaddeo/spree,nooysters/spree,pulkit21/spree,scottcrawford03/solidus,KMikhaylovCTG/spree,maybii/spree,zaeznet/spree,kitwalker12/spree,richardnuno/solidus,trigrass2/spree,jimblesm/spree,project-eutopia/spree,useiichi/spree,shekibobo/spree,Ropeney/spree,yushine/spree,Machpowersystems/spree_mach,welitonfreitas/spree,patdec/spree,Hawaiideveloper/shoppingcart,TimurTarasenko/spree,carlesjove/spree,firman/spree,vinayvinsol/spree,locomotivapro/spree,gregoryrikson/spree-sample,kewaunited/spree,azranel/spree,vinsol/spree,azclick/spree,hoanghiep90/spree,Machpowersystems/spree_mach,project-eutopia/spree,sunny2601/spree,azclick/spree,surfdome/spree,Nevensoft/spree,delphsoft/spree-store-ballchair,shioyama/spree,JuandGirald/spree,softr8/spree,trigrass2/spree,cutefrank/spree,abhishekjain16/spree,abhishekjain16/spree,knuepwebdev/FloatTubeRodHolders,tomash/spree,SadTreeFriends/spree,josephholsten/plain-sight,zamiang/spree,judaro13/spree-fork,SadTreeFriends/spree,Boomkat/spree,builtbybuffalo/spree,freerunningtech/spree,mleglise/spree,vulk/spree,archSeer/spree,bricesanchez/spree,builtbybuffalo/spree,Senjai/solidus,groundctrl/spree,jspizziri/spree,sliaquat/spree,gautamsawhney/spree,mindvolt/spree,jasonfb/spree,CiscoCloud/spree,archSeer/spree,joanblake/spree,shioyama/spree,dandanwei/spree,caiqinghua/spree,DarkoP/spree,lsirivong/spree,jimblesm/spree,Antdesk/karpal-spree,kewaunited/spree,vulk/spree,RatioClothing/spree,RatioClothing/spree,mindvolt/spree,richardnuno/solidus,grzlus/spree,miyazawatomoka/spree,NerdsvilleCEO/spree,progsri/spree,watg/spree,TrialGuides/spree,pervino/solidus,codesavvy/sandbox,locomotivapro/spree,ramkumar-kr/spree,piousbox/spree,madetech/spree,surfdome/spree,pulkit21/spree,fahidnasir/spree,SadTreeFriends/spree,vulk/spree,piousbox/spree,Hawaiideveloper/shoppingcart,jsurdilla/solidus,pjmj777/spree,dotandbo/spree,dafontaine/spree,JDutil/spree,reidblomquist/spree,sliaquat/spree,njerrywerry/spree,vinsol/spree,hifly/spree,Mayvenn/spree,Hates/spree,Boomkat/spree,njerrywerry/spree,richardnuno/solidus,berkes/spree,bonobos/solidus,devilcoders/solidus,tesserakt/clean_spree,jordan-brough/solidus,preston-scott/spree,welitonfreitas/spree,athal7/solidus,pjmj777/spree,project-eutopia/spree,vmatekole/spree,rbngzlv/spree,jeffboulet/spree,tailic/spree,reinaris/spree,brchristian/spree,kewaunited/spree,trigrass2/spree,vcavallo/spree,yiqing95/spree,Senjai/solidus,fahidnasir/spree,jparr/spree,groundctrl/spree,ujai/spree,ckk-scratch/solidus,raow/spree,progsri/spree,jimblesm/spree,Migweld/spree,hifly/spree,dotandbo/spree,JDutil/spree,CJMrozek/spree,alepore/spree,ayb/spree,lsirivong/solidus,JuandGirald/spree,StemboltHQ/spree,jspizziri/spree,Hates/spree,jhawthorn/spree,sfcgeorge/spree,forkata/solidus,edgward/spree,ayb/spree,net2b/spree,mleglise/spree,ckk-scratch/solidus,degica/spree,alepore/spree,rbngzlv/spree,tesserakt/clean_spree,yomishra/pce,firman/spree,hoanghiep90/spree,pulkit21/spree,tailic/spree,priyank-gupta/spree,Arpsara/solidus,wolfieorama/spree,siddharth28/spree,agient/agientstorefront,maybii/spree,jordan-brough/solidus,reinaris/spree,Migweld/spree,watg/spree,welitonfreitas/spree,locomotivapro/spree,Hawaiideveloper/shoppingcart,delphsoft/spree-store-ballchair,NerdsvilleCEO/spree,shekibobo/spree,ckk-scratch/solidus,jaspreet21anand/spree,cutefrank/spree,rakibulislam/spree,jordan-brough/solidus,rakibulislam/spree,gotoAndBliss/True-Jersey,volpejoaquin/spree,ujai/spree,APohio/spree,PhoenixTeam/spree_phoenix,CJMrozek/spree,FadliKun/spree,pervino/solidus