mandatory inlining was using an iterator pointing to the ApplyInst it inlines after it was invalidated.  This was exposed by an unrelated change I'm about to land.  Fixing this required reworking a few things, and  unfortunately seems to have broken the string O(1) optimization again.
mandatory inlining was using an iterator pointing to the ApplyInst
it inlines after it was invalidated.  This was exposed by an unrelated
change I'm about to land.  Fixing this required reworking a few things, and 
unfortunately seems to have broken the string O(1) optimization again.


Swift SVN r9905

LeoShimonaka/swift,SwiftAndroid/swift,rudkx/swift,ben-ng/swift,codestergit/swift,deyton/swift,emilstahl/swift,frootloops/swift,gribozavr/swift,tardieu/swift,arvedviehweger/swift,therealbnut/swift,mightydeveloper/swift,kentya6/swift,johnno1962d/swift,gmilos/swift,parkera/swift,MukeshKumarS/Swift,tardieu/swift,russbishop/swift,hooman/swift,Ivacker/swift,gregomni/swift,jckarter/swift,sdulal/swift,emilstahl/swift,johnno1962d/swift,cbrentharris/swift,Ivacker/swift,bitjammer/swift,kstaring/swift,danielmartin/swift,ken0nek/swift,aschwaighofer/swift,calebd/swift,swiftix/swift.old,MukeshKumarS/Swift,benlangmuir/swift,gottesmm/swift,milseman/swift,OscarSwanros/swift,codestergit/swift,shahmishal/swift,shahmishal/swift,calebd/swift,SwiftAndroid/swift,xedin/swift,airspeedswift/swift,johnno1962d/swift,milseman/swift,sdulal/swift,therealbnut/swift,gmilos/swift,jmgc/swift,austinzheng/swift,xwu/swift,swiftix/swift.old,MukeshKumarS/Swift,djwbrown/swift,jtbandes/swift,jmgc/swift,kstaring/swift,ben-ng/swift,amraboelela/swift,slavapestov/swift,djwbrown/swift,aschwaighofer/swift,Jnosh/swift,JaSpa/swift,lorentey/swift,hooman/swift,aschwaighofer/swift,lorentey/swift,JaSpa/swift,xwu/swift,sschiau/swift,mightydeveloper/swift,nathawes/swift,return/swift,calebd/swift,emilstahl/swift,cbrentharris/swift,apple/swift,KrishMunot/swift,ken0nek/swift,rudkx/swift,zisko/swift,tinysun212/swift-windows,manavgabhawala/swift,danielmartin/swift,JaSpa/swift,bitjammer/swift,alblue/swift,gottesmm/swift,milseman/swift,tinysun212/swift-windows,tinysun212/swift-windows,Ivacker/swift,CodaFi/swift,arvedviehweger/swift,devincoughlin/swift,glessard/swift,tkremenek/swift,gmilos/swift,tinysun212/swift-windows,SwiftAndroid/swift,calebd/swift,allevato/swift,tkremenek/swift,huonw/swift,kentya6/swift,kperryua/swift,benlangmuir/swift,slavapestov/swift,natecook1000/swift,nathawes/swift,KrishMunot/swift,kusl/swift,SwiftAndroid/swift,deyton/swift,Ivacker/swift,ahoppen/swift,bitjammer/swift,glessard/swift,roambotics/swift,kperryua/swift,khizkhiz/swift,nathawes/swift,stephentyrone/swift,frootloops/swift,JGiola/swift,gregomni/swift,OscarSwanros/swift,hughbe/swift,dduan/swift,kentya6/swift,djwbrown/swift,hooman/swift,OscarSwanros/swift,arvedviehweger/swift,manavgabhawala/swift,practicalswift/swift,lorentey/swift,russbishop/swift,practicalswift/swift,brentdax/swift,OscarSwanros/swift,felix91gr/swift,deyton/swift,karwa/swift,amraboelela/swift,felix91gr/swift,devincoughlin/swift,djwbrown/swift,sschiau/swift,nathawes/swift,kusl/swift,stephentyrone/swift,deyton/swift,codestergit/swift,kusl/swift,swiftix/swift,KrishMunot/swift,airspeedswift/swift,OscarSwanros/swift,felix91gr/swift,roambotics/swift,jopamer/swift,kusl/swift,zisko/swift,return/swift,kentya6/swift,slavapestov/swift,felix91gr/swift,kperryua/swift,jtbandes/swift,russbishop/swift,shahmishal/swift,adrfer/swift,gottesmm/swift,khizkhiz/swift,practicalswift/swift,parkera/swift,arvedviehweger/swift,Jnosh/swift,danielmartin/swift,hooman/swift,Jnosh/swift,zisko/swift,LeoShimonaka/swift,swiftix/swift.old,tinysun212/swift-windows,therealbnut/swift,practicalswift/swift,johnno1962d/swift,zisko/swift,khizkhiz/swift,ben-ng/swift,gmilos/swift,harlanhaskins/swift,codestergit/swift,karwa/swift,atrick/swift,kentya6/swift,parkera/swift,aschwaighofer/swift,LeoShimonaka/swift,karwa/swift,swiftix/swift,JGiola/swift,allevato/swift,shajrawi/swift,kperryua/swift,uasys/swift,jopamer/swift,shajrawi/swift,milseman/swift,tinysun212/swift-windows,ken0nek/swift,tkremenek/swift,danielmartin/swift,gottesmm/swift,calebd/swift,roambotics/swift,jmgc/swift,frootloops/swift,emilstahl/swift,gregomni/swift,parkera/swift,modocache/swift,xedin/swift,atrick/swift,shahmishal/swift,IngmarStein/swift,stephentyrone/swift,ahoppen/swift,jopamer/swift,ken0nek/swift,hughbe/swift,rudkx/swift,therealbnut/swift,gottesmm/swift,bitjammer/swift,roambotics/swift,johnno1962d/swift,allevato/swift,brentdax/swift,swiftix/swift.old,sschiau/swift,tardieu/swift,jckarter/swift,harlanhaskins/swift,codestergit/swift,russbishop/swift,gmilos/swift,manavgabhawala/swift,CodaFi/swift,natecook1000/swift,modocache/swift,devincoughlin/swift,mightydeveloper/swift,JaSpa/swift,MukeshKumarS/Swift,kusl/swift,ahoppen/swift,frootloops/swift,tardieu/swift,dduan/swift,jmgc/swift,brentdax/swift,OscarSwanros/swift,russbishop/swift,stephentyrone/swift,ben-ng/swift,tardieu/swift,airspeedswift/swift,modocache/swift,huonw/swift,practicalswift/swift,austinzheng/swift,codestergit/swift,milseman/swift,tardieu/swift,emilstahl/swift,austinzheng/swift,emilstahl/swift,alblue/swift,ben-ng/swift,gmilos/swift,djwbrown/swift,danielmartin/swift,glessard/swift,alblue/swift,allevato/swift,sdulal/swift,JaSpa/swift,hughbe/swift,karwa/swift,emilstahl/swift,manavgabhawala/swift,rudkx/swift,kusl/swift,Jnosh/swift,shajrawi/swift,ben-ng/swift,sschiau/swift,adrfer/swift,gregomni/swift,airspeedswift/swift,russbishop/swift,CodaFi/swift,natecook1000/swift,sschiau/swift,dduan/swift,Jnosh/swift,gribozavr/swift,allevato/swift,sschiau/swift,harlanhaskins/swift,khizkhiz/swift,felix91gr/swift,mightydeveloper/swift,LeoShimonaka/swift,airspeedswift/swift,felix91gr/swift,jmgc/swift,tjw/swift,hooman/swift,KrishMunot/swift,amraboelela/swift,gregomni/swift,arvedviehweger/swift,manavgabhawala/swift,djwbrown/swift,Ivacker/swift,apple/swift,lorentey/swift,jmgc/swift,jtbandes/swift,kusl/swift,swiftix/swift,MukeshKumarS/Swift,hughbe/swift,atrick/swift,return/swift,bitjammer/swift,xedin/swift,modocache/swift,karwa/swift,jckarter/swift,xwu/swift,parkera/swift,benlangmuir/swift,LeoShimonaka/swift,jckarter/swift,tkremenek/swift,IngmarStein/swift,gribozavr/swift,jopamer/swift,xedin/swift,tardieu/swift,tjw/swift,kstaring/swift,dduan/swift,mightydeveloper/swift,zisko/swift,sdulal/swift,karwa/swift,calebd/swift,tkremenek/swift,jckarter/swift,allevato/swift,brentdax/swift,gribozavr/swift,dduan/swift,bitjammer/swift,khizkhiz/swift,kentya6/swift,IngmarStein/swift,milseman/swift,ken0nek/swift,swiftix/swift.old,xedin/swift,amraboelela/swift,huonw/swift,huonw/swift,jopamer/swift,shajrawi/swift,johnno1962d/swift,huonw/swift,hughbe/swift,xedin/swift,gottesmm/swift,frootloops/swift,xwu/swift,danielmartin/swift,harlanhaskins/swift,tjw/swift,slavapestov/swift,CodaFi/swift,natecook1000/swift,huonw/swift,jtbandes/swift,tjw/swift,dduan/swift,frootloops/swift,sdulal/swift,cbrentharris/swift,hughbe/swift,uasys/swift,gribozavr/swift,deyton/swift,devincoughlin/swift,JGiola/swift,therealbnut/swift,codestergit/swift,KrishMunot/swift,swiftix/swift.old,SwiftAndroid/swift,nathawes/swift,ben-ng/swift,cbrentharris/swift,roambotics/swift,austinzheng/swift,kentya6/swift,xwu/swift,alblue/swift,swiftix/swift,swiftix/swift.old,brentdax/swift,Ivacker/swift,devincoughlin/swift,jtbandes/swift,adrfer/swift,hughbe/swift,cbrentharris/swift,JGiola/swift,ahoppen/swift,nathawes/swift,karwa/swift,kstaring/swift,tkremenek/swift,amraboelela/swift,mightydeveloper/swift,amraboelela/swift,JGiola/swift,JaSpa/swift,return/swift,adrfer/swift,atrick/swift,MukeshKumarS/Swift,kperryua/swift,calebd/swift,ahoppen/swift,jopamer/swift,roambotics/swift,hooman/swift,CodaFi/swift,shahmishal/swift,modocache/swift,hooman/swift,stephentyrone/swift,shajrawi/swift,apple/swift,LeoShimonaka/swift,khizkhiz/swift,brentdax/swift,return/swift,aschwaighofer/swift,slavapestov/swift,Ivacker/swift,tkremenek/swift,shahmishal/swift,lorentey/swift,karwa/swift,khizkhiz/swift,stephentyrone/swift,apple/swift,gribozavr/swift,jtbandes/swift,modocache/swift,benlangmuir/swift,benlangmuir/swift,natecook1000/swift,harlanhaskins/swift,xwu/swift,tjw/swift,mightydeveloper/swift,tjw/swift,return/swift,aschwaighofer/swift,amraboelela/swift,harlanhaskins/swift,gmilos/swift,kstaring/swift,jckarter/swift,arvedviehweger/swift,milseman/swift,huonw/swift,adrfer/swift,sschiau/swift,IngmarStein/swift,manavgabhawala/swift,SwiftAndroid/swift,Jnosh/swift,johnno1962d/swift,practicalswift/swift,arvedviehweger/swift,stephentyrone/swift,swiftix/swift,Jnosh/swift,IngmarStein/swift,tjw/swift,sdulal/swift,kusl/swift,alblue/swift,adrfer/swift,parkera/swift,austinzheng/swift,cbrentharris/swift,rudkx/swift,jtbandes/swift,jopamer/swift,CodaFi/swift,return/swift,parkera/swift,uasys/swift,manavgabhawala/swift,IngmarStein/swift,austinzheng/swift,shajrawi/swift,glessard/swift,gottesmm/swift,rudkx/swift,KrishMunot/swift,nathawes/swift,Ivacker/swift,shajrawi/swift,brentdax/swift,kstaring/swift,devincoughlin/swift,deyton/swift,airspeedswift/swift,shahmishal/swift,OscarSwanros/swift,dreamsxin/swift,zisko/swift,kstaring/swift,tinysun212/swift-windows,sdulal/swift,practicalswift/swift,zisko/swift,harlanhaskins/swift,uasys/swift,russbishop/swift,devincoughlin/swift,frootloops/swift,gribozavr/swift,sschiau/swift,xwu/swift,dreamsxin/swift,lorentey/swift,swiftix/swift,atrick/swift,sdulal/swift,dduan/swift,adrfer/swift,ahoppen/swift,deyton/swift,djwbrown/swift,practicalswift/swift,cbrentharris/swift,MukeshKumarS/Swift,benlangmuir/swift,kperryua/swift,austinzheng/swift,slavapestov/swift,cbrentharris/swift,gribozavr/swift,modocache/swift,bitjammer/swift,uasys/swift,swiftix/swift.old,alblue/swift,therealbnut/swift,CodaFi/swift,lorentey/swift,kentya6/swift,slavapestov/swift,SwiftAndroid/swift,alblue/swift,aschwaighofer/swift,uasys/swift,atrick/swift,ken0nek/swift,KrishMunot/swift,gregomni/swift,natecook1000/swift,jckarter/swift,swiftix/swift,LeoShimonaka/swift,glessard/swift,mightydeveloper/swift,ken0nek/swift,devincoughlin/swift,lorentey/swift,xedin/swift,uasys/swift,danielmartin/swift,JGiola/swift,apple/swift,jmgc/swift,parkera/swift,airspeedswift/swift,apple/swift,JaSpa/swift,kperryua/swift,glessard/swift,therealbnut/swift,shahmishal/swift,IngmarStein/swift,felix91gr/swift,emilstahl/swift,xedin/swift,natecook1000/swift,allevato/swift,LeoShimonaka/swift,shajrawi/swift