test: use pointers in denialofservice_tests/peer_discouragement
test: use pointers in denialofservice_tests/peer_discouragement

This is a non-functional change that replaces the `CNode` on-stack
variables with `CNode` pointers.

The reason for this is that it would allow us to add those `CNode`s
to `CConnman::vNodes[]` which in turn would allow us to check that they
are disconnected properly - a `CNode` object must be in
`CConnman::vNodes[]` in order for its `fDisconnect` flag to be set.

If we store pointers to the on-stack variables in `CConnman` then it
would crash at the end, trying to `delete` them.

prusnak/bitcoin,mruddy/bitcoin,namecoin/namecoin-core,andreaskern/bitcoin,jambolo/bitcoin,ElementsProject/elements,achow101/bitcoin,jlopp/statoshi,sstone/bitcoin,pataquets/namecoin-core,namecoin/namecore,ElementsProject/elements,kallewoof/bitcoin,domob1812/bitcoin,bitcoinsSG/bitcoin,jamesob/bitcoin,tecnovert/particl-core,sipsorcery/bitcoin,particl/particl-core,GroestlCoin/GroestlCoin,bitcoinknots/bitcoin,mm-s/bitcoin,bitcoin/bitcoin,prusnak/bitcoin,domob1812/namecore,yenliangl/bitcoin,namecoin/namecore,bitcoinknots/bitcoin,ElementsProject/elements,apoelstra/bitcoin,instagibbs/bitcoin,AkioNak/bitcoin,fujicoin/fujicoin,sstone/bitcoin,jamesob/bitcoin,fujicoin/fujicoin,JeremyRubin/bitcoin,AkioNak/bitcoin,GroestlCoin/bitcoin,pataquets/namecoin-core,dscotese/bitcoin,jamesob/bitcoin,lateminer/bitcoin,Xekyo/bitcoin,andreaskern/bitcoin,tecnovert/particl-core,bitcoin/bitcoin,jlopp/statoshi,MarcoFalke/bitcoin,qtumproject/qtum,jambolo/bitcoin,sipsorcery/bitcoin,Xekyo/bitcoin,kallewoof/bitcoin,mruddy/bitcoin,jlopp/statoshi,jamesob/bitcoin,achow101/bitcoin,ajtowns/bitcoin,mm-s/bitcoin,GroestlCoin/GroestlCoin,prusnak/bitcoin,bitcoinsSG/bitcoin,anditto/bitcoin,Xekyo/bitcoin,instagibbs/bitcoin,fujicoin/fujicoin,domob1812/bitcoin,qtumproject/qtum,namecoin/namecoin-core,GroestlCoin/bitcoin,qtumproject/qtum,sstone/bitcoin,particl/particl-core,Xekyo/bitcoin,JeremyRubin/bitcoin,dscotese/bitcoin,AkioNak/bitcoin,tecnovert/particl-core,apoelstra/bitcoin,domob1812/bitcoin,mm-s/bitcoin,andreaskern/bitcoin,kallewoof/bitcoin,domob1812/bitcoin,rnicoll/bitcoin,sipsorcery/bitcoin,instagibbs/bitcoin,yenliangl/bitcoin,namecoin/namecore,qtumproject/qtum,domob1812/namecore,yenliangl/bitcoin,dscotese/bitcoin,dscotese/bitcoin,bitcoin/bitcoin,bitcoinknots/bitcoin,achow101/bitcoin,lateminer/bitcoin,anditto/bitcoin,particl/particl-core,fanquake/bitcoin,fanquake/bitcoin,mm-s/bitcoin,pataquets/namecoin-core,sipsorcery/bitcoin,Xekyo/bitcoin,domob1812/namecore,apoelstra/bitcoin,sstone/bitcoin,lateminer/bitcoin,MarcoFalke/bitcoin,MarcoFalke/bitcoin,jamesob/bitcoin,sipsorcery/bitcoin,domob1812/bitcoin,domob1812/namecore,JeremyRubin/bitcoin,namecoin/namecore,jambolo/bitcoin,dscotese/bitcoin,MarcoFalke/bitcoin,GroestlCoin/GroestlCoin,jlopp/statoshi,AkioNak/bitcoin,bitcoinsSG/bitcoin,JeremyRubin/bitcoin,fujicoin/fujicoin,pataquets/namecoin-core,bitcoinknots/bitcoin,prusnak/bitcoin,rnicoll/bitcoin,namecoin/namecoin-core,lateminer/bitcoin,kallewoof/bitcoin,mruddy/bitcoin,GroestlCoin/GroestlCoin,prusnak/bitcoin,tecnovert/particl-core,GroestlCoin/bitcoin,namecoin/namecoin-core,fanquake/bitcoin,fanquake/bitcoin,lateminer/bitcoin,domob1812/namecore,instagibbs/bitcoin,particl/particl-core,andreaskern/bitcoin,bitcoinknots/bitcoin,bitcoinsSG/bitcoin,rnicoll/bitcoin,instagibbs/bitcoin,apoelstra/bitcoin,mruddy/bitcoin,qtumproject/qtum,domob1812/bitcoin,yenliangl/bitcoin,AkioNak/bitcoin,namecoin/namecoin-core,GroestlCoin/GroestlCoin,JeremyRubin/bitcoin,GroestlCoin/bitcoin,ElementsProject/elements,anditto/bitcoin,fujicoin/fujicoin,tecnovert/particl-core,ajtowns/bitcoin,bitcoin/bitcoin,mm-s/bitcoin,achow101/bitcoin,andreaskern/bitcoin,MarcoFalke/bitcoin,JeremyRubin/bitcoin,ajtowns/bitcoin,mruddy/bitcoin,jlopp/statoshi,bitcoinsSG/bitcoin,rnicoll/bitcoin,jambolo/bitcoin,ajtowns/bitcoin,GroestlCoin/GroestlCoin,fanquake/bitcoin,achow101/bitcoin,domob1812/namecore,tecnovert/particl-core,sstone/bitcoin,bitcoin/bitcoin,bitcoin/bitcoin,mruddy/bitcoin,GroestlCoin/bitcoin,prusnak/bitcoin,jlopp/statoshi,jamesob/bitcoin,achow101/bitcoin,ajtowns/bitcoin,yenliangl/bitcoin,particl/particl-core,apoelstra/bitcoin,anditto/bitcoin,qtumproject/qtum,ElementsProject/elements,jambolo/bitcoin,namecoin/namecore,bitcoinsSG/bitcoin,instagibbs/bitcoin,Xekyo/bitcoin,rnicoll/bitcoin,dscotese/bitcoin,ajtowns/bitcoin,mm-s/bitcoin,lateminer/bitcoin,kallewoof/bitcoin,AkioNak/bitcoin,pataquets/namecoin-core,yenliangl/bitcoin,kallewoof/bitcoin,andreaskern/bitcoin,MarcoFalke/bitcoin,jambolo/bitcoin,ElementsProject/elements,qtumproject/qtum,fujicoin/fujicoin,apoelstra/bitcoin,sstone/bitcoin,GroestlCoin/bitcoin,namecoin/namecoin-core,fanquake/bitcoin,sipsorcery/bitcoin,particl/particl-core,anditto/bitcoin,anditto/bitcoin,pataquets/namecoin-core,namecoin/namecore,rnicoll/bitcoin