fix up cases when referencing the wrong token expiry
fix up cases when referencing the wrong token expiry

Fixed up a few missed cases of not referencing the correct
expiry attribute on the access token. We need to reference
permanent_expires_at instead of expires_at since our change
to adding a permanently expired at tokens column vs the original
tokens that had expired in need of a refresh.

fixes FOO-2574
flag = none

test plan:
• Navigate to /profile/settings
• Generate a new access token with an expiry
• After generating the token ensure the expiry is visible
  in-line and when clicking on the access token details
• Refresh the page and verify the same behavior as above
• Verify access tokens with no expiry still function as they
  did before
• Verify regenerated access tokens display the exiry in
  Access Token Details

 Please enter the commit message for your changes. Lines starting

Change-Id: I160d7f6cdcdd4119f68c438a19fd32d9d0046c2c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282554
Tested-by: Service Cloud Jenkins <9144042a601061f88f1e1d7a1753ea3e2972119d@instructure.com>
Reviewed-by: Ben Rinaca <55a6093a45d41fed7a0fcf1e8dbdc41f5092bc04@instructure.com>
QA-Review: August Thornton <9adc7a1161ddf32ff608de792a7e50179545f026@instructure.com>
Product-Review: August Thornton <9adc7a1161ddf32ff608de792a7e50179545f026@instructure.com>

sfu/canvas-lms,sfu/canvas-lms,sfu/canvas-lms,sfu/canvas-lms,sfu/canvas-lms,sfu/canvas-lms,sfu/canvas-lms