fix most lint warnings
fix most lint warnings

The ones that remain are due to using "old-style iteration":

https://docs.puppetlabs.com/puppet/latest/reference/lang_iteration.html#old-style-iteration-with-defined-types

    modules/whimsy_server/manifests/init.pp - ERROR: whimsy_server::ruby::symlink not in autoload module layout on line 75
    modules/whimsy_server/manifests/init.pp - ERROR: whimsy_server::rvm::symlink
not in autoload module layout on line 84
    modules/whimsy_server/manifests/init.pp - WARNING: defined type defined inside a class on line 75
    modules/whimsy_server/manifests/init.pp - WARNING: defined type defined inside
a class on line 84

chtyim/infrastructure-puppet,sebbASF/infrastructure-puppet,sebbASF/infrastructure-puppet,sebbASF/infrastructure-puppet,chtyim/infrastructure-puppet,sebbASF/infrastructure-puppet,apache/infrastructure-puppet,sebbASF/infrastructure-puppet,apache/infrastructure-puppet,chtyim/infrastructure-puppet,apache/infrastructure-puppet,chtyim/infrastructure-puppet,chtyim/infrastructure-puppet,sebbASF/infrastructure-puppet,apache/infrastructure-puppet,apache/infrastructure-puppet,apache/infrastructure-puppet,apache/infrastructure-puppet,sebbASF/infrastructure-puppet,chtyim/infrastructure-puppet,sebbASF/infrastructure-puppet