Don't override notify! in ScheduledEditionPublisher
Don't override notify! in ScheduledEditionPublisher

I believe the intention here was to suppress non-critical errors
relating to ScheduledPublishing. However, the way the publishing
actually happens currently, relies on a listener, specifically the one
for the Publishing API.

So, if the now-critical part of scheduled publishing fails, this
attempt to suppress non-critical errors will actually catch errors
relating to the critical parts of scheduled publishing. This has
knock-on effects, as the monitoring for scheduled publishing depends
on the Whitehall state, and supressing these exceptions means that the
state will still transition to published.

It's only since the Publishing API interaction for publishing moved
out of Sidekiq [1] that this became relevant, as before, the exception
would have occured in a disconnected Sidekiq job. Now, at least it
propagates up to here.

1: 5747885413bdf2d382f6edf4563a1c26c09bc688

Ideally, the Publishing API interaction would move out of the listener
to make the code clearer, and avoid conflating it with other actions,
but for now, by not supressing the exceptions, the code is a little
simpler, and the monitoring should detect scheduled publishing
failures.

Unfortunately, this applies to everything on the message bus, so we'll
have to watch out for spurious alerts based on non-critical failures.

alphagov/whitehall,alphagov/whitehall,alphagov/whitehall,alphagov/whitehall