Fix libraries jobs
Fix libraries jobs

So that we run testing on puppet 4 and
puppet 5 for libraries where both are voting.

We are still having the job running the latest
puppet version unit tests but as non voting which
is the same as for the integration tests.

Also removes puppet 3 syntax and adds puppet 5.

Change-Id: I5f78c19922677265cac54a39b29d8b9111bf2b52

openstack/puppet-openstack-integration,openstack/puppet-openstack-integration,openstack/puppet-openstack-integration