prevent xss in modules' "Move To..." dialog, fixes CNVS-17662
prevent xss in modules' "Move To..." dialog, fixes CNVS-17662

ensure we properly escape module and item names when presenting them as
options in the dialog

also ensure translations are escaped, and rename some variables to
appease the linter

test plan: infer from the above, or see ticket for more info

Change-Id: I8cc16bb9828db8653843b5bbd35dc49bac6d0c00
Reviewed-on: https://gerrit.instructure.com/46294
Tested-by: Jenkins <d95b56ce41a2e1ac4cecdd398defd7414407cc08@instructure.com>
Reviewed-by: Jeremy Stanley <b3f594e10a9edcf5413cf1190121d45078c62290@instructure.com>
QA-Review: Caleb Guanzon <54fa1f30d451e4f3c341a8f3c47c9215fd0be9c6@instructure.com>
Product-Review: Jon Jensen <44f878afe53efc66b76772bd845eb65944ed8232@instructure.com>

HotChalk/canvas-lms,venturehive/canvas-lms,ShreniiNepal/shrenii_lmp,skmezanul/canvas-lms,va7map/canvas-lms,HotChalk/canvas-lms,va7map/canvas-lms,grahamb/canvas-lms,utkarshx/canvas-lms,sfu/canvas-lms,greyhwndz/canvas-lms,juoni/canvas-lms,grahamb/canvas-lms,leftplusrightllc/canvas-lms,jay3126/canvas-lms,wrdsb/canvas-lms,Jyaasa/canvas-lms,sfu/canvas-lms,utkarshx/canvas-lms,fronteerio/canvas-lms,venturehive/canvas-lms,wrdsb/canvas-lms,roxolan/canvas-lms,antoniuslin/canvas-lms,shidao-fm/canvas-lms,skmezanul/canvas-lms,wrdsb/canvas-lms,juoni/canvas-lms,sdeleon28/canvas-lms,SwinburneOnline/canvas-lms,va7map/canvas-lms,utkarshx/canvas-lms,leftplusrightllc/canvas-lms,samuels410/greatlakes-lms,Jyaasa/canvas-lms,samuels410/greatlakes-lms,fronteerio/canvas-lms,efrj/canvas-lms,greyhwndz/canvas-lms,kyroskoh/canvas-lms,sdeleon28/canvas-lms,Rvor/canvas-lms,ShreniiNepal/shrenii_lmp,whalejasmine/canvas-lms,venturehive/canvas-lms,tgroshon/canvas-lms,shidao-fm/canvas-lms,ShreniiNepal/shrenii_lmp,tgroshon/canvas-lms,redconfetti/canvas-lms,jay3126/canvas-lms,Rvor/canvas-lms,djbender/canvas-lms,djbender/canvas-lms,jay3126/canvas-lms,roxolan/canvas-lms,sfu/canvas-lms,leftplusrightllc/canvas-lms,SwinburneOnline/canvas-lms,djbender/canvas-lms,redconfetti/canvas-lms,fronteerio/canvas-lms,tgroshon/canvas-lms,grahamb/canvas-lms,roxolan/canvas-lms,fronteerio/canvas-lms,greyhwndz/canvas-lms,shidao-fm/canvas-lms,djbender/canvas-lms,utkarshx/canvas-lms,Rvor/canvas-lms,whalejasmine/canvas-lms,juoni/canvas-lms,wrdsb/canvas-lms,skmezanul/canvas-lms,HotChalk/canvas-lms,sfu/canvas-lms,sfu/canvas-lms,kyroskoh/canvas-lms,juoni/canvas-lms,SwinburneOnline/canvas-lms,samuels410/greatlakes-lms,shidao-fm/canvas-lms,kyroskoh/canvas-lms,HotChalk/canvas-lms,antoniuslin/canvas-lms,va7map/canvas-lms,efrj/canvas-lms,leftplusrightllc/canvas-lms,efrj/canvas-lms,sfu/canvas-lms,efrj/canvas-lms,sdeleon28/canvas-lms,antoniuslin/canvas-lms,Rvor/canvas-lms,jay3126/canvas-lms,skmezanul/canvas-lms,grahamb/canvas-lms,sfu/canvas-lms,sdeleon28/canvas-lms,tgroshon/canvas-lms,Jyaasa/canvas-lms,Jyaasa/canvas-lms,whalejasmine/canvas-lms,greyhwndz/canvas-lms,grahamb/canvas-lms,SwinburneOnline/canvas-lms,antoniuslin/canvas-lms,kyroskoh/canvas-lms,roxolan/canvas-lms,venturehive/canvas-lms,redconfetti/canvas-lms,whalejasmine/canvas-lms,ShreniiNepal/shrenii_lmp,redconfetti/canvas-lms,samuels410/greatlakes-lms