Redmine #5994 Standardize source port button
Redmine #5994 Standardize source port button

in firewall_rules_edit
1) Put some common code fragments into show_source_port_range() and use code that actually successfully changes the button text Display/Hide. Around line 1808.
2) Make the button itself be hidden when a protocol is selected that does not use source port range (as well as the source port fields being hidden) - line 1908-1909
3) When the user re-selects a protocol that can use source port range, unhide the button and set the button text and hide/unhide of source port fields appropriately depending on the run-time values in the source port fields - line 1900-1905

This standardizes the behavior of the source port Advanced button.

I will do the other general advanced button separately.
ch1c4um/pfsense,BlackstarGroup/pfsense,pfsense/pfsense,NewEraCracker/pfsense,ch1c4um/pfsense,brunostein/pfsense,brunostein/pfsense,jxmx/pfsense,BlackstarGroup/pfsense,NewEraCracker/pfsense,pfsense/pfsense,NewEraCracker/pfsense,dennypage/pfsense,NOYB/pfsense,ch1c4um/pfsense,dennypage/pfsense,phil-davis/pfsense,jxmx/pfsense,phil-davis/pfsense,NewEraCracker/pfsense,dennypage/pfsense,brunostein/pfsense,ptorsten/pfsense,NOYB/pfsense,phil-davis/pfsense,pfsense/pfsense,phil-davis/pfsense,ch1c4um/pfsense,ptorsten/pfsense,BlackstarGroup/pfsense,BlackstarGroup/pfsense,jxmx/pfsense,pfsense/pfsense,ptorsten/pfsense,dennypage/pfsense,NOYB/pfsense