[oc-chef-pedant] Fix search tests incorrectly using with_search_polling
[oc-chef-pedant] Fix search tests incorrectly using with_search_polling

with_search_polling works by retrying when an exception is raised. An
empty response from search will not raise an exception, rather the
assertions on the results should also be inside the with_search_polling
block.

chef/chef-server,stephenbm/chef-server,chef/chef-server,poliva83/chef-server,stephenbm/chef-server,poliva83/chef-server,itmustbejj/chef-server,marcparadise/chef-server,juliandunn/chef-server-1,itmustbejj/chef-server,marcparadise/chef-server,juliandunn/chef-server-1,juliandunn/chef-server-1,poliva83/chef-server,stephenbm/chef-server,juliandunn/chef-server-1,marcparadise/chef-server,chef/chef-server,itmustbejj/chef-server,stephenbm/chef-server,stephenbm/chef-server,itmustbejj/chef-server,marcparadise/chef-server,poliva83/chef-server,chef/chef-server,marcparadise/chef-server,chef/chef-server,chef/chef-server,poliva83/chef-server,itmustbejj/chef-server,juliandunn/chef-server-1