Fix invalid memory access on 2x downscale.
Fix invalid memory access on 2x downscale.

The issue was discovered on bitstream with 2x vertical downscale. For
zero MVs, y_pad is set to 1 only when vertical convolution is
required. The original code assumes that for y_step_q4 == 32 we don't
perform vertical convolution. But vp9_setup_scale_factors_for_frame()
sets convolve functions so that when x_step and y_step are both not
equal to 16, convolve in both directions is performed. And convolve()
unconditionally subtracts one stride from source pointer when calls
convolve_horiz(). This leads to invalid memory access.

Change-Id: I882dfa6081a58e172b5ffa55842bfcd6727f10bf

Topopiccione/libvpx,iniwf/webm.libvpx,ShiftMediaProject/libvpx,smarter/aom,jmvalin/aom,felipebetancur/libvpx,reimaginemedia/webm.libvpx,stewnorriss/libvpx,hsueceumd/test_hui,luctrudeau/aom,Acidburn0zzz/webm.libvpx,zofuthan/libvpx,Topopiccione/libvpx,jdm/libvpx,luctrudeau/aom,hsueceumd/test_hui,luctrudeau/aom,matanbs/vp982,shareefalis/libvpx,openpeer/libvpx_new,altogother/webm.libvpx,altogother/webm.libvpx,jmvalin/aom,jacklicn/webm.libvpx,ittiamvpx/libvpx-1,lyx2014/libvpx_c,pcwalton/libvpx,Laknot/libvpx,shacklettbp/aom,shyamalschandra/libvpx,Laknot/libvpx,jmvalin/aom,abwiz0086/webm.libvpx,altogother/webm.libvpx,webmproject/libvpx,reimaginemedia/webm.libvpx,Acidburn0zzz/webm.libvpx,mbebenita/aom,shareefalis/libvpx,jmvalin/aom,reimaginemedia/webm.libvpx,kim42083/webm.libvpx,kim42083/webm.libvpx,liqianggao/libvpx,abwiz0086/webm.libvpx,abwiz0086/webm.libvpx,matanbs/webm.libvpx,Laknot/libvpx,felipebetancur/libvpx,lyx2014/libvpx_c,altogother/webm.libvpx,stewnorriss/libvpx,Topopiccione/libvpx,running770/libvpx,Suvarna1488/webm.libvpx,Suvarna1488/webm.libvpx,ShiftMediaProject/libvpx,thdav/aom,Acidburn0zzz/webm.libvpx,charup/https---github.com-webmproject-libvpx-,reimaginemedia/webm.libvpx,smarter/aom,thdav/aom,ittiamvpx/libvpx-1,n4t/libvpx,n4t/libvpx,kim42083/webm.libvpx,felipebetancur/libvpx,Acidburn0zzz/webm.libvpx,mwgoldsmith/vpx,luctrudeau/aom,smarter/aom,kleopatra999/webm.libvpx,zofuthan/libvpx,hsueceumd/test_hui,Distrotech/libvpx,mbebenita/aom,shyamalschandra/libvpx,iniwf/webm.libvpx,mwgoldsmith/libvpx,openpeer/libvpx_new,charup/https---github.com-webmproject-libvpx-,luctrudeau/aom,mwgoldsmith/vpx,mbebenita/aom,zofuthan/libvpx,Suvarna1488/webm.libvpx,Maria1099/webm.libvpx,mwgoldsmith/vpx,GrokImageCompression/aom,mwgoldsmith/libvpx,matanbs/webm.libvpx,Suvarna1488/webm.libvpx,GrokImageCompression/aom,mbebenita/aom,lyx2014/libvpx_c,felipebetancur/libvpx,goodleixiao/vpx,VTCSecureLLC/libvpx,Suvarna1488/webm.libvpx,shyamalschandra/libvpx,mwgoldsmith/vpx,reimaginemedia/webm.libvpx,ittiamvpx/libvpx-1,ittiamvpx/libvpx-1,gshORTON/webm.libvpx,smarter/aom,shareefalis/libvpx,mwgoldsmith/libvpx,thdav/aom,hsueceumd/test_hui,Topopiccione/libvpx,goodleixiao/vpx,webmproject/libvpx,jacklicn/webm.libvpx,Laknot/libvpx,mbebenita/aom,Distrotech/libvpx,zofuthan/libvpx,kleopatra999/webm.libvpx,thdav/aom,matanbs/vp982,running770/libvpx,kleopatra999/webm.libvpx,altogother/webm.libvpx,shacklettbp/aom,kalli123/webm.libvpx,iniwf/webm.libvpx,ittiamvpx/libvpx-1,shyamalschandra/libvpx,Maria1099/webm.libvpx,liqianggao/libvpx,openpeer/libvpx_new,hsueceumd/test_hui,Maria1099/webm.libvpx,kim42083/webm.libvpx,goodleixiao/vpx,gshORTON/webm.libvpx,Distrotech/libvpx,charup/https---github.com-webmproject-libvpx-,webmproject/libvpx,Topopiccione/libvpx,matanbs/vp982,kleopatra999/webm.libvpx,Distrotech/libvpx,running770/libvpx,mwgoldsmith/libvpx,abwiz0086/webm.libvpx,zofuthan/libvpx,n4t/libvpx,gshORTON/webm.libvpx,pcwalton/libvpx,thdav/aom,liqianggao/libvpx,mbebenita/aom,lyx2014/libvpx_c,running770/libvpx,thdav/aom,goodleixiao/vpx,running770/libvpx,kleopatra999/webm.libvpx,jmvalin/aom,openpeer/libvpx_new,stewnorriss/libvpx,mbebenita/aom,n4t/libvpx,matanbs/vp982,kim42083/webm.libvpx,jdm/libvpx,shacklettbp/aom,stewnorriss/libvpx,kalli123/webm.libvpx,smarter/aom,jacklicn/webm.libvpx,matanbs/vp982,webmproject/libvpx,altogother/webm.libvpx,shacklettbp/aom,reimaginemedia/webm.libvpx,zofuthan/libvpx,Maria1099/webm.libvpx,openpeer/libvpx_new,Suvarna1488/webm.libvpx,kleopatra999/webm.libvpx,liqianggao/libvpx,Maria1099/webm.libvpx,VTCSecureLLC/libvpx,GrokImageCompression/aom,liqianggao/libvpx,felipebetancur/libvpx,ShiftMediaProject/libvpx,VTCSecureLLC/libvpx,matanbs/webm.libvpx,matanbs/webm.libvpx,lyx2014/libvpx_c,matanbs/webm.libvpx,mwgoldsmith/libvpx,Maria1099/webm.libvpx,gshORTON/webm.libvpx,felipebetancur/libvpx,abwiz0086/webm.libvpx,pcwalton/libvpx,jdm/libvpx,jdm/libvpx,shacklettbp/aom,jacklicn/webm.libvpx,jdm/libvpx,shareefalis/libvpx,mwgoldsmith/vpx,running770/libvpx,matanbs/vp982,hsueceumd/test_hui,iniwf/webm.libvpx,kalli123/webm.libvpx,goodleixiao/vpx,shareefalis/libvpx,kalli123/webm.libvpx,Distrotech/libvpx,shareefalis/libvpx,stewnorriss/libvpx,ShiftMediaProject/libvpx,Acidburn0zzz/webm.libvpx,GrokImageCompression/aom,pcwalton/libvpx,VTCSecureLLC/libvpx,VTCSecureLLC/libvpx,mwgoldsmith/libvpx,n4t/libvpx,charup/https---github.com-webmproject-libvpx-,matanbs/webm.libvpx,luctrudeau/aom,liqianggao/libvpx,Laknot/libvpx,kalli123/webm.libvpx,abwiz0086/webm.libvpx,gshORTON/webm.libvpx,gshORTON/webm.libvpx,jacklicn/webm.libvpx,smarter/aom,VTCSecureLLC/libvpx,shyamalschandra/libvpx,stewnorriss/libvpx,Acidburn0zzz/webm.libvpx,GrokImageCompression/aom,Topopiccione/libvpx,shyamalschandra/libvpx,jmvalin/aom,pcwalton/libvpx,charup/https---github.com-webmproject-libvpx-,Distrotech/libvpx,ShiftMediaProject/libvpx,mbebenita/aom,lyx2014/libvpx_c,charup/https---github.com-webmproject-libvpx-,mwgoldsmith/vpx,jacklicn/webm.libvpx,webmproject/libvpx,matanbs/vp982,shacklettbp/aom,Laknot/libvpx,pcwalton/libvpx,mbebenita/aom,goodleixiao/vpx,ittiamvpx/libvpx-1,openpeer/libvpx_new,kim42083/webm.libvpx,iniwf/webm.libvpx,iniwf/webm.libvpx,webmproject/libvpx,GrokImageCompression/aom,kalli123/webm.libvpx,jdm/libvpx