NEVER, EVER should modify the stringshared pointer.
NEVER, EVER should modify the stringshared pointer.

That is why stringshare returns "const char*".

ZMike, pay attention to these cases. I know this one was particularly
nasty to spot since you receive the "const char *path", but later on
you request strrchr(path..) and receive "char *p", the cast is done
implicitly by libC to make all the case works (C++ version fixed this
recently, but in C there is no way).

The crash that lead me to investigate it was spot by Lucas De Marchi
at advanced wallpaper dialog, but actually other places that uses efm
should be equaly broken.



SVN revision: 48508

tizenorg/platform.upstream.enlightenment,rvandegrift/e,tasn/enlightenment,rvandegrift/e,rvandegrift/e,tizenorg/platform.upstream.enlightenment,tizenorg/platform.upstream.enlightenment,FlorentRevest/Enlightenment,FlorentRevest/Enlightenment,FlorentRevest/Enlightenment,tasn/enlightenment,tasn/enlightenment