Hotkey-based inventory management now applies the click cooldown to prevent it from being abusable in combat scenarios. (#71325)
Hotkey-based inventory management now applies the click cooldown to prevent it from being abusable in combat scenarios. (#71325)


About The Pull Request

Hotkey-based inventory management now applies the click cooldown to prevent it from being abusable in combat scenarios.
Why It's Good For The Game

Players have been deploying unbelievable levels of abuse with these hotkeys having completely uncapped speeds.
I watched one cheater do automated inventory management using storage items and weirdly named empty pills to use as inventory delimiters.
Resolves people being able to have a baton hidden in their backpack and then activate and baton someone with it in 0.1 seconds without moving their mouse cursor off of their target.

Players should not be able to interact with their inventory faster than someone moving a mouse and clicking the left mouse button. This cripples the game balance and puts anyone with a worse internet connection, slower reaction speeds, or laggier computer at a distinct disadvantage against people who can macro their inventory management.

I can set up autohotkey so that I can withdraw a stun baton from my backpack, turn it on, and then click someone by just holding down a key and pressing M1 over someone. This shit needs to stop.

If a do_after() on hotkey management is too harsh, we can apply a combat click cooldown every time you use the hotkeys instead to discourage combat macro abuse.
Swapped it over to a click cooldown.
Changelog

cl
balance: Hotkey-based inventory management now applies the click cooldown to prevent it from being abusable in combat scenarios.
/cl

Bawhoppen/-tg-station,tgstation/tgstation,tgstation/tgstation,tgstation/tgstation,Bawhoppen/-tg-station,tgstation/tgstation,tgstation/tgstation,tgstation/tgstation,Bawhoppen/-tg-station,Bawhoppen/-tg-station,Bawhoppen/-tg-station,Bawhoppen/-tg-station,tgstation/tgstation,Bawhoppen/-tg-station,Bawhoppen/-tg-station,tgstation/tgstation