Rod's patch does what it is supposed to do, but it also includes some old code to add PK constraints to CREATE TABLE. That stuff had been removed as part of my original patch for pg_dump a little while ago.
Rod's patch does what it is supposed to do, but it also includes
some old code to add PK constraints to CREATE TABLE. That stuff
had been removed as part of my original patch for pg_dump a
little while ago.

The attached patch fixes this by removing (again :-) ) the
code in dumpTables() to perform PK creation during CREATE
TABLE. I briefly tested it locally and it fixes both of
Tom's test cases.

Please apply.

Cheers,

Neil

--
Neil Conway <neilconway@rogers.com>

foyzur/gpdb,ashwinstar/gpdb,yazun/postgres-xl,lintzc/gpdb,Quikling/gpdb,Quikling/gpdb,adam8157/gpdb,0x0FFF/gpdb,adam8157/gpdb,arcivanov/postgres-xl,pavanvd/postgres-xl,zaksoup/gpdb,ahachete/gpdb,lintzc/gpdb,janebeckman/gpdb,randomtask1155/gpdb,50wu/gpdb,Chibin/gpdb,0x0FFF/gpdb,cjcjameson/gpdb,pavanvd/postgres-xl,tangp3/gpdb,50wu/gpdb,lisakowen/gpdb,techdragon/Postgres-XL,edespino/gpdb,0x0FFF/gpdb,pavanvd/postgres-xl,edespino/gpdb,lisakowen/gpdb,50wu/gpdb,0x0FFF/gpdb,kaknikhil/gpdb,lisakowen/gpdb,randomtask1155/gpdb,lintzc/gpdb,postmind-net/postgres-xl,jmcatamney/gpdb,oberstet/postgres-xl,snaga/postgres-xl,Postgres-XL/Postgres-XL,CraigHarris/gpdb,edespino/gpdb,zaksoup/gpdb,jmcatamney/gpdb,edespino/gpdb,atris/gpdb,pavanvd/postgres-xl,postmind-net/postgres-xl,arcivanov/postgres-xl,ashwinstar/gpdb,postmind-net/postgres-xl,tangp3/gpdb,Quikling/gpdb,rvs/gpdb,xinzweb/gpdb,rubikloud/gpdb,jmcatamney/gpdb,zeroae/postgres-xl,royc1/gpdb,royc1/gpdb,50wu/gpdb,randomtask1155/gpdb,ashwinstar/gpdb,yuanzhao/gpdb,tpostgres-projects/tPostgres,edespino/gpdb,rubikloud/gpdb,50wu/gpdb,0x0FFF/gpdb,ahachete/gpdb,Postgres-XL/Postgres-XL,janebeckman/gpdb,foyzur/gpdb,yuanzhao/gpdb,snaga/postgres-xl,chrishajas/gpdb,ahachete/gpdb,greenplum-db/gpdb,rvs/gpdb,jmcatamney/gpdb,royc1/gpdb,foyzur/gpdb,rubikloud/gpdb,ovr/postgres-xl,Postgres-XL/Postgres-XL,adam8157/gpdb,kaknikhil/gpdb,greenplum-db/gpdb,yuanzhao/gpdb,arcivanov/postgres-xl,ashwinstar/gpdb,xuegang/gpdb,postmind-net/postgres-xl,arcivanov/postgres-xl,yuanzhao/gpdb,lpetrov-pivotal/gpdb,edespino/gpdb,kmjungersen/PostgresXL,atris/gpdb,xuegang/gpdb,CraigHarris/gpdb,zeroae/postgres-xl,chrishajas/gpdb,rubikloud/gpdb,Chibin/gpdb,atris/gpdb,adam8157/gpdb,adam8157/gpdb,ashwinstar/gpdb,edespino/gpdb,zaksoup/gpdb,Postgres-XL/Postgres-XL,xuegang/gpdb,foyzur/gpdb,Quikling/gpdb,rvs/gpdb,yuanzhao/gpdb,rvs/gpdb,ovr/postgres-xl,lpetrov-pivotal/gpdb,jmcatamney/gpdb,snaga/postgres-xl,yazun/postgres-xl,zaksoup/gpdb,ahachete/gpdb,xinzweb/gpdb,ashwinstar/gpdb,50wu/gpdb,oberstet/postgres-xl,lintzc/gpdb,jmcatamney/gpdb,xuegang/gpdb,lpetrov-pivotal/gpdb,rvs/gpdb,janebeckman/gpdb,cjcjameson/gpdb,0x0FFF/gpdb,xuegang/gpdb,kaknikhil/gpdb,lisakowen/gpdb,tangp3/gpdb,xuegang/gpdb,Chibin/gpdb,zaksoup/gpdb,xinzweb/gpdb,Chibin/gpdb,randomtask1155/gpdb,chrishajas/gpdb,xuegang/gpdb,lpetrov-pivotal/gpdb,chrishajas/gpdb,greenplum-db/gpdb,xuegang/gpdb,greenplum-db/gpdb,chrishajas/gpdb,rubikloud/gpdb,greenplum-db/gpdb,edespino/gpdb,kmjungersen/PostgresXL,ahachete/gpdb,rubikloud/gpdb,yuanzhao/gpdb,zaksoup/gpdb,zeroae/postgres-xl,chrishajas/gpdb,randomtask1155/gpdb,janebeckman/gpdb,Quikling/gpdb,janebeckman/gpdb,yuanzhao/gpdb,kaknikhil/gpdb,rvs/gpdb,kaknikhil/gpdb,janebeckman/gpdb,lisakowen/gpdb,CraigHarris/gpdb,atris/gpdb,CraigHarris/gpdb,techdragon/Postgres-XL,Quikling/gpdb,lintzc/gpdb,rvs/gpdb,royc1/gpdb,randomtask1155/gpdb,zaksoup/gpdb,snaga/postgres-xl,ahachete/gpdb,kaknikhil/gpdb,zaksoup/gpdb,rubikloud/gpdb,kmjungersen/PostgresXL,yazun/postgres-xl,kaknikhil/gpdb,ovr/postgres-xl,foyzur/gpdb,randomtask1155/gpdb,CraigHarris/gpdb,edespino/gpdb,ahachete/gpdb,0x0FFF/gpdb,atris/gpdb,lisakowen/gpdb,tangp3/gpdb,ovr/postgres-xl,xinzweb/gpdb,oberstet/postgres-xl,greenplum-db/gpdb,lintzc/gpdb,yazun/postgres-xl,CraigHarris/gpdb,50wu/gpdb,cjcjameson/gpdb,tangp3/gpdb,postmind-net/postgres-xl,pavanvd/postgres-xl,kaknikhil/gpdb,royc1/gpdb,janebeckman/gpdb,0x0FFF/gpdb,greenplum-db/gpdb,lintzc/gpdb,cjcjameson/gpdb,atris/gpdb,ovr/postgres-xl,Quikling/gpdb,Quikling/gpdb,techdragon/Postgres-XL,jmcatamney/gpdb,tangp3/gpdb,adam8157/gpdb,lintzc/gpdb,rubikloud/gpdb,tpostgres-projects/tPostgres,Quikling/gpdb,randomtask1155/gpdb,lisakowen/gpdb,cjcjameson/gpdb,Chibin/gpdb,chrishajas/gpdb,lpetrov-pivotal/gpdb,xinzweb/gpdb,jmcatamney/gpdb,royc1/gpdb,janebeckman/gpdb,kmjungersen/PostgresXL,yuanzhao/gpdb,janebeckman/gpdb,techdragon/Postgres-XL,Chibin/gpdb,foyzur/gpdb,cjcjameson/gpdb,kaknikhil/gpdb,yuanzhao/gpdb,rvs/gpdb,rvs/gpdb,zeroae/postgres-xl,lintzc/gpdb,techdragon/Postgres-XL,zeroae/postgres-xl,xinzweb/gpdb,tangp3/gpdb,cjcjameson/gpdb,edespino/gpdb,kmjungersen/PostgresXL,xinzweb/gpdb,tpostgres-projects/tPostgres,Postgres-XL/Postgres-XL,lisakowen/gpdb,tpostgres-projects/tPostgres,cjcjameson/gpdb,foyzur/gpdb,tangp3/gpdb,cjcjameson/gpdb,rvs/gpdb,lpetrov-pivotal/gpdb,ashwinstar/gpdb,royc1/gpdb,tpostgres-projects/tPostgres,CraigHarris/gpdb,atris/gpdb,CraigHarris/gpdb,oberstet/postgres-xl,Chibin/gpdb,Chibin/gpdb,arcivanov/postgres-xl,royc1/gpdb,cjcjameson/gpdb,ashwinstar/gpdb,adam8157/gpdb,ahachete/gpdb,lpetrov-pivotal/gpdb,xinzweb/gpdb,chrishajas/gpdb,greenplum-db/gpdb,Chibin/gpdb,foyzur/gpdb,snaga/postgres-xl,CraigHarris/gpdb,50wu/gpdb,xuegang/gpdb,adam8157/gpdb,atris/gpdb,kaknikhil/gpdb,arcivanov/postgres-xl,Chibin/gpdb,yuanzhao/gpdb,Quikling/gpdb,janebeckman/gpdb,oberstet/postgres-xl,yazun/postgres-xl,lpetrov-pivotal/gpdb