lib/datalib.php [4/6] Make the get_records* family of functions use the get_recordset* functions, instead of duplicating code.
lib/datalib.php [4/6] Make the get_records* family of functions use the
get_recordset* functions, instead of duplicating code.

Note: I've replaced the @deprecated tokens in phpdoc with an indication
that the get_records* calls are valid as convenience calls. The
get_recordset*() calls should be considered for performance and memory
footprint, but are not mandatory.

In a sense, deprecating get_records*() would mean a commitment to remove
them within X number of versions, which I am not sure we will do. Now,
if phpdoc has a @discouraged token, I'd like to hear about it ;-)

Author: Tim Hunt <9b37284682ae783c9d40a8998fae470ea8a65626@open.ac.uk>
Signed-off-by: Martin Langhoff <54669547a225ff20cba8b75a4adca540eef25858@catalyst.net.nz>

dilawar/moodle