Actually attach a volume to an instance before taking snapshot
Actually attach a volume to an instance before taking snapshot

In the test test_snapshot_create_with_volume_in_use, the test calls Cinder
"os-attach" for attaching a volume. The "os-attach" to tell Cinder the
volume is attached, but the API doesn't actually attach the volume to an
instance.(Only update volume status in DB)

This is not right test case for taking a snapshot with in-use volume.
In this test, Nova "os-volume_attachment" should be called for volume
attachment.

Also, some Cinder drivers fails assisted snapshot due to this problem.
In order to perform the snapshot properly, this fix is needed.

Closes-Bug #1401110
Change-Id: Ib31e351fe7c3d27824241cf142c213eae287483f

cisco-openstack/tempest,afaheem88/tempest_neutron,tudorvio/tempest,manasi24/tempest,hayderimran7/tempest,Juraci/tempest,akash1808/tempest,CiscoSystems/tempest,yamt/tempest,nunogt/tempest,yamt/tempest,izadorozhna/tempest,pczerkas/tempest,manasi24/tempest,cisco-openstack/tempest,masayukig/tempest,jaspreetw/tempest,Tesora/tesora-tempest,redhat-cip/tempest,tudorvio/tempest,openstack/tempest,Juniper/tempest,jamielennox/tempest,eggmaster/tempest,Vaidyanath/tempest,nunogt/tempest,eggmaster/tempest,akash1808/tempest,alinbalutoiu/tempest,openstack/tempest,neerja28/Tempest,jamielennox/tempest,rzarzynski/tempest,afaheem88/tempest_neutron,rakeshmi/tempest,FujitsuEnablingSoftwareTechnologyGmbH/tempest,NexusIS/tempest,JioCloud/tempest,Juraci/tempest,Tesora/tesora-tempest,afaheem88/tempest,pandeyop/tempest,hpcloud-mon/tempest,hpcloud-mon/tempest,roopali8/tempest,Juniper/tempest,izadorozhna/tempest,rakeshmi/tempest,Lilywei123/tempest,sebrandon1/tempest,dkalashnik/tempest,varunarya10/tempest,LIS/lis-tempest,danielmellado/tempest,manasi24/jiocloud-tempest-qatempest,JioCloud/tempest,afaheem88/tempest,roopali8/tempest,dkalashnik/tempest,danielmellado/tempest,neerja28/Tempest,vedujoshi/tempest,xbezdick/tempest,tonyli71/tempest,manasi24/jiocloud-tempest-qatempest,alinbalutoiu/tempest,jaspreetw/tempest,flyingfish007/tempest,ebagdasa/tempest,rzarzynski/tempest,LIS/lis-tempest,bigswitch/tempest,hayderimran7/tempest,xbezdick/tempest,masayukig/tempest,flyingfish007/tempest,CiscoSystems/tempest,sebrandon1/tempest,bigswitch/tempest,pandeyop/tempest,varunarya10/tempest,NexusIS/tempest,redhat-cip/tempest,Lilywei123/tempest,pczerkas/tempest,ebagdasa/tempest,zsoltdudas/lis-tempest,FujitsuEnablingSoftwareTechnologyGmbH/tempest,tonyli71/tempest,Vaidyanath/tempest,zsoltdudas/lis-tempest,vedujoshi/tempest