endpoint: Fix endpoint regeneration failure metric
endpoint: Fix endpoint regeneration failure metric

The endpoint regeneration metric was being considered "failed" if the
BPF compilation was not executed, even if the overall regeneration was
successful. Fix this by not taking into account whether BPF compilation
occurred when incrementing the metric.

We could in theory split this information out into a separate metric,
however I think that with the EndpointRegenerationTimeSquare we should
be able to tell which cases involved compilation and which did not, as
we should see a bimodal distribution of endpoint regeneration times.

Fixes: 70b82a69f914 ("metrics: Expose endpoint and policy computation time metrics")
Signed-off-by: Joe Stringer <16a9a54ddf4259952e3c118c763138e83693d7fd@covalent.io>

cilium/cilium,tklauser/cilium,michi-covalent/cilium,scanf/cilium,tklauser/cilium,scanf/cilium,tklauser/cilium,tgraf/cilium,cilium/cilium,michi-covalent/cilium,michi-covalent/cilium,tgraf/cilium,cilium-team/cilium,scanf/cilium,cilium/cilium,scanf/cilium,michi-covalent/cilium,scanf/cilium,tklauser/cilium,tgraf/cilium,cilium/cilium,michi-covalent/cilium,tgraf/cilium,scanf/cilium,tklauser/cilium,scanf/cilium,cilium/cilium,tgraf/cilium,tgraf/cilium,cilium-team/cilium