Cleanup create flavor tests
Cleanup create flavor tests

In preparation for some refactoring and additional features to the create
flavor method, this patch cleanups the existing tests by:

* Moving flavor create tests out to their own class

* Adding more coverage around boundary conditions

* Making tests more orthogonal (not testing that `root_gb` was set correctly in
  multiple tests, for example)

Change-Id: I82acadc19d2713406c3be01a104ccd64377098ed

mmnelemane/nova,rahulunair/nova,rickerc/nova_audit,ted-gould/nova,zhimin711/nova,akash1808/nova,ntt-sic/nova,tealover/nova,NeCTAR-RC/nova,affo/nova,devoid/nova,Francis-Liu/animated-broccoli,ntt-sic/nova,barnsnake351/nova,MountainWei/nova,double12gzh/nova,thomasem/nova,klmitch/nova,iuliat/nova,SUSE-Cloud/nova,zaina/nova,gooddata/openstack-nova,Brocade-OpenSource/OpenStack-DNRM-Nova,qwefi/nova,bclau/nova,noironetworks/nova,Yuriy-Leonov/nova,sridevikoushik31/nova,orbitfp7/nova,OpenAcademy-OpenStack/nova-scheduler,Stavitsky/nova,dims/nova,adelina-t/nova,alvarolopez/nova,cernops/nova,varunarya10/nova_test_latest,bigswitch/nova,cyx1231st/nova,petrutlucian94/nova,yosshy/nova,CiscoSystems/nova,akash1808/nova_test_latest,mikalstill/nova,citrix-openstack-build/nova,j-carpentier/nova,rickerc/nova_audit,redhat-openstack/nova,gooddata/openstack-nova,vmturbo/nova,cloudbase/nova,adelina-t/nova,CCI-MOC/nova,watonyweng/nova,hanlind/nova,tianweizhang/nova,fnordahl/nova,CiscoSystems/nova,Metaswitch/calico-nova,rajalokan/nova,takeshineshiro/nova,shootstar/novatest,sebrandon1/nova,takeshineshiro/nova,eayunstack/nova,cloudbase/nova,Brocade-OpenSource/OpenStack-DNRM-Nova,rrader/nova-docker-plugin,petrutlucian94/nova,tanglei528/nova,Juniper/nova,spring-week-topos/nova-week,tangfeixiong/nova,CEG-FYP-OpenStack/scheduler,ted-gould/nova,noironetworks/nova,maelnor/nova,shail2810/nova,JioCloud/nova,imsplitbit/nova,shahar-stratoscale/nova,mmnelemane/nova,sebrandon1/nova,rahulunair/nova,j-carpentier/nova,ruslanloman/nova,bclau/nova,vmturbo/nova,qwefi/nova,bgxavier/nova,sridevikoushik31/nova,mandeepdhami/nova,dawnpower/nova,vmturbo/nova,Yusuke1987/openstack_template,bigswitch/nova,joker946/nova,jianghuaw/nova,zhimin711/nova,kimjaejoong/nova,akash1808/nova,petrutlucian94/nova_dev,isyippee/nova,Juniper/nova,edulramirez/nova,blueboxgroup/nova,mahak/nova,eayunstack/nova,leilihh/novaha,jianghuaw/nova,imsplitbit/nova,NeCTAR-RC/nova,luogangyi/bcec-nova,Juniper/nova,CloudServer/nova,vladikr/nova_drafts,zaina/nova,BeyondTheClouds/nova,DirectXMan12/nova-hacking,openstack/nova,devendermishrajio/nova_test_latest,LoHChina/nova,zzicewind/nova,cernops/nova,petrutlucian94/nova_dev,double12gzh/nova,Tehsmash/nova,apporc/nova,hanlind/nova,jeffrey4l/nova,angdraug/nova,zzicewind/nova,tanglei528/nova,dims/nova,JianyuWang/nova,leilihh/novaha,silenceli/nova,bgxavier/nova,belmiromoreira/nova,devoid/nova,raildo/nova,rrader/nova-docker-plugin,redhat-openstack/nova,watonyweng/nova,badock/nova,cloudbase/nova,eharney/nova,nikesh-mahalka/nova,edulramirez/nova,leilihh/nova,tudorvio/nova,phenoxim/nova,jianghuaw/nova,joker946/nova,alaski/nova,iuliat/nova,CloudServer/nova,alexandrucoman/vbox-nova-driver,LoHChina/nova,gooddata/openstack-nova,BeyondTheClouds/nova,orbitfp7/nova,JioCloud/nova,akash1808/nova_test_latest,spring-week-topos/nova-week,cloudbau/nova,eonpatapon/nova,JioCloud/nova_test_latest,devendermishrajio/nova_test_latest,saleemjaveds/https-github.com-openstack-nova,scripnichenko/nova,affo/nova,apporc/nova,Francis-Liu/animated-broccoli,yatinkumbhare/openstack-nova,OpenAcademy-OpenStack/nova-scheduler,projectcalico/calico-nova,phenoxim/nova,devendermishrajio/nova,ruslanloman/nova,rahulunair/nova,plumgrid/plumgrid-nova,sridevikoushik31/nova,thomasem/nova,projectcalico/calico-nova,cyx1231st/nova,TwinkleChawla/nova,blueboxgroup/nova,alexandrucoman/vbox-nova-driver,openstack/nova,cloudbase/nova-virtualbox,shootstar/novatest,raildo/nova,CCI-MOC/nova,ewindisch/nova,sacharya/nova,DirectXMan12/nova-hacking,eharney/nova,tealover/nova,virtualopensystems/nova,vmturbo/nova,Tehsmash/nova,cloudbase/nova-virtualbox,belmiromoreira/nova,scripnichenko/nova,whitepages/nova,maelnor/nova,silenceli/nova,eonpatapon/nova,virtualopensystems/nova,angdraug/nova,mikalstill/nova,viggates/nova,alaski/nova,JianyuWang/nova,DirectXMan12/nova-hacking,SUSE-Cloud/nova,rajalokan/nova,felixma/nova,Yusuke1987/openstack_template,mandeepdhami/nova,rajalokan/nova,kimjaejoong/nova,CEG-FYP-OpenStack/scheduler,luogangyi/bcec-nova,gooddata/openstack-nova,jianghuaw/nova,viggates/nova,cloudbau/nova,felixma/nova,Metaswitch/calico-nova,nikesh-mahalka/nova,jeffrey4l/nova,ewindisch/nova,TieWei/nova,hanlind/nova,berrange/nova,mahak/nova,saleemjaveds/https-github.com-openstack-nova,JioCloud/nova_test_latest,mgagne/nova,rajalokan/nova,Juniper/nova,tangfeixiong/nova,dawnpower/nova,isyippee/nova,yosshy/nova,openstack/nova,MountainWei/nova,mahak/nova,klmitch/nova,klmitch/nova,badock/nova,shahar-stratoscale/nova,fnordahl/nova,TwinkleChawla/nova,tudorvio/nova,Yuriy-Leonov/nova,sacharya/nova,berrange/nova,alvarolopez/nova,sebrandon1/nova,sridevikoushik31/nova,shail2810/nova,tianweizhang/nova,vladikr/nova_drafts,BeyondTheClouds/nova,mgagne/nova,yatinkumbhare/openstack-nova,cernops/nova,whitepages/nova,TieWei/nova,varunarya10/nova_test_latest,Stavitsky/nova,klmitch/nova,mikalstill/nova,plumgrid/plumgrid-nova,citrix-openstack-build/nova,devendermishrajio/nova,leilihh/nova,barnsnake351/nova