service: fix crash on exit
service: fix crash on exit

This commit releases all service cores from their role,
returning them to ROLE_RTE on rte_service_finalize().

This fixes an issue relating to the service cores causing
a race-condition on rte_eal_cleanup(), where the service core
could still be executing while the main thread has already
free-d the service memory, leading to a segfault.

Fixes: da23f0aa87d8 ("service: fix memory leak with new function")
Cc: stable@dpdk.org

Reported-by: David Marchand <f28529695cfa9e3e1eb84e7072aa626af4abb18e@redhat.com>
Reported-by: Aaron Conole <aa17ba42a0685b214660ffb377dc7569a94d48c9@redhat.com>
Signed-off-by: David Marchand <f28529695cfa9e3e1eb84e7072aa626af4abb18e@redhat.com>
Signed-off-by: Harry van Haaren <b9ad04ed670c22cfa7f5f9ab17e311ca85d11a76@intel.com>
Acked-by: Aaron Conole <aa17ba42a0685b214660ffb377dc7569a94d48c9@redhat.com>

john-mcnamara-intel/dpdk,john-mcnamara-intel/dpdk,john-mcnamara-intel/dpdk,john-mcnamara-intel/dpdk