NSLocalizedString compatibility (10.8 SDK and clang trunk -Wformat-extra-args)
NSLocalizedString compatibility (10.8 SDK and clang trunk -Wformat-extra-args)

Apparently, as of the 10.8 SDK, Apple has quietly decided that the first
argument to NSLocalizedString is supposed to be usable as-is as a format
string, instead of simply being the key to obtain a usable format string.
The recent clang trunk enforces this, resulting in build breaks like

crash_report_sender.m:560:14: error: data argument not used by format string [-Werror,-Wformat-extra-args]
             displayName];
             ^

Breaking the result of NSLocalizedString into a temporary NSString* is enough
to suppress the warning.

BUG=chromium:314109
R=thakis@chromium.org

Review URL: https://breakpad.appspot.com/674003

git-svn-id: 7939527bf0a06ad24ad020f729d5600cb42ed5d7@1230 4c0a9323-5329-0410-9bdc-e9ce6186880e

bittorrent/breakpad,bittorrent/breakpad,wesen/google-breakpad,bittorrent/breakpad,wesen/google-breakpad,bittorrent/breakpad,bittorrent/breakpad,bittorrent/breakpad,wesen/google-breakpad,wesen/google-breakpad,wesen/google-breakpad,bittorrent/breakpad,wesen/google-breakpad