Fix RSpec 3.x syntax
Fix RSpec 3.x syntax

* 17 conversions
    from: it { should ... }
      to: it { is_expected.to ... }

* 2 conversions
    from: it { should_not ... }
      to: it { is_expected.to_not ... }

Change-Id: I12db704709d8d9bcb15fbd131aa001d5ea44a382
Signed-off-by: Gael Chamoulaud <68646863a1a9108d0246eb96cb6356f9fa9a34f3@redhat.com>

IPnett/puppet-ceph,rdo-puppet-modules/puppet-ceph,openstack/puppet-ceph,MI-OSiRIS/puppet-ceph,fultonj/puppet-ceph,openstack/puppet-ceph,ceph/puppet-ceph,norcams/puppet-ceph,tdb/puppet-ceph,cloudbuy/puppet-ceph,MI-OSiRIS/puppet-ceph,cloudbuy/puppet-ceph,fuel-infra/puppet-ceph,norcams/puppet-ceph,stackforge/puppet-ceph,fuel-infra/puppet-ceph