Fixing exit code return on error case in Windows.
Fixing exit code return on error case in Windows.

Right now, if we hit an error retrieving the exit code in HCS process.ExitCode, we return that 0 and that error.  Golang convention says that if an error is returned the other values should not be used, but the caller of ExitCode in libcontainerd has to fall through if an error is received.  Rather than return a success exit code in that failure case, we should return -1 to indicate a generic failure.

Signed-off-by: Stefan J. Wernli <83146b3f843e2cabf52cc6abaa32c20ae61a0a7e@microsoft.com>

pradipd/moby,abhinavdahiya/docker,Ramzec/docker,ffoysal/docker,vdemeester/docker,gschaetz/moby,x1022as/docker,thtanaka/docker,jhorwit2/docker,noxiouz/docker,containers/storage,mixja/docker,mtesselH/docker,laijs/moby,noironetworks/docker,miminar/docker,mixja/docker,mtrmac/docker,13W/docker,cyphar/docker,ripcurld0/moby,endophage/docker,fcrisciani/docker,stevvooe/docker,brahmaroutu/docker,yongtang/docker,unclejack/docker,sfsmithcha/docker,thaJeztah/docker,thaJeztah/docker,konstruktoid/docker-1,q384566678/docker,bonczj/moby-json-file-logger,dccurtis/docker,ibuildthecloud/docker,djs55/docker,michael-holzheu/docker,srust/docker,estesp/docker,rancher/docker,moul/docker,moypray/docker,mahak/docker,eskaaren/docker,abhinavdahiya/docker,asbjornenge/docker,erikh/docker,charleszheng44/moby,ndeloof/docker,yp-engineering/docker,yosifkit/docker,dperny/docker,zhuguihua/docker,dmcgowan/docker,mstanleyjones/docker,mike1729/docker,naveed-jamil-tenpearls/moby,imkin/moby,YuPengZTE/docker,darrenstahlmsft/docker,yp-engineering/docker,yasiramin10p/moby,HideoYamauchi/docker,sarnautov/moby,ajaymdesai/docker,moby/moby,qudongfang/docker,pramodhkp/moby,thtanaka/docker,bluebreezecf/docker,shhsu/docker,nghiant2710/docker,erikh/docker,moypray/docker,resin-io/docker,dims/docker,catinthesky/docker,cyphar/docker,cr7pt0gr4ph7/docker,xuxinkun/docker,yummypeng/docker,tianon/docker,13W/docker,Ramzec/docker,johnstep/moby-moby,nawawi/docker,rhatdan/docker,AkihiroSuda/docker,prertik/docker,madhanrm/docker,shhsu/docker,michelvocks/docker,cpuguy83/docker,cyphar/docker,lixiaobing10051267/docker,bonczj/moby-json-file-logger,catinthesky/docker,tagomoris/docker,kojiromike/docker,eskaaren/docker,kunalkushwaha/docker,konstruktoid/docker-upstream,sterchelen/docker,Syntaxide/docker,HuKeping/docker,moby/moby,erikstmartin/docker,gschaetz/moby,crosbymichael/docker,dccurtis/docker,mkumatag/docker,KingEmet/docker,haveatry/docker,nawawi/docker,sarnautov/moby,dsau/docker,zhuguihua/docker,tophj-ibm/moby,msabansal/docker,POLJM242/docker,srust/docker,AkihiroSuda/docker,darrenstahlmsft/moby,lixiaobing1/docker,msabansal/docker,mikebrow/docker,HideoYamauchi/docker,stevvooe/docker,POLJM242/docker,jwhonce/docker,jlebon/docker,dgageot/docker,Morsicus/docker,coolljt0725/docker,sdurrheimer/docker,tkopczynski/docker,duglin/docker,jthelin/docker,dperny/docker,tagomoris/docker,jvanz/docker,bearstech/moby,twaugh/docker,ajaymdesai/docker,mikedougherty/docker,Mokolea/docker,rhatdan/docker,akira-baruah/docker,SvenDowideit/docker,resin-io/docker,jlhawn/docker,shhsu/docker,xiekeyang/docker,kolyshkin/moby,liaoqingwei/docker,erikh/docker,Morsicus/docker,tophj-ibm/docker,trebonian/docker,diogomonica/docker,cpuguy83/docker,scotttlin/docker,twaugh/docker,hypriot/docker,trebonian/docker,sterchelen/docker,docker/docker,scotttlin/docker,ffoysal/docker,allencloud/docker,pramodhkp/moby,kolyshkin/docker,kojiromike/docker,mtanlee/docker,justyntemme/docker,mohmost12/docker,tophj-ibm/moby,dccurtis/docker,yummypeng/docker,fcrisciani/docker,dongjoon-hyun/docker,amatsus/docker,resin-io/docker,tkopczynski/docker,jwhonce/docker,madhanrm/docker,jimjag/docker,ColinHebert/docker,AkihiroSuda/docker,cpuguy83/docker,maxamillion/docker,mtanlee/docker,lixiaobing10051267/docker,maxamillion/docker,Morsicus/docker,xiekeyang/docker,rhatdan/docker,jlhawn/docker,coolljt0725/docker,KingEmet/docker,liaoqingwei/docker,msabansal/docker,eskaaren/docker,KarthikNayak/docker,kolyshkin/docker,akira-baruah/docker,sdurrheimer/docker,trebonian/docker,flavio/docker,YuPengZTE/docker,dsau/docker,JMesser81/docker,justyntemme/docker,darrenstahlmsft/docker,srust/docker,laijs/docker,charleszheng44/moby,thtanaka/docker,jlhawn/docker,noxiouz/docker,duglin/docker,harche/docker,HuKeping/docker,AkihiroSuda/docker,alfred-landrum/docker,containers/storage,sanjeo/docker,KingEmet/docker,darrenstahlmsft/moby,mahak/docker,jimjag/docker,gnailuy/docker,nalind/docker,johnstep/moby-moby,mtrmac/docker,mkumatag/docker,catinthesky/docker,xiaods/docker,projectatomic/docker,ripcurld0/moby,wenchma/docker,tagomoris/docker,ripcurld0/moby,asbjornenge/docker,jthelin/docker,sanjeo/docker,nghiant2710/docker,charleszheng44/moby,hqhq/moby,x1022as/docker,hqhq/moby,dsheets/moby,whuwxl/docker,moby/moby,docker/docker,prertik/docker,michael-holzheu/docker,stevvooe/docker,haveatry/docker,dongjoon-hyun/docker,diogomonica/docker,dnephin/docker,laijs/moby,xuxinkun/docker,tkopczynski/docker,nalind/docker,sanjeo/docker,kunalkushwaha/docker,kencochrane/docker,dnephin/docker,bluebreezecf/docker,imkin/moby,coreos/docker,afein/docker,cloudflare/docker,duglin/docker,kojiromike/docker,jameszhan/docker,bearstech/moby,shishir-a412ed/docker,ibuildthecloud/docker,trebonian/docker,unclejack/docker,endophage/docker,justincormack/docker,Mokolea/docker,JMesser81/docker,abhinavdahiya/docker,moul/docker,HideoYamauchi/docker,SvenDowideit/docker,kencochrane/docker,danyalKhaliq10p/moby,mikebrow/docker,michelvocks/docker,dmcgowan/docker,KarthikNayak/docker,tklauser/docker,liaoqingwei/docker,jvanz/docker,amatsus/docker,justincormack/docker,jimjag/docker,dsau/docker,gnailuy/docker,nawawi/docker,PatrickLang/moby,bluebreezecf/docker,qudongfang/docker,xiaods/docker,naveed-jamil-tenpearls/moby,fcrisciani/docker,mstanleyjones/docker,danyalKhaliq10p/moby,docker/docker,Mokolea/docker,pradipd/moby,allencloud/docker,cr7pt0gr4ph7/docker,naveed-jamil-tenpearls/moby,erikstmartin/docker,unclejack/docker,dsheets/moby,portworx/docker,portworx/docker,wenchma/docker,gjaskiewicz/moby,darrenstahlmsft/docker,endophage/docker,pramodhkp/moby,miminar/docker,tianon/docker,jhorwit2/docker,harche/docker,hypriot/docker,dperny/docker,dnephin/docker,johnstep/moby-moby,tonistiigi/docker,xuxinkun/docker,gnailuy/docker,cloudflare/docker,nawawi/docker,SvenDowideit/docker,laijs/docker,thaJeztah/docker,rhatdan/storage,13W/docker,mikebrow/docker,estesp/docker,gjaskiewicz/moby,shishir-a412ed/docker,whuwxl/docker,harche/docker,danyalKhaliq10p/moby,tklauser/docker,rancher/docker,Ramzec/docker,jlebon/docker,jameszhan/docker,madhanrm/docker,coreos/docker,raja-sami-10p/moby,jwhonce/docker,mohmost12/docker,Mokolea/docker,KarthikNayak/docker,twaugh/docker,michelvocks/docker,tmp6154/docker,tmp6154/docker,hypriot/docker,scotttlin/docker,Syntaxide/docker,mtrmac/docker,flavio/docker,mtesselH/docker,jvanz/docker,kolyshkin/moby,jameszhan/docker,darrenstahlmsft/moby,projectatomic/docker,yosifkit/docker,ibuildthecloud/docker,rremer/moby,laijs/docker,q384566678/docker,sfsmithcha/docker,haveatry/docker,splunk/docker,tonistiigi/docker,tophj-ibm/moby,ColinHebert/docker,mike1729/docker,nghiant2710/docker,djs55/docker,icaoweiwei/docker,Syntaxide/docker,mixja/docker,tophj-ibm/docker,jimjag/docker,konstruktoid/docker-upstream,flavio/docker,sterchelen/docker,mikedougherty/docker,noxiouz/docker,diogomonica/docker,imkin/moby,djs55/docker,sarnautov/moby,coolljt0725/docker,HuKeping/docker,estesp/docker,tmp6154/docker,vdemeester/docker,ajaymdesai/docker,13W/docker,konstruktoid/docker-1,x1022as/docker,asbjornenge/docker,lixiaobing10051267/docker,ndeloof/docker,yosifkit/docker,PatrickLang/moby,sfsmithcha/docker,moby/moby,thaJeztah/docker,xiaods/docker,mahak/docker,mkumatag/docker,kolyshkin/moby,dims/docker,dgageot/docker,kunalkushwaha/docker,rhatdan/storage,rhatdan/storage,gnailuy/docker,yosifkit/docker,michael-holzheu/docker,mikedougherty/docker,coreos/docker,ffoysal/docker,erikstmartin/docker,mahak/docker,jhorwit2/docker,moul/docker,icaoweiwei/docker,pradipd/moby,wenchma/docker,bearstech/moby,mstanleyjones/docker,paralin/docker,prertik/docker,JMesser81/docker,icaoweiwei/docker,afein/docker,gschaetz/moby,konstruktoid/docker-1,yasiramin10p/moby,justincormack/docker,konstruktoid/docker-upstream,laijs/moby,PatrickLang/moby,yongtang/docker,jlebon/docker,dmcgowan/docker,paralin/docker,raja-sami-10p/moby,gjaskiewicz/moby,crosbymichael/docker,mtanlee/docker,qudongfang/docker,tonistiigi/docker,crosbymichael/docker,raja-sami-10p/moby,zhuguihua/docker,paralin/docker,nalind/docker,lixiaobing1/docker,kencochrane/docker,lixiaobing1/docker,nalind/docker,allencloud/docker,alfred-landrum/docker,YuPengZTE/docker,paralin/docker,dims/docker,ibuildthecloud/docker,brahmaroutu/docker,13W/docker,flavio/docker,alfred-landrum/docker,ColinHebert/docker,containers/storage,splunk/docker,projectatomic/docker,ibuildthecloud/docker,yongtang/docker,mike1729/docker,yummypeng/docker,cpuguy83/docker,bearstech/moby,mohmost12/docker,tklauser/docker,rremer/moby,rancher/docker,hqhq/moby,noironetworks/docker,noironetworks/docker,dongjoon-hyun/docker,cloudflare/docker,rremer/moby,whuwxl/docker,cr7pt0gr4ph7/docker,moypray/docker,brahmaroutu/docker,shishir-a412ed/docker,splunk/docker,moul/docker,Ramzec/docker,vdemeester/docker,afein/docker,maxamillion/docker,portworx/docker,yp-engineering/docker,amatsus/docker,xiekeyang/docker,tophj-ibm/docker,konstruktoid/docker-upstream,bonczj/moby-json-file-logger,ndeloof/docker,mtesselH/docker,dsheets/moby,miminar/docker,justyntemme/docker,q384566678/docker,dgageot/docker,sdurrheimer/docker,yasiramin10p/moby