Add rule on primary keys to contribution guide (#42965)
Add rule on primary keys to contribution guide (#42965)

Jordie proofs the codebase.

Some unbanned legacy bans came back as active bans because the db conversion
script jordie had me run back during the ban panel rewrite didn't account for
erro being erro and setting unbanned to 2 in some cases for reasons we don't
understand or care about.

Normally I could easily fix this by having mysql give me a list of every id in
the old ban table with unbanned set to 2, and shunting that as a subquery to an
update statement to unban those bans. but jordie, complaining about weird gaps
in ordering and id numbers, intentionally reset and reassigned the id numbers
of all bans during the conversion.

Its at this point that I decided we should never reshuffle ids arounds for
bullshit reasons.
JJRcop/tgstation,Poojawa/tgstation-fork,infinitystation/-tg-station,SamuelRowe/-tg-station,ShizCalev/tgstation,anconfuzedrock/tgstation,anconfuzedrock/tgstation,Mark9013100/tgstation-m9,Fox-McCloud/-tg-station,HippieStation/HippieStation,TheRealGLH/-tg-station,nicbn/tgstation,Arianya/tgstation,MrStonedOne/tgstation,tgstation/tgstation,Poojawa/tgstation-fork,Niknakflak/-tg-station,QualityVan/tgstation,WJohn/-tg-station,McBawbaggings/HippieStation,Razharas/-tg-station,Incoming5643/-tg-station,Cruix/-tg-station,QualityVan/tgstation,Razharas/-tg-station,Mark9013100/tgstation-m9,Cruix/-tg-station,HippieStation/HippieStation,AnturK/-tg-station,HippieStation/HippieStation,McBawbaggings/HippieStation,JStheguy/tgstation,ohnopigeons/tgstation,TheRealGLH/-tg-station,Arianya/tgstation,Incoming5643/-tg-station,CPTANT/-tg-station,TheVekter/-tg-station,ShizCalev/tgstation,McBawbaggings/HippieStation,securitycopper/-tg-station,Bawhoppen/-tg-station,JJRcop/tgstation,Profakos/tgstation,Cyberboss/tgstation,erwgd/-tg-station,coiax/-tg-station,WJohn/-tg-station,kingofkosmos/-tg-station,Fox-McCloud/-tg-station,Aranclanos/-tg-station,Fox-McCloud/-tg-station,MrStonedOne/tgstation,XDTM/tgstation,TheRealGLH/-tg-station,Arianya/tgstation,Bawhoppen/-tg-station,tgstation/tgstation,CPTANT/-tg-station,nicbn/tgstation,TheVekter/-tg-station,XDTM/tgstation,McBawbaggings/HippieStation,HippieStation/HippieStation,PKPenguin321/-tg-station,TheVekter/-tg-station,Bawhoppen/-tg-station,erwgd/-tg-station,WJohn/-tg-station,Cruix/-tg-station,nicbn/tgstation,optimumtact/-tg-station,GunHog/-tg-station,Cyberboss/tgstation,AnturK/-tg-station,AnturK/-tg-station,coiax/-tg-station,infinitystation/-tg-station,QualityVan/tgstation,MicroWorldwide/SS13-TG-station,AnturK/-tg-station,Thunder12345/-tg-station,XDTM/tgstation,infinitystation/-tg-station,Razharas/-tg-station,TheVekter/-tg-station,Cruix/-tg-station,anconfuzedrock/tgstation,QualityVan/tgstation,MrStonedOne/tgstation,AnturK/-tg-station,Fox-McCloud/-tg-station,optimumtact/-tg-station,tgstation/tgstation,Aranclanos/-tg-station,Cruix/-tg-station,CPTANT/-tg-station,GunHog/-tg-station,Cruix/-tg-station,MrStonedOne/tgstation,JStheguy/tgstation,MrStonedOne/tgstation,JStheguy/tgstation,PKPenguin321/-tg-station,Poojawa/tgstation-fork,ShizCalev/tgstation,Thunder12345/-tg-station,Razharas/-tg-station,Incoming5643/-tg-station,CPTANT/-tg-station,JStheguy/tgstation,CPTANT/-tg-station,XDTM/tgstation,Fox-McCloud/-tg-station,MicroWorldwide/SS13-TG-station,McBawbaggings/HippieStation,TalkingCactus/tgstation,SamuelRowe/-tg-station,JStheguy/tgstation,MrStonedOne/tgstation,optimumtact/-tg-station,kingofkosmos/-tg-station,MicroWorldwide/SS13-TG-station,Thunder12345/-tg-station,QualityVan/tgstation,TheVekter/-tg-station,PKPenguin321/-tg-station,Bawhoppen/-tg-station,Jordie0608/tgstation,infinitystation/-tg-station,ShizCalev/tgstation,Jordie0608/tgstation,ShizCalev/tgstation,Fox-McCloud/-tg-station,CPTANT/-tg-station,securitycopper/-tg-station,HippieStation/HippieStation,Aranclanos/-tg-station,tgstation/tgstation,optimumtact/-tg-station,JJRcop/tgstation,GunHog/-tg-station,Cyberboss/tgstation,PKPenguin321/-tg-station,Niknakflak/-tg-station,XDTM/tgstation,Poojawa/tgstation-fork,WJohn/-tg-station,McBawbaggings/HippieStation,MrStonedOne/tgstation,Arianya/tgstation,Arianya/tgstation,Aranclanos/-tg-station,tgstation/-tg-station,Fox-McCloud/-tg-station,CPTANT/-tg-station,PKPenguin321/-tg-station,XDTM/tgstation,coiax/-tg-station,JJRcop/-tg-station,Cruix/-tg-station,WJohn/-tg-station,Jordie0608/tgstation,Jordie0608/tgstation,PKPenguin321/-tg-station,Mark9013100/tgstation-m9,XDTM/tgstation,nicbn/tgstation,Aranclanos/-tg-station,Cyberboss/tgstation,JJRcop/-tg-station,Jordie0608/tgstation,Arianya/tgstation,nicbn/tgstation,Aranclanos/-tg-station,TalkingCactus/tgstation,anconfuzedrock/tgstation,Aranclanos/-tg-station,Niknakflak/-tg-station,optimumtact/-tg-station,Profakos/tgstation,Niknakflak/-tg-station,infinitystation/-tg-station,coiax/-tg-station,Razharas/-tg-station,Thunder12345/-tg-station,tgstation/tgstation,ohnopigeons/tgstation,securitycopper/-tg-station,Niknakflak/-tg-station,Arianya/tgstation,Bawhoppen/-tg-station,Jordie0608/tgstation,MicroWorldwide/SS13-TG-station,anconfuzedrock/tgstation,Jordie0608/tgstation,Thunder12345/-tg-station,ShizCalev/tgstation,ohnopigeons/tgstation,anconfuzedrock/tgstation,WJohn/-tg-station,coiax/-tg-station,Profakos/tgstation,MicroWorldwide/SS13-TG-station,securitycopper/-tg-station,JJRcop/tgstation,AnturK/-tg-station,QualityVan/tgstation,JJRcop/tgstation,Incoming5643/-tg-station,Poojawa/tgstation-fork,Mark9013100/tgstation-m9,JStheguy/tgstation,GunHog/-tg-station,TalkingCactus/tgstation,JJRcop/tgstation,Niknakflak/-tg-station,Incoming5643/-tg-station,Niknakflak/-tg-station,GunHog/-tg-station,CPTANT/-tg-station,JStheguy/tgstation,Incoming5643/-tg-station,nicbn/tgstation,tgstation/-tg-station,kingofkosmos/-tg-station,securitycopper/-tg-station,Bawhoppen/-tg-station,TalkingCactus/tgstation,coiax/-tg-station,McBawbaggings/HippieStation,SamuelRowe/-tg-station,Profakos/tgstation,GunHog/-tg-station,McBawbaggings/HippieStation,securitycopper/-tg-station,Mark9013100/tgstation-m9,JJRcop/-tg-station,coiax/-tg-station,Razharas/-tg-station,MrStonedOne/tgstation,ShizCalev/tgstation,JJRcop/-tg-station,QualityVan/tgstation,Aranclanos/-tg-station,tgstation/tgstation,Thunder12345/-tg-station,Jordie0608/tgstation,Bawhoppen/-tg-station,Mark9013100/tgstation-m9,PKPenguin321/-tg-station,HippieStation/HippieStation,Incoming5643/-tg-station,ohnopigeons/tgstation,kingofkosmos/-tg-station,WJohn/-tg-station,Profakos/tgstation,Cyberboss/tgstation,HippieStation/HippieStation,TheVekter/-tg-station,optimumtact/-tg-station,securitycopper/-tg-station,AnturK/-tg-station,tgstation/-tg-station,Cyberboss/tgstation,GunHog/-tg-station,nicbn/tgstation,SamuelRowe/-tg-station,Razharas/-tg-station,erwgd/-tg-station,Profakos/tgstation,ShizCalev/tgstation,TheRealGLH/-tg-station,Incoming5643/-tg-station,PKPenguin321/-tg-station,Poojawa/tgstation-fork,securitycopper/-tg-station,Profakos/tgstation,optimumtact/-tg-station,tgstation/-tg-station,tgstation/tgstation,Thunder12345/-tg-station,anconfuzedrock/tgstation,TheVekter/-tg-station,infinitystation/-tg-station,Poojawa/tgstation-fork,infinitystation/-tg-station,tgstation/tgstation,Bawhoppen/-tg-station,kingofkosmos/-tg-station,Cyberboss/tgstation,Razharas/-tg-station,infinitystation/-tg-station,kingofkosmos/-tg-station,MicroWorldwide/SS13-TG-station,MicroWorldwide/SS13-TG-station,Cruix/-tg-station,Mark9013100/tgstation-m9,MicroWorldwide/SS13-TG-station,kingofkosmos/-tg-station,JJRcop/tgstation