Really avoid error loading rules for numeric host name in alias
Really avoid error loading rules for numeric host name in alias

Create a host-type alias. Put just a number in "IP or FQDN" - e.g. I made alias name "Zqw" and a single host "23". The webGUI reports:
There were error(s) loading the rules: /tmp/rules.debug:44: syntax error - The line in question reads [44]: table { 23 }
and /tmp/rules.debug has:
table { 23 }
Zqw = ""
which pf does not cope with.
This change will differentiate between a number in the context of a port alias and a number that is_hostname.
This time I think it really works :) The call to alias_get_type() needed to send the alias name as parameter. alias_get_type() is a bit expensive - it scans through the whole list of aliases looking for a match on the name. So I made this code just call it once for the name and then use that $alias_type var each time as it loops through all the addresses in an alias.
I have tried this successfully with a few combinations of nested port/host/network aliases. But maybe there is some wacky combination of nested aliases possible that could still break this? I don't see how, but it needs testing on some configs that have all sorts of nested alias types.
NOYB/pfsense,NewEraCracker/pfsense,ptorsten/pfsense,pfsense/pfsense,brunostein/pfsense,ch1c4um/pfsense,ch1c4um/pfsense,pfsense/pfsense,phil-davis/pfsense,BlackstarGroup/pfsense,pfsense/pfsense,jxmx/pfsense,pfsense/pfsense,ch1c4um/pfsense,dennypage/pfsense,ptorsten/pfsense,BlackstarGroup/pfsense,phil-davis/pfsense,jxmx/pfsense,NOYB/pfsense,BlackstarGroup/pfsense,phil-davis/pfsense,BlackstarGroup/pfsense,dennypage/pfsense,dennypage/pfsense,jxmx/pfsense,ptorsten/pfsense,ch1c4um/pfsense,NewEraCracker/pfsense,NewEraCracker/pfsense,NewEraCracker/pfsense,phil-davis/pfsense,NOYB/pfsense,dennypage/pfsense,brunostein/pfsense,brunostein/pfsense