Setting CDB_PALLOC_TAGS only when USE_ASSERT_CHECKING is defined and removing unused code. (#2924)
Setting CDB_PALLOC_TAGS only when USE_ASSERT_CHECKING is defined and removing unused code. (#2924)

We set CDB_PALLOC_TAGS regardless of USE_ASSERT_CHECKING on 81627e2. This bloated chunk header in release build, resulting in significantly more memory consumption in certain cases.

In this PR we are restoring the original behavior by setting CDB_PALLOC_TAGS only when USE_ASSERT_CHECKING is set. We are also removing unused code.

Signed-off-by: Foyzur Rahman <2f1407d2e59627fd1da79c9d4f58d4b2214fddbb@gmail.com>
greenplum-db/gpdb,xinzweb/gpdb,greenplum-db/gpdb,xinzweb/gpdb,ashwinstar/gpdb,kaknikhil/gpdb,kaknikhil/gpdb,lisakowen/gpdb,yuanzhao/gpdb,50wu/gpdb,edespino/gpdb,jmcatamney/gpdb,ashwinstar/gpdb,edespino/gpdb,lisakowen/gpdb,cjcjameson/gpdb,yuanzhao/gpdb,ashwinstar/gpdb,lisakowen/gpdb,cjcjameson/gpdb,Chibin/gpdb,janebeckman/gpdb,jmcatamney/gpdb,xinzweb/gpdb,kaknikhil/gpdb,edespino/gpdb,lisakowen/gpdb,cjcjameson/gpdb,greenplum-db/gpdb,Chibin/gpdb,yuanzhao/gpdb,edespino/gpdb,yuanzhao/gpdb,xinzweb/gpdb,jmcatamney/gpdb,yuanzhao/gpdb,ashwinstar/gpdb,adam8157/gpdb,janebeckman/gpdb,Chibin/gpdb,janebeckman/gpdb,jmcatamney/gpdb,janebeckman/gpdb,lisakowen/gpdb,kaknikhil/gpdb,Chibin/gpdb,edespino/gpdb,cjcjameson/gpdb,yuanzhao/gpdb,kaknikhil/gpdb,lisakowen/gpdb,ashwinstar/gpdb,jmcatamney/gpdb,adam8157/gpdb,janebeckman/gpdb,cjcjameson/gpdb,janebeckman/gpdb,greenplum-db/gpdb,adam8157/gpdb,edespino/gpdb,cjcjameson/gpdb,lisakowen/gpdb,edespino/gpdb,kaknikhil/gpdb,cjcjameson/gpdb,cjcjameson/gpdb,ashwinstar/gpdb,Chibin/gpdb,janebeckman/gpdb,yuanzhao/gpdb,xinzweb/gpdb,adam8157/gpdb,50wu/gpdb,janebeckman/gpdb,adam8157/gpdb,cjcjameson/gpdb,Chibin/gpdb,ashwinstar/gpdb,greenplum-db/gpdb,kaknikhil/gpdb,lisakowen/gpdb,cjcjameson/gpdb,greenplum-db/gpdb,janebeckman/gpdb,Chibin/gpdb,jmcatamney/gpdb,yuanzhao/gpdb,50wu/gpdb,edespino/gpdb,kaknikhil/gpdb,50wu/gpdb,greenplum-db/gpdb,yuanzhao/gpdb,kaknikhil/gpdb,Chibin/gpdb,xinzweb/gpdb,Chibin/gpdb,yuanzhao/gpdb,jmcatamney/gpdb,Chibin/gpdb,ashwinstar/gpdb,janebeckman/gpdb,edespino/gpdb,50wu/gpdb,50wu/gpdb,xinzweb/gpdb,adam8157/gpdb,jmcatamney/gpdb,50wu/gpdb,adam8157/gpdb,greenplum-db/gpdb,adam8157/gpdb,edespino/gpdb,50wu/gpdb,xinzweb/gpdb,kaknikhil/gpdb