shim: relocate_coff(): get rid of "FixupData" stuff
shim: relocate_coff(): get rid of "FixupData" stuff

"FixupData" in the edk2 tree is a log of the relocations that happened,
which is allocated by the "client" calling relocate, and written into
while it does relocations.  Since we never allocate that log anywhere,
FixupData is always NULL, and so covscan says:

318                        case EFI_IMAGE_REL_BASED_HIGH:
319                                Fixup16   = (UINT16 *) Fixup;
320                                *Fixup16 = (UINT16) (*Fixup16 + ((UINT16) ((UINT32) Adjust >> 16)));
   null: At condition FixupData != NULL, the value of FixupData must be
   NULL.  dead_error_condition: The condition FixupData != NULL cannot
   be true.
321                                if (FixupData != NULL) {
   CID 182859 (#1 of 4): Logically dead code (DEADCODE)dead_error_begin:
   Execution cannot reach this statement: *((UINT16 *)FixupData) =
   *F....
322                                        *(UINT16 *) FixupData = *Fixup16;
323                                        FixupData             = FixupData + sizeof (UINT16);
324                                }
325                                break;

And it's right; all four occurrances are deadcode that never do anything
but confuse the reader.

Kill it with fire.

Signed-off-by: Peter Jones <2e0a021e603479ff81838c00c3b770daca4e0214@redhat.com>

rhinstaller/shim,rhinstaller/shim,rhinstaller/shim