snapshot: simplify redefinition of disk snapshot
snapshot: simplify redefinition of disk snapshot

Redefining disk-only snapshot xml should work even if the user
did not explicitly pass VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY;
the flag is only required for conditions where the <state>
subelement is not already present in parsing (that is, defining
a new snapshot).

Also, fix the error code of some user-visible errors (the remaining
VIR_ERR_INTERNAL_ERROR should not be user-visible, since parsing
of <active> is only done from internal code).

* src/conf/domain_conf.c (virDomainSnapshotDefParseString): Allow
disks during redefinition of disk snapshot.

agx/libvirt,rmarwaha/libvirt1,datto/libvirt,foomango/libvirt,olafhering/libvirt,crobinso/libvirt,novel/fbsd-libvirt,usc-isi/libvirt,bjzhang/libvirt,rmarwaha/libvirt,iam-TJ/libvirt,novel/fbsd-libvirt,elmarco/libvirt,soulxu/libvirt-xuhj,rmarwaha/libvirt,warewolf/libvirt,foomango/libvirt,novel/fbsd-libvirt,wiedi/libvirt,rlaager/libvirt,elmarco/libvirt,rmarwaha/libvirt,jfehlig/libvirt,shugaoye/libvirt,datto/libvirt,zhlcindy/libvirt-1.1.4-maintain,zhlcindy/libvirt-1.1.4-maintain,leilihh/libvirt,zippy2/libvirt,emaste/libvirt,wiedi/libvirt,wiedi/libvirt,leilihh/libvirt,leilihh/libvirt,jeckersb/libvirt,cbosdo/libvirt,shugaoye/libvirt,jeckersb/libvirt,datto/libvirt,wiedi/libvirt,dumbbell/libvirt,rmarwaha/libvirt1,cbosdo/libvirt,jardasgit/libvirt,zippy2/libvirt,zhlcindy/libvirt-1.1.4-maintain,taget/libvirt,usc-isi/libvirt,olafhering/libvirt,trainstack/libvirt,warewolf/libvirt,iam-TJ/libvirt,soulxu/libvirt-xuhj,trainstack/libvirt,crobinso/libvirt,emaste/libvirt,dumbbell/libvirt,bjzhang/libvirt,novel/fbsd-libvirt,siboulet/libvirt-openvz,iam-TJ/libvirt,eskultety/libvirt,nertpinx/libvirt,libvirt/libvirt,agx/libvirt,wiedi/libvirt,crobinso/libvirt,nertpinx/libvirt,trainstack/libvirt,jeckersb/libvirt,fabianfreyer/libvirt,VenkatDatta/libvirt,jeckersb/libvirt,taget/libvirt,shugaoye/libvirt,usc-isi/libvirt,jardasgit/libvirt,foomango/libvirt,danwent/libvirt-ovs,jardasgit/libvirt,jeckersb/libvirt,leilihh/libvirt,eskultety/libvirt,rmarwaha/libvirt1,cbosdo/libvirt,soulxu/libvirt-xuhj,andreabolognani/libvirt,soulxu/libvirt-xuhj,agx/libvirt,bjzhang/libvirt,dumbbell/libvirt,elmarco/libvirt,dumbbell/libvirt,jardasgit/libvirt,datto/libvirt,zippy2/libvirt,rlaager/libvirt,siboulet/libvirt-openvz,rmarwaha/libvirt,jfehlig/libvirt,taget/libvirt,emaste/libvirt,libvirt/libvirt,taget/libvirt,iam-TJ/libvirt,warewolf/libvirt,agx/libvirt,rmarwaha/libvirt,jfehlig/libvirt,danwent/libvirt-ovs,shugaoye/libvirt,warewolf/libvirt,usc-isi/libvirt,libvirt/libvirt,nertpinx/libvirt,cbosdo/libvirt,usc-isi/libvirt,dumbbell/libvirt,zhlcindy/libvirt-1.1.4-maintain,novel/fbsd-libvirt,leilihh/libvirt,andreabolognani/libvirt,cbosdo/libvirt,soulxu/libvirt-xuhj,trainstack/libvirt,warewolf/libvirt,rlaager/libvirt,wiedi/libvirt,bjzhang/libvirt,taget/libvirt,iam-TJ/libvirt,zippy2/libvirt,fabianfreyer/libvirt,rmarwaha/libvirt1,andreabolognani/libvirt,andreabolognani/libvirt,wiedi/libvirt,shugaoye/libvirt,siboulet/libvirt-openvz,rmarwaha/libvirt1,jfehlig/libvirt,fabianfreyer/libvirt,emaste/libvirt,jardasgit/libvirt,eskultety/libvirt,bjzhang/libvirt,danwent/libvirt-ovs,agx/libvirt,novel/fbsd-libvirt,warewolf/libvirt,jeckersb/libvirt,zhlcindy/libvirt-1.1.4-maintain,VenkatDatta/libvirt,trainstack/libvirt,iam-TJ/libvirt,rlaager/libvirt,datto/libvirt,novel/fbsd-libvirt,danwent/libvirt-ovs,emaste/libvirt,warewolf/libvirt,jeckersb/libvirt,dumbbell/libvirt,siboulet/libvirt-openvz,crobinso/libvirt,libvirt/libvirt,emaste/libvirt,andreabolognani/libvirt,trainstack/libvirt,eskultety/libvirt,foomango/libvirt,olafhering/libvirt,VenkatDatta/libvirt,rlaager/libvirt,novel/fbsd-libvirt,VenkatDatta/libvirt,VenkatDatta/libvirt,foomango/libvirt,elmarco/libvirt,nertpinx/libvirt,iam-TJ/libvirt,fabianfreyer/libvirt,olafhering/libvirt,novel/fbsd-libvirt,siboulet/libvirt-openvz,elmarco/libvirt,rmarwaha/libvirt1,trainstack/libvirt,danwent/libvirt-ovs,rmarwaha/libvirt,leilihh/libvirt,nertpinx/libvirt,eskultety/libvirt,emaste/libvirt,fabianfreyer/libvirt