ultimate retry for image shader cleanup
ultimate retry for image shader cleanup

I _think_ I've sorted out everything that went wrong the first time:

   - Since we're not always kPremul by the time we clamp, we now
     need to clamp to [0,1] when either fClampAsIfUnpremul is set
     or... we're actually unpremul!  That's the first diff we couldn't
     figure out.

   - This was not the only use of apply(pipeline, SkColorType),
     and removing it made things fall back on apply(pipeline, bool),
     which was making us think everything was normalized.  I think
     that'll get the layout tests.

So I think this is now everything we'd want, uncompromised.

Change-Id: I46f3cd1cc79358e55f5c46a425bacb1de6932c7b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262022
Auto-Submit: Mike Klein <14574f09dfa9b4e14759b88c3426a495a0e627b0@google.com>
Reviewed-by: Brian Osman <794c0b5534edf5601d88e1d41975d0262da12894@google.com>
Commit-Queue: Mike Klein <14574f09dfa9b4e14759b88c3426a495a0e627b0@google.com>

aosp-mirror/platform_external_skia,HalCanary/skia-hc,google/skia,HalCanary/skia-hc,aosp-mirror/platform_external_skia,aosp-mirror/platform_external_skia,HalCanary/skia-hc,google/skia,aosp-mirror/platform_external_skia,google/skia,google/skia,HalCanary/skia-hc,HalCanary/skia-hc,google/skia,aosp-mirror/platform_external_skia,google/skia,google/skia,aosp-mirror/platform_external_skia,HalCanary/skia-hc,google/skia,google/skia,aosp-mirror/platform_external_skia,HalCanary/skia-hc,HalCanary/skia-hc,aosp-mirror/platform_external_skia,HalCanary/skia-hc,google/skia,aosp-mirror/platform_external_skia,HalCanary/skia-hc,aosp-mirror/platform_external_skia