Auto merge of #18829 - bholley:verify_in_drop, r=Manishearth
Auto merge of #18829 - bholley:verify_in_drop, r=Manishearth

Verify in DiagnosticHashMap::drop

This will let us reason better about the drop_in_place crashes.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18829)
<!-- Reviewable:end -->

ConnorGBrewster/servo,CJ8664/servo,dati91/servo,eddyb/servo,saneyuki/servo,pyfisch/servo,pyfisch/servo,emilio/servo,paulrouget/servo,ConnorGBrewster/servo,emilio/servo,larsbergstrom/servo,KiChjang/servo,fiji-flo/servo,anthgur/servo,pyfisch/servo,mattnenterprise/servo,emilio/servo,upsuper/servo,rnestler/servo,peterjoel/servo,nnethercote/servo,rnestler/servo,rnestler/servo,rnestler/servo,dsandeephegde/servo,jimberlage/servo,pyfisch/servo,sadmansk/servo,jimberlage/servo,szeged/servo,DominoTree/servo,cbrewster/servo,peterjoel/servo,fiji-flo/servo,cbrewster/servo,jimberlage/servo,notriddle/servo,anthgur/servo,DominoTree/servo,canaltinova/servo,KiChjang/servo,fiji-flo/servo,canaltinova/servo,anthgur/servo,canaltinova/servo,DominoTree/servo,larsbergstrom/servo,thiagopnts/servo,pyfisch/servo,paulrouget/servo,ConnorGBrewster/servo,ConnorGBrewster/servo,splav/servo,CJ8664/servo,DominoTree/servo,mattnenterprise/servo,upsuper/servo,SimonSapin/servo,ConnorGBrewster/servo,eddyb/servo,mattnenterprise/servo,rnestler/servo,KiChjang/servo,eddyb/servo,larsbergstrom/servo,fiji-flo/servo,szeged/servo,peterjoel/servo,saneyuki/servo,SimonSapin/servo,sadmansk/servo,canaltinova/servo,nnethercote/servo,paulrouget/servo,dati91/servo,KiChjang/servo,paulrouget/servo,splav/servo,szeged/servo,canaltinova/servo,saneyuki/servo,ConnorGBrewster/servo,thiagopnts/servo,peterjoel/servo,paulrouget/servo,nnethercote/servo,dsandeephegde/servo,avadacatavra/servo,upsuper/servo,anthgur/servo,notriddle/servo,notriddle/servo,peterjoel/servo,sadmansk/servo,dsandeephegde/servo,upsuper/servo,fiji-flo/servo,splav/servo,splav/servo,cbrewster/servo,dati91/servo,dati91/servo,eddyb/servo,dsandeephegde/servo,SimonSapin/servo,notriddle/servo,jimberlage/servo,thiagopnts/servo,sadmansk/servo,mbrubeck/servo,peterjoel/servo,avadacatavra/servo,dati91/servo,eddyb/servo,larsbergstrom/servo,KiChjang/servo,emilio/servo,anthgur/servo,szeged/servo,jimberlage/servo,anthgur/servo,szeged/servo,paulrouget/servo,anthgur/servo,notriddle/servo,emilio/servo,jimberlage/servo,nnethercote/servo,szeged/servo,cbrewster/servo,sadmansk/servo,pyfisch/servo,SimonSapin/servo,splav/servo,larsbergstrom/servo,canaltinova/servo,saneyuki/servo,splav/servo,DominoTree/servo,SimonSapin/servo,mbrubeck/servo,dati91/servo,mbrubeck/servo,canaltinova/servo,DominoTree/servo,mbrubeck/servo,cbrewster/servo,notriddle/servo,upsuper/servo,avadacatavra/servo,rnestler/servo,sadmansk/servo,KiChjang/servo,fiji-flo/servo,mbrubeck/servo,thiagopnts/servo,thiagopnts/servo,mbrubeck/servo,peterjoel/servo,mattnenterprise/servo,DominoTree/servo,cbrewster/servo,anthgur/servo,dsandeephegde/servo,avadacatavra/servo,larsbergstrom/servo,paulrouget/servo,emilio/servo,nnethercote/servo,dsandeephegde/servo,peterjoel/servo,nnethercote/servo,paulrouget/servo,szeged/servo,upsuper/servo,thiagopnts/servo,eddyb/servo,ConnorGBrewster/servo,fiji-flo/servo,peterjoel/servo,pyfisch/servo,eddyb/servo,thiagopnts/servo,avadacatavra/servo,SimonSapin/servo,pyfisch/servo,CJ8664/servo,splav/servo,mattnenterprise/servo,mbrubeck/servo,ConnorGBrewster/servo,KiChjang/servo,fiji-flo/servo,notriddle/servo,canaltinova/servo,sadmansk/servo,saneyuki/servo,eddyb/servo,KiChjang/servo,rnestler/servo,saneyuki/servo,CJ8664/servo,cbrewster/servo,splav/servo,saneyuki/servo,avadacatavra/servo,dati91/servo,emilio/servo,emilio/servo,pyfisch/servo,saneyuki/servo,paulrouget/servo,dsandeephegde/servo,SimonSapin/servo,jimberlage/servo,saneyuki/servo,peterjoel/servo,CJ8664/servo,splav/servo,nnethercote/servo,upsuper/servo,mattnenterprise/servo,CJ8664/servo,DominoTree/servo,pyfisch/servo,nnethercote/servo,notriddle/servo,DominoTree/servo,szeged/servo,larsbergstrom/servo,notriddle/servo,szeged/servo,SimonSapin/servo,rnestler/servo,larsbergstrom/servo,saneyuki/servo,cbrewster/servo,CJ8664/servo,KiChjang/servo,avadacatavra/servo,splav/servo,avadacatavra/servo,dati91/servo,notriddle/servo,thiagopnts/servo,larsbergstrom/servo,dsandeephegde/servo,jimberlage/servo,mattnenterprise/servo,CJ8664/servo,upsuper/servo,szeged/servo,DominoTree/servo,emilio/servo,paulrouget/servo,nnethercote/servo,emilio/servo,nnethercote/servo,mattnenterprise/servo,sadmansk/servo,larsbergstrom/servo,jimberlage/servo,KiChjang/servo,mbrubeck/servo