Fix "make dockertest" to sync files better (#3807)
Fix "make dockertest" to sync files better (#3807)

* Fix "make dockertest" to sync files better

When you run "make dockertest" it copies the contents of the repository
directory into /app in a data container and then runs the tests in that. The
problem is that it doesn't remove files that have been removed.

This fixes the script to remove all the files in /app and then copy the files
from the repository directory into /app. In this way, it better handles files
that have been removed.

* Fix issues brought up by shellcheck and an expansion problem

Tayamarn/socorro,Tayamarn/socorro,adngdb/socorro,adngdb/socorro,m8ttyB/socorro,mozilla/socorro,lonnen/socorro,m8ttyB/socorro,mozilla/socorro,m8ttyB/socorro,adngdb/socorro,lonnen/socorro,adngdb/socorro,m8ttyB/socorro,mozilla/socorro,AdrianGaudebert/socorro,AdrianGaudebert/socorro,m8ttyB/socorro,lonnen/socorro,adngdb/socorro,Tayamarn/socorro,mozilla/socorro,Tayamarn/socorro,AdrianGaudebert/socorro,Tayamarn/socorro,lonnen/socorro,mozilla/socorro,AdrianGaudebert/socorro,Tayamarn/socorro,mozilla/socorro,AdrianGaudebert/socorro,AdrianGaudebert/socorro,m8ttyB/socorro,adngdb/socorro