Remove the pointless WeakReference based schema factory
Remove the pointless WeakReference based schema factory

Using a WeakHashMap to cache transient objects which are created in
our constructor and quickly discarded is useless.  Its very likely the
GC will purge these, and the map will lose the binding, so we just
generate the code again later.

Besides, applications aren't supposed to create Database objects
often.  Instead they create them once and hold onto it, resuing
the object as a factory/connection pool.

Change-Id: Ia6dc43757443ca60820c066393a1746fc7a2f001
Signed-off-by: Shawn O. Pearce <f3ea74d906fa9fe97c1fef6bad9cb871485c7045@google.com>

thinkernel/gwtorm,1yvT0s/gerrit.gwtorm,CandyShop/gerrit.gwtorm,evanchueng/gerrit.gwtorm,GerritCodeReview/gwtorm,GerritCodeReview/gwtorm,thinkernel/gwtorm