cmd/internal/obj/arm: fix/rationalize checkpool distance check
cmd/internal/obj/arm: fix/rationalize checkpool distance check

When deciding whether to flush the constant pool, the distance check
in checkpool can fail to account for padding inserted before the next
instruction by nacl.

For example, see this failure:
https://go-review.googlesource.com/c/go/+/109350/2#message-07085b591227824bb1d646a7192cbfa7e0b97066
Here, the pool should be flushed before a CALL instruction, but
checkpool only considers the CALL instruction to be 4 bytes and
doesn't account for the 8 extra bytes of alignment padding added
before it by asmoutnacl. As a result, it flushes the pool after the
CALL instruction, which is 4 bytes too late.

Furthermore, there's no explanation for the rather convoluted
expression used to decide if we need to emit the constant pool.

This CL modifies checkpool to take the PC following the tentative
instruction as an argument. The caller knows this already and this way
checkpool doesn't have to guess (and get it wrong in the presence of
padding). In the process, it rewrites the test to be structured and
commented.

Change-Id: I32a3d50ffb5a94d42be943e9bcd49036c7e9b95c
Reviewed-on: https://go-review.googlesource.com/110017
Run-TryBot: Austin Clements <7ea35d812706d9213868749011af1ed4fa2f6aa0@google.com>
TryBot-Result: Gobot Gobot <66cb808b70d30c07676d5e946fee83fd561249e5@golang.org>
Reviewed-by: Cherry Zhang <d62e63aa42ce272d7b6a5055d97e942b33a34679@google.com>

akutz/go,golang/go,cloudflare/go,CAFxX/go,nawawi/go,akutz/go,akutz/go,josharian/go,cloudflare/go,CAFxX/go,josharian/go,cloudflare/go,nawawi/go,CAFxX/go,golang/go,josharian/go,golang/go,akutz/go,golang/go,josharian/go,nawawi/go,cloudflare/go,CAFxX/go,josharian/go,cloudflare/go,josharian/go,akutz/go,cloudflare/go,nawawi/go,CAFxX/go,golang/go,golang/go,josharian/go,akutz/go,akutz/go,nawawi/go,nawawi/go,josharian/go,CAFxX/go,cloudflare/go,golang/go,nawawi/go,CAFxX/go,CAFxX/go,nawawi/go,akutz/go,golang/go,cloudflare/go