Index type doesn't have to be persisted
Index type doesn't have to be persisted

Summary:

With the recent changes, there is no need to check the property block about the index block type.
If user want to use it, they don't really need any disk format change; everything happens in the fly.

Also another team encountered an error while reading the index type from properties.

Test Plan:

ran all the tests

Reviewers: sdong

CC:

Task ID: #

Blame Rev:

caijieming-baidu/rocksdb,ylong/rocksdb,Vaisman/rocksdb,vashstorm/rocksdb,makelivedotnet/rocksdb,amyvmiwei/rocksdb,ryneli/rocksdb,bbiao/rocksdb,biddyweb/rocksdb,Andymic/rocksdb,ryneli/rocksdb,geraldoandradee/rocksdb,vashstorm/rocksdb,JoeWoo/rocksdb,virtdb/rocksdb,tschottdorf/rocksdb,wskplho/rocksdb,msb-at-yahoo/rocksdb,geraldoandradee/rocksdb,alihalabyah/rocksdb,facebook/rocksdb,anagav/rocksdb,kaschaeffer/rocksdb,geraldoandradee/rocksdb,jalexanderqed/rocksdb,Applied-Duality/rocksdb,IMCG/RcoksDB,anagav/rocksdb,msb-at-yahoo/rocksdb,alihalabyah/rocksdb,wat-ze-hex/rocksdb,tsheasha/rocksdb,vmx/rocksdb,bbiao/rocksdb,wlqGit/rocksdb,virtdb/rocksdb,vmx/rocksdb,lgscofield/rocksdb,JackLian/rocksdb,biddyweb/rocksdb,alihalabyah/rocksdb,geraldoandradee/rocksdb,vmx/rocksdb,rDSN-Projects/rocksdb.replicated,siddhartharay007/rocksdb,zhangpng/rocksdb,caijieming-baidu/rocksdb,luckywhu/rocksdb,facebook/rocksdb,geraldoandradee/rocksdb,NickCis/rocksdb,norton/rocksdb,biddyweb/rocksdb,JohnPJenkins/rocksdb,hobinyoon/rocksdb,norton/rocksdb,rDSN-Projects/rocksdb.replicated,ylong/rocksdb,JackLian/rocksdb,temicai/rocksdb,ylong/rocksdb,tizzybec/rocksdb,temicai/rocksdb,kaschaeffer/rocksdb,IMCG/RcoksDB,luckywhu/rocksdb,norton/rocksdb,lgscofield/rocksdb,JackLian/rocksdb,JoeWoo/rocksdb,hobinyoon/rocksdb,siddhartharay007/rocksdb,NickCis/rocksdb,IMCG/RcoksDB,OverlordQ/rocksdb,mbarbon/rocksdb,facebook/rocksdb,bbiao/rocksdb,lgscofield/rocksdb,facebook/rocksdb,fengshao0907/rocksdb,dkorolev/rocksdb,vmx/rocksdb,Andymic/rocksdb,virtdb/rocksdb,wlqGit/rocksdb,jalexanderqed/rocksdb,wat-ze-hex/rocksdb,Andymic/rocksdb,tsheasha/rocksdb,JohnPJenkins/rocksdb,wlqGit/rocksdb,kaschaeffer/rocksdb,wenduo/rocksdb,luckywhu/rocksdb,tizzybec/rocksdb,wenduo/rocksdb,NickCis/rocksdb,SunguckLee/RocksDB,virtdb/rocksdb,wenduo/rocksdb,siddhartharay007/rocksdb,makelivedotnet/rocksdb,JackLian/rocksdb,JohnPJenkins/rocksdb,kaschaeffer/rocksdb,dkorolev/rocksdb,zhangpng/rocksdb,wlqGit/rocksdb,hobinyoon/rocksdb,Applied-Duality/rocksdb,SunguckLee/RocksDB,ylong/rocksdb,amyvmiwei/rocksdb,JoeWoo/rocksdb,wat-ze-hex/rocksdb,ylong/rocksdb,caijieming-baidu/rocksdb,dkorolev/rocksdb,wat-ze-hex/rocksdb,Andymic/rocksdb,temicai/rocksdb,norton/rocksdb,skunkwerks/rocksdb,tizzybec/rocksdb,Vaisman/rocksdb,sorphi/rocksdb,msb-at-yahoo/rocksdb,bbiao/rocksdb,temicai/rocksdb,caijieming-baidu/rocksdb,Applied-Duality/rocksdb,mbarbon/rocksdb,wenduo/rocksdb,fengshao0907/rocksdb,wskplho/rocksdb,JackLian/rocksdb,wskplho/rocksdb,siddhartharay007/rocksdb,norton/rocksdb,JoeWoo/rocksdb,siddhartharay007/rocksdb,Applied-Duality/rocksdb,temicai/rocksdb,vmx/rocksdb,jalexanderqed/rocksdb,tizzybec/rocksdb,jalexanderqed/rocksdb,vashstorm/rocksdb,zhangpng/rocksdb,JohnPJenkins/rocksdb,bbiao/rocksdb,bbiao/rocksdb,lgscofield/rocksdb,wlqGit/rocksdb,alihalabyah/rocksdb,SunguckLee/RocksDB,temicai/rocksdb,RyanTech/rocksdb,flabby/rocksdb,tizzybec/rocksdb,IMCG/RcoksDB,tsheasha/rocksdb,geraldoandradee/rocksdb,bbiao/rocksdb,msb-at-yahoo/rocksdb,alihalabyah/rocksdb,bbiao/rocksdb,jalexanderqed/rocksdb,zhangpng/rocksdb,flabby/rocksdb,ryneli/rocksdb,vmx/rocksdb,wskplho/rocksdb,Vaisman/rocksdb,lgscofield/rocksdb,norton/rocksdb,IMCG/RcoksDB,hobinyoon/rocksdb,kaschaeffer/rocksdb,fengshao0907/rocksdb,jalexanderqed/rocksdb,biddyweb/rocksdb,skunkwerks/rocksdb,biddyweb/rocksdb,facebook/rocksdb,Vaisman/rocksdb,sorphi/rocksdb,dkorolev/rocksdb,amyvmiwei/rocksdb,JohnPJenkins/rocksdb,Andymic/rocksdb,facebook/rocksdb,anagav/rocksdb,ryneli/rocksdb,Vaisman/rocksdb,flabby/rocksdb,hobinyoon/rocksdb,tizzybec/rocksdb,facebook/rocksdb,rDSN-Projects/rocksdb.replicated,OverlordQ/rocksdb,vmx/rocksdb,tsheasha/rocksdb,makelivedotnet/rocksdb,Vaisman/rocksdb,ryneli/rocksdb,lgscofield/rocksdb,wenduo/rocksdb,Applied-Duality/rocksdb,makelivedotnet/rocksdb,caijieming-baidu/rocksdb,wlqGit/rocksdb,makelivedotnet/rocksdb,JackLian/rocksdb,ylong/rocksdb,sorphi/rocksdb,skunkwerks/rocksdb,dkorolev/rocksdb,luckywhu/rocksdb,NickCis/rocksdb,RyanTech/rocksdb,norton/rocksdb,vashstorm/rocksdb,kaschaeffer/rocksdb,amyvmiwei/rocksdb,RyanTech/rocksdb,jalexanderqed/rocksdb,RyanTech/rocksdb,SunguckLee/RocksDB,wlqGit/rocksdb,tschottdorf/rocksdb,mbarbon/rocksdb,wat-ze-hex/rocksdb,hobinyoon/rocksdb,NickCis/rocksdb,sorphi/rocksdb,wat-ze-hex/rocksdb,flabby/rocksdb,siddhartharay007/rocksdb,wat-ze-hex/rocksdb,SunguckLee/RocksDB,temicai/rocksdb,sorphi/rocksdb,msb-at-yahoo/rocksdb,mbarbon/rocksdb,anagav/rocksdb,virtdb/rocksdb,Vaisman/rocksdb,IMCG/RcoksDB,Andymic/rocksdb,IMCG/RcoksDB,RyanTech/rocksdb,SunguckLee/RocksDB,vashstorm/rocksdb,tschottdorf/rocksdb,caijieming-baidu/rocksdb,luckywhu/rocksdb,rDSN-Projects/rocksdb.replicated,mbarbon/rocksdb,tsheasha/rocksdb,skunkwerks/rocksdb,vashstorm/rocksdb,zhangpng/rocksdb,wenduo/rocksdb,virtdb/rocksdb,zhangpng/rocksdb,fengshao0907/rocksdb,rDSN-Projects/rocksdb.replicated,wskplho/rocksdb,makelivedotnet/rocksdb,wat-ze-hex/rocksdb,alihalabyah/rocksdb,fengshao0907/rocksdb,tschottdorf/rocksdb,OverlordQ/rocksdb,NickCis/rocksdb,JohnPJenkins/rocksdb,ylong/rocksdb,virtdb/rocksdb,JoeWoo/rocksdb,vmx/rocksdb,mbarbon/rocksdb,siddhartharay007/rocksdb,JohnPJenkins/rocksdb,sorphi/rocksdb,kaschaeffer/rocksdb,SunguckLee/RocksDB,flabby/rocksdb,wskplho/rocksdb,ryneli/rocksdb,tsheasha/rocksdb,JackLian/rocksdb,sorphi/rocksdb,wskplho/rocksdb,biddyweb/rocksdb,lgscofield/rocksdb,luckywhu/rocksdb,caijieming-baidu/rocksdb,Andymic/rocksdb,dkorolev/rocksdb,skunkwerks/rocksdb,tschottdorf/rocksdb,ryneli/rocksdb,RyanTech/rocksdb,anagav/rocksdb,OverlordQ/rocksdb,wenduo/rocksdb,skunkwerks/rocksdb,rDSN-Projects/rocksdb.replicated,fengshao0907/rocksdb,skunkwerks/rocksdb,tizzybec/rocksdb,wenduo/rocksdb,alihalabyah/rocksdb,amyvmiwei/rocksdb,rDSN-Projects/rocksdb.replicated,norton/rocksdb,OverlordQ/rocksdb,makelivedotnet/rocksdb,flabby/rocksdb,vashstorm/rocksdb,msb-at-yahoo/rocksdb,OverlordQ/rocksdb,tsheasha/rocksdb,amyvmiwei/rocksdb,Applied-Duality/rocksdb,anagav/rocksdb,flabby/rocksdb,mbarbon/rocksdb,tschottdorf/rocksdb,facebook/rocksdb,hobinyoon/rocksdb,JoeWoo/rocksdb,Andymic/rocksdb,Applied-Duality/rocksdb,JoeWoo/rocksdb,amyvmiwei/rocksdb,zhangpng/rocksdb,SunguckLee/RocksDB,OverlordQ/rocksdb,geraldoandradee/rocksdb,hobinyoon/rocksdb,tsheasha/rocksdb,fengshao0907/rocksdb,dkorolev/rocksdb,luckywhu/rocksdb,NickCis/rocksdb,anagav/rocksdb,biddyweb/rocksdb,RyanTech/rocksdb