<body onunload="M_unloadPage();">
<body onunload="M_unloadPage();">

<!-- Begin help window -->
<script type="text/javascript"><!--
var xsrfToken = 'dd5d1a57ca1d5440593050fdc596d377';
var helpDisplayed = false;
document.onclick = M_clickCommon;
var media_url = "/static/";
var base_url = "/";

var publish_link = "/4571045/publish";

// -->
</script>
<div id="help" style="display: none;">

<div style="font-size: medium; text-align: center;">Keyboard Shortcuts</div>
<hr>
<table width="100%">

  <tbody><tr valign="top">
      <td>
            <table width="100%">
	            <tbody><tr>
		              <td></td><th>File</th>
			              </tr>
				              <tr>
					                <td class="shortcut"><span class="letter">u</span> <b>:</b></td><td>up to issue</td>
							        </tr>
								        <tr>
									          <td class="shortcut"><span class="letter">m</span> <b>:</b></td><td>publish + mail comments</td>
										          </tr>
											  	<tr>
													  <td class="shortcut"><span class="letter">M</span> <b>:</b></td><td>edit review message</td>
													  	</tr>
														        <tr>
															          <td class="shortcut"><span class="letter">j</span> / <span class="letter">k</span> <b>:</b></td><td>jump to file after / before current file</td>
																          </tr>
																	          <tr>
																		            <td class="shortcut"><span class="letter">J</span> / <span class="letter">K</span> <b>:</b></td><td>jump to next file with a comment after / before current file</td>
																			            </tr>
																				            <tr>
																					              <td></td><th>Side-by-side diff</th>
																						              </tr>
																							              <tr>
																								                <td class="shortcut"><span class="letter">i</span> <b>:</b></td><td>toggle intra-line diffs</td>
																										        </tr>
																											        <tr>
																												          <td class="shortcut"><span class="letter">e</span> <b>:</b></td><td>expand all comments</td>
																													          </tr>
																														          <tr>
																															            <td class="shortcut"><span class="letter">c</span> <b>:</b></td><td>collapse all comments</td>
																																            </tr>
																																	            <tr>
																																		              <td class="shortcut"><span class="letter">s</span> <b>:</b></td><td>toggle showing all comments</td>
																																			              </tr>
																																				              <tr>
																																					                <td class="shortcut"><span class="letter">n</span> / <span class="letter">p</span> <b>:</b></td><td>next / previous diff chunk or comment</td>
																																							        </tr>
																																								        <tr>
																																									          <td class="shortcut"><span class="letter">N</span> / <span class="letter">P</span> <b>:</b></td><td>next / previous comment</td>
																																										          </tr>
																																											          <tr>
																																												            <td class="shortcut"><span class="letter">&lt;Enter&gt;</span> <b>:</b></td><td>respond to / edit current comment</td>
																																													            </tr>
																																														          </tbody></table>
																																															      </td>
																																															          <td>
																																																        <table width="100%"> 
																																																	        <tbody><tr>
																																																		         <td></td><th>Issue</th>
																																																			         </tr>
																																																				         <tr>
																																																					           <td class="shortcut"><span class="letter">u</span> <b>:</b></td><td>up to list of issues</td>
																																																						           </tr>
																																																							           <tr>
																																																								             <td class="shortcut"><span class="letter">m</span> <b>:</b></td><td>publish + mail comments</td>
																																																									             </tr>
																																																										     	<tr>
																																																												  <td class="shortcut"><span class="letter">j</span> / <span class="letter">k</span> <b>:</b></td><td>jump to patch after / before current patch</td>
																																																												  	</tr>
																																																														<tr>
																																																															  <td class="shortcut"><span class="letter">o</span> / <span class="letter">&lt;Enter&gt;</span> <b>:</b></td><td>open current patch in side-by-side view</td>
																																																															  	</tr>
																																																																	<tr>
																																																																		  <td class="shortcut"><span class="letter">i</span> <b>:</b></td><td>open current patch in unified diff view</td>
																																																																		  	</tr>
																																																																			        <tr><td>&nbsp;</td></tr>
																																																																				        <tr><td></td><th>Issue List</th></tr>
																																																																					        <tr>
																																																																						          <td class="shortcut"><span class="letter">j</span> / <span class="letter">k</span> <b>:</b></td><td>jump to issue after / before current issue</td>
																																																																							          </tr>
																																																																								          <tr>
																																																																									            <td class="shortcut"><span class="letter">o</span> / <span class="letter">&lt;Enter&gt;</span> <b>:</b></td><td>open current issue</td>
																																																																										            </tr>
																																																																											            <tr>
																																																																												    	  <td class="shortcut"><span class="letter">#</span> <b>:</b></td>
																																																																													  	  <td>close issue</td>
																																																																														  	</tr>
																																																																															        <tr><td>&nbsp;</td></tr>
																																																																																        <tr>
																																																																																	          <td></td><th>Comment/message editing</th>
																																																																																		          </tr>
																																																																																			          <tr>
																																																																																				            <td class="shortcut"><span class="letter">&lt;Ctrl&gt;</span> + <span class="letter">s</span> <b>:</b></td><td>save comment</td>
																																																																																					            </tr>
																																																																																						            <tr>
																																																																																							              <td class="shortcut"><span class="letter">&lt;Esc&gt;</span> <b>:</b></td><td>cancel edit</td>
																																																																																								              </tr>
																																																																																									            </tbody></table>
																																																																																										        </td>
																																																																																											  </tr>

																																																																																											  </tbody></table>
																																																																																											  </div>
																																																																																											  <!-- End help window -->

																																																																																											  <div align="right">

																																																																																											  <div style="float:left; font-weight:bold"><i>Rietveld</i> Code Review Tool</div>


																																																																																											  <b>tomhudson@google.com (TomH)</b>
																																																																																											  |

																																																																																											  <a class="novisit" href="/settings">Settings</a>
																																																																																											  |


																																																																																											  <a class="novisit" target="_blank" href="http://code.google.com/p/rietveld/wiki/CodeReviewHelp">Help</a>
																																																																																											  |
																																																																																											  <a class="novisit" target="_blank" href="http://code.google.com/p/rietveld/issues/list">Bug tracker</a>
																																																																																											  |
																																																																																											  <a class="novisit" target="_blank" href="http://groups.google.com/group/codereview-discuss">Discussion group</a>
																																																																																											  |
																																																																																											  <a class="novisit" target="_blank" href="http://code.google.com/p/rietveld">Source code</a>
																																																																																											  |

																																																																																											  <a class="novisit" href="http://codereview.appspot.com/_ah/logout?continue=https://www.google.com/accounts/Logout%3Fcontinue%3Dhttps://appengine.google.com/_ah/logout%253Fcontinue%253Dhttp://codereview.appspot.com/4571045/%26service%3Dah">Sign out</a>

																																																																																											  </div>

																																																																																											  <div class="counter">(691)</div>
																																																																																											  <div class="mainmenu">
																																																																																											    
																																																																																											      <a href="/" class="active">Issues</a>
																																																																																											        <a href="/repos">Repositories</a>
																																																																																												  <a href="/search">Search</a>

																																																																																												  </div>
																																																																																												  <div class="mainmenu2">
																																																																																												    
																																																																																												      
																																																																																												          
																																																																																													        <a href="/use_uploadpy">Create Issue</a>
																																																																																														    
																																																																																														        |
																																																																																															    <a href="/mine">My Issues</a>
																																																																																															        |
																																																																																																    <a href="/starred">Starred</a>
																																																																																																        |
																																																																																																	    <a href="/all">Open</a>
																																																																																																	        |
																																																																																																		    <a href="/all?closed=1">All</a>
																																																																																																		      

																																																																																																		      </div>

																																																																																																		      <div>

																																																																																																		        <h2>
																																																																																																			    <span id="issue-star-4571045">
																																																																																																			      
																																																																																																			          
																																																																																																				        <a href="javascript:M_addIssueStar(4571045)">
																																																																																																						<img src="/static/star-dark.gif" width="15" height="15" border="0"></a>
																																																																																																						    
																																																																																																						      
																																																																																																						      </span>


																																																																																																						      <span class="issue-close" id="issue-close-4571045">
																																																																																																						          <a href="javascript:M_closeIssue(4571045)">
																																																																																																							        <img src="/static/close.gif" title="Close This Issue" width="15" height="15" border="0"></a>
																																																																																																								</span>

																																																																																																								    Issue <a href="/4571045/" onmouseover="M_showPopUp(this, 'popup-issue');">
																																																																																																								                4571045</a>:
																																																																																																										    New matrix benchmarks to evaluate ::setConcat implementation options 
																																																																																																										      </h2>

																																																																																																										        <table class="issue-details" border="0" width="100%">
																																																																																																											    <tbody><tr valign="top">

																																																																																																											          <td class="meta" width="20%">
																																																																																																												          
																																																																																																													            <div>
																																																																																																														                
																																																																																																																              <a class="novisit" href="/4571045/edit">
																																																																																																																	                      Edit Issue
																																																																																																																			                    </a>
																																																																																																																					                
																																																																																																																							            <br>
																																																																																																																								                
																																																																																																																										              <a class="novisit" href="/4571045/publish">
																																																																																																																											                      Publish+Mail Comments
																																																																																																																													                    </a> ('m')
																																																																																																																															                
																																																																																																																																	            
																																																																																																																																		                  <br>
																																																																																																																																				                <a class="novisit" href="/4571045/diff/1/bench/MatrixBench.cpp">
																																																																																																																																						                <b>Start Review</b>
																																																																																																																																								              </a>
																																																																																																																																									                  
																																																																																																																																											            </div>
																																																																																																																																												            
																																																																																																																																													            <div class="issue_details_sidebar">
																																																																																																																																														              <div><b>Created:</b><br>
																																																																																																																																															                  16 minutes ago by me
																																																																																																																																																	            </div>
																																																																																																																																																		              <div><b>Modified:</b><br>
																																																																																																																																																			                  0 minutes ago
																																																																																																																																																					            </div>
																																																																																																																																																						              <div><b>Reviewers:</b><br>
																																																																																																																																																							                  <a href="/user/reed1" onmouseover="M_showUserInfoPopup(this)">reed1</a>
																																																																																																																																																									            </div>
																																																																																																																																																										              <div><b>CC:</b><br>
																																																																																																																																																											                  
																																																																																																																																																													            </div>
																																																																																																																																																														              <div><b>Base URL:</b><br>
																																																																																																																																																															                  http://skia.googlecode.com/svn/trunk/
																																																																																																																																																																	            </div>
																																																																																																																																																																		              <div><b>Visibility:</b><br>
																																																																																																																																																																			                  
																																																																																																																																																																					                  Public.
																																																																																																																																																																							              
																																																																																																																																																																								                </div>
																																																																																																																																																																										        </div>
																																																																																																																																																																											      </td>

																																																																																																																																																																											            <td style="padding-left: .8em; padding-right: .8em;" width="80%">
																																																																																																																																																																												            




																																																																																																																																																																													      <h3><a id="issue-description-pointer" href="javascript:M_toggleSection('issue-description')" class="toggled-section opentriangle">
																																																																																																																																																																													          Description</a></h3>
																																																																																																																																																																														    <div id="issue-description" style="margin-left:15px;">
																																																																																																																																																																														        <pre>On platforms that use Float (instead of Fixed), SkMatrix stores its internal
																																																																																																																																																																															values as floats, but setConcat() needs extra precision and so uses doubles to
																																																																																																																																																																															contain intermediate values.
																																																																																																																																																																															These three benchmarks compare the speed of float-only, double-only, and
																																																																																																																																																																															float-cast-to-double implementations of a chunk of code extracted from the
																																																																																																																																																																															non-perspective case of setConcat().
																																																																																																																																																																															</pre>
																																																																																																																																																																															  </div>




																																																																																																																																																																															    <h3>
																																																																																																																																																																															        <a id="ps-1-pointer" href="javascript:M_toggleSectionForPS('4571045', '1')" class="toggled-section opentriangle">
																																																																																																																																																																																      Patch Set 1
																																																																																																																																																																																            
																																																																																																																																																																																	        </a>
																																																																																																																																																																																		  </h3>

																																																																																																																																																																																		    

																																																																																																																																																																																		      <div id="ps-1" style="">
																																																																																																																																																																																		          
																																																																																																																																																																																			  <div class="issue-list">

																																																																																																																																																																																			    <div class="pagination">
																																																																																																																																																																																			        <div style="float: left;">
																																																																																																																																																																																				      <i>Created:</i> 16 minutes ago
																																																																																																																																																																																				          </div>
																																																																																																																																																																																					      <div style="float: right;">
																																																																																																																																																																																					            
																																																																																																																																																																																						            <a href="/download/issue4571045_1.diff">
																																																																																																																																																																																							              Download raw patch set</a>
																																																																																																																																																																																								            
																																																																																																																																																																																									          
																																																																																																																																																																																										      </div>
																																																																																																																																																																																										          <div style="clear:both;"></div>
																																																																																																																																																																																											    </div>

																																																																																																																																																																																											      <table id="queues" style="clear:both;">
																																																																																																																																																																																											          <tbody><tr align="left">
																																																																																																																																																																																												        <th colspan="2"></th>
																																																																																																																																																																																													      <th>Unified diffs</th>
																																																																																																																																																																																													            <th>Side-by-side diffs</th>
																																																																																																																																																																																														          <th>Delta from patch set</th>
																																																																																																																																																																																															        <th colspan="3">Stats</th>
																																																																																																																																																																																																      <th>Patch</th>
																																																																																																																																																																																																          </tr>

																																																																																																																																																																																																	      
																																																																																																																																																																																																	            <tr name="patch">
																																																																																																																																																																																																		            <td class="first" width="14"><img src="/static/closedtriangle.gif" style="" width="12" height="9"></td>
																																																																																																																																																																																																			            <td style="white-space: nowrap">M    </td>
																																																																																																																																																																																																				            <td>
																																																																																																																																																																																																					              <a class="noul" href="/4571045/patch/1/2">
																																																																																																																																																																																																						                  bench/MatrixBench.cpp
																																																																																																																																																																																																								            </a>
																																																																																																																																																																																																									            </td>
																																																																																																																																																																																																										            <td>
																																																																																																																																																																																																											              <a class="noul" href="/4571045/diff/1/bench/MatrixBench.cpp">
																																																																																																																																																																																																												                  View
																																																																																																																																																																																																														            </a>
																																																																																																																																																																																																															            </td>
																																																																																																																																																																																																																            <td style="white-space: nowrap">
																																																																																																																																																																																																																	            
																																																																																																																																																																																																																		            </td>
																																																																																																																																																																																																																			            <td style="white-space: nowrap">4 chunks</td>
																																																																																																																																																																																																																				            <td style="white-space: nowrap">+114 lines, -3 lines</td>
																																																																																																																																																																																																																					            <td style="white-space: nowrap">
																																																																																																																																																																																																																						              
																																																																																																																																																																																																																							                  0 comments
																																																																																																																																																																																																																									              
																																																																																																																																																																																																																										                
																																																																																																																																																																																																																												        </td>
																																																																																																																																																																																																																													        <td>
																																																																																																																																																																																																																														          <a href="/download/issue4571045_1_2.diff" title="Download patch for bench/MatrixBench.cpp">
																																																																																																																																																																																																																															              Download
																																																																																																																																																																																																																																                </a>
																																																																																																																																																																																																																																		        </td>
																																																																																																																																																																																																																																			      </tr>
																																																																																																																																																																																																																																			          

																																																																																																																																																																																																																																				    </tbody></table>
																																																																																																																																																																																																																																				    </div>

																																																																																																																																																																																																																																				      
																																																																																																																																																																																																																																				        </div>




																																																																																																																																																																																																																																					  




																																																																																																																																																																																																																																					    <h3>
																																																																																																																																																																																																																																					        <a id="messages-pointer" href="javascript:M_toggleSection('messages')" class="toggled-section opentriangle">
																																																																																																																																																																																																																																						      Messages
																																																																																																																																																																																																																																						          </a>
																																																																																																																																																																																																																																							    </h3>

																																																																																																																																																																																																																																							      <div><i>Total messages: 3</i></div>

																																																																																																																																																																																																																																							        <div id="messages">
																																																																																																																																																																																																																																								    <div style="margin-bottom: .5em;">
																																																																																																																																																																																																																																								          <a href="javascript:M_showAllComments('cl', 3)">
																																																																																																																																																																																																																																									          Expand All Messages</a>
																																																																																																																																																																																																																																										        |
																																																																																																																																																																																																																																											      <a href="javascript:M_hideAllComments('cl', 3)">
																																																																																																																																																																																																																																											              Collapse All Messages</a>
																																																																																																																																																																																																																																												          </div>

																																																																																																																																																																																																																																													      
																																																																																																																																																																																																																																													            <div class="message " id="msg-agpjb2RlcmV2aWV3chwLEgVJc3N1ZRil_5YCDAsSB01lc3NhZ2UY6QcM" name="0">
																																																																																																																																																																																																																																														            <a name="msg-agpjb2RlcmV2aWV3chwLEgVJc3N1ZRil_5YCDAsSB01lc3NhZ2UY6QcM"></a>
																																																																																																																																																																																																																																															            <div class="header">
																																																																																																																																																																																																																																																              <table border="0" width="100%" cellspacing="0" cellpadding="0">
																																																																																																																																																																																																																																																	                  <tbody><tr class="comment_title" onclick="M_switchChangelistComment(0)">
																																																																																																																																																																																																																																																			                <td style="padding-left: 5px; white-space: nowrap;">
																																																																																																																																																																																																																																																					                <b>me</b>
																																																																																																																																																																																																																																																							              </td>
																																																																																																																																																																																																																																																								                    <td width="100%">
																																																																																																																																																																																																																																																										                    <table style="table-layout:fixed; white-space: nowrap;" width="100%">
																																																																																																																																																																																																																																																												                      <tbody><tr>
																																																																																																																																																																																																																																																														                          <td>
																																																																																																																																																																																																																																																																	                        <div style="white-space: nowrap; overflow: hidden;" class="extra" id="cl-preview-0">
																																																																																																																																																																																																																																																																				                          
																																																																																																																																																																																																																																																																							                         </div>
																																																																																																																																																																																																																																																																										                     </td>
																																																																																																																																																																																																																																																																												                       </tr>
																																																																																																																																																																																																																																																																														                       </tbody></table>
																																																																																																																																																																																																																																																																																                     </td>
																																																																																																																																																																																																																																																																																		                   <td align="right" style="white-space: nowrap; padding-right: 5px;">
																																																																																																																																																																																																																																																																																				                   13 minutes ago
																																																																																																																																																																																																																																																																																						                 </td>
																																																																																																																																																																																																																																																																																								             </tr>
																																																																																																																																																																																																																																																																																									               </tbody></table>
																																																																																																																																																																																																																																																																																										               </div>

																																																																																																																																																																																																																																																																																											               <div id="cl-comment-0" style="display: none;">
																																																																																																																																																																																																																																																																																												                 <div class="message-body">
																																																																																																																																																																																																																																																																																														             <pre name="cl-message-0"></pre>
																																																																																																																																																																																																																																																																																															               </div>
																																																																																																																																																																																																																																																																																																                 <div class="message-actions">
																																																																																																																																																																																																																																																																																																		             
																																																																																																																																																																																																																																																																																																			                   <a href="javascript:M_replyToMessage('0', '2011/06/03 18:57:35', 'TomH')" id="message-reply-href-0">Reply</a>
																																																																																																																																																																																																																																																																																																					                 <textarea rows="7" cols="70" name="message" style="display:none"></textarea>
																																																																																																																																																																																																																																																																																																							               <div id="message-reply-0" style="display:none;"></div>
																																																																																																																																																																																																																																																																																																								                   
																																																																																																																																																																																																																																																																																																										             </div>
																																																																																																																																																																																																																																																																																																											             </div>

																																																																																																																																																																																																																																																																																																												           </div>
																																																																																																																																																																																																																																																																																																													       
																																																																																																																																																																																																																																																																																																													             <div class="message " id="msg-agpjb2RlcmV2aWV3chwLEgVJc3N1ZRil_5YCDAsSB01lc3NhZ2UY0Q8M" name="1">
																																																																																																																																																																																																																																																																																																														             <a name="msg-agpjb2RlcmV2aWV3chwLEgVJc3N1ZRil_5YCDAsSB01lc3NhZ2UY0Q8M"></a>
																																																																																																																																																																																																																																																																																																															             <div class="header">
																																																																																																																																																																																																																																																																																																																               <table border="0" width="100%" cellspacing="0" cellpadding="0">
																																																																																																																																																																																																																																																																																																																	                   <tbody><tr class="comment_title" onclick="M_switchChangelistComment(1)">
																																																																																																																																																																																																																																																																																																																			                 <td style="padding-left: 5px; white-space: nowrap;">
																																																																																																																																																																																																																																																																																																																					                 <b>reed1</b>
																																																																																																																																																																																																																																																																																																																							               </td>
																																																																																																																																																																																																																																																																																																																								                     <td width="100%">
																																																																																																																																																																																																																																																																																																																										                     <table style="table-layout:fixed; white-space: nowrap;" width="100%">
																																																																																																																																																																																																																																																																																																																												                       <tbody><tr>
																																																																																																																																																																																																																																																																																																																														                           <td>
																																																																																																																																																																																																																																																																																																																																	                         <div style="white-space: nowrap; overflow: hidden;" class="extra" id="cl-preview-1">
																																																																																																																																																																																																																																																																																																																																				                           1. lets remove the "fix" from the function name. just muladdmul I think 2. we ...
																																																																																																																																																																																																																																																																																																																																							                          </div>
																																																																																																																																																																																																																																																																																																																																										                      </td>
																																																																																																																																																																																																																																																																																																																																												                        </tr>
																																																																																																																																																																																																																																																																																																																																															                </tbody></table>
																																																																																																																																																																																																																																																																																																																																																	              </td>
																																																																																																																																																																																																																																																																																																																																																		                    <td align="right" style="white-space: nowrap; padding-right: 5px;">
																																																																																																																																																																																																																																																																																																																																																				                    10 minutes ago
																																																																																																																																																																																																																																																																																																																																																						                  </td>
																																																																																																																																																																																																																																																																																																																																																								              </tr>
																																																																																																																																																																																																																																																																																																																																																									                </tbody></table>
																																																																																																																																																																																																																																																																																																																																																											        </div>

																																																																																																																																																																																																																																																																																																																																																												        <div id="cl-comment-1" style="display: none;">
																																																																																																																																																																																																																																																																																																																																																													          <div class="message-body">
																																																																																																																																																																																																																																																																																																																																																														              <pre name="cl-message-1">1. lets remove the "fix" from the function name. just muladdmul I think
																																																																																																																																																																																																																																																																																																																																																															      2. we can remove the return, since it will be compiled away anyway
																																																																																																																																																																																																																																																																																																																																																															      3. nice checkin comment!
																																																																																																																																																																																																																																																																																																																																																															      4. what are the results like?</pre>
																																																																																																																																																																																																																																																																																																																																																															                </div>
																																																																																																																																																																																																																																																																																																																																																																	          <div class="message-actions">
																																																																																																																																																																																																																																																																																																																																																																		              
																																																																																																																																																																																																																																																																																																																																																																			                    <a href="javascript:M_replyToMessage('1', '2011/06/03 19:00:39', 'reed1')" id="message-reply-href-1">Reply</a>
																																																																																																																																																																																																																																																																																																																																																																					                  <textarea rows="7" cols="70" name="message" style="display:none"></textarea>
																																																																																																																																																																																																																																																																																																																																																																							                <div id="message-reply-1" style="display:none;"></div>
																																																																																																																																																																																																																																																																																																																																																																									            
																																																																																																																																																																																																																																																																																																																																																																										              </div>
																																																																																																																																																																																																																																																																																																																																																																											              </div>

																																																																																																																																																																																																																																																																																																																																																																												            </div>
																																																																																																																																																																																																																																																																																																																																																																													        
																																																																																																																																																																																																																																																																																																																																																																														      <div class="message " id="msg-agpjb2RlcmV2aWV3chwLEgVJc3N1ZRil_5YCDAsSB01lc3NhZ2UYuRcM" name="2">
																																																																																																																																																																																																																																																																																																																																																																														              <a name="msg-agpjb2RlcmV2aWV3chwLEgVJc3N1ZRil_5YCDAsSB01lc3NhZ2UYuRcM"></a>
																																																																																																																																																																																																																																																																																																																																																																															              <div class="header">
																																																																																																																																																																																																																																																																																																																																																																																                <table border="0" width="100%" cellspacing="0" cellpadding="0">
																																																																																																																																																																																																																																																																																																																																																																																		            <tbody><tr class="comment_title" onclick="M_switchChangelistComment(2)">
																																																																																																																																																																																																																																																																																																																																																																																			                  <td style="padding-left: 5px; white-space: nowrap;">
																																																																																																																																																																																																																																																																																																																																																																																					                  <b>me</b>
																																																																																																																																																																																																																																																																																																																																																																																							                </td>
																																																																																																																																																																																																																																																																																																																																																																																									              <td width="100%">
																																																																																																																																																																																																																																																																																																																																																																																										                      <table style="table-layout:fixed; white-space: nowrap;" width="100%">
																																																																																																																																																																																																																																																																																																																																																																																												                        <tbody><tr>
																																																																																																																																																																																																																																																																																																																																																																																															                    <td>
																																																																																																																																																																																																																																																																																																																																																																																																	                          <div style="white-space: nowrap; overflow: hidden; visibility: hidden;" class="extra" id="cl-preview-2">
																																																																																																																																																																																																																																																																																																																																																																																																				                            &gt; 4. what are the results like? For posterity: tomhudson@tomhudson-zx600-linux:/usr/local/google/src/skia3$ out/bench/bench -match matrix_concat -repeat 1000 ...
																																																																																																																																																																																																																																																																																																																																																																																																							                           </div>
																																																																																																																																																																																																																																																																																																																																																																																																										                       </td>
																																																																																																																																																																																																																																																																																																																																																																																																												                         </tr>
																																																																																																																																																																																																																																																																																																																																																																																																															                 </tbody></table>
																																																																																																																																																																																																																																																																																																																																																																																																																	               </td>
																																																																																																																																																																																																																																																																																																																																																																																																																		                     <td align="right" style="white-space: nowrap; padding-right: 5px;">
																																																																																																																																																																																																																																																																																																																																																																																																																				                     0 minutes ago
																																																																																																																																																																																																																																																																																																																																																																																																																						                   </td>
																																																																																																																																																																																																																																																																																																																																																																																																																								               </tr>
																																																																																																																																																																																																																																																																																																																																																																																																																									                 </tbody></table>
																																																																																																																																																																																																																																																																																																																																																																																																																											         </div>

																																																																																																																																																																																																																																																																																																																																																																																																																												         <div id="cl-comment-2">
																																																																																																																																																																																																																																																																																																																																																																																																																													           <div class="message-body">
																																																																																																																																																																																																																																																																																																																																																																																																																														               <pre name="cl-message-2">&gt; 4. what are the results like?

																																																																																																																																																																																																																																																																																																																																																																																																																															       For posterity:

																																																																																																																																																																																																																																																																																																																																																																																																																															       tomhudson@tomhudson-zx600-linux:/usr/local/google/src/skia3$ out/bench/bench
																																																																																																																																																																																																																																																																																																																																																																																																																															       -match matrix_concat -repeat 1000
																																																																																																																																																																																																																																																																																																																																																																																																																															       skia bench: alpha=0xFF antialias=1 filter=0
																																																																																																																																																																																																																																																																																																																																																																																																																															       running bench [640 480]         matrix_concat_double  8888: msecs =  0.79   565:
																																																																																																																																																																																																																																																																																																																																																																																																																															       msecs =  0.79   GPU: msecs =  0.79
																																																																																																																																																																																																																																																																																																																																																																																																																															       running bench [640 480]    matrix_concat_floatdouble  8888: msecs =  0.97   565:
																																																																																																																																																																																																																																																																																																																																																																																																																															       msecs =  0.97   GPU: msecs =  0.97
																																																																																																																																																																																																																																																																																																																																																																																																																															       running bench [640 480]          matrix_concat_float  8888: msecs =  0.74   565:
																																																																																																																																																																																																																																																																																																																																																																																																																															       msecs =  0.73   GPU: msecs =  0.74</pre>
																																																																																																																																																																																																																																																																																																																																																																																																																															                 </div>
																																																																																																																																																																																																																																																																																																																																																																																																																																	           <div class="message-actions">
																																																																																																																																																																																																																																																																																																																																																																																																																																		               
																																																																																																																																																																																																																																																																																																																																																																																																																																			                     <a href="javascript:M_replyToMessage('2', '2011/06/03 19:11:06', 'TomH')" id="message-reply-href-2">Reply</a>
																																																																																																																																																																																																																																																																																																																																																																																																																																					                   <textarea rows="7" cols="70" name="message" style="display:none"></textarea>
																																																																																																																																																																																																																																																																																																																																																																																																																																							                 <div id="message-reply-2" style="display:none;"></div>
																																																																																																																																																																																																																																																																																																																																																																																																																																									             
																																																																																																																																																																																																																																																																																																																																																																																																																																										               </div>
																																																																																																																																																																																																																																																																																																																																																																																																																																											               </div>

																																																																																																																																																																																																																																																																																																																																																																																																																																												             </div>
																																																																																																																																																																																																																																																																																																																																																																																																																																													         

																																																																																																																																																																																																																																																																																																																																																																																																																																														     <div>
																																																																																																																																																																																																																																																																																																																																																																																																																																														           <a href="javascript:M_showAllComments('cl', 3)">
																																																																																																																																																																																																																																																																																																																																																																																																																																															         Expand All Messages</a>
																																																																																																																																																																																																																																																																																																																																																																																																																																																       |
																																																																																																																																																																																																																																																																																																																																																																																																																																																             <a href="javascript:M_hideAllComments('cl', 3)">
																																																																																																																																																																																																																																																																																																																																																																																																																																																	             Collapse All Messages</a>
																																																																																																																																																																																																																																																																																																																																																																																																																																																		         </div>

																																																																																																																																																																																																																																																																																																																																																																																																																																																			   </div>



																																																																																																																																																																																																																																																																																																																																																																																																																																																			   <script language="JavaScript" type="text/javascript">
																																																																																																																																																																																																																																																																																																																																																																																																																																																			     <!--
																																																																																																																																																																																																																																																																																																																																																																																																																																																			         document.onkeydown = M_changelistKeyDown;
																																																																																																																																																																																																																																																																																																																																																																																																																																																				     var dashboardState = new M_DashboardState(window, 'patch', 'M_CLPatchMarker');
																																																																																																																																																																																																																																																																																																																																																																																																																																																				         M_switchChangelistCommentByAnchor();
																																																																																																																																																																																																																																																																																																																																																																																																																																																					   // -->
																																																																																																																																																																																																																																																																																																																																																																																																																																																					   </script>



																																																																																																																																																																																																																																																																																																																																																																																																																																																					     <div style="display:none;">
																																																																																																																																																																																																																																																																																																																																																																																																																																																					         <form method="POST" action="/4571045/publish" id="message-reply-form">
																																																																																																																																																																																																																																																																																																																																																																																																																																																						       <input type="hidden" name="xsrf_token" value="dd5d1a57ca1d5440593050fdc596d377">
																																																																																																																																																																																																																																																																																																																																																																																																																																																						             <div></div>
																																																																																																																																																																																																																																																																																																																																																																																																																																																							           <input type="hidden" name="subject" value="New matrix benchmarks to evaluate ::setConcat implementation options">
																																																																																																																																																																																																																																																																																																																																																																																																																																																								         <input type="hidden" name="message_only" value="1">
																																																																																																																																																																																																																																																																																																																																																																																																																																																									       <input type="submit" value="Send Message">
																																																																																																																																																																																																																																																																																																																																																																																																																																																									             <input type="button" value="Discard" name="discard">
																																																																																																																																																																																																																																																																																																																																																																																																																																																										           <input type="checkbox" name="send_mail" value="1" id="message-reply-send-mail" checked="checked">
																																																																																																																																																																																																																																																																																																																																																																																																																																																											         <label>Send mail to reviewers</label>
																																																																																																																																																																																																																																																																																																																																																																																																																																																												     </form>
																																																																																																																																																																																																																																																																																																																																																																																																																																																												       </div>
																																																																																																																																																																																																																																																																																																																																																																																																																																																												         <a id="resizer" class="resizer" style="display:none;cursor:pointer">
																																																																																																																																																																																																																																																																																																																																																																																																																																																													     <img src="/static/zippyplus.gif">
																																																																																																																																																																																																																																																																																																																																																																																																																																																													       </a>



																																																																																																																																																																																																																																																																																																																																																																																																																																																													             </td>
																																																																																																																																																																																																																																																																																																																																																																																																																																																														         </tr>
																																																																																																																																																																																																																																																																																																																																																																																																																																																															   </tbody></table>

																																																																																																																																																																																																																																																																																																																																																																																																																																																															   </div>

																																																																																																																																																																																																																																																																																																																																																																																																																																																															     
																																																																																																																																																																																																																																																																																																																																																																																																																																																															         <div class="popup" id="popup-issue" style="left: 104px; top: 116px; visibility: hidden; ">
																																																																																																																																																																																																																																																																																																																																																																																																																																																																       <b>Issue 4571045: New matrix benchmarks to evaluate ::setConcat implementation options
																																																																																																																																																																																																																																																																																																																																																																																																																																																																       	</b><br>
																																																																																																																																																																																																																																																																																																																																																																																																																																																																	      Created 16 minutes ago by me<br>
																																																																																																																																																																																																																																																																																																																																																																																																																																																																	            Modified 0 minutes ago<br>
																																																																																																																																																																																																																																																																																																																																																																																																																																																																		          Reviewers: reed1<br>
																																																																																																																																																																																																																																																																																																																																																																																																																																																																			        Base URL: http://skia.googlecode.com/svn/trunk/<br>
																																																																																																																																																																																																																																																																																																																																																																																																																																																																				      Comments: 0
																																																																																																																																																																																																																																																																																																																																																																																																																																																																				            
																																																																																																																																																																																																																																																																																																																																																																																																																																																																					        </div>
																																																																																																																																																																																																																																																																																																																																																																																																																																																																						  


																																																																																																																																																																																																																																																																																																																																																																																																																																																																						  <p></p>
																																																																																																																																																																																																																																																																																																																																																																																																																																																																						  <div style="float: left;">
																																																																																																																																																																																																																																																																																																																																																																																																																																																																						    <a target="_blank" href="http://code.google.com/appengine/"><img border="0" src="/static/appengine-noborder-120x30.gif" alt="Powered by Google App Engine"></a>
																																																																																																																																																																																																																																																																																																																																																																																																																																																																						    </div>

																																																																																																																																																																																																																																																																																																																																																																																																																																																																						    <div class="extra" style="font-size: 9pt; float: right; text-align: right;">
																																																																																																																																																																																																																																																																																																																																																																																																																																																																						      <div style="height:14px;">
																																																																																																																																																																																																																																																																																																																																																																																																																																																																						        <img src="/static/rss.gif" alt="RSS Feeds" width="14" height="14" align="top">
																																																																																																																																																																																																																																																																																																																																																																																																																																																																							  <a href="/rss/all">Recent Issues</a>
																																																																																																																																																																																																																																																																																																																																																																																																																																																																							    
																																																																																																																																																																																																																																																																																																																																																																																																																																																																							      |
																																																																																																																																																																																																																																																																																																																																																																																																																																																																							        <a href="/rss/mine/TomH">My Issues</a>
																																																																																																																																																																																																																																																																																																																																																																																																																																																																								  |
																																																																																																																																																																																																																																																																																																																																																																																																																																																																								    <a href="/rss/reviews/TomH">My Reviews</a>
																																																																																																																																																																																																																																																																																																																																																																																																																																																																								      |
																																																																																																																																																																																																																																																																																																																																																																																																																																																																								        <a href="/rss/closed/TomH">My Closed</a>
																																																																																																																																																																																																																																																																																																																																																																																																																																																																									  
																																																																																																																																																																																																																																																																																																																																																																																																																																																																									    
																																																																																																																																																																																																																																																																																																																																																																																																																																																																									      |
																																																																																																																																																																																																																																																																																																																																																																																																																																																																									        <a href="/rss/issue/4571045">This issue</a>
																																																																																																																																																																																																																																																																																																																																																																																																																																																																										   
																																																																																																																																																																																																																																																																																																																																																																																																																																																																										     </div>
																																																																																																																																																																																																																																																																																																																																																																																																																																																																										       <div style="margin-top: .3em;">This is Rietveld <a href="http://code.google.com/p/rietveld/updates/list">r756
																																																																																																																																																																																																																																																																																																																																																																																																																																																																										       </a></div>
																																																																																																																																																																																																																																																																																																																																																																																																																																																																										       </div>


																																																																																																																																																																																																																																																																																																																																																																																																																																																																										       <script type="text/javascript">
																																																																																																																																																																																																																																																																																																																																																																																																																																																																										       var gaJsHost = (("https:" == document.location.protocol) ? "https://ssl." : "http://www.");
																																																																																																																																																																																																																																																																																																																																																																																																																																																																										       document.write(unescape("%3Cscript src='" + gaJsHost + "google-analytics.com/ga.js' type='text/javascript'%3E%3C/script%3E"));
																																																																																																																																																																																																																																																																																																																																																																																																																																																																										       </script><script src="http://www.google-analytics.com/ga.js" type="text/javascript"></script>
																																																																																																																																																																																																																																																																																																																																																																																																																																																																										       <script type="text/javascript">
																																																																																																																																																																																																																																																																																																																																																																																																																																																																										       var pageTracker = _gat._getTracker("UA-4803694-4");
																																																																																																																																																																																																																																																																																																																																																																																																																																																																										       pageTracker._initData();
																																																																																																																																																																																																																																																																																																																																																																																																																																																																										       pageTracker._trackPageview();
																																																																																																																																																																																																																																																																																																																																																																																																																																																																										       </script>
On platforms that use Float (instead of Fixed), SkMatrix stores its internal
values as floats, but setConcat() needs extra precision and so uses doubles
to contain intermediate values.
These three benchmarks compare the speed of float-only, double-only, and
float-cast-to-double implementations of a chunk of code extracted from the
non-perspective case of setConcat().




git-svn-id: e8541e15acce502a64c929015570ad1648e548cd@1497 2bbb7eff-a529-9590-31e7-b0007b416f81

OptiPop/external_skia,GladeRom/android_external_skia,HalCanary/skia-hc,MarshedOut/android_external_skia,MarshedOut/android_external_skia,xzzz9097/android_external_skia,Samsung/skia,MIPS/external-chromium_org-third_party-skia,OneRom/external_skia,MonkeyZZZZ/platform_external_skia,timduru/platform-external-skia,CyanogenMod/android_external_chromium_org_third_party_skia,invisiblek/android_external_skia,akiss77/skia,YUPlayGodDev/platform_external_skia,byterom/android_external_skia,nox/skia,android-ia/platform_external_skia,xin3liang/platform_external_chromium_org_third_party_skia,AsteroidOS/android_external_skia,qrealka/skia-hc,OneRom/external_skia,MinimalOS/external_chromium_org_third_party_skia,MinimalOS/external_skia,pcwalton/skia,Samsung/skia,HealthyHoney/temasek_SKIA,Igalia/skia,scroggo/skia,google/skia,w3nd1go/android_external_skia,MinimalOS-AOSP/platform_external_skia,byterom/android_external_skia,PAC-ROM/android_external_skia,Infusion-OS/android_external_skia,BrokenROM/external_skia,byterom/android_external_skia,chenlian2015/skia_from_google,Jichao/skia,MinimalOS-AOSP/platform_external_skia,PAC-ROM/android_external_skia,shahrzadmn/skia,todotodoo/skia,AndroidOpenDevelopment/android_external_skia,houst0nn/external_skia,ench0/external_skia,temasek/android_external_skia,VentureROM-L/android_external_skia,VentureROM-L/android_external_skia,zhaochengw/platform_external_skia,MinimalOS/android_external_skia,MarshedOut/android_external_skia,TeamEOS/external_chromium_org_third_party_skia,aospo/platform_external_skia,nvoron23/skia,sigysmund/platform_external_skia,google/skia,ench0/external_chromium_org_third_party_skia,MyAOSP/external_chromium_org_third_party_skia,wildermason/external_skia,TeslaProject/external_skia,MyAOSP/external_chromium_org_third_party_skia,mozilla-b2g/external_skia,ench0/external_skia,vanish87/skia,AOSPA-L/android_external_skia,Samsung/skia,amyvmiwei/skia,w3nd1go/android_external_skia,CyanogenMod/android_external_chromium_org_third_party_skia,geekboxzone/lollipop_external_chromium_org_third_party_skia,GladeRom/android_external_skia,TeamExodus/external_skia,boulzordev/android_external_skia,SlimSaber/android_external_skia,TeamEOS/external_skia,HalCanary/skia-hc,mmatyas/skia,tmpvar/skia.cc,UBERMALLOW/external_skia,mozilla-b2g/external_skia,FusionSP/android_external_skia,Omegaphora/external_chromium_org_third_party_skia,Plain-Andy/android_platform_external_skia,boulzordev/android_external_skia,invisiblek/android_external_skia,pcwalton/skia,ench0/external_chromium_org_third_party_skia,OptiPop/external_skia,MinimalOS/external_chromium_org_third_party_skia,wildermason/external_skia,TeamExodus/external_skia,Samsung/skia,DiamondLovesYou/skia-sys,Hybrid-Rom/external_skia,suyouxin/android_external_skia,mydongistiny/android_external_skia,MinimalOS/external_chromium_org_third_party_skia,YUPlayGodDev/platform_external_skia,android-ia/platform_external_chromium_org_third_party_skia,TeslaOS/android_external_skia,AsteroidOS/android_external_skia,aosp-mirror/platform_external_skia,CyanogenMod/android_external_chromium_org_third_party_skia,wildermason/external_skia,MinimalOS/android_external_skia,Asteroid-Project/android_external_skia,Fusion-Rom/android_external_skia,MinimalOS/external_skia,codeaurora-unoffical/platform-external-skia,FusionSP/external_chromium_org_third_party_skia,google/skia,Igalia/skia,geekboxzone/lollipop_external_skia,HealthyHoney/temasek_SKIA,aosp-mirror/platform_external_skia,xin3liang/platform_external_chromium_org_third_party_skia,TeamEOS/external_skia,Infusion-OS/android_external_skia,TeamTwisted/external_skia,AOSPA-L/android_external_skia,MinimalOS/external_chromium_org_third_party_skia,AOSPU/external_chromium_org_third_party_skia,suyouxin/android_external_skia,AsteroidOS/android_external_skia,Hybrid-Rom/external_skia,wildermason/external_skia,TeamBliss-LP/android_external_skia,MyAOSP/external_chromium_org_third_party_skia,geekboxzone/lollipop_external_skia,suyouxin/android_external_skia,Plain-Andy/android_platform_external_skia,invisiblek/android_external_skia,VRToxin-AOSP/android_external_skia,RadonX-ROM/external_skia,akiss77/skia,HalCanary/skia-hc,android-ia/platform_external_chromium_org_third_party_skia,google/skia,AOSP-YU/platform_external_skia,ench0/external_skia,nfxosp/platform_external_skia,scroggo/skia,VentureROM-L/android_external_skia,chenlian2015/skia_from_google,TeslaOS/android_external_skia,fire855/android_external_skia,Omegaphora/external_skia,ominux/skia,temasek/android_external_skia,todotodoo/skia,RadonX-ROM/external_skia,houst0nn/external_skia,SlimSaber/android_external_skia,todotodoo/skia,nfxosp/platform_external_skia,w3nd1go/android_external_skia,qrealka/skia-hc,NamelessRom/android_external_skia,Omegaphora/external_chromium_org_third_party_skia,CyanogenMod/android_external_chromium_org_third_party_skia,ctiao/platform-external-skia,TeamEOS/external_chromium_org_third_party_skia,amyvmiwei/skia,noselhq/skia,vanish87/skia,MinimalOS/external_chromium_org_third_party_skia,nox/skia,todotodoo/skia,sombree/android_external_skia,FusionSP/android_external_skia,Infinitive-OS/platform_external_skia,mydongistiny/android_external_skia,F-AOSP/platform_external_skia,MarshedOut/android_external_skia,SlimSaber/android_external_skia,OptiPop/external_chromium_org_third_party_skia,MinimalOS/android_external_skia,Omegaphora/external_skia,MonkeyZZZZ/platform_external_skia,houst0nn/external_skia,VRToxin-AOSP/android_external_skia,TeslaOS/android_external_skia,DiamondLovesYou/skia-sys,OptiPop/external_skia,todotodoo/skia,TeamEOS/external_skia,aosp-mirror/platform_external_skia,jtg-gg/skia,TeslaProject/external_skia,OneRom/external_skia,RadonX-ROM/external_skia,codeaurora-unoffical/platform-external-skia,Purity-Lollipop/platform_external_skia,Infinitive-OS/platform_external_skia,SlimSaber/android_external_skia,akiss77/skia,HalCanary/skia-hc,HealthyHoney/temasek_SKIA,nox/skia,akiss77/skia,MyAOSP/external_chromium_org_third_party_skia,Igalia/skia,VRToxin-AOSP/android_external_skia,TeamBliss-LP/android_external_skia,OptiPop/external_chromium_org_third_party_skia,pcwalton/skia,DARKPOP/external_chromium_org_third_party_skia,rubenvb/skia,InfinitiveOS/external_skia,OptiPop/external_chromium_org_third_party_skia,Android-AOSP/external_skia,boulzordev/android_external_skia,sigysmund/platform_external_skia,TeslaOS/android_external_skia,mydongistiny/external_chromium_org_third_party_skia,Euphoria-OS-Legacy/android_external_skia,timduru/platform-external-skia,mmatyas/skia,android-ia/platform_external_skia,Euphoria-OS-Legacy/android_external_skia,nox/skia,Tesla-Redux/android_external_skia,spezi77/android_external_skia,TeamExodus/external_skia,vvuk/skia,OptiPop/external_skia,nvoron23/skia,Jichao/skia,MIPS/external-chromium_org-third_party-skia,suyouxin/android_external_skia,F-AOSP/platform_external_skia,android-ia/platform_external_skia,w3nd1go/android_external_skia,shahrzadmn/skia,OptiPop/external_skia,pcwalton/skia,BrokenROM/external_skia,MinimalOS-AOSP/platform_external_skia,tmpvar/skia.cc,noselhq/skia,Jichao/skia,ench0/external_chromium_org_third_party_skia,geekboxzone/lollipop_external_skia,noselhq/skia,CyanogenMod/android_external_chromium_org_third_party_skia,TeamTwisted/external_skia,AOSPU/external_chromium_org_third_party_skia,geekboxzone/lollipop_external_chromium_org_third_party_skia,YUPlayGodDev/platform_external_skia,spezi77/android_external_skia,MinimalOS/external_skia,xzzz9097/android_external_skia,zhaochengw/platform_external_skia,BrokenROM/external_skia,sudosurootdev/external_skia,MIPS/external-chromium_org-third_party-skia,jtg-gg/skia,noselhq/skia,wildermason/external_skia,UBERMALLOW/external_skia,Fusion-Rom/android_external_skia,Android-AOSP/external_skia,tmpvar/skia.cc,zhaochengw/platform_external_skia,UBERMALLOW/external_skia,AOSP-YU/platform_external_skia,larsbergstrom/skia,scroggo/skia,Tesla-Redux/android_external_skia,mozilla-b2g/external_skia,AndroidOpenDevelopment/android_external_skia,MinimalOS/android_external_chromium_org_third_party_skia,larsbergstrom/skia,zhaochengw/platform_external_skia,scroggo/skia,InfinitiveOS/external_skia,spezi77/android_external_skia,Fusion-Rom/android_external_skia,tmpvar/skia.cc,todotodoo/skia,FusionSP/external_chromium_org_third_party_skia,byterom/android_external_skia,nvoron23/skia,AndroidOpenDevelopment/android_external_skia,Omegaphora/external_skia,MinimalOS-AOSP/platform_external_skia,nox/skia,sombree/android_external_skia,YUPlayGodDev/platform_external_skia,qrealka/skia-hc,ctiao/platform-external-skia,UBERMALLOW/external_skia,Pure-Aosp/android_external_skia,sombree/android_external_skia,Plain-Andy/android_platform_external_skia,w3nd1go/android_external_skia,MinimalOS-AOSP/platform_external_skia,rubenvb/skia,AOSPA-L/android_external_skia,TeamEOS/external_skia,Khaon/android_external_skia,vanish87/skia,MinimalOS/external_skia,houst0nn/external_skia,Tesla-Redux/android_external_skia,aosp-mirror/platform_external_skia,nox/skia,vanish87/skia,OptiPop/external_chromium_org_third_party_skia,xin3liang/platform_external_chromium_org_third_party_skia,geekboxzone/mmallow_external_skia,w3nd1go/android_external_skia,YUPlayGodDev/platform_external_skia,TeamEOS/external_chromium_org_third_party_skia,byterom/android_external_skia,Hybrid-Rom/external_skia,MonkeyZZZZ/platform_external_skia,noselhq/skia,android-ia/platform_external_skia,pcwalton/skia,nfxosp/platform_external_skia,ench0/external_chromium_org_third_party_skia,AOSPB/external_skia,mydongistiny/external_chromium_org_third_party_skia,Fusion-Rom/external_chromium_org_third_party_skia,byterom/android_external_skia,zhaochengw/platform_external_skia,VRToxin-AOSP/android_external_skia,zhaochengw/platform_external_skia,android-ia/platform_external_skia,w3nd1go/android_external_skia,amyvmiwei/skia,xzzz9097/android_external_skia,OptiPop/external_chromium_org_third_party_skia,DARKPOP/external_chromium_org_third_party_skia,ench0/external_chromium_org_third_party_skia,TeamTwisted/external_skia,invisiblek/android_external_skia,NamelessRom/android_external_skia,DiamondLovesYou/skia-sys,FusionSP/android_external_skia,nvoron23/skia,MyAOSP/external_chromium_org_third_party_skia,samuelig/skia,AOSPA-L/android_external_skia,AOSPB/external_skia,HalCanary/skia-hc,mydongistiny/external_chromium_org_third_party_skia,AOSPB/external_skia,InfinitiveOS/external_skia,FusionSP/external_chromium_org_third_party_skia,TeslaProject/external_skia,TeamBliss-LP/android_external_skia,AOSPU/external_chromium_org_third_party_skia,nfxosp/platform_external_skia,Igalia/skia,vanish87/skia,MinimalOS/external_skia,fire855/android_external_skia,aospo/platform_external_skia,nvoron23/skia,AOSPB/external_skia,HealthyHoney/temasek_SKIA,AOSPA-L/android_external_skia,Purity-Lollipop/platform_external_skia,sigysmund/platform_external_skia,android-ia/platform_external_chromium_org_third_party_skia,AOSP-YU/platform_external_skia,mydongistiny/android_external_skia,Omegaphora/external_chromium_org_third_party_skia,mozilla-b2g/external_skia,sombree/android_external_skia,Fusion-Rom/external_chromium_org_third_party_skia,temasek/android_external_skia,shahrzadmn/skia,mmatyas/skia,codeaurora-unoffical/platform-external-skia,geekboxzone/mmallow_external_skia,OptiPop/external_skia,mmatyas/skia,MyAOSP/external_chromium_org_third_party_skia,Pure-Aosp/android_external_skia,BrokenROM/external_skia,suyouxin/android_external_skia,ominux/skia,GladeRom/android_external_skia,Euphoria-OS-Legacy/android_external_skia,scroggo/skia,mydongistiny/android_external_skia,Euphoria-OS-Legacy/android_external_skia,akiss77/skia,tmpvar/skia.cc,geekboxzone/mmallow_external_skia,Omegaphora/external_chromium_org_third_party_skia,sombree/android_external_skia,shahrzadmn/skia,SlimSaber/android_external_skia,HalCanary/skia-hc,geekboxzone/mmallow_external_skia,MinimalOS/external_skia,OptiPop/external_skia,CyanogenMod/android_external_chromium_org_third_party_skia,TeamEOS/external_chromium_org_third_party_skia,vvuk/skia,akiss77/skia,Plain-Andy/android_platform_external_skia,aosp-mirror/platform_external_skia,sudosurootdev/external_skia,rubenvb/skia,larsbergstrom/skia,Fusion-Rom/external_chromium_org_third_party_skia,UBERMALLOW/external_skia,TeamTwisted/external_skia,Khaon/android_external_skia,android-ia/platform_external_chromium_org_third_party_skia,Igalia/skia,Pure-Aosp/android_external_skia,AOSP-YU/platform_external_skia,mydongistiny/android_external_skia,TeamEOS/external_chromium_org_third_party_skia,MinimalOS/android_external_skia,Asteroid-Project/android_external_skia,GladeRom/android_external_skia,Omegaphora/external_skia,nvoron23/skia,ench0/external_chromium_org_third_party_skia,rubenvb/skia,ominux/skia,zhaochengw/platform_external_skia,MinimalOS/external_chromium_org_third_party_skia,chenlian2015/skia_from_google,FusionSP/android_external_skia,InfinitiveOS/external_skia,nox/skia,MonkeyZZZZ/platform_external_skia,tmpvar/skia.cc,ctiao/platform-external-skia,MinimalOS/android_external_chromium_org_third_party_skia,amyvmiwei/skia,VRToxin-AOSP/android_external_skia,amyvmiwei/skia,VRToxin-AOSP/android_external_skia,larsbergstrom/skia,google/skia,DARKPOP/external_chromium_org_third_party_skia,codeaurora-unoffical/platform-external-skia,Infusion-OS/android_external_skia,google/skia,android-ia/platform_external_chromium_org_third_party_skia,MIPS/external-chromium_org-third_party-skia,MarshedOut/android_external_skia,nox/skia,qrealka/skia-hc,MinimalOS/external_skia,noselhq/skia,FusionSP/android_external_skia,DesolationStaging/android_external_skia,HealthyHoney/temasek_SKIA,spezi77/android_external_skia,invisiblek/android_external_skia,OptiPop/external_chromium_org_third_party_skia,aospo/platform_external_skia,Jichao/skia,MIPS/external-chromium_org-third_party-skia,Android-AOSP/external_skia,larsbergstrom/skia,chenlian2015/skia_from_google,MonkeyZZZZ/platform_external_skia,ench0/external_skia,amyvmiwei/skia,android-ia/platform_external_skia,VRToxin-AOSP/android_external_skia,AOSPB/external_skia,Samsung/skia,Infinitive-OS/platform_external_skia,MyAOSP/external_chromium_org_third_party_skia,houst0nn/external_skia,Fusion-Rom/android_external_skia,TeslaOS/android_external_skia,F-AOSP/platform_external_skia,shahrzadmn/skia,Igalia/skia,vvuk/skia,Hikari-no-Tenshi/android_external_skia,OptiPop/external_chromium_org_third_party_skia,Hikari-no-Tenshi/android_external_skia,Khaon/android_external_skia,amyvmiwei/skia,MinimalOS/android_external_chromium_org_third_party_skia,xzzz9097/android_external_skia,Infinitive-OS/platform_external_skia,aosp-mirror/platform_external_skia,larsbergstrom/skia,AsteroidOS/android_external_skia,mmatyas/skia,BrokenROM/external_skia,Samsung/skia,RadonX-ROM/external_skia,mydongistiny/android_external_skia,RadonX-ROM/external_skia,invisiblek/android_external_skia,Euphoria-OS-Legacy/android_external_skia,samuelig/skia,PAC-ROM/android_external_skia,boulzordev/android_external_skia,pacerom/external_skia,MinimalOS/external_chromium_org_third_party_skia,TeamExodus/external_skia,TeslaProject/external_skia,AsteroidOS/android_external_skia,mydongistiny/external_chromium_org_third_party_skia,rubenvb/skia,YUPlayGodDev/platform_external_skia,android-ia/platform_external_chromium_org_third_party_skia,Fusion-Rom/android_external_skia,mmatyas/skia,pcwalton/skia,MIPS/external-chromium_org-third_party-skia,xin3liang/platform_external_chromium_org_third_party_skia,TeamTwisted/external_skia,HalCanary/skia-hc,MinimalOS/android_external_skia,nvoron23/skia,ctiao/platform-external-skia,PAC-ROM/android_external_skia,vvuk/skia,ominux/skia,aospo/platform_external_skia,OptiPop/external_skia,Hikari-no-Tenshi/android_external_skia,Fusion-Rom/external_chromium_org_third_party_skia,NamelessRom/android_external_skia,houst0nn/external_skia,TeamExodus/external_skia,geekboxzone/lollipop_external_skia,ominux/skia,Hikari-no-Tenshi/android_external_skia,wildermason/external_skia,MinimalOS/android_external_chromium_org_third_party_skia,Samsung/skia,HealthyHoney/temasek_SKIA,google/skia,AOSPB/external_skia,F-AOSP/platform_external_skia,TeamBliss-LP/android_external_skia,MonkeyZZZZ/platform_external_skia,byterom/android_external_skia,Khaon/android_external_skia,HealthyHoney/temasek_SKIA,w3nd1go/android_external_skia,qrealka/skia-hc,TeamTwisted/external_skia,DARKPOP/external_chromium_org_third_party_skia,GladeRom/android_external_skia,mmatyas/skia,fire855/android_external_skia,vanish87/skia,vanish87/skia,AsteroidOS/android_external_skia,qrealka/skia-hc,noselhq/skia,HalCanary/skia-hc,Plain-Andy/android_platform_external_skia,aospo/platform_external_skia,AOSP-YU/platform_external_skia,fire855/android_external_skia,ctiao/platform-external-skia,InfinitiveOS/external_skia,Android-AOSP/external_skia,nvoron23/skia,jtg-gg/skia,fire855/android_external_skia,Omegaphora/external_chromium_org_third_party_skia,ench0/external_skia,HalCanary/skia-hc,MinimalOS-AOSP/platform_external_skia,MarshedOut/android_external_skia,pcwalton/skia,DiamondLovesYou/skia-sys,larsbergstrom/skia,Igalia/skia,AOSP-YU/platform_external_skia,TeslaOS/android_external_skia,OneRom/external_skia,Infinitive-OS/platform_external_skia,xin3liang/platform_external_chromium_org_third_party_skia,AsteroidOS/android_external_skia,nfxosp/platform_external_skia,GladeRom/android_external_skia,TeslaProject/external_skia,PAC-ROM/android_external_skia,FusionSP/external_chromium_org_third_party_skia,NamelessRom/android_external_skia,wildermason/external_skia,Purity-Lollipop/platform_external_skia,Asteroid-Project/android_external_skia,invisiblek/android_external_skia,boulzordev/android_external_skia,TeslaProject/external_skia,MonkeyZZZZ/platform_external_skia,larsbergstrom/skia,vvuk/skia,aosp-mirror/platform_external_skia,FusionSP/external_chromium_org_third_party_skia,Purity-Lollipop/platform_external_skia,Infusion-OS/android_external_skia,InfinitiveOS/external_skia,Hikari-no-Tenshi/android_external_skia,HalCanary/skia-hc,VRToxin-AOSP/android_external_skia,ominux/skia,Tesla-Redux/android_external_skia,Pure-Aosp/android_external_skia,Infusion-OS/android_external_skia,fire855/android_external_skia,TeamTwisted/external_skia,pcwalton/skia,TeamEOS/external_chromium_org_third_party_skia,geekboxzone/lollipop_external_chromium_org_third_party_skia,temasek/android_external_skia,tmpvar/skia.cc,geekboxzone/lollipop_external_chromium_org_third_party_skia,todotodoo/skia,akiss77/skia,Khaon/android_external_skia,android-ia/platform_external_chromium_org_third_party_skia,sudosurootdev/external_skia,HealthyHoney/temasek_SKIA,Android-AOSP/external_skia,Plain-Andy/android_platform_external_skia,Fusion-Rom/external_chromium_org_third_party_skia,codeaurora-unoffical/platform-external-skia,fire855/android_external_skia,SlimSaber/android_external_skia,geekboxzone/mmallow_external_skia,MinimalOS/external_skia,AndroidOpenDevelopment/android_external_skia,shahrzadmn/skia,Infinitive-OS/platform_external_skia,vvuk/skia,pacerom/external_skia,byterom/android_external_skia,OptiPop/external_chromium_org_third_party_skia,sigysmund/platform_external_skia,samuelig/skia,FusionSP/external_chromium_org_third_party_skia,amyvmiwei/skia,YUPlayGodDev/platform_external_skia,OneRom/external_skia,ench0/external_skia,ench0/external_skia,DARKPOP/external_chromium_org_third_party_skia,DesolationStaging/android_external_skia,VentureROM-L/android_external_skia,Jichao/skia,qrealka/skia-hc,vvuk/skia,TeslaOS/android_external_skia,Infusion-OS/android_external_skia,Pure-Aosp/android_external_skia,fire855/android_external_skia,timduru/platform-external-skia,Infusion-OS/android_external_skia,TeslaOS/android_external_skia,sudosurootdev/external_skia,AOSPB/external_skia,OneRom/external_skia,DesolationStaging/android_external_skia,android-ia/platform_external_skia,Omegaphora/external_chromium_org_third_party_skia,vanish87/skia,mmatyas/skia,shahrzadmn/skia,codeaurora-unoffical/platform-external-skia,pcwalton/skia,nfxosp/platform_external_skia,suyouxin/android_external_skia,samuelig/skia,xin3liang/platform_external_chromium_org_third_party_skia,ctiao/platform-external-skia,Omegaphora/external_chromium_org_third_party_skia,AOSP-YU/platform_external_skia,SlimSaber/android_external_skia,DesolationStaging/android_external_skia,DARKPOP/external_chromium_org_third_party_skia,Infinitive-OS/platform_external_skia,ench0/external_chromium_org_third_party_skia,akiss77/skia,geekboxzone/mmallow_external_skia,InfinitiveOS/external_skia,VentureROM-L/android_external_skia,tmpvar/skia.cc,samuelig/skia,vvuk/skia,MinimalOS/android_external_chromium_org_third_party_skia,MinimalOS/android_external_skia,Tesla-Redux/android_external_skia,shahrzadmn/skia,Omegaphora/external_chromium_org_third_party_skia,TeamExodus/external_skia,DesolationStaging/android_external_skia,Khaon/android_external_skia,Pure-Aosp/android_external_skia,geekboxzone/lollipop_external_chromium_org_third_party_skia,AOSPU/external_chromium_org_third_party_skia,Asteroid-Project/android_external_skia,nfxosp/platform_external_skia,jtg-gg/skia,larsbergstrom/skia,BrokenROM/external_skia,vvuk/skia,OneRom/external_skia,spezi77/android_external_skia,qrealka/skia-hc,todotodoo/skia,boulzordev/android_external_skia,jtg-gg/skia,MinimalOS/android_external_skia,Plain-Andy/android_platform_external_skia,Hikari-no-Tenshi/android_external_skia,MarshedOut/android_external_skia,ominux/skia,PAC-ROM/android_external_skia,AOSPB/external_skia,mozilla-b2g/external_skia,pacerom/external_skia,chenlian2015/skia_from_google,Infinitive-OS/platform_external_skia,FusionSP/android_external_skia,RadonX-ROM/external_skia,sudosurootdev/external_skia,TeamExodus/external_skia,aosp-mirror/platform_external_skia,aosp-mirror/platform_external_skia,xzzz9097/android_external_skia,PAC-ROM/android_external_skia,sombree/android_external_skia,timduru/platform-external-skia,rubenvb/skia,TeamTwisted/external_skia,jtg-gg/skia,YUPlayGodDev/platform_external_skia,NamelessRom/android_external_skia,codeaurora-unoffical/platform-external-skia,OneRom/external_skia,Omegaphora/external_skia,geekboxzone/mmallow_external_skia,DiamondLovesYou/skia-sys,Hikari-no-Tenshi/android_external_skia,sigysmund/platform_external_skia,mydongistiny/external_chromium_org_third_party_skia,codeaurora-unoffical/platform-external-skia,sudosurootdev/external_skia,PAC-ROM/android_external_skia,geekboxzone/lollipop_external_chromium_org_third_party_skia,nvoron23/skia,Purity-Lollipop/platform_external_skia,Purity-Lollipop/platform_external_skia,Asteroid-Project/android_external_skia,geekboxzone/mmallow_external_skia,rubenvb/skia,AOSP-YU/platform_external_skia,Omegaphora/external_skia,Euphoria-OS-Legacy/android_external_skia,mozilla-b2g/external_skia,geekboxzone/mmallow_external_skia,Android-AOSP/external_skia,google/skia,xin3liang/platform_external_chromium_org_third_party_skia,MinimalOS/android_external_chromium_org_third_party_skia,RadonX-ROM/external_skia,samuelig/skia,Fusion-Rom/android_external_skia,Hybrid-Rom/external_skia,TeamBliss-LP/android_external_skia,GladeRom/android_external_skia,SlimSaber/android_external_skia,MinimalOS-AOSP/platform_external_skia,sudosurootdev/external_skia,NamelessRom/android_external_skia,Khaon/android_external_skia,vanish87/skia,google/skia,Fusion-Rom/android_external_skia,Fusion-Rom/external_chromium_org_third_party_skia,geekboxzone/lollipop_external_chromium_org_third_party_skia,todotodoo/skia,sigysmund/platform_external_skia,boulzordev/android_external_skia,Fusion-Rom/external_chromium_org_third_party_skia,DARKPOP/external_chromium_org_third_party_skia,geekboxzone/lollipop_external_skia,mozilla-b2g/external_skia,Tesla-Redux/android_external_skia,Tesla-Redux/android_external_skia,chenlian2015/skia_from_google,sigysmund/platform_external_skia,Hikari-no-Tenshi/android_external_skia,TeamEOS/external_skia,nox/skia,Asteroid-Project/android_external_skia,samuelig/skia,sombree/android_external_skia,sudosurootdev/external_skia,xzzz9097/android_external_skia,MinimalOS/android_external_chromium_org_third_party_skia,AndroidOpenDevelopment/android_external_skia,TeamTwisted/external_skia,MinimalOS/android_external_skia,Fusion-Rom/external_chromium_org_third_party_skia,aospo/platform_external_skia,TeslaProject/external_skia,Purity-Lollipop/platform_external_skia,mydongistiny/android_external_skia,android-ia/platform_external_chromium_org_third_party_skia,wildermason/external_skia,mydongistiny/android_external_skia,VRToxin-AOSP/android_external_skia,Khaon/android_external_skia,TeamBliss-LP/android_external_skia,ench0/external_chromium_org_third_party_skia,Igalia/skia,YUPlayGodDev/platform_external_skia,DesolationStaging/android_external_skia,ench0/external_skia,MarshedOut/android_external_skia,Euphoria-OS-Legacy/android_external_skia,MinimalOS/android_external_chromium_org_third_party_skia,nfxosp/platform_external_skia,VentureROM-L/android_external_skia,pacerom/external_skia,temasek/android_external_skia,android-ia/platform_external_skia,AOSPB/external_skia,F-AOSP/platform_external_skia,RadonX-ROM/external_skia,aosp-mirror/platform_external_skia,rubenvb/skia,MinimalOS-AOSP/platform_external_skia,MonkeyZZZZ/platform_external_skia,DiamondLovesYou/skia-sys,F-AOSP/platform_external_skia,geekboxzone/lollipop_external_skia,CyanogenMod/android_external_chromium_org_third_party_skia,OneRom/external_skia,spezi77/android_external_skia,jtg-gg/skia,mydongistiny/external_chromium_org_third_party_skia,boulzordev/android_external_skia,Fusion-Rom/android_external_skia,UBERMALLOW/external_skia,FusionSP/external_chromium_org_third_party_skia,BrokenROM/external_skia,Android-AOSP/external_skia,Jichao/skia,AOSPA-L/android_external_skia,F-AOSP/platform_external_skia,temasek/android_external_skia,MonkeyZZZZ/platform_external_skia,scroggo/skia,DARKPOP/external_chromium_org_third_party_skia,xzzz9097/android_external_skia,MinimalOS/external_chromium_org_third_party_skia,TeamBliss-LP/android_external_skia,BrokenROM/external_skia,temasek/android_external_skia,Hybrid-Rom/external_skia,UBERMALLOW/external_skia,TeamExodus/external_skia,Tesla-Redux/android_external_skia,TeamExodus/external_skia,FusionSP/android_external_skia,DesolationStaging/android_external_skia,pacerom/external_skia,pacerom/external_skia,MinimalOS-AOSP/platform_external_skia,NamelessRom/android_external_skia,nfxosp/platform_external_skia,temasek/android_external_skia,noselhq/skia,mozilla-b2g/external_skia,aospo/platform_external_skia,AOSP-YU/platform_external_skia,DesolationStaging/android_external_skia,NamelessRom/android_external_skia,sigysmund/platform_external_skia,geekboxzone/lollipop_external_skia,MIPS/external-chromium_org-third_party-skia,houst0nn/external_skia,zhaochengw/platform_external_skia,scroggo/skia,suyouxin/android_external_skia,akiss77/skia,Purity-Lollipop/platform_external_skia,TeamEOS/external_skia,Asteroid-Project/android_external_skia,w3nd1go/android_external_skia,Infusion-OS/android_external_skia,TeslaProject/external_skia,UBERMALLOW/external_skia,timduru/platform-external-skia,Samsung/skia,Omegaphora/external_skia,noselhq/skia,shahrzadmn/skia,pacerom/external_skia,MIPS/external-chromium_org-third_party-skia,TeamEOS/external_chromium_org_third_party_skia,timduru/platform-external-skia,AOSPU/external_chromium_org_third_party_skia,InfinitiveOS/external_skia,Pure-Aosp/android_external_skia,AndroidOpenDevelopment/android_external_skia,geekboxzone/lollipop_external_chromium_org_third_party_skia,ominux/skia,AOSPU/external_chromium_org_third_party_skia,DiamondLovesYou/skia-sys,F-AOSP/platform_external_skia,FusionSP/external_chromium_org_third_party_skia,geekboxzone/lollipop_external_skia,chenlian2015/skia_from_google,tmpvar/skia.cc,AOSPA-L/android_external_skia,mydongistiny/external_chromium_org_third_party_skia,sombree/android_external_skia,MyAOSP/external_chromium_org_third_party_skia,VentureROM-L/android_external_skia,TeamEOS/external_skia,samuelig/skia,Euphoria-OS-Legacy/android_external_skia,Hybrid-Rom/external_skia,mmatyas/skia,Pure-Aosp/android_external_skia,Jichao/skia,ominux/skia,google/skia,Jichao/skia,Hybrid-Rom/external_skia,aospo/platform_external_skia,AOSPU/external_chromium_org_third_party_skia,scroggo/skia,ctiao/platform-external-skia,GladeRom/android_external_skia,VentureROM-L/android_external_skia,UBERMALLOW/external_skia,AOSPA-L/android_external_skia,Hybrid-Rom/external_skia,rubenvb/skia,MarshedOut/android_external_skia,Omegaphora/external_skia,timduru/platform-external-skia,xzzz9097/android_external_skia,Asteroid-Project/android_external_skia,boulzordev/android_external_skia,AndroidOpenDevelopment/android_external_skia,rubenvb/skia,AsteroidOS/android_external_skia,TeamEOS/external_chromium_org_third_party_skia,Jichao/skia,invisiblek/android_external_skia,mydongistiny/external_chromium_org_third_party_skia,Infinitive-OS/platform_external_skia,PAC-ROM/android_external_skia