[globalopt] Remove a local ToRemove vector that is never appended to.
[globalopt] Remove a local ToRemove vector that is never appended to.

This didn't trigger any unused variable warnings since we always try to clean up
the contents in the ToRemove vector. Of course since the ToRemove vector is
never actually appended to, nothing ever happens there.

The other aspect of this is whether or not we actually need a ToRemove vector. I
read the code in this section and it is not necessary since the section of
GlobalOpt is only collecting information about the function we are
processing. Later after function iteration is over, we later process the data
that we filled our caches with. So no iterator invalidation can happen.

gregomni/swift,airspeedswift/swift,devincoughlin/swift,brentdax/swift,rudkx/swift,amraboelela/swift,hooman/swift,devincoughlin/swift,tjw/swift,allevato/swift,gribozavr/swift,nathawes/swift,xedin/swift,roambotics/swift,roambotics/swift,roambotics/swift,devincoughlin/swift,natecook1000/swift,jopamer/swift,xwu/swift,huonw/swift,danielmartin/swift,JGiola/swift,shahmishal/swift,glessard/swift,gribozavr/swift,xedin/swift,CodaFi/swift,hooman/swift,huonw/swift,nathawes/swift,lorentey/swift,tkremenek/swift,apple/swift,practicalswift/swift,shajrawi/swift,lorentey/swift,jckarter/swift,tjw/swift,JGiola/swift,jckarter/swift,alblue/swift,CodaFi/swift,xwu/swift,benlangmuir/swift,karwa/swift,jopamer/swift,sschiau/swift,practicalswift/swift,gregomni/swift,brentdax/swift,jmgc/swift,shajrawi/swift,xedin/swift,parkera/swift,natecook1000/swift,allevato/swift,rudkx/swift,gregomni/swift,karwa/swift,shajrawi/swift,xwu/swift,amraboelela/swift,shahmishal/swift,shajrawi/swift,airspeedswift/swift,benlangmuir/swift,hooman/swift,tkremenek/swift,practicalswift/swift,benlangmuir/swift,jmgc/swift,jmgc/swift,devincoughlin/swift,tkremenek/swift,jckarter/swift,rudkx/swift,brentdax/swift,karwa/swift,alblue/swift,huonw/swift,gribozavr/swift,gregomni/swift,brentdax/swift,nathawes/swift,CodaFi/swift,brentdax/swift,sschiau/swift,devincoughlin/swift,parkera/swift,austinzheng/swift,stephentyrone/swift,rudkx/swift,atrick/swift,JGiola/swift,atrick/swift,stephentyrone/swift,gribozavr/swift,airspeedswift/swift,natecook1000/swift,nathawes/swift,tkremenek/swift,atrick/swift,danielmartin/swift,shahmishal/swift,atrick/swift,amraboelela/swift,parkera/swift,shahmishal/swift,parkera/swift,gregomni/swift,shahmishal/swift,gribozavr/swift,karwa/swift,jckarter/swift,nathawes/swift,apple/swift,amraboelela/swift,stephentyrone/swift,alblue/swift,karwa/swift,xwu/swift,harlanhaskins/swift,parkera/swift,parkera/swift,harlanhaskins/swift,stephentyrone/swift,hooman/swift,glessard/swift,alblue/swift,austinzheng/swift,benlangmuir/swift,natecook1000/swift,aschwaighofer/swift,xedin/swift,airspeedswift/swift,apple/swift,tjw/swift,practicalswift/swift,tjw/swift,nathawes/swift,amraboelela/swift,tjw/swift,aschwaighofer/swift,jmgc/swift,lorentey/swift,glessard/swift,austinzheng/swift,lorentey/swift,practicalswift/swift,glessard/swift,parkera/swift,ahoppen/swift,xwu/swift,sschiau/swift,CodaFi/swift,rudkx/swift,austinzheng/swift,hooman/swift,brentdax/swift,JGiola/swift,practicalswift/swift,xedin/swift,tjw/swift,natecook1000/swift,jmgc/swift,jopamer/swift,natecook1000/swift,parkera/swift,apple/swift,aschwaighofer/swift,jmgc/swift,ahoppen/swift,JGiola/swift,harlanhaskins/swift,glessard/swift,gribozavr/swift,aschwaighofer/swift,shahmishal/swift,allevato/swift,benlangmuir/swift,sschiau/swift,jopamer/swift,huonw/swift,aschwaighofer/swift,allevato/swift,lorentey/swift,airspeedswift/swift,CodaFi/swift,atrick/swift,xedin/swift,apple/swift,tkremenek/swift,karwa/swift,jmgc/swift,danielmartin/swift,danielmartin/swift,gribozavr/swift,devincoughlin/swift,huonw/swift,hooman/swift,gribozavr/swift,practicalswift/swift,shajrawi/swift,allevato/swift,lorentey/swift,aschwaighofer/swift,sschiau/swift,tkremenek/swift,huonw/swift,jckarter/swift,nathawes/swift,ahoppen/swift,xedin/swift,danielmartin/swift,jckarter/swift,roambotics/swift,xwu/swift,sschiau/swift,roambotics/swift,jopamer/swift,karwa/swift,devincoughlin/swift,harlanhaskins/swift,ahoppen/swift,alblue/swift,aschwaighofer/swift,shahmishal/swift,austinzheng/swift,xedin/swift,harlanhaskins/swift,stephentyrone/swift,alblue/swift,danielmartin/swift,natecook1000/swift,airspeedswift/swift,benlangmuir/swift,glessard/swift,amraboelela/swift,austinzheng/swift,stephentyrone/swift,karwa/swift,roambotics/swift,lorentey/swift,alblue/swift,huonw/swift,jopamer/swift,airspeedswift/swift,ahoppen/swift,brentdax/swift,devincoughlin/swift,lorentey/swift,stephentyrone/swift,ahoppen/swift,rudkx/swift,shajrawi/swift,austinzheng/swift,allevato/swift,apple/swift,amraboelela/swift,sschiau/swift,CodaFi/swift,shajrawi/swift,CodaFi/swift,tjw/swift,practicalswift/swift,jckarter/swift,allevato/swift,sschiau/swift,JGiola/swift,harlanhaskins/swift,danielmartin/swift,gregomni/swift,hooman/swift,shahmishal/swift,xwu/swift,jopamer/swift,tkremenek/swift,atrick/swift,harlanhaskins/swift,shajrawi/swift