Improvement fbvector.computePushBackCapacity
Improvement fbvector.computePushBackCapacity

Summary:
See the github pull request at https://github.com/facebook/folly/issues/135

Important optimizations: remove one of the branches and change ##empty()## to ##capacity()==0##

Test Plan:
Ran extended fbvector test suite (re-enabled in experimental/njormrod)

Also

fbconfig -r folly && fbmake runtests

Reviewed By: markisaa@fb.com

Subscribers: trunkagent, sdwilsh, njormrod, folly-diffs@, yfeldblum

FB internal diff: D1869112

Tasks: 6338531

Signature: t1:1869112:1424823901:d2d7331aef82edad1e8c159005cc1c7185550d0c

bowlofstew/folly,clearlinux/folly,wildinto/folly,sonnyhu/folly,nickhen/folly,zhiweicai/folly,doctaweeks/folly,cole14/folly,arg0/folly,sakishum/folly,hongliangzhao/folly,gaoyingie/folly,SammyK/folly,PPC64/folly,PPC64/folly,loverszhaokai/folly,CJstar/folly,loversInJapan/folly,bsampath/folly,chjp2046/folly,PoisonBOx/folly,brunomorishita/folly,gavioto/folly,zhiweicai/folly,raphaelamorim/folly,SeanRBurton/folly,doctaweeks/folly,bsampath/folly,hongliangzhao/folly,gavioto/folly,tomhughes/folly,alexst07/folly,tempbottle/folly,romange/folly,charsyam/folly,upsoft/folly,raphaelamorim/folly,shaobz/folly,Eagle-X/folly,brunomorishita/folly,hongliangzhao/folly,kernelim/folly,mqeizi/folly,loversInJapan/folly,nickhen/folly,Eagle-X/folly,yangjin-unique/folly,mqeizi/folly,reddit/folly,ykarlsbrun/folly,bsampath/folly,lifei/folly,tomhughes/folly,PPC64/folly,bobegir/folly,floxard/folly,facebook/folly,shaobz/folly,Hincoin/folly,SeanRBurton/folly,bobegir/folly,rklabs/folly,SeanRBurton/folly,stonegithubs/folly,mqeizi/folly,Eagle-X/folly,gaoyingie/folly,SeanRBurton/folly,theiver9827/folly,Hincoin/folly,kernelim/folly,clearlylin/folly,leolujuyi/folly,floxard/folly,gavioto/folly,cole14/folly,chjp2046/folly,mqeizi/folly,constantine001/folly,PoisonBOx/folly,project-zerus/folly,clearlinux/folly,wildinto/folly,leolujuyi/folly,cppfool/folly,KSreeHarsha/folly,SammyK/folly,bowlofstew/folly,chjp2046/folly,bikong2/folly,Eagle-X/folly,Orvid/folly,wildinto/folly,xzmagic/folly,PoisonBOx/folly,shaobz/folly,clearlylin/folly,Hincoin/folly,alexst07/folly,bikong2/folly,gaoyingie/folly,theiver9827/folly,xzmagic/folly,Eagle-X/folly,fw1121/folly,loverszhaokai/folly,xzmagic/folly,nickhen/folly,PoisonBOx/folly,raphaelamorim/folly,colemancda/folly,gavioto/folly,doctaweeks/folly,Orvid/folly,arg0/folly,loverszhaokai/folly,SammyK/folly,guker/folly,CJstar/folly,bobegir/folly,tempbottle/folly,loverszhaokai/folly,shaobz/folly,reddit/folly,brunomorishita/folly,brunomorishita/folly,kernelim/folly,raphaelamorim/folly,project-zerus/folly,upsoft/folly,yangjin-unique/folly,leolujuyi/folly,zhiweicai/folly,cole14/folly,romange/folly,facebook/folly,yangjin-unique/folly,reddit/folly,theiver9827/folly,alexst07/folly,xzmagic/folly,fw1121/folly,KSreeHarsha/folly,clearlinux/folly,bsampath/folly,CJstar/folly,bowlofstew/folly,zhiweicai/folly,bikong2/folly,tempbottle/folly,cole14/folly,stonegithubs/folly,clearlinux/folly,clearlylin/folly,SammyK/folly,stonegithubs/folly,CJstar/folly,chjp2046/folly,bobegir/folly,zhiweicai/folly,SammyK/folly,ykarlsbrun/folly,rklabs/folly,colemancda/folly,renyinew/folly,clearlylin/folly,guker/folly,yangjin-unique/folly,cole14/folly,leolujuyi/folly,lifei/folly,wildinto/folly,theiver9827/folly,sonnyhu/folly,juniway/folly,lifei/folly,sonnyhu/folly,Hincoin/folly,leolujuyi/folly,lifei/folly,cppfool/folly,tomhughes/folly,tempbottle/folly,reddit/folly,guker/folly,guker/folly,constantine001/folly,alexst07/folly,renyinew/folly,sakishum/folly,juniway/folly,SeanRBurton/folly,CJstar/folly,facebook/folly,floxard/folly,charsyam/folly,cppfool/folly,bowlofstew/folly,shaobz/folly,project-zerus/folly,facebook/folly,constantine001/folly,constantine001/folly,PPC64/folly,guker/folly,project-zerus/folly,yangjin-unique/folly,renyinew/folly,nickhen/folly,gaoyingie/folly,xzmagic/folly,clearlylin/folly,bikong2/folly,Orvid/folly,lifei/folly,fw1121/folly,bikong2/folly,clearlinux/folly,renyinew/folly,hongliangzhao/folly,loversInJapan/folly,fw1121/folly,tomhughes/folly,arg0/folly,upsoft/folly,fw1121/folly,cppfool/folly,floxard/folly,Orvid/folly,romange/folly,juniway/folly,kernelim/folly,loversInJapan/folly,rklabs/folly,sonnyhu/folly,wildinto/folly,loverszhaokai/folly,reddit/folly,Orvid/folly,tempbottle/folly,colemancda/folly,kernelim/folly,loversInJapan/folly,KSreeHarsha/folly,rklabs/folly,KSreeHarsha/folly,renyinew/folly,sakishum/folly,ykarlsbrun/folly,rklabs/folly,upsoft/folly,colemancda/folly,sonnyhu/folly,upsoft/folly,stonegithubs/folly,PoisonBOx/folly,mqeizi/folly,hongliangzhao/folly,doctaweeks/folly,PPC64/folly,charsyam/folly,arg0/folly,nickhen/folly,alexst07/folly,bowlofstew/folly,chjp2046/folly,ykarlsbrun/folly,constantine001/folly,tomhughes/folly,theiver9827/folly,project-zerus/folly,doctaweeks/folly,Hincoin/folly,ykarlsbrun/folly,floxard/folly,romange/folly,brunomorishita/folly,facebook/folly,sakishum/folly,juniway/folly,bsampath/folly,raphaelamorim/folly,juniway/folly,charsyam/folly,gavioto/folly,bobegir/folly,arg0/folly,gaoyingie/folly,cppfool/folly,KSreeHarsha/folly,stonegithubs/folly,romange/folly,colemancda/folly,sakishum/folly