Use a safer order of operations in dropdb(): rollbackable operations, ie removing shared-dependency entries, should happen before non-rollbackable ones.  That way a failure during the rollbackable part doesn't leave us with inconsistent state.
Use a safer order of operations in dropdb(): rollbackable operations,
ie removing shared-dependency entries, should happen before non-rollbackable
ones.  That way a failure during the rollbackable part doesn't leave us
with inconsistent state.

ovr/postgres-xl,Postgres-XL/Postgres-XL,Quikling/gpdb,lintzc/gpdb,kaknikhil/gpdb,xinzweb/gpdb,edespino/gpdb,rvs/gpdb,adam8157/gpdb,tangp3/gpdb,lisakowen/gpdb,snaga/postgres-xl,kaknikhil/gpdb,jmcatamney/gpdb,Chibin/gpdb,edespino/gpdb,chrishajas/gpdb,royc1/gpdb,zaksoup/gpdb,pavanvd/postgres-xl,rvs/gpdb,ahachete/gpdb,cjcjameson/gpdb,royc1/gpdb,adam8157/gpdb,edespino/gpdb,jmcatamney/gpdb,xinzweb/gpdb,Chibin/gpdb,greenplum-db/gpdb,xuegang/gpdb,0x0FFF/gpdb,ashwinstar/gpdb,greenplum-db/gpdb,0x0FFF/gpdb,rubikloud/gpdb,royc1/gpdb,CraigHarris/gpdb,kaknikhil/gpdb,ahachete/gpdb,tpostgres-projects/tPostgres,zaksoup/gpdb,rvs/gpdb,ashwinstar/gpdb,arcivanov/postgres-xl,atris/gpdb,foyzur/gpdb,lintzc/gpdb,50wu/gpdb,arcivanov/postgres-xl,pavanvd/postgres-xl,arcivanov/postgres-xl,greenplum-db/gpdb,edespino/gpdb,foyzur/gpdb,zeroae/postgres-xl,lpetrov-pivotal/gpdb,ahachete/gpdb,xinzweb/gpdb,50wu/gpdb,kaknikhil/gpdb,Postgres-XL/Postgres-XL,atris/gpdb,jmcatamney/gpdb,kaknikhil/gpdb,adam8157/gpdb,50wu/gpdb,pavanvd/postgres-xl,chrishajas/gpdb,randomtask1155/gpdb,atris/gpdb,rubikloud/gpdb,xuegang/gpdb,ahachete/gpdb,randomtask1155/gpdb,pavanvd/postgres-xl,yazun/postgres-xl,jmcatamney/gpdb,Quikling/gpdb,atris/gpdb,kaknikhil/gpdb,chrishajas/gpdb,lisakowen/gpdb,techdragon/Postgres-XL,atris/gpdb,royc1/gpdb,yuanzhao/gpdb,kaknikhil/gpdb,adam8157/gpdb,Quikling/gpdb,janebeckman/gpdb,rvs/gpdb,janebeckman/gpdb,tangp3/gpdb,janebeckman/gpdb,0x0FFF/gpdb,Quikling/gpdb,zaksoup/gpdb,xinzweb/gpdb,zeroae/postgres-xl,rvs/gpdb,zeroae/postgres-xl,lintzc/gpdb,lpetrov-pivotal/gpdb,ahachete/gpdb,edespino/gpdb,CraigHarris/gpdb,lpetrov-pivotal/gpdb,janebeckman/gpdb,zeroae/postgres-xl,lisakowen/gpdb,lintzc/gpdb,jmcatamney/gpdb,cjcjameson/gpdb,Chibin/gpdb,atris/gpdb,postmind-net/postgres-xl,yuanzhao/gpdb,lpetrov-pivotal/gpdb,Chibin/gpdb,kmjungersen/PostgresXL,50wu/gpdb,randomtask1155/gpdb,kaknikhil/gpdb,janebeckman/gpdb,CraigHarris/gpdb,tangp3/gpdb,Postgres-XL/Postgres-XL,ovr/postgres-xl,edespino/gpdb,50wu/gpdb,xuegang/gpdb,postmind-net/postgres-xl,edespino/gpdb,techdragon/Postgres-XL,adam8157/gpdb,rubikloud/gpdb,lpetrov-pivotal/gpdb,tangp3/gpdb,rvs/gpdb,oberstet/postgres-xl,kmjungersen/PostgresXL,0x0FFF/gpdb,chrishajas/gpdb,ovr/postgres-xl,jmcatamney/gpdb,lintzc/gpdb,greenplum-db/gpdb,0x0FFF/gpdb,lisakowen/gpdb,snaga/postgres-xl,lintzc/gpdb,CraigHarris/gpdb,xuegang/gpdb,kmjungersen/PostgresXL,adam8157/gpdb,Quikling/gpdb,lpetrov-pivotal/gpdb,cjcjameson/gpdb,foyzur/gpdb,tangp3/gpdb,yuanzhao/gpdb,greenplum-db/gpdb,CraigHarris/gpdb,Quikling/gpdb,kaknikhil/gpdb,arcivanov/postgres-xl,zaksoup/gpdb,tpostgres-projects/tPostgres,yazun/postgres-xl,lisakowen/gpdb,greenplum-db/gpdb,oberstet/postgres-xl,kmjungersen/PostgresXL,CraigHarris/gpdb,tpostgres-projects/tPostgres,cjcjameson/gpdb,rvs/gpdb,0x0FFF/gpdb,cjcjameson/gpdb,CraigHarris/gpdb,oberstet/postgres-xl,tangp3/gpdb,randomtask1155/gpdb,Chibin/gpdb,jmcatamney/gpdb,yazun/postgres-xl,cjcjameson/gpdb,royc1/gpdb,edespino/gpdb,kmjungersen/PostgresXL,royc1/gpdb,Chibin/gpdb,chrishajas/gpdb,yazun/postgres-xl,techdragon/Postgres-XL,rubikloud/gpdb,ovr/postgres-xl,lisakowen/gpdb,xinzweb/gpdb,lintzc/gpdb,foyzur/gpdb,foyzur/gpdb,ahachete/gpdb,lintzc/gpdb,ovr/postgres-xl,royc1/gpdb,ashwinstar/gpdb,royc1/gpdb,greenplum-db/gpdb,foyzur/gpdb,rubikloud/gpdb,yuanzhao/gpdb,Chibin/gpdb,yazun/postgres-xl,ashwinstar/gpdb,Quikling/gpdb,atris/gpdb,zaksoup/gpdb,ahachete/gpdb,foyzur/gpdb,janebeckman/gpdb,atris/gpdb,yuanzhao/gpdb,cjcjameson/gpdb,tpostgres-projects/tPostgres,randomtask1155/gpdb,edespino/gpdb,rubikloud/gpdb,postmind-net/postgres-xl,pavanvd/postgres-xl,yuanzhao/gpdb,xuegang/gpdb,xinzweb/gpdb,ashwinstar/gpdb,ahachete/gpdb,Postgres-XL/Postgres-XL,rubikloud/gpdb,rubikloud/gpdb,adam8157/gpdb,0x0FFF/gpdb,edespino/gpdb,xinzweb/gpdb,janebeckman/gpdb,xuegang/gpdb,oberstet/postgres-xl,tangp3/gpdb,oberstet/postgres-xl,chrishajas/gpdb,Quikling/gpdb,adam8157/gpdb,arcivanov/postgres-xl,randomtask1155/gpdb,50wu/gpdb,janebeckman/gpdb,rvs/gpdb,lisakowen/gpdb,snaga/postgres-xl,cjcjameson/gpdb,Chibin/gpdb,yuanzhao/gpdb,janebeckman/gpdb,yuanzhao/gpdb,janebeckman/gpdb,randomtask1155/gpdb,randomtask1155/gpdb,zeroae/postgres-xl,techdragon/Postgres-XL,snaga/postgres-xl,lisakowen/gpdb,0x0FFF/gpdb,Chibin/gpdb,snaga/postgres-xl,tangp3/gpdb,zaksoup/gpdb,zaksoup/gpdb,postmind-net/postgres-xl,lpetrov-pivotal/gpdb,rvs/gpdb,rvs/gpdb,Chibin/gpdb,jmcatamney/gpdb,ashwinstar/gpdb,foyzur/gpdb,50wu/gpdb,Quikling/gpdb,greenplum-db/gpdb,tpostgres-projects/tPostgres,ashwinstar/gpdb,techdragon/Postgres-XL,Postgres-XL/Postgres-XL,CraigHarris/gpdb,Quikling/gpdb,50wu/gpdb,ashwinstar/gpdb,xinzweb/gpdb,xuegang/gpdb,lpetrov-pivotal/gpdb,chrishajas/gpdb,cjcjameson/gpdb,cjcjameson/gpdb,kaknikhil/gpdb,CraigHarris/gpdb,arcivanov/postgres-xl,chrishajas/gpdb,postmind-net/postgres-xl,yuanzhao/gpdb,xuegang/gpdb,yuanzhao/gpdb,xuegang/gpdb,lintzc/gpdb,zaksoup/gpdb