Cluster: Fix trib create when masters==replicas
Cluster: Fix trib create when masters==replicas

This bug was introduced in 2e5c394f during a refactor.

It took me a while to understand what was going on with
the code, so I've refactored it further by:
  - Replacing boolean values with meaningful symbols
  - Replacing 'i' with a meaningful variable name
  - Adding the proper abort check
  - Factoring out now duplicated conditionals
  - Adding optional verbose logging (we're inside *four*
    different looping constructs, so it takes a while to
    figure out where all the moving parts are)
  - Updating comment for the section

This fixes a problem when the number of master instances
equaled the number of replica instances.  Before, when
there were equal numbers of both, nodes_count would go to
zero, but the while loop would spin in i < @replicas because
i would never be updated (because the nodes_list of each ip
was length == 0, which triggered an endless loop of
next -> i = 0 -> 0 < 1? -> true -> next -> i = 0 ...)

Thanks to carlo who found this problem at:
https://groups.google.com/forum/#!topic/redis-db/_WVVqDw5B7c

vincent-vivian-liu/redis,honestme/redis,YuraLukashik/redis,jasonkying/redis,Wangyao14cyy/redis,SyntaxStacks/redis,ofirluzon/redis,seppo0010/redis,cusspvz/redis,HeartSaVioR/redis,hedisdb/hedis,j0hnma/hszredis,pcarrier/redis,MOON-CLJ/redis,ytjiang/redis,hawkchch/redis,thomasdarimont/redis,gilala/bjredis,itugs/redis,kaushik94/redis,jackyan/redis,roth1002/redis,j0hnma/szredis,spinlock/redis,weizijun/redis,dreamquster/redis,ncopa/redis,hornen/redis,twskipper/redis,xujunhai1991/redis,davidradunz/redis,CodeJuan/redis,soloestoy/redis,Aaron1992/redis,hgl888/redis,csuhawk/redis,seppo0010/rlite-server,NBSW/redis,AplayER/redis,linfangrong/redis,jingjidejuren/redis,zguangyu/redis,netroby/redis,rouzier/redis,CodeJuan/redis,xuguruogu/redis,neomantra/redis,clamoriniere1A/redis,healerkx/redis,AplayER/redis,gaoxianglong/redis,huyuezheng/redis,YuanZhewei/redis,valdsJohn/redis,PKRoma/redis,yuhc/redis-benchmark-enhanced,guker/redis,SyntaxStacks/redis,gilala/bjredis,rogerlz/redis,hornen/redis,fengshao0907/redis,blackmady/redis,timothyohare/3rdPartySrc-redis,yossigo/redis,simplestbest/redis,iandyh/redis,neomantra/redis,healerkx/redis,SummonY/redis,GitHubMota/redis,pedigree/redis,taoguan/redis,simplestbest/redis,zhiliaoniu/redis,cloudrain21/redis,mcanthony/redis,kmiku7/redis,ouyangkongtong/redis,LongXQ/redis,ouyangkongtong/redis,riyan8250/redis,jackyan/redis,clamoriniere1A/redis,YuraLukashik/redis,sunheehnus/redis,thomasdarimont/redis,JoeWoo/redis,YongMan/redis,shreesundara/redis,guker/redis,a-pavlov/redis,kensou97/redis,healerkx/redis,ton31337/redis,rogerchina/redis,gilala/hbjredis,davidradunz/redis,z-fork/redis,PKRoma/redis,tanghaodong25/redis,Aaron1992/redis,huyuezheng/redis,allengaller/redis,190235047/redis,izhoujie/redis,roth1002/redis,NBSW/redis,riyan8250/redis,josiahcarlson/redis,ton31337/redis,linfangrong/redis,yuhc/redis-benchmark-enhanced,kaushik94/redis,devaos/redis,GitHubMota/redis,mengyou0304/redis,mverrilli/redis,wujf/redis,mengyou0304/redis,colstrom/redis,janekmi/redis,thomasdarimont/redis,hornen/redis,holstvoogd/redis,antirez/redis,nuxeh/redis,cusspvz/redis,harrisonfeng/redis,YongMan/redis,wenxueliu/redis_comment,wbailey5/redis,iandyh/redis,janekmi/redis,itamarhaber/redis,twskipper/redis,tjschuck/redis,alenslan/redis,MasahikoSawada/redis,spinlock/redis,riyan8250/redis,mingyaaaa/redis,ErikDubbelboer/redis,netroby/redis,190235047/redis,AplayER/redis,Markgorden/redis,hawkchch/redis,MOON-CLJ/redis,kensou97/redis,Markgorden/redis,seppo0010/redis,mverrilli/redis,dayuoba/redis,simplestbest/redis,devaos/redis,huyuezheng/redis,francischan714/redis,xlzhan/redis,ituncle/redis,wenxueliu/redis_comment,tjschuck/redis,saisai/redis,z-fork/redis,csuhawk/redis,josiahcarlson/redis,colstrom/redis,gilala/hbjredis,YuanZhewei/redis,wbailey5/redis,twskipper/redis,PKRoma/redis,fengshao0907/redis,jasonkying/redis,shining-yang/redis,JoeWoo/redis,AALEKH/redis,guker/redis,hedisdb/hedis,narma/redis,j0hnma/szredis,ytjiang/redis,gilala/hredis,mverrilli/redis,francischan714/redis,GrimDerp/redis,oranagra/redis,JoeWoo/redis,xuguruogu/redis,YuanZhewei/redis,weizijun/redis,StevenTsai/redis,abhiklodh/redis,saisai/redis,PradheepShrinivasan/redis,honestme/redis,z-fork/redis,citusdata/redis,LongXQ/redis,wenxueliu/redis_comment,Soledad89/redis,soveran/redis,pmem/redis,taoguan/redis,qiyang0221/redis,atreeyang/redis,ipmobiletech/redis,brg-liuwei/redis,Aliceljm1/redis,saisai/redis,gilala/hredis,Soledad89/redis,cusspvz/redis,AplayER/redis,hornen/redis,itugs/redis,CodeJuan/redis,elkingtonmcb/redis,jbochi/parallel_redis,dreamquster/redis,seppo0010/rlite-server,Soledad89/redis,clamoriniere1A/redis,jingjidejuren/redis,itugs/redis,arijitvt/redis,honestme/redis,pmem/redis,universsky/redis,zhcy/redis,gilala/redis,mgk/redis,gilala/hredis,timothyohare/3rdPartySrc-redis,zhcy/redis,Aliceljm1/redis,ncopa/redis,francischan714/redis,dayuoba/redis,JoeWoo/redis,wujf/redis,CodeJuan/redis,janekmi/redis,seppo0010/redis,yossigo/redis,oranagra/redis,190235047/redis,harrisonfeng/redis,pcarrier/redis,nnog/redis,hedisdb/hedis,atreeyang/redis,j0hnma/hszredis,brg-liuwei/redis,StevenTsai/redis,qiyang0221/redis,ipmobiletech/redis,OmarQunsul/graph-redis,mcanthony/redis,RepmujNetsik/redis,YuanZhewei/redis,netroby/redis,programmecat/redis,abhiklodh/redis,modulexcite/redis,harrisonfeng/redis,Wangyao14cyy/redis,soveran/redis,Aliceljm1/redis,itugs/redis,mattsta/redis,atreeyang/redis,PradheepShrinivasan/redis,tanghaodong25/redis,nuxeh/redis,allengaller/redis,seandsky/redis,PradheepShrinivasan/redis,universsky/redis,wprice/redis,duanx/redis,taoguan/redis,a-pavlov/redis,gilala/redis,ncopa/redis,dreamquster/redis,duanx/redis,ctripcorp/redis,zguangyu/redis,jingjidejuren/redis,wprice/redis,antirez/redis,pkdevbox/redis,ctripcorp/redis,elkingtonmcb/redis,shining-yang/redis,jackyan/redis,zhiliaoniu/redis,pedigree/redis,pmem/redis,devaos/redis,yossigo/redis,LongXQ/redis,GitHubMota/redis,mcanthony/redis,narma/redis,Markgorden/redis,wangyikai/redis,mengzhejin/RedisStudy,4396/redis,soveran/redis,tellapart/redis,mumingv/redis,Aaron1992/redis,h0x91b/redis,shining-yang/redis,wujf/redis,HeartSaVioR/redis,SummonY/redis,davidradunz/redis,elkingtonmcb/redis,july2993/redis,roth1002/redis,ErikDubbelboer/redis,rogerlz/redis,takeshineshiro/redis,pcarrier/redis,josiahcarlson/redis,zczhuohuo/redis,dayuoba/redis,yossigo/redis,fengshao0907/redis,4396/redis,shreesundara/redis,huyuezheng/redis,xlzhan/redis,timothyohare/3rdPartySrc-redis,mumingv/redis,OmarQunsul/graph-redis,clamoriniere1A/redis,gaoxianglong/redis,badboy/redis,jbochi/redis,wangyikai/redis,roth1002/redis,duanx/redis,ofirluzon/redis,jbochi/parallel_redis,yuhc/redis-benchmark-enhanced,ofirluzon/redis,abhiklodh/redis,Sciumo/redis,ErikDubbelboer/redis,francischan714/redis,AALEKH/redis,rouzier/redis,izhoujie/redis,thomasdarimont/redis,josiahcarlson/redis,july2993/redis,YongMan/redis,soloestoy/redis,neomantra/redis,flashbuckets/redis,MasahikoSawada/redis,modulexcite/redis,gilala/bjredis,mgk/redis,arijitvt/redis,pedigree/redis,rogerchina/redis,AALEKH/redis,mgk/redis,mverrilli/redis,hawkchch/redis,weizijun/redis,tanghaodong25/redis,ctripcorp/redis,GrimDerp/redis,ituncle/redis,qiyang0221/redis,Wangyao14cyy/redis,sunheehnus/redis,nnog/redis,Sciumo/redis,supasate/redis,vincent-vivian-liu/redis,NBSW/redis,AALEKH/redis,abhiklodh/redis,seppo0010/rlite-server,ipmobiletech/redis,mattsta/redis,jackyan/redis,spinlock/redis,seandsky/redis,tjschuck/redis,HeartSaVioR/redis,gilala/hredis,modulexcite/redis,wbailey5/redis,ytjiang/redis,taoguan/redis,zczhuohuo/redis,izhoujie/redis,cloudrain21/redis,antirez/redis,MOON-CLJ/redis,rogerlz/redis,tjschuck/redis,rogerchina/redis,takeshineshiro/redis,xujunhai1991/redis,takeshineshiro/redis,kmiku7/redis,soloestoy/redis,cnbin/redis,ctripcorp/redis,zczhuohuo/redis,valdsJohn/redis,Soledad89/redis,tellapart/redis,antirez/redis,citusdata/redis,flashbuckets/redis,aim-for-better/redis,duanx/redis,h0x91b/redis,mumingv/redis,wangyikai/redis,PKRoma/redis,ton31337/redis,kmiku7/redis,MasahikoSawada/redis,nnog/redis,honestme/redis,wprice/redis,GitHubMota/redis,zhiliaoniu/redis,cloudrain21/redis,xuguruogu/redis,mengzhejin/RedisStudy,mattsta/redis,xujunhai1991/redis,Aaron1992/redis,davidradunz/redis,hedisdb/hedis,oranagra/redis,iandyh/redis,HeartSaVioR/redis,kensou97/redis,z-fork/redis,gilala/hbjredis,alenslan/redis,blackmady/redis,sunheehnus/redis,nnog/redis,fengshao0907/redis,cnbin/redis,gaoxianglong/redis,YongMan/redis,ouyangkongtong/redis,jasonkying/redis,aim-for-better/redis,universsky/redis,gilala/redis,allengaller/redis,wbailey5/redis,supasate/redis,ouyangkongtong/redis,mengyou0304/redis,neomantra/redis,RepmujNetsik/redis,h0x91b/redis,OmarQunsul/graph-redis,spinlock/redis,itamarhaber/redis,a-pavlov/redis,simplestbest/redis,july2993/redis,Wangyao14cyy/redis,soloestoy/redis,jbochi/redis,j0hnma/hszredis,qiyang0221/redis,oranagra/redis,kaushik94/redis,itamarhaber/redis,citusdata/redis,jbochi/parallel_redis,mumingv/redis,colstrom/redis,pkdevbox/redis,ituncle/redis,zczhuohuo/redis,OmarQunsul/graph-redis,brg-liuwei/redis,xujunhai1991/redis,ton31337/redis,soloestoy/redis,healerkx/redis,oranagra/redis,jingjidejuren/redis,supasate/redis,aim-for-better/redis,GrimDerp/redis,tellapart/redis,mingyaaaa/redis,ipmobiletech/redis,xlzhan/redis,seandsky/redis,cnbin/redis,StevenTsai/redis,citusdata/redis,nuxeh/redis,rogerchina/redis,aim-for-better/redis,yossigo/redis,mengzhejin/RedisStudy,StevenTsai/redis,dreamquster/redis,kmiku7/redis,badboy/redis,colstrom/redis,csuhawk/redis,netroby/redis,LongXQ/redis,wujf/redis,allengaller/redis,zguangyu/redis,programmecat/redis,charsyam/redis,shreesundara/redis,SummonY/redis,linfangrong/redis,wenxueliu/redis_comment,arijitvt/redis,universsky/redis,SyntaxStacks/redis,kaushik94/redis,MasahikoSawada/redis,jbochi/redis,charsyam/redis,GrimDerp/redis,pkdevbox/redis,190235047/redis,hgl888/redis,dayuoba/redis,harrisonfeng/redis,j0hnma/hszredis,mgk/redis,zguangyu/redis,pkdevbox/redis,zhcy/redis,Aliceljm1/redis,zhiliaoniu/redis,gaoxianglong/redis,cnbin/redis,ituncle/redis,janekmi/redis,mengyou0304/redis,pmem/redis,narma/redis,jasonkying/redis,flashbuckets/redis,cloudrain21/redis,charsyam/redis,gilala/bjredis,tellapart/redis,mingyaaaa/redis,neomantra/redis,wprice/redis,iandyh/redis,timothyohare/3rdPartySrc-redis,ErikDubbelboer/redis,a-pavlov/redis,wangyikai/redis,brg-liuwei/redis,NBSW/redis,mingyaaaa/redis,mcanthony/redis,Sciumo/redis,xlzhan/redis,PradheepShrinivasan/redis,programmecat/redis,seandsky/redis,twskipper/redis,4396/redis,ofirluzon/redis,charsyam/redis,alenslan/redis,shreesundara/redis,soveran/redis,saisai/redis,csuhawk/redis,rouzier/redis,holstvoogd/redis,kensou97/redis,hgl888/redis,guker/redis,july2993/redis,sunheehnus/redis,arijitvt/redis,ytjiang/redis,weizijun/redis,badboy/redis,modulexcite/redis,RepmujNetsik/redis,blackmady/redis,Markgorden/redis,rouzier/redis,devaos/redis,xuguruogu/redis,alenslan/redis,PKRoma/redis,vincent-vivian-liu/redis,supasate/redis,j0hnma/szredis,h0x91b/redis,gilala/hbjredis,rogerlz/redis,atreeyang/redis,pedigree/redis,valdsJohn/redis,j0hnma/szredis,programmecat/redis,flashbuckets/redis,zhcy/redis,nuxeh/redis,gilala/redis,hawkchch/redis,linfangrong/redis,holstvoogd/redis,SyntaxStacks/redis,holstvoogd/redis,tanghaodong25/redis,mengzhejin/RedisStudy,elkingtonmcb/redis,seppo0010/rlite-server,riyan8250/redis,vincent-vivian-liu/redis,shining-yang/redis,pcarrier/redis,YuraLukashik/redis,Sciumo/redis,4396/redis,hgl888/redis,SummonY/redis,blackmady/redis,ofirluzon/redis,cusspvz/redis,seppo0010/redis,itamarhaber/redis,YuraLukashik/redis,takeshineshiro/redis,RepmujNetsik/redis,yuhc/redis-benchmark-enhanced,ncopa/redis,valdsJohn/redis,izhoujie/redis,charsyam/redis,badboy/redis