core/flash: More pointer vs value fixes
core/flash: More pointer vs value fixes

It appears the inital patch was incomplete and coverity has caught
more issues. The initial patch addressed one aspect of passing
pointers instead of values, actual function prototypes needed to be
changed and callers adjusted.

Fixes coverity 134277 and 134278

Fixes: 81a538a ("core/flash: Fix passing pointer instead of value")
Signed-off-by: Cyril Bur <6ce38dade8c4b52fd55c193fae70fd1d1275c3c3@au1.ibm.com>
Reviewed-by: Mukesh Ojha <642e2ee181c06342c4240cb5a92dcc8bb7a2d3b5@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <ec31ab75ddf977353c8f660f92ea8b23f64aef25@linux.vnet.ibm.com>

legoater/skiboot,legoater/skiboot,qemu/skiboot,open-power/skiboot,shenki/skiboot,mikey/skiboot,open-power/skiboot,legoater/skiboot,stewart-ibm/skiboot,shenki/skiboot,qemu/skiboot,open-power/skiboot,legoater/skiboot,open-power/skiboot,qemu/skiboot,stewart-ibm/skiboot,shenki/skiboot,qemu/skiboot,shenki/skiboot,stewart-ibm/skiboot,mikey/skiboot,mikey/skiboot,legoater/skiboot,open-power/skiboot,qemu/skiboot,shenki/skiboot