* subversion/libsvn_wc/adm_crawler.c   (svn_wc_transmit_text_deltas): Remove horrifying `else' condition,     so that we always open the text base once we've gotten past the     checksum comparison.  This was part of a series of amazing,     interrelated coincidences that led to us never transmitting true     textdeltas for commits.  First, we initialize basefile to null at     the top of the function.  Second, the aforementioned horrifying     `else', which meant that basefile almost always remained null.     Third, it turns out that svn_stream_from_aprfile() has a special     "convenience" case for the null apr file -- it returns the generic     empty stream.  Yay!  Happy!  So we ended up generating a delta     against the empty stream, which is just like sending the fulltext,     only more work.
* subversion/libsvn_wc/adm_crawler.c
  (svn_wc_transmit_text_deltas): Remove horrifying `else' condition,
    so that we always open the text base once we've gotten past the
    checksum comparison.  This was part of a series of amazing,
    interrelated coincidences that led to us never transmitting true
    textdeltas for commits.  First, we initialize basefile to null at
    the top of the function.  Second, the aforementioned horrifying
    `else', which meant that basefile almost always remained null.
    Third, it turns out that svn_stream_from_aprfile() has a special
    "convenience" case for the null apr file -- it returns the generic
    empty stream.  Yay!  Happy!  So we ended up generating a delta
    against the empty stream, which is just like sending the fulltext,
    only more work.

    Unrelatedly, add a comment about renaming instead of copying.

jmckaskill/subversion,jmckaskill/subversion,jmckaskill/subversion,jmckaskill/subversion,jmckaskill/subversion,jmckaskill/subversion,jmckaskill/subversion,jmckaskill/subversion