Don't eagerly clear frame collision events when physics actors subscribe and unsubscribe from collisions, in order to avoid a race condition.
Don't eagerly clear frame collision events when physics actors subscribe and unsubscribe from collisions, in order to avoid a race condition.

Since this is done directly from ScenePresence, it can lead to a race condition with the simulator loop.
There's no real point doing it anyway since the clear will be done very shortly afterwards by the simulate loop and either there are no events (for a new avatar) or events don't matter (for a departing avatar).
This matches existing behaviour in OdePrim

rryk/omp-server,ft-/opensim-optimizations-wip-tests,OpenSimian/opensimulator,bravelittlescientist/opensim-performance,QuillLittlefeather/opensim-1,bravelittlescientist/opensim-performance,Michelle-Argus/ArribasimExtract,BogusCurry/arribasim-dev,ft-/opensim-optimizations-wip-tests,TomDataworks/opensim,EriHoss/OpenSim_0.8.2.0_Dev_LibLSLCC,ft-/arribasim-dev-tests,QuillLittlefeather/opensim-1,justinccdev/opensim,ft-/arribasim-dev-extras,TomDataworks/opensim,ft-/opensim-optimizations-wip,RavenB/opensim,ft-/arribasim-dev-tests,justinccdev/opensim,M-O-S-E-S/opensim,ft-/arribasim-dev-tests,ft-/arribasim-dev-extras,M-O-S-E-S/opensim,EriHoss/OpenSim_0.8.2.0_Dev_LibLSLCC,Michelle-Argus/ArribasimExtract,bravelittlescientist/opensim-performance,justinccdev/opensim,ft-/arribasim-dev-tests,rryk/omp-server,ft-/opensim-optimizations-wip-extras,M-O-S-E-S/opensim,rryk/omp-server,Michelle-Argus/ArribasimExtract,RavenB/opensim,justinccdev/opensim,justinccdev/opensim,rryk/omp-server,ft-/arribasim-dev-extras,BogusCurry/arribasim-dev,TomDataworks/opensim,TomDataworks/opensim,EriHoss/OpenSim_0.8.2.0_Dev_LibLSLCC,ft-/arribasim-dev-extras,OpenSimian/opensimulator,ft-/opensim-optimizations-wip-extras,ft-/opensim-optimizations-wip-extras,RavenB/opensim,ft-/opensim-optimizations-wip-extras,QuillLittlefeather/opensim-1,ft-/opensim-optimizations-wip,ft-/opensim-optimizations-wip-extras,QuillLittlefeather/opensim-1,bravelittlescientist/opensim-performance,BogusCurry/arribasim-dev,ft-/opensim-optimizations-wip,justinccdev/opensim,QuillLittlefeather/opensim-1,QuillLittlefeather/opensim-1,RavenB/opensim,EriHoss/OpenSim_0.8.2.0_Dev_LibLSLCC,rryk/omp-server,ft-/arribasim-dev-tests,TomDataworks/opensim,ft-/arribasim-dev-extras,M-O-S-E-S/opensim,BogusCurry/arribasim-dev,BogusCurry/arribasim-dev,OpenSimian/opensimulator,Michelle-Argus/ArribasimExtract,ft-/opensim-optimizations-wip-tests,M-O-S-E-S/opensim,EriHoss/OpenSim_0.8.2.0_Dev_LibLSLCC,ft-/opensim-optimizations-wip-tests,ft-/arribasim-dev-tests,TomDataworks/opensim,ft-/opensim-optimizations-wip-tests,QuillLittlefeather/opensim-1,ft-/arribasim-dev-extras,EriHoss/OpenSim_0.8.2.0_Dev_LibLSLCC,OpenSimian/opensimulator,RavenB/opensim,M-O-S-E-S/opensim,Michelle-Argus/ArribasimExtract,RavenB/opensim,rryk/omp-server,M-O-S-E-S/opensim,ft-/opensim-optimizations-wip,EriHoss/OpenSim_0.8.2.0_Dev_LibLSLCC,RavenB/opensim,bravelittlescientist/opensim-performance,TomDataworks/opensim,OpenSimian/opensimulator,bravelittlescientist/opensim-performance,OpenSimian/opensimulator,BogusCurry/arribasim-dev,Michelle-Argus/ArribasimExtract,OpenSimian/opensimulator