Move allowvssprovider=false to vm-data field
Move allowvssprovider=false to vm-data field

Currently we're setting allowvssprovider=false in the other-config
field. However, this setting is not honored in the other-config field,
allowing vss-based snapshots to be created.

The allowvssprovider=false should be moved to the vm-data field in
xenstore as that field is used to decide whether vss snapshotting is allowed or not.

Amended to change: 'str(False)' to 'false'.

Relevant code:

https://github.com/openstack/nova/blob/master/nova/virt/xenapi/vm_utils.py#L233

Manually set allowvssprovider=false in the vm-data field:

xe vm-param-set uuid=<VM-UUID> xenstore-data:vm-data/allowvssprovider=false

References:

https://github.com/mcclurmc/xcp-storage-managers/blob/master/drivers/vss_control#L38
https://github.com/mcclurmc/xcp-storage-managers/blob/master/snapwatchd/snapwatchd#L298

Change-Id: I96efbc18cb7eb0ee2d0e6526b3c4f3502a68e1dd
Fixes: bug #1112673

kimjaejoong/nova,hanlind/nova,ruslanloman/nova,MountainWei/nova,zhimin711/nova,Metaswitch/calico-nova,yrobla/nova,badock/nova,Tehsmash/nova,MountainWei/nova,CiscoSystems/nova,citrix-openstack-build/nova,Brocade-OpenSource/OpenStack-DNRM-Nova,sridevikoushik31/nova,iuliat/nova,zaina/nova,JioCloud/nova_test_latest,cyx1231st/nova,leilihh/nova,JianyuWang/nova,watonyweng/nova,mmnelemane/nova,vmturbo/nova,tanglei528/nova,gooddata/openstack-nova,silenceli/nova,yrobla/nova,petrutlucian94/nova_dev,LoHChina/nova,silenceli/nova,JioCloud/nova_test_latest,devendermishrajio/nova,viggates/nova,vladikr/nova_drafts,ruslanloman/nova,DirectXMan12/nova-hacking,OpenAcademy-OpenStack/nova-scheduler,petrutlucian94/nova,Juniper/nova,sacharya/nova,Yusuke1987/openstack_template,bclau/nova,openstack/nova,klmitch/nova,alvarolopez/nova,vmturbo/nova,mmnelemane/nova,alaski/nova,bigswitch/nova,ted-gould/nova,edulramirez/nova,j-carpentier/nova,whitepages/nova,tangfeixiong/nova,mikalstill/nova,OpenAcademy-OpenStack/nova-scheduler,sridevikoushik31/nova,yatinkumbhare/openstack-nova,cernops/nova,fnordahl/nova,Yusuke1987/openstack_template,felixma/nova,nikesh-mahalka/nova,eayunstack/nova,gooddata/openstack-nova,rajalokan/nova,thomasem/nova,CEG-FYP-OpenStack/scheduler,vmturbo/nova,BeyondTheClouds/nova,raildo/nova,klmitch/nova,cernops/nova,citrix-openstack-build/nova,rajalokan/nova,rrader/nova-docker-plugin,mahak/nova,dstroppa/openstack-smartos-nova-grizzly,plumgrid/plumgrid-nova,spring-week-topos/nova-week,adelina-t/nova,NeCTAR-RC/nova,cloudbase/nova,dstroppa/openstack-smartos-nova-grizzly,tangfeixiong/nova,scripnichenko/nova,felixma/nova,cloudbase/nova,devendermishrajio/nova,takeshineshiro/nova,shail2810/nova,klmitch/nova,jianghuaw/nova,affo/nova,badock/nova,orbitfp7/nova,belmiromoreira/nova,gspilio/nova,orbitfp7/nova,virtualopensystems/nova,jeffrey4l/nova,devendermishrajio/nova_test_latest,j-carpentier/nova,mgagne/nova,Tehsmash/nova,eharney/nova,yatinkumbhare/openstack-nova,maheshp/novatest,berrange/nova,ntt-sic/nova,plumgrid/plumgrid-nova,LoHChina/nova,double12gzh/nova,zaina/nova,cloudbau/nova,shahar-stratoscale/nova,scripnichenko/nova,luogangyi/bcec-nova,eayunstack/nova,Stavitsky/nova,sacharya/nova,SUSE-Cloud/nova,TwinkleChawla/nova,tudorvio/nova,akash1808/nova,bgxavier/nova,DirectXMan12/nova-hacking,Juniper/nova,TieWei/nova,maheshp/novatest,whitepages/nova,CCI-MOC/nova,akash1808/nova_test_latest,BeyondTheClouds/nova,Metaswitch/calico-nova,BeyondTheClouds/nova,dawnpower/nova,cernops/nova,vladikr/nova_drafts,Francis-Liu/animated-broccoli,ewindisch/nova,Stavitsky/nova,cyx1231st/nova,bclau/nova,Yuriy-Leonov/nova,thomasem/nova,kimjaejoong/nova,varunarya10/nova_test_latest,gspilio/nova,shootstar/novatest,cloudbase/nova-virtualbox,eharney/nova,eonpatapon/nova,zzicewind/nova,yosshy/nova,apporc/nova,shahar-stratoscale/nova,mikalstill/nova,qwefi/nova,yosshy/nova,jianghuaw/nova,saleemjaveds/https-github.com-openstack-nova,gooddata/openstack-nova,leilihh/nova,projectcalico/calico-nova,isyippee/nova,dims/nova,blueboxgroup/nova,akash1808/nova,SUSE-Cloud/nova,berrange/nova,shail2810/nova,rahulunair/nova,phenoxim/nova,cloudbase/nova,NeCTAR-RC/nova,jeffrey4l/nova,angdraug/nova,mandeepdhami/nova,Triv90/Nova,petrutlucian94/nova,dims/nova,devoid/nova,tianweizhang/nova,barnsnake351/nova,shootstar/novatest,raildo/nova,luogangyi/bcec-nova,gspilio/nova,joker946/nova,adelina-t/nova,isyippee/nova,eonpatapon/nova,jianghuaw/nova,devoid/nova,qwefi/nova,redhat-openstack/nova,projectcalico/calico-nova,rahulunair/nova,sebrandon1/nova,double12gzh/nova,joker946/nova,noironetworks/nova,alvarolopez/nova,iuliat/nova,rrader/nova-docker-plugin,imsplitbit/nova,Brocade-OpenSource/OpenStack-DNRM-Nova,dawnpower/nova,phenoxim/nova,saleemjaveds/https-github.com-openstack-nova,sebrandon1/nova,tanglei528/nova,cloudbase/nova-virtualbox,redhat-openstack/nova,Juniper/nova,maelnor/nova,zzicewind/nova,tealover/nova,Triv90/Nova,akash1808/nova_test_latest,maelnor/nova,CloudServer/nova,nikesh-mahalka/nova,cloudbau/nova,edulramirez/nova,bgxavier/nova,leilihh/novaha,CiscoSystems/nova,viggates/nova,Triv90/Nova,watonyweng/nova,mgagne/nova,tianweizhang/nova,imsplitbit/nova,virtualopensystems/nova,dstroppa/openstack-smartos-nova-grizzly,rickerc/nova_audit,mahak/nova,alexandrucoman/vbox-nova-driver,ntt-sic/nova,mandeepdhami/nova,fnordahl/nova,bigswitch/nova,hanlind/nova,alexandrucoman/vbox-nova-driver,TwinkleChawla/nova,Yuriy-Leonov/nova,mahak/nova,klmitch/nova,takeshineshiro/nova,varunarya10/nova_test_latest,vmturbo/nova,jianghuaw/nova,sridevikoushik31/openstack,blueboxgroup/nova,sridevikoushik31/openstack,alaski/nova,DirectXMan12/nova-hacking,Francis-Liu/animated-broccoli,sebrandon1/nova,barnsnake351/nova,angdraug/nova,JioCloud/nova,rajalokan/nova,mikalstill/nova,ewindisch/nova,openstack/nova,gooddata/openstack-nova,leilihh/novaha,rickerc/nova_audit,petrutlucian94/nova_dev,openstack/nova,CloudServer/nova,devendermishrajio/nova_test_latest,rahulunair/nova,belmiromoreira/nova,CCI-MOC/nova,noironetworks/nova,zhimin711/nova,JianyuWang/nova,affo/nova,hanlind/nova,rajalokan/nova,ted-gould/nova,tudorvio/nova,sridevikoushik31/openstack,sridevikoushik31/nova,JioCloud/nova,tealover/nova,apporc/nova,Juniper/nova,maheshp/novatest,TieWei/nova,spring-week-topos/nova-week,yrobla/nova,CEG-FYP-OpenStack/scheduler,sridevikoushik31/nova