exposay: remove redundant NULL check in highlight_surface
exposay: remove redundant NULL check in highlight_surface

exposay_highlight_surface() is called from exposay_pick(),
exposay_layout(), and exposay_maybe_move() where the esurface
parameter is already validated prior to the call.  This makes
the 'esurface' NULL check redundant.  This assumes any future
calls to exposay_highlight_surface() will also validate the
'esurface' parameter prior to the call.

This fixes the logic in exposay_highlight_surface so static
analyzers don't complain about the possibility that 'view'
might be NULL deref'd when a 'esurface' == NULL condition is
true.

Signed-off-by: U. Artie Eoff <32aece0d55055227b44d04b7d0051cf3d04ee871@intel.com>

krezovic/weston,sir-murray/weston,mchalupa/weston,mchalupa/weston,kwm81/weston,jonnylamb/weston,udoprog/weston,Gnurou/weston,xorgy/weston,Tarnyko/weston-xdg_surface_present,xorgy/weston,udoprog/weston,giucam/weston,sir-murray/weston,Fantu/compositor-spice,Gnurou/weston,krezovic/weston,jonnylamb/weston,eyolfson/weston,Fantu/compositor-spice,kwm81/weston,Fantu/compositor-spice,Tarnyko/weston-xdg_surface_present,giucam/weston,eyolfson/weston