MB-12075: dont crash remote_clusters_info on missing couchApiBase
MB-12075: dont crash remote_clusters_info on missing couchApiBase

Our code had assertion that couchApiBaseHTTPS must always exist if
remote cluster's is configured with certificate.

It is usually true that cluster that supports xdcr-over-ssl has all
nodes with couchApiBaseHTTPS. But in this case due to stale cache we
saw one node sending us node info without couchApiBaseHTTPS. Which
caused assertion to crash remote_clusters_info. Which led to
max_restart_intensity_reached.

This commit refactors remote_clusters_info so that extract_node_props
and related functions really error out on missing important fields.

Change-Id: Id62b15ed73ae04b19420bd70b042af3b4049adad
Reviewed-on: http://review.couchbase.org/40953
Tested-by: Aliaksey Kandratsenka <340b8e09ca65cd3fc686427fcfed17e87eaf61e2@gmail.com>
Reviewed-by: Aliaksey Artamonau <3c875bcfb3adf2a65b2ae7686ca921e6c9433147@gmail.com>

t3rm1n4l/ns_server,mschoch/ns_server,ceejatec/ns_server,ceejatec/ns_server,membase/ns_server,t3rm1n4l/ns_server,nimishzynga/ns_server,nimishzynga/ns_server,nimishzynga/ns_server,membase/ns_server,ceejatec/ns_server,nimishzynga/ns_server,mschoch/ns_server,membase/ns_server,t3rm1n4l/ns_server,ceejatec/ns_server,nimishzynga/ns_server,t3rm1n4l/ns_server,membase/ns_server,nimishzynga/ns_server,membase/ns_server,mschoch/ns_server,mschoch/ns_server,membase/ns_server,ceejatec/ns_server,mschoch/ns_server,t3rm1n4l/ns_server,mschoch/ns_server,ceejatec/ns_server