Bookmark Manager button menu does not respond to selection
Bookmark Manager button menu does not respond to selection

This patch partially reverts a change in revision 178954 that changed
the focus when the menu was displayed from a menu button.  This focus
change was done to resolve the following display issue:

1) In the NTP, tab until Other Devices is highlighted (clicking on 
this control will not highlight it, you have to tab)
2) Click on Recently closed.
3) Notice the Other Devices is highlighted but the Recently Closed
menu is displayed.

The change of focus resolved the issue in NTP but causes the 
associated bug in the Bookmark Manager. 

The problem is that the second click to select a menu item results
in a focus change that did not happen before.  The focus change
happens because of pre-existing code in context_menu_button.js that
explicitly sets the focus to the parent of the menu (the bookmark 
list in this case).

case 'mousedown':
  // Menu buttons prevent focus changes.
  var target = getContextMenuTarget(this);
  if (target)
    target.focus();

The focus change is picked up by the menu button and interprets this
as the user moving away from the menu and so it closes the menu
before the menu action is executed.

Since the problem that r178954 was trying to resolved is trivial
(and not actually reported in a issue) while the problem it 
introduced is a blocker I am providing a patch to revert the focus
change and will log the original issue.

Contributed by: tom.cassiotis@gmail.com

BUG=177392
TEST=Follow reproduction steps

Review URL: https://chromiumcodereview.appspot.com/12320066

git-svn-id: de016e52bd170d2d4f2344f9bf92d50478b649e0@184251 0039d316-1c4b-4281-b951-d872f2087c98

krieger-od/nwjs_chromium.src,patrickm/chromium.src,dednal/chromium.src,crosswalk-project/chromium-crosswalk-efl,jaruba/chromium.src,Jonekee/chromium.src,Just-D/chromium-1,M4sse/chromium.src,markYoungH/chromium.src,krieger-od/nwjs_chromium.src,Just-D/chromium-1,hgl888/chromium-crosswalk-efl,Chilledheart/chromium,fujunwei/chromium-crosswalk,littlstar/chromium.src,ltilve/chromium,Just-D/chromium-1,ltilve/chromium,Jonekee/chromium.src,pozdnyakov/chromium-crosswalk,krieger-od/nwjs_chromium.src,Just-D/chromium-1,crosswalk-project/chromium-crosswalk-efl,TheTypoMaster/chromium-crosswalk,hgl888/chromium-crosswalk-efl,littlstar/chromium.src,crosswalk-project/chromium-crosswalk-efl,mogoweb/chromium-crosswalk,chuan9/chromium-crosswalk,markYoungH/chromium.src,ltilve/chromium,dushu1203/chromium.src,Chilledheart/chromium,patrickm/chromium.src,mogoweb/chromium-crosswalk,krieger-od/nwjs_chromium.src,axinging/chromium-crosswalk,mogoweb/chromium-crosswalk,ChromiumWebApps/chromium,chuan9/chromium-crosswalk,crosswalk-project/chromium-crosswalk-efl,ChromiumWebApps/chromium,patrickm/chromium.src,Fireblend/chromium-crosswalk,mohamed--abdel-maksoud/chromium.src,M4sse/chromium.src,pozdnyakov/chromium-crosswalk,hujiajie/pa-chromium,bright-sparks/chromium-spacewalk,ondra-novak/chromium.src,jaruba/chromium.src,PeterWangIntel/chromium-crosswalk,Chilledheart/chromium,M4sse/chromium.src,bright-sparks/chromium-spacewalk,Chilledheart/chromium,hujiajie/pa-chromium,Chilledheart/chromium,jaruba/chromium.src,hgl888/chromium-crosswalk,Fireblend/chromium-crosswalk,dednal/chromium.src,Jonekee/chromium.src,zcbenz/cefode-chromium,mogoweb/chromium-crosswalk,anirudhSK/chromium,ltilve/chromium,timopulkkinen/BubbleFish,axinging/chromium-crosswalk,Fireblend/chromium-crosswalk,Pluto-tv/chromium-crosswalk,ChromiumWebApps/chromium,Jonekee/chromium.src,markYoungH/chromium.src,hujiajie/pa-chromium,M4sse/chromium.src,chuan9/chromium-crosswalk,mohamed--abdel-maksoud/chromium.src,pozdnyakov/chromium-crosswalk,ChromiumWebApps/chromium,Jonekee/chromium.src,anirudhSK/chromium,littlstar/chromium.src,timopulkkinen/BubbleFish,timopulkkinen/BubbleFish,fujunwei/chromium-crosswalk,crosswalk-project/chromium-crosswalk-efl,ondra-novak/chromium.src,hujiajie/pa-chromium,axinging/chromium-crosswalk,hgl888/chromium-crosswalk,jaruba/chromium.src,timopulkkinen/BubbleFish,chuan9/chromium-crosswalk,ChromiumWebApps/chromium,hgl888/chromium-crosswalk-efl,PeterWangIntel/chromium-crosswalk,patrickm/chromium.src,mogoweb/chromium-crosswalk,bright-sparks/chromium-spacewalk,Just-D/chromium-1,axinging/chromium-crosswalk,patrickm/chromium.src,jaruba/chromium.src,anirudhSK/chromium,littlstar/chromium.src,chuan9/chromium-crosswalk,Jonekee/chromium.src,markYoungH/chromium.src,ondra-novak/chromium.src,pozdnyakov/chromium-crosswalk,hgl888/chromium-crosswalk-efl,dednal/chromium.src,Pluto-tv/chromium-crosswalk,mogoweb/chromium-crosswalk,Chilledheart/chromium,timopulkkinen/BubbleFish,ondra-novak/chromium.src,anirudhSK/chromium,Chilledheart/chromium,Chilledheart/chromium,pozdnyakov/chromium-crosswalk,anirudhSK/chromium,Just-D/chromium-1,dushu1203/chromium.src,dednal/chromium.src,anirudhSK/chromium,Fireblend/chromium-crosswalk,Pluto-tv/chromium-crosswalk,mohamed--abdel-maksoud/chromium.src,fujunwei/chromium-crosswalk,timopulkkinen/BubbleFish,mohamed--abdel-maksoud/chromium.src,jaruba/chromium.src,M4sse/chromium.src,Fireblend/chromium-crosswalk,hgl888/chromium-crosswalk,timopulkkinen/BubbleFish,ChromiumWebApps/chromium,Jonekee/chromium.src,markYoungH/chromium.src,PeterWangIntel/chromium-crosswalk,jaruba/chromium.src,TheTypoMaster/chromium-crosswalk,dushu1203/chromium.src,zcbenz/cefode-chromium,bright-sparks/chromium-spacewalk,zcbenz/cefode-chromium,zcbenz/cefode-chromium,dushu1203/chromium.src,crosswalk-project/chromium-crosswalk-efl,bright-sparks/chromium-spacewalk,TheTypoMaster/chromium-crosswalk,M4sse/chromium.src,crosswalk-project/chromium-crosswalk-efl,M4sse/chromium.src,zcbenz/cefode-chromium,zcbenz/cefode-chromium,pozdnyakov/chromium-crosswalk,PeterWangIntel/chromium-crosswalk,dednal/chromium.src,mohamed--abdel-maksoud/chromium.src,hujiajie/pa-chromium,fujunwei/chromium-crosswalk,ondra-novak/chromium.src,krieger-od/nwjs_chromium.src,hgl888/chromium-crosswalk,crosswalk-project/chromium-crosswalk-efl,ondra-novak/chromium.src,timopulkkinen/BubbleFish,pozdnyakov/chromium-crosswalk,ltilve/chromium,dushu1203/chromium.src,PeterWangIntel/chromium-crosswalk,markYoungH/chromium.src,Jonekee/chromium.src,axinging/chromium-crosswalk,M4sse/chromium.src,hgl888/chromium-crosswalk,krieger-od/nwjs_chromium.src,hujiajie/pa-chromium,axinging/chromium-crosswalk,mohamed--abdel-maksoud/chromium.src,zcbenz/cefode-chromium,krieger-od/nwjs_chromium.src,littlstar/chromium.src,Jonekee/chromium.src,jaruba/chromium.src,mogoweb/chromium-crosswalk,fujunwei/chromium-crosswalk,markYoungH/chromium.src,dushu1203/chromium.src,hujiajie/pa-chromium,M4sse/chromium.src,hgl888/chromium-crosswalk,TheTypoMaster/chromium-crosswalk,mogoweb/chromium-crosswalk,krieger-od/nwjs_chromium.src,pozdnyakov/chromium-crosswalk,dushu1203/chromium.src,TheTypoMaster/chromium-crosswalk,axinging/chromium-crosswalk,ondra-novak/chromium.src,littlstar/chromium.src,markYoungH/chromium.src,mogoweb/chromium-crosswalk,jaruba/chromium.src,ChromiumWebApps/chromium,jaruba/chromium.src,markYoungH/chromium.src,bright-sparks/chromium-spacewalk,ChromiumWebApps/chromium,Just-D/chromium-1,bright-sparks/chromium-spacewalk,Jonekee/chromium.src,M4sse/chromium.src,ChromiumWebApps/chromium,pozdnyakov/chromium-crosswalk,chuan9/chromium-crosswalk,bright-sparks/chromium-spacewalk,littlstar/chromium.src,fujunwei/chromium-crosswalk,zcbenz/cefode-chromium,hujiajie/pa-chromium,hujiajie/pa-chromium,PeterWangIntel/chromium-crosswalk,markYoungH/chromium.src,Pluto-tv/chromium-crosswalk,bright-sparks/chromium-spacewalk,dednal/chromium.src,timopulkkinen/BubbleFish,chuan9/chromium-crosswalk,dushu1203/chromium.src,mohamed--abdel-maksoud/chromium.src,ltilve/chromium,patrickm/chromium.src,TheTypoMaster/chromium-crosswalk,PeterWangIntel/chromium-crosswalk,timopulkkinen/BubbleFish,timopulkkinen/BubbleFish,fujunwei/chromium-crosswalk,Pluto-tv/chromium-crosswalk,pozdnyakov/chromium-crosswalk,PeterWangIntel/chromium-crosswalk,dushu1203/chromium.src,patrickm/chromium.src,Chilledheart/chromium,ltilve/chromium,axinging/chromium-crosswalk,M4sse/chromium.src,Just-D/chromium-1,dednal/chromium.src,dednal/chromium.src,Fireblend/chromium-crosswalk,ChromiumWebApps/chromium,dednal/chromium.src,jaruba/chromium.src,axinging/chromium-crosswalk,mohamed--abdel-maksoud/chromium.src,zcbenz/cefode-chromium,ChromiumWebApps/chromium,ltilve/chromium,TheTypoMaster/chromium-crosswalk,hujiajie/pa-chromium,hgl888/chromium-crosswalk-efl,Just-D/chromium-1,hgl888/chromium-crosswalk-efl,zcbenz/cefode-chromium,patrickm/chromium.src,chuan9/chromium-crosswalk,hgl888/chromium-crosswalk,krieger-od/nwjs_chromium.src,axinging/chromium-crosswalk,dushu1203/chromium.src,anirudhSK/chromium,mohamed--abdel-maksoud/chromium.src,anirudhSK/chromium,ChromiumWebApps/chromium,hgl888/chromium-crosswalk-efl,dednal/chromium.src,crosswalk-project/chromium-crosswalk-efl,Fireblend/chromium-crosswalk,Fireblend/chromium-crosswalk,anirudhSK/chromium,fujunwei/chromium-crosswalk,zcbenz/cefode-chromium,krieger-od/nwjs_chromium.src,anirudhSK/chromium,markYoungH/chromium.src,hgl888/chromium-crosswalk,fujunwei/chromium-crosswalk,Pluto-tv/chromium-crosswalk,mohamed--abdel-maksoud/chromium.src,axinging/chromium-crosswalk,anirudhSK/chromium,mohamed--abdel-maksoud/chromium.src,hgl888/chromium-crosswalk-efl,ondra-novak/chromium.src,ltilve/chromium,mogoweb/chromium-crosswalk,dednal/chromium.src,ondra-novak/chromium.src,dushu1203/chromium.src,anirudhSK/chromium,littlstar/chromium.src,Pluto-tv/chromium-crosswalk,pozdnyakov/chromium-crosswalk,PeterWangIntel/chromium-crosswalk,Jonekee/chromium.src,TheTypoMaster/chromium-crosswalk,Pluto-tv/chromium-crosswalk,Pluto-tv/chromium-crosswalk,patrickm/chromium.src,Fireblend/chromium-crosswalk,hgl888/chromium-crosswalk,hgl888/chromium-crosswalk-efl,krieger-od/nwjs_chromium.src,hujiajie/pa-chromium,hgl888/chromium-crosswalk-efl,chuan9/chromium-crosswalk,TheTypoMaster/chromium-crosswalk