Remove dead codepath to improve readability
Remove dead codepath to improve readability

There is no way we to reach PSETOP_NONE with the current coding, but
reading the code doesn't make that clear. Rewrite to make the intent
clearer.

Per gripe from Coverity.

yuanzhao/gpdb,50wu/gpdb,yuanzhao/gpdb,xinzweb/gpdb,jmcatamney/gpdb,edespino/gpdb,jmcatamney/gpdb,adam8157/gpdb,janebeckman/gpdb,lintzc/gpdb,janebeckman/gpdb,50wu/gpdb,lintzc/gpdb,50wu/gpdb,Quikling/gpdb,cjcjameson/gpdb,lisakowen/gpdb,Chibin/gpdb,greenplum-db/gpdb,Quikling/gpdb,kaknikhil/gpdb,janebeckman/gpdb,adam8157/gpdb,Chibin/gpdb,yuanzhao/gpdb,Chibin/gpdb,kaknikhil/gpdb,greenplum-db/gpdb,adam8157/gpdb,janebeckman/gpdb,jmcatamney/gpdb,kaknikhil/gpdb,lisakowen/gpdb,Quikling/gpdb,ashwinstar/gpdb,adam8157/gpdb,greenplum-db/gpdb,Quikling/gpdb,50wu/gpdb,lisakowen/gpdb,edespino/gpdb,kaknikhil/gpdb,50wu/gpdb,rvs/gpdb,lintzc/gpdb,lintzc/gpdb,Chibin/gpdb,jmcatamney/gpdb,janebeckman/gpdb,lisakowen/gpdb,rvs/gpdb,kaknikhil/gpdb,Quikling/gpdb,rvs/gpdb,edespino/gpdb,50wu/gpdb,cjcjameson/gpdb,adam8157/gpdb,edespino/gpdb,rvs/gpdb,Chibin/gpdb,Chibin/gpdb,yuanzhao/gpdb,ashwinstar/gpdb,Chibin/gpdb,edespino/gpdb,edespino/gpdb,greenplum-db/gpdb,xinzweb/gpdb,greenplum-db/gpdb,yuanzhao/gpdb,adam8157/gpdb,kaknikhil/gpdb,lisakowen/gpdb,yuanzhao/gpdb,lintzc/gpdb,edespino/gpdb,xinzweb/gpdb,janebeckman/gpdb,xinzweb/gpdb,lintzc/gpdb,cjcjameson/gpdb,edespino/gpdb,Quikling/gpdb,rvs/gpdb,yuanzhao/gpdb,lintzc/gpdb,50wu/gpdb,cjcjameson/gpdb,lisakowen/gpdb,janebeckman/gpdb,lisakowen/gpdb,cjcjameson/gpdb,yuanzhao/gpdb,jmcatamney/gpdb,Chibin/gpdb,Chibin/gpdb,greenplum-db/gpdb,lintzc/gpdb,adam8157/gpdb,janebeckman/gpdb,xinzweb/gpdb,rvs/gpdb,kaknikhil/gpdb,Quikling/gpdb,ashwinstar/gpdb,ashwinstar/gpdb,Quikling/gpdb,xinzweb/gpdb,cjcjameson/gpdb,50wu/gpdb,lisakowen/gpdb,rvs/gpdb,cjcjameson/gpdb,edespino/gpdb,greenplum-db/gpdb,kaknikhil/gpdb,ashwinstar/gpdb,lintzc/gpdb,Quikling/gpdb,Chibin/gpdb,edespino/gpdb,yuanzhao/gpdb,kaknikhil/gpdb,Quikling/gpdb,yuanzhao/gpdb,cjcjameson/gpdb,jmcatamney/gpdb,ashwinstar/gpdb,rvs/gpdb,rvs/gpdb,rvs/gpdb,jmcatamney/gpdb,janebeckman/gpdb,adam8157/gpdb,ashwinstar/gpdb,cjcjameson/gpdb,janebeckman/gpdb,cjcjameson/gpdb,greenplum-db/gpdb,ashwinstar/gpdb,xinzweb/gpdb,jmcatamney/gpdb,kaknikhil/gpdb,xinzweb/gpdb