conf: remove parse code for long-extinct "<state devaddr='d:b:s'/>
conf: remove parse code for long-extinct "<state devaddr='d:b:s'/>

Back in July 2009, in the days before libvirt supported explicitly
assigning a PCI address to every device, code was added to save the
PCI addresses of hotplugged network, disk, and hostdevs in the domain
status with this XML element:

   <state devaddr='domain:bus:slot'/>

This was added in commits 4e21a95a, 01654107, in v0.7.0, and 0c5b7b93
in v0.7.1.

Then just a few months later, in November 2009, The code that actually
formatted the "devaddr='blah'" into the status XML was removed by
commit 1b0cce7d3 (which "introduced a standardized data structure for
device addresses"). The code to *parse* the devaddr from the status
was left in for backward compatibility though (it just parses it into
the "standard" PCI address).

At the time the devaddr attribute was added, a few other attributes
already existed in the <state> element for network devices, and these
were removed over time (I haven't checked the exact dates of this),
but 10 years later, in libvirt v5.8.0, we *still* maintain code to
parse <state devaddr='blah'/> from the domain status.

In the meantime, even distros so old that we no longer support them in
upstream libvirt are using a libvirt new enough that it doesn't ever
write <state devaddr='blah'/> to the domain status XML.

Since the only way a current libvirt would ever encounter this element
would be if someone was upgrading directly from libvirt <= v0.7.5 with
running guests, it seems safe to finally remove the code that parses it.

Signed-off-by: Laine Stump <c23361c43fbf79fed83e8b76173707b083d6caf5@redhat.com>
Reviewed-by: Ján Tomko <4cab11cfb98d3c937327354a78eb07dbb6ee2bc6@redhat.com>

jardasgit/libvirt,fabianfreyer/libvirt,crobinso/libvirt,fabianfreyer/libvirt,nertpinx/libvirt,zippy2/libvirt,nertpinx/libvirt,olafhering/libvirt,jfehlig/libvirt,crobinso/libvirt,libvirt/libvirt,jfehlig/libvirt,olafhering/libvirt,zippy2/libvirt,nertpinx/libvirt,libvirt/libvirt,nertpinx/libvirt,zippy2/libvirt,zippy2/libvirt,jardasgit/libvirt,fabianfreyer/libvirt,nertpinx/libvirt,jardasgit/libvirt,crobinso/libvirt,jardasgit/libvirt,fabianfreyer/libvirt,crobinso/libvirt,jfehlig/libvirt,jardasgit/libvirt,olafhering/libvirt,fabianfreyer/libvirt,libvirt/libvirt,jfehlig/libvirt,olafhering/libvirt,libvirt/libvirt