Move controlled gate tests from Aqua to Terra (#3714)
Move controlled gate tests from Aqua to Terra (#3714)

* port qc.mct tests

* port qc.mcr(x,y,z) tests

* port qc.mcu1 test

* update register names, remove unnecessary list comprehension

register names are more expressive now, also removed names of
register, since this is not needed.
list comprehension was removed where the whole register could
be passed instead.

* docstrings have complete sentences

* fix lint, remove "parameterized" dependency

* use @combine instead of @unpack@data(itertools))

* fix import order

* self.assertTrue(np.allclose to assert_allclose

* atol as np.allclose

* unfold test_multi_control_toffoli_matrix_dirty_ancillas modes

* no need for combine in test_multi_control_toffoli_matrix_clean_ancillas

* unify style

* import gates via allGates

* unfold test_all_inverses

* unfolding test_multi_control_toffoli_matrix

* simplification

* use _compute_control_matrix where possible

* fix lint

* use subtest more, add note that tests from Aqua

Co-authored-by: Luciano Bello <e038f7a74cc380eed3dcb32b96cec8e184cd69ed@ibm.com>

QISKit/qiskit-sdk-py,QISKit/qiskit-sdk-py,QISKit/qiskit-sdk-py