Expand checking for implicit uses of self in closures to include method calls, and add a fallback to catch anything else that is missed.  This resolve the rest of: <rdar://problem/16193162> Require specifying self for locations in code where strong reference cycles are likely
Expand checking for implicit uses of self in closures to include method calls, and add
a fallback to catch anything else that is missed.  This resolve the rest of:
<rdar://problem/16193162> Require specifying self for locations in code where strong reference cycles are likely



Swift SVN r16344

natecook1000/swift,return/swift,uasys/swift,kstaring/swift,deyton/swift,nathawes/swift,xwu/swift,tkremenek/swift,ben-ng/swift,sschiau/swift,lorentey/swift,adrfer/swift,djwbrown/swift,MukeshKumarS/Swift,ken0nek/swift,MukeshKumarS/Swift,gottesmm/swift,khizkhiz/swift,frootloops/swift,roambotics/swift,aschwaighofer/swift,swiftix/swift.old,nathawes/swift,roambotics/swift,therealbnut/swift,Ivacker/swift,apple/swift,cbrentharris/swift,kstaring/swift,rudkx/swift,frootloops/swift,johnno1962d/swift,shahmishal/swift,practicalswift/swift,parkera/swift,austinzheng/swift,swiftix/swift.old,russbishop/swift,KrishMunot/swift,IngmarStein/swift,gottesmm/swift,CodaFi/swift,calebd/swift,amraboelela/swift,gottesmm/swift,tinysun212/swift-windows,calebd/swift,mightydeveloper/swift,mightydeveloper/swift,ben-ng/swift,kstaring/swift,amraboelela/swift,OscarSwanros/swift,MukeshKumarS/Swift,dduan/swift,amraboelela/swift,mightydeveloper/swift,Jnosh/swift,shahmishal/swift,nathawes/swift,kstaring/swift,devincoughlin/swift,codestergit/swift,airspeedswift/swift,mightydeveloper/swift,austinzheng/swift,ahoppen/swift,gmilos/swift,hughbe/swift,bitjammer/swift,kusl/swift,jckarter/swift,xwu/swift,allevato/swift,parkera/swift,KrishMunot/swift,rudkx/swift,LeoShimonaka/swift,CodaFi/swift,huonw/swift,brentdax/swift,milseman/swift,hooman/swift,kentya6/swift,khizkhiz/swift,airspeedswift/swift,kusl/swift,calebd/swift,alblue/swift,atrick/swift,devincoughlin/swift,stephentyrone/swift,Jnosh/swift,gottesmm/swift,apple/swift,xedin/swift,jopamer/swift,Ivacker/swift,shahmishal/swift,sschiau/swift,kusl/swift,shahmishal/swift,benlangmuir/swift,dreamsxin/swift,jckarter/swift,allevato/swift,cbrentharris/swift,modocache/swift,atrick/swift,gribozavr/swift,hughbe/swift,gmilos/swift,JaSpa/swift,kentya6/swift,danielmartin/swift,rudkx/swift,ahoppen/swift,gottesmm/swift,jmgc/swift,kentya6/swift,kusl/swift,russbishop/swift,JaSpa/swift,swiftix/swift,dduan/swift,austinzheng/swift,stephentyrone/swift,cbrentharris/swift,allevato/swift,tkremenek/swift,khizkhiz/swift,gribozavr/swift,adrfer/swift,hooman/swift,CodaFi/swift,sdulal/swift,airspeedswift/swift,brentdax/swift,mightydeveloper/swift,adrfer/swift,ahoppen/swift,mightydeveloper/swift,sdulal/swift,ben-ng/swift,russbishop/swift,IngmarStein/swift,tinysun212/swift-windows,KrishMunot/swift,OscarSwanros/swift,tardieu/swift,dduan/swift,codestergit/swift,xedin/swift,huonw/swift,roambotics/swift,jckarter/swift,milseman/swift,aschwaighofer/swift,harlanhaskins/swift,SwiftAndroid/swift,modocache/swift,JGiola/swift,manavgabhawala/swift,aschwaighofer/swift,OscarSwanros/swift,cbrentharris/swift,brentdax/swift,bitjammer/swift,tinysun212/swift-windows,benlangmuir/swift,return/swift,jmgc/swift,IngmarStein/swift,jopamer/swift,ben-ng/swift,tinysun212/swift-windows,codestergit/swift,ben-ng/swift,glessard/swift,deyton/swift,IngmarStein/swift,jtbandes/swift,allevato/swift,tjw/swift,rudkx/swift,tkremenek/swift,khizkhiz/swift,JGiola/swift,swiftix/swift,tkremenek/swift,karwa/swift,Ivacker/swift,amraboelela/swift,brentdax/swift,tardieu/swift,zisko/swift,huonw/swift,parkera/swift,practicalswift/swift,practicalswift/swift,frootloops/swift,gregomni/swift,therealbnut/swift,sdulal/swift,shajrawi/swift,huonw/swift,kentya6/swift,lorentey/swift,IngmarStein/swift,JGiola/swift,ahoppen/swift,djwbrown/swift,CodaFi/swift,tkremenek/swift,jopamer/swift,harlanhaskins/swift,natecook1000/swift,felix91gr/swift,codestergit/swift,xedin/swift,bitjammer/swift,dduan/swift,kstaring/swift,karwa/swift,xwu/swift,tardieu/swift,adrfer/swift,calebd/swift,shajrawi/swift,khizkhiz/swift,kusl/swift,alblue/swift,devincoughlin/swift,roambotics/swift,xwu/swift,huonw/swift,aschwaighofer/swift,shajrawi/swift,atrick/swift,parkera/swift,aschwaighofer/swift,slavapestov/swift,stephentyrone/swift,ahoppen/swift,Jnosh/swift,slavapestov/swift,airspeedswift/swift,jckarter/swift,practicalswift/swift,ken0nek/swift,arvedviehweger/swift,karwa/swift,swiftix/swift,xedin/swift,johnno1962d/swift,benlangmuir/swift,hughbe/swift,parkera/swift,alblue/swift,ben-ng/swift,uasys/swift,jmgc/swift,kperryua/swift,arvedviehweger/swift,gmilos/swift,MukeshKumarS/Swift,karwa/swift,practicalswift/swift,LeoShimonaka/swift,allevato/swift,airspeedswift/swift,slavapestov/swift,sdulal/swift,brentdax/swift,adrfer/swift,kentya6/swift,jmgc/swift,kstaring/swift,johnno1962d/swift,ken0nek/swift,JGiola/swift,nathawes/swift,gribozavr/swift,shahmishal/swift,harlanhaskins/swift,rudkx/swift,jtbandes/swift,natecook1000/swift,apple/swift,codestergit/swift,lorentey/swift,zisko/swift,arvedviehweger/swift,danielmartin/swift,parkera/swift,djwbrown/swift,cbrentharris/swift,codestergit/swift,ken0nek/swift,tinysun212/swift-windows,modocache/swift,swiftix/swift.old,parkera/swift,xedin/swift,SwiftAndroid/swift,dduan/swift,natecook1000/swift,tjw/swift,deyton/swift,OscarSwanros/swift,tjw/swift,manavgabhawala/swift,jtbandes/swift,karwa/swift,xwu/swift,return/swift,gregomni/swift,gmilos/swift,IngmarStein/swift,swiftix/swift.old,JaSpa/swift,uasys/swift,modocache/swift,kentya6/swift,SwiftAndroid/swift,hooman/swift,lorentey/swift,emilstahl/swift,hughbe/swift,JaSpa/swift,jopamer/swift,zisko/swift,harlanhaskins/swift,manavgabhawala/swift,emilstahl/swift,Ivacker/swift,harlanhaskins/swift,tjw/swift,arvedviehweger/swift,therealbnut/swift,aschwaighofer/swift,johnno1962d/swift,austinzheng/swift,gribozavr/swift,therealbnut/swift,karwa/swift,nathawes/swift,shajrawi/swift,slavapestov/swift,johnno1962d/swift,stephentyrone/swift,manavgabhawala/swift,calebd/swift,glessard/swift,atrick/swift,kperryua/swift,hooman/swift,tjw/swift,lorentey/swift,jckarter/swift,sschiau/swift,Jnosh/swift,alblue/swift,tjw/swift,Ivacker/swift,cbrentharris/swift,huonw/swift,slavapestov/swift,nathawes/swift,swiftix/swift.old,modocache/swift,jckarter/swift,ken0nek/swift,arvedviehweger/swift,Jnosh/swift,sschiau/swift,return/swift,xedin/swift,gottesmm/swift,airspeedswift/swift,frootloops/swift,devincoughlin/swift,Ivacker/swift,johnno1962d/swift,swiftix/swift,JaSpa/swift,milseman/swift,airspeedswift/swift,tinysun212/swift-windows,slavapestov/swift,adrfer/swift,tardieu/swift,karwa/swift,SwiftAndroid/swift,danielmartin/swift,xwu/swift,sdulal/swift,natecook1000/swift,kentya6/swift,gribozavr/swift,jtbandes/swift,benlangmuir/swift,devincoughlin/swift,allevato/swift,MukeshKumarS/Swift,felix91gr/swift,bitjammer/swift,swiftix/swift.old,Ivacker/swift,zisko/swift,sdulal/swift,OscarSwanros/swift,khizkhiz/swift,shahmishal/swift,benlangmuir/swift,LeoShimonaka/swift,MukeshKumarS/Swift,devincoughlin/swift,stephentyrone/swift,glessard/swift,SwiftAndroid/swift,jopamer/swift,gribozavr/swift,kstaring/swift,rudkx/swift,therealbnut/swift,djwbrown/swift,milseman/swift,russbishop/swift,LeoShimonaka/swift,bitjammer/swift,roambotics/swift,hughbe/swift,danielmartin/swift,gottesmm/swift,natecook1000/swift,lorentey/swift,slavapestov/swift,amraboelela/swift,deyton/swift,arvedviehweger/swift,djwbrown/swift,gregomni/swift,return/swift,deyton/swift,frootloops/swift,harlanhaskins/swift,amraboelela/swift,jmgc/swift,danielmartin/swift,Jnosh/swift,swiftix/swift,emilstahl/swift,felix91gr/swift,aschwaighofer/swift,shajrawi/swift,swiftix/swift.old,deyton/swift,gregomni/swift,JaSpa/swift,brentdax/swift,codestergit/swift,jopamer/swift,russbishop/swift,felix91gr/swift,nathawes/swift,jckarter/swift,jtbandes/swift,djwbrown/swift,atrick/swift,devincoughlin/swift,mightydeveloper/swift,kusl/swift,kusl/swift,manavgabhawala/swift,CodaFi/swift,shahmishal/swift,lorentey/swift,atrick/swift,glessard/swift,return/swift,milseman/swift,LeoShimonaka/swift,emilstahl/swift,IngmarStein/swift,natecook1000/swift,jtbandes/swift,amraboelela/swift,felix91gr/swift,tardieu/swift,gmilos/swift,shahmishal/swift,danielmartin/swift,uasys/swift,emilstahl/swift,hooman/swift,practicalswift/swift,harlanhaskins/swift,CodaFi/swift,devincoughlin/swift,LeoShimonaka/swift,apple/swift,russbishop/swift,jopamer/swift,hooman/swift,lorentey/swift,xwu/swift,xedin/swift,sschiau/swift,huonw/swift,sschiau/swift,LeoShimonaka/swift,russbishop/swift,shajrawi/swift,jtbandes/swift,ben-ng/swift,cbrentharris/swift,austinzheng/swift,sschiau/swift,frootloops/swift,austinzheng/swift,MukeshKumarS/Swift,SwiftAndroid/swift,roambotics/swift,gmilos/swift,sdulal/swift,tkremenek/swift,karwa/swift,manavgabhawala/swift,SwiftAndroid/swift,Jnosh/swift,modocache/swift,swiftix/swift,alblue/swift,hooman/swift,zisko/swift,ken0nek/swift,modocache/swift,hughbe/swift,sschiau/swift,kperryua/swift,JGiola/swift,OscarSwanros/swift,swiftix/swift.old,KrishMunot/swift,practicalswift/swift,glessard/swift,alblue/swift,tjw/swift,shajrawi/swift,practicalswift/swift,felix91gr/swift,kperryua/swift,OscarSwanros/swift,adrfer/swift,glessard/swift,CodaFi/swift,mightydeveloper/swift,dduan/swift,kentya6/swift,stephentyrone/swift,allevato/swift,ken0nek/swift,cbrentharris/swift,bitjammer/swift,milseman/swift,jmgc/swift,gregomni/swift,frootloops/swift,uasys/swift,gribozavr/swift,swiftix/swift,tinysun212/swift-windows,ahoppen/swift,brentdax/swift,JaSpa/swift,therealbnut/swift,deyton/swift,gregomni/swift,apple/swift,felix91gr/swift,johnno1962d/swift,uasys/swift,kusl/swift,gribozavr/swift,kperryua/swift,zisko/swift,parkera/swift,alblue/swift,khizkhiz/swift,emilstahl/swift,calebd/swift,jmgc/swift,Ivacker/swift,KrishMunot/swift,KrishMunot/swift,djwbrown/swift,JGiola/swift,LeoShimonaka/swift,austinzheng/swift,manavgabhawala/swift,dduan/swift,kperryua/swift,milseman/swift,hughbe/swift,bitjammer/swift,apple/swift,return/swift,benlangmuir/swift,danielmartin/swift,gmilos/swift,therealbnut/swift,emilstahl/swift,shajrawi/swift,xedin/swift,dreamsxin/swift,tardieu/swift,emilstahl/swift,sdulal/swift,KrishMunot/swift,zisko/swift,uasys/swift,tkremenek/swift,kperryua/swift,stephentyrone/swift,calebd/swift,tardieu/swift,arvedviehweger/swift